1 2005-06-26 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Quite a few new dictionaries were added in gdcm. The file:
3 gdcm/Dict/README should always explain were the info was found
4 (in case of double check). Also some dict are still only
5 express as 'template' (they contain 'xx'), therefore
6 a python script should be run first to generate a full dict.
7 In the longer term this python script should be replaced by
10 2005-06-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
11 * dicomV3.dic is deprecated in favor of gdcm.dic
12 There is now a dictionary per family:
13 - dicomV3.dic -> DICOM V3
14 - Papyrus.dic -> Papyrus
15 - NIH.dic -> tas that were never allowed in the main standart
17 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
19 lantency with the Util::Format function
21 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * Adding users file in CVSROOT for mail blaming
24 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
25 * Adding potential support for JPEG-LS DICOM files.
27 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
28 * Adding potential support for mpeg and jpeg2000 through two new lin
30 - libmpeg2 from the MPEG consortium
31 Also adding intial work to use this lib.
33 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
37 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
38 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
39 But this is a case where we should really signify the user there is
40 few chance the serie is really a serie...
42 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * FIX : on X, the python part is correctly installed. All files are
44 installed in gdcm sub-directory
46 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Builder/ : add something to facilitate the RPM creation of gdcm
49 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
50 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
52 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
54 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
55 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
57 * Fix compilation on gcc 2.96 (which does not have ios::failure)
59 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
61 and it's representation name (for the NIH)
63 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
65 conversion of YBR to RGB pixels. So, now, the conversion is made using
68 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
70 format) to replace 'at-run' dicom files generated by the
71 TestAllReadCompareDicom test
73 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
76 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
79 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * Testing/TestMAkeIcon.cxx : complete the test
82 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
85 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
89 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
92 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * Test/ : accelerate tests (it's not very significant accelerations).
94 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
96 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Testing/TestSequence.cxx : add test for sequences of images... test that
98 we have the same serie or the same study UID
100 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
103 * src/gdcmDict.h : remove commented code
104 * src/gdcmDocument.cxx : initialize values
105 * src/gdcmFile.cxx : bug fix when reading values
106 * gdcmPython/demo/ : change file names. Remove useless files
108 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * src/gdcmFile.cxx : remove the default array of initialization.
110 The static array contained pointers to non-static values (comming from
111 strings). To have coherences, when creating files, these values can't be
112 static. So, the array can't be static, too ! To simplify, the array have
113 been replaced by repeted lines to insert values in the File
115 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
117 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
119 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
121 (Dicom Element) into the Sequence Item
123 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * src/*.cxx : first parss to normalize file organisation
126 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmDirList.[h|cxx] : add method to find a directory
128 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
130 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
131 * Finish cleaning up my JPEG mess. Should be ok now.
132 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
133 contained within the RLE* class(doh!)
135 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
136 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
137 * SerieHeader::AddFileName() creates as many Coherent Files lists
138 (same Serie UID) as it founds different Serie UID
139 amongst the files instead of discarting any file
140 that doesn't match with the first one he found.
141 * SerieHeader::OrderGdcmFileList has now one parameter :
142 the Coherent Files list the user wants to sort
143 * SerieHeader::GetFirstCoherentFileList() |
144 * SerieHeader::GetLastCoherentFileList() | allow to parse
145 the set of Coherent Files lists
146 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
147 compatibility (it returns the *first* Coherent Files list,
148 since there was only one before)
149 * Test/TestSerieHeader gets gdcmData as a default root directory
151 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * Remove friend between DocEntry and File classes
153 * Remove friend between PixelReadConverter and RLEFramesInfo,
156 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
158 0002|0000. The value was incorrect.
160 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
161 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
163 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmUtil.cxx : compilation fix on Win32
165 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
166 variable, to be easy found. Add methods to change the default UID.
167 Amelioration of the CreateUniqueUID to use the correct default UID.
168 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
171 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * Test/TestVR.cxx : fix memory leaks
174 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
175 * Rewrite the base 256 to base 10 conversion, using string operation only.
176 This allows us to get rid of the problematic 64bits integer type (does not
177 always exist on target platform).
179 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
180 * Add construct and destructor to class gdcm::Debug to close the debug file
182 * Don't let uset to open twice the same file
183 * gdcm has now an official UID prefix,
184 supplied by http://www.medicalconnections.co.uk
185 1.2.826.0.1.3680043.2.1143
186 (Thx to Mathieu for providing URL)
187 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
188 to be able to perform some more tests
189 * gdcm::ContentEntry : Contructors and Destructor are now protected,
190 in order to be sure no user will try to use them.
191 (at user level, only the children classes are meaningfull)
193 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * move RLEInfo & JPEGInfo from Document to File
196 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
197 * FIX : remove so many friend between classes
199 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
201 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
203 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
204 In order to avoid missbehaviour :
205 . gdcm::DocEntry is now specialized in
206 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
207 - gdcm::ContentEntry (Dicom entry with a 'content')
208 . gdcm::ContentEntry is specialized in
209 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
210 characters value, or integers)
211 - gdcm::BinEntry (Dicom entry with a non strig representable value
212 (user hasn't any longer to thing about the precedence of his dynamic_casts)
214 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * Test/VTKTest*.cxx : bug fix under linux
217 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
219 use with python. Some methods are moved from Document to ElementSet or
220 DocEntrySet. The equivalent methods to ElementSet have been added to
221 SQItem and are virtual in DocEntrySet. Methods that may have the same code
222 in SQItem and ElementSet is directly placed in DocEntrySet
224 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
225 * Test/VTKTest*.cxx : remove the show variable in each test method because
226 it's useless (the viewer variable replace this variable)
228 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmDocument.cxx : bug fix on potential memory leak
230 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
231 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
232 Add ClearXxx methods to remove all the content of the list or map
233 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
235 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
236 * methods ReplaceOrCreate renamed as Insert
237 (nobody will be any longer confused by 'CreateOrReplace')
239 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
240 * Grealty simplify the JPEg decompression, no need to differenciate based on
241 the JPEG possible type (with/without fragment, with/without multiple frame).
242 Everything is done throught the JPEG IO Suspension mechanism in IJG
244 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
245 * Stage 3 of normalization :
246 in order to avoid any missunderstanding while reading method names :
247 - All the methods xxxEntry now deal with dicom Entries
248 - Methods GetEntry splitted into
251 - Method SetEntry renamed as SetEntryValue
252 - Method SetEntryBinArea let as it was
254 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
255 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
256 - Position correctly the entry points for JPEG2000 and JPEG-LS
257 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
259 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
261 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
262 with other method names
263 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
264 * Test/TestDicomDirElement.cxx : add new test
266 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
267 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
268 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
269 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
270 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
271 So can't you use __int64 in ostream at all.
273 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * bug fix for compilation on MSVC6
275 * gdcmPython/gdcm.i : rename of classes missed
277 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
278 * Stage 2 of names normalization :
279 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
280 (easy to understand ...)
281 - gdcm::FileHelper replaces old class gdcm::File
283 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
285 type and not a string. So, there remove problems on the format of the
288 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
289 * Add Example/TestPapyrus.cxx
290 - reads a Papyrus file (gdcm::Header compliant),
291 - gets the pixels of all the images, using low level iterators
292 - writes an multiframes Dicom image.
293 (Just to show it's *possible* to do that)
294 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
297 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
299 Thus, DicomDirXXX are created with a flad that indicates if the created
300 object is empty or not (when not empty, the DicomDirElement is used to
303 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
305 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
307 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
310 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
312 Remove all access to the hash-tables or lists in the objects.
314 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
315 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
316 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
317 be complient with all the gdcm source code
319 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
323 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
327 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * Test/ : rename VTK tests to have a best name for the tests
329 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
330 GetFirstEntry/GetNextEntry use
332 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * In SerieHeader::ImagePositionPatientOrdering()
334 // a Dicom 'Serie' may contain scout views
335 // and images may have differents directions.
336 // -> More than one may have the same 'pos'
337 // Sorting has then NO meaning !
338 Thx to Eduardo Davila for reporting bug.
340 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
342 test. Now it's on image content and not on the resulting visualisation...
343 might solve the problem on linux when using the OpenGL drivers
345 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
346 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
347 DicomDirSerie, DicomDirImage
348 Dict, DictSet classes :
349 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
350 -remove InitTraversal method.
351 * UPD Test programs + Example programs
353 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
354 * remove useless and never updated keyword \ingroup
355 * Solve pb when structure (list, map, ...) is empty.
356 Thx to Benoit for reporting bug
358 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
359 * Taking into account of 'Transfer Syntax' value
360 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
363 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
364 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
365 is no memory access violation
366 * gdcmPython/demo : add python demos using VTK
368 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
369 * FIX 'Dictionnary' is now spelt 'Dictionary'
370 'wether' is now spelt 'whether'
371 'archieve' is now spelt 'archive' ;-)
373 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
374 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
375 related methods, in order not to expose internal mechanisms
378 * REM methods that exposed internal mechanisms :
379 DicomDir::GetDicomDirPatients()
380 DicomDirPatient::GetDicomDirStudies()
381 DicomDirStudy::GetDicomDirSeries()
382 DicomDirSerie::GetDicomDirImages()
383 * UPD Test programs :
387 * UPD Example program
389 * ADD DictSet methods
393 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * Removed the Print/indent/default parameter mess. There is absolutely no
395 reason to have to methods, moreover with the second taking the ostream as
396 *SECOND* parameter. This was clearly a bad hack to get things compile.
398 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
399 * Complete rewrite of the GetMacAddress code. Now the code is *much*
400 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
401 Unfortunately the main code does not work on SunOS, thus provide a specific
402 code for this platform only (and Win32 of course). Since this seems to be
403 working, change CreateUniqueUID to use GetMACAddress instead of the
404 problematic GctestetIPAddress
406 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
407 * Unfortunately to be able to test gdcmDirList I had to break the API
408 a little. Now the class is not a std::list anymore but has a member
409 std::vector (more ITK compatible). Allow unit testing on Win32 and
412 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
413 * Update SerieHeader to take into account a Serie Instance UID to properly
416 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
417 * ENH - Comment out Mathieu's (dangerous) Super Hack
418 for dealing with BIGENDIAN processors
419 - Move equivalent stuff to BinEntry::WriteContent
420 When necessary, 16 Bits Pixels are swapped in a small buffer
421 and then written. This avoid allocating a huge buffer, in
422 PixelWriteConvertor, and avoid modifying the Pixel Area.
424 Probabely, the same operation will have to be done when we want
425 to write image with Big Endian Transfert Syntax,
426 and we are working on Little Endian Processor
428 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
429 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
431 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
432 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
433 all the dict content.
434 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
436 * Test/TestDict.cxx : add a new test for the dict classes
438 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
439 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
440 file. Debug is yanked if compiled with NDEBUG
442 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
443 * src/gdcmDictSet.h : set the default output to the os variable
444 * src/gdcmDictEntry.[h|cxx] : add the Print method
445 * gdcmPython/demo/ : add a new test
447 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
448 * merging of Test/PrintDicomDir and Test/TestDicomDir
449 * removal of now redundant Test/PrintDicomDir
450 * enhancement of Example/PrintDicomDir
452 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
453 * Now, python test might work on systems
454 * Add the PrintDicomDir test
456 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
457 * FIX : First entry following group 0002 was lost for
458 Explicit Big Endian Transfer Syntax files
459 (group and elem not swaped)
461 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
462 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
463 Big Endian Transfer Syntax supposed the group following 0002
464 begins always by element 0000 (element 0000 is *optional*)
465 To avoid further troubles, let's be pessimistic, and use
466 Document::HandleOutOfGroup0002() method
467 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
468 (related pb not yet solved)
470 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
471 * Bug fix for the python part use
472 * Now, PrintHeader.py pass... but outside the ctest use. shit !
474 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
477 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
478 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
479 a string and should ask the global TS dict what are the propreties of
482 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
483 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
484 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
485 to swap the Swap Code, at parsing time, when we come out of group 0002
486 and Transfer Syntax is Big Endian
487 We should be able to read now 'true DICOM" Big Endian coded images
488 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
489 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
491 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
492 * Hopefully fix the bug on MacOSX and static global initialization.
493 This is the only -minor- patch I found that both please MacOSX and VS6.
494 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
495 but this would require a lot of change. Another approach would be that Global
496 create those string and GDCM_UNFOUND becomes a pointer to a string (which
497 gdcm::Global would destroy at exit).
499 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
500 * Fix bug on MacOSX with static initialization in a multy threaded
501 environment. static const string in a header file used to be ill
502 initialized provoquing the freeze of any tests. patch should solve this
505 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
506 * According to Benoit's suggestion, and without any objection from anybody
507 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
508 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
509 - method gdcmDicomDirObject::GetEntry() renamed as
510 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
512 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
513 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
514 you debug/warning message just as c++ streams which make them very convinient
515 to use. Once this is stabilize I will change the ostringstrem to be
516 redirected to a file (ofstream).
517 * Properly support C99 extension: __FUNCTION__ which allow us to display
518 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
520 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
521 * Removal of useless and dangerous methods :
522 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
523 GetDocEntryByName, GetEntryByName, GetDictEntryByName
524 * Removal of usless methods :
525 Dict::PrintByName, Dict::GetDictEntryByName
526 * Commenting out of probabely useless methods :
527 Dict::GetDictEntryNames()
528 Dict::GetDictEntryNamesByCategory()
529 DictSet::GetPubDictEntryNames()
530 DictSet::GetPubDictEntryNamesByCategory()
531 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
532 * ENH : Use dicomTS.dic as described in 2004 version
533 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
534 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
535 Add Accessors on VM (Value Multiplicity), and VM related methods
536 * ADD : Add a list of 'Dicom Attribute types', as found in
537 http://medical.nema.org/dicom/2004/04_15PU.PDF
539 * ADD : Add dicomGroupNameAbbreviations.dic
540 should be used to write a method to replace the former
541 Dict::GetDictEntryNamesByCategory()
543 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
545 to read in the file... and only it ! Length is the efective length of the
546 data in the DocEntry structure
548 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
549 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
550 And now use a static function call instead, with a global variable. i
551 This is much closer to the VTK approach. Hopefully should be bulletproof
552 and easier to use...hopefully
554 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
557 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
560 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
561 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
562 ValEntry, BinEntry, SeqEntry creation or replace
564 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
566 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
568 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
569 when specifying the VR
570 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
571 * src/gdcmDocEntry.cxx : amelioration of print
573 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
574 * ADD : Add the method Util::IsCurrentProcessorBigEndian
575 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
576 * ADD Method Document::ComputeGroupLength
577 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
578 in order to allow further VR modification by user
579 * REM : removal of once-called method File::WriteBase
580 integration of its code in formerly one-line method File::Write
582 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
584 replace the different values "??", "Unkn", "Unknown".
585 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
586 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
587 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
588 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
590 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
593 * Set the gdcm::Base class to some Printable classes
595 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
596 * src/gdcmFile.[h|cxx] : add the Print method
597 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
598 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
599 * src/gdcmDocument.h : remove the PrintLevel informations
600 * Example/PrintFile.cxx : use the new gdcm::File::Print
602 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
604 problems when compiling with the python wrapping
606 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
608 writting in ImplicitVR
610 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
611 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
612 JPEG decompression, especially when dicom frames are split into several
613 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
614 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
616 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * src/gdcmHeader.cxx : change the initialisation of default header.
618 Now, this header is readable by gdm, e-film, DicomWorks
620 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
622 Rename Decompressed to Raw
623 * Use the API changes in gdcm::File.
624 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
627 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
628 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
629 each added entry in the header. Replace the 'Planes' field by the 'Number
632 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
634 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
636 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
637 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
638 At this time, this image isn't readable by e-film... waiting JPR help to
641 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
643 DocEntry. Now use methods of the Document !
645 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
646 * Test/ShowDicomSeq.cxx : bug fix
648 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
650 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
651 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
652 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
654 * Test/TestCopyRescaleDicom.cxx : remove unused variable
655 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
656 containing found sequences
658 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
659 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
661 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
662 Some fields in BinEntry must be copied to not seg fault when making the :
663 gdcm::File *copy = new gdcm::File( copyH );
664 and tests are now made on good variables
666 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
667 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
668 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
670 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
671 * Add vtkGdcmWriter example and test
673 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * Test/TestUtil.cxx : reformat the source code
675 * vtk/vtkGdcmReader.cxx : remove and change prints
676 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
678 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
679 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
681 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
683 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
685 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
686 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
687 by an eof to prevent all bad read of the file... and in this case, the
690 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
691 * Example/Volume2Dicom.cxx : comment unused variables
692 * Test/PrintDicomDir.cxx : comment unused variables
693 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
694 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
695 method that is redondant with AddEntry.
696 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
699 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
700 * Bug fix due my last commit (compilation under Windows).
701 * Example/Volume2Dicom : bug fix in the file and reformatting source code
702 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
704 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
706 - Remove printf / sprintf
707 - include iostream AFTER gdcm so we don't get warnings
708 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
710 - Also remove tons of include from header files, hopefully this should
711 speeup the compilation time, since it was becoming a dog slow.
712 - Remove gdcm.h as it include way too many files and slow down compilation
713 (plus it is not up to date)
714 - remove 'using namespace std' this is BAD !
716 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
717 * Remove memory leaks on the DicomDir
718 * Remove some useless data in DicomDirObject
719 * Add usefull methods in SQItem, to be complient withe the ElementSet
721 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
722 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
724 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
725 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
726 future, with convertion)
727 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
728 and ImageDataSize values. Remove the method to get the PixelReadConverter
729 from the output of the class
731 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
734 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
736 and vtkErrorMacro use.
737 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
739 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
740 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
742 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
743 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
744 The string leaves only in the fonction. So when we make a .c_str(), we
745 get the pointeur on the first element, element that will be destroyed
746 immediately after thee instruction.
747 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
748 file has been opened : the test must be made on the content of the
749 pointer and not directly on the pointer !
752 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
753 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
754 the python part recompiles
756 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
757 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
758 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
759 X session is killed (for my computer... it seems to not be identic on
762 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
763 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
764 avoid problems (otherwise, the difference test between the visible image
765 and the reference is incorrect. If the reference is greater than the
766 screen resolution, it's produce errors).
767 Can be used for only one image. Can be used with a visible flag.
768 * vtk/vtkGdcmReader.cxx : remove commented codes.
769 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
770 under windows at compilation
771 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
773 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
775 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
776 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
777 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
778 tests on the image size X, Y, Z
780 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
781 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
782 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
783 between the class name and the file name
785 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
786 * src/ : fix compilation warnings for the Write method (2 different
787 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
788 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
789 variable... create a static method in gdcm::Document to access to
790 this variable content.
792 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
793 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
794 file, to be accessed by other files (like gdcmFile). Remove commented
795 code. Move the change of the header to the gdcmFile, using the
797 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
798 To be sure of that (and simplify calls), the Write of the header now
799 gets a file name and not a file pointer (std::ifstream).
800 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
801 DocEntryArchive. Remove all open of the written file
803 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
806 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
807 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
808 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
810 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
811 some corresponding methods. Write correctly the file and check before
813 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
814 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
815 is now on RGB data (as before my last commit
816 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
818 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
819 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
820 Add a print information of the type of the entry
821 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
822 It was in the gdcmFile, and all write have been regrouped
823 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
824 Write correctly all dicom files (in decompressed mode only at this time)
825 * Test/ : test on files are now made using Raw data and not color data if
827 * Example/PrintFile.cxx : add more printings
829 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
830 * Amelioration of code, remove some code copy. For the loading of
831 BinEntry (in gdcmDocument), add the test to verify if the file is already
834 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
836 remove a DocEntry in the header (push an empty DocEntry)
837 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
838 lines. Bug fix in the initialization of the PixelConvert and the
840 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
841 use in TestCopyDicom (now this test can run under windows... but fails)
842 * Test/TestCopyDicom.cxx : amelioration of the test :
843 - test the pixels written
844 - add test points to quickly find where is the error
845 - can set a file name input and output in arguments
846 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
847 amelioration of the test output
849 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
850 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
851 all replaced DocEntry's
852 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
853 Now, each needed DocEntry to modify is duplicated, modified and inserted
854 to the header using DocEntryArchive. Thus, after save, we can restore the
855 header initial state.
857 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
858 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
860 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
861 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
862 correct to copy it. The DictEntry is specified at the DocEntry creation,
863 then, it musn't change in the time.
864 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
865 header correctly. At this time, the change is only made for the first
866 level of the Document. In the future, it might consider sequences.
867 The change is made by replacing a DocEntry by an other that is created
868 outside the class. The old value is kept. When we restore the header
869 status, the added DocEntry is deleted and replaced by the old value.
870 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
871 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
872 set the write type to explicit VR, implicit VR or ACR. Add methods to set
873 the write mode to native, decompressed or RGB (but not used at this time)
875 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
876 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
877 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
879 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
880 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
881 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
883 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
884 set because already copied when copying the BinEntry's of the header
885 * Test/TestAllReadCompareDicom.cxx : remove warnings
887 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
888 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
889 Two problems appear when doing it :
890 - with the gdcmFile : when the GetImageData method is called, the pixels
891 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
892 data (pixels). And each structure destruct the data when it's
893 destructed. So we have two destructions for the same data. To solve it,
894 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
895 data or not. If it doesn't own data, then they will not destroyed by
897 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
898 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
899 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
900 create a double destruction of the same DocEntry's. So, to solve it,
901 the TagHT is simply cleared and the DicomDir* elements are destroyed.
902 * TODO : add an entry concerning memory leaks in the DicomDir
904 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
905 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
906 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
909 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
911 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
912 after it have been deleted
914 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * FIX: src/* fix the doxygen warnings.
916 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
917 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
918 was erroneously defined with a size of 15 instead of 16. [many thanks
919 to Jean Michel Rouet for pointing out this bug].
921 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 1. Finish merging JMR patch for writting DICOM from scratch
923 2. Fix -hopefully- bug with MONOCHROME and space vs null character
924 3. Use const ref when possible
925 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
926 5. A few more comments
927 6. CreateUniqueUID can now be called without parameter"
929 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
930 * ENH: Slightly bigger patch:
931 1. Getting toward full integration of JMR patch for writting dicom from scratch
932 2. Update Test to test part of this patch: CreateUniqueUID
933 3. File was not close properly in gdcmDict
934 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
935 5. Use of const ref instead of copy (speed issue)
936 6. Remove temporary (duplicate) string in TranslateToKey
937 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
938 8. Do not repeat virtual in subclasses
939 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
941 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
942 * Apply first patch toward better string comparison when dealing with broken
943 DICOM files. Essentially the string could be padded with a space instead
944 of a null character as defined by standard
946 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
947 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
948 because never used... and in the same time, that's remove some memory leaks
950 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
951 * src/gdcmFile.cxx : now delete the PixelConvert instance.
952 * In examples and tests : change the type of image data variables from void*
953 to uint8_t*. Remmove all delete on image data variables
955 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
956 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
957 Verify the file pointer value before open the file, and if it's not null,
958 a verbose message is generated.
959 Close correctly the file when the file isn't considered dicom-like. The
960 correctly close is a call to CloseFile.
961 When closing the file pointer, test if its not null to close the file.
962 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
963 file. For an uncompressed image, the copied data correspond in the least
964 case to the image size (calculated) or the image size specified in the
965 header. A verbose is generated if these two size mismatch
967 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
968 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
969 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
970 break under windows (with msvc6 compilation).
972 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
973 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
974 compiling with MSVC6)
976 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
977 * Bugs fix for the Windows build with VC6
978 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
979 needed (only for projects required VTK). If the VTK is included in all
980 projects, there is conflicts with the jpeg lib of vtk when compiling the
981 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
982 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
983 when compiling the gdcm_wrap.cxx file (created by the compilation of the
985 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
986 (like it's already made for the cout use). Otherwise, conflict with the
989 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
990 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
992 - comments on the DicomDir::Method related usage added.
993 - now that we use the namespace gdcm, a lot of internal classes do
994 NOT need to be wrapped anymore.
995 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
996 DicomDir::Method) new example added.
998 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
999 * Improve string manipulation. I now inforce the notion of 'DicomString'
1000 A DicomString can contain as many \0 as they want
1001 and it is *always* of even length.
1002 We only support odd length for very rare case.
1003 And in the near future this should be removed.
1005 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1006 * /binary_write/ gdcm source. Now even on big endian we are writting
1007 little endian. This should -heopfully- fix some tests
1009 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1010 * Now the dictionary is compiled into gdcm lib. This is a default
1011 behavior, thus any dic file specified is picked before failback to
1012 the one comiled into lib
1014 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * Change internals for gdcmDict. Don't use any 'new' any more.
1016 This should definitely solve any leak problem, and we should be
1017 as fast as before, as long as don't modify too much the dictionary.
1019 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1020 * STYLE: ivars should start with a capital letter.
1021 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1022 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1024 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1026 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1027 new 2004 dictionaries added (thanks to JPR).
1028 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1029 * CLEANUP_ROUND (15) for gdcmPixelConvert
1030 - RLEFrame::NumberFragments is now of type unsigned int
1031 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1032 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1035 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * Initial work in gathering all transfer syntax accessors. clearly
1037 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1038 ivars, but only one transfersyntax (class) ivar with equivalent method on
1041 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1042 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1043 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1044 discussed (plus I didn't like having a 2000 lines patch not commited)
1046 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1048 * CLEANUP_ROUND (14) for gdcmPixelConvert
1049 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1050 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1051 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1052 CloseFile() anymore.
1053 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1054 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1055 into File::Pixel_Data.
1057 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1059 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1060 * CLEANUP_ROUND (13) for gdcmPixelConvert
1061 Substituted File::ParsePixelData() with PixelConvert::Print() new
1063 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1064 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1065 method to those classes.
1066 - src/gdcmFile.[cxx|h]:
1067 -- Added a ::Print() method.
1068 -- PixelConverter is now a reference instead of a member.
1069 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1070 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1072 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1074 collaboration diagram and inheritance diagram should be generated with
1076 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1077 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1078 pointlessly wrapped (see
1079 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1080 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1081 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1082 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1083 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1084 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1085 -- File::Initialise: PixelConverter setup moved away to
1086 PixelConverter::GrabInformationsFromHeader()
1087 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1088 interpretation moved away to PixelConverter::BuildRGBImage()
1090 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1091 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1092 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1094 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1095 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1096 displayed on Win32 when a brutal abort() occurs (because of uncatched
1097 exception). See TODO new entry of this commit for more on this.
1098 * TODO added new entry.
1099 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1100 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1101 - HandleColor is no longer called from gdcmFile.cxx
1102 - gdcmPixelConvert.cxx clean up on method arguments and internal
1103 variable names for semantical coherence.
1105 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1106 * Finished lossless transition, not only do we now read all lossless jpeg
1107 images, without the need of the Cornwell lib, but we do read them properly now
1108 * To reduce code (well to avoid code duplication), I defined a common place
1109 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1110 redefine symbols. This is not perfect but this the best solution I found for a
1111 compilation time jpeg option.
1113 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1114 * Update jpeg ijg lib to support lossless jpeg implementation
1115 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1117 * Also added a special copyright for dcmtk since we use their bugfixes.
1120 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1122 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1123 matters, as stated in warning note at beginning of %include section).
1124 * src/gdcmDicomDir*.[cxx|h]: coding style
1125 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1126 * src/gdcmJpeg8.cxx: doxygen fix.
1127 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1128 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1129 from File:: to PixelConvert::.
1131 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1132 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1133 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1134 - more code moved away from File:: to PixelConvert::
1135 - fat setup of PixelConverter set in place in File::Initialise.
1137 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1138 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1139 namespace at the file system level. So now you should convert your examples
1141 gdcmHeader -> gdcm::Header
1142 It would be nice if people keep in mind to no open the namespace, since it
1143 allows compilation on broken plateform which were defining common symbol in
1144 the standart namespace (like LP, Unknown ...)
1146 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1148 The JPEG fragments are now parsed at the same stage than the RLE
1149 information. All code related to JPEG is now in gdcmPixelConvert:
1150 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1151 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1152 export a gdcmFile:: method. Those are simply global functions
1153 (for the time being this is better than having them attach to
1154 either gdcmFile:: or gdcmPixelConvert::).
1155 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1156 and stores the result in a gdcmJPEGFragmentsInfo.
1157 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1158 code (among other stuff) moved away from gdcmFile:; to
1161 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1163 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1164 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1165 clean up of RLE related code.
1166 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1167 - src/gdcmRLE.cxx removed
1168 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1169 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1170 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1171 * CLEANUP_ROUND (9) for gdcmPixelConvert
1172 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1173 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1174 away from gdcmFile:: to gdcmPixelConvert::.
1176 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1177 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1178 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1179 This is because Parse7Fe0 used to parse the pixels to compute the
1180 length. This task was passed over to FindDocEntryLengthOB() a long
1181 time ago, EXCEPT I had forgotten the OW case...
1182 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1183 we just recylce the code for parsing RLE fragments and computing
1185 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1186 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1187 with the retired Parse7Fe0().
1188 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1189 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1191 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1193 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1194 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1195 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1196 * CLEANUP_ROUND (4) for gdcmPixelConvert
1197 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1198 to return an unused length.
1200 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1202 this should be cleanner from the plane view. The iostream are erally a pain
1203 to use to do simple stuff.
1205 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1206 * Redo the compilation of the ijg jpeg library. Now only one source is
1207 necesseray. No need to rename file by hand what so ever. CMake handle the
1208 copying of the file within different directory, configure header file to
1209 modify some symbol. The only addition made to ijg wasd a mangle table so
1210 that symbol are different whether we are within 8bits or 12bits.
1212 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1213 * Added documentation of vtkgdcmReader on Website:
1214 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1215 with it's binary name).
1216 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1217 the Website to be more complete.
1218 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1219 doxygenated documentation.
1220 - Doc/DoxyVtkGdcmReaderExamples.txt added
1221 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1222 DoxyVtkGdmReaderExamples.html )
1223 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1224 * CLEANUP_ROUND (3) for gdcmPixelConvert
1225 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1227 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * CLEANUP_ROUND (2) for gdcmPixelConvert
1229 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1231 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1232 * CLEANUP_ROUND for gdcmPixelConvert:
1233 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1234 - src/gdcmPixelStuff[h|cxx] removed
1235 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1236 - src/CMakeLists.txt changed accordingly
1237 * GDCMHOME clean up:
1238 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1239 gdcmVersion.py moved to newly created ATTIC related
1240 gdcmPython/SetupOldies/ directory.
1241 * Autotools clean up:
1242 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1243 - autogen.sh configure.in acinclude.m4 python.m4 removed
1245 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1246 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1247 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1248 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1250 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1251 * TODO updated with Mathieu suggestions. I proposed a template for
1252 describing TODO entries and used it for new entries.
1253 * Added Doc/Website/CodingStyle.html, Developpers.html,
1254 DeveloppersPython.html, GdcmDataCvs.html and
1255 DownloadVersion0_1.html, DownloadVersion0_3.html.
1256 * Some Doc/*.txt Doxygen files (which do not really concern the
1257 documentation itself, but the website) moved to html and
1258 placed in directory Doc/Website:
1259 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1260 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1261 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1262 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1263 * CMakeLists.txt changed accordingly.
1264 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1265 DeveloppersPython.html
1266 * INSTALL nows refers to Doc/Website/Installation.html
1268 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Added Doc/Website directory, that contains a first raw version
1272 2004-09-23 Jean-Pierre Roux
1273 * FIX In order not to be poluted any longer by casting problems,
1274 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1275 we can now delete[] it safely
1276 * VoidArea is now called BinArea (less confusing name),
1277 and all the methods called ...VoidArea... are now ... BinArea...
1278 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1280 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1281 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1282 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1283 up to the destructor of gdcmElementSet to clean up TagHt and it's
1286 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1287 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1288 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1290 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1291 * ENH: added some utility method that builds a flat dictionary
1292 holding all the Dicom entries contained in the recursive structure
1293 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1294 an example of usage.
1295 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1296 BuildFlatHashTable() that build a flat dictionary.
1297 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1298 gdcmDocument is now a friend of gdcmElementSet.
1299 - src/gdcmElementSet.cxx: clean up.
1300 - Example/FlatHashTablePrint.cxx added.
1301 - Example/CmakeLists.txt changed accordingly
1303 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1304 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1305 moved away from gdcmDocEntrySet (since this class is an abstract class
1306 acting like an interface). SQDepthLevel and BaseTagKey are now
1308 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1309 and associated accessors. Doxygenation of the class.
1310 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1312 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1313 Use SQDepthLevel accessor instead. ::Print() adapted.
1314 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1315 - src/gdcmDocument.cxx changed accordingly.
1317 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1318 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1319 - The following is the doxygen comment of the typedef declaration
1320 of gdcmTagKey in src/gdcmCommon.h:
1321 gdcmTagKey is made to old an "universal" (as in URL, Universal
1322 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1323 A dicom tag always has a group and an element, but a set of tags
1324 embeded in various (optionally nested) sequences and sharing
1325 the same group and element all share the same (group, element)
1326 "identifier". Hence the (group, element) cannot be used as an
1327 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1328 In order to construct a proper tag identifier (i.e. a key) we
1329 consider the following definition of a TagKey:
1330 - let Group, Element be the string representation of the
1331 group and element dicom tag members,
1332 - let ItemNumber be the string representation of the integer
1333 index of the considered item number of a sequence,
1334 Let the key of a tag embeded in a sequence, noted SeqTag, be
1336 /ItemNumber#Group|Element
1337 where "/", "#" and "|" are characters acting as separators.
1338 Then the general form of a gdcmTagKey is given by:
1339 Group|Element<SeqTag>
1340 where <SeqTag> means NO or many instances of SeqTag.
1341 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1344 but the gdcmTagKey of a tag "embeded" is the first item of
1345 a sequence, itself nested in the third item of a sequence is the
1347 0004|1220/2#0008|0082/0#0008|0090
1348 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1349 order to hold the new sequence compatible key. Previously, the
1350 GetKey() method would look in the underlying gdcmDictEntry.
1351 - src/gdcmDocEntry.cxx:
1352 -- constructor now copies the underlying DictEntry key, in the local
1354 -- ::Print: displays the member Key, instead of the (group, element).
1355 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1356 - src/gdcmDocEntrySet.h:xi
1357 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1358 -- now has a new BaseTagKey member.
1360 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1361 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1363 This poses the problem with the semantics of the following lines
1364 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1365 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1366 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1367 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1368 to the long FIXME note for what the problem is. Nevertheless in
1369 order to get things working the dicom dictionary was altered !
1370 Please fix things urgently...
1371 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1372 information), see above note on moving the member VoidArea. Nevertheless
1373 the following entries previously correctly set as US are now inproperly
1375 0028 1201 OW IMG Red Palette Color Lookup Table Data
1376 0028 1202 OW IMG Green Palette Color Lookup Table Data
1377 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1378 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1379 of gdcmDocEntry moved to gdcmSeqEntry.
1380 * src/gdcmSeqEntry.cxx: STYLE.
1382 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1383 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1385 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * gdcmPython/testSuite.py: all the test suite in python is now moved
1387 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1388 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1389 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1391 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1392 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1393 to avoid inclusion recursion until STL is reached.
1394 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1395 mecanism. errno.h is not included in gdcm anymore.
1396 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1397 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1399 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1400 gdcmData/TestAllEntryVerifyReference.txt
1401 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1402 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1403 exception_on_error parameter.
1404 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1405 - vtk/vtkGdcmReader.cxx changed accordingly,
1406 - Example/*.cxx and Test/*.cxx changed accordingly.
1408 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1410 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1411 enable_sequences removed from gdcmHeader constructor and dependencies.
1412 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1413 * gdcmPython/demo/PrintHeader.py: dummy fix.
1414 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1415 skip_shadow removed from gdcmHeader constructor and dependencies.
1416 * Example/*.cxx and Test/*.cxx changed accordingly.
1418 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1420 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1422 2004-07-21 Jean-Pierre Roux
1423 * FIX Now, Parsing and Printing a DICOMDIR do work!
1424 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1426 2004-07-20 Jean-Pierre Roux
1427 * FIX Some brain damaged headers have Zero-Lenght fields
1428 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1430 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1431 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1432 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1433 variable (instance of gdcmDebug) by a definition macro, and the instance
1434 is now in static in the gdcmDebug class
1435 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1436 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1438 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1439 * WARNING: ctest now depends more tightly on gdcmData. You should
1440 check out gdcmData properly for things to run smoothly...
1441 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1442 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1443 we need the pixels not be loaded in order to use the ValEntry
1444 that displays position and size).
1445 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1446 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1447 be deprecated. If you have any doubts about the advantages of a
1448 modern scripting language (read Python) versus grass root C++ (i.e.
1449 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1450 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1451 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1452 Anyhow, consider documenting the gdcmData images in
1453 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1455 * Test/CMakeLists.txt:
1456 - now uses TestAllEntryVerify.cxx
1457 - specific comments on oldACR00001.ima (now renamed in gdcmData
1458 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1459 gdcmData/TestAllEntryVerifyReference.txt
1462 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * src/*.[h|cxx] : typedef clean up
1464 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1465 - TagKey renamed to gdcmTagKey (for external usage)
1466 - VRKey renamed to gdcmVRKey (for external usage)
1467 - removal of typedef duplication.
1468 - Removed all unecessary inline keyword from class inline definitions.
1469 - Some method|function(void) declarations replaced with method|function().
1470 * src/jpeg/libijg12/jdhuff12.c:
1471 - printf polluting ctest removed.
1472 - TAB removal for comminting
1474 - TestAllReadCompareDicom.cxx: added a test that compares all the
1475 images in gdcmDataImages.h with corresponding images in
1476 gdcmData/BaselineDicom/. When baseline images are not present
1477 this test creates them.
1478 Note: we need to validate each reference image, but before that
1479 I'd like to rename them with a more explicit name...
1480 - CMakeLists.txt: changed accordingly.
1481 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1482 including each header needed).
1484 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1486 test suite to the Example directory. Are concerned:
1491 - TestWriteSimple.cxx
1492 * Test/CMakeLists.txt: added some comments on reasons for black listing
1493 image gdcmData/oldACR00001.ima
1495 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1496 * Test/CmakeList.txt: removed the following from black list (to be coherent
1497 with removal from gdcmData):
1498 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1499 - gdcm-MR-PHILIPS-16.dcm
1501 Added the following because after last cvs update, they cause
1502 ctest -R TestReadWriteReadCompare
1504 - gdcm-MR-SIEMENS-16-1.acr
1506 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1507 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1508 new comments in this file) we temporarily (sigh) move to a weaker
1510 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1511 we don't need to black list the following images anymore:
1512 - 8BitsUncompressedColor.dcm
1514 - US-PAL-8-10x-echo.dcm
1515 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1516 fixes and the beautified code ;-)
1517 This fixes the bug introduced in version 1.42 (when beautifying)
1518 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1519 Note: ctest was blind to this bug (this means we need to still
1520 improve the test suite). The bug could be detected by using
1521 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1523 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1524 and by displaying the (garbage) produced file temp.XDCM...
1526 2004-06-29 Jean-Pierre Roux
1527 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1528 - replace by uggly but working old code :-(
1529 A lot of things should be OK again.
1530 It's really urgent to have a test suite that *tests*,
1531 to prevent Frog's beautifying sessions to break all the stuff
1532 (twice, withing a fortnigh ...)
1534 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1535 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1536 redundancy) to added Test/TestReadWriteReadCompare.cxx
1537 * Test/CmakeList.txt: because the compare test of
1538 Test/TestReadWriteReadCompare.cxx fails, the following images are
1539 black listed: - 8BitsUncompressedColor.dcm
1541 - US-PAL-8-10x-echo.dcm
1542 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1543 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1544 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1545 and ad-hoc kludge. This kludge is now removed, and on encountering
1546 such an image (OB field brain damaged) we set errno. Then in
1547 ::FindDocLength() we "fix" the length as being ALL what remains
1548 in the file (until EOF). We then proceed, hoping for the best...
1549 This fixes a SegFault in ShowDicom when trying to write such an
1551 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1552 (because TestWriteRead breaks on it, after a non conformal commit?).
1553 ctest now runs properly, except for MakeDicomDir (which was always
1554 broken) and the Python related stuff (still not fixed).
1556 2004-06-24 Jean-Pierre Roux
1557 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1558 FIX : Test/TestReadWrite now iterates on all the file names
1559 (instead of infinite loop)
1560 ENH : Test/TestWriteRead now iterates on all the file names
1562 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1565 2004-06-24 Jean-Pierre Roux
1566 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1567 when SamplesPerPixel =3
1568 - now Write is no longer confused by
1569 'BitsAllocated = 12" and 'BitsStored=12"
1570 - "UN" value representation Elements are now written correctly
1571 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1572 ENH : - now gdcmHeader has its own Write methods
1573 (in order to split the job that has not to be done
1576 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1578 loop on the same image until memory went out.
1579 Note: this means we still have gobs of memory loss in PrintDocument
1580 * src/gdcmDocument.cxx: fixes problem on parsing on file
1581 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1583 2004-06-24 Jean-Pierre Roux
1584 FIX : Write - All the Sequences and Sequence Item are now written
1585 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1586 is added a the end, when necessary.
1587 - A lot of brain-damaged images, that were read correctly are
1588 now written correctly
1589 - length compatible BinEntry are now loaded correctly
1590 (even for odd groups)
1591 Note : only Explicit Value Representation was checked.
1592 (question : is implicit VR really necessary for gdcm ?)
1594 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * DEVELOPPER: added a proposition of coding style.
1596 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1599 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1601 Use the gdcmDocEntry::Print() and Write() instead.
1602 * src/gdcmDocument.cxx: bug fix.
1604 2004-06-22 Jean-Pierre Roux
1605 FIX : gdcmDocument.cxx
1606 - Now we do recognize the JpegLossLess format (there was a misstyping in
1607 code 'beautyfication' :-(
1608 - Now we automaticaticaly load the Luts, if any
1610 2004-06-22 Jean-Pierre Roux
1611 In order : to write Sequences, whatever their imbrication level,
1612 : to allow user to create his own Sequences
1613 a lot of modif where necessary (adding, moving, or virtualising methods)
1615 WARNING : save your own sources *before* cvs up !
1618 ADD virtual void Write(FILE *fp, FileType filetype);
1621 ADD virtual void Write(FILE *fp, FileType filetype);
1622 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1625 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1626 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1627 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1628 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1629 ADD std::string GetEntryByName(TagName name);
1630 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1632 std::string vr = "unkn",
1633 std::string fourth = "unkn",
1634 std::string name = "unkn");
1635 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1636 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1637 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1638 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1639 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1640 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1641 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1642 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1645 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1646 ADD virtual std::string GetEntryByName (TagName tagName);
1647 ADD virtual std::string GetEntryVRByName (TagName tagName);
1648 REM virtual bool Write(FILE *, FileType);
1649 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1650 FILE *_fp, FileType type);
1651 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1652 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1653 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1654 REM virtual std::string GetEntryByName (std::string tagName);
1655 REM virtual std::string GetEntryVRByName (std::string tagName);
1656 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1657 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1658 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1660 std::string vr = "unkn",
1661 std::string fourth = "unkn",
1662 std::string name = "unkn");
1663 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1664 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1665 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1666 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1669 ADD virtual void Write(FILE *fp, FileType filetype);
1672 ADD virtual void Write(FILE *fp,FileType filetype);
1675 ADD virtual void Write(FILE *fp, FileType filetype);
1676 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1677 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1678 REM std::string GetEntryByName(TagName name);
1681 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1683 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1685 The default constructor invoked by the line
1686 gdcmHeader *f1 = new gdcmHeader( header );
1687 was gdcmHeader::gdcmHeader(bool) instead of the expected
1688 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1689 Hence the parsing wasn't executed... See also below.
1690 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1691 as explicit constructor didn't do the trick to fix the above problem.
1692 Could anyone explain why ?
1693 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1694 properly calls gdcmValEntry::Print() (that was weed out from
1695 code related to gdcmBinEntry).
1697 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1698 * In order to fix memory leaks:
1699 - Test/TestWriteSimple.cxx: added cleaning of free store through
1701 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1702 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1703 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1704 (through the call to ::AddDicomDirMeta()) or the destructor
1705 would crash when deleting uninitialized ::metaElems].
1706 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1707 - src/gdcmDocument.cxx:
1708 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1709 from dynamic stores.
1710 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1711 was causing memory leaks.
1712 - src/gdcmSQItem.cxx:
1713 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1714 cleanly handled with polymophism: sorry but my milage is low).
1715 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1716 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1717 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1718 This avoids SegFaulting.
1719 - src/gdcmSQItem.h: coding style.
1721 - Test/TestWriteSimple still severely sucks. The output image content
1722 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1723 damaged when displayed with vtkgdcmViewer.
1724 - on memory leaks: TestWriteSimple leaks really less (see entry
1725 of 2004-06-18 in Changelog file for the call to valgrind).
1726 - on segfaults: ctest now passes all the tests but one (no more
1728 * Erroneous leading white fix:
1729 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1730 white[s] (as opposed to from >> xxx, that removes it [them].
1731 - src/gdcmTS.cxx: ditto.
1732 - gdcmPython/testSuite.py: dirty related kludge removed.
1733 * src/*: remaining references to gdcmParser removed.
1734 * src/*[cxx|h]: added copy[way]left header.
1737 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1738 * In order to fix writing of dicom files:
1739 - Test/TestWriteSimple.cxx: a simpler example of writing.
1740 - Test/CMakeLists.txt changed accordingly.
1741 - src/gdcmDocument.cxx:
1742 -- The destructor now recursilvely removes potential sequences.
1743 -- Bug fix in ::IsJPEG2000()
1744 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1745 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1747 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1748 to only declared) and build on top of
1749 ::GetDocEntryByNumber(guint16, guint16).
1750 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1751 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1752 for usage in destructor and treatement of promotion in
1753 ::ReplaceOrCreateByNumber().
1754 - src/gdcmSQItem.cxx: destructor should better handle his job.
1755 Test/TestWriteSimple now runs (or at least it DOES something).
1756 * We can now start hutting memory links. A good starting point is:
1757 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1758 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1759 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1761 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * Valgrind note: after Mathieu Malaterre teached me how to read
1763 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1765 Using gcc, you can force the STL to use malloc and to free memory as
1766 soon as possible by globally disabling memory caching.
1767 With 3.2.2 and later, you should export the environment variable
1768 GLIBCPP_FORCE_NEW before running your program.
1769 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1770 simply vanish (it is still not clear to me, whether this means that
1771 STL std::string leaks or if valgrind believes it leaks...).
1772 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1773 running bin/gdcmTests makeDicomDir):
1774 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1775 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1777 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1778 SegFaulting (I drowned in DicomDir related code when trying to
1779 understand why the list is empty...).
1780 * src/gdcmDocument.h: first BSD license header try.
1781 * Doc/License.txt added.
1783 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1784 * src/gdcmDocument.[h|cxx]:
1785 - Clean up of the Transfer related predicates. They are now all based
1786 on new method isGivenTransferSyntax, that (should) handle properly
1787 the padding problem.
1788 - general clean up, simplification, and coding style.
1789 - Specific clean up of Parse7FE0() (umproperly named actually).
1790 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1792 2004-06-14 Jean-Pierre Roux
1794 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1795 - fix the display of SQItem ordinal number
1796 - add the GetSQItemByOrdinalNumber method
1797 - remove some useless never written private methods
1799 2004-06-14 Jean-Pierre Roux
1801 - adding a constructor taking a gdcmDocEntry as an input param
1802 - ReplaceOrCreateByNumber now returns :
1803 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1804 a gdcmValEntry * if a string value is passed as a param
1806 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1807 according to the param type (no longer sets a gdcmDocEntry)
1808 - GetValEntryByNumber, GetBinEntryByNumber added
1809 - NewValEntryByNumber and NewBinEntryByNumber added
1811 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1813 - GetSQItemNumber and SetSQItemNumber added, to provide
1814 a (relative) Item identier inside a given Sequence
1815 \warning : some pb remaining around this number
1817 - AddEntry now takes the Item Number as a param
1819 - adding a constructor taking a gdcmDocEntry as an input param
1821 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1822 * Memory leak hunt with the following command:
1823 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1824 --show-reachable=yes gdcmTests PrintDocument
1825 It looks like many (all?) leaks are due to the STL (or a bad usage
1826 of the STL. The lines producing the leaks now have a comment with
1827 a "MEMORY LEAK" tag: you can retrieve them with
1828 grep "MEMORY LEAK" src/*
1829 Here are two typical examples which I can't help fixing:
1834 char * test = "babo";
1835 name = test; //// <--- valgrind detects 960 bytes lost in
1836 //// call to std::string::operator=(char const*)
1837 name.clear(); //// Doesn't help !
1845 std::cout << "Type a bunch of characters followed by RETURN: ";
1846 getline(std::cin, line); //// <--- valgrind dectects a loss
1847 //// of 1320 bytes in call to
1848 /// std::basic_istream<>& std::getline<>
1854 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * src/gdcmHeader.[cxx|h]:
1856 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1857 and related, moved away to gdcmDocument.
1858 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1859 the corresponding protected accessors of inherited class
1860 gdcmDocument, removed ! As a consequence gdcmFile had to be
1861 declared friend of class gdcmDocument (see below).
1862 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1863 - Clean up of undefined or unused methods.
1864 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1865 account the changes to gdcmHeader.h).
1866 * src/gdcmDocument.h:
1867 - gdcmFile is now a friend class (in order to take into account the
1868 changes to gdcmHeader.h).
1869 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1870 (see changes to gdcmHeader.h).
1871 - Accessors (reading on the form GetEntry*) are now public.
1872 - Clean up of undefined or unused methods.
1873 * src/gdcmDocument.cxx:
1874 - adaptation to changes to gdcmDocument.h
1875 - ::OpenFile now writes a verbose message when file cannot be opened.
1876 - some std::string properly set to VRKey
1877 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1878 references to gdcmDocument.
1879 * Test/TestFindTags.cxx: changed accordingly to above changes.
1880 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1881 cvs repository gdcmData.
1883 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1885 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1886 conflicts with gdcmValEntry::voidArea.
1887 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1888 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1889 Value representation between StringRepresentable and BinaryRepresentable.
1890 * src/gdcmDocument.cxx:
1891 - method ParseDES: proper indentation restored and usage of
1892 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1893 - method LoadDocEntry: the fingerprint left in the SetValue() of
1894 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1895 removed. Reverting to previous code segment with the proper
1896 dynamic_cast< gdcmValEntry* >.
1897 Note: this was (partially) breaking the python test suite
1898 (gdcmPython/testSuite.py) that made usage of the above
1899 fingerprint to check presence of "Pixel Data".
1900 * src/gdcmDocEntry.h: coding style.
1901 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1902 now taken into account.
1903 * gdcmPython/gdcm.i: adaptation to the new internal representation
1904 of gdcm (exit gdcmParser, hello gdcmDocument).
1905 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1907 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1908 anymore, but instead prints the loaded Python dictionary.
1909 * .... alas, the python testSuite is still broken.
1911 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1912 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1914 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1915 * src/gdcmUtil.h : export methods
1917 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1920 * Initial addition of automatic python testing
1921 * Initial addition of automatic image comparison
1923 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1924 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1925 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1927 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1928 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1929 * Test/ShowDicom.cxx : bug fix for msvc compilation
1930 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1932 2004-05-04 Jean-Pierre Roux
1933 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1934 new concepts (and new classes) :
1935 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1936 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1937 - Sequence Doc Entries (gdcmSeqEntries)
1938 a Sequence is composed of Items.
1939 Each item is a set of Doc Entries (this is recursive)
1940 The non uniqueness of the 'Dicom tag' is due to this recursivity
1941 (never taken into account)
1942 Our unability to add a new 'entry' in the header
1943 at the proper location (neither in the H-Table (map or multimap),
1944 nor in the Chained List is also due to this recursivity.
1945 Don't try, right now, to use/modify/compile these new sources :
1946 nothing is finished.
1947 We just commit all the stuff, 'as is', in order not to loose it.
1949 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1950 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1952 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1953 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1954 file prefix (SetFilePrefix)
1956 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * Add a new test: ShowDicom, for now this is just the c++ version of
1958 checkRead.sh, later it will be able to compare the image read against a
1960 * Replace the DEBUG on the stack with a global entry in cmake interface:
1961 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1963 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1964 * Add an example subdir, with a real example on how to read + write a
1967 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1969 * Doc/CMakeLists.txt: the main page is now properly differentiated
1970 between the developper and user version.
1971 * Doc/doxygen.config.in: dropped search related obsolete flags
1972 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1974 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * DEVELOPPER: added some helpfull comments for compile/test/install
1978 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1980 src directory, now generated in the build dir.
1981 2. Tests as mentionned smarter
1983 4. Add a new method in gdcmDict that return the PubDict by name
1984 this is interesting for 3rd party lib like ITK,
1985 where we could set the institution name / patient name...
1987 * ENH: 1. Now the test suite is working for real
1988 2. All binaries are now output in the gdcm-bin directory
1989 (this was not true before)
1991 2004-04-28 Jean-Pierre Roux
1992 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1993 SeQuence indented printing of Dicom Header.
1994 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1995 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1996 Computation of SQDepthLevel is now part of gdcmHeader constructor
1997 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1998 tree-like structure of a Dicom Header.
1999 * FIX Test code cleaning
2001 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2002 * ENH: Adding automatic testing
2003 1. Need a DartConfig.cmake to submit to public
2004 2. Add a test driver gdcmTest.cxx
2005 3. gdcmTestMain, an helper for the main test driver gdcmTest
2006 4. Files in Test don't have a main anymore, this becomes interesting
2007 when we add more and more tests, thus dsw don't have to load
2009 * ENH: Adding a GDCM_DATA_ROOT for testing
2010 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
2011 one file instead of seven + some small cleanup
2013 2004-04-22 Jean-Pierre Roux
2014 * ENH Minor changes to the Print() methods.
2015 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2016 Header printing. Example given with :
2017 > PrintHeader fileName 2 new
2018 (SQ based tree-like structure still to be done for the Header ...)
2020 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2022 1. I have added some unsigned where needed
2023 2. Some function parameter not used -> (void)
2024 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2025 4. g++ don't like character '\' in comment
2026 5. #define jpeg_create_decompress jCreaDecompress
2027 this really need to be fixed
2028 6. virtualize destructor of gdcmObject ... leakage
2029 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2030 this also really need to be fixed
2031 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2032 remove compression file
2033 (as we only do decompression, right ?)
2034 * ENH: Change malloc/calloc/free with c++ equivalent
2036 2004-04-21 Jean-Pierre Roux
2037 * FIX gdcmHeaderHelper::GetXSpacing
2038 when a single value is found (bug ?), xpacing is now
2039 defaulted to yspacing
2041 2004-04-19 Jean-Pierre Roux
2042 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2043 * ENH add parameters :
2044 bool exception_on_error = false,
2045 bool enable_sequences = false,
2046 bool ignore_shadow = false
2047 to the gdcmFile constructors to be full gdcmParser compliant
2048 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2049 to allow reading of PAPYRUS 3.0 files
2051 2004-04-06 Jean-Pierre Roux
2052 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2054 2004-04-02 Jean-Pierre Roux
2055 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2056 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2057 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2059 2004-03-30 Jean-Pierre Roux
2060 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2061 for ACR file, written out as DICOM files (hope so...)
2063 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2065 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2066 moved to base class gdcmParser and only the specialisation is kept
2068 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2069 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2070 already does the job.
2071 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2072 (to be consistent with gdcmParser::WriteEntries).
2074 2004-03-30 Benoit Regrain
2075 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2076 upate of the object's instance. It's passed to 2 in the unfavorable
2077 case : one in the ExecuteInformation, one in the ExecuteData
2079 2004-03-29 Jean-Pierre Roux
2080 * ENH : Check on file type to be written moved
2081 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2082 * FIX : gdcmObject::ResetBoundaries now stops properly
2083 when end-of-list is reached
2084 : gdcmVersion modified (as Benoit Regrain asked)
2086 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2087 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2088 * src/gdcmUtil.cxx: added forgotten iostream include.
2089 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2090 equivalent to ExplicitVR in existing code).
2092 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2094 now contains all the gdcmGlobal related code.
2095 * minor coding style and doxygenation changes.
2097 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2098 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2099 now contains all the Debug related code.
2100 * minor clean-up of includes in src/*.cxx
2101 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2102 CreateCleanString) removed.
2103 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2104 * Doc/DoxyMainPageUser.txt added.
2105 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2106 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2107 src/gdcmDirList.cxx)
2109 2004-03-24 Jean-Pierre Roux
2110 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2112 2004-03-23 Jean-Pierre Roux
2113 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2114 big endian made volumes
2115 * ENH Now gdcmParser constructor and destructor are protected to forbid
2116 end user to instanciate class gdcmParser
2117 (only gdcmHeader and gdcmDicomDir are meaningfull)
2119 2004-03-22 Benoit Regrain
2120 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2121 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2122 gdcmSerie to gdcmDicomDirSerie
2124 2004-03-19 Jean-Pierre Roux
2125 * ENH Now the tree-like structure describing a DICOMDIR comming from
2126 an already existing DICOMDIR file is consistent with
2127 the home-made tree-like structure build ex-nihilo
2128 or build from the files held (recursively) in a Directory
2129 functions gdcmDicomDir::CheckBoundaries()
2130 gdcmObject::SetBoundaries() added
2132 2004-03-17 Jean-Pierre Roux
2133 * REM (Eric Boix bug) : removal of meaningless
2134 gdcmDicomDirImage::NewImage function.
2135 * FIX now file names and directory name are written properly in the
2137 * FIX now gdcmDicomDir constructor may be call without any trick
2140 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2142 of gdcmDicomDirImage::NewImage as empty function.
2144 2004-02-28 Jean-Pierre Roux
2145 * ENH add gdcmDicomDir:NewPatient
2146 add gdcmDicomDirPatient:NewStudy
2147 add gdcmDicomDirStudy:NewSerie
2148 add gdcmDicomDirSerie:NewImage
2149 to allow making gdcDicomDir object.
2150 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2151 (as opposite to the gdcmHeader chained list)
2153 2004-02-11 Benoit Regrain
2154 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2155 when using from python
2157 2004-02-10 Benoit Regrain
2158 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2159 * FIX : in gdcmDicomDir when the directory is empty
2160 * ENH : add callback and methods to get the progression of dicomDir
2163 2004-02-06 Jean-Pierre Roux
2164 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2165 - GDCM_META added to gdcmDicomDirType
2166 - class gdcmMeta created
2167 * ENH : - A brief summary is now displayed at the beginning of
2168 'testDicomDir' to help disaster magnitude estimation
2169 * REM : Now useless Test/explDICOMDIR.cxx
2171 2004-02-05 Benoit Regrain
2172 * ENH : add methods in gdcmObject to get the hash table or the list of
2174 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2175 * FIX : wrapping python for TagHeaderEntryHT
2177 2004-02-04 Benoit Regrain
2178 * FIX : even length for some strings when writting the dicom dir
2179 * FIX : sort the images in the dicom dir
2180 * FIX : Bug fix for python use of dicom dir
2181 * ADD : a python demo
2183 2004-02-04 Jean-Pierre Roux
2184 * FIX : Final solution (?) for icone embedded images
2185 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2186 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2187 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2188 gdcmData/gdcm-MR-SIEMENS-16.acr1
2189 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2190 to make full checking easier
2192 2004-02-04 Benoit Regrain
2193 * FIX : WriteEntries : coding style & logic in parameters
2194 * FIX : Set the elements to create the DicomDir in a dictionary file
2196 2004-02-03 Benoit Regrain
2197 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2198 * gdcmDicomDir : add the load of directory
2199 * Bug fix and print add-on
2201 2004-02-03 Jean-Pierre Roux
2202 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2203 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2204 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2205 * FIX gdcmParser.cxx : 'group length' elements are now considered
2206 as integers, even for shadow groups, when file is Implicit VR
2208 2004-02-02 Jean-Pierre Roux
2209 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2211 of the last synonym :-(
2212 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2214 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2215 * FIX taking into account the possible 7fe0,0010 multiplicity
2216 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2217 to allow removal of references to 7fe0,0010, to deal with
2218 ACR-NEMA images, when 0028,0200 is meaningfull
2220 2004-01-31 Jean-Pierre Roux
2221 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2222 no longer writes 'Un' on disk
2223 * FIX SQ elements with actual length are now dealt with corectly
2224 * FIX gdcmFile::WriteBase make the difference, for color images, between
2225 the length (for Palette expanded images)
2226 and Raw Length (non expanded image + Palette)
2227 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2228 (that broke Write). Replaced by UL.
2229 Aware user will reload the field if he
2230 thinks it's necesssary
2232 2004-01-30 Jean-Pierre Roux
2233 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2234 when 'dirty Acr' is found, to be compliant with the new
2235 IsReadable() methods.
2237 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2238 (no DOUBLE images in kosher DICOM,
2239 but so usefull for people that miss them ;-)
2241 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2242 DICOMDIR related utilities (not checked as Windoze compliant)
2244 2004-01-28 Jean-Pierre Roux
2245 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2247 2004-01-27 Jean-Pierre Roux
2248 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2249 to allow skipping the shadow elements, to save memory space.
2250 The TRUE value for this param has to be used
2251 with a FALSE value for the 'enable_sequence' param.
2252 ('public elements' may be embedded in 'shadow Sequences')
2253 * gdcmHeader methods now deal with 'embedded icones images' in the header
2254 (even when an 'icone image sequence' is announced by the
2255 element (0x0088,0x0200), but there is NO icone at all ...
2257 * gdcmHeader sometimes Image Location value doesn't follow
2258 the supposed processor endianity (see gdcmData/cr172241.dcm).
2261 * gdcmHeader add the method
2262 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2263 to get *all* the Header Entries with the same tag.
2264 GetHeaderEntrySameName is probabely *useless*
2265 (no meaning : Name is *not* an identifier within the Dictionary)
2267 2004-01-26 Benoit Regrain
2268 * Bug fix in the print of hexadecimal representations. Remove long fields
2269 in the print and add a third level of print to print them
2271 2004-01-23 Benoit Regrain
2272 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2273 * Bug fix on test suite after remove the strip made on not string fields
2274 * Split the IsReadable method between gdcmParser which test that the file
2275 is dicom and gdcmHeader which test that it's an image file
2277 2004-01-22 Benoit Regrain
2278 * DicomDir : clean code, add methods, set variables in protected or private
2279 * gdcmUtil : bug fix for the clean string method
2281 2004-01-19 Benoit Regrain
2282 * Add the use of shadow dictionaries
2283 * bug fix and coding style
2285 2004-01-19 Benoit Regrain
2286 * src/gdcmFile.cxx : bug fix concerning the close of file
2287 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2288 * Add the update of header entries using the shadow library
2290 2004-01-19 Benoit Regrain
2291 * removal of file gdcmHeader2.cxx
2292 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2293 inheriting from gdcmParser. This split is to prepare the integration
2294 of dicom dir parsing
2295 * bug fix under python
2297 2004-01-16 Jean-Pierre Roux
2298 * REM removal of class gdcmHeaderEntrySet
2299 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2300 * ADD add file gdcmHeader2.cxx
2301 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2303 2004-01-15 Benoit Regrain
2304 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2305 entries created while parsing the header. Thus, they will be destroyed
2306 when the gdcmDictSet will be destroyed
2307 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2310 2004-01-15 Benoit Regrain
2311 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2312 made a fatal error because of the memory release at the end of program.
2313 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2314 some memory and vtk seems to have some problems with that.
2315 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2317 2004-01-14 Benoit Regrain
2318 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2319 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2320 * src/*.[h|cxx] : make changes due to class name changes
2321 * gdcmPython/demo/*.py : bug fix due to method names
2323 2004-01-13 Benoit Regrain
2324 * src/*.[h|cxx] : coding style
2325 * vtk/*.[h|cxx] : coding style
2327 2004-01-13 Benoit Regrain
2328 * gdcmPython/testSuite.py : test the readable flag of file for tests
2329 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2330 It's lied to the stl compilation by MSVC (windows, always windows...)
2331 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2333 2004-01-12 Benoit Regrain
2334 * src/*.h : add comments
2335 * src/gdcmDictSet.h : set the method BuildDictPath in public
2336 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2337 directly setted in the source code
2338 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2341 2004-01-09 Benoit Regrain
2342 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2343 * setup.py : use a reference to gdcmVERSION
2345 2004-01-07 Benoit Regrain
2346 * Modification to compile with the distutils.
2349 2003-12-10 Benoit Regrain
2350 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2351 can use a gdcmHeaderHelper to load data
2352 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2353 made in the source code
2355 2003-12-10 Benoit Regrain
2356 * Update Windows projects and .cvsignore files
2358 2003-11-12 Jean-Pierre Roux
2359 * ENH gdcmHeader constructor has one more parameter (default value : false)
2360 that allows the user to 'go inside' the SeQuences only
2362 gdcmElValSet:Print takes it into account
2364 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2365 * ENH: Update gdcmPython/CMakeLists
2366 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2367 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2369 2003-11-10 Jean-Pierre Roux
2370 * FIX : gdcmHeader::LoadElements is now based
2371 on the ListTag listElem member,
2372 not longer on the TagElValueHT tagHt member
2373 * ENH : PrintPubElVal shows (temporarily) both results,
2374 with the tagHt member and the listElem member.
2375 (it's easier to 'see' the problems when using Printheader)
2377 * FIX : old private member LgrElem is now splitted into
2378 ReadLength : Length actually found on disk (updated only
2379 if bug fixing is necessary), for internal
2381 UsableLength : Updated by FixFoundLength, to fix a bug
2382 or to allow Parser going on.
2383 Will allow to re-write a kosher header when a SeQuence
2384 with a length (not 0000) is found
2385 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2386 because gdcmElValSet::Add does not update ListElem
2389 2003-11-07 Jean-Pierre Roux
2390 * FIX misstyping in Transfert Syntax name table
2391 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2392 when they have an actual length (not 0000 nor FFFFF)
2393 (Nobody should care of it, but DICOMDIR explorers)
2395 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2396 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2398 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2399 * ENH: vtkGdcmReader now supports LUT !
2400 (vtkgdcmViewer for now is not able to use them though)
2402 2003-11-05 Jean-Pierre Roux
2403 * in testSuite.py : new files names for checking the package
2404 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2405 that returns the pixel area size to the *aware* (vtk) user
2406 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2408 2003-11-05 Benoit Regrain
2409 * in testSuite.py : Modify the rules for checking the paths
2410 : Explicit error messages
2411 * in __init__.py : Related modif
2413 2003-11-03 Jean-Pierre Roux
2414 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2415 to be used by aware (vtk) users that want to manage
2416 LUT (and no to turn the PALETTE image into an RGB pixels one)
2417 * GetPixelType now returns 8U for 24 Bits images
2418 (vtkGdcmReader compliant)
2420 2003-10-31 Jean-Pierre Roux
2421 * Removal of *all* gdcmData images and add them again
2422 in order to loose the 'history' of un-anonymised images
2424 2003-10-31 Jean-Pierre Roux
2425 * RMV : removal of useless jBitsInJsample.h
2426 for both 8 and 12 Bits JPEG Lossy Libraries
2428 2003-10-31 Jean-Pierre Roux
2429 * ENH : Add the functions gdcmFile::GetImageDataRaw
2430 gdcmFile::GetImageDataIntoVectorRaw
2431 that act as GetImageData and GetImageDataIntoVector
2432 except the making of an RGB Plane from Gray Plane + LUT
2433 Intended to aware (vtk) users who know how to manage
2436 GetLUTRGBA return a R,G,B,A LUT if any
2437 lgrTotaleRaw gives the 'Raw' length
2438 GetImageDataRaw returns the gray Plane
2439 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2440 (They stay Grey, just like with other Dicom viewers :-(
2442 2003-10-30 Jean-Pierre Roux
2443 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2445 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2446 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2447 being coherents dicom files.
2449 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2450 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2452 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2453 * ENH: Two steps is necessary to please VC++ compiler...
2454 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2455 * ENH: Add include dir to medcon lib
2456 * FIX: only one function is being exported for now !
2457 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2459 2003-10-29 Jean-Pierre Roux
2460 * adding gdcmHeader::GetLUTRGBA
2461 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2462 --> Mathieu, the modif u're waiting for is not yet committed
2463 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2465 2003-10-27 Jean-Pierre Roux
2466 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2467 00191113.dcm DermaColorLossLess.dcm
2468 MxTwinLossLess.dcm RadBWLossLess.dcm
2469 * ENH: For version prior to vtkImageViewer2 -r 1.19
2470 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2472 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2473 * Removal of ido stuff in CMakeLists.txt
2475 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2476 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2477 * FIX: remove a call to ->Modified ... see comments
2478 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2480 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2481 * FIX: Problem with path for libvtkgdcmPython
2482 * ENH: Try adding a search script for python site-package
2483 * RMV: Remove some file from medcon lib that are not necessary
2484 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2485 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2486 * FIX: More pragma disable fro VC++,
2487 I don't think I break something as it is also disable in VTK/ITK.
2488 But it fasten debug compilation time.
2490 2003-10-23 Jean-Pierre Roux
2491 * gdcm now deals with 16 Bits Run Length Encoded images
2492 (they are compressed as 2 planes images,
2493 one for the high Bytes, the other for low Bytes)
2495 2003-10-22 Jean-Pierre Roux
2496 * Now CheckRead takes into account :
2497 - the bugged 'Leonardo' Siemens images
2498 - the XA images, sent thru the burning VPRO station
2499 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2502 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2503 * FIX: When copying a Makefile.am to CMakeLists.txt
2504 one should remove the '\'
2506 2003-10-22 Jean-Pierre Roux
2507 * in gdcmData adding a bugged 'Leonardo' Siemens image
2508 (wrong lengths in header)
2509 OK with gdcm, KO with the other viewers :-)
2510 * add a GE dlx XA image, thru the VEPRO burning station
2513 2003-10-21 Jean-Pierre Roux
2514 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2515 for a brutal checking of vtkgdcmViewer compliance
2517 2003-10-21 Jean-Pierre Roux
2518 * add the files for 'xmedcon' Jpeg Lossless library
2519 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2521 2003-10-21 Jean-Pierre Roux
2522 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2524 2003-10-21 Jean-Pierre Roux
2525 * garbage Siemens 'Leonardo' images dealt with
2526 (the patch is easy to remove)
2527 * cosmetic changes to avoid warnings
2529 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2530 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2531 no need to press 'r' now.
2533 2003-10-20 Jean-Pierre Roux
2534 * upgrade of checkRead.sh checkWrite.sh according
2535 to new Jpeg Lossless decompressor
2536 * add US.3405.1.dcm, a genuine RGB medical file ...
2537 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2538 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2540 2003-10-15 Jean-Pierre Roux
2541 * general anonymisation in gdcmData
2542 * adding the 'color files' from
2543 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2544 * adding some well knowed bugged-header images
2545 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2546 waiting for their inclusion in Python testsuite
2548 2003-10-15 Jean-Pierre Roux
2549 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2550 no longer seg faults when file is not found
2552 2003-10-14 Jean-Pierre Roux
2553 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2556 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2557 * TODO: *.in file to genereate a UseGDCM later
2559 2003-10-14 Jean-Pierre Roux
2560 * Some supposed-to-be Dicom Images have no preamble.
2561 OpenFile takes it into account
2562 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2563 * Missing elements added in dicomV3.dic
2564 (just to be affraid : have a look at
2565 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2566 and do it again next year ;->
2568 2003-10-13 Jean-Pierre Roux
2569 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2570 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2571 But there are NOT. It's fixed !
2573 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2574 * FIX: "jpeglib.h" was not found on VC++
2575 * FIX: vtkgdcm was not being installed
2577 2003-10-10 Jean-Pierre Roux
2578 * ENH : OpenFile closes the file if it *really* doesn't look like
2579 an ACR-NEMA / DICOM one.
2580 * FIX : testWrite no longer writes an empty file if the source file
2581 is not gdcm Readable
2582 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2585 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * FIX: CMake generate now documentation
2587 * ENH: out of source doc build !
2588 * ENH: Generate both user and dev documentation
2589 * ENH: Should work on windows too
2590 * ENH: Only one doxygen config.in file is needed
2591 * FIX: make install should be ok now on ùnix plateform
2592 * FIX: PATH to dictionary was wrong (missing /)
2593 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2595 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2596 * vtkGdcmReader is now able to read rgb dicom file.
2597 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2598 * added a gdcmViewer to vtk test, use mouse to control
2599 window level & window width
2601 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2602 * CMake-ification of gdcm, we have now two build system
2603 * FIX: on cygwin Wsock32 doesn't exist
2604 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2606 2003-10-06 Emanuel Ollart
2607 * FIX : compilation process wad broken.
2608 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2610 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2611 * change gdcmViewer -> vtkgdcmViewer
2612 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2614 2003-10-06 Jean-Pierre Roux
2615 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2616 ( e.g : well known GE images with a wrong elem length,
2617 : Philips MRI Images with a wrong Huffman table)
2618 * still to be done : allow the reading of bugged LEONARDO Siemens images
2620 2003-10-03 Jean-Pierre Roux
2621 * Odd length strings are padded with '\0' (not with spaces,
2622 to remain compliant with already defined strings,
2623 like Transfert Syntax UID and others)
2625 2003-10-03 Jean-Pierre Roux
2626 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2627 to allow displaying RGB images (not only by affim ;-)
2629 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * vtkGdcmReader is now able to read rgb dicom file.
2631 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2633 2003-10-03 Jean-Pierre Roux
2634 * A few nasty patches to allow the reading of a lot of nasty images
2635 ( e.g : well known GE images with a wrong elem length,
2636 : Philips MRI Images with a wrong Huffman table)
2637 * still to be done : allow the reading of bugged LEONARDO Siemens images
2639 2003-10-03 Jean-Pierre Roux
2640 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2642 2003-10-03 Jean-Pierre Roux
2643 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2644 to allow displaying RGB images (not only by affim ;-)
2646 2003-10-03 Jean-Pierre Roux
2647 * gdcmFile::GetImageDataIntoVector now
2648 - deals with MultiFrames MultiFragments Run Length Encoded files
2649 - deals with YcBcR (YBR_FULL) files
2650 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2651 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2653 (no sample found :-(
2655 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2656 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2657 Two reasons: - clear things
2658 - third parties acces gdcm through header files, so won't
2659 suffer anymore VC++ complains
2661 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2662 * add argv[1] in testvtkGdcmReader.cxx
2665 2003-09-24 Jean-Pierre Roux
2666 * The lines are now eigthy characters long.for
2667 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2669 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2670 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2671 char* to std::string. Thus, the use of strdup becomes useless. (see
2672 previous commis of Malaterre)
2673 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2674 before the last Malaterre's commit.
2676 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2677 * This commit should fix the Debug building under VC++, the problem
2678 was mainly a mixture of debug and release lib being loaded at startup.
2679 * I also remove a depency to a specific C function: strdup. Because I had
2680 to force the link to msvcrtd (whereas strdup is in libc).
2682 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2683 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2684 located in the gdcmCommon.h file. All use of reference of tha has been
2685 changed to now use the variable GDCM_UNFOUND.
2687 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2689 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2690 Dicom dictionary. The test suite can now be run again. Note:
2691 I'm note very happy with the " (RET)" changes. I believe this
2692 RETAINED comment should be dropped when parsing the dictionary.
2693 - PACKAGER corrected
2695 - AUTHORS updated and now in alphabetical order
2696 * Makefile.am now exports gdcm.dsw for Windoze users.
2698 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2699 * cygwin complains about missing std:: in subdir Test/
2701 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2702 * remove some methods that are now in gdcmHeaderHelper
2704 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2705 * vtkGdcmReader set spacing and origin correctly
2707 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2708 * Fix a few delete/delete[] mismatch
2710 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2711 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2712 interpretation to data given by gdcmHeader. For instance there are
2713 heuristics to get informations (look at different places).
2714 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2715 sorting DICOM images based on different strategies.
2716 * modified Makefiles accordingly.
2718 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2719 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2720 when building in debug mode
2721 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2722 src/win32/gdcmdll.dsp
2723 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2725 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2726 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2729 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2730 * src/win32/libgdcmjpeg12.dsp was not dos format
2731 * src/win32/libgdcmjpeg12.dsp :
2732 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2733 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2735 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2736 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2738 * src/gdcmFile.cxx : bug fix in affectation type
2739 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2740 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2741 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2742 symbols... future problem ?
2744 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2745 * src/win32/libgdcmijpeg12.dsp was missing
2746 * modified gdcm.dsw accordingly
2748 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2749 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2751 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2752 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2753 commit of JPR (before his hollidays to facilitate our work).
2754 * setup.py : bug fix in code. Modifications made while the last commit
2755 of JPR. The code hasn't been tested before the commit... it's so
2756 useless to make that (for best programmer that is JPR) !!!
2758 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * tagged the current version as Version0_3 (i.e. version 0.3)
2761 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2762 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2763 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2764 * *.dsp : modifications to use new libgdcmijpeg8 library
2765 * setup.py : bug fix on VTKPATH variable
2766 * PACKAGER : adding all concerning windows
2768 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2771 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2772 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2773 test suite reported error.
2774 * PACKAGER file added (describes what a packager must do when
2775 packaging a new release).
2776 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2777 * configure.in: upgraded version number to 0.3.0
2778 * fixing build of rpm (through rpm -ta):
2779 - Doc/Makefile.am exports proper doxygen files
2780 - src/jpeg/libijg8/Makefile.am exports the include files.
2782 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2783 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2784 * src/gdcmHeader.h : formatting code
2786 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2787 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2788 We were obtaining error message from vtk. Now, creation of file list
2789 is made in an internal list to prevent this problem.
2790 Bug fix when output is empty.
2791 Bug fix in update of progress value. Previous commit for this was a bad
2793 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2795 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2796 * src/gdcmHeader.h : added method to get the file name
2797 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2798 files. Added method to remove all files on the input
2799 Added FIXME comment concerning the bad parsing of header made by
2800 ExecuteInformation method (in ExecuteData method)
2802 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2804 when using make instal.
2805 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2806 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2808 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2809 * setup.py : adding include dir of jpeg lib to compile all sources
2810 * */Win32/*.dsp : JPR fix for windows compilation
2812 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2813 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2815 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2816 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2818 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * setup.py is again effective on un*x (takes into account the
2820 addon of the jpeg library)
2821 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2822 * Doc/Doxy* updated (includes above enhancements)
2823 * INSTALL now points to web documentation
2825 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * src/gdcmHeader.h doesn't make unnecessary reference to
2828 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2830 * src/gdcm*.[cxx|h] :
2831 - to allow compilation with gcc 3.x
2832 -- clean up of STL usage (added explicit usage of std::)
2833 -- small fixes on exceptions.
2834 Note: linking not tested !
2835 - clean of doxygen comments to avoid warnings at documentation
2837 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2838 dependent convertion).
2840 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * Clean up of previous JPR garbage commit (not even commented in the
2843 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2844 - moved all jpeg related files from src to src/jpeg/libijg8, with
2845 addition/modification of Makefile.am and configure.in.
2846 - the testSuite is still brain damage (not guilty).
2848 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2849 * WrapVTK.py : modifications to get correctly vtk source files to
2851 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2852 (FileName -> Filename)
2854 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2855 * vtk/vtkGdcmReader.[cxx/h]:
2856 - UpdateProgress method should now be effective
2857 - removed the limitation on having only images loaded (as opposed
2859 - when building a stack of images/volume, a lesser number of
2860 gdcmHeader and gdcmFile instances should be used (hopefully
2861 accelerating things).
2862 - when building a stack of images/volumes, files which are not
2863 loadable (wrong path-filename, wrong permissions on existing file,
2864 or file not parsable by gdcm) are replaced with a black image
2865 in the stack (for the caller to notice the problem).
2867 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2870 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2871 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2872 between standard library (std) and vtk library (problems are found
2873 under Windows... thanks Windows !)
2875 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2876 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2878 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2880 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2881 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2883 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2884 * When compiling with distutils (see setup.py) the C++ compiler is
2885 called with different flags than the default ones (with automake).
2886 In order to fix all those warning, I compiled gdcm with the command
2887 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2888 and went for warning fixes:
2889 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2890 up from unused variables.
2891 - vtk/vtkGdcmReader.cxx: potential bug fix.
2892 * src/gdcmHeader.h: Doxygen warning cleanup
2894 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2895 * gdcmPython/gdcm.i:
2896 - typemaps correction to take into account the systematic replacement
2897 of "using namespace std" with std:: prefix e.g. std::list,
2898 std::string... (cf changes of 2003-05-21).
2899 - gdcmGlob global variable of type gdcmGlobal (defined in
2900 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2901 exported to Python a as cvar.
2902 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2903 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2904 gdcmDictSet.GetPubDictTagNames() and
2905 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2906 C++ static methods).
2907 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2908 with the above changes.
2910 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2911 * setup.py, manifest.in : bug fix under linux
2913 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2914 * Modification of setup.py to compile vtk part too. Then, we have 2
2915 wrappers which must work with same distutils. For that, we have a
2916 generic distutils in distusiltsWrapping.py ; with :
2917 - build_extWrap class to wrap generically all extensions,
2918 - ExtensionWrap base class for all wrapping extension that contains
2920 - Wrapper interface which wrap sources
2921 + In WrapSwig.py we have extension and wrapper for Swig
2922 + In WrapVTK.py we have extension and wrapper for VTK
2923 * MANIFEST.in : modifications to consider vtk directory and new python
2924 files for compilation
2926 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2927 * Added python wrappers of vtkGdcmReader vtk class (see the
2928 source in vtk/vtkGdcmReader.cxx) :
2929 - vtk/Makefile.am now builds a library
2930 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2931 python library (as opposed to _gdcm.so wich are the python
2932 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2933 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2935 - configure.in has an additional flag --enable-vtk that needs
2936 to be set to enable compilation of vtk related code, that is:
2937 + vtk/vtkGdcmReader.so and
2938 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2939 + gdcmPython/vtkgdcmPython.so (see above)
2940 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2941 be read when compressed or when HighBit + 1 != BitsStored),
2942 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2943 the usage of the python wrapper of vtkGdcmReader vtk class.
2944 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2945 * src/*.[h] all occurences of stl classes are now prefixed with
2946 std::, and all occurences of "using namespace std;" where removed.
2947 This is to avoid pollution of global namespace in included files.
2948 Apparently vtk does not avoid this pitfall: when using both
2949 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2950 collision of various stl members (principally cout...).
2951 * gdcmPython/testSuite.py now cleanly removes temprory generated
2953 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2954 comply with above changes)
2956 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2957 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2958 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2959 vtk data structure (an image Flip was required).
2960 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2961 * cosmetic changes in documentation.
2963 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2964 * src/gdcmHeader.cxx: the constructor no longer exits when an
2965 unexisting file is given as argument.
2966 * The subdirectory Data (containing all the images used for the
2967 test suite) is not part of this repository anymore. A new module
2968 containing those images is now available at
2969 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2970 with the name gdcmData.
2971 All the python scripts (including the package initialisation file
2972 gdcmPython/__init__.py) were adapated to take this change into
2973 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2975 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2976 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2977 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2978 demo of the usage of this class.
2979 Compilation of this vtk part is only done when using the --enable-vtk
2980 at configure (or autogen.sh) stage.
2982 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2983 * More memory link related corrections and documentation fixes.
2985 - maximum info is obtained with a command of the form:
2986 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2987 --show-reachable=yes PrintHeader
2988 - the remaining reachable blocks seem to come from the STL
2989 allocation scheme through the usage of map and list. It looks
2990 like this memory cannot be freed but it is not a memory leak
2991 (in fact further invocation to the STL would recollect the
2992 unused memory allthough it cannot explicitely be freed).
2993 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2994 of displaying an image parsed with gdcm and displayed with VTK.
2995 Note: some images don't seem to work e.g.
2996 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2997 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2998 Allthough this weakens the semantics, it is a ditch attempt to
2999 make gdcm more thread friendly.
3001 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3002 * Memory link hunt (by using valgrind through the command
3003 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
3004 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
3005 gdcmHeader::_dicom_vr.
3006 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
3007 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
3009 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
3011 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3012 * src/Makefile.am now exports all the necessary include files at
3016 * UpdateGroupLength replaced by new one
3019 * UpdateGroupLength re-written using H-Table
3020 (named UpdateGroupLengthNew untill checks are over)
3022 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3023 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3024 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3026 - gdcmHeader::GetPubElValSet removed.
3027 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3028 UpdateGroupLength, WriteElements, Write.
3029 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3030 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3031 carried the same semantics.
3032 - src/gdcmHeaderIdo.cxx changed accordingly.
3033 - gdcmFile::WriteBase now regroups all the codes from previous
3034 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3035 - enum FileType moved to gdcmCommon.h
3036 * src/gdcmHeader.cxx AddDefault trashed
3037 * gdcmGetXSize added
3038 * getimageDataSize now calls gdcmGetXSize
3039 * Test/*.cxx changed to agree with above changes
3041 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3042 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3043 (to avoid double call by end user).
3044 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3045 by end user, since gdcmHeader::gdcmHeader now handles it.
3047 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * gdcm/Doc many doxygen changes:
3049 - Doxyfile now has two different versions, DoxyfileUsers that generates
3050 the html.users end users oriented documentation and
3051 DoxyfileDeveloppers that generates the html.developper developper
3052 oriented documentation.
3053 - README changed accordingly
3054 - requirement.txt removed (old design info moved to TODO).
3055 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3056 DoxyMainPage.txt, DoxyPython.txt provide more information.
3057 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3058 be updated by simply regenerating the docs with doxygen and copying
3059 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3060 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3061 all the tests in the form "if (<map>.count() >1)" were removed.
3062 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3063 ill-formed documentation sections.
3064 * src/gdcmHeader.cxx: ditto
3066 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * setup.py fixed for un*x (needed macro for stdint.h)
3068 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3069 un*ces with sh-utils test utility.
3070 * gdcmPython/demo/test.py renamed to PrintHeader.py
3071 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3072 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3073 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3074 * src/gdcm*.cxx JPR's bad inclusion fixed.
3076 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3078 * gdcmPython/demo/test.py changed accordingly.
3080 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3081 * gdcmPython/Makefile.am fixed linking against libstdc++
3082 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3083 * Swig subdir (historical tests of swig version 1.3.17++) removed
3084 * Test/testChangeEntete.cxx some lines commented out in order to make
3086 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3087 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3089 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3090 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3091 hence the user doesn't need this explicit call.
3092 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3093 i.e. LoadElements() call removed.
3094 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3095 - src/Makefile.am declares the proper flag for g++.
3096 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3097 for adding user defined new tags.
3098 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3099 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3100 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3102 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3103 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3104 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3105 src/Makefile.am : the project should properly compile and install
3106 with the autotools, included the python wrappers part.
3107 * gdcm.spec.in : added a spec file for RPM packaging.
3109 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3110 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3112 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3114 to exported to the environement (see gdcmPython/testSuite.py
3116 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3117 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3118 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3119 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3120 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3122 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3123 * gdcmPython/__init__.py doesn't crash anymore when running in
3124 in InstallMode or PreInstallMode but with an environment given
3125 value of GDCM_DICT_PATH.
3126 * src/gdcmDictSet.[cxx/h] coding style.
3128 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3129 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3130 * src/gdcm.h general comments moved to TODO, and README
3131 * src/gdcm.h should now be seen as a user commodity (including it
3132 should suffice to fully use gdcm). It is nowhere including within
3133 any of the kernel files src/*.cxx and src/*.h.
3135 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3136 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3137 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3139 * src/gdcm*.cxx only include their corresponding include file
3140 (as opposed to gdcm.h)
3141 * gdcmPython/gdcm.i changed accordingly
3142 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3143 the autogen.sh generated "make snapshot" command to work.
3144 * autogen.sh removed history related references to crea package.
3146 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3147 * distutilsSwigCPlusPlus.py work around some swig portability
3150 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3151 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3152 was done in a last ditch attempt to get setup.py _really_
3153 operationnal. The python/gdcmPython layaout add the advantage
3154 of hidding away the python related distutils specific files
3155 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3156 Alas, the src directory was out of scope (i.e. it's relative
3157 position to setup.py was ../src) which made things impossible to
3158 handle (see previous version of python/setup.py). Crossing fingers...
3160 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3161 * python/setup.py now works on Un*x. (harder than I thougth)
3162 * python/distutilsSwigCPlusPlus.py can now have include files
3163 among the list of sources.
3165 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3166 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3167 * modifications in MSVC projects
3169 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3170 * As stated by the first lines of Test/ExceptionAndPython/README, it
3171 looks like we can move back to original usage of exception within
3172 src/gdcm* and hence remove the errno stuff that was introduced
3173 as a quick and dirty fixture of this problem (added to the TODO).
3174 * Doc/Doxyfile configuration file for Doxygen and corresponding
3175 README file for usage added.
3176 * Test/testWrite.cxx added. This new test comes from a split of
3177 test.cxx that is now reverted to its original purpous i.e.
3178 testing the proper parsing of a Dicom related file.
3179 testWrite.cxx concentrates on testing the IO part of gdcm.
3180 * Test/bug1.cxx (containing a bug on WIn32) added.
3181 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3182 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3183 whose purpose is to publish the content of the TagNames of the
3184 Dicom public dictionary were not accessible without an
3185 instance of class gdcmHeader.
3186 - those methods are now static methods of gdcmDictSet and hence
3187 require no instances at all to be invocated.
3188 - within gdcmDictSet this change required to change some method
3189 to class methods (i.e. are now static) among which SetDictPath
3190 (renamed to BuildDictPath) and LoadDefaultPubDict.
3191 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3192 the above changes by calling the new method classes of gdcmDictSet.
3193 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3194 the above to be effective.
3195 * python/gdcmPython: in order to wrap properly the above changes
3196 for Python, swig version now needs to be > 1.3.17.
3197 * python/gdcmPython/Makefile fixed to adapt itself to new
3198 configure/make shema introduced by Johan Montagnat (thanks for the
3199 contribution). Alas this Makefile cannot be turned into a proper
3200 Makefile.am without some heavy changes in the configure.in
3201 (for python dectection).
3202 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3203 now avoids publishing the empty entries.
3205 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3206 * python/setup.py : bug fix concerning install under windows
3207 ExtraPath reused :-P
3208 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3210 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3211 * Dicts/dicomV3.dic : remove double spaces !!!
3212 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3213 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3216 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3217 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3218 method. Doxygenation.
3219 * src/gdcm.h clean up of JPR spurious comments.
3221 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3222 * python/distutilsSwigCPlusPlus.py now properly collects the
3223 shadow classes generated by "swig -c++" (gdcm.py in our case)
3224 when using "python setup.py install".
3225 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3226 reexports the working classes.
3227 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3228 by the classical C errno scheme. This is to prevent an obscure
3229 behavior of the python wrappers when importing wxPython.wx prior
3230 to gdcmPython (which ended up in an abort call). An illustration
3231 of this oddity can be found in the Test/ExceptionAndPython
3232 subdir (see the README file). This problem probably due to
3233 an combination of g++ and dynamic loading.
3234 * added Test/ExceptionAndPython (see above)
3236 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3237 * Changed the layout of the python part to avoid bloating main
3238 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3239 i.e. the distutils arsenal. All the python related stuff is
3240 again in a python subdir, but the package itself is now in
3242 * setup.py was cleaned up:
3243 - pythonIncludePath removed
3244 - python setup.py bdist target is now functional.
3245 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3246 collision with other packages). gdcmPython/demo/*.py changed
3249 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3250 * python subdir moved to gdcmPython (preparation of distutils packaging).
3251 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3252 distutils installer is operational.
3253 * - gdcmPython/__init__.py now properly loads the swig generated
3254 shadow classes (from gdcm.py).
3255 - gdcmPython/demo/*.py changed to import the package gdcmPython
3256 instead of gdcmPython/demo/load.py.
3257 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3259 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3260 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3261 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3262 entries within the associated public Dicom dictionary resp. the same
3263 information but sorted by the fourth field (PAT, IMG, DIR) of the
3265 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3266 are now in the "???" group.
3267 - python/gdcm.i changed accordingly,
3268 - python/demo/printGroupedPublicDict.py added, that gives an example
3269 of the above new functionalities in Python.
3271 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3272 * src/gdcm.h, gdcmHeader.cxx:
3273 - historic references to glib's g_malloc and g_free (#defined)
3274 were definitively removed.
3275 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3276 * src/gdcmElValSet.cxx:
3277 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3278 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3279 - GetElValue(string) renamed to GetElValueByName.
3280 - Added GetElementByName(string).
3281 * src/gdcmHeader.cxx: added
3282 - GetPubElValRepByNumber(guint16, guint16)
3283 - GetPubElValRepByName(string)
3284 - GetShaElValRepByNumber(guint16, guint16)
3285 - GetShaElValRepByName(string)
3286 - GetShaElValByNumber(guint16, guint16)
3287 - GetShaElValRepByName(string)
3288 - GetElValRepByNumber(guint16, guint16)
3289 - GetElValRepByName(string)
3290 - GetElValByNumber(guint16, guint16)
3291 - GetElValRepByName(string)
3292 * Doc/requirements.txt added.
3294 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3295 * Test/Makefile building now depends on the one of libgdcm.so
3296 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3297 pixel data) aware which enables finding the address (offset) of
3298 the pixel data of JPEG encoded DICOM files. This leaves only a single
3299 file in the testSuite whose pixel data address (offset) is unknown.
3300 * python/testSuite.py changed accordingly.
3302 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3303 * VC++ has some strong limitations when working with the STL, as stated
3304 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3305 "Also note that some STL containers (map, set, queue, list, deque)
3306 cannot be exported. [...]
3307 Some STL classes contain nested classes. These classes can not
3309 This is caused by a designed limitation that once a template
3310 class is instantiated, it can not be re-instantiated and
3312 Since our usage of map<> is ubiquitous in gdcm, this "designed
3313 limitation" of VC++ is a pitfall.
3314 Hence the Python wrappers of gdcm cannot be incrementally linked
3315 against the c++ dynamic library. The dirty but only workaround is
3316 to forget about incremental link of dynamic libraries and to generate
3317 the Python wrappers library with the inclusions of the underlying C++
3319 The following modifications concern this matter on Win32/VC++:
3320 - wrapping python correct with standalone wrapped dll (don't use separate
3321 dll under windows !!!!)
3322 - python21_d debug mode enabled (ask Frog how to use it :-)
3323 - NO problem with having an STL member of class for example string in C++
3324 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3325 - Python test of dcmlib in Python is ok under windows on a large set
3327 * removed glib references
3328 * typedef's inserted in gdcm.i for correct swig type management
3330 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * python/demo/*.py load.py extracted from test.py. Added explore.py
3332 that only displays required tags and testAll.py that parses all
3333 the files of the testsuite without using unittest.
3334 * python/testSuite.py other additional test on new files added.
3335 * Data/* new test files added accordingly to the testSuite.
3336 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3337 the vr in the file differs from the one of the dictionary.
3339 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3340 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3341 values, but limits itself to values which are below a user specified
3342 size (by default 1024 bytes).
3343 * python/gdcm.i : elements not loaded (because their size is above the
3344 user specified treshold) are exported with their TagKey as key of the
3345 python dictionary. This enables the testsuite to make some checks
3346 on the unloaded elements (since we have their offset and size).
3347 * python/testSuite.py
3348 - now tests for the existence and proper value of the pixel data
3349 - two new examples added.
3350 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3352 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3353 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3354 aware. See the strategy comments in gdcmHeader::FindLength().
3355 * Test/test.cxx now accepts a filename as first argument.
3356 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3357 * python/testSuite.py changed to integrate test on above files.
3359 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3360 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3361 the vr was also RET.
3362 * python/testSuite.py more tests added.
3364 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3365 * python/testSuite.py unittest test suite added (uses Data)
3366 * Data/* dcm and acr files for the test suite.
3367 * glib dependance removed from un*x version. We now use ISO C99
3368 7.18 Integer types (see stdint.h)
3369 - python/Makefile, src/Makefile src/gdcm.h
3370 * src/ when an explicit vr (like dicom files) suddenly poped an
3371 implicit element we use to mark the underlying DictEntry of the
3372 concerned ElValue with "Implicit". This strategy was damageable
3373 too the public or provite dictionaries, since some of their vr
3374 would be changed. Since Header::FindLength heavily relies on the
3375 detection by Header::FindVR of falsely explicit elements, I
3376 added an extra ImplicitVr member to ElValue (boolean).
3377 The rest of the changes we the necessary adaptations.
3379 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3380 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3382 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3384 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3385 * Adaptation for porting to VC++:
3387 o forced to use std namespace (for string to be known)
3388 o all class use __declspec export style on WIN32
3389 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3390 (in stdlib.h on Win32 but in std:: for gcc)
3391 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3392 variable GDCM_DICT_PATH.
3393 * src/gdcmHeader.cxx verbose comments made discrete.
3395 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3396 * python/gdcm.i: added a typemap that converts a C++ hashing table
3397 to native Python dictionary.
3398 * python/demo/test.py:
3399 - now uses the native dictionary for exploration of gdcmHeader.
3400 - takes an optional filename argument (the file to parse).
3401 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3402 PubElVals hashing table.
3403 * Dicts/dicomV3.dic removed error prone trailing spaces.
3405 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3406 * Python wrapping process moved away from src/Makefile to
3407 newly created python/Makefile (as well as gdcm.i)
3408 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3409 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3410 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3411 from the environement variable GDCM_DICT_PATH (when existing).
3412 * src/gdcmDict::GetTag bug fix.
3414 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3415 * Straightforward temporary fixes for swig to build the python wrappers.
3416 src/Makefile now has a python working entry [by working we mean
3417 that we can import the shadow classes without errors].
3419 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3420 * hashtest.cxx removed (since already in Test)
3421 * src/gdcmlib.h renamed to src/gdcm.h
3422 * src/dcm.i renamed to src/gdcm.i
3423 * src/Makefile prepared for python wrapping
3425 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3426 * src/gdcmHeader.cxx :
3427 - Parsing of header is now separated from loading of element values
3428 (see gdcmHeader::LoadElements).
3429 - general clean up of hopefully all file access (creation of
3430 ReadInt16 and ReadInt32)
3432 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3433 * src/gdcmHeader.cxx :
3434 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3436 - SetLgrElem renamed to SetLength
3437 - GetLgrElem renamed to GetLength
3438 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3439 * src/gdcmElValSet.cxx fixed both GetElValue methods
3440 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3441 due to IdoDude was cleaned out.
3443 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3444 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3445 concentrates on finding the value representation (when it exists).
3446 RecupLgr now only finds the element value length, and it avoids
3447 returning the unecessary skL (skipped length).
3448 Also, offsetCourant was simply removed (with taille_fich) since
3449 it was redundant with the File position internals (by using
3450 ftell and fseek). This also made skL (see above in RecupLgr) usage
3452 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3453 on the libido specificities which are handled through class
3455 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3458 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3459 * Truckload of changes. Parsing of header is barely functional
3460 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3462 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3463 * src/gdcmHeader.cxx many addons of low level methods
3465 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3466 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3467 and _IdDcmSWAP_LONG.
3469 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3470 * This corresponds to all the changes decided at the meeting of
3471 May 23 2002. Needless to say we are running late...