1 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
4 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
5 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
6 to exported to the environement (see gdcmPython/testSuite.py
8 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
9 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
10 ElValue class renamed to gdcmElValue for obvious consistency reasons.
11 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
12 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
14 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
15 * gdcmPython/__init__.py doesn't crash anymore when running in
16 in InstallMode or PreInstallMode but with an environement given
17 value of GDCM_DICT_PATH.
18 * src/gdcmDictSet.[cxx/h] coding style.
20 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
22 * src/gdcm.h general comments moved to TODO, and README
23 * src/gdcm.h should now be seen as a user commodity (including it
24 should suffice to fully use gdcm). It is nowhere including within
25 any of the kernel files src/*.cxx and src/*.h.
27 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
29 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
31 * src/gdcm*.cxx only include their corresponding include file
32 (as opposed to gdcm.h)
33 * gdcmPython/gdcm.i changed accordingly
34 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
35 the autogen.sh generated "make snapshot" command to work.
36 * autogen.sh removed history related references to crea package.
38 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * distutilsSwigCPlusPlus.py work around some swig portability
42 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
43 * Eventually, python/gdcmPython was renamed to gdcmPython. This
44 was done in a last ditch attempt to get setup.py _really_
45 operationnal. The python/gdcmPython layaout add the advantage
46 of hidding away the python related distutils specific files
47 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
48 Alas, the src directory was out of scope (i.e. it's relative
49 position to setup.py was ../src) which made things impossible to
50 handle (see previous version of python/setup.py). Crossing fingers...
52 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * python/setup.py now works on Un*x. (harder than I thougth)
54 * python/distutilsSwigCPlusPlus.py can now have include files
55 among the list of sources.
57 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
59 * modifications in MSVC projects
61 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
62 * As stated by the first lines of Test/ExceptionAndPython/README, it
63 looks like we can move back to original usage of exception within
64 src/gdcm* and hence remove the errno stuff that was introduced
65 as a quick and dirty fixture of this problem (added to the TODO).
66 * Doc/Doxyfile configuration file for Doxygen and corresponding
67 README file for usage added.
68 * Test/testWrite.cxx added. This new test comes from a split of
69 test.cxx that is now reverted to its original purpous i.e.
70 testing the proper parsing of a Dicom related file.
71 testWrite.cxx concentrates on testing the IO part of gdcm.
72 * Test/bug1.cxx (containing a bug on WIn32) added.
73 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
74 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
75 whose purpose is to publish the content of the TagNames of the
76 Dicom public dictionnary were not accessible without an
77 instance of class gdcmHeader.
78 - those methods are now static methods of gdcmDictSet and hence
79 require no instances at all to be invocated.
80 - within gdcmDictSet this change required to change some method
81 to class methods (i.e. are now static) among which SetDictPath
82 (renamed to BuildDictPath) and LoadDefaultPubDict.
83 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
84 the above changes by calling the new method classes of gdcmDictSet.
85 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
86 the above to be effective.
87 * python/gdcmPython: in order to wrap properly the above changes
88 for Python, swig version now needs to be > 1.3.17.
89 * python/gdcmPython/Makefile fixed to adapt itself to new
90 configure/make shema introduced by Johan Montagnat (thanks for the
91 contribution). Alas this Makefile cannot be turned into a proper
92 Makefile.am without some heavy changes in the configure.in
93 (for python dectection).
94 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
95 now avoids publishing the empty entries.
97 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * python/setup.py : bug fix concerning install under windows
100 * gdcm.dsw : bug fix concerning path for libraries for python !!!
102 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * Dicts/dicomV3.dic : remove double spaces !!!
104 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
105 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
108 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
110 method. Doxygenation.
111 * src/gdcm.h clean up of JPR spurious comments.
113 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * python/distutilsSwigCPlusPlus.py now properly collects the
115 shadow classes generated by "swig -c++" (gdcm.py in our case)
116 when using "python setup.py install".
117 * python/gdcmPython/__init__.py imports gdcm.py and only manually
118 reexports the working classes.
119 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
120 by the classical C errno scheme. This is to prevent an obscure
121 behavior of the python wrappers when importing wxPython.wx prior
122 to gdcmPython (which ended up in an abort call). An illustration
123 of this oddity can be found in the Test/ExceptionAndPython
124 subdir (see the README file). This problem probably due to
125 an combination of g++ and dynamic loading.
126 * added Test/ExceptionAndPython (see above)
128 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 * Changed the layout of the python part to avoid bloating main
130 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
131 i.e. the distutils arsenal. All the python related stuff is
132 again in a python subdir, but the package itself is now in
134 * setup.py was cleaned up:
135 - pythonIncludePath removed
136 - python setup.py bdist target is now functional.
137 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
138 collision with other packages). gdcmPython/demo/*.py changed
140 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
141 * python subdir moved to gdcmPython (preparation of distutils packaging).
142 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
143 distutils installer is operational.
144 * - gdcmPython/__init__.py now properly loads the swig generated
145 shadow classes (from gdcm.py).
146 - gdcmPython/demo/*.py changed to import the package gdcmPython
147 instead of gdcmPython/demo/load.py.
148 - gdcmPython/testSuite.py changed to import the package gdcmPython.
151 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
152 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
153 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
154 entries within the associated public Dicom dictionary resp. the same
155 information but sorted by the fourth field (PAT, IMG, DIR) of the
157 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
158 are now in the "???" group.
159 - python/gdcm.i changed accordingly,
160 - python/demo/printGroupedPublicDict.py added, that gives an example
161 of the above new functionalities in Python.
163 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
164 * src/gdcm.h, gdcmHeader.cxx:
165 - historic references to glib's g_malloc and g_free (#defined)
166 were definitively removed.
167 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
168 * src/gdcmElValSet.cxx:
169 - GetElement(guint32, guint32) renamed to GetElementByNumber.
170 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
171 - GetElValue(string) renamed to GetElValueByName.
172 - Added GetElementByName(string).
173 * src/gdcmHeader.cxx: added
174 - GetPubElValRepByNumber(guint16, guint16)
175 - GetPubElValRepByName(string)
176 - GetShaElValRepByNumber(guint16, guint16)
177 - GetShaElValRepByName(string)
178 - GetShaElValByNumber(guint16, guint16)
179 - GetShaElValRepByName(string)
180 - GetElValRepByNumber(guint16, guint16)
181 - GetElValRepByName(string)
182 - GetElValByNumber(guint16, guint16)
183 - GetElValRepByName(string)
184 * Doc/requirements.txt added.
186 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * Test/Makefile building now depends on the one of libgdcm.so
188 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
189 pixel data) aware which enables finding the address (offset) of
190 the pixel data of JPEG encoded DICOM files. This leaves only a single
191 file in the testSuite whose pixel data address (offset) is unknown.
192 * python/testSuite.py changed accordingly.
194 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
195 * VC++ has some strong limitations when working with the STL, as stated
196 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
197 "Also note that some STL containers (map, set, queue, list, deque)
198 cannot be exported. [...]
199 Some STL classes contain nested classes. These classes can not
201 This is caused by a designed limitation that once a template
202 class is instantiated, it can not be re-instantiated and
204 Since our usage of map<> is ubiquitous in gdcm, this "designed
205 limitation" of VC++ is a pitfall.
206 Hence the Python wrappers of gdcm cannot be incrementally linked
207 against the c++ dynamic library. The dirty but only workaround is
208 to forget about incremental link of dynamic libraries and to generate
209 the Python wrappers library with the inclusions of the underlying C++
211 The following modifications concern this matter on Win32/VC++:
212 - wrapping python correct with standalone wrapped dll (don't use separate
213 dll under windows !!!!)
214 - python21_d debug mode enabled (ask Frog how to use it :-)
215 - NO problem with having an STL member of class for example string in C++
216 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
217 - Python test of dcmlib in Python is ok under windows on a large set
219 * removed glib references
220 * typedef's inserted in gdcm.i for correct swig type management
222 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
223 * python/demo/*.py load.py extracted from test.py. Added explore.py
224 that only displays required tags and testAll.py that parses all
225 the files of the testsuite without using unittest.
226 * python/testSuite.py other additional test on new files added.
227 * Data/* new test files added accordingly to the testSuite.
228 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
229 the vr in the file differs from the one of the dictionary.
231 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
232 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
233 values, but limits itself to values which are below a user specified
234 size (by default 1024 bytes).
235 * python/gdcm.i : elements not loaded (because their size is above the
236 user specified treshold) are exported with their TagKey as key of the
237 python dictionary. This enables the testsuite to make some checks
238 on the unloaded elements (since we have their offset and size).
239 * python/testSuite.py
240 - now tests for the existence and proper value of the pixel data
241 - two new examples added.
242 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
244 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
245 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
246 aware. See the strategy comments in gdcmHeader::FindeLength().
247 * Test/test.cxx now accepts a filename as first argument.
248 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
249 * python/testSuite.py changed to integrate test on above files.
251 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * Dicts/dicomV3.dic removed all the trailing (RET) when the
254 * python/testSuite.py more tests added.
256 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * python/testSuite.py unittest test suite added (uses Data)
258 * Data/* dcm and acr files for the test suite.
259 * glib dependance removed from un*x version. We now use ISO C99
260 7.18 Integer types (see stdint.h)
261 - python/Makefile, src/Makefile src/gdcm.h
262 * src/ when an explicit vr (like dicom files) suddenly poped an
263 implicit element we use to mark the underlying DictEntry of the
264 concerned ElValue with "Implicit". This strategy was damageable
265 too the public or provite dictionaries, since some of their vr
266 would be changed. Since Header::FindLength heavily relies on the
267 detection by Header::FindVR of falsely explicit elements, I
268 added an extra ImplicitVr member to ElValue (boolean).
269 The rest of the changes we the necessary adaptations.
271 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
272 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
274 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
276 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * Adaptation for porting to VC++:
279 o forced to use std namespace (for string to be known)
280 o all class use __declspec export style on WIN32
281 - src/gdcmUtil.cxx new Exit method that wraps the exit call
282 (in stdlib.h on Win32 but in std:: for gcc)
283 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
284 variable GDCM_DICT_PATH.
285 * src/gdcmHeader.cxx verbose comments made discrete.
287 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * python/gdcm.i: added a typemap that converts a C++ hashing table
289 to native Python dictionary.
290 * python/demo/test.py:
291 - now uses the native dictionary for exploration of gdcmHeader.
292 - takes an optional filename argument (the file to parse).
293 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
294 PubElVals hashing table.
295 * Dicts/dicomV3.dic removed error prone trailing spaces.
297 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * Python wrapping process moved away from src/Makefile to
299 newly created python/Makefile (as well as gdcm.i)
300 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
301 * src/gdcmHeader::FindLength only looks for current vr when necessary.
302 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
303 from the environement variable GDCM_DICT_PATH (when existing).
304 * src/gdcmDict::GetTag bug fix.
306 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * Straightforward temporary fixes for swig to build the python wrappers.
308 src/Makefile now has a python working entry [by working we mean
309 that we can import de shadow classes without errors].
311 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * hashtest.cxx removed (since allready in Test)
313 * src/gdcmlib.h renamed to src/gdcm.h
314 * src/dcm.i renamed to src/gdcm.i
315 * src/Makefile prepared for python wrapping
317 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * src/gdcmHeader.cxx :
319 - Parsing of header is now separated from loading of element values
320 (see gdcmHeader::LoadElements).
321 - general clean up of hopefully all file access (creation of
322 ReadInt16 and ReadInt32)
324 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * src/gdcmHeader.cxx :
326 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
328 - SetLgrElem renamed to SetLength
329 - GetLgrElem renamed to GetLength
330 - ~gdcmHeader() made virtual to pesky warning messages at compile.
331 * src/gdcmElValSet.cxx fixed both GetElValue methods
332 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
333 due to IdoDude was cleaned out.
335 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
336 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
337 concentrates on finding the value representation (when it exists).
338 RecupLgr now only finds the element value length, and it avoids
339 returning the unecessary skL (skipped length).
340 Also, offsetCourant was simply removed (with taille_fich) since
341 it was redundant with the File position internals (by using
342 ftell and fseek). This also made skL (see above in RecupLgr) usage
344 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
345 on the libido specificities which are handled through class
347 * Test/implicit_vr.dcm dicom v3 in implicit value representation
350 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * Truckload of changes. Parsing of header is barely functional
352 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
354 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * src/gdcmHeader.cxx many addons of low level methods
357 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
358 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
361 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * This corresponds to all the changes decided at the meeting of
363 May 23 2002. Needless to say we are running late...