1 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
4 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
7 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
9 ValEntry, BinEntry, SeqEntry creation or replace
11 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
13 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
15 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
16 when specifying the VR
17 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
18 * src/gdcmDocEntry.cxx : amelioration of print
20 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
21 * ADD : Add the method Util::IsCurrentProcessorBigEndian
22 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
23 * ADD Method Document::ComputeGroupLength
24 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
25 in order to allow further VR modification by user
26 * REM : removal of once-called method File::WriteBase
27 integration of its code in formerly one-line method File::Write
29 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
31 replace the different values "??", "Unkn", "Unknown".
32 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
33 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
34 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
35 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
37 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
40 * Set the gdcm::Base class to some Printable classes
42 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmFile.[h|cxx] : add the Print method
44 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
45 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
46 * src/gdcmDocument.h : remove the PrintLevel informations
47 * Example/PrintFile.cxx : use the new gdcm::File::Print
49 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
51 problems when compiling with the python wrapping
53 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
55 writting in ImplicitVR
57 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
58 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
59 JPEG decompression, especially when dicom frames are split into several
60 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
61 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
63 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmHeader.cxx : change the initialisation of default header.
65 Now, this header is readable by gdm, e-film, DicomWorks
67 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
69 Rename Decompressed to Raw
70 * Use the API changes in gdcm::File.
71 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
74 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
76 each added entry in the header. Replace the 'Planes' field by the 'Number
79 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
81 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
83 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
85 At this time, this image isn't readable by e-film... waiting JPR help to
88 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
90 DocEntry. Now use methods of the Document !
92 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * Test/ShowDicomSeq.cxx : bug fix
95 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
97 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
98 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
99 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
101 * Test/TestCopyRescaleDicom.cxx : remove unused variable
102 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
103 containing found sequences
105 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
108 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
109 Some fields in BinEntry must be copied to not seg fault when making the :
110 gdcm::File *copy = new gdcm::File( copyH );
111 and tests are now made on good variables
113 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
115 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
117 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
118 * Add vtkGdcmWriter example and test
120 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * Test/TestUtil.cxx : reformat the source code
122 * vtk/vtkGdcmReader.cxx : remove and change prints
123 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
125 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
126 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
128 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
130 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
132 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
133 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
134 by an eof to prevent all bad read of the file... and in this case, the
137 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * Example/Volume2Dicom.cxx : comment unused variables
139 * Test/PrintDicomDir.cxx : comment unused variables
140 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
141 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
142 method that is redondant with AddEntry.
143 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
146 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * Bug fix due my last commit (compilation under Windows).
148 * Example/Volume2Dicom : bug fix in the file and reformatting source code
149 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
151 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
153 - Remove printf / sprintf
154 - include iostream AFTER gdcm so we don't get warnings
155 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
157 - Also remove tons of include from header files, hopefully this should
158 speeup the compilation time, since it was becoming a dog slow.
159 - Remove gdcm.h as it include way too many files and slow down compilation
160 (plus it is not up to date)
161 - remove 'using namespace std' this is BAD !
163 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * Remove memory leaks on the DicomDir
165 * Remove some useless datas in DicomDirObject
166 * Add usefull methods in SQItem, to be complient withe the ElementSet
168 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
171 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
173 future, with convertion)
174 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
175 and ImageDataSize values. Remove the method to get the PixelReadConverter
176 from the output of the class
178 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
181 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
183 and vtkErrorMacro use.
184 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
186 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
187 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
189 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
190 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
191 The string leaves only in the fonction. So when we make a .c_str(), we
192 get the pointeur on the first element, element that will be destroyed
193 immediately after thee instruction.
194 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
195 file has been opened : the test must be made on the content of the
196 pointer and not directly on the pointer !
199 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
201 the python part recompiles
203 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
205 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
206 X session is killed (for my computer... it seems to not be identic on
209 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
211 avoid problems (otherwise, the difference test between the visible image
212 and the reference is incorrect. If the reference is greater than the
213 screen resolution, it's produce errors).
214 Can be used for only one image. Can be used with a visible flag.
215 * vtk/vtkGdcmReader.cxx : remove commented codes.
216 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
217 under windows at compilation
218 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
220 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
222 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
224 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
225 tests on the image size X, Y, Z
227 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
228 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
229 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
230 between the class name and the file name
232 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/ : fix compilation warnings for the Write method (2 different
234 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
235 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
236 variable... create a static method in gdcm::Document to access to
237 this variable content.
239 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
241 file, to be accessed by other files (like gdcmFile). Remove commented
242 code. Move the change of the header to the gdcmFile, using the
244 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
245 To be sure of that (and simplify calls), the Write of the header now
246 gets a file name and not a file pointer (std::ifstream).
247 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
248 DocEntryArchive. Remove all open of the written file
250 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
251 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
253 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
255 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
257 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
258 some corresponding methods. Write correctly the file and check before
260 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
261 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
262 is now on RGB datas (as before my last commit
263 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
265 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
267 Add a print information of the type of the entry
268 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
269 It was in the gdcmFile, and all write have been regrouped
270 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
271 Write correctly all dicom files (in decompressed mode only at this time)
272 * Test/ : test on files are now made using Raw datas and not color datas if
274 * Example/PrintFile.cxx : add more printings
276 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
277 * Amelioration of code, remove some code copy. For the loading of
278 BinEntry (in gdcmDocument), add the test to verify if the file is already
281 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
283 remove a DocEntry in the header (push an empty DocEntry)
284 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
285 lines. Bug fix in the initialization of the PixelConvert and the
287 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
288 use in TestCopyDicom (now this test can run under windows... but fails)
289 * Test/TestCopyDicom.cxx : amelioration of the test :
290 - test the pixels written
291 - add test points to quickly find where is the error
292 - can set a file name input and output in arguments
293 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
294 amelioration of the test output
296 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
297 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
298 all replaced DocEntry's
299 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
300 Now, each needed DocEntry to modify is duplicated, modified and inserted
301 to the header using DocEntryArchive. Thus, after save, we can restore the
302 header initial state.
304 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
305 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
307 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
309 correct to copy it. The DictEntry is specified at the DocEntry creation,
310 then, it musn't change in the time.
311 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
312 header correctly. At this time, the change is only made for the first
313 level of the Document. In the future, it might consider sequences.
314 The change is made by replacing a DocEntry by an other that is created
315 outside the class. The old value is kept. When we restore the header
316 status, the added DocEntry is deleted and replaced by the old value.
317 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
318 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
319 set the write type to explicit VR, implicit VR or ACR. Add methods to set
320 the write mode to native, decompressed or RGB (but not used at this time)
322 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
323 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
324 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
326 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
327 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
328 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
330 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
331 set because already copied when copying the BinEntry's of the header
332 * Test/TestAllReadCompareDicom.cxx : remove warnings
334 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
335 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
336 Two problems appear when doing it :
337 - with the gdcmFile : when the GetImageData method is called, the pixels
338 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
339 datas (pixels). And each structure destruct the datas when it's
340 destructed. So we have two destructions for the same datas. To solve it,
341 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
342 datas or not. If it doesn't own datas, then they will not destroyed by
344 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
345 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
346 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
347 create a double destruction of the same DocEntry's. So, to solve it,
348 the TagHT is simply cleared and the DicomDir* elements are destroyed.
349 * TODO : add an entry concerning memory leaks in the DicomDir
351 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
352 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
353 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
356 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
358 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
359 after it have been deleted
361 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * FIX: src/* fix the doxygen warnings.
363 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
364 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
365 was erroneously defined with a size of 15 instead of 16. [many thanks
366 to Jean Michel Rouet for pointing out this bug].
368 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
369 1. Finish merging JMR patch for writting DICOM from scratch
370 2. Fix -hopefully- bug with MONOCHROME and space vs null character
371 3. Use const ref when possible
372 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
373 5. A few more comments
374 6. CreateUniqueUID can now be called without parameter"
376 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * ENH: Slightly bigger patch:
378 1. Getting toward full integration of JMR patch for writting dicom from scratch
379 2. Update Test to test part of this patch: CreateUniqueUID
380 3. File was not close properly in gdcmDict
381 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
382 5. Use of const ref instead of copy (speed issue)
383 6. Remove temporary (duplicate) string in TranslateToKey
384 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
385 8. Do not repeat virtual in subclasses
386 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
388 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 * Apply first patch toward better string comparison when dealing with broken
390 DICOM files. Essentially the string could be padded with a space instead
391 of a null character as defined by standard
393 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
394 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
395 because never used... and in the same time, that's remove some memory leaks
397 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
398 * src/gdcmFile.cxx : now delete the PixelConvert instance.
399 * In examples and tests : change the type of image data variables from void*
400 to uint8_t*. Remmove all delete on image data variables
402 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
403 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
404 Verify the file pointer value before open the file, and if it's not null,
405 a verbose message is generated.
406 Close correctly the file when the file isn't considered dicom-like. The
407 correctly close is a call to CloseFile.
408 When closing the file pointer, test if its not null to close the file.
409 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
410 file. For an uncompressed image, the copied datas correspond in the least
411 case to the image size (calculated) or the image size specified in the
412 header. A verbose is generated if these two size mismatch
414 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
415 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
416 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
417 break under windows (with msvc6 compilation).
419 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
420 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
421 compiling with MSVC6)
423 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
424 * Bugs fix for the Windows build with VC6
425 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
426 needed (only for projects required VTK). If the VTK is included in all
427 projects, there is conflicts with the jpeg lib of vtk when compiling the
428 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
429 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
430 when compiling the gdcm_wrap.cxx file (created by the compilation of the
432 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
433 (like it's already made for the cout use). Otherwise, conflict with the
436 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
439 - comments on the DicomDir::Method related usage added.
440 - now that we use the namespace gdcm, a lot of internal classes do
441 NOT need to be wrapped anymore.
442 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
443 DicomDir::Method) new example added.
445 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
446 * Improve string manipulation. I now inforce the notion of 'DicomString'
447 A DicomString can contain as many \0 as they want
448 and it is *always* of even length.
449 We only support odd length for very rare case.
450 And in the near future this should be removed.
452 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
453 * /binary_write/ gdcm source. Now even on big endian we are writting
454 little endian. This should -heopfully- fix some tests
456 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
457 * Now the dictionary is compiled into gdcm lib. This is a default
458 behavior, thus any dic file specified is picked before failback to
459 the one comiled into lib
461 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
462 * Change internals for gdcmDict. Don't use any 'new' any more.
463 This should definitely solve any leak problem, and we should be
464 as fast as before, as long as don't modify too much the dictionary.
466 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
467 * STYLE: ivars should start with a capital letter.
468 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
469 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
471 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
473 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
474 new 2004 dictionaries added (thanks to JPR).
475 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
476 * CLEANUP_ROUND (15) for gdcmPixelConvert
477 - RLEFrame::NumberFragments is now of type unsigned int
478 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
479 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
482 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Initial work in gathering all transfer syntax accessors. clearly
484 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
485 ivars, but only one transfersyntax (class) ivar with equivalent method on
488 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
489 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
490 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
491 discussed (plus I didn't like having a 2000 lines patch not commited)
493 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
495 * CLEANUP_ROUND (14) for gdcmPixelConvert
496 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
497 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
498 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
500 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
501 anymore and hence avoids storing a copy of PixelConvert::Decompressed
502 into File::Pixel_Data.
504 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
506 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
507 * CLEANUP_ROUND (13) for gdcmPixelConvert
508 Substituted File::ParsePixelData() with PixelConvert::Print() new
510 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
511 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
512 method to those classes.
513 - src/gdcmFile.[cxx|h]:
514 -- Added a ::Print() method.
515 -- PixelConverter is now a reference instead of a member.
516 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
517 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
519 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
521 collaboration diagram and inheritance diagram should be generated with
523 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
524 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
525 pointlessly wrapped (see
526 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
527 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
528 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
529 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
530 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
531 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
532 -- File::Initialise: PixelConverter setup moved away to
533 PixelConverter::GrabInformationsFromHeader()
534 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
535 interpretation moved away to PixelConverter::BuildRGBImage()
537 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
538 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
539 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
541 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
542 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
543 displayed on Win32 when a brutal abort() occurs (because of uncatched
544 exception). See TODO new entry of this commit for more on this.
545 * TODO added new entry.
546 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
547 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
548 - HandleColor is no longer called from gdcmFile.cxx
549 - gdcmPixelConvert.cxx clean up on method arguments and internal
550 variable names for semantical coherence.
552 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
553 * Finished lossless transition, not only do we now read all lossless jpeg
554 images, without the need of the Cornwell lib, but we do read them properly now
555 * To reduce code (well to avoid code duplication), I defined a common place
556 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
557 redefine symbols. This is not prefect but this the best solution I found for a
558 compilation time jpeg option.
560 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
561 * Update jpeg ijg lib to support lossless jpeg implementation
562 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
564 * Also added a special copyright for dcmtk since we use their bugfixes.
567 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
568 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
569 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
570 matters, as stated in warning note at begining of %include section).
571 * src/gdcmDicomDir*.[cxx|h]: coding style
572 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
573 * src/gdcmJpeg8.cxx: doxygen fix.
574 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
575 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
576 from File:: to PixelConvert::.
578 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
579 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
580 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
581 - more code moved away from File:: to PixelConvert::
582 - fat setup of PixelConverter set in place in File::Initialise.
584 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
585 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
586 namespace at the file system level. So now you should convert your examples
588 gdcmHeader -> gdcm::Header
589 It would be nice if people keep in mind to no open the namespace, since it
590 allows compilation on broken plateform which were defining common symbol in
591 the standart namespace (like LP, Unknown ...)
593 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
595 The JPEG fragments are now parsed at the same stage than the RLE
596 information. All code related to JPEG is now in gdcmPixelConvert:
597 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
598 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
599 export a gdcmFile:: method. Those are simply global functions
600 (for the time being this is better than having them attach to
601 either gdcmFile:: or gdcmPixelConvert::).
602 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
603 and stores the result in a gdcmJPEGFragmentsInfo.
604 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
605 code (among other stuff) moved away from gdcmFile:; to
608 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
609 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
610 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
611 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
612 clean up of RLE related code.
613 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
614 - src/gdcmRLE.cxx removed
615 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
616 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
617 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
618 * CLEANUP_ROUND (9) for gdcmPixelConvert
619 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
620 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
621 away from gdcmFile:: to gdcmPixelConvert::.
623 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
624 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
625 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
626 This is because Parse7Fe0 used to parse the pixels to compute the
627 length. This task was passed over to FindDocEntryLengthOB() a long
628 time ago, EXCEPT I had forgotten the OW case...
629 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
630 we just recylce the code for parsing RLE fragments and computing
632 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
633 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
634 with the retired Parse7Fe0().
635 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
636 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
638 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
640 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
641 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
642 - src/CMakeLists.txt: alphabetic order reodering + new entries.
643 * CLEANUP_ROUND (4) for gdcmPixelConvert
644 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
645 to return an unused length.
647 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
648 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
649 this should be cleanner from the plane view. The iostream are erally a pain
650 to use to do simple stuff.
652 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
653 * Redo the compilation of the ijg jpeg library. Now only one source is
654 necesseray. No need to rename file by hand what so ever. CMake handle the
655 copying of the file within different directory, configure header file to
656 modify some symbol. The only addition made to ijg wasd a mangle table so
657 that symbol are different wether we are within 8bits or 12bits.
659 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * Added documentation of vtkgdcmReader on Website:
661 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
662 with it's binary name).
663 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
664 the Website to be more complete.
665 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
666 doxygenated documentation.
667 - Doc/DoxyVtkGdcmReaderExamples.txt added
668 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
669 DoxyVtkGdmReaderExamples.html )
670 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
671 * CLEANUP_ROUND (3) for gdcmPixelConvert
672 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
674 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
675 * CLEANUP_ROUND (2) for gdcmPixelConvert
676 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
678 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * CLEANUP_ROUND for gdcmPixelConvert:
680 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
681 - src/gdcmPixelStuff[h|cxx] removed
682 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
683 - src/CMakeLists.txt changed accordingly
685 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
686 gdcmVersion.py moved to newly created ATTIC related
687 gdcmPython/SetupOldies/ directory.
688 * Autotools clean up:
689 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
690 - autogen.sh configure.in acinclude.m4 python.m4 removed
692 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * src/*.cxx *.h Reference to License.htm fixed to License.html.
694 * Doc/CMakeLists.txt, doxygen.config.in: fix.
695 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
697 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
698 * TODO updated with Mathieu suggestions. I proposed a template for
699 describing TODO entries and used it for new entries.
700 * Added Doc/Website/CodingStyle.html, Developpers.html,
701 DeveloppersPython.html, GdcmDataCvs.html and
702 DownloadVersion0_1.html, DownloadVersion0_3.html.
703 * Some Doc/*.txt Doxygen files (which do not really concern the
704 documentation itself, but the website) moved to html and
705 placed in directory Doc/Website:
706 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
707 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
708 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
709 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
710 * CMakeLists.txt changed accordingly.
711 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
712 DeveloppersPython.html
713 * INSTALL nows refers to Doc/Website/Installation.html
715 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
716 * Added Doc/Website directory, that contains a first raw version
719 2004-09-23 Jean-Pierre Roux
720 * FIX In order not to be poluted any longer by casting problems,
721 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
722 we can now delete[] it safely
723 * VoidArea is now called BinArea (less confusing name),
724 and all the methods called ...VoidArea... are now ... BinArea...
725 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
727 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
729 clear) TagHT, which is an inherited member of gdcmElementSet. It is
730 up to the destructor of gdcmElementSet to clean up TagHt and it's
733 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * Test/CMakeLists.txt: update to follow gdcmData renamings.
735 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
737 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
738 * ENH: added some utility method that builds a flat dictionnary
739 holding all the Dicom entries contained in the recursive structure
740 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
742 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
743 BuildFlatHashTable() that build a flat dictionary.
744 - src/gdcmElementSet.h: added a new private GetTag() accessor.
745 gdcmDocument is now a friend of gdcmElementSet.
746 - src/gdcmElementSet.cxx: clean up.
747 - Example/FlatHashTablePrint.cxx added.
748 - Example/CmakeLists.txt changed accordingly
750 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
752 moved away from gdcmDocEntrySet (since this class is an abstract class
753 acting like an interface). SQDepthLevel and BaseTagKey are now
755 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
756 and associated accessors. Doxygenation of the class.
757 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
759 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
760 Use SQDepthLevel accessor instead. ::Print() adapted.
761 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
762 - src/gdcmDocument.cxx changed accordingly.
764 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
766 - The following is the doxygen comment of the typedef declaration
767 of gdcmagKey in src/gdcmCommon.h:
768 gdcmTagKey is made to old an "universal" (as in URL, Universal
769 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
770 A dicom tag allways has a group and an element, but a set of tags
771 embeded in various (optionally nested) sequences and sharing
772 the same group and element all share the same (group, element)
773 "identifier". Hence the (group, element) cannot be used as an
774 identifier (in gdcm we shall refer to a "TagKey") of a tag.
775 In order to construct a proper tag identifier (i.e. a key) we
776 consider the following definition of a TagKey:
777 - let Group, Element be the string representation of the
778 group and element dicom tag members,
779 - let ItemNumber be the string representation of the integer
780 index of the considered item number of a sequence,
781 Let the key of a tag embeded in a sequence, noted SeqTag, be
783 /ItemNumber#Group|Element
784 where "/", "#" and "|" are characters acting as separators.
785 Then the general form of a gdcmTagKey is given by:
786 Group|Element<SeqTag>
787 where <SeqTag> means NO or many instances of SeqTag.
788 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
791 but the gdcmTagKey of a tag "embeded" is the first item of
792 a sequence, itself nested in the third item of a sequence is the
794 0004|1220/2#0008|0082/0#0008|0090
795 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
796 order to hold the new sequence compatible key. Previously, the
797 GetKey() method would look in the underlying gdcmDictEntry.
798 - src/gdcmDocEntry.cxx:
799 -- constructor now copies the underlying DictEntry key, in the local
801 -- ::Print: displays the member Key, instead of the (group, element).
802 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
803 - src/gdcmDocEntrySet.h:xi
804 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
805 -- now has a new BaseTagKey member.
807 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
808 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
810 This poses the problem with the semantics of the following lines
811 LoadEntryVoidArea(0x0028,0x1201); // R LUT
812 LoadEntryVoidArea(0x0028,0x1202); // G LUT
813 LoadEntryVoidArea(0x0028,0x1203); // B LUT
814 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
815 to the long FIXME note for what the problem is. Nevertheless in
816 order to get things working the dicom dictionary was altered !
817 Please fix things urgently...
818 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
819 information), see above note on moving the member VoidArea. Nevertheless
820 the following entries previously correctly set as US are now inproperly
822 0028 1201 OW IMG Red Palette Color Lookup Table Data
823 0028 1202 OW IMG Green Palette Color Lookup Table Data
824 0028 1203 OW IMG Blue Palette Color Lookup Table Data
825 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
826 of gdcmDocEntry moved to gdcmSeqEntry.
827 * src/gdcmSeqEntry.cxx: STYLE.
829 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
830 * Test/TestAllEntryVerify.cxx minor fix and added comments.
832 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * gdcmPython/testSuite.py: all the test suite in python is now moved
834 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
835 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
836 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
838 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
840 to avoid inclusion recursion until STL is reached.
841 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
842 mecanism. errno.h is not included in gdcm anymore.
843 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
844 (gdcmFormatError now inherits from gdcmFormatUnexpected).
846 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
847 gdcmData/TestAllEntryVerifyReference.txt
848 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
849 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
850 exception_on_error parameter.
851 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
852 - vtk/vtkGdcmReader.cxx changed accordingly,
853 - Example/*.cxx and Test/*.cxx changed accordingly.
855 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
857 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
858 enable_sequences removed from gdcmHeader constructor and dependencies.
859 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
860 * gdcmPython/demo/PrintHeader.py: dummy fix.
861 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
862 skip_shadow removed from gdcmHeader constructor and dependencies.
863 * Example/*.cxx and Test/*.cxx changed accordingly.
865 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
867 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
869 2004-07-21 Jean-Pierre Roux
870 * FIX Now, Parsing and Printing a DICOMDIR do work!
871 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
873 2004-07-20 Jean-Pierre Roux
874 * FIX Some brain damaged headers have Zero-Lenght fields
875 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
877 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
878 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
879 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
880 variable (instance of gdcmDebug) by a definition macro, and the instance
881 is now in static in the gdcmDebug class
882 * src/gdcmSQItem.h : (FIXME) remove an undefined method
883 * Test/PrintAllDocument.cxx : bug fix in the result of the test
885 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
886 * WARNING: ctest now depends more tightly on gdcmData. You should
887 check out gdcmData properly for things to run smoothly...
888 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
889 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
890 we need the pixels not be loaded in order to use the ValEntry
891 that displays position and size).
892 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
893 This is a C++ based equivalent of gdcmPython/testSuite.py that should
894 be deprecated. If you have any doubts about the advantages of a
895 modern scripting language (read Python) versus grass root C++ (i.e.
896 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
897 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
898 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
899 Anyhow, consider documenting the gdcmData images in
900 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
902 * Test/CMakeLists.txt:
903 - now uses TestAllEntryVerify.cxx
904 - specific comments on oldACR00001.ima (now renamed in gdcmData
905 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
906 gdcmData/TestAllEntryVerifyReference.txt
909 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * src/*.[h|cxx] : typedef clean up
911 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
912 - TagKey renamed to gdcmTagKey (for external usage)
913 - VRKey renamed to gdcmVRKey (for external usage)
914 - removal of typedef duplication.
915 - Removed all unecessary inline keyword from class inline definitions.
916 - Some method|function(void) declarations replaced with method|function().
917 * src/jpeg/libijg12/jdhuff12.c:
918 - printf polluting ctest removed.
919 - TAB removal for comminting
921 - TestAllReadCompareDicom.cxx: added a test that compares all the
922 images in gdcmDataImages.h with corresponding images in
923 gdcmData/BaselineDicom/. When baseline images are not present
924 this test creates them.
925 Note: we need to validate each reference image, but before that
926 I'd like to rename them with a more explicit name...
927 - CMakeLists.txt: changed accordingly.
928 * Example/*.cxx: examples now only include gdcm.h (as opposed to
929 including each header needed).
931 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * Test/*.cxx and Example/*.cxx: moved some examples away from the
933 test suite to the Example directory. Are concerned:
938 - TestWriteSimple.cxx
939 * Test/CMakeLists.txt: added some comments on reasons for black listing
940 image gdcmData/oldACR00001.ima
942 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * Test/CmakeList.txt: removed the following from black list (to be coherent
944 with removal from gdcmData):
945 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
946 - gdcm-MR-PHILIPS-16.dcm
948 Added the following because after last cvs update, they cause
949 ctest -R TestReadWriteReadCompare
951 - gdcm-MR-SIEMENS-16-1.acr
953 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
954 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
955 new comments in this file) we temporarily (sigh) move to a weaker
957 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
958 we don't need to black list the following images anymore:
959 - 8BitsUncompressedColor.dcm
961 - US-PAL-8-10x-echo.dcm
962 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
963 fixes and the beautified code ;-)
964 This fixes the bug introduced in version 1.42 (when beautifying)
965 that made the parsing of 8BitsRunLengthColor.dcm unproper.
966 Note: ctest was blind to this bug (this means we need to still
967 improve the test suite). The bug could be detected by using
968 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
970 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
971 and by displaying the (garbage) produced file temp.XDCM...
973 2004-06-29 Jean-Pierre Roux
974 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
975 - replace by uggly but working old code :-(
976 A lot of things should be OK again.
977 It's really urgent to have a test suite that *tests*,
978 to prevent Frog's beautifying sessions to break all the stuff
979 (twice, withing a fortnigh ...)
981 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
982 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
983 redundancy) to added Test/TestReadWriteReadCompare.cxx
984 * Test/CmakeList.txt: because the compare test of
985 Test/TestReadWriteReadCompare.cxx fails, the following images are
986 black listed: - 8BitsUncompressedColor.dcm
988 - US-PAL-8-10x-echo.dcm
989 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
990 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
991 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
992 and ad-hoc kludge. This kludge is now removed, and on encountering
993 such an image (OB field brain damaged) we set errno. Then in
994 ::FindDocLength() we "fix" the length as being ALL what remains
995 in the file (until EOF). We then proceed, hoping for the best...
996 This fixes a SegFault in ShowDicom when trying to write such an
998 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
999 (because TestWriteRead breaks on it, after a non conformal commit?).
1000 ctest now runs properly, except for MakeDicomDir (which was allways
1001 broken) and the Python related stuff (still not fixed).
1003 2004-06-24 Jean-Pierre Roux
1004 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1005 FIX : Test/TestReadWrite now iterates on all the file names
1006 (instead of infinite loop)
1007 ENH : Test/TestWriteRead now iterates on all the file names
1009 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1010 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1012 2004-06-24 Jean-Pierre Roux
1013 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1014 when SamplesPerPixel =3
1015 - now Write is no longer confused by
1016 'BitsAllocated = 12" and 'BitsStored=12"
1017 - "UN" value representation Elements are now written correctly
1018 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1019 ENH : - now gdcmHeader has its own Write methods
1020 (in order to split the job that has not to be done
1023 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1025 loop on the same image until memory went out.
1026 Note: this means we still have gobs of memory loss in PrintDocument
1027 * src/gdcmDocument.cxx: fixes problem on parsing on file
1028 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1030 2004-06-24 Jean-Pierre Roux
1031 FIX : Write - All the Sequences and Sequence Item are now written
1032 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1033 is added a the end, when necessary.
1034 - A lot of brain-damaged images, that were read correctly are
1035 now written correctly
1036 - length compatible BinEntry are now loaded correctly
1037 (even for odd groups)
1038 Note : only Explicit Value Representation was checked.
1039 (question : is implicit VR really necessary for gdcm ?)
1041 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * DEVELOPPER: added a proposition of coding style.
1043 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1046 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1047 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1048 Use the gdcmDocEntry::Print() and Write() instead.
1049 * src/gdcmDocument.cxx: bug fix.
1051 2004-06-22 Jean-Pierre Roux
1052 FIX : gdcmDocument.cxx
1053 - Now we do recognize the JpegLossLess format (there was a misstyping in
1054 code 'beautyfication' :-(
1055 - Now we automaticaticaly load the Luts, if any
1057 2004-06-22 Jean-Pierre Roux
1058 In order : to write Sequences, whatever their imbrication level,
1059 : to allow user to create his own Sequences
1060 a lot of modif where necessary (adding, moving, or virtualising methods)
1062 WARNING : save your own sources *before* cvs up !
1065 ADD virtual void Write(FILE *fp, FileType filetype);
1068 ADD virtual void Write(FILE *fp, FileType filetype);
1069 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1072 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1073 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1074 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1075 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1076 ADD std::string GetEntryByName(TagName name);
1077 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1079 std::string vr = "unkn",
1080 std::string fourth = "unkn",
1081 std::string name = "unkn");
1082 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1083 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1084 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1085 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1086 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1087 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1088 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1089 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1092 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1093 ADD virtual std::string GetEntryByName (TagName tagName);
1094 ADD virtual std::string GetEntryVRByName (TagName tagName);
1095 REM virtual bool Write(FILE *, FileType);
1096 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1097 FILE *_fp, FileType type);
1098 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1099 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1100 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1101 REM virtual std::string GetEntryByName (std::string tagName);
1102 REM virtual std::string GetEntryVRByName (std::string tagName);
1103 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1104 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1105 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1107 std::string vr = "unkn",
1108 std::string fourth = "unkn",
1109 std::string name = "unkn");
1110 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1111 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1112 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1113 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1116 ADD virtual void Write(FILE *fp, FileType filetype);
1119 ADD virtual void Write(FILE *fp,FileType filetype);
1122 ADD virtual void Write(FILE *fp, FileType filetype);
1123 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1124 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1125 REM std::string GetEntryByName(TagName name);
1128 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1130 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1132 The default constructor invoked by the line
1133 gdcmHeader *f1 = new gdcmHeader( header );
1134 was gdcmHeader::gdcmHeader(bool) instead of the expected
1135 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1136 Hence the parsing wasn't executed... See also below.
1137 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1138 as explicit constructor didn't do the trick to fix the above problem.
1139 Could anyone explain why ?
1140 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1141 properly calls gdcmValEntry::Print() (that was weed out from
1142 code related to gdcmBinEntry).
1144 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1145 * In order to fix memory leaks:
1146 - Test/TestWriteSimple.cxx: added cleaning of free store through
1148 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1149 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1150 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1151 (through the call to ::AddDicomDirMeta()) or the destructor
1152 would crash when deleting uninitialized ::metaElems].
1153 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1154 - src/gdcmDocument.cxx:
1155 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1156 from dynamic stores.
1157 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1158 was causing memory leaks.
1159 - src/gdcmSQItem.cxx:
1160 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1161 cleanly handled with polymophism: sorry but my milage is low).
1162 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1163 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1164 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1165 This avoids SegFaulting.
1166 - src/gdcmSQItem.h: coding style.
1168 - Test/TestWriteSimple still severely sucks. The output image content
1169 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1170 damaged when displayed with vtkgdcmViewer.
1171 - on memory leaks: TestWriteSimple leaks really less (see entry
1172 of 2004-06-18 in Changelog file for the call to valgrind).
1173 - on segfaults: ctest now passes all the tests but one (no more
1175 * Erroneous leading white fix:
1176 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1177 white[s] (as opposed to from >> xxx, that removes it [them].
1178 - src/gdcmTS.cxx: ditto.
1179 - gdcmPython/testSuite.py: dirty related kludge removed.
1180 * src/*: remaining references to gdcmParser removed.
1181 * src/*[cxx|h]: added copy[way]left header.
1184 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * In order to fix writing of dicom files:
1186 - Test/TestWriteSimple.cxx: a simpler example of writing.
1187 - Test/CMakeLists.txt changed accordingly.
1188 - src/gdcmDocument.cxx:
1189 -- The destructor now recursilvely removes potential sequences.
1190 -- Bug fix in ::IsJPEG2000()
1191 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1192 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1194 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1195 to only declared) and build on top of
1196 ::GetDocEntryByNumber(guint16, guint16).
1197 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1198 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1199 for usage in destructor and treatement of promotion in
1200 ::ReplaceOrCreateByNumber().
1201 - src/gdcmSQItem.cxx: destructor should better handle his job.
1202 Test/TestWriteSimple now runs (or at least it DOES something).
1203 * We can now start hutting memory links. A good starting point is:
1204 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1205 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1206 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1208 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * Valgrind note: after Mathieu Malaterre teached me how to read
1210 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1212 Using gcc, you can force the STL to use malloc and to free memory as
1213 soon as possible by globally disabling memory caching.
1214 With 3.2.2 and later, you should export the environment variable
1215 GLIBCPP_FORCE_NEW before running your program.
1216 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1217 simply vanish (it is still not clear to me, whether this means that
1218 STL std::string leaks or if valgrind believes it leaks...).
1219 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1220 running bin/gdcmTests makeDicomDir):
1221 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1222 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1224 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1225 SegFaulting (I drowned in DicomDir related code when trying to
1226 understand why the list is empty...).
1227 * src/gdcmDocument.h: first BSD license header try.
1228 * Doc/License.txt added.
1230 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * src/gdcmDocument.[h|cxx]:
1232 - Clean up of the Transfer related predicates. They are now all based
1233 on new method isGivenTransferSyntax, that (should) handle properly
1234 the padding problem.
1235 - general clean up, simplification, and coding style.
1236 - Specific clean up of Parse7FE0() (umproperly named actually).
1237 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1239 2004-06-14 Jean-Pierre Roux
1241 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1242 - fix the display of SQItem ordinal number
1243 - add the GetSQItemByOrdinalNumber method
1244 - remove some useless never written private methods
1246 2004-06-14 Jean-Pierre Roux
1248 - adding a constructor taking a gdcmDocEntry as an input param
1249 - ReplaceOrCreateByNumber now returns :
1250 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1251 a gdcmValEntry * if a string value is passed as a param
1253 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1254 according to the param type (no longer sets a gdcmDocEntry)
1255 - GetValEntryByNumber, GetBinEntryByNumber added
1256 - NewValEntryByNumber and NewBinEntryByNumber added
1258 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1260 - GetSQItemNumber and SetSQItemNumber added, to provide
1261 a (relative) Item identier inside a given Sequence
1262 \warning : some pb remaining around this number
1264 - AddEntry now takes the Item Number as a param
1266 - adding a constructor taking a gdcmDocEntry as an input param
1268 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Memory leak hunt with the following command:
1270 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1271 --show-reachable=yes gdcmTests PrintDocument
1272 It looks like many (all?) leaks are due to the STL (or a bad usage
1273 of the STL. The lines producing the leaks now have a comment with
1274 a "MEMORY LEAK" tag: you can retrieve them with
1275 grep "MEMORY LEAK" src/*
1276 Here are two typical examples which I can't help fixing:
1281 char * test = "babo";
1282 name = test; //// <--- valgrind detects 960 bytes lost in
1283 //// call to std::string::operator=(char const*)
1284 name.clear(); //// Doesn't help !
1292 std::cout << "Type a bunch of characters followed by RETURN: ";
1293 getline(std::cin, line); //// <--- valgrind dectects a loss
1294 //// of 1320 bytes in call to
1295 /// std::basic_istream<>& std::getline<>
1301 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * src/gdcmHeader.[cxx|h]:
1303 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1304 and related, moved away to gdcmDocument.
1305 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1306 the corresponding protected accessors of inherited class
1307 gdcmDocument, removed ! As a consequence gdcmFile had to be
1308 declared friend of class gdcmDocument (see below).
1309 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1310 - Clean up of undefined or unused methods.
1311 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1312 account the changes to gdcmHeader.h).
1313 * src/gdcmDocument.h:
1314 - gdcmFile is now a friend class (in order to take into account the
1315 changes to gdcmHeader.h).
1316 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1317 (see changes to gdcmHeader.h).
1318 - Accessors (reading on the form GetEntry*) are now public.
1319 - Clean up of undefined or unused methods.
1320 * src/gdcmDocument.cxx:
1321 - adaptation to changes to gdcmDocument.h
1322 - ::OpenFile now writes a verbose message when file cannot be opened.
1323 - some std::string properly set to VRKey
1324 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1325 references to gdcmDocument.
1326 * Test/TestFindTags.cxx: changed accordingly to above changes.
1327 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1328 cvs repository gdcmData.
1330 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1332 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1333 conflicts with gdcmValEntry::voidArea.
1334 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1335 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1336 Value representation between StringRepresentable and BinaryRepresentable.
1337 * src/gdcmDocument.cxx:
1338 - method ParseDES: proper indentation restored and usage of
1339 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1340 - method LoadDocEntry: the fingerprint left in the SetValue() of
1341 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1342 removed. Reverting to previous code segment with the proper
1343 dynamic_cast< gdcmValEntry* >.
1344 Note: this was (partially) breaking the python test suite
1345 (gdcmPython/testSuite.py) that made usage of the above
1346 fingerprint to check presence of "Pixel Data".
1347 * src/gdcmDocEntry.h: coding style.
1348 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1349 now taken into account.
1350 * gdcmPython/gdcm.i: adaptation to the new internal representation
1351 of gdcm (exit gdcmParser, hello gdcmDocument).
1352 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1354 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1355 anymore, but instead prints the loaded Python dictionary.
1356 * .... alas, the python testSuite is still broken.
1358 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1359 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1361 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1362 * src/gdcmUtil.h : export methods
1364 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1365 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1367 * Initial addition of automatic python testing
1368 * Initial addition of automatic image comparison
1370 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1371 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1372 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1374 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1375 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1376 * Test/ShowDicom.cxx : bug fix for msvc compilation
1377 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1379 2004-05-04 Jean-Pierre Roux
1380 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1381 new concepts (and new classes) :
1382 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1383 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1384 - Sequence Doc Entries (gdcmSeqEntries)
1385 a Sequence is composed of Items.
1386 Each item is a set of Doc Entries (this is recursive)
1387 The non uniqueness of the 'Dicom tag' is due to this recursivity
1388 (never taken into account)
1389 Our unability to add a new 'entry' in the header
1390 at the proper location (neither in the H-Table (map or multimap),
1391 nor in the Chained List is also due to this recursivity.
1392 Don't try, right now, to use/modify/compile these new sources :
1393 nothing is finished.
1394 We just commit all the stuff, 'as is', in order not to loose it.
1396 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1397 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1399 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1400 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1401 file prefix (SetFilePrefix)
1403 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1404 * Add a new test: ShowDicom, for now this is just the c++ version of
1405 checkRead.sh, later it will be able to compare the image read against a
1407 * Replace the DEBUG on the stack with a global entry in cmake interface:
1408 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1410 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1411 * Add an example subdir, with a real example on how to read + write a
1414 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1415 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1416 * Doc/CMakeLists.txt: the main page is now properly differentiated
1417 between the developper and user version.
1418 * Doc/doxygen.config.in: dropped search related obsolete flags
1419 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1421 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * DEVELOPPER: added some helpfull comments for compile/test/install
1425 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1427 src directory, now generated in the build dir.
1428 2. Tests as mentionned smarter
1430 4. Add a new method in gdcmDict that return the PubDict by name
1431 this is interesting for 3rd party lib like ITK,
1432 where we could set the institution name / patient name...
1434 * ENH: 1. Now the test suite is working for real
1435 2. All binaries are now output in the gdcm-bin directory
1436 (this was not true before)
1438 2004-04-28 Jean-Pierre Roux
1439 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1440 SeQuence indented printing of Dicom Header.
1441 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1442 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1443 Computation of SQDepthLevel is now part of gdcmHeader constructor
1444 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1445 tree-like structure of a Dicom Header.
1446 * FIX Test code cleaning
1448 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1449 * ENH: Adding automatic testing
1450 1. Need a DartConfig.cmake to submit to public
1451 2. Add a test driver gdcmTest.cxx
1452 3. gdcmTestMain, an helper for the main test driver gdcmTest
1453 4. Files in Test don't have a main anymore, this becomes interesting
1454 when we add more and more tests, thus dsw don't have to load
1456 * ENH: Adding a GDCM_DATA_ROOT for testing
1457 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1458 one file instead of seven + some small cleanup
1460 2004-04-22 Jean-Pierre Roux
1461 * ENH Minor changes to the Print() methods.
1462 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1463 Header printing. Example given with :
1464 > PrintHeader fileName 2 new
1465 (SQ based tree-like structure still to be done for the Header ...)
1467 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1468 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1469 1. I have added some unsigned where needed
1470 2. Some function parameter not used -> (void)
1471 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1472 4. g++ don't like character '\' in comment
1473 5. #define jpeg_create_decompress jCreaDecompress
1474 this really need to be fixed
1475 6. virtualize destructor of gdcmObject ... leakage
1476 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1477 this also really need to be fixed
1478 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1479 remove compression file
1480 (as we only do decompression, right ?)
1481 * ENH: Change malloc/calloc/free with c++ equivalent
1483 2004-04-21 Jean-Pierre Roux
1484 * FIX gdcmHeaderHelper::GetXSpacing
1485 when a single value is found (bug ?), xpacing is now
1486 defaulted to yspacing
1488 2004-04-19 Jean-Pierre Roux
1489 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1490 * ENH add parameters :
1491 bool exception_on_error = false,
1492 bool enable_sequences = false,
1493 bool ignore_shadow = false
1494 to the gdcmFile constructors to be full gdcmParser compliant
1495 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1496 to allow reading of PAPYRUS 3.0 files
1498 2004-04-06 Jean-Pierre Roux
1499 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1501 2004-04-02 Jean-Pierre Roux
1502 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1503 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1504 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1506 2004-03-30 Jean-Pierre Roux
1507 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1508 for ACR file, written out as DICOM files (hope so...)
1510 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1512 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1513 moved to base class gdcmParser and only the specialisation is kept
1515 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1516 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1517 already does the job.
1518 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1519 (to be consistent with gdcmParser::WriteEntries).
1521 2004-03-30 Benoit Regrain
1522 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1523 upate of the object's instance. It's passed to 2 in the unfavorable
1524 case : one in the ExecuteInformation, one in the ExecuteData
1526 2004-03-29 Jean-Pierre Roux
1527 * ENH : Check on file type to be written moved
1528 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1529 * FIX : gdcmObject::ResetBoundaries now stops properly
1530 when end-of-list is reached
1531 : gdcmVersion modified (as Benoit Regrain asked)
1533 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1535 * src/gdcmUtil.cxx: added forgotten iostream include.
1536 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1537 equivalent to ExplicitVR in existing code).
1539 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1541 now contains all the gdcmGlobal related code.
1542 * minor coding style and doxygenation changes.
1544 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1546 now contains all the Debug related code.
1547 * minor clean-up of includes in src/*.cxx
1548 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1549 CreateCleanString) removed.
1550 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1551 * Doc/DoxyMainPageUser.txt added.
1552 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1553 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1554 src/gdcmDirList.cxx)
1556 2004-03-24 Jean-Pierre Roux
1557 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1559 2004-03-23 Jean-Pierre Roux
1560 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1561 big endian made volumes
1562 * ENH Now gdcmParser constructor and destructor are protected to forbid
1563 end user to instanciate class gdcmParser
1564 (only gdcmHeader and gdcmDicomDir are meaningfull)
1566 2004-03-22 Benoit Regrain
1567 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1568 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1569 gdcmSerie to gdcmDicomDirSerie
1571 2004-03-19 Jean-Pierre Roux
1572 * ENH Now the tree-like structure describing a DICOMDIR comming from
1573 an already existing DICOMDIR file is consistent with
1574 the home-made tree-like structure build ex-nihilo
1575 or build from the files held (recursively) in a Directory
1576 functions gdcmDicomDir::CheckBoundaries()
1577 gdcmObject::SetBoundaries() added
1579 2004-03-17 Jean-Pierre Roux
1580 * REM (Eric Boix bug) : removal of meaningless
1581 gdcmDicomDirImage::NewImage function.
1582 * FIX now file names and directory name are written properly in the
1584 * FIX now gdcmDicomDir constructor may be call without any trick
1587 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1588 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1589 of gdcmDicomDirImage::NewImage as empty function.
1591 2004-02-28 Jean-Pierre Roux
1592 * ENH add gdcmDicomDir:NewPatient
1593 add gdcmDicomDirPatient:NewStudy
1594 add gdcmDicomDirStudy:NewSerie
1595 add gdcmDicomDirSerie:NewImage
1596 to allow making gdcDicomDir object.
1597 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1598 (as opposite to the gdcmHeader chained list)
1600 2004-02-11 Benoit Regrain
1601 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1602 when using from python
1604 2004-02-10 Benoit Regrain
1605 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1606 * FIX : in gdcmDicomDir when the directory is empty
1607 * ENH : add callback and methods to get the progression of dicomDir
1610 2004-02-06 Jean-Pierre Roux
1611 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1612 - GDCM_META added to gdcmDicomDirType
1613 - class gdcmMeta created
1614 * ENH : - A brief summary is now displayed at the beginning of
1615 'testDicomDir' to help disaster magnitude estimation
1616 * REM : Now useless Test/explDICOMDIR.cxx
1618 2004-02-05 Benoit Regrain
1619 * ENH : add methods in gdcmObject to get the hash table or the list of
1621 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1622 * FIX : wrapping python for TagHeaderEntryHT
1624 2004-02-04 Benoit Regrain
1625 * FIX : even length for some strings when writting the dicom dir
1626 * FIX : sort the images in the dicom dir
1627 * FIX : Bug fix for python use of dicom dir
1628 * ADD : a python demo
1630 2004-02-04 Jean-Pierre Roux
1631 * FIX : Final solution (?) for icone embedded images
1632 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1633 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1634 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1635 gdcmData/gdcm-MR-SIEMENS-16.acr1
1636 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1637 to make full checking easier
1639 2004-02-04 Benoit Regrain
1640 * FIX : WriteEntries : coding style & logic in parameters
1641 * FIX : Set the elements to create the DicomDir in a dictionary file
1643 2004-02-03 Benoit Regrain
1644 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1645 * gdcmDicomDir : add the load of directory
1646 * Bug fix and print add-on
1648 2004-02-03 Jean-Pierre Roux
1649 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1650 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1651 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1652 * FIX gdcmParser.cxx : 'group length' elements are now considered
1653 as integers, even for shadow groups, when file is Implicit VR
1655 2004-02-02 Jean-Pierre Roux
1656 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1658 of the last synonym :-(
1659 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1661 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1662 * FIX taking into account the possible 7fe0,0010 multiplicity
1663 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1664 to allow removal of references to 7fe0,0010, to deal with
1665 ACR-NEMA images, when 0028,0200 is meaningfull
1667 2004-01-31 Jean-Pierre Roux
1668 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1669 no longer writes 'Un' on disk
1670 * FIX SQ elements with actual length are now dealt with corectly
1671 * FIX gdcmFile::WriteBase make the difference, for color images, between
1672 the length (for Palette expanded images)
1673 and Raw Length (non expanded image + Palette)
1674 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1675 (that broke Write). Replaced by UL.
1676 Aware user will reload the field if he
1677 thinks it's necesssary
1679 2004-01-30 Jean-Pierre Roux
1680 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1681 when 'dirty Acr' is found, to be compliant with the new
1682 IsReadable() methods.
1684 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1685 (no DOUBLE images in kosher DICOM,
1686 but so usefull for people that miss them ;-)
1688 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1689 DICOMDIR related utilities (not checked as Windoze compliant)
1691 2004-01-28 Jean-Pierre Roux
1692 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1694 2004-01-27 Jean-Pierre Roux
1695 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1696 to allow skipping the shadow elements, to save memory space.
1697 The TRUE value for this param has to be used
1698 with a FALSE value for the 'enable_sequence' param.
1699 ('public elements' may be embedded in 'shadow Sequences')
1700 * gdcmHeader methods now deal with 'embedded icones images' in the header
1701 (even when an 'icone image sequence' is announced by the
1702 element (0x0088,0x0200), but there is NO icone at all ...
1704 * gdcmHeader sometimes Image Location value doesn't follow
1705 the supposed processor endianity (see gdcmData/cr172241.dcm).
1708 * gdcmHeader add the method
1709 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1710 to get *all* the Header Entries with the same tag.
1711 GetHeaderEntrySameName is probabely *useless*
1712 (no meaning : Name is *not* an identifier within the Dictionnary)
1714 2004-01-26 Benoit Regrain
1715 * Bug fix in the print of hexadecimal representations. Remove long fields
1716 in the print and add a third level of print to print them
1718 2004-01-23 Benoit Regrain
1719 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1720 * Bug fix on test suite after remove the strip made on not string fields
1721 * Split the IsReadable method between gdcmParser which test that the file
1722 is dicom and gdcmHeader which test that it's an image file
1724 2004-01-22 Benoit Regrain
1725 * DicomDir : clean code, add methods, set variables in protected or private
1726 * gdcmUtil : bug fix for the clean string method
1728 2004-01-19 Benoit Regrain
1729 * Add the use of shadow dictionaries
1730 * bug fix and coding style
1732 2004-01-19 Benoit Regrain
1733 * src/gdcmFile.cxx : bug fix concerning the close of file
1734 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1735 * Add the update of header entries using the shadow library
1737 2004-01-19 Benoit Regrain
1738 * removal of file gdcmHeader2.cxx
1739 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1740 inheriting from gdcmParser. This split is to prepare the integration
1741 of dicom dir parsing
1742 * bug fix under python
1744 2004-01-16 Jean-Pierre Roux
1745 * REM removal of class gdcmHeaderEntrySet
1746 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1747 * ADD add file gdcmHeader2.cxx
1748 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1750 2004-01-15 Benoit Regrain
1751 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1752 entries created while parsing the header. Thus, they will be destroyed
1753 when the gdcmDictSet will be destroyed
1754 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1757 2004-01-15 Benoit Regrain
1758 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1759 made a fatal error because of the memory release at the end of program.
1760 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1761 some memory and vtk seems to have some problems with that.
1762 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1764 2004-01-14 Benoit Regrain
1765 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1766 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1767 * src/*.[h|cxx] : make changes due to class name changes
1768 * gdcmPython/demo/*.py : bug fix due to method names
1770 2004-01-13 Benoit Regrain
1771 * src/*.[h|cxx] : coding style
1772 * vtk/*.[h|cxx] : coding style
1774 2004-01-13 Benoit Regrain
1775 * gdcmPython/testSuite.py : test the readable flag of file for tests
1776 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1777 It's lied to the stl compilation by MSVC (windows, always windows...)
1778 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1780 2004-01-12 Benoit Regrain
1781 * src/*.h : add comments
1782 * src/gdcmDictSet.h : set the method BuildDictPath in public
1783 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1784 directly setted in the source code
1785 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1788 2004-01-09 Benoit Regrain
1789 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1790 * setup.py : use a reference to gdcmVERSION
1792 2004-01-07 Benoit Regrain
1793 * Modification to compile with the distutils.
1796 2003-12-10 Benoit Regrain
1797 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1798 can use a gdcmHeaderHelper to load datas
1799 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1800 made in the source code
1802 2003-12-10 Benoit Regrain
1803 * Update Windows projects and .cvsignore files
1805 2003-11-12 Jean-Pierre Roux
1806 * ENH gdcmHeader constructor has one more parameter (default value : false)
1807 that allows the user to 'go inside' the SeQuences only
1809 gdcmElValSet:Print takes it into account
1811 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1812 * ENH: Update gdcmPython/CMakeLists
1813 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1814 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1816 2003-11-10 Jean-Pierre Roux
1817 * FIX : gdcmHeader::LoadElements is now based
1818 on the ListTag listElem member,
1819 not longer on the TagElValueHT tagHt member
1820 * ENH : PrintPubElVal shows (temporarily) both results,
1821 with the tagHt member and the listElem member.
1822 (it's easier to 'see' the problems when using Printheader)
1824 * FIX : old private member LgrElem is now splitted into
1825 ReadLength : Length actually found on disk (updated only
1826 if bug fixing is necessary), for internal
1828 UsableLength : Updated by FixFoundLength, to fix a bug
1829 or to allow Parser going on.
1830 Will allow to re-write a kosher header when a SeQuence
1831 with a length (not 0000) is found
1832 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1833 because gdcmElValSet::Add does not update ListElem
1836 2003-11-07 Jean-Pierre Roux
1837 * FIX misstyping in Transfert Syntax name table
1838 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1839 when they have an actual length (not 0000 nor FFFFF)
1840 (Nobody should care of it, but DICOMDIR explorers)
1842 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1845 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * ENH: vtkGdcmReader now supports LUT !
1847 (vtkgdcmViewer for now is not able to use them though)
1849 2003-11-05 Jean-Pierre Roux
1850 * in testSuite.py : new files names for checking the package
1851 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1852 that returns the pixel area size to the *aware* (vtk) user
1853 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1855 2003-11-05 Benoit Regrain
1856 * in testSuite.py : Modify the rules for checking the paths
1857 : Explicit error messages
1858 * in __init__.py : Related modif
1860 2003-11-03 Jean-Pierre Roux
1861 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1862 to be used by aware (vtk) users that want to manage
1863 LUT (and no to turn the PALETTE image into an RGB pixels one)
1864 * GetPixelType now returns 8U for 24 Bits images
1865 (vtkGdcmReader compliant)
1867 2003-10-31 Jean-Pierre Roux
1868 * Removal of *all* gdcmData images and add them again
1869 in order to loose the 'history' of un-anonymised images
1871 2003-10-31 Jean-Pierre Roux
1872 * RMV : removal of useless jBitsInJsample.h
1873 for both 8 and 12 Bits JPEG Lossy Libraries
1875 2003-10-31 Jean-Pierre Roux
1876 * ENH : Add the functions gdcmFile::GetImageDataRaw
1877 gdcmFile::GetImageDataIntoVectorRaw
1878 that act as GetImageData and GetImageDataIntoVector
1879 except the making of an RGB Plane from Gray Plane + LUT
1880 Intended to aware (vtk) users who know how to manage
1883 GetLUTRGBA return a R,G,B,A LUT if any
1884 lgrTotaleRaw gives the 'Raw' length
1885 GetImageDataRaw returns the gray Plane
1886 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1887 (They stay Grey, just like with other Dicom viewers :-(
1889 2003-10-30 Jean-Pierre Roux
1890 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1892 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1893 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1894 being coherents dicom files.
1896 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1899 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1900 * ENH: Two steps is necessary to please VC++ compiler...
1901 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1902 * ENH: Add include dir to medcon lib
1903 * FIX: only one function is being exported for now !
1904 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1906 2003-10-29 Jean-Pierre Roux
1907 * adding gdcmHeader::GetLUTRGBA
1908 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1909 --> Mathieu, the modif u're waiting for is not yet committed
1910 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1912 2003-10-27 Jean-Pierre Roux
1913 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1914 00191113.dcm DermaColorLossLess.dcm
1915 MxTwinLossLess.dcm RadBWLossLess.dcm
1916 * ENH: For version prior to vtkImageViewer2 -r 1.19
1917 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1919 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1920 * Removal of ido stuff in CMakeLists.txt
1922 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1923 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1924 * FIX: remove a call to ->Modified ... see comments
1925 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1927 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1928 * FIX: Problem with path for libvtkgdcmPython
1929 * ENH: Try adding a search script for python site-package
1930 * RMV: Remove some file from medcon lib that are not necessary
1931 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1932 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1933 * FIX: More pragma disable fro VC++,
1934 I don't think I break something as it is also disable in VTK/ITK.
1935 But it fasten debug compilation time.
1937 2003-10-23 Jean-Pierre Roux
1938 * gdcm now deals with 16 Bits Run Length Encoded images
1939 (they are compressed as 2 planes images,
1940 one for the high Bytes, the other for low Bytes)
1942 2003-10-22 Jean-Pierre Roux
1943 * Now CheckRead takes into account :
1944 - the bugged 'Leonardo' Siemens images
1945 - the XA images, sent thru the burning VPRO station
1946 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1949 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * FIX: When copying a Makefile.am to CMakeLists.txt
1951 one should remove the '\'
1953 2003-10-22 Jean-Pierre Roux
1954 * in gdcmData adding a bugged 'Leonardo' Siemens image
1955 (wrong lengths in header)
1956 OK with gdcm, KO with the other viewers :-)
1957 * add a GE dlx XA image, thru the VEPRO burning station
1960 2003-10-21 Jean-Pierre Roux
1961 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1962 for a brutal checking of vtkgdcmViewer compliance
1964 2003-10-21 Jean-Pierre Roux
1965 * add the files for 'xmedcon' Jpeg Lossless library
1966 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1968 2003-10-21 Jean-Pierre Roux
1969 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1971 2003-10-21 Jean-Pierre Roux
1972 * garbage Siemens 'Leonardo' images dealt with
1973 (the patch is easy to remove)
1974 * cosmetic changes to avoid warnings
1976 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1977 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1978 no need to press 'r' now.
1980 2003-10-20 Jean-Pierre Roux
1981 * upgrade of checkRead.sh checkWrite.sh according
1982 to new Jpeg Lossless decompressor
1983 * add US.3405.1.dcm, a genuine RGB medical file ...
1984 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1985 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1987 2003-10-15 Jean-Pierre Roux
1988 * general anonymisation in gdcmData
1989 * adding the 'color files' from
1990 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1991 * adding some well knowed bugged-header images
1992 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1993 waiting for their inclusion in Python testsuite
1995 2003-10-15 Jean-Pierre Roux
1996 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1997 no longer seg faults when file is not found
1999 2003-10-14 Jean-Pierre Roux
2000 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2003 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2004 * TODO: *.in file to genereate a UseGDCM later
2006 2003-10-14 Jean-Pierre Roux
2007 * Some supposed-to-be Dicom Images have no preamble.
2008 OpenFile takes it into account
2009 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2010 * Missing elements added in dicomV3.dic
2011 (just to be affraid : have a look at
2012 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2013 and do it again next year ;->
2015 2003-10-13 Jean-Pierre Roux
2016 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2017 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2018 But there are NOT. It's fixed !
2020 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * FIX: "jpeglib.h" was not found on VC++
2022 * FIX: vtkgdcm was not being installed
2024 2003-10-10 Jean-Pierre Roux
2025 * ENH : OpenFile closes the file if it *really* doesn't look like
2026 an ACR-NEMA / DICOM one.
2027 * FIX : testWrite no longer writes an empty file if the source file
2028 is not gdcm Readable
2029 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2032 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2033 * FIX: CMake generate now documentation
2034 * ENH: out of source doc build !
2035 * ENH: Generate both user and dev documentation
2036 * ENH: Should work on windows too
2037 * ENH: Only one doxygen config.in file is needed
2038 * FIX: make install should be ok now on ùnix plateform
2039 * FIX: PATH to dictionary was wrong (missing /)
2040 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2042 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2043 * vtkGdcmReader is now able to read rgb dicom file.
2044 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2045 * added a gdcmViewer to vtk test, use mouse to control
2046 window level & window width
2048 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2049 * CMake-ification of gdcm, we have now two build system
2050 * FIX: on cygwin Wsock32 doesn't exist
2051 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2053 2003-10-06 Emanuel Ollart
2054 * FIX : compilation process wad broken.
2055 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2057 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * change gdcmViewer -> vtkgdcmViewer
2059 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2061 2003-10-06 Jean-Pierre Roux
2062 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2063 ( e.g : well known GE images with a wrong elem length,
2064 : Philips MRI Images with a wrong Huffman table)
2065 * still to be done : allow the reading of bugged LEONARDO Siemens images
2067 2003-10-03 Jean-Pierre Roux
2068 * Odd length strings are padded with '\0' (not with spaces,
2069 to remain compliant with already defined strings,
2070 like Transfert Syntax UID and others)
2072 2003-10-03 Jean-Pierre Roux
2073 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2074 to allow displaying RGB images (not only by affim ;-)
2076 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2077 * vtkGdcmReader is now able to read rgb dicom file.
2078 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2080 2003-10-03 Jean-Pierre Roux
2081 * A few nasty patches to allow the reading of a lot of nasty images
2082 ( e.g : well known GE images with a wrong elem length,
2083 : Philips MRI Images with a wrong Huffman table)
2084 * still to be done : allow the reading of bugged LEONARDO Siemens images
2086 2003-10-03 Jean-Pierre Roux
2087 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2089 2003-10-03 Jean-Pierre Roux
2090 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2091 to allow displaying RGB images (not only by affim ;-)
2093 2003-10-03 Jean-Pierre Roux
2094 * gdcmFile::GetImageDataIntoVector now
2095 - deals with MultiFrames MultiFragments Run Length Encoded files
2096 - deals with YcBcR (YBR_FULL) files
2097 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2098 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2100 (no sample found :-(
2102 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2103 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2104 Two reasons: - clear things
2105 - third parties acces gdcm through header files, so won't
2106 suffer anymore VC++ complains
2108 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * add argv[1] in testvtkGdcmReader.cxx
2112 2003-09-24 Jean-Pierre Roux
2113 * The lines are now eigthy characters long.for
2114 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2116 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2117 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2118 char* to std::string. Thus, the use of strdup becomes useless. (see
2119 previous commis of Malaterre)
2120 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2121 before the last Malaterre's commit.
2123 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2124 * This commit should fix the Debug building under VC++, the problem
2125 was mainly a mixture of debug and release lib being loaded at startup.
2126 * I also remove a depency to a specific C function: strdup. Because I had
2127 to force the link to msvcrtd (whereas strdup is in libc).
2129 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2130 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2131 located in the gdcmCommon.h file. All use of reference of tha has been
2132 changed to now use the variable GDCM_UNFOUND.
2134 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2136 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2137 Dicom dictionary. The test suite can now be run again. Note:
2138 I'm note very happy with the " (RET)" changes. I believe this
2139 RETAINED comment should be dropped when parsing the dictionary.
2140 - PACKAGER corrected
2142 - AUTHORS updated and now in alphabetical order
2143 * Makefile.am now exports gdcm.dsw for Windoze users.
2145 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2146 * cygwin complains about missing std:: in subdir Test/
2148 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * remove some methods that are now in gdcmHeaderHelper
2151 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * vtkGdcmReader set spacing and origin correctly
2154 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * Fix a few delete/delete[] mismatch
2157 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2159 interpretation to data given by gdcmHeader. For instance there are
2160 heuristics to get informations (look at different places).
2161 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2162 sorting DICOM images based on different strategies.
2163 * modified Makefiles accordingly.
2165 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2166 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2167 when building in debug mode
2168 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2169 src/win32/gdcmdll.dsp
2170 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2172 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2173 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2176 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2177 * src/win32/libgdcmjpeg12.dsp was not dos format
2178 * src/win32/libgdcmjpeg12.dsp :
2179 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2180 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2182 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2183 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2185 * src/gdcmFile.cxx : bug fix in affectation type
2186 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2187 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2188 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2189 symbols... future problem ?
2191 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * src/win32/libgdcmijpeg12.dsp was missing
2193 * modified gdcm.dsw accordingly
2195 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2196 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2198 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2199 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2200 commit of JPR (before his hollidays to facilitate our work).
2201 * setup.py : bug fix in code. Modifications made while the last commit
2202 of JPR. The code hasn't been tested before the commit... it's so
2203 useless to make that (for best programmer that is JPR) !!!
2205 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * tagged the current version as Version0_3 (i.e. version 0.3)
2208 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2209 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2210 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2211 * *.dsp : modifications to use new libgdcmijpeg8 library
2212 * setup.py : bug fix on VTKPATH variable
2213 * PACKAGER : adding all concerning windows
2215 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2218 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2219 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2220 test suite reported error.
2221 * PACKAGER file added (describes what a packager must do when
2222 packaging a new release).
2223 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2224 * configure.in: upgraded version number to 0.3.0
2225 * fixing build of rpm (through rpm -ta):
2226 - Doc/Makefile.am exports proper doxygen files
2227 - src/jpeg/libijg8/Makefile.am exports the include files.
2229 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2230 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2231 * src/gdcmHeader.h : formatting code
2233 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2234 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2235 We were obtaining error message from vtk. Now, creation of file list
2236 is made in an internal list to prevent this problem.
2237 Bug fix when output is empty.
2238 Bug fix in update of progress value. Previous commit for this was a bad
2240 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2242 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2243 * src/gdcmHeader.h : added method to get the file name
2244 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2245 files. Added method to remove all files on the input
2246 Added FIXME comment concerning the bad parsing of header made by
2247 ExecuteInformation method (in ExecuteData method)
2249 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2251 when using make instal.
2252 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2253 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2255 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2256 * setup.py : adding include dir of jpeg lib to compile all sources
2257 * */Win32/*.dsp : JPR fix for windows compilation
2259 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2260 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2262 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2263 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2265 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2266 * setup.py is again effective on un*x (takes into account the
2267 addon of the jpeg library)
2268 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2269 * Doc/Doxy* updated (includes above enhancements)
2270 * INSTALL now points to web documentation
2272 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * src/gdcmHeader.h doesn't make unnecessary reference to
2275 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2277 * src/gdcm*.[cxx|h] :
2278 - to allow compilation with gcc 3.x
2279 -- clean up of STL usage (added explicit usage of std::)
2280 -- small fixes on exceptions.
2281 Note: linking not tested !
2282 - clean of doxygen comments to avoid warnings at documentation
2284 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2285 dependent convertion).
2287 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * Clean up of previous JPR garbage commit (not even commented in the
2290 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2291 - moved all jpeg related files from src to src/jpeg/libijg8, with
2292 addition/modification of Makefile.am and configure.in.
2293 - the testSuite is still brain damage (not guilty).
2295 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2296 * WrapVTK.py : modifications to get correctly vtk source files to
2298 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2299 (FileName -> Filename)
2301 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2302 * vtk/vtkGdcmReader.[cxx/h]:
2303 - UpdateProgress method should now be effective
2304 - removed the limitation on having only images loaded (as opposed
2306 - when building a stack of images/volume, a lesser number of
2307 gdcmHeader and gdcmFile instances should be used (hopefully
2308 accelerating things).
2309 - when building a stack of images/volumes, files which are not
2310 loadable (wrong path-filename, wrong permissions on existing file,
2311 or file not parsable by gdcm) are replaced with a black image
2312 in the stack (for the caller to notice the problem).
2314 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2317 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2318 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2319 between standard library (std) and vtk library (problems are found
2320 under Windows... thanks Windows !)
2322 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2325 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2327 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2330 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2331 * When compiling with distutils (see setup.py) the C++ compiler is
2332 called with different flags than the default ones (with automake).
2333 In order to fix all those warning, I compiled gdcm with the command
2334 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2335 and went for warning fixes:
2336 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2337 up from unused variables.
2338 - vtk/vtkGdcmReader.cxx: potential bug fix.
2339 * src/gdcmHeader.h: Doxygen warning cleanup
2341 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * gdcmPython/gdcm.i:
2343 - typemaps correction to take into account the systematic replacement
2344 of "using namespace std" with std:: prefix e.g. std::list,
2345 std::string... (cf changes of 2003-05-21).
2346 - gdcmGlob global variable of type gdcmGlobal (defined in
2347 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2348 exported to Python a as cvar.
2349 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2350 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2351 gdcmDictSet.GetPubDictTagNames() and
2352 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2353 C++ static methods).
2354 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2355 with the above changes.
2357 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2358 * setup.py, manifest.in : bug fix under linux
2360 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2361 * Modification of setup.py to compile vtk part too. Then, we have 2
2362 wrappers which must work with same distutils. For that, we have a
2363 generic distutils in distusiltsWrapping.py ; with :
2364 - build_extWrap class to wrap generically all extensions,
2365 - ExtensionWrap base class for all wrapping extension that contains
2367 - Wrapper interface which wrap sources
2368 + In WrapSwig.py we have extension and wrapper for Swig
2369 + In WrapVTK.py we have extension and wrapper for VTK
2370 * MANIFEST.in : modifications to consider vtk directory and new python
2371 files for compilation
2373 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2374 * Added python wrappers of vtkGdcmReader vtk class (see the
2375 source in vtk/vtkGdcmReader.cxx) :
2376 - vtk/Makefile.am now builds a library
2377 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2378 python library (as opposed to _gdcm.so wich are the python
2379 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2380 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2382 - configure.in has an additional flag --enable-vtk that needs
2383 to be set to enable compilation of vtk related code, that is:
2384 + vtk/vtkGdcmReader.so and
2385 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2386 + gdcmPython/vtkgdcmPython.so (see above)
2387 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2388 be read when compressed or when HighBit + 1 != BitsStored),
2389 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2390 the usage of the python wrapper of vtkGdcmReader vtk class.
2391 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2392 * src/*.[h] all occurences of stl classes are now prefixed with
2393 std::, and all occurences of "using namespace std;" where removed.
2394 This is to avoid pollution of global namespace in included files.
2395 Apparently vtk does not avoid this pitfall: when using both
2396 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2397 collision of various stl members (principally cout...).
2398 * gdcmPython/testSuite.py now cleanly removes temprory generated
2400 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2401 comply with above changes)
2403 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2404 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2405 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2406 vtk data structure (an image Flip was required).
2407 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2408 * cosmetic changes in documentation.
2410 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2411 * src/gdcmHeader.cxx: the constructor no longer exits when an
2412 unexisting file is given as argument.
2413 * The subdirectory Data (containing all the images used for the
2414 test suite) is not part of this repository anymore. A new module
2415 containing those images is now available at
2416 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2417 with the name gdcmData.
2418 All the python scripts (including the package initialisation file
2419 gdcmPython/__init__.py) were adapated to take this change into
2420 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2422 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2423 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2424 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2425 demo of the usage of this class.
2426 Compilation of this vtk part is only done when using the --enable-vtk
2427 at configure (or autogen.sh) stage.
2429 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2430 * More memory link related corrections and documentation fixes.
2432 - maximum info is obtained with a command of the form:
2433 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2434 --show-reachable=yes PrintHeader
2435 - the remaining reachable blocks seem to come from the STL
2436 allocation scheme through the usage of map and list. It looks
2437 like this memory cannot be freed but it is not a memory leak
2438 (in fact further invocation to the STL would recollect the
2439 unused memory allthough it cannot explicitely be freed).
2440 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2441 of displaying an image parsed with gdcm and displayed with VTK.
2442 Note: some images don't seem to work e.g.
2443 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2444 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2445 Allthough this weakens the semantics, it is a ditch attempt to
2446 make gdcm more thread friendly.
2448 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2449 * Memory link hunt (by using valgrind through the command
2450 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2451 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2452 gdcmHeader::_dicom_vr.
2453 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2454 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2456 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2458 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2459 * src/Makefile.am now exports all the necessary include files at
2463 * UpdateGroupLength replaced by new one
2466 * UpdateGroupLength re-written using H-Table
2467 (named UpdateGroupLengthNew untill checks are over)
2469 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2470 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2471 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2473 - gdcmHeader::GetPubElValSet removed.
2474 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2475 UpdateGroupLength, WriteElements, Write.
2476 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2477 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2478 carried the same semantics.
2479 - src/gdcmHeaderIdo.cxx changed accordingly.
2480 - gdcmFile::WriteBase now regroups all the codes from previous
2481 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2482 - enum FileType moved to gdcmCommon.h
2483 * src/gdcmHeader.cxx AddDefault trashed
2484 * gdcmGetXSize added
2485 * getimageDataSize now calls gdcmGetXSize
2486 * Test/*.cxx changed to agree with above changes
2488 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2490 (to avoid double call by end user).
2491 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2492 by end user, since gdcmHeader::gdcmHeader now handles it.
2494 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * gdcm/Doc many doxygen changes:
2496 - Doxyfile now has two different versions, DoxyfileUsers that generates
2497 the html.users end users oriented documentation and
2498 DoxyfileDeveloppers that generates the html.developper developper
2499 oriented documentation.
2500 - README changed accordingly
2501 - requirement.txt removed (old design info moved to TODO).
2502 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2503 DoxyMainPage.txt, DoxyPython.txt provide more information.
2504 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2505 be updated by simply regenerating the docs with doxygen and copying
2506 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2507 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2508 all the tests in the form "if (<map>.count() >1)" were removed.
2509 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2510 ill-formed documentation sections.
2511 * src/gdcmHeader.cxx: ditto
2513 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * setup.py fixed for un*x (needed macro for stdint.h)
2515 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2516 un*ces with sh-utils test utility.
2517 * gdcmPython/demo/test.py renamed to PrintHeader.py
2518 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2519 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2520 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2521 * src/gdcm*.cxx JPR's bad inclusion fixed.
2523 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2524 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2525 * gdcmPython/demo/test.py changed accordingly.
2527 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * gdcmPython/Makefile.am fixed linking against libstdc++
2529 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2530 * Swig subdir (historical tests of swig version 1.3.17++) removed
2531 * Test/testChangeEntete.cxx some lines commented out in order to make
2533 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2534 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2536 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2538 hence the user doesn't need this explicit call.
2539 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2540 i.e. LoadElements() call removed.
2541 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2542 - src/Makefile.am declares the proper flag for g++.
2543 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2544 for adding user defined new tags.
2545 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2546 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2547 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2549 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2550 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2551 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2552 src/Makefile.am : the project should properly compile and install
2553 with the autotools, included the python wrappers part.
2554 * gdcm.spec.in : added a spec file for RPM packaging.
2556 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2557 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2559 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2561 to exported to the environement (see gdcmPython/testSuite.py
2563 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2564 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2565 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2566 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2567 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2569 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * gdcmPython/__init__.py doesn't crash anymore when running in
2571 in InstallMode or PreInstallMode but with an environement given
2572 value of GDCM_DICT_PATH.
2573 * src/gdcmDictSet.[cxx/h] coding style.
2575 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2577 * src/gdcm.h general comments moved to TODO, and README
2578 * src/gdcm.h should now be seen as a user commodity (including it
2579 should suffice to fully use gdcm). It is nowhere including within
2580 any of the kernel files src/*.cxx and src/*.h.
2582 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2583 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2584 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2586 * src/gdcm*.cxx only include their corresponding include file
2587 (as opposed to gdcm.h)
2588 * gdcmPython/gdcm.i changed accordingly
2589 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2590 the autogen.sh generated "make snapshot" command to work.
2591 * autogen.sh removed history related references to crea package.
2593 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2594 * distutilsSwigCPlusPlus.py work around some swig portability
2597 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2599 was done in a last ditch attempt to get setup.py _really_
2600 operationnal. The python/gdcmPython layaout add the advantage
2601 of hidding away the python related distutils specific files
2602 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2603 Alas, the src directory was out of scope (i.e. it's relative
2604 position to setup.py was ../src) which made things impossible to
2605 handle (see previous version of python/setup.py). Crossing fingers...
2607 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2608 * python/setup.py now works on Un*x. (harder than I thougth)
2609 * python/distutilsSwigCPlusPlus.py can now have include files
2610 among the list of sources.
2612 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2613 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2614 * modifications in MSVC projects
2616 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * As stated by the first lines of Test/ExceptionAndPython/README, it
2618 looks like we can move back to original usage of exception within
2619 src/gdcm* and hence remove the errno stuff that was introduced
2620 as a quick and dirty fixture of this problem (added to the TODO).
2621 * Doc/Doxyfile configuration file for Doxygen and corresponding
2622 README file for usage added.
2623 * Test/testWrite.cxx added. This new test comes from a split of
2624 test.cxx that is now reverted to its original purpous i.e.
2625 testing the proper parsing of a Dicom related file.
2626 testWrite.cxx concentrates on testing the IO part of gdcm.
2627 * Test/bug1.cxx (containing a bug on WIn32) added.
2628 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2629 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2630 whose purpose is to publish the content of the TagNames of the
2631 Dicom public dictionnary were not accessible without an
2632 instance of class gdcmHeader.
2633 - those methods are now static methods of gdcmDictSet and hence
2634 require no instances at all to be invocated.
2635 - within gdcmDictSet this change required to change some method
2636 to class methods (i.e. are now static) among which SetDictPath
2637 (renamed to BuildDictPath) and LoadDefaultPubDict.
2638 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2639 the above changes by calling the new method classes of gdcmDictSet.
2640 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2641 the above to be effective.
2642 * python/gdcmPython: in order to wrap properly the above changes
2643 for Python, swig version now needs to be > 1.3.17.
2644 * python/gdcmPython/Makefile fixed to adapt itself to new
2645 configure/make shema introduced by Johan Montagnat (thanks for the
2646 contribution). Alas this Makefile cannot be turned into a proper
2647 Makefile.am without some heavy changes in the configure.in
2648 (for python dectection).
2649 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2650 now avoids publishing the empty entries.
2652 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2653 * python/setup.py : bug fix concerning install under windows
2654 ExtraPath reused :-P
2655 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2657 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2658 * Dicts/dicomV3.dic : remove double spaces !!!
2659 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2660 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2663 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2665 method. Doxygenation.
2666 * src/gdcm.h clean up of JPR spurious comments.
2668 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2669 * python/distutilsSwigCPlusPlus.py now properly collects the
2670 shadow classes generated by "swig -c++" (gdcm.py in our case)
2671 when using "python setup.py install".
2672 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2673 reexports the working classes.
2674 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2675 by the classical C errno scheme. This is to prevent an obscure
2676 behavior of the python wrappers when importing wxPython.wx prior
2677 to gdcmPython (which ended up in an abort call). An illustration
2678 of this oddity can be found in the Test/ExceptionAndPython
2679 subdir (see the README file). This problem probably due to
2680 an combination of g++ and dynamic loading.
2681 * added Test/ExceptionAndPython (see above)
2683 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * Changed the layout of the python part to avoid bloating main
2685 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2686 i.e. the distutils arsenal. All the python related stuff is
2687 again in a python subdir, but the package itself is now in
2689 * setup.py was cleaned up:
2690 - pythonIncludePath removed
2691 - python setup.py bdist target is now functional.
2692 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2693 collision with other packages). gdcmPython/demo/*.py changed
2696 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * python subdir moved to gdcmPython (preparation of distutils packaging).
2698 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2699 distutils installer is operational.
2700 * - gdcmPython/__init__.py now properly loads the swig generated
2701 shadow classes (from gdcm.py).
2702 - gdcmPython/demo/*.py changed to import the package gdcmPython
2703 instead of gdcmPython/demo/load.py.
2704 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2706 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2707 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2708 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2709 entries within the associated public Dicom dictionary resp. the same
2710 information but sorted by the fourth field (PAT, IMG, DIR) of the
2712 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2713 are now in the "???" group.
2714 - python/gdcm.i changed accordingly,
2715 - python/demo/printGroupedPublicDict.py added, that gives an example
2716 of the above new functionalities in Python.
2718 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * src/gdcm.h, gdcmHeader.cxx:
2720 - historic references to glib's g_malloc and g_free (#defined)
2721 were definitively removed.
2722 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2723 * src/gdcmElValSet.cxx:
2724 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2725 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2726 - GetElValue(string) renamed to GetElValueByName.
2727 - Added GetElementByName(string).
2728 * src/gdcmHeader.cxx: added
2729 - GetPubElValRepByNumber(guint16, guint16)
2730 - GetPubElValRepByName(string)
2731 - GetShaElValRepByNumber(guint16, guint16)
2732 - GetShaElValRepByName(string)
2733 - GetShaElValByNumber(guint16, guint16)
2734 - GetShaElValRepByName(string)
2735 - GetElValRepByNumber(guint16, guint16)
2736 - GetElValRepByName(string)
2737 - GetElValByNumber(guint16, guint16)
2738 - GetElValRepByName(string)
2739 * Doc/requirements.txt added.
2741 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * Test/Makefile building now depends on the one of libgdcm.so
2743 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2744 pixel data) aware which enables finding the address (offset) of
2745 the pixel data of JPEG encoded DICOM files. This leaves only a single
2746 file in the testSuite whose pixel data address (offset) is unknown.
2747 * python/testSuite.py changed accordingly.
2749 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2750 * VC++ has some strong limitations when working with the STL, as stated
2751 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2752 "Also note that some STL containers (map, set, queue, list, deque)
2753 cannot be exported. [...]
2754 Some STL classes contain nested classes. These classes can not
2756 This is caused by a designed limitation that once a template
2757 class is instantiated, it can not be re-instantiated and
2759 Since our usage of map<> is ubiquitous in gdcm, this "designed
2760 limitation" of VC++ is a pitfall.
2761 Hence the Python wrappers of gdcm cannot be incrementally linked
2762 against the c++ dynamic library. The dirty but only workaround is
2763 to forget about incremental link of dynamic libraries and to generate
2764 the Python wrappers library with the inclusions of the underlying C++
2766 The following modifications concern this matter on Win32/VC++:
2767 - wrapping python correct with standalone wrapped dll (don't use separate
2768 dll under windows !!!!)
2769 - python21_d debug mode enabled (ask Frog how to use it :-)
2770 - NO problem with having an STL member of class for example string in C++
2771 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2772 - Python test of dcmlib in Python is ok under windows on a large set
2774 * removed glib references
2775 * typedef's inserted in gdcm.i for correct swig type management
2777 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2778 * python/demo/*.py load.py extracted from test.py. Added explore.py
2779 that only displays required tags and testAll.py that parses all
2780 the files of the testsuite without using unittest.
2781 * python/testSuite.py other additional test on new files added.
2782 * Data/* new test files added accordingly to the testSuite.
2783 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2784 the vr in the file differs from the one of the dictionary.
2786 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2788 values, but limits itself to values which are below a user specified
2789 size (by default 1024 bytes).
2790 * python/gdcm.i : elements not loaded (because their size is above the
2791 user specified treshold) are exported with their TagKey as key of the
2792 python dictionary. This enables the testsuite to make some checks
2793 on the unloaded elements (since we have their offset and size).
2794 * python/testSuite.py
2795 - now tests for the existence and proper value of the pixel data
2796 - two new examples added.
2797 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2799 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2801 aware. See the strategy comments in gdcmHeader::FindeLength().
2802 * Test/test.cxx now accepts a filename as first argument.
2803 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2804 * python/testSuite.py changed to integrate test on above files.
2806 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2807 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2808 the vr was also RET.
2809 * python/testSuite.py more tests added.
2811 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * python/testSuite.py unittest test suite added (uses Data)
2813 * Data/* dcm and acr files for the test suite.
2814 * glib dependance removed from un*x version. We now use ISO C99
2815 7.18 Integer types (see stdint.h)
2816 - python/Makefile, src/Makefile src/gdcm.h
2817 * src/ when an explicit vr (like dicom files) suddenly poped an
2818 implicit element we use to mark the underlying DictEntry of the
2819 concerned ElValue with "Implicit". This strategy was damageable
2820 too the public or provite dictionaries, since some of their vr
2821 would be changed. Since Header::FindLength heavily relies on the
2822 detection by Header::FindVR of falsely explicit elements, I
2823 added an extra ImplicitVr member to ElValue (boolean).
2824 The rest of the changes we the necessary adaptations.
2826 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2827 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2829 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2831 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * Adaptation for porting to VC++:
2834 o forced to use std namespace (for string to be known)
2835 o all class use __declspec export style on WIN32
2836 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2837 (in stdlib.h on Win32 but in std:: for gcc)
2838 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2839 variable GDCM_DICT_PATH.
2840 * src/gdcmHeader.cxx verbose comments made discrete.
2842 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * python/gdcm.i: added a typemap that converts a C++ hashing table
2844 to native Python dictionary.
2845 * python/demo/test.py:
2846 - now uses the native dictionary for exploration of gdcmHeader.
2847 - takes an optional filename argument (the file to parse).
2848 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2849 PubElVals hashing table.
2850 * Dicts/dicomV3.dic removed error prone trailing spaces.
2852 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2853 * Python wrapping process moved away from src/Makefile to
2854 newly created python/Makefile (as well as gdcm.i)
2855 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2856 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2857 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2858 from the environement variable GDCM_DICT_PATH (when existing).
2859 * src/gdcmDict::GetTag bug fix.
2861 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2862 * Straightforward temporary fixes for swig to build the python wrappers.
2863 src/Makefile now has a python working entry [by working we mean
2864 that we can import de shadow classes without errors].
2866 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * hashtest.cxx removed (since allready in Test)
2868 * src/gdcmlib.h renamed to src/gdcm.h
2869 * src/dcm.i renamed to src/gdcm.i
2870 * src/Makefile prepared for python wrapping
2872 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2873 * src/gdcmHeader.cxx :
2874 - Parsing of header is now separated from loading of element values
2875 (see gdcmHeader::LoadElements).
2876 - general clean up of hopefully all file access (creation of
2877 ReadInt16 and ReadInt32)
2879 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2880 * src/gdcmHeader.cxx :
2881 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2883 - SetLgrElem renamed to SetLength
2884 - GetLgrElem renamed to GetLength
2885 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2886 * src/gdcmElValSet.cxx fixed both GetElValue methods
2887 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2888 due to IdoDude was cleaned out.
2890 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2891 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2892 concentrates on finding the value representation (when it exists).
2893 RecupLgr now only finds the element value length, and it avoids
2894 returning the unecessary skL (skipped length).
2895 Also, offsetCourant was simply removed (with taille_fich) since
2896 it was redundant with the File position internals (by using
2897 ftell and fseek). This also made skL (see above in RecupLgr) usage
2899 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2900 on the libido specificities which are handled through class
2902 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2905 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2906 * Truckload of changes. Parsing of header is barely functional
2907 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2909 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2910 * src/gdcmHeader.cxx many addons of low level methods
2912 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2913 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2914 and _IdDcmSWAP_LONG.
2916 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2917 * This corresponds to all the changes decided at the meeting of
2918 May 23 2002. Needless to say we are running late...