1 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Test/TestAllEntryVerify.cxx minor fix and added comments.
4 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
5 * gdcmPython/testSuite.py: all the test suite in python is now moved
6 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
7 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
8 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
10 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
12 to avoid inclusion recursion until STL is reached.
13 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
14 mecanism. errno.h is not included in gdcm anymore.
15 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
16 (gdcmFormatError now inherits from gdcmFormatUnexpected).
18 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
19 gdcmData/TestAllEntryVerifyReference.txt
20 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
21 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
22 exception_on_error parameter.
23 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
24 - vtk/vtkGdcmReader.cxx changed accordingly,
25 - Example/*.cxx and Test/*.cxx changed accordingly.
27 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
28 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
29 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
30 enable_sequences removed from gdcmHeader constructor and dependencies.
31 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
32 * gdcmPython/demo/PrintHeader.py: dummy fix.
33 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
34 skip_shadow removed from gdcmHeader constructor and dependencies.
35 * Example/*.cxx and Test/*.cxx changed accordingly.
37 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
38 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
39 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
41 2004-07-21 Jean-Pierre Roux
42 * FIX Now, Parsing and Printing a DICOMDIR do work!
43 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
45 2004-07-20 Jean-Pierre Roux
46 * FIX Some brain damaged headers have Zero-Lenght fields
47 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
49 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
50 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
51 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
52 variable (instance of gdcmDebug) by a definition macro, and the instance
53 is now in static in the gdcmDebug class
54 * src/gdcmSQItem.h : (FIXME) remove an undefined method
55 * Test/PrintAllDocument.cxx : bug fix in the result of the test
57 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
58 * WARNING: ctest now depends more tightly on gdcmData. You should
59 check out gdcmData properly for things to run smoothly...
60 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
61 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
62 we need the pixels not be loaded in order to use the ValEntry
63 that displays position and size).
64 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
65 This is a C++ based equivalent of gdcmPython/testSuite.py that should
66 be deprecated. If you have any doubts about the advantages of a
67 modern scripting language (read Python) versus grass root C++ (i.e.
68 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
69 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
70 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
71 Anyhow, consider documenting the gdcmData images in
72 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
74 * Test/CMakeLists.txt:
75 - now uses TestAllEntryVerify.cxx
76 - specific comments on oldACR00001.ima (now renamed in gdcmData
77 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
78 gdcmData/TestAllEntryVerifyReference.txt
81 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
82 * src/*.[h|cxx] : typedef clean up
83 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
84 - TagKey renamed to gdcmTagKey (for external usage)
85 - VRKey renamed to gdcmVRKey (for external usage)
86 - removal of typedef duplication.
87 - Removed all unecessary inline keyword from class inline definitions.
88 - Some method|function(void) declarations replaced with method|function().
89 * src/jpeg/libijg12/jdhuff12.c:
90 - printf polluting ctest removed.
91 - TAB removal for comminting
93 - TestAllReadCompareDicom.cxx: added a test that compares all the
94 images in gdcmDataImages.h with corresponding images in
95 gdcmData/BaselineDicom/. When baseline images are not present
96 this test creates them.
97 Note: we need to validate each reference image, but before that
98 I'd like to rename them with a more explicit name...
99 - CMakeLists.txt: changed accordingly.
100 * Example/*.cxx: examples now only include gdcm.h (as opposed to
101 including each header needed).
103 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * Test/*.cxx and Example/*.cxx: moved some examples away from the
105 test suite to the Example directory. Are concerned:
110 - TestWriteSimple.cxx
111 * Test/CMakeLists.txt: added some comments on reasons for black listing
112 image gdcmData/oldACR00001.ima
114 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
115 * Test/CmakeList.txt: removed the following from black list (to be coherent
116 with removal from gdcmData):
117 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
118 - gdcm-MR-PHILIPS-16.dcm
120 Added the following because after last cvs update, they cause
121 ctest -R TestReadWriteReadCompare
123 - gdcm-MR-SIEMENS-16-1.acr
125 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
126 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
127 new comments in this file) we temporarily (sigh) move to a weaker
129 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
130 we don't need to black list the following images anymore:
131 - 8BitsUncompressedColor.dcm
133 - US-PAL-8-10x-echo.dcm
134 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
135 fixes and the beautified code ;-)
136 This fixes the bug introduced in version 1.42 (when beautifying)
137 that made the parsing of 8BitsRunLengthColor.dcm unproper.
138 Note: ctest was blind to this bug (this means we need to still
139 improve the test suite). The bug could be detected by using
140 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
142 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
143 and by displaying the (garbage) produced file temp.XDCM...
145 2004-06-29 Jean-Pierre Roux
146 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
147 - replace by uggly but working old code :-(
148 A lot of things should be OK again.
149 It's really urgent to have a test suite that *tests*,
150 to prevent Frog's beautifying sessions to break all the stuff
151 (twice, withing a fortnigh ...)
153 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
154 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
155 redundancy) to added Test/TestReadWriteReadCompare.cxx
156 * Test/CmakeList.txt: because the compare test of
157 Test/TestReadWriteReadCompare.cxx fails, the following images are
158 black listed: - 8BitsUncompressedColor.dcm
160 - US-PAL-8-10x-echo.dcm
161 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
162 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
163 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
164 and ad-hoc kludge. This kludge is now removed, and on encountering
165 such an image (OB field brain damaged) we set errno. Then in
166 ::FindDocLength() we "fix" the length as being ALL what remains
167 in the file (until EOF). We then proceed, hoping for the best...
168 This fixes a SegFault in ShowDicom when trying to write such an
170 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
171 (because TestWriteRead breaks on it, after a non conformal commit?).
172 ctest now runs properly, except for MakeDicomDir (which was allways
173 broken) and the Python related stuff (still not fixed).
175 2004-06-24 Jean-Pierre Roux
176 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
177 FIX : Test/TestReadWrite now iterates on all the file names
178 (instead of infinite loop)
179 ENH : Test/TestWriteRead now iterates on all the file names
181 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
184 2004-06-24 Jean-Pierre Roux
185 FIX : - now Write drops LUT Descriptors and LUTs (if any)
186 when SamplesPerPixel =3
187 - now Write is no longer confused by
188 'BitsAllocated = 12" and 'BitsStored=12"
189 - "UN" value representation Elements are now written correctly
190 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
191 ENH : - now gdcmHeader has its own Write methods
192 (in order to split the job that has not to be done
195 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
196 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
197 loop on the same image until memory went out.
198 Note: this means we still have gobs of memory loss in PrintDocument
199 * src/gdcmDocument.cxx: fixes problem on parsing on file
200 gdcmData/16BitsJpegLosslessGrayScale.dcm.
202 2004-06-24 Jean-Pierre Roux
203 FIX : Write - All the Sequences and Sequence Item are now written
204 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
205 is added a the end, when necessary.
206 - A lot of brain-damaged images, that were read correctly are
207 now written correctly
208 - length compatible BinEntry are now loaded correctly
209 (even for odd groups)
210 Note : only Explicit Value Representation was checked.
211 (question : is implicit VR really necessary for gdcm ?)
213 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * DEVELOPPER: added a proposition of coding style.
215 * src/gdcmDocEntry.h: removed every inline declaration (for test of
218 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
220 Use the gdcmDocEntry::Print() and Write() instead.
221 * src/gdcmDocument.cxx: bug fix.
223 2004-06-22 Jean-Pierre Roux
224 FIX : gdcmDocument.cxx
225 - Now we do recognize the JpegLossLess format (there was a misstyping in
226 code 'beautyfication' :-(
227 - Now we automaticaticaly load the Luts, if any
229 2004-06-22 Jean-Pierre Roux
230 In order : to write Sequences, whatever their imbrication level,
231 : to allow user to create his own Sequences
232 a lot of modif where necessary (adding, moving, or virtualising methods)
234 WARNING : save your own sources *before* cvs up !
237 ADD virtual void Write(FILE *fp, FileType filetype);
240 ADD virtual void Write(FILE *fp, FileType filetype);
241 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
244 ADD virtual void Write (FILE *fp, FileType filetype)=0;
245 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
246 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
247 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
248 ADD std::string GetEntryByName(TagName name);
249 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
251 std::string vr = "unkn",
252 std::string fourth = "unkn",
253 std::string name = "unkn");
254 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
255 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
256 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
257 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
258 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
259 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
260 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
261 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
264 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
265 ADD virtual std::string GetEntryByName (TagName tagName);
266 ADD virtual std::string GetEntryVRByName (TagName tagName);
267 REM virtual bool Write(FILE *, FileType);
268 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
269 FILE *_fp, FileType type);
270 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
271 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
272 REM virtual bool WriteEntries(FILE *_fp,FileType type);
273 REM virtual std::string GetEntryByName (std::string tagName);
274 REM virtual std::string GetEntryVRByName (std::string tagName);
275 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
276 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
277 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
279 std::string vr = "unkn",
280 std::string fourth = "unkn",
281 std::string name = "unkn");
282 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
283 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
284 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
285 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
288 ADD virtual void Write(FILE *fp, FileType filetype);
291 ADD virtual void Write(FILE *fp,FileType filetype);
294 ADD virtual void Write(FILE *fp, FileType filetype);
295 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
296 REM std::string GetEntryByNumber(guint16 group, guint16 element);
297 REM std::string GetEntryByName(TagName name);
300 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
302 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
304 The default constructor invoked by the line
305 gdcmHeader *f1 = new gdcmHeader( header );
306 was gdcmHeader::gdcmHeader(bool) instead of the expected
307 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
308 Hence the parsing wasn't executed... See also below.
309 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
310 as explicit constructor didn't do the trick to fix the above problem.
311 Could anyone explain why ?
312 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
313 properly calls gdcmValEntry::Print() (that was weed out from
314 code related to gdcmBinEntry).
316 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * In order to fix memory leaks:
318 - Test/TestWriteSimple.cxx: added cleaning of free store through
320 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
321 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
322 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
323 (through the call to ::AddDicomDirMeta()) or the destructor
324 would crash when deleting uninitialized ::metaElems].
325 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
326 - src/gdcmDocument.cxx:
327 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
329 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
330 was causing memory leaks.
331 - src/gdcmSQItem.cxx:
332 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
333 cleanly handled with polymophism: sorry but my milage is low).
334 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
335 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
336 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
337 This avoids SegFaulting.
338 - src/gdcmSQItem.h: coding style.
340 - Test/TestWriteSimple still severely sucks. The output image content
341 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
342 damaged when displayed with vtkgdcmViewer.
343 - on memory leaks: TestWriteSimple leaks really less (see entry
344 of 2004-06-18 in Changelog file for the call to valgrind).
345 - on segfaults: ctest now passes all the tests but one (no more
347 * Erroneous leading white fix:
348 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
349 white[s] (as opposed to from >> xxx, that removes it [them].
350 - src/gdcmTS.cxx: ditto.
351 - gdcmPython/testSuite.py: dirty related kludge removed.
352 * src/*: remaining references to gdcmParser removed.
353 * src/*[cxx|h]: added copy[way]left header.
356 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * In order to fix writing of dicom files:
358 - Test/TestWriteSimple.cxx: a simpler example of writing.
359 - Test/CMakeLists.txt changed accordingly.
360 - src/gdcmDocument.cxx:
361 -- The destructor now recursilvely removes potential sequences.
362 -- Bug fix in ::IsJPEG2000()
363 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
364 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
366 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
367 to only declared) and build on top of
368 ::GetDocEntryByNumber(guint16, guint16).
369 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
370 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
371 for usage in destructor and treatement of promotion in
372 ::ReplaceOrCreateByNumber().
373 - src/gdcmSQItem.cxx: destructor should better handle his job.
374 Test/TestWriteSimple now runs (or at least it DOES something).
375 * We can now start hutting memory links. A good starting point is:
376 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
377 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
378 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
380 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * Valgrind note: after Mathieu Malaterre teached me how to read
382 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
384 Using gcc, you can force the STL to use malloc and to free memory as
385 soon as possible by globally disabling memory caching.
386 With 3.2.2 and later, you should export the environment variable
387 GLIBCPP_FORCE_NEW before running your program.
388 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
389 simply vanish (it is still not clear to me, whether this means that
390 STL std::string leaks or if valgrind believes it leaks...).
391 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
392 running bin/gdcmTests makeDicomDir):
393 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
394 - Test/makeDicomDir.cxx now properly traps empty lists and returns
396 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
397 SegFaulting (I drowned in DicomDir related code when trying to
398 understand why the list is empty...).
399 * src/gdcmDocument.h: first BSD license header try.
400 * Doc/License.txt added.
402 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * src/gdcmDocument.[h|cxx]:
404 - Clean up of the Transfer related predicates. They are now all based
405 on new method isGivenTransferSyntax, that (should) handle properly
407 - general clean up, simplification, and coding style.
408 - Specific clean up of Parse7FE0() (umproperly named actually).
409 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
411 2004-06-14 Jean-Pierre Roux
413 - fix the display of Sequence Delimitor (SQDepthLevel pb)
414 - fix the display of SQItem ordinal number
415 - add the GetSQItemByOrdinalNumber method
416 - remove some useless never written private methods
418 2004-06-14 Jean-Pierre Roux
420 - adding a constructor taking a gdcmDocEntry as an input param
421 - ReplaceOrCreateByNumber now returns :
422 a gdcmBinEntry * if a Binary (void *) value is passed as a param
423 a gdcmValEntry * if a string value is passed as a param
425 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
426 according to the param type (no longer sets a gdcmDocEntry)
427 - GetValEntryByNumber, GetBinEntryByNumber added
428 - NewValEntryByNumber and NewBinEntryByNumber added
430 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
432 - GetSQItemNumber and SetSQItemNumber added, to provide
433 a (relative) Item identier inside a given Sequence
434 \warning : some pb remaining around this number
436 - AddEntry now takes the Item Number as a param
438 - adding a constructor taking a gdcmDocEntry as an input param
440 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * Memory leak hunt with the following command:
442 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
443 --show-reachable=yes gdcmTests PrintDocument
444 It looks like many (all?) leaks are due to the STL (or a bad usage
445 of the STL. The lines producing the leaks now have a comment with
446 a "MEMORY LEAK" tag: you can retrieve them with
447 grep "MEMORY LEAK" src/*
448 Here are two typical examples which I can't help fixing:
453 char * test = "babo";
454 name = test; //// <--- valgrind detects 960 bytes lost in
455 //// call to std::string::operator=(char const*)
456 name.clear(); //// Doesn't help !
464 std::cout << "Type a bunch of characters followed by RETURN: ";
465 getline(std::cin, line); //// <--- valgrind dectects a loss
466 //// of 1320 bytes in call to
467 /// std::basic_istream<>& std::getline<>
473 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * src/gdcmHeader.[cxx|h]:
475 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
476 and related, moved away to gdcmDocument.
477 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
478 the corresponding protected accessors of inherited class
479 gdcmDocument, removed ! As a consequence gdcmFile had to be
480 declared friend of class gdcmDocument (see below).
481 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
482 - Clean up of undefined or unused methods.
483 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
484 account the changes to gdcmHeader.h).
485 * src/gdcmDocument.h:
486 - gdcmFile is now a friend class (in order to take into account the
487 changes to gdcmHeader.h).
488 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
489 (see changes to gdcmHeader.h).
490 - Accessors (reading on the form GetEntry*) are now public.
491 - Clean up of undefined or unused methods.
492 * src/gdcmDocument.cxx:
493 - adaptation to changes to gdcmDocument.h
494 - ::OpenFile now writes a verbose message when file cannot be opened.
495 - some std::string properly set to VRKey
496 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
497 references to gdcmDocument.
498 * Test/TestFindTags.cxx: changed accordingly to above changes.
499 * gdcmPython/testSuite.py: adapted to renaming of acr files in
500 cvs repository gdcmData.
502 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
503 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
504 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
505 conflicts with gdcmValEntry::voidArea.
506 * src/gdcmValEntry.cxx: unmatching comment wiped out.
507 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
508 Value representation between StringRepresentable and BinaryRepresentable.
509 * src/gdcmDocument.cxx:
510 - method ParseDES: proper indentation restored and usage of
511 gdcmVR::IsVROfGdcmStringRepresentable wired in.
512 - method LoadDocEntry: the fingerprint left in the SetValue() of
513 unloaded entries (length > MaxSizeLoadEntry) had curiously been
514 removed. Reverting to previous code segment with the proper
515 dynamic_cast< gdcmValEntry* >.
516 Note: this was (partially) breaking the python test suite
517 (gdcmPython/testSuite.py) that made usage of the above
518 fingerprint to check presence of "Pixel Data".
519 * src/gdcmDocEntry.h: coding style.
520 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
521 now taken into account.
522 * gdcmPython/gdcm.i: adaptation to the new internal representation
523 of gdcm (exit gdcmParser, hello gdcmDocument).
524 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
526 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
527 anymore, but instead prints the loaded Python dictionary.
528 * .... alas, the python testSuite is still broken.
530 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
531 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
533 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
534 * src/gdcmUtil.h : export methods
536 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
537 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
539 * Initial addition of automatic python testing
540 * Initial addition of automatic image comparison
542 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
544 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
546 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
548 * Test/ShowDicom.cxx : bug fix for msvc compilation
549 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
551 2004-05-04 Jean-Pierre Roux
552 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
553 new concepts (and new classes) :
554 a 'gdcmDocument' is composed of a set of Doc Entries, that are
555 - elementary gdcmDocEntries (former gdcmHeaderEntries)
556 - Sequence Doc Entries (gdcmSeqEntries)
557 a Sequence is composed of Items.
558 Each item is a set of Doc Entries (this is recursive)
559 The non uniqueness of the 'Dicom tag' is due to this recursivity
560 (never taken into account)
561 Our unability to add a new 'entry' in the header
562 at the proper location (neither in the H-Table (map or multimap),
563 nor in the Chained List is also due to this recursivity.
564 Don't try, right now, to use/modify/compile these new sources :
566 We just commit all the stuff, 'as is', in order not to loose it.
568 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
569 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
571 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
573 file prefix (SetFilePrefix)
575 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
576 * Add a new test: ShowDicom, for now this is just the c++ version of
577 checkRead.sh, later it will be able to compare the image read against a
579 * Replace the DEBUG on the stack with a global entry in cmake interface:
580 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
582 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
583 * Add an example subdir, with a real example on how to read + write a
586 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
587 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
588 * Doc/CMakeLists.txt: the main page is now properly differentiated
589 between the developper and user version.
590 * Doc/doxygen.config.in: dropped search related obsolete flags
591 * src/gdcmParser.h, gdcmHeader.h: doxygenation
593 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * DEVELOPPER: added some helpfull comments for compile/test/install
597 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
598 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
599 src directory, now generated in the build dir.
600 2. Tests as mentionned smarter
602 4. Add a new method in gdcmDict that return the PubDict by name
603 this is interesting for 3rd party lib like ITK,
604 where we could set the institution name / patient name...
606 * ENH: 1. Now the test suite is working for real
607 2. All binaries are now output in the gdcm-bin directory
608 (this was not true before)
610 2004-04-28 Jean-Pierre Roux
611 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
612 SeQuence indented printing of Dicom Header.
613 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
614 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
615 Computation of SQDepthLevel is now part of gdcmHeader constructor
616 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
617 tree-like structure of a Dicom Header.
618 * FIX Test code cleaning
620 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
621 * ENH: Adding automatic testing
622 1. Need a DartConfig.cmake to submit to public
623 2. Add a test driver gdcmTest.cxx
624 3. gdcmTestMain, an helper for the main test driver gdcmTest
625 4. Files in Test don't have a main anymore, this becomes interesting
626 when we add more and more tests, thus dsw don't have to load
628 * ENH: Adding a GDCM_DATA_ROOT for testing
629 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
630 one file instead of seven + some small cleanup
632 2004-04-22 Jean-Pierre Roux
633 * ENH Minor changes to the Print() methods.
634 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
635 Header printing. Example given with :
636 > PrintHeader fileName 2 new
637 (SQ based tree-like structure still to be done for the Header ...)
639 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
640 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
641 1. I have added some unsigned where needed
642 2. Some function parameter not used -> (void)
643 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
644 4. g++ don't like character '\' in comment
645 5. #define jpeg_create_decompress jCreaDecompress
646 this really need to be fixed
647 6. virtualize destructor of gdcmObject ... leakage
648 7. sscanf(g->first.c_str(),"%x",&gr_bid);
649 this also really need to be fixed
650 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
651 remove compression file
652 (as we only do decompression, right ?)
653 * ENH: Change malloc/calloc/free with c++ equivalent
655 2004-04-21 Jean-Pierre Roux
656 * FIX gdcmHeaderHelper::GetXSpacing
657 when a single value is found (bug ?), xpacing is now
658 defaulted to yspacing
660 2004-04-19 Jean-Pierre Roux
661 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
662 * ENH add parameters :
663 bool exception_on_error = false,
664 bool enable_sequences = false,
665 bool ignore_shadow = false
666 to the gdcmFile constructors to be full gdcmParser compliant
667 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
668 to allow reading of PAPYRUS 3.0 files
670 2004-04-06 Jean-Pierre Roux
671 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
673 2004-04-02 Jean-Pierre Roux
674 * ADD : Test/checksequence.sh, for a general recap on SQ pb
675 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
676 for Philips spurious Tag fffe|0000 while rewritting Dicom files
678 2004-03-30 Jean-Pierre Roux
679 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
680 for ACR file, written out as DICOM files (hope so...)
682 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
684 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
685 moved to base class gdcmParser and only the specialisation is kept
687 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
688 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
689 already does the job.
690 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
691 (to be consistent with gdcmParser::WriteEntries).
693 2004-03-30 Benoit Regrain
694 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
695 upate of the object's instance. It's passed to 2 in the unfavorable
696 case : one in the ExecuteInformation, one in the ExecuteData
698 2004-03-29 Jean-Pierre Roux
699 * ENH : Check on file type to be written moved
700 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
701 * FIX : gdcmObject::ResetBoundaries now stops properly
702 when end-of-list is reached
703 : gdcmVersion modified (as Benoit Regrain asked)
705 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
707 * src/gdcmUtil.cxx: added forgotten iostream include.
708 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
709 equivalent to ExplicitVR in existing code).
711 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
712 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
713 now contains all the gdcmGlobal related code.
714 * minor coding style and doxygenation changes.
716 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
718 now contains all the Debug related code.
719 * minor clean-up of includes in src/*.cxx
720 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
721 CreateCleanString) removed.
722 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
723 * Doc/DoxyMainPageUser.txt added.
724 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
725 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
728 2004-03-24 Jean-Pierre Roux
729 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
731 2004-03-23 Jean-Pierre Roux
732 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
733 big endian made volumes
734 * ENH Now gdcmParser constructor and destructor are protected to forbid
735 end user to instanciate class gdcmParser
736 (only gdcmHeader and gdcmDicomDir are meaningfull)
738 2004-03-22 Benoit Regrain
739 * FIX : src/gdcmDicomDir.cxx : make windows compilable
740 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
741 gdcmSerie to gdcmDicomDirSerie
743 2004-03-19 Jean-Pierre Roux
744 * ENH Now the tree-like structure describing a DICOMDIR comming from
745 an already existing DICOMDIR file is consistent with
746 the home-made tree-like structure build ex-nihilo
747 or build from the files held (recursively) in a Directory
748 functions gdcmDicomDir::CheckBoundaries()
749 gdcmObject::SetBoundaries() added
751 2004-03-17 Jean-Pierre Roux
752 * REM (Eric Boix bug) : removal of meaningless
753 gdcmDicomDirImage::NewImage function.
754 * FIX now file names and directory name are written properly in the
756 * FIX now gdcmDicomDir constructor may be call without any trick
759 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
760 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
761 of gdcmDicomDirImage::NewImage as empty function.
763 2004-02-28 Jean-Pierre Roux
764 * ENH add gdcmDicomDir:NewPatient
765 add gdcmDicomDirPatient:NewStudy
766 add gdcmDicomDirStudy:NewSerie
767 add gdcmDicomDirSerie:NewImage
768 to allow making gdcDicomDir object.
769 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
770 (as opposite to the gdcmHeader chained list)
772 2004-02-11 Benoit Regrain
773 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
774 when using from python
776 2004-02-10 Benoit Regrain
777 * FIX : bug fix in the gdcmDirList for the recursivity in directories
778 * FIX : in gdcmDicomDir when the directory is empty
779 * ENH : add callback and methods to get the progression of dicomDir
782 2004-02-06 Jean-Pierre Roux
783 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
784 - GDCM_META added to gdcmDicomDirType
785 - class gdcmMeta created
786 * ENH : - A brief summary is now displayed at the beginning of
787 'testDicomDir' to help disaster magnitude estimation
788 * REM : Now useless Test/explDICOMDIR.cxx
790 2004-02-05 Benoit Regrain
791 * ENH : add methods in gdcmObject to get the hash table or the list of
793 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
794 * FIX : wrapping python for TagHeaderEntryHT
796 2004-02-04 Benoit Regrain
797 * FIX : even length for some strings when writting the dicom dir
798 * FIX : sort the images in the dicom dir
799 * FIX : Bug fix for python use of dicom dir
800 * ADD : a python demo
802 2004-02-04 Jean-Pierre Roux
803 * FIX : Final solution (?) for icone embedded images
804 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
805 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
806 add groups 6002, 6004, 6006, to allow 'clean' parsing of
807 gdcmData/gdcm-MR-SIEMENS-16.acr1
808 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
809 to make full checking easier
811 2004-02-04 Benoit Regrain
812 * FIX : WriteEntries : coding style & logic in parameters
813 * FIX : Set the elements to create the DicomDir in a dictionary file
815 2004-02-03 Benoit Regrain
816 * gdcmDirList : to parse a hard drive directory in recursive (or not)
817 * gdcmDicomDir : add the load of directory
818 * Bug fix and print add-on
820 2004-02-03 Jean-Pierre Roux
821 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
822 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
823 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
824 * FIX gdcmParser.cxx : 'group length' elements are now considered
825 as integers, even for shadow groups, when file is Implicit VR
827 2004-02-02 Jean-Pierre Roux
828 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
830 of the last synonym :-(
831 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
833 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
834 * FIX taking into account the possible 7fe0,0010 multiplicity
835 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
836 to allow removal of references to 7fe0,0010, to deal with
837 ACR-NEMA images, when 0028,0200 is meaningfull
839 2004-01-31 Jean-Pierre Roux
840 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
841 no longer writes 'Un' on disk
842 * FIX SQ elements with actual length are now dealt with corectly
843 * FIX gdcmFile::WriteBase make the difference, for color images, between
844 the length (for Palette expanded images)
845 and Raw Length (non expanded image + Palette)
846 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
847 (that broke Write). Replaced by UL.
848 Aware user will reload the field if he
849 thinks it's necesssary
851 2004-01-30 Jean-Pierre Roux
852 * gdcmParser::CheckSwap() now defaults the filetype to ACR
853 when 'dirty Acr' is found, to be compliant with the new
854 IsReadable() methods.
856 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
857 (no DOUBLE images in kosher DICOM,
858 but so usefull for people that miss them ;-)
860 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
861 DICOMDIR related utilities (not checked as Windoze compliant)
863 2004-01-28 Jean-Pierre Roux
864 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
866 2004-01-27 Jean-Pierre Roux
867 * gdcmParser constructor has a new boolean param,'ignore_shadow',
868 to allow skipping the shadow elements, to save memory space.
869 The TRUE value for this param has to be used
870 with a FALSE value for the 'enable_sequence' param.
871 ('public elements' may be embedded in 'shadow Sequences')
872 * gdcmHeader methods now deal with 'embedded icones images' in the header
873 (even when an 'icone image sequence' is announced by the
874 element (0x0088,0x0200), but there is NO icone at all ...
876 * gdcmHeader sometimes Image Location value doesn't follow
877 the supposed processor endianity (see gdcmData/cr172241.dcm).
880 * gdcmHeader add the method
881 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
882 to get *all* the Header Entries with the same tag.
883 GetHeaderEntrySameName is probabely *useless*
884 (no meaning : Name is *not* an identifier within the Dictionnary)
886 2004-01-26 Benoit Regrain
887 * Bug fix in the print of hexadecimal representations. Remove long fields
888 in the print and add a third level of print to print them
890 2004-01-23 Benoit Regrain
891 * Bug fix on field having a VR = 'UI'. Assume that is a string field
892 * Bug fix on test suite after remove the strip made on not string fields
893 * Split the IsReadable method between gdcmParser which test that the file
894 is dicom and gdcmHeader which test that it's an image file
896 2004-01-22 Benoit Regrain
897 * DicomDir : clean code, add methods, set variables in protected or private
898 * gdcmUtil : bug fix for the clean string method
900 2004-01-19 Benoit Regrain
901 * Add the use of shadow dictionaries
902 * bug fix and coding style
904 2004-01-19 Benoit Regrain
905 * src/gdcmFile.cxx : bug fix concerning the close of file
906 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
907 * Add the update of header entries using the shadow library
909 2004-01-19 Benoit Regrain
910 * removal of file gdcmHeader2.cxx
911 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
912 inheriting from gdcmParser. This split is to prepare the integration
914 * bug fix under python
916 2004-01-16 Jean-Pierre Roux
917 * REM removal of class gdcmHeaderEntrySet
918 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
919 * ADD add file gdcmHeader2.cxx
920 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
922 2004-01-15 Benoit Regrain
923 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
924 entries created while parsing the header. Thus, they will be destroyed
925 when the gdcmDictSet will be destroyed
926 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
929 2004-01-15 Benoit Regrain
930 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
931 made a fatal error because of the memory release at the end of program.
932 The problem was in vtkGdcmReader::ExecuteData where we were allocate
933 some memory and vtk seems to have some problems with that.
934 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
936 2004-01-14 Benoit Regrain
937 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
938 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
939 * src/*.[h|cxx] : make changes due to class name changes
940 * gdcmPython/demo/*.py : bug fix due to method names
942 2004-01-13 Benoit Regrain
943 * src/*.[h|cxx] : coding style
944 * vtk/*.[h|cxx] : coding style
946 2004-01-13 Benoit Regrain
947 * gdcmPython/testSuite.py : test the readable flag of file for tests
948 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
949 It's lied to the stl compilation by MSVC (windows, always windows...)
950 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
952 2004-01-12 Benoit Regrain
953 * src/*.h : add comments
954 * src/gdcmDictSet.h : set the method BuildDictPath in public
955 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
956 directly setted in the source code
957 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
960 2004-01-09 Benoit Regrain
961 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
962 * setup.py : use a reference to gdcmVERSION
964 2004-01-07 Benoit Regrain
965 * Modification to compile with the distutils.
968 2003-12-10 Benoit Regrain
969 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
970 can use a gdcmHeaderHelper to load datas
971 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
972 made in the source code
974 2003-12-10 Benoit Regrain
975 * Update Windows projects and .cvsignore files
977 2003-11-12 Jean-Pierre Roux
978 * ENH gdcmHeader constructor has one more parameter (default value : false)
979 that allows the user to 'go inside' the SeQuences only
981 gdcmElValSet:Print takes it into account
983 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * ENH: Update gdcmPython/CMakeLists
985 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
986 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
988 2003-11-10 Jean-Pierre Roux
989 * FIX : gdcmHeader::LoadElements is now based
990 on the ListTag listElem member,
991 not longer on the TagElValueHT tagHt member
992 * ENH : PrintPubElVal shows (temporarily) both results,
993 with the tagHt member and the listElem member.
994 (it's easier to 'see' the problems when using Printheader)
996 * FIX : old private member LgrElem is now splitted into
997 ReadLength : Length actually found on disk (updated only
998 if bug fixing is necessary), for internal
1000 UsableLength : Updated by FixFoundLength, to fix a bug
1001 or to allow Parser going on.
1002 Will allow to re-write a kosher header when a SeQuence
1003 with a length (not 0000) is found
1004 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1005 because gdcmElValSet::Add does not update ListElem
1008 2003-11-07 Jean-Pierre Roux
1009 * FIX misstyping in Transfert Syntax name table
1010 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1011 when they have an actual length (not 0000 nor FFFFF)
1012 (Nobody should care of it, but DICOMDIR explorers)
1014 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1017 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1018 * ENH: vtkGdcmReader now supports LUT !
1019 (vtkgdcmViewer for now is not able to use them though)
1021 2003-11-05 Jean-Pierre Roux
1022 * in testSuite.py : new files names for checking the package
1023 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1024 that returns the pixel area size to the *aware* (vtk) user
1025 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1027 2003-11-05 Benoit Regrain
1028 * in testSuite.py : Modify the rules for checking the paths
1029 : Explicit error messages
1030 * in __init__.py : Related modif
1032 2003-11-03 Jean-Pierre Roux
1033 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1034 to be used by aware (vtk) users that want to manage
1035 LUT (and no to turn the PALETTE image into an RGB pixels one)
1036 * GetPixelType now returns 8U for 24 Bits images
1037 (vtkGdcmReader compliant)
1039 2003-10-31 Jean-Pierre Roux
1040 * Removal of *all* gdcmData images and add them again
1041 in order to loose the 'history' of un-anonymised images
1043 2003-10-31 Jean-Pierre Roux
1044 * RMV : removal of useless jBitsInJsample.h
1045 for both 8 and 12 Bits JPEG Lossy Libraries
1047 2003-10-31 Jean-Pierre Roux
1048 * ENH : Add the functions gdcmFile::GetImageDataRaw
1049 gdcmFile::GetImageDataIntoVectorRaw
1050 that act as GetImageData and GetImageDataIntoVector
1051 except the making of an RGB Plane from Gray Plane + LUT
1052 Intended to aware (vtk) users who know how to manage
1055 GetLUTRGBA return a R,G,B,A LUT if any
1056 lgrTotaleRaw gives the 'Raw' length
1057 GetImageDataRaw returns the gray Plane
1058 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1059 (They stay Grey, just like with other Dicom viewers :-(
1061 2003-10-30 Jean-Pierre Roux
1062 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1064 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1065 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1066 being coherents dicom files.
1068 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1069 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1071 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1072 * ENH: Two steps is necessary to please VC++ compiler...
1073 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1074 * ENH: Add include dir to medcon lib
1075 * FIX: only one function is being exported for now !
1076 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1078 2003-10-29 Jean-Pierre Roux
1079 * adding gdcmHeader::GetLUTRGBA
1080 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1081 --> Mathieu, the modif u're waiting for is not yet committed
1082 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1084 2003-10-27 Jean-Pierre Roux
1085 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1086 00191113.dcm DermaColorLossLess.dcm
1087 MxTwinLossLess.dcm RadBWLossLess.dcm
1088 * ENH: For version prior to vtkImageViewer2 -r 1.19
1089 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1091 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1092 * Removal of ido stuff in CMakeLists.txt
1094 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1095 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1096 * FIX: remove a call to ->Modified ... see comments
1097 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1099 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1100 * FIX: Problem with path for libvtkgdcmPython
1101 * ENH: Try adding a search script for python site-package
1102 * RMV: Remove some file from medcon lib that are not necessary
1103 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1104 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1105 * FIX: More pragma disable fro VC++,
1106 I don't think I break something as it is also disable in VTK/ITK.
1107 But it fasten debug compilation time.
1109 2003-10-23 Jean-Pierre Roux
1110 * gdcm now deals with 16 Bits Run Length Encoded images
1111 (they are compressed as 2 planes images,
1112 one for the high Bytes, the other for low Bytes)
1114 2003-10-22 Jean-Pierre Roux
1115 * Now CheckRead takes into account :
1116 - the bugged 'Leonardo' Siemens images
1117 - the XA images, sent thru the burning VPRO station
1118 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1121 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1122 * FIX: When copying a Makefile.am to CMakeLists.txt
1123 one should remove the '\'
1125 2003-10-22 Jean-Pierre Roux
1126 * in gdcmData adding a bugged 'Leonardo' Siemens image
1127 (wrong lengths in header)
1128 OK with gdcm, KO with the other viewers :-)
1129 * add a GE dlx XA image, thru the VEPRO burning station
1132 2003-10-21 Jean-Pierre Roux
1133 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1134 for a brutal checking of vtkgdcmViewer compliance
1136 2003-10-21 Jean-Pierre Roux
1137 * add the files for 'xmedcon' Jpeg Lossless library
1138 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1140 2003-10-21 Jean-Pierre Roux
1141 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1143 2003-10-21 Jean-Pierre Roux
1144 * garbage Siemens 'Leonardo' images dealt with
1145 (the patch is easy to remove)
1146 * cosmetic changes to avoid warnings
1148 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1149 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1150 no need to press 'r' now.
1152 2003-10-20 Jean-Pierre Roux
1153 * upgrade of checkRead.sh checkWrite.sh according
1154 to new Jpeg Lossless decompressor
1155 * add US.3405.1.dcm, a genuine RGB medical file ...
1156 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1157 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1159 2003-10-15 Jean-Pierre Roux
1160 * general anonymisation in gdcmData
1161 * adding the 'color files' from
1162 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1163 * adding some well knowed bugged-header images
1164 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1165 waiting for their inclusion in Python testsuite
1167 2003-10-15 Jean-Pierre Roux
1168 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1169 no longer seg faults when file is not found
1171 2003-10-14 Jean-Pierre Roux
1172 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1175 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1176 * TODO: *.in file to genereate a UseGDCM later
1178 2003-10-14 Jean-Pierre Roux
1179 * Some supposed-to-be Dicom Images have no preamble.
1180 OpenFile takes it into account
1181 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1182 * Missing elements added in dicomV3.dic
1183 (just to be affraid : have a look at
1184 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1185 and do it again next year ;->
1187 2003-10-13 Jean-Pierre Roux
1188 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1189 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1190 But there are NOT. It's fixed !
1192 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1193 * FIX: "jpeglib.h" was not found on VC++
1194 * FIX: vtkgdcm was not being installed
1196 2003-10-10 Jean-Pierre Roux
1197 * ENH : OpenFile closes the file if it *really* doesn't look like
1198 an ACR-NEMA / DICOM one.
1199 * FIX : testWrite no longer writes an empty file if the source file
1200 is not gdcm Readable
1201 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1204 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1205 * FIX: CMake generate now documentation
1206 * ENH: out of source doc build !
1207 * ENH: Generate both user and dev documentation
1208 * ENH: Should work on windows too
1209 * ENH: Only one doxygen config.in file is needed
1210 * FIX: make install should be ok now on ùnix plateform
1211 * FIX: PATH to dictionary was wrong (missing /)
1212 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1214 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1215 * vtkGdcmReader is now able to read rgb dicom file.
1216 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1217 * added a gdcmViewer to vtk test, use mouse to control
1218 window level & window width
1220 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1221 * CMake-ification of gdcm, we have now two build system
1222 * FIX: on cygwin Wsock32 doesn't exist
1223 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1225 2003-10-06 Emanuel Ollart
1226 * FIX : compilation process wad broken.
1227 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1229 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1230 * change gdcmViewer -> vtkgdcmViewer
1231 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1233 2003-10-06 Jean-Pierre Roux
1234 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1235 ( e.g : well known GE images with a wrong elem length,
1236 : Philips MRI Images with a wrong Huffman table)
1237 * still to be done : allow the reading of bugged LEONARDO Siemens images
1239 2003-10-03 Jean-Pierre Roux
1240 * Odd length strings are padded with '\0' (not with spaces,
1241 to remain compliant with already defined strings,
1242 like Transfert Syntax UID and others)
1244 2003-10-03 Jean-Pierre Roux
1245 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1246 to allow displaying RGB images (not only by affim ;-)
1248 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1249 * vtkGdcmReader is now able to read rgb dicom file.
1250 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1252 2003-10-03 Jean-Pierre Roux
1253 * A few nasty patches to allow the reading of a lot of nasty images
1254 ( e.g : well known GE images with a wrong elem length,
1255 : Philips MRI Images with a wrong Huffman table)
1256 * still to be done : allow the reading of bugged LEONARDO Siemens images
1258 2003-10-03 Jean-Pierre Roux
1259 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1261 2003-10-03 Jean-Pierre Roux
1262 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1263 to allow displaying RGB images (not only by affim ;-)
1265 2003-10-03 Jean-Pierre Roux
1266 * gdcmFile::GetImageDataIntoVector now
1267 - deals with MultiFrames MultiFragments Run Length Encoded files
1268 - deals with YcBcR (YBR_FULL) files
1269 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1270 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1272 (no sample found :-(
1274 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1275 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1276 Two reasons: - clear things
1277 - third parties acces gdcm through header files, so won't
1278 suffer anymore VC++ complains
1280 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1281 * add argv[1] in testvtkGdcmReader.cxx
1284 2003-09-24 Jean-Pierre Roux
1285 * The lines are now eigthy characters long.for
1286 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1288 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1289 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1290 char* to std::string. Thus, the use of strdup becomes useless. (see
1291 previous commis of Malaterre)
1292 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1293 before the last Malaterre's commit.
1295 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1296 * This commit should fix the Debug building under VC++, the problem
1297 was mainly a mixture of debug and release lib being loaded at startup.
1298 * I also remove a depency to a specific C function: strdup. Because I had
1299 to force the link to msvcrtd (whereas strdup is in libc).
1301 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1302 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1303 located in the gdcmCommon.h file. All use of reference of tha has been
1304 changed to now use the variable GDCM_UNFOUND.
1306 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1308 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1309 Dicom dictionary. The test suite can now be run again. Note:
1310 I'm note very happy with the " (RET)" changes. I believe this
1311 RETAINED comment should be dropped when parsing the dictionary.
1312 - PACKAGER corrected
1314 - AUTHORS updated and now in alphabetical order
1315 * Makefile.am now exports gdcm.dsw for Windoze users.
1317 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1318 * cygwin complains about missing std:: in subdir Test/
1320 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1321 * remove some methods that are now in gdcmHeaderHelper
1323 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * vtkGdcmReader set spacing and origin correctly
1326 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1327 * Fix a few delete/delete[] mismatch
1329 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1330 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1331 interpretation to data given by gdcmHeader. For instance there are
1332 heuristics to get informations (look at different places).
1333 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1334 sorting DICOM images based on different strategies.
1335 * modified Makefiles accordingly.
1337 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1338 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1339 when building in debug mode
1340 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1341 src/win32/gdcmdll.dsp
1342 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1344 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1345 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1348 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1349 * src/win32/libgdcmjpeg12.dsp was not dos format
1350 * src/win32/libgdcmjpeg12.dsp :
1351 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1352 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1354 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1355 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1357 * src/gdcmFile.cxx : bug fix in affectation type
1358 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1359 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1360 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1361 symbols... future problem ?
1363 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1364 * src/win32/libgdcmijpeg12.dsp was missing
1365 * modified gdcm.dsw accordingly
1367 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1368 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1370 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1371 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1372 commit of JPR (before his hollidays to facilitate our work).
1373 * setup.py : bug fix in code. Modifications made while the last commit
1374 of JPR. The code hasn't been tested before the commit... it's so
1375 useless to make that (for best programmer that is JPR) !!!
1377 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * tagged the current version as Version0_3 (i.e. version 0.3)
1380 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1382 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1383 * *.dsp : modifications to use new libgdcmijpeg8 library
1384 * setup.py : bug fix on VTKPATH variable
1385 * PACKAGER : adding all concerning windows
1387 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1388 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1390 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1391 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1392 test suite reported error.
1393 * PACKAGER file added (describes what a packager must do when
1394 packaging a new release).
1395 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1396 * configure.in: upgraded version number to 0.3.0
1397 * fixing build of rpm (through rpm -ta):
1398 - Doc/Makefile.am exports proper doxygen files
1399 - src/jpeg/libijg8/Makefile.am exports the include files.
1401 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1402 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1403 * src/gdcmHeader.h : formatting code
1405 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1407 We were obtaining error message from vtk. Now, creation of file list
1408 is made in an internal list to prevent this problem.
1409 Bug fix when output is empty.
1410 Bug fix in update of progress value. Previous commit for this was a bad
1412 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1414 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1415 * src/gdcmHeader.h : added method to get the file name
1416 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1417 files. Added method to remove all files on the input
1418 Added FIXME comment concerning the bad parsing of header made by
1419 ExecuteInformation method (in ExecuteData method)
1421 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1423 when using make instal.
1424 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1425 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1427 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1428 * setup.py : adding include dir of jpeg lib to compile all sources
1429 * */Win32/*.dsp : JPR fix for windows compilation
1431 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1432 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1434 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1435 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1437 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * setup.py is again effective on un*x (takes into account the
1439 addon of the jpeg library)
1440 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1441 * Doc/Doxy* updated (includes above enhancements)
1442 * INSTALL now points to web documentation
1444 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * src/gdcmHeader.h doesn't make unnecessary reference to
1447 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1449 * src/gdcm*.[cxx|h] :
1450 - to allow compilation with gcc 3.x
1451 -- clean up of STL usage (added explicit usage of std::)
1452 -- small fixes on exceptions.
1453 Note: linking not tested !
1454 - clean of doxygen comments to avoid warnings at documentation
1456 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1457 dependent convertion).
1459 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1460 * Clean up of previous JPR garbage commit (not even commented in the
1462 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1463 - moved all jpeg related files from src to src/jpeg/libijg8, with
1464 addition/modification of Makefile.am and configure.in.
1465 - the testSuite is still brain damage (not guilty).
1467 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1468 * WrapVTK.py : modifications to get correctly vtk source files to
1470 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1471 (FileName -> Filename)
1473 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * vtk/vtkGdcmReader.[cxx/h]:
1475 - UpdateProgress method should now be effective
1476 - removed the limitation on having only images loaded (as opposed
1478 - when building a stack of images/volume, a lesser number of
1479 gdcmHeader and gdcmFile instances should be used (hopefully
1480 accelerating things).
1481 - when building a stack of images/volumes, files which are not
1482 loadable (wrong path-filename, wrong permissions on existing file,
1483 or file not parsable by gdcm) are replaced with a black image
1484 in the stack (for the caller to notice the problem).
1486 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1489 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1490 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1491 between standard library (std) and vtk library (problems are found
1492 under Windows... thanks Windows !)
1494 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1495 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1497 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1499 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1500 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1502 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1503 * When compiling with distutils (see setup.py) the C++ compiler is
1504 called with different flags than the default ones (with automake).
1505 In order to fix all those warning, I compiled gdcm with the command
1506 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1507 and went for warning fixes:
1508 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1509 up from unused variables.
1510 - vtk/vtkGdcmReader.cxx: potential bug fix.
1511 * src/gdcmHeader.h: Doxygen warning cleanup
1513 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * gdcmPython/gdcm.i:
1515 - typemaps correction to take into account the systematic replacement
1516 of "using namespace std" with std:: prefix e.g. std::list,
1517 std::string... (cf changes of 2003-05-21).
1518 - gdcmGlob global variable of type gdcmGlobal (defined in
1519 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1520 exported to Python a as cvar.
1521 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1522 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1523 gdcmDictSet.GetPubDictTagNames() and
1524 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1525 C++ static methods).
1526 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1527 with the above changes.
1529 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1530 * setup.py, manifest.in : bug fix under linux
1532 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1533 * Modification of setup.py to compile vtk part too. Then, we have 2
1534 wrappers which must work with same distutils. For that, we have a
1535 generic distutils in distusiltsWrapping.py ; with :
1536 - build_extWrap class to wrap generically all extensions,
1537 - ExtensionWrap base class for all wrapping extension that contains
1539 - Wrapper interface which wrap sources
1540 + In WrapSwig.py we have extension and wrapper for Swig
1541 + In WrapVTK.py we have extension and wrapper for VTK
1542 * MANIFEST.in : modifications to consider vtk directory and new python
1543 files for compilation
1545 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1546 * Added python wrappers of vtkGdcmReader vtk class (see the
1547 source in vtk/vtkGdcmReader.cxx) :
1548 - vtk/Makefile.am now builds a library
1549 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1550 python library (as opposed to _gdcm.so wich are the python
1551 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1552 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1554 - configure.in has an additional flag --enable-vtk that needs
1555 to be set to enable compilation of vtk related code, that is:
1556 + vtk/vtkGdcmReader.so and
1557 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1558 + gdcmPython/vtkgdcmPython.so (see above)
1559 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1560 be read when compressed or when HighBit + 1 != BitsStored),
1561 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1562 the usage of the python wrapper of vtkGdcmReader vtk class.
1563 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1564 * src/*.[h] all occurences of stl classes are now prefixed with
1565 std::, and all occurences of "using namespace std;" where removed.
1566 This is to avoid pollution of global namespace in included files.
1567 Apparently vtk does not avoid this pitfall: when using both
1568 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1569 collision of various stl members (principally cout...).
1570 * gdcmPython/testSuite.py now cleanly removes temprory generated
1572 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1573 comply with above changes)
1575 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1576 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1577 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1578 vtk data structure (an image Flip was required).
1579 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1580 * cosmetic changes in documentation.
1582 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1583 * src/gdcmHeader.cxx: the constructor no longer exits when an
1584 unexisting file is given as argument.
1585 * The subdirectory Data (containing all the images used for the
1586 test suite) is not part of this repository anymore. A new module
1587 containing those images is now available at
1588 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1589 with the name gdcmData.
1590 All the python scripts (including the package initialisation file
1591 gdcmPython/__init__.py) were adapated to take this change into
1592 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1594 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1595 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1596 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1597 demo of the usage of this class.
1598 Compilation of this vtk part is only done when using the --enable-vtk
1599 at configure (or autogen.sh) stage.
1601 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1602 * More memory link related corrections and documentation fixes.
1604 - maximum info is obtained with a command of the form:
1605 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1606 --show-reachable=yes PrintHeader
1607 - the remaining reachable blocks seem to come from the STL
1608 allocation scheme through the usage of map and list. It looks
1609 like this memory cannot be freed but it is not a memory leak
1610 (in fact further invocation to the STL would recollect the
1611 unused memory allthough it cannot explicitely be freed).
1612 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1613 of displaying an image parsed with gdcm and displayed with VTK.
1614 Note: some images don't seem to work e.g.
1615 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1616 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1617 Allthough this weakens the semantics, it is a ditch attempt to
1618 make gdcm more thread friendly.
1620 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1621 * Memory link hunt (by using valgrind through the command
1622 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1623 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1624 gdcmHeader::_dicom_vr.
1625 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1626 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1628 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1630 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1631 * src/Makefile.am now exports all the necessary include files at
1635 * UpdateGroupLength replaced by new one
1638 * UpdateGroupLength re-written using H-Table
1639 (named UpdateGroupLengthNew untill checks are over)
1641 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1642 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1643 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1645 - gdcmHeader::GetPubElValSet removed.
1646 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1647 UpdateGroupLength, WriteElements, Write.
1648 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1649 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1650 carried the same semantics.
1651 - src/gdcmHeaderIdo.cxx changed accordingly.
1652 - gdcmFile::WriteBase now regroups all the codes from previous
1653 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1654 - enum FileType moved to gdcmCommon.h
1655 * src/gdcmHeader.cxx AddDefault trashed
1656 * gdcmGetXSize added
1657 * getimageDataSize now calls gdcmGetXSize
1658 * Test/*.cxx changed to agree with above changes
1660 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1661 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1662 (to avoid double call by end user).
1663 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1664 by end user, since gdcmHeader::gdcmHeader now handles it.
1666 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * gdcm/Doc many doxygen changes:
1668 - Doxyfile now has two different versions, DoxyfileUsers that generates
1669 the html.users end users oriented documentation and
1670 DoxyfileDeveloppers that generates the html.developper developper
1671 oriented documentation.
1672 - README changed accordingly
1673 - requirement.txt removed (old design info moved to TODO).
1674 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1675 DoxyMainPage.txt, DoxyPython.txt provide more information.
1676 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1677 be updated by simply regenerating the docs with doxygen and copying
1678 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1679 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1680 all the tests in the form "if (<map>.count() >1)" were removed.
1681 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1682 ill-formed documentation sections.
1683 * src/gdcmHeader.cxx: ditto
1685 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1686 * setup.py fixed for un*x (needed macro for stdint.h)
1687 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1688 un*ces with sh-utils test utility.
1689 * gdcmPython/demo/test.py renamed to PrintHeader.py
1690 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1691 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1692 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1693 * src/gdcm*.cxx JPR's bad inclusion fixed.
1695 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1697 * gdcmPython/demo/test.py changed accordingly.
1699 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * gdcmPython/Makefile.am fixed linking against libstdc++
1701 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1702 * Swig subdir (historical tests of swig version 1.3.17++) removed
1703 * Test/testChangeEntete.cxx some lines commented out in order to make
1705 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1706 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1708 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1709 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1710 hence the user doesn't need this explicit call.
1711 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1712 i.e. LoadElements() call removed.
1713 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1714 - src/Makefile.am declares the proper flag for g++.
1715 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1716 for adding user defined new tags.
1717 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1718 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1719 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1721 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1722 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1723 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1724 src/Makefile.am : the project should properly compile and install
1725 with the autotools, included the python wrappers part.
1726 * gdcm.spec.in : added a spec file for RPM packaging.
1728 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1729 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1731 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1732 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1733 to exported to the environement (see gdcmPython/testSuite.py
1735 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1736 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1737 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1738 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1739 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1741 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1742 * gdcmPython/__init__.py doesn't crash anymore when running in
1743 in InstallMode or PreInstallMode but with an environement given
1744 value of GDCM_DICT_PATH.
1745 * src/gdcmDictSet.[cxx/h] coding style.
1747 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1748 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1749 * src/gdcm.h general comments moved to TODO, and README
1750 * src/gdcm.h should now be seen as a user commodity (including it
1751 should suffice to fully use gdcm). It is nowhere including within
1752 any of the kernel files src/*.cxx and src/*.h.
1754 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1755 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1756 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1758 * src/gdcm*.cxx only include their corresponding include file
1759 (as opposed to gdcm.h)
1760 * gdcmPython/gdcm.i changed accordingly
1761 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1762 the autogen.sh generated "make snapshot" command to work.
1763 * autogen.sh removed history related references to crea package.
1765 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * distutilsSwigCPlusPlus.py work around some swig portability
1769 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1771 was done in a last ditch attempt to get setup.py _really_
1772 operationnal. The python/gdcmPython layaout add the advantage
1773 of hidding away the python related distutils specific files
1774 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1775 Alas, the src directory was out of scope (i.e. it's relative
1776 position to setup.py was ../src) which made things impossible to
1777 handle (see previous version of python/setup.py). Crossing fingers...
1779 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * python/setup.py now works on Un*x. (harder than I thougth)
1781 * python/distutilsSwigCPlusPlus.py can now have include files
1782 among the list of sources.
1784 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1785 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1786 * modifications in MSVC projects
1788 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1789 * As stated by the first lines of Test/ExceptionAndPython/README, it
1790 looks like we can move back to original usage of exception within
1791 src/gdcm* and hence remove the errno stuff that was introduced
1792 as a quick and dirty fixture of this problem (added to the TODO).
1793 * Doc/Doxyfile configuration file for Doxygen and corresponding
1794 README file for usage added.
1795 * Test/testWrite.cxx added. This new test comes from a split of
1796 test.cxx that is now reverted to its original purpous i.e.
1797 testing the proper parsing of a Dicom related file.
1798 testWrite.cxx concentrates on testing the IO part of gdcm.
1799 * Test/bug1.cxx (containing a bug on WIn32) added.
1800 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1801 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1802 whose purpose is to publish the content of the TagNames of the
1803 Dicom public dictionnary were not accessible without an
1804 instance of class gdcmHeader.
1805 - those methods are now static methods of gdcmDictSet and hence
1806 require no instances at all to be invocated.
1807 - within gdcmDictSet this change required to change some method
1808 to class methods (i.e. are now static) among which SetDictPath
1809 (renamed to BuildDictPath) and LoadDefaultPubDict.
1810 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1811 the above changes by calling the new method classes of gdcmDictSet.
1812 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1813 the above to be effective.
1814 * python/gdcmPython: in order to wrap properly the above changes
1815 for Python, swig version now needs to be > 1.3.17.
1816 * python/gdcmPython/Makefile fixed to adapt itself to new
1817 configure/make shema introduced by Johan Montagnat (thanks for the
1818 contribution). Alas this Makefile cannot be turned into a proper
1819 Makefile.am without some heavy changes in the configure.in
1820 (for python dectection).
1821 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1822 now avoids publishing the empty entries.
1824 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * python/setup.py : bug fix concerning install under windows
1826 ExtraPath reused :-P
1827 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1829 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1830 * Dicts/dicomV3.dic : remove double spaces !!!
1831 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1832 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1835 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1836 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1837 method. Doxygenation.
1838 * src/gdcm.h clean up of JPR spurious comments.
1840 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * python/distutilsSwigCPlusPlus.py now properly collects the
1842 shadow classes generated by "swig -c++" (gdcm.py in our case)
1843 when using "python setup.py install".
1844 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1845 reexports the working classes.
1846 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1847 by the classical C errno scheme. This is to prevent an obscure
1848 behavior of the python wrappers when importing wxPython.wx prior
1849 to gdcmPython (which ended up in an abort call). An illustration
1850 of this oddity can be found in the Test/ExceptionAndPython
1851 subdir (see the README file). This problem probably due to
1852 an combination of g++ and dynamic loading.
1853 * added Test/ExceptionAndPython (see above)
1855 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1856 * Changed the layout of the python part to avoid bloating main
1857 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1858 i.e. the distutils arsenal. All the python related stuff is
1859 again in a python subdir, but the package itself is now in
1861 * setup.py was cleaned up:
1862 - pythonIncludePath removed
1863 - python setup.py bdist target is now functional.
1864 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1865 collision with other packages). gdcmPython/demo/*.py changed
1868 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1869 * python subdir moved to gdcmPython (preparation of distutils packaging).
1870 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1871 distutils installer is operational.
1872 * - gdcmPython/__init__.py now properly loads the swig generated
1873 shadow classes (from gdcm.py).
1874 - gdcmPython/demo/*.py changed to import the package gdcmPython
1875 instead of gdcmPython/demo/load.py.
1876 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1878 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1880 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1881 entries within the associated public Dicom dictionary resp. the same
1882 information but sorted by the fourth field (PAT, IMG, DIR) of the
1884 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1885 are now in the "???" group.
1886 - python/gdcm.i changed accordingly,
1887 - python/demo/printGroupedPublicDict.py added, that gives an example
1888 of the above new functionalities in Python.
1890 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * src/gdcm.h, gdcmHeader.cxx:
1892 - historic references to glib's g_malloc and g_free (#defined)
1893 were definitively removed.
1894 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1895 * src/gdcmElValSet.cxx:
1896 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1897 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1898 - GetElValue(string) renamed to GetElValueByName.
1899 - Added GetElementByName(string).
1900 * src/gdcmHeader.cxx: added
1901 - GetPubElValRepByNumber(guint16, guint16)
1902 - GetPubElValRepByName(string)
1903 - GetShaElValRepByNumber(guint16, guint16)
1904 - GetShaElValRepByName(string)
1905 - GetShaElValByNumber(guint16, guint16)
1906 - GetShaElValRepByName(string)
1907 - GetElValRepByNumber(guint16, guint16)
1908 - GetElValRepByName(string)
1909 - GetElValByNumber(guint16, guint16)
1910 - GetElValRepByName(string)
1911 * Doc/requirements.txt added.
1913 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * Test/Makefile building now depends on the one of libgdcm.so
1915 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1916 pixel data) aware which enables finding the address (offset) of
1917 the pixel data of JPEG encoded DICOM files. This leaves only a single
1918 file in the testSuite whose pixel data address (offset) is unknown.
1919 * python/testSuite.py changed accordingly.
1921 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1922 * VC++ has some strong limitations when working with the STL, as stated
1923 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1924 "Also note that some STL containers (map, set, queue, list, deque)
1925 cannot be exported. [...]
1926 Some STL classes contain nested classes. These classes can not
1928 This is caused by a designed limitation that once a template
1929 class is instantiated, it can not be re-instantiated and
1931 Since our usage of map<> is ubiquitous in gdcm, this "designed
1932 limitation" of VC++ is a pitfall.
1933 Hence the Python wrappers of gdcm cannot be incrementally linked
1934 against the c++ dynamic library. The dirty but only workaround is
1935 to forget about incremental link of dynamic libraries and to generate
1936 the Python wrappers library with the inclusions of the underlying C++
1938 The following modifications concern this matter on Win32/VC++:
1939 - wrapping python correct with standalone wrapped dll (don't use separate
1940 dll under windows !!!!)
1941 - python21_d debug mode enabled (ask Frog how to use it :-)
1942 - NO problem with having an STL member of class for example string in C++
1943 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1944 - Python test of dcmlib in Python is ok under windows on a large set
1946 * removed glib references
1947 * typedef's inserted in gdcm.i for correct swig type management
1949 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * python/demo/*.py load.py extracted from test.py. Added explore.py
1951 that only displays required tags and testAll.py that parses all
1952 the files of the testsuite without using unittest.
1953 * python/testSuite.py other additional test on new files added.
1954 * Data/* new test files added accordingly to the testSuite.
1955 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1956 the vr in the file differs from the one of the dictionary.
1958 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1960 values, but limits itself to values which are below a user specified
1961 size (by default 1024 bytes).
1962 * python/gdcm.i : elements not loaded (because their size is above the
1963 user specified treshold) are exported with their TagKey as key of the
1964 python dictionary. This enables the testsuite to make some checks
1965 on the unloaded elements (since we have their offset and size).
1966 * python/testSuite.py
1967 - now tests for the existence and proper value of the pixel data
1968 - two new examples added.
1969 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1971 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1972 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1973 aware. See the strategy comments in gdcmHeader::FindeLength().
1974 * Test/test.cxx now accepts a filename as first argument.
1975 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1976 * python/testSuite.py changed to integrate test on above files.
1978 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1980 the vr was also RET.
1981 * python/testSuite.py more tests added.
1983 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1984 * python/testSuite.py unittest test suite added (uses Data)
1985 * Data/* dcm and acr files for the test suite.
1986 * glib dependance removed from un*x version. We now use ISO C99
1987 7.18 Integer types (see stdint.h)
1988 - python/Makefile, src/Makefile src/gdcm.h
1989 * src/ when an explicit vr (like dicom files) suddenly poped an
1990 implicit element we use to mark the underlying DictEntry of the
1991 concerned ElValue with "Implicit". This strategy was damageable
1992 too the public or provite dictionaries, since some of their vr
1993 would be changed. Since Header::FindLength heavily relies on the
1994 detection by Header::FindVR of falsely explicit elements, I
1995 added an extra ImplicitVr member to ElValue (boolean).
1996 The rest of the changes we the necessary adaptations.
1998 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1999 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2001 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2003 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2004 * Adaptation for porting to VC++:
2006 o forced to use std namespace (for string to be known)
2007 o all class use __declspec export style on WIN32
2008 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2009 (in stdlib.h on Win32 but in std:: for gcc)
2010 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2011 variable GDCM_DICT_PATH.
2012 * src/gdcmHeader.cxx verbose comments made discrete.
2014 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * python/gdcm.i: added a typemap that converts a C++ hashing table
2016 to native Python dictionary.
2017 * python/demo/test.py:
2018 - now uses the native dictionary for exploration of gdcmHeader.
2019 - takes an optional filename argument (the file to parse).
2020 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2021 PubElVals hashing table.
2022 * Dicts/dicomV3.dic removed error prone trailing spaces.
2024 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * Python wrapping process moved away from src/Makefile to
2026 newly created python/Makefile (as well as gdcm.i)
2027 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2028 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2029 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2030 from the environement variable GDCM_DICT_PATH (when existing).
2031 * src/gdcmDict::GetTag bug fix.
2033 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * Straightforward temporary fixes for swig to build the python wrappers.
2035 src/Makefile now has a python working entry [by working we mean
2036 that we can import de shadow classes without errors].
2038 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * hashtest.cxx removed (since allready in Test)
2040 * src/gdcmlib.h renamed to src/gdcm.h
2041 * src/dcm.i renamed to src/gdcm.i
2042 * src/Makefile prepared for python wrapping
2044 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2045 * src/gdcmHeader.cxx :
2046 - Parsing of header is now separated from loading of element values
2047 (see gdcmHeader::LoadElements).
2048 - general clean up of hopefully all file access (creation of
2049 ReadInt16 and ReadInt32)
2051 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * src/gdcmHeader.cxx :
2053 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2055 - SetLgrElem renamed to SetLength
2056 - GetLgrElem renamed to GetLength
2057 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2058 * src/gdcmElValSet.cxx fixed both GetElValue methods
2059 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2060 due to IdoDude was cleaned out.
2062 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2064 concentrates on finding the value representation (when it exists).
2065 RecupLgr now only finds the element value length, and it avoids
2066 returning the unecessary skL (skipped length).
2067 Also, offsetCourant was simply removed (with taille_fich) since
2068 it was redundant with the File position internals (by using
2069 ftell and fseek). This also made skL (see above in RecupLgr) usage
2071 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2072 on the libido specificities which are handled through class
2074 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2077 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * Truckload of changes. Parsing of header is barely functional
2079 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2081 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * src/gdcmHeader.cxx many addons of low level methods
2084 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2085 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2086 and _IdDcmSWAP_LONG.
2088 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * This corresponds to all the changes decided at the meeting of
2090 May 23 2002. Needless to say we are running late...