1 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
3 clear) TagHT, which is an inherited member of gdcmElementSet. It is
4 up to the destructor of gdcmElementSet to clean up TagHt and it's
7 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
8 * Test/CMakeLists.txt: update to follow gdcmData renamings.
9 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
11 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * ENH: added some utility method that builds a flat dictionnary
13 holding all the Dicom entries contained in the recursive structure
14 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
16 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
17 BuildFlatHashTable() that build a flat dictionary.
18 - src/gdcmElementSet.h: added a new private GetTag() accessor.
19 gdcmDocument is now a friend of gdcmElementSet.
20 - src/gdcmElementSet.cxx: clean up.
21 - Example/FlatHashTablePrint.cxx added.
22 - Example/CmakeLists.txt changed accordingly
24 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
25 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
26 moved away from gdcmDocEntrySet (since this class is an abstract class
27 acting like an interface). SQDepthLevel and BaseTagKey are now
29 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
30 and associated accessors. Doxygenation of the class.
31 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
33 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
34 Use SQDepthLevel accessor instead. ::Print() adapted.
35 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
36 - src/gdcmDocument.cxx changed accordingly.
38 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
39 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
40 - The following is the doxygen comment of the typedef declaration
41 of gdcmagKey in src/gdcmCommon.h:
42 gdcmTagKey is made to old an "universal" (as in URL, Universal
43 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
44 A dicom tag allways has a group and an element, but a set of tags
45 embeded in various (optionally nested) sequences and sharing
46 the same group and element all share the same (group, element)
47 "identifier". Hence the (group, element) cannot be used as an
48 identifier (in gdcm we shall refer to a "TagKey") of a tag.
49 In order to construct a proper tag identifier (i.e. a key) we
50 consider the following definition of a TagKey:
51 - let Group, Element be the string representation of the
52 group and element dicom tag members,
53 - let ItemNumber be the string representation of the integer
54 index of the considered item number of a sequence,
55 Let the key of a tag embeded in a sequence, noted SeqTag, be
57 /ItemNumber#Group|Element
58 where "/", "#" and "|" are characters acting as separators.
59 Then the general form of a gdcmTagKey is given by:
61 where <SeqTag> means NO or many instances of SeqTag.
62 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
65 but the gdcmTagKey of a tag "embeded" is the first item of
66 a sequence, itself nested in the third item of a sequence is the
68 0004|1220/2#0008|0082/0#0008|0090
69 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
70 order to hold the new sequence compatible key. Previously, the
71 GetKey() method would look in the underlying gdcmDictEntry.
72 - src/gdcmDocEntry.cxx:
73 -- constructor now copies the underlying DictEntry key, in the local
75 -- ::Print: displays the member Key, instead of the (group, element).
76 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
77 - src/gdcmDocEntrySet.h:xi
78 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
79 -- now has a new BaseTagKey member.
81 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
82 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
84 This poses the problem with the semantics of the following lines
85 LoadEntryVoidArea(0x0028,0x1201); // R LUT
86 LoadEntryVoidArea(0x0028,0x1202); // G LUT
87 LoadEntryVoidArea(0x0028,0x1203); // B LUT
88 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
89 to the long FIXME note for what the problem is. Nevertheless in
90 order to get things working the dicom dictionary was altered !
91 Please fix things urgently...
92 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
93 information), see above note on moving the member VoidArea. Nevertheless
94 the following entries previously correctly set as US are now inproperly
96 0028 1201 OW IMG Red Palette Color Lookup Table Data
97 0028 1202 OW IMG Green Palette Color Lookup Table Data
98 0028 1203 OW IMG Blue Palette Color Lookup Table Data
99 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
100 of gdcmDocEntry moved to gdcmSeqEntry.
101 * src/gdcmSeqEntry.cxx: STYLE.
103 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * Test/TestAllEntryVerify.cxx minor fix and added comments.
106 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * gdcmPython/testSuite.py: all the test suite in python is now moved
108 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
109 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
110 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
112 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
113 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
114 to avoid inclusion recursion until STL is reached.
115 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
116 mecanism. errno.h is not included in gdcm anymore.
117 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
118 (gdcmFormatError now inherits from gdcmFormatUnexpected).
120 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
121 gdcmData/TestAllEntryVerifyReference.txt
122 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
123 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
124 exception_on_error parameter.
125 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
126 - vtk/vtkGdcmReader.cxx changed accordingly,
127 - Example/*.cxx and Test/*.cxx changed accordingly.
129 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
130 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
131 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
132 enable_sequences removed from gdcmHeader constructor and dependencies.
133 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
134 * gdcmPython/demo/PrintHeader.py: dummy fix.
135 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
136 skip_shadow removed from gdcmHeader constructor and dependencies.
137 * Example/*.cxx and Test/*.cxx changed accordingly.
139 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
140 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
141 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
143 2004-07-21 Jean-Pierre Roux
144 * FIX Now, Parsing and Printing a DICOMDIR do work!
145 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
147 2004-07-20 Jean-Pierre Roux
148 * FIX Some brain damaged headers have Zero-Lenght fields
149 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
151 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
153 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
154 variable (instance of gdcmDebug) by a definition macro, and the instance
155 is now in static in the gdcmDebug class
156 * src/gdcmSQItem.h : (FIXME) remove an undefined method
157 * Test/PrintAllDocument.cxx : bug fix in the result of the test
159 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * WARNING: ctest now depends more tightly on gdcmData. You should
161 check out gdcmData properly for things to run smoothly...
162 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
163 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
164 we need the pixels not be loaded in order to use the ValEntry
165 that displays position and size).
166 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
167 This is a C++ based equivalent of gdcmPython/testSuite.py that should
168 be deprecated. If you have any doubts about the advantages of a
169 modern scripting language (read Python) versus grass root C++ (i.e.
170 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
171 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
172 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
173 Anyhow, consider documenting the gdcmData images in
174 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
176 * Test/CMakeLists.txt:
177 - now uses TestAllEntryVerify.cxx
178 - specific comments on oldACR00001.ima (now renamed in gdcmData
179 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
180 gdcmData/TestAllEntryVerifyReference.txt
183 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * src/*.[h|cxx] : typedef clean up
185 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
186 - TagKey renamed to gdcmTagKey (for external usage)
187 - VRKey renamed to gdcmVRKey (for external usage)
188 - removal of typedef duplication.
189 - Removed all unecessary inline keyword from class inline definitions.
190 - Some method|function(void) declarations replaced with method|function().
191 * src/jpeg/libijg12/jdhuff12.c:
192 - printf polluting ctest removed.
193 - TAB removal for comminting
195 - TestAllReadCompareDicom.cxx: added a test that compares all the
196 images in gdcmDataImages.h with corresponding images in
197 gdcmData/BaselineDicom/. When baseline images are not present
198 this test creates them.
199 Note: we need to validate each reference image, but before that
200 I'd like to rename them with a more explicit name...
201 - CMakeLists.txt: changed accordingly.
202 * Example/*.cxx: examples now only include gdcm.h (as opposed to
203 including each header needed).
205 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * Test/*.cxx and Example/*.cxx: moved some examples away from the
207 test suite to the Example directory. Are concerned:
212 - TestWriteSimple.cxx
213 * Test/CMakeLists.txt: added some comments on reasons for black listing
214 image gdcmData/oldACR00001.ima
216 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * Test/CmakeList.txt: removed the following from black list (to be coherent
218 with removal from gdcmData):
219 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
220 - gdcm-MR-PHILIPS-16.dcm
222 Added the following because after last cvs update, they cause
223 ctest -R TestReadWriteReadCompare
225 - gdcm-MR-SIEMENS-16-1.acr
227 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
228 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
229 new comments in this file) we temporarily (sigh) move to a weaker
231 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
232 we don't need to black list the following images anymore:
233 - 8BitsUncompressedColor.dcm
235 - US-PAL-8-10x-echo.dcm
236 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
237 fixes and the beautified code ;-)
238 This fixes the bug introduced in version 1.42 (when beautifying)
239 that made the parsing of 8BitsRunLengthColor.dcm unproper.
240 Note: ctest was blind to this bug (this means we need to still
241 improve the test suite). The bug could be detected by using
242 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
244 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
245 and by displaying the (garbage) produced file temp.XDCM...
247 2004-06-29 Jean-Pierre Roux
248 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
249 - replace by uggly but working old code :-(
250 A lot of things should be OK again.
251 It's really urgent to have a test suite that *tests*,
252 to prevent Frog's beautifying sessions to break all the stuff
253 (twice, withing a fortnigh ...)
255 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
256 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
257 redundancy) to added Test/TestReadWriteReadCompare.cxx
258 * Test/CmakeList.txt: because the compare test of
259 Test/TestReadWriteReadCompare.cxx fails, the following images are
260 black listed: - 8BitsUncompressedColor.dcm
262 - US-PAL-8-10x-echo.dcm
263 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
264 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
265 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
266 and ad-hoc kludge. This kludge is now removed, and on encountering
267 such an image (OB field brain damaged) we set errno. Then in
268 ::FindDocLength() we "fix" the length as being ALL what remains
269 in the file (until EOF). We then proceed, hoping for the best...
270 This fixes a SegFault in ShowDicom when trying to write such an
272 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
273 (because TestWriteRead breaks on it, after a non conformal commit?).
274 ctest now runs properly, except for MakeDicomDir (which was allways
275 broken) and the Python related stuff (still not fixed).
277 2004-06-24 Jean-Pierre Roux
278 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
279 FIX : Test/TestReadWrite now iterates on all the file names
280 (instead of infinite loop)
281 ENH : Test/TestWriteRead now iterates on all the file names
283 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
286 2004-06-24 Jean-Pierre Roux
287 FIX : - now Write drops LUT Descriptors and LUTs (if any)
288 when SamplesPerPixel =3
289 - now Write is no longer confused by
290 'BitsAllocated = 12" and 'BitsStored=12"
291 - "UN" value representation Elements are now written correctly
292 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
293 ENH : - now gdcmHeader has its own Write methods
294 (in order to split the job that has not to be done
297 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
299 loop on the same image until memory went out.
300 Note: this means we still have gobs of memory loss in PrintDocument
301 * src/gdcmDocument.cxx: fixes problem on parsing on file
302 gdcmData/16BitsJpegLosslessGrayScale.dcm.
304 2004-06-24 Jean-Pierre Roux
305 FIX : Write - All the Sequences and Sequence Item are now written
306 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
307 is added a the end, when necessary.
308 - A lot of brain-damaged images, that were read correctly are
309 now written correctly
310 - length compatible BinEntry are now loaded correctly
311 (even for odd groups)
312 Note : only Explicit Value Representation was checked.
313 (question : is implicit VR really necessary for gdcm ?)
315 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * DEVELOPPER: added a proposition of coding style.
317 * src/gdcmDocEntry.h: removed every inline declaration (for test of
320 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
322 Use the gdcmDocEntry::Print() and Write() instead.
323 * src/gdcmDocument.cxx: bug fix.
325 2004-06-22 Jean-Pierre Roux
326 FIX : gdcmDocument.cxx
327 - Now we do recognize the JpegLossLess format (there was a misstyping in
328 code 'beautyfication' :-(
329 - Now we automaticaticaly load the Luts, if any
331 2004-06-22 Jean-Pierre Roux
332 In order : to write Sequences, whatever their imbrication level,
333 : to allow user to create his own Sequences
334 a lot of modif where necessary (adding, moving, or virtualising methods)
336 WARNING : save your own sources *before* cvs up !
339 ADD virtual void Write(FILE *fp, FileType filetype);
342 ADD virtual void Write(FILE *fp, FileType filetype);
343 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
346 ADD virtual void Write (FILE *fp, FileType filetype)=0;
347 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
348 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
349 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
350 ADD std::string GetEntryByName(TagName name);
351 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
353 std::string vr = "unkn",
354 std::string fourth = "unkn",
355 std::string name = "unkn");
356 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
357 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
358 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
359 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
360 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
361 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
362 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
363 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
366 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
367 ADD virtual std::string GetEntryByName (TagName tagName);
368 ADD virtual std::string GetEntryVRByName (TagName tagName);
369 REM virtual bool Write(FILE *, FileType);
370 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
371 FILE *_fp, FileType type);
372 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
373 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
374 REM virtual bool WriteEntries(FILE *_fp,FileType type);
375 REM virtual std::string GetEntryByName (std::string tagName);
376 REM virtual std::string GetEntryVRByName (std::string tagName);
377 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
378 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
379 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
381 std::string vr = "unkn",
382 std::string fourth = "unkn",
383 std::string name = "unkn");
384 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
385 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
386 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
387 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
390 ADD virtual void Write(FILE *fp, FileType filetype);
393 ADD virtual void Write(FILE *fp,FileType filetype);
396 ADD virtual void Write(FILE *fp, FileType filetype);
397 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
398 REM std::string GetEntryByNumber(guint16 group, guint16 element);
399 REM std::string GetEntryByName(TagName name);
402 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
404 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
406 The default constructor invoked by the line
407 gdcmHeader *f1 = new gdcmHeader( header );
408 was gdcmHeader::gdcmHeader(bool) instead of the expected
409 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
410 Hence the parsing wasn't executed... See also below.
411 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
412 as explicit constructor didn't do the trick to fix the above problem.
413 Could anyone explain why ?
414 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
415 properly calls gdcmValEntry::Print() (that was weed out from
416 code related to gdcmBinEntry).
418 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
419 * In order to fix memory leaks:
420 - Test/TestWriteSimple.cxx: added cleaning of free store through
422 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
423 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
424 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
425 (through the call to ::AddDicomDirMeta()) or the destructor
426 would crash when deleting uninitialized ::metaElems].
427 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
428 - src/gdcmDocument.cxx:
429 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
431 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
432 was causing memory leaks.
433 - src/gdcmSQItem.cxx:
434 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
435 cleanly handled with polymophism: sorry but my milage is low).
436 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
437 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
438 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
439 This avoids SegFaulting.
440 - src/gdcmSQItem.h: coding style.
442 - Test/TestWriteSimple still severely sucks. The output image content
443 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
444 damaged when displayed with vtkgdcmViewer.
445 - on memory leaks: TestWriteSimple leaks really less (see entry
446 of 2004-06-18 in Changelog file for the call to valgrind).
447 - on segfaults: ctest now passes all the tests but one (no more
449 * Erroneous leading white fix:
450 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
451 white[s] (as opposed to from >> xxx, that removes it [them].
452 - src/gdcmTS.cxx: ditto.
453 - gdcmPython/testSuite.py: dirty related kludge removed.
454 * src/*: remaining references to gdcmParser removed.
455 * src/*[cxx|h]: added copy[way]left header.
458 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * In order to fix writing of dicom files:
460 - Test/TestWriteSimple.cxx: a simpler example of writing.
461 - Test/CMakeLists.txt changed accordingly.
462 - src/gdcmDocument.cxx:
463 -- The destructor now recursilvely removes potential sequences.
464 -- Bug fix in ::IsJPEG2000()
465 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
466 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
468 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
469 to only declared) and build on top of
470 ::GetDocEntryByNumber(guint16, guint16).
471 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
472 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
473 for usage in destructor and treatement of promotion in
474 ::ReplaceOrCreateByNumber().
475 - src/gdcmSQItem.cxx: destructor should better handle his job.
476 Test/TestWriteSimple now runs (or at least it DOES something).
477 * We can now start hutting memory links. A good starting point is:
478 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
479 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
480 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
482 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * Valgrind note: after Mathieu Malaterre teached me how to read
484 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
486 Using gcc, you can force the STL to use malloc and to free memory as
487 soon as possible by globally disabling memory caching.
488 With 3.2.2 and later, you should export the environment variable
489 GLIBCPP_FORCE_NEW before running your program.
490 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
491 simply vanish (it is still not clear to me, whether this means that
492 STL std::string leaks or if valgrind believes it leaks...).
493 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
494 running bin/gdcmTests makeDicomDir):
495 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
496 - Test/makeDicomDir.cxx now properly traps empty lists and returns
498 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
499 SegFaulting (I drowned in DicomDir related code when trying to
500 understand why the list is empty...).
501 * src/gdcmDocument.h: first BSD license header try.
502 * Doc/License.txt added.
504 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * src/gdcmDocument.[h|cxx]:
506 - Clean up of the Transfer related predicates. They are now all based
507 on new method isGivenTransferSyntax, that (should) handle properly
509 - general clean up, simplification, and coding style.
510 - Specific clean up of Parse7FE0() (umproperly named actually).
511 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
513 2004-06-14 Jean-Pierre Roux
515 - fix the display of Sequence Delimitor (SQDepthLevel pb)
516 - fix the display of SQItem ordinal number
517 - add the GetSQItemByOrdinalNumber method
518 - remove some useless never written private methods
520 2004-06-14 Jean-Pierre Roux
522 - adding a constructor taking a gdcmDocEntry as an input param
523 - ReplaceOrCreateByNumber now returns :
524 a gdcmBinEntry * if a Binary (void *) value is passed as a param
525 a gdcmValEntry * if a string value is passed as a param
527 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
528 according to the param type (no longer sets a gdcmDocEntry)
529 - GetValEntryByNumber, GetBinEntryByNumber added
530 - NewValEntryByNumber and NewBinEntryByNumber added
532 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
534 - GetSQItemNumber and SetSQItemNumber added, to provide
535 a (relative) Item identier inside a given Sequence
536 \warning : some pb remaining around this number
538 - AddEntry now takes the Item Number as a param
540 - adding a constructor taking a gdcmDocEntry as an input param
542 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * Memory leak hunt with the following command:
544 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
545 --show-reachable=yes gdcmTests PrintDocument
546 It looks like many (all?) leaks are due to the STL (or a bad usage
547 of the STL. The lines producing the leaks now have a comment with
548 a "MEMORY LEAK" tag: you can retrieve them with
549 grep "MEMORY LEAK" src/*
550 Here are two typical examples which I can't help fixing:
555 char * test = "babo";
556 name = test; //// <--- valgrind detects 960 bytes lost in
557 //// call to std::string::operator=(char const*)
558 name.clear(); //// Doesn't help !
566 std::cout << "Type a bunch of characters followed by RETURN: ";
567 getline(std::cin, line); //// <--- valgrind dectects a loss
568 //// of 1320 bytes in call to
569 /// std::basic_istream<>& std::getline<>
575 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * src/gdcmHeader.[cxx|h]:
577 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
578 and related, moved away to gdcmDocument.
579 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
580 the corresponding protected accessors of inherited class
581 gdcmDocument, removed ! As a consequence gdcmFile had to be
582 declared friend of class gdcmDocument (see below).
583 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
584 - Clean up of undefined or unused methods.
585 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
586 account the changes to gdcmHeader.h).
587 * src/gdcmDocument.h:
588 - gdcmFile is now a friend class (in order to take into account the
589 changes to gdcmHeader.h).
590 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
591 (see changes to gdcmHeader.h).
592 - Accessors (reading on the form GetEntry*) are now public.
593 - Clean up of undefined or unused methods.
594 * src/gdcmDocument.cxx:
595 - adaptation to changes to gdcmDocument.h
596 - ::OpenFile now writes a verbose message when file cannot be opened.
597 - some std::string properly set to VRKey
598 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
599 references to gdcmDocument.
600 * Test/TestFindTags.cxx: changed accordingly to above changes.
601 * gdcmPython/testSuite.py: adapted to renaming of acr files in
602 cvs repository gdcmData.
604 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
606 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
607 conflicts with gdcmValEntry::voidArea.
608 * src/gdcmValEntry.cxx: unmatching comment wiped out.
609 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
610 Value representation between StringRepresentable and BinaryRepresentable.
611 * src/gdcmDocument.cxx:
612 - method ParseDES: proper indentation restored and usage of
613 gdcmVR::IsVROfGdcmStringRepresentable wired in.
614 - method LoadDocEntry: the fingerprint left in the SetValue() of
615 unloaded entries (length > MaxSizeLoadEntry) had curiously been
616 removed. Reverting to previous code segment with the proper
617 dynamic_cast< gdcmValEntry* >.
618 Note: this was (partially) breaking the python test suite
619 (gdcmPython/testSuite.py) that made usage of the above
620 fingerprint to check presence of "Pixel Data".
621 * src/gdcmDocEntry.h: coding style.
622 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
623 now taken into account.
624 * gdcmPython/gdcm.i: adaptation to the new internal representation
625 of gdcm (exit gdcmParser, hello gdcmDocument).
626 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
628 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
629 anymore, but instead prints the loaded Python dictionary.
630 * .... alas, the python testSuite is still broken.
632 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
635 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
636 * src/gdcmUtil.h : export methods
638 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
639 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
641 * Initial addition of automatic python testing
642 * Initial addition of automatic image comparison
644 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
645 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
646 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
648 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
649 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
650 * Test/ShowDicom.cxx : bug fix for msvc compilation
651 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
653 2004-05-04 Jean-Pierre Roux
654 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
655 new concepts (and new classes) :
656 a 'gdcmDocument' is composed of a set of Doc Entries, that are
657 - elementary gdcmDocEntries (former gdcmHeaderEntries)
658 - Sequence Doc Entries (gdcmSeqEntries)
659 a Sequence is composed of Items.
660 Each item is a set of Doc Entries (this is recursive)
661 The non uniqueness of the 'Dicom tag' is due to this recursivity
662 (never taken into account)
663 Our unability to add a new 'entry' in the header
664 at the proper location (neither in the H-Table (map or multimap),
665 nor in the Chained List is also due to this recursivity.
666 Don't try, right now, to use/modify/compile these new sources :
668 We just commit all the stuff, 'as is', in order not to loose it.
670 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
673 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
674 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
675 file prefix (SetFilePrefix)
677 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
678 * Add a new test: ShowDicom, for now this is just the c++ version of
679 checkRead.sh, later it will be able to compare the image read against a
681 * Replace the DEBUG on the stack with a global entry in cmake interface:
682 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
684 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
685 * Add an example subdir, with a real example on how to read + write a
688 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
690 * Doc/CMakeLists.txt: the main page is now properly differentiated
691 between the developper and user version.
692 * Doc/doxygen.config.in: dropped search related obsolete flags
693 * src/gdcmParser.h, gdcmHeader.h: doxygenation
695 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * DEVELOPPER: added some helpfull comments for compile/test/install
699 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
700 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
701 src directory, now generated in the build dir.
702 2. Tests as mentionned smarter
704 4. Add a new method in gdcmDict that return the PubDict by name
705 this is interesting for 3rd party lib like ITK,
706 where we could set the institution name / patient name...
708 * ENH: 1. Now the test suite is working for real
709 2. All binaries are now output in the gdcm-bin directory
710 (this was not true before)
712 2004-04-28 Jean-Pierre Roux
713 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
714 SeQuence indented printing of Dicom Header.
715 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
716 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
717 Computation of SQDepthLevel is now part of gdcmHeader constructor
718 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
719 tree-like structure of a Dicom Header.
720 * FIX Test code cleaning
722 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
723 * ENH: Adding automatic testing
724 1. Need a DartConfig.cmake to submit to public
725 2. Add a test driver gdcmTest.cxx
726 3. gdcmTestMain, an helper for the main test driver gdcmTest
727 4. Files in Test don't have a main anymore, this becomes interesting
728 when we add more and more tests, thus dsw don't have to load
730 * ENH: Adding a GDCM_DATA_ROOT for testing
731 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
732 one file instead of seven + some small cleanup
734 2004-04-22 Jean-Pierre Roux
735 * ENH Minor changes to the Print() methods.
736 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
737 Header printing. Example given with :
738 > PrintHeader fileName 2 new
739 (SQ based tree-like structure still to be done for the Header ...)
741 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
742 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
743 1. I have added some unsigned where needed
744 2. Some function parameter not used -> (void)
745 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
746 4. g++ don't like character '\' in comment
747 5. #define jpeg_create_decompress jCreaDecompress
748 this really need to be fixed
749 6. virtualize destructor of gdcmObject ... leakage
750 7. sscanf(g->first.c_str(),"%x",&gr_bid);
751 this also really need to be fixed
752 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
753 remove compression file
754 (as we only do decompression, right ?)
755 * ENH: Change malloc/calloc/free with c++ equivalent
757 2004-04-21 Jean-Pierre Roux
758 * FIX gdcmHeaderHelper::GetXSpacing
759 when a single value is found (bug ?), xpacing is now
760 defaulted to yspacing
762 2004-04-19 Jean-Pierre Roux
763 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
764 * ENH add parameters :
765 bool exception_on_error = false,
766 bool enable_sequences = false,
767 bool ignore_shadow = false
768 to the gdcmFile constructors to be full gdcmParser compliant
769 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
770 to allow reading of PAPYRUS 3.0 files
772 2004-04-06 Jean-Pierre Roux
773 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
775 2004-04-02 Jean-Pierre Roux
776 * ADD : Test/checksequence.sh, for a general recap on SQ pb
777 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
778 for Philips spurious Tag fffe|0000 while rewritting Dicom files
780 2004-03-30 Jean-Pierre Roux
781 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
782 for ACR file, written out as DICOM files (hope so...)
784 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
786 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
787 moved to base class gdcmParser and only the specialisation is kept
789 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
790 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
791 already does the job.
792 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
793 (to be consistent with gdcmParser::WriteEntries).
795 2004-03-30 Benoit Regrain
796 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
797 upate of the object's instance. It's passed to 2 in the unfavorable
798 case : one in the ExecuteInformation, one in the ExecuteData
800 2004-03-29 Jean-Pierre Roux
801 * ENH : Check on file type to be written moved
802 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
803 * FIX : gdcmObject::ResetBoundaries now stops properly
804 when end-of-list is reached
805 : gdcmVersion modified (as Benoit Regrain asked)
807 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
809 * src/gdcmUtil.cxx: added forgotten iostream include.
810 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
811 equivalent to ExplicitVR in existing code).
813 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
814 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
815 now contains all the gdcmGlobal related code.
816 * minor coding style and doxygenation changes.
818 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
820 now contains all the Debug related code.
821 * minor clean-up of includes in src/*.cxx
822 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
823 CreateCleanString) removed.
824 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
825 * Doc/DoxyMainPageUser.txt added.
826 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
827 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
830 2004-03-24 Jean-Pierre Roux
831 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
833 2004-03-23 Jean-Pierre Roux
834 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
835 big endian made volumes
836 * ENH Now gdcmParser constructor and destructor are protected to forbid
837 end user to instanciate class gdcmParser
838 (only gdcmHeader and gdcmDicomDir are meaningfull)
840 2004-03-22 Benoit Regrain
841 * FIX : src/gdcmDicomDir.cxx : make windows compilable
842 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
843 gdcmSerie to gdcmDicomDirSerie
845 2004-03-19 Jean-Pierre Roux
846 * ENH Now the tree-like structure describing a DICOMDIR comming from
847 an already existing DICOMDIR file is consistent with
848 the home-made tree-like structure build ex-nihilo
849 or build from the files held (recursively) in a Directory
850 functions gdcmDicomDir::CheckBoundaries()
851 gdcmObject::SetBoundaries() added
853 2004-03-17 Jean-Pierre Roux
854 * REM (Eric Boix bug) : removal of meaningless
855 gdcmDicomDirImage::NewImage function.
856 * FIX now file names and directory name are written properly in the
858 * FIX now gdcmDicomDir constructor may be call without any trick
861 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
863 of gdcmDicomDirImage::NewImage as empty function.
865 2004-02-28 Jean-Pierre Roux
866 * ENH add gdcmDicomDir:NewPatient
867 add gdcmDicomDirPatient:NewStudy
868 add gdcmDicomDirStudy:NewSerie
869 add gdcmDicomDirSerie:NewImage
870 to allow making gdcDicomDir object.
871 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
872 (as opposite to the gdcmHeader chained list)
874 2004-02-11 Benoit Regrain
875 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
876 when using from python
878 2004-02-10 Benoit Regrain
879 * FIX : bug fix in the gdcmDirList for the recursivity in directories
880 * FIX : in gdcmDicomDir when the directory is empty
881 * ENH : add callback and methods to get the progression of dicomDir
884 2004-02-06 Jean-Pierre Roux
885 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
886 - GDCM_META added to gdcmDicomDirType
887 - class gdcmMeta created
888 * ENH : - A brief summary is now displayed at the beginning of
889 'testDicomDir' to help disaster magnitude estimation
890 * REM : Now useless Test/explDICOMDIR.cxx
892 2004-02-05 Benoit Regrain
893 * ENH : add methods in gdcmObject to get the hash table or the list of
895 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
896 * FIX : wrapping python for TagHeaderEntryHT
898 2004-02-04 Benoit Regrain
899 * FIX : even length for some strings when writting the dicom dir
900 * FIX : sort the images in the dicom dir
901 * FIX : Bug fix for python use of dicom dir
902 * ADD : a python demo
904 2004-02-04 Jean-Pierre Roux
905 * FIX : Final solution (?) for icone embedded images
906 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
907 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
908 add groups 6002, 6004, 6006, to allow 'clean' parsing of
909 gdcmData/gdcm-MR-SIEMENS-16.acr1
910 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
911 to make full checking easier
913 2004-02-04 Benoit Regrain
914 * FIX : WriteEntries : coding style & logic in parameters
915 * FIX : Set the elements to create the DicomDir in a dictionary file
917 2004-02-03 Benoit Regrain
918 * gdcmDirList : to parse a hard drive directory in recursive (or not)
919 * gdcmDicomDir : add the load of directory
920 * Bug fix and print add-on
922 2004-02-03 Jean-Pierre Roux
923 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
924 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
925 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
926 * FIX gdcmParser.cxx : 'group length' elements are now considered
927 as integers, even for shadow groups, when file is Implicit VR
929 2004-02-02 Jean-Pierre Roux
930 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
932 of the last synonym :-(
933 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
935 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
936 * FIX taking into account the possible 7fe0,0010 multiplicity
937 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
938 to allow removal of references to 7fe0,0010, to deal with
939 ACR-NEMA images, when 0028,0200 is meaningfull
941 2004-01-31 Jean-Pierre Roux
942 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
943 no longer writes 'Un' on disk
944 * FIX SQ elements with actual length are now dealt with corectly
945 * FIX gdcmFile::WriteBase make the difference, for color images, between
946 the length (for Palette expanded images)
947 and Raw Length (non expanded image + Palette)
948 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
949 (that broke Write). Replaced by UL.
950 Aware user will reload the field if he
951 thinks it's necesssary
953 2004-01-30 Jean-Pierre Roux
954 * gdcmParser::CheckSwap() now defaults the filetype to ACR
955 when 'dirty Acr' is found, to be compliant with the new
956 IsReadable() methods.
958 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
959 (no DOUBLE images in kosher DICOM,
960 but so usefull for people that miss them ;-)
962 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
963 DICOMDIR related utilities (not checked as Windoze compliant)
965 2004-01-28 Jean-Pierre Roux
966 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
968 2004-01-27 Jean-Pierre Roux
969 * gdcmParser constructor has a new boolean param,'ignore_shadow',
970 to allow skipping the shadow elements, to save memory space.
971 The TRUE value for this param has to be used
972 with a FALSE value for the 'enable_sequence' param.
973 ('public elements' may be embedded in 'shadow Sequences')
974 * gdcmHeader methods now deal with 'embedded icones images' in the header
975 (even when an 'icone image sequence' is announced by the
976 element (0x0088,0x0200), but there is NO icone at all ...
978 * gdcmHeader sometimes Image Location value doesn't follow
979 the supposed processor endianity (see gdcmData/cr172241.dcm).
982 * gdcmHeader add the method
983 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
984 to get *all* the Header Entries with the same tag.
985 GetHeaderEntrySameName is probabely *useless*
986 (no meaning : Name is *not* an identifier within the Dictionnary)
988 2004-01-26 Benoit Regrain
989 * Bug fix in the print of hexadecimal representations. Remove long fields
990 in the print and add a third level of print to print them
992 2004-01-23 Benoit Regrain
993 * Bug fix on field having a VR = 'UI'. Assume that is a string field
994 * Bug fix on test suite after remove the strip made on not string fields
995 * Split the IsReadable method between gdcmParser which test that the file
996 is dicom and gdcmHeader which test that it's an image file
998 2004-01-22 Benoit Regrain
999 * DicomDir : clean code, add methods, set variables in protected or private
1000 * gdcmUtil : bug fix for the clean string method
1002 2004-01-19 Benoit Regrain
1003 * Add the use of shadow dictionaries
1004 * bug fix and coding style
1006 2004-01-19 Benoit Regrain
1007 * src/gdcmFile.cxx : bug fix concerning the close of file
1008 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1009 * Add the update of header entries using the shadow library
1011 2004-01-19 Benoit Regrain
1012 * removal of file gdcmHeader2.cxx
1013 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1014 inheriting from gdcmParser. This split is to prepare the integration
1015 of dicom dir parsing
1016 * bug fix under python
1018 2004-01-16 Jean-Pierre Roux
1019 * REM removal of class gdcmHeaderEntrySet
1020 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1021 * ADD add file gdcmHeader2.cxx
1022 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1024 2004-01-15 Benoit Regrain
1025 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1026 entries created while parsing the header. Thus, they will be destroyed
1027 when the gdcmDictSet will be destroyed
1028 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1031 2004-01-15 Benoit Regrain
1032 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1033 made a fatal error because of the memory release at the end of program.
1034 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1035 some memory and vtk seems to have some problems with that.
1036 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1038 2004-01-14 Benoit Regrain
1039 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1040 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1041 * src/*.[h|cxx] : make changes due to class name changes
1042 * gdcmPython/demo/*.py : bug fix due to method names
1044 2004-01-13 Benoit Regrain
1045 * src/*.[h|cxx] : coding style
1046 * vtk/*.[h|cxx] : coding style
1048 2004-01-13 Benoit Regrain
1049 * gdcmPython/testSuite.py : test the readable flag of file for tests
1050 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1051 It's lied to the stl compilation by MSVC (windows, always windows...)
1052 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1054 2004-01-12 Benoit Regrain
1055 * src/*.h : add comments
1056 * src/gdcmDictSet.h : set the method BuildDictPath in public
1057 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1058 directly setted in the source code
1059 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1062 2004-01-09 Benoit Regrain
1063 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1064 * setup.py : use a reference to gdcmVERSION
1066 2004-01-07 Benoit Regrain
1067 * Modification to compile with the distutils.
1070 2003-12-10 Benoit Regrain
1071 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1072 can use a gdcmHeaderHelper to load datas
1073 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1074 made in the source code
1076 2003-12-10 Benoit Regrain
1077 * Update Windows projects and .cvsignore files
1079 2003-11-12 Jean-Pierre Roux
1080 * ENH gdcmHeader constructor has one more parameter (default value : false)
1081 that allows the user to 'go inside' the SeQuences only
1083 gdcmElValSet:Print takes it into account
1085 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1086 * ENH: Update gdcmPython/CMakeLists
1087 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1088 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1090 2003-11-10 Jean-Pierre Roux
1091 * FIX : gdcmHeader::LoadElements is now based
1092 on the ListTag listElem member,
1093 not longer on the TagElValueHT tagHt member
1094 * ENH : PrintPubElVal shows (temporarily) both results,
1095 with the tagHt member and the listElem member.
1096 (it's easier to 'see' the problems when using Printheader)
1098 * FIX : old private member LgrElem is now splitted into
1099 ReadLength : Length actually found on disk (updated only
1100 if bug fixing is necessary), for internal
1102 UsableLength : Updated by FixFoundLength, to fix a bug
1103 or to allow Parser going on.
1104 Will allow to re-write a kosher header when a SeQuence
1105 with a length (not 0000) is found
1106 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1107 because gdcmElValSet::Add does not update ListElem
1110 2003-11-07 Jean-Pierre Roux
1111 * FIX misstyping in Transfert Syntax name table
1112 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1113 when they have an actual length (not 0000 nor FFFFF)
1114 (Nobody should care of it, but DICOMDIR explorers)
1116 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1117 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1119 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * ENH: vtkGdcmReader now supports LUT !
1121 (vtkgdcmViewer for now is not able to use them though)
1123 2003-11-05 Jean-Pierre Roux
1124 * in testSuite.py : new files names for checking the package
1125 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1126 that returns the pixel area size to the *aware* (vtk) user
1127 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1129 2003-11-05 Benoit Regrain
1130 * in testSuite.py : Modify the rules for checking the paths
1131 : Explicit error messages
1132 * in __init__.py : Related modif
1134 2003-11-03 Jean-Pierre Roux
1135 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1136 to be used by aware (vtk) users that want to manage
1137 LUT (and no to turn the PALETTE image into an RGB pixels one)
1138 * GetPixelType now returns 8U for 24 Bits images
1139 (vtkGdcmReader compliant)
1141 2003-10-31 Jean-Pierre Roux
1142 * Removal of *all* gdcmData images and add them again
1143 in order to loose the 'history' of un-anonymised images
1145 2003-10-31 Jean-Pierre Roux
1146 * RMV : removal of useless jBitsInJsample.h
1147 for both 8 and 12 Bits JPEG Lossy Libraries
1149 2003-10-31 Jean-Pierre Roux
1150 * ENH : Add the functions gdcmFile::GetImageDataRaw
1151 gdcmFile::GetImageDataIntoVectorRaw
1152 that act as GetImageData and GetImageDataIntoVector
1153 except the making of an RGB Plane from Gray Plane + LUT
1154 Intended to aware (vtk) users who know how to manage
1157 GetLUTRGBA return a R,G,B,A LUT if any
1158 lgrTotaleRaw gives the 'Raw' length
1159 GetImageDataRaw returns the gray Plane
1160 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1161 (They stay Grey, just like with other Dicom viewers :-(
1163 2003-10-30 Jean-Pierre Roux
1164 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1166 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1168 being coherents dicom files.
1170 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1171 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1173 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1174 * ENH: Two steps is necessary to please VC++ compiler...
1175 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1176 * ENH: Add include dir to medcon lib
1177 * FIX: only one function is being exported for now !
1178 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1180 2003-10-29 Jean-Pierre Roux
1181 * adding gdcmHeader::GetLUTRGBA
1182 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1183 --> Mathieu, the modif u're waiting for is not yet committed
1184 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1186 2003-10-27 Jean-Pierre Roux
1187 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1188 00191113.dcm DermaColorLossLess.dcm
1189 MxTwinLossLess.dcm RadBWLossLess.dcm
1190 * ENH: For version prior to vtkImageViewer2 -r 1.19
1191 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1193 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1194 * Removal of ido stuff in CMakeLists.txt
1196 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1197 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1198 * FIX: remove a call to ->Modified ... see comments
1199 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1201 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * FIX: Problem with path for libvtkgdcmPython
1203 * ENH: Try adding a search script for python site-package
1204 * RMV: Remove some file from medcon lib that are not necessary
1205 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1206 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1207 * FIX: More pragma disable fro VC++,
1208 I don't think I break something as it is also disable in VTK/ITK.
1209 But it fasten debug compilation time.
1211 2003-10-23 Jean-Pierre Roux
1212 * gdcm now deals with 16 Bits Run Length Encoded images
1213 (they are compressed as 2 planes images,
1214 one for the high Bytes, the other for low Bytes)
1216 2003-10-22 Jean-Pierre Roux
1217 * Now CheckRead takes into account :
1218 - the bugged 'Leonardo' Siemens images
1219 - the XA images, sent thru the burning VPRO station
1220 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1223 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1224 * FIX: When copying a Makefile.am to CMakeLists.txt
1225 one should remove the '\'
1227 2003-10-22 Jean-Pierre Roux
1228 * in gdcmData adding a bugged 'Leonardo' Siemens image
1229 (wrong lengths in header)
1230 OK with gdcm, KO with the other viewers :-)
1231 * add a GE dlx XA image, thru the VEPRO burning station
1234 2003-10-21 Jean-Pierre Roux
1235 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1236 for a brutal checking of vtkgdcmViewer compliance
1238 2003-10-21 Jean-Pierre Roux
1239 * add the files for 'xmedcon' Jpeg Lossless library
1240 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1242 2003-10-21 Jean-Pierre Roux
1243 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1245 2003-10-21 Jean-Pierre Roux
1246 * garbage Siemens 'Leonardo' images dealt with
1247 (the patch is easy to remove)
1248 * cosmetic changes to avoid warnings
1250 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1251 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1252 no need to press 'r' now.
1254 2003-10-20 Jean-Pierre Roux
1255 * upgrade of checkRead.sh checkWrite.sh according
1256 to new Jpeg Lossless decompressor
1257 * add US.3405.1.dcm, a genuine RGB medical file ...
1258 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1259 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1261 2003-10-15 Jean-Pierre Roux
1262 * general anonymisation in gdcmData
1263 * adding the 'color files' from
1264 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1265 * adding some well knowed bugged-header images
1266 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1267 waiting for their inclusion in Python testsuite
1269 2003-10-15 Jean-Pierre Roux
1270 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1271 no longer seg faults when file is not found
1273 2003-10-14 Jean-Pierre Roux
1274 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1277 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1278 * TODO: *.in file to genereate a UseGDCM later
1280 2003-10-14 Jean-Pierre Roux
1281 * Some supposed-to-be Dicom Images have no preamble.
1282 OpenFile takes it into account
1283 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1284 * Missing elements added in dicomV3.dic
1285 (just to be affraid : have a look at
1286 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1287 and do it again next year ;->
1289 2003-10-13 Jean-Pierre Roux
1290 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1291 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1292 But there are NOT. It's fixed !
1294 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1295 * FIX: "jpeglib.h" was not found on VC++
1296 * FIX: vtkgdcm was not being installed
1298 2003-10-10 Jean-Pierre Roux
1299 * ENH : OpenFile closes the file if it *really* doesn't look like
1300 an ACR-NEMA / DICOM one.
1301 * FIX : testWrite no longer writes an empty file if the source file
1302 is not gdcm Readable
1303 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1306 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * FIX: CMake generate now documentation
1308 * ENH: out of source doc build !
1309 * ENH: Generate both user and dev documentation
1310 * ENH: Should work on windows too
1311 * ENH: Only one doxygen config.in file is needed
1312 * FIX: make install should be ok now on ùnix plateform
1313 * FIX: PATH to dictionary was wrong (missing /)
1314 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1316 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1317 * vtkGdcmReader is now able to read rgb dicom file.
1318 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1319 * added a gdcmViewer to vtk test, use mouse to control
1320 window level & window width
1322 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1323 * CMake-ification of gdcm, we have now two build system
1324 * FIX: on cygwin Wsock32 doesn't exist
1325 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1327 2003-10-06 Emanuel Ollart
1328 * FIX : compilation process wad broken.
1329 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1331 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1332 * change gdcmViewer -> vtkgdcmViewer
1333 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1335 2003-10-06 Jean-Pierre Roux
1336 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1337 ( e.g : well known GE images with a wrong elem length,
1338 : Philips MRI Images with a wrong Huffman table)
1339 * still to be done : allow the reading of bugged LEONARDO Siemens images
1341 2003-10-03 Jean-Pierre Roux
1342 * Odd length strings are padded with '\0' (not with spaces,
1343 to remain compliant with already defined strings,
1344 like Transfert Syntax UID and others)
1346 2003-10-03 Jean-Pierre Roux
1347 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1348 to allow displaying RGB images (not only by affim ;-)
1350 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1351 * vtkGdcmReader is now able to read rgb dicom file.
1352 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1354 2003-10-03 Jean-Pierre Roux
1355 * A few nasty patches to allow the reading of a lot of nasty images
1356 ( e.g : well known GE images with a wrong elem length,
1357 : Philips MRI Images with a wrong Huffman table)
1358 * still to be done : allow the reading of bugged LEONARDO Siemens images
1360 2003-10-03 Jean-Pierre Roux
1361 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1363 2003-10-03 Jean-Pierre Roux
1364 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1365 to allow displaying RGB images (not only by affim ;-)
1367 2003-10-03 Jean-Pierre Roux
1368 * gdcmFile::GetImageDataIntoVector now
1369 - deals with MultiFrames MultiFragments Run Length Encoded files
1370 - deals with YcBcR (YBR_FULL) files
1371 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1372 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1374 (no sample found :-(
1376 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1377 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1378 Two reasons: - clear things
1379 - third parties acces gdcm through header files, so won't
1380 suffer anymore VC++ complains
1382 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1383 * add argv[1] in testvtkGdcmReader.cxx
1386 2003-09-24 Jean-Pierre Roux
1387 * The lines are now eigthy characters long.for
1388 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1390 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1391 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1392 char* to std::string. Thus, the use of strdup becomes useless. (see
1393 previous commis of Malaterre)
1394 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1395 before the last Malaterre's commit.
1397 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1398 * This commit should fix the Debug building under VC++, the problem
1399 was mainly a mixture of debug and release lib being loaded at startup.
1400 * I also remove a depency to a specific C function: strdup. Because I had
1401 to force the link to msvcrtd (whereas strdup is in libc).
1403 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1404 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1405 located in the gdcmCommon.h file. All use of reference of tha has been
1406 changed to now use the variable GDCM_UNFOUND.
1408 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1410 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1411 Dicom dictionary. The test suite can now be run again. Note:
1412 I'm note very happy with the " (RET)" changes. I believe this
1413 RETAINED comment should be dropped when parsing the dictionary.
1414 - PACKAGER corrected
1416 - AUTHORS updated and now in alphabetical order
1417 * Makefile.am now exports gdcm.dsw for Windoze users.
1419 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * cygwin complains about missing std:: in subdir Test/
1422 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1423 * remove some methods that are now in gdcmHeaderHelper
1425 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * vtkGdcmReader set spacing and origin correctly
1428 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1429 * Fix a few delete/delete[] mismatch
1431 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1433 interpretation to data given by gdcmHeader. For instance there are
1434 heuristics to get informations (look at different places).
1435 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1436 sorting DICOM images based on different strategies.
1437 * modified Makefiles accordingly.
1439 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1440 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1441 when building in debug mode
1442 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1443 src/win32/gdcmdll.dsp
1444 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1446 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1450 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1451 * src/win32/libgdcmjpeg12.dsp was not dos format
1452 * src/win32/libgdcmjpeg12.dsp :
1453 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1454 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1456 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1457 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1459 * src/gdcmFile.cxx : bug fix in affectation type
1460 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1461 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1462 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1463 symbols... future problem ?
1465 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1466 * src/win32/libgdcmijpeg12.dsp was missing
1467 * modified gdcm.dsw accordingly
1469 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1470 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1472 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1473 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1474 commit of JPR (before his hollidays to facilitate our work).
1475 * setup.py : bug fix in code. Modifications made while the last commit
1476 of JPR. The code hasn't been tested before the commit... it's so
1477 useless to make that (for best programmer that is JPR) !!!
1479 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1480 * tagged the current version as Version0_3 (i.e. version 0.3)
1482 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1483 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1484 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1485 * *.dsp : modifications to use new libgdcmijpeg8 library
1486 * setup.py : bug fix on VTKPATH variable
1487 * PACKAGER : adding all concerning windows
1489 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1490 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1492 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1493 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1494 test suite reported error.
1495 * PACKAGER file added (describes what a packager must do when
1496 packaging a new release).
1497 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1498 * configure.in: upgraded version number to 0.3.0
1499 * fixing build of rpm (through rpm -ta):
1500 - Doc/Makefile.am exports proper doxygen files
1501 - src/jpeg/libijg8/Makefile.am exports the include files.
1503 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1504 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1505 * src/gdcmHeader.h : formatting code
1507 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1508 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1509 We were obtaining error message from vtk. Now, creation of file list
1510 is made in an internal list to prevent this problem.
1511 Bug fix when output is empty.
1512 Bug fix in update of progress value. Previous commit for this was a bad
1514 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1516 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1517 * src/gdcmHeader.h : added method to get the file name
1518 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1519 files. Added method to remove all files on the input
1520 Added FIXME comment concerning the bad parsing of header made by
1521 ExecuteInformation method (in ExecuteData method)
1523 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1525 when using make instal.
1526 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1527 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1529 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1530 * setup.py : adding include dir of jpeg lib to compile all sources
1531 * */Win32/*.dsp : JPR fix for windows compilation
1533 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1534 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1536 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1537 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1539 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * setup.py is again effective on un*x (takes into account the
1541 addon of the jpeg library)
1542 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1543 * Doc/Doxy* updated (includes above enhancements)
1544 * INSTALL now points to web documentation
1546 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * src/gdcmHeader.h doesn't make unnecessary reference to
1549 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1551 * src/gdcm*.[cxx|h] :
1552 - to allow compilation with gcc 3.x
1553 -- clean up of STL usage (added explicit usage of std::)
1554 -- small fixes on exceptions.
1555 Note: linking not tested !
1556 - clean of doxygen comments to avoid warnings at documentation
1558 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1559 dependent convertion).
1561 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1562 * Clean up of previous JPR garbage commit (not even commented in the
1564 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1565 - moved all jpeg related files from src to src/jpeg/libijg8, with
1566 addition/modification of Makefile.am and configure.in.
1567 - the testSuite is still brain damage (not guilty).
1569 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1570 * WrapVTK.py : modifications to get correctly vtk source files to
1572 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1573 (FileName -> Filename)
1575 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1576 * vtk/vtkGdcmReader.[cxx/h]:
1577 - UpdateProgress method should now be effective
1578 - removed the limitation on having only images loaded (as opposed
1580 - when building a stack of images/volume, a lesser number of
1581 gdcmHeader and gdcmFile instances should be used (hopefully
1582 accelerating things).
1583 - when building a stack of images/volumes, files which are not
1584 loadable (wrong path-filename, wrong permissions on existing file,
1585 or file not parsable by gdcm) are replaced with a black image
1586 in the stack (for the caller to notice the problem).
1588 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1589 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1591 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1592 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1593 between standard library (std) and vtk library (problems are found
1594 under Windows... thanks Windows !)
1596 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1597 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1599 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1601 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1602 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1604 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1605 * When compiling with distutils (see setup.py) the C++ compiler is
1606 called with different flags than the default ones (with automake).
1607 In order to fix all those warning, I compiled gdcm with the command
1608 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1609 and went for warning fixes:
1610 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1611 up from unused variables.
1612 - vtk/vtkGdcmReader.cxx: potential bug fix.
1613 * src/gdcmHeader.h: Doxygen warning cleanup
1615 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1616 * gdcmPython/gdcm.i:
1617 - typemaps correction to take into account the systematic replacement
1618 of "using namespace std" with std:: prefix e.g. std::list,
1619 std::string... (cf changes of 2003-05-21).
1620 - gdcmGlob global variable of type gdcmGlobal (defined in
1621 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1622 exported to Python a as cvar.
1623 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1624 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1625 gdcmDictSet.GetPubDictTagNames() and
1626 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1627 C++ static methods).
1628 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1629 with the above changes.
1631 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1632 * setup.py, manifest.in : bug fix under linux
1634 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1635 * Modification of setup.py to compile vtk part too. Then, we have 2
1636 wrappers which must work with same distutils. For that, we have a
1637 generic distutils in distusiltsWrapping.py ; with :
1638 - build_extWrap class to wrap generically all extensions,
1639 - ExtensionWrap base class for all wrapping extension that contains
1641 - Wrapper interface which wrap sources
1642 + In WrapSwig.py we have extension and wrapper for Swig
1643 + In WrapVTK.py we have extension and wrapper for VTK
1644 * MANIFEST.in : modifications to consider vtk directory and new python
1645 files for compilation
1647 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1648 * Added python wrappers of vtkGdcmReader vtk class (see the
1649 source in vtk/vtkGdcmReader.cxx) :
1650 - vtk/Makefile.am now builds a library
1651 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1652 python library (as opposed to _gdcm.so wich are the python
1653 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1654 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1656 - configure.in has an additional flag --enable-vtk that needs
1657 to be set to enable compilation of vtk related code, that is:
1658 + vtk/vtkGdcmReader.so and
1659 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1660 + gdcmPython/vtkgdcmPython.so (see above)
1661 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1662 be read when compressed or when HighBit + 1 != BitsStored),
1663 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1664 the usage of the python wrapper of vtkGdcmReader vtk class.
1665 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1666 * src/*.[h] all occurences of stl classes are now prefixed with
1667 std::, and all occurences of "using namespace std;" where removed.
1668 This is to avoid pollution of global namespace in included files.
1669 Apparently vtk does not avoid this pitfall: when using both
1670 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1671 collision of various stl members (principally cout...).
1672 * gdcmPython/testSuite.py now cleanly removes temprory generated
1674 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1675 comply with above changes)
1677 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1678 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1679 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1680 vtk data structure (an image Flip was required).
1681 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1682 * cosmetic changes in documentation.
1684 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1685 * src/gdcmHeader.cxx: the constructor no longer exits when an
1686 unexisting file is given as argument.
1687 * The subdirectory Data (containing all the images used for the
1688 test suite) is not part of this repository anymore. A new module
1689 containing those images is now available at
1690 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1691 with the name gdcmData.
1692 All the python scripts (including the package initialisation file
1693 gdcmPython/__init__.py) were adapated to take this change into
1694 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1696 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1697 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1698 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1699 demo of the usage of this class.
1700 Compilation of this vtk part is only done when using the --enable-vtk
1701 at configure (or autogen.sh) stage.
1703 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1704 * More memory link related corrections and documentation fixes.
1706 - maximum info is obtained with a command of the form:
1707 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1708 --show-reachable=yes PrintHeader
1709 - the remaining reachable blocks seem to come from the STL
1710 allocation scheme through the usage of map and list. It looks
1711 like this memory cannot be freed but it is not a memory leak
1712 (in fact further invocation to the STL would recollect the
1713 unused memory allthough it cannot explicitely be freed).
1714 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1715 of displaying an image parsed with gdcm and displayed with VTK.
1716 Note: some images don't seem to work e.g.
1717 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1718 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1719 Allthough this weakens the semantics, it is a ditch attempt to
1720 make gdcm more thread friendly.
1722 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1723 * Memory link hunt (by using valgrind through the command
1724 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1725 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1726 gdcmHeader::_dicom_vr.
1727 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1728 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1730 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1732 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1733 * src/Makefile.am now exports all the necessary include files at
1737 * UpdateGroupLength replaced by new one
1740 * UpdateGroupLength re-written using H-Table
1741 (named UpdateGroupLengthNew untill checks are over)
1743 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1744 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1745 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1747 - gdcmHeader::GetPubElValSet removed.
1748 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1749 UpdateGroupLength, WriteElements, Write.
1750 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1751 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1752 carried the same semantics.
1753 - src/gdcmHeaderIdo.cxx changed accordingly.
1754 - gdcmFile::WriteBase now regroups all the codes from previous
1755 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1756 - enum FileType moved to gdcmCommon.h
1757 * src/gdcmHeader.cxx AddDefault trashed
1758 * gdcmGetXSize added
1759 * getimageDataSize now calls gdcmGetXSize
1760 * Test/*.cxx changed to agree with above changes
1762 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1764 (to avoid double call by end user).
1765 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1766 by end user, since gdcmHeader::gdcmHeader now handles it.
1768 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * gdcm/Doc many doxygen changes:
1770 - Doxyfile now has two different versions, DoxyfileUsers that generates
1771 the html.users end users oriented documentation and
1772 DoxyfileDeveloppers that generates the html.developper developper
1773 oriented documentation.
1774 - README changed accordingly
1775 - requirement.txt removed (old design info moved to TODO).
1776 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1777 DoxyMainPage.txt, DoxyPython.txt provide more information.
1778 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1779 be updated by simply regenerating the docs with doxygen and copying
1780 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1781 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1782 all the tests in the form "if (<map>.count() >1)" were removed.
1783 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1784 ill-formed documentation sections.
1785 * src/gdcmHeader.cxx: ditto
1787 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * setup.py fixed for un*x (needed macro for stdint.h)
1789 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1790 un*ces with sh-utils test utility.
1791 * gdcmPython/demo/test.py renamed to PrintHeader.py
1792 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1793 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1794 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1795 * src/gdcm*.cxx JPR's bad inclusion fixed.
1797 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1798 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1799 * gdcmPython/demo/test.py changed accordingly.
1801 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * gdcmPython/Makefile.am fixed linking against libstdc++
1803 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1804 * Swig subdir (historical tests of swig version 1.3.17++) removed
1805 * Test/testChangeEntete.cxx some lines commented out in order to make
1807 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1808 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1810 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1812 hence the user doesn't need this explicit call.
1813 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1814 i.e. LoadElements() call removed.
1815 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1816 - src/Makefile.am declares the proper flag for g++.
1817 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1818 for adding user defined new tags.
1819 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1820 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1821 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1823 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1824 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1825 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1826 src/Makefile.am : the project should properly compile and install
1827 with the autotools, included the python wrappers part.
1828 * gdcm.spec.in : added a spec file for RPM packaging.
1830 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1831 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1833 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1835 to exported to the environement (see gdcmPython/testSuite.py
1837 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1838 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1839 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1840 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1841 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1843 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * gdcmPython/__init__.py doesn't crash anymore when running in
1845 in InstallMode or PreInstallMode but with an environement given
1846 value of GDCM_DICT_PATH.
1847 * src/gdcmDictSet.[cxx/h] coding style.
1849 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1851 * src/gdcm.h general comments moved to TODO, and README
1852 * src/gdcm.h should now be seen as a user commodity (including it
1853 should suffice to fully use gdcm). It is nowhere including within
1854 any of the kernel files src/*.cxx and src/*.h.
1856 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1857 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1858 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1860 * src/gdcm*.cxx only include their corresponding include file
1861 (as opposed to gdcm.h)
1862 * gdcmPython/gdcm.i changed accordingly
1863 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1864 the autogen.sh generated "make snapshot" command to work.
1865 * autogen.sh removed history related references to crea package.
1867 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * distutilsSwigCPlusPlus.py work around some swig portability
1871 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1873 was done in a last ditch attempt to get setup.py _really_
1874 operationnal. The python/gdcmPython layaout add the advantage
1875 of hidding away the python related distutils specific files
1876 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1877 Alas, the src directory was out of scope (i.e. it's relative
1878 position to setup.py was ../src) which made things impossible to
1879 handle (see previous version of python/setup.py). Crossing fingers...
1881 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1882 * python/setup.py now works on Un*x. (harder than I thougth)
1883 * python/distutilsSwigCPlusPlus.py can now have include files
1884 among the list of sources.
1886 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1887 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1888 * modifications in MSVC projects
1890 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * As stated by the first lines of Test/ExceptionAndPython/README, it
1892 looks like we can move back to original usage of exception within
1893 src/gdcm* and hence remove the errno stuff that was introduced
1894 as a quick and dirty fixture of this problem (added to the TODO).
1895 * Doc/Doxyfile configuration file for Doxygen and corresponding
1896 README file for usage added.
1897 * Test/testWrite.cxx added. This new test comes from a split of
1898 test.cxx that is now reverted to its original purpous i.e.
1899 testing the proper parsing of a Dicom related file.
1900 testWrite.cxx concentrates on testing the IO part of gdcm.
1901 * Test/bug1.cxx (containing a bug on WIn32) added.
1902 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1903 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1904 whose purpose is to publish the content of the TagNames of the
1905 Dicom public dictionnary were not accessible without an
1906 instance of class gdcmHeader.
1907 - those methods are now static methods of gdcmDictSet and hence
1908 require no instances at all to be invocated.
1909 - within gdcmDictSet this change required to change some method
1910 to class methods (i.e. are now static) among which SetDictPath
1911 (renamed to BuildDictPath) and LoadDefaultPubDict.
1912 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1913 the above changes by calling the new method classes of gdcmDictSet.
1914 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1915 the above to be effective.
1916 * python/gdcmPython: in order to wrap properly the above changes
1917 for Python, swig version now needs to be > 1.3.17.
1918 * python/gdcmPython/Makefile fixed to adapt itself to new
1919 configure/make shema introduced by Johan Montagnat (thanks for the
1920 contribution). Alas this Makefile cannot be turned into a proper
1921 Makefile.am without some heavy changes in the configure.in
1922 (for python dectection).
1923 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1924 now avoids publishing the empty entries.
1926 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1927 * python/setup.py : bug fix concerning install under windows
1928 ExtraPath reused :-P
1929 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1931 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1932 * Dicts/dicomV3.dic : remove double spaces !!!
1933 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1934 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1937 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1938 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1939 method. Doxygenation.
1940 * src/gdcm.h clean up of JPR spurious comments.
1942 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * python/distutilsSwigCPlusPlus.py now properly collects the
1944 shadow classes generated by "swig -c++" (gdcm.py in our case)
1945 when using "python setup.py install".
1946 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1947 reexports the working classes.
1948 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1949 by the classical C errno scheme. This is to prevent an obscure
1950 behavior of the python wrappers when importing wxPython.wx prior
1951 to gdcmPython (which ended up in an abort call). An illustration
1952 of this oddity can be found in the Test/ExceptionAndPython
1953 subdir (see the README file). This problem probably due to
1954 an combination of g++ and dynamic loading.
1955 * added Test/ExceptionAndPython (see above)
1957 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * Changed the layout of the python part to avoid bloating main
1959 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1960 i.e. the distutils arsenal. All the python related stuff is
1961 again in a python subdir, but the package itself is now in
1963 * setup.py was cleaned up:
1964 - pythonIncludePath removed
1965 - python setup.py bdist target is now functional.
1966 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1967 collision with other packages). gdcmPython/demo/*.py changed
1970 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * python subdir moved to gdcmPython (preparation of distutils packaging).
1972 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1973 distutils installer is operational.
1974 * - gdcmPython/__init__.py now properly loads the swig generated
1975 shadow classes (from gdcm.py).
1976 - gdcmPython/demo/*.py changed to import the package gdcmPython
1977 instead of gdcmPython/demo/load.py.
1978 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1980 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1981 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1982 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1983 entries within the associated public Dicom dictionary resp. the same
1984 information but sorted by the fourth field (PAT, IMG, DIR) of the
1986 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1987 are now in the "???" group.
1988 - python/gdcm.i changed accordingly,
1989 - python/demo/printGroupedPublicDict.py added, that gives an example
1990 of the above new functionalities in Python.
1992 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * src/gdcm.h, gdcmHeader.cxx:
1994 - historic references to glib's g_malloc and g_free (#defined)
1995 were definitively removed.
1996 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1997 * src/gdcmElValSet.cxx:
1998 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1999 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2000 - GetElValue(string) renamed to GetElValueByName.
2001 - Added GetElementByName(string).
2002 * src/gdcmHeader.cxx: added
2003 - GetPubElValRepByNumber(guint16, guint16)
2004 - GetPubElValRepByName(string)
2005 - GetShaElValRepByNumber(guint16, guint16)
2006 - GetShaElValRepByName(string)
2007 - GetShaElValByNumber(guint16, guint16)
2008 - GetShaElValRepByName(string)
2009 - GetElValRepByNumber(guint16, guint16)
2010 - GetElValRepByName(string)
2011 - GetElValByNumber(guint16, guint16)
2012 - GetElValRepByName(string)
2013 * Doc/requirements.txt added.
2015 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * Test/Makefile building now depends on the one of libgdcm.so
2017 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2018 pixel data) aware which enables finding the address (offset) of
2019 the pixel data of JPEG encoded DICOM files. This leaves only a single
2020 file in the testSuite whose pixel data address (offset) is unknown.
2021 * python/testSuite.py changed accordingly.
2023 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2024 * VC++ has some strong limitations when working with the STL, as stated
2025 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2026 "Also note that some STL containers (map, set, queue, list, deque)
2027 cannot be exported. [...]
2028 Some STL classes contain nested classes. These classes can not
2030 This is caused by a designed limitation that once a template
2031 class is instantiated, it can not be re-instantiated and
2033 Since our usage of map<> is ubiquitous in gdcm, this "designed
2034 limitation" of VC++ is a pitfall.
2035 Hence the Python wrappers of gdcm cannot be incrementally linked
2036 against the c++ dynamic library. The dirty but only workaround is
2037 to forget about incremental link of dynamic libraries and to generate
2038 the Python wrappers library with the inclusions of the underlying C++
2040 The following modifications concern this matter on Win32/VC++:
2041 - wrapping python correct with standalone wrapped dll (don't use separate
2042 dll under windows !!!!)
2043 - python21_d debug mode enabled (ask Frog how to use it :-)
2044 - NO problem with having an STL member of class for example string in C++
2045 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2046 - Python test of dcmlib in Python is ok under windows on a large set
2048 * removed glib references
2049 * typedef's inserted in gdcm.i for correct swig type management
2051 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2052 * python/demo/*.py load.py extracted from test.py. Added explore.py
2053 that only displays required tags and testAll.py that parses all
2054 the files of the testsuite without using unittest.
2055 * python/testSuite.py other additional test on new files added.
2056 * Data/* new test files added accordingly to the testSuite.
2057 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2058 the vr in the file differs from the one of the dictionary.
2060 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2061 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2062 values, but limits itself to values which are below a user specified
2063 size (by default 1024 bytes).
2064 * python/gdcm.i : elements not loaded (because their size is above the
2065 user specified treshold) are exported with their TagKey as key of the
2066 python dictionary. This enables the testsuite to make some checks
2067 on the unloaded elements (since we have their offset and size).
2068 * python/testSuite.py
2069 - now tests for the existence and proper value of the pixel data
2070 - two new examples added.
2071 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2073 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2074 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2075 aware. See the strategy comments in gdcmHeader::FindeLength().
2076 * Test/test.cxx now accepts a filename as first argument.
2077 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2078 * python/testSuite.py changed to integrate test on above files.
2080 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2082 the vr was also RET.
2083 * python/testSuite.py more tests added.
2085 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * python/testSuite.py unittest test suite added (uses Data)
2087 * Data/* dcm and acr files for the test suite.
2088 * glib dependance removed from un*x version. We now use ISO C99
2089 7.18 Integer types (see stdint.h)
2090 - python/Makefile, src/Makefile src/gdcm.h
2091 * src/ when an explicit vr (like dicom files) suddenly poped an
2092 implicit element we use to mark the underlying DictEntry of the
2093 concerned ElValue with "Implicit". This strategy was damageable
2094 too the public or provite dictionaries, since some of their vr
2095 would be changed. Since Header::FindLength heavily relies on the
2096 detection by Header::FindVR of falsely explicit elements, I
2097 added an extra ImplicitVr member to ElValue (boolean).
2098 The rest of the changes we the necessary adaptations.
2100 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2101 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2103 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2105 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * Adaptation for porting to VC++:
2108 o forced to use std namespace (for string to be known)
2109 o all class use __declspec export style on WIN32
2110 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2111 (in stdlib.h on Win32 but in std:: for gcc)
2112 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2113 variable GDCM_DICT_PATH.
2114 * src/gdcmHeader.cxx verbose comments made discrete.
2116 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * python/gdcm.i: added a typemap that converts a C++ hashing table
2118 to native Python dictionary.
2119 * python/demo/test.py:
2120 - now uses the native dictionary for exploration of gdcmHeader.
2121 - takes an optional filename argument (the file to parse).
2122 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2123 PubElVals hashing table.
2124 * Dicts/dicomV3.dic removed error prone trailing spaces.
2126 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * Python wrapping process moved away from src/Makefile to
2128 newly created python/Makefile (as well as gdcm.i)
2129 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2130 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2131 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2132 from the environement variable GDCM_DICT_PATH (when existing).
2133 * src/gdcmDict::GetTag bug fix.
2135 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * Straightforward temporary fixes for swig to build the python wrappers.
2137 src/Makefile now has a python working entry [by working we mean
2138 that we can import de shadow classes without errors].
2140 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * hashtest.cxx removed (since allready in Test)
2142 * src/gdcmlib.h renamed to src/gdcm.h
2143 * src/dcm.i renamed to src/gdcm.i
2144 * src/Makefile prepared for python wrapping
2146 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * src/gdcmHeader.cxx :
2148 - Parsing of header is now separated from loading of element values
2149 (see gdcmHeader::LoadElements).
2150 - general clean up of hopefully all file access (creation of
2151 ReadInt16 and ReadInt32)
2153 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmHeader.cxx :
2155 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2157 - SetLgrElem renamed to SetLength
2158 - GetLgrElem renamed to GetLength
2159 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2160 * src/gdcmElValSet.cxx fixed both GetElValue methods
2161 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2162 due to IdoDude was cleaned out.
2164 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2166 concentrates on finding the value representation (when it exists).
2167 RecupLgr now only finds the element value length, and it avoids
2168 returning the unecessary skL (skipped length).
2169 Also, offsetCourant was simply removed (with taille_fich) since
2170 it was redundant with the File position internals (by using
2171 ftell and fseek). This also made skL (see above in RecupLgr) usage
2173 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2174 on the libido specificities which are handled through class
2176 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2179 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * Truckload of changes. Parsing of header is barely functional
2181 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2183 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * src/gdcmHeader.cxx many addons of low level methods
2186 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2188 and _IdDcmSWAP_LONG.
2190 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * This corresponds to all the changes decided at the meeting of
2192 May 23 2002. Needless to say we are running late...