1 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
4 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * Testing/TestMAkeIcon.cxx : complete the test
7 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
8 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
10 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
14 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
17 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Test/ : accelerate tests (it's not very significant accelerations).
19 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
21 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * Testing/TestSequence.cxx : add test for sequences of images... test that
23 we have the same serie or the same study UID
25 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
28 * src/gdcmDict.h : remove commented code
29 * src/gdcmDocument.cxx : initialize values
30 * src/gdcmFile.cxx : bug fix when reading values
31 * gdcmPython/demo/ : change file names. Remove useless files
33 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * src/gdcmFile.cxx : remove the default array of initialization.
35 The static array contained pointers to non-static values (comming from
36 strings). To have coherences, when creating files, these values can't be
37 static. So, the array can't be static, too ! To simplify, the array have
38 been replaced by repeted lines to insert values in the File
40 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
42 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
44 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
45 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
46 (Dicom Element) into the Sequence Item
48 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/*.cxx : first parss to normalize file organisation
51 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/gdcmDirList.[h|cxx] : add method to find a directory
53 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
55 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
56 * Finish cleaning up my JPEG mess. Should be ok now.
57 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
58 contained within the RLE* class(doh!)
60 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
61 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
62 * SerieHeader::AddFileName() creates as many Coherent Files lists
63 (same Serie UID) as it founds different Serie UID
64 amongst the files instead of discarting any file
65 that doesn't match with the first one he found.
66 * SerieHeader::OrderGdcmFileList has now one parameter :
67 the Coherent Files list the user wants to sort
68 * SerieHeader::GetFirstCoherentFileList() |
69 * SerieHeader::GetLastCoherentFileList() | allow to parse
70 the set of Coherent Files lists
71 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
72 compatibility (it returns the *first* Coherent Files list,
73 since there was only one before)
74 * Test/TestSerieHeader gets gdcmData as a default root directory
76 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Remove friend between DocEntry and File classes
78 * Remove friend between PixelReadConverter and RLEFramesInfo,
81 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
83 0002|0000. The value was incorrect.
85 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
88 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmUtil.cxx : compilation fix on Win32
90 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
91 variable, to be easy found. Add methods to change the default UID.
92 Amelioration of the CreateUniqueUID to use the correct default UID.
93 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
96 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Test/TestVR.cxx : fix memory leaks
99 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
100 * Rewrite the base 256 to base 10 conversion, using string operation only.
101 This allows us to get rid of the problematic 64bits integer type (does not
102 always exist on target platform).
104 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
105 * Add construct and destructor to class gdcm::Debug to close the debug file
107 * Don't let uset to open twice the same file
108 * gdcm has now an official UID prefix,
109 supplied by http://www.medicalconnections.co.uk
110 1.2.826.0.1.3680043.2.1143
111 (Thx to Mathieu for providing URL)
112 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
113 to be able to perform some more tests
114 * gdcm::ContentEntry : Contructors and Destructor are now protected,
115 in order to be sure no user will try to use them.
116 (at user level, only the children classes are meaningfull)
118 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * move RLEInfo & JPEGInfo from Document to File
121 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * FIX : remove so many friend between classes
124 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
125 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
126 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
128 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
129 In order to avoid missbehaviour :
130 . gdcm::DocEntry is now specialized in
131 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
132 - gdcm::ContentEntry (Dicom entry with a 'content')
133 . gdcm::ContentEntry is specialized in
134 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
135 characters value, or integers)
136 - gdcm::BinEntry (Dicom entry with a non strig representable value
137 (user hasn't any longer to thing about the precedence of his dynamic_casts)
139 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * Test/VTKTest*.cxx : bug fix under linux
142 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
144 use with python. Some methods are moved from Document to ElementSet or
145 DocEntrySet. The equivalent methods to ElementSet have been added to
146 SQItem and are virtual in DocEntrySet. Methods that may have the same code
147 in SQItem and ElementSet is directly placed in DocEntrySet
149 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * Test/VTKTest*.cxx : remove the show variable in each test method because
151 it's useless (the viewer variable replace this variable)
153 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/gdcmDocument.cxx : bug fix on potential memory leak
155 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
156 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
157 Add ClearXxx methods to remove all the content of the list or map
158 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
160 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
161 * methods ReplaceOrCreate renamed as Insert
162 (nobody will be any longer confused by 'CreateOrReplace')
164 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
165 * Grealty simplify the JPEg decompression, no need to differenciate based on
166 the JPEG possible type (with/without fragment, with/without multiple frame).
167 Everything is done throught the JPEG IO Suspension mechanism in IJG
169 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
170 * Stage 3 of normalization :
171 in order to avoid any missunderstanding while reading method names :
172 - All the methods xxxEntry now deal with dicom Entries
173 - Methods GetEntry splitted into
176 - Method SetEntry renamed as SetEntryValue
177 - Method SetEntryBinArea let as it was
179 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
180 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
181 - Position correctly the entry points for JPEG2000 and JPEG-LS
182 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
184 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
186 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
187 with other method names
188 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
189 * Test/TestDicomDirElement.cxx : add new test
191 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
193 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
194 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
195 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
196 So can't you use __int64 in ostream at all.
198 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * bug fix for compilation on MSVC6
200 * gdcmPython/gdcm.i : rename of classes missed
202 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
203 * Stage 2 of names normalization :
204 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
205 (easy to understand ...)
206 - gdcm::FileHelper replaces old class gdcm::File
208 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
210 type and not a string. So, there remove problems on the format of the
213 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
214 * Add Example/TestPapyrus.cxx
215 - reads a Papyrus file (gdcm::Header compliant),
216 - gets the pixels of all the images, using low level iterators
217 - writes an multiframes Dicom image.
218 (Just to show it's *possible* to do that)
219 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
222 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
224 Thus, DicomDirXXX are created with a flad that indicates if the created
225 object is empty or not (when not empty, the DicomDirElement is used to
228 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
230 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
232 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
233 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
235 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
237 Remove all access to the hash-tables or lists in the objects.
239 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
241 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
242 be complient with all the gdcm source code
244 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
248 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
252 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * Test/ : rename VTK tests to have a best name for the tests
254 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
255 GetFirstEntry/GetNextEntry use
257 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
258 * In SerieHeader::ImagePositionPatientOrdering()
259 // a Dicom 'Serie' may contain scout views
260 // and images may have differents directions.
261 // -> More than one may have the same 'pos'
262 // Sorting has then NO meaning !
263 Thx to Eduardo Davila for reporting bug.
265 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
267 test. Now it's on image content and not on the resulting visualisation...
268 might solve the problem on linux when using the OpenGL drivers
270 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
271 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
272 DicomDirSerie, DicomDirImage
273 Dict, DictSet classes :
274 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
275 -remove InitTraversal method.
276 * UPD Test programs + Example programs
278 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
279 * remove useless and never updated keyword \ingroup
280 * Solve pb when structure (list, map, ...) is empty.
281 Thx to Benoit for reporting bug
283 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
284 * Taking into account of 'Transfer Syntax' value
285 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
288 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
289 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
290 is no memory access violation
291 * gdcmPython/demo : add python demos using VTK
293 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
294 * FIX 'Dictionnary' is now spelt 'Dictionary'
295 'wether' is now spelt 'whether'
296 'archieve' is now spelt 'archive' ;-)
298 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
299 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
300 related methods, in order not to expose internal mechanisms
303 * REM methods that exposed internal mechanisms :
304 DicomDir::GetDicomDirPatients()
305 DicomDirPatient::GetDicomDirStudies()
306 DicomDirStudy::GetDicomDirSeries()
307 DicomDirSerie::GetDicomDirImages()
308 * UPD Test programs :
312 * UPD Example program
314 * ADD DictSet methods
318 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Removed the Print/indent/default parameter mess. There is absolutely no
320 reason to have to methods, moreover with the second taking the ostream as
321 *SECOND* parameter. This was clearly a bad hack to get things compile.
323 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
324 * Complete rewrite of the GetMacAddress code. Now the code is *much*
325 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
326 Unfortunately the main code does not work on SunOS, thus provide a specific
327 code for this platform only (and Win32 of course). Since this seems to be
328 working, change CreateUniqueUID to use GetMACAddress instead of the
329 problematic GctestetIPAddress
331 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
332 * Unfortunately to be able to test gdcmDirList I had to break the API
333 a little. Now the class is not a std::list anymore but has a member
334 std::vector (more ITK compatible). Allow unit testing on Win32 and
337 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
338 * Update SerieHeader to take into account a Serie Instance UID to properly
341 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
342 * ENH - Comment out Mathieu's (dangerous) Super Hack
343 for dealing with BIGENDIAN processors
344 - Move equivalent stuff to BinEntry::WriteContent
345 When necessary, 16 Bits Pixels are swapped in a small buffer
346 and then written. This avoid allocating a huge buffer, in
347 PixelWriteConvertor, and avoid modifying the Pixel Area.
349 Probabely, the same operation will have to be done when we want
350 to write image with Big Endian Transfert Syntax,
351 and we are working on Little Endian Processor
353 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
354 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
356 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
357 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
358 all the dict content.
359 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
361 * Test/TestDict.cxx : add a new test for the dict classes
363 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
364 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
365 file. Debug is yanked if compiled with NDEBUG
367 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
368 * src/gdcmDictSet.h : set the default output to the os variable
369 * src/gdcmDictEntry.[h|cxx] : add the Print method
370 * gdcmPython/demo/ : add a new test
372 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
373 * merging of Test/PrintDicomDir and Test/TestDicomDir
374 * removal of now redundant Test/PrintDicomDir
375 * enhancement of Example/PrintDicomDir
377 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
378 * Now, python test might work on systems
379 * Add the PrintDicomDir test
381 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
382 * FIX : First entry following group 0002 was lost for
383 Explicit Big Endian Transfer Syntax files
384 (group and elem not swaped)
386 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
387 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
388 Big Endian Transfer Syntax supposed the group following 0002
389 begins always by element 0000 (element 0000 is *optional*)
390 To avoid further troubles, let's be pessimistic, and use
391 Document::HandleOutOfGroup0002() method
392 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
393 (related pb not yet solved)
395 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
396 * Bug fix for the python part use
397 * Now, PrintHeader.py pass... but outside the ctest use. shit !
399 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
402 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
403 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
404 a string and should ask the global TS dict what are the propreties of
407 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
408 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
409 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
410 to swap the Swap Code, at parsing time, when we come out of group 0002
411 and Transfer Syntax is Big Endian
412 We should be able to read now 'true DICOM" Big Endian coded images
413 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
414 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
416 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
417 * Hopefully fix the bug on MacOSX and static global initialization.
418 This is the only -minor- patch I found that both please MacOSX and VS6.
419 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
420 but this would require a lot of change. Another approach would be that Global
421 create those string and GDCM_UNFOUND becomes a pointer to a string (which
422 gdcm::Global would destroy at exit).
424 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
425 * Fix bug on MacOSX with static initialization in a multy threaded
426 environment. static const string in a header file used to be ill
427 initialized provoquing the freeze of any tests. patch should solve this
430 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
431 * According to Benoit's suggestion, and without any objection from anybody
432 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
433 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
434 - method gdcmDicomDirObject::GetEntry() renamed as
435 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
437 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
438 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
439 you debug/warning message just as c++ streams which make them very convinient
440 to use. Once this is stabilize I will change the ostringstrem to be
441 redirected to a file (ofstream).
442 * Properly support C99 extension: __FUNCTION__ which allow us to display
443 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
445 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
446 * Removal of useless and dangerous methods :
447 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
448 GetDocEntryByName, GetEntryByName, GetDictEntryByName
449 * Removal of usless methods :
450 Dict::PrintByName, Dict::GetDictEntryByName
451 * Commenting out of probabely useless methods :
452 Dict::GetDictEntryNames()
453 Dict::GetDictEntryNamesByCategory()
454 DictSet::GetPubDictEntryNames()
455 DictSet::GetPubDictEntryNamesByCategory()
456 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
457 * ENH : Use dicomTS.dic as described in 2004 version
458 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
459 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
460 Add Accessors on VM (Value Multiplicity), and VM related methods
461 * ADD : Add a list of 'Dicom Attribute types', as found in
462 http://medical.nema.org/dicom/2004/04_15PU.PDF
464 * ADD : Add dicomGroupNameAbbreviations.dic
465 should be used to write a method to replace the former
466 Dict::GetDictEntryNamesByCategory()
468 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
469 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
470 to read in the file... and only it ! Length is the efective length of the
471 data in the DocEntry structure
473 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
474 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
475 And now use a static function call instead, with a global variable. i
476 This is much closer to the VTK approach. Hopefully should be bulletproof
477 and easier to use...hopefully
479 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
482 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
485 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
486 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
487 ValEntry, BinEntry, SeqEntry creation or replace
489 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
490 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
491 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
493 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
494 when specifying the VR
495 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
496 * src/gdcmDocEntry.cxx : amelioration of print
498 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
499 * ADD : Add the method Util::IsCurrentProcessorBigEndian
500 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
501 * ADD Method Document::ComputeGroupLength
502 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
503 in order to allow further VR modification by user
504 * REM : removal of once-called method File::WriteBase
505 integration of its code in formerly one-line method File::Write
507 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
508 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
509 replace the different values "??", "Unkn", "Unknown".
510 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
511 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
512 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
513 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
515 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
518 * Set the gdcm::Base class to some Printable classes
520 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * src/gdcmFile.[h|cxx] : add the Print method
522 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
523 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
524 * src/gdcmDocument.h : remove the PrintLevel informations
525 * Example/PrintFile.cxx : use the new gdcm::File::Print
527 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
529 problems when compiling with the python wrapping
531 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
532 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
533 writting in ImplicitVR
535 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
536 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
537 JPEG decompression, especially when dicom frames are split into several
538 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
539 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
541 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmHeader.cxx : change the initialisation of default header.
543 Now, this header is readable by gdm, e-film, DicomWorks
545 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
546 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
547 Rename Decompressed to Raw
548 * Use the API changes in gdcm::File.
549 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
552 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
554 each added entry in the header. Replace the 'Planes' field by the 'Number
557 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
559 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
561 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
563 At this time, this image isn't readable by e-film... waiting JPR help to
566 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
568 DocEntry. Now use methods of the Document !
570 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * Test/ShowDicomSeq.cxx : bug fix
573 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
574 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
575 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
576 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
577 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
579 * Test/TestCopyRescaleDicom.cxx : remove unused variable
580 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
581 containing found sequences
583 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
584 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
586 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
587 Some fields in BinEntry must be copied to not seg fault when making the :
588 gdcm::File *copy = new gdcm::File( copyH );
589 and tests are now made on good variables
591 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
592 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
593 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
595 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
596 * Add vtkGdcmWriter example and test
598 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
599 * Test/TestUtil.cxx : reformat the source code
600 * vtk/vtkGdcmReader.cxx : remove and change prints
601 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
603 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
604 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
606 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
608 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
610 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
611 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
612 by an eof to prevent all bad read of the file... and in this case, the
615 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * Example/Volume2Dicom.cxx : comment unused variables
617 * Test/PrintDicomDir.cxx : comment unused variables
618 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
619 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
620 method that is redondant with AddEntry.
621 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
624 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
625 * Bug fix due my last commit (compilation under Windows).
626 * Example/Volume2Dicom : bug fix in the file and reformatting source code
627 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
629 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
631 - Remove printf / sprintf
632 - include iostream AFTER gdcm so we don't get warnings
633 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
635 - Also remove tons of include from header files, hopefully this should
636 speeup the compilation time, since it was becoming a dog slow.
637 - Remove gdcm.h as it include way too many files and slow down compilation
638 (plus it is not up to date)
639 - remove 'using namespace std' this is BAD !
641 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
642 * Remove memory leaks on the DicomDir
643 * Remove some useless data in DicomDirObject
644 * Add usefull methods in SQItem, to be complient withe the ElementSet
646 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
649 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
651 future, with convertion)
652 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
653 and ImageDataSize values. Remove the method to get the PixelReadConverter
654 from the output of the class
656 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
657 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
659 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
660 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
661 and vtkErrorMacro use.
662 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
664 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
667 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
668 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
669 The string leaves only in the fonction. So when we make a .c_str(), we
670 get the pointeur on the first element, element that will be destroyed
671 immediately after thee instruction.
672 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
673 file has been opened : the test must be made on the content of the
674 pointer and not directly on the pointer !
677 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
679 the python part recompiles
681 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
682 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
683 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
684 X session is killed (for my computer... it seems to not be identic on
687 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
688 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
689 avoid problems (otherwise, the difference test between the visible image
690 and the reference is incorrect. If the reference is greater than the
691 screen resolution, it's produce errors).
692 Can be used for only one image. Can be used with a visible flag.
693 * vtk/vtkGdcmReader.cxx : remove commented codes.
694 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
695 under windows at compilation
696 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
698 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
700 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
702 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
703 tests on the image size X, Y, Z
705 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
707 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
708 between the class name and the file name
710 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
711 * src/ : fix compilation warnings for the Write method (2 different
712 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
713 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
714 variable... create a static method in gdcm::Document to access to
715 this variable content.
717 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
718 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
719 file, to be accessed by other files (like gdcmFile). Remove commented
720 code. Move the change of the header to the gdcmFile, using the
722 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
723 To be sure of that (and simplify calls), the Write of the header now
724 gets a file name and not a file pointer (std::ifstream).
725 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
726 DocEntryArchive. Remove all open of the written file
728 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
729 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
731 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
733 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
735 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
736 some corresponding methods. Write correctly the file and check before
738 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
739 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
740 is now on RGB data (as before my last commit
741 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
743 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
744 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
745 Add a print information of the type of the entry
746 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
747 It was in the gdcmFile, and all write have been regrouped
748 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
749 Write correctly all dicom files (in decompressed mode only at this time)
750 * Test/ : test on files are now made using Raw data and not color data if
752 * Example/PrintFile.cxx : add more printings
754 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
755 * Amelioration of code, remove some code copy. For the loading of
756 BinEntry (in gdcmDocument), add the test to verify if the file is already
759 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
760 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
761 remove a DocEntry in the header (push an empty DocEntry)
762 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
763 lines. Bug fix in the initialization of the PixelConvert and the
765 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
766 use in TestCopyDicom (now this test can run under windows... but fails)
767 * Test/TestCopyDicom.cxx : amelioration of the test :
768 - test the pixels written
769 - add test points to quickly find where is the error
770 - can set a file name input and output in arguments
771 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
772 amelioration of the test output
774 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
775 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
776 all replaced DocEntry's
777 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
778 Now, each needed DocEntry to modify is duplicated, modified and inserted
779 to the header using DocEntryArchive. Thus, after save, we can restore the
780 header initial state.
782 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
783 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
785 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
786 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
787 correct to copy it. The DictEntry is specified at the DocEntry creation,
788 then, it musn't change in the time.
789 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
790 header correctly. At this time, the change is only made for the first
791 level of the Document. In the future, it might consider sequences.
792 The change is made by replacing a DocEntry by an other that is created
793 outside the class. The old value is kept. When we restore the header
794 status, the added DocEntry is deleted and replaced by the old value.
795 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
796 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
797 set the write type to explicit VR, implicit VR or ACR. Add methods to set
798 the write mode to native, decompressed or RGB (but not used at this time)
800 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
801 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
802 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
804 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
805 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
806 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
808 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
809 set because already copied when copying the BinEntry's of the header
810 * Test/TestAllReadCompareDicom.cxx : remove warnings
812 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
813 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
814 Two problems appear when doing it :
815 - with the gdcmFile : when the GetImageData method is called, the pixels
816 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
817 data (pixels). And each structure destruct the data when it's
818 destructed. So we have two destructions for the same data. To solve it,
819 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
820 data or not. If it doesn't own data, then they will not destroyed by
822 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
823 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
824 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
825 create a double destruction of the same DocEntry's. So, to solve it,
826 the TagHT is simply cleared and the DicomDir* elements are destroyed.
827 * TODO : add an entry concerning memory leaks in the DicomDir
829 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
830 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
831 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
834 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
835 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
836 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
837 after it have been deleted
839 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
840 * FIX: src/* fix the doxygen warnings.
841 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
842 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
843 was erroneously defined with a size of 15 instead of 16. [many thanks
844 to Jean Michel Rouet for pointing out this bug].
846 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
847 1. Finish merging JMR patch for writting DICOM from scratch
848 2. Fix -hopefully- bug with MONOCHROME and space vs null character
849 3. Use const ref when possible
850 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
851 5. A few more comments
852 6. CreateUniqueUID can now be called without parameter"
854 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
855 * ENH: Slightly bigger patch:
856 1. Getting toward full integration of JMR patch for writting dicom from scratch
857 2. Update Test to test part of this patch: CreateUniqueUID
858 3. File was not close properly in gdcmDict
859 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
860 5. Use of const ref instead of copy (speed issue)
861 6. Remove temporary (duplicate) string in TranslateToKey
862 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
863 8. Do not repeat virtual in subclasses
864 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
866 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
867 * Apply first patch toward better string comparison when dealing with broken
868 DICOM files. Essentially the string could be padded with a space instead
869 of a null character as defined by standard
871 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
873 because never used... and in the same time, that's remove some memory leaks
875 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
876 * src/gdcmFile.cxx : now delete the PixelConvert instance.
877 * In examples and tests : change the type of image data variables from void*
878 to uint8_t*. Remmove all delete on image data variables
880 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
881 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
882 Verify the file pointer value before open the file, and if it's not null,
883 a verbose message is generated.
884 Close correctly the file when the file isn't considered dicom-like. The
885 correctly close is a call to CloseFile.
886 When closing the file pointer, test if its not null to close the file.
887 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
888 file. For an uncompressed image, the copied data correspond in the least
889 case to the image size (calculated) or the image size specified in the
890 header. A verbose is generated if these two size mismatch
892 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
894 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
895 break under windows (with msvc6 compilation).
897 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
898 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
899 compiling with MSVC6)
901 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
902 * Bugs fix for the Windows build with VC6
903 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
904 needed (only for projects required VTK). If the VTK is included in all
905 projects, there is conflicts with the jpeg lib of vtk when compiling the
906 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
907 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
908 when compiling the gdcm_wrap.cxx file (created by the compilation of the
910 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
911 (like it's already made for the cout use). Otherwise, conflict with the
914 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
917 - comments on the DicomDir::Method related usage added.
918 - now that we use the namespace gdcm, a lot of internal classes do
919 NOT need to be wrapped anymore.
920 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
921 DicomDir::Method) new example added.
923 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
924 * Improve string manipulation. I now inforce the notion of 'DicomString'
925 A DicomString can contain as many \0 as they want
926 and it is *always* of even length.
927 We only support odd length for very rare case.
928 And in the near future this should be removed.
930 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
931 * /binary_write/ gdcm source. Now even on big endian we are writting
932 little endian. This should -heopfully- fix some tests
934 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
935 * Now the dictionary is compiled into gdcm lib. This is a default
936 behavior, thus any dic file specified is picked before failback to
937 the one comiled into lib
939 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
940 * Change internals for gdcmDict. Don't use any 'new' any more.
941 This should definitely solve any leak problem, and we should be
942 as fast as before, as long as don't modify too much the dictionary.
944 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
945 * STYLE: ivars should start with a capital letter.
946 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
947 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
949 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
951 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
952 new 2004 dictionaries added (thanks to JPR).
953 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
954 * CLEANUP_ROUND (15) for gdcmPixelConvert
955 - RLEFrame::NumberFragments is now of type unsigned int
956 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
957 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
960 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
961 * Initial work in gathering all transfer syntax accessors. clearly
962 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
963 ivars, but only one transfersyntax (class) ivar with equivalent method on
966 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
968 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
969 discussed (plus I didn't like having a 2000 lines patch not commited)
971 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
973 * CLEANUP_ROUND (14) for gdcmPixelConvert
974 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
975 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
976 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
978 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
979 anymore and hence avoids storing a copy of PixelConvert::Decompressed
980 into File::Pixel_Data.
982 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
983 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
984 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
985 * CLEANUP_ROUND (13) for gdcmPixelConvert
986 Substituted File::ParsePixelData() with PixelConvert::Print() new
988 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
989 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
990 method to those classes.
991 - src/gdcmFile.[cxx|h]:
992 -- Added a ::Print() method.
993 -- PixelConverter is now a reference instead of a member.
994 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
995 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
997 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
998 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
999 collaboration diagram and inheritance diagram should be generated with
1001 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1002 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1003 pointlessly wrapped (see
1004 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1005 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1006 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1007 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1008 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1009 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1010 -- File::Initialise: PixelConverter setup moved away to
1011 PixelConverter::GrabInformationsFromHeader()
1012 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1013 interpretation moved away to PixelConverter::BuildRGBImage()
1015 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1017 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1019 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1020 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1021 displayed on Win32 when a brutal abort() occurs (because of uncatched
1022 exception). See TODO new entry of this commit for more on this.
1023 * TODO added new entry.
1024 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1025 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1026 - HandleColor is no longer called from gdcmFile.cxx
1027 - gdcmPixelConvert.cxx clean up on method arguments and internal
1028 variable names for semantical coherence.
1030 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1031 * Finished lossless transition, not only do we now read all lossless jpeg
1032 images, without the need of the Cornwell lib, but we do read them properly now
1033 * To reduce code (well to avoid code duplication), I defined a common place
1034 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1035 redefine symbols. This is not perfect but this the best solution I found for a
1036 compilation time jpeg option.
1038 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * Update jpeg ijg lib to support lossless jpeg implementation
1040 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1042 * Also added a special copyright for dcmtk since we use their bugfixes.
1045 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1046 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1047 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1048 matters, as stated in warning note at beginning of %include section).
1049 * src/gdcmDicomDir*.[cxx|h]: coding style
1050 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1051 * src/gdcmJpeg8.cxx: doxygen fix.
1052 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1053 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1054 from File:: to PixelConvert::.
1056 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1057 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1058 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1059 - more code moved away from File:: to PixelConvert::
1060 - fat setup of PixelConverter set in place in File::Initialise.
1062 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1063 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1064 namespace at the file system level. So now you should convert your examples
1066 gdcmHeader -> gdcm::Header
1067 It would be nice if people keep in mind to no open the namespace, since it
1068 allows compilation on broken plateform which were defining common symbol in
1069 the standart namespace (like LP, Unknown ...)
1071 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1073 The JPEG fragments are now parsed at the same stage than the RLE
1074 information. All code related to JPEG is now in gdcmPixelConvert:
1075 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1076 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1077 export a gdcmFile:: method. Those are simply global functions
1078 (for the time being this is better than having them attach to
1079 either gdcmFile:: or gdcmPixelConvert::).
1080 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1081 and stores the result in a gdcmJPEGFragmentsInfo.
1082 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1083 code (among other stuff) moved away from gdcmFile:; to
1086 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1087 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1088 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1089 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1090 clean up of RLE related code.
1091 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1092 - src/gdcmRLE.cxx removed
1093 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1094 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1095 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1096 * CLEANUP_ROUND (9) for gdcmPixelConvert
1097 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1098 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1099 away from gdcmFile:: to gdcmPixelConvert::.
1101 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1103 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1104 This is because Parse7Fe0 used to parse the pixels to compute the
1105 length. This task was passed over to FindDocEntryLengthOB() a long
1106 time ago, EXCEPT I had forgotten the OW case...
1107 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1108 we just recylce the code for parsing RLE fragments and computing
1110 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1111 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1112 with the retired Parse7Fe0().
1113 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1114 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1116 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1118 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1119 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1120 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1121 * CLEANUP_ROUND (4) for gdcmPixelConvert
1122 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1123 to return an unused length.
1125 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1126 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1127 this should be cleanner from the plane view. The iostream are erally a pain
1128 to use to do simple stuff.
1130 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1131 * Redo the compilation of the ijg jpeg library. Now only one source is
1132 necesseray. No need to rename file by hand what so ever. CMake handle the
1133 copying of the file within different directory, configure header file to
1134 modify some symbol. The only addition made to ijg wasd a mangle table so
1135 that symbol are different whether we are within 8bits or 12bits.
1137 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1138 * Added documentation of vtkgdcmReader on Website:
1139 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1140 with it's binary name).
1141 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1142 the Website to be more complete.
1143 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1144 doxygenated documentation.
1145 - Doc/DoxyVtkGdcmReaderExamples.txt added
1146 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1147 DoxyVtkGdmReaderExamples.html )
1148 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1149 * CLEANUP_ROUND (3) for gdcmPixelConvert
1150 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1152 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * CLEANUP_ROUND (2) for gdcmPixelConvert
1154 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1156 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * CLEANUP_ROUND for gdcmPixelConvert:
1158 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1159 - src/gdcmPixelStuff[h|cxx] removed
1160 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1161 - src/CMakeLists.txt changed accordingly
1162 * GDCMHOME clean up:
1163 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1164 gdcmVersion.py moved to newly created ATTIC related
1165 gdcmPython/SetupOldies/ directory.
1166 * Autotools clean up:
1167 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1168 - autogen.sh configure.in acinclude.m4 python.m4 removed
1170 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1171 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1172 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1173 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1175 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1176 * TODO updated with Mathieu suggestions. I proposed a template for
1177 describing TODO entries and used it for new entries.
1178 * Added Doc/Website/CodingStyle.html, Developpers.html,
1179 DeveloppersPython.html, GdcmDataCvs.html and
1180 DownloadVersion0_1.html, DownloadVersion0_3.html.
1181 * Some Doc/*.txt Doxygen files (which do not really concern the
1182 documentation itself, but the website) moved to html and
1183 placed in directory Doc/Website:
1184 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1185 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1186 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1187 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1188 * CMakeLists.txt changed accordingly.
1189 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1190 DeveloppersPython.html
1191 * INSTALL nows refers to Doc/Website/Installation.html
1193 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1194 * Added Doc/Website directory, that contains a first raw version
1197 2004-09-23 Jean-Pierre Roux
1198 * FIX In order not to be poluted any longer by casting problems,
1199 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1200 we can now delete[] it safely
1201 * VoidArea is now called BinArea (less confusing name),
1202 and all the methods called ...VoidArea... are now ... BinArea...
1203 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1205 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1206 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1207 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1208 up to the destructor of gdcmElementSet to clean up TagHt and it's
1211 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1213 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1215 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * ENH: added some utility method that builds a flat dictionary
1217 holding all the Dicom entries contained in the recursive structure
1218 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1219 an example of usage.
1220 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1221 BuildFlatHashTable() that build a flat dictionary.
1222 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1223 gdcmDocument is now a friend of gdcmElementSet.
1224 - src/gdcmElementSet.cxx: clean up.
1225 - Example/FlatHashTablePrint.cxx added.
1226 - Example/CmakeLists.txt changed accordingly
1228 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1229 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1230 moved away from gdcmDocEntrySet (since this class is an abstract class
1231 acting like an interface). SQDepthLevel and BaseTagKey are now
1233 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1234 and associated accessors. Doxygenation of the class.
1235 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1237 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1238 Use SQDepthLevel accessor instead. ::Print() adapted.
1239 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1240 - src/gdcmDocument.cxx changed accordingly.
1242 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1244 - The following is the doxygen comment of the typedef declaration
1245 of gdcmTagKey in src/gdcmCommon.h:
1246 gdcmTagKey is made to old an "universal" (as in URL, Universal
1247 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1248 A dicom tag always has a group and an element, but a set of tags
1249 embeded in various (optionally nested) sequences and sharing
1250 the same group and element all share the same (group, element)
1251 "identifier". Hence the (group, element) cannot be used as an
1252 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1253 In order to construct a proper tag identifier (i.e. a key) we
1254 consider the following definition of a TagKey:
1255 - let Group, Element be the string representation of the
1256 group and element dicom tag members,
1257 - let ItemNumber be the string representation of the integer
1258 index of the considered item number of a sequence,
1259 Let the key of a tag embeded in a sequence, noted SeqTag, be
1261 /ItemNumber#Group|Element
1262 where "/", "#" and "|" are characters acting as separators.
1263 Then the general form of a gdcmTagKey is given by:
1264 Group|Element<SeqTag>
1265 where <SeqTag> means NO or many instances of SeqTag.
1266 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1269 but the gdcmTagKey of a tag "embeded" is the first item of
1270 a sequence, itself nested in the third item of a sequence is the
1272 0004|1220/2#0008|0082/0#0008|0090
1273 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1274 order to hold the new sequence compatible key. Previously, the
1275 GetKey() method would look in the underlying gdcmDictEntry.
1276 - src/gdcmDocEntry.cxx:
1277 -- constructor now copies the underlying DictEntry key, in the local
1279 -- ::Print: displays the member Key, instead of the (group, element).
1280 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1281 - src/gdcmDocEntrySet.h:xi
1282 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1283 -- now has a new BaseTagKey member.
1285 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1286 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1288 This poses the problem with the semantics of the following lines
1289 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1290 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1291 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1292 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1293 to the long FIXME note for what the problem is. Nevertheless in
1294 order to get things working the dicom dictionary was altered !
1295 Please fix things urgently...
1296 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1297 information), see above note on moving the member VoidArea. Nevertheless
1298 the following entries previously correctly set as US are now inproperly
1300 0028 1201 OW IMG Red Palette Color Lookup Table Data
1301 0028 1202 OW IMG Green Palette Color Lookup Table Data
1302 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1303 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1304 of gdcmDocEntry moved to gdcmSeqEntry.
1305 * src/gdcmSeqEntry.cxx: STYLE.
1307 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1310 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * gdcmPython/testSuite.py: all the test suite in python is now moved
1312 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1313 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1314 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1316 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1317 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1318 to avoid inclusion recursion until STL is reached.
1319 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1320 mecanism. errno.h is not included in gdcm anymore.
1321 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1322 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1324 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1325 gdcmData/TestAllEntryVerifyReference.txt
1326 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1327 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1328 exception_on_error parameter.
1329 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1330 - vtk/vtkGdcmReader.cxx changed accordingly,
1331 - Example/*.cxx and Test/*.cxx changed accordingly.
1333 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1335 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1336 enable_sequences removed from gdcmHeader constructor and dependencies.
1337 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1338 * gdcmPython/demo/PrintHeader.py: dummy fix.
1339 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1340 skip_shadow removed from gdcmHeader constructor and dependencies.
1341 * Example/*.cxx and Test/*.cxx changed accordingly.
1343 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1345 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1347 2004-07-21 Jean-Pierre Roux
1348 * FIX Now, Parsing and Printing a DICOMDIR do work!
1349 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1351 2004-07-20 Jean-Pierre Roux
1352 * FIX Some brain damaged headers have Zero-Lenght fields
1353 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1355 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1356 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1357 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1358 variable (instance of gdcmDebug) by a definition macro, and the instance
1359 is now in static in the gdcmDebug class
1360 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1361 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1363 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1364 * WARNING: ctest now depends more tightly on gdcmData. You should
1365 check out gdcmData properly for things to run smoothly...
1366 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1367 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1368 we need the pixels not be loaded in order to use the ValEntry
1369 that displays position and size).
1370 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1371 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1372 be deprecated. If you have any doubts about the advantages of a
1373 modern scripting language (read Python) versus grass root C++ (i.e.
1374 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1375 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1376 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1377 Anyhow, consider documenting the gdcmData images in
1378 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1380 * Test/CMakeLists.txt:
1381 - now uses TestAllEntryVerify.cxx
1382 - specific comments on oldACR00001.ima (now renamed in gdcmData
1383 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1384 gdcmData/TestAllEntryVerifyReference.txt
1387 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1388 * src/*.[h|cxx] : typedef clean up
1389 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1390 - TagKey renamed to gdcmTagKey (for external usage)
1391 - VRKey renamed to gdcmVRKey (for external usage)
1392 - removal of typedef duplication.
1393 - Removed all unecessary inline keyword from class inline definitions.
1394 - Some method|function(void) declarations replaced with method|function().
1395 * src/jpeg/libijg12/jdhuff12.c:
1396 - printf polluting ctest removed.
1397 - TAB removal for comminting
1399 - TestAllReadCompareDicom.cxx: added a test that compares all the
1400 images in gdcmDataImages.h with corresponding images in
1401 gdcmData/BaselineDicom/. When baseline images are not present
1402 this test creates them.
1403 Note: we need to validate each reference image, but before that
1404 I'd like to rename them with a more explicit name...
1405 - CMakeLists.txt: changed accordingly.
1406 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1407 including each header needed).
1409 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1410 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1411 test suite to the Example directory. Are concerned:
1416 - TestWriteSimple.cxx
1417 * Test/CMakeLists.txt: added some comments on reasons for black listing
1418 image gdcmData/oldACR00001.ima
1420 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * Test/CmakeList.txt: removed the following from black list (to be coherent
1422 with removal from gdcmData):
1423 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1424 - gdcm-MR-PHILIPS-16.dcm
1426 Added the following because after last cvs update, they cause
1427 ctest -R TestReadWriteReadCompare
1429 - gdcm-MR-SIEMENS-16-1.acr
1431 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1432 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1433 new comments in this file) we temporarily (sigh) move to a weaker
1435 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1436 we don't need to black list the following images anymore:
1437 - 8BitsUncompressedColor.dcm
1439 - US-PAL-8-10x-echo.dcm
1440 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1441 fixes and the beautified code ;-)
1442 This fixes the bug introduced in version 1.42 (when beautifying)
1443 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1444 Note: ctest was blind to this bug (this means we need to still
1445 improve the test suite). The bug could be detected by using
1446 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1448 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1449 and by displaying the (garbage) produced file temp.XDCM...
1451 2004-06-29 Jean-Pierre Roux
1452 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1453 - replace by uggly but working old code :-(
1454 A lot of things should be OK again.
1455 It's really urgent to have a test suite that *tests*,
1456 to prevent Frog's beautifying sessions to break all the stuff
1457 (twice, withing a fortnigh ...)
1459 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1460 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1461 redundancy) to added Test/TestReadWriteReadCompare.cxx
1462 * Test/CmakeList.txt: because the compare test of
1463 Test/TestReadWriteReadCompare.cxx fails, the following images are
1464 black listed: - 8BitsUncompressedColor.dcm
1466 - US-PAL-8-10x-echo.dcm
1467 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1468 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1469 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1470 and ad-hoc kludge. This kludge is now removed, and on encountering
1471 such an image (OB field brain damaged) we set errno. Then in
1472 ::FindDocLength() we "fix" the length as being ALL what remains
1473 in the file (until EOF). We then proceed, hoping for the best...
1474 This fixes a SegFault in ShowDicom when trying to write such an
1476 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1477 (because TestWriteRead breaks on it, after a non conformal commit?).
1478 ctest now runs properly, except for MakeDicomDir (which was always
1479 broken) and the Python related stuff (still not fixed).
1481 2004-06-24 Jean-Pierre Roux
1482 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1483 FIX : Test/TestReadWrite now iterates on all the file names
1484 (instead of infinite loop)
1485 ENH : Test/TestWriteRead now iterates on all the file names
1487 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1488 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1490 2004-06-24 Jean-Pierre Roux
1491 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1492 when SamplesPerPixel =3
1493 - now Write is no longer confused by
1494 'BitsAllocated = 12" and 'BitsStored=12"
1495 - "UN" value representation Elements are now written correctly
1496 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1497 ENH : - now gdcmHeader has its own Write methods
1498 (in order to split the job that has not to be done
1501 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1502 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1503 loop on the same image until memory went out.
1504 Note: this means we still have gobs of memory loss in PrintDocument
1505 * src/gdcmDocument.cxx: fixes problem on parsing on file
1506 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1508 2004-06-24 Jean-Pierre Roux
1509 FIX : Write - All the Sequences and Sequence Item are now written
1510 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1511 is added a the end, when necessary.
1512 - A lot of brain-damaged images, that were read correctly are
1513 now written correctly
1514 - length compatible BinEntry are now loaded correctly
1515 (even for odd groups)
1516 Note : only Explicit Value Representation was checked.
1517 (question : is implicit VR really necessary for gdcm ?)
1519 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * DEVELOPPER: added a proposition of coding style.
1521 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1524 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1525 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1526 Use the gdcmDocEntry::Print() and Write() instead.
1527 * src/gdcmDocument.cxx: bug fix.
1529 2004-06-22 Jean-Pierre Roux
1530 FIX : gdcmDocument.cxx
1531 - Now we do recognize the JpegLossLess format (there was a misstyping in
1532 code 'beautyfication' :-(
1533 - Now we automaticaticaly load the Luts, if any
1535 2004-06-22 Jean-Pierre Roux
1536 In order : to write Sequences, whatever their imbrication level,
1537 : to allow user to create his own Sequences
1538 a lot of modif where necessary (adding, moving, or virtualising methods)
1540 WARNING : save your own sources *before* cvs up !
1543 ADD virtual void Write(FILE *fp, FileType filetype);
1546 ADD virtual void Write(FILE *fp, FileType filetype);
1547 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1550 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1551 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1552 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1553 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1554 ADD std::string GetEntryByName(TagName name);
1555 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1557 std::string vr = "unkn",
1558 std::string fourth = "unkn",
1559 std::string name = "unkn");
1560 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1561 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1562 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1563 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1564 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1565 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1566 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1567 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1570 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1571 ADD virtual std::string GetEntryByName (TagName tagName);
1572 ADD virtual std::string GetEntryVRByName (TagName tagName);
1573 REM virtual bool Write(FILE *, FileType);
1574 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1575 FILE *_fp, FileType type);
1576 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1577 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1578 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1579 REM virtual std::string GetEntryByName (std::string tagName);
1580 REM virtual std::string GetEntryVRByName (std::string tagName);
1581 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1582 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1583 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1585 std::string vr = "unkn",
1586 std::string fourth = "unkn",
1587 std::string name = "unkn");
1588 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1589 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1590 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1591 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1594 ADD virtual void Write(FILE *fp, FileType filetype);
1597 ADD virtual void Write(FILE *fp,FileType filetype);
1600 ADD virtual void Write(FILE *fp, FileType filetype);
1601 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1602 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1603 REM std::string GetEntryByName(TagName name);
1606 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1608 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1610 The default constructor invoked by the line
1611 gdcmHeader *f1 = new gdcmHeader( header );
1612 was gdcmHeader::gdcmHeader(bool) instead of the expected
1613 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1614 Hence the parsing wasn't executed... See also below.
1615 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1616 as explicit constructor didn't do the trick to fix the above problem.
1617 Could anyone explain why ?
1618 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1619 properly calls gdcmValEntry::Print() (that was weed out from
1620 code related to gdcmBinEntry).
1622 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * In order to fix memory leaks:
1624 - Test/TestWriteSimple.cxx: added cleaning of free store through
1626 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1627 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1628 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1629 (through the call to ::AddDicomDirMeta()) or the destructor
1630 would crash when deleting uninitialized ::metaElems].
1631 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1632 - src/gdcmDocument.cxx:
1633 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1634 from dynamic stores.
1635 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1636 was causing memory leaks.
1637 - src/gdcmSQItem.cxx:
1638 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1639 cleanly handled with polymophism: sorry but my milage is low).
1640 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1641 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1642 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1643 This avoids SegFaulting.
1644 - src/gdcmSQItem.h: coding style.
1646 - Test/TestWriteSimple still severely sucks. The output image content
1647 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1648 damaged when displayed with vtkgdcmViewer.
1649 - on memory leaks: TestWriteSimple leaks really less (see entry
1650 of 2004-06-18 in Changelog file for the call to valgrind).
1651 - on segfaults: ctest now passes all the tests but one (no more
1653 * Erroneous leading white fix:
1654 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1655 white[s] (as opposed to from >> xxx, that removes it [them].
1656 - src/gdcmTS.cxx: ditto.
1657 - gdcmPython/testSuite.py: dirty related kludge removed.
1658 * src/*: remaining references to gdcmParser removed.
1659 * src/*[cxx|h]: added copy[way]left header.
1662 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * In order to fix writing of dicom files:
1664 - Test/TestWriteSimple.cxx: a simpler example of writing.
1665 - Test/CMakeLists.txt changed accordingly.
1666 - src/gdcmDocument.cxx:
1667 -- The destructor now recursilvely removes potential sequences.
1668 -- Bug fix in ::IsJPEG2000()
1669 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1670 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1672 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1673 to only declared) and build on top of
1674 ::GetDocEntryByNumber(guint16, guint16).
1675 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1676 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1677 for usage in destructor and treatement of promotion in
1678 ::ReplaceOrCreateByNumber().
1679 - src/gdcmSQItem.cxx: destructor should better handle his job.
1680 Test/TestWriteSimple now runs (or at least it DOES something).
1681 * We can now start hutting memory links. A good starting point is:
1682 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1683 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1684 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1686 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1687 * Valgrind note: after Mathieu Malaterre teached me how to read
1688 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1690 Using gcc, you can force the STL to use malloc and to free memory as
1691 soon as possible by globally disabling memory caching.
1692 With 3.2.2 and later, you should export the environment variable
1693 GLIBCPP_FORCE_NEW before running your program.
1694 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1695 simply vanish (it is still not clear to me, whether this means that
1696 STL std::string leaks or if valgrind believes it leaks...).
1697 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1698 running bin/gdcmTests makeDicomDir):
1699 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1700 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1702 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1703 SegFaulting (I drowned in DicomDir related code when trying to
1704 understand why the list is empty...).
1705 * src/gdcmDocument.h: first BSD license header try.
1706 * Doc/License.txt added.
1708 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1709 * src/gdcmDocument.[h|cxx]:
1710 - Clean up of the Transfer related predicates. They are now all based
1711 on new method isGivenTransferSyntax, that (should) handle properly
1712 the padding problem.
1713 - general clean up, simplification, and coding style.
1714 - Specific clean up of Parse7FE0() (umproperly named actually).
1715 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1717 2004-06-14 Jean-Pierre Roux
1719 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1720 - fix the display of SQItem ordinal number
1721 - add the GetSQItemByOrdinalNumber method
1722 - remove some useless never written private methods
1724 2004-06-14 Jean-Pierre Roux
1726 - adding a constructor taking a gdcmDocEntry as an input param
1727 - ReplaceOrCreateByNumber now returns :
1728 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1729 a gdcmValEntry * if a string value is passed as a param
1731 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1732 according to the param type (no longer sets a gdcmDocEntry)
1733 - GetValEntryByNumber, GetBinEntryByNumber added
1734 - NewValEntryByNumber and NewBinEntryByNumber added
1736 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1738 - GetSQItemNumber and SetSQItemNumber added, to provide
1739 a (relative) Item identier inside a given Sequence
1740 \warning : some pb remaining around this number
1742 - AddEntry now takes the Item Number as a param
1744 - adding a constructor taking a gdcmDocEntry as an input param
1746 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * Memory leak hunt with the following command:
1748 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1749 --show-reachable=yes gdcmTests PrintDocument
1750 It looks like many (all?) leaks are due to the STL (or a bad usage
1751 of the STL. The lines producing the leaks now have a comment with
1752 a "MEMORY LEAK" tag: you can retrieve them with
1753 grep "MEMORY LEAK" src/*
1754 Here are two typical examples which I can't help fixing:
1759 char * test = "babo";
1760 name = test; //// <--- valgrind detects 960 bytes lost in
1761 //// call to std::string::operator=(char const*)
1762 name.clear(); //// Doesn't help !
1770 std::cout << "Type a bunch of characters followed by RETURN: ";
1771 getline(std::cin, line); //// <--- valgrind dectects a loss
1772 //// of 1320 bytes in call to
1773 /// std::basic_istream<>& std::getline<>
1779 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * src/gdcmHeader.[cxx|h]:
1781 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1782 and related, moved away to gdcmDocument.
1783 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1784 the corresponding protected accessors of inherited class
1785 gdcmDocument, removed ! As a consequence gdcmFile had to be
1786 declared friend of class gdcmDocument (see below).
1787 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1788 - Clean up of undefined or unused methods.
1789 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1790 account the changes to gdcmHeader.h).
1791 * src/gdcmDocument.h:
1792 - gdcmFile is now a friend class (in order to take into account the
1793 changes to gdcmHeader.h).
1794 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1795 (see changes to gdcmHeader.h).
1796 - Accessors (reading on the form GetEntry*) are now public.
1797 - Clean up of undefined or unused methods.
1798 * src/gdcmDocument.cxx:
1799 - adaptation to changes to gdcmDocument.h
1800 - ::OpenFile now writes a verbose message when file cannot be opened.
1801 - some std::string properly set to VRKey
1802 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1803 references to gdcmDocument.
1804 * Test/TestFindTags.cxx: changed accordingly to above changes.
1805 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1806 cvs repository gdcmData.
1808 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1809 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1810 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1811 conflicts with gdcmValEntry::voidArea.
1812 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1813 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1814 Value representation between StringRepresentable and BinaryRepresentable.
1815 * src/gdcmDocument.cxx:
1816 - method ParseDES: proper indentation restored and usage of
1817 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1818 - method LoadDocEntry: the fingerprint left in the SetValue() of
1819 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1820 removed. Reverting to previous code segment with the proper
1821 dynamic_cast< gdcmValEntry* >.
1822 Note: this was (partially) breaking the python test suite
1823 (gdcmPython/testSuite.py) that made usage of the above
1824 fingerprint to check presence of "Pixel Data".
1825 * src/gdcmDocEntry.h: coding style.
1826 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1827 now taken into account.
1828 * gdcmPython/gdcm.i: adaptation to the new internal representation
1829 of gdcm (exit gdcmParser, hello gdcmDocument).
1830 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1832 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1833 anymore, but instead prints the loaded Python dictionary.
1834 * .... alas, the python testSuite is still broken.
1836 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1837 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1839 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1840 * src/gdcmUtil.h : export methods
1842 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1845 * Initial addition of automatic python testing
1846 * Initial addition of automatic image comparison
1848 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1849 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1850 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1852 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1853 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1854 * Test/ShowDicom.cxx : bug fix for msvc compilation
1855 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1857 2004-05-04 Jean-Pierre Roux
1858 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1859 new concepts (and new classes) :
1860 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1861 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1862 - Sequence Doc Entries (gdcmSeqEntries)
1863 a Sequence is composed of Items.
1864 Each item is a set of Doc Entries (this is recursive)
1865 The non uniqueness of the 'Dicom tag' is due to this recursivity
1866 (never taken into account)
1867 Our unability to add a new 'entry' in the header
1868 at the proper location (neither in the H-Table (map or multimap),
1869 nor in the Chained List is also due to this recursivity.
1870 Don't try, right now, to use/modify/compile these new sources :
1871 nothing is finished.
1872 We just commit all the stuff, 'as is', in order not to loose it.
1874 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1875 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1877 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1878 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1879 file prefix (SetFilePrefix)
1881 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * Add a new test: ShowDicom, for now this is just the c++ version of
1883 checkRead.sh, later it will be able to compare the image read against a
1885 * Replace the DEBUG on the stack with a global entry in cmake interface:
1886 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1888 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1889 * Add an example subdir, with a real example on how to read + write a
1892 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1893 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1894 * Doc/CMakeLists.txt: the main page is now properly differentiated
1895 between the developper and user version.
1896 * Doc/doxygen.config.in: dropped search related obsolete flags
1897 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1899 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * DEVELOPPER: added some helpfull comments for compile/test/install
1903 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1904 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1905 src directory, now generated in the build dir.
1906 2. Tests as mentionned smarter
1908 4. Add a new method in gdcmDict that return the PubDict by name
1909 this is interesting for 3rd party lib like ITK,
1910 where we could set the institution name / patient name...
1912 * ENH: 1. Now the test suite is working for real
1913 2. All binaries are now output in the gdcm-bin directory
1914 (this was not true before)
1916 2004-04-28 Jean-Pierre Roux
1917 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1918 SeQuence indented printing of Dicom Header.
1919 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1920 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1921 Computation of SQDepthLevel is now part of gdcmHeader constructor
1922 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1923 tree-like structure of a Dicom Header.
1924 * FIX Test code cleaning
1926 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * ENH: Adding automatic testing
1928 1. Need a DartConfig.cmake to submit to public
1929 2. Add a test driver gdcmTest.cxx
1930 3. gdcmTestMain, an helper for the main test driver gdcmTest
1931 4. Files in Test don't have a main anymore, this becomes interesting
1932 when we add more and more tests, thus dsw don't have to load
1934 * ENH: Adding a GDCM_DATA_ROOT for testing
1935 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1936 one file instead of seven + some small cleanup
1938 2004-04-22 Jean-Pierre Roux
1939 * ENH Minor changes to the Print() methods.
1940 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1941 Header printing. Example given with :
1942 > PrintHeader fileName 2 new
1943 (SQ based tree-like structure still to be done for the Header ...)
1945 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1947 1. I have added some unsigned where needed
1948 2. Some function parameter not used -> (void)
1949 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1950 4. g++ don't like character '\' in comment
1951 5. #define jpeg_create_decompress jCreaDecompress
1952 this really need to be fixed
1953 6. virtualize destructor of gdcmObject ... leakage
1954 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1955 this also really need to be fixed
1956 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1957 remove compression file
1958 (as we only do decompression, right ?)
1959 * ENH: Change malloc/calloc/free with c++ equivalent
1961 2004-04-21 Jean-Pierre Roux
1962 * FIX gdcmHeaderHelper::GetXSpacing
1963 when a single value is found (bug ?), xpacing is now
1964 defaulted to yspacing
1966 2004-04-19 Jean-Pierre Roux
1967 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1968 * ENH add parameters :
1969 bool exception_on_error = false,
1970 bool enable_sequences = false,
1971 bool ignore_shadow = false
1972 to the gdcmFile constructors to be full gdcmParser compliant
1973 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1974 to allow reading of PAPYRUS 3.0 files
1976 2004-04-06 Jean-Pierre Roux
1977 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1979 2004-04-02 Jean-Pierre Roux
1980 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1981 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1982 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1984 2004-03-30 Jean-Pierre Roux
1985 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1986 for ACR file, written out as DICOM files (hope so...)
1988 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1990 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1991 moved to base class gdcmParser and only the specialisation is kept
1993 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1994 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1995 already does the job.
1996 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1997 (to be consistent with gdcmParser::WriteEntries).
1999 2004-03-30 Benoit Regrain
2000 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2001 upate of the object's instance. It's passed to 2 in the unfavorable
2002 case : one in the ExecuteInformation, one in the ExecuteData
2004 2004-03-29 Jean-Pierre Roux
2005 * ENH : Check on file type to be written moved
2006 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2007 * FIX : gdcmObject::ResetBoundaries now stops properly
2008 when end-of-list is reached
2009 : gdcmVersion modified (as Benoit Regrain asked)
2011 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2012 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2013 * src/gdcmUtil.cxx: added forgotten iostream include.
2014 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2015 equivalent to ExplicitVR in existing code).
2017 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2018 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2019 now contains all the gdcmGlobal related code.
2020 * minor coding style and doxygenation changes.
2022 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2024 now contains all the Debug related code.
2025 * minor clean-up of includes in src/*.cxx
2026 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2027 CreateCleanString) removed.
2028 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2029 * Doc/DoxyMainPageUser.txt added.
2030 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2031 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2032 src/gdcmDirList.cxx)
2034 2004-03-24 Jean-Pierre Roux
2035 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2037 2004-03-23 Jean-Pierre Roux
2038 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2039 big endian made volumes
2040 * ENH Now gdcmParser constructor and destructor are protected to forbid
2041 end user to instanciate class gdcmParser
2042 (only gdcmHeader and gdcmDicomDir are meaningfull)
2044 2004-03-22 Benoit Regrain
2045 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2046 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2047 gdcmSerie to gdcmDicomDirSerie
2049 2004-03-19 Jean-Pierre Roux
2050 * ENH Now the tree-like structure describing a DICOMDIR comming from
2051 an already existing DICOMDIR file is consistent with
2052 the home-made tree-like structure build ex-nihilo
2053 or build from the files held (recursively) in a Directory
2054 functions gdcmDicomDir::CheckBoundaries()
2055 gdcmObject::SetBoundaries() added
2057 2004-03-17 Jean-Pierre Roux
2058 * REM (Eric Boix bug) : removal of meaningless
2059 gdcmDicomDirImage::NewImage function.
2060 * FIX now file names and directory name are written properly in the
2062 * FIX now gdcmDicomDir constructor may be call without any trick
2065 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2066 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2067 of gdcmDicomDirImage::NewImage as empty function.
2069 2004-02-28 Jean-Pierre Roux
2070 * ENH add gdcmDicomDir:NewPatient
2071 add gdcmDicomDirPatient:NewStudy
2072 add gdcmDicomDirStudy:NewSerie
2073 add gdcmDicomDirSerie:NewImage
2074 to allow making gdcDicomDir object.
2075 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2076 (as opposite to the gdcmHeader chained list)
2078 2004-02-11 Benoit Regrain
2079 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2080 when using from python
2082 2004-02-10 Benoit Regrain
2083 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2084 * FIX : in gdcmDicomDir when the directory is empty
2085 * ENH : add callback and methods to get the progression of dicomDir
2088 2004-02-06 Jean-Pierre Roux
2089 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2090 - GDCM_META added to gdcmDicomDirType
2091 - class gdcmMeta created
2092 * ENH : - A brief summary is now displayed at the beginning of
2093 'testDicomDir' to help disaster magnitude estimation
2094 * REM : Now useless Test/explDICOMDIR.cxx
2096 2004-02-05 Benoit Regrain
2097 * ENH : add methods in gdcmObject to get the hash table or the list of
2099 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2100 * FIX : wrapping python for TagHeaderEntryHT
2102 2004-02-04 Benoit Regrain
2103 * FIX : even length for some strings when writting the dicom dir
2104 * FIX : sort the images in the dicom dir
2105 * FIX : Bug fix for python use of dicom dir
2106 * ADD : a python demo
2108 2004-02-04 Jean-Pierre Roux
2109 * FIX : Final solution (?) for icone embedded images
2110 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2111 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2112 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2113 gdcmData/gdcm-MR-SIEMENS-16.acr1
2114 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2115 to make full checking easier
2117 2004-02-04 Benoit Regrain
2118 * FIX : WriteEntries : coding style & logic in parameters
2119 * FIX : Set the elements to create the DicomDir in a dictionary file
2121 2004-02-03 Benoit Regrain
2122 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2123 * gdcmDicomDir : add the load of directory
2124 * Bug fix and print add-on
2126 2004-02-03 Jean-Pierre Roux
2127 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2128 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2129 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2130 * FIX gdcmParser.cxx : 'group length' elements are now considered
2131 as integers, even for shadow groups, when file is Implicit VR
2133 2004-02-02 Jean-Pierre Roux
2134 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2136 of the last synonym :-(
2137 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2139 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2140 * FIX taking into account the possible 7fe0,0010 multiplicity
2141 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2142 to allow removal of references to 7fe0,0010, to deal with
2143 ACR-NEMA images, when 0028,0200 is meaningfull
2145 2004-01-31 Jean-Pierre Roux
2146 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2147 no longer writes 'Un' on disk
2148 * FIX SQ elements with actual length are now dealt with corectly
2149 * FIX gdcmFile::WriteBase make the difference, for color images, between
2150 the length (for Palette expanded images)
2151 and Raw Length (non expanded image + Palette)
2152 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2153 (that broke Write). Replaced by UL.
2154 Aware user will reload the field if he
2155 thinks it's necesssary
2157 2004-01-30 Jean-Pierre Roux
2158 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2159 when 'dirty Acr' is found, to be compliant with the new
2160 IsReadable() methods.
2162 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2163 (no DOUBLE images in kosher DICOM,
2164 but so usefull for people that miss them ;-)
2166 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2167 DICOMDIR related utilities (not checked as Windoze compliant)
2169 2004-01-28 Jean-Pierre Roux
2170 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2172 2004-01-27 Jean-Pierre Roux
2173 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2174 to allow skipping the shadow elements, to save memory space.
2175 The TRUE value for this param has to be used
2176 with a FALSE value for the 'enable_sequence' param.
2177 ('public elements' may be embedded in 'shadow Sequences')
2178 * gdcmHeader methods now deal with 'embedded icones images' in the header
2179 (even when an 'icone image sequence' is announced by the
2180 element (0x0088,0x0200), but there is NO icone at all ...
2182 * gdcmHeader sometimes Image Location value doesn't follow
2183 the supposed processor endianity (see gdcmData/cr172241.dcm).
2186 * gdcmHeader add the method
2187 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2188 to get *all* the Header Entries with the same tag.
2189 GetHeaderEntrySameName is probabely *useless*
2190 (no meaning : Name is *not* an identifier within the Dictionary)
2192 2004-01-26 Benoit Regrain
2193 * Bug fix in the print of hexadecimal representations. Remove long fields
2194 in the print and add a third level of print to print them
2196 2004-01-23 Benoit Regrain
2197 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2198 * Bug fix on test suite after remove the strip made on not string fields
2199 * Split the IsReadable method between gdcmParser which test that the file
2200 is dicom and gdcmHeader which test that it's an image file
2202 2004-01-22 Benoit Regrain
2203 * DicomDir : clean code, add methods, set variables in protected or private
2204 * gdcmUtil : bug fix for the clean string method
2206 2004-01-19 Benoit Regrain
2207 * Add the use of shadow dictionaries
2208 * bug fix and coding style
2210 2004-01-19 Benoit Regrain
2211 * src/gdcmFile.cxx : bug fix concerning the close of file
2212 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2213 * Add the update of header entries using the shadow library
2215 2004-01-19 Benoit Regrain
2216 * removal of file gdcmHeader2.cxx
2217 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2218 inheriting from gdcmParser. This split is to prepare the integration
2219 of dicom dir parsing
2220 * bug fix under python
2222 2004-01-16 Jean-Pierre Roux
2223 * REM removal of class gdcmHeaderEntrySet
2224 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2225 * ADD add file gdcmHeader2.cxx
2226 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2228 2004-01-15 Benoit Regrain
2229 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2230 entries created while parsing the header. Thus, they will be destroyed
2231 when the gdcmDictSet will be destroyed
2232 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2235 2004-01-15 Benoit Regrain
2236 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2237 made a fatal error because of the memory release at the end of program.
2238 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2239 some memory and vtk seems to have some problems with that.
2240 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2242 2004-01-14 Benoit Regrain
2243 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2244 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2245 * src/*.[h|cxx] : make changes due to class name changes
2246 * gdcmPython/demo/*.py : bug fix due to method names
2248 2004-01-13 Benoit Regrain
2249 * src/*.[h|cxx] : coding style
2250 * vtk/*.[h|cxx] : coding style
2252 2004-01-13 Benoit Regrain
2253 * gdcmPython/testSuite.py : test the readable flag of file for tests
2254 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2255 It's lied to the stl compilation by MSVC (windows, always windows...)
2256 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2258 2004-01-12 Benoit Regrain
2259 * src/*.h : add comments
2260 * src/gdcmDictSet.h : set the method BuildDictPath in public
2261 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2262 directly setted in the source code
2263 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2266 2004-01-09 Benoit Regrain
2267 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2268 * setup.py : use a reference to gdcmVERSION
2270 2004-01-07 Benoit Regrain
2271 * Modification to compile with the distutils.
2274 2003-12-10 Benoit Regrain
2275 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2276 can use a gdcmHeaderHelper to load data
2277 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2278 made in the source code
2280 2003-12-10 Benoit Regrain
2281 * Update Windows projects and .cvsignore files
2283 2003-11-12 Jean-Pierre Roux
2284 * ENH gdcmHeader constructor has one more parameter (default value : false)
2285 that allows the user to 'go inside' the SeQuences only
2287 gdcmElValSet:Print takes it into account
2289 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2290 * ENH: Update gdcmPython/CMakeLists
2291 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2292 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2294 2003-11-10 Jean-Pierre Roux
2295 * FIX : gdcmHeader::LoadElements is now based
2296 on the ListTag listElem member,
2297 not longer on the TagElValueHT tagHt member
2298 * ENH : PrintPubElVal shows (temporarily) both results,
2299 with the tagHt member and the listElem member.
2300 (it's easier to 'see' the problems when using Printheader)
2302 * FIX : old private member LgrElem is now splitted into
2303 ReadLength : Length actually found on disk (updated only
2304 if bug fixing is necessary), for internal
2306 UsableLength : Updated by FixFoundLength, to fix a bug
2307 or to allow Parser going on.
2308 Will allow to re-write a kosher header when a SeQuence
2309 with a length (not 0000) is found
2310 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2311 because gdcmElValSet::Add does not update ListElem
2314 2003-11-07 Jean-Pierre Roux
2315 * FIX misstyping in Transfert Syntax name table
2316 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2317 when they have an actual length (not 0000 nor FFFFF)
2318 (Nobody should care of it, but DICOMDIR explorers)
2320 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2321 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2323 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2324 * ENH: vtkGdcmReader now supports LUT !
2325 (vtkgdcmViewer for now is not able to use them though)
2327 2003-11-05 Jean-Pierre Roux
2328 * in testSuite.py : new files names for checking the package
2329 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2330 that returns the pixel area size to the *aware* (vtk) user
2331 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2333 2003-11-05 Benoit Regrain
2334 * in testSuite.py : Modify the rules for checking the paths
2335 : Explicit error messages
2336 * in __init__.py : Related modif
2338 2003-11-03 Jean-Pierre Roux
2339 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2340 to be used by aware (vtk) users that want to manage
2341 LUT (and no to turn the PALETTE image into an RGB pixels one)
2342 * GetPixelType now returns 8U for 24 Bits images
2343 (vtkGdcmReader compliant)
2345 2003-10-31 Jean-Pierre Roux
2346 * Removal of *all* gdcmData images and add them again
2347 in order to loose the 'history' of un-anonymised images
2349 2003-10-31 Jean-Pierre Roux
2350 * RMV : removal of useless jBitsInJsample.h
2351 for both 8 and 12 Bits JPEG Lossy Libraries
2353 2003-10-31 Jean-Pierre Roux
2354 * ENH : Add the functions gdcmFile::GetImageDataRaw
2355 gdcmFile::GetImageDataIntoVectorRaw
2356 that act as GetImageData and GetImageDataIntoVector
2357 except the making of an RGB Plane from Gray Plane + LUT
2358 Intended to aware (vtk) users who know how to manage
2361 GetLUTRGBA return a R,G,B,A LUT if any
2362 lgrTotaleRaw gives the 'Raw' length
2363 GetImageDataRaw returns the gray Plane
2364 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2365 (They stay Grey, just like with other Dicom viewers :-(
2367 2003-10-30 Jean-Pierre Roux
2368 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2370 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2371 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2372 being coherents dicom files.
2374 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2375 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2377 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2378 * ENH: Two steps is necessary to please VC++ compiler...
2379 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2380 * ENH: Add include dir to medcon lib
2381 * FIX: only one function is being exported for now !
2382 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2384 2003-10-29 Jean-Pierre Roux
2385 * adding gdcmHeader::GetLUTRGBA
2386 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2387 --> Mathieu, the modif u're waiting for is not yet committed
2388 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2390 2003-10-27 Jean-Pierre Roux
2391 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2392 00191113.dcm DermaColorLossLess.dcm
2393 MxTwinLossLess.dcm RadBWLossLess.dcm
2394 * ENH: For version prior to vtkImageViewer2 -r 1.19
2395 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2397 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2398 * Removal of ido stuff in CMakeLists.txt
2400 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2401 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2402 * FIX: remove a call to ->Modified ... see comments
2403 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2405 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2406 * FIX: Problem with path for libvtkgdcmPython
2407 * ENH: Try adding a search script for python site-package
2408 * RMV: Remove some file from medcon lib that are not necessary
2409 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2410 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2411 * FIX: More pragma disable fro VC++,
2412 I don't think I break something as it is also disable in VTK/ITK.
2413 But it fasten debug compilation time.
2415 2003-10-23 Jean-Pierre Roux
2416 * gdcm now deals with 16 Bits Run Length Encoded images
2417 (they are compressed as 2 planes images,
2418 one for the high Bytes, the other for low Bytes)
2420 2003-10-22 Jean-Pierre Roux
2421 * Now CheckRead takes into account :
2422 - the bugged 'Leonardo' Siemens images
2423 - the XA images, sent thru the burning VPRO station
2424 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2427 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2428 * FIX: When copying a Makefile.am to CMakeLists.txt
2429 one should remove the '\'
2431 2003-10-22 Jean-Pierre Roux
2432 * in gdcmData adding a bugged 'Leonardo' Siemens image
2433 (wrong lengths in header)
2434 OK with gdcm, KO with the other viewers :-)
2435 * add a GE dlx XA image, thru the VEPRO burning station
2438 2003-10-21 Jean-Pierre Roux
2439 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2440 for a brutal checking of vtkgdcmViewer compliance
2442 2003-10-21 Jean-Pierre Roux
2443 * add the files for 'xmedcon' Jpeg Lossless library
2444 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2446 2003-10-21 Jean-Pierre Roux
2447 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2449 2003-10-21 Jean-Pierre Roux
2450 * garbage Siemens 'Leonardo' images dealt with
2451 (the patch is easy to remove)
2452 * cosmetic changes to avoid warnings
2454 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2455 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2456 no need to press 'r' now.
2458 2003-10-20 Jean-Pierre Roux
2459 * upgrade of checkRead.sh checkWrite.sh according
2460 to new Jpeg Lossless decompressor
2461 * add US.3405.1.dcm, a genuine RGB medical file ...
2462 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2463 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2465 2003-10-15 Jean-Pierre Roux
2466 * general anonymisation in gdcmData
2467 * adding the 'color files' from
2468 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2469 * adding some well knowed bugged-header images
2470 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2471 waiting for their inclusion in Python testsuite
2473 2003-10-15 Jean-Pierre Roux
2474 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2475 no longer seg faults when file is not found
2477 2003-10-14 Jean-Pierre Roux
2478 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2481 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2482 * TODO: *.in file to genereate a UseGDCM later
2484 2003-10-14 Jean-Pierre Roux
2485 * Some supposed-to-be Dicom Images have no preamble.
2486 OpenFile takes it into account
2487 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2488 * Missing elements added in dicomV3.dic
2489 (just to be affraid : have a look at
2490 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2491 and do it again next year ;->
2493 2003-10-13 Jean-Pierre Roux
2494 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2495 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2496 But there are NOT. It's fixed !
2498 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2499 * FIX: "jpeglib.h" was not found on VC++
2500 * FIX: vtkgdcm was not being installed
2502 2003-10-10 Jean-Pierre Roux
2503 * ENH : OpenFile closes the file if it *really* doesn't look like
2504 an ACR-NEMA / DICOM one.
2505 * FIX : testWrite no longer writes an empty file if the source file
2506 is not gdcm Readable
2507 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2510 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2511 * FIX: CMake generate now documentation
2512 * ENH: out of source doc build !
2513 * ENH: Generate both user and dev documentation
2514 * ENH: Should work on windows too
2515 * ENH: Only one doxygen config.in file is needed
2516 * FIX: make install should be ok now on ùnix plateform
2517 * FIX: PATH to dictionary was wrong (missing /)
2518 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2520 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2521 * vtkGdcmReader is now able to read rgb dicom file.
2522 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2523 * added a gdcmViewer to vtk test, use mouse to control
2524 window level & window width
2526 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * CMake-ification of gdcm, we have now two build system
2528 * FIX: on cygwin Wsock32 doesn't exist
2529 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2531 2003-10-06 Emanuel Ollart
2532 * FIX : compilation process wad broken.
2533 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2535 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2536 * change gdcmViewer -> vtkgdcmViewer
2537 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2539 2003-10-06 Jean-Pierre Roux
2540 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2541 ( e.g : well known GE images with a wrong elem length,
2542 : Philips MRI Images with a wrong Huffman table)
2543 * still to be done : allow the reading of bugged LEONARDO Siemens images
2545 2003-10-03 Jean-Pierre Roux
2546 * Odd length strings are padded with '\0' (not with spaces,
2547 to remain compliant with already defined strings,
2548 like Transfert Syntax UID and others)
2550 2003-10-03 Jean-Pierre Roux
2551 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2552 to allow displaying RGB images (not only by affim ;-)
2554 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2555 * vtkGdcmReader is now able to read rgb dicom file.
2556 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2558 2003-10-03 Jean-Pierre Roux
2559 * A few nasty patches to allow the reading of a lot of nasty images
2560 ( e.g : well known GE images with a wrong elem length,
2561 : Philips MRI Images with a wrong Huffman table)
2562 * still to be done : allow the reading of bugged LEONARDO Siemens images
2564 2003-10-03 Jean-Pierre Roux
2565 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2567 2003-10-03 Jean-Pierre Roux
2568 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2569 to allow displaying RGB images (not only by affim ;-)
2571 2003-10-03 Jean-Pierre Roux
2572 * gdcmFile::GetImageDataIntoVector now
2573 - deals with MultiFrames MultiFragments Run Length Encoded files
2574 - deals with YcBcR (YBR_FULL) files
2575 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2576 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2578 (no sample found :-(
2580 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2581 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2582 Two reasons: - clear things
2583 - third parties acces gdcm through header files, so won't
2584 suffer anymore VC++ complains
2586 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2587 * add argv[1] in testvtkGdcmReader.cxx
2590 2003-09-24 Jean-Pierre Roux
2591 * The lines are now eigthy characters long.for
2592 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2594 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2595 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2596 char* to std::string. Thus, the use of strdup becomes useless. (see
2597 previous commis of Malaterre)
2598 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2599 before the last Malaterre's commit.
2601 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2602 * This commit should fix the Debug building under VC++, the problem
2603 was mainly a mixture of debug and release lib being loaded at startup.
2604 * I also remove a depency to a specific C function: strdup. Because I had
2605 to force the link to msvcrtd (whereas strdup is in libc).
2607 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2608 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2609 located in the gdcmCommon.h file. All use of reference of tha has been
2610 changed to now use the variable GDCM_UNFOUND.
2612 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2614 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2615 Dicom dictionary. The test suite can now be run again. Note:
2616 I'm note very happy with the " (RET)" changes. I believe this
2617 RETAINED comment should be dropped when parsing the dictionary.
2618 - PACKAGER corrected
2620 - AUTHORS updated and now in alphabetical order
2621 * Makefile.am now exports gdcm.dsw for Windoze users.
2623 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * cygwin complains about missing std:: in subdir Test/
2626 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * remove some methods that are now in gdcmHeaderHelper
2629 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2630 * vtkGdcmReader set spacing and origin correctly
2632 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2633 * Fix a few delete/delete[] mismatch
2635 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2636 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2637 interpretation to data given by gdcmHeader. For instance there are
2638 heuristics to get informations (look at different places).
2639 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2640 sorting DICOM images based on different strategies.
2641 * modified Makefiles accordingly.
2643 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2644 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2645 when building in debug mode
2646 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2647 src/win32/gdcmdll.dsp
2648 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2650 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2651 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2654 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2655 * src/win32/libgdcmjpeg12.dsp was not dos format
2656 * src/win32/libgdcmjpeg12.dsp :
2657 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2658 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2660 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2661 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2663 * src/gdcmFile.cxx : bug fix in affectation type
2664 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2665 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2666 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2667 symbols... future problem ?
2669 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2670 * src/win32/libgdcmijpeg12.dsp was missing
2671 * modified gdcm.dsw accordingly
2673 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2674 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2676 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2677 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2678 commit of JPR (before his hollidays to facilitate our work).
2679 * setup.py : bug fix in code. Modifications made while the last commit
2680 of JPR. The code hasn't been tested before the commit... it's so
2681 useless to make that (for best programmer that is JPR) !!!
2683 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2684 * tagged the current version as Version0_3 (i.e. version 0.3)
2686 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2687 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2688 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2689 * *.dsp : modifications to use new libgdcmijpeg8 library
2690 * setup.py : bug fix on VTKPATH variable
2691 * PACKAGER : adding all concerning windows
2693 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2694 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2696 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2697 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2698 test suite reported error.
2699 * PACKAGER file added (describes what a packager must do when
2700 packaging a new release).
2701 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2702 * configure.in: upgraded version number to 0.3.0
2703 * fixing build of rpm (through rpm -ta):
2704 - Doc/Makefile.am exports proper doxygen files
2705 - src/jpeg/libijg8/Makefile.am exports the include files.
2707 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2708 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2709 * src/gdcmHeader.h : formatting code
2711 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2712 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2713 We were obtaining error message from vtk. Now, creation of file list
2714 is made in an internal list to prevent this problem.
2715 Bug fix when output is empty.
2716 Bug fix in update of progress value. Previous commit for this was a bad
2718 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2720 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2721 * src/gdcmHeader.h : added method to get the file name
2722 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2723 files. Added method to remove all files on the input
2724 Added FIXME comment concerning the bad parsing of header made by
2725 ExecuteInformation method (in ExecuteData method)
2727 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2729 when using make instal.
2730 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2731 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2733 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2734 * setup.py : adding include dir of jpeg lib to compile all sources
2735 * */Win32/*.dsp : JPR fix for windows compilation
2737 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2738 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2740 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2741 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2743 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2744 * setup.py is again effective on un*x (takes into account the
2745 addon of the jpeg library)
2746 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2747 * Doc/Doxy* updated (includes above enhancements)
2748 * INSTALL now points to web documentation
2750 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2751 * src/gdcmHeader.h doesn't make unnecessary reference to
2753 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2755 * src/gdcm*.[cxx|h] :
2756 - to allow compilation with gcc 3.x
2757 -- clean up of STL usage (added explicit usage of std::)
2758 -- small fixes on exceptions.
2759 Note: linking not tested !
2760 - clean of doxygen comments to avoid warnings at documentation
2762 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2763 dependent convertion).
2765 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * Clean up of previous JPR garbage commit (not even commented in the
2768 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2769 - moved all jpeg related files from src to src/jpeg/libijg8, with
2770 addition/modification of Makefile.am and configure.in.
2771 - the testSuite is still brain damage (not guilty).
2773 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2774 * WrapVTK.py : modifications to get correctly vtk source files to
2776 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2777 (FileName -> Filename)
2779 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * vtk/vtkGdcmReader.[cxx/h]:
2781 - UpdateProgress method should now be effective
2782 - removed the limitation on having only images loaded (as opposed
2784 - when building a stack of images/volume, a lesser number of
2785 gdcmHeader and gdcmFile instances should be used (hopefully
2786 accelerating things).
2787 - when building a stack of images/volumes, files which are not
2788 loadable (wrong path-filename, wrong permissions on existing file,
2789 or file not parsable by gdcm) are replaced with a black image
2790 in the stack (for the caller to notice the problem).
2792 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2795 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2796 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2797 between standard library (std) and vtk library (problems are found
2798 under Windows... thanks Windows !)
2800 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2803 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2805 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2808 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * When compiling with distutils (see setup.py) the C++ compiler is
2810 called with different flags than the default ones (with automake).
2811 In order to fix all those warning, I compiled gdcm with the command
2812 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2813 and went for warning fixes:
2814 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2815 up from unused variables.
2816 - vtk/vtkGdcmReader.cxx: potential bug fix.
2817 * src/gdcmHeader.h: Doxygen warning cleanup
2819 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2820 * gdcmPython/gdcm.i:
2821 - typemaps correction to take into account the systematic replacement
2822 of "using namespace std" with std:: prefix e.g. std::list,
2823 std::string... (cf changes of 2003-05-21).
2824 - gdcmGlob global variable of type gdcmGlobal (defined in
2825 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2826 exported to Python a as cvar.
2827 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2828 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2829 gdcmDictSet.GetPubDictTagNames() and
2830 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2831 C++ static methods).
2832 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2833 with the above changes.
2835 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2836 * setup.py, manifest.in : bug fix under linux
2838 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2839 * Modification of setup.py to compile vtk part too. Then, we have 2
2840 wrappers which must work with same distutils. For that, we have a
2841 generic distutils in distusiltsWrapping.py ; with :
2842 - build_extWrap class to wrap generically all extensions,
2843 - ExtensionWrap base class for all wrapping extension that contains
2845 - Wrapper interface which wrap sources
2846 + In WrapSwig.py we have extension and wrapper for Swig
2847 + In WrapVTK.py we have extension and wrapper for VTK
2848 * MANIFEST.in : modifications to consider vtk directory and new python
2849 files for compilation
2851 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2852 * Added python wrappers of vtkGdcmReader vtk class (see the
2853 source in vtk/vtkGdcmReader.cxx) :
2854 - vtk/Makefile.am now builds a library
2855 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2856 python library (as opposed to _gdcm.so wich are the python
2857 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2858 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2860 - configure.in has an additional flag --enable-vtk that needs
2861 to be set to enable compilation of vtk related code, that is:
2862 + vtk/vtkGdcmReader.so and
2863 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2864 + gdcmPython/vtkgdcmPython.so (see above)
2865 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2866 be read when compressed or when HighBit + 1 != BitsStored),
2867 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2868 the usage of the python wrapper of vtkGdcmReader vtk class.
2869 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2870 * src/*.[h] all occurences of stl classes are now prefixed with
2871 std::, and all occurences of "using namespace std;" where removed.
2872 This is to avoid pollution of global namespace in included files.
2873 Apparently vtk does not avoid this pitfall: when using both
2874 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2875 collision of various stl members (principally cout...).
2876 * gdcmPython/testSuite.py now cleanly removes temprory generated
2878 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2879 comply with above changes)
2881 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2882 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2883 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2884 vtk data structure (an image Flip was required).
2885 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2886 * cosmetic changes in documentation.
2888 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2889 * src/gdcmHeader.cxx: the constructor no longer exits when an
2890 unexisting file is given as argument.
2891 * The subdirectory Data (containing all the images used for the
2892 test suite) is not part of this repository anymore. A new module
2893 containing those images is now available at
2894 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2895 with the name gdcmData.
2896 All the python scripts (including the package initialisation file
2897 gdcmPython/__init__.py) were adapated to take this change into
2898 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2900 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2901 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2902 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2903 demo of the usage of this class.
2904 Compilation of this vtk part is only done when using the --enable-vtk
2905 at configure (or autogen.sh) stage.
2907 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2908 * More memory link related corrections and documentation fixes.
2910 - maximum info is obtained with a command of the form:
2911 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2912 --show-reachable=yes PrintHeader
2913 - the remaining reachable blocks seem to come from the STL
2914 allocation scheme through the usage of map and list. It looks
2915 like this memory cannot be freed but it is not a memory leak
2916 (in fact further invocation to the STL would recollect the
2917 unused memory allthough it cannot explicitely be freed).
2918 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2919 of displaying an image parsed with gdcm and displayed with VTK.
2920 Note: some images don't seem to work e.g.
2921 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2922 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2923 Allthough this weakens the semantics, it is a ditch attempt to
2924 make gdcm more thread friendly.
2926 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2927 * Memory link hunt (by using valgrind through the command
2928 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2929 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2930 gdcmHeader::_dicom_vr.
2931 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2932 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2934 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2936 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2937 * src/Makefile.am now exports all the necessary include files at
2941 * UpdateGroupLength replaced by new one
2944 * UpdateGroupLength re-written using H-Table
2945 (named UpdateGroupLengthNew untill checks are over)
2947 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2948 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2949 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2951 - gdcmHeader::GetPubElValSet removed.
2952 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2953 UpdateGroupLength, WriteElements, Write.
2954 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2955 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2956 carried the same semantics.
2957 - src/gdcmHeaderIdo.cxx changed accordingly.
2958 - gdcmFile::WriteBase now regroups all the codes from previous
2959 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2960 - enum FileType moved to gdcmCommon.h
2961 * src/gdcmHeader.cxx AddDefault trashed
2962 * gdcmGetXSize added
2963 * getimageDataSize now calls gdcmGetXSize
2964 * Test/*.cxx changed to agree with above changes
2966 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2967 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2968 (to avoid double call by end user).
2969 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2970 by end user, since gdcmHeader::gdcmHeader now handles it.
2972 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2973 * gdcm/Doc many doxygen changes:
2974 - Doxyfile now has two different versions, DoxyfileUsers that generates
2975 the html.users end users oriented documentation and
2976 DoxyfileDeveloppers that generates the html.developper developper
2977 oriented documentation.
2978 - README changed accordingly
2979 - requirement.txt removed (old design info moved to TODO).
2980 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2981 DoxyMainPage.txt, DoxyPython.txt provide more information.
2982 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2983 be updated by simply regenerating the docs with doxygen and copying
2984 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2985 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2986 all the tests in the form "if (<map>.count() >1)" were removed.
2987 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2988 ill-formed documentation sections.
2989 * src/gdcmHeader.cxx: ditto
2991 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2992 * setup.py fixed for un*x (needed macro for stdint.h)
2993 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2994 un*ces with sh-utils test utility.
2995 * gdcmPython/demo/test.py renamed to PrintHeader.py
2996 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2997 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2998 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2999 * src/gdcm*.cxx JPR's bad inclusion fixed.
3001 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3002 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3003 * gdcmPython/demo/test.py changed accordingly.
3005 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * gdcmPython/Makefile.am fixed linking against libstdc++
3007 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3008 * Swig subdir (historical tests of swig version 1.3.17++) removed
3009 * Test/testChangeEntete.cxx some lines commented out in order to make
3011 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3012 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3014 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3015 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3016 hence the user doesn't need this explicit call.
3017 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3018 i.e. LoadElements() call removed.
3019 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3020 - src/Makefile.am declares the proper flag for g++.
3021 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3022 for adding user defined new tags.
3023 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3024 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3025 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3027 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3028 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3029 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3030 src/Makefile.am : the project should properly compile and install
3031 with the autotools, included the python wrappers part.
3032 * gdcm.spec.in : added a spec file for RPM packaging.
3034 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3035 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3037 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3038 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3039 to exported to the environement (see gdcmPython/testSuite.py
3041 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3042 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3043 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3044 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3045 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3047 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3048 * gdcmPython/__init__.py doesn't crash anymore when running in
3049 in InstallMode or PreInstallMode but with an environment given
3050 value of GDCM_DICT_PATH.
3051 * src/gdcmDictSet.[cxx/h] coding style.
3053 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3054 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3055 * src/gdcm.h general comments moved to TODO, and README
3056 * src/gdcm.h should now be seen as a user commodity (including it
3057 should suffice to fully use gdcm). It is nowhere including within
3058 any of the kernel files src/*.cxx and src/*.h.
3060 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3062 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3064 * src/gdcm*.cxx only include their corresponding include file
3065 (as opposed to gdcm.h)
3066 * gdcmPython/gdcm.i changed accordingly
3067 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3068 the autogen.sh generated "make snapshot" command to work.
3069 * autogen.sh removed history related references to crea package.
3071 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3072 * distutilsSwigCPlusPlus.py work around some swig portability
3075 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3076 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3077 was done in a last ditch attempt to get setup.py _really_
3078 operationnal. The python/gdcmPython layaout add the advantage
3079 of hidding away the python related distutils specific files
3080 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3081 Alas, the src directory was out of scope (i.e. it's relative
3082 position to setup.py was ../src) which made things impossible to
3083 handle (see previous version of python/setup.py). Crossing fingers...
3085 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3086 * python/setup.py now works on Un*x. (harder than I thougth)
3087 * python/distutilsSwigCPlusPlus.py can now have include files
3088 among the list of sources.
3090 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3091 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3092 * modifications in MSVC projects
3094 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3095 * As stated by the first lines of Test/ExceptionAndPython/README, it
3096 looks like we can move back to original usage of exception within
3097 src/gdcm* and hence remove the errno stuff that was introduced
3098 as a quick and dirty fixture of this problem (added to the TODO).
3099 * Doc/Doxyfile configuration file for Doxygen and corresponding
3100 README file for usage added.
3101 * Test/testWrite.cxx added. This new test comes from a split of
3102 test.cxx that is now reverted to its original purpous i.e.
3103 testing the proper parsing of a Dicom related file.
3104 testWrite.cxx concentrates on testing the IO part of gdcm.
3105 * Test/bug1.cxx (containing a bug on WIn32) added.
3106 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3107 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3108 whose purpose is to publish the content of the TagNames of the
3109 Dicom public dictionary were not accessible without an
3110 instance of class gdcmHeader.
3111 - those methods are now static methods of gdcmDictSet and hence
3112 require no instances at all to be invocated.
3113 - within gdcmDictSet this change required to change some method
3114 to class methods (i.e. are now static) among which SetDictPath
3115 (renamed to BuildDictPath) and LoadDefaultPubDict.
3116 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3117 the above changes by calling the new method classes of gdcmDictSet.
3118 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3119 the above to be effective.
3120 * python/gdcmPython: in order to wrap properly the above changes
3121 for Python, swig version now needs to be > 1.3.17.
3122 * python/gdcmPython/Makefile fixed to adapt itself to new
3123 configure/make shema introduced by Johan Montagnat (thanks for the
3124 contribution). Alas this Makefile cannot be turned into a proper
3125 Makefile.am without some heavy changes in the configure.in
3126 (for python dectection).
3127 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3128 now avoids publishing the empty entries.
3130 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3131 * python/setup.py : bug fix concerning install under windows
3132 ExtraPath reused :-P
3133 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3135 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3136 * Dicts/dicomV3.dic : remove double spaces !!!
3137 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3138 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3141 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3142 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3143 method. Doxygenation.
3144 * src/gdcm.h clean up of JPR spurious comments.
3146 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3147 * python/distutilsSwigCPlusPlus.py now properly collects the
3148 shadow classes generated by "swig -c++" (gdcm.py in our case)
3149 when using "python setup.py install".
3150 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3151 reexports the working classes.
3152 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3153 by the classical C errno scheme. This is to prevent an obscure
3154 behavior of the python wrappers when importing wxPython.wx prior
3155 to gdcmPython (which ended up in an abort call). An illustration
3156 of this oddity can be found in the Test/ExceptionAndPython
3157 subdir (see the README file). This problem probably due to
3158 an combination of g++ and dynamic loading.
3159 * added Test/ExceptionAndPython (see above)
3161 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3162 * Changed the layout of the python part to avoid bloating main
3163 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3164 i.e. the distutils arsenal. All the python related stuff is
3165 again in a python subdir, but the package itself is now in
3167 * setup.py was cleaned up:
3168 - pythonIncludePath removed
3169 - python setup.py bdist target is now functional.
3170 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3171 collision with other packages). gdcmPython/demo/*.py changed
3174 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3175 * python subdir moved to gdcmPython (preparation of distutils packaging).
3176 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3177 distutils installer is operational.
3178 * - gdcmPython/__init__.py now properly loads the swig generated
3179 shadow classes (from gdcm.py).
3180 - gdcmPython/demo/*.py changed to import the package gdcmPython
3181 instead of gdcmPython/demo/load.py.
3182 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3184 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3185 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3186 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3187 entries within the associated public Dicom dictionary resp. the same
3188 information but sorted by the fourth field (PAT, IMG, DIR) of the
3190 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3191 are now in the "???" group.
3192 - python/gdcm.i changed accordingly,
3193 - python/demo/printGroupedPublicDict.py added, that gives an example
3194 of the above new functionalities in Python.
3196 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3197 * src/gdcm.h, gdcmHeader.cxx:
3198 - historic references to glib's g_malloc and g_free (#defined)
3199 were definitively removed.
3200 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3201 * src/gdcmElValSet.cxx:
3202 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3203 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3204 - GetElValue(string) renamed to GetElValueByName.
3205 - Added GetElementByName(string).
3206 * src/gdcmHeader.cxx: added
3207 - GetPubElValRepByNumber(guint16, guint16)
3208 - GetPubElValRepByName(string)
3209 - GetShaElValRepByNumber(guint16, guint16)
3210 - GetShaElValRepByName(string)
3211 - GetShaElValByNumber(guint16, guint16)
3212 - GetShaElValRepByName(string)
3213 - GetElValRepByNumber(guint16, guint16)
3214 - GetElValRepByName(string)
3215 - GetElValByNumber(guint16, guint16)
3216 - GetElValRepByName(string)
3217 * Doc/requirements.txt added.
3219 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3220 * Test/Makefile building now depends on the one of libgdcm.so
3221 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3222 pixel data) aware which enables finding the address (offset) of
3223 the pixel data of JPEG encoded DICOM files. This leaves only a single
3224 file in the testSuite whose pixel data address (offset) is unknown.
3225 * python/testSuite.py changed accordingly.
3227 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3228 * VC++ has some strong limitations when working with the STL, as stated
3229 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3230 "Also note that some STL containers (map, set, queue, list, deque)
3231 cannot be exported. [...]
3232 Some STL classes contain nested classes. These classes can not
3234 This is caused by a designed limitation that once a template
3235 class is instantiated, it can not be re-instantiated and
3237 Since our usage of map<> is ubiquitous in gdcm, this "designed
3238 limitation" of VC++ is a pitfall.
3239 Hence the Python wrappers of gdcm cannot be incrementally linked
3240 against the c++ dynamic library. The dirty but only workaround is
3241 to forget about incremental link of dynamic libraries and to generate
3242 the Python wrappers library with the inclusions of the underlying C++
3244 The following modifications concern this matter on Win32/VC++:
3245 - wrapping python correct with standalone wrapped dll (don't use separate
3246 dll under windows !!!!)
3247 - python21_d debug mode enabled (ask Frog how to use it :-)
3248 - NO problem with having an STL member of class for example string in C++
3249 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3250 - Python test of dcmlib in Python is ok under windows on a large set
3252 * removed glib references
3253 * typedef's inserted in gdcm.i for correct swig type management
3255 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * python/demo/*.py load.py extracted from test.py. Added explore.py
3257 that only displays required tags and testAll.py that parses all
3258 the files of the testsuite without using unittest.
3259 * python/testSuite.py other additional test on new files added.
3260 * Data/* new test files added accordingly to the testSuite.
3261 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3262 the vr in the file differs from the one of the dictionary.
3264 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3265 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3266 values, but limits itself to values which are below a user specified
3267 size (by default 1024 bytes).
3268 * python/gdcm.i : elements not loaded (because their size is above the
3269 user specified treshold) are exported with their TagKey as key of the
3270 python dictionary. This enables the testsuite to make some checks
3271 on the unloaded elements (since we have their offset and size).
3272 * python/testSuite.py
3273 - now tests for the existence and proper value of the pixel data
3274 - two new examples added.
3275 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3277 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3278 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3279 aware. See the strategy comments in gdcmHeader::FindLength().
3280 * Test/test.cxx now accepts a filename as first argument.
3281 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3282 * python/testSuite.py changed to integrate test on above files.
3284 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3285 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3286 the vr was also RET.
3287 * python/testSuite.py more tests added.
3289 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3290 * python/testSuite.py unittest test suite added (uses Data)
3291 * Data/* dcm and acr files for the test suite.
3292 * glib dependance removed from un*x version. We now use ISO C99
3293 7.18 Integer types (see stdint.h)
3294 - python/Makefile, src/Makefile src/gdcm.h
3295 * src/ when an explicit vr (like dicom files) suddenly poped an
3296 implicit element we use to mark the underlying DictEntry of the
3297 concerned ElValue with "Implicit". This strategy was damageable
3298 too the public or provite dictionaries, since some of their vr
3299 would be changed. Since Header::FindLength heavily relies on the
3300 detection by Header::FindVR of falsely explicit elements, I
3301 added an extra ImplicitVr member to ElValue (boolean).
3302 The rest of the changes we the necessary adaptations.
3304 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3305 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3307 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3309 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3310 * Adaptation for porting to VC++:
3312 o forced to use std namespace (for string to be known)
3313 o all class use __declspec export style on WIN32
3314 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3315 (in stdlib.h on Win32 but in std:: for gcc)
3316 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3317 variable GDCM_DICT_PATH.
3318 * src/gdcmHeader.cxx verbose comments made discrete.
3320 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3321 * python/gdcm.i: added a typemap that converts a C++ hashing table
3322 to native Python dictionary.
3323 * python/demo/test.py:
3324 - now uses the native dictionary for exploration of gdcmHeader.
3325 - takes an optional filename argument (the file to parse).
3326 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3327 PubElVals hashing table.
3328 * Dicts/dicomV3.dic removed error prone trailing spaces.
3330 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * Python wrapping process moved away from src/Makefile to
3332 newly created python/Makefile (as well as gdcm.i)
3333 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3334 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3335 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3336 from the environement variable GDCM_DICT_PATH (when existing).
3337 * src/gdcmDict::GetTag bug fix.
3339 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3340 * Straightforward temporary fixes for swig to build the python wrappers.
3341 src/Makefile now has a python working entry [by working we mean
3342 that we can import the shadow classes without errors].
3344 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * hashtest.cxx removed (since already in Test)
3346 * src/gdcmlib.h renamed to src/gdcm.h
3347 * src/dcm.i renamed to src/gdcm.i
3348 * src/Makefile prepared for python wrapping
3350 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3351 * src/gdcmHeader.cxx :
3352 - Parsing of header is now separated from loading of element values
3353 (see gdcmHeader::LoadElements).
3354 - general clean up of hopefully all file access (creation of
3355 ReadInt16 and ReadInt32)
3357 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3358 * src/gdcmHeader.cxx :
3359 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3361 - SetLgrElem renamed to SetLength
3362 - GetLgrElem renamed to GetLength
3363 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3364 * src/gdcmElValSet.cxx fixed both GetElValue methods
3365 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3366 due to IdoDude was cleaned out.
3368 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3369 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3370 concentrates on finding the value representation (when it exists).
3371 RecupLgr now only finds the element value length, and it avoids
3372 returning the unecessary skL (skipped length).
3373 Also, offsetCourant was simply removed (with taille_fich) since
3374 it was redundant with the File position internals (by using
3375 ftell and fseek). This also made skL (see above in RecupLgr) usage
3377 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3378 on the libido specificities which are handled through class
3380 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3383 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3384 * Truckload of changes. Parsing of header is barely functional
3385 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3387 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3388 * src/gdcmHeader.cxx many addons of low level methods
3390 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3391 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3392 and _IdDcmSWAP_LONG.
3394 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3395 * This corresponds to all the changes decided at the meeting of
3396 May 23 2002. Needless to say we are running late...