1 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/ShowDicomSeq.cxx : bug fix
4 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
6 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
7 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
8 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
10 * Test/TestCopyRescaleDicom.cxx : remove unused variable
11 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
12 containing found sequences
14 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
17 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
18 Some fields in BinEntry must be copied to not seg fault when making the :
19 gdcm::File *copy = new gdcm::File( copyH );
20 and tests are now made on good variables
22 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
24 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
26 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
27 * Add vtkGdcmWriter example and test
29 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * Test/TestUtil.cxx : reformat the source code
31 * vtk/vtkGdcmReader.cxx : remove and change prints
32 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
34 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
35 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
37 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
39 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
41 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
43 by an eof to prevent all bad read of the file... and in this case, the
46 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * Example/Volume2Dicom.cxx : comment unused variables
48 * Test/PrintDicomDir.cxx : comment unused variables
49 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
50 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
51 method that is redondant with AddEntry.
52 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
55 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Bug fix due my last commit (compilation under Windows).
57 * Example/Volume2Dicom : bug fix in the file and reformatting source code
58 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
60 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 - Remove printf / sprintf
63 - include iostream AFTER gdcm so we don't get warnings
64 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
66 - Also remove tons of include from header files, hopefully this should
67 speeup the compilation time, since it was becoming a dog slow.
68 - Remove gdcm.h as it include way too many files and slow down compilation
69 (plus it is not up to date)
70 - remove 'using namespace std' this is BAD !
72 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Remove memory leaks on the DicomDir
74 * Remove some useless datas in DicomDirObject
75 * Add usefull methods in SQItem, to be complient withe the ElementSet
77 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
80 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
82 future, with convertion)
83 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
84 and ImageDataSize values. Remove the method to get the PixelReadConverter
85 from the output of the class
87 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
90 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
92 and vtkErrorMacro use.
93 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
95 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
98 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
99 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
100 The string leaves only in the fonction. So when we make a .c_str(), we
101 get the pointeur on the first element, element that will be destroyed
102 immediately after thee instruction.
103 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
104 file has been opened : the test must be made on the content of the
105 pointer and not directly on the pointer !
108 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
110 the python part recompiles
112 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
114 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
115 X session is killed (for my computer... it seems to not be identic on
118 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
120 avoid problems (otherwise, the difference test between the visible image
121 and the reference is incorrect. If the reference is greater than the
122 screen resolution, it's produce errors).
123 Can be used for only one image. Can be used with a visible flag.
124 * vtk/vtkGdcmReader.cxx : remove commented codes.
125 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
126 under windows at compilation
127 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
129 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
131 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
133 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
134 tests on the image size X, Y, Z
136 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
138 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
139 between the class name and the file name
141 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/ : fix compilation warnings for the Write method (2 different
143 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
144 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
145 variable... create a static method in gdcm::Document to access to
146 this variable content.
148 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
150 file, to be accessed by other files (like gdcmFile). Remove commented
151 code. Move the change of the header to the gdcmFile, using the
153 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
154 To be sure of that (and simplify calls), the Write of the header now
155 gets a file name and not a file pointer (std::ifstream).
156 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
157 DocEntryArchive. Remove all open of the written file
159 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
162 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
164 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
166 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
167 some corresponding methods. Write correctly the file and check before
169 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
170 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
171 is now on RGB datas (as before my last commit
172 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
174 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
176 Add a print information of the type of the entry
177 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
178 It was in the gdcmFile, and all write have been regrouped
179 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
180 Write correctly all dicom files (in decompressed mode only at this time)
181 * Test/ : test on files are now made using Raw datas and not color datas if
183 * Example/PrintFile.cxx : add more printings
185 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * Amelioration of code, remove some code copy. For the loading of
187 BinEntry (in gdcmDocument), add the test to verify if the file is already
190 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
191 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
192 remove a DocEntry in the header (push an empty DocEntry)
193 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
194 lines. Bug fix in the initialization of the PixelConvert and the
196 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
197 use in TestCopyDicom (now this test can run under windows... but fails)
198 * Test/TestCopyDicom.cxx : amelioration of the test :
199 - test the pixels written
200 - add test points to quickly find where is the error
201 - can set a file name input and output in arguments
202 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
203 amelioration of the test output
205 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
207 all replaced DocEntry's
208 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
209 Now, each needed DocEntry to modify is duplicated, modified and inserted
210 to the header using DocEntryArchive. Thus, after save, we can restore the
211 header initial state.
213 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
216 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
218 correct to copy it. The DictEntry is specified at the DocEntry creation,
219 then, it musn't change in the time.
220 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
221 header correctly. At this time, the change is only made for the first
222 level of the Document. In the future, it might consider sequences.
223 The change is made by replacing a DocEntry by an other that is created
224 outside the class. The old value is kept. When we restore the header
225 status, the added DocEntry is deleted and replaced by the old value.
226 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
227 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
228 set the write type to explicit VR, implicit VR or ACR. Add methods to set
229 the write mode to native, decompressed or RGB (but not used at this time)
231 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
232 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
233 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
235 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
237 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
239 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
240 set because already copied when copying the BinEntry's of the header
241 * Test/TestAllReadCompareDicom.cxx : remove warnings
243 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
245 Two problems appear when doing it :
246 - with the gdcmFile : when the GetImageData method is called, the pixels
247 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
248 datas (pixels). And each structure destruct the datas when it's
249 destructed. So we have two destructions for the same datas. To solve it,
250 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
251 datas or not. If it doesn't own datas, then they will not destroyed by
253 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
254 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
255 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
256 create a double destruction of the same DocEntry's. So, to solve it,
257 the TagHT is simply cleared and the DicomDir* elements are destroyed.
258 * TODO : add an entry concerning memory leaks in the DicomDir
260 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
261 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
262 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
265 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
266 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
267 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
268 after it have been deleted
270 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * FIX: src/* fix the doxygen warnings.
272 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
273 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
274 was erroneously defined with a size of 15 instead of 16. [many thanks
275 to Jean Michel Rouet for pointing out this bug].
277 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
278 1. Finish merging JMR patch for writting DICOM from scratch
279 2. Fix -hopefully- bug with MONOCHROME and space vs null character
280 3. Use const ref when possible
281 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
282 5. A few more comments
283 6. CreateUniqueUID can now be called without parameter"
285 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
286 * ENH: Slightly bigger patch:
287 1. Getting toward full integration of JMR patch for writting dicom from scratch
288 2. Update Test to test part of this patch: CreateUniqueUID
289 3. File was not close properly in gdcmDict
290 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
291 5. Use of const ref instead of copy (speed issue)
292 6. Remove temporary (duplicate) string in TranslateToKey
293 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
294 8. Do not repeat virtual in subclasses
295 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
297 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
298 * Apply first patch toward better string comparison when dealing with broken
299 DICOM files. Essentially the string could be padded with a space instead
300 of a null character as defined by standard
302 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
304 because never used... and in the same time, that's remove some memory leaks
306 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmFile.cxx : now delete the PixelConvert instance.
308 * In examples and tests : change the type of image data variables from void*
309 to uint8_t*. Remmove all delete on image data variables
311 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
313 Verify the file pointer value before open the file, and if it's not null,
314 a verbose message is generated.
315 Close correctly the file when the file isn't considered dicom-like. The
316 correctly close is a call to CloseFile.
317 When closing the file pointer, test if its not null to close the file.
318 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
319 file. For an uncompressed image, the copied datas correspond in the least
320 case to the image size (calculated) or the image size specified in the
321 header. A verbose is generated if these two size mismatch
323 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
324 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
325 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
326 break under windows (with msvc6 compilation).
328 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
330 compiling with MSVC6)
332 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * Bugs fix for the Windows build with VC6
334 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
335 needed (only for projects required VTK). If the VTK is included in all
336 projects, there is conflicts with the jpeg lib of vtk when compiling the
337 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
338 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
339 when compiling the gdcm_wrap.cxx file (created by the compilation of the
341 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
342 (like it's already made for the cout use). Otherwise, conflict with the
345 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
348 - comments on the DicomDir::Method related usage added.
349 - now that we use the namespace gdcm, a lot of internal classes do
350 NOT need to be wrapped anymore.
351 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
352 DicomDir::Method) new example added.
354 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 * Improve string manipulation. I now inforce the notion of 'DicomString'
356 A DicomString can contain as many \0 as they want
357 and it is *always* of even length.
358 We only support odd length for very rare case.
359 And in the near future this should be removed.
361 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
362 * /binary_write/ gdcm source. Now even on big endian we are writting
363 little endian. This should -heopfully- fix some tests
365 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
366 * Now the dictionary is compiled into gdcm lib. This is a default
367 behavior, thus any dic file specified is picked before failback to
368 the one comiled into lib
370 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Change internals for gdcmDict. Don't use any 'new' any more.
372 This should definitely solve any leak problem, and we should be
373 as fast as before, as long as don't modify too much the dictionary.
375 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * STYLE: ivars should start with a capital letter.
377 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
378 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
380 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
381 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
382 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
383 new 2004 dictionaries added (thanks to JPR).
384 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
385 * CLEANUP_ROUND (15) for gdcmPixelConvert
386 - RLEFrame::NumberFragments is now of type unsigned int
387 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
388 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
391 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
392 * Initial work in gathering all transfer syntax accessors. clearly
393 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
394 ivars, but only one transfersyntax (class) ivar with equivalent method on
397 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
398 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
399 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
400 discussed (plus I didn't like having a 2000 lines patch not commited)
402 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
403 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
404 * CLEANUP_ROUND (14) for gdcmPixelConvert
405 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
406 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
407 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
409 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
410 anymore and hence avoids storing a copy of PixelConvert::Decompressed
411 into File::Pixel_Data.
413 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
414 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
415 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
416 * CLEANUP_ROUND (13) for gdcmPixelConvert
417 Substituted File::ParsePixelData() with PixelConvert::Print() new
419 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
420 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
421 method to those classes.
422 - src/gdcmFile.[cxx|h]:
423 -- Added a ::Print() method.
424 -- PixelConverter is now a reference instead of a member.
425 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
426 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
428 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
430 collaboration diagram and inheritance diagram should be generated with
432 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
433 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
434 pointlessly wrapped (see
435 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
436 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
437 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
438 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
439 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
440 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
441 -- File::Initialise: PixelConverter setup moved away to
442 PixelConverter::GrabInformationsFromHeader()
443 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
444 interpretation moved away to PixelConverter::BuildRGBImage()
446 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
448 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
450 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
451 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
452 displayed on Win32 when a brutal abort() occurs (because of uncatched
453 exception). See TODO new entry of this commit for more on this.
454 * TODO added new entry.
455 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
456 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
457 - HandleColor is no longer called from gdcmFile.cxx
458 - gdcmPixelConvert.cxx clean up on method arguments and internal
459 variable names for semantical coherence.
461 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
462 * Finished lossless transition, not only do we now read all lossless jpeg
463 images, without the need of the Cornwell lib, but we do read them properly now
464 * To reduce code (well to avoid code duplication), I defined a common place
465 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
466 redefine symbols. This is not prefect but this the best solution I found for a
467 compilation time jpeg option.
469 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
470 * Update jpeg ijg lib to support lossless jpeg implementation
471 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
473 * Also added a special copyright for dcmtk since we use their bugfixes.
476 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
478 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
479 matters, as stated in warning note at begining of %include section).
480 * src/gdcmDicomDir*.[cxx|h]: coding style
481 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
482 * src/gdcmJpeg8.cxx: doxygen fix.
483 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
484 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
485 from File:: to PixelConvert::.
487 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
489 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
490 - more code moved away from File:: to PixelConvert::
491 - fat setup of PixelConverter set in place in File::Initialise.
493 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
494 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
495 namespace at the file system level. So now you should convert your examples
497 gdcmHeader -> gdcm::Header
498 It would be nice if people keep in mind to no open the namespace, since it
499 allows compilation on broken plateform which were defining common symbol in
500 the standart namespace (like LP, Unknown ...)
502 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
503 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
504 The JPEG fragments are now parsed at the same stage than the RLE
505 information. All code related to JPEG is now in gdcmPixelConvert:
506 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
507 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
508 export a gdcmFile:: method. Those are simply global functions
509 (for the time being this is better than having them attach to
510 either gdcmFile:: or gdcmPixelConvert::).
511 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
512 and stores the result in a gdcmJPEGFragmentsInfo.
513 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
514 code (among other stuff) moved away from gdcmFile:; to
517 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
518 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
519 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
520 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
521 clean up of RLE related code.
522 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
523 - src/gdcmRLE.cxx removed
524 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
525 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
526 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
527 * CLEANUP_ROUND (9) for gdcmPixelConvert
528 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
529 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
530 away from gdcmFile:: to gdcmPixelConvert::.
532 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
534 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
535 This is because Parse7Fe0 used to parse the pixels to compute the
536 length. This task was passed over to FindDocEntryLengthOB() a long
537 time ago, EXCEPT I had forgotten the OW case...
538 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
539 we just recylce the code for parsing RLE fragments and computing
541 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
542 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
543 with the retired Parse7Fe0().
544 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
545 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
547 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
549 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
550 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
551 - src/CMakeLists.txt: alphabetic order reodering + new entries.
552 * CLEANUP_ROUND (4) for gdcmPixelConvert
553 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
554 to return an unused length.
556 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
557 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
558 this should be cleanner from the plane view. The iostream are erally a pain
559 to use to do simple stuff.
561 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
562 * Redo the compilation of the ijg jpeg library. Now only one source is
563 necesseray. No need to rename file by hand what so ever. CMake handle the
564 copying of the file within different directory, configure header file to
565 modify some symbol. The only addition made to ijg wasd a mangle table so
566 that symbol are different wether we are within 8bits or 12bits.
568 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * Added documentation of vtkgdcmReader on Website:
570 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
571 with it's binary name).
572 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
573 the Website to be more complete.
574 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
575 doxygenated documentation.
576 - Doc/DoxyVtkGdcmReaderExamples.txt added
577 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
578 DoxyVtkGdmReaderExamples.html )
579 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
580 * CLEANUP_ROUND (3) for gdcmPixelConvert
581 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
583 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * CLEANUP_ROUND (2) for gdcmPixelConvert
585 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
587 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * CLEANUP_ROUND for gdcmPixelConvert:
589 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
590 - src/gdcmPixelStuff[h|cxx] removed
591 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
592 - src/CMakeLists.txt changed accordingly
594 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
595 gdcmVersion.py moved to newly created ATTIC related
596 gdcmPython/SetupOldies/ directory.
597 * Autotools clean up:
598 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
599 - autogen.sh configure.in acinclude.m4 python.m4 removed
601 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * src/*.cxx *.h Reference to License.htm fixed to License.html.
603 * Doc/CMakeLists.txt, doxygen.config.in: fix.
604 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
606 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
607 * TODO updated with Mathieu suggestions. I proposed a template for
608 describing TODO entries and used it for new entries.
609 * Added Doc/Website/CodingStyle.html, Developpers.html,
610 DeveloppersPython.html, GdcmDataCvs.html and
611 DownloadVersion0_1.html, DownloadVersion0_3.html.
612 * Some Doc/*.txt Doxygen files (which do not really concern the
613 documentation itself, but the website) moved to html and
614 placed in directory Doc/Website:
615 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
616 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
617 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
618 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
619 * CMakeLists.txt changed accordingly.
620 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
621 DeveloppersPython.html
622 * INSTALL nows refers to Doc/Website/Installation.html
624 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * Added Doc/Website directory, that contains a first raw version
628 2004-09-23 Jean-Pierre Roux
629 * FIX In order not to be poluted any longer by casting problems,
630 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
631 we can now delete[] it safely
632 * VoidArea is now called BinArea (less confusing name),
633 and all the methods called ...VoidArea... are now ... BinArea...
634 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
636 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
638 clear) TagHT, which is an inherited member of gdcmElementSet. It is
639 up to the destructor of gdcmElementSet to clean up TagHt and it's
642 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * Test/CMakeLists.txt: update to follow gdcmData renamings.
644 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
646 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * ENH: added some utility method that builds a flat dictionnary
648 holding all the Dicom entries contained in the recursive structure
649 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
651 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
652 BuildFlatHashTable() that build a flat dictionary.
653 - src/gdcmElementSet.h: added a new private GetTag() accessor.
654 gdcmDocument is now a friend of gdcmElementSet.
655 - src/gdcmElementSet.cxx: clean up.
656 - Example/FlatHashTablePrint.cxx added.
657 - Example/CmakeLists.txt changed accordingly
659 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
661 moved away from gdcmDocEntrySet (since this class is an abstract class
662 acting like an interface). SQDepthLevel and BaseTagKey are now
664 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
665 and associated accessors. Doxygenation of the class.
666 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
668 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
669 Use SQDepthLevel accessor instead. ::Print() adapted.
670 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
671 - src/gdcmDocument.cxx changed accordingly.
673 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
674 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
675 - The following is the doxygen comment of the typedef declaration
676 of gdcmagKey in src/gdcmCommon.h:
677 gdcmTagKey is made to old an "universal" (as in URL, Universal
678 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
679 A dicom tag allways has a group and an element, but a set of tags
680 embeded in various (optionally nested) sequences and sharing
681 the same group and element all share the same (group, element)
682 "identifier". Hence the (group, element) cannot be used as an
683 identifier (in gdcm we shall refer to a "TagKey") of a tag.
684 In order to construct a proper tag identifier (i.e. a key) we
685 consider the following definition of a TagKey:
686 - let Group, Element be the string representation of the
687 group and element dicom tag members,
688 - let ItemNumber be the string representation of the integer
689 index of the considered item number of a sequence,
690 Let the key of a tag embeded in a sequence, noted SeqTag, be
692 /ItemNumber#Group|Element
693 where "/", "#" and "|" are characters acting as separators.
694 Then the general form of a gdcmTagKey is given by:
695 Group|Element<SeqTag>
696 where <SeqTag> means NO or many instances of SeqTag.
697 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
700 but the gdcmTagKey of a tag "embeded" is the first item of
701 a sequence, itself nested in the third item of a sequence is the
703 0004|1220/2#0008|0082/0#0008|0090
704 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
705 order to hold the new sequence compatible key. Previously, the
706 GetKey() method would look in the underlying gdcmDictEntry.
707 - src/gdcmDocEntry.cxx:
708 -- constructor now copies the underlying DictEntry key, in the local
710 -- ::Print: displays the member Key, instead of the (group, element).
711 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
712 - src/gdcmDocEntrySet.h:xi
713 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
714 -- now has a new BaseTagKey member.
716 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
717 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
719 This poses the problem with the semantics of the following lines
720 LoadEntryVoidArea(0x0028,0x1201); // R LUT
721 LoadEntryVoidArea(0x0028,0x1202); // G LUT
722 LoadEntryVoidArea(0x0028,0x1203); // B LUT
723 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
724 to the long FIXME note for what the problem is. Nevertheless in
725 order to get things working the dicom dictionary was altered !
726 Please fix things urgently...
727 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
728 information), see above note on moving the member VoidArea. Nevertheless
729 the following entries previously correctly set as US are now inproperly
731 0028 1201 OW IMG Red Palette Color Lookup Table Data
732 0028 1202 OW IMG Green Palette Color Lookup Table Data
733 0028 1203 OW IMG Blue Palette Color Lookup Table Data
734 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
735 of gdcmDocEntry moved to gdcmSeqEntry.
736 * src/gdcmSeqEntry.cxx: STYLE.
738 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
739 * Test/TestAllEntryVerify.cxx minor fix and added comments.
741 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
742 * gdcmPython/testSuite.py: all the test suite in python is now moved
743 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
744 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
745 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
747 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
749 to avoid inclusion recursion until STL is reached.
750 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
751 mecanism. errno.h is not included in gdcm anymore.
752 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
753 (gdcmFormatError now inherits from gdcmFormatUnexpected).
755 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
756 gdcmData/TestAllEntryVerifyReference.txt
757 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
758 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
759 exception_on_error parameter.
760 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
761 - vtk/vtkGdcmReader.cxx changed accordingly,
762 - Example/*.cxx and Test/*.cxx changed accordingly.
764 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
766 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
767 enable_sequences removed from gdcmHeader constructor and dependencies.
768 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
769 * gdcmPython/demo/PrintHeader.py: dummy fix.
770 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
771 skip_shadow removed from gdcmHeader constructor and dependencies.
772 * Example/*.cxx and Test/*.cxx changed accordingly.
774 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
776 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
778 2004-07-21 Jean-Pierre Roux
779 * FIX Now, Parsing and Printing a DICOMDIR do work!
780 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
782 2004-07-20 Jean-Pierre Roux
783 * FIX Some brain damaged headers have Zero-Lenght fields
784 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
786 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
787 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
788 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
789 variable (instance of gdcmDebug) by a definition macro, and the instance
790 is now in static in the gdcmDebug class
791 * src/gdcmSQItem.h : (FIXME) remove an undefined method
792 * Test/PrintAllDocument.cxx : bug fix in the result of the test
794 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
795 * WARNING: ctest now depends more tightly on gdcmData. You should
796 check out gdcmData properly for things to run smoothly...
797 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
798 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
799 we need the pixels not be loaded in order to use the ValEntry
800 that displays position and size).
801 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
802 This is a C++ based equivalent of gdcmPython/testSuite.py that should
803 be deprecated. If you have any doubts about the advantages of a
804 modern scripting language (read Python) versus grass root C++ (i.e.
805 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
806 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
807 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
808 Anyhow, consider documenting the gdcmData images in
809 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
811 * Test/CMakeLists.txt:
812 - now uses TestAllEntryVerify.cxx
813 - specific comments on oldACR00001.ima (now renamed in gdcmData
814 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
815 gdcmData/TestAllEntryVerifyReference.txt
818 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/*.[h|cxx] : typedef clean up
820 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
821 - TagKey renamed to gdcmTagKey (for external usage)
822 - VRKey renamed to gdcmVRKey (for external usage)
823 - removal of typedef duplication.
824 - Removed all unecessary inline keyword from class inline definitions.
825 - Some method|function(void) declarations replaced with method|function().
826 * src/jpeg/libijg12/jdhuff12.c:
827 - printf polluting ctest removed.
828 - TAB removal for comminting
830 - TestAllReadCompareDicom.cxx: added a test that compares all the
831 images in gdcmDataImages.h with corresponding images in
832 gdcmData/BaselineDicom/. When baseline images are not present
833 this test creates them.
834 Note: we need to validate each reference image, but before that
835 I'd like to rename them with a more explicit name...
836 - CMakeLists.txt: changed accordingly.
837 * Example/*.cxx: examples now only include gdcm.h (as opposed to
838 including each header needed).
840 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
841 * Test/*.cxx and Example/*.cxx: moved some examples away from the
842 test suite to the Example directory. Are concerned:
847 - TestWriteSimple.cxx
848 * Test/CMakeLists.txt: added some comments on reasons for black listing
849 image gdcmData/oldACR00001.ima
851 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * Test/CmakeList.txt: removed the following from black list (to be coherent
853 with removal from gdcmData):
854 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
855 - gdcm-MR-PHILIPS-16.dcm
857 Added the following because after last cvs update, they cause
858 ctest -R TestReadWriteReadCompare
860 - gdcm-MR-SIEMENS-16-1.acr
862 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
863 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
864 new comments in this file) we temporarily (sigh) move to a weaker
866 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
867 we don't need to black list the following images anymore:
868 - 8BitsUncompressedColor.dcm
870 - US-PAL-8-10x-echo.dcm
871 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
872 fixes and the beautified code ;-)
873 This fixes the bug introduced in version 1.42 (when beautifying)
874 that made the parsing of 8BitsRunLengthColor.dcm unproper.
875 Note: ctest was blind to this bug (this means we need to still
876 improve the test suite). The bug could be detected by using
877 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
879 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
880 and by displaying the (garbage) produced file temp.XDCM...
882 2004-06-29 Jean-Pierre Roux
883 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
884 - replace by uggly but working old code :-(
885 A lot of things should be OK again.
886 It's really urgent to have a test suite that *tests*,
887 to prevent Frog's beautifying sessions to break all the stuff
888 (twice, withing a fortnigh ...)
890 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
892 redundancy) to added Test/TestReadWriteReadCompare.cxx
893 * Test/CmakeList.txt: because the compare test of
894 Test/TestReadWriteReadCompare.cxx fails, the following images are
895 black listed: - 8BitsUncompressedColor.dcm
897 - US-PAL-8-10x-echo.dcm
898 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
899 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
900 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
901 and ad-hoc kludge. This kludge is now removed, and on encountering
902 such an image (OB field brain damaged) we set errno. Then in
903 ::FindDocLength() we "fix" the length as being ALL what remains
904 in the file (until EOF). We then proceed, hoping for the best...
905 This fixes a SegFault in ShowDicom when trying to write such an
907 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
908 (because TestWriteRead breaks on it, after a non conformal commit?).
909 ctest now runs properly, except for MakeDicomDir (which was allways
910 broken) and the Python related stuff (still not fixed).
912 2004-06-24 Jean-Pierre Roux
913 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
914 FIX : Test/TestReadWrite now iterates on all the file names
915 (instead of infinite loop)
916 ENH : Test/TestWriteRead now iterates on all the file names
918 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
919 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
921 2004-06-24 Jean-Pierre Roux
922 FIX : - now Write drops LUT Descriptors and LUTs (if any)
923 when SamplesPerPixel =3
924 - now Write is no longer confused by
925 'BitsAllocated = 12" and 'BitsStored=12"
926 - "UN" value representation Elements are now written correctly
927 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
928 ENH : - now gdcmHeader has its own Write methods
929 (in order to split the job that has not to be done
932 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
934 loop on the same image until memory went out.
935 Note: this means we still have gobs of memory loss in PrintDocument
936 * src/gdcmDocument.cxx: fixes problem on parsing on file
937 gdcmData/16BitsJpegLosslessGrayScale.dcm.
939 2004-06-24 Jean-Pierre Roux
940 FIX : Write - All the Sequences and Sequence Item are now written
941 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
942 is added a the end, when necessary.
943 - A lot of brain-damaged images, that were read correctly are
944 now written correctly
945 - length compatible BinEntry are now loaded correctly
946 (even for odd groups)
947 Note : only Explicit Value Representation was checked.
948 (question : is implicit VR really necessary for gdcm ?)
950 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * DEVELOPPER: added a proposition of coding style.
952 * src/gdcmDocEntry.h: removed every inline declaration (for test of
955 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
957 Use the gdcmDocEntry::Print() and Write() instead.
958 * src/gdcmDocument.cxx: bug fix.
960 2004-06-22 Jean-Pierre Roux
961 FIX : gdcmDocument.cxx
962 - Now we do recognize the JpegLossLess format (there was a misstyping in
963 code 'beautyfication' :-(
964 - Now we automaticaticaly load the Luts, if any
966 2004-06-22 Jean-Pierre Roux
967 In order : to write Sequences, whatever their imbrication level,
968 : to allow user to create his own Sequences
969 a lot of modif where necessary (adding, moving, or virtualising methods)
971 WARNING : save your own sources *before* cvs up !
974 ADD virtual void Write(FILE *fp, FileType filetype);
977 ADD virtual void Write(FILE *fp, FileType filetype);
978 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
981 ADD virtual void Write (FILE *fp, FileType filetype)=0;
982 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
983 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
984 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
985 ADD std::string GetEntryByName(TagName name);
986 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
988 std::string vr = "unkn",
989 std::string fourth = "unkn",
990 std::string name = "unkn");
991 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
992 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
993 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
994 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
995 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
996 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
997 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
998 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1001 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1002 ADD virtual std::string GetEntryByName (TagName tagName);
1003 ADD virtual std::string GetEntryVRByName (TagName tagName);
1004 REM virtual bool Write(FILE *, FileType);
1005 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1006 FILE *_fp, FileType type);
1007 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1008 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1009 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1010 REM virtual std::string GetEntryByName (std::string tagName);
1011 REM virtual std::string GetEntryVRByName (std::string tagName);
1012 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1013 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1014 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1016 std::string vr = "unkn",
1017 std::string fourth = "unkn",
1018 std::string name = "unkn");
1019 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1020 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1021 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1022 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1025 ADD virtual void Write(FILE *fp, FileType filetype);
1028 ADD virtual void Write(FILE *fp,FileType filetype);
1031 ADD virtual void Write(FILE *fp, FileType filetype);
1032 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1033 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1034 REM std::string GetEntryByName(TagName name);
1037 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1039 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1040 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1041 The default constructor invoked by the line
1042 gdcmHeader *f1 = new gdcmHeader( header );
1043 was gdcmHeader::gdcmHeader(bool) instead of the expected
1044 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1045 Hence the parsing wasn't executed... See also below.
1046 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1047 as explicit constructor didn't do the trick to fix the above problem.
1048 Could anyone explain why ?
1049 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1050 properly calls gdcmValEntry::Print() (that was weed out from
1051 code related to gdcmBinEntry).
1053 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * In order to fix memory leaks:
1055 - Test/TestWriteSimple.cxx: added cleaning of free store through
1057 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1058 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1059 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1060 (through the call to ::AddDicomDirMeta()) or the destructor
1061 would crash when deleting uninitialized ::metaElems].
1062 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1063 - src/gdcmDocument.cxx:
1064 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1065 from dynamic stores.
1066 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1067 was causing memory leaks.
1068 - src/gdcmSQItem.cxx:
1069 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1070 cleanly handled with polymophism: sorry but my milage is low).
1071 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1072 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1073 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1074 This avoids SegFaulting.
1075 - src/gdcmSQItem.h: coding style.
1077 - Test/TestWriteSimple still severely sucks. The output image content
1078 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1079 damaged when displayed with vtkgdcmViewer.
1080 - on memory leaks: TestWriteSimple leaks really less (see entry
1081 of 2004-06-18 in Changelog file for the call to valgrind).
1082 - on segfaults: ctest now passes all the tests but one (no more
1084 * Erroneous leading white fix:
1085 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1086 white[s] (as opposed to from >> xxx, that removes it [them].
1087 - src/gdcmTS.cxx: ditto.
1088 - gdcmPython/testSuite.py: dirty related kludge removed.
1089 * src/*: remaining references to gdcmParser removed.
1090 * src/*[cxx|h]: added copy[way]left header.
1093 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * In order to fix writing of dicom files:
1095 - Test/TestWriteSimple.cxx: a simpler example of writing.
1096 - Test/CMakeLists.txt changed accordingly.
1097 - src/gdcmDocument.cxx:
1098 -- The destructor now recursilvely removes potential sequences.
1099 -- Bug fix in ::IsJPEG2000()
1100 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1101 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1103 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1104 to only declared) and build on top of
1105 ::GetDocEntryByNumber(guint16, guint16).
1106 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1107 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1108 for usage in destructor and treatement of promotion in
1109 ::ReplaceOrCreateByNumber().
1110 - src/gdcmSQItem.cxx: destructor should better handle his job.
1111 Test/TestWriteSimple now runs (or at least it DOES something).
1112 * We can now start hutting memory links. A good starting point is:
1113 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1114 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1115 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1117 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * Valgrind note: after Mathieu Malaterre teached me how to read
1119 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1121 Using gcc, you can force the STL to use malloc and to free memory as
1122 soon as possible by globally disabling memory caching.
1123 With 3.2.2 and later, you should export the environment variable
1124 GLIBCPP_FORCE_NEW before running your program.
1125 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1126 simply vanish (it is still not clear to me, whether this means that
1127 STL std::string leaks or if valgrind believes it leaks...).
1128 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1129 running bin/gdcmTests makeDicomDir):
1130 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1131 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1133 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1134 SegFaulting (I drowned in DicomDir related code when trying to
1135 understand why the list is empty...).
1136 * src/gdcmDocument.h: first BSD license header try.
1137 * Doc/License.txt added.
1139 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * src/gdcmDocument.[h|cxx]:
1141 - Clean up of the Transfer related predicates. They are now all based
1142 on new method isGivenTransferSyntax, that (should) handle properly
1143 the padding problem.
1144 - general clean up, simplification, and coding style.
1145 - Specific clean up of Parse7FE0() (umproperly named actually).
1146 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1148 2004-06-14 Jean-Pierre Roux
1150 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1151 - fix the display of SQItem ordinal number
1152 - add the GetSQItemByOrdinalNumber method
1153 - remove some useless never written private methods
1155 2004-06-14 Jean-Pierre Roux
1157 - adding a constructor taking a gdcmDocEntry as an input param
1158 - ReplaceOrCreateByNumber now returns :
1159 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1160 a gdcmValEntry * if a string value is passed as a param
1162 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1163 according to the param type (no longer sets a gdcmDocEntry)
1164 - GetValEntryByNumber, GetBinEntryByNumber added
1165 - NewValEntryByNumber and NewBinEntryByNumber added
1167 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1169 - GetSQItemNumber and SetSQItemNumber added, to provide
1170 a (relative) Item identier inside a given Sequence
1171 \warning : some pb remaining around this number
1173 - AddEntry now takes the Item Number as a param
1175 - adding a constructor taking a gdcmDocEntry as an input param
1177 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1178 * Memory leak hunt with the following command:
1179 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1180 --show-reachable=yes gdcmTests PrintDocument
1181 It looks like many (all?) leaks are due to the STL (or a bad usage
1182 of the STL. The lines producing the leaks now have a comment with
1183 a "MEMORY LEAK" tag: you can retrieve them with
1184 grep "MEMORY LEAK" src/*
1185 Here are two typical examples which I can't help fixing:
1190 char * test = "babo";
1191 name = test; //// <--- valgrind detects 960 bytes lost in
1192 //// call to std::string::operator=(char const*)
1193 name.clear(); //// Doesn't help !
1201 std::cout << "Type a bunch of characters followed by RETURN: ";
1202 getline(std::cin, line); //// <--- valgrind dectects a loss
1203 //// of 1320 bytes in call to
1204 /// std::basic_istream<>& std::getline<>
1210 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1211 * src/gdcmHeader.[cxx|h]:
1212 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1213 and related, moved away to gdcmDocument.
1214 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1215 the corresponding protected accessors of inherited class
1216 gdcmDocument, removed ! As a consequence gdcmFile had to be
1217 declared friend of class gdcmDocument (see below).
1218 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1219 - Clean up of undefined or unused methods.
1220 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1221 account the changes to gdcmHeader.h).
1222 * src/gdcmDocument.h:
1223 - gdcmFile is now a friend class (in order to take into account the
1224 changes to gdcmHeader.h).
1225 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1226 (see changes to gdcmHeader.h).
1227 - Accessors (reading on the form GetEntry*) are now public.
1228 - Clean up of undefined or unused methods.
1229 * src/gdcmDocument.cxx:
1230 - adaptation to changes to gdcmDocument.h
1231 - ::OpenFile now writes a verbose message when file cannot be opened.
1232 - some std::string properly set to VRKey
1233 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1234 references to gdcmDocument.
1235 * Test/TestFindTags.cxx: changed accordingly to above changes.
1236 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1237 cvs repository gdcmData.
1239 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1240 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1241 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1242 conflicts with gdcmValEntry::voidArea.
1243 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1244 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1245 Value representation between StringRepresentable and BinaryRepresentable.
1246 * src/gdcmDocument.cxx:
1247 - method ParseDES: proper indentation restored and usage of
1248 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1249 - method LoadDocEntry: the fingerprint left in the SetValue() of
1250 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1251 removed. Reverting to previous code segment with the proper
1252 dynamic_cast< gdcmValEntry* >.
1253 Note: this was (partially) breaking the python test suite
1254 (gdcmPython/testSuite.py) that made usage of the above
1255 fingerprint to check presence of "Pixel Data".
1256 * src/gdcmDocEntry.h: coding style.
1257 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1258 now taken into account.
1259 * gdcmPython/gdcm.i: adaptation to the new internal representation
1260 of gdcm (exit gdcmParser, hello gdcmDocument).
1261 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1263 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1264 anymore, but instead prints the loaded Python dictionary.
1265 * .... alas, the python testSuite is still broken.
1267 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1268 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1270 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1271 * src/gdcmUtil.h : export methods
1273 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1274 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1276 * Initial addition of automatic python testing
1277 * Initial addition of automatic image comparison
1279 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1280 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1281 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1283 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1284 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1285 * Test/ShowDicom.cxx : bug fix for msvc compilation
1286 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1288 2004-05-04 Jean-Pierre Roux
1289 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1290 new concepts (and new classes) :
1291 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1292 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1293 - Sequence Doc Entries (gdcmSeqEntries)
1294 a Sequence is composed of Items.
1295 Each item is a set of Doc Entries (this is recursive)
1296 The non uniqueness of the 'Dicom tag' is due to this recursivity
1297 (never taken into account)
1298 Our unability to add a new 'entry' in the header
1299 at the proper location (neither in the H-Table (map or multimap),
1300 nor in the Chained List is also due to this recursivity.
1301 Don't try, right now, to use/modify/compile these new sources :
1302 nothing is finished.
1303 We just commit all the stuff, 'as is', in order not to loose it.
1305 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1306 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1308 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1309 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1310 file prefix (SetFilePrefix)
1312 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * Add a new test: ShowDicom, for now this is just the c++ version of
1314 checkRead.sh, later it will be able to compare the image read against a
1316 * Replace the DEBUG on the stack with a global entry in cmake interface:
1317 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1319 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * Add an example subdir, with a real example on how to read + write a
1323 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1324 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1325 * Doc/CMakeLists.txt: the main page is now properly differentiated
1326 between the developper and user version.
1327 * Doc/doxygen.config.in: dropped search related obsolete flags
1328 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1330 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1331 * DEVELOPPER: added some helpfull comments for compile/test/install
1334 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1335 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1336 src directory, now generated in the build dir.
1337 2. Tests as mentionned smarter
1339 4. Add a new method in gdcmDict that return the PubDict by name
1340 this is interesting for 3rd party lib like ITK,
1341 where we could set the institution name / patient name...
1343 * ENH: 1. Now the test suite is working for real
1344 2. All binaries are now output in the gdcm-bin directory
1345 (this was not true before)
1347 2004-04-28 Jean-Pierre Roux
1348 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1349 SeQuence indented printing of Dicom Header.
1350 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1351 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1352 Computation of SQDepthLevel is now part of gdcmHeader constructor
1353 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1354 tree-like structure of a Dicom Header.
1355 * FIX Test code cleaning
1357 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1358 * ENH: Adding automatic testing
1359 1. Need a DartConfig.cmake to submit to public
1360 2. Add a test driver gdcmTest.cxx
1361 3. gdcmTestMain, an helper for the main test driver gdcmTest
1362 4. Files in Test don't have a main anymore, this becomes interesting
1363 when we add more and more tests, thus dsw don't have to load
1365 * ENH: Adding a GDCM_DATA_ROOT for testing
1366 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1367 one file instead of seven + some small cleanup
1369 2004-04-22 Jean-Pierre Roux
1370 * ENH Minor changes to the Print() methods.
1371 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1372 Header printing. Example given with :
1373 > PrintHeader fileName 2 new
1374 (SQ based tree-like structure still to be done for the Header ...)
1376 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1377 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1378 1. I have added some unsigned where needed
1379 2. Some function parameter not used -> (void)
1380 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1381 4. g++ don't like character '\' in comment
1382 5. #define jpeg_create_decompress jCreaDecompress
1383 this really need to be fixed
1384 6. virtualize destructor of gdcmObject ... leakage
1385 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1386 this also really need to be fixed
1387 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1388 remove compression file
1389 (as we only do decompression, right ?)
1390 * ENH: Change malloc/calloc/free with c++ equivalent
1392 2004-04-21 Jean-Pierre Roux
1393 * FIX gdcmHeaderHelper::GetXSpacing
1394 when a single value is found (bug ?), xpacing is now
1395 defaulted to yspacing
1397 2004-04-19 Jean-Pierre Roux
1398 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1399 * ENH add parameters :
1400 bool exception_on_error = false,
1401 bool enable_sequences = false,
1402 bool ignore_shadow = false
1403 to the gdcmFile constructors to be full gdcmParser compliant
1404 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1405 to allow reading of PAPYRUS 3.0 files
1407 2004-04-06 Jean-Pierre Roux
1408 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1410 2004-04-02 Jean-Pierre Roux
1411 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1412 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1413 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1415 2004-03-30 Jean-Pierre Roux
1416 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1417 for ACR file, written out as DICOM files (hope so...)
1419 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1420 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1421 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1422 moved to base class gdcmParser and only the specialisation is kept
1424 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1425 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1426 already does the job.
1427 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1428 (to be consistent with gdcmParser::WriteEntries).
1430 2004-03-30 Benoit Regrain
1431 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1432 upate of the object's instance. It's passed to 2 in the unfavorable
1433 case : one in the ExecuteInformation, one in the ExecuteData
1435 2004-03-29 Jean-Pierre Roux
1436 * ENH : Check on file type to be written moved
1437 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1438 * FIX : gdcmObject::ResetBoundaries now stops properly
1439 when end-of-list is reached
1440 : gdcmVersion modified (as Benoit Regrain asked)
1442 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1444 * src/gdcmUtil.cxx: added forgotten iostream include.
1445 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1446 equivalent to ExplicitVR in existing code).
1448 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1449 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1450 now contains all the gdcmGlobal related code.
1451 * minor coding style and doxygenation changes.
1453 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1454 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1455 now contains all the Debug related code.
1456 * minor clean-up of includes in src/*.cxx
1457 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1458 CreateCleanString) removed.
1459 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1460 * Doc/DoxyMainPageUser.txt added.
1461 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1462 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1463 src/gdcmDirList.cxx)
1465 2004-03-24 Jean-Pierre Roux
1466 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1468 2004-03-23 Jean-Pierre Roux
1469 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1470 big endian made volumes
1471 * ENH Now gdcmParser constructor and destructor are protected to forbid
1472 end user to instanciate class gdcmParser
1473 (only gdcmHeader and gdcmDicomDir are meaningfull)
1475 2004-03-22 Benoit Regrain
1476 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1477 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1478 gdcmSerie to gdcmDicomDirSerie
1480 2004-03-19 Jean-Pierre Roux
1481 * ENH Now the tree-like structure describing a DICOMDIR comming from
1482 an already existing DICOMDIR file is consistent with
1483 the home-made tree-like structure build ex-nihilo
1484 or build from the files held (recursively) in a Directory
1485 functions gdcmDicomDir::CheckBoundaries()
1486 gdcmObject::SetBoundaries() added
1488 2004-03-17 Jean-Pierre Roux
1489 * REM (Eric Boix bug) : removal of meaningless
1490 gdcmDicomDirImage::NewImage function.
1491 * FIX now file names and directory name are written properly in the
1493 * FIX now gdcmDicomDir constructor may be call without any trick
1496 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1498 of gdcmDicomDirImage::NewImage as empty function.
1500 2004-02-28 Jean-Pierre Roux
1501 * ENH add gdcmDicomDir:NewPatient
1502 add gdcmDicomDirPatient:NewStudy
1503 add gdcmDicomDirStudy:NewSerie
1504 add gdcmDicomDirSerie:NewImage
1505 to allow making gdcDicomDir object.
1506 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1507 (as opposite to the gdcmHeader chained list)
1509 2004-02-11 Benoit Regrain
1510 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1511 when using from python
1513 2004-02-10 Benoit Regrain
1514 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1515 * FIX : in gdcmDicomDir when the directory is empty
1516 * ENH : add callback and methods to get the progression of dicomDir
1519 2004-02-06 Jean-Pierre Roux
1520 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1521 - GDCM_META added to gdcmDicomDirType
1522 - class gdcmMeta created
1523 * ENH : - A brief summary is now displayed at the beginning of
1524 'testDicomDir' to help disaster magnitude estimation
1525 * REM : Now useless Test/explDICOMDIR.cxx
1527 2004-02-05 Benoit Regrain
1528 * ENH : add methods in gdcmObject to get the hash table or the list of
1530 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1531 * FIX : wrapping python for TagHeaderEntryHT
1533 2004-02-04 Benoit Regrain
1534 * FIX : even length for some strings when writting the dicom dir
1535 * FIX : sort the images in the dicom dir
1536 * FIX : Bug fix for python use of dicom dir
1537 * ADD : a python demo
1539 2004-02-04 Jean-Pierre Roux
1540 * FIX : Final solution (?) for icone embedded images
1541 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1542 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1543 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1544 gdcmData/gdcm-MR-SIEMENS-16.acr1
1545 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1546 to make full checking easier
1548 2004-02-04 Benoit Regrain
1549 * FIX : WriteEntries : coding style & logic in parameters
1550 * FIX : Set the elements to create the DicomDir in a dictionary file
1552 2004-02-03 Benoit Regrain
1553 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1554 * gdcmDicomDir : add the load of directory
1555 * Bug fix and print add-on
1557 2004-02-03 Jean-Pierre Roux
1558 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1559 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1560 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1561 * FIX gdcmParser.cxx : 'group length' elements are now considered
1562 as integers, even for shadow groups, when file is Implicit VR
1564 2004-02-02 Jean-Pierre Roux
1565 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1567 of the last synonym :-(
1568 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1570 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1571 * FIX taking into account the possible 7fe0,0010 multiplicity
1572 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1573 to allow removal of references to 7fe0,0010, to deal with
1574 ACR-NEMA images, when 0028,0200 is meaningfull
1576 2004-01-31 Jean-Pierre Roux
1577 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1578 no longer writes 'Un' on disk
1579 * FIX SQ elements with actual length are now dealt with corectly
1580 * FIX gdcmFile::WriteBase make the difference, for color images, between
1581 the length (for Palette expanded images)
1582 and Raw Length (non expanded image + Palette)
1583 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1584 (that broke Write). Replaced by UL.
1585 Aware user will reload the field if he
1586 thinks it's necesssary
1588 2004-01-30 Jean-Pierre Roux
1589 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1590 when 'dirty Acr' is found, to be compliant with the new
1591 IsReadable() methods.
1593 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1594 (no DOUBLE images in kosher DICOM,
1595 but so usefull for people that miss them ;-)
1597 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1598 DICOMDIR related utilities (not checked as Windoze compliant)
1600 2004-01-28 Jean-Pierre Roux
1601 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1603 2004-01-27 Jean-Pierre Roux
1604 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1605 to allow skipping the shadow elements, to save memory space.
1606 The TRUE value for this param has to be used
1607 with a FALSE value for the 'enable_sequence' param.
1608 ('public elements' may be embedded in 'shadow Sequences')
1609 * gdcmHeader methods now deal with 'embedded icones images' in the header
1610 (even when an 'icone image sequence' is announced by the
1611 element (0x0088,0x0200), but there is NO icone at all ...
1613 * gdcmHeader sometimes Image Location value doesn't follow
1614 the supposed processor endianity (see gdcmData/cr172241.dcm).
1617 * gdcmHeader add the method
1618 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1619 to get *all* the Header Entries with the same tag.
1620 GetHeaderEntrySameName is probabely *useless*
1621 (no meaning : Name is *not* an identifier within the Dictionnary)
1623 2004-01-26 Benoit Regrain
1624 * Bug fix in the print of hexadecimal representations. Remove long fields
1625 in the print and add a third level of print to print them
1627 2004-01-23 Benoit Regrain
1628 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1629 * Bug fix on test suite after remove the strip made on not string fields
1630 * Split the IsReadable method between gdcmParser which test that the file
1631 is dicom and gdcmHeader which test that it's an image file
1633 2004-01-22 Benoit Regrain
1634 * DicomDir : clean code, add methods, set variables in protected or private
1635 * gdcmUtil : bug fix for the clean string method
1637 2004-01-19 Benoit Regrain
1638 * Add the use of shadow dictionaries
1639 * bug fix and coding style
1641 2004-01-19 Benoit Regrain
1642 * src/gdcmFile.cxx : bug fix concerning the close of file
1643 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1644 * Add the update of header entries using the shadow library
1646 2004-01-19 Benoit Regrain
1647 * removal of file gdcmHeader2.cxx
1648 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1649 inheriting from gdcmParser. This split is to prepare the integration
1650 of dicom dir parsing
1651 * bug fix under python
1653 2004-01-16 Jean-Pierre Roux
1654 * REM removal of class gdcmHeaderEntrySet
1655 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1656 * ADD add file gdcmHeader2.cxx
1657 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1659 2004-01-15 Benoit Regrain
1660 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1661 entries created while parsing the header. Thus, they will be destroyed
1662 when the gdcmDictSet will be destroyed
1663 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1666 2004-01-15 Benoit Regrain
1667 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1668 made a fatal error because of the memory release at the end of program.
1669 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1670 some memory and vtk seems to have some problems with that.
1671 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1673 2004-01-14 Benoit Regrain
1674 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1675 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1676 * src/*.[h|cxx] : make changes due to class name changes
1677 * gdcmPython/demo/*.py : bug fix due to method names
1679 2004-01-13 Benoit Regrain
1680 * src/*.[h|cxx] : coding style
1681 * vtk/*.[h|cxx] : coding style
1683 2004-01-13 Benoit Regrain
1684 * gdcmPython/testSuite.py : test the readable flag of file for tests
1685 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1686 It's lied to the stl compilation by MSVC (windows, always windows...)
1687 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1689 2004-01-12 Benoit Regrain
1690 * src/*.h : add comments
1691 * src/gdcmDictSet.h : set the method BuildDictPath in public
1692 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1693 directly setted in the source code
1694 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1697 2004-01-09 Benoit Regrain
1698 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1699 * setup.py : use a reference to gdcmVERSION
1701 2004-01-07 Benoit Regrain
1702 * Modification to compile with the distutils.
1705 2003-12-10 Benoit Regrain
1706 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1707 can use a gdcmHeaderHelper to load datas
1708 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1709 made in the source code
1711 2003-12-10 Benoit Regrain
1712 * Update Windows projects and .cvsignore files
1714 2003-11-12 Jean-Pierre Roux
1715 * ENH gdcmHeader constructor has one more parameter (default value : false)
1716 that allows the user to 'go inside' the SeQuences only
1718 gdcmElValSet:Print takes it into account
1720 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1721 * ENH: Update gdcmPython/CMakeLists
1722 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1723 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1725 2003-11-10 Jean-Pierre Roux
1726 * FIX : gdcmHeader::LoadElements is now based
1727 on the ListTag listElem member,
1728 not longer on the TagElValueHT tagHt member
1729 * ENH : PrintPubElVal shows (temporarily) both results,
1730 with the tagHt member and the listElem member.
1731 (it's easier to 'see' the problems when using Printheader)
1733 * FIX : old private member LgrElem is now splitted into
1734 ReadLength : Length actually found on disk (updated only
1735 if bug fixing is necessary), for internal
1737 UsableLength : Updated by FixFoundLength, to fix a bug
1738 or to allow Parser going on.
1739 Will allow to re-write a kosher header when a SeQuence
1740 with a length (not 0000) is found
1741 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1742 because gdcmElValSet::Add does not update ListElem
1745 2003-11-07 Jean-Pierre Roux
1746 * FIX misstyping in Transfert Syntax name table
1747 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1748 when they have an actual length (not 0000 nor FFFFF)
1749 (Nobody should care of it, but DICOMDIR explorers)
1751 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1754 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * ENH: vtkGdcmReader now supports LUT !
1756 (vtkgdcmViewer for now is not able to use them though)
1758 2003-11-05 Jean-Pierre Roux
1759 * in testSuite.py : new files names for checking the package
1760 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1761 that returns the pixel area size to the *aware* (vtk) user
1762 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1764 2003-11-05 Benoit Regrain
1765 * in testSuite.py : Modify the rules for checking the paths
1766 : Explicit error messages
1767 * in __init__.py : Related modif
1769 2003-11-03 Jean-Pierre Roux
1770 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1771 to be used by aware (vtk) users that want to manage
1772 LUT (and no to turn the PALETTE image into an RGB pixels one)
1773 * GetPixelType now returns 8U for 24 Bits images
1774 (vtkGdcmReader compliant)
1776 2003-10-31 Jean-Pierre Roux
1777 * Removal of *all* gdcmData images and add them again
1778 in order to loose the 'history' of un-anonymised images
1780 2003-10-31 Jean-Pierre Roux
1781 * RMV : removal of useless jBitsInJsample.h
1782 for both 8 and 12 Bits JPEG Lossy Libraries
1784 2003-10-31 Jean-Pierre Roux
1785 * ENH : Add the functions gdcmFile::GetImageDataRaw
1786 gdcmFile::GetImageDataIntoVectorRaw
1787 that act as GetImageData and GetImageDataIntoVector
1788 except the making of an RGB Plane from Gray Plane + LUT
1789 Intended to aware (vtk) users who know how to manage
1792 GetLUTRGBA return a R,G,B,A LUT if any
1793 lgrTotaleRaw gives the 'Raw' length
1794 GetImageDataRaw returns the gray Plane
1795 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1796 (They stay Grey, just like with other Dicom viewers :-(
1798 2003-10-30 Jean-Pierre Roux
1799 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1801 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1803 being coherents dicom files.
1805 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1808 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1809 * ENH: Two steps is necessary to please VC++ compiler...
1810 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1811 * ENH: Add include dir to medcon lib
1812 * FIX: only one function is being exported for now !
1813 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1815 2003-10-29 Jean-Pierre Roux
1816 * adding gdcmHeader::GetLUTRGBA
1817 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1818 --> Mathieu, the modif u're waiting for is not yet committed
1819 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1821 2003-10-27 Jean-Pierre Roux
1822 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1823 00191113.dcm DermaColorLossLess.dcm
1824 MxTwinLossLess.dcm RadBWLossLess.dcm
1825 * ENH: For version prior to vtkImageViewer2 -r 1.19
1826 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1828 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1829 * Removal of ido stuff in CMakeLists.txt
1831 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1832 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1833 * FIX: remove a call to ->Modified ... see comments
1834 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1836 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * FIX: Problem with path for libvtkgdcmPython
1838 * ENH: Try adding a search script for python site-package
1839 * RMV: Remove some file from medcon lib that are not necessary
1840 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1841 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1842 * FIX: More pragma disable fro VC++,
1843 I don't think I break something as it is also disable in VTK/ITK.
1844 But it fasten debug compilation time.
1846 2003-10-23 Jean-Pierre Roux
1847 * gdcm now deals with 16 Bits Run Length Encoded images
1848 (they are compressed as 2 planes images,
1849 one for the high Bytes, the other for low Bytes)
1851 2003-10-22 Jean-Pierre Roux
1852 * Now CheckRead takes into account :
1853 - the bugged 'Leonardo' Siemens images
1854 - the XA images, sent thru the burning VPRO station
1855 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1858 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1859 * FIX: When copying a Makefile.am to CMakeLists.txt
1860 one should remove the '\'
1862 2003-10-22 Jean-Pierre Roux
1863 * in gdcmData adding a bugged 'Leonardo' Siemens image
1864 (wrong lengths in header)
1865 OK with gdcm, KO with the other viewers :-)
1866 * add a GE dlx XA image, thru the VEPRO burning station
1869 2003-10-21 Jean-Pierre Roux
1870 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1871 for a brutal checking of vtkgdcmViewer compliance
1873 2003-10-21 Jean-Pierre Roux
1874 * add the files for 'xmedcon' Jpeg Lossless library
1875 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1877 2003-10-21 Jean-Pierre Roux
1878 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1880 2003-10-21 Jean-Pierre Roux
1881 * garbage Siemens 'Leonardo' images dealt with
1882 (the patch is easy to remove)
1883 * cosmetic changes to avoid warnings
1885 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1887 no need to press 'r' now.
1889 2003-10-20 Jean-Pierre Roux
1890 * upgrade of checkRead.sh checkWrite.sh according
1891 to new Jpeg Lossless decompressor
1892 * add US.3405.1.dcm, a genuine RGB medical file ...
1893 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1894 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1896 2003-10-15 Jean-Pierre Roux
1897 * general anonymisation in gdcmData
1898 * adding the 'color files' from
1899 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1900 * adding some well knowed bugged-header images
1901 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1902 waiting for their inclusion in Python testsuite
1904 2003-10-15 Jean-Pierre Roux
1905 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1906 no longer seg faults when file is not found
1908 2003-10-14 Jean-Pierre Roux
1909 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1912 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * TODO: *.in file to genereate a UseGDCM later
1915 2003-10-14 Jean-Pierre Roux
1916 * Some supposed-to-be Dicom Images have no preamble.
1917 OpenFile takes it into account
1918 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1919 * Missing elements added in dicomV3.dic
1920 (just to be affraid : have a look at
1921 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1922 and do it again next year ;->
1924 2003-10-13 Jean-Pierre Roux
1925 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1926 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1927 But there are NOT. It's fixed !
1929 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1930 * FIX: "jpeglib.h" was not found on VC++
1931 * FIX: vtkgdcm was not being installed
1933 2003-10-10 Jean-Pierre Roux
1934 * ENH : OpenFile closes the file if it *really* doesn't look like
1935 an ACR-NEMA / DICOM one.
1936 * FIX : testWrite no longer writes an empty file if the source file
1937 is not gdcm Readable
1938 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1941 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1942 * FIX: CMake generate now documentation
1943 * ENH: out of source doc build !
1944 * ENH: Generate both user and dev documentation
1945 * ENH: Should work on windows too
1946 * ENH: Only one doxygen config.in file is needed
1947 * FIX: make install should be ok now on ùnix plateform
1948 * FIX: PATH to dictionary was wrong (missing /)
1949 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1951 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1952 * vtkGdcmReader is now able to read rgb dicom file.
1953 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1954 * added a gdcmViewer to vtk test, use mouse to control
1955 window level & window width
1957 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * CMake-ification of gdcm, we have now two build system
1959 * FIX: on cygwin Wsock32 doesn't exist
1960 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1962 2003-10-06 Emanuel Ollart
1963 * FIX : compilation process wad broken.
1964 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1966 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * change gdcmViewer -> vtkgdcmViewer
1968 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1970 2003-10-06 Jean-Pierre Roux
1971 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1972 ( e.g : well known GE images with a wrong elem length,
1973 : Philips MRI Images with a wrong Huffman table)
1974 * still to be done : allow the reading of bugged LEONARDO Siemens images
1976 2003-10-03 Jean-Pierre Roux
1977 * Odd length strings are padded with '\0' (not with spaces,
1978 to remain compliant with already defined strings,
1979 like Transfert Syntax UID and others)
1981 2003-10-03 Jean-Pierre Roux
1982 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1983 to allow displaying RGB images (not only by affim ;-)
1985 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1986 * vtkGdcmReader is now able to read rgb dicom file.
1987 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1989 2003-10-03 Jean-Pierre Roux
1990 * A few nasty patches to allow the reading of a lot of nasty images
1991 ( e.g : well known GE images with a wrong elem length,
1992 : Philips MRI Images with a wrong Huffman table)
1993 * still to be done : allow the reading of bugged LEONARDO Siemens images
1995 2003-10-03 Jean-Pierre Roux
1996 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1998 2003-10-03 Jean-Pierre Roux
1999 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2000 to allow displaying RGB images (not only by affim ;-)
2002 2003-10-03 Jean-Pierre Roux
2003 * gdcmFile::GetImageDataIntoVector now
2004 - deals with MultiFrames MultiFragments Run Length Encoded files
2005 - deals with YcBcR (YBR_FULL) files
2006 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2007 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2009 (no sample found :-(
2011 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2013 Two reasons: - clear things
2014 - third parties acces gdcm through header files, so won't
2015 suffer anymore VC++ complains
2017 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2018 * add argv[1] in testvtkGdcmReader.cxx
2021 2003-09-24 Jean-Pierre Roux
2022 * The lines are now eigthy characters long.for
2023 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2025 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2026 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2027 char* to std::string. Thus, the use of strdup becomes useless. (see
2028 previous commis of Malaterre)
2029 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2030 before the last Malaterre's commit.
2032 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2033 * This commit should fix the Debug building under VC++, the problem
2034 was mainly a mixture of debug and release lib being loaded at startup.
2035 * I also remove a depency to a specific C function: strdup. Because I had
2036 to force the link to msvcrtd (whereas strdup is in libc).
2038 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2039 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2040 located in the gdcmCommon.h file. All use of reference of tha has been
2041 changed to now use the variable GDCM_UNFOUND.
2043 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2045 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2046 Dicom dictionary. The test suite can now be run again. Note:
2047 I'm note very happy with the " (RET)" changes. I believe this
2048 RETAINED comment should be dropped when parsing the dictionary.
2049 - PACKAGER corrected
2051 - AUTHORS updated and now in alphabetical order
2052 * Makefile.am now exports gdcm.dsw for Windoze users.
2054 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * cygwin complains about missing std:: in subdir Test/
2057 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2058 * remove some methods that are now in gdcmHeaderHelper
2060 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * vtkGdcmReader set spacing and origin correctly
2063 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2064 * Fix a few delete/delete[] mismatch
2066 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2068 interpretation to data given by gdcmHeader. For instance there are
2069 heuristics to get informations (look at different places).
2070 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2071 sorting DICOM images based on different strategies.
2072 * modified Makefiles accordingly.
2074 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2075 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2076 when building in debug mode
2077 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2078 src/win32/gdcmdll.dsp
2079 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2081 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2082 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2085 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2086 * src/win32/libgdcmjpeg12.dsp was not dos format
2087 * src/win32/libgdcmjpeg12.dsp :
2088 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2089 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2091 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2092 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2094 * src/gdcmFile.cxx : bug fix in affectation type
2095 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2096 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2097 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2098 symbols... future problem ?
2100 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2101 * src/win32/libgdcmijpeg12.dsp was missing
2102 * modified gdcm.dsw accordingly
2104 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2107 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2108 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2109 commit of JPR (before his hollidays to facilitate our work).
2110 * setup.py : bug fix in code. Modifications made while the last commit
2111 of JPR. The code hasn't been tested before the commit... it's so
2112 useless to make that (for best programmer that is JPR) !!!
2114 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * tagged the current version as Version0_3 (i.e. version 0.3)
2117 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2118 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2119 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2120 * *.dsp : modifications to use new libgdcmijpeg8 library
2121 * setup.py : bug fix on VTKPATH variable
2122 * PACKAGER : adding all concerning windows
2124 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2127 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2128 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2129 test suite reported error.
2130 * PACKAGER file added (describes what a packager must do when
2131 packaging a new release).
2132 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2133 * configure.in: upgraded version number to 0.3.0
2134 * fixing build of rpm (through rpm -ta):
2135 - Doc/Makefile.am exports proper doxygen files
2136 - src/jpeg/libijg8/Makefile.am exports the include files.
2138 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2139 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2140 * src/gdcmHeader.h : formatting code
2142 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2144 We were obtaining error message from vtk. Now, creation of file list
2145 is made in an internal list to prevent this problem.
2146 Bug fix when output is empty.
2147 Bug fix in update of progress value. Previous commit for this was a bad
2149 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2151 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2152 * src/gdcmHeader.h : added method to get the file name
2153 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2154 files. Added method to remove all files on the input
2155 Added FIXME comment concerning the bad parsing of header made by
2156 ExecuteInformation method (in ExecuteData method)
2158 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2160 when using make instal.
2161 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2162 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2164 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2165 * setup.py : adding include dir of jpeg lib to compile all sources
2166 * */Win32/*.dsp : JPR fix for windows compilation
2168 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2169 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2171 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2172 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2174 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * setup.py is again effective on un*x (takes into account the
2176 addon of the jpeg library)
2177 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2178 * Doc/Doxy* updated (includes above enhancements)
2179 * INSTALL now points to web documentation
2181 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * src/gdcmHeader.h doesn't make unnecessary reference to
2184 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2186 * src/gdcm*.[cxx|h] :
2187 - to allow compilation with gcc 3.x
2188 -- clean up of STL usage (added explicit usage of std::)
2189 -- small fixes on exceptions.
2190 Note: linking not tested !
2191 - clean of doxygen comments to avoid warnings at documentation
2193 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2194 dependent convertion).
2196 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2197 * Clean up of previous JPR garbage commit (not even commented in the
2199 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2200 - moved all jpeg related files from src to src/jpeg/libijg8, with
2201 addition/modification of Makefile.am and configure.in.
2202 - the testSuite is still brain damage (not guilty).
2204 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2205 * WrapVTK.py : modifications to get correctly vtk source files to
2207 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2208 (FileName -> Filename)
2210 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * vtk/vtkGdcmReader.[cxx/h]:
2212 - UpdateProgress method should now be effective
2213 - removed the limitation on having only images loaded (as opposed
2215 - when building a stack of images/volume, a lesser number of
2216 gdcmHeader and gdcmFile instances should be used (hopefully
2217 accelerating things).
2218 - when building a stack of images/volumes, files which are not
2219 loadable (wrong path-filename, wrong permissions on existing file,
2220 or file not parsable by gdcm) are replaced with a black image
2221 in the stack (for the caller to notice the problem).
2223 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2226 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2227 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2228 between standard library (std) and vtk library (problems are found
2229 under Windows... thanks Windows !)
2231 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2232 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2234 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2236 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2239 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * When compiling with distutils (see setup.py) the C++ compiler is
2241 called with different flags than the default ones (with automake).
2242 In order to fix all those warning, I compiled gdcm with the command
2243 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2244 and went for warning fixes:
2245 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2246 up from unused variables.
2247 - vtk/vtkGdcmReader.cxx: potential bug fix.
2248 * src/gdcmHeader.h: Doxygen warning cleanup
2250 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2251 * gdcmPython/gdcm.i:
2252 - typemaps correction to take into account the systematic replacement
2253 of "using namespace std" with std:: prefix e.g. std::list,
2254 std::string... (cf changes of 2003-05-21).
2255 - gdcmGlob global variable of type gdcmGlobal (defined in
2256 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2257 exported to Python a as cvar.
2258 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2259 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2260 gdcmDictSet.GetPubDictTagNames() and
2261 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2262 C++ static methods).
2263 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2264 with the above changes.
2266 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2267 * setup.py, manifest.in : bug fix under linux
2269 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2270 * Modification of setup.py to compile vtk part too. Then, we have 2
2271 wrappers which must work with same distutils. For that, we have a
2272 generic distutils in distusiltsWrapping.py ; with :
2273 - build_extWrap class to wrap generically all extensions,
2274 - ExtensionWrap base class for all wrapping extension that contains
2276 - Wrapper interface which wrap sources
2277 + In WrapSwig.py we have extension and wrapper for Swig
2278 + In WrapVTK.py we have extension and wrapper for VTK
2279 * MANIFEST.in : modifications to consider vtk directory and new python
2280 files for compilation
2282 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2283 * Added python wrappers of vtkGdcmReader vtk class (see the
2284 source in vtk/vtkGdcmReader.cxx) :
2285 - vtk/Makefile.am now builds a library
2286 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2287 python library (as opposed to _gdcm.so wich are the python
2288 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2289 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2291 - configure.in has an additional flag --enable-vtk that needs
2292 to be set to enable compilation of vtk related code, that is:
2293 + vtk/vtkGdcmReader.so and
2294 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2295 + gdcmPython/vtkgdcmPython.so (see above)
2296 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2297 be read when compressed or when HighBit + 1 != BitsStored),
2298 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2299 the usage of the python wrapper of vtkGdcmReader vtk class.
2300 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2301 * src/*.[h] all occurences of stl classes are now prefixed with
2302 std::, and all occurences of "using namespace std;" where removed.
2303 This is to avoid pollution of global namespace in included files.
2304 Apparently vtk does not avoid this pitfall: when using both
2305 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2306 collision of various stl members (principally cout...).
2307 * gdcmPython/testSuite.py now cleanly removes temprory generated
2309 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2310 comply with above changes)
2312 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2313 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2314 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2315 vtk data structure (an image Flip was required).
2316 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2317 * cosmetic changes in documentation.
2319 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2320 * src/gdcmHeader.cxx: the constructor no longer exits when an
2321 unexisting file is given as argument.
2322 * The subdirectory Data (containing all the images used for the
2323 test suite) is not part of this repository anymore. A new module
2324 containing those images is now available at
2325 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2326 with the name gdcmData.
2327 All the python scripts (including the package initialisation file
2328 gdcmPython/__init__.py) were adapated to take this change into
2329 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2331 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2332 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2333 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2334 demo of the usage of this class.
2335 Compilation of this vtk part is only done when using the --enable-vtk
2336 at configure (or autogen.sh) stage.
2338 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2339 * More memory link related corrections and documentation fixes.
2341 - maximum info is obtained with a command of the form:
2342 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2343 --show-reachable=yes PrintHeader
2344 - the remaining reachable blocks seem to come from the STL
2345 allocation scheme through the usage of map and list. It looks
2346 like this memory cannot be freed but it is not a memory leak
2347 (in fact further invocation to the STL would recollect the
2348 unused memory allthough it cannot explicitely be freed).
2349 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2350 of displaying an image parsed with gdcm and displayed with VTK.
2351 Note: some images don't seem to work e.g.
2352 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2353 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2354 Allthough this weakens the semantics, it is a ditch attempt to
2355 make gdcm more thread friendly.
2357 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2358 * Memory link hunt (by using valgrind through the command
2359 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2360 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2361 gdcmHeader::_dicom_vr.
2362 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2363 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2365 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2367 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2368 * src/Makefile.am now exports all the necessary include files at
2372 * UpdateGroupLength replaced by new one
2375 * UpdateGroupLength re-written using H-Table
2376 (named UpdateGroupLengthNew untill checks are over)
2378 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2379 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2380 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2382 - gdcmHeader::GetPubElValSet removed.
2383 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2384 UpdateGroupLength, WriteElements, Write.
2385 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2386 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2387 carried the same semantics.
2388 - src/gdcmHeaderIdo.cxx changed accordingly.
2389 - gdcmFile::WriteBase now regroups all the codes from previous
2390 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2391 - enum FileType moved to gdcmCommon.h
2392 * src/gdcmHeader.cxx AddDefault trashed
2393 * gdcmGetXSize added
2394 * getimageDataSize now calls gdcmGetXSize
2395 * Test/*.cxx changed to agree with above changes
2397 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2399 (to avoid double call by end user).
2400 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2401 by end user, since gdcmHeader::gdcmHeader now handles it.
2403 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * gdcm/Doc many doxygen changes:
2405 - Doxyfile now has two different versions, DoxyfileUsers that generates
2406 the html.users end users oriented documentation and
2407 DoxyfileDeveloppers that generates the html.developper developper
2408 oriented documentation.
2409 - README changed accordingly
2410 - requirement.txt removed (old design info moved to TODO).
2411 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2412 DoxyMainPage.txt, DoxyPython.txt provide more information.
2413 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2414 be updated by simply regenerating the docs with doxygen and copying
2415 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2416 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2417 all the tests in the form "if (<map>.count() >1)" were removed.
2418 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2419 ill-formed documentation sections.
2420 * src/gdcmHeader.cxx: ditto
2422 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * setup.py fixed for un*x (needed macro for stdint.h)
2424 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2425 un*ces with sh-utils test utility.
2426 * gdcmPython/demo/test.py renamed to PrintHeader.py
2427 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2428 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2429 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2430 * src/gdcm*.cxx JPR's bad inclusion fixed.
2432 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2434 * gdcmPython/demo/test.py changed accordingly.
2436 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * gdcmPython/Makefile.am fixed linking against libstdc++
2438 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2439 * Swig subdir (historical tests of swig version 1.3.17++) removed
2440 * Test/testChangeEntete.cxx some lines commented out in order to make
2442 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2443 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2445 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2447 hence the user doesn't need this explicit call.
2448 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2449 i.e. LoadElements() call removed.
2450 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2451 - src/Makefile.am declares the proper flag for g++.
2452 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2453 for adding user defined new tags.
2454 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2455 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2456 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2458 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2459 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2460 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2461 src/Makefile.am : the project should properly compile and install
2462 with the autotools, included the python wrappers part.
2463 * gdcm.spec.in : added a spec file for RPM packaging.
2465 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2466 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2468 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2470 to exported to the environement (see gdcmPython/testSuite.py
2472 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2473 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2474 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2475 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2476 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2478 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * gdcmPython/__init__.py doesn't crash anymore when running in
2480 in InstallMode or PreInstallMode but with an environement given
2481 value of GDCM_DICT_PATH.
2482 * src/gdcmDictSet.[cxx/h] coding style.
2484 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2485 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2486 * src/gdcm.h general comments moved to TODO, and README
2487 * src/gdcm.h should now be seen as a user commodity (including it
2488 should suffice to fully use gdcm). It is nowhere including within
2489 any of the kernel files src/*.cxx and src/*.h.
2491 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2493 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2495 * src/gdcm*.cxx only include their corresponding include file
2496 (as opposed to gdcm.h)
2497 * gdcmPython/gdcm.i changed accordingly
2498 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2499 the autogen.sh generated "make snapshot" command to work.
2500 * autogen.sh removed history related references to crea package.
2502 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * distutilsSwigCPlusPlus.py work around some swig portability
2506 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2508 was done in a last ditch attempt to get setup.py _really_
2509 operationnal. The python/gdcmPython layaout add the advantage
2510 of hidding away the python related distutils specific files
2511 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2512 Alas, the src directory was out of scope (i.e. it's relative
2513 position to setup.py was ../src) which made things impossible to
2514 handle (see previous version of python/setup.py). Crossing fingers...
2516 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * python/setup.py now works on Un*x. (harder than I thougth)
2518 * python/distutilsSwigCPlusPlus.py can now have include files
2519 among the list of sources.
2521 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2522 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2523 * modifications in MSVC projects
2525 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2526 * As stated by the first lines of Test/ExceptionAndPython/README, it
2527 looks like we can move back to original usage of exception within
2528 src/gdcm* and hence remove the errno stuff that was introduced
2529 as a quick and dirty fixture of this problem (added to the TODO).
2530 * Doc/Doxyfile configuration file for Doxygen and corresponding
2531 README file for usage added.
2532 * Test/testWrite.cxx added. This new test comes from a split of
2533 test.cxx that is now reverted to its original purpous i.e.
2534 testing the proper parsing of a Dicom related file.
2535 testWrite.cxx concentrates on testing the IO part of gdcm.
2536 * Test/bug1.cxx (containing a bug on WIn32) added.
2537 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2538 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2539 whose purpose is to publish the content of the TagNames of the
2540 Dicom public dictionnary were not accessible without an
2541 instance of class gdcmHeader.
2542 - those methods are now static methods of gdcmDictSet and hence
2543 require no instances at all to be invocated.
2544 - within gdcmDictSet this change required to change some method
2545 to class methods (i.e. are now static) among which SetDictPath
2546 (renamed to BuildDictPath) and LoadDefaultPubDict.
2547 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2548 the above changes by calling the new method classes of gdcmDictSet.
2549 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2550 the above to be effective.
2551 * python/gdcmPython: in order to wrap properly the above changes
2552 for Python, swig version now needs to be > 1.3.17.
2553 * python/gdcmPython/Makefile fixed to adapt itself to new
2554 configure/make shema introduced by Johan Montagnat (thanks for the
2555 contribution). Alas this Makefile cannot be turned into a proper
2556 Makefile.am without some heavy changes in the configure.in
2557 (for python dectection).
2558 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2559 now avoids publishing the empty entries.
2561 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2562 * python/setup.py : bug fix concerning install under windows
2563 ExtraPath reused :-P
2564 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2566 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2567 * Dicts/dicomV3.dic : remove double spaces !!!
2568 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2569 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2572 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2574 method. Doxygenation.
2575 * src/gdcm.h clean up of JPR spurious comments.
2577 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * python/distutilsSwigCPlusPlus.py now properly collects the
2579 shadow classes generated by "swig -c++" (gdcm.py in our case)
2580 when using "python setup.py install".
2581 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2582 reexports the working classes.
2583 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2584 by the classical C errno scheme. This is to prevent an obscure
2585 behavior of the python wrappers when importing wxPython.wx prior
2586 to gdcmPython (which ended up in an abort call). An illustration
2587 of this oddity can be found in the Test/ExceptionAndPython
2588 subdir (see the README file). This problem probably due to
2589 an combination of g++ and dynamic loading.
2590 * added Test/ExceptionAndPython (see above)
2592 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * Changed the layout of the python part to avoid bloating main
2594 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2595 i.e. the distutils arsenal. All the python related stuff is
2596 again in a python subdir, but the package itself is now in
2598 * setup.py was cleaned up:
2599 - pythonIncludePath removed
2600 - python setup.py bdist target is now functional.
2601 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2602 collision with other packages). gdcmPython/demo/*.py changed
2605 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * python subdir moved to gdcmPython (preparation of distutils packaging).
2607 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2608 distutils installer is operational.
2609 * - gdcmPython/__init__.py now properly loads the swig generated
2610 shadow classes (from gdcm.py).
2611 - gdcmPython/demo/*.py changed to import the package gdcmPython
2612 instead of gdcmPython/demo/load.py.
2613 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2615 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2617 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2618 entries within the associated public Dicom dictionary resp. the same
2619 information but sorted by the fourth field (PAT, IMG, DIR) of the
2621 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2622 are now in the "???" group.
2623 - python/gdcm.i changed accordingly,
2624 - python/demo/printGroupedPublicDict.py added, that gives an example
2625 of the above new functionalities in Python.
2627 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * src/gdcm.h, gdcmHeader.cxx:
2629 - historic references to glib's g_malloc and g_free (#defined)
2630 were definitively removed.
2631 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2632 * src/gdcmElValSet.cxx:
2633 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2634 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2635 - GetElValue(string) renamed to GetElValueByName.
2636 - Added GetElementByName(string).
2637 * src/gdcmHeader.cxx: added
2638 - GetPubElValRepByNumber(guint16, guint16)
2639 - GetPubElValRepByName(string)
2640 - GetShaElValRepByNumber(guint16, guint16)
2641 - GetShaElValRepByName(string)
2642 - GetShaElValByNumber(guint16, guint16)
2643 - GetShaElValRepByName(string)
2644 - GetElValRepByNumber(guint16, guint16)
2645 - GetElValRepByName(string)
2646 - GetElValByNumber(guint16, guint16)
2647 - GetElValRepByName(string)
2648 * Doc/requirements.txt added.
2650 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * Test/Makefile building now depends on the one of libgdcm.so
2652 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2653 pixel data) aware which enables finding the address (offset) of
2654 the pixel data of JPEG encoded DICOM files. This leaves only a single
2655 file in the testSuite whose pixel data address (offset) is unknown.
2656 * python/testSuite.py changed accordingly.
2658 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2659 * VC++ has some strong limitations when working with the STL, as stated
2660 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2661 "Also note that some STL containers (map, set, queue, list, deque)
2662 cannot be exported. [...]
2663 Some STL classes contain nested classes. These classes can not
2665 This is caused by a designed limitation that once a template
2666 class is instantiated, it can not be re-instantiated and
2668 Since our usage of map<> is ubiquitous in gdcm, this "designed
2669 limitation" of VC++ is a pitfall.
2670 Hence the Python wrappers of gdcm cannot be incrementally linked
2671 against the c++ dynamic library. The dirty but only workaround is
2672 to forget about incremental link of dynamic libraries and to generate
2673 the Python wrappers library with the inclusions of the underlying C++
2675 The following modifications concern this matter on Win32/VC++:
2676 - wrapping python correct with standalone wrapped dll (don't use separate
2677 dll under windows !!!!)
2678 - python21_d debug mode enabled (ask Frog how to use it :-)
2679 - NO problem with having an STL member of class for example string in C++
2680 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2681 - Python test of dcmlib in Python is ok under windows on a large set
2683 * removed glib references
2684 * typedef's inserted in gdcm.i for correct swig type management
2686 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * python/demo/*.py load.py extracted from test.py. Added explore.py
2688 that only displays required tags and testAll.py that parses all
2689 the files of the testsuite without using unittest.
2690 * python/testSuite.py other additional test on new files added.
2691 * Data/* new test files added accordingly to the testSuite.
2692 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2693 the vr in the file differs from the one of the dictionary.
2695 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2697 values, but limits itself to values which are below a user specified
2698 size (by default 1024 bytes).
2699 * python/gdcm.i : elements not loaded (because their size is above the
2700 user specified treshold) are exported with their TagKey as key of the
2701 python dictionary. This enables the testsuite to make some checks
2702 on the unloaded elements (since we have their offset and size).
2703 * python/testSuite.py
2704 - now tests for the existence and proper value of the pixel data
2705 - two new examples added.
2706 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2708 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2710 aware. See the strategy comments in gdcmHeader::FindeLength().
2711 * Test/test.cxx now accepts a filename as first argument.
2712 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2713 * python/testSuite.py changed to integrate test on above files.
2715 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2717 the vr was also RET.
2718 * python/testSuite.py more tests added.
2720 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * python/testSuite.py unittest test suite added (uses Data)
2722 * Data/* dcm and acr files for the test suite.
2723 * glib dependance removed from un*x version. We now use ISO C99
2724 7.18 Integer types (see stdint.h)
2725 - python/Makefile, src/Makefile src/gdcm.h
2726 * src/ when an explicit vr (like dicom files) suddenly poped an
2727 implicit element we use to mark the underlying DictEntry of the
2728 concerned ElValue with "Implicit". This strategy was damageable
2729 too the public or provite dictionaries, since some of their vr
2730 would be changed. Since Header::FindLength heavily relies on the
2731 detection by Header::FindVR of falsely explicit elements, I
2732 added an extra ImplicitVr member to ElValue (boolean).
2733 The rest of the changes we the necessary adaptations.
2735 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2738 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2740 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * Adaptation for porting to VC++:
2743 o forced to use std namespace (for string to be known)
2744 o all class use __declspec export style on WIN32
2745 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2746 (in stdlib.h on Win32 but in std:: for gcc)
2747 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2748 variable GDCM_DICT_PATH.
2749 * src/gdcmHeader.cxx verbose comments made discrete.
2751 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * python/gdcm.i: added a typemap that converts a C++ hashing table
2753 to native Python dictionary.
2754 * python/demo/test.py:
2755 - now uses the native dictionary for exploration of gdcmHeader.
2756 - takes an optional filename argument (the file to parse).
2757 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2758 PubElVals hashing table.
2759 * Dicts/dicomV3.dic removed error prone trailing spaces.
2761 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2762 * Python wrapping process moved away from src/Makefile to
2763 newly created python/Makefile (as well as gdcm.i)
2764 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2765 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2766 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2767 from the environement variable GDCM_DICT_PATH (when existing).
2768 * src/gdcmDict::GetTag bug fix.
2770 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * Straightforward temporary fixes for swig to build the python wrappers.
2772 src/Makefile now has a python working entry [by working we mean
2773 that we can import de shadow classes without errors].
2775 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * hashtest.cxx removed (since allready in Test)
2777 * src/gdcmlib.h renamed to src/gdcm.h
2778 * src/dcm.i renamed to src/gdcm.i
2779 * src/Makefile prepared for python wrapping
2781 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2782 * src/gdcmHeader.cxx :
2783 - Parsing of header is now separated from loading of element values
2784 (see gdcmHeader::LoadElements).
2785 - general clean up of hopefully all file access (creation of
2786 ReadInt16 and ReadInt32)
2788 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * src/gdcmHeader.cxx :
2790 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2792 - SetLgrElem renamed to SetLength
2793 - GetLgrElem renamed to GetLength
2794 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2795 * src/gdcmElValSet.cxx fixed both GetElValue methods
2796 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2797 due to IdoDude was cleaned out.
2799 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2801 concentrates on finding the value representation (when it exists).
2802 RecupLgr now only finds the element value length, and it avoids
2803 returning the unecessary skL (skipped length).
2804 Also, offsetCourant was simply removed (with taille_fich) since
2805 it was redundant with the File position internals (by using
2806 ftell and fseek). This also made skL (see above in RecupLgr) usage
2808 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2809 on the libido specificities which are handled through class
2811 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2814 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2815 * Truckload of changes. Parsing of header is barely functional
2816 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2818 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * src/gdcmHeader.cxx many addons of low level methods
2821 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2823 and _IdDcmSWAP_LONG.
2825 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * This corresponds to all the changes decided at the meeting of
2827 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob