1 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
3 moved away from gdcmDocEntrySet (since this class is an abstract class
4 acting like an interface). SQDepthLevel and BaseTagKey are now
6 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
7 and associated accessors. Doxygenation of the class.
8 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
10 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
11 Use SQDepthLevel accessor instead. ::Print() adapted.
12 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
13 - src/gdcmDocument.cxx changed accordingly.
15 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
17 - The following is the doxygen comment of the typedef declaration
18 of gdcmagKey in src/gdcmCommon.h:
19 gdcmTagKey is made to old an "universal" (as in URL, Universal
20 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
21 A dicom tag allways has a group and an element, but a set of tags
22 embeded in various (optionally nested) sequences and sharing
23 the same group and element all share the same (group, element)
24 "identifier". Hence the (group, element) cannot be used as an
25 identifier (in gdcm we shall refer to a "TagKey") of a tag.
26 In order to construct a proper tag identifier (i.e. a key) we
27 consider the following definition of a TagKey:
28 - let Group, Element be the string representation of the
29 group and element dicom tag members,
30 - let ItemNumber be the string representation of the integer
31 index of the considered item number of a sequence,
32 Let the key of a tag embeded in a sequence, noted SeqTag, be
34 /ItemNumber#Group|Element
35 where "/", "#" and "|" are characters acting as separators.
36 Then the general form of a gdcmTagKey is given by:
38 where <SeqTag> means NO or many instances of SeqTag.
39 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
42 but the gdcmTagKey of a tag "embeded" is the first item of
43 a sequence, itself nested in the third item of a sequence is the
45 0004|1220/2#0008|0082/0#0008|0090
46 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
47 order to hold the new sequence compatible key. Previously, the
48 GetKey() method would look in the underlying gdcmDictEntry.
49 - src/gdcmDocEntry.cxx:
50 -- constructor now copies the underlying DictEntry key, in the local
52 -- ::Print: displays the member Key, instead of the (group, element).
53 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
54 - src/gdcmDocEntrySet.h:xi
55 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
56 -- now has a new BaseTagKey member.
58 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
59 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
61 This poses the problem with the semantics of the following lines
62 LoadEntryVoidArea(0x0028,0x1201); // R LUT
63 LoadEntryVoidArea(0x0028,0x1202); // G LUT
64 LoadEntryVoidArea(0x0028,0x1203); // B LUT
65 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
66 to the long FIXME note for what the problem is. Nevertheless in
67 order to get things working the dicom dictionary was altered !
68 Please fix things urgently...
69 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
70 information), see above note on moving the member VoidArea. Nevertheless
71 the following entries previously correctly set as US are now inproperly
73 0028 1201 OW IMG Red Palette Color Lookup Table Data
74 0028 1202 OW IMG Green Palette Color Lookup Table Data
75 0028 1203 OW IMG Blue Palette Color Lookup Table Data
76 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
77 of gdcmDocEntry moved to gdcmSeqEntry.
78 * src/gdcmSeqEntry.cxx: STYLE.
80 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
81 * Test/TestAllEntryVerify.cxx minor fix and added comments.
83 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
84 * gdcmPython/testSuite.py: all the test suite in python is now moved
85 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
86 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
87 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
89 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
90 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
91 to avoid inclusion recursion until STL is reached.
92 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
93 mecanism. errno.h is not included in gdcm anymore.
94 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
95 (gdcmFormatError now inherits from gdcmFormatUnexpected).
97 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
98 gdcmData/TestAllEntryVerifyReference.txt
99 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
100 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
101 exception_on_error parameter.
102 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
103 - vtk/vtkGdcmReader.cxx changed accordingly,
104 - Example/*.cxx and Test/*.cxx changed accordingly.
106 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
108 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
109 enable_sequences removed from gdcmHeader constructor and dependencies.
110 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
111 * gdcmPython/demo/PrintHeader.py: dummy fix.
112 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
113 skip_shadow removed from gdcmHeader constructor and dependencies.
114 * Example/*.cxx and Test/*.cxx changed accordingly.
116 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
117 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
118 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
120 2004-07-21 Jean-Pierre Roux
121 * FIX Now, Parsing and Printing a DICOMDIR do work!
122 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
124 2004-07-20 Jean-Pierre Roux
125 * FIX Some brain damaged headers have Zero-Lenght fields
126 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
128 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
130 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
131 variable (instance of gdcmDebug) by a definition macro, and the instance
132 is now in static in the gdcmDebug class
133 * src/gdcmSQItem.h : (FIXME) remove an undefined method
134 * Test/PrintAllDocument.cxx : bug fix in the result of the test
136 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
137 * WARNING: ctest now depends more tightly on gdcmData. You should
138 check out gdcmData properly for things to run smoothly...
139 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
140 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
141 we need the pixels not be loaded in order to use the ValEntry
142 that displays position and size).
143 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
144 This is a C++ based equivalent of gdcmPython/testSuite.py that should
145 be deprecated. If you have any doubts about the advantages of a
146 modern scripting language (read Python) versus grass root C++ (i.e.
147 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
148 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
149 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
150 Anyhow, consider documenting the gdcmData images in
151 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
153 * Test/CMakeLists.txt:
154 - now uses TestAllEntryVerify.cxx
155 - specific comments on oldACR00001.ima (now renamed in gdcmData
156 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
157 gdcmData/TestAllEntryVerifyReference.txt
160 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
161 * src/*.[h|cxx] : typedef clean up
162 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
163 - TagKey renamed to gdcmTagKey (for external usage)
164 - VRKey renamed to gdcmVRKey (for external usage)
165 - removal of typedef duplication.
166 - Removed all unecessary inline keyword from class inline definitions.
167 - Some method|function(void) declarations replaced with method|function().
168 * src/jpeg/libijg12/jdhuff12.c:
169 - printf polluting ctest removed.
170 - TAB removal for comminting
172 - TestAllReadCompareDicom.cxx: added a test that compares all the
173 images in gdcmDataImages.h with corresponding images in
174 gdcmData/BaselineDicom/. When baseline images are not present
175 this test creates them.
176 Note: we need to validate each reference image, but before that
177 I'd like to rename them with a more explicit name...
178 - CMakeLists.txt: changed accordingly.
179 * Example/*.cxx: examples now only include gdcm.h (as opposed to
180 including each header needed).
182 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * Test/*.cxx and Example/*.cxx: moved some examples away from the
184 test suite to the Example directory. Are concerned:
189 - TestWriteSimple.cxx
190 * Test/CMakeLists.txt: added some comments on reasons for black listing
191 image gdcmData/oldACR00001.ima
193 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
194 * Test/CmakeList.txt: removed the following from black list (to be coherent
195 with removal from gdcmData):
196 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
197 - gdcm-MR-PHILIPS-16.dcm
199 Added the following because after last cvs update, they cause
200 ctest -R TestReadWriteReadCompare
202 - gdcm-MR-SIEMENS-16-1.acr
204 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
205 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
206 new comments in this file) we temporarily (sigh) move to a weaker
208 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
209 we don't need to black list the following images anymore:
210 - 8BitsUncompressedColor.dcm
212 - US-PAL-8-10x-echo.dcm
213 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
214 fixes and the beautified code ;-)
215 This fixes the bug introduced in version 1.42 (when beautifying)
216 that made the parsing of 8BitsRunLengthColor.dcm unproper.
217 Note: ctest was blind to this bug (this means we need to still
218 improve the test suite). The bug could be detected by using
219 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
221 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
222 and by displaying the (garbage) produced file temp.XDCM...
224 2004-06-29 Jean-Pierre Roux
225 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
226 - replace by uggly but working old code :-(
227 A lot of things should be OK again.
228 It's really urgent to have a test suite that *tests*,
229 to prevent Frog's beautifying sessions to break all the stuff
230 (twice, withing a fortnigh ...)
232 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
234 redundancy) to added Test/TestReadWriteReadCompare.cxx
235 * Test/CmakeList.txt: because the compare test of
236 Test/TestReadWriteReadCompare.cxx fails, the following images are
237 black listed: - 8BitsUncompressedColor.dcm
239 - US-PAL-8-10x-echo.dcm
240 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
241 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
242 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
243 and ad-hoc kludge. This kludge is now removed, and on encountering
244 such an image (OB field brain damaged) we set errno. Then in
245 ::FindDocLength() we "fix" the length as being ALL what remains
246 in the file (until EOF). We then proceed, hoping for the best...
247 This fixes a SegFault in ShowDicom when trying to write such an
249 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
250 (because TestWriteRead breaks on it, after a non conformal commit?).
251 ctest now runs properly, except for MakeDicomDir (which was allways
252 broken) and the Python related stuff (still not fixed).
254 2004-06-24 Jean-Pierre Roux
255 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
256 FIX : Test/TestReadWrite now iterates on all the file names
257 (instead of infinite loop)
258 ENH : Test/TestWriteRead now iterates on all the file names
260 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
263 2004-06-24 Jean-Pierre Roux
264 FIX : - now Write drops LUT Descriptors and LUTs (if any)
265 when SamplesPerPixel =3
266 - now Write is no longer confused by
267 'BitsAllocated = 12" and 'BitsStored=12"
268 - "UN" value representation Elements are now written correctly
269 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
270 ENH : - now gdcmHeader has its own Write methods
271 (in order to split the job that has not to be done
274 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
276 loop on the same image until memory went out.
277 Note: this means we still have gobs of memory loss in PrintDocument
278 * src/gdcmDocument.cxx: fixes problem on parsing on file
279 gdcmData/16BitsJpegLosslessGrayScale.dcm.
281 2004-06-24 Jean-Pierre Roux
282 FIX : Write - All the Sequences and Sequence Item are now written
283 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
284 is added a the end, when necessary.
285 - A lot of brain-damaged images, that were read correctly are
286 now written correctly
287 - length compatible BinEntry are now loaded correctly
288 (even for odd groups)
289 Note : only Explicit Value Representation was checked.
290 (question : is implicit VR really necessary for gdcm ?)
292 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * DEVELOPPER: added a proposition of coding style.
294 * src/gdcmDocEntry.h: removed every inline declaration (for test of
297 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
298 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
299 Use the gdcmDocEntry::Print() and Write() instead.
300 * src/gdcmDocument.cxx: bug fix.
302 2004-06-22 Jean-Pierre Roux
303 FIX : gdcmDocument.cxx
304 - Now we do recognize the JpegLossLess format (there was a misstyping in
305 code 'beautyfication' :-(
306 - Now we automaticaticaly load the Luts, if any
308 2004-06-22 Jean-Pierre Roux
309 In order : to write Sequences, whatever their imbrication level,
310 : to allow user to create his own Sequences
311 a lot of modif where necessary (adding, moving, or virtualising methods)
313 WARNING : save your own sources *before* cvs up !
316 ADD virtual void Write(FILE *fp, FileType filetype);
319 ADD virtual void Write(FILE *fp, FileType filetype);
320 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
323 ADD virtual void Write (FILE *fp, FileType filetype)=0;
324 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
325 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
326 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
327 ADD std::string GetEntryByName(TagName name);
328 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
330 std::string vr = "unkn",
331 std::string fourth = "unkn",
332 std::string name = "unkn");
333 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
334 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
335 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
336 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
337 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
338 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
339 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
340 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
343 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
344 ADD virtual std::string GetEntryByName (TagName tagName);
345 ADD virtual std::string GetEntryVRByName (TagName tagName);
346 REM virtual bool Write(FILE *, FileType);
347 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
348 FILE *_fp, FileType type);
349 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
350 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
351 REM virtual bool WriteEntries(FILE *_fp,FileType type);
352 REM virtual std::string GetEntryByName (std::string tagName);
353 REM virtual std::string GetEntryVRByName (std::string tagName);
354 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
355 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
356 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
358 std::string vr = "unkn",
359 std::string fourth = "unkn",
360 std::string name = "unkn");
361 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
362 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
363 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
364 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
367 ADD virtual void Write(FILE *fp, FileType filetype);
370 ADD virtual void Write(FILE *fp,FileType filetype);
373 ADD virtual void Write(FILE *fp, FileType filetype);
374 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
375 REM std::string GetEntryByNumber(guint16 group, guint16 element);
376 REM std::string GetEntryByName(TagName name);
379 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
381 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
382 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
383 The default constructor invoked by the line
384 gdcmHeader *f1 = new gdcmHeader( header );
385 was gdcmHeader::gdcmHeader(bool) instead of the expected
386 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
387 Hence the parsing wasn't executed... See also below.
388 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
389 as explicit constructor didn't do the trick to fix the above problem.
390 Could anyone explain why ?
391 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
392 properly calls gdcmValEntry::Print() (that was weed out from
393 code related to gdcmBinEntry).
395 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * In order to fix memory leaks:
397 - Test/TestWriteSimple.cxx: added cleaning of free store through
399 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
400 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
401 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
402 (through the call to ::AddDicomDirMeta()) or the destructor
403 would crash when deleting uninitialized ::metaElems].
404 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
405 - src/gdcmDocument.cxx:
406 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
408 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
409 was causing memory leaks.
410 - src/gdcmSQItem.cxx:
411 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
412 cleanly handled with polymophism: sorry but my milage is low).
413 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
414 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
415 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
416 This avoids SegFaulting.
417 - src/gdcmSQItem.h: coding style.
419 - Test/TestWriteSimple still severely sucks. The output image content
420 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
421 damaged when displayed with vtkgdcmViewer.
422 - on memory leaks: TestWriteSimple leaks really less (see entry
423 of 2004-06-18 in Changelog file for the call to valgrind).
424 - on segfaults: ctest now passes all the tests but one (no more
426 * Erroneous leading white fix:
427 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
428 white[s] (as opposed to from >> xxx, that removes it [them].
429 - src/gdcmTS.cxx: ditto.
430 - gdcmPython/testSuite.py: dirty related kludge removed.
431 * src/*: remaining references to gdcmParser removed.
432 * src/*[cxx|h]: added copy[way]left header.
435 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
436 * In order to fix writing of dicom files:
437 - Test/TestWriteSimple.cxx: a simpler example of writing.
438 - Test/CMakeLists.txt changed accordingly.
439 - src/gdcmDocument.cxx:
440 -- The destructor now recursilvely removes potential sequences.
441 -- Bug fix in ::IsJPEG2000()
442 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
443 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
445 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
446 to only declared) and build on top of
447 ::GetDocEntryByNumber(guint16, guint16).
448 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
449 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
450 for usage in destructor and treatement of promotion in
451 ::ReplaceOrCreateByNumber().
452 - src/gdcmSQItem.cxx: destructor should better handle his job.
453 Test/TestWriteSimple now runs (or at least it DOES something).
454 * We can now start hutting memory links. A good starting point is:
455 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
456 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
457 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
459 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * Valgrind note: after Mathieu Malaterre teached me how to read
461 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
463 Using gcc, you can force the STL to use malloc and to free memory as
464 soon as possible by globally disabling memory caching.
465 With 3.2.2 and later, you should export the environment variable
466 GLIBCPP_FORCE_NEW before running your program.
467 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
468 simply vanish (it is still not clear to me, whether this means that
469 STL std::string leaks or if valgrind believes it leaks...).
470 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
471 running bin/gdcmTests makeDicomDir):
472 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
473 - Test/makeDicomDir.cxx now properly traps empty lists and returns
475 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
476 SegFaulting (I drowned in DicomDir related code when trying to
477 understand why the list is empty...).
478 * src/gdcmDocument.h: first BSD license header try.
479 * Doc/License.txt added.
481 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * src/gdcmDocument.[h|cxx]:
483 - Clean up of the Transfer related predicates. They are now all based
484 on new method isGivenTransferSyntax, that (should) handle properly
486 - general clean up, simplification, and coding style.
487 - Specific clean up of Parse7FE0() (umproperly named actually).
488 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
490 2004-06-14 Jean-Pierre Roux
492 - fix the display of Sequence Delimitor (SQDepthLevel pb)
493 - fix the display of SQItem ordinal number
494 - add the GetSQItemByOrdinalNumber method
495 - remove some useless never written private methods
497 2004-06-14 Jean-Pierre Roux
499 - adding a constructor taking a gdcmDocEntry as an input param
500 - ReplaceOrCreateByNumber now returns :
501 a gdcmBinEntry * if a Binary (void *) value is passed as a param
502 a gdcmValEntry * if a string value is passed as a param
504 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
505 according to the param type (no longer sets a gdcmDocEntry)
506 - GetValEntryByNumber, GetBinEntryByNumber added
507 - NewValEntryByNumber and NewBinEntryByNumber added
509 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
511 - GetSQItemNumber and SetSQItemNumber added, to provide
512 a (relative) Item identier inside a given Sequence
513 \warning : some pb remaining around this number
515 - AddEntry now takes the Item Number as a param
517 - adding a constructor taking a gdcmDocEntry as an input param
519 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * Memory leak hunt with the following command:
521 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
522 --show-reachable=yes gdcmTests PrintDocument
523 It looks like many (all?) leaks are due to the STL (or a bad usage
524 of the STL. The lines producing the leaks now have a comment with
525 a "MEMORY LEAK" tag: you can retrieve them with
526 grep "MEMORY LEAK" src/*
527 Here are two typical examples which I can't help fixing:
532 char * test = "babo";
533 name = test; //// <--- valgrind detects 960 bytes lost in
534 //// call to std::string::operator=(char const*)
535 name.clear(); //// Doesn't help !
543 std::cout << "Type a bunch of characters followed by RETURN: ";
544 getline(std::cin, line); //// <--- valgrind dectects a loss
545 //// of 1320 bytes in call to
546 /// std::basic_istream<>& std::getline<>
552 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * src/gdcmHeader.[cxx|h]:
554 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
555 and related, moved away to gdcmDocument.
556 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
557 the corresponding protected accessors of inherited class
558 gdcmDocument, removed ! As a consequence gdcmFile had to be
559 declared friend of class gdcmDocument (see below).
560 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
561 - Clean up of undefined or unused methods.
562 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
563 account the changes to gdcmHeader.h).
564 * src/gdcmDocument.h:
565 - gdcmFile is now a friend class (in order to take into account the
566 changes to gdcmHeader.h).
567 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
568 (see changes to gdcmHeader.h).
569 - Accessors (reading on the form GetEntry*) are now public.
570 - Clean up of undefined or unused methods.
571 * src/gdcmDocument.cxx:
572 - adaptation to changes to gdcmDocument.h
573 - ::OpenFile now writes a verbose message when file cannot be opened.
574 - some std::string properly set to VRKey
575 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
576 references to gdcmDocument.
577 * Test/TestFindTags.cxx: changed accordingly to above changes.
578 * gdcmPython/testSuite.py: adapted to renaming of acr files in
579 cvs repository gdcmData.
581 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
583 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
584 conflicts with gdcmValEntry::voidArea.
585 * src/gdcmValEntry.cxx: unmatching comment wiped out.
586 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
587 Value representation between StringRepresentable and BinaryRepresentable.
588 * src/gdcmDocument.cxx:
589 - method ParseDES: proper indentation restored and usage of
590 gdcmVR::IsVROfGdcmStringRepresentable wired in.
591 - method LoadDocEntry: the fingerprint left in the SetValue() of
592 unloaded entries (length > MaxSizeLoadEntry) had curiously been
593 removed. Reverting to previous code segment with the proper
594 dynamic_cast< gdcmValEntry* >.
595 Note: this was (partially) breaking the python test suite
596 (gdcmPython/testSuite.py) that made usage of the above
597 fingerprint to check presence of "Pixel Data".
598 * src/gdcmDocEntry.h: coding style.
599 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
600 now taken into account.
601 * gdcmPython/gdcm.i: adaptation to the new internal representation
602 of gdcm (exit gdcmParser, hello gdcmDocument).
603 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
605 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
606 anymore, but instead prints the loaded Python dictionary.
607 * .... alas, the python testSuite is still broken.
609 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
610 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
612 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
613 * src/gdcmUtil.h : export methods
615 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
616 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
618 * Initial addition of automatic python testing
619 * Initial addition of automatic image comparison
621 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
623 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
625 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
627 * Test/ShowDicom.cxx : bug fix for msvc compilation
628 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
630 2004-05-04 Jean-Pierre Roux
631 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
632 new concepts (and new classes) :
633 a 'gdcmDocument' is composed of a set of Doc Entries, that are
634 - elementary gdcmDocEntries (former gdcmHeaderEntries)
635 - Sequence Doc Entries (gdcmSeqEntries)
636 a Sequence is composed of Items.
637 Each item is a set of Doc Entries (this is recursive)
638 The non uniqueness of the 'Dicom tag' is due to this recursivity
639 (never taken into account)
640 Our unability to add a new 'entry' in the header
641 at the proper location (neither in the H-Table (map or multimap),
642 nor in the Chained List is also due to this recursivity.
643 Don't try, right now, to use/modify/compile these new sources :
645 We just commit all the stuff, 'as is', in order not to loose it.
647 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
650 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
652 file prefix (SetFilePrefix)
654 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
655 * Add a new test: ShowDicom, for now this is just the c++ version of
656 checkRead.sh, later it will be able to compare the image read against a
658 * Replace the DEBUG on the stack with a global entry in cmake interface:
659 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
661 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
662 * Add an example subdir, with a real example on how to read + write a
665 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
667 * Doc/CMakeLists.txt: the main page is now properly differentiated
668 between the developper and user version.
669 * Doc/doxygen.config.in: dropped search related obsolete flags
670 * src/gdcmParser.h, gdcmHeader.h: doxygenation
672 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * DEVELOPPER: added some helpfull comments for compile/test/install
676 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
677 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
678 src directory, now generated in the build dir.
679 2. Tests as mentionned smarter
681 4. Add a new method in gdcmDict that return the PubDict by name
682 this is interesting for 3rd party lib like ITK,
683 where we could set the institution name / patient name...
685 * ENH: 1. Now the test suite is working for real
686 2. All binaries are now output in the gdcm-bin directory
687 (this was not true before)
689 2004-04-28 Jean-Pierre Roux
690 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
691 SeQuence indented printing of Dicom Header.
692 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
693 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
694 Computation of SQDepthLevel is now part of gdcmHeader constructor
695 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
696 tree-like structure of a Dicom Header.
697 * FIX Test code cleaning
699 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
700 * ENH: Adding automatic testing
701 1. Need a DartConfig.cmake to submit to public
702 2. Add a test driver gdcmTest.cxx
703 3. gdcmTestMain, an helper for the main test driver gdcmTest
704 4. Files in Test don't have a main anymore, this becomes interesting
705 when we add more and more tests, thus dsw don't have to load
707 * ENH: Adding a GDCM_DATA_ROOT for testing
708 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
709 one file instead of seven + some small cleanup
711 2004-04-22 Jean-Pierre Roux
712 * ENH Minor changes to the Print() methods.
713 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
714 Header printing. Example given with :
715 > PrintHeader fileName 2 new
716 (SQ based tree-like structure still to be done for the Header ...)
718 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
719 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
720 1. I have added some unsigned where needed
721 2. Some function parameter not used -> (void)
722 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
723 4. g++ don't like character '\' in comment
724 5. #define jpeg_create_decompress jCreaDecompress
725 this really need to be fixed
726 6. virtualize destructor of gdcmObject ... leakage
727 7. sscanf(g->first.c_str(),"%x",&gr_bid);
728 this also really need to be fixed
729 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
730 remove compression file
731 (as we only do decompression, right ?)
732 * ENH: Change malloc/calloc/free with c++ equivalent
734 2004-04-21 Jean-Pierre Roux
735 * FIX gdcmHeaderHelper::GetXSpacing
736 when a single value is found (bug ?), xpacing is now
737 defaulted to yspacing
739 2004-04-19 Jean-Pierre Roux
740 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
741 * ENH add parameters :
742 bool exception_on_error = false,
743 bool enable_sequences = false,
744 bool ignore_shadow = false
745 to the gdcmFile constructors to be full gdcmParser compliant
746 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
747 to allow reading of PAPYRUS 3.0 files
749 2004-04-06 Jean-Pierre Roux
750 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
752 2004-04-02 Jean-Pierre Roux
753 * ADD : Test/checksequence.sh, for a general recap on SQ pb
754 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
755 for Philips spurious Tag fffe|0000 while rewritting Dicom files
757 2004-03-30 Jean-Pierre Roux
758 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
759 for ACR file, written out as DICOM files (hope so...)
761 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
763 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
764 moved to base class gdcmParser and only the specialisation is kept
766 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
767 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
768 already does the job.
769 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
770 (to be consistent with gdcmParser::WriteEntries).
772 2004-03-30 Benoit Regrain
773 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
774 upate of the object's instance. It's passed to 2 in the unfavorable
775 case : one in the ExecuteInformation, one in the ExecuteData
777 2004-03-29 Jean-Pierre Roux
778 * ENH : Check on file type to be written moved
779 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
780 * FIX : gdcmObject::ResetBoundaries now stops properly
781 when end-of-list is reached
782 : gdcmVersion modified (as Benoit Regrain asked)
784 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
786 * src/gdcmUtil.cxx: added forgotten iostream include.
787 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
788 equivalent to ExplicitVR in existing code).
790 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
792 now contains all the gdcmGlobal related code.
793 * minor coding style and doxygenation changes.
795 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
797 now contains all the Debug related code.
798 * minor clean-up of includes in src/*.cxx
799 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
800 CreateCleanString) removed.
801 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
802 * Doc/DoxyMainPageUser.txt added.
803 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
804 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
807 2004-03-24 Jean-Pierre Roux
808 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
810 2004-03-23 Jean-Pierre Roux
811 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
812 big endian made volumes
813 * ENH Now gdcmParser constructor and destructor are protected to forbid
814 end user to instanciate class gdcmParser
815 (only gdcmHeader and gdcmDicomDir are meaningfull)
817 2004-03-22 Benoit Regrain
818 * FIX : src/gdcmDicomDir.cxx : make windows compilable
819 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
820 gdcmSerie to gdcmDicomDirSerie
822 2004-03-19 Jean-Pierre Roux
823 * ENH Now the tree-like structure describing a DICOMDIR comming from
824 an already existing DICOMDIR file is consistent with
825 the home-made tree-like structure build ex-nihilo
826 or build from the files held (recursively) in a Directory
827 functions gdcmDicomDir::CheckBoundaries()
828 gdcmObject::SetBoundaries() added
830 2004-03-17 Jean-Pierre Roux
831 * REM (Eric Boix bug) : removal of meaningless
832 gdcmDicomDirImage::NewImage function.
833 * FIX now file names and directory name are written properly in the
835 * FIX now gdcmDicomDir constructor may be call without any trick
838 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
840 of gdcmDicomDirImage::NewImage as empty function.
842 2004-02-28 Jean-Pierre Roux
843 * ENH add gdcmDicomDir:NewPatient
844 add gdcmDicomDirPatient:NewStudy
845 add gdcmDicomDirStudy:NewSerie
846 add gdcmDicomDirSerie:NewImage
847 to allow making gdcDicomDir object.
848 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
849 (as opposite to the gdcmHeader chained list)
851 2004-02-11 Benoit Regrain
852 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
853 when using from python
855 2004-02-10 Benoit Regrain
856 * FIX : bug fix in the gdcmDirList for the recursivity in directories
857 * FIX : in gdcmDicomDir when the directory is empty
858 * ENH : add callback and methods to get the progression of dicomDir
861 2004-02-06 Jean-Pierre Roux
862 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
863 - GDCM_META added to gdcmDicomDirType
864 - class gdcmMeta created
865 * ENH : - A brief summary is now displayed at the beginning of
866 'testDicomDir' to help disaster magnitude estimation
867 * REM : Now useless Test/explDICOMDIR.cxx
869 2004-02-05 Benoit Regrain
870 * ENH : add methods in gdcmObject to get the hash table or the list of
872 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
873 * FIX : wrapping python for TagHeaderEntryHT
875 2004-02-04 Benoit Regrain
876 * FIX : even length for some strings when writting the dicom dir
877 * FIX : sort the images in the dicom dir
878 * FIX : Bug fix for python use of dicom dir
879 * ADD : a python demo
881 2004-02-04 Jean-Pierre Roux
882 * FIX : Final solution (?) for icone embedded images
883 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
884 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
885 add groups 6002, 6004, 6006, to allow 'clean' parsing of
886 gdcmData/gdcm-MR-SIEMENS-16.acr1
887 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
888 to make full checking easier
890 2004-02-04 Benoit Regrain
891 * FIX : WriteEntries : coding style & logic in parameters
892 * FIX : Set the elements to create the DicomDir in a dictionary file
894 2004-02-03 Benoit Regrain
895 * gdcmDirList : to parse a hard drive directory in recursive (or not)
896 * gdcmDicomDir : add the load of directory
897 * Bug fix and print add-on
899 2004-02-03 Jean-Pierre Roux
900 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
901 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
902 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
903 * FIX gdcmParser.cxx : 'group length' elements are now considered
904 as integers, even for shadow groups, when file is Implicit VR
906 2004-02-02 Jean-Pierre Roux
907 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
909 of the last synonym :-(
910 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
912 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
913 * FIX taking into account the possible 7fe0,0010 multiplicity
914 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
915 to allow removal of references to 7fe0,0010, to deal with
916 ACR-NEMA images, when 0028,0200 is meaningfull
918 2004-01-31 Jean-Pierre Roux
919 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
920 no longer writes 'Un' on disk
921 * FIX SQ elements with actual length are now dealt with corectly
922 * FIX gdcmFile::WriteBase make the difference, for color images, between
923 the length (for Palette expanded images)
924 and Raw Length (non expanded image + Palette)
925 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
926 (that broke Write). Replaced by UL.
927 Aware user will reload the field if he
928 thinks it's necesssary
930 2004-01-30 Jean-Pierre Roux
931 * gdcmParser::CheckSwap() now defaults the filetype to ACR
932 when 'dirty Acr' is found, to be compliant with the new
933 IsReadable() methods.
935 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
936 (no DOUBLE images in kosher DICOM,
937 but so usefull for people that miss them ;-)
939 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
940 DICOMDIR related utilities (not checked as Windoze compliant)
942 2004-01-28 Jean-Pierre Roux
943 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
945 2004-01-27 Jean-Pierre Roux
946 * gdcmParser constructor has a new boolean param,'ignore_shadow',
947 to allow skipping the shadow elements, to save memory space.
948 The TRUE value for this param has to be used
949 with a FALSE value for the 'enable_sequence' param.
950 ('public elements' may be embedded in 'shadow Sequences')
951 * gdcmHeader methods now deal with 'embedded icones images' in the header
952 (even when an 'icone image sequence' is announced by the
953 element (0x0088,0x0200), but there is NO icone at all ...
955 * gdcmHeader sometimes Image Location value doesn't follow
956 the supposed processor endianity (see gdcmData/cr172241.dcm).
959 * gdcmHeader add the method
960 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
961 to get *all* the Header Entries with the same tag.
962 GetHeaderEntrySameName is probabely *useless*
963 (no meaning : Name is *not* an identifier within the Dictionnary)
965 2004-01-26 Benoit Regrain
966 * Bug fix in the print of hexadecimal representations. Remove long fields
967 in the print and add a third level of print to print them
969 2004-01-23 Benoit Regrain
970 * Bug fix on field having a VR = 'UI'. Assume that is a string field
971 * Bug fix on test suite after remove the strip made on not string fields
972 * Split the IsReadable method between gdcmParser which test that the file
973 is dicom and gdcmHeader which test that it's an image file
975 2004-01-22 Benoit Regrain
976 * DicomDir : clean code, add methods, set variables in protected or private
977 * gdcmUtil : bug fix for the clean string method
979 2004-01-19 Benoit Regrain
980 * Add the use of shadow dictionaries
981 * bug fix and coding style
983 2004-01-19 Benoit Regrain
984 * src/gdcmFile.cxx : bug fix concerning the close of file
985 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
986 * Add the update of header entries using the shadow library
988 2004-01-19 Benoit Regrain
989 * removal of file gdcmHeader2.cxx
990 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
991 inheriting from gdcmParser. This split is to prepare the integration
993 * bug fix under python
995 2004-01-16 Jean-Pierre Roux
996 * REM removal of class gdcmHeaderEntrySet
997 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
998 * ADD add file gdcmHeader2.cxx
999 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1001 2004-01-15 Benoit Regrain
1002 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1003 entries created while parsing the header. Thus, they will be destroyed
1004 when the gdcmDictSet will be destroyed
1005 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1008 2004-01-15 Benoit Regrain
1009 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1010 made a fatal error because of the memory release at the end of program.
1011 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1012 some memory and vtk seems to have some problems with that.
1013 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1015 2004-01-14 Benoit Regrain
1016 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1017 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1018 * src/*.[h|cxx] : make changes due to class name changes
1019 * gdcmPython/demo/*.py : bug fix due to method names
1021 2004-01-13 Benoit Regrain
1022 * src/*.[h|cxx] : coding style
1023 * vtk/*.[h|cxx] : coding style
1025 2004-01-13 Benoit Regrain
1026 * gdcmPython/testSuite.py : test the readable flag of file for tests
1027 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1028 It's lied to the stl compilation by MSVC (windows, always windows...)
1029 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1031 2004-01-12 Benoit Regrain
1032 * src/*.h : add comments
1033 * src/gdcmDictSet.h : set the method BuildDictPath in public
1034 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1035 directly setted in the source code
1036 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1039 2004-01-09 Benoit Regrain
1040 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1041 * setup.py : use a reference to gdcmVERSION
1043 2004-01-07 Benoit Regrain
1044 * Modification to compile with the distutils.
1047 2003-12-10 Benoit Regrain
1048 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1049 can use a gdcmHeaderHelper to load datas
1050 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1051 made in the source code
1053 2003-12-10 Benoit Regrain
1054 * Update Windows projects and .cvsignore files
1056 2003-11-12 Jean-Pierre Roux
1057 * ENH gdcmHeader constructor has one more parameter (default value : false)
1058 that allows the user to 'go inside' the SeQuences only
1060 gdcmElValSet:Print takes it into account
1062 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1063 * ENH: Update gdcmPython/CMakeLists
1064 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1065 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1067 2003-11-10 Jean-Pierre Roux
1068 * FIX : gdcmHeader::LoadElements is now based
1069 on the ListTag listElem member,
1070 not longer on the TagElValueHT tagHt member
1071 * ENH : PrintPubElVal shows (temporarily) both results,
1072 with the tagHt member and the listElem member.
1073 (it's easier to 'see' the problems when using Printheader)
1075 * FIX : old private member LgrElem is now splitted into
1076 ReadLength : Length actually found on disk (updated only
1077 if bug fixing is necessary), for internal
1079 UsableLength : Updated by FixFoundLength, to fix a bug
1080 or to allow Parser going on.
1081 Will allow to re-write a kosher header when a SeQuence
1082 with a length (not 0000) is found
1083 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1084 because gdcmElValSet::Add does not update ListElem
1087 2003-11-07 Jean-Pierre Roux
1088 * FIX misstyping in Transfert Syntax name table
1089 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1090 when they have an actual length (not 0000 nor FFFFF)
1091 (Nobody should care of it, but DICOMDIR explorers)
1093 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1094 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1096 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1097 * ENH: vtkGdcmReader now supports LUT !
1098 (vtkgdcmViewer for now is not able to use them though)
1100 2003-11-05 Jean-Pierre Roux
1101 * in testSuite.py : new files names for checking the package
1102 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1103 that returns the pixel area size to the *aware* (vtk) user
1104 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1106 2003-11-05 Benoit Regrain
1107 * in testSuite.py : Modify the rules for checking the paths
1108 : Explicit error messages
1109 * in __init__.py : Related modif
1111 2003-11-03 Jean-Pierre Roux
1112 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1113 to be used by aware (vtk) users that want to manage
1114 LUT (and no to turn the PALETTE image into an RGB pixels one)
1115 * GetPixelType now returns 8U for 24 Bits images
1116 (vtkGdcmReader compliant)
1118 2003-10-31 Jean-Pierre Roux
1119 * Removal of *all* gdcmData images and add them again
1120 in order to loose the 'history' of un-anonymised images
1122 2003-10-31 Jean-Pierre Roux
1123 * RMV : removal of useless jBitsInJsample.h
1124 for both 8 and 12 Bits JPEG Lossy Libraries
1126 2003-10-31 Jean-Pierre Roux
1127 * ENH : Add the functions gdcmFile::GetImageDataRaw
1128 gdcmFile::GetImageDataIntoVectorRaw
1129 that act as GetImageData and GetImageDataIntoVector
1130 except the making of an RGB Plane from Gray Plane + LUT
1131 Intended to aware (vtk) users who know how to manage
1134 GetLUTRGBA return a R,G,B,A LUT if any
1135 lgrTotaleRaw gives the 'Raw' length
1136 GetImageDataRaw returns the gray Plane
1137 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1138 (They stay Grey, just like with other Dicom viewers :-(
1140 2003-10-30 Jean-Pierre Roux
1141 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1143 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1144 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1145 being coherents dicom files.
1147 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1148 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1150 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1151 * ENH: Two steps is necessary to please VC++ compiler...
1152 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1153 * ENH: Add include dir to medcon lib
1154 * FIX: only one function is being exported for now !
1155 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1157 2003-10-29 Jean-Pierre Roux
1158 * adding gdcmHeader::GetLUTRGBA
1159 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1160 --> Mathieu, the modif u're waiting for is not yet committed
1161 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1163 2003-10-27 Jean-Pierre Roux
1164 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1165 00191113.dcm DermaColorLossLess.dcm
1166 MxTwinLossLess.dcm RadBWLossLess.dcm
1167 * ENH: For version prior to vtkImageViewer2 -r 1.19
1168 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1170 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1171 * Removal of ido stuff in CMakeLists.txt
1173 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1175 * FIX: remove a call to ->Modified ... see comments
1176 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1178 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1179 * FIX: Problem with path for libvtkgdcmPython
1180 * ENH: Try adding a search script for python site-package
1181 * RMV: Remove some file from medcon lib that are not necessary
1182 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1183 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1184 * FIX: More pragma disable fro VC++,
1185 I don't think I break something as it is also disable in VTK/ITK.
1186 But it fasten debug compilation time.
1188 2003-10-23 Jean-Pierre Roux
1189 * gdcm now deals with 16 Bits Run Length Encoded images
1190 (they are compressed as 2 planes images,
1191 one for the high Bytes, the other for low Bytes)
1193 2003-10-22 Jean-Pierre Roux
1194 * Now CheckRead takes into account :
1195 - the bugged 'Leonardo' Siemens images
1196 - the XA images, sent thru the burning VPRO station
1197 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1200 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * FIX: When copying a Makefile.am to CMakeLists.txt
1202 one should remove the '\'
1204 2003-10-22 Jean-Pierre Roux
1205 * in gdcmData adding a bugged 'Leonardo' Siemens image
1206 (wrong lengths in header)
1207 OK with gdcm, KO with the other viewers :-)
1208 * add a GE dlx XA image, thru the VEPRO burning station
1211 2003-10-21 Jean-Pierre Roux
1212 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1213 for a brutal checking of vtkgdcmViewer compliance
1215 2003-10-21 Jean-Pierre Roux
1216 * add the files for 'xmedcon' Jpeg Lossless library
1217 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1219 2003-10-21 Jean-Pierre Roux
1220 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1222 2003-10-21 Jean-Pierre Roux
1223 * garbage Siemens 'Leonardo' images dealt with
1224 (the patch is easy to remove)
1225 * cosmetic changes to avoid warnings
1227 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1228 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1229 no need to press 'r' now.
1231 2003-10-20 Jean-Pierre Roux
1232 * upgrade of checkRead.sh checkWrite.sh according
1233 to new Jpeg Lossless decompressor
1234 * add US.3405.1.dcm, a genuine RGB medical file ...
1235 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1236 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1238 2003-10-15 Jean-Pierre Roux
1239 * general anonymisation in gdcmData
1240 * adding the 'color files' from
1241 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1242 * adding some well knowed bugged-header images
1243 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1244 waiting for their inclusion in Python testsuite
1246 2003-10-15 Jean-Pierre Roux
1247 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1248 no longer seg faults when file is not found
1250 2003-10-14 Jean-Pierre Roux
1251 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1254 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1255 * TODO: *.in file to genereate a UseGDCM later
1257 2003-10-14 Jean-Pierre Roux
1258 * Some supposed-to-be Dicom Images have no preamble.
1259 OpenFile takes it into account
1260 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1261 * Missing elements added in dicomV3.dic
1262 (just to be affraid : have a look at
1263 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1264 and do it again next year ;->
1266 2003-10-13 Jean-Pierre Roux
1267 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1268 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1269 But there are NOT. It's fixed !
1271 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * FIX: "jpeglib.h" was not found on VC++
1273 * FIX: vtkgdcm was not being installed
1275 2003-10-10 Jean-Pierre Roux
1276 * ENH : OpenFile closes the file if it *really* doesn't look like
1277 an ACR-NEMA / DICOM one.
1278 * FIX : testWrite no longer writes an empty file if the source file
1279 is not gdcm Readable
1280 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1283 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1284 * FIX: CMake generate now documentation
1285 * ENH: out of source doc build !
1286 * ENH: Generate both user and dev documentation
1287 * ENH: Should work on windows too
1288 * ENH: Only one doxygen config.in file is needed
1289 * FIX: make install should be ok now on ùnix plateform
1290 * FIX: PATH to dictionary was wrong (missing /)
1291 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1293 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1294 * vtkGdcmReader is now able to read rgb dicom file.
1295 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1296 * added a gdcmViewer to vtk test, use mouse to control
1297 window level & window width
1299 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1300 * CMake-ification of gdcm, we have now two build system
1301 * FIX: on cygwin Wsock32 doesn't exist
1302 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1304 2003-10-06 Emanuel Ollart
1305 * FIX : compilation process wad broken.
1306 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1308 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * change gdcmViewer -> vtkgdcmViewer
1310 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1312 2003-10-06 Jean-Pierre Roux
1313 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1314 ( e.g : well known GE images with a wrong elem length,
1315 : Philips MRI Images with a wrong Huffman table)
1316 * still to be done : allow the reading of bugged LEONARDO Siemens images
1318 2003-10-03 Jean-Pierre Roux
1319 * Odd length strings are padded with '\0' (not with spaces,
1320 to remain compliant with already defined strings,
1321 like Transfert Syntax UID and others)
1323 2003-10-03 Jean-Pierre Roux
1324 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1325 to allow displaying RGB images (not only by affim ;-)
1327 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * vtkGdcmReader is now able to read rgb dicom file.
1329 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1331 2003-10-03 Jean-Pierre Roux
1332 * A few nasty patches to allow the reading of a lot of nasty images
1333 ( e.g : well known GE images with a wrong elem length,
1334 : Philips MRI Images with a wrong Huffman table)
1335 * still to be done : allow the reading of bugged LEONARDO Siemens images
1337 2003-10-03 Jean-Pierre Roux
1338 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1340 2003-10-03 Jean-Pierre Roux
1341 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1342 to allow displaying RGB images (not only by affim ;-)
1344 2003-10-03 Jean-Pierre Roux
1345 * gdcmFile::GetImageDataIntoVector now
1346 - deals with MultiFrames MultiFragments Run Length Encoded files
1347 - deals with YcBcR (YBR_FULL) files
1348 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1349 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1351 (no sample found :-(
1353 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1354 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1355 Two reasons: - clear things
1356 - third parties acces gdcm through header files, so won't
1357 suffer anymore VC++ complains
1359 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1360 * add argv[1] in testvtkGdcmReader.cxx
1363 2003-09-24 Jean-Pierre Roux
1364 * The lines are now eigthy characters long.for
1365 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1367 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1368 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1369 char* to std::string. Thus, the use of strdup becomes useless. (see
1370 previous commis of Malaterre)
1371 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1372 before the last Malaterre's commit.
1374 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1375 * This commit should fix the Debug building under VC++, the problem
1376 was mainly a mixture of debug and release lib being loaded at startup.
1377 * I also remove a depency to a specific C function: strdup. Because I had
1378 to force the link to msvcrtd (whereas strdup is in libc).
1380 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1382 located in the gdcmCommon.h file. All use of reference of tha has been
1383 changed to now use the variable GDCM_UNFOUND.
1385 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1387 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1388 Dicom dictionary. The test suite can now be run again. Note:
1389 I'm note very happy with the " (RET)" changes. I believe this
1390 RETAINED comment should be dropped when parsing the dictionary.
1391 - PACKAGER corrected
1393 - AUTHORS updated and now in alphabetical order
1394 * Makefile.am now exports gdcm.dsw for Windoze users.
1396 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1397 * cygwin complains about missing std:: in subdir Test/
1399 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1400 * remove some methods that are now in gdcmHeaderHelper
1402 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1403 * vtkGdcmReader set spacing and origin correctly
1405 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1406 * Fix a few delete/delete[] mismatch
1408 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1409 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1410 interpretation to data given by gdcmHeader. For instance there are
1411 heuristics to get informations (look at different places).
1412 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1413 sorting DICOM images based on different strategies.
1414 * modified Makefiles accordingly.
1416 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1417 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1418 when building in debug mode
1419 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1420 src/win32/gdcmdll.dsp
1421 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1423 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1424 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1427 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * src/win32/libgdcmjpeg12.dsp was not dos format
1429 * src/win32/libgdcmjpeg12.dsp :
1430 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1431 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1433 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1436 * src/gdcmFile.cxx : bug fix in affectation type
1437 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1438 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1439 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1440 symbols... future problem ?
1442 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1443 * src/win32/libgdcmijpeg12.dsp was missing
1444 * modified gdcm.dsw accordingly
1446 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1449 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1450 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1451 commit of JPR (before his hollidays to facilitate our work).
1452 * setup.py : bug fix in code. Modifications made while the last commit
1453 of JPR. The code hasn't been tested before the commit... it's so
1454 useless to make that (for best programmer that is JPR) !!!
1456 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1457 * tagged the current version as Version0_3 (i.e. version 0.3)
1459 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1460 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1461 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1462 * *.dsp : modifications to use new libgdcmijpeg8 library
1463 * setup.py : bug fix on VTKPATH variable
1464 * PACKAGER : adding all concerning windows
1466 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1469 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1470 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1471 test suite reported error.
1472 * PACKAGER file added (describes what a packager must do when
1473 packaging a new release).
1474 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1475 * configure.in: upgraded version number to 0.3.0
1476 * fixing build of rpm (through rpm -ta):
1477 - Doc/Makefile.am exports proper doxygen files
1478 - src/jpeg/libijg8/Makefile.am exports the include files.
1480 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1482 * src/gdcmHeader.h : formatting code
1484 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1485 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1486 We were obtaining error message from vtk. Now, creation of file list
1487 is made in an internal list to prevent this problem.
1488 Bug fix when output is empty.
1489 Bug fix in update of progress value. Previous commit for this was a bad
1491 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1493 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1494 * src/gdcmHeader.h : added method to get the file name
1495 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1496 files. Added method to remove all files on the input
1497 Added FIXME comment concerning the bad parsing of header made by
1498 ExecuteInformation method (in ExecuteData method)
1500 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1502 when using make instal.
1503 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1504 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1506 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * setup.py : adding include dir of jpeg lib to compile all sources
1508 * */Win32/*.dsp : JPR fix for windows compilation
1510 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1511 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1513 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1514 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1516 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * setup.py is again effective on un*x (takes into account the
1518 addon of the jpeg library)
1519 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1520 * Doc/Doxy* updated (includes above enhancements)
1521 * INSTALL now points to web documentation
1523 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * src/gdcmHeader.h doesn't make unnecessary reference to
1526 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1528 * src/gdcm*.[cxx|h] :
1529 - to allow compilation with gcc 3.x
1530 -- clean up of STL usage (added explicit usage of std::)
1531 -- small fixes on exceptions.
1532 Note: linking not tested !
1533 - clean of doxygen comments to avoid warnings at documentation
1535 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1536 dependent convertion).
1538 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * Clean up of previous JPR garbage commit (not even commented in the
1541 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1542 - moved all jpeg related files from src to src/jpeg/libijg8, with
1543 addition/modification of Makefile.am and configure.in.
1544 - the testSuite is still brain damage (not guilty).
1546 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1547 * WrapVTK.py : modifications to get correctly vtk source files to
1549 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1550 (FileName -> Filename)
1552 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1553 * vtk/vtkGdcmReader.[cxx/h]:
1554 - UpdateProgress method should now be effective
1555 - removed the limitation on having only images loaded (as opposed
1557 - when building a stack of images/volume, a lesser number of
1558 gdcmHeader and gdcmFile instances should be used (hopefully
1559 accelerating things).
1560 - when building a stack of images/volumes, files which are not
1561 loadable (wrong path-filename, wrong permissions on existing file,
1562 or file not parsable by gdcm) are replaced with a black image
1563 in the stack (for the caller to notice the problem).
1565 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1566 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1568 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1569 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1570 between standard library (std) and vtk library (problems are found
1571 under Windows... thanks Windows !)
1573 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1576 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1578 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1581 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * When compiling with distutils (see setup.py) the C++ compiler is
1583 called with different flags than the default ones (with automake).
1584 In order to fix all those warning, I compiled gdcm with the command
1585 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1586 and went for warning fixes:
1587 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1588 up from unused variables.
1589 - vtk/vtkGdcmReader.cxx: potential bug fix.
1590 * src/gdcmHeader.h: Doxygen warning cleanup
1592 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1593 * gdcmPython/gdcm.i:
1594 - typemaps correction to take into account the systematic replacement
1595 of "using namespace std" with std:: prefix e.g. std::list,
1596 std::string... (cf changes of 2003-05-21).
1597 - gdcmGlob global variable of type gdcmGlobal (defined in
1598 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1599 exported to Python a as cvar.
1600 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1601 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1602 gdcmDictSet.GetPubDictTagNames() and
1603 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1604 C++ static methods).
1605 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1606 with the above changes.
1608 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1609 * setup.py, manifest.in : bug fix under linux
1611 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1612 * Modification of setup.py to compile vtk part too. Then, we have 2
1613 wrappers which must work with same distutils. For that, we have a
1614 generic distutils in distusiltsWrapping.py ; with :
1615 - build_extWrap class to wrap generically all extensions,
1616 - ExtensionWrap base class for all wrapping extension that contains
1618 - Wrapper interface which wrap sources
1619 + In WrapSwig.py we have extension and wrapper for Swig
1620 + In WrapVTK.py we have extension and wrapper for VTK
1621 * MANIFEST.in : modifications to consider vtk directory and new python
1622 files for compilation
1624 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1625 * Added python wrappers of vtkGdcmReader vtk class (see the
1626 source in vtk/vtkGdcmReader.cxx) :
1627 - vtk/Makefile.am now builds a library
1628 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1629 python library (as opposed to _gdcm.so wich are the python
1630 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1631 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1633 - configure.in has an additional flag --enable-vtk that needs
1634 to be set to enable compilation of vtk related code, that is:
1635 + vtk/vtkGdcmReader.so and
1636 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1637 + gdcmPython/vtkgdcmPython.so (see above)
1638 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1639 be read when compressed or when HighBit + 1 != BitsStored),
1640 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1641 the usage of the python wrapper of vtkGdcmReader vtk class.
1642 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1643 * src/*.[h] all occurences of stl classes are now prefixed with
1644 std::, and all occurences of "using namespace std;" where removed.
1645 This is to avoid pollution of global namespace in included files.
1646 Apparently vtk does not avoid this pitfall: when using both
1647 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1648 collision of various stl members (principally cout...).
1649 * gdcmPython/testSuite.py now cleanly removes temprory generated
1651 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1652 comply with above changes)
1654 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1655 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1656 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1657 vtk data structure (an image Flip was required).
1658 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1659 * cosmetic changes in documentation.
1661 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1662 * src/gdcmHeader.cxx: the constructor no longer exits when an
1663 unexisting file is given as argument.
1664 * The subdirectory Data (containing all the images used for the
1665 test suite) is not part of this repository anymore. A new module
1666 containing those images is now available at
1667 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1668 with the name gdcmData.
1669 All the python scripts (including the package initialisation file
1670 gdcmPython/__init__.py) were adapated to take this change into
1671 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1673 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1674 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1675 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1676 demo of the usage of this class.
1677 Compilation of this vtk part is only done when using the --enable-vtk
1678 at configure (or autogen.sh) stage.
1680 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1681 * More memory link related corrections and documentation fixes.
1683 - maximum info is obtained with a command of the form:
1684 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1685 --show-reachable=yes PrintHeader
1686 - the remaining reachable blocks seem to come from the STL
1687 allocation scheme through the usage of map and list. It looks
1688 like this memory cannot be freed but it is not a memory leak
1689 (in fact further invocation to the STL would recollect the
1690 unused memory allthough it cannot explicitely be freed).
1691 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1692 of displaying an image parsed with gdcm and displayed with VTK.
1693 Note: some images don't seem to work e.g.
1694 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1695 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1696 Allthough this weakens the semantics, it is a ditch attempt to
1697 make gdcm more thread friendly.
1699 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1700 * Memory link hunt (by using valgrind through the command
1701 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1702 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1703 gdcmHeader::_dicom_vr.
1704 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1705 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1707 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1709 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1710 * src/Makefile.am now exports all the necessary include files at
1714 * UpdateGroupLength replaced by new one
1717 * UpdateGroupLength re-written using H-Table
1718 (named UpdateGroupLengthNew untill checks are over)
1720 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1721 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1722 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1724 - gdcmHeader::GetPubElValSet removed.
1725 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1726 UpdateGroupLength, WriteElements, Write.
1727 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1728 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1729 carried the same semantics.
1730 - src/gdcmHeaderIdo.cxx changed accordingly.
1731 - gdcmFile::WriteBase now regroups all the codes from previous
1732 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1733 - enum FileType moved to gdcmCommon.h
1734 * src/gdcmHeader.cxx AddDefault trashed
1735 * gdcmGetXSize added
1736 * getimageDataSize now calls gdcmGetXSize
1737 * Test/*.cxx changed to agree with above changes
1739 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1741 (to avoid double call by end user).
1742 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1743 by end user, since gdcmHeader::gdcmHeader now handles it.
1745 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * gdcm/Doc many doxygen changes:
1747 - Doxyfile now has two different versions, DoxyfileUsers that generates
1748 the html.users end users oriented documentation and
1749 DoxyfileDeveloppers that generates the html.developper developper
1750 oriented documentation.
1751 - README changed accordingly
1752 - requirement.txt removed (old design info moved to TODO).
1753 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1754 DoxyMainPage.txt, DoxyPython.txt provide more information.
1755 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1756 be updated by simply regenerating the docs with doxygen and copying
1757 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1758 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1759 all the tests in the form "if (<map>.count() >1)" were removed.
1760 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1761 ill-formed documentation sections.
1762 * src/gdcmHeader.cxx: ditto
1764 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1765 * setup.py fixed for un*x (needed macro for stdint.h)
1766 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1767 un*ces with sh-utils test utility.
1768 * gdcmPython/demo/test.py renamed to PrintHeader.py
1769 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1770 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1771 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1772 * src/gdcm*.cxx JPR's bad inclusion fixed.
1774 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1775 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1776 * gdcmPython/demo/test.py changed accordingly.
1778 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1779 * gdcmPython/Makefile.am fixed linking against libstdc++
1780 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1781 * Swig subdir (historical tests of swig version 1.3.17++) removed
1782 * Test/testChangeEntete.cxx some lines commented out in order to make
1784 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1785 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1787 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1789 hence the user doesn't need this explicit call.
1790 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1791 i.e. LoadElements() call removed.
1792 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1793 - src/Makefile.am declares the proper flag for g++.
1794 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1795 for adding user defined new tags.
1796 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1797 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1798 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1800 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1801 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1802 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1803 src/Makefile.am : the project should properly compile and install
1804 with the autotools, included the python wrappers part.
1805 * gdcm.spec.in : added a spec file for RPM packaging.
1807 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1810 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1811 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1812 to exported to the environement (see gdcmPython/testSuite.py
1814 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1815 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1816 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1817 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1818 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1820 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1821 * gdcmPython/__init__.py doesn't crash anymore when running in
1822 in InstallMode or PreInstallMode but with an environement given
1823 value of GDCM_DICT_PATH.
1824 * src/gdcmDictSet.[cxx/h] coding style.
1826 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1827 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1828 * src/gdcm.h general comments moved to TODO, and README
1829 * src/gdcm.h should now be seen as a user commodity (including it
1830 should suffice to fully use gdcm). It is nowhere including within
1831 any of the kernel files src/*.cxx and src/*.h.
1833 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1835 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1837 * src/gdcm*.cxx only include their corresponding include file
1838 (as opposed to gdcm.h)
1839 * gdcmPython/gdcm.i changed accordingly
1840 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1841 the autogen.sh generated "make snapshot" command to work.
1842 * autogen.sh removed history related references to crea package.
1844 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1845 * distutilsSwigCPlusPlus.py work around some swig portability
1848 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1849 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1850 was done in a last ditch attempt to get setup.py _really_
1851 operationnal. The python/gdcmPython layaout add the advantage
1852 of hidding away the python related distutils specific files
1853 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1854 Alas, the src directory was out of scope (i.e. it's relative
1855 position to setup.py was ../src) which made things impossible to
1856 handle (see previous version of python/setup.py). Crossing fingers...
1858 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1859 * python/setup.py now works on Un*x. (harder than I thougth)
1860 * python/distutilsSwigCPlusPlus.py can now have include files
1861 among the list of sources.
1863 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1864 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1865 * modifications in MSVC projects
1867 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * As stated by the first lines of Test/ExceptionAndPython/README, it
1869 looks like we can move back to original usage of exception within
1870 src/gdcm* and hence remove the errno stuff that was introduced
1871 as a quick and dirty fixture of this problem (added to the TODO).
1872 * Doc/Doxyfile configuration file for Doxygen and corresponding
1873 README file for usage added.
1874 * Test/testWrite.cxx added. This new test comes from a split of
1875 test.cxx that is now reverted to its original purpous i.e.
1876 testing the proper parsing of a Dicom related file.
1877 testWrite.cxx concentrates on testing the IO part of gdcm.
1878 * Test/bug1.cxx (containing a bug on WIn32) added.
1879 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1880 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1881 whose purpose is to publish the content of the TagNames of the
1882 Dicom public dictionnary were not accessible without an
1883 instance of class gdcmHeader.
1884 - those methods are now static methods of gdcmDictSet and hence
1885 require no instances at all to be invocated.
1886 - within gdcmDictSet this change required to change some method
1887 to class methods (i.e. are now static) among which SetDictPath
1888 (renamed to BuildDictPath) and LoadDefaultPubDict.
1889 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1890 the above changes by calling the new method classes of gdcmDictSet.
1891 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1892 the above to be effective.
1893 * python/gdcmPython: in order to wrap properly the above changes
1894 for Python, swig version now needs to be > 1.3.17.
1895 * python/gdcmPython/Makefile fixed to adapt itself to new
1896 configure/make shema introduced by Johan Montagnat (thanks for the
1897 contribution). Alas this Makefile cannot be turned into a proper
1898 Makefile.am without some heavy changes in the configure.in
1899 (for python dectection).
1900 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1901 now avoids publishing the empty entries.
1903 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1904 * python/setup.py : bug fix concerning install under windows
1905 ExtraPath reused :-P
1906 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1908 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * Dicts/dicomV3.dic : remove double spaces !!!
1910 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1911 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1914 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1915 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1916 method. Doxygenation.
1917 * src/gdcm.h clean up of JPR spurious comments.
1919 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1920 * python/distutilsSwigCPlusPlus.py now properly collects the
1921 shadow classes generated by "swig -c++" (gdcm.py in our case)
1922 when using "python setup.py install".
1923 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1924 reexports the working classes.
1925 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1926 by the classical C errno scheme. This is to prevent an obscure
1927 behavior of the python wrappers when importing wxPython.wx prior
1928 to gdcmPython (which ended up in an abort call). An illustration
1929 of this oddity can be found in the Test/ExceptionAndPython
1930 subdir (see the README file). This problem probably due to
1931 an combination of g++ and dynamic loading.
1932 * added Test/ExceptionAndPython (see above)
1934 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * Changed the layout of the python part to avoid bloating main
1936 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1937 i.e. the distutils arsenal. All the python related stuff is
1938 again in a python subdir, but the package itself is now in
1940 * setup.py was cleaned up:
1941 - pythonIncludePath removed
1942 - python setup.py bdist target is now functional.
1943 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1944 collision with other packages). gdcmPython/demo/*.py changed
1947 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * python subdir moved to gdcmPython (preparation of distutils packaging).
1949 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1950 distutils installer is operational.
1951 * - gdcmPython/__init__.py now properly loads the swig generated
1952 shadow classes (from gdcm.py).
1953 - gdcmPython/demo/*.py changed to import the package gdcmPython
1954 instead of gdcmPython/demo/load.py.
1955 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1957 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1958 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1959 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1960 entries within the associated public Dicom dictionary resp. the same
1961 information but sorted by the fourth field (PAT, IMG, DIR) of the
1963 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1964 are now in the "???" group.
1965 - python/gdcm.i changed accordingly,
1966 - python/demo/printGroupedPublicDict.py added, that gives an example
1967 of the above new functionalities in Python.
1969 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * src/gdcm.h, gdcmHeader.cxx:
1971 - historic references to glib's g_malloc and g_free (#defined)
1972 were definitively removed.
1973 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1974 * src/gdcmElValSet.cxx:
1975 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1976 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1977 - GetElValue(string) renamed to GetElValueByName.
1978 - Added GetElementByName(string).
1979 * src/gdcmHeader.cxx: added
1980 - GetPubElValRepByNumber(guint16, guint16)
1981 - GetPubElValRepByName(string)
1982 - GetShaElValRepByNumber(guint16, guint16)
1983 - GetShaElValRepByName(string)
1984 - GetShaElValByNumber(guint16, guint16)
1985 - GetShaElValRepByName(string)
1986 - GetElValRepByNumber(guint16, guint16)
1987 - GetElValRepByName(string)
1988 - GetElValByNumber(guint16, guint16)
1989 - GetElValRepByName(string)
1990 * Doc/requirements.txt added.
1992 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1993 * Test/Makefile building now depends on the one of libgdcm.so
1994 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1995 pixel data) aware which enables finding the address (offset) of
1996 the pixel data of JPEG encoded DICOM files. This leaves only a single
1997 file in the testSuite whose pixel data address (offset) is unknown.
1998 * python/testSuite.py changed accordingly.
2000 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2001 * VC++ has some strong limitations when working with the STL, as stated
2002 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2003 "Also note that some STL containers (map, set, queue, list, deque)
2004 cannot be exported. [...]
2005 Some STL classes contain nested classes. These classes can not
2007 This is caused by a designed limitation that once a template
2008 class is instantiated, it can not be re-instantiated and
2010 Since our usage of map<> is ubiquitous in gdcm, this "designed
2011 limitation" of VC++ is a pitfall.
2012 Hence the Python wrappers of gdcm cannot be incrementally linked
2013 against the c++ dynamic library. The dirty but only workaround is
2014 to forget about incremental link of dynamic libraries and to generate
2015 the Python wrappers library with the inclusions of the underlying C++
2017 The following modifications concern this matter on Win32/VC++:
2018 - wrapping python correct with standalone wrapped dll (don't use separate
2019 dll under windows !!!!)
2020 - python21_d debug mode enabled (ask Frog how to use it :-)
2021 - NO problem with having an STL member of class for example string in C++
2022 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2023 - Python test of dcmlib in Python is ok under windows on a large set
2025 * removed glib references
2026 * typedef's inserted in gdcm.i for correct swig type management
2028 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * python/demo/*.py load.py extracted from test.py. Added explore.py
2030 that only displays required tags and testAll.py that parses all
2031 the files of the testsuite without using unittest.
2032 * python/testSuite.py other additional test on new files added.
2033 * Data/* new test files added accordingly to the testSuite.
2034 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2035 the vr in the file differs from the one of the dictionary.
2037 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2038 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2039 values, but limits itself to values which are below a user specified
2040 size (by default 1024 bytes).
2041 * python/gdcm.i : elements not loaded (because their size is above the
2042 user specified treshold) are exported with their TagKey as key of the
2043 python dictionary. This enables the testsuite to make some checks
2044 on the unloaded elements (since we have their offset and size).
2045 * python/testSuite.py
2046 - now tests for the existence and proper value of the pixel data
2047 - two new examples added.
2048 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2050 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2052 aware. See the strategy comments in gdcmHeader::FindeLength().
2053 * Test/test.cxx now accepts a filename as first argument.
2054 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2055 * python/testSuite.py changed to integrate test on above files.
2057 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2059 the vr was also RET.
2060 * python/testSuite.py more tests added.
2062 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * python/testSuite.py unittest test suite added (uses Data)
2064 * Data/* dcm and acr files for the test suite.
2065 * glib dependance removed from un*x version. We now use ISO C99
2066 7.18 Integer types (see stdint.h)
2067 - python/Makefile, src/Makefile src/gdcm.h
2068 * src/ when an explicit vr (like dicom files) suddenly poped an
2069 implicit element we use to mark the underlying DictEntry of the
2070 concerned ElValue with "Implicit". This strategy was damageable
2071 too the public or provite dictionaries, since some of their vr
2072 would be changed. Since Header::FindLength heavily relies on the
2073 detection by Header::FindVR of falsely explicit elements, I
2074 added an extra ImplicitVr member to ElValue (boolean).
2075 The rest of the changes we the necessary adaptations.
2077 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2080 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2082 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2083 * Adaptation for porting to VC++:
2085 o forced to use std namespace (for string to be known)
2086 o all class use __declspec export style on WIN32
2087 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2088 (in stdlib.h on Win32 but in std:: for gcc)
2089 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2090 variable GDCM_DICT_PATH.
2091 * src/gdcmHeader.cxx verbose comments made discrete.
2093 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * python/gdcm.i: added a typemap that converts a C++ hashing table
2095 to native Python dictionary.
2096 * python/demo/test.py:
2097 - now uses the native dictionary for exploration of gdcmHeader.
2098 - takes an optional filename argument (the file to parse).
2099 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2100 PubElVals hashing table.
2101 * Dicts/dicomV3.dic removed error prone trailing spaces.
2103 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * Python wrapping process moved away from src/Makefile to
2105 newly created python/Makefile (as well as gdcm.i)
2106 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2107 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2108 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2109 from the environement variable GDCM_DICT_PATH (when existing).
2110 * src/gdcmDict::GetTag bug fix.
2112 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * Straightforward temporary fixes for swig to build the python wrappers.
2114 src/Makefile now has a python working entry [by working we mean
2115 that we can import de shadow classes without errors].
2117 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * hashtest.cxx removed (since allready in Test)
2119 * src/gdcmlib.h renamed to src/gdcm.h
2120 * src/dcm.i renamed to src/gdcm.i
2121 * src/Makefile prepared for python wrapping
2123 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * src/gdcmHeader.cxx :
2125 - Parsing of header is now separated from loading of element values
2126 (see gdcmHeader::LoadElements).
2127 - general clean up of hopefully all file access (creation of
2128 ReadInt16 and ReadInt32)
2130 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * src/gdcmHeader.cxx :
2132 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2134 - SetLgrElem renamed to SetLength
2135 - GetLgrElem renamed to GetLength
2136 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2137 * src/gdcmElValSet.cxx fixed both GetElValue methods
2138 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2139 due to IdoDude was cleaned out.
2141 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2143 concentrates on finding the value representation (when it exists).
2144 RecupLgr now only finds the element value length, and it avoids
2145 returning the unecessary skL (skipped length).
2146 Also, offsetCourant was simply removed (with taille_fich) since
2147 it was redundant with the File position internals (by using
2148 ftell and fseek). This also made skL (see above in RecupLgr) usage
2150 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2151 on the libido specificities which are handled through class
2153 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2156 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * Truckload of changes. Parsing of header is barely functional
2158 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2160 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * src/gdcmHeader.cxx many addons of low level methods
2163 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2165 and _IdDcmSWAP_LONG.
2167 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * This corresponds to all the changes decided at the meeting of
2169 May 23 2002. Needless to say we are running late...