1 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Test/CMakeLists.txt: update to follow gdcmData renamings.
3 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
5 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
6 * ENH: added some utility method that builds a flat dictionnary
7 holding all the Dicom entries contained in the recursive structure
8 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
10 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
11 BuildFlatHashTable() that build a flat dictionary.
12 - src/gdcmElementSet.h: added a new private GetTag() accessor.
13 gdcmDocument is now a friend of gdcmElementSet.
14 - src/gdcmElementSet.cxx: clean up.
15 - Example/FlatHashTablePrint.cxx added.
16 - Example/CmakeLists.txt changed accordingly
18 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
19 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
20 moved away from gdcmDocEntrySet (since this class is an abstract class
21 acting like an interface). SQDepthLevel and BaseTagKey are now
23 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
24 and associated accessors. Doxygenation of the class.
25 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
27 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
28 Use SQDepthLevel accessor instead. ::Print() adapted.
29 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
30 - src/gdcmDocument.cxx changed accordingly.
32 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
33 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
34 - The following is the doxygen comment of the typedef declaration
35 of gdcmagKey in src/gdcmCommon.h:
36 gdcmTagKey is made to old an "universal" (as in URL, Universal
37 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
38 A dicom tag allways has a group and an element, but a set of tags
39 embeded in various (optionally nested) sequences and sharing
40 the same group and element all share the same (group, element)
41 "identifier". Hence the (group, element) cannot be used as an
42 identifier (in gdcm we shall refer to a "TagKey") of a tag.
43 In order to construct a proper tag identifier (i.e. a key) we
44 consider the following definition of a TagKey:
45 - let Group, Element be the string representation of the
46 group and element dicom tag members,
47 - let ItemNumber be the string representation of the integer
48 index of the considered item number of a sequence,
49 Let the key of a tag embeded in a sequence, noted SeqTag, be
51 /ItemNumber#Group|Element
52 where "/", "#" and "|" are characters acting as separators.
53 Then the general form of a gdcmTagKey is given by:
55 where <SeqTag> means NO or many instances of SeqTag.
56 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
59 but the gdcmTagKey of a tag "embeded" is the first item of
60 a sequence, itself nested in the third item of a sequence is the
62 0004|1220/2#0008|0082/0#0008|0090
63 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
64 order to hold the new sequence compatible key. Previously, the
65 GetKey() method would look in the underlying gdcmDictEntry.
66 - src/gdcmDocEntry.cxx:
67 -- constructor now copies the underlying DictEntry key, in the local
69 -- ::Print: displays the member Key, instead of the (group, element).
70 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
71 - src/gdcmDocEntrySet.h:xi
72 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
73 -- now has a new BaseTagKey member.
75 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
76 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
78 This poses the problem with the semantics of the following lines
79 LoadEntryVoidArea(0x0028,0x1201); // R LUT
80 LoadEntryVoidArea(0x0028,0x1202); // G LUT
81 LoadEntryVoidArea(0x0028,0x1203); // B LUT
82 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
83 to the long FIXME note for what the problem is. Nevertheless in
84 order to get things working the dicom dictionary was altered !
85 Please fix things urgently...
86 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
87 information), see above note on moving the member VoidArea. Nevertheless
88 the following entries previously correctly set as US are now inproperly
90 0028 1201 OW IMG Red Palette Color Lookup Table Data
91 0028 1202 OW IMG Green Palette Color Lookup Table Data
92 0028 1203 OW IMG Blue Palette Color Lookup Table Data
93 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
94 of gdcmDocEntry moved to gdcmSeqEntry.
95 * src/gdcmSeqEntry.cxx: STYLE.
97 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * Test/TestAllEntryVerify.cxx minor fix and added comments.
100 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
101 * gdcmPython/testSuite.py: all the test suite in python is now moved
102 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
103 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
104 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
106 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
107 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
108 to avoid inclusion recursion until STL is reached.
109 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
110 mecanism. errno.h is not included in gdcm anymore.
111 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
112 (gdcmFormatError now inherits from gdcmFormatUnexpected).
114 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
115 gdcmData/TestAllEntryVerifyReference.txt
116 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
117 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
118 exception_on_error parameter.
119 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
120 - vtk/vtkGdcmReader.cxx changed accordingly,
121 - Example/*.cxx and Test/*.cxx changed accordingly.
123 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
125 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
126 enable_sequences removed from gdcmHeader constructor and dependencies.
127 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
128 * gdcmPython/demo/PrintHeader.py: dummy fix.
129 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
130 skip_shadow removed from gdcmHeader constructor and dependencies.
131 * Example/*.cxx and Test/*.cxx changed accordingly.
133 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
135 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
137 2004-07-21 Jean-Pierre Roux
138 * FIX Now, Parsing and Printing a DICOMDIR do work!
139 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
141 2004-07-20 Jean-Pierre Roux
142 * FIX Some brain damaged headers have Zero-Lenght fields
143 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
145 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
147 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
148 variable (instance of gdcmDebug) by a definition macro, and the instance
149 is now in static in the gdcmDebug class
150 * src/gdcmSQItem.h : (FIXME) remove an undefined method
151 * Test/PrintAllDocument.cxx : bug fix in the result of the test
153 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
154 * WARNING: ctest now depends more tightly on gdcmData. You should
155 check out gdcmData properly for things to run smoothly...
156 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
157 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
158 we need the pixels not be loaded in order to use the ValEntry
159 that displays position and size).
160 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
161 This is a C++ based equivalent of gdcmPython/testSuite.py that should
162 be deprecated. If you have any doubts about the advantages of a
163 modern scripting language (read Python) versus grass root C++ (i.e.
164 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
165 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
166 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
167 Anyhow, consider documenting the gdcmData images in
168 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
170 * Test/CMakeLists.txt:
171 - now uses TestAllEntryVerify.cxx
172 - specific comments on oldACR00001.ima (now renamed in gdcmData
173 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
174 gdcmData/TestAllEntryVerifyReference.txt
177 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * src/*.[h|cxx] : typedef clean up
179 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
180 - TagKey renamed to gdcmTagKey (for external usage)
181 - VRKey renamed to gdcmVRKey (for external usage)
182 - removal of typedef duplication.
183 - Removed all unecessary inline keyword from class inline definitions.
184 - Some method|function(void) declarations replaced with method|function().
185 * src/jpeg/libijg12/jdhuff12.c:
186 - printf polluting ctest removed.
187 - TAB removal for comminting
189 - TestAllReadCompareDicom.cxx: added a test that compares all the
190 images in gdcmDataImages.h with corresponding images in
191 gdcmData/BaselineDicom/. When baseline images are not present
192 this test creates them.
193 Note: we need to validate each reference image, but before that
194 I'd like to rename them with a more explicit name...
195 - CMakeLists.txt: changed accordingly.
196 * Example/*.cxx: examples now only include gdcm.h (as opposed to
197 including each header needed).
199 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * Test/*.cxx and Example/*.cxx: moved some examples away from the
201 test suite to the Example directory. Are concerned:
206 - TestWriteSimple.cxx
207 * Test/CMakeLists.txt: added some comments on reasons for black listing
208 image gdcmData/oldACR00001.ima
210 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * Test/CmakeList.txt: removed the following from black list (to be coherent
212 with removal from gdcmData):
213 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
214 - gdcm-MR-PHILIPS-16.dcm
216 Added the following because after last cvs update, they cause
217 ctest -R TestReadWriteReadCompare
219 - gdcm-MR-SIEMENS-16-1.acr
221 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
222 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
223 new comments in this file) we temporarily (sigh) move to a weaker
225 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
226 we don't need to black list the following images anymore:
227 - 8BitsUncompressedColor.dcm
229 - US-PAL-8-10x-echo.dcm
230 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
231 fixes and the beautified code ;-)
232 This fixes the bug introduced in version 1.42 (when beautifying)
233 that made the parsing of 8BitsRunLengthColor.dcm unproper.
234 Note: ctest was blind to this bug (this means we need to still
235 improve the test suite). The bug could be detected by using
236 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
238 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
239 and by displaying the (garbage) produced file temp.XDCM...
241 2004-06-29 Jean-Pierre Roux
242 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
243 - replace by uggly but working old code :-(
244 A lot of things should be OK again.
245 It's really urgent to have a test suite that *tests*,
246 to prevent Frog's beautifying sessions to break all the stuff
247 (twice, withing a fortnigh ...)
249 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
250 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
251 redundancy) to added Test/TestReadWriteReadCompare.cxx
252 * Test/CmakeList.txt: because the compare test of
253 Test/TestReadWriteReadCompare.cxx fails, the following images are
254 black listed: - 8BitsUncompressedColor.dcm
256 - US-PAL-8-10x-echo.dcm
257 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
258 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
259 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
260 and ad-hoc kludge. This kludge is now removed, and on encountering
261 such an image (OB field brain damaged) we set errno. Then in
262 ::FindDocLength() we "fix" the length as being ALL what remains
263 in the file (until EOF). We then proceed, hoping for the best...
264 This fixes a SegFault in ShowDicom when trying to write such an
266 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
267 (because TestWriteRead breaks on it, after a non conformal commit?).
268 ctest now runs properly, except for MakeDicomDir (which was allways
269 broken) and the Python related stuff (still not fixed).
271 2004-06-24 Jean-Pierre Roux
272 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
273 FIX : Test/TestReadWrite now iterates on all the file names
274 (instead of infinite loop)
275 ENH : Test/TestWriteRead now iterates on all the file names
277 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
280 2004-06-24 Jean-Pierre Roux
281 FIX : - now Write drops LUT Descriptors and LUTs (if any)
282 when SamplesPerPixel =3
283 - now Write is no longer confused by
284 'BitsAllocated = 12" and 'BitsStored=12"
285 - "UN" value representation Elements are now written correctly
286 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
287 ENH : - now gdcmHeader has its own Write methods
288 (in order to split the job that has not to be done
291 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
292 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
293 loop on the same image until memory went out.
294 Note: this means we still have gobs of memory loss in PrintDocument
295 * src/gdcmDocument.cxx: fixes problem on parsing on file
296 gdcmData/16BitsJpegLosslessGrayScale.dcm.
298 2004-06-24 Jean-Pierre Roux
299 FIX : Write - All the Sequences and Sequence Item are now written
300 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
301 is added a the end, when necessary.
302 - A lot of brain-damaged images, that were read correctly are
303 now written correctly
304 - length compatible BinEntry are now loaded correctly
305 (even for odd groups)
306 Note : only Explicit Value Representation was checked.
307 (question : is implicit VR really necessary for gdcm ?)
309 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * DEVELOPPER: added a proposition of coding style.
311 * src/gdcmDocEntry.h: removed every inline declaration (for test of
314 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
315 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
316 Use the gdcmDocEntry::Print() and Write() instead.
317 * src/gdcmDocument.cxx: bug fix.
319 2004-06-22 Jean-Pierre Roux
320 FIX : gdcmDocument.cxx
321 - Now we do recognize the JpegLossLess format (there was a misstyping in
322 code 'beautyfication' :-(
323 - Now we automaticaticaly load the Luts, if any
325 2004-06-22 Jean-Pierre Roux
326 In order : to write Sequences, whatever their imbrication level,
327 : to allow user to create his own Sequences
328 a lot of modif where necessary (adding, moving, or virtualising methods)
330 WARNING : save your own sources *before* cvs up !
333 ADD virtual void Write(FILE *fp, FileType filetype);
336 ADD virtual void Write(FILE *fp, FileType filetype);
337 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
340 ADD virtual void Write (FILE *fp, FileType filetype)=0;
341 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
342 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
343 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
344 ADD std::string GetEntryByName(TagName name);
345 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
347 std::string vr = "unkn",
348 std::string fourth = "unkn",
349 std::string name = "unkn");
350 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
351 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
352 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
353 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
354 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
355 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
356 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
357 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
360 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
361 ADD virtual std::string GetEntryByName (TagName tagName);
362 ADD virtual std::string GetEntryVRByName (TagName tagName);
363 REM virtual bool Write(FILE *, FileType);
364 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
365 FILE *_fp, FileType type);
366 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
367 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
368 REM virtual bool WriteEntries(FILE *_fp,FileType type);
369 REM virtual std::string GetEntryByName (std::string tagName);
370 REM virtual std::string GetEntryVRByName (std::string tagName);
371 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
372 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
373 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
375 std::string vr = "unkn",
376 std::string fourth = "unkn",
377 std::string name = "unkn");
378 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
379 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
380 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
381 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
384 ADD virtual void Write(FILE *fp, FileType filetype);
387 ADD virtual void Write(FILE *fp,FileType filetype);
390 ADD virtual void Write(FILE *fp, FileType filetype);
391 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
392 REM std::string GetEntryByNumber(guint16 group, guint16 element);
393 REM std::string GetEntryByName(TagName name);
396 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
398 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
399 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
400 The default constructor invoked by the line
401 gdcmHeader *f1 = new gdcmHeader( header );
402 was gdcmHeader::gdcmHeader(bool) instead of the expected
403 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
404 Hence the parsing wasn't executed... See also below.
405 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
406 as explicit constructor didn't do the trick to fix the above problem.
407 Could anyone explain why ?
408 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
409 properly calls gdcmValEntry::Print() (that was weed out from
410 code related to gdcmBinEntry).
412 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
413 * In order to fix memory leaks:
414 - Test/TestWriteSimple.cxx: added cleaning of free store through
416 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
417 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
418 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
419 (through the call to ::AddDicomDirMeta()) or the destructor
420 would crash when deleting uninitialized ::metaElems].
421 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
422 - src/gdcmDocument.cxx:
423 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
425 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
426 was causing memory leaks.
427 - src/gdcmSQItem.cxx:
428 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
429 cleanly handled with polymophism: sorry but my milage is low).
430 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
431 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
432 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
433 This avoids SegFaulting.
434 - src/gdcmSQItem.h: coding style.
436 - Test/TestWriteSimple still severely sucks. The output image content
437 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
438 damaged when displayed with vtkgdcmViewer.
439 - on memory leaks: TestWriteSimple leaks really less (see entry
440 of 2004-06-18 in Changelog file for the call to valgrind).
441 - on segfaults: ctest now passes all the tests but one (no more
443 * Erroneous leading white fix:
444 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
445 white[s] (as opposed to from >> xxx, that removes it [them].
446 - src/gdcmTS.cxx: ditto.
447 - gdcmPython/testSuite.py: dirty related kludge removed.
448 * src/*: remaining references to gdcmParser removed.
449 * src/*[cxx|h]: added copy[way]left header.
452 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * In order to fix writing of dicom files:
454 - Test/TestWriteSimple.cxx: a simpler example of writing.
455 - Test/CMakeLists.txt changed accordingly.
456 - src/gdcmDocument.cxx:
457 -- The destructor now recursilvely removes potential sequences.
458 -- Bug fix in ::IsJPEG2000()
459 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
460 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
462 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
463 to only declared) and build on top of
464 ::GetDocEntryByNumber(guint16, guint16).
465 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
466 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
467 for usage in destructor and treatement of promotion in
468 ::ReplaceOrCreateByNumber().
469 - src/gdcmSQItem.cxx: destructor should better handle his job.
470 Test/TestWriteSimple now runs (or at least it DOES something).
471 * We can now start hutting memory links. A good starting point is:
472 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
473 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
474 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
476 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * Valgrind note: after Mathieu Malaterre teached me how to read
478 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
480 Using gcc, you can force the STL to use malloc and to free memory as
481 soon as possible by globally disabling memory caching.
482 With 3.2.2 and later, you should export the environment variable
483 GLIBCPP_FORCE_NEW before running your program.
484 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
485 simply vanish (it is still not clear to me, whether this means that
486 STL std::string leaks or if valgrind believes it leaks...).
487 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
488 running bin/gdcmTests makeDicomDir):
489 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
490 - Test/makeDicomDir.cxx now properly traps empty lists and returns
492 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
493 SegFaulting (I drowned in DicomDir related code when trying to
494 understand why the list is empty...).
495 * src/gdcmDocument.h: first BSD license header try.
496 * Doc/License.txt added.
498 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * src/gdcmDocument.[h|cxx]:
500 - Clean up of the Transfer related predicates. They are now all based
501 on new method isGivenTransferSyntax, that (should) handle properly
503 - general clean up, simplification, and coding style.
504 - Specific clean up of Parse7FE0() (umproperly named actually).
505 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
507 2004-06-14 Jean-Pierre Roux
509 - fix the display of Sequence Delimitor (SQDepthLevel pb)
510 - fix the display of SQItem ordinal number
511 - add the GetSQItemByOrdinalNumber method
512 - remove some useless never written private methods
514 2004-06-14 Jean-Pierre Roux
516 - adding a constructor taking a gdcmDocEntry as an input param
517 - ReplaceOrCreateByNumber now returns :
518 a gdcmBinEntry * if a Binary (void *) value is passed as a param
519 a gdcmValEntry * if a string value is passed as a param
521 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
522 according to the param type (no longer sets a gdcmDocEntry)
523 - GetValEntryByNumber, GetBinEntryByNumber added
524 - NewValEntryByNumber and NewBinEntryByNumber added
526 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
528 - GetSQItemNumber and SetSQItemNumber added, to provide
529 a (relative) Item identier inside a given Sequence
530 \warning : some pb remaining around this number
532 - AddEntry now takes the Item Number as a param
534 - adding a constructor taking a gdcmDocEntry as an input param
536 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
537 * Memory leak hunt with the following command:
538 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
539 --show-reachable=yes gdcmTests PrintDocument
540 It looks like many (all?) leaks are due to the STL (or a bad usage
541 of the STL. The lines producing the leaks now have a comment with
542 a "MEMORY LEAK" tag: you can retrieve them with
543 grep "MEMORY LEAK" src/*
544 Here are two typical examples which I can't help fixing:
549 char * test = "babo";
550 name = test; //// <--- valgrind detects 960 bytes lost in
551 //// call to std::string::operator=(char const*)
552 name.clear(); //// Doesn't help !
560 std::cout << "Type a bunch of characters followed by RETURN: ";
561 getline(std::cin, line); //// <--- valgrind dectects a loss
562 //// of 1320 bytes in call to
563 /// std::basic_istream<>& std::getline<>
569 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
570 * src/gdcmHeader.[cxx|h]:
571 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
572 and related, moved away to gdcmDocument.
573 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
574 the corresponding protected accessors of inherited class
575 gdcmDocument, removed ! As a consequence gdcmFile had to be
576 declared friend of class gdcmDocument (see below).
577 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
578 - Clean up of undefined or unused methods.
579 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
580 account the changes to gdcmHeader.h).
581 * src/gdcmDocument.h:
582 - gdcmFile is now a friend class (in order to take into account the
583 changes to gdcmHeader.h).
584 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
585 (see changes to gdcmHeader.h).
586 - Accessors (reading on the form GetEntry*) are now public.
587 - Clean up of undefined or unused methods.
588 * src/gdcmDocument.cxx:
589 - adaptation to changes to gdcmDocument.h
590 - ::OpenFile now writes a verbose message when file cannot be opened.
591 - some std::string properly set to VRKey
592 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
593 references to gdcmDocument.
594 * Test/TestFindTags.cxx: changed accordingly to above changes.
595 * gdcmPython/testSuite.py: adapted to renaming of acr files in
596 cvs repository gdcmData.
598 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
600 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
601 conflicts with gdcmValEntry::voidArea.
602 * src/gdcmValEntry.cxx: unmatching comment wiped out.
603 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
604 Value representation between StringRepresentable and BinaryRepresentable.
605 * src/gdcmDocument.cxx:
606 - method ParseDES: proper indentation restored and usage of
607 gdcmVR::IsVROfGdcmStringRepresentable wired in.
608 - method LoadDocEntry: the fingerprint left in the SetValue() of
609 unloaded entries (length > MaxSizeLoadEntry) had curiously been
610 removed. Reverting to previous code segment with the proper
611 dynamic_cast< gdcmValEntry* >.
612 Note: this was (partially) breaking the python test suite
613 (gdcmPython/testSuite.py) that made usage of the above
614 fingerprint to check presence of "Pixel Data".
615 * src/gdcmDocEntry.h: coding style.
616 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
617 now taken into account.
618 * gdcmPython/gdcm.i: adaptation to the new internal representation
619 of gdcm (exit gdcmParser, hello gdcmDocument).
620 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
622 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
623 anymore, but instead prints the loaded Python dictionary.
624 * .... alas, the python testSuite is still broken.
626 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
627 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
629 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
630 * src/gdcmUtil.h : export methods
632 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
633 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
635 * Initial addition of automatic python testing
636 * Initial addition of automatic image comparison
638 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
640 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
642 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
644 * Test/ShowDicom.cxx : bug fix for msvc compilation
645 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
647 2004-05-04 Jean-Pierre Roux
648 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
649 new concepts (and new classes) :
650 a 'gdcmDocument' is composed of a set of Doc Entries, that are
651 - elementary gdcmDocEntries (former gdcmHeaderEntries)
652 - Sequence Doc Entries (gdcmSeqEntries)
653 a Sequence is composed of Items.
654 Each item is a set of Doc Entries (this is recursive)
655 The non uniqueness of the 'Dicom tag' is due to this recursivity
656 (never taken into account)
657 Our unability to add a new 'entry' in the header
658 at the proper location (neither in the H-Table (map or multimap),
659 nor in the Chained List is also due to this recursivity.
660 Don't try, right now, to use/modify/compile these new sources :
662 We just commit all the stuff, 'as is', in order not to loose it.
664 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
665 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
667 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
668 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
669 file prefix (SetFilePrefix)
671 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
672 * Add a new test: ShowDicom, for now this is just the c++ version of
673 checkRead.sh, later it will be able to compare the image read against a
675 * Replace the DEBUG on the stack with a global entry in cmake interface:
676 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
678 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
679 * Add an example subdir, with a real example on how to read + write a
682 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
684 * Doc/CMakeLists.txt: the main page is now properly differentiated
685 between the developper and user version.
686 * Doc/doxygen.config.in: dropped search related obsolete flags
687 * src/gdcmParser.h, gdcmHeader.h: doxygenation
689 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * DEVELOPPER: added some helpfull comments for compile/test/install
693 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
694 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
695 src directory, now generated in the build dir.
696 2. Tests as mentionned smarter
698 4. Add a new method in gdcmDict that return the PubDict by name
699 this is interesting for 3rd party lib like ITK,
700 where we could set the institution name / patient name...
702 * ENH: 1. Now the test suite is working for real
703 2. All binaries are now output in the gdcm-bin directory
704 (this was not true before)
706 2004-04-28 Jean-Pierre Roux
707 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
708 SeQuence indented printing of Dicom Header.
709 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
710 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
711 Computation of SQDepthLevel is now part of gdcmHeader constructor
712 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
713 tree-like structure of a Dicom Header.
714 * FIX Test code cleaning
716 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
717 * ENH: Adding automatic testing
718 1. Need a DartConfig.cmake to submit to public
719 2. Add a test driver gdcmTest.cxx
720 3. gdcmTestMain, an helper for the main test driver gdcmTest
721 4. Files in Test don't have a main anymore, this becomes interesting
722 when we add more and more tests, thus dsw don't have to load
724 * ENH: Adding a GDCM_DATA_ROOT for testing
725 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
726 one file instead of seven + some small cleanup
728 2004-04-22 Jean-Pierre Roux
729 * ENH Minor changes to the Print() methods.
730 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
731 Header printing. Example given with :
732 > PrintHeader fileName 2 new
733 (SQ based tree-like structure still to be done for the Header ...)
735 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
736 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
737 1. I have added some unsigned where needed
738 2. Some function parameter not used -> (void)
739 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
740 4. g++ don't like character '\' in comment
741 5. #define jpeg_create_decompress jCreaDecompress
742 this really need to be fixed
743 6. virtualize destructor of gdcmObject ... leakage
744 7. sscanf(g->first.c_str(),"%x",&gr_bid);
745 this also really need to be fixed
746 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
747 remove compression file
748 (as we only do decompression, right ?)
749 * ENH: Change malloc/calloc/free with c++ equivalent
751 2004-04-21 Jean-Pierre Roux
752 * FIX gdcmHeaderHelper::GetXSpacing
753 when a single value is found (bug ?), xpacing is now
754 defaulted to yspacing
756 2004-04-19 Jean-Pierre Roux
757 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
758 * ENH add parameters :
759 bool exception_on_error = false,
760 bool enable_sequences = false,
761 bool ignore_shadow = false
762 to the gdcmFile constructors to be full gdcmParser compliant
763 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
764 to allow reading of PAPYRUS 3.0 files
766 2004-04-06 Jean-Pierre Roux
767 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
769 2004-04-02 Jean-Pierre Roux
770 * ADD : Test/checksequence.sh, for a general recap on SQ pb
771 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
772 for Philips spurious Tag fffe|0000 while rewritting Dicom files
774 2004-03-30 Jean-Pierre Roux
775 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
776 for ACR file, written out as DICOM files (hope so...)
778 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
780 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
781 moved to base class gdcmParser and only the specialisation is kept
783 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
784 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
785 already does the job.
786 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
787 (to be consistent with gdcmParser::WriteEntries).
789 2004-03-30 Benoit Regrain
790 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
791 upate of the object's instance. It's passed to 2 in the unfavorable
792 case : one in the ExecuteInformation, one in the ExecuteData
794 2004-03-29 Jean-Pierre Roux
795 * ENH : Check on file type to be written moved
796 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
797 * FIX : gdcmObject::ResetBoundaries now stops properly
798 when end-of-list is reached
799 : gdcmVersion modified (as Benoit Regrain asked)
801 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
802 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
803 * src/gdcmUtil.cxx: added forgotten iostream include.
804 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
805 equivalent to ExplicitVR in existing code).
807 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
809 now contains all the gdcmGlobal related code.
810 * minor coding style and doxygenation changes.
812 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
814 now contains all the Debug related code.
815 * minor clean-up of includes in src/*.cxx
816 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
817 CreateCleanString) removed.
818 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
819 * Doc/DoxyMainPageUser.txt added.
820 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
821 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
824 2004-03-24 Jean-Pierre Roux
825 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
827 2004-03-23 Jean-Pierre Roux
828 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
829 big endian made volumes
830 * ENH Now gdcmParser constructor and destructor are protected to forbid
831 end user to instanciate class gdcmParser
832 (only gdcmHeader and gdcmDicomDir are meaningfull)
834 2004-03-22 Benoit Regrain
835 * FIX : src/gdcmDicomDir.cxx : make windows compilable
836 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
837 gdcmSerie to gdcmDicomDirSerie
839 2004-03-19 Jean-Pierre Roux
840 * ENH Now the tree-like structure describing a DICOMDIR comming from
841 an already existing DICOMDIR file is consistent with
842 the home-made tree-like structure build ex-nihilo
843 or build from the files held (recursively) in a Directory
844 functions gdcmDicomDir::CheckBoundaries()
845 gdcmObject::SetBoundaries() added
847 2004-03-17 Jean-Pierre Roux
848 * REM (Eric Boix bug) : removal of meaningless
849 gdcmDicomDirImage::NewImage function.
850 * FIX now file names and directory name are written properly in the
852 * FIX now gdcmDicomDir constructor may be call without any trick
855 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
857 of gdcmDicomDirImage::NewImage as empty function.
859 2004-02-28 Jean-Pierre Roux
860 * ENH add gdcmDicomDir:NewPatient
861 add gdcmDicomDirPatient:NewStudy
862 add gdcmDicomDirStudy:NewSerie
863 add gdcmDicomDirSerie:NewImage
864 to allow making gdcDicomDir object.
865 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
866 (as opposite to the gdcmHeader chained list)
868 2004-02-11 Benoit Regrain
869 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
870 when using from python
872 2004-02-10 Benoit Regrain
873 * FIX : bug fix in the gdcmDirList for the recursivity in directories
874 * FIX : in gdcmDicomDir when the directory is empty
875 * ENH : add callback and methods to get the progression of dicomDir
878 2004-02-06 Jean-Pierre Roux
879 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
880 - GDCM_META added to gdcmDicomDirType
881 - class gdcmMeta created
882 * ENH : - A brief summary is now displayed at the beginning of
883 'testDicomDir' to help disaster magnitude estimation
884 * REM : Now useless Test/explDICOMDIR.cxx
886 2004-02-05 Benoit Regrain
887 * ENH : add methods in gdcmObject to get the hash table or the list of
889 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
890 * FIX : wrapping python for TagHeaderEntryHT
892 2004-02-04 Benoit Regrain
893 * FIX : even length for some strings when writting the dicom dir
894 * FIX : sort the images in the dicom dir
895 * FIX : Bug fix for python use of dicom dir
896 * ADD : a python demo
898 2004-02-04 Jean-Pierre Roux
899 * FIX : Final solution (?) for icone embedded images
900 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
901 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
902 add groups 6002, 6004, 6006, to allow 'clean' parsing of
903 gdcmData/gdcm-MR-SIEMENS-16.acr1
904 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
905 to make full checking easier
907 2004-02-04 Benoit Regrain
908 * FIX : WriteEntries : coding style & logic in parameters
909 * FIX : Set the elements to create the DicomDir in a dictionary file
911 2004-02-03 Benoit Regrain
912 * gdcmDirList : to parse a hard drive directory in recursive (or not)
913 * gdcmDicomDir : add the load of directory
914 * Bug fix and print add-on
916 2004-02-03 Jean-Pierre Roux
917 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
918 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
919 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
920 * FIX gdcmParser.cxx : 'group length' elements are now considered
921 as integers, even for shadow groups, when file is Implicit VR
923 2004-02-02 Jean-Pierre Roux
924 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
926 of the last synonym :-(
927 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
929 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
930 * FIX taking into account the possible 7fe0,0010 multiplicity
931 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
932 to allow removal of references to 7fe0,0010, to deal with
933 ACR-NEMA images, when 0028,0200 is meaningfull
935 2004-01-31 Jean-Pierre Roux
936 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
937 no longer writes 'Un' on disk
938 * FIX SQ elements with actual length are now dealt with corectly
939 * FIX gdcmFile::WriteBase make the difference, for color images, between
940 the length (for Palette expanded images)
941 and Raw Length (non expanded image + Palette)
942 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
943 (that broke Write). Replaced by UL.
944 Aware user will reload the field if he
945 thinks it's necesssary
947 2004-01-30 Jean-Pierre Roux
948 * gdcmParser::CheckSwap() now defaults the filetype to ACR
949 when 'dirty Acr' is found, to be compliant with the new
950 IsReadable() methods.
952 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
953 (no DOUBLE images in kosher DICOM,
954 but so usefull for people that miss them ;-)
956 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
957 DICOMDIR related utilities (not checked as Windoze compliant)
959 2004-01-28 Jean-Pierre Roux
960 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
962 2004-01-27 Jean-Pierre Roux
963 * gdcmParser constructor has a new boolean param,'ignore_shadow',
964 to allow skipping the shadow elements, to save memory space.
965 The TRUE value for this param has to be used
966 with a FALSE value for the 'enable_sequence' param.
967 ('public elements' may be embedded in 'shadow Sequences')
968 * gdcmHeader methods now deal with 'embedded icones images' in the header
969 (even when an 'icone image sequence' is announced by the
970 element (0x0088,0x0200), but there is NO icone at all ...
972 * gdcmHeader sometimes Image Location value doesn't follow
973 the supposed processor endianity (see gdcmData/cr172241.dcm).
976 * gdcmHeader add the method
977 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
978 to get *all* the Header Entries with the same tag.
979 GetHeaderEntrySameName is probabely *useless*
980 (no meaning : Name is *not* an identifier within the Dictionnary)
982 2004-01-26 Benoit Regrain
983 * Bug fix in the print of hexadecimal representations. Remove long fields
984 in the print and add a third level of print to print them
986 2004-01-23 Benoit Regrain
987 * Bug fix on field having a VR = 'UI'. Assume that is a string field
988 * Bug fix on test suite after remove the strip made on not string fields
989 * Split the IsReadable method between gdcmParser which test that the file
990 is dicom and gdcmHeader which test that it's an image file
992 2004-01-22 Benoit Regrain
993 * DicomDir : clean code, add methods, set variables in protected or private
994 * gdcmUtil : bug fix for the clean string method
996 2004-01-19 Benoit Regrain
997 * Add the use of shadow dictionaries
998 * bug fix and coding style
1000 2004-01-19 Benoit Regrain
1001 * src/gdcmFile.cxx : bug fix concerning the close of file
1002 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1003 * Add the update of header entries using the shadow library
1005 2004-01-19 Benoit Regrain
1006 * removal of file gdcmHeader2.cxx
1007 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1008 inheriting from gdcmParser. This split is to prepare the integration
1009 of dicom dir parsing
1010 * bug fix under python
1012 2004-01-16 Jean-Pierre Roux
1013 * REM removal of class gdcmHeaderEntrySet
1014 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1015 * ADD add file gdcmHeader2.cxx
1016 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1018 2004-01-15 Benoit Regrain
1019 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1020 entries created while parsing the header. Thus, they will be destroyed
1021 when the gdcmDictSet will be destroyed
1022 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1025 2004-01-15 Benoit Regrain
1026 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1027 made a fatal error because of the memory release at the end of program.
1028 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1029 some memory and vtk seems to have some problems with that.
1030 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1032 2004-01-14 Benoit Regrain
1033 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1034 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1035 * src/*.[h|cxx] : make changes due to class name changes
1036 * gdcmPython/demo/*.py : bug fix due to method names
1038 2004-01-13 Benoit Regrain
1039 * src/*.[h|cxx] : coding style
1040 * vtk/*.[h|cxx] : coding style
1042 2004-01-13 Benoit Regrain
1043 * gdcmPython/testSuite.py : test the readable flag of file for tests
1044 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1045 It's lied to the stl compilation by MSVC (windows, always windows...)
1046 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1048 2004-01-12 Benoit Regrain
1049 * src/*.h : add comments
1050 * src/gdcmDictSet.h : set the method BuildDictPath in public
1051 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1052 directly setted in the source code
1053 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1056 2004-01-09 Benoit Regrain
1057 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1058 * setup.py : use a reference to gdcmVERSION
1060 2004-01-07 Benoit Regrain
1061 * Modification to compile with the distutils.
1064 2003-12-10 Benoit Regrain
1065 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1066 can use a gdcmHeaderHelper to load datas
1067 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1068 made in the source code
1070 2003-12-10 Benoit Regrain
1071 * Update Windows projects and .cvsignore files
1073 2003-11-12 Jean-Pierre Roux
1074 * ENH gdcmHeader constructor has one more parameter (default value : false)
1075 that allows the user to 'go inside' the SeQuences only
1077 gdcmElValSet:Print takes it into account
1079 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1080 * ENH: Update gdcmPython/CMakeLists
1081 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1082 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1084 2003-11-10 Jean-Pierre Roux
1085 * FIX : gdcmHeader::LoadElements is now based
1086 on the ListTag listElem member,
1087 not longer on the TagElValueHT tagHt member
1088 * ENH : PrintPubElVal shows (temporarily) both results,
1089 with the tagHt member and the listElem member.
1090 (it's easier to 'see' the problems when using Printheader)
1092 * FIX : old private member LgrElem is now splitted into
1093 ReadLength : Length actually found on disk (updated only
1094 if bug fixing is necessary), for internal
1096 UsableLength : Updated by FixFoundLength, to fix a bug
1097 or to allow Parser going on.
1098 Will allow to re-write a kosher header when a SeQuence
1099 with a length (not 0000) is found
1100 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1101 because gdcmElValSet::Add does not update ListElem
1104 2003-11-07 Jean-Pierre Roux
1105 * FIX misstyping in Transfert Syntax name table
1106 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1107 when they have an actual length (not 0000 nor FFFFF)
1108 (Nobody should care of it, but DICOMDIR explorers)
1110 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1111 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1113 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1114 * ENH: vtkGdcmReader now supports LUT !
1115 (vtkgdcmViewer for now is not able to use them though)
1117 2003-11-05 Jean-Pierre Roux
1118 * in testSuite.py : new files names for checking the package
1119 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1120 that returns the pixel area size to the *aware* (vtk) user
1121 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1123 2003-11-05 Benoit Regrain
1124 * in testSuite.py : Modify the rules for checking the paths
1125 : Explicit error messages
1126 * in __init__.py : Related modif
1128 2003-11-03 Jean-Pierre Roux
1129 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1130 to be used by aware (vtk) users that want to manage
1131 LUT (and no to turn the PALETTE image into an RGB pixels one)
1132 * GetPixelType now returns 8U for 24 Bits images
1133 (vtkGdcmReader compliant)
1135 2003-10-31 Jean-Pierre Roux
1136 * Removal of *all* gdcmData images and add them again
1137 in order to loose the 'history' of un-anonymised images
1139 2003-10-31 Jean-Pierre Roux
1140 * RMV : removal of useless jBitsInJsample.h
1141 for both 8 and 12 Bits JPEG Lossy Libraries
1143 2003-10-31 Jean-Pierre Roux
1144 * ENH : Add the functions gdcmFile::GetImageDataRaw
1145 gdcmFile::GetImageDataIntoVectorRaw
1146 that act as GetImageData and GetImageDataIntoVector
1147 except the making of an RGB Plane from Gray Plane + LUT
1148 Intended to aware (vtk) users who know how to manage
1151 GetLUTRGBA return a R,G,B,A LUT if any
1152 lgrTotaleRaw gives the 'Raw' length
1153 GetImageDataRaw returns the gray Plane
1154 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1155 (They stay Grey, just like with other Dicom viewers :-(
1157 2003-10-30 Jean-Pierre Roux
1158 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1160 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1161 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1162 being coherents dicom files.
1164 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1165 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1167 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1168 * ENH: Two steps is necessary to please VC++ compiler...
1169 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1170 * ENH: Add include dir to medcon lib
1171 * FIX: only one function is being exported for now !
1172 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1174 2003-10-29 Jean-Pierre Roux
1175 * adding gdcmHeader::GetLUTRGBA
1176 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1177 --> Mathieu, the modif u're waiting for is not yet committed
1178 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1180 2003-10-27 Jean-Pierre Roux
1181 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1182 00191113.dcm DermaColorLossLess.dcm
1183 MxTwinLossLess.dcm RadBWLossLess.dcm
1184 * ENH: For version prior to vtkImageViewer2 -r 1.19
1185 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1187 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * Removal of ido stuff in CMakeLists.txt
1190 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1191 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1192 * FIX: remove a call to ->Modified ... see comments
1193 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1195 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1196 * FIX: Problem with path for libvtkgdcmPython
1197 * ENH: Try adding a search script for python site-package
1198 * RMV: Remove some file from medcon lib that are not necessary
1199 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1200 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1201 * FIX: More pragma disable fro VC++,
1202 I don't think I break something as it is also disable in VTK/ITK.
1203 But it fasten debug compilation time.
1205 2003-10-23 Jean-Pierre Roux
1206 * gdcm now deals with 16 Bits Run Length Encoded images
1207 (they are compressed as 2 planes images,
1208 one for the high Bytes, the other for low Bytes)
1210 2003-10-22 Jean-Pierre Roux
1211 * Now CheckRead takes into account :
1212 - the bugged 'Leonardo' Siemens images
1213 - the XA images, sent thru the burning VPRO station
1214 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1217 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1218 * FIX: When copying a Makefile.am to CMakeLists.txt
1219 one should remove the '\'
1221 2003-10-22 Jean-Pierre Roux
1222 * in gdcmData adding a bugged 'Leonardo' Siemens image
1223 (wrong lengths in header)
1224 OK with gdcm, KO with the other viewers :-)
1225 * add a GE dlx XA image, thru the VEPRO burning station
1228 2003-10-21 Jean-Pierre Roux
1229 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1230 for a brutal checking of vtkgdcmViewer compliance
1232 2003-10-21 Jean-Pierre Roux
1233 * add the files for 'xmedcon' Jpeg Lossless library
1234 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1236 2003-10-21 Jean-Pierre Roux
1237 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1239 2003-10-21 Jean-Pierre Roux
1240 * garbage Siemens 'Leonardo' images dealt with
1241 (the patch is easy to remove)
1242 * cosmetic changes to avoid warnings
1244 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1245 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1246 no need to press 'r' now.
1248 2003-10-20 Jean-Pierre Roux
1249 * upgrade of checkRead.sh checkWrite.sh according
1250 to new Jpeg Lossless decompressor
1251 * add US.3405.1.dcm, a genuine RGB medical file ...
1252 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1253 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1255 2003-10-15 Jean-Pierre Roux
1256 * general anonymisation in gdcmData
1257 * adding the 'color files' from
1258 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1259 * adding some well knowed bugged-header images
1260 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1261 waiting for their inclusion in Python testsuite
1263 2003-10-15 Jean-Pierre Roux
1264 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1265 no longer seg faults when file is not found
1267 2003-10-14 Jean-Pierre Roux
1268 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1271 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * TODO: *.in file to genereate a UseGDCM later
1274 2003-10-14 Jean-Pierre Roux
1275 * Some supposed-to-be Dicom Images have no preamble.
1276 OpenFile takes it into account
1277 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1278 * Missing elements added in dicomV3.dic
1279 (just to be affraid : have a look at
1280 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1281 and do it again next year ;->
1283 2003-10-13 Jean-Pierre Roux
1284 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1285 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1286 But there are NOT. It's fixed !
1288 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1289 * FIX: "jpeglib.h" was not found on VC++
1290 * FIX: vtkgdcm was not being installed
1292 2003-10-10 Jean-Pierre Roux
1293 * ENH : OpenFile closes the file if it *really* doesn't look like
1294 an ACR-NEMA / DICOM one.
1295 * FIX : testWrite no longer writes an empty file if the source file
1296 is not gdcm Readable
1297 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1300 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * FIX: CMake generate now documentation
1302 * ENH: out of source doc build !
1303 * ENH: Generate both user and dev documentation
1304 * ENH: Should work on windows too
1305 * ENH: Only one doxygen config.in file is needed
1306 * FIX: make install should be ok now on ùnix plateform
1307 * FIX: PATH to dictionary was wrong (missing /)
1308 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1310 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1311 * vtkGdcmReader is now able to read rgb dicom file.
1312 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1313 * added a gdcmViewer to vtk test, use mouse to control
1314 window level & window width
1316 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1317 * CMake-ification of gdcm, we have now two build system
1318 * FIX: on cygwin Wsock32 doesn't exist
1319 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1321 2003-10-06 Emanuel Ollart
1322 * FIX : compilation process wad broken.
1323 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1325 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1326 * change gdcmViewer -> vtkgdcmViewer
1327 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1329 2003-10-06 Jean-Pierre Roux
1330 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1331 ( e.g : well known GE images with a wrong elem length,
1332 : Philips MRI Images with a wrong Huffman table)
1333 * still to be done : allow the reading of bugged LEONARDO Siemens images
1335 2003-10-03 Jean-Pierre Roux
1336 * Odd length strings are padded with '\0' (not with spaces,
1337 to remain compliant with already defined strings,
1338 like Transfert Syntax UID and others)
1340 2003-10-03 Jean-Pierre Roux
1341 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1342 to allow displaying RGB images (not only by affim ;-)
1344 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1345 * vtkGdcmReader is now able to read rgb dicom file.
1346 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1348 2003-10-03 Jean-Pierre Roux
1349 * A few nasty patches to allow the reading of a lot of nasty images
1350 ( e.g : well known GE images with a wrong elem length,
1351 : Philips MRI Images with a wrong Huffman table)
1352 * still to be done : allow the reading of bugged LEONARDO Siemens images
1354 2003-10-03 Jean-Pierre Roux
1355 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1357 2003-10-03 Jean-Pierre Roux
1358 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1359 to allow displaying RGB images (not only by affim ;-)
1361 2003-10-03 Jean-Pierre Roux
1362 * gdcmFile::GetImageDataIntoVector now
1363 - deals with MultiFrames MultiFragments Run Length Encoded files
1364 - deals with YcBcR (YBR_FULL) files
1365 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1366 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1368 (no sample found :-(
1370 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1371 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1372 Two reasons: - clear things
1373 - third parties acces gdcm through header files, so won't
1374 suffer anymore VC++ complains
1376 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1377 * add argv[1] in testvtkGdcmReader.cxx
1380 2003-09-24 Jean-Pierre Roux
1381 * The lines are now eigthy characters long.for
1382 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1384 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1385 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1386 char* to std::string. Thus, the use of strdup becomes useless. (see
1387 previous commis of Malaterre)
1388 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1389 before the last Malaterre's commit.
1391 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1392 * This commit should fix the Debug building under VC++, the problem
1393 was mainly a mixture of debug and release lib being loaded at startup.
1394 * I also remove a depency to a specific C function: strdup. Because I had
1395 to force the link to msvcrtd (whereas strdup is in libc).
1397 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1398 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1399 located in the gdcmCommon.h file. All use of reference of tha has been
1400 changed to now use the variable GDCM_UNFOUND.
1402 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1404 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1405 Dicom dictionary. The test suite can now be run again. Note:
1406 I'm note very happy with the " (RET)" changes. I believe this
1407 RETAINED comment should be dropped when parsing the dictionary.
1408 - PACKAGER corrected
1410 - AUTHORS updated and now in alphabetical order
1411 * Makefile.am now exports gdcm.dsw for Windoze users.
1413 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1414 * cygwin complains about missing std:: in subdir Test/
1416 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1417 * remove some methods that are now in gdcmHeaderHelper
1419 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * vtkGdcmReader set spacing and origin correctly
1422 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1423 * Fix a few delete/delete[] mismatch
1425 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1426 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1427 interpretation to data given by gdcmHeader. For instance there are
1428 heuristics to get informations (look at different places).
1429 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1430 sorting DICOM images based on different strategies.
1431 * modified Makefiles accordingly.
1433 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1434 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1435 when building in debug mode
1436 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1437 src/win32/gdcmdll.dsp
1438 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1440 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1441 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1444 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * src/win32/libgdcmjpeg12.dsp was not dos format
1446 * src/win32/libgdcmjpeg12.dsp :
1447 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1448 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1450 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1451 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1453 * src/gdcmFile.cxx : bug fix in affectation type
1454 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1455 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1456 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1457 symbols... future problem ?
1459 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * src/win32/libgdcmijpeg12.dsp was missing
1461 * modified gdcm.dsw accordingly
1463 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1464 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1466 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1467 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1468 commit of JPR (before his hollidays to facilitate our work).
1469 * setup.py : bug fix in code. Modifications made while the last commit
1470 of JPR. The code hasn't been tested before the commit... it's so
1471 useless to make that (for best programmer that is JPR) !!!
1473 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * tagged the current version as Version0_3 (i.e. version 0.3)
1476 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1478 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1479 * *.dsp : modifications to use new libgdcmijpeg8 library
1480 * setup.py : bug fix on VTKPATH variable
1481 * PACKAGER : adding all concerning windows
1483 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1484 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1486 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1487 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1488 test suite reported error.
1489 * PACKAGER file added (describes what a packager must do when
1490 packaging a new release).
1491 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1492 * configure.in: upgraded version number to 0.3.0
1493 * fixing build of rpm (through rpm -ta):
1494 - Doc/Makefile.am exports proper doxygen files
1495 - src/jpeg/libijg8/Makefile.am exports the include files.
1497 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1498 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1499 * src/gdcmHeader.h : formatting code
1501 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1502 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1503 We were obtaining error message from vtk. Now, creation of file list
1504 is made in an internal list to prevent this problem.
1505 Bug fix when output is empty.
1506 Bug fix in update of progress value. Previous commit for this was a bad
1508 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1510 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1511 * src/gdcmHeader.h : added method to get the file name
1512 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1513 files. Added method to remove all files on the input
1514 Added FIXME comment concerning the bad parsing of header made by
1515 ExecuteInformation method (in ExecuteData method)
1517 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1518 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1519 when using make instal.
1520 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1521 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1523 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1524 * setup.py : adding include dir of jpeg lib to compile all sources
1525 * */Win32/*.dsp : JPR fix for windows compilation
1527 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1528 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1530 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1531 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1533 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * setup.py is again effective on un*x (takes into account the
1535 addon of the jpeg library)
1536 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1537 * Doc/Doxy* updated (includes above enhancements)
1538 * INSTALL now points to web documentation
1540 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1541 * src/gdcmHeader.h doesn't make unnecessary reference to
1543 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1545 * src/gdcm*.[cxx|h] :
1546 - to allow compilation with gcc 3.x
1547 -- clean up of STL usage (added explicit usage of std::)
1548 -- small fixes on exceptions.
1549 Note: linking not tested !
1550 - clean of doxygen comments to avoid warnings at documentation
1552 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1553 dependent convertion).
1555 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1556 * Clean up of previous JPR garbage commit (not even commented in the
1558 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1559 - moved all jpeg related files from src to src/jpeg/libijg8, with
1560 addition/modification of Makefile.am and configure.in.
1561 - the testSuite is still brain damage (not guilty).
1563 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1564 * WrapVTK.py : modifications to get correctly vtk source files to
1566 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1567 (FileName -> Filename)
1569 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * vtk/vtkGdcmReader.[cxx/h]:
1571 - UpdateProgress method should now be effective
1572 - removed the limitation on having only images loaded (as opposed
1574 - when building a stack of images/volume, a lesser number of
1575 gdcmHeader and gdcmFile instances should be used (hopefully
1576 accelerating things).
1577 - when building a stack of images/volumes, files which are not
1578 loadable (wrong path-filename, wrong permissions on existing file,
1579 or file not parsable by gdcm) are replaced with a black image
1580 in the stack (for the caller to notice the problem).
1582 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1585 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1586 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1587 between standard library (std) and vtk library (problems are found
1588 under Windows... thanks Windows !)
1590 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1591 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1593 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1595 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1598 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1599 * When compiling with distutils (see setup.py) the C++ compiler is
1600 called with different flags than the default ones (with automake).
1601 In order to fix all those warning, I compiled gdcm with the command
1602 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1603 and went for warning fixes:
1604 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1605 up from unused variables.
1606 - vtk/vtkGdcmReader.cxx: potential bug fix.
1607 * src/gdcmHeader.h: Doxygen warning cleanup
1609 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * gdcmPython/gdcm.i:
1611 - typemaps correction to take into account the systematic replacement
1612 of "using namespace std" with std:: prefix e.g. std::list,
1613 std::string... (cf changes of 2003-05-21).
1614 - gdcmGlob global variable of type gdcmGlobal (defined in
1615 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1616 exported to Python a as cvar.
1617 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1618 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1619 gdcmDictSet.GetPubDictTagNames() and
1620 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1621 C++ static methods).
1622 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1623 with the above changes.
1625 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1626 * setup.py, manifest.in : bug fix under linux
1628 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1629 * Modification of setup.py to compile vtk part too. Then, we have 2
1630 wrappers which must work with same distutils. For that, we have a
1631 generic distutils in distusiltsWrapping.py ; with :
1632 - build_extWrap class to wrap generically all extensions,
1633 - ExtensionWrap base class for all wrapping extension that contains
1635 - Wrapper interface which wrap sources
1636 + In WrapSwig.py we have extension and wrapper for Swig
1637 + In WrapVTK.py we have extension and wrapper for VTK
1638 * MANIFEST.in : modifications to consider vtk directory and new python
1639 files for compilation
1641 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1642 * Added python wrappers of vtkGdcmReader vtk class (see the
1643 source in vtk/vtkGdcmReader.cxx) :
1644 - vtk/Makefile.am now builds a library
1645 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1646 python library (as opposed to _gdcm.so wich are the python
1647 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1648 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1650 - configure.in has an additional flag --enable-vtk that needs
1651 to be set to enable compilation of vtk related code, that is:
1652 + vtk/vtkGdcmReader.so and
1653 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1654 + gdcmPython/vtkgdcmPython.so (see above)
1655 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1656 be read when compressed or when HighBit + 1 != BitsStored),
1657 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1658 the usage of the python wrapper of vtkGdcmReader vtk class.
1659 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1660 * src/*.[h] all occurences of stl classes are now prefixed with
1661 std::, and all occurences of "using namespace std;" where removed.
1662 This is to avoid pollution of global namespace in included files.
1663 Apparently vtk does not avoid this pitfall: when using both
1664 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1665 collision of various stl members (principally cout...).
1666 * gdcmPython/testSuite.py now cleanly removes temprory generated
1668 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1669 comply with above changes)
1671 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1672 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1673 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1674 vtk data structure (an image Flip was required).
1675 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1676 * cosmetic changes in documentation.
1678 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1679 * src/gdcmHeader.cxx: the constructor no longer exits when an
1680 unexisting file is given as argument.
1681 * The subdirectory Data (containing all the images used for the
1682 test suite) is not part of this repository anymore. A new module
1683 containing those images is now available at
1684 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1685 with the name gdcmData.
1686 All the python scripts (including the package initialisation file
1687 gdcmPython/__init__.py) were adapated to take this change into
1688 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1690 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1691 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1692 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1693 demo of the usage of this class.
1694 Compilation of this vtk part is only done when using the --enable-vtk
1695 at configure (or autogen.sh) stage.
1697 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1698 * More memory link related corrections and documentation fixes.
1700 - maximum info is obtained with a command of the form:
1701 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1702 --show-reachable=yes PrintHeader
1703 - the remaining reachable blocks seem to come from the STL
1704 allocation scheme through the usage of map and list. It looks
1705 like this memory cannot be freed but it is not a memory leak
1706 (in fact further invocation to the STL would recollect the
1707 unused memory allthough it cannot explicitely be freed).
1708 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1709 of displaying an image parsed with gdcm and displayed with VTK.
1710 Note: some images don't seem to work e.g.
1711 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1712 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1713 Allthough this weakens the semantics, it is a ditch attempt to
1714 make gdcm more thread friendly.
1716 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1717 * Memory link hunt (by using valgrind through the command
1718 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1719 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1720 gdcmHeader::_dicom_vr.
1721 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1722 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1724 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1726 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1727 * src/Makefile.am now exports all the necessary include files at
1731 * UpdateGroupLength replaced by new one
1734 * UpdateGroupLength re-written using H-Table
1735 (named UpdateGroupLengthNew untill checks are over)
1737 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1738 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1739 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1741 - gdcmHeader::GetPubElValSet removed.
1742 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1743 UpdateGroupLength, WriteElements, Write.
1744 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1745 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1746 carried the same semantics.
1747 - src/gdcmHeaderIdo.cxx changed accordingly.
1748 - gdcmFile::WriteBase now regroups all the codes from previous
1749 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1750 - enum FileType moved to gdcmCommon.h
1751 * src/gdcmHeader.cxx AddDefault trashed
1752 * gdcmGetXSize added
1753 * getimageDataSize now calls gdcmGetXSize
1754 * Test/*.cxx changed to agree with above changes
1756 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1757 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1758 (to avoid double call by end user).
1759 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1760 by end user, since gdcmHeader::gdcmHeader now handles it.
1762 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1763 * gdcm/Doc many doxygen changes:
1764 - Doxyfile now has two different versions, DoxyfileUsers that generates
1765 the html.users end users oriented documentation and
1766 DoxyfileDeveloppers that generates the html.developper developper
1767 oriented documentation.
1768 - README changed accordingly
1769 - requirement.txt removed (old design info moved to TODO).
1770 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1771 DoxyMainPage.txt, DoxyPython.txt provide more information.
1772 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1773 be updated by simply regenerating the docs with doxygen and copying
1774 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1775 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1776 all the tests in the form "if (<map>.count() >1)" were removed.
1777 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1778 ill-formed documentation sections.
1779 * src/gdcmHeader.cxx: ditto
1781 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1782 * setup.py fixed for un*x (needed macro for stdint.h)
1783 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1784 un*ces with sh-utils test utility.
1785 * gdcmPython/demo/test.py renamed to PrintHeader.py
1786 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1787 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1788 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1789 * src/gdcm*.cxx JPR's bad inclusion fixed.
1791 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1793 * gdcmPython/demo/test.py changed accordingly.
1795 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1796 * gdcmPython/Makefile.am fixed linking against libstdc++
1797 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1798 * Swig subdir (historical tests of swig version 1.3.17++) removed
1799 * Test/testChangeEntete.cxx some lines commented out in order to make
1801 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1802 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1804 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1806 hence the user doesn't need this explicit call.
1807 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1808 i.e. LoadElements() call removed.
1809 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1810 - src/Makefile.am declares the proper flag for g++.
1811 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1812 for adding user defined new tags.
1813 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1814 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1815 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1817 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1818 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1819 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1820 src/Makefile.am : the project should properly compile and install
1821 with the autotools, included the python wrappers part.
1822 * gdcm.spec.in : added a spec file for RPM packaging.
1824 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1825 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1827 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1829 to exported to the environement (see gdcmPython/testSuite.py
1831 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1832 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1833 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1834 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1835 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1837 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1838 * gdcmPython/__init__.py doesn't crash anymore when running in
1839 in InstallMode or PreInstallMode but with an environement given
1840 value of GDCM_DICT_PATH.
1841 * src/gdcmDictSet.[cxx/h] coding style.
1843 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1845 * src/gdcm.h general comments moved to TODO, and README
1846 * src/gdcm.h should now be seen as a user commodity (including it
1847 should suffice to fully use gdcm). It is nowhere including within
1848 any of the kernel files src/*.cxx and src/*.h.
1850 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1852 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1854 * src/gdcm*.cxx only include their corresponding include file
1855 (as opposed to gdcm.h)
1856 * gdcmPython/gdcm.i changed accordingly
1857 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1858 the autogen.sh generated "make snapshot" command to work.
1859 * autogen.sh removed history related references to crea package.
1861 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * distutilsSwigCPlusPlus.py work around some swig portability
1865 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1867 was done in a last ditch attempt to get setup.py _really_
1868 operationnal. The python/gdcmPython layaout add the advantage
1869 of hidding away the python related distutils specific files
1870 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1871 Alas, the src directory was out of scope (i.e. it's relative
1872 position to setup.py was ../src) which made things impossible to
1873 handle (see previous version of python/setup.py). Crossing fingers...
1875 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1876 * python/setup.py now works on Un*x. (harder than I thougth)
1877 * python/distutilsSwigCPlusPlus.py can now have include files
1878 among the list of sources.
1880 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1881 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1882 * modifications in MSVC projects
1884 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * As stated by the first lines of Test/ExceptionAndPython/README, it
1886 looks like we can move back to original usage of exception within
1887 src/gdcm* and hence remove the errno stuff that was introduced
1888 as a quick and dirty fixture of this problem (added to the TODO).
1889 * Doc/Doxyfile configuration file for Doxygen and corresponding
1890 README file for usage added.
1891 * Test/testWrite.cxx added. This new test comes from a split of
1892 test.cxx that is now reverted to its original purpous i.e.
1893 testing the proper parsing of a Dicom related file.
1894 testWrite.cxx concentrates on testing the IO part of gdcm.
1895 * Test/bug1.cxx (containing a bug on WIn32) added.
1896 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1897 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1898 whose purpose is to publish the content of the TagNames of the
1899 Dicom public dictionnary were not accessible without an
1900 instance of class gdcmHeader.
1901 - those methods are now static methods of gdcmDictSet and hence
1902 require no instances at all to be invocated.
1903 - within gdcmDictSet this change required to change some method
1904 to class methods (i.e. are now static) among which SetDictPath
1905 (renamed to BuildDictPath) and LoadDefaultPubDict.
1906 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1907 the above changes by calling the new method classes of gdcmDictSet.
1908 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1909 the above to be effective.
1910 * python/gdcmPython: in order to wrap properly the above changes
1911 for Python, swig version now needs to be > 1.3.17.
1912 * python/gdcmPython/Makefile fixed to adapt itself to new
1913 configure/make shema introduced by Johan Montagnat (thanks for the
1914 contribution). Alas this Makefile cannot be turned into a proper
1915 Makefile.am without some heavy changes in the configure.in
1916 (for python dectection).
1917 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1918 now avoids publishing the empty entries.
1920 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1921 * python/setup.py : bug fix concerning install under windows
1922 ExtraPath reused :-P
1923 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1925 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1926 * Dicts/dicomV3.dic : remove double spaces !!!
1927 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1928 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1931 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1932 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1933 method. Doxygenation.
1934 * src/gdcm.h clean up of JPR spurious comments.
1936 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1937 * python/distutilsSwigCPlusPlus.py now properly collects the
1938 shadow classes generated by "swig -c++" (gdcm.py in our case)
1939 when using "python setup.py install".
1940 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1941 reexports the working classes.
1942 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1943 by the classical C errno scheme. This is to prevent an obscure
1944 behavior of the python wrappers when importing wxPython.wx prior
1945 to gdcmPython (which ended up in an abort call). An illustration
1946 of this oddity can be found in the Test/ExceptionAndPython
1947 subdir (see the README file). This problem probably due to
1948 an combination of g++ and dynamic loading.
1949 * added Test/ExceptionAndPython (see above)
1951 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * Changed the layout of the python part to avoid bloating main
1953 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1954 i.e. the distutils arsenal. All the python related stuff is
1955 again in a python subdir, but the package itself is now in
1957 * setup.py was cleaned up:
1958 - pythonIncludePath removed
1959 - python setup.py bdist target is now functional.
1960 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1961 collision with other packages). gdcmPython/demo/*.py changed
1964 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * python subdir moved to gdcmPython (preparation of distutils packaging).
1966 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1967 distutils installer is operational.
1968 * - gdcmPython/__init__.py now properly loads the swig generated
1969 shadow classes (from gdcm.py).
1970 - gdcmPython/demo/*.py changed to import the package gdcmPython
1971 instead of gdcmPython/demo/load.py.
1972 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1974 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1976 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1977 entries within the associated public Dicom dictionary resp. the same
1978 information but sorted by the fourth field (PAT, IMG, DIR) of the
1980 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1981 are now in the "???" group.
1982 - python/gdcm.i changed accordingly,
1983 - python/demo/printGroupedPublicDict.py added, that gives an example
1984 of the above new functionalities in Python.
1986 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1987 * src/gdcm.h, gdcmHeader.cxx:
1988 - historic references to glib's g_malloc and g_free (#defined)
1989 were definitively removed.
1990 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1991 * src/gdcmElValSet.cxx:
1992 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1993 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1994 - GetElValue(string) renamed to GetElValueByName.
1995 - Added GetElementByName(string).
1996 * src/gdcmHeader.cxx: added
1997 - GetPubElValRepByNumber(guint16, guint16)
1998 - GetPubElValRepByName(string)
1999 - GetShaElValRepByNumber(guint16, guint16)
2000 - GetShaElValRepByName(string)
2001 - GetShaElValByNumber(guint16, guint16)
2002 - GetShaElValRepByName(string)
2003 - GetElValRepByNumber(guint16, guint16)
2004 - GetElValRepByName(string)
2005 - GetElValByNumber(guint16, guint16)
2006 - GetElValRepByName(string)
2007 * Doc/requirements.txt added.
2009 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * Test/Makefile building now depends on the one of libgdcm.so
2011 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2012 pixel data) aware which enables finding the address (offset) of
2013 the pixel data of JPEG encoded DICOM files. This leaves only a single
2014 file in the testSuite whose pixel data address (offset) is unknown.
2015 * python/testSuite.py changed accordingly.
2017 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2018 * VC++ has some strong limitations when working with the STL, as stated
2019 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2020 "Also note that some STL containers (map, set, queue, list, deque)
2021 cannot be exported. [...]
2022 Some STL classes contain nested classes. These classes can not
2024 This is caused by a designed limitation that once a template
2025 class is instantiated, it can not be re-instantiated and
2027 Since our usage of map<> is ubiquitous in gdcm, this "designed
2028 limitation" of VC++ is a pitfall.
2029 Hence the Python wrappers of gdcm cannot be incrementally linked
2030 against the c++ dynamic library. The dirty but only workaround is
2031 to forget about incremental link of dynamic libraries and to generate
2032 the Python wrappers library with the inclusions of the underlying C++
2034 The following modifications concern this matter on Win32/VC++:
2035 - wrapping python correct with standalone wrapped dll (don't use separate
2036 dll under windows !!!!)
2037 - python21_d debug mode enabled (ask Frog how to use it :-)
2038 - NO problem with having an STL member of class for example string in C++
2039 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2040 - Python test of dcmlib in Python is ok under windows on a large set
2042 * removed glib references
2043 * typedef's inserted in gdcm.i for correct swig type management
2045 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * python/demo/*.py load.py extracted from test.py. Added explore.py
2047 that only displays required tags and testAll.py that parses all
2048 the files of the testsuite without using unittest.
2049 * python/testSuite.py other additional test on new files added.
2050 * Data/* new test files added accordingly to the testSuite.
2051 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2052 the vr in the file differs from the one of the dictionary.
2054 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2055 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2056 values, but limits itself to values which are below a user specified
2057 size (by default 1024 bytes).
2058 * python/gdcm.i : elements not loaded (because their size is above the
2059 user specified treshold) are exported with their TagKey as key of the
2060 python dictionary. This enables the testsuite to make some checks
2061 on the unloaded elements (since we have their offset and size).
2062 * python/testSuite.py
2063 - now tests for the existence and proper value of the pixel data
2064 - two new examples added.
2065 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2067 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2069 aware. See the strategy comments in gdcmHeader::FindeLength().
2070 * Test/test.cxx now accepts a filename as first argument.
2071 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2072 * python/testSuite.py changed to integrate test on above files.
2074 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2075 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2076 the vr was also RET.
2077 * python/testSuite.py more tests added.
2079 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * python/testSuite.py unittest test suite added (uses Data)
2081 * Data/* dcm and acr files for the test suite.
2082 * glib dependance removed from un*x version. We now use ISO C99
2083 7.18 Integer types (see stdint.h)
2084 - python/Makefile, src/Makefile src/gdcm.h
2085 * src/ when an explicit vr (like dicom files) suddenly poped an
2086 implicit element we use to mark the underlying DictEntry of the
2087 concerned ElValue with "Implicit". This strategy was damageable
2088 too the public or provite dictionaries, since some of their vr
2089 would be changed. Since Header::FindLength heavily relies on the
2090 detection by Header::FindVR of falsely explicit elements, I
2091 added an extra ImplicitVr member to ElValue (boolean).
2092 The rest of the changes we the necessary adaptations.
2094 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2095 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2097 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2099 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2100 * Adaptation for porting to VC++:
2102 o forced to use std namespace (for string to be known)
2103 o all class use __declspec export style on WIN32
2104 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2105 (in stdlib.h on Win32 but in std:: for gcc)
2106 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2107 variable GDCM_DICT_PATH.
2108 * src/gdcmHeader.cxx verbose comments made discrete.
2110 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * python/gdcm.i: added a typemap that converts a C++ hashing table
2112 to native Python dictionary.
2113 * python/demo/test.py:
2114 - now uses the native dictionary for exploration of gdcmHeader.
2115 - takes an optional filename argument (the file to parse).
2116 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2117 PubElVals hashing table.
2118 * Dicts/dicomV3.dic removed error prone trailing spaces.
2120 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * Python wrapping process moved away from src/Makefile to
2122 newly created python/Makefile (as well as gdcm.i)
2123 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2124 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2125 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2126 from the environement variable GDCM_DICT_PATH (when existing).
2127 * src/gdcmDict::GetTag bug fix.
2129 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * Straightforward temporary fixes for swig to build the python wrappers.
2131 src/Makefile now has a python working entry [by working we mean
2132 that we can import de shadow classes without errors].
2134 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * hashtest.cxx removed (since allready in Test)
2136 * src/gdcmlib.h renamed to src/gdcm.h
2137 * src/dcm.i renamed to src/gdcm.i
2138 * src/Makefile prepared for python wrapping
2140 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * src/gdcmHeader.cxx :
2142 - Parsing of header is now separated from loading of element values
2143 (see gdcmHeader::LoadElements).
2144 - general clean up of hopefully all file access (creation of
2145 ReadInt16 and ReadInt32)
2147 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * src/gdcmHeader.cxx :
2149 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2151 - SetLgrElem renamed to SetLength
2152 - GetLgrElem renamed to GetLength
2153 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2154 * src/gdcmElValSet.cxx fixed both GetElValue methods
2155 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2156 due to IdoDude was cleaned out.
2158 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2160 concentrates on finding the value representation (when it exists).
2161 RecupLgr now only finds the element value length, and it avoids
2162 returning the unecessary skL (skipped length).
2163 Also, offsetCourant was simply removed (with taille_fich) since
2164 it was redundant with the File position internals (by using
2165 ftell and fseek). This also made skL (see above in RecupLgr) usage
2167 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2168 on the libido specificities which are handled through class
2170 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2173 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * Truckload of changes. Parsing of header is barely functional
2175 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2177 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * src/gdcmHeader.cxx many addons of low level methods
2180 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2182 and _IdDcmSWAP_LONG.
2184 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * This corresponds to all the changes decided at the meeting of
2186 May 23 2002. Needless to say we are running late...