1 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Adding users file in CVSROOT for mail blaming
4 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
5 * Adding potential support for JPEG-LS DICOM files.
7 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Adding potential support for mpeg and jpeg2000 through two new lin
10 - libmpeg2 from the MPEG consortium
11 Also adding intial work to use this lib.
13 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
17 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
19 But this is a case where we should really signify the user there is
20 few chance the serie is really a serie...
22 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * FIX : on X, the python part is correctly installed. All files are
24 installed in gdcm sub-directory
26 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Builder/ : add something to facilitate the RPM creation of gdcm
29 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
30 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
32 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
34 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
37 * Fix compilation on gcc 2.96 (which does not have ios::failure)
39 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
41 and it's representation name (for the NIH)
43 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
45 conversion of YBR to RGB pixels. So, now, the conversion is made using
48 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
50 format) to replace 'at-run' dicom files generated by the
51 TestAllReadCompareDicom test
53 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
56 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
59 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Testing/TestMAkeIcon.cxx : complete the test
62 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
65 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
69 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
72 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Test/ : accelerate tests (it's not very significant accelerations).
74 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
76 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Testing/TestSequence.cxx : add test for sequences of images... test that
78 we have the same serie or the same study UID
80 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
83 * src/gdcmDict.h : remove commented code
84 * src/gdcmDocument.cxx : initialize values
85 * src/gdcmFile.cxx : bug fix when reading values
86 * gdcmPython/demo/ : change file names. Remove useless files
88 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmFile.cxx : remove the default array of initialization.
90 The static array contained pointers to non-static values (comming from
91 strings). To have coherences, when creating files, these values can't be
92 static. So, the array can't be static, too ! To simplify, the array have
93 been replaced by repeted lines to insert values in the File
95 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
97 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
99 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
100 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
101 (Dicom Element) into the Sequence Item
103 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * src/*.cxx : first parss to normalize file organisation
106 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
107 * src/gdcmDirList.[h|cxx] : add method to find a directory
108 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
110 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
111 * Finish cleaning up my JPEG mess. Should be ok now.
112 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
113 contained within the RLE* class(doh!)
115 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
116 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
117 * SerieHeader::AddFileName() creates as many Coherent Files lists
118 (same Serie UID) as it founds different Serie UID
119 amongst the files instead of discarting any file
120 that doesn't match with the first one he found.
121 * SerieHeader::OrderGdcmFileList has now one parameter :
122 the Coherent Files list the user wants to sort
123 * SerieHeader::GetFirstCoherentFileList() |
124 * SerieHeader::GetLastCoherentFileList() | allow to parse
125 the set of Coherent Files lists
126 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
127 compatibility (it returns the *first* Coherent Files list,
128 since there was only one before)
129 * Test/TestSerieHeader gets gdcmData as a default root directory
131 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Remove friend between DocEntry and File classes
133 * Remove friend between PixelReadConverter and RLEFramesInfo,
136 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
138 0002|0000. The value was incorrect.
140 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
143 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * src/gdcmUtil.cxx : compilation fix on Win32
145 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
146 variable, to be easy found. Add methods to change the default UID.
147 Amelioration of the CreateUniqueUID to use the correct default UID.
148 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
151 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * Test/TestVR.cxx : fix memory leaks
154 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
155 * Rewrite the base 256 to base 10 conversion, using string operation only.
156 This allows us to get rid of the problematic 64bits integer type (does not
157 always exist on target platform).
159 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
160 * Add construct and destructor to class gdcm::Debug to close the debug file
162 * Don't let uset to open twice the same file
163 * gdcm has now an official UID prefix,
164 supplied by http://www.medicalconnections.co.uk
165 1.2.826.0.1.3680043.2.1143
166 (Thx to Mathieu for providing URL)
167 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
168 to be able to perform some more tests
169 * gdcm::ContentEntry : Contructors and Destructor are now protected,
170 in order to be sure no user will try to use them.
171 (at user level, only the children classes are meaningfull)
173 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * move RLEInfo & JPEGInfo from Document to File
176 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * FIX : remove so many friend between classes
179 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
181 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
183 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
184 In order to avoid missbehaviour :
185 . gdcm::DocEntry is now specialized in
186 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
187 - gdcm::ContentEntry (Dicom entry with a 'content')
188 . gdcm::ContentEntry is specialized in
189 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
190 characters value, or integers)
191 - gdcm::BinEntry (Dicom entry with a non strig representable value
192 (user hasn't any longer to thing about the precedence of his dynamic_casts)
194 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * Test/VTKTest*.cxx : bug fix under linux
197 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
199 use with python. Some methods are moved from Document to ElementSet or
200 DocEntrySet. The equivalent methods to ElementSet have been added to
201 SQItem and are virtual in DocEntrySet. Methods that may have the same code
202 in SQItem and ElementSet is directly placed in DocEntrySet
204 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
205 * Test/VTKTest*.cxx : remove the show variable in each test method because
206 it's useless (the viewer variable replace this variable)
208 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmDocument.cxx : bug fix on potential memory leak
210 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
211 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
212 Add ClearXxx methods to remove all the content of the list or map
213 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
215 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
216 * methods ReplaceOrCreate renamed as Insert
217 (nobody will be any longer confused by 'CreateOrReplace')
219 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
220 * Grealty simplify the JPEg decompression, no need to differenciate based on
221 the JPEG possible type (with/without fragment, with/without multiple frame).
222 Everything is done throught the JPEG IO Suspension mechanism in IJG
224 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
225 * Stage 3 of normalization :
226 in order to avoid any missunderstanding while reading method names :
227 - All the methods xxxEntry now deal with dicom Entries
228 - Methods GetEntry splitted into
231 - Method SetEntry renamed as SetEntryValue
232 - Method SetEntryBinArea let as it was
234 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
235 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
236 - Position correctly the entry points for JPEG2000 and JPEG-LS
237 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
239 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
241 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
242 with other method names
243 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
244 * Test/TestDicomDirElement.cxx : add new test
246 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
248 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
249 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
250 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
251 So can't you use __int64 in ostream at all.
253 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
254 * bug fix for compilation on MSVC6
255 * gdcmPython/gdcm.i : rename of classes missed
257 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
258 * Stage 2 of names normalization :
259 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
260 (easy to understand ...)
261 - gdcm::FileHelper replaces old class gdcm::File
263 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
264 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
265 type and not a string. So, there remove problems on the format of the
268 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
269 * Add Example/TestPapyrus.cxx
270 - reads a Papyrus file (gdcm::Header compliant),
271 - gets the pixels of all the images, using low level iterators
272 - writes an multiframes Dicom image.
273 (Just to show it's *possible* to do that)
274 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
277 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
279 Thus, DicomDirXXX are created with a flad that indicates if the created
280 object is empty or not (when not empty, the DicomDirElement is used to
283 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
284 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
285 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
287 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
290 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
292 Remove all access to the hash-tables or lists in the objects.
294 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
296 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
297 be complient with all the gdcm source code
299 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
303 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
307 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * Test/ : rename VTK tests to have a best name for the tests
309 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
310 GetFirstEntry/GetNextEntry use
312 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
313 * In SerieHeader::ImagePositionPatientOrdering()
314 // a Dicom 'Serie' may contain scout views
315 // and images may have differents directions.
316 // -> More than one may have the same 'pos'
317 // Sorting has then NO meaning !
318 Thx to Eduardo Davila for reporting bug.
320 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
322 test. Now it's on image content and not on the resulting visualisation...
323 might solve the problem on linux when using the OpenGL drivers
325 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
326 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
327 DicomDirSerie, DicomDirImage
328 Dict, DictSet classes :
329 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
330 -remove InitTraversal method.
331 * UPD Test programs + Example programs
333 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
334 * remove useless and never updated keyword \ingroup
335 * Solve pb when structure (list, map, ...) is empty.
336 Thx to Benoit for reporting bug
338 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
339 * Taking into account of 'Transfer Syntax' value
340 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
343 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
344 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
345 is no memory access violation
346 * gdcmPython/demo : add python demos using VTK
348 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
349 * FIX 'Dictionnary' is now spelt 'Dictionary'
350 'wether' is now spelt 'whether'
351 'archieve' is now spelt 'archive' ;-)
353 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
354 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
355 related methods, in order not to expose internal mechanisms
358 * REM methods that exposed internal mechanisms :
359 DicomDir::GetDicomDirPatients()
360 DicomDirPatient::GetDicomDirStudies()
361 DicomDirStudy::GetDicomDirSeries()
362 DicomDirSerie::GetDicomDirImages()
363 * UPD Test programs :
367 * UPD Example program
369 * ADD DictSet methods
373 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
374 * Removed the Print/indent/default parameter mess. There is absolutely no
375 reason to have to methods, moreover with the second taking the ostream as
376 *SECOND* parameter. This was clearly a bad hack to get things compile.
378 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Complete rewrite of the GetMacAddress code. Now the code is *much*
380 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
381 Unfortunately the main code does not work on SunOS, thus provide a specific
382 code for this platform only (and Win32 of course). Since this seems to be
383 working, change CreateUniqueUID to use GetMACAddress instead of the
384 problematic GctestetIPAddress
386 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
387 * Unfortunately to be able to test gdcmDirList I had to break the API
388 a little. Now the class is not a std::list anymore but has a member
389 std::vector (more ITK compatible). Allow unit testing on Win32 and
392 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
393 * Update SerieHeader to take into account a Serie Instance UID to properly
396 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
397 * ENH - Comment out Mathieu's (dangerous) Super Hack
398 for dealing with BIGENDIAN processors
399 - Move equivalent stuff to BinEntry::WriteContent
400 When necessary, 16 Bits Pixels are swapped in a small buffer
401 and then written. This avoid allocating a huge buffer, in
402 PixelWriteConvertor, and avoid modifying the Pixel Area.
404 Probabely, the same operation will have to be done when we want
405 to write image with Big Endian Transfert Syntax,
406 and we are working on Little Endian Processor
408 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
411 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
412 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
413 all the dict content.
414 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
416 * Test/TestDict.cxx : add a new test for the dict classes
418 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
420 file. Debug is yanked if compiled with NDEBUG
422 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
423 * src/gdcmDictSet.h : set the default output to the os variable
424 * src/gdcmDictEntry.[h|cxx] : add the Print method
425 * gdcmPython/demo/ : add a new test
427 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
428 * merging of Test/PrintDicomDir and Test/TestDicomDir
429 * removal of now redundant Test/PrintDicomDir
430 * enhancement of Example/PrintDicomDir
432 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
433 * Now, python test might work on systems
434 * Add the PrintDicomDir test
436 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
437 * FIX : First entry following group 0002 was lost for
438 Explicit Big Endian Transfer Syntax files
439 (group and elem not swaped)
441 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
442 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
443 Big Endian Transfer Syntax supposed the group following 0002
444 begins always by element 0000 (element 0000 is *optional*)
445 To avoid further troubles, let's be pessimistic, and use
446 Document::HandleOutOfGroup0002() method
447 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
448 (related pb not yet solved)
450 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * Bug fix for the python part use
452 * Now, PrintHeader.py pass... but outside the ctest use. shit !
454 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
457 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
458 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
459 a string and should ask the global TS dict what are the propreties of
462 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
463 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
464 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
465 to swap the Swap Code, at parsing time, when we come out of group 0002
466 and Transfer Syntax is Big Endian
467 We should be able to read now 'true DICOM" Big Endian coded images
468 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
469 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
471 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
472 * Hopefully fix the bug on MacOSX and static global initialization.
473 This is the only -minor- patch I found that both please MacOSX and VS6.
474 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
475 but this would require a lot of change. Another approach would be that Global
476 create those string and GDCM_UNFOUND becomes a pointer to a string (which
477 gdcm::Global would destroy at exit).
479 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Fix bug on MacOSX with static initialization in a multy threaded
481 environment. static const string in a header file used to be ill
482 initialized provoquing the freeze of any tests. patch should solve this
485 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
486 * According to Benoit's suggestion, and without any objection from anybody
487 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
488 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
489 - method gdcmDicomDirObject::GetEntry() renamed as
490 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
492 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
493 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
494 you debug/warning message just as c++ streams which make them very convinient
495 to use. Once this is stabilize I will change the ostringstrem to be
496 redirected to a file (ofstream).
497 * Properly support C99 extension: __FUNCTION__ which allow us to display
498 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
500 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
501 * Removal of useless and dangerous methods :
502 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
503 GetDocEntryByName, GetEntryByName, GetDictEntryByName
504 * Removal of usless methods :
505 Dict::PrintByName, Dict::GetDictEntryByName
506 * Commenting out of probabely useless methods :
507 Dict::GetDictEntryNames()
508 Dict::GetDictEntryNamesByCategory()
509 DictSet::GetPubDictEntryNames()
510 DictSet::GetPubDictEntryNamesByCategory()
511 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
512 * ENH : Use dicomTS.dic as described in 2004 version
513 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
514 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
515 Add Accessors on VM (Value Multiplicity), and VM related methods
516 * ADD : Add a list of 'Dicom Attribute types', as found in
517 http://medical.nema.org/dicom/2004/04_15PU.PDF
519 * ADD : Add dicomGroupNameAbbreviations.dic
520 should be used to write a method to replace the former
521 Dict::GetDictEntryNamesByCategory()
523 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
525 to read in the file... and only it ! Length is the efective length of the
526 data in the DocEntry structure
528 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
529 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
530 And now use a static function call instead, with a global variable. i
531 This is much closer to the VTK approach. Hopefully should be bulletproof
532 and easier to use...hopefully
534 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
535 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
537 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
538 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
540 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
542 ValEntry, BinEntry, SeqEntry creation or replace
544 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
546 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
548 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
549 when specifying the VR
550 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
551 * src/gdcmDocEntry.cxx : amelioration of print
553 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
554 * ADD : Add the method Util::IsCurrentProcessorBigEndian
555 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
556 * ADD Method Document::ComputeGroupLength
557 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
558 in order to allow further VR modification by user
559 * REM : removal of once-called method File::WriteBase
560 integration of its code in formerly one-line method File::Write
562 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
563 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
564 replace the different values "??", "Unkn", "Unknown".
565 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
566 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
567 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
568 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
570 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
571 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
573 * Set the gdcm::Base class to some Printable classes
575 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
576 * src/gdcmFile.[h|cxx] : add the Print method
577 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
578 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
579 * src/gdcmDocument.h : remove the PrintLevel informations
580 * Example/PrintFile.cxx : use the new gdcm::File::Print
582 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
584 problems when compiling with the python wrapping
586 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
588 writting in ImplicitVR
590 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
591 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
592 JPEG decompression, especially when dicom frames are split into several
593 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
594 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
596 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
597 * src/gdcmHeader.cxx : change the initialisation of default header.
598 Now, this header is readable by gdm, e-film, DicomWorks
600 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
602 Rename Decompressed to Raw
603 * Use the API changes in gdcm::File.
604 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
607 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
608 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
609 each added entry in the header. Replace the 'Planes' field by the 'Number
612 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
613 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
614 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
616 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
618 At this time, this image isn't readable by e-film... waiting JPR help to
621 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
622 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
623 DocEntry. Now use methods of the Document !
625 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * Test/ShowDicomSeq.cxx : bug fix
628 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
629 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
630 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
631 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
632 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
634 * Test/TestCopyRescaleDicom.cxx : remove unused variable
635 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
636 containing found sequences
638 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
641 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
642 Some fields in BinEntry must be copied to not seg fault when making the :
643 gdcm::File *copy = new gdcm::File( copyH );
644 and tests are now made on good variables
646 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
647 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
648 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
650 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
651 * Add vtkGdcmWriter example and test
653 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * Test/TestUtil.cxx : reformat the source code
655 * vtk/vtkGdcmReader.cxx : remove and change prints
656 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
658 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
659 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
661 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
662 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
663 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
665 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
667 by an eof to prevent all bad read of the file... and in this case, the
670 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
671 * Example/Volume2Dicom.cxx : comment unused variables
672 * Test/PrintDicomDir.cxx : comment unused variables
673 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
674 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
675 method that is redondant with AddEntry.
676 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
679 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
680 * Bug fix due my last commit (compilation under Windows).
681 * Example/Volume2Dicom : bug fix in the file and reformatting source code
682 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
684 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
686 - Remove printf / sprintf
687 - include iostream AFTER gdcm so we don't get warnings
688 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
690 - Also remove tons of include from header files, hopefully this should
691 speeup the compilation time, since it was becoming a dog slow.
692 - Remove gdcm.h as it include way too many files and slow down compilation
693 (plus it is not up to date)
694 - remove 'using namespace std' this is BAD !
696 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * Remove memory leaks on the DicomDir
698 * Remove some useless data in DicomDirObject
699 * Add usefull methods in SQItem, to be complient withe the ElementSet
701 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
704 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
705 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
706 future, with convertion)
707 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
708 and ImageDataSize values. Remove the method to get the PixelReadConverter
709 from the output of the class
711 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
712 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
714 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
715 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
716 and vtkErrorMacro use.
717 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
719 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
720 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
722 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
723 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
724 The string leaves only in the fonction. So when we make a .c_str(), we
725 get the pointeur on the first element, element that will be destroyed
726 immediately after thee instruction.
727 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
728 file has been opened : the test must be made on the content of the
729 pointer and not directly on the pointer !
732 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
733 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
734 the python part recompiles
736 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
738 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
739 X session is killed (for my computer... it seems to not be identic on
742 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
743 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
744 avoid problems (otherwise, the difference test between the visible image
745 and the reference is incorrect. If the reference is greater than the
746 screen resolution, it's produce errors).
747 Can be used for only one image. Can be used with a visible flag.
748 * vtk/vtkGdcmReader.cxx : remove commented codes.
749 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
750 under windows at compilation
751 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
753 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
755 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
756 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
757 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
758 tests on the image size X, Y, Z
760 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
761 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
762 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
763 between the class name and the file name
765 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/ : fix compilation warnings for the Write method (2 different
767 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
768 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
769 variable... create a static method in gdcm::Document to access to
770 this variable content.
772 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
773 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
774 file, to be accessed by other files (like gdcmFile). Remove commented
775 code. Move the change of the header to the gdcmFile, using the
777 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
778 To be sure of that (and simplify calls), the Write of the header now
779 gets a file name and not a file pointer (std::ifstream).
780 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
781 DocEntryArchive. Remove all open of the written file
783 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
784 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
786 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
787 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
788 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
790 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
791 some corresponding methods. Write correctly the file and check before
793 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
794 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
795 is now on RGB data (as before my last commit
796 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
798 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
799 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
800 Add a print information of the type of the entry
801 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
802 It was in the gdcmFile, and all write have been regrouped
803 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
804 Write correctly all dicom files (in decompressed mode only at this time)
805 * Test/ : test on files are now made using Raw data and not color data if
807 * Example/PrintFile.cxx : add more printings
809 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
810 * Amelioration of code, remove some code copy. For the loading of
811 BinEntry (in gdcmDocument), add the test to verify if the file is already
814 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
815 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
816 remove a DocEntry in the header (push an empty DocEntry)
817 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
818 lines. Bug fix in the initialization of the PixelConvert and the
820 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
821 use in TestCopyDicom (now this test can run under windows... but fails)
822 * Test/TestCopyDicom.cxx : amelioration of the test :
823 - test the pixels written
824 - add test points to quickly find where is the error
825 - can set a file name input and output in arguments
826 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
827 amelioration of the test output
829 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
830 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
831 all replaced DocEntry's
832 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
833 Now, each needed DocEntry to modify is duplicated, modified and inserted
834 to the header using DocEntryArchive. Thus, after save, we can restore the
835 header initial state.
837 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
838 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
840 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
841 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
842 correct to copy it. The DictEntry is specified at the DocEntry creation,
843 then, it musn't change in the time.
844 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
845 header correctly. At this time, the change is only made for the first
846 level of the Document. In the future, it might consider sequences.
847 The change is made by replacing a DocEntry by an other that is created
848 outside the class. The old value is kept. When we restore the header
849 status, the added DocEntry is deleted and replaced by the old value.
850 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
851 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
852 set the write type to explicit VR, implicit VR or ACR. Add methods to set
853 the write mode to native, decompressed or RGB (but not used at this time)
855 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
856 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
857 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
859 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
860 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
861 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
863 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
864 set because already copied when copying the BinEntry's of the header
865 * Test/TestAllReadCompareDicom.cxx : remove warnings
867 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
868 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
869 Two problems appear when doing it :
870 - with the gdcmFile : when the GetImageData method is called, the pixels
871 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
872 data (pixels). And each structure destruct the data when it's
873 destructed. So we have two destructions for the same data. To solve it,
874 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
875 data or not. If it doesn't own data, then they will not destroyed by
877 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
878 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
879 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
880 create a double destruction of the same DocEntry's. So, to solve it,
881 the TagHT is simply cleared and the DicomDir* elements are destroyed.
882 * TODO : add an entry concerning memory leaks in the DicomDir
884 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
885 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
886 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
889 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
890 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
891 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
892 after it have been deleted
894 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * FIX: src/* fix the doxygen warnings.
896 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
897 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
898 was erroneously defined with a size of 15 instead of 16. [many thanks
899 to Jean Michel Rouet for pointing out this bug].
901 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
902 1. Finish merging JMR patch for writting DICOM from scratch
903 2. Fix -hopefully- bug with MONOCHROME and space vs null character
904 3. Use const ref when possible
905 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
906 5. A few more comments
907 6. CreateUniqueUID can now be called without parameter"
909 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * ENH: Slightly bigger patch:
911 1. Getting toward full integration of JMR patch for writting dicom from scratch
912 2. Update Test to test part of this patch: CreateUniqueUID
913 3. File was not close properly in gdcmDict
914 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
915 5. Use of const ref instead of copy (speed issue)
916 6. Remove temporary (duplicate) string in TranslateToKey
917 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
918 8. Do not repeat virtual in subclasses
919 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
921 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * Apply first patch toward better string comparison when dealing with broken
923 DICOM files. Essentially the string could be padded with a space instead
924 of a null character as defined by standard
926 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
927 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
928 because never used... and in the same time, that's remove some memory leaks
930 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
931 * src/gdcmFile.cxx : now delete the PixelConvert instance.
932 * In examples and tests : change the type of image data variables from void*
933 to uint8_t*. Remmove all delete on image data variables
935 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
936 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
937 Verify the file pointer value before open the file, and if it's not null,
938 a verbose message is generated.
939 Close correctly the file when the file isn't considered dicom-like. The
940 correctly close is a call to CloseFile.
941 When closing the file pointer, test if its not null to close the file.
942 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
943 file. For an uncompressed image, the copied data correspond in the least
944 case to the image size (calculated) or the image size specified in the
945 header. A verbose is generated if these two size mismatch
947 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
948 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
949 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
950 break under windows (with msvc6 compilation).
952 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
953 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
954 compiling with MSVC6)
956 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
957 * Bugs fix for the Windows build with VC6
958 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
959 needed (only for projects required VTK). If the VTK is included in all
960 projects, there is conflicts with the jpeg lib of vtk when compiling the
961 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
962 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
963 when compiling the gdcm_wrap.cxx file (created by the compilation of the
965 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
966 (like it's already made for the cout use). Otherwise, conflict with the
969 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
970 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
972 - comments on the DicomDir::Method related usage added.
973 - now that we use the namespace gdcm, a lot of internal classes do
974 NOT need to be wrapped anymore.
975 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
976 DicomDir::Method) new example added.
978 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * Improve string manipulation. I now inforce the notion of 'DicomString'
980 A DicomString can contain as many \0 as they want
981 and it is *always* of even length.
982 We only support odd length for very rare case.
983 And in the near future this should be removed.
985 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
986 * /binary_write/ gdcm source. Now even on big endian we are writting
987 little endian. This should -heopfully- fix some tests
989 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
990 * Now the dictionary is compiled into gdcm lib. This is a default
991 behavior, thus any dic file specified is picked before failback to
992 the one comiled into lib
994 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
995 * Change internals for gdcmDict. Don't use any 'new' any more.
996 This should definitely solve any leak problem, and we should be
997 as fast as before, as long as don't modify too much the dictionary.
999 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1000 * STYLE: ivars should start with a capital letter.
1001 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1002 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1004 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1005 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1006 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1007 new 2004 dictionaries added (thanks to JPR).
1008 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1009 * CLEANUP_ROUND (15) for gdcmPixelConvert
1010 - RLEFrame::NumberFragments is now of type unsigned int
1011 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1012 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1015 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * Initial work in gathering all transfer syntax accessors. clearly
1017 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1018 ivars, but only one transfersyntax (class) ivar with equivalent method on
1021 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1023 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1024 discussed (plus I didn't like having a 2000 lines patch not commited)
1026 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1028 * CLEANUP_ROUND (14) for gdcmPixelConvert
1029 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1030 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1031 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1032 CloseFile() anymore.
1033 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1034 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1035 into File::Pixel_Data.
1037 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1038 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1039 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1040 * CLEANUP_ROUND (13) for gdcmPixelConvert
1041 Substituted File::ParsePixelData() with PixelConvert::Print() new
1043 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1044 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1045 method to those classes.
1046 - src/gdcmFile.[cxx|h]:
1047 -- Added a ::Print() method.
1048 -- PixelConverter is now a reference instead of a member.
1049 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1050 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1052 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1054 collaboration diagram and inheritance diagram should be generated with
1056 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1057 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1058 pointlessly wrapped (see
1059 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1060 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1061 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1062 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1063 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1064 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1065 -- File::Initialise: PixelConverter setup moved away to
1066 PixelConverter::GrabInformationsFromHeader()
1067 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1068 interpretation moved away to PixelConverter::BuildRGBImage()
1070 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1072 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1074 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1076 displayed on Win32 when a brutal abort() occurs (because of uncatched
1077 exception). See TODO new entry of this commit for more on this.
1078 * TODO added new entry.
1079 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1080 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1081 - HandleColor is no longer called from gdcmFile.cxx
1082 - gdcmPixelConvert.cxx clean up on method arguments and internal
1083 variable names for semantical coherence.
1085 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1086 * Finished lossless transition, not only do we now read all lossless jpeg
1087 images, without the need of the Cornwell lib, but we do read them properly now
1088 * To reduce code (well to avoid code duplication), I defined a common place
1089 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1090 redefine symbols. This is not perfect but this the best solution I found for a
1091 compilation time jpeg option.
1093 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1094 * Update jpeg ijg lib to support lossless jpeg implementation
1095 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1097 * Also added a special copyright for dcmtk since we use their bugfixes.
1100 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1101 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1102 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1103 matters, as stated in warning note at beginning of %include section).
1104 * src/gdcmDicomDir*.[cxx|h]: coding style
1105 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1106 * src/gdcmJpeg8.cxx: doxygen fix.
1107 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1108 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1109 from File:: to PixelConvert::.
1111 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1113 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1114 - more code moved away from File:: to PixelConvert::
1115 - fat setup of PixelConverter set in place in File::Initialise.
1117 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1118 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1119 namespace at the file system level. So now you should convert your examples
1121 gdcmHeader -> gdcm::Header
1122 It would be nice if people keep in mind to no open the namespace, since it
1123 allows compilation on broken plateform which were defining common symbol in
1124 the standart namespace (like LP, Unknown ...)
1126 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1128 The JPEG fragments are now parsed at the same stage than the RLE
1129 information. All code related to JPEG is now in gdcmPixelConvert:
1130 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1131 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1132 export a gdcmFile:: method. Those are simply global functions
1133 (for the time being this is better than having them attach to
1134 either gdcmFile:: or gdcmPixelConvert::).
1135 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1136 and stores the result in a gdcmJPEGFragmentsInfo.
1137 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1138 code (among other stuff) moved away from gdcmFile:; to
1141 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1142 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1143 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1144 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1145 clean up of RLE related code.
1146 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1147 - src/gdcmRLE.cxx removed
1148 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1149 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1150 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1151 * CLEANUP_ROUND (9) for gdcmPixelConvert
1152 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1153 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1154 away from gdcmFile:: to gdcmPixelConvert::.
1156 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1158 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1159 This is because Parse7Fe0 used to parse the pixels to compute the
1160 length. This task was passed over to FindDocEntryLengthOB() a long
1161 time ago, EXCEPT I had forgotten the OW case...
1162 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1163 we just recylce the code for parsing RLE fragments and computing
1165 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1166 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1167 with the retired Parse7Fe0().
1168 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1169 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1171 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1172 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1173 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1174 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1175 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1176 * CLEANUP_ROUND (4) for gdcmPixelConvert
1177 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1178 to return an unused length.
1180 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1181 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1182 this should be cleanner from the plane view. The iostream are erally a pain
1183 to use to do simple stuff.
1185 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1186 * Redo the compilation of the ijg jpeg library. Now only one source is
1187 necesseray. No need to rename file by hand what so ever. CMake handle the
1188 copying of the file within different directory, configure header file to
1189 modify some symbol. The only addition made to ijg wasd a mangle table so
1190 that symbol are different whether we are within 8bits or 12bits.
1192 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1193 * Added documentation of vtkgdcmReader on Website:
1194 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1195 with it's binary name).
1196 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1197 the Website to be more complete.
1198 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1199 doxygenated documentation.
1200 - Doc/DoxyVtkGdcmReaderExamples.txt added
1201 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1202 DoxyVtkGdmReaderExamples.html )
1203 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1204 * CLEANUP_ROUND (3) for gdcmPixelConvert
1205 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1207 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1208 * CLEANUP_ROUND (2) for gdcmPixelConvert
1209 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1211 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * CLEANUP_ROUND for gdcmPixelConvert:
1213 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1214 - src/gdcmPixelStuff[h|cxx] removed
1215 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1216 - src/CMakeLists.txt changed accordingly
1217 * GDCMHOME clean up:
1218 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1219 gdcmVersion.py moved to newly created ATTIC related
1220 gdcmPython/SetupOldies/ directory.
1221 * Autotools clean up:
1222 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1223 - autogen.sh configure.in acinclude.m4 python.m4 removed
1225 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1226 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1227 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1228 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1230 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1231 * TODO updated with Mathieu suggestions. I proposed a template for
1232 describing TODO entries and used it for new entries.
1233 * Added Doc/Website/CodingStyle.html, Developpers.html,
1234 DeveloppersPython.html, GdcmDataCvs.html and
1235 DownloadVersion0_1.html, DownloadVersion0_3.html.
1236 * Some Doc/*.txt Doxygen files (which do not really concern the
1237 documentation itself, but the website) moved to html and
1238 placed in directory Doc/Website:
1239 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1240 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1241 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1242 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1243 * CMakeLists.txt changed accordingly.
1244 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1245 DeveloppersPython.html
1246 * INSTALL nows refers to Doc/Website/Installation.html
1248 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * Added Doc/Website directory, that contains a first raw version
1252 2004-09-23 Jean-Pierre Roux
1253 * FIX In order not to be poluted any longer by casting problems,
1254 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1255 we can now delete[] it safely
1256 * VoidArea is now called BinArea (less confusing name),
1257 and all the methods called ...VoidArea... are now ... BinArea...
1258 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1260 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1261 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1262 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1263 up to the destructor of gdcmElementSet to clean up TagHt and it's
1266 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1267 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1268 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1270 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * ENH: added some utility method that builds a flat dictionary
1272 holding all the Dicom entries contained in the recursive structure
1273 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1274 an example of usage.
1275 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1276 BuildFlatHashTable() that build a flat dictionary.
1277 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1278 gdcmDocument is now a friend of gdcmElementSet.
1279 - src/gdcmElementSet.cxx: clean up.
1280 - Example/FlatHashTablePrint.cxx added.
1281 - Example/CmakeLists.txt changed accordingly
1283 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1284 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1285 moved away from gdcmDocEntrySet (since this class is an abstract class
1286 acting like an interface). SQDepthLevel and BaseTagKey are now
1288 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1289 and associated accessors. Doxygenation of the class.
1290 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1292 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1293 Use SQDepthLevel accessor instead. ::Print() adapted.
1294 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1295 - src/gdcmDocument.cxx changed accordingly.
1297 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1298 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1299 - The following is the doxygen comment of the typedef declaration
1300 of gdcmTagKey in src/gdcmCommon.h:
1301 gdcmTagKey is made to old an "universal" (as in URL, Universal
1302 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1303 A dicom tag always has a group and an element, but a set of tags
1304 embeded in various (optionally nested) sequences and sharing
1305 the same group and element all share the same (group, element)
1306 "identifier". Hence the (group, element) cannot be used as an
1307 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1308 In order to construct a proper tag identifier (i.e. a key) we
1309 consider the following definition of a TagKey:
1310 - let Group, Element be the string representation of the
1311 group and element dicom tag members,
1312 - let ItemNumber be the string representation of the integer
1313 index of the considered item number of a sequence,
1314 Let the key of a tag embeded in a sequence, noted SeqTag, be
1316 /ItemNumber#Group|Element
1317 where "/", "#" and "|" are characters acting as separators.
1318 Then the general form of a gdcmTagKey is given by:
1319 Group|Element<SeqTag>
1320 where <SeqTag> means NO or many instances of SeqTag.
1321 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1324 but the gdcmTagKey of a tag "embeded" is the first item of
1325 a sequence, itself nested in the third item of a sequence is the
1327 0004|1220/2#0008|0082/0#0008|0090
1328 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1329 order to hold the new sequence compatible key. Previously, the
1330 GetKey() method would look in the underlying gdcmDictEntry.
1331 - src/gdcmDocEntry.cxx:
1332 -- constructor now copies the underlying DictEntry key, in the local
1334 -- ::Print: displays the member Key, instead of the (group, element).
1335 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1336 - src/gdcmDocEntrySet.h:xi
1337 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1338 -- now has a new BaseTagKey member.
1340 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1341 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1343 This poses the problem with the semantics of the following lines
1344 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1345 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1346 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1347 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1348 to the long FIXME note for what the problem is. Nevertheless in
1349 order to get things working the dicom dictionary was altered !
1350 Please fix things urgently...
1351 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1352 information), see above note on moving the member VoidArea. Nevertheless
1353 the following entries previously correctly set as US are now inproperly
1355 0028 1201 OW IMG Red Palette Color Lookup Table Data
1356 0028 1202 OW IMG Green Palette Color Lookup Table Data
1357 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1358 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1359 of gdcmDocEntry moved to gdcmSeqEntry.
1360 * src/gdcmSeqEntry.cxx: STYLE.
1362 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1365 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * gdcmPython/testSuite.py: all the test suite in python is now moved
1367 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1368 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1369 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1371 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1372 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1373 to avoid inclusion recursion until STL is reached.
1374 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1375 mecanism. errno.h is not included in gdcm anymore.
1376 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1377 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1379 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1380 gdcmData/TestAllEntryVerifyReference.txt
1381 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1382 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1383 exception_on_error parameter.
1384 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1385 - vtk/vtkGdcmReader.cxx changed accordingly,
1386 - Example/*.cxx and Test/*.cxx changed accordingly.
1388 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1389 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1390 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1391 enable_sequences removed from gdcmHeader constructor and dependencies.
1392 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1393 * gdcmPython/demo/PrintHeader.py: dummy fix.
1394 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1395 skip_shadow removed from gdcmHeader constructor and dependencies.
1396 * Example/*.cxx and Test/*.cxx changed accordingly.
1398 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1399 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1400 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1402 2004-07-21 Jean-Pierre Roux
1403 * FIX Now, Parsing and Printing a DICOMDIR do work!
1404 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1406 2004-07-20 Jean-Pierre Roux
1407 * FIX Some brain damaged headers have Zero-Lenght fields
1408 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1410 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1412 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1413 variable (instance of gdcmDebug) by a definition macro, and the instance
1414 is now in static in the gdcmDebug class
1415 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1416 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1418 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1419 * WARNING: ctest now depends more tightly on gdcmData. You should
1420 check out gdcmData properly for things to run smoothly...
1421 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1422 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1423 we need the pixels not be loaded in order to use the ValEntry
1424 that displays position and size).
1425 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1426 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1427 be deprecated. If you have any doubts about the advantages of a
1428 modern scripting language (read Python) versus grass root C++ (i.e.
1429 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1430 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1431 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1432 Anyhow, consider documenting the gdcmData images in
1433 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1435 * Test/CMakeLists.txt:
1436 - now uses TestAllEntryVerify.cxx
1437 - specific comments on oldACR00001.ima (now renamed in gdcmData
1438 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1439 gdcmData/TestAllEntryVerifyReference.txt
1442 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * src/*.[h|cxx] : typedef clean up
1444 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1445 - TagKey renamed to gdcmTagKey (for external usage)
1446 - VRKey renamed to gdcmVRKey (for external usage)
1447 - removal of typedef duplication.
1448 - Removed all unecessary inline keyword from class inline definitions.
1449 - Some method|function(void) declarations replaced with method|function().
1450 * src/jpeg/libijg12/jdhuff12.c:
1451 - printf polluting ctest removed.
1452 - TAB removal for comminting
1454 - TestAllReadCompareDicom.cxx: added a test that compares all the
1455 images in gdcmDataImages.h with corresponding images in
1456 gdcmData/BaselineDicom/. When baseline images are not present
1457 this test creates them.
1458 Note: we need to validate each reference image, but before that
1459 I'd like to rename them with a more explicit name...
1460 - CMakeLists.txt: changed accordingly.
1461 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1462 including each header needed).
1464 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1465 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1466 test suite to the Example directory. Are concerned:
1471 - TestWriteSimple.cxx
1472 * Test/CMakeLists.txt: added some comments on reasons for black listing
1473 image gdcmData/oldACR00001.ima
1475 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1476 * Test/CmakeList.txt: removed the following from black list (to be coherent
1477 with removal from gdcmData):
1478 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1479 - gdcm-MR-PHILIPS-16.dcm
1481 Added the following because after last cvs update, they cause
1482 ctest -R TestReadWriteReadCompare
1484 - gdcm-MR-SIEMENS-16-1.acr
1486 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1487 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1488 new comments in this file) we temporarily (sigh) move to a weaker
1490 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1491 we don't need to black list the following images anymore:
1492 - 8BitsUncompressedColor.dcm
1494 - US-PAL-8-10x-echo.dcm
1495 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1496 fixes and the beautified code ;-)
1497 This fixes the bug introduced in version 1.42 (when beautifying)
1498 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1499 Note: ctest was blind to this bug (this means we need to still
1500 improve the test suite). The bug could be detected by using
1501 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1503 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1504 and by displaying the (garbage) produced file temp.XDCM...
1506 2004-06-29 Jean-Pierre Roux
1507 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1508 - replace by uggly but working old code :-(
1509 A lot of things should be OK again.
1510 It's really urgent to have a test suite that *tests*,
1511 to prevent Frog's beautifying sessions to break all the stuff
1512 (twice, withing a fortnigh ...)
1514 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1515 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1516 redundancy) to added Test/TestReadWriteReadCompare.cxx
1517 * Test/CmakeList.txt: because the compare test of
1518 Test/TestReadWriteReadCompare.cxx fails, the following images are
1519 black listed: - 8BitsUncompressedColor.dcm
1521 - US-PAL-8-10x-echo.dcm
1522 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1523 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1524 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1525 and ad-hoc kludge. This kludge is now removed, and on encountering
1526 such an image (OB field brain damaged) we set errno. Then in
1527 ::FindDocLength() we "fix" the length as being ALL what remains
1528 in the file (until EOF). We then proceed, hoping for the best...
1529 This fixes a SegFault in ShowDicom when trying to write such an
1531 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1532 (because TestWriteRead breaks on it, after a non conformal commit?).
1533 ctest now runs properly, except for MakeDicomDir (which was always
1534 broken) and the Python related stuff (still not fixed).
1536 2004-06-24 Jean-Pierre Roux
1537 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1538 FIX : Test/TestReadWrite now iterates on all the file names
1539 (instead of infinite loop)
1540 ENH : Test/TestWriteRead now iterates on all the file names
1542 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1543 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1545 2004-06-24 Jean-Pierre Roux
1546 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1547 when SamplesPerPixel =3
1548 - now Write is no longer confused by
1549 'BitsAllocated = 12" and 'BitsStored=12"
1550 - "UN" value representation Elements are now written correctly
1551 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1552 ENH : - now gdcmHeader has its own Write methods
1553 (in order to split the job that has not to be done
1556 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1557 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1558 loop on the same image until memory went out.
1559 Note: this means we still have gobs of memory loss in PrintDocument
1560 * src/gdcmDocument.cxx: fixes problem on parsing on file
1561 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1563 2004-06-24 Jean-Pierre Roux
1564 FIX : Write - All the Sequences and Sequence Item are now written
1565 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1566 is added a the end, when necessary.
1567 - A lot of brain-damaged images, that were read correctly are
1568 now written correctly
1569 - length compatible BinEntry are now loaded correctly
1570 (even for odd groups)
1571 Note : only Explicit Value Representation was checked.
1572 (question : is implicit VR really necessary for gdcm ?)
1574 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1575 * DEVELOPPER: added a proposition of coding style.
1576 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1579 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1580 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1581 Use the gdcmDocEntry::Print() and Write() instead.
1582 * src/gdcmDocument.cxx: bug fix.
1584 2004-06-22 Jean-Pierre Roux
1585 FIX : gdcmDocument.cxx
1586 - Now we do recognize the JpegLossLess format (there was a misstyping in
1587 code 'beautyfication' :-(
1588 - Now we automaticaticaly load the Luts, if any
1590 2004-06-22 Jean-Pierre Roux
1591 In order : to write Sequences, whatever their imbrication level,
1592 : to allow user to create his own Sequences
1593 a lot of modif where necessary (adding, moving, or virtualising methods)
1595 WARNING : save your own sources *before* cvs up !
1598 ADD virtual void Write(FILE *fp, FileType filetype);
1601 ADD virtual void Write(FILE *fp, FileType filetype);
1602 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1605 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1606 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1607 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1608 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1609 ADD std::string GetEntryByName(TagName name);
1610 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1612 std::string vr = "unkn",
1613 std::string fourth = "unkn",
1614 std::string name = "unkn");
1615 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1616 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1617 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1618 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1619 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1620 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1621 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1622 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1625 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1626 ADD virtual std::string GetEntryByName (TagName tagName);
1627 ADD virtual std::string GetEntryVRByName (TagName tagName);
1628 REM virtual bool Write(FILE *, FileType);
1629 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1630 FILE *_fp, FileType type);
1631 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1632 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1633 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1634 REM virtual std::string GetEntryByName (std::string tagName);
1635 REM virtual std::string GetEntryVRByName (std::string tagName);
1636 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1637 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1638 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1640 std::string vr = "unkn",
1641 std::string fourth = "unkn",
1642 std::string name = "unkn");
1643 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1644 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1645 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1646 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1649 ADD virtual void Write(FILE *fp, FileType filetype);
1652 ADD virtual void Write(FILE *fp,FileType filetype);
1655 ADD virtual void Write(FILE *fp, FileType filetype);
1656 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1657 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1658 REM std::string GetEntryByName(TagName name);
1661 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1663 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1664 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1665 The default constructor invoked by the line
1666 gdcmHeader *f1 = new gdcmHeader( header );
1667 was gdcmHeader::gdcmHeader(bool) instead of the expected
1668 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1669 Hence the parsing wasn't executed... See also below.
1670 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1671 as explicit constructor didn't do the trick to fix the above problem.
1672 Could anyone explain why ?
1673 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1674 properly calls gdcmValEntry::Print() (that was weed out from
1675 code related to gdcmBinEntry).
1677 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1678 * In order to fix memory leaks:
1679 - Test/TestWriteSimple.cxx: added cleaning of free store through
1681 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1682 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1683 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1684 (through the call to ::AddDicomDirMeta()) or the destructor
1685 would crash when deleting uninitialized ::metaElems].
1686 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1687 - src/gdcmDocument.cxx:
1688 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1689 from dynamic stores.
1690 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1691 was causing memory leaks.
1692 - src/gdcmSQItem.cxx:
1693 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1694 cleanly handled with polymophism: sorry but my milage is low).
1695 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1696 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1697 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1698 This avoids SegFaulting.
1699 - src/gdcmSQItem.h: coding style.
1701 - Test/TestWriteSimple still severely sucks. The output image content
1702 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1703 damaged when displayed with vtkgdcmViewer.
1704 - on memory leaks: TestWriteSimple leaks really less (see entry
1705 of 2004-06-18 in Changelog file for the call to valgrind).
1706 - on segfaults: ctest now passes all the tests but one (no more
1708 * Erroneous leading white fix:
1709 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1710 white[s] (as opposed to from >> xxx, that removes it [them].
1711 - src/gdcmTS.cxx: ditto.
1712 - gdcmPython/testSuite.py: dirty related kludge removed.
1713 * src/*: remaining references to gdcmParser removed.
1714 * src/*[cxx|h]: added copy[way]left header.
1717 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1718 * In order to fix writing of dicom files:
1719 - Test/TestWriteSimple.cxx: a simpler example of writing.
1720 - Test/CMakeLists.txt changed accordingly.
1721 - src/gdcmDocument.cxx:
1722 -- The destructor now recursilvely removes potential sequences.
1723 -- Bug fix in ::IsJPEG2000()
1724 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1725 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1727 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1728 to only declared) and build on top of
1729 ::GetDocEntryByNumber(guint16, guint16).
1730 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1731 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1732 for usage in destructor and treatement of promotion in
1733 ::ReplaceOrCreateByNumber().
1734 - src/gdcmSQItem.cxx: destructor should better handle his job.
1735 Test/TestWriteSimple now runs (or at least it DOES something).
1736 * We can now start hutting memory links. A good starting point is:
1737 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1738 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1739 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1741 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1742 * Valgrind note: after Mathieu Malaterre teached me how to read
1743 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1745 Using gcc, you can force the STL to use malloc and to free memory as
1746 soon as possible by globally disabling memory caching.
1747 With 3.2.2 and later, you should export the environment variable
1748 GLIBCPP_FORCE_NEW before running your program.
1749 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1750 simply vanish (it is still not clear to me, whether this means that
1751 STL std::string leaks or if valgrind believes it leaks...).
1752 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1753 running bin/gdcmTests makeDicomDir):
1754 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1755 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1757 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1758 SegFaulting (I drowned in DicomDir related code when trying to
1759 understand why the list is empty...).
1760 * src/gdcmDocument.h: first BSD license header try.
1761 * Doc/License.txt added.
1763 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1764 * src/gdcmDocument.[h|cxx]:
1765 - Clean up of the Transfer related predicates. They are now all based
1766 on new method isGivenTransferSyntax, that (should) handle properly
1767 the padding problem.
1768 - general clean up, simplification, and coding style.
1769 - Specific clean up of Parse7FE0() (umproperly named actually).
1770 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1772 2004-06-14 Jean-Pierre Roux
1774 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1775 - fix the display of SQItem ordinal number
1776 - add the GetSQItemByOrdinalNumber method
1777 - remove some useless never written private methods
1779 2004-06-14 Jean-Pierre Roux
1781 - adding a constructor taking a gdcmDocEntry as an input param
1782 - ReplaceOrCreateByNumber now returns :
1783 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1784 a gdcmValEntry * if a string value is passed as a param
1786 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1787 according to the param type (no longer sets a gdcmDocEntry)
1788 - GetValEntryByNumber, GetBinEntryByNumber added
1789 - NewValEntryByNumber and NewBinEntryByNumber added
1791 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1793 - GetSQItemNumber and SetSQItemNumber added, to provide
1794 a (relative) Item identier inside a given Sequence
1795 \warning : some pb remaining around this number
1797 - AddEntry now takes the Item Number as a param
1799 - adding a constructor taking a gdcmDocEntry as an input param
1801 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1802 * Memory leak hunt with the following command:
1803 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1804 --show-reachable=yes gdcmTests PrintDocument
1805 It looks like many (all?) leaks are due to the STL (or a bad usage
1806 of the STL. The lines producing the leaks now have a comment with
1807 a "MEMORY LEAK" tag: you can retrieve them with
1808 grep "MEMORY LEAK" src/*
1809 Here are two typical examples which I can't help fixing:
1814 char * test = "babo";
1815 name = test; //// <--- valgrind detects 960 bytes lost in
1816 //// call to std::string::operator=(char const*)
1817 name.clear(); //// Doesn't help !
1825 std::cout << "Type a bunch of characters followed by RETURN: ";
1826 getline(std::cin, line); //// <--- valgrind dectects a loss
1827 //// of 1320 bytes in call to
1828 /// std::basic_istream<>& std::getline<>
1834 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1835 * src/gdcmHeader.[cxx|h]:
1836 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1837 and related, moved away to gdcmDocument.
1838 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1839 the corresponding protected accessors of inherited class
1840 gdcmDocument, removed ! As a consequence gdcmFile had to be
1841 declared friend of class gdcmDocument (see below).
1842 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1843 - Clean up of undefined or unused methods.
1844 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1845 account the changes to gdcmHeader.h).
1846 * src/gdcmDocument.h:
1847 - gdcmFile is now a friend class (in order to take into account the
1848 changes to gdcmHeader.h).
1849 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1850 (see changes to gdcmHeader.h).
1851 - Accessors (reading on the form GetEntry*) are now public.
1852 - Clean up of undefined or unused methods.
1853 * src/gdcmDocument.cxx:
1854 - adaptation to changes to gdcmDocument.h
1855 - ::OpenFile now writes a verbose message when file cannot be opened.
1856 - some std::string properly set to VRKey
1857 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1858 references to gdcmDocument.
1859 * Test/TestFindTags.cxx: changed accordingly to above changes.
1860 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1861 cvs repository gdcmData.
1863 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1865 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1866 conflicts with gdcmValEntry::voidArea.
1867 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1868 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1869 Value representation between StringRepresentable and BinaryRepresentable.
1870 * src/gdcmDocument.cxx:
1871 - method ParseDES: proper indentation restored and usage of
1872 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1873 - method LoadDocEntry: the fingerprint left in the SetValue() of
1874 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1875 removed. Reverting to previous code segment with the proper
1876 dynamic_cast< gdcmValEntry* >.
1877 Note: this was (partially) breaking the python test suite
1878 (gdcmPython/testSuite.py) that made usage of the above
1879 fingerprint to check presence of "Pixel Data".
1880 * src/gdcmDocEntry.h: coding style.
1881 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1882 now taken into account.
1883 * gdcmPython/gdcm.i: adaptation to the new internal representation
1884 of gdcm (exit gdcmParser, hello gdcmDocument).
1885 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1887 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1888 anymore, but instead prints the loaded Python dictionary.
1889 * .... alas, the python testSuite is still broken.
1891 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1894 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1895 * src/gdcmUtil.h : export methods
1897 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1900 * Initial addition of automatic python testing
1901 * Initial addition of automatic image comparison
1903 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1904 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1905 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1907 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1908 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1909 * Test/ShowDicom.cxx : bug fix for msvc compilation
1910 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1912 2004-05-04 Jean-Pierre Roux
1913 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1914 new concepts (and new classes) :
1915 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1916 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1917 - Sequence Doc Entries (gdcmSeqEntries)
1918 a Sequence is composed of Items.
1919 Each item is a set of Doc Entries (this is recursive)
1920 The non uniqueness of the 'Dicom tag' is due to this recursivity
1921 (never taken into account)
1922 Our unability to add a new 'entry' in the header
1923 at the proper location (neither in the H-Table (map or multimap),
1924 nor in the Chained List is also due to this recursivity.
1925 Don't try, right now, to use/modify/compile these new sources :
1926 nothing is finished.
1927 We just commit all the stuff, 'as is', in order not to loose it.
1929 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1930 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1932 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1933 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1934 file prefix (SetFilePrefix)
1936 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * Add a new test: ShowDicom, for now this is just the c++ version of
1938 checkRead.sh, later it will be able to compare the image read against a
1940 * Replace the DEBUG on the stack with a global entry in cmake interface:
1941 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1943 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * Add an example subdir, with a real example on how to read + write a
1947 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1949 * Doc/CMakeLists.txt: the main page is now properly differentiated
1950 between the developper and user version.
1951 * Doc/doxygen.config.in: dropped search related obsolete flags
1952 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1954 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * DEVELOPPER: added some helpfull comments for compile/test/install
1958 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1959 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1960 src directory, now generated in the build dir.
1961 2. Tests as mentionned smarter
1963 4. Add a new method in gdcmDict that return the PubDict by name
1964 this is interesting for 3rd party lib like ITK,
1965 where we could set the institution name / patient name...
1967 * ENH: 1. Now the test suite is working for real
1968 2. All binaries are now output in the gdcm-bin directory
1969 (this was not true before)
1971 2004-04-28 Jean-Pierre Roux
1972 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1973 SeQuence indented printing of Dicom Header.
1974 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1975 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1976 Computation of SQDepthLevel is now part of gdcmHeader constructor
1977 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1978 tree-like structure of a Dicom Header.
1979 * FIX Test code cleaning
1981 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1982 * ENH: Adding automatic testing
1983 1. Need a DartConfig.cmake to submit to public
1984 2. Add a test driver gdcmTest.cxx
1985 3. gdcmTestMain, an helper for the main test driver gdcmTest
1986 4. Files in Test don't have a main anymore, this becomes interesting
1987 when we add more and more tests, thus dsw don't have to load
1989 * ENH: Adding a GDCM_DATA_ROOT for testing
1990 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1991 one file instead of seven + some small cleanup
1993 2004-04-22 Jean-Pierre Roux
1994 * ENH Minor changes to the Print() methods.
1995 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1996 Header printing. Example given with :
1997 > PrintHeader fileName 2 new
1998 (SQ based tree-like structure still to be done for the Header ...)
2000 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2001 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2002 1. I have added some unsigned where needed
2003 2. Some function parameter not used -> (void)
2004 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2005 4. g++ don't like character '\' in comment
2006 5. #define jpeg_create_decompress jCreaDecompress
2007 this really need to be fixed
2008 6. virtualize destructor of gdcmObject ... leakage
2009 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2010 this also really need to be fixed
2011 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2012 remove compression file
2013 (as we only do decompression, right ?)
2014 * ENH: Change malloc/calloc/free with c++ equivalent
2016 2004-04-21 Jean-Pierre Roux
2017 * FIX gdcmHeaderHelper::GetXSpacing
2018 when a single value is found (bug ?), xpacing is now
2019 defaulted to yspacing
2021 2004-04-19 Jean-Pierre Roux
2022 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2023 * ENH add parameters :
2024 bool exception_on_error = false,
2025 bool enable_sequences = false,
2026 bool ignore_shadow = false
2027 to the gdcmFile constructors to be full gdcmParser compliant
2028 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2029 to allow reading of PAPYRUS 3.0 files
2031 2004-04-06 Jean-Pierre Roux
2032 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2034 2004-04-02 Jean-Pierre Roux
2035 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2036 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2037 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2039 2004-03-30 Jean-Pierre Roux
2040 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2041 for ACR file, written out as DICOM files (hope so...)
2043 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2044 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2045 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2046 moved to base class gdcmParser and only the specialisation is kept
2048 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2049 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2050 already does the job.
2051 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2052 (to be consistent with gdcmParser::WriteEntries).
2054 2004-03-30 Benoit Regrain
2055 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2056 upate of the object's instance. It's passed to 2 in the unfavorable
2057 case : one in the ExecuteInformation, one in the ExecuteData
2059 2004-03-29 Jean-Pierre Roux
2060 * ENH : Check on file type to be written moved
2061 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2062 * FIX : gdcmObject::ResetBoundaries now stops properly
2063 when end-of-list is reached
2064 : gdcmVersion modified (as Benoit Regrain asked)
2066 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2068 * src/gdcmUtil.cxx: added forgotten iostream include.
2069 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2070 equivalent to ExplicitVR in existing code).
2072 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2074 now contains all the gdcmGlobal related code.
2075 * minor coding style and doxygenation changes.
2077 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2078 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2079 now contains all the Debug related code.
2080 * minor clean-up of includes in src/*.cxx
2081 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2082 CreateCleanString) removed.
2083 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2084 * Doc/DoxyMainPageUser.txt added.
2085 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2086 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2087 src/gdcmDirList.cxx)
2089 2004-03-24 Jean-Pierre Roux
2090 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2092 2004-03-23 Jean-Pierre Roux
2093 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2094 big endian made volumes
2095 * ENH Now gdcmParser constructor and destructor are protected to forbid
2096 end user to instanciate class gdcmParser
2097 (only gdcmHeader and gdcmDicomDir are meaningfull)
2099 2004-03-22 Benoit Regrain
2100 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2101 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2102 gdcmSerie to gdcmDicomDirSerie
2104 2004-03-19 Jean-Pierre Roux
2105 * ENH Now the tree-like structure describing a DICOMDIR comming from
2106 an already existing DICOMDIR file is consistent with
2107 the home-made tree-like structure build ex-nihilo
2108 or build from the files held (recursively) in a Directory
2109 functions gdcmDicomDir::CheckBoundaries()
2110 gdcmObject::SetBoundaries() added
2112 2004-03-17 Jean-Pierre Roux
2113 * REM (Eric Boix bug) : removal of meaningless
2114 gdcmDicomDirImage::NewImage function.
2115 * FIX now file names and directory name are written properly in the
2117 * FIX now gdcmDicomDir constructor may be call without any trick
2120 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2122 of gdcmDicomDirImage::NewImage as empty function.
2124 2004-02-28 Jean-Pierre Roux
2125 * ENH add gdcmDicomDir:NewPatient
2126 add gdcmDicomDirPatient:NewStudy
2127 add gdcmDicomDirStudy:NewSerie
2128 add gdcmDicomDirSerie:NewImage
2129 to allow making gdcDicomDir object.
2130 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2131 (as opposite to the gdcmHeader chained list)
2133 2004-02-11 Benoit Regrain
2134 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2135 when using from python
2137 2004-02-10 Benoit Regrain
2138 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2139 * FIX : in gdcmDicomDir when the directory is empty
2140 * ENH : add callback and methods to get the progression of dicomDir
2143 2004-02-06 Jean-Pierre Roux
2144 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2145 - GDCM_META added to gdcmDicomDirType
2146 - class gdcmMeta created
2147 * ENH : - A brief summary is now displayed at the beginning of
2148 'testDicomDir' to help disaster magnitude estimation
2149 * REM : Now useless Test/explDICOMDIR.cxx
2151 2004-02-05 Benoit Regrain
2152 * ENH : add methods in gdcmObject to get the hash table or the list of
2154 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2155 * FIX : wrapping python for TagHeaderEntryHT
2157 2004-02-04 Benoit Regrain
2158 * FIX : even length for some strings when writting the dicom dir
2159 * FIX : sort the images in the dicom dir
2160 * FIX : Bug fix for python use of dicom dir
2161 * ADD : a python demo
2163 2004-02-04 Jean-Pierre Roux
2164 * FIX : Final solution (?) for icone embedded images
2165 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2166 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2167 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2168 gdcmData/gdcm-MR-SIEMENS-16.acr1
2169 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2170 to make full checking easier
2172 2004-02-04 Benoit Regrain
2173 * FIX : WriteEntries : coding style & logic in parameters
2174 * FIX : Set the elements to create the DicomDir in a dictionary file
2176 2004-02-03 Benoit Regrain
2177 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2178 * gdcmDicomDir : add the load of directory
2179 * Bug fix and print add-on
2181 2004-02-03 Jean-Pierre Roux
2182 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2183 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2184 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2185 * FIX gdcmParser.cxx : 'group length' elements are now considered
2186 as integers, even for shadow groups, when file is Implicit VR
2188 2004-02-02 Jean-Pierre Roux
2189 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2191 of the last synonym :-(
2192 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2194 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2195 * FIX taking into account the possible 7fe0,0010 multiplicity
2196 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2197 to allow removal of references to 7fe0,0010, to deal with
2198 ACR-NEMA images, when 0028,0200 is meaningfull
2200 2004-01-31 Jean-Pierre Roux
2201 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2202 no longer writes 'Un' on disk
2203 * FIX SQ elements with actual length are now dealt with corectly
2204 * FIX gdcmFile::WriteBase make the difference, for color images, between
2205 the length (for Palette expanded images)
2206 and Raw Length (non expanded image + Palette)
2207 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2208 (that broke Write). Replaced by UL.
2209 Aware user will reload the field if he
2210 thinks it's necesssary
2212 2004-01-30 Jean-Pierre Roux
2213 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2214 when 'dirty Acr' is found, to be compliant with the new
2215 IsReadable() methods.
2217 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2218 (no DOUBLE images in kosher DICOM,
2219 but so usefull for people that miss them ;-)
2221 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2222 DICOMDIR related utilities (not checked as Windoze compliant)
2224 2004-01-28 Jean-Pierre Roux
2225 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2227 2004-01-27 Jean-Pierre Roux
2228 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2229 to allow skipping the shadow elements, to save memory space.
2230 The TRUE value for this param has to be used
2231 with a FALSE value for the 'enable_sequence' param.
2232 ('public elements' may be embedded in 'shadow Sequences')
2233 * gdcmHeader methods now deal with 'embedded icones images' in the header
2234 (even when an 'icone image sequence' is announced by the
2235 element (0x0088,0x0200), but there is NO icone at all ...
2237 * gdcmHeader sometimes Image Location value doesn't follow
2238 the supposed processor endianity (see gdcmData/cr172241.dcm).
2241 * gdcmHeader add the method
2242 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2243 to get *all* the Header Entries with the same tag.
2244 GetHeaderEntrySameName is probabely *useless*
2245 (no meaning : Name is *not* an identifier within the Dictionary)
2247 2004-01-26 Benoit Regrain
2248 * Bug fix in the print of hexadecimal representations. Remove long fields
2249 in the print and add a third level of print to print them
2251 2004-01-23 Benoit Regrain
2252 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2253 * Bug fix on test suite after remove the strip made on not string fields
2254 * Split the IsReadable method between gdcmParser which test that the file
2255 is dicom and gdcmHeader which test that it's an image file
2257 2004-01-22 Benoit Regrain
2258 * DicomDir : clean code, add methods, set variables in protected or private
2259 * gdcmUtil : bug fix for the clean string method
2261 2004-01-19 Benoit Regrain
2262 * Add the use of shadow dictionaries
2263 * bug fix and coding style
2265 2004-01-19 Benoit Regrain
2266 * src/gdcmFile.cxx : bug fix concerning the close of file
2267 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2268 * Add the update of header entries using the shadow library
2270 2004-01-19 Benoit Regrain
2271 * removal of file gdcmHeader2.cxx
2272 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2273 inheriting from gdcmParser. This split is to prepare the integration
2274 of dicom dir parsing
2275 * bug fix under python
2277 2004-01-16 Jean-Pierre Roux
2278 * REM removal of class gdcmHeaderEntrySet
2279 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2280 * ADD add file gdcmHeader2.cxx
2281 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2283 2004-01-15 Benoit Regrain
2284 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2285 entries created while parsing the header. Thus, they will be destroyed
2286 when the gdcmDictSet will be destroyed
2287 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2290 2004-01-15 Benoit Regrain
2291 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2292 made a fatal error because of the memory release at the end of program.
2293 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2294 some memory and vtk seems to have some problems with that.
2295 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2297 2004-01-14 Benoit Regrain
2298 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2299 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2300 * src/*.[h|cxx] : make changes due to class name changes
2301 * gdcmPython/demo/*.py : bug fix due to method names
2303 2004-01-13 Benoit Regrain
2304 * src/*.[h|cxx] : coding style
2305 * vtk/*.[h|cxx] : coding style
2307 2004-01-13 Benoit Regrain
2308 * gdcmPython/testSuite.py : test the readable flag of file for tests
2309 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2310 It's lied to the stl compilation by MSVC (windows, always windows...)
2311 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2313 2004-01-12 Benoit Regrain
2314 * src/*.h : add comments
2315 * src/gdcmDictSet.h : set the method BuildDictPath in public
2316 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2317 directly setted in the source code
2318 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2321 2004-01-09 Benoit Regrain
2322 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2323 * setup.py : use a reference to gdcmVERSION
2325 2004-01-07 Benoit Regrain
2326 * Modification to compile with the distutils.
2329 2003-12-10 Benoit Regrain
2330 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2331 can use a gdcmHeaderHelper to load data
2332 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2333 made in the source code
2335 2003-12-10 Benoit Regrain
2336 * Update Windows projects and .cvsignore files
2338 2003-11-12 Jean-Pierre Roux
2339 * ENH gdcmHeader constructor has one more parameter (default value : false)
2340 that allows the user to 'go inside' the SeQuences only
2342 gdcmElValSet:Print takes it into account
2344 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2345 * ENH: Update gdcmPython/CMakeLists
2346 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2347 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2349 2003-11-10 Jean-Pierre Roux
2350 * FIX : gdcmHeader::LoadElements is now based
2351 on the ListTag listElem member,
2352 not longer on the TagElValueHT tagHt member
2353 * ENH : PrintPubElVal shows (temporarily) both results,
2354 with the tagHt member and the listElem member.
2355 (it's easier to 'see' the problems when using Printheader)
2357 * FIX : old private member LgrElem is now splitted into
2358 ReadLength : Length actually found on disk (updated only
2359 if bug fixing is necessary), for internal
2361 UsableLength : Updated by FixFoundLength, to fix a bug
2362 or to allow Parser going on.
2363 Will allow to re-write a kosher header when a SeQuence
2364 with a length (not 0000) is found
2365 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2366 because gdcmElValSet::Add does not update ListElem
2369 2003-11-07 Jean-Pierre Roux
2370 * FIX misstyping in Transfert Syntax name table
2371 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2372 when they have an actual length (not 0000 nor FFFFF)
2373 (Nobody should care of it, but DICOMDIR explorers)
2375 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2376 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2378 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2379 * ENH: vtkGdcmReader now supports LUT !
2380 (vtkgdcmViewer for now is not able to use them though)
2382 2003-11-05 Jean-Pierre Roux
2383 * in testSuite.py : new files names for checking the package
2384 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2385 that returns the pixel area size to the *aware* (vtk) user
2386 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2388 2003-11-05 Benoit Regrain
2389 * in testSuite.py : Modify the rules for checking the paths
2390 : Explicit error messages
2391 * in __init__.py : Related modif
2393 2003-11-03 Jean-Pierre Roux
2394 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2395 to be used by aware (vtk) users that want to manage
2396 LUT (and no to turn the PALETTE image into an RGB pixels one)
2397 * GetPixelType now returns 8U for 24 Bits images
2398 (vtkGdcmReader compliant)
2400 2003-10-31 Jean-Pierre Roux
2401 * Removal of *all* gdcmData images and add them again
2402 in order to loose the 'history' of un-anonymised images
2404 2003-10-31 Jean-Pierre Roux
2405 * RMV : removal of useless jBitsInJsample.h
2406 for both 8 and 12 Bits JPEG Lossy Libraries
2408 2003-10-31 Jean-Pierre Roux
2409 * ENH : Add the functions gdcmFile::GetImageDataRaw
2410 gdcmFile::GetImageDataIntoVectorRaw
2411 that act as GetImageData and GetImageDataIntoVector
2412 except the making of an RGB Plane from Gray Plane + LUT
2413 Intended to aware (vtk) users who know how to manage
2416 GetLUTRGBA return a R,G,B,A LUT if any
2417 lgrTotaleRaw gives the 'Raw' length
2418 GetImageDataRaw returns the gray Plane
2419 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2420 (They stay Grey, just like with other Dicom viewers :-(
2422 2003-10-30 Jean-Pierre Roux
2423 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2425 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2426 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2427 being coherents dicom files.
2429 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2430 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2432 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2433 * ENH: Two steps is necessary to please VC++ compiler...
2434 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2435 * ENH: Add include dir to medcon lib
2436 * FIX: only one function is being exported for now !
2437 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2439 2003-10-29 Jean-Pierre Roux
2440 * adding gdcmHeader::GetLUTRGBA
2441 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2442 --> Mathieu, the modif u're waiting for is not yet committed
2443 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2445 2003-10-27 Jean-Pierre Roux
2446 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2447 00191113.dcm DermaColorLossLess.dcm
2448 MxTwinLossLess.dcm RadBWLossLess.dcm
2449 * ENH: For version prior to vtkImageViewer2 -r 1.19
2450 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2452 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2453 * Removal of ido stuff in CMakeLists.txt
2455 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2456 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2457 * FIX: remove a call to ->Modified ... see comments
2458 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2460 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2461 * FIX: Problem with path for libvtkgdcmPython
2462 * ENH: Try adding a search script for python site-package
2463 * RMV: Remove some file from medcon lib that are not necessary
2464 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2465 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2466 * FIX: More pragma disable fro VC++,
2467 I don't think I break something as it is also disable in VTK/ITK.
2468 But it fasten debug compilation time.
2470 2003-10-23 Jean-Pierre Roux
2471 * gdcm now deals with 16 Bits Run Length Encoded images
2472 (they are compressed as 2 planes images,
2473 one for the high Bytes, the other for low Bytes)
2475 2003-10-22 Jean-Pierre Roux
2476 * Now CheckRead takes into account :
2477 - the bugged 'Leonardo' Siemens images
2478 - the XA images, sent thru the burning VPRO station
2479 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2482 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2483 * FIX: When copying a Makefile.am to CMakeLists.txt
2484 one should remove the '\'
2486 2003-10-22 Jean-Pierre Roux
2487 * in gdcmData adding a bugged 'Leonardo' Siemens image
2488 (wrong lengths in header)
2489 OK with gdcm, KO with the other viewers :-)
2490 * add a GE dlx XA image, thru the VEPRO burning station
2493 2003-10-21 Jean-Pierre Roux
2494 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2495 for a brutal checking of vtkgdcmViewer compliance
2497 2003-10-21 Jean-Pierre Roux
2498 * add the files for 'xmedcon' Jpeg Lossless library
2499 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2501 2003-10-21 Jean-Pierre Roux
2502 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2504 2003-10-21 Jean-Pierre Roux
2505 * garbage Siemens 'Leonardo' images dealt with
2506 (the patch is easy to remove)
2507 * cosmetic changes to avoid warnings
2509 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2510 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2511 no need to press 'r' now.
2513 2003-10-20 Jean-Pierre Roux
2514 * upgrade of checkRead.sh checkWrite.sh according
2515 to new Jpeg Lossless decompressor
2516 * add US.3405.1.dcm, a genuine RGB medical file ...
2517 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2518 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2520 2003-10-15 Jean-Pierre Roux
2521 * general anonymisation in gdcmData
2522 * adding the 'color files' from
2523 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2524 * adding some well knowed bugged-header images
2525 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2526 waiting for their inclusion in Python testsuite
2528 2003-10-15 Jean-Pierre Roux
2529 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2530 no longer seg faults when file is not found
2532 2003-10-14 Jean-Pierre Roux
2533 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2536 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2537 * TODO: *.in file to genereate a UseGDCM later
2539 2003-10-14 Jean-Pierre Roux
2540 * Some supposed-to-be Dicom Images have no preamble.
2541 OpenFile takes it into account
2542 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2543 * Missing elements added in dicomV3.dic
2544 (just to be affraid : have a look at
2545 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2546 and do it again next year ;->
2548 2003-10-13 Jean-Pierre Roux
2549 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2550 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2551 But there are NOT. It's fixed !
2553 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2554 * FIX: "jpeglib.h" was not found on VC++
2555 * FIX: vtkgdcm was not being installed
2557 2003-10-10 Jean-Pierre Roux
2558 * ENH : OpenFile closes the file if it *really* doesn't look like
2559 an ACR-NEMA / DICOM one.
2560 * FIX : testWrite no longer writes an empty file if the source file
2561 is not gdcm Readable
2562 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2565 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2566 * FIX: CMake generate now documentation
2567 * ENH: out of source doc build !
2568 * ENH: Generate both user and dev documentation
2569 * ENH: Should work on windows too
2570 * ENH: Only one doxygen config.in file is needed
2571 * FIX: make install should be ok now on ùnix plateform
2572 * FIX: PATH to dictionary was wrong (missing /)
2573 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2575 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2576 * vtkGdcmReader is now able to read rgb dicom file.
2577 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2578 * added a gdcmViewer to vtk test, use mouse to control
2579 window level & window width
2581 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2582 * CMake-ification of gdcm, we have now two build system
2583 * FIX: on cygwin Wsock32 doesn't exist
2584 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2586 2003-10-06 Emanuel Ollart
2587 * FIX : compilation process wad broken.
2588 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2590 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2591 * change gdcmViewer -> vtkgdcmViewer
2592 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2594 2003-10-06 Jean-Pierre Roux
2595 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2596 ( e.g : well known GE images with a wrong elem length,
2597 : Philips MRI Images with a wrong Huffman table)
2598 * still to be done : allow the reading of bugged LEONARDO Siemens images
2600 2003-10-03 Jean-Pierre Roux
2601 * Odd length strings are padded with '\0' (not with spaces,
2602 to remain compliant with already defined strings,
2603 like Transfert Syntax UID and others)
2605 2003-10-03 Jean-Pierre Roux
2606 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2607 to allow displaying RGB images (not only by affim ;-)
2609 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2610 * vtkGdcmReader is now able to read rgb dicom file.
2611 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2613 2003-10-03 Jean-Pierre Roux
2614 * A few nasty patches to allow the reading of a lot of nasty images
2615 ( e.g : well known GE images with a wrong elem length,
2616 : Philips MRI Images with a wrong Huffman table)
2617 * still to be done : allow the reading of bugged LEONARDO Siemens images
2619 2003-10-03 Jean-Pierre Roux
2620 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2622 2003-10-03 Jean-Pierre Roux
2623 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2624 to allow displaying RGB images (not only by affim ;-)
2626 2003-10-03 Jean-Pierre Roux
2627 * gdcmFile::GetImageDataIntoVector now
2628 - deals with MultiFrames MultiFragments Run Length Encoded files
2629 - deals with YcBcR (YBR_FULL) files
2630 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2631 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2633 (no sample found :-(
2635 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2636 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2637 Two reasons: - clear things
2638 - third parties acces gdcm through header files, so won't
2639 suffer anymore VC++ complains
2641 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2642 * add argv[1] in testvtkGdcmReader.cxx
2645 2003-09-24 Jean-Pierre Roux
2646 * The lines are now eigthy characters long.for
2647 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2649 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2650 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2651 char* to std::string. Thus, the use of strdup becomes useless. (see
2652 previous commis of Malaterre)
2653 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2654 before the last Malaterre's commit.
2656 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2657 * This commit should fix the Debug building under VC++, the problem
2658 was mainly a mixture of debug and release lib being loaded at startup.
2659 * I also remove a depency to a specific C function: strdup. Because I had
2660 to force the link to msvcrtd (whereas strdup is in libc).
2662 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2663 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2664 located in the gdcmCommon.h file. All use of reference of tha has been
2665 changed to now use the variable GDCM_UNFOUND.
2667 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2669 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2670 Dicom dictionary. The test suite can now be run again. Note:
2671 I'm note very happy with the " (RET)" changes. I believe this
2672 RETAINED comment should be dropped when parsing the dictionary.
2673 - PACKAGER corrected
2675 - AUTHORS updated and now in alphabetical order
2676 * Makefile.am now exports gdcm.dsw for Windoze users.
2678 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2679 * cygwin complains about missing std:: in subdir Test/
2681 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2682 * remove some methods that are now in gdcmHeaderHelper
2684 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2685 * vtkGdcmReader set spacing and origin correctly
2687 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2688 * Fix a few delete/delete[] mismatch
2690 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2691 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2692 interpretation to data given by gdcmHeader. For instance there are
2693 heuristics to get informations (look at different places).
2694 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2695 sorting DICOM images based on different strategies.
2696 * modified Makefiles accordingly.
2698 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2699 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2700 when building in debug mode
2701 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2702 src/win32/gdcmdll.dsp
2703 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2705 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2706 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2709 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2710 * src/win32/libgdcmjpeg12.dsp was not dos format
2711 * src/win32/libgdcmjpeg12.dsp :
2712 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2713 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2715 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2716 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2718 * src/gdcmFile.cxx : bug fix in affectation type
2719 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2720 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2721 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2722 symbols... future problem ?
2724 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2725 * src/win32/libgdcmijpeg12.dsp was missing
2726 * modified gdcm.dsw accordingly
2728 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2729 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2731 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2732 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2733 commit of JPR (before his hollidays to facilitate our work).
2734 * setup.py : bug fix in code. Modifications made while the last commit
2735 of JPR. The code hasn't been tested before the commit... it's so
2736 useless to make that (for best programmer that is JPR) !!!
2738 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * tagged the current version as Version0_3 (i.e. version 0.3)
2741 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2742 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2743 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2744 * *.dsp : modifications to use new libgdcmijpeg8 library
2745 * setup.py : bug fix on VTKPATH variable
2746 * PACKAGER : adding all concerning windows
2748 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2751 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2752 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2753 test suite reported error.
2754 * PACKAGER file added (describes what a packager must do when
2755 packaging a new release).
2756 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2757 * configure.in: upgraded version number to 0.3.0
2758 * fixing build of rpm (through rpm -ta):
2759 - Doc/Makefile.am exports proper doxygen files
2760 - src/jpeg/libijg8/Makefile.am exports the include files.
2762 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2763 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2764 * src/gdcmHeader.h : formatting code
2766 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2767 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2768 We were obtaining error message from vtk. Now, creation of file list
2769 is made in an internal list to prevent this problem.
2770 Bug fix when output is empty.
2771 Bug fix in update of progress value. Previous commit for this was a bad
2773 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2775 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2776 * src/gdcmHeader.h : added method to get the file name
2777 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2778 files. Added method to remove all files on the input
2779 Added FIXME comment concerning the bad parsing of header made by
2780 ExecuteInformation method (in ExecuteData method)
2782 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2783 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2784 when using make instal.
2785 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2786 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2788 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2789 * setup.py : adding include dir of jpeg lib to compile all sources
2790 * */Win32/*.dsp : JPR fix for windows compilation
2792 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2793 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2795 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2796 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2798 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2799 * setup.py is again effective on un*x (takes into account the
2800 addon of the jpeg library)
2801 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2802 * Doc/Doxy* updated (includes above enhancements)
2803 * INSTALL now points to web documentation
2805 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * src/gdcmHeader.h doesn't make unnecessary reference to
2808 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2810 * src/gdcm*.[cxx|h] :
2811 - to allow compilation with gcc 3.x
2812 -- clean up of STL usage (added explicit usage of std::)
2813 -- small fixes on exceptions.
2814 Note: linking not tested !
2815 - clean of doxygen comments to avoid warnings at documentation
2817 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2818 dependent convertion).
2820 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * Clean up of previous JPR garbage commit (not even commented in the
2823 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2824 - moved all jpeg related files from src to src/jpeg/libijg8, with
2825 addition/modification of Makefile.am and configure.in.
2826 - the testSuite is still brain damage (not guilty).
2828 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2829 * WrapVTK.py : modifications to get correctly vtk source files to
2831 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2832 (FileName -> Filename)
2834 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * vtk/vtkGdcmReader.[cxx/h]:
2836 - UpdateProgress method should now be effective
2837 - removed the limitation on having only images loaded (as opposed
2839 - when building a stack of images/volume, a lesser number of
2840 gdcmHeader and gdcmFile instances should be used (hopefully
2841 accelerating things).
2842 - when building a stack of images/volumes, files which are not
2843 loadable (wrong path-filename, wrong permissions on existing file,
2844 or file not parsable by gdcm) are replaced with a black image
2845 in the stack (for the caller to notice the problem).
2847 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2848 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2850 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2851 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2852 between standard library (std) and vtk library (problems are found
2853 under Windows... thanks Windows !)
2855 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2856 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2858 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2860 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2863 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2864 * When compiling with distutils (see setup.py) the C++ compiler is
2865 called with different flags than the default ones (with automake).
2866 In order to fix all those warning, I compiled gdcm with the command
2867 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2868 and went for warning fixes:
2869 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2870 up from unused variables.
2871 - vtk/vtkGdcmReader.cxx: potential bug fix.
2872 * src/gdcmHeader.h: Doxygen warning cleanup
2874 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2875 * gdcmPython/gdcm.i:
2876 - typemaps correction to take into account the systematic replacement
2877 of "using namespace std" with std:: prefix e.g. std::list,
2878 std::string... (cf changes of 2003-05-21).
2879 - gdcmGlob global variable of type gdcmGlobal (defined in
2880 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2881 exported to Python a as cvar.
2882 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2883 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2884 gdcmDictSet.GetPubDictTagNames() and
2885 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2886 C++ static methods).
2887 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2888 with the above changes.
2890 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2891 * setup.py, manifest.in : bug fix under linux
2893 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2894 * Modification of setup.py to compile vtk part too. Then, we have 2
2895 wrappers which must work with same distutils. For that, we have a
2896 generic distutils in distusiltsWrapping.py ; with :
2897 - build_extWrap class to wrap generically all extensions,
2898 - ExtensionWrap base class for all wrapping extension that contains
2900 - Wrapper interface which wrap sources
2901 + In WrapSwig.py we have extension and wrapper for Swig
2902 + In WrapVTK.py we have extension and wrapper for VTK
2903 * MANIFEST.in : modifications to consider vtk directory and new python
2904 files for compilation
2906 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2907 * Added python wrappers of vtkGdcmReader vtk class (see the
2908 source in vtk/vtkGdcmReader.cxx) :
2909 - vtk/Makefile.am now builds a library
2910 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2911 python library (as opposed to _gdcm.so wich are the python
2912 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2913 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2915 - configure.in has an additional flag --enable-vtk that needs
2916 to be set to enable compilation of vtk related code, that is:
2917 + vtk/vtkGdcmReader.so and
2918 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2919 + gdcmPython/vtkgdcmPython.so (see above)
2920 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2921 be read when compressed or when HighBit + 1 != BitsStored),
2922 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2923 the usage of the python wrapper of vtkGdcmReader vtk class.
2924 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2925 * src/*.[h] all occurences of stl classes are now prefixed with
2926 std::, and all occurences of "using namespace std;" where removed.
2927 This is to avoid pollution of global namespace in included files.
2928 Apparently vtk does not avoid this pitfall: when using both
2929 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2930 collision of various stl members (principally cout...).
2931 * gdcmPython/testSuite.py now cleanly removes temprory generated
2933 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2934 comply with above changes)
2936 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2937 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2938 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2939 vtk data structure (an image Flip was required).
2940 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2941 * cosmetic changes in documentation.
2943 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2944 * src/gdcmHeader.cxx: the constructor no longer exits when an
2945 unexisting file is given as argument.
2946 * The subdirectory Data (containing all the images used for the
2947 test suite) is not part of this repository anymore. A new module
2948 containing those images is now available at
2949 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2950 with the name gdcmData.
2951 All the python scripts (including the package initialisation file
2952 gdcmPython/__init__.py) were adapated to take this change into
2953 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2955 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2956 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2957 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2958 demo of the usage of this class.
2959 Compilation of this vtk part is only done when using the --enable-vtk
2960 at configure (or autogen.sh) stage.
2962 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2963 * More memory link related corrections and documentation fixes.
2965 - maximum info is obtained with a command of the form:
2966 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2967 --show-reachable=yes PrintHeader
2968 - the remaining reachable blocks seem to come from the STL
2969 allocation scheme through the usage of map and list. It looks
2970 like this memory cannot be freed but it is not a memory leak
2971 (in fact further invocation to the STL would recollect the
2972 unused memory allthough it cannot explicitely be freed).
2973 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2974 of displaying an image parsed with gdcm and displayed with VTK.
2975 Note: some images don't seem to work e.g.
2976 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2977 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2978 Allthough this weakens the semantics, it is a ditch attempt to
2979 make gdcm more thread friendly.
2981 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2982 * Memory link hunt (by using valgrind through the command
2983 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2984 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2985 gdcmHeader::_dicom_vr.
2986 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2987 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2989 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2991 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2992 * src/Makefile.am now exports all the necessary include files at
2996 * UpdateGroupLength replaced by new one
2999 * UpdateGroupLength re-written using H-Table
3000 (named UpdateGroupLengthNew untill checks are over)
3002 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3003 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3004 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3006 - gdcmHeader::GetPubElValSet removed.
3007 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3008 UpdateGroupLength, WriteElements, Write.
3009 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3010 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3011 carried the same semantics.
3012 - src/gdcmHeaderIdo.cxx changed accordingly.
3013 - gdcmFile::WriteBase now regroups all the codes from previous
3014 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3015 - enum FileType moved to gdcmCommon.h
3016 * src/gdcmHeader.cxx AddDefault trashed
3017 * gdcmGetXSize added
3018 * getimageDataSize now calls gdcmGetXSize
3019 * Test/*.cxx changed to agree with above changes
3021 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3022 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3023 (to avoid double call by end user).
3024 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3025 by end user, since gdcmHeader::gdcmHeader now handles it.
3027 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3028 * gdcm/Doc many doxygen changes:
3029 - Doxyfile now has two different versions, DoxyfileUsers that generates
3030 the html.users end users oriented documentation and
3031 DoxyfileDeveloppers that generates the html.developper developper
3032 oriented documentation.
3033 - README changed accordingly
3034 - requirement.txt removed (old design info moved to TODO).
3035 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3036 DoxyMainPage.txt, DoxyPython.txt provide more information.
3037 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3038 be updated by simply regenerating the docs with doxygen and copying
3039 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3040 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3041 all the tests in the form "if (<map>.count() >1)" were removed.
3042 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3043 ill-formed documentation sections.
3044 * src/gdcmHeader.cxx: ditto
3046 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3047 * setup.py fixed for un*x (needed macro for stdint.h)
3048 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3049 un*ces with sh-utils test utility.
3050 * gdcmPython/demo/test.py renamed to PrintHeader.py
3051 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3052 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3053 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3054 * src/gdcm*.cxx JPR's bad inclusion fixed.
3056 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3057 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3058 * gdcmPython/demo/test.py changed accordingly.
3060 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * gdcmPython/Makefile.am fixed linking against libstdc++
3062 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3063 * Swig subdir (historical tests of swig version 1.3.17++) removed
3064 * Test/testChangeEntete.cxx some lines commented out in order to make
3066 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3067 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3069 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3070 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3071 hence the user doesn't need this explicit call.
3072 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3073 i.e. LoadElements() call removed.
3074 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3075 - src/Makefile.am declares the proper flag for g++.
3076 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3077 for adding user defined new tags.
3078 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3079 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3080 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3082 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3083 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3084 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3085 src/Makefile.am : the project should properly compile and install
3086 with the autotools, included the python wrappers part.
3087 * gdcm.spec.in : added a spec file for RPM packaging.
3089 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3090 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3092 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3093 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3094 to exported to the environement (see gdcmPython/testSuite.py
3096 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3097 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3098 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3099 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3100 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3102 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3103 * gdcmPython/__init__.py doesn't crash anymore when running in
3104 in InstallMode or PreInstallMode but with an environment given
3105 value of GDCM_DICT_PATH.
3106 * src/gdcmDictSet.[cxx/h] coding style.
3108 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3109 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3110 * src/gdcm.h general comments moved to TODO, and README
3111 * src/gdcm.h should now be seen as a user commodity (including it
3112 should suffice to fully use gdcm). It is nowhere including within
3113 any of the kernel files src/*.cxx and src/*.h.
3115 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3116 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3117 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3119 * src/gdcm*.cxx only include their corresponding include file
3120 (as opposed to gdcm.h)
3121 * gdcmPython/gdcm.i changed accordingly
3122 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3123 the autogen.sh generated "make snapshot" command to work.
3124 * autogen.sh removed history related references to crea package.
3126 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3127 * distutilsSwigCPlusPlus.py work around some swig portability
3130 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3132 was done in a last ditch attempt to get setup.py _really_
3133 operationnal. The python/gdcmPython layaout add the advantage
3134 of hidding away the python related distutils specific files
3135 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3136 Alas, the src directory was out of scope (i.e. it's relative
3137 position to setup.py was ../src) which made things impossible to
3138 handle (see previous version of python/setup.py). Crossing fingers...
3140 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3141 * python/setup.py now works on Un*x. (harder than I thougth)
3142 * python/distutilsSwigCPlusPlus.py can now have include files
3143 among the list of sources.
3145 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3146 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3147 * modifications in MSVC projects
3149 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3150 * As stated by the first lines of Test/ExceptionAndPython/README, it
3151 looks like we can move back to original usage of exception within
3152 src/gdcm* and hence remove the errno stuff that was introduced
3153 as a quick and dirty fixture of this problem (added to the TODO).
3154 * Doc/Doxyfile configuration file for Doxygen and corresponding
3155 README file for usage added.
3156 * Test/testWrite.cxx added. This new test comes from a split of
3157 test.cxx that is now reverted to its original purpous i.e.
3158 testing the proper parsing of a Dicom related file.
3159 testWrite.cxx concentrates on testing the IO part of gdcm.
3160 * Test/bug1.cxx (containing a bug on WIn32) added.
3161 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3162 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3163 whose purpose is to publish the content of the TagNames of the
3164 Dicom public dictionary were not accessible without an
3165 instance of class gdcmHeader.
3166 - those methods are now static methods of gdcmDictSet and hence
3167 require no instances at all to be invocated.
3168 - within gdcmDictSet this change required to change some method
3169 to class methods (i.e. are now static) among which SetDictPath
3170 (renamed to BuildDictPath) and LoadDefaultPubDict.
3171 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3172 the above changes by calling the new method classes of gdcmDictSet.
3173 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3174 the above to be effective.
3175 * python/gdcmPython: in order to wrap properly the above changes
3176 for Python, swig version now needs to be > 1.3.17.
3177 * python/gdcmPython/Makefile fixed to adapt itself to new
3178 configure/make shema introduced by Johan Montagnat (thanks for the
3179 contribution). Alas this Makefile cannot be turned into a proper
3180 Makefile.am without some heavy changes in the configure.in
3181 (for python dectection).
3182 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3183 now avoids publishing the empty entries.
3185 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3186 * python/setup.py : bug fix concerning install under windows
3187 ExtraPath reused :-P
3188 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3190 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3191 * Dicts/dicomV3.dic : remove double spaces !!!
3192 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3193 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3196 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3197 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3198 method. Doxygenation.
3199 * src/gdcm.h clean up of JPR spurious comments.
3201 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3202 * python/distutilsSwigCPlusPlus.py now properly collects the
3203 shadow classes generated by "swig -c++" (gdcm.py in our case)
3204 when using "python setup.py install".
3205 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3206 reexports the working classes.
3207 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3208 by the classical C errno scheme. This is to prevent an obscure
3209 behavior of the python wrappers when importing wxPython.wx prior
3210 to gdcmPython (which ended up in an abort call). An illustration
3211 of this oddity can be found in the Test/ExceptionAndPython
3212 subdir (see the README file). This problem probably due to
3213 an combination of g++ and dynamic loading.
3214 * added Test/ExceptionAndPython (see above)
3216 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3217 * Changed the layout of the python part to avoid bloating main
3218 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3219 i.e. the distutils arsenal. All the python related stuff is
3220 again in a python subdir, but the package itself is now in
3222 * setup.py was cleaned up:
3223 - pythonIncludePath removed
3224 - python setup.py bdist target is now functional.
3225 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3226 collision with other packages). gdcmPython/demo/*.py changed
3229 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3230 * python subdir moved to gdcmPython (preparation of distutils packaging).
3231 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3232 distutils installer is operational.
3233 * - gdcmPython/__init__.py now properly loads the swig generated
3234 shadow classes (from gdcm.py).
3235 - gdcmPython/demo/*.py changed to import the package gdcmPython
3236 instead of gdcmPython/demo/load.py.
3237 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3239 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3240 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3241 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3242 entries within the associated public Dicom dictionary resp. the same
3243 information but sorted by the fourth field (PAT, IMG, DIR) of the
3245 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3246 are now in the "???" group.
3247 - python/gdcm.i changed accordingly,
3248 - python/demo/printGroupedPublicDict.py added, that gives an example
3249 of the above new functionalities in Python.
3251 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3252 * src/gdcm.h, gdcmHeader.cxx:
3253 - historic references to glib's g_malloc and g_free (#defined)
3254 were definitively removed.
3255 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3256 * src/gdcmElValSet.cxx:
3257 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3258 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3259 - GetElValue(string) renamed to GetElValueByName.
3260 - Added GetElementByName(string).
3261 * src/gdcmHeader.cxx: added
3262 - GetPubElValRepByNumber(guint16, guint16)
3263 - GetPubElValRepByName(string)
3264 - GetShaElValRepByNumber(guint16, guint16)
3265 - GetShaElValRepByName(string)
3266 - GetShaElValByNumber(guint16, guint16)
3267 - GetShaElValRepByName(string)
3268 - GetElValRepByNumber(guint16, guint16)
3269 - GetElValRepByName(string)
3270 - GetElValByNumber(guint16, guint16)
3271 - GetElValRepByName(string)
3272 * Doc/requirements.txt added.
3274 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3275 * Test/Makefile building now depends on the one of libgdcm.so
3276 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3277 pixel data) aware which enables finding the address (offset) of
3278 the pixel data of JPEG encoded DICOM files. This leaves only a single
3279 file in the testSuite whose pixel data address (offset) is unknown.
3280 * python/testSuite.py changed accordingly.
3282 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3283 * VC++ has some strong limitations when working with the STL, as stated
3284 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3285 "Also note that some STL containers (map, set, queue, list, deque)
3286 cannot be exported. [...]
3287 Some STL classes contain nested classes. These classes can not
3289 This is caused by a designed limitation that once a template
3290 class is instantiated, it can not be re-instantiated and
3292 Since our usage of map<> is ubiquitous in gdcm, this "designed
3293 limitation" of VC++ is a pitfall.
3294 Hence the Python wrappers of gdcm cannot be incrementally linked
3295 against the c++ dynamic library. The dirty but only workaround is
3296 to forget about incremental link of dynamic libraries and to generate
3297 the Python wrappers library with the inclusions of the underlying C++
3299 The following modifications concern this matter on Win32/VC++:
3300 - wrapping python correct with standalone wrapped dll (don't use separate
3301 dll under windows !!!!)
3302 - python21_d debug mode enabled (ask Frog how to use it :-)
3303 - NO problem with having an STL member of class for example string in C++
3304 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3305 - Python test of dcmlib in Python is ok under windows on a large set
3307 * removed glib references
3308 * typedef's inserted in gdcm.i for correct swig type management
3310 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3311 * python/demo/*.py load.py extracted from test.py. Added explore.py
3312 that only displays required tags and testAll.py that parses all
3313 the files of the testsuite without using unittest.
3314 * python/testSuite.py other additional test on new files added.
3315 * Data/* new test files added accordingly to the testSuite.
3316 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3317 the vr in the file differs from the one of the dictionary.
3319 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3320 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3321 values, but limits itself to values which are below a user specified
3322 size (by default 1024 bytes).
3323 * python/gdcm.i : elements not loaded (because their size is above the
3324 user specified treshold) are exported with their TagKey as key of the
3325 python dictionary. This enables the testsuite to make some checks
3326 on the unloaded elements (since we have their offset and size).
3327 * python/testSuite.py
3328 - now tests for the existence and proper value of the pixel data
3329 - two new examples added.
3330 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3332 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3333 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3334 aware. See the strategy comments in gdcmHeader::FindLength().
3335 * Test/test.cxx now accepts a filename as first argument.
3336 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3337 * python/testSuite.py changed to integrate test on above files.
3339 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3340 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3341 the vr was also RET.
3342 * python/testSuite.py more tests added.
3344 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3345 * python/testSuite.py unittest test suite added (uses Data)
3346 * Data/* dcm and acr files for the test suite.
3347 * glib dependance removed from un*x version. We now use ISO C99
3348 7.18 Integer types (see stdint.h)
3349 - python/Makefile, src/Makefile src/gdcm.h
3350 * src/ when an explicit vr (like dicom files) suddenly poped an
3351 implicit element we use to mark the underlying DictEntry of the
3352 concerned ElValue with "Implicit". This strategy was damageable
3353 too the public or provite dictionaries, since some of their vr
3354 would be changed. Since Header::FindLength heavily relies on the
3355 detection by Header::FindVR of falsely explicit elements, I
3356 added an extra ImplicitVr member to ElValue (boolean).
3357 The rest of the changes we the necessary adaptations.
3359 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3360 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3362 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3364 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3365 * Adaptation for porting to VC++:
3367 o forced to use std namespace (for string to be known)
3368 o all class use __declspec export style on WIN32
3369 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3370 (in stdlib.h on Win32 but in std:: for gcc)
3371 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3372 variable GDCM_DICT_PATH.
3373 * src/gdcmHeader.cxx verbose comments made discrete.
3375 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3376 * python/gdcm.i: added a typemap that converts a C++ hashing table
3377 to native Python dictionary.
3378 * python/demo/test.py:
3379 - now uses the native dictionary for exploration of gdcmHeader.
3380 - takes an optional filename argument (the file to parse).
3381 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3382 PubElVals hashing table.
3383 * Dicts/dicomV3.dic removed error prone trailing spaces.
3385 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3386 * Python wrapping process moved away from src/Makefile to
3387 newly created python/Makefile (as well as gdcm.i)
3388 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3389 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3390 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3391 from the environement variable GDCM_DICT_PATH (when existing).
3392 * src/gdcmDict::GetTag bug fix.
3394 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3395 * Straightforward temporary fixes for swig to build the python wrappers.
3396 src/Makefile now has a python working entry [by working we mean
3397 that we can import the shadow classes without errors].
3399 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3400 * hashtest.cxx removed (since already in Test)
3401 * src/gdcmlib.h renamed to src/gdcm.h
3402 * src/dcm.i renamed to src/gdcm.i
3403 * src/Makefile prepared for python wrapping
3405 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3406 * src/gdcmHeader.cxx :
3407 - Parsing of header is now separated from loading of element values
3408 (see gdcmHeader::LoadElements).
3409 - general clean up of hopefully all file access (creation of
3410 ReadInt16 and ReadInt32)
3412 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3413 * src/gdcmHeader.cxx :
3414 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3416 - SetLgrElem renamed to SetLength
3417 - GetLgrElem renamed to GetLength
3418 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3419 * src/gdcmElValSet.cxx fixed both GetElValue methods
3420 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3421 due to IdoDude was cleaned out.
3423 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3424 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3425 concentrates on finding the value representation (when it exists).
3426 RecupLgr now only finds the element value length, and it avoids
3427 returning the unecessary skL (skipped length).
3428 Also, offsetCourant was simply removed (with taille_fich) since
3429 it was redundant with the File position internals (by using
3430 ftell and fseek). This also made skL (see above in RecupLgr) usage
3432 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3433 on the libido specificities which are handled through class
3435 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3438 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3439 * Truckload of changes. Parsing of header is barely functional
3440 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3442 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3443 * src/gdcmHeader.cxx many addons of low level methods
3445 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3446 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3447 and _IdDcmSWAP_LONG.
3449 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3450 * This corresponds to all the changes decided at the meeting of
3451 May 23 2002. Needless to say we are running late...