1 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Bugs fix for the Windows build with VC6
3 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
4 needed (only for projects required VTK). If the VTK is included in all
5 projects, there is conflicts with the jpeg lib of vtk when compiling the
6 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
7 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
8 when compiling the gdcm_wrap.cxx file (created by the compilation of the
10 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
11 (like it's already made for the cout use). Otherwise, conflict with the
14 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
15 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
17 - comments on the DicomDir::Method related usage added.
18 - now that we use the namespace gdcm, a lot of internal classes do
19 NOT need to be wrapped anymore.
20 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
21 DicomDir::Method) new example added.
23 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * Improve string manipulation. I now inforce the notion of 'DicomString'
25 A DicomString can contain as many \0 as they want
26 and it is *always* of even length.
27 We only support odd length for very rare case.
28 And in the near future this should be removed.
30 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
31 * /binary_write/ gdcm source. Now even on big endian we are writting
32 little endian. This should -heopfully- fix some tests
34 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Now the dictionary is compiled into gdcm lib. This is a default
36 behavior, thus any dic file specified is picked before failback to
37 the one comiled into lib
39 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Change internals for gdcmDict. Don't use any 'new' any more.
41 This should definitely solve any leak problem, and we should be
42 as fast as before, as long as don't modify too much the dictionary.
44 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * STYLE: ivars should start with a capital letter.
46 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
47 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
49 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
50 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
51 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
52 new 2004 dictionaries added (thanks to JPR).
53 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
54 * CLEANUP_ROUND (15) for gdcmPixelConvert
55 - RLEFrame::NumberFragments is now of type unsigned int
56 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
57 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
60 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Initial work in gathering all transfer syntax accessors. clearly
62 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
63 ivars, but only one transfersyntax (class) ivar with equivalent method on
66 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
67 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
68 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
69 discussed (plus I didn't like having a 2000 lines patch not commited)
71 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
72 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
73 * CLEANUP_ROUND (14) for gdcmPixelConvert
74 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
75 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
76 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
78 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
79 anymore and hence avoids storing a copy of PixelConvert::Decompressed
80 into File::Pixel_Data.
82 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
83 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
84 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
85 * CLEANUP_ROUND (13) for gdcmPixelConvert
86 Substituted File::ParsePixelData() with PixelConvert::Print() new
88 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
89 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
90 method to those classes.
91 - src/gdcmFile.[cxx|h]:
92 -- Added a ::Print() method.
93 -- PixelConverter is now a reference instead of a member.
94 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
95 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
97 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
99 collaboration diagram and inheritance diagram should be generated with
101 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
102 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
103 pointlessly wrapped (see
104 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
105 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
106 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
107 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
108 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
109 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
110 -- File::Initialise: PixelConverter setup moved away to
111 PixelConverter::GrabInformationsFromHeader()
112 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
113 interpretation moved away to PixelConverter::BuildRGBImage()
115 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
116 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
117 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
119 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
120 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
121 displayed on Win32 when a brutal abort() occurs (because of uncatched
122 exception). See TODO new entry of this commit for more on this.
123 * TODO added new entry.
124 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
125 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
126 - HandleColor is no longer called from gdcmFile.cxx
127 - gdcmPixelConvert.cxx clean up on method arguments and internal
128 variable names for semantical coherence.
130 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
131 * Finished lossless transition, not only do we now read all lossless jpeg
132 images, without the need of the Cornwell lib, but we do read them properly now
133 * To reduce code (well to avoid code duplication), I defined a common place
134 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
135 redefine symbols. This is not prefect but this the best solution I found for a
136 compilation time jpeg option.
138 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
139 * Update jpeg ijg lib to support lossless jpeg implementation
140 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
142 * Also added a special copyright for dcmtk since we use their bugfixes.
145 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
147 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
148 matters, as stated in warning note at begining of %include section).
149 * src/gdcmDicomDir*.[cxx|h]: coding style
150 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
151 * src/gdcmJpeg8.cxx: doxygen fix.
152 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
153 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
154 from File:: to PixelConvert::.
156 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
157 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
158 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
159 - more code moved away from File:: to PixelConvert::
160 - fat setup of PixelConverter set in place in File::Initialise.
162 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
163 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
164 namespace at the file system level. So now you should convert your examples
166 gdcmHeader -> gdcm::Header
167 It would be nice if people keep in mind to no open the namespace, since it
168 allows compilation on broken plateform which were defining common symbol in
169 the standart namespace (like LP, Unknown ...)
171 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
173 The JPEG fragments are now parsed at the same stage than the RLE
174 information. All code related to JPEG is now in gdcmPixelConvert:
175 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
176 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
177 export a gdcmFile:: method. Those are simply global functions
178 (for the time being this is better than having them attach to
179 either gdcmFile:: or gdcmPixelConvert::).
180 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
181 and stores the result in a gdcmJPEGFragmentsInfo.
182 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
183 code (among other stuff) moved away from gdcmFile:; to
186 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
188 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
189 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
190 clean up of RLE related code.
191 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
192 - src/gdcmRLE.cxx removed
193 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
194 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
195 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
196 * CLEANUP_ROUND (9) for gdcmPixelConvert
197 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
198 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
199 away from gdcmFile:: to gdcmPixelConvert::.
201 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
202 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
203 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
204 This is because Parse7Fe0 used to parse the pixels to compute the
205 length. This task was passed over to FindDocEntryLengthOB() a long
206 time ago, EXCEPT I had forgotten the OW case...
207 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
208 we just recylce the code for parsing RLE fragments and computing
210 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
211 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
212 with the retired Parse7Fe0().
213 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
214 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
216 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
218 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
219 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
220 - src/CMakeLists.txt: alphabetic order reodering + new entries.
221 * CLEANUP_ROUND (4) for gdcmPixelConvert
222 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
223 to return an unused length.
225 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
226 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
227 this should be cleanner from the plane view. The iostream are erally a pain
228 to use to do simple stuff.
230 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Redo the compilation of the ijg jpeg library. Now only one source is
232 necesseray. No need to rename file by hand what so ever. CMake handle the
233 copying of the file within different directory, configure header file to
234 modify some symbol. The only addition made to ijg wasd a mangle table so
235 that symbol are different wether we are within 8bits or 12bits.
237 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * Added documentation of vtkgdcmReader on Website:
239 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
240 with it's binary name).
241 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
242 the Website to be more complete.
243 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
244 doxygenated documentation.
245 - Doc/DoxyVtkGdcmReaderExamples.txt added
246 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
247 DoxyVtkGdmReaderExamples.html )
248 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
249 * CLEANUP_ROUND (3) for gdcmPixelConvert
250 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
252 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
253 * CLEANUP_ROUND (2) for gdcmPixelConvert
254 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
256 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * CLEANUP_ROUND for gdcmPixelConvert:
258 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
259 - src/gdcmPixelStuff[h|cxx] removed
260 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
261 - src/CMakeLists.txt changed accordingly
263 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
264 gdcmVersion.py moved to newly created ATTIC related
265 gdcmPython/SetupOldies/ directory.
266 * Autotools clean up:
267 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
268 - autogen.sh configure.in acinclude.m4 python.m4 removed
270 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * src/*.cxx *.h Reference to License.htm fixed to License.html.
272 * Doc/CMakeLists.txt, doxygen.config.in: fix.
273 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
275 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
276 * TODO updated with Mathieu suggestions. I proposed a template for
277 describing TODO entries and used it for new entries.
278 * Added Doc/Website/CodingStyle.html, Developpers.html,
279 DeveloppersPython.html, GdcmDataCvs.html and
280 DownloadVersion0_1.html, DownloadVersion0_3.html.
281 * Some Doc/*.txt Doxygen files (which do not really concern the
282 documentation itself, but the website) moved to html and
283 placed in directory Doc/Website:
284 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
285 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
286 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
287 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
288 * CMakeLists.txt changed accordingly.
289 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
290 DeveloppersPython.html
291 * INSTALL nows refers to Doc/Website/Installation.html
293 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Added Doc/Website directory, that contains a first raw version
297 2004-09-23 Jean-Pierre Roux
298 * FIX In order not to be poluted any longer by casting problems,
299 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
300 we can now delete[] it safely
301 * VoidArea is now called BinArea (less confusing name),
302 and all the methods called ...VoidArea... are now ... BinArea...
303 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
305 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
307 clear) TagHT, which is an inherited member of gdcmElementSet. It is
308 up to the destructor of gdcmElementSet to clean up TagHt and it's
311 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * Test/CMakeLists.txt: update to follow gdcmData renamings.
313 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
315 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * ENH: added some utility method that builds a flat dictionnary
317 holding all the Dicom entries contained in the recursive structure
318 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
320 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
321 BuildFlatHashTable() that build a flat dictionary.
322 - src/gdcmElementSet.h: added a new private GetTag() accessor.
323 gdcmDocument is now a friend of gdcmElementSet.
324 - src/gdcmElementSet.cxx: clean up.
325 - Example/FlatHashTablePrint.cxx added.
326 - Example/CmakeLists.txt changed accordingly
328 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
329 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
330 moved away from gdcmDocEntrySet (since this class is an abstract class
331 acting like an interface). SQDepthLevel and BaseTagKey are now
333 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
334 and associated accessors. Doxygenation of the class.
335 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
337 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
338 Use SQDepthLevel accessor instead. ::Print() adapted.
339 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
340 - src/gdcmDocument.cxx changed accordingly.
342 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
344 - The following is the doxygen comment of the typedef declaration
345 of gdcmagKey in src/gdcmCommon.h:
346 gdcmTagKey is made to old an "universal" (as in URL, Universal
347 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
348 A dicom tag allways has a group and an element, but a set of tags
349 embeded in various (optionally nested) sequences and sharing
350 the same group and element all share the same (group, element)
351 "identifier". Hence the (group, element) cannot be used as an
352 identifier (in gdcm we shall refer to a "TagKey") of a tag.
353 In order to construct a proper tag identifier (i.e. a key) we
354 consider the following definition of a TagKey:
355 - let Group, Element be the string representation of the
356 group and element dicom tag members,
357 - let ItemNumber be the string representation of the integer
358 index of the considered item number of a sequence,
359 Let the key of a tag embeded in a sequence, noted SeqTag, be
361 /ItemNumber#Group|Element
362 where "/", "#" and "|" are characters acting as separators.
363 Then the general form of a gdcmTagKey is given by:
364 Group|Element<SeqTag>
365 where <SeqTag> means NO or many instances of SeqTag.
366 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
369 but the gdcmTagKey of a tag "embeded" is the first item of
370 a sequence, itself nested in the third item of a sequence is the
372 0004|1220/2#0008|0082/0#0008|0090
373 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
374 order to hold the new sequence compatible key. Previously, the
375 GetKey() method would look in the underlying gdcmDictEntry.
376 - src/gdcmDocEntry.cxx:
377 -- constructor now copies the underlying DictEntry key, in the local
379 -- ::Print: displays the member Key, instead of the (group, element).
380 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
381 - src/gdcmDocEntrySet.h:xi
382 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
383 -- now has a new BaseTagKey member.
385 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
386 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
388 This poses the problem with the semantics of the following lines
389 LoadEntryVoidArea(0x0028,0x1201); // R LUT
390 LoadEntryVoidArea(0x0028,0x1202); // G LUT
391 LoadEntryVoidArea(0x0028,0x1203); // B LUT
392 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
393 to the long FIXME note for what the problem is. Nevertheless in
394 order to get things working the dicom dictionary was altered !
395 Please fix things urgently...
396 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
397 information), see above note on moving the member VoidArea. Nevertheless
398 the following entries previously correctly set as US are now inproperly
400 0028 1201 OW IMG Red Palette Color Lookup Table Data
401 0028 1202 OW IMG Green Palette Color Lookup Table Data
402 0028 1203 OW IMG Blue Palette Color Lookup Table Data
403 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
404 of gdcmDocEntry moved to gdcmSeqEntry.
405 * src/gdcmSeqEntry.cxx: STYLE.
407 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
408 * Test/TestAllEntryVerify.cxx minor fix and added comments.
410 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * gdcmPython/testSuite.py: all the test suite in python is now moved
412 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
413 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
414 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
416 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
418 to avoid inclusion recursion until STL is reached.
419 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
420 mecanism. errno.h is not included in gdcm anymore.
421 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
422 (gdcmFormatError now inherits from gdcmFormatUnexpected).
424 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
425 gdcmData/TestAllEntryVerifyReference.txt
426 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
427 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
428 exception_on_error parameter.
429 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
430 - vtk/vtkGdcmReader.cxx changed accordingly,
431 - Example/*.cxx and Test/*.cxx changed accordingly.
433 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
435 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
436 enable_sequences removed from gdcmHeader constructor and dependencies.
437 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
438 * gdcmPython/demo/PrintHeader.py: dummy fix.
439 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
440 skip_shadow removed from gdcmHeader constructor and dependencies.
441 * Example/*.cxx and Test/*.cxx changed accordingly.
443 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
445 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
447 2004-07-21 Jean-Pierre Roux
448 * FIX Now, Parsing and Printing a DICOMDIR do work!
449 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
451 2004-07-20 Jean-Pierre Roux
452 * FIX Some brain damaged headers have Zero-Lenght fields
453 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
455 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
456 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
457 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
458 variable (instance of gdcmDebug) by a definition macro, and the instance
459 is now in static in the gdcmDebug class
460 * src/gdcmSQItem.h : (FIXME) remove an undefined method
461 * Test/PrintAllDocument.cxx : bug fix in the result of the test
463 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * WARNING: ctest now depends more tightly on gdcmData. You should
465 check out gdcmData properly for things to run smoothly...
466 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
467 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
468 we need the pixels not be loaded in order to use the ValEntry
469 that displays position and size).
470 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
471 This is a C++ based equivalent of gdcmPython/testSuite.py that should
472 be deprecated. If you have any doubts about the advantages of a
473 modern scripting language (read Python) versus grass root C++ (i.e.
474 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
475 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
476 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
477 Anyhow, consider documenting the gdcmData images in
478 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
480 * Test/CMakeLists.txt:
481 - now uses TestAllEntryVerify.cxx
482 - specific comments on oldACR00001.ima (now renamed in gdcmData
483 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
484 gdcmData/TestAllEntryVerifyReference.txt
487 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * src/*.[h|cxx] : typedef clean up
489 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
490 - TagKey renamed to gdcmTagKey (for external usage)
491 - VRKey renamed to gdcmVRKey (for external usage)
492 - removal of typedef duplication.
493 - Removed all unecessary inline keyword from class inline definitions.
494 - Some method|function(void) declarations replaced with method|function().
495 * src/jpeg/libijg12/jdhuff12.c:
496 - printf polluting ctest removed.
497 - TAB removal for comminting
499 - TestAllReadCompareDicom.cxx: added a test that compares all the
500 images in gdcmDataImages.h with corresponding images in
501 gdcmData/BaselineDicom/. When baseline images are not present
502 this test creates them.
503 Note: we need to validate each reference image, but before that
504 I'd like to rename them with a more explicit name...
505 - CMakeLists.txt: changed accordingly.
506 * Example/*.cxx: examples now only include gdcm.h (as opposed to
507 including each header needed).
509 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
510 * Test/*.cxx and Example/*.cxx: moved some examples away from the
511 test suite to the Example directory. Are concerned:
516 - TestWriteSimple.cxx
517 * Test/CMakeLists.txt: added some comments on reasons for black listing
518 image gdcmData/oldACR00001.ima
520 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * Test/CmakeList.txt: removed the following from black list (to be coherent
522 with removal from gdcmData):
523 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
524 - gdcm-MR-PHILIPS-16.dcm
526 Added the following because after last cvs update, they cause
527 ctest -R TestReadWriteReadCompare
529 - gdcm-MR-SIEMENS-16-1.acr
531 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
532 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
533 new comments in this file) we temporarily (sigh) move to a weaker
535 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
536 we don't need to black list the following images anymore:
537 - 8BitsUncompressedColor.dcm
539 - US-PAL-8-10x-echo.dcm
540 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
541 fixes and the beautified code ;-)
542 This fixes the bug introduced in version 1.42 (when beautifying)
543 that made the parsing of 8BitsRunLengthColor.dcm unproper.
544 Note: ctest was blind to this bug (this means we need to still
545 improve the test suite). The bug could be detected by using
546 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
548 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
549 and by displaying the (garbage) produced file temp.XDCM...
551 2004-06-29 Jean-Pierre Roux
552 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
553 - replace by uggly but working old code :-(
554 A lot of things should be OK again.
555 It's really urgent to have a test suite that *tests*,
556 to prevent Frog's beautifying sessions to break all the stuff
557 (twice, withing a fortnigh ...)
559 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
561 redundancy) to added Test/TestReadWriteReadCompare.cxx
562 * Test/CmakeList.txt: because the compare test of
563 Test/TestReadWriteReadCompare.cxx fails, the following images are
564 black listed: - 8BitsUncompressedColor.dcm
566 - US-PAL-8-10x-echo.dcm
567 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
568 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
569 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
570 and ad-hoc kludge. This kludge is now removed, and on encountering
571 such an image (OB field brain damaged) we set errno. Then in
572 ::FindDocLength() we "fix" the length as being ALL what remains
573 in the file (until EOF). We then proceed, hoping for the best...
574 This fixes a SegFault in ShowDicom when trying to write such an
576 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
577 (because TestWriteRead breaks on it, after a non conformal commit?).
578 ctest now runs properly, except for MakeDicomDir (which was allways
579 broken) and the Python related stuff (still not fixed).
581 2004-06-24 Jean-Pierre Roux
582 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
583 FIX : Test/TestReadWrite now iterates on all the file names
584 (instead of infinite loop)
585 ENH : Test/TestWriteRead now iterates on all the file names
587 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
590 2004-06-24 Jean-Pierre Roux
591 FIX : - now Write drops LUT Descriptors and LUTs (if any)
592 when SamplesPerPixel =3
593 - now Write is no longer confused by
594 'BitsAllocated = 12" and 'BitsStored=12"
595 - "UN" value representation Elements are now written correctly
596 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
597 ENH : - now gdcmHeader has its own Write methods
598 (in order to split the job that has not to be done
601 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
603 loop on the same image until memory went out.
604 Note: this means we still have gobs of memory loss in PrintDocument
605 * src/gdcmDocument.cxx: fixes problem on parsing on file
606 gdcmData/16BitsJpegLosslessGrayScale.dcm.
608 2004-06-24 Jean-Pierre Roux
609 FIX : Write - All the Sequences and Sequence Item are now written
610 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
611 is added a the end, when necessary.
612 - A lot of brain-damaged images, that were read correctly are
613 now written correctly
614 - length compatible BinEntry are now loaded correctly
615 (even for odd groups)
616 Note : only Explicit Value Representation was checked.
617 (question : is implicit VR really necessary for gdcm ?)
619 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * DEVELOPPER: added a proposition of coding style.
621 * src/gdcmDocEntry.h: removed every inline declaration (for test of
624 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
626 Use the gdcmDocEntry::Print() and Write() instead.
627 * src/gdcmDocument.cxx: bug fix.
629 2004-06-22 Jean-Pierre Roux
630 FIX : gdcmDocument.cxx
631 - Now we do recognize the JpegLossLess format (there was a misstyping in
632 code 'beautyfication' :-(
633 - Now we automaticaticaly load the Luts, if any
635 2004-06-22 Jean-Pierre Roux
636 In order : to write Sequences, whatever their imbrication level,
637 : to allow user to create his own Sequences
638 a lot of modif where necessary (adding, moving, or virtualising methods)
640 WARNING : save your own sources *before* cvs up !
643 ADD virtual void Write(FILE *fp, FileType filetype);
646 ADD virtual void Write(FILE *fp, FileType filetype);
647 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
650 ADD virtual void Write (FILE *fp, FileType filetype)=0;
651 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
652 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
653 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
654 ADD std::string GetEntryByName(TagName name);
655 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
657 std::string vr = "unkn",
658 std::string fourth = "unkn",
659 std::string name = "unkn");
660 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
661 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
662 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
663 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
664 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
665 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
666 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
667 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
670 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
671 ADD virtual std::string GetEntryByName (TagName tagName);
672 ADD virtual std::string GetEntryVRByName (TagName tagName);
673 REM virtual bool Write(FILE *, FileType);
674 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
675 FILE *_fp, FileType type);
676 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
677 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
678 REM virtual bool WriteEntries(FILE *_fp,FileType type);
679 REM virtual std::string GetEntryByName (std::string tagName);
680 REM virtual std::string GetEntryVRByName (std::string tagName);
681 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
682 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
683 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
685 std::string vr = "unkn",
686 std::string fourth = "unkn",
687 std::string name = "unkn");
688 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
689 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
690 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
691 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
694 ADD virtual void Write(FILE *fp, FileType filetype);
697 ADD virtual void Write(FILE *fp,FileType filetype);
700 ADD virtual void Write(FILE *fp, FileType filetype);
701 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
702 REM std::string GetEntryByNumber(guint16 group, guint16 element);
703 REM std::string GetEntryByName(TagName name);
706 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
708 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
710 The default constructor invoked by the line
711 gdcmHeader *f1 = new gdcmHeader( header );
712 was gdcmHeader::gdcmHeader(bool) instead of the expected
713 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
714 Hence the parsing wasn't executed... See also below.
715 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
716 as explicit constructor didn't do the trick to fix the above problem.
717 Could anyone explain why ?
718 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
719 properly calls gdcmValEntry::Print() (that was weed out from
720 code related to gdcmBinEntry).
722 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
723 * In order to fix memory leaks:
724 - Test/TestWriteSimple.cxx: added cleaning of free store through
726 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
727 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
728 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
729 (through the call to ::AddDicomDirMeta()) or the destructor
730 would crash when deleting uninitialized ::metaElems].
731 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
732 - src/gdcmDocument.cxx:
733 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
735 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
736 was causing memory leaks.
737 - src/gdcmSQItem.cxx:
738 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
739 cleanly handled with polymophism: sorry but my milage is low).
740 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
741 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
742 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
743 This avoids SegFaulting.
744 - src/gdcmSQItem.h: coding style.
746 - Test/TestWriteSimple still severely sucks. The output image content
747 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
748 damaged when displayed with vtkgdcmViewer.
749 - on memory leaks: TestWriteSimple leaks really less (see entry
750 of 2004-06-18 in Changelog file for the call to valgrind).
751 - on segfaults: ctest now passes all the tests but one (no more
753 * Erroneous leading white fix:
754 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
755 white[s] (as opposed to from >> xxx, that removes it [them].
756 - src/gdcmTS.cxx: ditto.
757 - gdcmPython/testSuite.py: dirty related kludge removed.
758 * src/*: remaining references to gdcmParser removed.
759 * src/*[cxx|h]: added copy[way]left header.
762 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * In order to fix writing of dicom files:
764 - Test/TestWriteSimple.cxx: a simpler example of writing.
765 - Test/CMakeLists.txt changed accordingly.
766 - src/gdcmDocument.cxx:
767 -- The destructor now recursilvely removes potential sequences.
768 -- Bug fix in ::IsJPEG2000()
769 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
770 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
772 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
773 to only declared) and build on top of
774 ::GetDocEntryByNumber(guint16, guint16).
775 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
776 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
777 for usage in destructor and treatement of promotion in
778 ::ReplaceOrCreateByNumber().
779 - src/gdcmSQItem.cxx: destructor should better handle his job.
780 Test/TestWriteSimple now runs (or at least it DOES something).
781 * We can now start hutting memory links. A good starting point is:
782 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
783 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
784 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
786 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
787 * Valgrind note: after Mathieu Malaterre teached me how to read
788 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
790 Using gcc, you can force the STL to use malloc and to free memory as
791 soon as possible by globally disabling memory caching.
792 With 3.2.2 and later, you should export the environment variable
793 GLIBCPP_FORCE_NEW before running your program.
794 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
795 simply vanish (it is still not clear to me, whether this means that
796 STL std::string leaks or if valgrind believes it leaks...).
797 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
798 running bin/gdcmTests makeDicomDir):
799 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
800 - Test/makeDicomDir.cxx now properly traps empty lists and returns
802 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
803 SegFaulting (I drowned in DicomDir related code when trying to
804 understand why the list is empty...).
805 * src/gdcmDocument.h: first BSD license header try.
806 * Doc/License.txt added.
808 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
809 * src/gdcmDocument.[h|cxx]:
810 - Clean up of the Transfer related predicates. They are now all based
811 on new method isGivenTransferSyntax, that (should) handle properly
813 - general clean up, simplification, and coding style.
814 - Specific clean up of Parse7FE0() (umproperly named actually).
815 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
817 2004-06-14 Jean-Pierre Roux
819 - fix the display of Sequence Delimitor (SQDepthLevel pb)
820 - fix the display of SQItem ordinal number
821 - add the GetSQItemByOrdinalNumber method
822 - remove some useless never written private methods
824 2004-06-14 Jean-Pierre Roux
826 - adding a constructor taking a gdcmDocEntry as an input param
827 - ReplaceOrCreateByNumber now returns :
828 a gdcmBinEntry * if a Binary (void *) value is passed as a param
829 a gdcmValEntry * if a string value is passed as a param
831 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
832 according to the param type (no longer sets a gdcmDocEntry)
833 - GetValEntryByNumber, GetBinEntryByNumber added
834 - NewValEntryByNumber and NewBinEntryByNumber added
836 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
838 - GetSQItemNumber and SetSQItemNumber added, to provide
839 a (relative) Item identier inside a given Sequence
840 \warning : some pb remaining around this number
842 - AddEntry now takes the Item Number as a param
844 - adding a constructor taking a gdcmDocEntry as an input param
846 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * Memory leak hunt with the following command:
848 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
849 --show-reachable=yes gdcmTests PrintDocument
850 It looks like many (all?) leaks are due to the STL (or a bad usage
851 of the STL. The lines producing the leaks now have a comment with
852 a "MEMORY LEAK" tag: you can retrieve them with
853 grep "MEMORY LEAK" src/*
854 Here are two typical examples which I can't help fixing:
859 char * test = "babo";
860 name = test; //// <--- valgrind detects 960 bytes lost in
861 //// call to std::string::operator=(char const*)
862 name.clear(); //// Doesn't help !
870 std::cout << "Type a bunch of characters followed by RETURN: ";
871 getline(std::cin, line); //// <--- valgrind dectects a loss
872 //// of 1320 bytes in call to
873 /// std::basic_istream<>& std::getline<>
879 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * src/gdcmHeader.[cxx|h]:
881 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
882 and related, moved away to gdcmDocument.
883 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
884 the corresponding protected accessors of inherited class
885 gdcmDocument, removed ! As a consequence gdcmFile had to be
886 declared friend of class gdcmDocument (see below).
887 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
888 - Clean up of undefined or unused methods.
889 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
890 account the changes to gdcmHeader.h).
891 * src/gdcmDocument.h:
892 - gdcmFile is now a friend class (in order to take into account the
893 changes to gdcmHeader.h).
894 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
895 (see changes to gdcmHeader.h).
896 - Accessors (reading on the form GetEntry*) are now public.
897 - Clean up of undefined or unused methods.
898 * src/gdcmDocument.cxx:
899 - adaptation to changes to gdcmDocument.h
900 - ::OpenFile now writes a verbose message when file cannot be opened.
901 - some std::string properly set to VRKey
902 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
903 references to gdcmDocument.
904 * Test/TestFindTags.cxx: changed accordingly to above changes.
905 * gdcmPython/testSuite.py: adapted to renaming of acr files in
906 cvs repository gdcmData.
908 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
909 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
910 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
911 conflicts with gdcmValEntry::voidArea.
912 * src/gdcmValEntry.cxx: unmatching comment wiped out.
913 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
914 Value representation between StringRepresentable and BinaryRepresentable.
915 * src/gdcmDocument.cxx:
916 - method ParseDES: proper indentation restored and usage of
917 gdcmVR::IsVROfGdcmStringRepresentable wired in.
918 - method LoadDocEntry: the fingerprint left in the SetValue() of
919 unloaded entries (length > MaxSizeLoadEntry) had curiously been
920 removed. Reverting to previous code segment with the proper
921 dynamic_cast< gdcmValEntry* >.
922 Note: this was (partially) breaking the python test suite
923 (gdcmPython/testSuite.py) that made usage of the above
924 fingerprint to check presence of "Pixel Data".
925 * src/gdcmDocEntry.h: coding style.
926 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
927 now taken into account.
928 * gdcmPython/gdcm.i: adaptation to the new internal representation
929 of gdcm (exit gdcmParser, hello gdcmDocument).
930 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
932 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
933 anymore, but instead prints the loaded Python dictionary.
934 * .... alas, the python testSuite is still broken.
936 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
937 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
939 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
940 * src/gdcmUtil.h : export methods
942 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
943 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
945 * Initial addition of automatic python testing
946 * Initial addition of automatic image comparison
948 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
949 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
950 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
952 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
953 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
954 * Test/ShowDicom.cxx : bug fix for msvc compilation
955 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
957 2004-05-04 Jean-Pierre Roux
958 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
959 new concepts (and new classes) :
960 a 'gdcmDocument' is composed of a set of Doc Entries, that are
961 - elementary gdcmDocEntries (former gdcmHeaderEntries)
962 - Sequence Doc Entries (gdcmSeqEntries)
963 a Sequence is composed of Items.
964 Each item is a set of Doc Entries (this is recursive)
965 The non uniqueness of the 'Dicom tag' is due to this recursivity
966 (never taken into account)
967 Our unability to add a new 'entry' in the header
968 at the proper location (neither in the H-Table (map or multimap),
969 nor in the Chained List is also due to this recursivity.
970 Don't try, right now, to use/modify/compile these new sources :
972 We just commit all the stuff, 'as is', in order not to loose it.
974 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
975 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
977 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
978 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
979 file prefix (SetFilePrefix)
981 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
982 * Add a new test: ShowDicom, for now this is just the c++ version of
983 checkRead.sh, later it will be able to compare the image read against a
985 * Replace the DEBUG on the stack with a global entry in cmake interface:
986 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
988 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * Add an example subdir, with a real example on how to read + write a
992 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
993 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
994 * Doc/CMakeLists.txt: the main page is now properly differentiated
995 between the developper and user version.
996 * Doc/doxygen.config.in: dropped search related obsolete flags
997 * src/gdcmParser.h, gdcmHeader.h: doxygenation
999 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * DEVELOPPER: added some helpfull comments for compile/test/install
1003 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1005 src directory, now generated in the build dir.
1006 2. Tests as mentionned smarter
1008 4. Add a new method in gdcmDict that return the PubDict by name
1009 this is interesting for 3rd party lib like ITK,
1010 where we could set the institution name / patient name...
1012 * ENH: 1. Now the test suite is working for real
1013 2. All binaries are now output in the gdcm-bin directory
1014 (this was not true before)
1016 2004-04-28 Jean-Pierre Roux
1017 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1018 SeQuence indented printing of Dicom Header.
1019 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1020 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1021 Computation of SQDepthLevel is now part of gdcmHeader constructor
1022 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1023 tree-like structure of a Dicom Header.
1024 * FIX Test code cleaning
1026 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1027 * ENH: Adding automatic testing
1028 1. Need a DartConfig.cmake to submit to public
1029 2. Add a test driver gdcmTest.cxx
1030 3. gdcmTestMain, an helper for the main test driver gdcmTest
1031 4. Files in Test don't have a main anymore, this becomes interesting
1032 when we add more and more tests, thus dsw don't have to load
1034 * ENH: Adding a GDCM_DATA_ROOT for testing
1035 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1036 one file instead of seven + some small cleanup
1038 2004-04-22 Jean-Pierre Roux
1039 * ENH Minor changes to the Print() methods.
1040 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1041 Header printing. Example given with :
1042 > PrintHeader fileName 2 new
1043 (SQ based tree-like structure still to be done for the Header ...)
1045 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1046 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1047 1. I have added some unsigned where needed
1048 2. Some function parameter not used -> (void)
1049 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1050 4. g++ don't like character '\' in comment
1051 5. #define jpeg_create_decompress jCreaDecompress
1052 this really need to be fixed
1053 6. virtualize destructor of gdcmObject ... leakage
1054 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1055 this also really need to be fixed
1056 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1057 remove compression file
1058 (as we only do decompression, right ?)
1059 * ENH: Change malloc/calloc/free with c++ equivalent
1061 2004-04-21 Jean-Pierre Roux
1062 * FIX gdcmHeaderHelper::GetXSpacing
1063 when a single value is found (bug ?), xpacing is now
1064 defaulted to yspacing
1066 2004-04-19 Jean-Pierre Roux
1067 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1068 * ENH add parameters :
1069 bool exception_on_error = false,
1070 bool enable_sequences = false,
1071 bool ignore_shadow = false
1072 to the gdcmFile constructors to be full gdcmParser compliant
1073 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1074 to allow reading of PAPYRUS 3.0 files
1076 2004-04-06 Jean-Pierre Roux
1077 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1079 2004-04-02 Jean-Pierre Roux
1080 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1081 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1082 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1084 2004-03-30 Jean-Pierre Roux
1085 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1086 for ACR file, written out as DICOM files (hope so...)
1088 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1089 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1090 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1091 moved to base class gdcmParser and only the specialisation is kept
1093 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1094 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1095 already does the job.
1096 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1097 (to be consistent with gdcmParser::WriteEntries).
1099 2004-03-30 Benoit Regrain
1100 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1101 upate of the object's instance. It's passed to 2 in the unfavorable
1102 case : one in the ExecuteInformation, one in the ExecuteData
1104 2004-03-29 Jean-Pierre Roux
1105 * ENH : Check on file type to be written moved
1106 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1107 * FIX : gdcmObject::ResetBoundaries now stops properly
1108 when end-of-list is reached
1109 : gdcmVersion modified (as Benoit Regrain asked)
1111 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1112 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1113 * src/gdcmUtil.cxx: added forgotten iostream include.
1114 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1115 equivalent to ExplicitVR in existing code).
1117 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1118 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1119 now contains all the gdcmGlobal related code.
1120 * minor coding style and doxygenation changes.
1122 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1124 now contains all the Debug related code.
1125 * minor clean-up of includes in src/*.cxx
1126 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1127 CreateCleanString) removed.
1128 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1129 * Doc/DoxyMainPageUser.txt added.
1130 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1131 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1132 src/gdcmDirList.cxx)
1134 2004-03-24 Jean-Pierre Roux
1135 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1137 2004-03-23 Jean-Pierre Roux
1138 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1139 big endian made volumes
1140 * ENH Now gdcmParser constructor and destructor are protected to forbid
1141 end user to instanciate class gdcmParser
1142 (only gdcmHeader and gdcmDicomDir are meaningfull)
1144 2004-03-22 Benoit Regrain
1145 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1146 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1147 gdcmSerie to gdcmDicomDirSerie
1149 2004-03-19 Jean-Pierre Roux
1150 * ENH Now the tree-like structure describing a DICOMDIR comming from
1151 an already existing DICOMDIR file is consistent with
1152 the home-made tree-like structure build ex-nihilo
1153 or build from the files held (recursively) in a Directory
1154 functions gdcmDicomDir::CheckBoundaries()
1155 gdcmObject::SetBoundaries() added
1157 2004-03-17 Jean-Pierre Roux
1158 * REM (Eric Boix bug) : removal of meaningless
1159 gdcmDicomDirImage::NewImage function.
1160 * FIX now file names and directory name are written properly in the
1162 * FIX now gdcmDicomDir constructor may be call without any trick
1165 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1166 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1167 of gdcmDicomDirImage::NewImage as empty function.
1169 2004-02-28 Jean-Pierre Roux
1170 * ENH add gdcmDicomDir:NewPatient
1171 add gdcmDicomDirPatient:NewStudy
1172 add gdcmDicomDirStudy:NewSerie
1173 add gdcmDicomDirSerie:NewImage
1174 to allow making gdcDicomDir object.
1175 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1176 (as opposite to the gdcmHeader chained list)
1178 2004-02-11 Benoit Regrain
1179 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1180 when using from python
1182 2004-02-10 Benoit Regrain
1183 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1184 * FIX : in gdcmDicomDir when the directory is empty
1185 * ENH : add callback and methods to get the progression of dicomDir
1188 2004-02-06 Jean-Pierre Roux
1189 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1190 - GDCM_META added to gdcmDicomDirType
1191 - class gdcmMeta created
1192 * ENH : - A brief summary is now displayed at the beginning of
1193 'testDicomDir' to help disaster magnitude estimation
1194 * REM : Now useless Test/explDICOMDIR.cxx
1196 2004-02-05 Benoit Regrain
1197 * ENH : add methods in gdcmObject to get the hash table or the list of
1199 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1200 * FIX : wrapping python for TagHeaderEntryHT
1202 2004-02-04 Benoit Regrain
1203 * FIX : even length for some strings when writting the dicom dir
1204 * FIX : sort the images in the dicom dir
1205 * FIX : Bug fix for python use of dicom dir
1206 * ADD : a python demo
1208 2004-02-04 Jean-Pierre Roux
1209 * FIX : Final solution (?) for icone embedded images
1210 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1211 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1212 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1213 gdcmData/gdcm-MR-SIEMENS-16.acr1
1214 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1215 to make full checking easier
1217 2004-02-04 Benoit Regrain
1218 * FIX : WriteEntries : coding style & logic in parameters
1219 * FIX : Set the elements to create the DicomDir in a dictionary file
1221 2004-02-03 Benoit Regrain
1222 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1223 * gdcmDicomDir : add the load of directory
1224 * Bug fix and print add-on
1226 2004-02-03 Jean-Pierre Roux
1227 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1228 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1229 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1230 * FIX gdcmParser.cxx : 'group length' elements are now considered
1231 as integers, even for shadow groups, when file is Implicit VR
1233 2004-02-02 Jean-Pierre Roux
1234 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1236 of the last synonym :-(
1237 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1239 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1240 * FIX taking into account the possible 7fe0,0010 multiplicity
1241 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1242 to allow removal of references to 7fe0,0010, to deal with
1243 ACR-NEMA images, when 0028,0200 is meaningfull
1245 2004-01-31 Jean-Pierre Roux
1246 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1247 no longer writes 'Un' on disk
1248 * FIX SQ elements with actual length are now dealt with corectly
1249 * FIX gdcmFile::WriteBase make the difference, for color images, between
1250 the length (for Palette expanded images)
1251 and Raw Length (non expanded image + Palette)
1252 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1253 (that broke Write). Replaced by UL.
1254 Aware user will reload the field if he
1255 thinks it's necesssary
1257 2004-01-30 Jean-Pierre Roux
1258 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1259 when 'dirty Acr' is found, to be compliant with the new
1260 IsReadable() methods.
1262 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1263 (no DOUBLE images in kosher DICOM,
1264 but so usefull for people that miss them ;-)
1266 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1267 DICOMDIR related utilities (not checked as Windoze compliant)
1269 2004-01-28 Jean-Pierre Roux
1270 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1272 2004-01-27 Jean-Pierre Roux
1273 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1274 to allow skipping the shadow elements, to save memory space.
1275 The TRUE value for this param has to be used
1276 with a FALSE value for the 'enable_sequence' param.
1277 ('public elements' may be embedded in 'shadow Sequences')
1278 * gdcmHeader methods now deal with 'embedded icones images' in the header
1279 (even when an 'icone image sequence' is announced by the
1280 element (0x0088,0x0200), but there is NO icone at all ...
1282 * gdcmHeader sometimes Image Location value doesn't follow
1283 the supposed processor endianity (see gdcmData/cr172241.dcm).
1286 * gdcmHeader add the method
1287 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1288 to get *all* the Header Entries with the same tag.
1289 GetHeaderEntrySameName is probabely *useless*
1290 (no meaning : Name is *not* an identifier within the Dictionnary)
1292 2004-01-26 Benoit Regrain
1293 * Bug fix in the print of hexadecimal representations. Remove long fields
1294 in the print and add a third level of print to print them
1296 2004-01-23 Benoit Regrain
1297 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1298 * Bug fix on test suite after remove the strip made on not string fields
1299 * Split the IsReadable method between gdcmParser which test that the file
1300 is dicom and gdcmHeader which test that it's an image file
1302 2004-01-22 Benoit Regrain
1303 * DicomDir : clean code, add methods, set variables in protected or private
1304 * gdcmUtil : bug fix for the clean string method
1306 2004-01-19 Benoit Regrain
1307 * Add the use of shadow dictionaries
1308 * bug fix and coding style
1310 2004-01-19 Benoit Regrain
1311 * src/gdcmFile.cxx : bug fix concerning the close of file
1312 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1313 * Add the update of header entries using the shadow library
1315 2004-01-19 Benoit Regrain
1316 * removal of file gdcmHeader2.cxx
1317 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1318 inheriting from gdcmParser. This split is to prepare the integration
1319 of dicom dir parsing
1320 * bug fix under python
1322 2004-01-16 Jean-Pierre Roux
1323 * REM removal of class gdcmHeaderEntrySet
1324 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1325 * ADD add file gdcmHeader2.cxx
1326 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1328 2004-01-15 Benoit Regrain
1329 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1330 entries created while parsing the header. Thus, they will be destroyed
1331 when the gdcmDictSet will be destroyed
1332 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1335 2004-01-15 Benoit Regrain
1336 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1337 made a fatal error because of the memory release at the end of program.
1338 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1339 some memory and vtk seems to have some problems with that.
1340 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1342 2004-01-14 Benoit Regrain
1343 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1344 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1345 * src/*.[h|cxx] : make changes due to class name changes
1346 * gdcmPython/demo/*.py : bug fix due to method names
1348 2004-01-13 Benoit Regrain
1349 * src/*.[h|cxx] : coding style
1350 * vtk/*.[h|cxx] : coding style
1352 2004-01-13 Benoit Regrain
1353 * gdcmPython/testSuite.py : test the readable flag of file for tests
1354 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1355 It's lied to the stl compilation by MSVC (windows, always windows...)
1356 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1358 2004-01-12 Benoit Regrain
1359 * src/*.h : add comments
1360 * src/gdcmDictSet.h : set the method BuildDictPath in public
1361 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1362 directly setted in the source code
1363 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1366 2004-01-09 Benoit Regrain
1367 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1368 * setup.py : use a reference to gdcmVERSION
1370 2004-01-07 Benoit Regrain
1371 * Modification to compile with the distutils.
1374 2003-12-10 Benoit Regrain
1375 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1376 can use a gdcmHeaderHelper to load datas
1377 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1378 made in the source code
1380 2003-12-10 Benoit Regrain
1381 * Update Windows projects and .cvsignore files
1383 2003-11-12 Jean-Pierre Roux
1384 * ENH gdcmHeader constructor has one more parameter (default value : false)
1385 that allows the user to 'go inside' the SeQuences only
1387 gdcmElValSet:Print takes it into account
1389 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1390 * ENH: Update gdcmPython/CMakeLists
1391 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1392 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1394 2003-11-10 Jean-Pierre Roux
1395 * FIX : gdcmHeader::LoadElements is now based
1396 on the ListTag listElem member,
1397 not longer on the TagElValueHT tagHt member
1398 * ENH : PrintPubElVal shows (temporarily) both results,
1399 with the tagHt member and the listElem member.
1400 (it's easier to 'see' the problems when using Printheader)
1402 * FIX : old private member LgrElem is now splitted into
1403 ReadLength : Length actually found on disk (updated only
1404 if bug fixing is necessary), for internal
1406 UsableLength : Updated by FixFoundLength, to fix a bug
1407 or to allow Parser going on.
1408 Will allow to re-write a kosher header when a SeQuence
1409 with a length (not 0000) is found
1410 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1411 because gdcmElValSet::Add does not update ListElem
1414 2003-11-07 Jean-Pierre Roux
1415 * FIX misstyping in Transfert Syntax name table
1416 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1417 when they have an actual length (not 0000 nor FFFFF)
1418 (Nobody should care of it, but DICOMDIR explorers)
1420 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1421 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1423 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1424 * ENH: vtkGdcmReader now supports LUT !
1425 (vtkgdcmViewer for now is not able to use them though)
1427 2003-11-05 Jean-Pierre Roux
1428 * in testSuite.py : new files names for checking the package
1429 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1430 that returns the pixel area size to the *aware* (vtk) user
1431 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1433 2003-11-05 Benoit Regrain
1434 * in testSuite.py : Modify the rules for checking the paths
1435 : Explicit error messages
1436 * in __init__.py : Related modif
1438 2003-11-03 Jean-Pierre Roux
1439 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1440 to be used by aware (vtk) users that want to manage
1441 LUT (and no to turn the PALETTE image into an RGB pixels one)
1442 * GetPixelType now returns 8U for 24 Bits images
1443 (vtkGdcmReader compliant)
1445 2003-10-31 Jean-Pierre Roux
1446 * Removal of *all* gdcmData images and add them again
1447 in order to loose the 'history' of un-anonymised images
1449 2003-10-31 Jean-Pierre Roux
1450 * RMV : removal of useless jBitsInJsample.h
1451 for both 8 and 12 Bits JPEG Lossy Libraries
1453 2003-10-31 Jean-Pierre Roux
1454 * ENH : Add the functions gdcmFile::GetImageDataRaw
1455 gdcmFile::GetImageDataIntoVectorRaw
1456 that act as GetImageData and GetImageDataIntoVector
1457 except the making of an RGB Plane from Gray Plane + LUT
1458 Intended to aware (vtk) users who know how to manage
1461 GetLUTRGBA return a R,G,B,A LUT if any
1462 lgrTotaleRaw gives the 'Raw' length
1463 GetImageDataRaw returns the gray Plane
1464 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1465 (They stay Grey, just like with other Dicom viewers :-(
1467 2003-10-30 Jean-Pierre Roux
1468 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1470 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1471 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1472 being coherents dicom files.
1474 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1477 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1478 * ENH: Two steps is necessary to please VC++ compiler...
1479 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1480 * ENH: Add include dir to medcon lib
1481 * FIX: only one function is being exported for now !
1482 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1484 2003-10-29 Jean-Pierre Roux
1485 * adding gdcmHeader::GetLUTRGBA
1486 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1487 --> Mathieu, the modif u're waiting for is not yet committed
1488 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1490 2003-10-27 Jean-Pierre Roux
1491 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1492 00191113.dcm DermaColorLossLess.dcm
1493 MxTwinLossLess.dcm RadBWLossLess.dcm
1494 * ENH: For version prior to vtkImageViewer2 -r 1.19
1495 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1497 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1498 * Removal of ido stuff in CMakeLists.txt
1500 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1501 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1502 * FIX: remove a call to ->Modified ... see comments
1503 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1505 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * FIX: Problem with path for libvtkgdcmPython
1507 * ENH: Try adding a search script for python site-package
1508 * RMV: Remove some file from medcon lib that are not necessary
1509 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1510 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1511 * FIX: More pragma disable fro VC++,
1512 I don't think I break something as it is also disable in VTK/ITK.
1513 But it fasten debug compilation time.
1515 2003-10-23 Jean-Pierre Roux
1516 * gdcm now deals with 16 Bits Run Length Encoded images
1517 (they are compressed as 2 planes images,
1518 one for the high Bytes, the other for low Bytes)
1520 2003-10-22 Jean-Pierre Roux
1521 * Now CheckRead takes into account :
1522 - the bugged 'Leonardo' Siemens images
1523 - the XA images, sent thru the burning VPRO station
1524 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1527 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1528 * FIX: When copying a Makefile.am to CMakeLists.txt
1529 one should remove the '\'
1531 2003-10-22 Jean-Pierre Roux
1532 * in gdcmData adding a bugged 'Leonardo' Siemens image
1533 (wrong lengths in header)
1534 OK with gdcm, KO with the other viewers :-)
1535 * add a GE dlx XA image, thru the VEPRO burning station
1538 2003-10-21 Jean-Pierre Roux
1539 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1540 for a brutal checking of vtkgdcmViewer compliance
1542 2003-10-21 Jean-Pierre Roux
1543 * add the files for 'xmedcon' Jpeg Lossless library
1544 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1546 2003-10-21 Jean-Pierre Roux
1547 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1549 2003-10-21 Jean-Pierre Roux
1550 * garbage Siemens 'Leonardo' images dealt with
1551 (the patch is easy to remove)
1552 * cosmetic changes to avoid warnings
1554 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1555 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1556 no need to press 'r' now.
1558 2003-10-20 Jean-Pierre Roux
1559 * upgrade of checkRead.sh checkWrite.sh according
1560 to new Jpeg Lossless decompressor
1561 * add US.3405.1.dcm, a genuine RGB medical file ...
1562 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1563 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1565 2003-10-15 Jean-Pierre Roux
1566 * general anonymisation in gdcmData
1567 * adding the 'color files' from
1568 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1569 * adding some well knowed bugged-header images
1570 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1571 waiting for their inclusion in Python testsuite
1573 2003-10-15 Jean-Pierre Roux
1574 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1575 no longer seg faults when file is not found
1577 2003-10-14 Jean-Pierre Roux
1578 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1581 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1582 * TODO: *.in file to genereate a UseGDCM later
1584 2003-10-14 Jean-Pierre Roux
1585 * Some supposed-to-be Dicom Images have no preamble.
1586 OpenFile takes it into account
1587 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1588 * Missing elements added in dicomV3.dic
1589 (just to be affraid : have a look at
1590 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1591 and do it again next year ;->
1593 2003-10-13 Jean-Pierre Roux
1594 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1595 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1596 But there are NOT. It's fixed !
1598 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1599 * FIX: "jpeglib.h" was not found on VC++
1600 * FIX: vtkgdcm was not being installed
1602 2003-10-10 Jean-Pierre Roux
1603 * ENH : OpenFile closes the file if it *really* doesn't look like
1604 an ACR-NEMA / DICOM one.
1605 * FIX : testWrite no longer writes an empty file if the source file
1606 is not gdcm Readable
1607 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1610 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1611 * FIX: CMake generate now documentation
1612 * ENH: out of source doc build !
1613 * ENH: Generate both user and dev documentation
1614 * ENH: Should work on windows too
1615 * ENH: Only one doxygen config.in file is needed
1616 * FIX: make install should be ok now on ùnix plateform
1617 * FIX: PATH to dictionary was wrong (missing /)
1618 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1620 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1621 * vtkGdcmReader is now able to read rgb dicom file.
1622 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1623 * added a gdcmViewer to vtk test, use mouse to control
1624 window level & window width
1626 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1627 * CMake-ification of gdcm, we have now two build system
1628 * FIX: on cygwin Wsock32 doesn't exist
1629 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1631 2003-10-06 Emanuel Ollart
1632 * FIX : compilation process wad broken.
1633 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1635 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1636 * change gdcmViewer -> vtkgdcmViewer
1637 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1639 2003-10-06 Jean-Pierre Roux
1640 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1641 ( e.g : well known GE images with a wrong elem length,
1642 : Philips MRI Images with a wrong Huffman table)
1643 * still to be done : allow the reading of bugged LEONARDO Siemens images
1645 2003-10-03 Jean-Pierre Roux
1646 * Odd length strings are padded with '\0' (not with spaces,
1647 to remain compliant with already defined strings,
1648 like Transfert Syntax UID and others)
1650 2003-10-03 Jean-Pierre Roux
1651 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1652 to allow displaying RGB images (not only by affim ;-)
1654 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1655 * vtkGdcmReader is now able to read rgb dicom file.
1656 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1658 2003-10-03 Jean-Pierre Roux
1659 * A few nasty patches to allow the reading of a lot of nasty images
1660 ( e.g : well known GE images with a wrong elem length,
1661 : Philips MRI Images with a wrong Huffman table)
1662 * still to be done : allow the reading of bugged LEONARDO Siemens images
1664 2003-10-03 Jean-Pierre Roux
1665 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1667 2003-10-03 Jean-Pierre Roux
1668 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1669 to allow displaying RGB images (not only by affim ;-)
1671 2003-10-03 Jean-Pierre Roux
1672 * gdcmFile::GetImageDataIntoVector now
1673 - deals with MultiFrames MultiFragments Run Length Encoded files
1674 - deals with YcBcR (YBR_FULL) files
1675 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1676 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1678 (no sample found :-(
1680 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1682 Two reasons: - clear things
1683 - third parties acces gdcm through header files, so won't
1684 suffer anymore VC++ complains
1686 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1687 * add argv[1] in testvtkGdcmReader.cxx
1690 2003-09-24 Jean-Pierre Roux
1691 * The lines are now eigthy characters long.for
1692 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1694 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1695 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1696 char* to std::string. Thus, the use of strdup becomes useless. (see
1697 previous commis of Malaterre)
1698 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1699 before the last Malaterre's commit.
1701 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * This commit should fix the Debug building under VC++, the problem
1703 was mainly a mixture of debug and release lib being loaded at startup.
1704 * I also remove a depency to a specific C function: strdup. Because I had
1705 to force the link to msvcrtd (whereas strdup is in libc).
1707 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1708 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1709 located in the gdcmCommon.h file. All use of reference of tha has been
1710 changed to now use the variable GDCM_UNFOUND.
1712 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1714 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1715 Dicom dictionary. The test suite can now be run again. Note:
1716 I'm note very happy with the " (RET)" changes. I believe this
1717 RETAINED comment should be dropped when parsing the dictionary.
1718 - PACKAGER corrected
1720 - AUTHORS updated and now in alphabetical order
1721 * Makefile.am now exports gdcm.dsw for Windoze users.
1723 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1724 * cygwin complains about missing std:: in subdir Test/
1726 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * remove some methods that are now in gdcmHeaderHelper
1729 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * vtkGdcmReader set spacing and origin correctly
1732 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1733 * Fix a few delete/delete[] mismatch
1735 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1736 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1737 interpretation to data given by gdcmHeader. For instance there are
1738 heuristics to get informations (look at different places).
1739 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1740 sorting DICOM images based on different strategies.
1741 * modified Makefiles accordingly.
1743 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1744 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1745 when building in debug mode
1746 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1747 src/win32/gdcmdll.dsp
1748 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1750 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1751 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1754 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * src/win32/libgdcmjpeg12.dsp was not dos format
1756 * src/win32/libgdcmjpeg12.dsp :
1757 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1758 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1760 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1761 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1763 * src/gdcmFile.cxx : bug fix in affectation type
1764 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1765 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1766 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1767 symbols... future problem ?
1769 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * src/win32/libgdcmijpeg12.dsp was missing
1771 * modified gdcm.dsw accordingly
1773 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1776 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1777 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1778 commit of JPR (before his hollidays to facilitate our work).
1779 * setup.py : bug fix in code. Modifications made while the last commit
1780 of JPR. The code hasn't been tested before the commit... it's so
1781 useless to make that (for best programmer that is JPR) !!!
1783 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1784 * tagged the current version as Version0_3 (i.e. version 0.3)
1786 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1787 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1788 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1789 * *.dsp : modifications to use new libgdcmijpeg8 library
1790 * setup.py : bug fix on VTKPATH variable
1791 * PACKAGER : adding all concerning windows
1793 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1794 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1796 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1797 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1798 test suite reported error.
1799 * PACKAGER file added (describes what a packager must do when
1800 packaging a new release).
1801 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1802 * configure.in: upgraded version number to 0.3.0
1803 * fixing build of rpm (through rpm -ta):
1804 - Doc/Makefile.am exports proper doxygen files
1805 - src/jpeg/libijg8/Makefile.am exports the include files.
1807 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1808 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1809 * src/gdcmHeader.h : formatting code
1811 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1812 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1813 We were obtaining error message from vtk. Now, creation of file list
1814 is made in an internal list to prevent this problem.
1815 Bug fix when output is empty.
1816 Bug fix in update of progress value. Previous commit for this was a bad
1818 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1820 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * src/gdcmHeader.h : added method to get the file name
1822 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1823 files. Added method to remove all files on the input
1824 Added FIXME comment concerning the bad parsing of header made by
1825 ExecuteInformation method (in ExecuteData method)
1827 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1829 when using make instal.
1830 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1831 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1833 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1834 * setup.py : adding include dir of jpeg lib to compile all sources
1835 * */Win32/*.dsp : JPR fix for windows compilation
1837 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1838 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1840 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1841 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1843 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1844 * setup.py is again effective on un*x (takes into account the
1845 addon of the jpeg library)
1846 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1847 * Doc/Doxy* updated (includes above enhancements)
1848 * INSTALL now points to web documentation
1850 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * src/gdcmHeader.h doesn't make unnecessary reference to
1853 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1855 * src/gdcm*.[cxx|h] :
1856 - to allow compilation with gcc 3.x
1857 -- clean up of STL usage (added explicit usage of std::)
1858 -- small fixes on exceptions.
1859 Note: linking not tested !
1860 - clean of doxygen comments to avoid warnings at documentation
1862 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1863 dependent convertion).
1865 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * Clean up of previous JPR garbage commit (not even commented in the
1868 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1869 - moved all jpeg related files from src to src/jpeg/libijg8, with
1870 addition/modification of Makefile.am and configure.in.
1871 - the testSuite is still brain damage (not guilty).
1873 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1874 * WrapVTK.py : modifications to get correctly vtk source files to
1876 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1877 (FileName -> Filename)
1879 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * vtk/vtkGdcmReader.[cxx/h]:
1881 - UpdateProgress method should now be effective
1882 - removed the limitation on having only images loaded (as opposed
1884 - when building a stack of images/volume, a lesser number of
1885 gdcmHeader and gdcmFile instances should be used (hopefully
1886 accelerating things).
1887 - when building a stack of images/volumes, files which are not
1888 loadable (wrong path-filename, wrong permissions on existing file,
1889 or file not parsable by gdcm) are replaced with a black image
1890 in the stack (for the caller to notice the problem).
1892 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1893 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1895 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1897 between standard library (std) and vtk library (problems are found
1898 under Windows... thanks Windows !)
1900 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1901 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1903 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1905 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1908 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1909 * When compiling with distutils (see setup.py) the C++ compiler is
1910 called with different flags than the default ones (with automake).
1911 In order to fix all those warning, I compiled gdcm with the command
1912 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1913 and went for warning fixes:
1914 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1915 up from unused variables.
1916 - vtk/vtkGdcmReader.cxx: potential bug fix.
1917 * src/gdcmHeader.h: Doxygen warning cleanup
1919 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1920 * gdcmPython/gdcm.i:
1921 - typemaps correction to take into account the systematic replacement
1922 of "using namespace std" with std:: prefix e.g. std::list,
1923 std::string... (cf changes of 2003-05-21).
1924 - gdcmGlob global variable of type gdcmGlobal (defined in
1925 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1926 exported to Python a as cvar.
1927 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1928 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1929 gdcmDictSet.GetPubDictTagNames() and
1930 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1931 C++ static methods).
1932 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1933 with the above changes.
1935 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1936 * setup.py, manifest.in : bug fix under linux
1938 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1939 * Modification of setup.py to compile vtk part too. Then, we have 2
1940 wrappers which must work with same distutils. For that, we have a
1941 generic distutils in distusiltsWrapping.py ; with :
1942 - build_extWrap class to wrap generically all extensions,
1943 - ExtensionWrap base class for all wrapping extension that contains
1945 - Wrapper interface which wrap sources
1946 + In WrapSwig.py we have extension and wrapper for Swig
1947 + In WrapVTK.py we have extension and wrapper for VTK
1948 * MANIFEST.in : modifications to consider vtk directory and new python
1949 files for compilation
1951 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1952 * Added python wrappers of vtkGdcmReader vtk class (see the
1953 source in vtk/vtkGdcmReader.cxx) :
1954 - vtk/Makefile.am now builds a library
1955 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1956 python library (as opposed to _gdcm.so wich are the python
1957 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1958 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1960 - configure.in has an additional flag --enable-vtk that needs
1961 to be set to enable compilation of vtk related code, that is:
1962 + vtk/vtkGdcmReader.so and
1963 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1964 + gdcmPython/vtkgdcmPython.so (see above)
1965 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1966 be read when compressed or when HighBit + 1 != BitsStored),
1967 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1968 the usage of the python wrapper of vtkGdcmReader vtk class.
1969 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1970 * src/*.[h] all occurences of stl classes are now prefixed with
1971 std::, and all occurences of "using namespace std;" where removed.
1972 This is to avoid pollution of global namespace in included files.
1973 Apparently vtk does not avoid this pitfall: when using both
1974 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1975 collision of various stl members (principally cout...).
1976 * gdcmPython/testSuite.py now cleanly removes temprory generated
1978 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1979 comply with above changes)
1981 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1982 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1983 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1984 vtk data structure (an image Flip was required).
1985 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1986 * cosmetic changes in documentation.
1988 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1989 * src/gdcmHeader.cxx: the constructor no longer exits when an
1990 unexisting file is given as argument.
1991 * The subdirectory Data (containing all the images used for the
1992 test suite) is not part of this repository anymore. A new module
1993 containing those images is now available at
1994 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1995 with the name gdcmData.
1996 All the python scripts (including the package initialisation file
1997 gdcmPython/__init__.py) were adapated to take this change into
1998 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2000 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2001 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2002 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2003 demo of the usage of this class.
2004 Compilation of this vtk part is only done when using the --enable-vtk
2005 at configure (or autogen.sh) stage.
2007 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2008 * More memory link related corrections and documentation fixes.
2010 - maximum info is obtained with a command of the form:
2011 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2012 --show-reachable=yes PrintHeader
2013 - the remaining reachable blocks seem to come from the STL
2014 allocation scheme through the usage of map and list. It looks
2015 like this memory cannot be freed but it is not a memory leak
2016 (in fact further invocation to the STL would recollect the
2017 unused memory allthough it cannot explicitely be freed).
2018 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2019 of displaying an image parsed with gdcm and displayed with VTK.
2020 Note: some images don't seem to work e.g.
2021 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2022 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2023 Allthough this weakens the semantics, it is a ditch attempt to
2024 make gdcm more thread friendly.
2026 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2027 * Memory link hunt (by using valgrind through the command
2028 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2029 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2030 gdcmHeader::_dicom_vr.
2031 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2032 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2034 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2036 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2037 * src/Makefile.am now exports all the necessary include files at
2041 * UpdateGroupLength replaced by new one
2044 * UpdateGroupLength re-written using H-Table
2045 (named UpdateGroupLengthNew untill checks are over)
2047 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2048 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2049 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2051 - gdcmHeader::GetPubElValSet removed.
2052 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2053 UpdateGroupLength, WriteElements, Write.
2054 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2055 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2056 carried the same semantics.
2057 - src/gdcmHeaderIdo.cxx changed accordingly.
2058 - gdcmFile::WriteBase now regroups all the codes from previous
2059 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2060 - enum FileType moved to gdcmCommon.h
2061 * src/gdcmHeader.cxx AddDefault trashed
2062 * gdcmGetXSize added
2063 * getimageDataSize now calls gdcmGetXSize
2064 * Test/*.cxx changed to agree with above changes
2066 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2068 (to avoid double call by end user).
2069 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2070 by end user, since gdcmHeader::gdcmHeader now handles it.
2072 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * gdcm/Doc many doxygen changes:
2074 - Doxyfile now has two different versions, DoxyfileUsers that generates
2075 the html.users end users oriented documentation and
2076 DoxyfileDeveloppers that generates the html.developper developper
2077 oriented documentation.
2078 - README changed accordingly
2079 - requirement.txt removed (old design info moved to TODO).
2080 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2081 DoxyMainPage.txt, DoxyPython.txt provide more information.
2082 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2083 be updated by simply regenerating the docs with doxygen and copying
2084 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2085 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2086 all the tests in the form "if (<map>.count() >1)" were removed.
2087 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2088 ill-formed documentation sections.
2089 * src/gdcmHeader.cxx: ditto
2091 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2092 * setup.py fixed for un*x (needed macro for stdint.h)
2093 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2094 un*ces with sh-utils test utility.
2095 * gdcmPython/demo/test.py renamed to PrintHeader.py
2096 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2097 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2098 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2099 * src/gdcm*.cxx JPR's bad inclusion fixed.
2101 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2103 * gdcmPython/demo/test.py changed accordingly.
2105 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * gdcmPython/Makefile.am fixed linking against libstdc++
2107 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2108 * Swig subdir (historical tests of swig version 1.3.17++) removed
2109 * Test/testChangeEntete.cxx some lines commented out in order to make
2111 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2112 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2114 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2116 hence the user doesn't need this explicit call.
2117 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2118 i.e. LoadElements() call removed.
2119 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2120 - src/Makefile.am declares the proper flag for g++.
2121 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2122 for adding user defined new tags.
2123 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2124 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2125 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2127 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2128 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2129 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2130 src/Makefile.am : the project should properly compile and install
2131 with the autotools, included the python wrappers part.
2132 * gdcm.spec.in : added a spec file for RPM packaging.
2134 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2135 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2137 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2139 to exported to the environement (see gdcmPython/testSuite.py
2141 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2142 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2143 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2144 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2145 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2147 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * gdcmPython/__init__.py doesn't crash anymore when running in
2149 in InstallMode or PreInstallMode but with an environement given
2150 value of GDCM_DICT_PATH.
2151 * src/gdcmDictSet.[cxx/h] coding style.
2153 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2155 * src/gdcm.h general comments moved to TODO, and README
2156 * src/gdcm.h should now be seen as a user commodity (including it
2157 should suffice to fully use gdcm). It is nowhere including within
2158 any of the kernel files src/*.cxx and src/*.h.
2160 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2162 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2164 * src/gdcm*.cxx only include their corresponding include file
2165 (as opposed to gdcm.h)
2166 * gdcmPython/gdcm.i changed accordingly
2167 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2168 the autogen.sh generated "make snapshot" command to work.
2169 * autogen.sh removed history related references to crea package.
2171 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * distutilsSwigCPlusPlus.py work around some swig portability
2175 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2177 was done in a last ditch attempt to get setup.py _really_
2178 operationnal. The python/gdcmPython layaout add the advantage
2179 of hidding away the python related distutils specific files
2180 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2181 Alas, the src directory was out of scope (i.e. it's relative
2182 position to setup.py was ../src) which made things impossible to
2183 handle (see previous version of python/setup.py). Crossing fingers...
2185 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2186 * python/setup.py now works on Un*x. (harder than I thougth)
2187 * python/distutilsSwigCPlusPlus.py can now have include files
2188 among the list of sources.
2190 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2191 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2192 * modifications in MSVC projects
2194 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * As stated by the first lines of Test/ExceptionAndPython/README, it
2196 looks like we can move back to original usage of exception within
2197 src/gdcm* and hence remove the errno stuff that was introduced
2198 as a quick and dirty fixture of this problem (added to the TODO).
2199 * Doc/Doxyfile configuration file for Doxygen and corresponding
2200 README file for usage added.
2201 * Test/testWrite.cxx added. This new test comes from a split of
2202 test.cxx that is now reverted to its original purpous i.e.
2203 testing the proper parsing of a Dicom related file.
2204 testWrite.cxx concentrates on testing the IO part of gdcm.
2205 * Test/bug1.cxx (containing a bug on WIn32) added.
2206 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2207 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2208 whose purpose is to publish the content of the TagNames of the
2209 Dicom public dictionnary were not accessible without an
2210 instance of class gdcmHeader.
2211 - those methods are now static methods of gdcmDictSet and hence
2212 require no instances at all to be invocated.
2213 - within gdcmDictSet this change required to change some method
2214 to class methods (i.e. are now static) among which SetDictPath
2215 (renamed to BuildDictPath) and LoadDefaultPubDict.
2216 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2217 the above changes by calling the new method classes of gdcmDictSet.
2218 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2219 the above to be effective.
2220 * python/gdcmPython: in order to wrap properly the above changes
2221 for Python, swig version now needs to be > 1.3.17.
2222 * python/gdcmPython/Makefile fixed to adapt itself to new
2223 configure/make shema introduced by Johan Montagnat (thanks for the
2224 contribution). Alas this Makefile cannot be turned into a proper
2225 Makefile.am without some heavy changes in the configure.in
2226 (for python dectection).
2227 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2228 now avoids publishing the empty entries.
2230 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2231 * python/setup.py : bug fix concerning install under windows
2232 ExtraPath reused :-P
2233 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2235 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2236 * Dicts/dicomV3.dic : remove double spaces !!!
2237 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2238 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2241 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2243 method. Doxygenation.
2244 * src/gdcm.h clean up of JPR spurious comments.
2246 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2247 * python/distutilsSwigCPlusPlus.py now properly collects the
2248 shadow classes generated by "swig -c++" (gdcm.py in our case)
2249 when using "python setup.py install".
2250 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2251 reexports the working classes.
2252 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2253 by the classical C errno scheme. This is to prevent an obscure
2254 behavior of the python wrappers when importing wxPython.wx prior
2255 to gdcmPython (which ended up in an abort call). An illustration
2256 of this oddity can be found in the Test/ExceptionAndPython
2257 subdir (see the README file). This problem probably due to
2258 an combination of g++ and dynamic loading.
2259 * added Test/ExceptionAndPython (see above)
2261 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2262 * Changed the layout of the python part to avoid bloating main
2263 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2264 i.e. the distutils arsenal. All the python related stuff is
2265 again in a python subdir, but the package itself is now in
2267 * setup.py was cleaned up:
2268 - pythonIncludePath removed
2269 - python setup.py bdist target is now functional.
2270 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2271 collision with other packages). gdcmPython/demo/*.py changed
2274 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * python subdir moved to gdcmPython (preparation of distutils packaging).
2276 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2277 distutils installer is operational.
2278 * - gdcmPython/__init__.py now properly loads the swig generated
2279 shadow classes (from gdcm.py).
2280 - gdcmPython/demo/*.py changed to import the package gdcmPython
2281 instead of gdcmPython/demo/load.py.
2282 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2284 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2285 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2286 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2287 entries within the associated public Dicom dictionary resp. the same
2288 information but sorted by the fourth field (PAT, IMG, DIR) of the
2290 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2291 are now in the "???" group.
2292 - python/gdcm.i changed accordingly,
2293 - python/demo/printGroupedPublicDict.py added, that gives an example
2294 of the above new functionalities in Python.
2296 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2297 * src/gdcm.h, gdcmHeader.cxx:
2298 - historic references to glib's g_malloc and g_free (#defined)
2299 were definitively removed.
2300 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2301 * src/gdcmElValSet.cxx:
2302 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2303 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2304 - GetElValue(string) renamed to GetElValueByName.
2305 - Added GetElementByName(string).
2306 * src/gdcmHeader.cxx: added
2307 - GetPubElValRepByNumber(guint16, guint16)
2308 - GetPubElValRepByName(string)
2309 - GetShaElValRepByNumber(guint16, guint16)
2310 - GetShaElValRepByName(string)
2311 - GetShaElValByNumber(guint16, guint16)
2312 - GetShaElValRepByName(string)
2313 - GetElValRepByNumber(guint16, guint16)
2314 - GetElValRepByName(string)
2315 - GetElValByNumber(guint16, guint16)
2316 - GetElValRepByName(string)
2317 * Doc/requirements.txt added.
2319 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * Test/Makefile building now depends on the one of libgdcm.so
2321 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2322 pixel data) aware which enables finding the address (offset) of
2323 the pixel data of JPEG encoded DICOM files. This leaves only a single
2324 file in the testSuite whose pixel data address (offset) is unknown.
2325 * python/testSuite.py changed accordingly.
2327 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2328 * VC++ has some strong limitations when working with the STL, as stated
2329 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2330 "Also note that some STL containers (map, set, queue, list, deque)
2331 cannot be exported. [...]
2332 Some STL classes contain nested classes. These classes can not
2334 This is caused by a designed limitation that once a template
2335 class is instantiated, it can not be re-instantiated and
2337 Since our usage of map<> is ubiquitous in gdcm, this "designed
2338 limitation" of VC++ is a pitfall.
2339 Hence the Python wrappers of gdcm cannot be incrementally linked
2340 against the c++ dynamic library. The dirty but only workaround is
2341 to forget about incremental link of dynamic libraries and to generate
2342 the Python wrappers library with the inclusions of the underlying C++
2344 The following modifications concern this matter on Win32/VC++:
2345 - wrapping python correct with standalone wrapped dll (don't use separate
2346 dll under windows !!!!)
2347 - python21_d debug mode enabled (ask Frog how to use it :-)
2348 - NO problem with having an STL member of class for example string in C++
2349 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2350 - Python test of dcmlib in Python is ok under windows on a large set
2352 * removed glib references
2353 * typedef's inserted in gdcm.i for correct swig type management
2355 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2356 * python/demo/*.py load.py extracted from test.py. Added explore.py
2357 that only displays required tags and testAll.py that parses all
2358 the files of the testsuite without using unittest.
2359 * python/testSuite.py other additional test on new files added.
2360 * Data/* new test files added accordingly to the testSuite.
2361 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2362 the vr in the file differs from the one of the dictionary.
2364 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2366 values, but limits itself to values which are below a user specified
2367 size (by default 1024 bytes).
2368 * python/gdcm.i : elements not loaded (because their size is above the
2369 user specified treshold) are exported with their TagKey as key of the
2370 python dictionary. This enables the testsuite to make some checks
2371 on the unloaded elements (since we have their offset and size).
2372 * python/testSuite.py
2373 - now tests for the existence and proper value of the pixel data
2374 - two new examples added.
2375 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2377 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2379 aware. See the strategy comments in gdcmHeader::FindeLength().
2380 * Test/test.cxx now accepts a filename as first argument.
2381 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2382 * python/testSuite.py changed to integrate test on above files.
2384 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2386 the vr was also RET.
2387 * python/testSuite.py more tests added.
2389 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2390 * python/testSuite.py unittest test suite added (uses Data)
2391 * Data/* dcm and acr files for the test suite.
2392 * glib dependance removed from un*x version. We now use ISO C99
2393 7.18 Integer types (see stdint.h)
2394 - python/Makefile, src/Makefile src/gdcm.h
2395 * src/ when an explicit vr (like dicom files) suddenly poped an
2396 implicit element we use to mark the underlying DictEntry of the
2397 concerned ElValue with "Implicit". This strategy was damageable
2398 too the public or provite dictionaries, since some of their vr
2399 would be changed. Since Header::FindLength heavily relies on the
2400 detection by Header::FindVR of falsely explicit elements, I
2401 added an extra ImplicitVr member to ElValue (boolean).
2402 The rest of the changes we the necessary adaptations.
2404 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2405 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2407 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2409 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * Adaptation for porting to VC++:
2412 o forced to use std namespace (for string to be known)
2413 o all class use __declspec export style on WIN32
2414 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2415 (in stdlib.h on Win32 but in std:: for gcc)
2416 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2417 variable GDCM_DICT_PATH.
2418 * src/gdcmHeader.cxx verbose comments made discrete.
2420 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * python/gdcm.i: added a typemap that converts a C++ hashing table
2422 to native Python dictionary.
2423 * python/demo/test.py:
2424 - now uses the native dictionary for exploration of gdcmHeader.
2425 - takes an optional filename argument (the file to parse).
2426 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2427 PubElVals hashing table.
2428 * Dicts/dicomV3.dic removed error prone trailing spaces.
2430 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * Python wrapping process moved away from src/Makefile to
2432 newly created python/Makefile (as well as gdcm.i)
2433 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2434 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2435 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2436 from the environement variable GDCM_DICT_PATH (when existing).
2437 * src/gdcmDict::GetTag bug fix.
2439 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * Straightforward temporary fixes for swig to build the python wrappers.
2441 src/Makefile now has a python working entry [by working we mean
2442 that we can import de shadow classes without errors].
2444 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * hashtest.cxx removed (since allready in Test)
2446 * src/gdcmlib.h renamed to src/gdcm.h
2447 * src/dcm.i renamed to src/gdcm.i
2448 * src/Makefile prepared for python wrapping
2450 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2451 * src/gdcmHeader.cxx :
2452 - Parsing of header is now separated from loading of element values
2453 (see gdcmHeader::LoadElements).
2454 - general clean up of hopefully all file access (creation of
2455 ReadInt16 and ReadInt32)
2457 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * src/gdcmHeader.cxx :
2459 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2461 - SetLgrElem renamed to SetLength
2462 - GetLgrElem renamed to GetLength
2463 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2464 * src/gdcmElValSet.cxx fixed both GetElValue methods
2465 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2466 due to IdoDude was cleaned out.
2468 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2469 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2470 concentrates on finding the value representation (when it exists).
2471 RecupLgr now only finds the element value length, and it avoids
2472 returning the unecessary skL (skipped length).
2473 Also, offsetCourant was simply removed (with taille_fich) since
2474 it was redundant with the File position internals (by using
2475 ftell and fseek). This also made skL (see above in RecupLgr) usage
2477 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2478 on the libido specificities which are handled through class
2480 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2483 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * Truckload of changes. Parsing of header is barely functional
2485 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2487 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * src/gdcmHeader.cxx many addons of low level methods
2490 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2491 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2492 and _IdDcmSWAP_LONG.
2494 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * This corresponds to all the changes decided at the meeting of
2496 May 23 2002. Needless to say we are running late...