1 2004-09-23 Jean-Pierre Roux
2 * FIX In order not to be poluted any longer by casting problems,
3 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
4 we can now delete[] it safely
6 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
8 clear) TagHT, which is an inherited member of gdcmElementSet. It is
9 up to the destructor of gdcmElementSet to clean up TagHt and it's
12 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
13 * Test/CMakeLists.txt: update to follow gdcmData renamings.
14 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
16 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
17 * ENH: added some utility method that builds a flat dictionnary
18 holding all the Dicom entries contained in the recursive structure
19 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
21 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
22 BuildFlatHashTable() that build a flat dictionary.
23 - src/gdcmElementSet.h: added a new private GetTag() accessor.
24 gdcmDocument is now a friend of gdcmElementSet.
25 - src/gdcmElementSet.cxx: clean up.
26 - Example/FlatHashTablePrint.cxx added.
27 - Example/CmakeLists.txt changed accordingly
29 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
31 moved away from gdcmDocEntrySet (since this class is an abstract class
32 acting like an interface). SQDepthLevel and BaseTagKey are now
34 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
35 and associated accessors. Doxygenation of the class.
36 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
38 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
39 Use SQDepthLevel accessor instead. ::Print() adapted.
40 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
41 - src/gdcmDocument.cxx changed accordingly.
43 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
44 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
45 - The following is the doxygen comment of the typedef declaration
46 of gdcmagKey in src/gdcmCommon.h:
47 gdcmTagKey is made to old an "universal" (as in URL, Universal
48 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
49 A dicom tag allways has a group and an element, but a set of tags
50 embeded in various (optionally nested) sequences and sharing
51 the same group and element all share the same (group, element)
52 "identifier". Hence the (group, element) cannot be used as an
53 identifier (in gdcm we shall refer to a "TagKey") of a tag.
54 In order to construct a proper tag identifier (i.e. a key) we
55 consider the following definition of a TagKey:
56 - let Group, Element be the string representation of the
57 group and element dicom tag members,
58 - let ItemNumber be the string representation of the integer
59 index of the considered item number of a sequence,
60 Let the key of a tag embeded in a sequence, noted SeqTag, be
62 /ItemNumber#Group|Element
63 where "/", "#" and "|" are characters acting as separators.
64 Then the general form of a gdcmTagKey is given by:
66 where <SeqTag> means NO or many instances of SeqTag.
67 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
70 but the gdcmTagKey of a tag "embeded" is the first item of
71 a sequence, itself nested in the third item of a sequence is the
73 0004|1220/2#0008|0082/0#0008|0090
74 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
75 order to hold the new sequence compatible key. Previously, the
76 GetKey() method would look in the underlying gdcmDictEntry.
77 - src/gdcmDocEntry.cxx:
78 -- constructor now copies the underlying DictEntry key, in the local
80 -- ::Print: displays the member Key, instead of the (group, element).
81 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
82 - src/gdcmDocEntrySet.h:xi
83 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
84 -- now has a new BaseTagKey member.
86 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
87 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
89 This poses the problem with the semantics of the following lines
90 LoadEntryVoidArea(0x0028,0x1201); // R LUT
91 LoadEntryVoidArea(0x0028,0x1202); // G LUT
92 LoadEntryVoidArea(0x0028,0x1203); // B LUT
93 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
94 to the long FIXME note for what the problem is. Nevertheless in
95 order to get things working the dicom dictionary was altered !
96 Please fix things urgently...
97 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
98 information), see above note on moving the member VoidArea. Nevertheless
99 the following entries previously correctly set as US are now inproperly
101 0028 1201 OW IMG Red Palette Color Lookup Table Data
102 0028 1202 OW IMG Green Palette Color Lookup Table Data
103 0028 1203 OW IMG Blue Palette Color Lookup Table Data
104 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
105 of gdcmDocEntry moved to gdcmSeqEntry.
106 * src/gdcmSeqEntry.cxx: STYLE.
108 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * Test/TestAllEntryVerify.cxx minor fix and added comments.
111 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
112 * gdcmPython/testSuite.py: all the test suite in python is now moved
113 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
114 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
115 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
117 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
119 to avoid inclusion recursion until STL is reached.
120 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
121 mecanism. errno.h is not included in gdcm anymore.
122 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
123 (gdcmFormatError now inherits from gdcmFormatUnexpected).
125 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
126 gdcmData/TestAllEntryVerifyReference.txt
127 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
128 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
129 exception_on_error parameter.
130 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
131 - vtk/vtkGdcmReader.cxx changed accordingly,
132 - Example/*.cxx and Test/*.cxx changed accordingly.
134 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
135 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
136 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
137 enable_sequences removed from gdcmHeader constructor and dependencies.
138 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
139 * gdcmPython/demo/PrintHeader.py: dummy fix.
140 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
141 skip_shadow removed from gdcmHeader constructor and dependencies.
142 * Example/*.cxx and Test/*.cxx changed accordingly.
144 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
145 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
146 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
148 2004-07-21 Jean-Pierre Roux
149 * FIX Now, Parsing and Printing a DICOMDIR do work!
150 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
152 2004-07-20 Jean-Pierre Roux
153 * FIX Some brain damaged headers have Zero-Lenght fields
154 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
156 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
157 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
158 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
159 variable (instance of gdcmDebug) by a definition macro, and the instance
160 is now in static in the gdcmDebug class
161 * src/gdcmSQItem.h : (FIXME) remove an undefined method
162 * Test/PrintAllDocument.cxx : bug fix in the result of the test
164 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
165 * WARNING: ctest now depends more tightly on gdcmData. You should
166 check out gdcmData properly for things to run smoothly...
167 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
168 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
169 we need the pixels not be loaded in order to use the ValEntry
170 that displays position and size).
171 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
172 This is a C++ based equivalent of gdcmPython/testSuite.py that should
173 be deprecated. If you have any doubts about the advantages of a
174 modern scripting language (read Python) versus grass root C++ (i.e.
175 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
176 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
177 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
178 Anyhow, consider documenting the gdcmData images in
179 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
181 * Test/CMakeLists.txt:
182 - now uses TestAllEntryVerify.cxx
183 - specific comments on oldACR00001.ima (now renamed in gdcmData
184 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
185 gdcmData/TestAllEntryVerifyReference.txt
188 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
189 * src/*.[h|cxx] : typedef clean up
190 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
191 - TagKey renamed to gdcmTagKey (for external usage)
192 - VRKey renamed to gdcmVRKey (for external usage)
193 - removal of typedef duplication.
194 - Removed all unecessary inline keyword from class inline definitions.
195 - Some method|function(void) declarations replaced with method|function().
196 * src/jpeg/libijg12/jdhuff12.c:
197 - printf polluting ctest removed.
198 - TAB removal for comminting
200 - TestAllReadCompareDicom.cxx: added a test that compares all the
201 images in gdcmDataImages.h with corresponding images in
202 gdcmData/BaselineDicom/. When baseline images are not present
203 this test creates them.
204 Note: we need to validate each reference image, but before that
205 I'd like to rename them with a more explicit name...
206 - CMakeLists.txt: changed accordingly.
207 * Example/*.cxx: examples now only include gdcm.h (as opposed to
208 including each header needed).
210 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * Test/*.cxx and Example/*.cxx: moved some examples away from the
212 test suite to the Example directory. Are concerned:
217 - TestWriteSimple.cxx
218 * Test/CMakeLists.txt: added some comments on reasons for black listing
219 image gdcmData/oldACR00001.ima
221 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
222 * Test/CmakeList.txt: removed the following from black list (to be coherent
223 with removal from gdcmData):
224 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
225 - gdcm-MR-PHILIPS-16.dcm
227 Added the following because after last cvs update, they cause
228 ctest -R TestReadWriteReadCompare
230 - gdcm-MR-SIEMENS-16-1.acr
232 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
233 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
234 new comments in this file) we temporarily (sigh) move to a weaker
236 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
237 we don't need to black list the following images anymore:
238 - 8BitsUncompressedColor.dcm
240 - US-PAL-8-10x-echo.dcm
241 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
242 fixes and the beautified code ;-)
243 This fixes the bug introduced in version 1.42 (when beautifying)
244 that made the parsing of 8BitsRunLengthColor.dcm unproper.
245 Note: ctest was blind to this bug (this means we need to still
246 improve the test suite). The bug could be detected by using
247 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
249 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
250 and by displaying the (garbage) produced file temp.XDCM...
252 2004-06-29 Jean-Pierre Roux
253 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
254 - replace by uggly but working old code :-(
255 A lot of things should be OK again.
256 It's really urgent to have a test suite that *tests*,
257 to prevent Frog's beautifying sessions to break all the stuff
258 (twice, withing a fortnigh ...)
260 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
262 redundancy) to added Test/TestReadWriteReadCompare.cxx
263 * Test/CmakeList.txt: because the compare test of
264 Test/TestReadWriteReadCompare.cxx fails, the following images are
265 black listed: - 8BitsUncompressedColor.dcm
267 - US-PAL-8-10x-echo.dcm
268 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
269 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
270 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
271 and ad-hoc kludge. This kludge is now removed, and on encountering
272 such an image (OB field brain damaged) we set errno. Then in
273 ::FindDocLength() we "fix" the length as being ALL what remains
274 in the file (until EOF). We then proceed, hoping for the best...
275 This fixes a SegFault in ShowDicom when trying to write such an
277 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
278 (because TestWriteRead breaks on it, after a non conformal commit?).
279 ctest now runs properly, except for MakeDicomDir (which was allways
280 broken) and the Python related stuff (still not fixed).
282 2004-06-24 Jean-Pierre Roux
283 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
284 FIX : Test/TestReadWrite now iterates on all the file names
285 (instead of infinite loop)
286 ENH : Test/TestWriteRead now iterates on all the file names
288 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
291 2004-06-24 Jean-Pierre Roux
292 FIX : - now Write drops LUT Descriptors and LUTs (if any)
293 when SamplesPerPixel =3
294 - now Write is no longer confused by
295 'BitsAllocated = 12" and 'BitsStored=12"
296 - "UN" value representation Elements are now written correctly
297 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
298 ENH : - now gdcmHeader has its own Write methods
299 (in order to split the job that has not to be done
302 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
304 loop on the same image until memory went out.
305 Note: this means we still have gobs of memory loss in PrintDocument
306 * src/gdcmDocument.cxx: fixes problem on parsing on file
307 gdcmData/16BitsJpegLosslessGrayScale.dcm.
309 2004-06-24 Jean-Pierre Roux
310 FIX : Write - All the Sequences and Sequence Item are now written
311 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
312 is added a the end, when necessary.
313 - A lot of brain-damaged images, that were read correctly are
314 now written correctly
315 - length compatible BinEntry are now loaded correctly
316 (even for odd groups)
317 Note : only Explicit Value Representation was checked.
318 (question : is implicit VR really necessary for gdcm ?)
320 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * DEVELOPPER: added a proposition of coding style.
322 * src/gdcmDocEntry.h: removed every inline declaration (for test of
325 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
327 Use the gdcmDocEntry::Print() and Write() instead.
328 * src/gdcmDocument.cxx: bug fix.
330 2004-06-22 Jean-Pierre Roux
331 FIX : gdcmDocument.cxx
332 - Now we do recognize the JpegLossLess format (there was a misstyping in
333 code 'beautyfication' :-(
334 - Now we automaticaticaly load the Luts, if any
336 2004-06-22 Jean-Pierre Roux
337 In order : to write Sequences, whatever their imbrication level,
338 : to allow user to create his own Sequences
339 a lot of modif where necessary (adding, moving, or virtualising methods)
341 WARNING : save your own sources *before* cvs up !
344 ADD virtual void Write(FILE *fp, FileType filetype);
347 ADD virtual void Write(FILE *fp, FileType filetype);
348 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
351 ADD virtual void Write (FILE *fp, FileType filetype)=0;
352 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
353 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
354 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
355 ADD std::string GetEntryByName(TagName name);
356 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
358 std::string vr = "unkn",
359 std::string fourth = "unkn",
360 std::string name = "unkn");
361 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
362 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
363 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
364 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
365 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
366 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
367 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
368 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
371 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
372 ADD virtual std::string GetEntryByName (TagName tagName);
373 ADD virtual std::string GetEntryVRByName (TagName tagName);
374 REM virtual bool Write(FILE *, FileType);
375 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
376 FILE *_fp, FileType type);
377 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
378 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
379 REM virtual bool WriteEntries(FILE *_fp,FileType type);
380 REM virtual std::string GetEntryByName (std::string tagName);
381 REM virtual std::string GetEntryVRByName (std::string tagName);
382 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
383 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
384 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
386 std::string vr = "unkn",
387 std::string fourth = "unkn",
388 std::string name = "unkn");
389 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
390 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
391 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
392 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
395 ADD virtual void Write(FILE *fp, FileType filetype);
398 ADD virtual void Write(FILE *fp,FileType filetype);
401 ADD virtual void Write(FILE *fp, FileType filetype);
402 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
403 REM std::string GetEntryByNumber(guint16 group, guint16 element);
404 REM std::string GetEntryByName(TagName name);
407 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
409 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
410 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
411 The default constructor invoked by the line
412 gdcmHeader *f1 = new gdcmHeader( header );
413 was gdcmHeader::gdcmHeader(bool) instead of the expected
414 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
415 Hence the parsing wasn't executed... See also below.
416 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
417 as explicit constructor didn't do the trick to fix the above problem.
418 Could anyone explain why ?
419 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
420 properly calls gdcmValEntry::Print() (that was weed out from
421 code related to gdcmBinEntry).
423 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
424 * In order to fix memory leaks:
425 - Test/TestWriteSimple.cxx: added cleaning of free store through
427 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
428 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
429 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
430 (through the call to ::AddDicomDirMeta()) or the destructor
431 would crash when deleting uninitialized ::metaElems].
432 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
433 - src/gdcmDocument.cxx:
434 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
436 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
437 was causing memory leaks.
438 - src/gdcmSQItem.cxx:
439 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
440 cleanly handled with polymophism: sorry but my milage is low).
441 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
442 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
443 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
444 This avoids SegFaulting.
445 - src/gdcmSQItem.h: coding style.
447 - Test/TestWriteSimple still severely sucks. The output image content
448 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
449 damaged when displayed with vtkgdcmViewer.
450 - on memory leaks: TestWriteSimple leaks really less (see entry
451 of 2004-06-18 in Changelog file for the call to valgrind).
452 - on segfaults: ctest now passes all the tests but one (no more
454 * Erroneous leading white fix:
455 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
456 white[s] (as opposed to from >> xxx, that removes it [them].
457 - src/gdcmTS.cxx: ditto.
458 - gdcmPython/testSuite.py: dirty related kludge removed.
459 * src/*: remaining references to gdcmParser removed.
460 * src/*[cxx|h]: added copy[way]left header.
463 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * In order to fix writing of dicom files:
465 - Test/TestWriteSimple.cxx: a simpler example of writing.
466 - Test/CMakeLists.txt changed accordingly.
467 - src/gdcmDocument.cxx:
468 -- The destructor now recursilvely removes potential sequences.
469 -- Bug fix in ::IsJPEG2000()
470 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
471 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
473 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
474 to only declared) and build on top of
475 ::GetDocEntryByNumber(guint16, guint16).
476 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
477 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
478 for usage in destructor and treatement of promotion in
479 ::ReplaceOrCreateByNumber().
480 - src/gdcmSQItem.cxx: destructor should better handle his job.
481 Test/TestWriteSimple now runs (or at least it DOES something).
482 * We can now start hutting memory links. A good starting point is:
483 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
484 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
485 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
487 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * Valgrind note: after Mathieu Malaterre teached me how to read
489 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
491 Using gcc, you can force the STL to use malloc and to free memory as
492 soon as possible by globally disabling memory caching.
493 With 3.2.2 and later, you should export the environment variable
494 GLIBCPP_FORCE_NEW before running your program.
495 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
496 simply vanish (it is still not clear to me, whether this means that
497 STL std::string leaks or if valgrind believes it leaks...).
498 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
499 running bin/gdcmTests makeDicomDir):
500 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
501 - Test/makeDicomDir.cxx now properly traps empty lists and returns
503 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
504 SegFaulting (I drowned in DicomDir related code when trying to
505 understand why the list is empty...).
506 * src/gdcmDocument.h: first BSD license header try.
507 * Doc/License.txt added.
509 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
510 * src/gdcmDocument.[h|cxx]:
511 - Clean up of the Transfer related predicates. They are now all based
512 on new method isGivenTransferSyntax, that (should) handle properly
514 - general clean up, simplification, and coding style.
515 - Specific clean up of Parse7FE0() (umproperly named actually).
516 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
518 2004-06-14 Jean-Pierre Roux
520 - fix the display of Sequence Delimitor (SQDepthLevel pb)
521 - fix the display of SQItem ordinal number
522 - add the GetSQItemByOrdinalNumber method
523 - remove some useless never written private methods
525 2004-06-14 Jean-Pierre Roux
527 - adding a constructor taking a gdcmDocEntry as an input param
528 - ReplaceOrCreateByNumber now returns :
529 a gdcmBinEntry * if a Binary (void *) value is passed as a param
530 a gdcmValEntry * if a string value is passed as a param
532 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
533 according to the param type (no longer sets a gdcmDocEntry)
534 - GetValEntryByNumber, GetBinEntryByNumber added
535 - NewValEntryByNumber and NewBinEntryByNumber added
537 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
539 - GetSQItemNumber and SetSQItemNumber added, to provide
540 a (relative) Item identier inside a given Sequence
541 \warning : some pb remaining around this number
543 - AddEntry now takes the Item Number as a param
545 - adding a constructor taking a gdcmDocEntry as an input param
547 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * Memory leak hunt with the following command:
549 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
550 --show-reachable=yes gdcmTests PrintDocument
551 It looks like many (all?) leaks are due to the STL (or a bad usage
552 of the STL. The lines producing the leaks now have a comment with
553 a "MEMORY LEAK" tag: you can retrieve them with
554 grep "MEMORY LEAK" src/*
555 Here are two typical examples which I can't help fixing:
560 char * test = "babo";
561 name = test; //// <--- valgrind detects 960 bytes lost in
562 //// call to std::string::operator=(char const*)
563 name.clear(); //// Doesn't help !
571 std::cout << "Type a bunch of characters followed by RETURN: ";
572 getline(std::cin, line); //// <--- valgrind dectects a loss
573 //// of 1320 bytes in call to
574 /// std::basic_istream<>& std::getline<>
580 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * src/gdcmHeader.[cxx|h]:
582 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
583 and related, moved away to gdcmDocument.
584 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
585 the corresponding protected accessors of inherited class
586 gdcmDocument, removed ! As a consequence gdcmFile had to be
587 declared friend of class gdcmDocument (see below).
588 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
589 - Clean up of undefined or unused methods.
590 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
591 account the changes to gdcmHeader.h).
592 * src/gdcmDocument.h:
593 - gdcmFile is now a friend class (in order to take into account the
594 changes to gdcmHeader.h).
595 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
596 (see changes to gdcmHeader.h).
597 - Accessors (reading on the form GetEntry*) are now public.
598 - Clean up of undefined or unused methods.
599 * src/gdcmDocument.cxx:
600 - adaptation to changes to gdcmDocument.h
601 - ::OpenFile now writes a verbose message when file cannot be opened.
602 - some std::string properly set to VRKey
603 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
604 references to gdcmDocument.
605 * Test/TestFindTags.cxx: changed accordingly to above changes.
606 * gdcmPython/testSuite.py: adapted to renaming of acr files in
607 cvs repository gdcmData.
609 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
610 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
611 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
612 conflicts with gdcmValEntry::voidArea.
613 * src/gdcmValEntry.cxx: unmatching comment wiped out.
614 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
615 Value representation between StringRepresentable and BinaryRepresentable.
616 * src/gdcmDocument.cxx:
617 - method ParseDES: proper indentation restored and usage of
618 gdcmVR::IsVROfGdcmStringRepresentable wired in.
619 - method LoadDocEntry: the fingerprint left in the SetValue() of
620 unloaded entries (length > MaxSizeLoadEntry) had curiously been
621 removed. Reverting to previous code segment with the proper
622 dynamic_cast< gdcmValEntry* >.
623 Note: this was (partially) breaking the python test suite
624 (gdcmPython/testSuite.py) that made usage of the above
625 fingerprint to check presence of "Pixel Data".
626 * src/gdcmDocEntry.h: coding style.
627 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
628 now taken into account.
629 * gdcmPython/gdcm.i: adaptation to the new internal representation
630 of gdcm (exit gdcmParser, hello gdcmDocument).
631 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
633 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
634 anymore, but instead prints the loaded Python dictionary.
635 * .... alas, the python testSuite is still broken.
637 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
640 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
641 * src/gdcmUtil.h : export methods
643 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
644 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
646 * Initial addition of automatic python testing
647 * Initial addition of automatic image comparison
649 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
650 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
651 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
653 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
654 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
655 * Test/ShowDicom.cxx : bug fix for msvc compilation
656 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
658 2004-05-04 Jean-Pierre Roux
659 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
660 new concepts (and new classes) :
661 a 'gdcmDocument' is composed of a set of Doc Entries, that are
662 - elementary gdcmDocEntries (former gdcmHeaderEntries)
663 - Sequence Doc Entries (gdcmSeqEntries)
664 a Sequence is composed of Items.
665 Each item is a set of Doc Entries (this is recursive)
666 The non uniqueness of the 'Dicom tag' is due to this recursivity
667 (never taken into account)
668 Our unability to add a new 'entry' in the header
669 at the proper location (neither in the H-Table (map or multimap),
670 nor in the Chained List is also due to this recursivity.
671 Don't try, right now, to use/modify/compile these new sources :
673 We just commit all the stuff, 'as is', in order not to loose it.
675 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
676 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
678 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
680 file prefix (SetFilePrefix)
682 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
683 * Add a new test: ShowDicom, for now this is just the c++ version of
684 checkRead.sh, later it will be able to compare the image read against a
686 * Replace the DEBUG on the stack with a global entry in cmake interface:
687 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
689 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
690 * Add an example subdir, with a real example on how to read + write a
693 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
695 * Doc/CMakeLists.txt: the main page is now properly differentiated
696 between the developper and user version.
697 * Doc/doxygen.config.in: dropped search related obsolete flags
698 * src/gdcmParser.h, gdcmHeader.h: doxygenation
700 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * DEVELOPPER: added some helpfull comments for compile/test/install
704 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
705 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
706 src directory, now generated in the build dir.
707 2. Tests as mentionned smarter
709 4. Add a new method in gdcmDict that return the PubDict by name
710 this is interesting for 3rd party lib like ITK,
711 where we could set the institution name / patient name...
713 * ENH: 1. Now the test suite is working for real
714 2. All binaries are now output in the gdcm-bin directory
715 (this was not true before)
717 2004-04-28 Jean-Pierre Roux
718 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
719 SeQuence indented printing of Dicom Header.
720 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
721 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
722 Computation of SQDepthLevel is now part of gdcmHeader constructor
723 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
724 tree-like structure of a Dicom Header.
725 * FIX Test code cleaning
727 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
728 * ENH: Adding automatic testing
729 1. Need a DartConfig.cmake to submit to public
730 2. Add a test driver gdcmTest.cxx
731 3. gdcmTestMain, an helper for the main test driver gdcmTest
732 4. Files in Test don't have a main anymore, this becomes interesting
733 when we add more and more tests, thus dsw don't have to load
735 * ENH: Adding a GDCM_DATA_ROOT for testing
736 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
737 one file instead of seven + some small cleanup
739 2004-04-22 Jean-Pierre Roux
740 * ENH Minor changes to the Print() methods.
741 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
742 Header printing. Example given with :
743 > PrintHeader fileName 2 new
744 (SQ based tree-like structure still to be done for the Header ...)
746 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
747 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
748 1. I have added some unsigned where needed
749 2. Some function parameter not used -> (void)
750 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
751 4. g++ don't like character '\' in comment
752 5. #define jpeg_create_decompress jCreaDecompress
753 this really need to be fixed
754 6. virtualize destructor of gdcmObject ... leakage
755 7. sscanf(g->first.c_str(),"%x",&gr_bid);
756 this also really need to be fixed
757 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
758 remove compression file
759 (as we only do decompression, right ?)
760 * ENH: Change malloc/calloc/free with c++ equivalent
762 2004-04-21 Jean-Pierre Roux
763 * FIX gdcmHeaderHelper::GetXSpacing
764 when a single value is found (bug ?), xpacing is now
765 defaulted to yspacing
767 2004-04-19 Jean-Pierre Roux
768 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
769 * ENH add parameters :
770 bool exception_on_error = false,
771 bool enable_sequences = false,
772 bool ignore_shadow = false
773 to the gdcmFile constructors to be full gdcmParser compliant
774 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
775 to allow reading of PAPYRUS 3.0 files
777 2004-04-06 Jean-Pierre Roux
778 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
780 2004-04-02 Jean-Pierre Roux
781 * ADD : Test/checksequence.sh, for a general recap on SQ pb
782 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
783 for Philips spurious Tag fffe|0000 while rewritting Dicom files
785 2004-03-30 Jean-Pierre Roux
786 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
787 for ACR file, written out as DICOM files (hope so...)
789 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
791 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
792 moved to base class gdcmParser and only the specialisation is kept
794 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
795 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
796 already does the job.
797 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
798 (to be consistent with gdcmParser::WriteEntries).
800 2004-03-30 Benoit Regrain
801 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
802 upate of the object's instance. It's passed to 2 in the unfavorable
803 case : one in the ExecuteInformation, one in the ExecuteData
805 2004-03-29 Jean-Pierre Roux
806 * ENH : Check on file type to be written moved
807 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
808 * FIX : gdcmObject::ResetBoundaries now stops properly
809 when end-of-list is reached
810 : gdcmVersion modified (as Benoit Regrain asked)
812 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
814 * src/gdcmUtil.cxx: added forgotten iostream include.
815 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
816 equivalent to ExplicitVR in existing code).
818 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
819 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
820 now contains all the gdcmGlobal related code.
821 * minor coding style and doxygenation changes.
823 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
825 now contains all the Debug related code.
826 * minor clean-up of includes in src/*.cxx
827 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
828 CreateCleanString) removed.
829 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
830 * Doc/DoxyMainPageUser.txt added.
831 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
832 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
835 2004-03-24 Jean-Pierre Roux
836 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
838 2004-03-23 Jean-Pierre Roux
839 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
840 big endian made volumes
841 * ENH Now gdcmParser constructor and destructor are protected to forbid
842 end user to instanciate class gdcmParser
843 (only gdcmHeader and gdcmDicomDir are meaningfull)
845 2004-03-22 Benoit Regrain
846 * FIX : src/gdcmDicomDir.cxx : make windows compilable
847 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
848 gdcmSerie to gdcmDicomDirSerie
850 2004-03-19 Jean-Pierre Roux
851 * ENH Now the tree-like structure describing a DICOMDIR comming from
852 an already existing DICOMDIR file is consistent with
853 the home-made tree-like structure build ex-nihilo
854 or build from the files held (recursively) in a Directory
855 functions gdcmDicomDir::CheckBoundaries()
856 gdcmObject::SetBoundaries() added
858 2004-03-17 Jean-Pierre Roux
859 * REM (Eric Boix bug) : removal of meaningless
860 gdcmDicomDirImage::NewImage function.
861 * FIX now file names and directory name are written properly in the
863 * FIX now gdcmDicomDir constructor may be call without any trick
866 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
868 of gdcmDicomDirImage::NewImage as empty function.
870 2004-02-28 Jean-Pierre Roux
871 * ENH add gdcmDicomDir:NewPatient
872 add gdcmDicomDirPatient:NewStudy
873 add gdcmDicomDirStudy:NewSerie
874 add gdcmDicomDirSerie:NewImage
875 to allow making gdcDicomDir object.
876 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
877 (as opposite to the gdcmHeader chained list)
879 2004-02-11 Benoit Regrain
880 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
881 when using from python
883 2004-02-10 Benoit Regrain
884 * FIX : bug fix in the gdcmDirList for the recursivity in directories
885 * FIX : in gdcmDicomDir when the directory is empty
886 * ENH : add callback and methods to get the progression of dicomDir
889 2004-02-06 Jean-Pierre Roux
890 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
891 - GDCM_META added to gdcmDicomDirType
892 - class gdcmMeta created
893 * ENH : - A brief summary is now displayed at the beginning of
894 'testDicomDir' to help disaster magnitude estimation
895 * REM : Now useless Test/explDICOMDIR.cxx
897 2004-02-05 Benoit Regrain
898 * ENH : add methods in gdcmObject to get the hash table or the list of
900 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
901 * FIX : wrapping python for TagHeaderEntryHT
903 2004-02-04 Benoit Regrain
904 * FIX : even length for some strings when writting the dicom dir
905 * FIX : sort the images in the dicom dir
906 * FIX : Bug fix for python use of dicom dir
907 * ADD : a python demo
909 2004-02-04 Jean-Pierre Roux
910 * FIX : Final solution (?) for icone embedded images
911 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
912 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
913 add groups 6002, 6004, 6006, to allow 'clean' parsing of
914 gdcmData/gdcm-MR-SIEMENS-16.acr1
915 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
916 to make full checking easier
918 2004-02-04 Benoit Regrain
919 * FIX : WriteEntries : coding style & logic in parameters
920 * FIX : Set the elements to create the DicomDir in a dictionary file
922 2004-02-03 Benoit Regrain
923 * gdcmDirList : to parse a hard drive directory in recursive (or not)
924 * gdcmDicomDir : add the load of directory
925 * Bug fix and print add-on
927 2004-02-03 Jean-Pierre Roux
928 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
929 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
930 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
931 * FIX gdcmParser.cxx : 'group length' elements are now considered
932 as integers, even for shadow groups, when file is Implicit VR
934 2004-02-02 Jean-Pierre Roux
935 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
937 of the last synonym :-(
938 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
940 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
941 * FIX taking into account the possible 7fe0,0010 multiplicity
942 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
943 to allow removal of references to 7fe0,0010, to deal with
944 ACR-NEMA images, when 0028,0200 is meaningfull
946 2004-01-31 Jean-Pierre Roux
947 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
948 no longer writes 'Un' on disk
949 * FIX SQ elements with actual length are now dealt with corectly
950 * FIX gdcmFile::WriteBase make the difference, for color images, between
951 the length (for Palette expanded images)
952 and Raw Length (non expanded image + Palette)
953 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
954 (that broke Write). Replaced by UL.
955 Aware user will reload the field if he
956 thinks it's necesssary
958 2004-01-30 Jean-Pierre Roux
959 * gdcmParser::CheckSwap() now defaults the filetype to ACR
960 when 'dirty Acr' is found, to be compliant with the new
961 IsReadable() methods.
963 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
964 (no DOUBLE images in kosher DICOM,
965 but so usefull for people that miss them ;-)
967 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
968 DICOMDIR related utilities (not checked as Windoze compliant)
970 2004-01-28 Jean-Pierre Roux
971 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
973 2004-01-27 Jean-Pierre Roux
974 * gdcmParser constructor has a new boolean param,'ignore_shadow',
975 to allow skipping the shadow elements, to save memory space.
976 The TRUE value for this param has to be used
977 with a FALSE value for the 'enable_sequence' param.
978 ('public elements' may be embedded in 'shadow Sequences')
979 * gdcmHeader methods now deal with 'embedded icones images' in the header
980 (even when an 'icone image sequence' is announced by the
981 element (0x0088,0x0200), but there is NO icone at all ...
983 * gdcmHeader sometimes Image Location value doesn't follow
984 the supposed processor endianity (see gdcmData/cr172241.dcm).
987 * gdcmHeader add the method
988 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
989 to get *all* the Header Entries with the same tag.
990 GetHeaderEntrySameName is probabely *useless*
991 (no meaning : Name is *not* an identifier within the Dictionnary)
993 2004-01-26 Benoit Regrain
994 * Bug fix in the print of hexadecimal representations. Remove long fields
995 in the print and add a third level of print to print them
997 2004-01-23 Benoit Regrain
998 * Bug fix on field having a VR = 'UI'. Assume that is a string field
999 * Bug fix on test suite after remove the strip made on not string fields
1000 * Split the IsReadable method between gdcmParser which test that the file
1001 is dicom and gdcmHeader which test that it's an image file
1003 2004-01-22 Benoit Regrain
1004 * DicomDir : clean code, add methods, set variables in protected or private
1005 * gdcmUtil : bug fix for the clean string method
1007 2004-01-19 Benoit Regrain
1008 * Add the use of shadow dictionaries
1009 * bug fix and coding style
1011 2004-01-19 Benoit Regrain
1012 * src/gdcmFile.cxx : bug fix concerning the close of file
1013 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1014 * Add the update of header entries using the shadow library
1016 2004-01-19 Benoit Regrain
1017 * removal of file gdcmHeader2.cxx
1018 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1019 inheriting from gdcmParser. This split is to prepare the integration
1020 of dicom dir parsing
1021 * bug fix under python
1023 2004-01-16 Jean-Pierre Roux
1024 * REM removal of class gdcmHeaderEntrySet
1025 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1026 * ADD add file gdcmHeader2.cxx
1027 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1029 2004-01-15 Benoit Regrain
1030 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1031 entries created while parsing the header. Thus, they will be destroyed
1032 when the gdcmDictSet will be destroyed
1033 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1036 2004-01-15 Benoit Regrain
1037 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1038 made a fatal error because of the memory release at the end of program.
1039 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1040 some memory and vtk seems to have some problems with that.
1041 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1043 2004-01-14 Benoit Regrain
1044 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1045 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1046 * src/*.[h|cxx] : make changes due to class name changes
1047 * gdcmPython/demo/*.py : bug fix due to method names
1049 2004-01-13 Benoit Regrain
1050 * src/*.[h|cxx] : coding style
1051 * vtk/*.[h|cxx] : coding style
1053 2004-01-13 Benoit Regrain
1054 * gdcmPython/testSuite.py : test the readable flag of file for tests
1055 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1056 It's lied to the stl compilation by MSVC (windows, always windows...)
1057 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1059 2004-01-12 Benoit Regrain
1060 * src/*.h : add comments
1061 * src/gdcmDictSet.h : set the method BuildDictPath in public
1062 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1063 directly setted in the source code
1064 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1067 2004-01-09 Benoit Regrain
1068 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1069 * setup.py : use a reference to gdcmVERSION
1071 2004-01-07 Benoit Regrain
1072 * Modification to compile with the distutils.
1075 2003-12-10 Benoit Regrain
1076 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1077 can use a gdcmHeaderHelper to load datas
1078 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1079 made in the source code
1081 2003-12-10 Benoit Regrain
1082 * Update Windows projects and .cvsignore files
1084 2003-11-12 Jean-Pierre Roux
1085 * ENH gdcmHeader constructor has one more parameter (default value : false)
1086 that allows the user to 'go inside' the SeQuences only
1088 gdcmElValSet:Print takes it into account
1090 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1091 * ENH: Update gdcmPython/CMakeLists
1092 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1093 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1095 2003-11-10 Jean-Pierre Roux
1096 * FIX : gdcmHeader::LoadElements is now based
1097 on the ListTag listElem member,
1098 not longer on the TagElValueHT tagHt member
1099 * ENH : PrintPubElVal shows (temporarily) both results,
1100 with the tagHt member and the listElem member.
1101 (it's easier to 'see' the problems when using Printheader)
1103 * FIX : old private member LgrElem is now splitted into
1104 ReadLength : Length actually found on disk (updated only
1105 if bug fixing is necessary), for internal
1107 UsableLength : Updated by FixFoundLength, to fix a bug
1108 or to allow Parser going on.
1109 Will allow to re-write a kosher header when a SeQuence
1110 with a length (not 0000) is found
1111 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1112 because gdcmElValSet::Add does not update ListElem
1115 2003-11-07 Jean-Pierre Roux
1116 * FIX misstyping in Transfert Syntax name table
1117 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1118 when they have an actual length (not 0000 nor FFFFF)
1119 (Nobody should care of it, but DICOMDIR explorers)
1121 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1122 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1124 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1125 * ENH: vtkGdcmReader now supports LUT !
1126 (vtkgdcmViewer for now is not able to use them though)
1128 2003-11-05 Jean-Pierre Roux
1129 * in testSuite.py : new files names for checking the package
1130 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1131 that returns the pixel area size to the *aware* (vtk) user
1132 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1134 2003-11-05 Benoit Regrain
1135 * in testSuite.py : Modify the rules for checking the paths
1136 : Explicit error messages
1137 * in __init__.py : Related modif
1139 2003-11-03 Jean-Pierre Roux
1140 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1141 to be used by aware (vtk) users that want to manage
1142 LUT (and no to turn the PALETTE image into an RGB pixels one)
1143 * GetPixelType now returns 8U for 24 Bits images
1144 (vtkGdcmReader compliant)
1146 2003-10-31 Jean-Pierre Roux
1147 * Removal of *all* gdcmData images and add them again
1148 in order to loose the 'history' of un-anonymised images
1150 2003-10-31 Jean-Pierre Roux
1151 * RMV : removal of useless jBitsInJsample.h
1152 for both 8 and 12 Bits JPEG Lossy Libraries
1154 2003-10-31 Jean-Pierre Roux
1155 * ENH : Add the functions gdcmFile::GetImageDataRaw
1156 gdcmFile::GetImageDataIntoVectorRaw
1157 that act as GetImageData and GetImageDataIntoVector
1158 except the making of an RGB Plane from Gray Plane + LUT
1159 Intended to aware (vtk) users who know how to manage
1162 GetLUTRGBA return a R,G,B,A LUT if any
1163 lgrTotaleRaw gives the 'Raw' length
1164 GetImageDataRaw returns the gray Plane
1165 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1166 (They stay Grey, just like with other Dicom viewers :-(
1168 2003-10-30 Jean-Pierre Roux
1169 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1171 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1172 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1173 being coherents dicom files.
1175 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1176 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1178 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1179 * ENH: Two steps is necessary to please VC++ compiler...
1180 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1181 * ENH: Add include dir to medcon lib
1182 * FIX: only one function is being exported for now !
1183 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1185 2003-10-29 Jean-Pierre Roux
1186 * adding gdcmHeader::GetLUTRGBA
1187 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1188 --> Mathieu, the modif u're waiting for is not yet committed
1189 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1191 2003-10-27 Jean-Pierre Roux
1192 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1193 00191113.dcm DermaColorLossLess.dcm
1194 MxTwinLossLess.dcm RadBWLossLess.dcm
1195 * ENH: For version prior to vtkImageViewer2 -r 1.19
1196 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1198 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1199 * Removal of ido stuff in CMakeLists.txt
1201 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1202 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1203 * FIX: remove a call to ->Modified ... see comments
1204 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1206 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1207 * FIX: Problem with path for libvtkgdcmPython
1208 * ENH: Try adding a search script for python site-package
1209 * RMV: Remove some file from medcon lib that are not necessary
1210 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1211 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1212 * FIX: More pragma disable fro VC++,
1213 I don't think I break something as it is also disable in VTK/ITK.
1214 But it fasten debug compilation time.
1216 2003-10-23 Jean-Pierre Roux
1217 * gdcm now deals with 16 Bits Run Length Encoded images
1218 (they are compressed as 2 planes images,
1219 one for the high Bytes, the other for low Bytes)
1221 2003-10-22 Jean-Pierre Roux
1222 * Now CheckRead takes into account :
1223 - the bugged 'Leonardo' Siemens images
1224 - the XA images, sent thru the burning VPRO station
1225 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1228 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1229 * FIX: When copying a Makefile.am to CMakeLists.txt
1230 one should remove the '\'
1232 2003-10-22 Jean-Pierre Roux
1233 * in gdcmData adding a bugged 'Leonardo' Siemens image
1234 (wrong lengths in header)
1235 OK with gdcm, KO with the other viewers :-)
1236 * add a GE dlx XA image, thru the VEPRO burning station
1239 2003-10-21 Jean-Pierre Roux
1240 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1241 for a brutal checking of vtkgdcmViewer compliance
1243 2003-10-21 Jean-Pierre Roux
1244 * add the files for 'xmedcon' Jpeg Lossless library
1245 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1247 2003-10-21 Jean-Pierre Roux
1248 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1250 2003-10-21 Jean-Pierre Roux
1251 * garbage Siemens 'Leonardo' images dealt with
1252 (the patch is easy to remove)
1253 * cosmetic changes to avoid warnings
1255 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1256 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1257 no need to press 'r' now.
1259 2003-10-20 Jean-Pierre Roux
1260 * upgrade of checkRead.sh checkWrite.sh according
1261 to new Jpeg Lossless decompressor
1262 * add US.3405.1.dcm, a genuine RGB medical file ...
1263 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1264 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1266 2003-10-15 Jean-Pierre Roux
1267 * general anonymisation in gdcmData
1268 * adding the 'color files' from
1269 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1270 * adding some well knowed bugged-header images
1271 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1272 waiting for their inclusion in Python testsuite
1274 2003-10-15 Jean-Pierre Roux
1275 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1276 no longer seg faults when file is not found
1278 2003-10-14 Jean-Pierre Roux
1279 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1282 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1283 * TODO: *.in file to genereate a UseGDCM later
1285 2003-10-14 Jean-Pierre Roux
1286 * Some supposed-to-be Dicom Images have no preamble.
1287 OpenFile takes it into account
1288 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1289 * Missing elements added in dicomV3.dic
1290 (just to be affraid : have a look at
1291 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1292 and do it again next year ;->
1294 2003-10-13 Jean-Pierre Roux
1295 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1296 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1297 But there are NOT. It's fixed !
1299 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1300 * FIX: "jpeglib.h" was not found on VC++
1301 * FIX: vtkgdcm was not being installed
1303 2003-10-10 Jean-Pierre Roux
1304 * ENH : OpenFile closes the file if it *really* doesn't look like
1305 an ACR-NEMA / DICOM one.
1306 * FIX : testWrite no longer writes an empty file if the source file
1307 is not gdcm Readable
1308 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1311 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1312 * FIX: CMake generate now documentation
1313 * ENH: out of source doc build !
1314 * ENH: Generate both user and dev documentation
1315 * ENH: Should work on windows too
1316 * ENH: Only one doxygen config.in file is needed
1317 * FIX: make install should be ok now on ùnix plateform
1318 * FIX: PATH to dictionary was wrong (missing /)
1319 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1321 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * vtkGdcmReader is now able to read rgb dicom file.
1323 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1324 * added a gdcmViewer to vtk test, use mouse to control
1325 window level & window width
1327 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * CMake-ification of gdcm, we have now two build system
1329 * FIX: on cygwin Wsock32 doesn't exist
1330 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1332 2003-10-06 Emanuel Ollart
1333 * FIX : compilation process wad broken.
1334 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1336 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1337 * change gdcmViewer -> vtkgdcmViewer
1338 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1340 2003-10-06 Jean-Pierre Roux
1341 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1342 ( e.g : well known GE images with a wrong elem length,
1343 : Philips MRI Images with a wrong Huffman table)
1344 * still to be done : allow the reading of bugged LEONARDO Siemens images
1346 2003-10-03 Jean-Pierre Roux
1347 * Odd length strings are padded with '\0' (not with spaces,
1348 to remain compliant with already defined strings,
1349 like Transfert Syntax UID and others)
1351 2003-10-03 Jean-Pierre Roux
1352 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1353 to allow displaying RGB images (not only by affim ;-)
1355 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1356 * vtkGdcmReader is now able to read rgb dicom file.
1357 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1359 2003-10-03 Jean-Pierre Roux
1360 * A few nasty patches to allow the reading of a lot of nasty images
1361 ( e.g : well known GE images with a wrong elem length,
1362 : Philips MRI Images with a wrong Huffman table)
1363 * still to be done : allow the reading of bugged LEONARDO Siemens images
1365 2003-10-03 Jean-Pierre Roux
1366 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1368 2003-10-03 Jean-Pierre Roux
1369 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1370 to allow displaying RGB images (not only by affim ;-)
1372 2003-10-03 Jean-Pierre Roux
1373 * gdcmFile::GetImageDataIntoVector now
1374 - deals with MultiFrames MultiFragments Run Length Encoded files
1375 - deals with YcBcR (YBR_FULL) files
1376 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1377 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1379 (no sample found :-(
1381 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1382 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1383 Two reasons: - clear things
1384 - third parties acces gdcm through header files, so won't
1385 suffer anymore VC++ complains
1387 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1388 * add argv[1] in testvtkGdcmReader.cxx
1391 2003-09-24 Jean-Pierre Roux
1392 * The lines are now eigthy characters long.for
1393 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1395 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1396 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1397 char* to std::string. Thus, the use of strdup becomes useless. (see
1398 previous commis of Malaterre)
1399 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1400 before the last Malaterre's commit.
1402 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1403 * This commit should fix the Debug building under VC++, the problem
1404 was mainly a mixture of debug and release lib being loaded at startup.
1405 * I also remove a depency to a specific C function: strdup. Because I had
1406 to force the link to msvcrtd (whereas strdup is in libc).
1408 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1409 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1410 located in the gdcmCommon.h file. All use of reference of tha has been
1411 changed to now use the variable GDCM_UNFOUND.
1413 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1415 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1416 Dicom dictionary. The test suite can now be run again. Note:
1417 I'm note very happy with the " (RET)" changes. I believe this
1418 RETAINED comment should be dropped when parsing the dictionary.
1419 - PACKAGER corrected
1421 - AUTHORS updated and now in alphabetical order
1422 * Makefile.am now exports gdcm.dsw for Windoze users.
1424 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1425 * cygwin complains about missing std:: in subdir Test/
1427 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * remove some methods that are now in gdcmHeaderHelper
1430 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1431 * vtkGdcmReader set spacing and origin correctly
1433 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1434 * Fix a few delete/delete[] mismatch
1436 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1438 interpretation to data given by gdcmHeader. For instance there are
1439 heuristics to get informations (look at different places).
1440 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1441 sorting DICOM images based on different strategies.
1442 * modified Makefiles accordingly.
1444 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1446 when building in debug mode
1447 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1448 src/win32/gdcmdll.dsp
1449 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1451 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1452 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1455 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1456 * src/win32/libgdcmjpeg12.dsp was not dos format
1457 * src/win32/libgdcmjpeg12.dsp :
1458 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1459 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1461 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1462 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1464 * src/gdcmFile.cxx : bug fix in affectation type
1465 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1466 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1467 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1468 symbols... future problem ?
1470 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1471 * src/win32/libgdcmijpeg12.dsp was missing
1472 * modified gdcm.dsw accordingly
1474 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1477 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1478 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1479 commit of JPR (before his hollidays to facilitate our work).
1480 * setup.py : bug fix in code. Modifications made while the last commit
1481 of JPR. The code hasn't been tested before the commit... it's so
1482 useless to make that (for best programmer that is JPR) !!!
1484 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * tagged the current version as Version0_3 (i.e. version 0.3)
1487 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1488 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1489 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1490 * *.dsp : modifications to use new libgdcmijpeg8 library
1491 * setup.py : bug fix on VTKPATH variable
1492 * PACKAGER : adding all concerning windows
1494 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1495 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1497 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1498 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1499 test suite reported error.
1500 * PACKAGER file added (describes what a packager must do when
1501 packaging a new release).
1502 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1503 * configure.in: upgraded version number to 0.3.0
1504 * fixing build of rpm (through rpm -ta):
1505 - Doc/Makefile.am exports proper doxygen files
1506 - src/jpeg/libijg8/Makefile.am exports the include files.
1508 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1509 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1510 * src/gdcmHeader.h : formatting code
1512 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1514 We were obtaining error message from vtk. Now, creation of file list
1515 is made in an internal list to prevent this problem.
1516 Bug fix when output is empty.
1517 Bug fix in update of progress value. Previous commit for this was a bad
1519 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1521 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1522 * src/gdcmHeader.h : added method to get the file name
1523 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1524 files. Added method to remove all files on the input
1525 Added FIXME comment concerning the bad parsing of header made by
1526 ExecuteInformation method (in ExecuteData method)
1528 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1529 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1530 when using make instal.
1531 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1532 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1534 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1535 * setup.py : adding include dir of jpeg lib to compile all sources
1536 * */Win32/*.dsp : JPR fix for windows compilation
1538 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1539 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1541 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1542 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1544 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * setup.py is again effective on un*x (takes into account the
1546 addon of the jpeg library)
1547 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1548 * Doc/Doxy* updated (includes above enhancements)
1549 * INSTALL now points to web documentation
1551 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1552 * src/gdcmHeader.h doesn't make unnecessary reference to
1554 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1556 * src/gdcm*.[cxx|h] :
1557 - to allow compilation with gcc 3.x
1558 -- clean up of STL usage (added explicit usage of std::)
1559 -- small fixes on exceptions.
1560 Note: linking not tested !
1561 - clean of doxygen comments to avoid warnings at documentation
1563 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1564 dependent convertion).
1566 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * Clean up of previous JPR garbage commit (not even commented in the
1569 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1570 - moved all jpeg related files from src to src/jpeg/libijg8, with
1571 addition/modification of Makefile.am and configure.in.
1572 - the testSuite is still brain damage (not guilty).
1574 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1575 * WrapVTK.py : modifications to get correctly vtk source files to
1577 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1578 (FileName -> Filename)
1580 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1581 * vtk/vtkGdcmReader.[cxx/h]:
1582 - UpdateProgress method should now be effective
1583 - removed the limitation on having only images loaded (as opposed
1585 - when building a stack of images/volume, a lesser number of
1586 gdcmHeader and gdcmFile instances should be used (hopefully
1587 accelerating things).
1588 - when building a stack of images/volumes, files which are not
1589 loadable (wrong path-filename, wrong permissions on existing file,
1590 or file not parsable by gdcm) are replaced with a black image
1591 in the stack (for the caller to notice the problem).
1593 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1594 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1596 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1597 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1598 between standard library (std) and vtk library (problems are found
1599 under Windows... thanks Windows !)
1601 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1602 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1604 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1606 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1607 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1609 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1610 * When compiling with distutils (see setup.py) the C++ compiler is
1611 called with different flags than the default ones (with automake).
1612 In order to fix all those warning, I compiled gdcm with the command
1613 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1614 and went for warning fixes:
1615 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1616 up from unused variables.
1617 - vtk/vtkGdcmReader.cxx: potential bug fix.
1618 * src/gdcmHeader.h: Doxygen warning cleanup
1620 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1621 * gdcmPython/gdcm.i:
1622 - typemaps correction to take into account the systematic replacement
1623 of "using namespace std" with std:: prefix e.g. std::list,
1624 std::string... (cf changes of 2003-05-21).
1625 - gdcmGlob global variable of type gdcmGlobal (defined in
1626 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1627 exported to Python a as cvar.
1628 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1629 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1630 gdcmDictSet.GetPubDictTagNames() and
1631 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1632 C++ static methods).
1633 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1634 with the above changes.
1636 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1637 * setup.py, manifest.in : bug fix under linux
1639 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1640 * Modification of setup.py to compile vtk part too. Then, we have 2
1641 wrappers which must work with same distutils. For that, we have a
1642 generic distutils in distusiltsWrapping.py ; with :
1643 - build_extWrap class to wrap generically all extensions,
1644 - ExtensionWrap base class for all wrapping extension that contains
1646 - Wrapper interface which wrap sources
1647 + In WrapSwig.py we have extension and wrapper for Swig
1648 + In WrapVTK.py we have extension and wrapper for VTK
1649 * MANIFEST.in : modifications to consider vtk directory and new python
1650 files for compilation
1652 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1653 * Added python wrappers of vtkGdcmReader vtk class (see the
1654 source in vtk/vtkGdcmReader.cxx) :
1655 - vtk/Makefile.am now builds a library
1656 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1657 python library (as opposed to _gdcm.so wich are the python
1658 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1659 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1661 - configure.in has an additional flag --enable-vtk that needs
1662 to be set to enable compilation of vtk related code, that is:
1663 + vtk/vtkGdcmReader.so and
1664 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1665 + gdcmPython/vtkgdcmPython.so (see above)
1666 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1667 be read when compressed or when HighBit + 1 != BitsStored),
1668 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1669 the usage of the python wrapper of vtkGdcmReader vtk class.
1670 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1671 * src/*.[h] all occurences of stl classes are now prefixed with
1672 std::, and all occurences of "using namespace std;" where removed.
1673 This is to avoid pollution of global namespace in included files.
1674 Apparently vtk does not avoid this pitfall: when using both
1675 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1676 collision of various stl members (principally cout...).
1677 * gdcmPython/testSuite.py now cleanly removes temprory generated
1679 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1680 comply with above changes)
1682 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1683 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1684 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1685 vtk data structure (an image Flip was required).
1686 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1687 * cosmetic changes in documentation.
1689 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1690 * src/gdcmHeader.cxx: the constructor no longer exits when an
1691 unexisting file is given as argument.
1692 * The subdirectory Data (containing all the images used for the
1693 test suite) is not part of this repository anymore. A new module
1694 containing those images is now available at
1695 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1696 with the name gdcmData.
1697 All the python scripts (including the package initialisation file
1698 gdcmPython/__init__.py) were adapated to take this change into
1699 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1701 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1702 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1703 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1704 demo of the usage of this class.
1705 Compilation of this vtk part is only done when using the --enable-vtk
1706 at configure (or autogen.sh) stage.
1708 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1709 * More memory link related corrections and documentation fixes.
1711 - maximum info is obtained with a command of the form:
1712 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1713 --show-reachable=yes PrintHeader
1714 - the remaining reachable blocks seem to come from the STL
1715 allocation scheme through the usage of map and list. It looks
1716 like this memory cannot be freed but it is not a memory leak
1717 (in fact further invocation to the STL would recollect the
1718 unused memory allthough it cannot explicitely be freed).
1719 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1720 of displaying an image parsed with gdcm and displayed with VTK.
1721 Note: some images don't seem to work e.g.
1722 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1723 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1724 Allthough this weakens the semantics, it is a ditch attempt to
1725 make gdcm more thread friendly.
1727 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1728 * Memory link hunt (by using valgrind through the command
1729 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1730 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1731 gdcmHeader::_dicom_vr.
1732 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1733 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1735 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1737 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1738 * src/Makefile.am now exports all the necessary include files at
1742 * UpdateGroupLength replaced by new one
1745 * UpdateGroupLength re-written using H-Table
1746 (named UpdateGroupLengthNew untill checks are over)
1748 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1749 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1750 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1752 - gdcmHeader::GetPubElValSet removed.
1753 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1754 UpdateGroupLength, WriteElements, Write.
1755 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1756 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1757 carried the same semantics.
1758 - src/gdcmHeaderIdo.cxx changed accordingly.
1759 - gdcmFile::WriteBase now regroups all the codes from previous
1760 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1761 - enum FileType moved to gdcmCommon.h
1762 * src/gdcmHeader.cxx AddDefault trashed
1763 * gdcmGetXSize added
1764 * getimageDataSize now calls gdcmGetXSize
1765 * Test/*.cxx changed to agree with above changes
1767 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1768 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1769 (to avoid double call by end user).
1770 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1771 by end user, since gdcmHeader::gdcmHeader now handles it.
1773 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1774 * gdcm/Doc many doxygen changes:
1775 - Doxyfile now has two different versions, DoxyfileUsers that generates
1776 the html.users end users oriented documentation and
1777 DoxyfileDeveloppers that generates the html.developper developper
1778 oriented documentation.
1779 - README changed accordingly
1780 - requirement.txt removed (old design info moved to TODO).
1781 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1782 DoxyMainPage.txt, DoxyPython.txt provide more information.
1783 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1784 be updated by simply regenerating the docs with doxygen and copying
1785 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1786 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1787 all the tests in the form "if (<map>.count() >1)" were removed.
1788 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1789 ill-formed documentation sections.
1790 * src/gdcmHeader.cxx: ditto
1792 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * setup.py fixed for un*x (needed macro for stdint.h)
1794 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1795 un*ces with sh-utils test utility.
1796 * gdcmPython/demo/test.py renamed to PrintHeader.py
1797 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1798 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1799 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1800 * src/gdcm*.cxx JPR's bad inclusion fixed.
1802 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1803 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1804 * gdcmPython/demo/test.py changed accordingly.
1806 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1807 * gdcmPython/Makefile.am fixed linking against libstdc++
1808 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1809 * Swig subdir (historical tests of swig version 1.3.17++) removed
1810 * Test/testChangeEntete.cxx some lines commented out in order to make
1812 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1813 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1815 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1816 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1817 hence the user doesn't need this explicit call.
1818 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1819 i.e. LoadElements() call removed.
1820 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1821 - src/Makefile.am declares the proper flag for g++.
1822 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1823 for adding user defined new tags.
1824 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1825 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1826 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1828 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1829 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1830 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1831 src/Makefile.am : the project should properly compile and install
1832 with the autotools, included the python wrappers part.
1833 * gdcm.spec.in : added a spec file for RPM packaging.
1835 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1836 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1838 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1840 to exported to the environement (see gdcmPython/testSuite.py
1842 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1843 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1844 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1845 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1846 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1848 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1849 * gdcmPython/__init__.py doesn't crash anymore when running in
1850 in InstallMode or PreInstallMode but with an environement given
1851 value of GDCM_DICT_PATH.
1852 * src/gdcmDictSet.[cxx/h] coding style.
1854 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1856 * src/gdcm.h general comments moved to TODO, and README
1857 * src/gdcm.h should now be seen as a user commodity (including it
1858 should suffice to fully use gdcm). It is nowhere including within
1859 any of the kernel files src/*.cxx and src/*.h.
1861 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1863 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1865 * src/gdcm*.cxx only include their corresponding include file
1866 (as opposed to gdcm.h)
1867 * gdcmPython/gdcm.i changed accordingly
1868 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1869 the autogen.sh generated "make snapshot" command to work.
1870 * autogen.sh removed history related references to crea package.
1872 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1873 * distutilsSwigCPlusPlus.py work around some swig portability
1876 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1878 was done in a last ditch attempt to get setup.py _really_
1879 operationnal. The python/gdcmPython layaout add the advantage
1880 of hidding away the python related distutils specific files
1881 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1882 Alas, the src directory was out of scope (i.e. it's relative
1883 position to setup.py was ../src) which made things impossible to
1884 handle (see previous version of python/setup.py). Crossing fingers...
1886 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * python/setup.py now works on Un*x. (harder than I thougth)
1888 * python/distutilsSwigCPlusPlus.py can now have include files
1889 among the list of sources.
1891 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1892 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1893 * modifications in MSVC projects
1895 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * As stated by the first lines of Test/ExceptionAndPython/README, it
1897 looks like we can move back to original usage of exception within
1898 src/gdcm* and hence remove the errno stuff that was introduced
1899 as a quick and dirty fixture of this problem (added to the TODO).
1900 * Doc/Doxyfile configuration file for Doxygen and corresponding
1901 README file for usage added.
1902 * Test/testWrite.cxx added. This new test comes from a split of
1903 test.cxx that is now reverted to its original purpous i.e.
1904 testing the proper parsing of a Dicom related file.
1905 testWrite.cxx concentrates on testing the IO part of gdcm.
1906 * Test/bug1.cxx (containing a bug on WIn32) added.
1907 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1908 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1909 whose purpose is to publish the content of the TagNames of the
1910 Dicom public dictionnary were not accessible without an
1911 instance of class gdcmHeader.
1912 - those methods are now static methods of gdcmDictSet and hence
1913 require no instances at all to be invocated.
1914 - within gdcmDictSet this change required to change some method
1915 to class methods (i.e. are now static) among which SetDictPath
1916 (renamed to BuildDictPath) and LoadDefaultPubDict.
1917 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1918 the above changes by calling the new method classes of gdcmDictSet.
1919 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1920 the above to be effective.
1921 * python/gdcmPython: in order to wrap properly the above changes
1922 for Python, swig version now needs to be > 1.3.17.
1923 * python/gdcmPython/Makefile fixed to adapt itself to new
1924 configure/make shema introduced by Johan Montagnat (thanks for the
1925 contribution). Alas this Makefile cannot be turned into a proper
1926 Makefile.am without some heavy changes in the configure.in
1927 (for python dectection).
1928 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1929 now avoids publishing the empty entries.
1931 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1932 * python/setup.py : bug fix concerning install under windows
1933 ExtraPath reused :-P
1934 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1936 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1937 * Dicts/dicomV3.dic : remove double spaces !!!
1938 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1939 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1942 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1944 method. Doxygenation.
1945 * src/gdcm.h clean up of JPR spurious comments.
1947 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * python/distutilsSwigCPlusPlus.py now properly collects the
1949 shadow classes generated by "swig -c++" (gdcm.py in our case)
1950 when using "python setup.py install".
1951 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1952 reexports the working classes.
1953 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1954 by the classical C errno scheme. This is to prevent an obscure
1955 behavior of the python wrappers when importing wxPython.wx prior
1956 to gdcmPython (which ended up in an abort call). An illustration
1957 of this oddity can be found in the Test/ExceptionAndPython
1958 subdir (see the README file). This problem probably due to
1959 an combination of g++ and dynamic loading.
1960 * added Test/ExceptionAndPython (see above)
1962 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * Changed the layout of the python part to avoid bloating main
1964 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1965 i.e. the distutils arsenal. All the python related stuff is
1966 again in a python subdir, but the package itself is now in
1968 * setup.py was cleaned up:
1969 - pythonIncludePath removed
1970 - python setup.py bdist target is now functional.
1971 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1972 collision with other packages). gdcmPython/demo/*.py changed
1975 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1976 * python subdir moved to gdcmPython (preparation of distutils packaging).
1977 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1978 distutils installer is operational.
1979 * - gdcmPython/__init__.py now properly loads the swig generated
1980 shadow classes (from gdcm.py).
1981 - gdcmPython/demo/*.py changed to import the package gdcmPython
1982 instead of gdcmPython/demo/load.py.
1983 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1985 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1987 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1988 entries within the associated public Dicom dictionary resp. the same
1989 information but sorted by the fourth field (PAT, IMG, DIR) of the
1991 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1992 are now in the "???" group.
1993 - python/gdcm.i changed accordingly,
1994 - python/demo/printGroupedPublicDict.py added, that gives an example
1995 of the above new functionalities in Python.
1997 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * src/gdcm.h, gdcmHeader.cxx:
1999 - historic references to glib's g_malloc and g_free (#defined)
2000 were definitively removed.
2001 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2002 * src/gdcmElValSet.cxx:
2003 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2004 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2005 - GetElValue(string) renamed to GetElValueByName.
2006 - Added GetElementByName(string).
2007 * src/gdcmHeader.cxx: added
2008 - GetPubElValRepByNumber(guint16, guint16)
2009 - GetPubElValRepByName(string)
2010 - GetShaElValRepByNumber(guint16, guint16)
2011 - GetShaElValRepByName(string)
2012 - GetShaElValByNumber(guint16, guint16)
2013 - GetShaElValRepByName(string)
2014 - GetElValRepByNumber(guint16, guint16)
2015 - GetElValRepByName(string)
2016 - GetElValByNumber(guint16, guint16)
2017 - GetElValRepByName(string)
2018 * Doc/requirements.txt added.
2020 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * Test/Makefile building now depends on the one of libgdcm.so
2022 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2023 pixel data) aware which enables finding the address (offset) of
2024 the pixel data of JPEG encoded DICOM files. This leaves only a single
2025 file in the testSuite whose pixel data address (offset) is unknown.
2026 * python/testSuite.py changed accordingly.
2028 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2029 * VC++ has some strong limitations when working with the STL, as stated
2030 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2031 "Also note that some STL containers (map, set, queue, list, deque)
2032 cannot be exported. [...]
2033 Some STL classes contain nested classes. These classes can not
2035 This is caused by a designed limitation that once a template
2036 class is instantiated, it can not be re-instantiated and
2038 Since our usage of map<> is ubiquitous in gdcm, this "designed
2039 limitation" of VC++ is a pitfall.
2040 Hence the Python wrappers of gdcm cannot be incrementally linked
2041 against the c++ dynamic library. The dirty but only workaround is
2042 to forget about incremental link of dynamic libraries and to generate
2043 the Python wrappers library with the inclusions of the underlying C++
2045 The following modifications concern this matter on Win32/VC++:
2046 - wrapping python correct with standalone wrapped dll (don't use separate
2047 dll under windows !!!!)
2048 - python21_d debug mode enabled (ask Frog how to use it :-)
2049 - NO problem with having an STL member of class for example string in C++
2050 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2051 - Python test of dcmlib in Python is ok under windows on a large set
2053 * removed glib references
2054 * typedef's inserted in gdcm.i for correct swig type management
2056 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * python/demo/*.py load.py extracted from test.py. Added explore.py
2058 that only displays required tags and testAll.py that parses all
2059 the files of the testsuite without using unittest.
2060 * python/testSuite.py other additional test on new files added.
2061 * Data/* new test files added accordingly to the testSuite.
2062 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2063 the vr in the file differs from the one of the dictionary.
2065 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2066 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2067 values, but limits itself to values which are below a user specified
2068 size (by default 1024 bytes).
2069 * python/gdcm.i : elements not loaded (because their size is above the
2070 user specified treshold) are exported with their TagKey as key of the
2071 python dictionary. This enables the testsuite to make some checks
2072 on the unloaded elements (since we have their offset and size).
2073 * python/testSuite.py
2074 - now tests for the existence and proper value of the pixel data
2075 - two new examples added.
2076 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2078 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2079 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2080 aware. See the strategy comments in gdcmHeader::FindeLength().
2081 * Test/test.cxx now accepts a filename as first argument.
2082 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2083 * python/testSuite.py changed to integrate test on above files.
2085 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2086 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2087 the vr was also RET.
2088 * python/testSuite.py more tests added.
2090 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * python/testSuite.py unittest test suite added (uses Data)
2092 * Data/* dcm and acr files for the test suite.
2093 * glib dependance removed from un*x version. We now use ISO C99
2094 7.18 Integer types (see stdint.h)
2095 - python/Makefile, src/Makefile src/gdcm.h
2096 * src/ when an explicit vr (like dicom files) suddenly poped an
2097 implicit element we use to mark the underlying DictEntry of the
2098 concerned ElValue with "Implicit". This strategy was damageable
2099 too the public or provite dictionaries, since some of their vr
2100 would be changed. Since Header::FindLength heavily relies on the
2101 detection by Header::FindVR of falsely explicit elements, I
2102 added an extra ImplicitVr member to ElValue (boolean).
2103 The rest of the changes we the necessary adaptations.
2105 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2108 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2110 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * Adaptation for porting to VC++:
2113 o forced to use std namespace (for string to be known)
2114 o all class use __declspec export style on WIN32
2115 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2116 (in stdlib.h on Win32 but in std:: for gcc)
2117 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2118 variable GDCM_DICT_PATH.
2119 * src/gdcmHeader.cxx verbose comments made discrete.
2121 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2122 * python/gdcm.i: added a typemap that converts a C++ hashing table
2123 to native Python dictionary.
2124 * python/demo/test.py:
2125 - now uses the native dictionary for exploration of gdcmHeader.
2126 - takes an optional filename argument (the file to parse).
2127 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2128 PubElVals hashing table.
2129 * Dicts/dicomV3.dic removed error prone trailing spaces.
2131 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * Python wrapping process moved away from src/Makefile to
2133 newly created python/Makefile (as well as gdcm.i)
2134 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2135 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2136 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2137 from the environement variable GDCM_DICT_PATH (when existing).
2138 * src/gdcmDict::GetTag bug fix.
2140 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * Straightforward temporary fixes for swig to build the python wrappers.
2142 src/Makefile now has a python working entry [by working we mean
2143 that we can import de shadow classes without errors].
2145 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * hashtest.cxx removed (since allready in Test)
2147 * src/gdcmlib.h renamed to src/gdcm.h
2148 * src/dcm.i renamed to src/gdcm.i
2149 * src/Makefile prepared for python wrapping
2151 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * src/gdcmHeader.cxx :
2153 - Parsing of header is now separated from loading of element values
2154 (see gdcmHeader::LoadElements).
2155 - general clean up of hopefully all file access (creation of
2156 ReadInt16 and ReadInt32)
2158 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2159 * src/gdcmHeader.cxx :
2160 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2162 - SetLgrElem renamed to SetLength
2163 - GetLgrElem renamed to GetLength
2164 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2165 * src/gdcmElValSet.cxx fixed both GetElValue methods
2166 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2167 due to IdoDude was cleaned out.
2169 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2171 concentrates on finding the value representation (when it exists).
2172 RecupLgr now only finds the element value length, and it avoids
2173 returning the unecessary skL (skipped length).
2174 Also, offsetCourant was simply removed (with taille_fich) since
2175 it was redundant with the File position internals (by using
2176 ftell and fseek). This also made skL (see above in RecupLgr) usage
2178 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2179 on the libido specificities which are handled through class
2181 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2184 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * Truckload of changes. Parsing of header is barely functional
2186 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2188 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * src/gdcmHeader.cxx many addons of low level methods
2191 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2192 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2193 and _IdDcmSWAP_LONG.
2195 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * This corresponds to all the changes decided at the meeting of
2197 May 23 2002. Needless to say we are running late...