1 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
5 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
8 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Test/ : accelerate tests (it's not very significant accelerations).
10 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
12 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * Testing/TestSequence.cxx : add test for sequences of images... test that
14 we have the same serie or the same study UID
16 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
19 * src/gdcmDict.h : remove commented code
20 * src/gdcmDocument.cxx : initialize values
21 * src/gdcmFile.cxx : bug fix when reading values
22 * gdcmPython/demo/ : change file names. Remove useless files
24 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmFile.cxx : remove the default array of initialization.
26 The static array contained pointers to non-static values (comming from
27 strings). To have coherences, when creating files, these values can't be
28 static. So, the array can't be static, too ! To simplify, the array have
29 been replaced by repeted lines to insert values in the File
31 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
33 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
35 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
36 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
37 (Dicom Element) into the Sequence Item
39 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/*.cxx : first parss to normalize file organisation
42 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * src/gdcmDirList.[h|cxx] : add method to find a directory
44 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
46 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
47 * Finish cleaning up my JPEG mess. Should be ok now.
48 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
49 contained within the RLE* class(doh!)
51 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
52 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
53 * SerieHeader::AddFileName() creates as many Coherent Files lists
54 (same Serie UID) as it founds different Serie UID
55 amongst the files instead of discarting any file
56 that doesn't match with the first one he found.
57 * SerieHeader::OrderGdcmFileList has now one parameter :
58 the Coherent Files list the user wants to sort
59 * SerieHeader::GetFirstCoherentFileList() |
60 * SerieHeader::GetLastCoherentFileList() | allow to parse
61 the set of Coherent Files lists
62 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
63 compatibility (it returns the *first* Coherent Files list,
64 since there was only one before)
65 * Test/TestSerieHeader gets gdcmData as a default root directory
67 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * Remove friend between DocEntry and File classes
69 * Remove friend between PixelReadConverter and RLEFramesInfo,
72 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
74 0002|0000. The value was incorrect.
76 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
79 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
80 * src/gdcmUtil.cxx : compilation fix on Win32
81 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
82 variable, to be easy found. Add methods to change the default UID.
83 Amelioration of the CreateUniqueUID to use the correct default UID.
84 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
87 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * Test/TestVR.cxx : fix memory leaks
90 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
91 * Rewrite the base 256 to base 10 conversion, using string operation only.
92 This allows us to get rid of the problematic 64bits integer type (does not
93 always exist on target platform).
95 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
96 * Add construct and destructor to class gdcm::Debug to close the debug file
98 * Don't let uset to open twice the same file
99 * gdcm has now an official UID prefix,
100 supplied by http://www.medicalconnections.co.uk
101 1.2.826.0.1.3680043.2.1143
102 (Thx to Mathieu for providing URL)
103 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
104 to be able to perform some more tests
105 * gdcm::ContentEntry : Contructors and Destructor are now protected,
106 in order to be sure no user will try to use them.
107 (at user level, only the children classes are meaningfull)
109 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * move RLEInfo & JPEGInfo from Document to File
112 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * FIX : remove so many friend between classes
115 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
117 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
119 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 In order to avoid missbehaviour :
121 . gdcm::DocEntry is now specialized in
122 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
123 - gdcm::ContentEntry (Dicom entry with a 'content')
124 . gdcm::ContentEntry is specialized in
125 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
126 characters value, or integers)
127 - gdcm::BinEntry (Dicom entry with a non strig representable value
128 (user hasn't any longer to thing about the precedence of his dynamic_casts)
130 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Test/VTKTest*.cxx : bug fix under linux
133 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
135 use with python. Some methods are moved from Document to ElementSet or
136 DocEntrySet. The equivalent methods to ElementSet have been added to
137 SQItem and are virtual in DocEntrySet. Methods that may have the same code
138 in SQItem and ElementSet is directly placed in DocEntrySet
140 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * Test/VTKTest*.cxx : remove the show variable in each test method because
142 it's useless (the viewer variable replace this variable)
144 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmDocument.cxx : bug fix on potential memory leak
146 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
147 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
148 Add ClearXxx methods to remove all the content of the list or map
149 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
151 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
152 * methods ReplaceOrCreate renamed as Insert
153 (nobody will be any longer confused by 'CreateOrReplace')
155 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * Grealty simplify the JPEg decompression, no need to differenciate based on
157 the JPEG possible type (with/without fragment, with/without multiple frame).
158 Everything is done throught the JPEG IO Suspension mechanism in IJG
160 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
161 * Stage 3 of normalization :
162 in order to avoid any missunderstanding while reading method names :
163 - All the methods xxxEntry now deal with dicom Entries
164 - Methods GetEntry splitted into
167 - Method SetEntry renamed as SetEntryValue
168 - Method SetEntryBinArea let as it was
170 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
171 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
172 - Position correctly the entry points for JPEG2000 and JPEG-LS
173 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
175 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
177 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
178 with other method names
179 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
180 * Test/TestDicomDirElement.cxx : add new test
182 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
184 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
185 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
186 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
187 So can't you use __int64 in ostream at all.
189 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * bug fix for compilation on MSVC6
191 * gdcmPython/gdcm.i : rename of classes missed
193 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
194 * Stage 2 of names normalization :
195 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
196 (easy to understand ...)
197 - gdcm::FileHelper replaces old class gdcm::File
199 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
201 type and not a string. So, there remove problems on the format of the
204 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
205 * Add Example/TestPapyrus.cxx
206 - reads a Papyrus file (gdcm::Header compliant),
207 - gets the pixels of all the images, using low level iterators
208 - writes an multiframes Dicom image.
209 (Just to show it's *possible* to do that)
210 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
213 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
214 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
215 Thus, DicomDirXXX are created with a flad that indicates if the created
216 object is empty or not (when not empty, the DicomDirElement is used to
219 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
220 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
221 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
223 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
224 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
226 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
228 Remove all access to the hash-tables or lists in the objects.
230 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
232 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
233 be complient with all the gdcm source code
235 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
239 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
243 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Test/ : rename VTK tests to have a best name for the tests
245 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
246 GetFirstEntry/GetNextEntry use
248 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
249 * In SerieHeader::ImagePositionPatientOrdering()
250 // a Dicom 'Serie' may contain scout views
251 // and images may have differents directions.
252 // -> More than one may have the same 'pos'
253 // Sorting has then NO meaning !
254 Thx to Eduardo Davila for reporting bug.
256 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
258 test. Now it's on image content and not on the resulting visualisation...
259 might solve the problem on linux when using the OpenGL drivers
261 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
262 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
263 DicomDirSerie, DicomDirImage
264 Dict, DictSet classes :
265 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
266 -remove InitTraversal method.
267 * UPD Test programs + Example programs
269 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
270 * remove useless and never updated keyword \ingroup
271 * Solve pb when structure (list, map, ...) is empty.
272 Thx to Benoit for reporting bug
274 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
275 * Taking into account of 'Transfer Syntax' value
276 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
279 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
280 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
281 is no memory access violation
282 * gdcmPython/demo : add python demos using VTK
284 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
285 * FIX 'Dictionnary' is now spelt 'Dictionary'
286 'wether' is now spelt 'whether'
287 'archieve' is now spelt 'archive' ;-)
289 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
290 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
291 related methods, in order not to expose internal mechanisms
294 * REM methods that exposed internal mechanisms :
295 DicomDir::GetDicomDirPatients()
296 DicomDirPatient::GetDicomDirStudies()
297 DicomDirStudy::GetDicomDirSeries()
298 DicomDirSerie::GetDicomDirImages()
299 * UPD Test programs :
303 * UPD Example program
305 * ADD DictSet methods
309 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
310 * Removed the Print/indent/default parameter mess. There is absolutely no
311 reason to have to methods, moreover with the second taking the ostream as
312 *SECOND* parameter. This was clearly a bad hack to get things compile.
314 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
315 * Complete rewrite of the GetMacAddress code. Now the code is *much*
316 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
317 Unfortunately the main code does not work on SunOS, thus provide a specific
318 code for this platform only (and Win32 of course). Since this seems to be
319 working, change CreateUniqueUID to use GetMACAddress instead of the
320 problematic GctestetIPAddress
322 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
323 * Unfortunately to be able to test gdcmDirList I had to break the API
324 a little. Now the class is not a std::list anymore but has a member
325 std::vector (more ITK compatible). Allow unit testing on Win32 and
328 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
329 * Update SerieHeader to take into account a Serie Instance UID to properly
332 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
333 * ENH - Comment out Mathieu's (dangerous) Super Hack
334 for dealing with BIGENDIAN processors
335 - Move equivalent stuff to BinEntry::WriteContent
336 When necessary, 16 Bits Pixels are swapped in a small buffer
337 and then written. This avoid allocating a huge buffer, in
338 PixelWriteConvertor, and avoid modifying the Pixel Area.
340 Probabely, the same operation will have to be done when we want
341 to write image with Big Endian Transfert Syntax,
342 and we are working on Little Endian Processor
344 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
345 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
347 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
348 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
349 all the dict content.
350 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
352 * Test/TestDict.cxx : add a new test for the dict classes
354 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
356 file. Debug is yanked if compiled with NDEBUG
358 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
359 * src/gdcmDictSet.h : set the default output to the os variable
360 * src/gdcmDictEntry.[h|cxx] : add the Print method
361 * gdcmPython/demo/ : add a new test
363 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
364 * merging of Test/PrintDicomDir and Test/TestDicomDir
365 * removal of now redundant Test/PrintDicomDir
366 * enhancement of Example/PrintDicomDir
368 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * Now, python test might work on systems
370 * Add the PrintDicomDir test
372 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
373 * FIX : First entry following group 0002 was lost for
374 Explicit Big Endian Transfer Syntax files
375 (group and elem not swaped)
377 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
378 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
379 Big Endian Transfer Syntax supposed the group following 0002
380 begins always by element 0000 (element 0000 is *optional*)
381 To avoid further troubles, let's be pessimistic, and use
382 Document::HandleOutOfGroup0002() method
383 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
384 (related pb not yet solved)
386 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
387 * Bug fix for the python part use
388 * Now, PrintHeader.py pass... but outside the ctest use. shit !
390 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
393 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
395 a string and should ask the global TS dict what are the propreties of
398 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
399 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
400 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
401 to swap the Swap Code, at parsing time, when we come out of group 0002
402 and Transfer Syntax is Big Endian
403 We should be able to read now 'true DICOM" Big Endian coded images
404 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
405 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
407 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
408 * Hopefully fix the bug on MacOSX and static global initialization.
409 This is the only -minor- patch I found that both please MacOSX and VS6.
410 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
411 but this would require a lot of change. Another approach would be that Global
412 create those string and GDCM_UNFOUND becomes a pointer to a string (which
413 gdcm::Global would destroy at exit).
415 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
416 * Fix bug on MacOSX with static initialization in a multy threaded
417 environment. static const string in a header file used to be ill
418 initialized provoquing the freeze of any tests. patch should solve this
421 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
422 * According to Benoit's suggestion, and without any objection from anybody
423 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
424 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
425 - method gdcmDicomDirObject::GetEntry() renamed as
426 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
428 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
429 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
430 you debug/warning message just as c++ streams which make them very convinient
431 to use. Once this is stabilize I will change the ostringstrem to be
432 redirected to a file (ofstream).
433 * Properly support C99 extension: __FUNCTION__ which allow us to display
434 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
436 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
437 * Removal of useless and dangerous methods :
438 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
439 GetDocEntryByName, GetEntryByName, GetDictEntryByName
440 * Removal of usless methods :
441 Dict::PrintByName, Dict::GetDictEntryByName
442 * Commenting out of probabely useless methods :
443 Dict::GetDictEntryNames()
444 Dict::GetDictEntryNamesByCategory()
445 DictSet::GetPubDictEntryNames()
446 DictSet::GetPubDictEntryNamesByCategory()
447 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
448 * ENH : Use dicomTS.dic as described in 2004 version
449 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
450 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
451 Add Accessors on VM (Value Multiplicity), and VM related methods
452 * ADD : Add a list of 'Dicom Attribute types', as found in
453 http://medical.nema.org/dicom/2004/04_15PU.PDF
455 * ADD : Add dicomGroupNameAbbreviations.dic
456 should be used to write a method to replace the former
457 Dict::GetDictEntryNamesByCategory()
459 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
460 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
461 to read in the file... and only it ! Length is the efective length of the
462 data in the DocEntry structure
464 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
465 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
466 And now use a static function call instead, with a global variable. i
467 This is much closer to the VTK approach. Hopefully should be bulletproof
468 and easier to use...hopefully
470 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
473 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
474 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
476 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
477 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
478 ValEntry, BinEntry, SeqEntry creation or replace
480 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
481 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
482 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
484 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
485 when specifying the VR
486 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
487 * src/gdcmDocEntry.cxx : amelioration of print
489 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
490 * ADD : Add the method Util::IsCurrentProcessorBigEndian
491 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
492 * ADD Method Document::ComputeGroupLength
493 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
494 in order to allow further VR modification by user
495 * REM : removal of once-called method File::WriteBase
496 integration of its code in formerly one-line method File::Write
498 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
500 replace the different values "??", "Unkn", "Unknown".
501 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
502 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
503 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
504 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
506 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
509 * Set the gdcm::Base class to some Printable classes
511 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
512 * src/gdcmFile.[h|cxx] : add the Print method
513 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
514 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
515 * src/gdcmDocument.h : remove the PrintLevel informations
516 * Example/PrintFile.cxx : use the new gdcm::File::Print
518 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
519 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
520 problems when compiling with the python wrapping
522 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
523 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
524 writting in ImplicitVR
526 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
527 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
528 JPEG decompression, especially when dicom frames are split into several
529 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
530 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
532 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * src/gdcmHeader.cxx : change the initialisation of default header.
534 Now, this header is readable by gdm, e-film, DicomWorks
536 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
537 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
538 Rename Decompressed to Raw
539 * Use the API changes in gdcm::File.
540 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
543 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
544 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
545 each added entry in the header. Replace the 'Planes' field by the 'Number
548 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
550 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
552 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
553 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
554 At this time, this image isn't readable by e-film... waiting JPR help to
557 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
558 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
559 DocEntry. Now use methods of the Document !
561 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
562 * Test/ShowDicomSeq.cxx : bug fix
564 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
565 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
566 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
567 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
568 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
570 * Test/TestCopyRescaleDicom.cxx : remove unused variable
571 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
572 containing found sequences
574 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
577 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
578 Some fields in BinEntry must be copied to not seg fault when making the :
579 gdcm::File *copy = new gdcm::File( copyH );
580 and tests are now made on good variables
582 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
583 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
584 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
586 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
587 * Add vtkGdcmWriter example and test
589 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
590 * Test/TestUtil.cxx : reformat the source code
591 * vtk/vtkGdcmReader.cxx : remove and change prints
592 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
594 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
595 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
597 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
598 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
599 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
601 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
602 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
603 by an eof to prevent all bad read of the file... and in this case, the
606 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
607 * Example/Volume2Dicom.cxx : comment unused variables
608 * Test/PrintDicomDir.cxx : comment unused variables
609 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
610 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
611 method that is redondant with AddEntry.
612 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
615 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
616 * Bug fix due my last commit (compilation under Windows).
617 * Example/Volume2Dicom : bug fix in the file and reformatting source code
618 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
620 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
622 - Remove printf / sprintf
623 - include iostream AFTER gdcm so we don't get warnings
624 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
626 - Also remove tons of include from header files, hopefully this should
627 speeup the compilation time, since it was becoming a dog slow.
628 - Remove gdcm.h as it include way too many files and slow down compilation
629 (plus it is not up to date)
630 - remove 'using namespace std' this is BAD !
632 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * Remove memory leaks on the DicomDir
634 * Remove some useless data in DicomDirObject
635 * Add usefull methods in SQItem, to be complient withe the ElementSet
637 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
638 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
640 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
641 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
642 future, with convertion)
643 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
644 and ImageDataSize values. Remove the method to get the PixelReadConverter
645 from the output of the class
647 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
648 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
650 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
652 and vtkErrorMacro use.
653 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
655 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
658 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
659 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
660 The string leaves only in the fonction. So when we make a .c_str(), we
661 get the pointeur on the first element, element that will be destroyed
662 immediately after thee instruction.
663 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
664 file has been opened : the test must be made on the content of the
665 pointer and not directly on the pointer !
668 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
669 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
670 the python part recompiles
672 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
673 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
674 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
675 X session is killed (for my computer... it seems to not be identic on
678 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
680 avoid problems (otherwise, the difference test between the visible image
681 and the reference is incorrect. If the reference is greater than the
682 screen resolution, it's produce errors).
683 Can be used for only one image. Can be used with a visible flag.
684 * vtk/vtkGdcmReader.cxx : remove commented codes.
685 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
686 under windows at compilation
687 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
689 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
691 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
692 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
693 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
694 tests on the image size X, Y, Z
696 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
697 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
698 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
699 between the class name and the file name
701 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
702 * src/ : fix compilation warnings for the Write method (2 different
703 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
704 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
705 variable... create a static method in gdcm::Document to access to
706 this variable content.
708 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
710 file, to be accessed by other files (like gdcmFile). Remove commented
711 code. Move the change of the header to the gdcmFile, using the
713 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
714 To be sure of that (and simplify calls), the Write of the header now
715 gets a file name and not a file pointer (std::ifstream).
716 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
717 DocEntryArchive. Remove all open of the written file
719 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
720 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
722 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
723 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
724 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
726 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
727 some corresponding methods. Write correctly the file and check before
729 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
730 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
731 is now on RGB data (as before my last commit
732 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
734 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
735 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
736 Add a print information of the type of the entry
737 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
738 It was in the gdcmFile, and all write have been regrouped
739 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
740 Write correctly all dicom files (in decompressed mode only at this time)
741 * Test/ : test on files are now made using Raw data and not color data if
743 * Example/PrintFile.cxx : add more printings
745 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
746 * Amelioration of code, remove some code copy. For the loading of
747 BinEntry (in gdcmDocument), add the test to verify if the file is already
750 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
752 remove a DocEntry in the header (push an empty DocEntry)
753 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
754 lines. Bug fix in the initialization of the PixelConvert and the
756 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
757 use in TestCopyDicom (now this test can run under windows... but fails)
758 * Test/TestCopyDicom.cxx : amelioration of the test :
759 - test the pixels written
760 - add test points to quickly find where is the error
761 - can set a file name input and output in arguments
762 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
763 amelioration of the test output
765 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
767 all replaced DocEntry's
768 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
769 Now, each needed DocEntry to modify is duplicated, modified and inserted
770 to the header using DocEntryArchive. Thus, after save, we can restore the
771 header initial state.
773 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
774 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
776 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
778 correct to copy it. The DictEntry is specified at the DocEntry creation,
779 then, it musn't change in the time.
780 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
781 header correctly. At this time, the change is only made for the first
782 level of the Document. In the future, it might consider sequences.
783 The change is made by replacing a DocEntry by an other that is created
784 outside the class. The old value is kept. When we restore the header
785 status, the added DocEntry is deleted and replaced by the old value.
786 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
787 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
788 set the write type to explicit VR, implicit VR or ACR. Add methods to set
789 the write mode to native, decompressed or RGB (but not used at this time)
791 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
792 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
793 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
795 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
797 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
799 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
800 set because already copied when copying the BinEntry's of the header
801 * Test/TestAllReadCompareDicom.cxx : remove warnings
803 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
804 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
805 Two problems appear when doing it :
806 - with the gdcmFile : when the GetImageData method is called, the pixels
807 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
808 data (pixels). And each structure destruct the data when it's
809 destructed. So we have two destructions for the same data. To solve it,
810 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
811 data or not. If it doesn't own data, then they will not destroyed by
813 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
814 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
815 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
816 create a double destruction of the same DocEntry's. So, to solve it,
817 the TagHT is simply cleared and the DicomDir* elements are destroyed.
818 * TODO : add an entry concerning memory leaks in the DicomDir
820 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
821 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
822 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
825 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
826 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
827 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
828 after it have been deleted
830 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * FIX: src/* fix the doxygen warnings.
832 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
833 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
834 was erroneously defined with a size of 15 instead of 16. [many thanks
835 to Jean Michel Rouet for pointing out this bug].
837 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
838 1. Finish merging JMR patch for writting DICOM from scratch
839 2. Fix -hopefully- bug with MONOCHROME and space vs null character
840 3. Use const ref when possible
841 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
842 5. A few more comments
843 6. CreateUniqueUID can now be called without parameter"
845 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
846 * ENH: Slightly bigger patch:
847 1. Getting toward full integration of JMR patch for writting dicom from scratch
848 2. Update Test to test part of this patch: CreateUniqueUID
849 3. File was not close properly in gdcmDict
850 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
851 5. Use of const ref instead of copy (speed issue)
852 6. Remove temporary (duplicate) string in TranslateToKey
853 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
854 8. Do not repeat virtual in subclasses
855 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
857 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
858 * Apply first patch toward better string comparison when dealing with broken
859 DICOM files. Essentially the string could be padded with a space instead
860 of a null character as defined by standard
862 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
863 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
864 because never used... and in the same time, that's remove some memory leaks
866 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
867 * src/gdcmFile.cxx : now delete the PixelConvert instance.
868 * In examples and tests : change the type of image data variables from void*
869 to uint8_t*. Remmove all delete on image data variables
871 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
873 Verify the file pointer value before open the file, and if it's not null,
874 a verbose message is generated.
875 Close correctly the file when the file isn't considered dicom-like. The
876 correctly close is a call to CloseFile.
877 When closing the file pointer, test if its not null to close the file.
878 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
879 file. For an uncompressed image, the copied data correspond in the least
880 case to the image size (calculated) or the image size specified in the
881 header. A verbose is generated if these two size mismatch
883 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
885 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
886 break under windows (with msvc6 compilation).
888 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
890 compiling with MSVC6)
892 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
893 * Bugs fix for the Windows build with VC6
894 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
895 needed (only for projects required VTK). If the VTK is included in all
896 projects, there is conflicts with the jpeg lib of vtk when compiling the
897 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
898 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
899 when compiling the gdcm_wrap.cxx file (created by the compilation of the
901 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
902 (like it's already made for the cout use). Otherwise, conflict with the
905 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
908 - comments on the DicomDir::Method related usage added.
909 - now that we use the namespace gdcm, a lot of internal classes do
910 NOT need to be wrapped anymore.
911 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
912 DicomDir::Method) new example added.
914 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
915 * Improve string manipulation. I now inforce the notion of 'DicomString'
916 A DicomString can contain as many \0 as they want
917 and it is *always* of even length.
918 We only support odd length for very rare case.
919 And in the near future this should be removed.
921 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
922 * /binary_write/ gdcm source. Now even on big endian we are writting
923 little endian. This should -heopfully- fix some tests
925 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
926 * Now the dictionary is compiled into gdcm lib. This is a default
927 behavior, thus any dic file specified is picked before failback to
928 the one comiled into lib
930 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
931 * Change internals for gdcmDict. Don't use any 'new' any more.
932 This should definitely solve any leak problem, and we should be
933 as fast as before, as long as don't modify too much the dictionary.
935 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * STYLE: ivars should start with a capital letter.
937 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
938 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
940 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
941 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
942 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
943 new 2004 dictionaries added (thanks to JPR).
944 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
945 * CLEANUP_ROUND (15) for gdcmPixelConvert
946 - RLEFrame::NumberFragments is now of type unsigned int
947 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
948 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
951 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
952 * Initial work in gathering all transfer syntax accessors. clearly
953 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
954 ivars, but only one transfersyntax (class) ivar with equivalent method on
957 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
958 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
959 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
960 discussed (plus I didn't like having a 2000 lines patch not commited)
962 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
964 * CLEANUP_ROUND (14) for gdcmPixelConvert
965 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
966 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
967 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
969 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
970 anymore and hence avoids storing a copy of PixelConvert::Decompressed
971 into File::Pixel_Data.
973 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
975 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
976 * CLEANUP_ROUND (13) for gdcmPixelConvert
977 Substituted File::ParsePixelData() with PixelConvert::Print() new
979 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
980 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
981 method to those classes.
982 - src/gdcmFile.[cxx|h]:
983 -- Added a ::Print() method.
984 -- PixelConverter is now a reference instead of a member.
985 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
986 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
988 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
989 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
990 collaboration diagram and inheritance diagram should be generated with
992 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
993 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
994 pointlessly wrapped (see
995 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
996 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
997 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
998 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
999 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1000 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1001 -- File::Initialise: PixelConverter setup moved away to
1002 PixelConverter::GrabInformationsFromHeader()
1003 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1004 interpretation moved away to PixelConverter::BuildRGBImage()
1006 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1007 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1008 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1010 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1011 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1012 displayed on Win32 when a brutal abort() occurs (because of uncatched
1013 exception). See TODO new entry of this commit for more on this.
1014 * TODO added new entry.
1015 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1016 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1017 - HandleColor is no longer called from gdcmFile.cxx
1018 - gdcmPixelConvert.cxx clean up on method arguments and internal
1019 variable names for semantical coherence.
1021 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * Finished lossless transition, not only do we now read all lossless jpeg
1023 images, without the need of the Cornwell lib, but we do read them properly now
1024 * To reduce code (well to avoid code duplication), I defined a common place
1025 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1026 redefine symbols. This is not perfect but this the best solution I found for a
1027 compilation time jpeg option.
1029 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1030 * Update jpeg ijg lib to support lossless jpeg implementation
1031 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1033 * Also added a special copyright for dcmtk since we use their bugfixes.
1036 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1038 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1039 matters, as stated in warning note at beginning of %include section).
1040 * src/gdcmDicomDir*.[cxx|h]: coding style
1041 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1042 * src/gdcmJpeg8.cxx: doxygen fix.
1043 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1044 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1045 from File:: to PixelConvert::.
1047 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1049 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1050 - more code moved away from File:: to PixelConvert::
1051 - fat setup of PixelConverter set in place in File::Initialise.
1053 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1054 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1055 namespace at the file system level. So now you should convert your examples
1057 gdcmHeader -> gdcm::Header
1058 It would be nice if people keep in mind to no open the namespace, since it
1059 allows compilation on broken plateform which were defining common symbol in
1060 the standart namespace (like LP, Unknown ...)
1062 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1064 The JPEG fragments are now parsed at the same stage than the RLE
1065 information. All code related to JPEG is now in gdcmPixelConvert:
1066 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1067 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1068 export a gdcmFile:: method. Those are simply global functions
1069 (for the time being this is better than having them attach to
1070 either gdcmFile:: or gdcmPixelConvert::).
1071 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1072 and stores the result in a gdcmJPEGFragmentsInfo.
1073 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1074 code (among other stuff) moved away from gdcmFile:; to
1077 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1078 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1079 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1080 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1081 clean up of RLE related code.
1082 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1083 - src/gdcmRLE.cxx removed
1084 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1085 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1086 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1087 * CLEANUP_ROUND (9) for gdcmPixelConvert
1088 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1089 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1090 away from gdcmFile:: to gdcmPixelConvert::.
1092 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1093 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1094 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1095 This is because Parse7Fe0 used to parse the pixels to compute the
1096 length. This task was passed over to FindDocEntryLengthOB() a long
1097 time ago, EXCEPT I had forgotten the OW case...
1098 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1099 we just recylce the code for parsing RLE fragments and computing
1101 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1102 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1103 with the retired Parse7Fe0().
1104 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1105 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1107 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1108 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1109 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1110 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1111 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1112 * CLEANUP_ROUND (4) for gdcmPixelConvert
1113 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1114 to return an unused length.
1116 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1117 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1118 this should be cleanner from the plane view. The iostream are erally a pain
1119 to use to do simple stuff.
1121 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1122 * Redo the compilation of the ijg jpeg library. Now only one source is
1123 necesseray. No need to rename file by hand what so ever. CMake handle the
1124 copying of the file within different directory, configure header file to
1125 modify some symbol. The only addition made to ijg wasd a mangle table so
1126 that symbol are different whether we are within 8bits or 12bits.
1128 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * Added documentation of vtkgdcmReader on Website:
1130 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1131 with it's binary name).
1132 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1133 the Website to be more complete.
1134 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1135 doxygenated documentation.
1136 - Doc/DoxyVtkGdcmReaderExamples.txt added
1137 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1138 DoxyVtkGdmReaderExamples.html )
1139 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1140 * CLEANUP_ROUND (3) for gdcmPixelConvert
1141 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1143 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * CLEANUP_ROUND (2) for gdcmPixelConvert
1145 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1147 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1148 * CLEANUP_ROUND for gdcmPixelConvert:
1149 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1150 - src/gdcmPixelStuff[h|cxx] removed
1151 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1152 - src/CMakeLists.txt changed accordingly
1153 * GDCMHOME clean up:
1154 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1155 gdcmVersion.py moved to newly created ATTIC related
1156 gdcmPython/SetupOldies/ directory.
1157 * Autotools clean up:
1158 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1159 - autogen.sh configure.in acinclude.m4 python.m4 removed
1161 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1162 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1163 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1164 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1166 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1167 * TODO updated with Mathieu suggestions. I proposed a template for
1168 describing TODO entries and used it for new entries.
1169 * Added Doc/Website/CodingStyle.html, Developpers.html,
1170 DeveloppersPython.html, GdcmDataCvs.html and
1171 DownloadVersion0_1.html, DownloadVersion0_3.html.
1172 * Some Doc/*.txt Doxygen files (which do not really concern the
1173 documentation itself, but the website) moved to html and
1174 placed in directory Doc/Website:
1175 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1176 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1177 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1178 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1179 * CMakeLists.txt changed accordingly.
1180 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1181 DeveloppersPython.html
1182 * INSTALL nows refers to Doc/Website/Installation.html
1184 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * Added Doc/Website directory, that contains a first raw version
1188 2004-09-23 Jean-Pierre Roux
1189 * FIX In order not to be poluted any longer by casting problems,
1190 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1191 we can now delete[] it safely
1192 * VoidArea is now called BinArea (less confusing name),
1193 and all the methods called ...VoidArea... are now ... BinArea...
1194 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1196 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1198 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1199 up to the destructor of gdcmElementSet to clean up TagHt and it's
1202 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1204 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1206 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * ENH: added some utility method that builds a flat dictionary
1208 holding all the Dicom entries contained in the recursive structure
1209 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1210 an example of usage.
1211 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1212 BuildFlatHashTable() that build a flat dictionary.
1213 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1214 gdcmDocument is now a friend of gdcmElementSet.
1215 - src/gdcmElementSet.cxx: clean up.
1216 - Example/FlatHashTablePrint.cxx added.
1217 - Example/CmakeLists.txt changed accordingly
1219 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1221 moved away from gdcmDocEntrySet (since this class is an abstract class
1222 acting like an interface). SQDepthLevel and BaseTagKey are now
1224 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1225 and associated accessors. Doxygenation of the class.
1226 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1228 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1229 Use SQDepthLevel accessor instead. ::Print() adapted.
1230 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1231 - src/gdcmDocument.cxx changed accordingly.
1233 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1235 - The following is the doxygen comment of the typedef declaration
1236 of gdcmTagKey in src/gdcmCommon.h:
1237 gdcmTagKey is made to old an "universal" (as in URL, Universal
1238 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1239 A dicom tag always has a group and an element, but a set of tags
1240 embeded in various (optionally nested) sequences and sharing
1241 the same group and element all share the same (group, element)
1242 "identifier". Hence the (group, element) cannot be used as an
1243 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1244 In order to construct a proper tag identifier (i.e. a key) we
1245 consider the following definition of a TagKey:
1246 - let Group, Element be the string representation of the
1247 group and element dicom tag members,
1248 - let ItemNumber be the string representation of the integer
1249 index of the considered item number of a sequence,
1250 Let the key of a tag embeded in a sequence, noted SeqTag, be
1252 /ItemNumber#Group|Element
1253 where "/", "#" and "|" are characters acting as separators.
1254 Then the general form of a gdcmTagKey is given by:
1255 Group|Element<SeqTag>
1256 where <SeqTag> means NO or many instances of SeqTag.
1257 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1260 but the gdcmTagKey of a tag "embeded" is the first item of
1261 a sequence, itself nested in the third item of a sequence is the
1263 0004|1220/2#0008|0082/0#0008|0090
1264 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1265 order to hold the new sequence compatible key. Previously, the
1266 GetKey() method would look in the underlying gdcmDictEntry.
1267 - src/gdcmDocEntry.cxx:
1268 -- constructor now copies the underlying DictEntry key, in the local
1270 -- ::Print: displays the member Key, instead of the (group, element).
1271 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1272 - src/gdcmDocEntrySet.h:xi
1273 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1274 -- now has a new BaseTagKey member.
1276 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1277 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1279 This poses the problem with the semantics of the following lines
1280 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1281 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1282 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1283 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1284 to the long FIXME note for what the problem is. Nevertheless in
1285 order to get things working the dicom dictionary was altered !
1286 Please fix things urgently...
1287 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1288 information), see above note on moving the member VoidArea. Nevertheless
1289 the following entries previously correctly set as US are now inproperly
1291 0028 1201 OW IMG Red Palette Color Lookup Table Data
1292 0028 1202 OW IMG Green Palette Color Lookup Table Data
1293 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1294 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1295 of gdcmDocEntry moved to gdcmSeqEntry.
1296 * src/gdcmSeqEntry.cxx: STYLE.
1298 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1299 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1301 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * gdcmPython/testSuite.py: all the test suite in python is now moved
1303 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1304 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1305 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1307 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1309 to avoid inclusion recursion until STL is reached.
1310 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1311 mecanism. errno.h is not included in gdcm anymore.
1312 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1313 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1315 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1316 gdcmData/TestAllEntryVerifyReference.txt
1317 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1318 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1319 exception_on_error parameter.
1320 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1321 - vtk/vtkGdcmReader.cxx changed accordingly,
1322 - Example/*.cxx and Test/*.cxx changed accordingly.
1324 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1326 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1327 enable_sequences removed from gdcmHeader constructor and dependencies.
1328 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1329 * gdcmPython/demo/PrintHeader.py: dummy fix.
1330 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1331 skip_shadow removed from gdcmHeader constructor and dependencies.
1332 * Example/*.cxx and Test/*.cxx changed accordingly.
1334 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1336 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1338 2004-07-21 Jean-Pierre Roux
1339 * FIX Now, Parsing and Printing a DICOMDIR do work!
1340 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1342 2004-07-20 Jean-Pierre Roux
1343 * FIX Some brain damaged headers have Zero-Lenght fields
1344 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1346 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1347 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1348 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1349 variable (instance of gdcmDebug) by a definition macro, and the instance
1350 is now in static in the gdcmDebug class
1351 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1352 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1354 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1355 * WARNING: ctest now depends more tightly on gdcmData. You should
1356 check out gdcmData properly for things to run smoothly...
1357 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1358 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1359 we need the pixels not be loaded in order to use the ValEntry
1360 that displays position and size).
1361 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1362 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1363 be deprecated. If you have any doubts about the advantages of a
1364 modern scripting language (read Python) versus grass root C++ (i.e.
1365 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1366 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1367 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1368 Anyhow, consider documenting the gdcmData images in
1369 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1371 * Test/CMakeLists.txt:
1372 - now uses TestAllEntryVerify.cxx
1373 - specific comments on oldACR00001.ima (now renamed in gdcmData
1374 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1375 gdcmData/TestAllEntryVerifyReference.txt
1378 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1379 * src/*.[h|cxx] : typedef clean up
1380 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1381 - TagKey renamed to gdcmTagKey (for external usage)
1382 - VRKey renamed to gdcmVRKey (for external usage)
1383 - removal of typedef duplication.
1384 - Removed all unecessary inline keyword from class inline definitions.
1385 - Some method|function(void) declarations replaced with method|function().
1386 * src/jpeg/libijg12/jdhuff12.c:
1387 - printf polluting ctest removed.
1388 - TAB removal for comminting
1390 - TestAllReadCompareDicom.cxx: added a test that compares all the
1391 images in gdcmDataImages.h with corresponding images in
1392 gdcmData/BaselineDicom/. When baseline images are not present
1393 this test creates them.
1394 Note: we need to validate each reference image, but before that
1395 I'd like to rename them with a more explicit name...
1396 - CMakeLists.txt: changed accordingly.
1397 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1398 including each header needed).
1400 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1401 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1402 test suite to the Example directory. Are concerned:
1407 - TestWriteSimple.cxx
1408 * Test/CMakeLists.txt: added some comments on reasons for black listing
1409 image gdcmData/oldACR00001.ima
1411 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * Test/CmakeList.txt: removed the following from black list (to be coherent
1413 with removal from gdcmData):
1414 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1415 - gdcm-MR-PHILIPS-16.dcm
1417 Added the following because after last cvs update, they cause
1418 ctest -R TestReadWriteReadCompare
1420 - gdcm-MR-SIEMENS-16-1.acr
1422 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1423 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1424 new comments in this file) we temporarily (sigh) move to a weaker
1426 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1427 we don't need to black list the following images anymore:
1428 - 8BitsUncompressedColor.dcm
1430 - US-PAL-8-10x-echo.dcm
1431 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1432 fixes and the beautified code ;-)
1433 This fixes the bug introduced in version 1.42 (when beautifying)
1434 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1435 Note: ctest was blind to this bug (this means we need to still
1436 improve the test suite). The bug could be detected by using
1437 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1439 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1440 and by displaying the (garbage) produced file temp.XDCM...
1442 2004-06-29 Jean-Pierre Roux
1443 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1444 - replace by uggly but working old code :-(
1445 A lot of things should be OK again.
1446 It's really urgent to have a test suite that *tests*,
1447 to prevent Frog's beautifying sessions to break all the stuff
1448 (twice, withing a fortnigh ...)
1450 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1452 redundancy) to added Test/TestReadWriteReadCompare.cxx
1453 * Test/CmakeList.txt: because the compare test of
1454 Test/TestReadWriteReadCompare.cxx fails, the following images are
1455 black listed: - 8BitsUncompressedColor.dcm
1457 - US-PAL-8-10x-echo.dcm
1458 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1459 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1460 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1461 and ad-hoc kludge. This kludge is now removed, and on encountering
1462 such an image (OB field brain damaged) we set errno. Then in
1463 ::FindDocLength() we "fix" the length as being ALL what remains
1464 in the file (until EOF). We then proceed, hoping for the best...
1465 This fixes a SegFault in ShowDicom when trying to write such an
1467 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1468 (because TestWriteRead breaks on it, after a non conformal commit?).
1469 ctest now runs properly, except for MakeDicomDir (which was always
1470 broken) and the Python related stuff (still not fixed).
1472 2004-06-24 Jean-Pierre Roux
1473 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1474 FIX : Test/TestReadWrite now iterates on all the file names
1475 (instead of infinite loop)
1476 ENH : Test/TestWriteRead now iterates on all the file names
1478 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1479 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1481 2004-06-24 Jean-Pierre Roux
1482 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1483 when SamplesPerPixel =3
1484 - now Write is no longer confused by
1485 'BitsAllocated = 12" and 'BitsStored=12"
1486 - "UN" value representation Elements are now written correctly
1487 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1488 ENH : - now gdcmHeader has its own Write methods
1489 (in order to split the job that has not to be done
1492 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1493 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1494 loop on the same image until memory went out.
1495 Note: this means we still have gobs of memory loss in PrintDocument
1496 * src/gdcmDocument.cxx: fixes problem on parsing on file
1497 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1499 2004-06-24 Jean-Pierre Roux
1500 FIX : Write - All the Sequences and Sequence Item are now written
1501 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1502 is added a the end, when necessary.
1503 - A lot of brain-damaged images, that were read correctly are
1504 now written correctly
1505 - length compatible BinEntry are now loaded correctly
1506 (even for odd groups)
1507 Note : only Explicit Value Representation was checked.
1508 (question : is implicit VR really necessary for gdcm ?)
1510 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1511 * DEVELOPPER: added a proposition of coding style.
1512 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1515 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1516 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1517 Use the gdcmDocEntry::Print() and Write() instead.
1518 * src/gdcmDocument.cxx: bug fix.
1520 2004-06-22 Jean-Pierre Roux
1521 FIX : gdcmDocument.cxx
1522 - Now we do recognize the JpegLossLess format (there was a misstyping in
1523 code 'beautyfication' :-(
1524 - Now we automaticaticaly load the Luts, if any
1526 2004-06-22 Jean-Pierre Roux
1527 In order : to write Sequences, whatever their imbrication level,
1528 : to allow user to create his own Sequences
1529 a lot of modif where necessary (adding, moving, or virtualising methods)
1531 WARNING : save your own sources *before* cvs up !
1534 ADD virtual void Write(FILE *fp, FileType filetype);
1537 ADD virtual void Write(FILE *fp, FileType filetype);
1538 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1541 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1542 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1543 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1544 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1545 ADD std::string GetEntryByName(TagName name);
1546 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1548 std::string vr = "unkn",
1549 std::string fourth = "unkn",
1550 std::string name = "unkn");
1551 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1552 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1553 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1554 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1555 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1556 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1557 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1558 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1561 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1562 ADD virtual std::string GetEntryByName (TagName tagName);
1563 ADD virtual std::string GetEntryVRByName (TagName tagName);
1564 REM virtual bool Write(FILE *, FileType);
1565 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1566 FILE *_fp, FileType type);
1567 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1568 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1569 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1570 REM virtual std::string GetEntryByName (std::string tagName);
1571 REM virtual std::string GetEntryVRByName (std::string tagName);
1572 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1573 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1574 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1576 std::string vr = "unkn",
1577 std::string fourth = "unkn",
1578 std::string name = "unkn");
1579 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1580 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1581 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1582 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1585 ADD virtual void Write(FILE *fp, FileType filetype);
1588 ADD virtual void Write(FILE *fp,FileType filetype);
1591 ADD virtual void Write(FILE *fp, FileType filetype);
1592 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1593 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1594 REM std::string GetEntryByName(TagName name);
1597 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1599 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1600 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1601 The default constructor invoked by the line
1602 gdcmHeader *f1 = new gdcmHeader( header );
1603 was gdcmHeader::gdcmHeader(bool) instead of the expected
1604 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1605 Hence the parsing wasn't executed... See also below.
1606 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1607 as explicit constructor didn't do the trick to fix the above problem.
1608 Could anyone explain why ?
1609 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1610 properly calls gdcmValEntry::Print() (that was weed out from
1611 code related to gdcmBinEntry).
1613 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1614 * In order to fix memory leaks:
1615 - Test/TestWriteSimple.cxx: added cleaning of free store through
1617 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1618 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1619 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1620 (through the call to ::AddDicomDirMeta()) or the destructor
1621 would crash when deleting uninitialized ::metaElems].
1622 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1623 - src/gdcmDocument.cxx:
1624 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1625 from dynamic stores.
1626 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1627 was causing memory leaks.
1628 - src/gdcmSQItem.cxx:
1629 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1630 cleanly handled with polymophism: sorry but my milage is low).
1631 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1632 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1633 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1634 This avoids SegFaulting.
1635 - src/gdcmSQItem.h: coding style.
1637 - Test/TestWriteSimple still severely sucks. The output image content
1638 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1639 damaged when displayed with vtkgdcmViewer.
1640 - on memory leaks: TestWriteSimple leaks really less (see entry
1641 of 2004-06-18 in Changelog file for the call to valgrind).
1642 - on segfaults: ctest now passes all the tests but one (no more
1644 * Erroneous leading white fix:
1645 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1646 white[s] (as opposed to from >> xxx, that removes it [them].
1647 - src/gdcmTS.cxx: ditto.
1648 - gdcmPython/testSuite.py: dirty related kludge removed.
1649 * src/*: remaining references to gdcmParser removed.
1650 * src/*[cxx|h]: added copy[way]left header.
1653 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1654 * In order to fix writing of dicom files:
1655 - Test/TestWriteSimple.cxx: a simpler example of writing.
1656 - Test/CMakeLists.txt changed accordingly.
1657 - src/gdcmDocument.cxx:
1658 -- The destructor now recursilvely removes potential sequences.
1659 -- Bug fix in ::IsJPEG2000()
1660 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1661 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1663 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1664 to only declared) and build on top of
1665 ::GetDocEntryByNumber(guint16, guint16).
1666 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1667 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1668 for usage in destructor and treatement of promotion in
1669 ::ReplaceOrCreateByNumber().
1670 - src/gdcmSQItem.cxx: destructor should better handle his job.
1671 Test/TestWriteSimple now runs (or at least it DOES something).
1672 * We can now start hutting memory links. A good starting point is:
1673 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1674 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1675 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1677 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1678 * Valgrind note: after Mathieu Malaterre teached me how to read
1679 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1681 Using gcc, you can force the STL to use malloc and to free memory as
1682 soon as possible by globally disabling memory caching.
1683 With 3.2.2 and later, you should export the environment variable
1684 GLIBCPP_FORCE_NEW before running your program.
1685 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1686 simply vanish (it is still not clear to me, whether this means that
1687 STL std::string leaks or if valgrind believes it leaks...).
1688 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1689 running bin/gdcmTests makeDicomDir):
1690 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1691 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1693 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1694 SegFaulting (I drowned in DicomDir related code when trying to
1695 understand why the list is empty...).
1696 * src/gdcmDocument.h: first BSD license header try.
1697 * Doc/License.txt added.
1699 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * src/gdcmDocument.[h|cxx]:
1701 - Clean up of the Transfer related predicates. They are now all based
1702 on new method isGivenTransferSyntax, that (should) handle properly
1703 the padding problem.
1704 - general clean up, simplification, and coding style.
1705 - Specific clean up of Parse7FE0() (umproperly named actually).
1706 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1708 2004-06-14 Jean-Pierre Roux
1710 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1711 - fix the display of SQItem ordinal number
1712 - add the GetSQItemByOrdinalNumber method
1713 - remove some useless never written private methods
1715 2004-06-14 Jean-Pierre Roux
1717 - adding a constructor taking a gdcmDocEntry as an input param
1718 - ReplaceOrCreateByNumber now returns :
1719 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1720 a gdcmValEntry * if a string value is passed as a param
1722 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1723 according to the param type (no longer sets a gdcmDocEntry)
1724 - GetValEntryByNumber, GetBinEntryByNumber added
1725 - NewValEntryByNumber and NewBinEntryByNumber added
1727 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1729 - GetSQItemNumber and SetSQItemNumber added, to provide
1730 a (relative) Item identier inside a given Sequence
1731 \warning : some pb remaining around this number
1733 - AddEntry now takes the Item Number as a param
1735 - adding a constructor taking a gdcmDocEntry as an input param
1737 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1738 * Memory leak hunt with the following command:
1739 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1740 --show-reachable=yes gdcmTests PrintDocument
1741 It looks like many (all?) leaks are due to the STL (or a bad usage
1742 of the STL. The lines producing the leaks now have a comment with
1743 a "MEMORY LEAK" tag: you can retrieve them with
1744 grep "MEMORY LEAK" src/*
1745 Here are two typical examples which I can't help fixing:
1750 char * test = "babo";
1751 name = test; //// <--- valgrind detects 960 bytes lost in
1752 //// call to std::string::operator=(char const*)
1753 name.clear(); //// Doesn't help !
1761 std::cout << "Type a bunch of characters followed by RETURN: ";
1762 getline(std::cin, line); //// <--- valgrind dectects a loss
1763 //// of 1320 bytes in call to
1764 /// std::basic_istream<>& std::getline<>
1770 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1771 * src/gdcmHeader.[cxx|h]:
1772 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1773 and related, moved away to gdcmDocument.
1774 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1775 the corresponding protected accessors of inherited class
1776 gdcmDocument, removed ! As a consequence gdcmFile had to be
1777 declared friend of class gdcmDocument (see below).
1778 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1779 - Clean up of undefined or unused methods.
1780 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1781 account the changes to gdcmHeader.h).
1782 * src/gdcmDocument.h:
1783 - gdcmFile is now a friend class (in order to take into account the
1784 changes to gdcmHeader.h).
1785 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1786 (see changes to gdcmHeader.h).
1787 - Accessors (reading on the form GetEntry*) are now public.
1788 - Clean up of undefined or unused methods.
1789 * src/gdcmDocument.cxx:
1790 - adaptation to changes to gdcmDocument.h
1791 - ::OpenFile now writes a verbose message when file cannot be opened.
1792 - some std::string properly set to VRKey
1793 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1794 references to gdcmDocument.
1795 * Test/TestFindTags.cxx: changed accordingly to above changes.
1796 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1797 cvs repository gdcmData.
1799 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1800 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1801 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1802 conflicts with gdcmValEntry::voidArea.
1803 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1804 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1805 Value representation between StringRepresentable and BinaryRepresentable.
1806 * src/gdcmDocument.cxx:
1807 - method ParseDES: proper indentation restored and usage of
1808 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1809 - method LoadDocEntry: the fingerprint left in the SetValue() of
1810 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1811 removed. Reverting to previous code segment with the proper
1812 dynamic_cast< gdcmValEntry* >.
1813 Note: this was (partially) breaking the python test suite
1814 (gdcmPython/testSuite.py) that made usage of the above
1815 fingerprint to check presence of "Pixel Data".
1816 * src/gdcmDocEntry.h: coding style.
1817 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1818 now taken into account.
1819 * gdcmPython/gdcm.i: adaptation to the new internal representation
1820 of gdcm (exit gdcmParser, hello gdcmDocument).
1821 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1823 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1824 anymore, but instead prints the loaded Python dictionary.
1825 * .... alas, the python testSuite is still broken.
1827 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1828 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1830 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1831 * src/gdcmUtil.h : export methods
1833 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1834 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1836 * Initial addition of automatic python testing
1837 * Initial addition of automatic image comparison
1839 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1840 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1841 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1843 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1844 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1845 * Test/ShowDicom.cxx : bug fix for msvc compilation
1846 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1848 2004-05-04 Jean-Pierre Roux
1849 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1850 new concepts (and new classes) :
1851 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1852 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1853 - Sequence Doc Entries (gdcmSeqEntries)
1854 a Sequence is composed of Items.
1855 Each item is a set of Doc Entries (this is recursive)
1856 The non uniqueness of the 'Dicom tag' is due to this recursivity
1857 (never taken into account)
1858 Our unability to add a new 'entry' in the header
1859 at the proper location (neither in the H-Table (map or multimap),
1860 nor in the Chained List is also due to this recursivity.
1861 Don't try, right now, to use/modify/compile these new sources :
1862 nothing is finished.
1863 We just commit all the stuff, 'as is', in order not to loose it.
1865 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1866 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1868 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1869 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1870 file prefix (SetFilePrefix)
1872 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * Add a new test: ShowDicom, for now this is just the c++ version of
1874 checkRead.sh, later it will be able to compare the image read against a
1876 * Replace the DEBUG on the stack with a global entry in cmake interface:
1877 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1879 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * Add an example subdir, with a real example on how to read + write a
1883 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1884 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1885 * Doc/CMakeLists.txt: the main page is now properly differentiated
1886 between the developper and user version.
1887 * Doc/doxygen.config.in: dropped search related obsolete flags
1888 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1890 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1891 * DEVELOPPER: added some helpfull comments for compile/test/install
1894 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1896 src directory, now generated in the build dir.
1897 2. Tests as mentionned smarter
1899 4. Add a new method in gdcmDict that return the PubDict by name
1900 this is interesting for 3rd party lib like ITK,
1901 where we could set the institution name / patient name...
1903 * ENH: 1. Now the test suite is working for real
1904 2. All binaries are now output in the gdcm-bin directory
1905 (this was not true before)
1907 2004-04-28 Jean-Pierre Roux
1908 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1909 SeQuence indented printing of Dicom Header.
1910 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1911 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1912 Computation of SQDepthLevel is now part of gdcmHeader constructor
1913 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1914 tree-like structure of a Dicom Header.
1915 * FIX Test code cleaning
1917 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * ENH: Adding automatic testing
1919 1. Need a DartConfig.cmake to submit to public
1920 2. Add a test driver gdcmTest.cxx
1921 3. gdcmTestMain, an helper for the main test driver gdcmTest
1922 4. Files in Test don't have a main anymore, this becomes interesting
1923 when we add more and more tests, thus dsw don't have to load
1925 * ENH: Adding a GDCM_DATA_ROOT for testing
1926 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1927 one file instead of seven + some small cleanup
1929 2004-04-22 Jean-Pierre Roux
1930 * ENH Minor changes to the Print() methods.
1931 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1932 Header printing. Example given with :
1933 > PrintHeader fileName 2 new
1934 (SQ based tree-like structure still to be done for the Header ...)
1936 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1938 1. I have added some unsigned where needed
1939 2. Some function parameter not used -> (void)
1940 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1941 4. g++ don't like character '\' in comment
1942 5. #define jpeg_create_decompress jCreaDecompress
1943 this really need to be fixed
1944 6. virtualize destructor of gdcmObject ... leakage
1945 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1946 this also really need to be fixed
1947 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1948 remove compression file
1949 (as we only do decompression, right ?)
1950 * ENH: Change malloc/calloc/free with c++ equivalent
1952 2004-04-21 Jean-Pierre Roux
1953 * FIX gdcmHeaderHelper::GetXSpacing
1954 when a single value is found (bug ?), xpacing is now
1955 defaulted to yspacing
1957 2004-04-19 Jean-Pierre Roux
1958 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1959 * ENH add parameters :
1960 bool exception_on_error = false,
1961 bool enable_sequences = false,
1962 bool ignore_shadow = false
1963 to the gdcmFile constructors to be full gdcmParser compliant
1964 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1965 to allow reading of PAPYRUS 3.0 files
1967 2004-04-06 Jean-Pierre Roux
1968 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1970 2004-04-02 Jean-Pierre Roux
1971 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1972 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1973 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1975 2004-03-30 Jean-Pierre Roux
1976 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1977 for ACR file, written out as DICOM files (hope so...)
1979 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1980 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1981 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1982 moved to base class gdcmParser and only the specialisation is kept
1984 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1985 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1986 already does the job.
1987 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1988 (to be consistent with gdcmParser::WriteEntries).
1990 2004-03-30 Benoit Regrain
1991 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1992 upate of the object's instance. It's passed to 2 in the unfavorable
1993 case : one in the ExecuteInformation, one in the ExecuteData
1995 2004-03-29 Jean-Pierre Roux
1996 * ENH : Check on file type to be written moved
1997 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1998 * FIX : gdcmObject::ResetBoundaries now stops properly
1999 when end-of-list is reached
2000 : gdcmVersion modified (as Benoit Regrain asked)
2002 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2003 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2004 * src/gdcmUtil.cxx: added forgotten iostream include.
2005 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2006 equivalent to ExplicitVR in existing code).
2008 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2010 now contains all the gdcmGlobal related code.
2011 * minor coding style and doxygenation changes.
2013 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2014 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2015 now contains all the Debug related code.
2016 * minor clean-up of includes in src/*.cxx
2017 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2018 CreateCleanString) removed.
2019 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2020 * Doc/DoxyMainPageUser.txt added.
2021 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2022 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2023 src/gdcmDirList.cxx)
2025 2004-03-24 Jean-Pierre Roux
2026 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2028 2004-03-23 Jean-Pierre Roux
2029 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2030 big endian made volumes
2031 * ENH Now gdcmParser constructor and destructor are protected to forbid
2032 end user to instanciate class gdcmParser
2033 (only gdcmHeader and gdcmDicomDir are meaningfull)
2035 2004-03-22 Benoit Regrain
2036 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2037 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2038 gdcmSerie to gdcmDicomDirSerie
2040 2004-03-19 Jean-Pierre Roux
2041 * ENH Now the tree-like structure describing a DICOMDIR comming from
2042 an already existing DICOMDIR file is consistent with
2043 the home-made tree-like structure build ex-nihilo
2044 or build from the files held (recursively) in a Directory
2045 functions gdcmDicomDir::CheckBoundaries()
2046 gdcmObject::SetBoundaries() added
2048 2004-03-17 Jean-Pierre Roux
2049 * REM (Eric Boix bug) : removal of meaningless
2050 gdcmDicomDirImage::NewImage function.
2051 * FIX now file names and directory name are written properly in the
2053 * FIX now gdcmDicomDir constructor may be call without any trick
2056 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2057 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2058 of gdcmDicomDirImage::NewImage as empty function.
2060 2004-02-28 Jean-Pierre Roux
2061 * ENH add gdcmDicomDir:NewPatient
2062 add gdcmDicomDirPatient:NewStudy
2063 add gdcmDicomDirStudy:NewSerie
2064 add gdcmDicomDirSerie:NewImage
2065 to allow making gdcDicomDir object.
2066 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2067 (as opposite to the gdcmHeader chained list)
2069 2004-02-11 Benoit Regrain
2070 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2071 when using from python
2073 2004-02-10 Benoit Regrain
2074 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2075 * FIX : in gdcmDicomDir when the directory is empty
2076 * ENH : add callback and methods to get the progression of dicomDir
2079 2004-02-06 Jean-Pierre Roux
2080 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2081 - GDCM_META added to gdcmDicomDirType
2082 - class gdcmMeta created
2083 * ENH : - A brief summary is now displayed at the beginning of
2084 'testDicomDir' to help disaster magnitude estimation
2085 * REM : Now useless Test/explDICOMDIR.cxx
2087 2004-02-05 Benoit Regrain
2088 * ENH : add methods in gdcmObject to get the hash table or the list of
2090 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2091 * FIX : wrapping python for TagHeaderEntryHT
2093 2004-02-04 Benoit Regrain
2094 * FIX : even length for some strings when writting the dicom dir
2095 * FIX : sort the images in the dicom dir
2096 * FIX : Bug fix for python use of dicom dir
2097 * ADD : a python demo
2099 2004-02-04 Jean-Pierre Roux
2100 * FIX : Final solution (?) for icone embedded images
2101 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2102 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2103 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2104 gdcmData/gdcm-MR-SIEMENS-16.acr1
2105 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2106 to make full checking easier
2108 2004-02-04 Benoit Regrain
2109 * FIX : WriteEntries : coding style & logic in parameters
2110 * FIX : Set the elements to create the DicomDir in a dictionary file
2112 2004-02-03 Benoit Regrain
2113 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2114 * gdcmDicomDir : add the load of directory
2115 * Bug fix and print add-on
2117 2004-02-03 Jean-Pierre Roux
2118 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2119 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2120 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2121 * FIX gdcmParser.cxx : 'group length' elements are now considered
2122 as integers, even for shadow groups, when file is Implicit VR
2124 2004-02-02 Jean-Pierre Roux
2125 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2127 of the last synonym :-(
2128 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2130 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2131 * FIX taking into account the possible 7fe0,0010 multiplicity
2132 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2133 to allow removal of references to 7fe0,0010, to deal with
2134 ACR-NEMA images, when 0028,0200 is meaningfull
2136 2004-01-31 Jean-Pierre Roux
2137 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2138 no longer writes 'Un' on disk
2139 * FIX SQ elements with actual length are now dealt with corectly
2140 * FIX gdcmFile::WriteBase make the difference, for color images, between
2141 the length (for Palette expanded images)
2142 and Raw Length (non expanded image + Palette)
2143 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2144 (that broke Write). Replaced by UL.
2145 Aware user will reload the field if he
2146 thinks it's necesssary
2148 2004-01-30 Jean-Pierre Roux
2149 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2150 when 'dirty Acr' is found, to be compliant with the new
2151 IsReadable() methods.
2153 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2154 (no DOUBLE images in kosher DICOM,
2155 but so usefull for people that miss them ;-)
2157 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2158 DICOMDIR related utilities (not checked as Windoze compliant)
2160 2004-01-28 Jean-Pierre Roux
2161 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2163 2004-01-27 Jean-Pierre Roux
2164 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2165 to allow skipping the shadow elements, to save memory space.
2166 The TRUE value for this param has to be used
2167 with a FALSE value for the 'enable_sequence' param.
2168 ('public elements' may be embedded in 'shadow Sequences')
2169 * gdcmHeader methods now deal with 'embedded icones images' in the header
2170 (even when an 'icone image sequence' is announced by the
2171 element (0x0088,0x0200), but there is NO icone at all ...
2173 * gdcmHeader sometimes Image Location value doesn't follow
2174 the supposed processor endianity (see gdcmData/cr172241.dcm).
2177 * gdcmHeader add the method
2178 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2179 to get *all* the Header Entries with the same tag.
2180 GetHeaderEntrySameName is probabely *useless*
2181 (no meaning : Name is *not* an identifier within the Dictionary)
2183 2004-01-26 Benoit Regrain
2184 * Bug fix in the print of hexadecimal representations. Remove long fields
2185 in the print and add a third level of print to print them
2187 2004-01-23 Benoit Regrain
2188 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2189 * Bug fix on test suite after remove the strip made on not string fields
2190 * Split the IsReadable method between gdcmParser which test that the file
2191 is dicom and gdcmHeader which test that it's an image file
2193 2004-01-22 Benoit Regrain
2194 * DicomDir : clean code, add methods, set variables in protected or private
2195 * gdcmUtil : bug fix for the clean string method
2197 2004-01-19 Benoit Regrain
2198 * Add the use of shadow dictionaries
2199 * bug fix and coding style
2201 2004-01-19 Benoit Regrain
2202 * src/gdcmFile.cxx : bug fix concerning the close of file
2203 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2204 * Add the update of header entries using the shadow library
2206 2004-01-19 Benoit Regrain
2207 * removal of file gdcmHeader2.cxx
2208 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2209 inheriting from gdcmParser. This split is to prepare the integration
2210 of dicom dir parsing
2211 * bug fix under python
2213 2004-01-16 Jean-Pierre Roux
2214 * REM removal of class gdcmHeaderEntrySet
2215 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2216 * ADD add file gdcmHeader2.cxx
2217 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2219 2004-01-15 Benoit Regrain
2220 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2221 entries created while parsing the header. Thus, they will be destroyed
2222 when the gdcmDictSet will be destroyed
2223 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2226 2004-01-15 Benoit Regrain
2227 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2228 made a fatal error because of the memory release at the end of program.
2229 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2230 some memory and vtk seems to have some problems with that.
2231 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2233 2004-01-14 Benoit Regrain
2234 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2235 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2236 * src/*.[h|cxx] : make changes due to class name changes
2237 * gdcmPython/demo/*.py : bug fix due to method names
2239 2004-01-13 Benoit Regrain
2240 * src/*.[h|cxx] : coding style
2241 * vtk/*.[h|cxx] : coding style
2243 2004-01-13 Benoit Regrain
2244 * gdcmPython/testSuite.py : test the readable flag of file for tests
2245 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2246 It's lied to the stl compilation by MSVC (windows, always windows...)
2247 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2249 2004-01-12 Benoit Regrain
2250 * src/*.h : add comments
2251 * src/gdcmDictSet.h : set the method BuildDictPath in public
2252 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2253 directly setted in the source code
2254 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2257 2004-01-09 Benoit Regrain
2258 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2259 * setup.py : use a reference to gdcmVERSION
2261 2004-01-07 Benoit Regrain
2262 * Modification to compile with the distutils.
2265 2003-12-10 Benoit Regrain
2266 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2267 can use a gdcmHeaderHelper to load data
2268 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2269 made in the source code
2271 2003-12-10 Benoit Regrain
2272 * Update Windows projects and .cvsignore files
2274 2003-11-12 Jean-Pierre Roux
2275 * ENH gdcmHeader constructor has one more parameter (default value : false)
2276 that allows the user to 'go inside' the SeQuences only
2278 gdcmElValSet:Print takes it into account
2280 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2281 * ENH: Update gdcmPython/CMakeLists
2282 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2283 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2285 2003-11-10 Jean-Pierre Roux
2286 * FIX : gdcmHeader::LoadElements is now based
2287 on the ListTag listElem member,
2288 not longer on the TagElValueHT tagHt member
2289 * ENH : PrintPubElVal shows (temporarily) both results,
2290 with the tagHt member and the listElem member.
2291 (it's easier to 'see' the problems when using Printheader)
2293 * FIX : old private member LgrElem is now splitted into
2294 ReadLength : Length actually found on disk (updated only
2295 if bug fixing is necessary), for internal
2297 UsableLength : Updated by FixFoundLength, to fix a bug
2298 or to allow Parser going on.
2299 Will allow to re-write a kosher header when a SeQuence
2300 with a length (not 0000) is found
2301 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2302 because gdcmElValSet::Add does not update ListElem
2305 2003-11-07 Jean-Pierre Roux
2306 * FIX misstyping in Transfert Syntax name table
2307 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2308 when they have an actual length (not 0000 nor FFFFF)
2309 (Nobody should care of it, but DICOMDIR explorers)
2311 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2312 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2314 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2315 * ENH: vtkGdcmReader now supports LUT !
2316 (vtkgdcmViewer for now is not able to use them though)
2318 2003-11-05 Jean-Pierre Roux
2319 * in testSuite.py : new files names for checking the package
2320 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2321 that returns the pixel area size to the *aware* (vtk) user
2322 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2324 2003-11-05 Benoit Regrain
2325 * in testSuite.py : Modify the rules for checking the paths
2326 : Explicit error messages
2327 * in __init__.py : Related modif
2329 2003-11-03 Jean-Pierre Roux
2330 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2331 to be used by aware (vtk) users that want to manage
2332 LUT (and no to turn the PALETTE image into an RGB pixels one)
2333 * GetPixelType now returns 8U for 24 Bits images
2334 (vtkGdcmReader compliant)
2336 2003-10-31 Jean-Pierre Roux
2337 * Removal of *all* gdcmData images and add them again
2338 in order to loose the 'history' of un-anonymised images
2340 2003-10-31 Jean-Pierre Roux
2341 * RMV : removal of useless jBitsInJsample.h
2342 for both 8 and 12 Bits JPEG Lossy Libraries
2344 2003-10-31 Jean-Pierre Roux
2345 * ENH : Add the functions gdcmFile::GetImageDataRaw
2346 gdcmFile::GetImageDataIntoVectorRaw
2347 that act as GetImageData and GetImageDataIntoVector
2348 except the making of an RGB Plane from Gray Plane + LUT
2349 Intended to aware (vtk) users who know how to manage
2352 GetLUTRGBA return a R,G,B,A LUT if any
2353 lgrTotaleRaw gives the 'Raw' length
2354 GetImageDataRaw returns the gray Plane
2355 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2356 (They stay Grey, just like with other Dicom viewers :-(
2358 2003-10-30 Jean-Pierre Roux
2359 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2361 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2362 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2363 being coherents dicom files.
2365 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2366 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2368 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2369 * ENH: Two steps is necessary to please VC++ compiler...
2370 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2371 * ENH: Add include dir to medcon lib
2372 * FIX: only one function is being exported for now !
2373 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2375 2003-10-29 Jean-Pierre Roux
2376 * adding gdcmHeader::GetLUTRGBA
2377 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2378 --> Mathieu, the modif u're waiting for is not yet committed
2379 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2381 2003-10-27 Jean-Pierre Roux
2382 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2383 00191113.dcm DermaColorLossLess.dcm
2384 MxTwinLossLess.dcm RadBWLossLess.dcm
2385 * ENH: For version prior to vtkImageViewer2 -r 1.19
2386 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2388 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2389 * Removal of ido stuff in CMakeLists.txt
2391 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2392 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2393 * FIX: remove a call to ->Modified ... see comments
2394 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2396 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2397 * FIX: Problem with path for libvtkgdcmPython
2398 * ENH: Try adding a search script for python site-package
2399 * RMV: Remove some file from medcon lib that are not necessary
2400 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2401 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2402 * FIX: More pragma disable fro VC++,
2403 I don't think I break something as it is also disable in VTK/ITK.
2404 But it fasten debug compilation time.
2406 2003-10-23 Jean-Pierre Roux
2407 * gdcm now deals with 16 Bits Run Length Encoded images
2408 (they are compressed as 2 planes images,
2409 one for the high Bytes, the other for low Bytes)
2411 2003-10-22 Jean-Pierre Roux
2412 * Now CheckRead takes into account :
2413 - the bugged 'Leonardo' Siemens images
2414 - the XA images, sent thru the burning VPRO station
2415 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2418 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2419 * FIX: When copying a Makefile.am to CMakeLists.txt
2420 one should remove the '\'
2422 2003-10-22 Jean-Pierre Roux
2423 * in gdcmData adding a bugged 'Leonardo' Siemens image
2424 (wrong lengths in header)
2425 OK with gdcm, KO with the other viewers :-)
2426 * add a GE dlx XA image, thru the VEPRO burning station
2429 2003-10-21 Jean-Pierre Roux
2430 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2431 for a brutal checking of vtkgdcmViewer compliance
2433 2003-10-21 Jean-Pierre Roux
2434 * add the files for 'xmedcon' Jpeg Lossless library
2435 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2437 2003-10-21 Jean-Pierre Roux
2438 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2440 2003-10-21 Jean-Pierre Roux
2441 * garbage Siemens 'Leonardo' images dealt with
2442 (the patch is easy to remove)
2443 * cosmetic changes to avoid warnings
2445 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2446 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2447 no need to press 'r' now.
2449 2003-10-20 Jean-Pierre Roux
2450 * upgrade of checkRead.sh checkWrite.sh according
2451 to new Jpeg Lossless decompressor
2452 * add US.3405.1.dcm, a genuine RGB medical file ...
2453 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2454 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2456 2003-10-15 Jean-Pierre Roux
2457 * general anonymisation in gdcmData
2458 * adding the 'color files' from
2459 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2460 * adding some well knowed bugged-header images
2461 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2462 waiting for their inclusion in Python testsuite
2464 2003-10-15 Jean-Pierre Roux
2465 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2466 no longer seg faults when file is not found
2468 2003-10-14 Jean-Pierre Roux
2469 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2472 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2473 * TODO: *.in file to genereate a UseGDCM later
2475 2003-10-14 Jean-Pierre Roux
2476 * Some supposed-to-be Dicom Images have no preamble.
2477 OpenFile takes it into account
2478 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2479 * Missing elements added in dicomV3.dic
2480 (just to be affraid : have a look at
2481 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2482 and do it again next year ;->
2484 2003-10-13 Jean-Pierre Roux
2485 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2486 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2487 But there are NOT. It's fixed !
2489 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2490 * FIX: "jpeglib.h" was not found on VC++
2491 * FIX: vtkgdcm was not being installed
2493 2003-10-10 Jean-Pierre Roux
2494 * ENH : OpenFile closes the file if it *really* doesn't look like
2495 an ACR-NEMA / DICOM one.
2496 * FIX : testWrite no longer writes an empty file if the source file
2497 is not gdcm Readable
2498 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2501 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2502 * FIX: CMake generate now documentation
2503 * ENH: out of source doc build !
2504 * ENH: Generate both user and dev documentation
2505 * ENH: Should work on windows too
2506 * ENH: Only one doxygen config.in file is needed
2507 * FIX: make install should be ok now on ùnix plateform
2508 * FIX: PATH to dictionary was wrong (missing /)
2509 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2511 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2512 * vtkGdcmReader is now able to read rgb dicom file.
2513 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2514 * added a gdcmViewer to vtk test, use mouse to control
2515 window level & window width
2517 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2518 * CMake-ification of gdcm, we have now two build system
2519 * FIX: on cygwin Wsock32 doesn't exist
2520 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2522 2003-10-06 Emanuel Ollart
2523 * FIX : compilation process wad broken.
2524 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2526 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2527 * change gdcmViewer -> vtkgdcmViewer
2528 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2530 2003-10-06 Jean-Pierre Roux
2531 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2532 ( e.g : well known GE images with a wrong elem length,
2533 : Philips MRI Images with a wrong Huffman table)
2534 * still to be done : allow the reading of bugged LEONARDO Siemens images
2536 2003-10-03 Jean-Pierre Roux
2537 * Odd length strings are padded with '\0' (not with spaces,
2538 to remain compliant with already defined strings,
2539 like Transfert Syntax UID and others)
2541 2003-10-03 Jean-Pierre Roux
2542 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2543 to allow displaying RGB images (not only by affim ;-)
2545 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2546 * vtkGdcmReader is now able to read rgb dicom file.
2547 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2549 2003-10-03 Jean-Pierre Roux
2550 * A few nasty patches to allow the reading of a lot of nasty images
2551 ( e.g : well known GE images with a wrong elem length,
2552 : Philips MRI Images with a wrong Huffman table)
2553 * still to be done : allow the reading of bugged LEONARDO Siemens images
2555 2003-10-03 Jean-Pierre Roux
2556 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2558 2003-10-03 Jean-Pierre Roux
2559 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2560 to allow displaying RGB images (not only by affim ;-)
2562 2003-10-03 Jean-Pierre Roux
2563 * gdcmFile::GetImageDataIntoVector now
2564 - deals with MultiFrames MultiFragments Run Length Encoded files
2565 - deals with YcBcR (YBR_FULL) files
2566 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2567 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2569 (no sample found :-(
2571 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2572 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2573 Two reasons: - clear things
2574 - third parties acces gdcm through header files, so won't
2575 suffer anymore VC++ complains
2577 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2578 * add argv[1] in testvtkGdcmReader.cxx
2581 2003-09-24 Jean-Pierre Roux
2582 * The lines are now eigthy characters long.for
2583 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2585 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2586 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2587 char* to std::string. Thus, the use of strdup becomes useless. (see
2588 previous commis of Malaterre)
2589 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2590 before the last Malaterre's commit.
2592 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2593 * This commit should fix the Debug building under VC++, the problem
2594 was mainly a mixture of debug and release lib being loaded at startup.
2595 * I also remove a depency to a specific C function: strdup. Because I had
2596 to force the link to msvcrtd (whereas strdup is in libc).
2598 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2599 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2600 located in the gdcmCommon.h file. All use of reference of tha has been
2601 changed to now use the variable GDCM_UNFOUND.
2603 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2605 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2606 Dicom dictionary. The test suite can now be run again. Note:
2607 I'm note very happy with the " (RET)" changes. I believe this
2608 RETAINED comment should be dropped when parsing the dictionary.
2609 - PACKAGER corrected
2611 - AUTHORS updated and now in alphabetical order
2612 * Makefile.am now exports gdcm.dsw for Windoze users.
2614 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2615 * cygwin complains about missing std:: in subdir Test/
2617 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2618 * remove some methods that are now in gdcmHeaderHelper
2620 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2621 * vtkGdcmReader set spacing and origin correctly
2623 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2624 * Fix a few delete/delete[] mismatch
2626 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2627 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2628 interpretation to data given by gdcmHeader. For instance there are
2629 heuristics to get informations (look at different places).
2630 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2631 sorting DICOM images based on different strategies.
2632 * modified Makefiles accordingly.
2634 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2635 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2636 when building in debug mode
2637 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2638 src/win32/gdcmdll.dsp
2639 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2641 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2642 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2645 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * src/win32/libgdcmjpeg12.dsp was not dos format
2647 * src/win32/libgdcmjpeg12.dsp :
2648 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2649 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2651 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2652 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2654 * src/gdcmFile.cxx : bug fix in affectation type
2655 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2656 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2657 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2658 symbols... future problem ?
2660 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * src/win32/libgdcmijpeg12.dsp was missing
2662 * modified gdcm.dsw accordingly
2664 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2665 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2667 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2668 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2669 commit of JPR (before his hollidays to facilitate our work).
2670 * setup.py : bug fix in code. Modifications made while the last commit
2671 of JPR. The code hasn't been tested before the commit... it's so
2672 useless to make that (for best programmer that is JPR) !!!
2674 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * tagged the current version as Version0_3 (i.e. version 0.3)
2677 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2678 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2679 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2680 * *.dsp : modifications to use new libgdcmijpeg8 library
2681 * setup.py : bug fix on VTKPATH variable
2682 * PACKAGER : adding all concerning windows
2684 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2687 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2688 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2689 test suite reported error.
2690 * PACKAGER file added (describes what a packager must do when
2691 packaging a new release).
2692 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2693 * configure.in: upgraded version number to 0.3.0
2694 * fixing build of rpm (through rpm -ta):
2695 - Doc/Makefile.am exports proper doxygen files
2696 - src/jpeg/libijg8/Makefile.am exports the include files.
2698 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2699 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2700 * src/gdcmHeader.h : formatting code
2702 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2703 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2704 We were obtaining error message from vtk. Now, creation of file list
2705 is made in an internal list to prevent this problem.
2706 Bug fix when output is empty.
2707 Bug fix in update of progress value. Previous commit for this was a bad
2709 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2711 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2712 * src/gdcmHeader.h : added method to get the file name
2713 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2714 files. Added method to remove all files on the input
2715 Added FIXME comment concerning the bad parsing of header made by
2716 ExecuteInformation method (in ExecuteData method)
2718 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2719 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2720 when using make instal.
2721 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2722 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2724 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2725 * setup.py : adding include dir of jpeg lib to compile all sources
2726 * */Win32/*.dsp : JPR fix for windows compilation
2728 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2729 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2731 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2732 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2734 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2735 * setup.py is again effective on un*x (takes into account the
2736 addon of the jpeg library)
2737 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2738 * Doc/Doxy* updated (includes above enhancements)
2739 * INSTALL now points to web documentation
2741 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2742 * src/gdcmHeader.h doesn't make unnecessary reference to
2744 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2746 * src/gdcm*.[cxx|h] :
2747 - to allow compilation with gcc 3.x
2748 -- clean up of STL usage (added explicit usage of std::)
2749 -- small fixes on exceptions.
2750 Note: linking not tested !
2751 - clean of doxygen comments to avoid warnings at documentation
2753 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2754 dependent convertion).
2756 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2757 * Clean up of previous JPR garbage commit (not even commented in the
2759 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2760 - moved all jpeg related files from src to src/jpeg/libijg8, with
2761 addition/modification of Makefile.am and configure.in.
2762 - the testSuite is still brain damage (not guilty).
2764 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2765 * WrapVTK.py : modifications to get correctly vtk source files to
2767 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2768 (FileName -> Filename)
2770 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * vtk/vtkGdcmReader.[cxx/h]:
2772 - UpdateProgress method should now be effective
2773 - removed the limitation on having only images loaded (as opposed
2775 - when building a stack of images/volume, a lesser number of
2776 gdcmHeader and gdcmFile instances should be used (hopefully
2777 accelerating things).
2778 - when building a stack of images/volumes, files which are not
2779 loadable (wrong path-filename, wrong permissions on existing file,
2780 or file not parsable by gdcm) are replaced with a black image
2781 in the stack (for the caller to notice the problem).
2783 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2786 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2787 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2788 between standard library (std) and vtk library (problems are found
2789 under Windows... thanks Windows !)
2791 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2792 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2794 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2796 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2799 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2800 * When compiling with distutils (see setup.py) the C++ compiler is
2801 called with different flags than the default ones (with automake).
2802 In order to fix all those warning, I compiled gdcm with the command
2803 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2804 and went for warning fixes:
2805 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2806 up from unused variables.
2807 - vtk/vtkGdcmReader.cxx: potential bug fix.
2808 * src/gdcmHeader.h: Doxygen warning cleanup
2810 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2811 * gdcmPython/gdcm.i:
2812 - typemaps correction to take into account the systematic replacement
2813 of "using namespace std" with std:: prefix e.g. std::list,
2814 std::string... (cf changes of 2003-05-21).
2815 - gdcmGlob global variable of type gdcmGlobal (defined in
2816 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2817 exported to Python a as cvar.
2818 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2819 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2820 gdcmDictSet.GetPubDictTagNames() and
2821 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2822 C++ static methods).
2823 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2824 with the above changes.
2826 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2827 * setup.py, manifest.in : bug fix under linux
2829 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2830 * Modification of setup.py to compile vtk part too. Then, we have 2
2831 wrappers which must work with same distutils. For that, we have a
2832 generic distutils in distusiltsWrapping.py ; with :
2833 - build_extWrap class to wrap generically all extensions,
2834 - ExtensionWrap base class for all wrapping extension that contains
2836 - Wrapper interface which wrap sources
2837 + In WrapSwig.py we have extension and wrapper for Swig
2838 + In WrapVTK.py we have extension and wrapper for VTK
2839 * MANIFEST.in : modifications to consider vtk directory and new python
2840 files for compilation
2842 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2843 * Added python wrappers of vtkGdcmReader vtk class (see the
2844 source in vtk/vtkGdcmReader.cxx) :
2845 - vtk/Makefile.am now builds a library
2846 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2847 python library (as opposed to _gdcm.so wich are the python
2848 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2849 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2851 - configure.in has an additional flag --enable-vtk that needs
2852 to be set to enable compilation of vtk related code, that is:
2853 + vtk/vtkGdcmReader.so and
2854 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2855 + gdcmPython/vtkgdcmPython.so (see above)
2856 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2857 be read when compressed or when HighBit + 1 != BitsStored),
2858 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2859 the usage of the python wrapper of vtkGdcmReader vtk class.
2860 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2861 * src/*.[h] all occurences of stl classes are now prefixed with
2862 std::, and all occurences of "using namespace std;" where removed.
2863 This is to avoid pollution of global namespace in included files.
2864 Apparently vtk does not avoid this pitfall: when using both
2865 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2866 collision of various stl members (principally cout...).
2867 * gdcmPython/testSuite.py now cleanly removes temprory generated
2869 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2870 comply with above changes)
2872 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2873 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2874 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2875 vtk data structure (an image Flip was required).
2876 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2877 * cosmetic changes in documentation.
2879 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2880 * src/gdcmHeader.cxx: the constructor no longer exits when an
2881 unexisting file is given as argument.
2882 * The subdirectory Data (containing all the images used for the
2883 test suite) is not part of this repository anymore. A new module
2884 containing those images is now available at
2885 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2886 with the name gdcmData.
2887 All the python scripts (including the package initialisation file
2888 gdcmPython/__init__.py) were adapated to take this change into
2889 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2891 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2892 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2893 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2894 demo of the usage of this class.
2895 Compilation of this vtk part is only done when using the --enable-vtk
2896 at configure (or autogen.sh) stage.
2898 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2899 * More memory link related corrections and documentation fixes.
2901 - maximum info is obtained with a command of the form:
2902 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2903 --show-reachable=yes PrintHeader
2904 - the remaining reachable blocks seem to come from the STL
2905 allocation scheme through the usage of map and list. It looks
2906 like this memory cannot be freed but it is not a memory leak
2907 (in fact further invocation to the STL would recollect the
2908 unused memory allthough it cannot explicitely be freed).
2909 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2910 of displaying an image parsed with gdcm and displayed with VTK.
2911 Note: some images don't seem to work e.g.
2912 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2913 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2914 Allthough this weakens the semantics, it is a ditch attempt to
2915 make gdcm more thread friendly.
2917 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2918 * Memory link hunt (by using valgrind through the command
2919 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2920 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2921 gdcmHeader::_dicom_vr.
2922 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2923 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2925 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2927 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2928 * src/Makefile.am now exports all the necessary include files at
2932 * UpdateGroupLength replaced by new one
2935 * UpdateGroupLength re-written using H-Table
2936 (named UpdateGroupLengthNew untill checks are over)
2938 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2939 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2940 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2942 - gdcmHeader::GetPubElValSet removed.
2943 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2944 UpdateGroupLength, WriteElements, Write.
2945 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2946 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2947 carried the same semantics.
2948 - src/gdcmHeaderIdo.cxx changed accordingly.
2949 - gdcmFile::WriteBase now regroups all the codes from previous
2950 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2951 - enum FileType moved to gdcmCommon.h
2952 * src/gdcmHeader.cxx AddDefault trashed
2953 * gdcmGetXSize added
2954 * getimageDataSize now calls gdcmGetXSize
2955 * Test/*.cxx changed to agree with above changes
2957 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2958 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2959 (to avoid double call by end user).
2960 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2961 by end user, since gdcmHeader::gdcmHeader now handles it.
2963 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2964 * gdcm/Doc many doxygen changes:
2965 - Doxyfile now has two different versions, DoxyfileUsers that generates
2966 the html.users end users oriented documentation and
2967 DoxyfileDeveloppers that generates the html.developper developper
2968 oriented documentation.
2969 - README changed accordingly
2970 - requirement.txt removed (old design info moved to TODO).
2971 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2972 DoxyMainPage.txt, DoxyPython.txt provide more information.
2973 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2974 be updated by simply regenerating the docs with doxygen and copying
2975 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2976 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2977 all the tests in the form "if (<map>.count() >1)" were removed.
2978 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2979 ill-formed documentation sections.
2980 * src/gdcmHeader.cxx: ditto
2982 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2983 * setup.py fixed for un*x (needed macro for stdint.h)
2984 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2985 un*ces with sh-utils test utility.
2986 * gdcmPython/demo/test.py renamed to PrintHeader.py
2987 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2988 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2989 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2990 * src/gdcm*.cxx JPR's bad inclusion fixed.
2992 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2993 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2994 * gdcmPython/demo/test.py changed accordingly.
2996 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2997 * gdcmPython/Makefile.am fixed linking against libstdc++
2998 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2999 * Swig subdir (historical tests of swig version 1.3.17++) removed
3000 * Test/testChangeEntete.cxx some lines commented out in order to make
3002 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3003 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3005 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3006 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3007 hence the user doesn't need this explicit call.
3008 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3009 i.e. LoadElements() call removed.
3010 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3011 - src/Makefile.am declares the proper flag for g++.
3012 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3013 for adding user defined new tags.
3014 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3015 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3016 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3018 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3019 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3020 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3021 src/Makefile.am : the project should properly compile and install
3022 with the autotools, included the python wrappers part.
3023 * gdcm.spec.in : added a spec file for RPM packaging.
3025 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3026 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3028 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3029 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3030 to exported to the environement (see gdcmPython/testSuite.py
3032 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3033 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3034 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3035 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3036 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3038 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3039 * gdcmPython/__init__.py doesn't crash anymore when running in
3040 in InstallMode or PreInstallMode but with an environment given
3041 value of GDCM_DICT_PATH.
3042 * src/gdcmDictSet.[cxx/h] coding style.
3044 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3045 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3046 * src/gdcm.h general comments moved to TODO, and README
3047 * src/gdcm.h should now be seen as a user commodity (including it
3048 should suffice to fully use gdcm). It is nowhere including within
3049 any of the kernel files src/*.cxx and src/*.h.
3051 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3052 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3053 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3055 * src/gdcm*.cxx only include their corresponding include file
3056 (as opposed to gdcm.h)
3057 * gdcmPython/gdcm.i changed accordingly
3058 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3059 the autogen.sh generated "make snapshot" command to work.
3060 * autogen.sh removed history related references to crea package.
3062 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3063 * distutilsSwigCPlusPlus.py work around some swig portability
3066 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3067 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3068 was done in a last ditch attempt to get setup.py _really_
3069 operationnal. The python/gdcmPython layaout add the advantage
3070 of hidding away the python related distutils specific files
3071 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3072 Alas, the src directory was out of scope (i.e. it's relative
3073 position to setup.py was ../src) which made things impossible to
3074 handle (see previous version of python/setup.py). Crossing fingers...
3076 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3077 * python/setup.py now works on Un*x. (harder than I thougth)
3078 * python/distutilsSwigCPlusPlus.py can now have include files
3079 among the list of sources.
3081 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3082 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3083 * modifications in MSVC projects
3085 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3086 * As stated by the first lines of Test/ExceptionAndPython/README, it
3087 looks like we can move back to original usage of exception within
3088 src/gdcm* and hence remove the errno stuff that was introduced
3089 as a quick and dirty fixture of this problem (added to the TODO).
3090 * Doc/Doxyfile configuration file for Doxygen and corresponding
3091 README file for usage added.
3092 * Test/testWrite.cxx added. This new test comes from a split of
3093 test.cxx that is now reverted to its original purpous i.e.
3094 testing the proper parsing of a Dicom related file.
3095 testWrite.cxx concentrates on testing the IO part of gdcm.
3096 * Test/bug1.cxx (containing a bug on WIn32) added.
3097 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3098 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3099 whose purpose is to publish the content of the TagNames of the
3100 Dicom public dictionary were not accessible without an
3101 instance of class gdcmHeader.
3102 - those methods are now static methods of gdcmDictSet and hence
3103 require no instances at all to be invocated.
3104 - within gdcmDictSet this change required to change some method
3105 to class methods (i.e. are now static) among which SetDictPath
3106 (renamed to BuildDictPath) and LoadDefaultPubDict.
3107 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3108 the above changes by calling the new method classes of gdcmDictSet.
3109 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3110 the above to be effective.
3111 * python/gdcmPython: in order to wrap properly the above changes
3112 for Python, swig version now needs to be > 1.3.17.
3113 * python/gdcmPython/Makefile fixed to adapt itself to new
3114 configure/make shema introduced by Johan Montagnat (thanks for the
3115 contribution). Alas this Makefile cannot be turned into a proper
3116 Makefile.am without some heavy changes in the configure.in
3117 (for python dectection).
3118 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3119 now avoids publishing the empty entries.
3121 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3122 * python/setup.py : bug fix concerning install under windows
3123 ExtraPath reused :-P
3124 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3126 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3127 * Dicts/dicomV3.dic : remove double spaces !!!
3128 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3129 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3132 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3133 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3134 method. Doxygenation.
3135 * src/gdcm.h clean up of JPR spurious comments.
3137 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3138 * python/distutilsSwigCPlusPlus.py now properly collects the
3139 shadow classes generated by "swig -c++" (gdcm.py in our case)
3140 when using "python setup.py install".
3141 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3142 reexports the working classes.
3143 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3144 by the classical C errno scheme. This is to prevent an obscure
3145 behavior of the python wrappers when importing wxPython.wx prior
3146 to gdcmPython (which ended up in an abort call). An illustration
3147 of this oddity can be found in the Test/ExceptionAndPython
3148 subdir (see the README file). This problem probably due to
3149 an combination of g++ and dynamic loading.
3150 * added Test/ExceptionAndPython (see above)
3152 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3153 * Changed the layout of the python part to avoid bloating main
3154 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3155 i.e. the distutils arsenal. All the python related stuff is
3156 again in a python subdir, but the package itself is now in
3158 * setup.py was cleaned up:
3159 - pythonIncludePath removed
3160 - python setup.py bdist target is now functional.
3161 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3162 collision with other packages). gdcmPython/demo/*.py changed
3165 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3166 * python subdir moved to gdcmPython (preparation of distutils packaging).
3167 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3168 distutils installer is operational.
3169 * - gdcmPython/__init__.py now properly loads the swig generated
3170 shadow classes (from gdcm.py).
3171 - gdcmPython/demo/*.py changed to import the package gdcmPython
3172 instead of gdcmPython/demo/load.py.
3173 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3175 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3176 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3177 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3178 entries within the associated public Dicom dictionary resp. the same
3179 information but sorted by the fourth field (PAT, IMG, DIR) of the
3181 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3182 are now in the "???" group.
3183 - python/gdcm.i changed accordingly,
3184 - python/demo/printGroupedPublicDict.py added, that gives an example
3185 of the above new functionalities in Python.
3187 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3188 * src/gdcm.h, gdcmHeader.cxx:
3189 - historic references to glib's g_malloc and g_free (#defined)
3190 were definitively removed.
3191 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3192 * src/gdcmElValSet.cxx:
3193 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3194 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3195 - GetElValue(string) renamed to GetElValueByName.
3196 - Added GetElementByName(string).
3197 * src/gdcmHeader.cxx: added
3198 - GetPubElValRepByNumber(guint16, guint16)
3199 - GetPubElValRepByName(string)
3200 - GetShaElValRepByNumber(guint16, guint16)
3201 - GetShaElValRepByName(string)
3202 - GetShaElValByNumber(guint16, guint16)
3203 - GetShaElValRepByName(string)
3204 - GetElValRepByNumber(guint16, guint16)
3205 - GetElValRepByName(string)
3206 - GetElValByNumber(guint16, guint16)
3207 - GetElValRepByName(string)
3208 * Doc/requirements.txt added.
3210 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3211 * Test/Makefile building now depends on the one of libgdcm.so
3212 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3213 pixel data) aware which enables finding the address (offset) of
3214 the pixel data of JPEG encoded DICOM files. This leaves only a single
3215 file in the testSuite whose pixel data address (offset) is unknown.
3216 * python/testSuite.py changed accordingly.
3218 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3219 * VC++ has some strong limitations when working with the STL, as stated
3220 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3221 "Also note that some STL containers (map, set, queue, list, deque)
3222 cannot be exported. [...]
3223 Some STL classes contain nested classes. These classes can not
3225 This is caused by a designed limitation that once a template
3226 class is instantiated, it can not be re-instantiated and
3228 Since our usage of map<> is ubiquitous in gdcm, this "designed
3229 limitation" of VC++ is a pitfall.
3230 Hence the Python wrappers of gdcm cannot be incrementally linked
3231 against the c++ dynamic library. The dirty but only workaround is
3232 to forget about incremental link of dynamic libraries and to generate
3233 the Python wrappers library with the inclusions of the underlying C++
3235 The following modifications concern this matter on Win32/VC++:
3236 - wrapping python correct with standalone wrapped dll (don't use separate
3237 dll under windows !!!!)
3238 - python21_d debug mode enabled (ask Frog how to use it :-)
3239 - NO problem with having an STL member of class for example string in C++
3240 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3241 - Python test of dcmlib in Python is ok under windows on a large set
3243 * removed glib references
3244 * typedef's inserted in gdcm.i for correct swig type management
3246 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3247 * python/demo/*.py load.py extracted from test.py. Added explore.py
3248 that only displays required tags and testAll.py that parses all
3249 the files of the testsuite without using unittest.
3250 * python/testSuite.py other additional test on new files added.
3251 * Data/* new test files added accordingly to the testSuite.
3252 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3253 the vr in the file differs from the one of the dictionary.
3255 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3257 values, but limits itself to values which are below a user specified
3258 size (by default 1024 bytes).
3259 * python/gdcm.i : elements not loaded (because their size is above the
3260 user specified treshold) are exported with their TagKey as key of the
3261 python dictionary. This enables the testsuite to make some checks
3262 on the unloaded elements (since we have their offset and size).
3263 * python/testSuite.py
3264 - now tests for the existence and proper value of the pixel data
3265 - two new examples added.
3266 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3268 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3269 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3270 aware. See the strategy comments in gdcmHeader::FindLength().
3271 * Test/test.cxx now accepts a filename as first argument.
3272 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3273 * python/testSuite.py changed to integrate test on above files.
3275 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3276 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3277 the vr was also RET.
3278 * python/testSuite.py more tests added.
3280 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3281 * python/testSuite.py unittest test suite added (uses Data)
3282 * Data/* dcm and acr files for the test suite.
3283 * glib dependance removed from un*x version. We now use ISO C99
3284 7.18 Integer types (see stdint.h)
3285 - python/Makefile, src/Makefile src/gdcm.h
3286 * src/ when an explicit vr (like dicom files) suddenly poped an
3287 implicit element we use to mark the underlying DictEntry of the
3288 concerned ElValue with "Implicit". This strategy was damageable
3289 too the public or provite dictionaries, since some of their vr
3290 would be changed. Since Header::FindLength heavily relies on the
3291 detection by Header::FindVR of falsely explicit elements, I
3292 added an extra ImplicitVr member to ElValue (boolean).
3293 The rest of the changes we the necessary adaptations.
3295 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3296 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3298 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3300 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3301 * Adaptation for porting to VC++:
3303 o forced to use std namespace (for string to be known)
3304 o all class use __declspec export style on WIN32
3305 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3306 (in stdlib.h on Win32 but in std:: for gcc)
3307 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3308 variable GDCM_DICT_PATH.
3309 * src/gdcmHeader.cxx verbose comments made discrete.
3311 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3312 * python/gdcm.i: added a typemap that converts a C++ hashing table
3313 to native Python dictionary.
3314 * python/demo/test.py:
3315 - now uses the native dictionary for exploration of gdcmHeader.
3316 - takes an optional filename argument (the file to parse).
3317 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3318 PubElVals hashing table.
3319 * Dicts/dicomV3.dic removed error prone trailing spaces.
3321 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3322 * Python wrapping process moved away from src/Makefile to
3323 newly created python/Makefile (as well as gdcm.i)
3324 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3325 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3326 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3327 from the environement variable GDCM_DICT_PATH (when existing).
3328 * src/gdcmDict::GetTag bug fix.
3330 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3331 * Straightforward temporary fixes for swig to build the python wrappers.
3332 src/Makefile now has a python working entry [by working we mean
3333 that we can import the shadow classes without errors].
3335 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3336 * hashtest.cxx removed (since already in Test)
3337 * src/gdcmlib.h renamed to src/gdcm.h
3338 * src/dcm.i renamed to src/gdcm.i
3339 * src/Makefile prepared for python wrapping
3341 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3342 * src/gdcmHeader.cxx :
3343 - Parsing of header is now separated from loading of element values
3344 (see gdcmHeader::LoadElements).
3345 - general clean up of hopefully all file access (creation of
3346 ReadInt16 and ReadInt32)
3348 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3349 * src/gdcmHeader.cxx :
3350 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3352 - SetLgrElem renamed to SetLength
3353 - GetLgrElem renamed to GetLength
3354 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3355 * src/gdcmElValSet.cxx fixed both GetElValue methods
3356 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3357 due to IdoDude was cleaned out.
3359 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3360 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3361 concentrates on finding the value representation (when it exists).
3362 RecupLgr now only finds the element value length, and it avoids
3363 returning the unecessary skL (skipped length).
3364 Also, offsetCourant was simply removed (with taille_fich) since
3365 it was redundant with the File position internals (by using
3366 ftell and fseek). This also made skL (see above in RecupLgr) usage
3368 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3369 on the libido specificities which are handled through class
3371 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3374 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3375 * Truckload of changes. Parsing of header is barely functional
3376 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3378 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3379 * src/gdcmHeader.cxx many addons of low level methods
3381 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3382 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3383 and _IdDcmSWAP_LONG.
3385 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3386 * This corresponds to all the changes decided at the meeting of
3387 May 23 2002. Needless to say we are running late...