1 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
3 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
4 variable (instance of gdcmDebug) by a definition macro, and the instance
5 is now in static in the gdcmDebug class
6 * src/gdcmSQItem.h : (FIXME) remove an undefined method
7 * Test/PrintAllDocument.cxx : bug fix in the result of the test
9 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
10 * WARNING: ctest now depends more tightly on gdcmData. You should
11 check out gdcmData properly for things to run smoothly...
12 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
13 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
14 we need the pixels not be loaded in order to use the ValEntry
15 that displays position and size).
16 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
17 This is a C++ based equivalent of gdcmPython/testSuite.py that should
18 be deprecated. If you have any doubts about the advantages of a
19 modern scripting language (read Python) versus grass root C++ (i.e.
20 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
21 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
22 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
23 Anyhow, consider documenting the gdcmData images in
24 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
26 * Test/CMakeLists.txt:
27 - now uses TestAllEntryVerify.cxx
28 - specific comments on oldACR00001.ima (now renamed in gdcmData
29 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
30 gdcmData/TestAllEntryVerifyReference.txt
33 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * src/*.[h|cxx] : typedef clean up
35 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
36 - TagKey renamed to gdcmTagKey (for external usage)
37 - VRKey renamed to gdcmVRKey (for external usage)
38 - removal of typedef duplication.
39 - Removed all unecessary inline keyword from class inline definitions.
40 - Some method|function(void) declarations replaced with method|function().
41 * src/jpeg/libijg12/jdhuff12.c:
42 - printf polluting ctest removed.
43 - TAB removal for comminting
45 - TestAllReadCompareDicom.cxx: added a test that compares all the
46 images in gdcmDataImages.h with corresponding images in
47 gdcmData/BaselineDicom/. When baseline images are not present
48 this test creates them.
49 Note: we need to validate each reference image, but before that
50 I'd like to rename them with a more explicit name...
51 - CMakeLists.txt: changed accordingly.
52 * Example/*.cxx: examples now only include gdcm.h (as opposed to
53 including each header needed).
55 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
56 * Test/*.cxx and Example/*.cxx: moved some examples away from the
57 test suite to the Example directory. Are concerned:
63 * Test/CMakeLists.txt: added some comments on reasons for black listing
64 image gdcmData/oldACR00001.ima
66 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
67 * Test/CmakeList.txt: removed the following from black list (to be coherent
68 with removal from gdcmData):
69 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
70 - gdcm-MR-PHILIPS-16.dcm
72 Added the following because after last cvs update, they cause
73 ctest -R TestReadWriteReadCompare
75 - gdcm-MR-SIEMENS-16-1.acr
77 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
78 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
79 new comments in this file) we temporarily (sigh) move to a weaker
81 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
82 we don't need to black list the following images anymore:
83 - 8BitsUncompressedColor.dcm
85 - US-PAL-8-10x-echo.dcm
86 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
87 fixes and the beautified code ;-)
88 This fixes the bug introduced in version 1.42 (when beautifying)
89 that made the parsing of 8BitsRunLengthColor.dcm unproper.
90 Note: ctest was blind to this bug (this means we need to still
91 improve the test suite). The bug could be detected by using
92 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
94 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
95 and by displaying the (garbage) produced file temp.XDCM...
97 2004-06-29 Jean-Pierre Roux
98 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
99 - replace by uggly but working old code :-(
100 A lot of things should be OK again.
101 It's really urgent to have a test suite that *tests*,
102 to prevent Frog's beautifying sessions to break all the stuff
103 (twice, withing a fortnigh ...)
105 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
106 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
107 redundancy) to added Test/TestReadWriteReadCompare.cxx
108 * Test/CmakeList.txt: because the compare test of
109 Test/TestReadWriteReadCompare.cxx fails, the following images are
110 black listed: - 8BitsUncompressedColor.dcm
112 - US-PAL-8-10x-echo.dcm
113 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
114 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
115 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
116 and ad-hoc kludge. This kludge is now removed, and on encountering
117 such an image (OB field brain damaged) we set errno. Then in
118 ::FindDocLength() we "fix" the length as being ALL what remains
119 in the file (until EOF). We then proceed, hoping for the best...
120 This fixes a SegFault in ShowDicom when trying to write such an
122 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
123 (because TestWriteRead breaks on it, after a non conformal commit?).
124 ctest now runs properly, except for MakeDicomDir (which was allways
125 broken) and the Python related stuff (still not fixed).
127 2004-06-24 Jean-Pierre Roux
128 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
129 FIX : Test/TestReadWrite now iterates on all the file names
130 (instead of infinite loop)
131 ENH : Test/TestWriteRead now iterates on all the file names
133 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
136 2004-06-24 Jean-Pierre Roux
137 FIX : - now Write drops LUT Descriptors and LUTs (if any)
138 when SamplesPerPixel =3
139 - now Write is no longer confused by
140 'BitsAllocated = 12" and 'BitsStored=12"
141 - "UN" value representation Elements are now written correctly
142 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
143 ENH : - now gdcmHeader has its own Write methods
144 (in order to split the job that has not to be done
147 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
148 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
149 loop on the same image until memory went out.
150 Note: this means we still have gobs of memory loss in PrintDocument
151 * src/gdcmDocument.cxx: fixes problem on parsing on file
152 gdcmData/16BitsJpegLosslessGrayScale.dcm.
154 2004-06-24 Jean-Pierre Roux
155 FIX : Write - All the Sequences and Sequence Item are now written
156 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
157 is added a the end, when necessary.
158 - A lot of brain-damaged images, that were read correctly are
159 now written correctly
160 - length compatible BinEntry are now loaded correctly
161 (even for odd groups)
162 Note : only Explicit Value Representation was checked.
163 (question : is implicit VR really necessary for gdcm ?)
165 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
166 * DEVELOPPER: added a proposition of coding style.
167 * src/gdcmDocEntry.h: removed every inline declaration (for test of
170 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
171 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
172 Use the gdcmDocEntry::Print() and Write() instead.
173 * src/gdcmDocument.cxx: bug fix.
175 2004-06-22 Jean-Pierre Roux
176 FIX : gdcmDocument.cxx
177 - Now we do recognize the JpegLossLess format (there was a misstyping in
178 code 'beautyfication' :-(
179 - Now we automaticaticaly load the Luts, if any
181 2004-06-22 Jean-Pierre Roux
182 In order : to write Sequences, whatever their imbrication level,
183 : to allow user to create his own Sequences
184 a lot of modif where necessary (adding, moving, or virtualising methods)
186 WARNING : save your own sources *before* cvs up !
189 ADD virtual void Write(FILE *fp, FileType filetype);
192 ADD virtual void Write(FILE *fp, FileType filetype);
193 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
196 ADD virtual void Write (FILE *fp, FileType filetype)=0;
197 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
198 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
199 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
200 ADD std::string GetEntryByName(TagName name);
201 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
203 std::string vr = "unkn",
204 std::string fourth = "unkn",
205 std::string name = "unkn");
206 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
207 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
208 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
209 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
210 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
211 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
212 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
213 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
216 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
217 ADD virtual std::string GetEntryByName (TagName tagName);
218 ADD virtual std::string GetEntryVRByName (TagName tagName);
219 REM virtual bool Write(FILE *, FileType);
220 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
221 FILE *_fp, FileType type);
222 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
223 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
224 REM virtual bool WriteEntries(FILE *_fp,FileType type);
225 REM virtual std::string GetEntryByName (std::string tagName);
226 REM virtual std::string GetEntryVRByName (std::string tagName);
227 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
228 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
229 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
231 std::string vr = "unkn",
232 std::string fourth = "unkn",
233 std::string name = "unkn");
234 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
235 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
236 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
237 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
240 ADD virtual void Write(FILE *fp, FileType filetype);
243 ADD virtual void Write(FILE *fp,FileType filetype);
246 ADD virtual void Write(FILE *fp, FileType filetype);
247 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
248 REM std::string GetEntryByNumber(guint16 group, guint16 element);
249 REM std::string GetEntryByName(TagName name);
252 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
254 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
255 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
256 The default constructor invoked by the line
257 gdcmHeader *f1 = new gdcmHeader( header );
258 was gdcmHeader::gdcmHeader(bool) instead of the expected
259 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
260 Hence the parsing wasn't executed... See also below.
261 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
262 as explicit constructor didn't do the trick to fix the above problem.
263 Could anyone explain why ?
264 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
265 properly calls gdcmValEntry::Print() (that was weed out from
266 code related to gdcmBinEntry).
268 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * In order to fix memory leaks:
270 - Test/TestWriteSimple.cxx: added cleaning of free store through
272 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
273 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
274 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
275 (through the call to ::AddDicomDirMeta()) or the destructor
276 would crash when deleting uninitialized ::metaElems].
277 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
278 - src/gdcmDocument.cxx:
279 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
281 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
282 was causing memory leaks.
283 - src/gdcmSQItem.cxx:
284 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
285 cleanly handled with polymophism: sorry but my milage is low).
286 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
287 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
288 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
289 This avoids SegFaulting.
290 - src/gdcmSQItem.h: coding style.
292 - Test/TestWriteSimple still severely sucks. The output image content
293 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
294 damaged when displayed with vtkgdcmViewer.
295 - on memory leaks: TestWriteSimple leaks really less (see entry
296 of 2004-06-18 in Changelog file for the call to valgrind).
297 - on segfaults: ctest now passes all the tests but one (no more
299 * Erroneous leading white fix:
300 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
301 white[s] (as opposed to from >> xxx, that removes it [them].
302 - src/gdcmTS.cxx: ditto.
303 - gdcmPython/testSuite.py: dirty related kludge removed.
304 * src/*: remaining references to gdcmParser removed.
305 * src/*[cxx|h]: added copy[way]left header.
308 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * In order to fix writing of dicom files:
310 - Test/TestWriteSimple.cxx: a simpler example of writing.
311 - Test/CMakeLists.txt changed accordingly.
312 - src/gdcmDocument.cxx:
313 -- The destructor now recursilvely removes potential sequences.
314 -- Bug fix in ::IsJPEG2000()
315 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
316 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
318 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
319 to only declared) and build on top of
320 ::GetDocEntryByNumber(guint16, guint16).
321 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
322 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
323 for usage in destructor and treatement of promotion in
324 ::ReplaceOrCreateByNumber().
325 - src/gdcmSQItem.cxx: destructor should better handle his job.
326 Test/TestWriteSimple now runs (or at least it DOES something).
327 * We can now start hutting memory links. A good starting point is:
328 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
329 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
330 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
332 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * Valgrind note: after Mathieu Malaterre teached me how to read
334 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
336 Using gcc, you can force the STL to use malloc and to free memory as
337 soon as possible by globally disabling memory caching.
338 With 3.2.2 and later, you should export the environment variable
339 GLIBCPP_FORCE_NEW before running your program.
340 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
341 simply vanish (it is still not clear to me, whether this means that
342 STL std::string leaks or if valgrind believes it leaks...).
343 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
344 running bin/gdcmTests makeDicomDir):
345 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
346 - Test/makeDicomDir.cxx now properly traps empty lists and returns
348 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
349 SegFaulting (I drowned in DicomDir related code when trying to
350 understand why the list is empty...).
351 * src/gdcmDocument.h: first BSD license header try.
352 * Doc/License.txt added.
354 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * src/gdcmDocument.[h|cxx]:
356 - Clean up of the Transfer related predicates. They are now all based
357 on new method isGivenTransferSyntax, that (should) handle properly
359 - general clean up, simplification, and coding style.
360 - Specific clean up of Parse7FE0() (umproperly named actually).
361 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
363 2004-06-14 Jean-Pierre Roux
365 - fix the display of Sequence Delimitor (SQDepthLevel pb)
366 - fix the display of SQItem ordinal number
367 - add the GetSQItemByOrdinalNumber method
368 - remove some useless never written private methods
370 2004-06-14 Jean-Pierre Roux
372 - adding a constructor taking a gdcmDocEntry as an input param
373 - ReplaceOrCreateByNumber now returns :
374 a gdcmBinEntry * if a Binary (void *) value is passed as a param
375 a gdcmValEntry * if a string value is passed as a param
377 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
378 according to the param type (no longer sets a gdcmDocEntry)
379 - GetValEntryByNumber, GetBinEntryByNumber added
380 - NewValEntryByNumber and NewBinEntryByNumber added
382 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
384 - GetSQItemNumber and SetSQItemNumber added, to provide
385 a (relative) Item identier inside a given Sequence
386 \warning : some pb remaining around this number
388 - AddEntry now takes the Item Number as a param
390 - adding a constructor taking a gdcmDocEntry as an input param
392 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * Memory leak hunt with the following command:
394 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
395 --show-reachable=yes gdcmTests PrintDocument
396 It looks like many (all?) leaks are due to the STL (or a bad usage
397 of the STL. The lines producing the leaks now have a comment with
398 a "MEMORY LEAK" tag: you can retrieve them with
399 grep "MEMORY LEAK" src/*
400 Here are two typical examples which I can't help fixing:
405 char * test = "babo";
406 name = test; //// <--- valgrind detects 960 bytes lost in
407 //// call to std::string::operator=(char const*)
408 name.clear(); //// Doesn't help !
416 std::cout << "Type a bunch of characters followed by RETURN: ";
417 getline(std::cin, line); //// <--- valgrind dectects a loss
418 //// of 1320 bytes in call to
419 /// std::basic_istream<>& std::getline<>
425 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * src/gdcmHeader.[cxx|h]:
427 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
428 and related, moved away to gdcmDocument.
429 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
430 the corresponding protected accessors of inherited class
431 gdcmDocument, removed ! As a consequence gdcmFile had to be
432 declared friend of class gdcmDocument (see below).
433 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
434 - Clean up of undefined or unused methods.
435 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
436 account the changes to gdcmHeader.h).
437 * src/gdcmDocument.h:
438 - gdcmFile is now a friend class (in order to take into account the
439 changes to gdcmHeader.h).
440 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
441 (see changes to gdcmHeader.h).
442 - Accessors (reading on the form GetEntry*) are now public.
443 - Clean up of undefined or unused methods.
444 * src/gdcmDocument.cxx:
445 - adaptation to changes to gdcmDocument.h
446 - ::OpenFile now writes a verbose message when file cannot be opened.
447 - some std::string properly set to VRKey
448 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
449 references to gdcmDocument.
450 * Test/TestFindTags.cxx: changed accordingly to above changes.
451 * gdcmPython/testSuite.py: adapted to renaming of acr files in
452 cvs repository gdcmData.
454 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
456 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
457 conflicts with gdcmValEntry::voidArea.
458 * src/gdcmValEntry.cxx: unmatching comment wiped out.
459 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
460 Value representation between StringRepresentable and BinaryRepresentable.
461 * src/gdcmDocument.cxx:
462 - method ParseDES: proper indentation restored and usage of
463 gdcmVR::IsVROfGdcmStringRepresentable wired in.
464 - method LoadDocEntry: the fingerprint left in the SetValue() of
465 unloaded entries (length > MaxSizeLoadEntry) had curiously been
466 removed. Reverting to previous code segment with the proper
467 dynamic_cast< gdcmValEntry* >.
468 Note: this was (partially) breaking the python test suite
469 (gdcmPython/testSuite.py) that made usage of the above
470 fingerprint to check presence of "Pixel Data".
471 * src/gdcmDocEntry.h: coding style.
472 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
473 now taken into account.
474 * gdcmPython/gdcm.i: adaptation to the new internal representation
475 of gdcm (exit gdcmParser, hello gdcmDocument).
476 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
478 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
479 anymore, but instead prints the loaded Python dictionary.
480 * .... alas, the python testSuite is still broken.
482 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
483 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
485 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
486 * src/gdcmUtil.h : export methods
488 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
489 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
491 * Initial addition of automatic python testing
492 * Initial addition of automatic image comparison
494 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
496 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
498 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
499 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
500 * Test/ShowDicom.cxx : bug fix for msvc compilation
501 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
503 2004-05-04 Jean-Pierre Roux
504 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
505 new concepts (and new classes) :
506 a 'gdcmDocument' is composed of a set of Doc Entries, that are
507 - elementary gdcmDocEntries (former gdcmHeaderEntries)
508 - Sequence Doc Entries (gdcmSeqEntries)
509 a Sequence is composed of Items.
510 Each item is a set of Doc Entries (this is recursive)
511 The non uniqueness of the 'Dicom tag' is due to this recursivity
512 (never taken into account)
513 Our unability to add a new 'entry' in the header
514 at the proper location (neither in the H-Table (map or multimap),
515 nor in the Chained List is also due to this recursivity.
516 Don't try, right now, to use/modify/compile these new sources :
518 We just commit all the stuff, 'as is', in order not to loose it.
520 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
521 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
523 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
525 file prefix (SetFilePrefix)
527 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
528 * Add a new test: ShowDicom, for now this is just the c++ version of
529 checkRead.sh, later it will be able to compare the image read against a
531 * Replace the DEBUG on the stack with a global entry in cmake interface:
532 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
534 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
535 * Add an example subdir, with a real example on how to read + write a
538 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
540 * Doc/CMakeLists.txt: the main page is now properly differentiated
541 between the developper and user version.
542 * Doc/doxygen.config.in: dropped search related obsolete flags
543 * src/gdcmParser.h, gdcmHeader.h: doxygenation
545 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * DEVELOPPER: added some helpfull comments for compile/test/install
549 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
550 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
551 src directory, now generated in the build dir.
552 2. Tests as mentionned smarter
554 4. Add a new method in gdcmDict that return the PubDict by name
555 this is interesting for 3rd party lib like ITK,
556 where we could set the institution name / patient name...
558 * ENH: 1. Now the test suite is working for real
559 2. All binaries are now output in the gdcm-bin directory
560 (this was not true before)
562 2004-04-28 Jean-Pierre Roux
563 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
564 SeQuence indented printing of Dicom Header.
565 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
566 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
567 Computation of SQDepthLevel is now part of gdcmHeader constructor
568 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
569 tree-like structure of a Dicom Header.
570 * FIX Test code cleaning
572 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
573 * ENH: Adding automatic testing
574 1. Need a DartConfig.cmake to submit to public
575 2. Add a test driver gdcmTest.cxx
576 3. gdcmTestMain, an helper for the main test driver gdcmTest
577 4. Files in Test don't have a main anymore, this becomes interesting
578 when we add more and more tests, thus dsw don't have to load
580 * ENH: Adding a GDCM_DATA_ROOT for testing
581 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
582 one file instead of seven + some small cleanup
584 2004-04-22 Jean-Pierre Roux
585 * ENH Minor changes to the Print() methods.
586 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
587 Header printing. Example given with :
588 > PrintHeader fileName 2 new
589 (SQ based tree-like structure still to be done for the Header ...)
591 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
592 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
593 1. I have added some unsigned where needed
594 2. Some function parameter not used -> (void)
595 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
596 4. g++ don't like character '\' in comment
597 5. #define jpeg_create_decompress jCreaDecompress
598 this really need to be fixed
599 6. virtualize destructor of gdcmObject ... leakage
600 7. sscanf(g->first.c_str(),"%x",&gr_bid);
601 this also really need to be fixed
602 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
603 remove compression file
604 (as we only do decompression, right ?)
605 * ENH: Change malloc/calloc/free with c++ equivalent
607 2004-04-21 Jean-Pierre Roux
608 * FIX gdcmHeaderHelper::GetXSpacing
609 when a single value is found (bug ?), xpacing is now
610 defaulted to yspacing
612 2004-04-19 Jean-Pierre Roux
613 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
614 * ENH add parameters :
615 bool exception_on_error = false,
616 bool enable_sequences = false,
617 bool ignore_shadow = false
618 to the gdcmFile constructors to be full gdcmParser compliant
619 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
620 to allow reading of PAPYRUS 3.0 files
622 2004-04-06 Jean-Pierre Roux
623 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
625 2004-04-02 Jean-Pierre Roux
626 * ADD : Test/checksequence.sh, for a general recap on SQ pb
627 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
628 for Philips spurious Tag fffe|0000 while rewritting Dicom files
630 2004-03-30 Jean-Pierre Roux
631 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
632 for ACR file, written out as DICOM files (hope so...)
634 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
636 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
637 moved to base class gdcmParser and only the specialisation is kept
639 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
640 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
641 already does the job.
642 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
643 (to be consistent with gdcmParser::WriteEntries).
645 2004-03-30 Benoit Regrain
646 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
647 upate of the object's instance. It's passed to 2 in the unfavorable
648 case : one in the ExecuteInformation, one in the ExecuteData
650 2004-03-29 Jean-Pierre Roux
651 * ENH : Check on file type to be written moved
652 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
653 * FIX : gdcmObject::ResetBoundaries now stops properly
654 when end-of-list is reached
655 : gdcmVersion modified (as Benoit Regrain asked)
657 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
659 * src/gdcmUtil.cxx: added forgotten iostream include.
660 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
661 equivalent to ExplicitVR in existing code).
663 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
665 now contains all the gdcmGlobal related code.
666 * minor coding style and doxygenation changes.
668 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
670 now contains all the Debug related code.
671 * minor clean-up of includes in src/*.cxx
672 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
673 CreateCleanString) removed.
674 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
675 * Doc/DoxyMainPageUser.txt added.
676 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
677 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
680 2004-03-24 Jean-Pierre Roux
681 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
683 2004-03-23 Jean-Pierre Roux
684 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
685 big endian made volumes
686 * ENH Now gdcmParser constructor and destructor are protected to forbid
687 end user to instanciate class gdcmParser
688 (only gdcmHeader and gdcmDicomDir are meaningfull)
690 2004-03-22 Benoit Regrain
691 * FIX : src/gdcmDicomDir.cxx : make windows compilable
692 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
693 gdcmSerie to gdcmDicomDirSerie
695 2004-03-19 Jean-Pierre Roux
696 * ENH Now the tree-like structure describing a DICOMDIR comming from
697 an already existing DICOMDIR file is consistent with
698 the home-made tree-like structure build ex-nihilo
699 or build from the files held (recursively) in a Directory
700 functions gdcmDicomDir::CheckBoundaries()
701 gdcmObject::SetBoundaries() added
703 2004-03-17 Jean-Pierre Roux
704 * REM (Eric Boix bug) : removal of meaningless
705 gdcmDicomDirImage::NewImage function.
706 * FIX now file names and directory name are written properly in the
708 * FIX now gdcmDicomDir constructor may be call without any trick
711 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
712 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
713 of gdcmDicomDirImage::NewImage as empty function.
715 2004-02-28 Jean-Pierre Roux
716 * ENH add gdcmDicomDir:NewPatient
717 add gdcmDicomDirPatient:NewStudy
718 add gdcmDicomDirStudy:NewSerie
719 add gdcmDicomDirSerie:NewImage
720 to allow making gdcDicomDir object.
721 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
722 (as opposite to the gdcmHeader chained list)
724 2004-02-11 Benoit Regrain
725 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
726 when using from python
728 2004-02-10 Benoit Regrain
729 * FIX : bug fix in the gdcmDirList for the recursivity in directories
730 * FIX : in gdcmDicomDir when the directory is empty
731 * ENH : add callback and methods to get the progression of dicomDir
734 2004-02-06 Jean-Pierre Roux
735 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
736 - GDCM_META added to gdcmDicomDirType
737 - class gdcmMeta created
738 * ENH : - A brief summary is now displayed at the beginning of
739 'testDicomDir' to help disaster magnitude estimation
740 * REM : Now useless Test/explDICOMDIR.cxx
742 2004-02-05 Benoit Regrain
743 * ENH : add methods in gdcmObject to get the hash table or the list of
745 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
746 * FIX : wrapping python for TagHeaderEntryHT
748 2004-02-04 Benoit Regrain
749 * FIX : even length for some strings when writting the dicom dir
750 * FIX : sort the images in the dicom dir
751 * FIX : Bug fix for python use of dicom dir
752 * ADD : a python demo
754 2004-02-04 Jean-Pierre Roux
755 * FIX : Final solution (?) for icone embedded images
756 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
757 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
758 add groups 6002, 6004, 6006, to allow 'clean' parsing of
759 gdcmData/gdcm-MR-SIEMENS-16.acr1
760 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
761 to make full checking easier
763 2004-02-04 Benoit Regrain
764 * FIX : WriteEntries : coding style & logic in parameters
765 * FIX : Set the elements to create the DicomDir in a dictionary file
767 2004-02-03 Benoit Regrain
768 * gdcmDirList : to parse a hard drive directory in recursive (or not)
769 * gdcmDicomDir : add the load of directory
770 * Bug fix and print add-on
772 2004-02-03 Jean-Pierre Roux
773 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
774 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
775 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
776 * FIX gdcmParser.cxx : 'group length' elements are now considered
777 as integers, even for shadow groups, when file is Implicit VR
779 2004-02-02 Jean-Pierre Roux
780 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
782 of the last synonym :-(
783 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
785 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
786 * FIX taking into account the possible 7fe0,0010 multiplicity
787 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
788 to allow removal of references to 7fe0,0010, to deal with
789 ACR-NEMA images, when 0028,0200 is meaningfull
791 2004-01-31 Jean-Pierre Roux
792 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
793 no longer writes 'Un' on disk
794 * FIX SQ elements with actual length are now dealt with corectly
795 * FIX gdcmFile::WriteBase make the difference, for color images, between
796 the length (for Palette expanded images)
797 and Raw Length (non expanded image + Palette)
798 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
799 (that broke Write). Replaced by UL.
800 Aware user will reload the field if he
801 thinks it's necesssary
803 2004-01-30 Jean-Pierre Roux
804 * gdcmParser::CheckSwap() now defaults the filetype to ACR
805 when 'dirty Acr' is found, to be compliant with the new
806 IsReadable() methods.
808 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
809 (no DOUBLE images in kosher DICOM,
810 but so usefull for people that miss them ;-)
812 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
813 DICOMDIR related utilities (not checked as Windoze compliant)
815 2004-01-28 Jean-Pierre Roux
816 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
818 2004-01-27 Jean-Pierre Roux
819 * gdcmParser constructor has a new boolean param,'ignore_shadow',
820 to allow skipping the shadow elements, to save memory space.
821 The TRUE value for this param has to be used
822 with a FALSE value for the 'enable_sequence' param.
823 ('public elements' may be embedded in 'shadow Sequences')
824 * gdcmHeader methods now deal with 'embedded icones images' in the header
825 (even when an 'icone image sequence' is announced by the
826 element (0x0088,0x0200), but there is NO icone at all ...
828 * gdcmHeader sometimes Image Location value doesn't follow
829 the supposed processor endianity (see gdcmData/cr172241.dcm).
832 * gdcmHeader add the method
833 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
834 to get *all* the Header Entries with the same tag.
835 GetHeaderEntrySameName is probabely *useless*
836 (no meaning : Name is *not* an identifier within the Dictionnary)
838 2004-01-26 Benoit Regrain
839 * Bug fix in the print of hexadecimal representations. Remove long fields
840 in the print and add a third level of print to print them
842 2004-01-23 Benoit Regrain
843 * Bug fix on field having a VR = 'UI'. Assume that is a string field
844 * Bug fix on test suite after remove the strip made on not string fields
845 * Split the IsReadable method between gdcmParser which test that the file
846 is dicom and gdcmHeader which test that it's an image file
848 2004-01-22 Benoit Regrain
849 * DicomDir : clean code, add methods, set variables in protected or private
850 * gdcmUtil : bug fix for the clean string method
852 2004-01-19 Benoit Regrain
853 * Add the use of shadow dictionaries
854 * bug fix and coding style
856 2004-01-19 Benoit Regrain
857 * src/gdcmFile.cxx : bug fix concerning the close of file
858 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
859 * Add the update of header entries using the shadow library
861 2004-01-19 Benoit Regrain
862 * removal of file gdcmHeader2.cxx
863 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
864 inheriting from gdcmParser. This split is to prepare the integration
866 * bug fix under python
868 2004-01-16 Jean-Pierre Roux
869 * REM removal of class gdcmHeaderEntrySet
870 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
871 * ADD add file gdcmHeader2.cxx
872 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
874 2004-01-15 Benoit Regrain
875 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
876 entries created while parsing the header. Thus, they will be destroyed
877 when the gdcmDictSet will be destroyed
878 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
881 2004-01-15 Benoit Regrain
882 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
883 made a fatal error because of the memory release at the end of program.
884 The problem was in vtkGdcmReader::ExecuteData where we were allocate
885 some memory and vtk seems to have some problems with that.
886 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
888 2004-01-14 Benoit Regrain
889 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
890 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
891 * src/*.[h|cxx] : make changes due to class name changes
892 * gdcmPython/demo/*.py : bug fix due to method names
894 2004-01-13 Benoit Regrain
895 * src/*.[h|cxx] : coding style
896 * vtk/*.[h|cxx] : coding style
898 2004-01-13 Benoit Regrain
899 * gdcmPython/testSuite.py : test the readable flag of file for tests
900 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
901 It's lied to the stl compilation by MSVC (windows, always windows...)
902 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
904 2004-01-12 Benoit Regrain
905 * src/*.h : add comments
906 * src/gdcmDictSet.h : set the method BuildDictPath in public
907 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
908 directly setted in the source code
909 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
912 2004-01-09 Benoit Regrain
913 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
914 * setup.py : use a reference to gdcmVERSION
916 2004-01-07 Benoit Regrain
917 * Modification to compile with the distutils.
920 2003-12-10 Benoit Regrain
921 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
922 can use a gdcmHeaderHelper to load datas
923 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
924 made in the source code
926 2003-12-10 Benoit Regrain
927 * Update Windows projects and .cvsignore files
929 2003-11-12 Jean-Pierre Roux
930 * ENH gdcmHeader constructor has one more parameter (default value : false)
931 that allows the user to 'go inside' the SeQuences only
933 gdcmElValSet:Print takes it into account
935 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
936 * ENH: Update gdcmPython/CMakeLists
937 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
938 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
940 2003-11-10 Jean-Pierre Roux
941 * FIX : gdcmHeader::LoadElements is now based
942 on the ListTag listElem member,
943 not longer on the TagElValueHT tagHt member
944 * ENH : PrintPubElVal shows (temporarily) both results,
945 with the tagHt member and the listElem member.
946 (it's easier to 'see' the problems when using Printheader)
948 * FIX : old private member LgrElem is now splitted into
949 ReadLength : Length actually found on disk (updated only
950 if bug fixing is necessary), for internal
952 UsableLength : Updated by FixFoundLength, to fix a bug
953 or to allow Parser going on.
954 Will allow to re-write a kosher header when a SeQuence
955 with a length (not 0000) is found
956 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
957 because gdcmElValSet::Add does not update ListElem
960 2003-11-07 Jean-Pierre Roux
961 * FIX misstyping in Transfert Syntax name table
962 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
963 when they have an actual length (not 0000 nor FFFFF)
964 (Nobody should care of it, but DICOMDIR explorers)
966 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
967 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
969 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * ENH: vtkGdcmReader now supports LUT !
971 (vtkgdcmViewer for now is not able to use them though)
973 2003-11-05 Jean-Pierre Roux
974 * in testSuite.py : new files names for checking the package
975 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
976 that returns the pixel area size to the *aware* (vtk) user
977 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
979 2003-11-05 Benoit Regrain
980 * in testSuite.py : Modify the rules for checking the paths
981 : Explicit error messages
982 * in __init__.py : Related modif
984 2003-11-03 Jean-Pierre Roux
985 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
986 to be used by aware (vtk) users that want to manage
987 LUT (and no to turn the PALETTE image into an RGB pixels one)
988 * GetPixelType now returns 8U for 24 Bits images
989 (vtkGdcmReader compliant)
991 2003-10-31 Jean-Pierre Roux
992 * Removal of *all* gdcmData images and add them again
993 in order to loose the 'history' of un-anonymised images
995 2003-10-31 Jean-Pierre Roux
996 * RMV : removal of useless jBitsInJsample.h
997 for both 8 and 12 Bits JPEG Lossy Libraries
999 2003-10-31 Jean-Pierre Roux
1000 * ENH : Add the functions gdcmFile::GetImageDataRaw
1001 gdcmFile::GetImageDataIntoVectorRaw
1002 that act as GetImageData and GetImageDataIntoVector
1003 except the making of an RGB Plane from Gray Plane + LUT
1004 Intended to aware (vtk) users who know how to manage
1007 GetLUTRGBA return a R,G,B,A LUT if any
1008 lgrTotaleRaw gives the 'Raw' length
1009 GetImageDataRaw returns the gray Plane
1010 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1011 (They stay Grey, just like with other Dicom viewers :-(
1013 2003-10-30 Jean-Pierre Roux
1014 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1016 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1017 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1018 being coherents dicom files.
1020 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1021 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1023 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1024 * ENH: Two steps is necessary to please VC++ compiler...
1025 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1026 * ENH: Add include dir to medcon lib
1027 * FIX: only one function is being exported for now !
1028 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1030 2003-10-29 Jean-Pierre Roux
1031 * adding gdcmHeader::GetLUTRGBA
1032 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1033 --> Mathieu, the modif u're waiting for is not yet committed
1034 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1036 2003-10-27 Jean-Pierre Roux
1037 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1038 00191113.dcm DermaColorLossLess.dcm
1039 MxTwinLossLess.dcm RadBWLossLess.dcm
1040 * ENH: For version prior to vtkImageViewer2 -r 1.19
1041 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1043 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * Removal of ido stuff in CMakeLists.txt
1046 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1047 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1048 * FIX: remove a call to ->Modified ... see comments
1049 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1051 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * FIX: Problem with path for libvtkgdcmPython
1053 * ENH: Try adding a search script for python site-package
1054 * RMV: Remove some file from medcon lib that are not necessary
1055 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1056 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1057 * FIX: More pragma disable fro VC++,
1058 I don't think I break something as it is also disable in VTK/ITK.
1059 But it fasten debug compilation time.
1061 2003-10-23 Jean-Pierre Roux
1062 * gdcm now deals with 16 Bits Run Length Encoded images
1063 (they are compressed as 2 planes images,
1064 one for the high Bytes, the other for low Bytes)
1066 2003-10-22 Jean-Pierre Roux
1067 * Now CheckRead takes into account :
1068 - the bugged 'Leonardo' Siemens images
1069 - the XA images, sent thru the burning VPRO station
1070 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1073 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1074 * FIX: When copying a Makefile.am to CMakeLists.txt
1075 one should remove the '\'
1077 2003-10-22 Jean-Pierre Roux
1078 * in gdcmData adding a bugged 'Leonardo' Siemens image
1079 (wrong lengths in header)
1080 OK with gdcm, KO with the other viewers :-)
1081 * add a GE dlx XA image, thru the VEPRO burning station
1084 2003-10-21 Jean-Pierre Roux
1085 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1086 for a brutal checking of vtkgdcmViewer compliance
1088 2003-10-21 Jean-Pierre Roux
1089 * add the files for 'xmedcon' Jpeg Lossless library
1090 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1092 2003-10-21 Jean-Pierre Roux
1093 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1095 2003-10-21 Jean-Pierre Roux
1096 * garbage Siemens 'Leonardo' images dealt with
1097 (the patch is easy to remove)
1098 * cosmetic changes to avoid warnings
1100 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1101 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1102 no need to press 'r' now.
1104 2003-10-20 Jean-Pierre Roux
1105 * upgrade of checkRead.sh checkWrite.sh according
1106 to new Jpeg Lossless decompressor
1107 * add US.3405.1.dcm, a genuine RGB medical file ...
1108 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1109 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1111 2003-10-15 Jean-Pierre Roux
1112 * general anonymisation in gdcmData
1113 * adding the 'color files' from
1114 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1115 * adding some well knowed bugged-header images
1116 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1117 waiting for their inclusion in Python testsuite
1119 2003-10-15 Jean-Pierre Roux
1120 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1121 no longer seg faults when file is not found
1123 2003-10-14 Jean-Pierre Roux
1124 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1127 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1128 * TODO: *.in file to genereate a UseGDCM later
1130 2003-10-14 Jean-Pierre Roux
1131 * Some supposed-to-be Dicom Images have no preamble.
1132 OpenFile takes it into account
1133 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1134 * Missing elements added in dicomV3.dic
1135 (just to be affraid : have a look at
1136 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1137 and do it again next year ;->
1139 2003-10-13 Jean-Pierre Roux
1140 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1141 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1142 But there are NOT. It's fixed !
1144 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1145 * FIX: "jpeglib.h" was not found on VC++
1146 * FIX: vtkgdcm was not being installed
1148 2003-10-10 Jean-Pierre Roux
1149 * ENH : OpenFile closes the file if it *really* doesn't look like
1150 an ACR-NEMA / DICOM one.
1151 * FIX : testWrite no longer writes an empty file if the source file
1152 is not gdcm Readable
1153 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1156 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1157 * FIX: CMake generate now documentation
1158 * ENH: out of source doc build !
1159 * ENH: Generate both user and dev documentation
1160 * ENH: Should work on windows too
1161 * ENH: Only one doxygen config.in file is needed
1162 * FIX: make install should be ok now on ùnix plateform
1163 * FIX: PATH to dictionary was wrong (missing /)
1164 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1166 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1167 * vtkGdcmReader is now able to read rgb dicom file.
1168 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1169 * added a gdcmViewer to vtk test, use mouse to control
1170 window level & window width
1172 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1173 * CMake-ification of gdcm, we have now two build system
1174 * FIX: on cygwin Wsock32 doesn't exist
1175 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1177 2003-10-06 Emanuel Ollart
1178 * FIX : compilation process wad broken.
1179 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1181 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1182 * change gdcmViewer -> vtkgdcmViewer
1183 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1185 2003-10-06 Jean-Pierre Roux
1186 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1187 ( e.g : well known GE images with a wrong elem length,
1188 : Philips MRI Images with a wrong Huffman table)
1189 * still to be done : allow the reading of bugged LEONARDO Siemens images
1191 2003-10-03 Jean-Pierre Roux
1192 * Odd length strings are padded with '\0' (not with spaces,
1193 to remain compliant with already defined strings,
1194 like Transfert Syntax UID and others)
1196 2003-10-03 Jean-Pierre Roux
1197 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1198 to allow displaying RGB images (not only by affim ;-)
1200 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * vtkGdcmReader is now able to read rgb dicom file.
1202 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1204 2003-10-03 Jean-Pierre Roux
1205 * A few nasty patches to allow the reading of a lot of nasty images
1206 ( e.g : well known GE images with a wrong elem length,
1207 : Philips MRI Images with a wrong Huffman table)
1208 * still to be done : allow the reading of bugged LEONARDO Siemens images
1210 2003-10-03 Jean-Pierre Roux
1211 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1213 2003-10-03 Jean-Pierre Roux
1214 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1215 to allow displaying RGB images (not only by affim ;-)
1217 2003-10-03 Jean-Pierre Roux
1218 * gdcmFile::GetImageDataIntoVector now
1219 - deals with MultiFrames MultiFragments Run Length Encoded files
1220 - deals with YcBcR (YBR_FULL) files
1221 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1222 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1224 (no sample found :-(
1226 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1227 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1228 Two reasons: - clear things
1229 - third parties acces gdcm through header files, so won't
1230 suffer anymore VC++ complains
1232 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1233 * add argv[1] in testvtkGdcmReader.cxx
1236 2003-09-24 Jean-Pierre Roux
1237 * The lines are now eigthy characters long.for
1238 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1240 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1241 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1242 char* to std::string. Thus, the use of strdup becomes useless. (see
1243 previous commis of Malaterre)
1244 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1245 before the last Malaterre's commit.
1247 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1248 * This commit should fix the Debug building under VC++, the problem
1249 was mainly a mixture of debug and release lib being loaded at startup.
1250 * I also remove a depency to a specific C function: strdup. Because I had
1251 to force the link to msvcrtd (whereas strdup is in libc).
1253 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1254 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1255 located in the gdcmCommon.h file. All use of reference of tha has been
1256 changed to now use the variable GDCM_UNFOUND.
1258 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1260 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1261 Dicom dictionary. The test suite can now be run again. Note:
1262 I'm note very happy with the " (RET)" changes. I believe this
1263 RETAINED comment should be dropped when parsing the dictionary.
1264 - PACKAGER corrected
1266 - AUTHORS updated and now in alphabetical order
1267 * Makefile.am now exports gdcm.dsw for Windoze users.
1269 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1270 * cygwin complains about missing std:: in subdir Test/
1272 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1273 * remove some methods that are now in gdcmHeaderHelper
1275 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1276 * vtkGdcmReader set spacing and origin correctly
1278 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1279 * Fix a few delete/delete[] mismatch
1281 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1282 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1283 interpretation to data given by gdcmHeader. For instance there are
1284 heuristics to get informations (look at different places).
1285 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1286 sorting DICOM images based on different strategies.
1287 * modified Makefiles accordingly.
1289 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1290 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1291 when building in debug mode
1292 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1293 src/win32/gdcmdll.dsp
1294 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1296 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1297 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1300 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * src/win32/libgdcmjpeg12.dsp was not dos format
1302 * src/win32/libgdcmjpeg12.dsp :
1303 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1304 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1306 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1307 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1309 * src/gdcmFile.cxx : bug fix in affectation type
1310 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1311 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1312 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1313 symbols... future problem ?
1315 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1316 * src/win32/libgdcmijpeg12.dsp was missing
1317 * modified gdcm.dsw accordingly
1319 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1322 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1324 commit of JPR (before his hollidays to facilitate our work).
1325 * setup.py : bug fix in code. Modifications made while the last commit
1326 of JPR. The code hasn't been tested before the commit... it's so
1327 useless to make that (for best programmer that is JPR) !!!
1329 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1330 * tagged the current version as Version0_3 (i.e. version 0.3)
1332 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1333 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1334 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1335 * *.dsp : modifications to use new libgdcmijpeg8 library
1336 * setup.py : bug fix on VTKPATH variable
1337 * PACKAGER : adding all concerning windows
1339 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1340 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1342 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1343 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1344 test suite reported error.
1345 * PACKAGER file added (describes what a packager must do when
1346 packaging a new release).
1347 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1348 * configure.in: upgraded version number to 0.3.0
1349 * fixing build of rpm (through rpm -ta):
1350 - Doc/Makefile.am exports proper doxygen files
1351 - src/jpeg/libijg8/Makefile.am exports the include files.
1353 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1354 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1355 * src/gdcmHeader.h : formatting code
1357 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1358 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1359 We were obtaining error message from vtk. Now, creation of file list
1360 is made in an internal list to prevent this problem.
1361 Bug fix when output is empty.
1362 Bug fix in update of progress value. Previous commit for this was a bad
1364 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1366 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1367 * src/gdcmHeader.h : added method to get the file name
1368 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1369 files. Added method to remove all files on the input
1370 Added FIXME comment concerning the bad parsing of header made by
1371 ExecuteInformation method (in ExecuteData method)
1373 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1375 when using make instal.
1376 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1377 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1379 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1380 * setup.py : adding include dir of jpeg lib to compile all sources
1381 * */Win32/*.dsp : JPR fix for windows compilation
1383 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1384 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1386 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1387 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1389 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1390 * setup.py is again effective on un*x (takes into account the
1391 addon of the jpeg library)
1392 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1393 * Doc/Doxy* updated (includes above enhancements)
1394 * INSTALL now points to web documentation
1396 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1397 * src/gdcmHeader.h doesn't make unnecessary reference to
1399 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1401 * src/gdcm*.[cxx|h] :
1402 - to allow compilation with gcc 3.x
1403 -- clean up of STL usage (added explicit usage of std::)
1404 -- small fixes on exceptions.
1405 Note: linking not tested !
1406 - clean of doxygen comments to avoid warnings at documentation
1408 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1409 dependent convertion).
1411 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * Clean up of previous JPR garbage commit (not even commented in the
1414 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1415 - moved all jpeg related files from src to src/jpeg/libijg8, with
1416 addition/modification of Makefile.am and configure.in.
1417 - the testSuite is still brain damage (not guilty).
1419 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1420 * WrapVTK.py : modifications to get correctly vtk source files to
1422 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1423 (FileName -> Filename)
1425 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * vtk/vtkGdcmReader.[cxx/h]:
1427 - UpdateProgress method should now be effective
1428 - removed the limitation on having only images loaded (as opposed
1430 - when building a stack of images/volume, a lesser number of
1431 gdcmHeader and gdcmFile instances should be used (hopefully
1432 accelerating things).
1433 - when building a stack of images/volumes, files which are not
1434 loadable (wrong path-filename, wrong permissions on existing file,
1435 or file not parsable by gdcm) are replaced with a black image
1436 in the stack (for the caller to notice the problem).
1438 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1439 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1441 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1442 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1443 between standard library (std) and vtk library (problems are found
1444 under Windows... thanks Windows !)
1446 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1449 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1451 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1454 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1455 * When compiling with distutils (see setup.py) the C++ compiler is
1456 called with different flags than the default ones (with automake).
1457 In order to fix all those warning, I compiled gdcm with the command
1458 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1459 and went for warning fixes:
1460 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1461 up from unused variables.
1462 - vtk/vtkGdcmReader.cxx: potential bug fix.
1463 * src/gdcmHeader.h: Doxygen warning cleanup
1465 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * gdcmPython/gdcm.i:
1467 - typemaps correction to take into account the systematic replacement
1468 of "using namespace std" with std:: prefix e.g. std::list,
1469 std::string... (cf changes of 2003-05-21).
1470 - gdcmGlob global variable of type gdcmGlobal (defined in
1471 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1472 exported to Python a as cvar.
1473 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1474 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1475 gdcmDictSet.GetPubDictTagNames() and
1476 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1477 C++ static methods).
1478 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1479 with the above changes.
1481 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1482 * setup.py, manifest.in : bug fix under linux
1484 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1485 * Modification of setup.py to compile vtk part too. Then, we have 2
1486 wrappers which must work with same distutils. For that, we have a
1487 generic distutils in distusiltsWrapping.py ; with :
1488 - build_extWrap class to wrap generically all extensions,
1489 - ExtensionWrap base class for all wrapping extension that contains
1491 - Wrapper interface which wrap sources
1492 + In WrapSwig.py we have extension and wrapper for Swig
1493 + In WrapVTK.py we have extension and wrapper for VTK
1494 * MANIFEST.in : modifications to consider vtk directory and new python
1495 files for compilation
1497 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1498 * Added python wrappers of vtkGdcmReader vtk class (see the
1499 source in vtk/vtkGdcmReader.cxx) :
1500 - vtk/Makefile.am now builds a library
1501 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1502 python library (as opposed to _gdcm.so wich are the python
1503 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1504 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1506 - configure.in has an additional flag --enable-vtk that needs
1507 to be set to enable compilation of vtk related code, that is:
1508 + vtk/vtkGdcmReader.so and
1509 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1510 + gdcmPython/vtkgdcmPython.so (see above)
1511 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1512 be read when compressed or when HighBit + 1 != BitsStored),
1513 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1514 the usage of the python wrapper of vtkGdcmReader vtk class.
1515 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1516 * src/*.[h] all occurences of stl classes are now prefixed with
1517 std::, and all occurences of "using namespace std;" where removed.
1518 This is to avoid pollution of global namespace in included files.
1519 Apparently vtk does not avoid this pitfall: when using both
1520 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1521 collision of various stl members (principally cout...).
1522 * gdcmPython/testSuite.py now cleanly removes temprory generated
1524 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1525 comply with above changes)
1527 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1528 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1529 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1530 vtk data structure (an image Flip was required).
1531 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1532 * cosmetic changes in documentation.
1534 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1535 * src/gdcmHeader.cxx: the constructor no longer exits when an
1536 unexisting file is given as argument.
1537 * The subdirectory Data (containing all the images used for the
1538 test suite) is not part of this repository anymore. A new module
1539 containing those images is now available at
1540 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1541 with the name gdcmData.
1542 All the python scripts (including the package initialisation file
1543 gdcmPython/__init__.py) were adapated to take this change into
1544 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1546 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1547 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1548 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1549 demo of the usage of this class.
1550 Compilation of this vtk part is only done when using the --enable-vtk
1551 at configure (or autogen.sh) stage.
1553 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1554 * More memory link related corrections and documentation fixes.
1556 - maximum info is obtained with a command of the form:
1557 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1558 --show-reachable=yes PrintHeader
1559 - the remaining reachable blocks seem to come from the STL
1560 allocation scheme through the usage of map and list. It looks
1561 like this memory cannot be freed but it is not a memory leak
1562 (in fact further invocation to the STL would recollect the
1563 unused memory allthough it cannot explicitely be freed).
1564 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1565 of displaying an image parsed with gdcm and displayed with VTK.
1566 Note: some images don't seem to work e.g.
1567 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1568 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1569 Allthough this weakens the semantics, it is a ditch attempt to
1570 make gdcm more thread friendly.
1572 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1573 * Memory link hunt (by using valgrind through the command
1574 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1575 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1576 gdcmHeader::_dicom_vr.
1577 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1578 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1580 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1582 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1583 * src/Makefile.am now exports all the necessary include files at
1587 * UpdateGroupLength replaced by new one
1590 * UpdateGroupLength re-written using H-Table
1591 (named UpdateGroupLengthNew untill checks are over)
1593 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1594 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1595 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1597 - gdcmHeader::GetPubElValSet removed.
1598 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1599 UpdateGroupLength, WriteElements, Write.
1600 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1601 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1602 carried the same semantics.
1603 - src/gdcmHeaderIdo.cxx changed accordingly.
1604 - gdcmFile::WriteBase now regroups all the codes from previous
1605 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1606 - enum FileType moved to gdcmCommon.h
1607 * src/gdcmHeader.cxx AddDefault trashed
1608 * gdcmGetXSize added
1609 * getimageDataSize now calls gdcmGetXSize
1610 * Test/*.cxx changed to agree with above changes
1612 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1613 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1614 (to avoid double call by end user).
1615 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1616 by end user, since gdcmHeader::gdcmHeader now handles it.
1618 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1619 * gdcm/Doc many doxygen changes:
1620 - Doxyfile now has two different versions, DoxyfileUsers that generates
1621 the html.users end users oriented documentation and
1622 DoxyfileDeveloppers that generates the html.developper developper
1623 oriented documentation.
1624 - README changed accordingly
1625 - requirement.txt removed (old design info moved to TODO).
1626 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1627 DoxyMainPage.txt, DoxyPython.txt provide more information.
1628 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1629 be updated by simply regenerating the docs with doxygen and copying
1630 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1631 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1632 all the tests in the form "if (<map>.count() >1)" were removed.
1633 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1634 ill-formed documentation sections.
1635 * src/gdcmHeader.cxx: ditto
1637 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * setup.py fixed for un*x (needed macro for stdint.h)
1639 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1640 un*ces with sh-utils test utility.
1641 * gdcmPython/demo/test.py renamed to PrintHeader.py
1642 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1643 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1644 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1645 * src/gdcm*.cxx JPR's bad inclusion fixed.
1647 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1648 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1649 * gdcmPython/demo/test.py changed accordingly.
1651 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1652 * gdcmPython/Makefile.am fixed linking against libstdc++
1653 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1654 * Swig subdir (historical tests of swig version 1.3.17++) removed
1655 * Test/testChangeEntete.cxx some lines commented out in order to make
1657 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1658 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1660 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1661 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1662 hence the user doesn't need this explicit call.
1663 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1664 i.e. LoadElements() call removed.
1665 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1666 - src/Makefile.am declares the proper flag for g++.
1667 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1668 for adding user defined new tags.
1669 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1670 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1671 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1673 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1674 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1675 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1676 src/Makefile.am : the project should properly compile and install
1677 with the autotools, included the python wrappers part.
1678 * gdcm.spec.in : added a spec file for RPM packaging.
1680 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1681 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1683 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1684 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1685 to exported to the environement (see gdcmPython/testSuite.py
1687 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1688 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1689 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1690 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1691 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1693 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1694 * gdcmPython/__init__.py doesn't crash anymore when running in
1695 in InstallMode or PreInstallMode but with an environement given
1696 value of GDCM_DICT_PATH.
1697 * src/gdcmDictSet.[cxx/h] coding style.
1699 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1700 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1701 * src/gdcm.h general comments moved to TODO, and README
1702 * src/gdcm.h should now be seen as a user commodity (including it
1703 should suffice to fully use gdcm). It is nowhere including within
1704 any of the kernel files src/*.cxx and src/*.h.
1706 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1707 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1708 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1710 * src/gdcm*.cxx only include their corresponding include file
1711 (as opposed to gdcm.h)
1712 * gdcmPython/gdcm.i changed accordingly
1713 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1714 the autogen.sh generated "make snapshot" command to work.
1715 * autogen.sh removed history related references to crea package.
1717 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1718 * distutilsSwigCPlusPlus.py work around some swig portability
1721 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1723 was done in a last ditch attempt to get setup.py _really_
1724 operationnal. The python/gdcmPython layaout add the advantage
1725 of hidding away the python related distutils specific files
1726 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1727 Alas, the src directory was out of scope (i.e. it's relative
1728 position to setup.py was ../src) which made things impossible to
1729 handle (see previous version of python/setup.py). Crossing fingers...
1731 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1732 * python/setup.py now works on Un*x. (harder than I thougth)
1733 * python/distutilsSwigCPlusPlus.py can now have include files
1734 among the list of sources.
1736 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1737 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1738 * modifications in MSVC projects
1740 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1741 * As stated by the first lines of Test/ExceptionAndPython/README, it
1742 looks like we can move back to original usage of exception within
1743 src/gdcm* and hence remove the errno stuff that was introduced
1744 as a quick and dirty fixture of this problem (added to the TODO).
1745 * Doc/Doxyfile configuration file for Doxygen and corresponding
1746 README file for usage added.
1747 * Test/testWrite.cxx added. This new test comes from a split of
1748 test.cxx that is now reverted to its original purpous i.e.
1749 testing the proper parsing of a Dicom related file.
1750 testWrite.cxx concentrates on testing the IO part of gdcm.
1751 * Test/bug1.cxx (containing a bug on WIn32) added.
1752 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1753 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1754 whose purpose is to publish the content of the TagNames of the
1755 Dicom public dictionnary were not accessible without an
1756 instance of class gdcmHeader.
1757 - those methods are now static methods of gdcmDictSet and hence
1758 require no instances at all to be invocated.
1759 - within gdcmDictSet this change required to change some method
1760 to class methods (i.e. are now static) among which SetDictPath
1761 (renamed to BuildDictPath) and LoadDefaultPubDict.
1762 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1763 the above changes by calling the new method classes of gdcmDictSet.
1764 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1765 the above to be effective.
1766 * python/gdcmPython: in order to wrap properly the above changes
1767 for Python, swig version now needs to be > 1.3.17.
1768 * python/gdcmPython/Makefile fixed to adapt itself to new
1769 configure/make shema introduced by Johan Montagnat (thanks for the
1770 contribution). Alas this Makefile cannot be turned into a proper
1771 Makefile.am without some heavy changes in the configure.in
1772 (for python dectection).
1773 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1774 now avoids publishing the empty entries.
1776 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1777 * python/setup.py : bug fix concerning install under windows
1778 ExtraPath reused :-P
1779 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1781 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1782 * Dicts/dicomV3.dic : remove double spaces !!!
1783 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1784 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1787 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1789 method. Doxygenation.
1790 * src/gdcm.h clean up of JPR spurious comments.
1792 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * python/distutilsSwigCPlusPlus.py now properly collects the
1794 shadow classes generated by "swig -c++" (gdcm.py in our case)
1795 when using "python setup.py install".
1796 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1797 reexports the working classes.
1798 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1799 by the classical C errno scheme. This is to prevent an obscure
1800 behavior of the python wrappers when importing wxPython.wx prior
1801 to gdcmPython (which ended up in an abort call). An illustration
1802 of this oddity can be found in the Test/ExceptionAndPython
1803 subdir (see the README file). This problem probably due to
1804 an combination of g++ and dynamic loading.
1805 * added Test/ExceptionAndPython (see above)
1807 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1808 * Changed the layout of the python part to avoid bloating main
1809 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1810 i.e. the distutils arsenal. All the python related stuff is
1811 again in a python subdir, but the package itself is now in
1813 * setup.py was cleaned up:
1814 - pythonIncludePath removed
1815 - python setup.py bdist target is now functional.
1816 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1817 collision with other packages). gdcmPython/demo/*.py changed
1820 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1821 * python subdir moved to gdcmPython (preparation of distutils packaging).
1822 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1823 distutils installer is operational.
1824 * - gdcmPython/__init__.py now properly loads the swig generated
1825 shadow classes (from gdcm.py).
1826 - gdcmPython/demo/*.py changed to import the package gdcmPython
1827 instead of gdcmPython/demo/load.py.
1828 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1830 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1831 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1832 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1833 entries within the associated public Dicom dictionary resp. the same
1834 information but sorted by the fourth field (PAT, IMG, DIR) of the
1836 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1837 are now in the "???" group.
1838 - python/gdcm.i changed accordingly,
1839 - python/demo/printGroupedPublicDict.py added, that gives an example
1840 of the above new functionalities in Python.
1842 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * src/gdcm.h, gdcmHeader.cxx:
1844 - historic references to glib's g_malloc and g_free (#defined)
1845 were definitively removed.
1846 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1847 * src/gdcmElValSet.cxx:
1848 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1849 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1850 - GetElValue(string) renamed to GetElValueByName.
1851 - Added GetElementByName(string).
1852 * src/gdcmHeader.cxx: added
1853 - GetPubElValRepByNumber(guint16, guint16)
1854 - GetPubElValRepByName(string)
1855 - GetShaElValRepByNumber(guint16, guint16)
1856 - GetShaElValRepByName(string)
1857 - GetShaElValByNumber(guint16, guint16)
1858 - GetShaElValRepByName(string)
1859 - GetElValRepByNumber(guint16, guint16)
1860 - GetElValRepByName(string)
1861 - GetElValByNumber(guint16, guint16)
1862 - GetElValRepByName(string)
1863 * Doc/requirements.txt added.
1865 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * Test/Makefile building now depends on the one of libgdcm.so
1867 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1868 pixel data) aware which enables finding the address (offset) of
1869 the pixel data of JPEG encoded DICOM files. This leaves only a single
1870 file in the testSuite whose pixel data address (offset) is unknown.
1871 * python/testSuite.py changed accordingly.
1873 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1874 * VC++ has some strong limitations when working with the STL, as stated
1875 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1876 "Also note that some STL containers (map, set, queue, list, deque)
1877 cannot be exported. [...]
1878 Some STL classes contain nested classes. These classes can not
1880 This is caused by a designed limitation that once a template
1881 class is instantiated, it can not be re-instantiated and
1883 Since our usage of map<> is ubiquitous in gdcm, this "designed
1884 limitation" of VC++ is a pitfall.
1885 Hence the Python wrappers of gdcm cannot be incrementally linked
1886 against the c++ dynamic library. The dirty but only workaround is
1887 to forget about incremental link of dynamic libraries and to generate
1888 the Python wrappers library with the inclusions of the underlying C++
1890 The following modifications concern this matter on Win32/VC++:
1891 - wrapping python correct with standalone wrapped dll (don't use separate
1892 dll under windows !!!!)
1893 - python21_d debug mode enabled (ask Frog how to use it :-)
1894 - NO problem with having an STL member of class for example string in C++
1895 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1896 - Python test of dcmlib in Python is ok under windows on a large set
1898 * removed glib references
1899 * typedef's inserted in gdcm.i for correct swig type management
1901 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * python/demo/*.py load.py extracted from test.py. Added explore.py
1903 that only displays required tags and testAll.py that parses all
1904 the files of the testsuite without using unittest.
1905 * python/testSuite.py other additional test on new files added.
1906 * Data/* new test files added accordingly to the testSuite.
1907 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1908 the vr in the file differs from the one of the dictionary.
1910 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1911 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1912 values, but limits itself to values which are below a user specified
1913 size (by default 1024 bytes).
1914 * python/gdcm.i : elements not loaded (because their size is above the
1915 user specified treshold) are exported with their TagKey as key of the
1916 python dictionary. This enables the testsuite to make some checks
1917 on the unloaded elements (since we have their offset and size).
1918 * python/testSuite.py
1919 - now tests for the existence and proper value of the pixel data
1920 - two new examples added.
1921 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1923 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1924 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1925 aware. See the strategy comments in gdcmHeader::FindeLength().
1926 * Test/test.cxx now accepts a filename as first argument.
1927 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1928 * python/testSuite.py changed to integrate test on above files.
1930 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1932 the vr was also RET.
1933 * python/testSuite.py more tests added.
1935 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * python/testSuite.py unittest test suite added (uses Data)
1937 * Data/* dcm and acr files for the test suite.
1938 * glib dependance removed from un*x version. We now use ISO C99
1939 7.18 Integer types (see stdint.h)
1940 - python/Makefile, src/Makefile src/gdcm.h
1941 * src/ when an explicit vr (like dicom files) suddenly poped an
1942 implicit element we use to mark the underlying DictEntry of the
1943 concerned ElValue with "Implicit". This strategy was damageable
1944 too the public or provite dictionaries, since some of their vr
1945 would be changed. Since Header::FindLength heavily relies on the
1946 detection by Header::FindVR of falsely explicit elements, I
1947 added an extra ImplicitVr member to ElValue (boolean).
1948 The rest of the changes we the necessary adaptations.
1950 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1951 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1953 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1955 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1956 * Adaptation for porting to VC++:
1958 o forced to use std namespace (for string to be known)
1959 o all class use __declspec export style on WIN32
1960 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1961 (in stdlib.h on Win32 but in std:: for gcc)
1962 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1963 variable GDCM_DICT_PATH.
1964 * src/gdcmHeader.cxx verbose comments made discrete.
1966 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * python/gdcm.i: added a typemap that converts a C++ hashing table
1968 to native Python dictionary.
1969 * python/demo/test.py:
1970 - now uses the native dictionary for exploration of gdcmHeader.
1971 - takes an optional filename argument (the file to parse).
1972 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1973 PubElVals hashing table.
1974 * Dicts/dicomV3.dic removed error prone trailing spaces.
1976 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * Python wrapping process moved away from src/Makefile to
1978 newly created python/Makefile (as well as gdcm.i)
1979 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1980 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1981 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1982 from the environement variable GDCM_DICT_PATH (when existing).
1983 * src/gdcmDict::GetTag bug fix.
1985 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * Straightforward temporary fixes for swig to build the python wrappers.
1987 src/Makefile now has a python working entry [by working we mean
1988 that we can import de shadow classes without errors].
1990 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1991 * hashtest.cxx removed (since allready in Test)
1992 * src/gdcmlib.h renamed to src/gdcm.h
1993 * src/dcm.i renamed to src/gdcm.i
1994 * src/Makefile prepared for python wrapping
1996 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1997 * src/gdcmHeader.cxx :
1998 - Parsing of header is now separated from loading of element values
1999 (see gdcmHeader::LoadElements).
2000 - general clean up of hopefully all file access (creation of
2001 ReadInt16 and ReadInt32)
2003 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2004 * src/gdcmHeader.cxx :
2005 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2007 - SetLgrElem renamed to SetLength
2008 - GetLgrElem renamed to GetLength
2009 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2010 * src/gdcmElValSet.cxx fixed both GetElValue methods
2011 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2012 due to IdoDude was cleaned out.
2014 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2016 concentrates on finding the value representation (when it exists).
2017 RecupLgr now only finds the element value length, and it avoids
2018 returning the unecessary skL (skipped length).
2019 Also, offsetCourant was simply removed (with taille_fich) since
2020 it was redundant with the File position internals (by using
2021 ftell and fseek). This also made skL (see above in RecupLgr) usage
2023 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2024 on the libido specificities which are handled through class
2026 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2029 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2030 * Truckload of changes. Parsing of header is barely functional
2031 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2033 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcmHeader.cxx many addons of low level methods
2036 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2037 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2038 and _IdDcmSWAP_LONG.
2040 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2041 * This corresponds to all the changes decided at the meeting of
2042 May 23 2002. Needless to say we are running late...