1 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * ENH: added some utility method that builds a flat dictionnary
3 holding all the Dicom entries contained in the recursive structure
4 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
6 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
7 BuildFlatHashTable() that build a flat dictionary.
8 - src/gdcmElementSet.h: added a new private GetTag() accessor.
9 gdcmDocument is now a friend of gdcmElementSet.
10 - src/gdcmElementSet.cxx: clean up.
11 - Example/FlatHashTablePrint.cxx added.
12 - Example/CmakeLists.txt changed accordingly
14 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
15 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
16 moved away from gdcmDocEntrySet (since this class is an abstract class
17 acting like an interface). SQDepthLevel and BaseTagKey are now
19 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
20 and associated accessors. Doxygenation of the class.
21 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
23 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
24 Use SQDepthLevel accessor instead. ::Print() adapted.
25 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
26 - src/gdcmDocument.cxx changed accordingly.
28 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
29 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
30 - The following is the doxygen comment of the typedef declaration
31 of gdcmagKey in src/gdcmCommon.h:
32 gdcmTagKey is made to old an "universal" (as in URL, Universal
33 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
34 A dicom tag allways has a group and an element, but a set of tags
35 embeded in various (optionally nested) sequences and sharing
36 the same group and element all share the same (group, element)
37 "identifier". Hence the (group, element) cannot be used as an
38 identifier (in gdcm we shall refer to a "TagKey") of a tag.
39 In order to construct a proper tag identifier (i.e. a key) we
40 consider the following definition of a TagKey:
41 - let Group, Element be the string representation of the
42 group and element dicom tag members,
43 - let ItemNumber be the string representation of the integer
44 index of the considered item number of a sequence,
45 Let the key of a tag embeded in a sequence, noted SeqTag, be
47 /ItemNumber#Group|Element
48 where "/", "#" and "|" are characters acting as separators.
49 Then the general form of a gdcmTagKey is given by:
51 where <SeqTag> means NO or many instances of SeqTag.
52 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
55 but the gdcmTagKey of a tag "embeded" is the first item of
56 a sequence, itself nested in the third item of a sequence is the
58 0004|1220/2#0008|0082/0#0008|0090
59 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
60 order to hold the new sequence compatible key. Previously, the
61 GetKey() method would look in the underlying gdcmDictEntry.
62 - src/gdcmDocEntry.cxx:
63 -- constructor now copies the underlying DictEntry key, in the local
65 -- ::Print: displays the member Key, instead of the (group, element).
66 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
67 - src/gdcmDocEntrySet.h:xi
68 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
69 -- now has a new BaseTagKey member.
71 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
72 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
74 This poses the problem with the semantics of the following lines
75 LoadEntryVoidArea(0x0028,0x1201); // R LUT
76 LoadEntryVoidArea(0x0028,0x1202); // G LUT
77 LoadEntryVoidArea(0x0028,0x1203); // B LUT
78 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
79 to the long FIXME note for what the problem is. Nevertheless in
80 order to get things working the dicom dictionary was altered !
81 Please fix things urgently...
82 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
83 information), see above note on moving the member VoidArea. Nevertheless
84 the following entries previously correctly set as US are now inproperly
86 0028 1201 OW IMG Red Palette Color Lookup Table Data
87 0028 1202 OW IMG Green Palette Color Lookup Table Data
88 0028 1203 OW IMG Blue Palette Color Lookup Table Data
89 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
90 of gdcmDocEntry moved to gdcmSeqEntry.
91 * src/gdcmSeqEntry.cxx: STYLE.
93 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
94 * Test/TestAllEntryVerify.cxx minor fix and added comments.
96 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
97 * gdcmPython/testSuite.py: all the test suite in python is now moved
98 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
99 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
100 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
102 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
103 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
104 to avoid inclusion recursion until STL is reached.
105 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
106 mecanism. errno.h is not included in gdcm anymore.
107 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
108 (gdcmFormatError now inherits from gdcmFormatUnexpected).
110 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
111 gdcmData/TestAllEntryVerifyReference.txt
112 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
113 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
114 exception_on_error parameter.
115 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
116 - vtk/vtkGdcmReader.cxx changed accordingly,
117 - Example/*.cxx and Test/*.cxx changed accordingly.
119 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
120 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
121 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
122 enable_sequences removed from gdcmHeader constructor and dependencies.
123 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
124 * gdcmPython/demo/PrintHeader.py: dummy fix.
125 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
126 skip_shadow removed from gdcmHeader constructor and dependencies.
127 * Example/*.cxx and Test/*.cxx changed accordingly.
129 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
130 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
131 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
133 2004-07-21 Jean-Pierre Roux
134 * FIX Now, Parsing and Printing a DICOMDIR do work!
135 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
137 2004-07-20 Jean-Pierre Roux
138 * FIX Some brain damaged headers have Zero-Lenght fields
139 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
141 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
143 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
144 variable (instance of gdcmDebug) by a definition macro, and the instance
145 is now in static in the gdcmDebug class
146 * src/gdcmSQItem.h : (FIXME) remove an undefined method
147 * Test/PrintAllDocument.cxx : bug fix in the result of the test
149 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
150 * WARNING: ctest now depends more tightly on gdcmData. You should
151 check out gdcmData properly for things to run smoothly...
152 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
153 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
154 we need the pixels not be loaded in order to use the ValEntry
155 that displays position and size).
156 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
157 This is a C++ based equivalent of gdcmPython/testSuite.py that should
158 be deprecated. If you have any doubts about the advantages of a
159 modern scripting language (read Python) versus grass root C++ (i.e.
160 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
161 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
162 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
163 Anyhow, consider documenting the gdcmData images in
164 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
166 * Test/CMakeLists.txt:
167 - now uses TestAllEntryVerify.cxx
168 - specific comments on oldACR00001.ima (now renamed in gdcmData
169 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
170 gdcmData/TestAllEntryVerifyReference.txt
173 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * src/*.[h|cxx] : typedef clean up
175 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
176 - TagKey renamed to gdcmTagKey (for external usage)
177 - VRKey renamed to gdcmVRKey (for external usage)
178 - removal of typedef duplication.
179 - Removed all unecessary inline keyword from class inline definitions.
180 - Some method|function(void) declarations replaced with method|function().
181 * src/jpeg/libijg12/jdhuff12.c:
182 - printf polluting ctest removed.
183 - TAB removal for comminting
185 - TestAllReadCompareDicom.cxx: added a test that compares all the
186 images in gdcmDataImages.h with corresponding images in
187 gdcmData/BaselineDicom/. When baseline images are not present
188 this test creates them.
189 Note: we need to validate each reference image, but before that
190 I'd like to rename them with a more explicit name...
191 - CMakeLists.txt: changed accordingly.
192 * Example/*.cxx: examples now only include gdcm.h (as opposed to
193 including each header needed).
195 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
196 * Test/*.cxx and Example/*.cxx: moved some examples away from the
197 test suite to the Example directory. Are concerned:
202 - TestWriteSimple.cxx
203 * Test/CMakeLists.txt: added some comments on reasons for black listing
204 image gdcmData/oldACR00001.ima
206 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
207 * Test/CmakeList.txt: removed the following from black list (to be coherent
208 with removal from gdcmData):
209 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
210 - gdcm-MR-PHILIPS-16.dcm
212 Added the following because after last cvs update, they cause
213 ctest -R TestReadWriteReadCompare
215 - gdcm-MR-SIEMENS-16-1.acr
217 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
218 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
219 new comments in this file) we temporarily (sigh) move to a weaker
221 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
222 we don't need to black list the following images anymore:
223 - 8BitsUncompressedColor.dcm
225 - US-PAL-8-10x-echo.dcm
226 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
227 fixes and the beautified code ;-)
228 This fixes the bug introduced in version 1.42 (when beautifying)
229 that made the parsing of 8BitsRunLengthColor.dcm unproper.
230 Note: ctest was blind to this bug (this means we need to still
231 improve the test suite). The bug could be detected by using
232 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
234 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
235 and by displaying the (garbage) produced file temp.XDCM...
237 2004-06-29 Jean-Pierre Roux
238 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
239 - replace by uggly but working old code :-(
240 A lot of things should be OK again.
241 It's really urgent to have a test suite that *tests*,
242 to prevent Frog's beautifying sessions to break all the stuff
243 (twice, withing a fortnigh ...)
245 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
246 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
247 redundancy) to added Test/TestReadWriteReadCompare.cxx
248 * Test/CmakeList.txt: because the compare test of
249 Test/TestReadWriteReadCompare.cxx fails, the following images are
250 black listed: - 8BitsUncompressedColor.dcm
252 - US-PAL-8-10x-echo.dcm
253 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
254 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
255 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
256 and ad-hoc kludge. This kludge is now removed, and on encountering
257 such an image (OB field brain damaged) we set errno. Then in
258 ::FindDocLength() we "fix" the length as being ALL what remains
259 in the file (until EOF). We then proceed, hoping for the best...
260 This fixes a SegFault in ShowDicom when trying to write such an
262 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
263 (because TestWriteRead breaks on it, after a non conformal commit?).
264 ctest now runs properly, except for MakeDicomDir (which was allways
265 broken) and the Python related stuff (still not fixed).
267 2004-06-24 Jean-Pierre Roux
268 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
269 FIX : Test/TestReadWrite now iterates on all the file names
270 (instead of infinite loop)
271 ENH : Test/TestWriteRead now iterates on all the file names
273 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
276 2004-06-24 Jean-Pierre Roux
277 FIX : - now Write drops LUT Descriptors and LUTs (if any)
278 when SamplesPerPixel =3
279 - now Write is no longer confused by
280 'BitsAllocated = 12" and 'BitsStored=12"
281 - "UN" value representation Elements are now written correctly
282 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
283 ENH : - now gdcmHeader has its own Write methods
284 (in order to split the job that has not to be done
287 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
289 loop on the same image until memory went out.
290 Note: this means we still have gobs of memory loss in PrintDocument
291 * src/gdcmDocument.cxx: fixes problem on parsing on file
292 gdcmData/16BitsJpegLosslessGrayScale.dcm.
294 2004-06-24 Jean-Pierre Roux
295 FIX : Write - All the Sequences and Sequence Item are now written
296 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
297 is added a the end, when necessary.
298 - A lot of brain-damaged images, that were read correctly are
299 now written correctly
300 - length compatible BinEntry are now loaded correctly
301 (even for odd groups)
302 Note : only Explicit Value Representation was checked.
303 (question : is implicit VR really necessary for gdcm ?)
305 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * DEVELOPPER: added a proposition of coding style.
307 * src/gdcmDocEntry.h: removed every inline declaration (for test of
310 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
311 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
312 Use the gdcmDocEntry::Print() and Write() instead.
313 * src/gdcmDocument.cxx: bug fix.
315 2004-06-22 Jean-Pierre Roux
316 FIX : gdcmDocument.cxx
317 - Now we do recognize the JpegLossLess format (there was a misstyping in
318 code 'beautyfication' :-(
319 - Now we automaticaticaly load the Luts, if any
321 2004-06-22 Jean-Pierre Roux
322 In order : to write Sequences, whatever their imbrication level,
323 : to allow user to create his own Sequences
324 a lot of modif where necessary (adding, moving, or virtualising methods)
326 WARNING : save your own sources *before* cvs up !
329 ADD virtual void Write(FILE *fp, FileType filetype);
332 ADD virtual void Write(FILE *fp, FileType filetype);
333 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
336 ADD virtual void Write (FILE *fp, FileType filetype)=0;
337 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
338 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
339 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
340 ADD std::string GetEntryByName(TagName name);
341 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
343 std::string vr = "unkn",
344 std::string fourth = "unkn",
345 std::string name = "unkn");
346 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
347 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
348 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
349 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
350 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
351 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
352 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
353 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
356 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
357 ADD virtual std::string GetEntryByName (TagName tagName);
358 ADD virtual std::string GetEntryVRByName (TagName tagName);
359 REM virtual bool Write(FILE *, FileType);
360 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
361 FILE *_fp, FileType type);
362 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
363 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
364 REM virtual bool WriteEntries(FILE *_fp,FileType type);
365 REM virtual std::string GetEntryByName (std::string tagName);
366 REM virtual std::string GetEntryVRByName (std::string tagName);
367 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
368 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
369 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
371 std::string vr = "unkn",
372 std::string fourth = "unkn",
373 std::string name = "unkn");
374 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
375 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
376 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
377 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
380 ADD virtual void Write(FILE *fp, FileType filetype);
383 ADD virtual void Write(FILE *fp,FileType filetype);
386 ADD virtual void Write(FILE *fp, FileType filetype);
387 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
388 REM std::string GetEntryByNumber(guint16 group, guint16 element);
389 REM std::string GetEntryByName(TagName name);
392 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
394 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
395 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
396 The default constructor invoked by the line
397 gdcmHeader *f1 = new gdcmHeader( header );
398 was gdcmHeader::gdcmHeader(bool) instead of the expected
399 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
400 Hence the parsing wasn't executed... See also below.
401 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
402 as explicit constructor didn't do the trick to fix the above problem.
403 Could anyone explain why ?
404 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
405 properly calls gdcmValEntry::Print() (that was weed out from
406 code related to gdcmBinEntry).
408 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
409 * In order to fix memory leaks:
410 - Test/TestWriteSimple.cxx: added cleaning of free store through
412 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
413 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
414 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
415 (through the call to ::AddDicomDirMeta()) or the destructor
416 would crash when deleting uninitialized ::metaElems].
417 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
418 - src/gdcmDocument.cxx:
419 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
421 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
422 was causing memory leaks.
423 - src/gdcmSQItem.cxx:
424 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
425 cleanly handled with polymophism: sorry but my milage is low).
426 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
427 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
428 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
429 This avoids SegFaulting.
430 - src/gdcmSQItem.h: coding style.
432 - Test/TestWriteSimple still severely sucks. The output image content
433 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
434 damaged when displayed with vtkgdcmViewer.
435 - on memory leaks: TestWriteSimple leaks really less (see entry
436 of 2004-06-18 in Changelog file for the call to valgrind).
437 - on segfaults: ctest now passes all the tests but one (no more
439 * Erroneous leading white fix:
440 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
441 white[s] (as opposed to from >> xxx, that removes it [them].
442 - src/gdcmTS.cxx: ditto.
443 - gdcmPython/testSuite.py: dirty related kludge removed.
444 * src/*: remaining references to gdcmParser removed.
445 * src/*[cxx|h]: added copy[way]left header.
448 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * In order to fix writing of dicom files:
450 - Test/TestWriteSimple.cxx: a simpler example of writing.
451 - Test/CMakeLists.txt changed accordingly.
452 - src/gdcmDocument.cxx:
453 -- The destructor now recursilvely removes potential sequences.
454 -- Bug fix in ::IsJPEG2000()
455 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
456 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
458 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
459 to only declared) and build on top of
460 ::GetDocEntryByNumber(guint16, guint16).
461 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
462 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
463 for usage in destructor and treatement of promotion in
464 ::ReplaceOrCreateByNumber().
465 - src/gdcmSQItem.cxx: destructor should better handle his job.
466 Test/TestWriteSimple now runs (or at least it DOES something).
467 * We can now start hutting memory links. A good starting point is:
468 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
469 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
470 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
472 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
473 * Valgrind note: after Mathieu Malaterre teached me how to read
474 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
476 Using gcc, you can force the STL to use malloc and to free memory as
477 soon as possible by globally disabling memory caching.
478 With 3.2.2 and later, you should export the environment variable
479 GLIBCPP_FORCE_NEW before running your program.
480 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
481 simply vanish (it is still not clear to me, whether this means that
482 STL std::string leaks or if valgrind believes it leaks...).
483 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
484 running bin/gdcmTests makeDicomDir):
485 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
486 - Test/makeDicomDir.cxx now properly traps empty lists and returns
488 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
489 SegFaulting (I drowned in DicomDir related code when trying to
490 understand why the list is empty...).
491 * src/gdcmDocument.h: first BSD license header try.
492 * Doc/License.txt added.
494 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * src/gdcmDocument.[h|cxx]:
496 - Clean up of the Transfer related predicates. They are now all based
497 on new method isGivenTransferSyntax, that (should) handle properly
499 - general clean up, simplification, and coding style.
500 - Specific clean up of Parse7FE0() (umproperly named actually).
501 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
503 2004-06-14 Jean-Pierre Roux
505 - fix the display of Sequence Delimitor (SQDepthLevel pb)
506 - fix the display of SQItem ordinal number
507 - add the GetSQItemByOrdinalNumber method
508 - remove some useless never written private methods
510 2004-06-14 Jean-Pierre Roux
512 - adding a constructor taking a gdcmDocEntry as an input param
513 - ReplaceOrCreateByNumber now returns :
514 a gdcmBinEntry * if a Binary (void *) value is passed as a param
515 a gdcmValEntry * if a string value is passed as a param
517 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
518 according to the param type (no longer sets a gdcmDocEntry)
519 - GetValEntryByNumber, GetBinEntryByNumber added
520 - NewValEntryByNumber and NewBinEntryByNumber added
522 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
524 - GetSQItemNumber and SetSQItemNumber added, to provide
525 a (relative) Item identier inside a given Sequence
526 \warning : some pb remaining around this number
528 - AddEntry now takes the Item Number as a param
530 - adding a constructor taking a gdcmDocEntry as an input param
532 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * Memory leak hunt with the following command:
534 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
535 --show-reachable=yes gdcmTests PrintDocument
536 It looks like many (all?) leaks are due to the STL (or a bad usage
537 of the STL. The lines producing the leaks now have a comment with
538 a "MEMORY LEAK" tag: you can retrieve them with
539 grep "MEMORY LEAK" src/*
540 Here are two typical examples which I can't help fixing:
545 char * test = "babo";
546 name = test; //// <--- valgrind detects 960 bytes lost in
547 //// call to std::string::operator=(char const*)
548 name.clear(); //// Doesn't help !
556 std::cout << "Type a bunch of characters followed by RETURN: ";
557 getline(std::cin, line); //// <--- valgrind dectects a loss
558 //// of 1320 bytes in call to
559 /// std::basic_istream<>& std::getline<>
565 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * src/gdcmHeader.[cxx|h]:
567 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
568 and related, moved away to gdcmDocument.
569 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
570 the corresponding protected accessors of inherited class
571 gdcmDocument, removed ! As a consequence gdcmFile had to be
572 declared friend of class gdcmDocument (see below).
573 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
574 - Clean up of undefined or unused methods.
575 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
576 account the changes to gdcmHeader.h).
577 * src/gdcmDocument.h:
578 - gdcmFile is now a friend class (in order to take into account the
579 changes to gdcmHeader.h).
580 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
581 (see changes to gdcmHeader.h).
582 - Accessors (reading on the form GetEntry*) are now public.
583 - Clean up of undefined or unused methods.
584 * src/gdcmDocument.cxx:
585 - adaptation to changes to gdcmDocument.h
586 - ::OpenFile now writes a verbose message when file cannot be opened.
587 - some std::string properly set to VRKey
588 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
589 references to gdcmDocument.
590 * Test/TestFindTags.cxx: changed accordingly to above changes.
591 * gdcmPython/testSuite.py: adapted to renaming of acr files in
592 cvs repository gdcmData.
594 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
595 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
596 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
597 conflicts with gdcmValEntry::voidArea.
598 * src/gdcmValEntry.cxx: unmatching comment wiped out.
599 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
600 Value representation between StringRepresentable and BinaryRepresentable.
601 * src/gdcmDocument.cxx:
602 - method ParseDES: proper indentation restored and usage of
603 gdcmVR::IsVROfGdcmStringRepresentable wired in.
604 - method LoadDocEntry: the fingerprint left in the SetValue() of
605 unloaded entries (length > MaxSizeLoadEntry) had curiously been
606 removed. Reverting to previous code segment with the proper
607 dynamic_cast< gdcmValEntry* >.
608 Note: this was (partially) breaking the python test suite
609 (gdcmPython/testSuite.py) that made usage of the above
610 fingerprint to check presence of "Pixel Data".
611 * src/gdcmDocEntry.h: coding style.
612 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
613 now taken into account.
614 * gdcmPython/gdcm.i: adaptation to the new internal representation
615 of gdcm (exit gdcmParser, hello gdcmDocument).
616 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
618 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
619 anymore, but instead prints the loaded Python dictionary.
620 * .... alas, the python testSuite is still broken.
622 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
623 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
625 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
626 * src/gdcmUtil.h : export methods
628 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
629 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
631 * Initial addition of automatic python testing
632 * Initial addition of automatic image comparison
634 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
635 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
636 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
638 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
639 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
640 * Test/ShowDicom.cxx : bug fix for msvc compilation
641 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
643 2004-05-04 Jean-Pierre Roux
644 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
645 new concepts (and new classes) :
646 a 'gdcmDocument' is composed of a set of Doc Entries, that are
647 - elementary gdcmDocEntries (former gdcmHeaderEntries)
648 - Sequence Doc Entries (gdcmSeqEntries)
649 a Sequence is composed of Items.
650 Each item is a set of Doc Entries (this is recursive)
651 The non uniqueness of the 'Dicom tag' is due to this recursivity
652 (never taken into account)
653 Our unability to add a new 'entry' in the header
654 at the proper location (neither in the H-Table (map or multimap),
655 nor in the Chained List is also due to this recursivity.
656 Don't try, right now, to use/modify/compile these new sources :
658 We just commit all the stuff, 'as is', in order not to loose it.
660 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
661 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
663 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
664 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
665 file prefix (SetFilePrefix)
667 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
668 * Add a new test: ShowDicom, for now this is just the c++ version of
669 checkRead.sh, later it will be able to compare the image read against a
671 * Replace the DEBUG on the stack with a global entry in cmake interface:
672 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
674 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
675 * Add an example subdir, with a real example on how to read + write a
678 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
680 * Doc/CMakeLists.txt: the main page is now properly differentiated
681 between the developper and user version.
682 * Doc/doxygen.config.in: dropped search related obsolete flags
683 * src/gdcmParser.h, gdcmHeader.h: doxygenation
685 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * DEVELOPPER: added some helpfull comments for compile/test/install
689 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
690 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
691 src directory, now generated in the build dir.
692 2. Tests as mentionned smarter
694 4. Add a new method in gdcmDict that return the PubDict by name
695 this is interesting for 3rd party lib like ITK,
696 where we could set the institution name / patient name...
698 * ENH: 1. Now the test suite is working for real
699 2. All binaries are now output in the gdcm-bin directory
700 (this was not true before)
702 2004-04-28 Jean-Pierre Roux
703 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
704 SeQuence indented printing of Dicom Header.
705 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
706 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
707 Computation of SQDepthLevel is now part of gdcmHeader constructor
708 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
709 tree-like structure of a Dicom Header.
710 * FIX Test code cleaning
712 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * ENH: Adding automatic testing
714 1. Need a DartConfig.cmake to submit to public
715 2. Add a test driver gdcmTest.cxx
716 3. gdcmTestMain, an helper for the main test driver gdcmTest
717 4. Files in Test don't have a main anymore, this becomes interesting
718 when we add more and more tests, thus dsw don't have to load
720 * ENH: Adding a GDCM_DATA_ROOT for testing
721 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
722 one file instead of seven + some small cleanup
724 2004-04-22 Jean-Pierre Roux
725 * ENH Minor changes to the Print() methods.
726 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
727 Header printing. Example given with :
728 > PrintHeader fileName 2 new
729 (SQ based tree-like structure still to be done for the Header ...)
731 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
732 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
733 1. I have added some unsigned where needed
734 2. Some function parameter not used -> (void)
735 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
736 4. g++ don't like character '\' in comment
737 5. #define jpeg_create_decompress jCreaDecompress
738 this really need to be fixed
739 6. virtualize destructor of gdcmObject ... leakage
740 7. sscanf(g->first.c_str(),"%x",&gr_bid);
741 this also really need to be fixed
742 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
743 remove compression file
744 (as we only do decompression, right ?)
745 * ENH: Change malloc/calloc/free with c++ equivalent
747 2004-04-21 Jean-Pierre Roux
748 * FIX gdcmHeaderHelper::GetXSpacing
749 when a single value is found (bug ?), xpacing is now
750 defaulted to yspacing
752 2004-04-19 Jean-Pierre Roux
753 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
754 * ENH add parameters :
755 bool exception_on_error = false,
756 bool enable_sequences = false,
757 bool ignore_shadow = false
758 to the gdcmFile constructors to be full gdcmParser compliant
759 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
760 to allow reading of PAPYRUS 3.0 files
762 2004-04-06 Jean-Pierre Roux
763 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
765 2004-04-02 Jean-Pierre Roux
766 * ADD : Test/checksequence.sh, for a general recap on SQ pb
767 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
768 for Philips spurious Tag fffe|0000 while rewritting Dicom files
770 2004-03-30 Jean-Pierre Roux
771 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
772 for ACR file, written out as DICOM files (hope so...)
774 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
775 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
776 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
777 moved to base class gdcmParser and only the specialisation is kept
779 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
780 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
781 already does the job.
782 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
783 (to be consistent with gdcmParser::WriteEntries).
785 2004-03-30 Benoit Regrain
786 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
787 upate of the object's instance. It's passed to 2 in the unfavorable
788 case : one in the ExecuteInformation, one in the ExecuteData
790 2004-03-29 Jean-Pierre Roux
791 * ENH : Check on file type to be written moved
792 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
793 * FIX : gdcmObject::ResetBoundaries now stops properly
794 when end-of-list is reached
795 : gdcmVersion modified (as Benoit Regrain asked)
797 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
799 * src/gdcmUtil.cxx: added forgotten iostream include.
800 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
801 equivalent to ExplicitVR in existing code).
803 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
805 now contains all the gdcmGlobal related code.
806 * minor coding style and doxygenation changes.
808 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
809 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
810 now contains all the Debug related code.
811 * minor clean-up of includes in src/*.cxx
812 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
813 CreateCleanString) removed.
814 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
815 * Doc/DoxyMainPageUser.txt added.
816 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
817 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
820 2004-03-24 Jean-Pierre Roux
821 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
823 2004-03-23 Jean-Pierre Roux
824 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
825 big endian made volumes
826 * ENH Now gdcmParser constructor and destructor are protected to forbid
827 end user to instanciate class gdcmParser
828 (only gdcmHeader and gdcmDicomDir are meaningfull)
830 2004-03-22 Benoit Regrain
831 * FIX : src/gdcmDicomDir.cxx : make windows compilable
832 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
833 gdcmSerie to gdcmDicomDirSerie
835 2004-03-19 Jean-Pierre Roux
836 * ENH Now the tree-like structure describing a DICOMDIR comming from
837 an already existing DICOMDIR file is consistent with
838 the home-made tree-like structure build ex-nihilo
839 or build from the files held (recursively) in a Directory
840 functions gdcmDicomDir::CheckBoundaries()
841 gdcmObject::SetBoundaries() added
843 2004-03-17 Jean-Pierre Roux
844 * REM (Eric Boix bug) : removal of meaningless
845 gdcmDicomDirImage::NewImage function.
846 * FIX now file names and directory name are written properly in the
848 * FIX now gdcmDicomDir constructor may be call without any trick
851 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
852 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
853 of gdcmDicomDirImage::NewImage as empty function.
855 2004-02-28 Jean-Pierre Roux
856 * ENH add gdcmDicomDir:NewPatient
857 add gdcmDicomDirPatient:NewStudy
858 add gdcmDicomDirStudy:NewSerie
859 add gdcmDicomDirSerie:NewImage
860 to allow making gdcDicomDir object.
861 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
862 (as opposite to the gdcmHeader chained list)
864 2004-02-11 Benoit Regrain
865 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
866 when using from python
868 2004-02-10 Benoit Regrain
869 * FIX : bug fix in the gdcmDirList for the recursivity in directories
870 * FIX : in gdcmDicomDir when the directory is empty
871 * ENH : add callback and methods to get the progression of dicomDir
874 2004-02-06 Jean-Pierre Roux
875 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
876 - GDCM_META added to gdcmDicomDirType
877 - class gdcmMeta created
878 * ENH : - A brief summary is now displayed at the beginning of
879 'testDicomDir' to help disaster magnitude estimation
880 * REM : Now useless Test/explDICOMDIR.cxx
882 2004-02-05 Benoit Regrain
883 * ENH : add methods in gdcmObject to get the hash table or the list of
885 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
886 * FIX : wrapping python for TagHeaderEntryHT
888 2004-02-04 Benoit Regrain
889 * FIX : even length for some strings when writting the dicom dir
890 * FIX : sort the images in the dicom dir
891 * FIX : Bug fix for python use of dicom dir
892 * ADD : a python demo
894 2004-02-04 Jean-Pierre Roux
895 * FIX : Final solution (?) for icone embedded images
896 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
897 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
898 add groups 6002, 6004, 6006, to allow 'clean' parsing of
899 gdcmData/gdcm-MR-SIEMENS-16.acr1
900 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
901 to make full checking easier
903 2004-02-04 Benoit Regrain
904 * FIX : WriteEntries : coding style & logic in parameters
905 * FIX : Set the elements to create the DicomDir in a dictionary file
907 2004-02-03 Benoit Regrain
908 * gdcmDirList : to parse a hard drive directory in recursive (or not)
909 * gdcmDicomDir : add the load of directory
910 * Bug fix and print add-on
912 2004-02-03 Jean-Pierre Roux
913 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
914 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
915 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
916 * FIX gdcmParser.cxx : 'group length' elements are now considered
917 as integers, even for shadow groups, when file is Implicit VR
919 2004-02-02 Jean-Pierre Roux
920 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
922 of the last synonym :-(
923 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
925 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
926 * FIX taking into account the possible 7fe0,0010 multiplicity
927 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
928 to allow removal of references to 7fe0,0010, to deal with
929 ACR-NEMA images, when 0028,0200 is meaningfull
931 2004-01-31 Jean-Pierre Roux
932 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
933 no longer writes 'Un' on disk
934 * FIX SQ elements with actual length are now dealt with corectly
935 * FIX gdcmFile::WriteBase make the difference, for color images, between
936 the length (for Palette expanded images)
937 and Raw Length (non expanded image + Palette)
938 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
939 (that broke Write). Replaced by UL.
940 Aware user will reload the field if he
941 thinks it's necesssary
943 2004-01-30 Jean-Pierre Roux
944 * gdcmParser::CheckSwap() now defaults the filetype to ACR
945 when 'dirty Acr' is found, to be compliant with the new
946 IsReadable() methods.
948 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
949 (no DOUBLE images in kosher DICOM,
950 but so usefull for people that miss them ;-)
952 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
953 DICOMDIR related utilities (not checked as Windoze compliant)
955 2004-01-28 Jean-Pierre Roux
956 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
958 2004-01-27 Jean-Pierre Roux
959 * gdcmParser constructor has a new boolean param,'ignore_shadow',
960 to allow skipping the shadow elements, to save memory space.
961 The TRUE value for this param has to be used
962 with a FALSE value for the 'enable_sequence' param.
963 ('public elements' may be embedded in 'shadow Sequences')
964 * gdcmHeader methods now deal with 'embedded icones images' in the header
965 (even when an 'icone image sequence' is announced by the
966 element (0x0088,0x0200), but there is NO icone at all ...
968 * gdcmHeader sometimes Image Location value doesn't follow
969 the supposed processor endianity (see gdcmData/cr172241.dcm).
972 * gdcmHeader add the method
973 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
974 to get *all* the Header Entries with the same tag.
975 GetHeaderEntrySameName is probabely *useless*
976 (no meaning : Name is *not* an identifier within the Dictionnary)
978 2004-01-26 Benoit Regrain
979 * Bug fix in the print of hexadecimal representations. Remove long fields
980 in the print and add a third level of print to print them
982 2004-01-23 Benoit Regrain
983 * Bug fix on field having a VR = 'UI'. Assume that is a string field
984 * Bug fix on test suite after remove the strip made on not string fields
985 * Split the IsReadable method between gdcmParser which test that the file
986 is dicom and gdcmHeader which test that it's an image file
988 2004-01-22 Benoit Regrain
989 * DicomDir : clean code, add methods, set variables in protected or private
990 * gdcmUtil : bug fix for the clean string method
992 2004-01-19 Benoit Regrain
993 * Add the use of shadow dictionaries
994 * bug fix and coding style
996 2004-01-19 Benoit Regrain
997 * src/gdcmFile.cxx : bug fix concerning the close of file
998 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
999 * Add the update of header entries using the shadow library
1001 2004-01-19 Benoit Regrain
1002 * removal of file gdcmHeader2.cxx
1003 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1004 inheriting from gdcmParser. This split is to prepare the integration
1005 of dicom dir parsing
1006 * bug fix under python
1008 2004-01-16 Jean-Pierre Roux
1009 * REM removal of class gdcmHeaderEntrySet
1010 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1011 * ADD add file gdcmHeader2.cxx
1012 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1014 2004-01-15 Benoit Regrain
1015 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1016 entries created while parsing the header. Thus, they will be destroyed
1017 when the gdcmDictSet will be destroyed
1018 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1021 2004-01-15 Benoit Regrain
1022 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1023 made a fatal error because of the memory release at the end of program.
1024 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1025 some memory and vtk seems to have some problems with that.
1026 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1028 2004-01-14 Benoit Regrain
1029 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1030 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1031 * src/*.[h|cxx] : make changes due to class name changes
1032 * gdcmPython/demo/*.py : bug fix due to method names
1034 2004-01-13 Benoit Regrain
1035 * src/*.[h|cxx] : coding style
1036 * vtk/*.[h|cxx] : coding style
1038 2004-01-13 Benoit Regrain
1039 * gdcmPython/testSuite.py : test the readable flag of file for tests
1040 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1041 It's lied to the stl compilation by MSVC (windows, always windows...)
1042 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1044 2004-01-12 Benoit Regrain
1045 * src/*.h : add comments
1046 * src/gdcmDictSet.h : set the method BuildDictPath in public
1047 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1048 directly setted in the source code
1049 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1052 2004-01-09 Benoit Regrain
1053 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1054 * setup.py : use a reference to gdcmVERSION
1056 2004-01-07 Benoit Regrain
1057 * Modification to compile with the distutils.
1060 2003-12-10 Benoit Regrain
1061 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1062 can use a gdcmHeaderHelper to load datas
1063 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1064 made in the source code
1066 2003-12-10 Benoit Regrain
1067 * Update Windows projects and .cvsignore files
1069 2003-11-12 Jean-Pierre Roux
1070 * ENH gdcmHeader constructor has one more parameter (default value : false)
1071 that allows the user to 'go inside' the SeQuences only
1073 gdcmElValSet:Print takes it into account
1075 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1076 * ENH: Update gdcmPython/CMakeLists
1077 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1078 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1080 2003-11-10 Jean-Pierre Roux
1081 * FIX : gdcmHeader::LoadElements is now based
1082 on the ListTag listElem member,
1083 not longer on the TagElValueHT tagHt member
1084 * ENH : PrintPubElVal shows (temporarily) both results,
1085 with the tagHt member and the listElem member.
1086 (it's easier to 'see' the problems when using Printheader)
1088 * FIX : old private member LgrElem is now splitted into
1089 ReadLength : Length actually found on disk (updated only
1090 if bug fixing is necessary), for internal
1092 UsableLength : Updated by FixFoundLength, to fix a bug
1093 or to allow Parser going on.
1094 Will allow to re-write a kosher header when a SeQuence
1095 with a length (not 0000) is found
1096 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1097 because gdcmElValSet::Add does not update ListElem
1100 2003-11-07 Jean-Pierre Roux
1101 * FIX misstyping in Transfert Syntax name table
1102 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1103 when they have an actual length (not 0000 nor FFFFF)
1104 (Nobody should care of it, but DICOMDIR explorers)
1106 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1107 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1109 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1110 * ENH: vtkGdcmReader now supports LUT !
1111 (vtkgdcmViewer for now is not able to use them though)
1113 2003-11-05 Jean-Pierre Roux
1114 * in testSuite.py : new files names for checking the package
1115 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1116 that returns the pixel area size to the *aware* (vtk) user
1117 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1119 2003-11-05 Benoit Regrain
1120 * in testSuite.py : Modify the rules for checking the paths
1121 : Explicit error messages
1122 * in __init__.py : Related modif
1124 2003-11-03 Jean-Pierre Roux
1125 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1126 to be used by aware (vtk) users that want to manage
1127 LUT (and no to turn the PALETTE image into an RGB pixels one)
1128 * GetPixelType now returns 8U for 24 Bits images
1129 (vtkGdcmReader compliant)
1131 2003-10-31 Jean-Pierre Roux
1132 * Removal of *all* gdcmData images and add them again
1133 in order to loose the 'history' of un-anonymised images
1135 2003-10-31 Jean-Pierre Roux
1136 * RMV : removal of useless jBitsInJsample.h
1137 for both 8 and 12 Bits JPEG Lossy Libraries
1139 2003-10-31 Jean-Pierre Roux
1140 * ENH : Add the functions gdcmFile::GetImageDataRaw
1141 gdcmFile::GetImageDataIntoVectorRaw
1142 that act as GetImageData and GetImageDataIntoVector
1143 except the making of an RGB Plane from Gray Plane + LUT
1144 Intended to aware (vtk) users who know how to manage
1147 GetLUTRGBA return a R,G,B,A LUT if any
1148 lgrTotaleRaw gives the 'Raw' length
1149 GetImageDataRaw returns the gray Plane
1150 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1151 (They stay Grey, just like with other Dicom viewers :-(
1153 2003-10-30 Jean-Pierre Roux
1154 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1156 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1157 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1158 being coherents dicom files.
1160 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1161 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1163 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1164 * ENH: Two steps is necessary to please VC++ compiler...
1165 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1166 * ENH: Add include dir to medcon lib
1167 * FIX: only one function is being exported for now !
1168 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1170 2003-10-29 Jean-Pierre Roux
1171 * adding gdcmHeader::GetLUTRGBA
1172 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1173 --> Mathieu, the modif u're waiting for is not yet committed
1174 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1176 2003-10-27 Jean-Pierre Roux
1177 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1178 00191113.dcm DermaColorLossLess.dcm
1179 MxTwinLossLess.dcm RadBWLossLess.dcm
1180 * ENH: For version prior to vtkImageViewer2 -r 1.19
1181 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1183 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1184 * Removal of ido stuff in CMakeLists.txt
1186 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1187 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1188 * FIX: remove a call to ->Modified ... see comments
1189 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1191 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1192 * FIX: Problem with path for libvtkgdcmPython
1193 * ENH: Try adding a search script for python site-package
1194 * RMV: Remove some file from medcon lib that are not necessary
1195 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1196 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1197 * FIX: More pragma disable fro VC++,
1198 I don't think I break something as it is also disable in VTK/ITK.
1199 But it fasten debug compilation time.
1201 2003-10-23 Jean-Pierre Roux
1202 * gdcm now deals with 16 Bits Run Length Encoded images
1203 (they are compressed as 2 planes images,
1204 one for the high Bytes, the other for low Bytes)
1206 2003-10-22 Jean-Pierre Roux
1207 * Now CheckRead takes into account :
1208 - the bugged 'Leonardo' Siemens images
1209 - the XA images, sent thru the burning VPRO station
1210 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1213 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1214 * FIX: When copying a Makefile.am to CMakeLists.txt
1215 one should remove the '\'
1217 2003-10-22 Jean-Pierre Roux
1218 * in gdcmData adding a bugged 'Leonardo' Siemens image
1219 (wrong lengths in header)
1220 OK with gdcm, KO with the other viewers :-)
1221 * add a GE dlx XA image, thru the VEPRO burning station
1224 2003-10-21 Jean-Pierre Roux
1225 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1226 for a brutal checking of vtkgdcmViewer compliance
1228 2003-10-21 Jean-Pierre Roux
1229 * add the files for 'xmedcon' Jpeg Lossless library
1230 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1232 2003-10-21 Jean-Pierre Roux
1233 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1235 2003-10-21 Jean-Pierre Roux
1236 * garbage Siemens 'Leonardo' images dealt with
1237 (the patch is easy to remove)
1238 * cosmetic changes to avoid warnings
1240 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1241 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1242 no need to press 'r' now.
1244 2003-10-20 Jean-Pierre Roux
1245 * upgrade of checkRead.sh checkWrite.sh according
1246 to new Jpeg Lossless decompressor
1247 * add US.3405.1.dcm, a genuine RGB medical file ...
1248 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1249 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1251 2003-10-15 Jean-Pierre Roux
1252 * general anonymisation in gdcmData
1253 * adding the 'color files' from
1254 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1255 * adding some well knowed bugged-header images
1256 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1257 waiting for their inclusion in Python testsuite
1259 2003-10-15 Jean-Pierre Roux
1260 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1261 no longer seg faults when file is not found
1263 2003-10-14 Jean-Pierre Roux
1264 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1267 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1268 * TODO: *.in file to genereate a UseGDCM later
1270 2003-10-14 Jean-Pierre Roux
1271 * Some supposed-to-be Dicom Images have no preamble.
1272 OpenFile takes it into account
1273 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1274 * Missing elements added in dicomV3.dic
1275 (just to be affraid : have a look at
1276 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1277 and do it again next year ;->
1279 2003-10-13 Jean-Pierre Roux
1280 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1281 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1282 But there are NOT. It's fixed !
1284 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1285 * FIX: "jpeglib.h" was not found on VC++
1286 * FIX: vtkgdcm was not being installed
1288 2003-10-10 Jean-Pierre Roux
1289 * ENH : OpenFile closes the file if it *really* doesn't look like
1290 an ACR-NEMA / DICOM one.
1291 * FIX : testWrite no longer writes an empty file if the source file
1292 is not gdcm Readable
1293 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1296 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1297 * FIX: CMake generate now documentation
1298 * ENH: out of source doc build !
1299 * ENH: Generate both user and dev documentation
1300 * ENH: Should work on windows too
1301 * ENH: Only one doxygen config.in file is needed
1302 * FIX: make install should be ok now on ùnix plateform
1303 * FIX: PATH to dictionary was wrong (missing /)
1304 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1306 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * vtkGdcmReader is now able to read rgb dicom file.
1308 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1309 * added a gdcmViewer to vtk test, use mouse to control
1310 window level & window width
1312 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * CMake-ification of gdcm, we have now two build system
1314 * FIX: on cygwin Wsock32 doesn't exist
1315 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1317 2003-10-06 Emanuel Ollart
1318 * FIX : compilation process wad broken.
1319 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1321 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * change gdcmViewer -> vtkgdcmViewer
1323 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1325 2003-10-06 Jean-Pierre Roux
1326 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1327 ( e.g : well known GE images with a wrong elem length,
1328 : Philips MRI Images with a wrong Huffman table)
1329 * still to be done : allow the reading of bugged LEONARDO Siemens images
1331 2003-10-03 Jean-Pierre Roux
1332 * Odd length strings are padded with '\0' (not with spaces,
1333 to remain compliant with already defined strings,
1334 like Transfert Syntax UID and others)
1336 2003-10-03 Jean-Pierre Roux
1337 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1338 to allow displaying RGB images (not only by affim ;-)
1340 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1341 * vtkGdcmReader is now able to read rgb dicom file.
1342 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1344 2003-10-03 Jean-Pierre Roux
1345 * A few nasty patches to allow the reading of a lot of nasty images
1346 ( e.g : well known GE images with a wrong elem length,
1347 : Philips MRI Images with a wrong Huffman table)
1348 * still to be done : allow the reading of bugged LEONARDO Siemens images
1350 2003-10-03 Jean-Pierre Roux
1351 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1353 2003-10-03 Jean-Pierre Roux
1354 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1355 to allow displaying RGB images (not only by affim ;-)
1357 2003-10-03 Jean-Pierre Roux
1358 * gdcmFile::GetImageDataIntoVector now
1359 - deals with MultiFrames MultiFragments Run Length Encoded files
1360 - deals with YcBcR (YBR_FULL) files
1361 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1362 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1364 (no sample found :-(
1366 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1367 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1368 Two reasons: - clear things
1369 - third parties acces gdcm through header files, so won't
1370 suffer anymore VC++ complains
1372 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1373 * add argv[1] in testvtkGdcmReader.cxx
1376 2003-09-24 Jean-Pierre Roux
1377 * The lines are now eigthy characters long.for
1378 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1380 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1382 char* to std::string. Thus, the use of strdup becomes useless. (see
1383 previous commis of Malaterre)
1384 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1385 before the last Malaterre's commit.
1387 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1388 * This commit should fix the Debug building under VC++, the problem
1389 was mainly a mixture of debug and release lib being loaded at startup.
1390 * I also remove a depency to a specific C function: strdup. Because I had
1391 to force the link to msvcrtd (whereas strdup is in libc).
1393 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1394 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1395 located in the gdcmCommon.h file. All use of reference of tha has been
1396 changed to now use the variable GDCM_UNFOUND.
1398 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1400 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1401 Dicom dictionary. The test suite can now be run again. Note:
1402 I'm note very happy with the " (RET)" changes. I believe this
1403 RETAINED comment should be dropped when parsing the dictionary.
1404 - PACKAGER corrected
1406 - AUTHORS updated and now in alphabetical order
1407 * Makefile.am now exports gdcm.dsw for Windoze users.
1409 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1410 * cygwin complains about missing std:: in subdir Test/
1412 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1413 * remove some methods that are now in gdcmHeaderHelper
1415 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * vtkGdcmReader set spacing and origin correctly
1418 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1419 * Fix a few delete/delete[] mismatch
1421 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1422 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1423 interpretation to data given by gdcmHeader. For instance there are
1424 heuristics to get informations (look at different places).
1425 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1426 sorting DICOM images based on different strategies.
1427 * modified Makefiles accordingly.
1429 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1430 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1431 when building in debug mode
1432 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1433 src/win32/gdcmdll.dsp
1434 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1436 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1437 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1440 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1441 * src/win32/libgdcmjpeg12.dsp was not dos format
1442 * src/win32/libgdcmjpeg12.dsp :
1443 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1444 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1446 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1447 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1449 * src/gdcmFile.cxx : bug fix in affectation type
1450 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1451 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1452 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1453 symbols... future problem ?
1455 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1456 * src/win32/libgdcmijpeg12.dsp was missing
1457 * modified gdcm.dsw accordingly
1459 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1462 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1463 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1464 commit of JPR (before his hollidays to facilitate our work).
1465 * setup.py : bug fix in code. Modifications made while the last commit
1466 of JPR. The code hasn't been tested before the commit... it's so
1467 useless to make that (for best programmer that is JPR) !!!
1469 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1470 * tagged the current version as Version0_3 (i.e. version 0.3)
1472 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1473 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1474 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1475 * *.dsp : modifications to use new libgdcmijpeg8 library
1476 * setup.py : bug fix on VTKPATH variable
1477 * PACKAGER : adding all concerning windows
1479 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1480 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1482 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1483 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1484 test suite reported error.
1485 * PACKAGER file added (describes what a packager must do when
1486 packaging a new release).
1487 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1488 * configure.in: upgraded version number to 0.3.0
1489 * fixing build of rpm (through rpm -ta):
1490 - Doc/Makefile.am exports proper doxygen files
1491 - src/jpeg/libijg8/Makefile.am exports the include files.
1493 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1494 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1495 * src/gdcmHeader.h : formatting code
1497 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1498 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1499 We were obtaining error message from vtk. Now, creation of file list
1500 is made in an internal list to prevent this problem.
1501 Bug fix when output is empty.
1502 Bug fix in update of progress value. Previous commit for this was a bad
1504 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1506 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1507 * src/gdcmHeader.h : added method to get the file name
1508 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1509 files. Added method to remove all files on the input
1510 Added FIXME comment concerning the bad parsing of header made by
1511 ExecuteInformation method (in ExecuteData method)
1513 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1514 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1515 when using make instal.
1516 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1517 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1519 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1520 * setup.py : adding include dir of jpeg lib to compile all sources
1521 * */Win32/*.dsp : JPR fix for windows compilation
1523 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1524 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1526 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1527 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1529 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1530 * setup.py is again effective on un*x (takes into account the
1531 addon of the jpeg library)
1532 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1533 * Doc/Doxy* updated (includes above enhancements)
1534 * INSTALL now points to web documentation
1536 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1537 * src/gdcmHeader.h doesn't make unnecessary reference to
1539 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1541 * src/gdcm*.[cxx|h] :
1542 - to allow compilation with gcc 3.x
1543 -- clean up of STL usage (added explicit usage of std::)
1544 -- small fixes on exceptions.
1545 Note: linking not tested !
1546 - clean of doxygen comments to avoid warnings at documentation
1548 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1549 dependent convertion).
1551 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1552 * Clean up of previous JPR garbage commit (not even commented in the
1554 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1555 - moved all jpeg related files from src to src/jpeg/libijg8, with
1556 addition/modification of Makefile.am and configure.in.
1557 - the testSuite is still brain damage (not guilty).
1559 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1560 * WrapVTK.py : modifications to get correctly vtk source files to
1562 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1563 (FileName -> Filename)
1565 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1566 * vtk/vtkGdcmReader.[cxx/h]:
1567 - UpdateProgress method should now be effective
1568 - removed the limitation on having only images loaded (as opposed
1570 - when building a stack of images/volume, a lesser number of
1571 gdcmHeader and gdcmFile instances should be used (hopefully
1572 accelerating things).
1573 - when building a stack of images/volumes, files which are not
1574 loadable (wrong path-filename, wrong permissions on existing file,
1575 or file not parsable by gdcm) are replaced with a black image
1576 in the stack (for the caller to notice the problem).
1578 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1581 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1582 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1583 between standard library (std) and vtk library (problems are found
1584 under Windows... thanks Windows !)
1586 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1587 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1589 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1591 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1594 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1595 * When compiling with distutils (see setup.py) the C++ compiler is
1596 called with different flags than the default ones (with automake).
1597 In order to fix all those warning, I compiled gdcm with the command
1598 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1599 and went for warning fixes:
1600 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1601 up from unused variables.
1602 - vtk/vtkGdcmReader.cxx: potential bug fix.
1603 * src/gdcmHeader.h: Doxygen warning cleanup
1605 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * gdcmPython/gdcm.i:
1607 - typemaps correction to take into account the systematic replacement
1608 of "using namespace std" with std:: prefix e.g. std::list,
1609 std::string... (cf changes of 2003-05-21).
1610 - gdcmGlob global variable of type gdcmGlobal (defined in
1611 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1612 exported to Python a as cvar.
1613 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1614 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1615 gdcmDictSet.GetPubDictTagNames() and
1616 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1617 C++ static methods).
1618 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1619 with the above changes.
1621 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * setup.py, manifest.in : bug fix under linux
1624 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1625 * Modification of setup.py to compile vtk part too. Then, we have 2
1626 wrappers which must work with same distutils. For that, we have a
1627 generic distutils in distusiltsWrapping.py ; with :
1628 - build_extWrap class to wrap generically all extensions,
1629 - ExtensionWrap base class for all wrapping extension that contains
1631 - Wrapper interface which wrap sources
1632 + In WrapSwig.py we have extension and wrapper for Swig
1633 + In WrapVTK.py we have extension and wrapper for VTK
1634 * MANIFEST.in : modifications to consider vtk directory and new python
1635 files for compilation
1637 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1638 * Added python wrappers of vtkGdcmReader vtk class (see the
1639 source in vtk/vtkGdcmReader.cxx) :
1640 - vtk/Makefile.am now builds a library
1641 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1642 python library (as opposed to _gdcm.so wich are the python
1643 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1644 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1646 - configure.in has an additional flag --enable-vtk that needs
1647 to be set to enable compilation of vtk related code, that is:
1648 + vtk/vtkGdcmReader.so and
1649 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1650 + gdcmPython/vtkgdcmPython.so (see above)
1651 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1652 be read when compressed or when HighBit + 1 != BitsStored),
1653 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1654 the usage of the python wrapper of vtkGdcmReader vtk class.
1655 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1656 * src/*.[h] all occurences of stl classes are now prefixed with
1657 std::, and all occurences of "using namespace std;" where removed.
1658 This is to avoid pollution of global namespace in included files.
1659 Apparently vtk does not avoid this pitfall: when using both
1660 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1661 collision of various stl members (principally cout...).
1662 * gdcmPython/testSuite.py now cleanly removes temprory generated
1664 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1665 comply with above changes)
1667 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1668 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1669 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1670 vtk data structure (an image Flip was required).
1671 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1672 * cosmetic changes in documentation.
1674 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1675 * src/gdcmHeader.cxx: the constructor no longer exits when an
1676 unexisting file is given as argument.
1677 * The subdirectory Data (containing all the images used for the
1678 test suite) is not part of this repository anymore. A new module
1679 containing those images is now available at
1680 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1681 with the name gdcmData.
1682 All the python scripts (including the package initialisation file
1683 gdcmPython/__init__.py) were adapated to take this change into
1684 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1686 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1687 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1688 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1689 demo of the usage of this class.
1690 Compilation of this vtk part is only done when using the --enable-vtk
1691 at configure (or autogen.sh) stage.
1693 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1694 * More memory link related corrections and documentation fixes.
1696 - maximum info is obtained with a command of the form:
1697 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1698 --show-reachable=yes PrintHeader
1699 - the remaining reachable blocks seem to come from the STL
1700 allocation scheme through the usage of map and list. It looks
1701 like this memory cannot be freed but it is not a memory leak
1702 (in fact further invocation to the STL would recollect the
1703 unused memory allthough it cannot explicitely be freed).
1704 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1705 of displaying an image parsed with gdcm and displayed with VTK.
1706 Note: some images don't seem to work e.g.
1707 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1708 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1709 Allthough this weakens the semantics, it is a ditch attempt to
1710 make gdcm more thread friendly.
1712 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1713 * Memory link hunt (by using valgrind through the command
1714 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1715 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1716 gdcmHeader::_dicom_vr.
1717 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1718 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1720 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1722 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1723 * src/Makefile.am now exports all the necessary include files at
1727 * UpdateGroupLength replaced by new one
1730 * UpdateGroupLength re-written using H-Table
1731 (named UpdateGroupLengthNew untill checks are over)
1733 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1734 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1735 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1737 - gdcmHeader::GetPubElValSet removed.
1738 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1739 UpdateGroupLength, WriteElements, Write.
1740 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1741 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1742 carried the same semantics.
1743 - src/gdcmHeaderIdo.cxx changed accordingly.
1744 - gdcmFile::WriteBase now regroups all the codes from previous
1745 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1746 - enum FileType moved to gdcmCommon.h
1747 * src/gdcmHeader.cxx AddDefault trashed
1748 * gdcmGetXSize added
1749 * getimageDataSize now calls gdcmGetXSize
1750 * Test/*.cxx changed to agree with above changes
1752 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1753 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1754 (to avoid double call by end user).
1755 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1756 by end user, since gdcmHeader::gdcmHeader now handles it.
1758 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1759 * gdcm/Doc many doxygen changes:
1760 - Doxyfile now has two different versions, DoxyfileUsers that generates
1761 the html.users end users oriented documentation and
1762 DoxyfileDeveloppers that generates the html.developper developper
1763 oriented documentation.
1764 - README changed accordingly
1765 - requirement.txt removed (old design info moved to TODO).
1766 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1767 DoxyMainPage.txt, DoxyPython.txt provide more information.
1768 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1769 be updated by simply regenerating the docs with doxygen and copying
1770 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1771 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1772 all the tests in the form "if (<map>.count() >1)" were removed.
1773 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1774 ill-formed documentation sections.
1775 * src/gdcmHeader.cxx: ditto
1777 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1778 * setup.py fixed for un*x (needed macro for stdint.h)
1779 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1780 un*ces with sh-utils test utility.
1781 * gdcmPython/demo/test.py renamed to PrintHeader.py
1782 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1783 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1784 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1785 * src/gdcm*.cxx JPR's bad inclusion fixed.
1787 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1788 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1789 * gdcmPython/demo/test.py changed accordingly.
1791 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1792 * gdcmPython/Makefile.am fixed linking against libstdc++
1793 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1794 * Swig subdir (historical tests of swig version 1.3.17++) removed
1795 * Test/testChangeEntete.cxx some lines commented out in order to make
1797 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1798 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1800 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1801 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1802 hence the user doesn't need this explicit call.
1803 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1804 i.e. LoadElements() call removed.
1805 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1806 - src/Makefile.am declares the proper flag for g++.
1807 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1808 for adding user defined new tags.
1809 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1810 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1811 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1813 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1814 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1815 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1816 src/Makefile.am : the project should properly compile and install
1817 with the autotools, included the python wrappers part.
1818 * gdcm.spec.in : added a spec file for RPM packaging.
1820 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1821 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1823 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1824 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1825 to exported to the environement (see gdcmPython/testSuite.py
1827 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1828 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1829 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1830 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1831 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1833 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1834 * gdcmPython/__init__.py doesn't crash anymore when running in
1835 in InstallMode or PreInstallMode but with an environement given
1836 value of GDCM_DICT_PATH.
1837 * src/gdcmDictSet.[cxx/h] coding style.
1839 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1840 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1841 * src/gdcm.h general comments moved to TODO, and README
1842 * src/gdcm.h should now be seen as a user commodity (including it
1843 should suffice to fully use gdcm). It is nowhere including within
1844 any of the kernel files src/*.cxx and src/*.h.
1846 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1847 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1848 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1850 * src/gdcm*.cxx only include their corresponding include file
1851 (as opposed to gdcm.h)
1852 * gdcmPython/gdcm.i changed accordingly
1853 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1854 the autogen.sh generated "make snapshot" command to work.
1855 * autogen.sh removed history related references to crea package.
1857 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * distutilsSwigCPlusPlus.py work around some swig portability
1861 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1863 was done in a last ditch attempt to get setup.py _really_
1864 operationnal. The python/gdcmPython layaout add the advantage
1865 of hidding away the python related distutils specific files
1866 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1867 Alas, the src directory was out of scope (i.e. it's relative
1868 position to setup.py was ../src) which made things impossible to
1869 handle (see previous version of python/setup.py). Crossing fingers...
1871 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1872 * python/setup.py now works on Un*x. (harder than I thougth)
1873 * python/distutilsSwigCPlusPlus.py can now have include files
1874 among the list of sources.
1876 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1877 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1878 * modifications in MSVC projects
1880 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1881 * As stated by the first lines of Test/ExceptionAndPython/README, it
1882 looks like we can move back to original usage of exception within
1883 src/gdcm* and hence remove the errno stuff that was introduced
1884 as a quick and dirty fixture of this problem (added to the TODO).
1885 * Doc/Doxyfile configuration file for Doxygen and corresponding
1886 README file for usage added.
1887 * Test/testWrite.cxx added. This new test comes from a split of
1888 test.cxx that is now reverted to its original purpous i.e.
1889 testing the proper parsing of a Dicom related file.
1890 testWrite.cxx concentrates on testing the IO part of gdcm.
1891 * Test/bug1.cxx (containing a bug on WIn32) added.
1892 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1893 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1894 whose purpose is to publish the content of the TagNames of the
1895 Dicom public dictionnary were not accessible without an
1896 instance of class gdcmHeader.
1897 - those methods are now static methods of gdcmDictSet and hence
1898 require no instances at all to be invocated.
1899 - within gdcmDictSet this change required to change some method
1900 to class methods (i.e. are now static) among which SetDictPath
1901 (renamed to BuildDictPath) and LoadDefaultPubDict.
1902 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1903 the above changes by calling the new method classes of gdcmDictSet.
1904 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1905 the above to be effective.
1906 * python/gdcmPython: in order to wrap properly the above changes
1907 for Python, swig version now needs to be > 1.3.17.
1908 * python/gdcmPython/Makefile fixed to adapt itself to new
1909 configure/make shema introduced by Johan Montagnat (thanks for the
1910 contribution). Alas this Makefile cannot be turned into a proper
1911 Makefile.am without some heavy changes in the configure.in
1912 (for python dectection).
1913 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1914 now avoids publishing the empty entries.
1916 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1917 * python/setup.py : bug fix concerning install under windows
1918 ExtraPath reused :-P
1919 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1921 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1922 * Dicts/dicomV3.dic : remove double spaces !!!
1923 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1924 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1927 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1929 method. Doxygenation.
1930 * src/gdcm.h clean up of JPR spurious comments.
1932 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1933 * python/distutilsSwigCPlusPlus.py now properly collects the
1934 shadow classes generated by "swig -c++" (gdcm.py in our case)
1935 when using "python setup.py install".
1936 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1937 reexports the working classes.
1938 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1939 by the classical C errno scheme. This is to prevent an obscure
1940 behavior of the python wrappers when importing wxPython.wx prior
1941 to gdcmPython (which ended up in an abort call). An illustration
1942 of this oddity can be found in the Test/ExceptionAndPython
1943 subdir (see the README file). This problem probably due to
1944 an combination of g++ and dynamic loading.
1945 * added Test/ExceptionAndPython (see above)
1947 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * Changed the layout of the python part to avoid bloating main
1949 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1950 i.e. the distutils arsenal. All the python related stuff is
1951 again in a python subdir, but the package itself is now in
1953 * setup.py was cleaned up:
1954 - pythonIncludePath removed
1955 - python setup.py bdist target is now functional.
1956 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1957 collision with other packages). gdcmPython/demo/*.py changed
1960 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1961 * python subdir moved to gdcmPython (preparation of distutils packaging).
1962 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1963 distutils installer is operational.
1964 * - gdcmPython/__init__.py now properly loads the swig generated
1965 shadow classes (from gdcm.py).
1966 - gdcmPython/demo/*.py changed to import the package gdcmPython
1967 instead of gdcmPython/demo/load.py.
1968 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1970 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1971 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1972 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1973 entries within the associated public Dicom dictionary resp. the same
1974 information but sorted by the fourth field (PAT, IMG, DIR) of the
1976 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1977 are now in the "???" group.
1978 - python/gdcm.i changed accordingly,
1979 - python/demo/printGroupedPublicDict.py added, that gives an example
1980 of the above new functionalities in Python.
1982 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1983 * src/gdcm.h, gdcmHeader.cxx:
1984 - historic references to glib's g_malloc and g_free (#defined)
1985 were definitively removed.
1986 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1987 * src/gdcmElValSet.cxx:
1988 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1989 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1990 - GetElValue(string) renamed to GetElValueByName.
1991 - Added GetElementByName(string).
1992 * src/gdcmHeader.cxx: added
1993 - GetPubElValRepByNumber(guint16, guint16)
1994 - GetPubElValRepByName(string)
1995 - GetShaElValRepByNumber(guint16, guint16)
1996 - GetShaElValRepByName(string)
1997 - GetShaElValByNumber(guint16, guint16)
1998 - GetShaElValRepByName(string)
1999 - GetElValRepByNumber(guint16, guint16)
2000 - GetElValRepByName(string)
2001 - GetElValByNumber(guint16, guint16)
2002 - GetElValRepByName(string)
2003 * Doc/requirements.txt added.
2005 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2006 * Test/Makefile building now depends on the one of libgdcm.so
2007 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2008 pixel data) aware which enables finding the address (offset) of
2009 the pixel data of JPEG encoded DICOM files. This leaves only a single
2010 file in the testSuite whose pixel data address (offset) is unknown.
2011 * python/testSuite.py changed accordingly.
2013 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2014 * VC++ has some strong limitations when working with the STL, as stated
2015 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2016 "Also note that some STL containers (map, set, queue, list, deque)
2017 cannot be exported. [...]
2018 Some STL classes contain nested classes. These classes can not
2020 This is caused by a designed limitation that once a template
2021 class is instantiated, it can not be re-instantiated and
2023 Since our usage of map<> is ubiquitous in gdcm, this "designed
2024 limitation" of VC++ is a pitfall.
2025 Hence the Python wrappers of gdcm cannot be incrementally linked
2026 against the c++ dynamic library. The dirty but only workaround is
2027 to forget about incremental link of dynamic libraries and to generate
2028 the Python wrappers library with the inclusions of the underlying C++
2030 The following modifications concern this matter on Win32/VC++:
2031 - wrapping python correct with standalone wrapped dll (don't use separate
2032 dll under windows !!!!)
2033 - python21_d debug mode enabled (ask Frog how to use it :-)
2034 - NO problem with having an STL member of class for example string in C++
2035 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2036 - Python test of dcmlib in Python is ok under windows on a large set
2038 * removed glib references
2039 * typedef's inserted in gdcm.i for correct swig type management
2041 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * python/demo/*.py load.py extracted from test.py. Added explore.py
2043 that only displays required tags and testAll.py that parses all
2044 the files of the testsuite without using unittest.
2045 * python/testSuite.py other additional test on new files added.
2046 * Data/* new test files added accordingly to the testSuite.
2047 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2048 the vr in the file differs from the one of the dictionary.
2050 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2051 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2052 values, but limits itself to values which are below a user specified
2053 size (by default 1024 bytes).
2054 * python/gdcm.i : elements not loaded (because their size is above the
2055 user specified treshold) are exported with their TagKey as key of the
2056 python dictionary. This enables the testsuite to make some checks
2057 on the unloaded elements (since we have their offset and size).
2058 * python/testSuite.py
2059 - now tests for the existence and proper value of the pixel data
2060 - two new examples added.
2061 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2063 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2064 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2065 aware. See the strategy comments in gdcmHeader::FindeLength().
2066 * Test/test.cxx now accepts a filename as first argument.
2067 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2068 * python/testSuite.py changed to integrate test on above files.
2070 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2072 the vr was also RET.
2073 * python/testSuite.py more tests added.
2075 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2076 * python/testSuite.py unittest test suite added (uses Data)
2077 * Data/* dcm and acr files for the test suite.
2078 * glib dependance removed from un*x version. We now use ISO C99
2079 7.18 Integer types (see stdint.h)
2080 - python/Makefile, src/Makefile src/gdcm.h
2081 * src/ when an explicit vr (like dicom files) suddenly poped an
2082 implicit element we use to mark the underlying DictEntry of the
2083 concerned ElValue with "Implicit". This strategy was damageable
2084 too the public or provite dictionaries, since some of their vr
2085 would be changed. Since Header::FindLength heavily relies on the
2086 detection by Header::FindVR of falsely explicit elements, I
2087 added an extra ImplicitVr member to ElValue (boolean).
2088 The rest of the changes we the necessary adaptations.
2090 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2093 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2095 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * Adaptation for porting to VC++:
2098 o forced to use std namespace (for string to be known)
2099 o all class use __declspec export style on WIN32
2100 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2101 (in stdlib.h on Win32 but in std:: for gcc)
2102 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2103 variable GDCM_DICT_PATH.
2104 * src/gdcmHeader.cxx verbose comments made discrete.
2106 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2107 * python/gdcm.i: added a typemap that converts a C++ hashing table
2108 to native Python dictionary.
2109 * python/demo/test.py:
2110 - now uses the native dictionary for exploration of gdcmHeader.
2111 - takes an optional filename argument (the file to parse).
2112 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2113 PubElVals hashing table.
2114 * Dicts/dicomV3.dic removed error prone trailing spaces.
2116 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * Python wrapping process moved away from src/Makefile to
2118 newly created python/Makefile (as well as gdcm.i)
2119 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2120 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2121 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2122 from the environement variable GDCM_DICT_PATH (when existing).
2123 * src/gdcmDict::GetTag bug fix.
2125 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2126 * Straightforward temporary fixes for swig to build the python wrappers.
2127 src/Makefile now has a python working entry [by working we mean
2128 that we can import de shadow classes without errors].
2130 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * hashtest.cxx removed (since allready in Test)
2132 * src/gdcmlib.h renamed to src/gdcm.h
2133 * src/dcm.i renamed to src/gdcm.i
2134 * src/Makefile prepared for python wrapping
2136 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2137 * src/gdcmHeader.cxx :
2138 - Parsing of header is now separated from loading of element values
2139 (see gdcmHeader::LoadElements).
2140 - general clean up of hopefully all file access (creation of
2141 ReadInt16 and ReadInt32)
2143 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2144 * src/gdcmHeader.cxx :
2145 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2147 - SetLgrElem renamed to SetLength
2148 - GetLgrElem renamed to GetLength
2149 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2150 * src/gdcmElValSet.cxx fixed both GetElValue methods
2151 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2152 due to IdoDude was cleaned out.
2154 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2155 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2156 concentrates on finding the value representation (when it exists).
2157 RecupLgr now only finds the element value length, and it avoids
2158 returning the unecessary skL (skipped length).
2159 Also, offsetCourant was simply removed (with taille_fich) since
2160 it was redundant with the File position internals (by using
2161 ftell and fseek). This also made skL (see above in RecupLgr) usage
2163 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2164 on the libido specificities which are handled through class
2166 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2169 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * Truckload of changes. Parsing of header is barely functional
2171 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2173 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * src/gdcmHeader.cxx many addons of low level methods
2176 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2178 and _IdDcmSWAP_LONG.
2180 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2181 * This corresponds to all the changes decided at the meeting of
2182 May 23 2002. Needless to say we are running late...