1 2005-06-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmUtil.cxx : change call to Util::Format to sprintf because of
3 lantency with the Util::Format function
5 2005-06-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
6 * Adding users file in CVSROOT for mail blaming
8 2005-06-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * Adding potential support for JPEG-LS DICOM files.
11 2005-05-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
12 * Adding potential support for mpeg and jpeg2000 through two new lin
14 - libmpeg2 from the MPEG consortium
15 Also adding intial work to use this lib.
17 2005-04-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Testing/TestAllReadCompareDicom.cxx : update the test printed results and
21 2005-04-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
22 * FIX : Numerical exception on borland (cannot divide by 0, doh !)
23 But this is a case where we should really signify the user there is
24 few chance the serie is really a serie...
26 2005-04-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * FIX : on X, the python part is correctly installed. All files are
28 installed in gdcm sub-directory
30 2005-04-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
31 * Builder/ : add something to facilitate the RPM creation of gdcm
33 2005-04-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * Fix gdcmDirList::IsDirectory. Apparently borland did not like the ending
36 * Also fix compilation on gcc 3.3.5 does not have ios::failure either ...
38 2005-04-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
39 * vtk/vtkGdcmWriter fix bug when writing spacing. The Y spacing comes first
41 * Fix compilation on gcc 2.96 (which does not have ios::failure)
43 2005-04-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmDictGroupName.[h|cxx] : add a correlation between a group (number)
45 and it's representation name (for the NIH)
47 2005-03-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmPixelReadConvert.cxx : problems of around of double to uint8, when
49 conversion of YBR to RGB pixels. So, now, the conversion is made using
52 2005-03-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * Testing/TestAllReadCompareDicom.cxx : now use test files (invented file
54 format) to replace 'at-run' dicom files generated by the
55 TestAllReadCompareDicom test
57 2005-03-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmFileHelper.cxx : remove memory leaks and bugs when writing files
60 2005-02-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * src/gdcmFileHelper.cxx : JPR bad personal choices fix
63 2005-02-11 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * Testing/TestMAkeIcon.cxx : complete the test
66 2005-02-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * Testing/TestWriteSimple.cxx, TestSequence.cxx : fix memroy leaks
69 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmFileHelper.[h|cxx] : now correctly set the VR of the datas when
73 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Test/VTKTestWriteSeq.cxx : add a VTK test to write sequences
76 2005-02-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Test/ : accelerate tests (it's not very significant accelerations).
78 Remove TestCopyDicom that is redundant with TestCopyRescaleDicom
80 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * Testing/TestSequence.cxx : add test for sequences of images... test that
82 we have the same serie or the same study UID
84 2005-02-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * gdcmPython/gdcm.i : bug fix. Now string are correctly converted in python
87 * src/gdcmDict.h : remove commented code
88 * src/gdcmDocument.cxx : initialize values
89 * src/gdcmFile.cxx : bug fix when reading values
90 * gdcmPython/demo/ : change file names. Remove useless files
92 2005-02-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmFile.cxx : remove the default array of initialization.
94 The static array contained pointers to non-static values (comming from
95 strings). To have coherences, when creating files, these values can't be
96 static. So, the array can't be static, too ! To simplify, the array have
97 been replaced by repeted lines to insert values in the File
99 2005-02-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmBinEntry.cxx : bug fix for BIG_ENDIAN part when writing the content
101 * gdcmPython/gdcm.i : rename gdcmHeader to gdcmHelper
103 2005-02-02 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
104 * FIX SQItem::AddEntry inserts now *in the right place* any Entry
105 (Dicom Element) into the Sequence Item
107 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/*.cxx : first parss to normalize file organisation
110 2005-01-31 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * src/gdcmDirList.[h|cxx] : add method to find a directory
112 * Test/TestAllReadCompareDicom.cxx : bug fix under Windows
114 2005-01-31 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
115 * Finish cleaning up my JPEG mess. Should be ok now.
116 * Getting toward a RLE very similar to JPEG. Every RLE stuff is now self
117 contained within the RLE* class(doh!)
119 2005-01-30 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
120 * SerieHeader::SetDirectory() allow recursive exploration of the Directory
121 * SerieHeader::AddFileName() creates as many Coherent Files lists
122 (same Serie UID) as it founds different Serie UID
123 amongst the files instead of discarting any file
124 that doesn't match with the first one he found.
125 * SerieHeader::OrderGdcmFileList has now one parameter :
126 the Coherent Files list the user wants to sort
127 * SerieHeader::GetFirstCoherentFileList() |
128 * SerieHeader::GetLastCoherentFileList() | allow to parse
129 the set of Coherent Files lists
130 * const SerieHeader::GdcmFileList &GetGdcmFileList() is kept, for backwards
131 compatibility (it returns the *first* Coherent Files list,
132 since there was only one before)
133 * Test/TestSerieHeader gets gdcmData as a default root directory
135 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * Remove friend between DocEntry and File classes
137 * Remove friend between PixelReadConverter and RLEFramesInfo,
140 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmFile.cxx, gdcmDocument.cxx : fix the bug on the group|element
142 0002|0000. The value was incorrect.
144 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * vtk/vtkGdcmWriter.[h|cxx] : add the gestion of UID
147 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * src/gdcmUtil.cxx : compilation fix on Win32
149 * src/gdcmUtil.[h|cxx] : Set the default GDCM UID in a static constant
150 variable, to be easy found. Add methods to change the default UID.
151 Amelioration of the CreateUniqueUID to use the correct default UID.
152 * src/gdcmFile.cxx : correct use of the CreateUniqueUID method to create
155 2005-01-28 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * Test/TestVR.cxx : fix memory leaks
158 2005-01-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 * Rewrite the base 256 to base 10 conversion, using string operation only.
160 This allows us to get rid of the problematic 64bits integer type (does not
161 always exist on target platform).
163 2005-01-27 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
164 * Add construct and destructor to class gdcm::Debug to close the debug file
166 * Don't let uset to open twice the same file
167 * gdcm has now an official UID prefix,
168 supplied by http://www.medicalconnections.co.uk
169 1.2.826.0.1.3680043.2.1143
170 (Thx to Mathieu for providing URL)
171 * Add a forty-entries private Dicom Dictionary (Philips MR Intera)
172 to be able to perform some more tests
173 * gdcm::ContentEntry : Contructors and Destructor are now protected,
174 in order to be sure no user will try to use them.
175 (at user level, only the children classes are meaningfull)
177 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * move RLEInfo & JPEGInfo from Document to File
180 2005-01-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * FIX : remove so many friend between classes
183 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmDocEntrySet.cxx : Bug fix when getting the value
185 * src/gdcmContentEntry.[h|cxx], gdcmValEntry.cxx : amelioration of code
187 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
188 In order to avoid missbehaviour :
189 . gdcm::DocEntry is now specialized in
190 - gdcm::SeqEntry (Dicom Sequence) as opposed to :
191 - gdcm::ContentEntry (Dicom entry with a 'content')
192 . gdcm::ContentEntry is specialized in
193 - gdcm::ValEntry (Dicom entry with a std::string representable value, i.e.
194 characters value, or integers)
195 - gdcm::BinEntry (Dicom entry with a non strig representable value
196 (user hasn't any longer to thing about the precedence of his dynamic_casts)
198 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * Test/VTKTest*.cxx : bug fix under linux
201 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
202 * src/ : rename some methods on Entry (SetXxx, InsertXxx) to have a better
203 use with python. Some methods are moved from Document to ElementSet or
204 DocEntrySet. The equivalent methods to ElementSet have been added to
205 SQItem and are virtual in DocEntrySet. Methods that may have the same code
206 in SQItem and ElementSet is directly placed in DocEntrySet
208 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * Test/VTKTest*.cxx : remove the show variable in each test method because
210 it's useless (the viewer variable replace this variable)
212 2005-01-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmDocument.cxx : bug fix on potential memory leak
214 * src/gdcmSQItem.cxx : initialize the SQItemNumber value in the constructor
215 * src/gdcmSQItem.[h|cxx], gdcmElementSet.[h|cxx], gdcmDicomDir*.[h|cxx] :
216 Add ClearXxx methods to remove all the content of the list or map
217 * gdcmDocEntrySet.h : add GetFirst/NextEntry in pure virtual
219 2005-01-25 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
220 * methods ReplaceOrCreate renamed as Insert
221 (nobody will be any longer confused by 'CreateOrReplace')
223 2005-01-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
224 * Grealty simplify the JPEg decompression, no need to differenciate based on
225 the JPEG possible type (with/without fragment, with/without multiple frame).
226 Everything is done throught the JPEG IO Suspension mechanism in IJG
228 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
229 * Stage 3 of normalization :
230 in order to avoid any missunderstanding while reading method names :
231 - All the methods xxxEntry now deal with dicom Entries
232 - Methods GetEntry splitted into
235 - Method SetEntry renamed as SetEntryValue
236 - Method SetEntryBinArea let as it was
238 2005-01-24 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
239 - Add empty nutshell for JPEG-LS (JPG-LS in NOT jpeg 'lossless')
240 - Position correctly the entry points for JPEG2000 and JPEG-LS
241 (Now Fragments info is get from the file, even for JPEG2000 and JPEG-LS)
243 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDicomDirElement.h, gdcmDict.h : rename AddNewXxx methods to AddXxx.
245 * src/gdcmDict.h : rename GetDictEntry moethod to GetEntry, to be coherent
246 with other method names
247 * gdcmPython/gdcm.i : bug fix. Add the typemaps for the TagName type
248 * Test/TestDicomDirElement.cxx : add new test
250 2005-01-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
251 * Finish the CreateUniqueUID stuff. Seems to compiled/runs on every
252 plateforms ITK support. Had some troubles with uint64_t on Win32, go to
253 http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclang/html/_langref_data_type_ranges.asp
254 for more info. Basically you can not used 'unsigned' __int8 in an ostream.
255 So can't you use __int64 in ostream at all.
257 2005-01-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
258 * bug fix for compilation on MSVC6
259 * gdcmPython/gdcm.i : rename of classes missed
261 2005-01-21 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
262 * Stage 2 of names normalization :
263 - A gdcm::Document is now either a gdcm::DicomDir or a gdcm::File
264 (easy to understand ...)
265 - gdcm::FileHelper replaces old class gdcm::File
267 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
268 * gdcmDicomDirElement.[h|cxx] : change the AddEntry method. Now, it gets a
269 type and not a string. So, there remove problems on the format of the
272 2005-01-20 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
273 * Add Example/TestPapyrus.cxx
274 - reads a Papyrus file (gdcm::Header compliant),
275 - gets the pixels of all the images, using low level iterators
276 - writes an multiframes Dicom image.
277 (Just to show it's *possible* to do that)
278 Uses SQItems accessors (we could use it as a 'Test' program, to improve test
281 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDicomDirObject.h : set the FillObject method in protected.
283 Thus, DicomDirXXX are created with a flad that indicates if the created
284 object is empty or not (when not empty, the DicomDirElement is used to
287 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDicomDir.cxx : simplify the NewPatient method, like made in
289 gdcm::DicomDirPatient, gdcm::DicomDirStudy, gdcm::DicomDirSerie
291 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
292 * src/gdcmSQItem[h|cxx] : rename some methods to have coherent names
294 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmDicomDir*.[h|cxx] : rename methods to be logik in their name.
296 Remove all access to the hash-tables or lists in the objects.
298 2005-01-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmDebug.h : remove the Debug test in the gdcmErrorMacro
300 * src/gdcmDocument.[h|cxx] : rename the Initialise method to Initialize, to
301 be complient with all the gdcm source code
303 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * src/gdcmDocEntry.h : DocEntry is now secure. User can't change the
307 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * gdcmPython/ : change GDCM_DATA_PATH to GDCM_DATA_ROOT to be complient with
311 2005-01-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Test/ : rename VTK tests to have a best name for the tests
313 * gdcmPython/demo/*.py.in : Change the InitTraversal/GetNextEntry use to
314 GetFirstEntry/GetNextEntry use
316 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
317 * In SerieHeader::ImagePositionPatientOrdering()
318 // a Dicom 'Serie' may contain scout views
319 // and images may have differents directions.
320 // -> More than one may have the same 'pos'
321 // Sorting has then NO meaning !
322 Thx to Eduardo Davila for reporting bug.
324 2005-01-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * Test/ShowDicom.cxx, ShowDicomSeq.cxx, TestWriteWithVTK.cxx : change the
326 test. Now it's on image content and not on the resulting visualisation...
327 might solve the problem on linux when using the OpenGL drivers
329 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
330 * ENH for DicomDir, DicomDirPatient, DicomDirStudy,
331 DicomDirSerie, DicomDirImage
332 Dict, DictSet classes :
333 -add method GetFirstEntry to replace call to InitTraversal+GetNextEntry
334 -remove InitTraversal method.
335 * UPD Test programs + Example programs
337 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
338 * remove useless and never updated keyword \ingroup
339 * Solve pb when structure (list, map, ...) is empty.
340 Thx to Benoit for reporting bug
342 2005-01-18 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
343 * Taking into account of 'Transfer Syntax' value
344 (for 'true' Dicom V3 files, the 'ACR-NEMA' heuristics sometimes gives
347 2005-01-17 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
348 * src/gdcmUtil.cxx : bug fix to find the Windows MAC address. Now, there
349 is no memory access violation
350 * gdcmPython/demo : add python demos using VTK
352 2005-01-16 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
353 * FIX 'Dictionnary' is now spelt 'Dictionary'
354 'wether' is now spelt 'whether'
355 'archieve' is now spelt 'archive' ;-)
357 2005-01-15 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
358 * ADD DicomDir, DicomDirPatient, DicomDirStudy, DicomDirSerie, DicomDirImage
359 related methods, in order not to expose internal mechanisms
362 * REM methods that exposed internal mechanisms :
363 DicomDir::GetDicomDirPatients()
364 DicomDirPatient::GetDicomDirStudies()
365 DicomDirStudy::GetDicomDirSeries()
366 DicomDirSerie::GetDicomDirImages()
367 * UPD Test programs :
371 * UPD Example program
373 * ADD DictSet methods
377 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
378 * Removed the Print/indent/default parameter mess. There is absolutely no
379 reason to have to methods, moreover with the second taking the ostream as
380 *SECOND* parameter. This was clearly a bad hack to get things compile.
382 2005-01-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * Complete rewrite of the GetMacAddress code. Now the code is *much*
384 smaller (no more MacOSX specific crap). A lot more POSIX oriented.
385 Unfortunately the main code does not work on SunOS, thus provide a specific
386 code for this platform only (and Win32 of course). Since this seems to be
387 working, change CreateUniqueUID to use GetMACAddress instead of the
388 problematic GctestetIPAddress
390 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
391 * Unfortunately to be able to test gdcmDirList I had to break the API
392 a little. Now the class is not a std::list anymore but has a member
393 std::vector (more ITK compatible). Allow unit testing on Win32 and
396 2005-01-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
397 * Update SerieHeader to take into account a Serie Instance UID to properly
400 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
401 * ENH - Comment out Mathieu's (dangerous) Super Hack
402 for dealing with BIGENDIAN processors
403 - Move equivalent stuff to BinEntry::WriteContent
404 When necessary, 16 Bits Pixels are swapped in a small buffer
405 and then written. This avoid allocating a huge buffer, in
406 PixelWriteConvertor, and avoid modifying the Pixel Area.
408 Probabely, the same operation will have to be done when we want
409 to write image with Big Endian Transfert Syntax,
410 and we are working on Little Endian Processor
412 2005-01-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmDocument.[h|cxx] : comment all methods concerning a flat hash
415 * src/gdcmElementSet.[h|cxx] : rename Initialize into InitTraversal
416 * src/gdcmDict.[h|cxx] : add InitTraversal/getNextEntry methods to parse
417 all the dict content.
418 * src/gdcmDictEntry.cxx : add a carriage return at the end of the DictEntry
420 * Test/TestDict.cxx : add a new test for the dict classes
422 2005-01-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
423 * src/gdcmDebug.h : Adding an option to redirect debug stream to a
424 file. Debug is yanked if compiled with NDEBUG
426 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
427 * src/gdcmDictSet.h : set the default output to the os variable
428 * src/gdcmDictEntry.[h|cxx] : add the Print method
429 * gdcmPython/demo/ : add a new test
431 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
432 * merging of Test/PrintDicomDir and Test/TestDicomDir
433 * removal of now redundant Test/PrintDicomDir
434 * enhancement of Example/PrintDicomDir
436 2005-01-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * Now, python test might work on systems
438 * Add the PrintDicomDir test
440 2005-01-13 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
441 * FIX : First entry following group 0002 was lost for
442 Explicit Big Endian Transfer Syntax files
443 (group and elem not swaped)
445 2005-01-12 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
446 * FIX : Old quick and dirty 'optimistic' heuristic to deal with
447 Big Endian Transfer Syntax supposed the group following 0002
448 begins always by element 0000 (element 0000 is *optional*)
449 To avoid further troubles, let's be pessimistic, and use
450 Document::HandleOutOfGroup0002() method
451 * FIX : comparison between GDCM_NOTLOADED and Transfer Syntax
452 (related pb not yet solved)
454 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
455 * Bug fix for the python part use
456 * Now, PrintHeader.py pass... but outside the ctest use. shit !
458 2005-01-12 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
459 * gdcmPython/gdcm.i : bug fix when compiling with MSCV
461 2005-01-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
462 * Untangle TransferSynatx from gdcm::Document. Now Document only manipulate
463 a string and should ask the global TS dict what are the propreties of
466 2005-01-11 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
467 * Replace confusing name SwitchSwapToBigEndian name by SwitchByteSwapCode
468 * Add the Document::HandleOutOfGroup0002(uint16_t group) method
469 to swap the Swap Code, at parsing time, when we come out of group 0002
470 and Transfer Syntax is Big Endian
471 We should be able to read now 'true DICOM" Big Endian coded images
472 * Add optional run time SetDebugOn (last param) for PrintHeader, PrintFile
473 * Replace the french 'Transfert Syntax' by the english 'Transfer Syntax'
475 2005-01-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
476 * Hopefully fix the bug on MacOSX and static global initialization.
477 This is the only -minor- patch I found that both please MacOSX and VS6.
478 Other patch would be to declare a const std::string & GDCM_UNFOUND() instead,
479 but this would require a lot of change. Another approach would be that Global
480 create those string and GDCM_UNFOUND becomes a pointer to a string (which
481 gdcm::Global would destroy at exit).
483 2005-01-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
484 * Fix bug on MacOSX with static initialization in a multy threaded
485 environment. static const string in a header file used to be ill
486 initialized provoquing the freeze of any tests. patch should solve this
489 2005-01-08 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
490 * According to Benoit's suggestion, and without any objection from anybody
491 - methods SetxxxByNumber and GetxxxByNumber renamed as Setxxx and Getxxx
492 - methods Dict::Print() and Dict::PrintByKey() merged into Dict::Print()
493 - method gdcmDicomDirObject::GetEntry() renamed as
494 gdcmDicomDirObject::GetEntryHT() to avoid confusion (and compile error)
496 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
497 * Now gdcm::Debug is clearly a copy/paste of VTK approach. You can manipulate
498 you debug/warning message just as c++ streams which make them very convinient
499 to use. Once this is stabilize I will change the ostringstrem to be
500 redirected to a file (ofstream).
501 * Properly support C99 extension: __FUNCTION__ which allow us to display
502 the name of the function call (GNUC also allow __PRETTY_FUNCTION__ for c++)
504 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
505 * Removal of useless and dangerous methods :
506 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
507 GetDocEntryByName, GetEntryByName, GetDictEntryByName
508 * Removal of usless methods :
509 Dict::PrintByName, Dict::GetDictEntryByName
510 * Commenting out of probabely useless methods :
511 Dict::GetDictEntryNames()
512 Dict::GetDictEntryNamesByCategory()
513 DictSet::GetPubDictEntryNames()
514 DictSet::GetPubDictEntryNamesByCategory()
515 * ENH : New Dicom Dictionary (with Value Multiplicity) is now used
516 * ENH : Use dicomTS.dic as described in 2004 version
517 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
518 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
519 Add Accessors on VM (Value Multiplicity), and VM related methods
520 * ADD : Add a list of 'Dicom Attribute types', as found in
521 http://medical.nema.org/dicom/2004/04_15PU.PDF
523 * ADD : Add dicomGroupNameAbbreviations.dic
524 should be used to write a method to replace the former
525 Dict::GetDictEntryNamesByCategory()
527 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
528 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
529 to read in the file... and only it ! Length is the efective length of the
530 data in the DocEntry structure
532 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
533 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
534 And now use a static function call instead, with a global variable. i
535 This is much closer to the VTK approach. Hopefully should be bulletproof
536 and easier to use...hopefully
538 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
539 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
541 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
542 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
544 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
545 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
546 ValEntry, BinEntry, SeqEntry creation or replace
548 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
549 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
550 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
552 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
553 when specifying the VR
554 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
555 * src/gdcmDocEntry.cxx : amelioration of print
557 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
558 * ADD : Add the method Util::IsCurrentProcessorBigEndian
559 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
560 * ADD Method Document::ComputeGroupLength
561 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
562 in order to allow further VR modification by user
563 * REM : removal of once-called method File::WriteBase
564 integration of its code in formerly one-line method File::Write
566 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
567 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
568 replace the different values "??", "Unkn", "Unknown".
569 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
570 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
571 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
572 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
574 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
575 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
577 * Set the gdcm::Base class to some Printable classes
579 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
580 * src/gdcmFile.[h|cxx] : add the Print method
581 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
582 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
583 * src/gdcmDocument.h : remove the PrintLevel informations
584 * Example/PrintFile.cxx : use the new gdcm::File::Print
586 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
587 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
588 problems when compiling with the python wrapping
590 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
591 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
592 writting in ImplicitVR
594 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
595 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
596 JPEG decompression, especially when dicom frames are split into several
597 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
598 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
600 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
601 * src/gdcmHeader.cxx : change the initialisation of default header.
602 Now, this header is readable by gdm, e-film, DicomWorks
604 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
605 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
606 Rename Decompressed to Raw
607 * Use the API changes in gdcm::File.
608 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
611 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
612 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
613 each added entry in the header. Replace the 'Planes' field by the 'Number
616 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
617 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
618 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
620 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
621 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
622 At this time, this image isn't readable by e-film... waiting JPR help to
625 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
626 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
627 DocEntry. Now use methods of the Document !
629 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
630 * Test/ShowDicomSeq.cxx : bug fix
632 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
633 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
634 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
635 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
636 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
638 * Test/TestCopyRescaleDicom.cxx : remove unused variable
639 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
640 containing found sequences
642 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
643 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
645 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
646 Some fields in BinEntry must be copied to not seg fault when making the :
647 gdcm::File *copy = new gdcm::File( copyH );
648 and tests are now made on good variables
650 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
651 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
652 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
654 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
655 * Add vtkGdcmWriter example and test
657 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
658 * Test/TestUtil.cxx : reformat the source code
659 * vtk/vtkGdcmReader.cxx : remove and change prints
660 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
662 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
663 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
665 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
666 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
667 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
669 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
670 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
671 by an eof to prevent all bad read of the file... and in this case, the
674 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * Example/Volume2Dicom.cxx : comment unused variables
676 * Test/PrintDicomDir.cxx : comment unused variables
677 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
678 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
679 method that is redondant with AddEntry.
680 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
683 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
684 * Bug fix due my last commit (compilation under Windows).
685 * Example/Volume2Dicom : bug fix in the file and reformatting source code
686 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
688 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
690 - Remove printf / sprintf
691 - include iostream AFTER gdcm so we don't get warnings
692 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
694 - Also remove tons of include from header files, hopefully this should
695 speeup the compilation time, since it was becoming a dog slow.
696 - Remove gdcm.h as it include way too many files and slow down compilation
697 (plus it is not up to date)
698 - remove 'using namespace std' this is BAD !
700 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * Remove memory leaks on the DicomDir
702 * Remove some useless data in DicomDirObject
703 * Add usefull methods in SQItem, to be complient withe the ElementSet
705 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
706 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
708 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
709 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write data (and in the
710 future, with convertion)
711 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
712 and ImageDataSize values. Remove the method to get the PixelReadConverter
713 from the output of the class
715 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
716 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
718 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
719 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
720 and vtkErrorMacro use.
721 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
723 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
724 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
726 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
727 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
728 The string leaves only in the fonction. So when we make a .c_str(), we
729 get the pointeur on the first element, element that will be destroyed
730 immediately after thee instruction.
731 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
732 file has been opened : the test must be made on the content of the
733 pointer and not directly on the pointer !
736 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
737 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
738 the python part recompiles
740 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
741 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
742 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
743 X session is killed (for my computer... it seems to not be identic on
746 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
747 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
748 avoid problems (otherwise, the difference test between the visible image
749 and the reference is incorrect. If the reference is greater than the
750 screen resolution, it's produce errors).
751 Can be used for only one image. Can be used with a visible flag.
752 * vtk/vtkGdcmReader.cxx : remove commented codes.
753 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
754 under windows at compilation
755 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
757 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
759 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
760 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
761 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
762 tests on the image size X, Y, Z
764 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
765 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
766 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
767 between the class name and the file name
769 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
770 * src/ : fix compilation warnings for the Write method (2 different
771 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
772 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
773 variable... create a static method in gdcm::Document to access to
774 this variable content.
776 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
777 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
778 file, to be accessed by other files (like gdcmFile). Remove commented
779 code. Move the change of the header to the gdcmFile, using the
781 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
782 To be sure of that (and simplify calls), the Write of the header now
783 gets a file name and not a file pointer (std::ifstream).
784 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
785 DocEntryArchive. Remove all open of the written file
787 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
788 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
790 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
791 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
792 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
794 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
795 some corresponding methods. Write correctly the file and check before
797 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
798 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
799 is now on RGB data (as before my last commit
800 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
802 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
803 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
804 Add a print information of the type of the entry
805 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
806 It was in the gdcmFile, and all write have been regrouped
807 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
808 Write correctly all dicom files (in decompressed mode only at this time)
809 * Test/ : test on files are now made using Raw data and not color data if
811 * Example/PrintFile.cxx : add more printings
813 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
814 * Amelioration of code, remove some code copy. For the loading of
815 BinEntry (in gdcmDocument), add the test to verify if the file is already
818 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
819 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
820 remove a DocEntry in the header (push an empty DocEntry)
821 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
822 lines. Bug fix in the initialization of the PixelConvert and the
824 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
825 use in TestCopyDicom (now this test can run under windows... but fails)
826 * Test/TestCopyDicom.cxx : amelioration of the test :
827 - test the pixels written
828 - add test points to quickly find where is the error
829 - can set a file name input and output in arguments
830 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
831 amelioration of the test output
833 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
834 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
835 all replaced DocEntry's
836 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting data.
837 Now, each needed DocEntry to modify is duplicated, modified and inserted
838 to the header using DocEntryArchive. Thus, after save, we can restore the
839 header initial state.
841 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
842 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
844 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
845 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
846 correct to copy it. The DictEntry is specified at the DocEntry creation,
847 then, it musn't change in the time.
848 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
849 header correctly. At this time, the change is only made for the first
850 level of the Document. In the future, it might consider sequences.
851 The change is made by replacing a DocEntry by an other that is created
852 outside the class. The old value is kept. When we restore the header
853 status, the added DocEntry is deleted and replaced by the old value.
854 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
855 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
856 set the write type to explicit VR, implicit VR or ACR. Add methods to set
857 the write mode to native, decompressed or RGB (but not used at this time)
859 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
860 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
861 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
863 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
864 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
865 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
867 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
868 set because already copied when copying the BinEntry's of the header
869 * Test/TestAllReadCompareDicom.cxx : remove warnings
871 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
873 Two problems appear when doing it :
874 - with the gdcmFile : when the GetImageData method is called, the pixels
875 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
876 data (pixels). And each structure destruct the data when it's
877 destructed. So we have two destructions for the same data. To solve it,
878 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
879 data or not. If it doesn't own data, then they will not destroyed by
881 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
882 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
883 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
884 create a double destruction of the same DocEntry's. So, to solve it,
885 the TagHT is simply cleared and the DicomDir* elements are destroyed.
886 * TODO : add an entry concerning memory leaks in the DicomDir
888 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
889 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
890 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
893 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
895 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
896 after it have been deleted
898 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
899 * FIX: src/* fix the doxygen warnings.
900 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
901 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
902 was erroneously defined with a size of 15 instead of 16. [many thanks
903 to Jean Michel Rouet for pointing out this bug].
905 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
906 1. Finish merging JMR patch for writting DICOM from scratch
907 2. Fix -hopefully- bug with MONOCHROME and space vs null character
908 3. Use const ref when possible
909 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
910 5. A few more comments
911 6. CreateUniqueUID can now be called without parameter"
913 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * ENH: Slightly bigger patch:
915 1. Getting toward full integration of JMR patch for writting dicom from scratch
916 2. Update Test to test part of this patch: CreateUniqueUID
917 3. File was not close properly in gdcmDict
918 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
919 5. Use of const ref instead of copy (speed issue)
920 6. Remove temporary (duplicate) string in TranslateToKey
921 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
922 8. Do not repeat virtual in subclasses
923 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
925 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
926 * Apply first patch toward better string comparison when dealing with broken
927 DICOM files. Essentially the string could be padded with a space instead
928 of a null character as defined by standard
930 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
931 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
932 because never used... and in the same time, that's remove some memory leaks
934 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
935 * src/gdcmFile.cxx : now delete the PixelConvert instance.
936 * In examples and tests : change the type of image data variables from void*
937 to uint8_t*. Remmove all delete on image data variables
939 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
940 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
941 Verify the file pointer value before open the file, and if it's not null,
942 a verbose message is generated.
943 Close correctly the file when the file isn't considered dicom-like. The
944 correctly close is a call to CloseFile.
945 When closing the file pointer, test if its not null to close the file.
946 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
947 file. For an uncompressed image, the copied data correspond in the least
948 case to the image size (calculated) or the image size specified in the
949 header. A verbose is generated if these two size mismatch
951 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
952 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
953 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
954 break under windows (with msvc6 compilation).
956 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
957 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
958 compiling with MSVC6)
960 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
961 * Bugs fix for the Windows build with VC6
962 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
963 needed (only for projects required VTK). If the VTK is included in all
964 projects, there is conflicts with the jpeg lib of vtk when compiling the
965 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
966 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
967 when compiling the gdcm_wrap.cxx file (created by the compilation of the
969 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
970 (like it's already made for the cout use). Otherwise, conflict with the
973 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
974 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
976 - comments on the DicomDir::Method related usage added.
977 - now that we use the namespace gdcm, a lot of internal classes do
978 NOT need to be wrapped anymore.
979 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
980 DicomDir::Method) new example added.
982 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
983 * Improve string manipulation. I now inforce the notion of 'DicomString'
984 A DicomString can contain as many \0 as they want
985 and it is *always* of even length.
986 We only support odd length for very rare case.
987 And in the near future this should be removed.
989 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
990 * /binary_write/ gdcm source. Now even on big endian we are writting
991 little endian. This should -heopfully- fix some tests
993 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
994 * Now the dictionary is compiled into gdcm lib. This is a default
995 behavior, thus any dic file specified is picked before failback to
996 the one comiled into lib
998 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
999 * Change internals for gdcmDict. Don't use any 'new' any more.
1000 This should definitely solve any leak problem, and we should be
1001 as fast as before, as long as don't modify too much the dictionary.
1003 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1004 * STYLE: ivars should start with a capital letter.
1005 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
1006 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
1008 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1009 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
1010 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
1011 new 2004 dictionaries added (thanks to JPR).
1012 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
1013 * CLEANUP_ROUND (15) for gdcmPixelConvert
1014 - RLEFrame::NumberFragments is now of type unsigned int
1015 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
1016 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
1019 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1020 * Initial work in gathering all transfer syntax accessors. clearly
1021 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
1022 ivars, but only one transfersyntax (class) ivar with equivalent method on
1025 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1026 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
1027 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
1028 discussed (plus I didn't like having a 2000 lines patch not commited)
1030 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1031 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
1032 * CLEANUP_ROUND (14) for gdcmPixelConvert
1033 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
1034 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
1035 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
1036 CloseFile() anymore.
1037 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
1038 anymore and hence avoids storing a copy of PixelConvert::Decompressed
1039 into File::Pixel_Data.
1041 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
1043 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
1044 * CLEANUP_ROUND (13) for gdcmPixelConvert
1045 Substituted File::ParsePixelData() with PixelConvert::Print() new
1047 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
1048 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
1049 method to those classes.
1050 - src/gdcmFile.[cxx|h]:
1051 -- Added a ::Print() method.
1052 -- PixelConverter is now a reference instead of a member.
1053 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
1054 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
1056 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1057 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
1058 collaboration diagram and inheritance diagram should be generated with
1060 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
1061 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
1062 pointlessly wrapped (see
1063 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
1064 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
1065 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
1066 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
1067 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
1068 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1069 -- File::Initialise: PixelConverter setup moved away to
1070 PixelConverter::GrabInformationsFromHeader()
1071 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
1072 interpretation moved away to PixelConverter::BuildRGBImage()
1074 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1075 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
1076 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
1078 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1079 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
1080 displayed on Win32 when a brutal abort() occurs (because of uncatched
1081 exception). See TODO new entry of this commit for more on this.
1082 * TODO added new entry.
1083 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
1084 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1085 - HandleColor is no longer called from gdcmFile.cxx
1086 - gdcmPixelConvert.cxx clean up on method arguments and internal
1087 variable names for semantical coherence.
1089 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * Finished lossless transition, not only do we now read all lossless jpeg
1091 images, without the need of the Cornwell lib, but we do read them properly now
1092 * To reduce code (well to avoid code duplication), I defined a common place
1093 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
1094 redefine symbols. This is not perfect but this the best solution I found for a
1095 compilation time jpeg option.
1097 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1098 * Update jpeg ijg lib to support lossless jpeg implementation
1099 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
1101 * Also added a special copyright for dcmtk since we use their bugfixes.
1104 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
1106 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
1107 matters, as stated in warning note at beginning of %include section).
1108 * src/gdcmDicomDir*.[cxx|h]: coding style
1109 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
1110 * src/gdcmJpeg8.cxx: doxygen fix.
1111 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
1112 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
1113 from File:: to PixelConvert::.
1115 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
1117 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
1118 - more code moved away from File:: to PixelConvert::
1119 - fat setup of PixelConverter set in place in File::Initialise.
1121 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1122 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
1123 namespace at the file system level. So now you should convert your examples
1125 gdcmHeader -> gdcm::Header
1126 It would be nice if people keep in mind to no open the namespace, since it
1127 allows compilation on broken plateform which were defining common symbol in
1128 the standart namespace (like LP, Unknown ...)
1130 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
1132 The JPEG fragments are now parsed at the same stage than the RLE
1133 information. All code related to JPEG is now in gdcmPixelConvert:
1134 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
1135 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
1136 export a gdcmFile:: method. Those are simply global functions
1137 (for the time being this is better than having them attach to
1138 either gdcmFile:: or gdcmPixelConvert::).
1139 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
1140 and stores the result in a gdcmJPEGFragmentsInfo.
1141 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
1142 code (among other stuff) moved away from gdcmFile:; to
1145 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1146 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
1147 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
1148 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
1149 clean up of RLE related code.
1150 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
1151 - src/gdcmRLE.cxx removed
1152 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
1153 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
1154 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
1155 * CLEANUP_ROUND (9) for gdcmPixelConvert
1156 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
1157 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
1158 away from gdcmFile:: to gdcmPixelConvert::.
1160 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
1162 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
1163 This is because Parse7Fe0 used to parse the pixels to compute the
1164 length. This task was passed over to FindDocEntryLengthOB() a long
1165 time ago, EXCEPT I had forgotten the OW case...
1166 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
1167 we just recylce the code for parsing RLE fragments and computing
1169 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
1170 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
1171 with the retired Parse7Fe0().
1172 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
1173 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
1175 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1176 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
1177 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
1178 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
1179 - src/CMakeLists.txt: alphabetic order reodering + new entries.
1180 * CLEANUP_ROUND (4) for gdcmPixelConvert
1181 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
1182 to return an unused length.
1184 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
1186 this should be cleanner from the plane view. The iostream are erally a pain
1187 to use to do simple stuff.
1189 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1190 * Redo the compilation of the ijg jpeg library. Now only one source is
1191 necesseray. No need to rename file by hand what so ever. CMake handle the
1192 copying of the file within different directory, configure header file to
1193 modify some symbol. The only addition made to ijg wasd a mangle table so
1194 that symbol are different whether we are within 8bits or 12bits.
1196 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1197 * Added documentation of vtkgdcmReader on Website:
1198 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
1199 with it's binary name).
1200 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
1201 the Website to be more complete.
1202 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
1203 doxygenated documentation.
1204 - Doc/DoxyVtkGdcmReaderExamples.txt added
1205 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
1206 DoxyVtkGdmReaderExamples.html )
1207 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
1208 * CLEANUP_ROUND (3) for gdcmPixelConvert
1209 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1211 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1212 * CLEANUP_ROUND (2) for gdcmPixelConvert
1213 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
1215 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1216 * CLEANUP_ROUND for gdcmPixelConvert:
1217 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
1218 - src/gdcmPixelStuff[h|cxx] removed
1219 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
1220 - src/CMakeLists.txt changed accordingly
1221 * GDCMHOME clean up:
1222 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
1223 gdcmVersion.py moved to newly created ATTIC related
1224 gdcmPython/SetupOldies/ directory.
1225 * Autotools clean up:
1226 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
1227 - autogen.sh configure.in acinclude.m4 python.m4 removed
1229 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1230 * src/*.cxx *.h Reference to License.htm fixed to License.html.
1231 * Doc/CMakeLists.txt, doxygen.config.in: fix.
1232 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
1234 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1235 * TODO updated with Mathieu suggestions. I proposed a template for
1236 describing TODO entries and used it for new entries.
1237 * Added Doc/Website/CodingStyle.html, Developpers.html,
1238 DeveloppersPython.html, GdcmDataCvs.html and
1239 DownloadVersion0_1.html, DownloadVersion0_3.html.
1240 * Some Doc/*.txt Doxygen files (which do not really concern the
1241 documentation itself, but the website) moved to html and
1242 placed in directory Doc/Website:
1243 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
1244 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
1245 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
1246 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
1247 * CMakeLists.txt changed accordingly.
1248 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
1249 DeveloppersPython.html
1250 * INSTALL nows refers to Doc/Website/Installation.html
1252 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1253 * Added Doc/Website directory, that contains a first raw version
1256 2004-09-23 Jean-Pierre Roux
1257 * FIX In order not to be poluted any longer by casting problems,
1258 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
1259 we can now delete[] it safely
1260 * VoidArea is now called BinArea (less confusing name),
1261 and all the methods called ...VoidArea... are now ... BinArea...
1262 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
1264 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
1266 clear) TagHT, which is an inherited member of gdcmElementSet. It is
1267 up to the destructor of gdcmElementSet to clean up TagHt and it's
1270 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1271 * Test/CMakeLists.txt: update to follow gdcmData renamings.
1272 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
1274 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * ENH: added some utility method that builds a flat dictionary
1276 holding all the Dicom entries contained in the recursive structure
1277 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
1278 an example of usage.
1279 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
1280 BuildFlatHashTable() that build a flat dictionary.
1281 - src/gdcmElementSet.h: added a new private GetTag() accessor.
1282 gdcmDocument is now a friend of gdcmElementSet.
1283 - src/gdcmElementSet.cxx: clean up.
1284 - Example/FlatHashTablePrint.cxx added.
1285 - Example/CmakeLists.txt changed accordingly
1287 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1288 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
1289 moved away from gdcmDocEntrySet (since this class is an abstract class
1290 acting like an interface). SQDepthLevel and BaseTagKey are now
1292 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
1293 and associated accessors. Doxygenation of the class.
1294 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
1296 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
1297 Use SQDepthLevel accessor instead. ::Print() adapted.
1298 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
1299 - src/gdcmDocument.cxx changed accordingly.
1301 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1302 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
1303 - The following is the doxygen comment of the typedef declaration
1304 of gdcmTagKey in src/gdcmCommon.h:
1305 gdcmTagKey is made to old an "universal" (as in URL, Universal
1306 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
1307 A dicom tag always has a group and an element, but a set of tags
1308 embeded in various (optionally nested) sequences and sharing
1309 the same group and element all share the same (group, element)
1310 "identifier". Hence the (group, element) cannot be used as an
1311 identifier (in gdcm we shall refer to a "TagKey") of a tag.
1312 In order to construct a proper tag identifier (i.e. a key) we
1313 consider the following definition of a TagKey:
1314 - let Group, Element be the string representation of the
1315 group and element dicom tag members,
1316 - let ItemNumber be the string representation of the integer
1317 index of the considered item number of a sequence,
1318 Let the key of a tag embeded in a sequence, noted SeqTag, be
1320 /ItemNumber#Group|Element
1321 where "/", "#" and "|" are characters acting as separators.
1322 Then the general form of a gdcmTagKey is given by:
1323 Group|Element<SeqTag>
1324 where <SeqTag> means NO or many instances of SeqTag.
1325 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
1328 but the gdcmTagKey of a tag "embeded" is the first item of
1329 a sequence, itself nested in the third item of a sequence is the
1331 0004|1220/2#0008|0082/0#0008|0090
1332 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
1333 order to hold the new sequence compatible key. Previously, the
1334 GetKey() method would look in the underlying gdcmDictEntry.
1335 - src/gdcmDocEntry.cxx:
1336 -- constructor now copies the underlying DictEntry key, in the local
1338 -- ::Print: displays the member Key, instead of the (group, element).
1339 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
1340 - src/gdcmDocEntrySet.h:xi
1341 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
1342 -- now has a new BaseTagKey member.
1344 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
1345 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
1347 This poses the problem with the semantics of the following lines
1348 LoadEntryVoidArea(0x0028,0x1201); // R LUT
1349 LoadEntryVoidArea(0x0028,0x1202); // G LUT
1350 LoadEntryVoidArea(0x0028,0x1203); // B LUT
1351 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
1352 to the long FIXME note for what the problem is. Nevertheless in
1353 order to get things working the dicom dictionary was altered !
1354 Please fix things urgently...
1355 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
1356 information), see above note on moving the member VoidArea. Nevertheless
1357 the following entries previously correctly set as US are now inproperly
1359 0028 1201 OW IMG Red Palette Color Lookup Table Data
1360 0028 1202 OW IMG Green Palette Color Lookup Table Data
1361 0028 1203 OW IMG Blue Palette Color Lookup Table Data
1362 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
1363 of gdcmDocEntry moved to gdcmSeqEntry.
1364 * src/gdcmSeqEntry.cxx: STYLE.
1366 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Test/TestAllEntryVerify.cxx minor fix and added comments.
1369 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * gdcmPython/testSuite.py: all the test suite in python is now moved
1371 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
1372 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
1373 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
1375 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1376 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
1377 to avoid inclusion recursion until STL is reached.
1378 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
1379 mecanism. errno.h is not included in gdcm anymore.
1380 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
1381 (gdcmFormatError now inherits from gdcmFormatUnexpected).
1383 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
1384 gdcmData/TestAllEntryVerifyReference.txt
1385 * Test/TestAllEntryVerify.cxx is now effective (used always return true)
1386 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
1387 exception_on_error parameter.
1388 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
1389 - vtk/vtkGdcmReader.cxx changed accordingly,
1390 - Example/*.cxx and Test/*.cxx changed accordingly.
1392 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
1394 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1395 enable_sequences removed from gdcmHeader constructor and dependencies.
1396 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
1397 * gdcmPython/demo/PrintHeader.py: dummy fix.
1398 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
1399 skip_shadow removed from gdcmHeader constructor and dependencies.
1400 * Example/*.cxx and Test/*.cxx changed accordingly.
1402 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
1404 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
1406 2004-07-21 Jean-Pierre Roux
1407 * FIX Now, Parsing and Printing a DICOMDIR do work!
1408 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
1410 2004-07-20 Jean-Pierre Roux
1411 * FIX Some brain damaged headers have Zero-Lenght fields
1412 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
1414 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1415 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
1416 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
1417 variable (instance of gdcmDebug) by a definition macro, and the instance
1418 is now in static in the gdcmDebug class
1419 * src/gdcmSQItem.h : (FIXME) remove an undefined method
1420 * Test/PrintAllDocument.cxx : bug fix in the result of the test
1422 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1423 * WARNING: ctest now depends more tightly on gdcmData. You should
1424 check out gdcmData properly for things to run smoothly...
1425 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
1426 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
1427 we need the pixels not be loaded in order to use the ValEntry
1428 that displays position and size).
1429 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
1430 This is a C++ based equivalent of gdcmPython/testSuite.py that should
1431 be deprecated. If you have any doubts about the advantages of a
1432 modern scripting language (read Python) versus grass root C++ (i.e.
1433 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
1434 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
1435 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
1436 Anyhow, consider documenting the gdcmData images in
1437 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
1439 * Test/CMakeLists.txt:
1440 - now uses TestAllEntryVerify.cxx
1441 - specific comments on oldACR00001.ima (now renamed in gdcmData
1442 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
1443 gdcmData/TestAllEntryVerifyReference.txt
1446 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * src/*.[h|cxx] : typedef clean up
1448 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
1449 - TagKey renamed to gdcmTagKey (for external usage)
1450 - VRKey renamed to gdcmVRKey (for external usage)
1451 - removal of typedef duplication.
1452 - Removed all unecessary inline keyword from class inline definitions.
1453 - Some method|function(void) declarations replaced with method|function().
1454 * src/jpeg/libijg12/jdhuff12.c:
1455 - printf polluting ctest removed.
1456 - TAB removal for comminting
1458 - TestAllReadCompareDicom.cxx: added a test that compares all the
1459 images in gdcmDataImages.h with corresponding images in
1460 gdcmData/BaselineDicom/. When baseline images are not present
1461 this test creates them.
1462 Note: we need to validate each reference image, but before that
1463 I'd like to rename them with a more explicit name...
1464 - CMakeLists.txt: changed accordingly.
1465 * Example/*.cxx: examples now only include gdcm.h (as opposed to
1466 including each header needed).
1468 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1469 * Test/*.cxx and Example/*.cxx: moved some examples away from the
1470 test suite to the Example directory. Are concerned:
1475 - TestWriteSimple.cxx
1476 * Test/CMakeLists.txt: added some comments on reasons for black listing
1477 image gdcmData/oldACR00001.ima
1479 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1480 * Test/CmakeList.txt: removed the following from black list (to be coherent
1481 with removal from gdcmData):
1482 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
1483 - gdcm-MR-PHILIPS-16.dcm
1485 Added the following because after last cvs update, they cause
1486 ctest -R TestReadWriteReadCompare
1488 - gdcm-MR-SIEMENS-16-1.acr
1490 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
1491 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
1492 new comments in this file) we temporarily (sigh) move to a weaker
1494 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
1495 we don't need to black list the following images anymore:
1496 - 8BitsUncompressedColor.dcm
1498 - US-PAL-8-10x-echo.dcm
1499 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
1500 fixes and the beautified code ;-)
1501 This fixes the bug introduced in version 1.42 (when beautifying)
1502 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1503 Note: ctest was blind to this bug (this means we need to still
1504 improve the test suite). The bug could be detected by using
1505 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1507 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1508 and by displaying the (garbage) produced file temp.XDCM...
1510 2004-06-29 Jean-Pierre Roux
1511 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1512 - replace by uggly but working old code :-(
1513 A lot of things should be OK again.
1514 It's really urgent to have a test suite that *tests*,
1515 to prevent Frog's beautifying sessions to break all the stuff
1516 (twice, withing a fortnigh ...)
1518 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1519 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1520 redundancy) to added Test/TestReadWriteReadCompare.cxx
1521 * Test/CmakeList.txt: because the compare test of
1522 Test/TestReadWriteReadCompare.cxx fails, the following images are
1523 black listed: - 8BitsUncompressedColor.dcm
1525 - US-PAL-8-10x-echo.dcm
1526 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1527 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1528 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1529 and ad-hoc kludge. This kludge is now removed, and on encountering
1530 such an image (OB field brain damaged) we set errno. Then in
1531 ::FindDocLength() we "fix" the length as being ALL what remains
1532 in the file (until EOF). We then proceed, hoping for the best...
1533 This fixes a SegFault in ShowDicom when trying to write such an
1535 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1536 (because TestWriteRead breaks on it, after a non conformal commit?).
1537 ctest now runs properly, except for MakeDicomDir (which was always
1538 broken) and the Python related stuff (still not fixed).
1540 2004-06-24 Jean-Pierre Roux
1541 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1542 FIX : Test/TestReadWrite now iterates on all the file names
1543 (instead of infinite loop)
1544 ENH : Test/TestWriteRead now iterates on all the file names
1546 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1549 2004-06-24 Jean-Pierre Roux
1550 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1551 when SamplesPerPixel =3
1552 - now Write is no longer confused by
1553 'BitsAllocated = 12" and 'BitsStored=12"
1554 - "UN" value representation Elements are now written correctly
1555 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1556 ENH : - now gdcmHeader has its own Write methods
1557 (in order to split the job that has not to be done
1560 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1561 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1562 loop on the same image until memory went out.
1563 Note: this means we still have gobs of memory loss in PrintDocument
1564 * src/gdcmDocument.cxx: fixes problem on parsing on file
1565 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1567 2004-06-24 Jean-Pierre Roux
1568 FIX : Write - All the Sequences and Sequence Item are now written
1569 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1570 is added a the end, when necessary.
1571 - A lot of brain-damaged images, that were read correctly are
1572 now written correctly
1573 - length compatible BinEntry are now loaded correctly
1574 (even for odd groups)
1575 Note : only Explicit Value Representation was checked.
1576 (question : is implicit VR really necessary for gdcm ?)
1578 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * DEVELOPPER: added a proposition of coding style.
1580 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1583 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1584 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1585 Use the gdcmDocEntry::Print() and Write() instead.
1586 * src/gdcmDocument.cxx: bug fix.
1588 2004-06-22 Jean-Pierre Roux
1589 FIX : gdcmDocument.cxx
1590 - Now we do recognize the JpegLossLess format (there was a misstyping in
1591 code 'beautyfication' :-(
1592 - Now we automaticaticaly load the Luts, if any
1594 2004-06-22 Jean-Pierre Roux
1595 In order : to write Sequences, whatever their imbrication level,
1596 : to allow user to create his own Sequences
1597 a lot of modif where necessary (adding, moving, or virtualising methods)
1599 WARNING : save your own sources *before* cvs up !
1602 ADD virtual void Write(FILE *fp, FileType filetype);
1605 ADD virtual void Write(FILE *fp, FileType filetype);
1606 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1609 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1610 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1611 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1612 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1613 ADD std::string GetEntryByName(TagName name);
1614 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1616 std::string vr = "unkn",
1617 std::string fourth = "unkn",
1618 std::string name = "unkn");
1619 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1620 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1621 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1622 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1623 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1624 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1625 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1626 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1629 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1630 ADD virtual std::string GetEntryByName (TagName tagName);
1631 ADD virtual std::string GetEntryVRByName (TagName tagName);
1632 REM virtual bool Write(FILE *, FileType);
1633 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1634 FILE *_fp, FileType type);
1635 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1636 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1637 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1638 REM virtual std::string GetEntryByName (std::string tagName);
1639 REM virtual std::string GetEntryVRByName (std::string tagName);
1640 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1641 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1642 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1644 std::string vr = "unkn",
1645 std::string fourth = "unkn",
1646 std::string name = "unkn");
1647 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1648 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1649 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1650 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1653 ADD virtual void Write(FILE *fp, FileType filetype);
1656 ADD virtual void Write(FILE *fp,FileType filetype);
1659 ADD virtual void Write(FILE *fp, FileType filetype);
1660 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1661 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1662 REM std::string GetEntryByName(TagName name);
1665 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1667 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1668 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1669 The default constructor invoked by the line
1670 gdcmHeader *f1 = new gdcmHeader( header );
1671 was gdcmHeader::gdcmHeader(bool) instead of the expected
1672 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1673 Hence the parsing wasn't executed... See also below.
1674 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1675 as explicit constructor didn't do the trick to fix the above problem.
1676 Could anyone explain why ?
1677 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1678 properly calls gdcmValEntry::Print() (that was weed out from
1679 code related to gdcmBinEntry).
1681 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * In order to fix memory leaks:
1683 - Test/TestWriteSimple.cxx: added cleaning of free store through
1685 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1686 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1687 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1688 (through the call to ::AddDicomDirMeta()) or the destructor
1689 would crash when deleting uninitialized ::metaElems].
1690 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1691 - src/gdcmDocument.cxx:
1692 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1693 from dynamic stores.
1694 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1695 was causing memory leaks.
1696 - src/gdcmSQItem.cxx:
1697 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1698 cleanly handled with polymophism: sorry but my milage is low).
1699 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1700 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1701 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1702 This avoids SegFaulting.
1703 - src/gdcmSQItem.h: coding style.
1705 - Test/TestWriteSimple still severely sucks. The output image content
1706 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1707 damaged when displayed with vtkgdcmViewer.
1708 - on memory leaks: TestWriteSimple leaks really less (see entry
1709 of 2004-06-18 in Changelog file for the call to valgrind).
1710 - on segfaults: ctest now passes all the tests but one (no more
1712 * Erroneous leading white fix:
1713 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1714 white[s] (as opposed to from >> xxx, that removes it [them].
1715 - src/gdcmTS.cxx: ditto.
1716 - gdcmPython/testSuite.py: dirty related kludge removed.
1717 * src/*: remaining references to gdcmParser removed.
1718 * src/*[cxx|h]: added copy[way]left header.
1721 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1722 * In order to fix writing of dicom files:
1723 - Test/TestWriteSimple.cxx: a simpler example of writing.
1724 - Test/CMakeLists.txt changed accordingly.
1725 - src/gdcmDocument.cxx:
1726 -- The destructor now recursilvely removes potential sequences.
1727 -- Bug fix in ::IsJPEG2000()
1728 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1729 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1731 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1732 to only declared) and build on top of
1733 ::GetDocEntryByNumber(guint16, guint16).
1734 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1735 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1736 for usage in destructor and treatement of promotion in
1737 ::ReplaceOrCreateByNumber().
1738 - src/gdcmSQItem.cxx: destructor should better handle his job.
1739 Test/TestWriteSimple now runs (or at least it DOES something).
1740 * We can now start hutting memory links. A good starting point is:
1741 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1742 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1743 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1745 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1746 * Valgrind note: after Mathieu Malaterre teached me how to read
1747 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1749 Using gcc, you can force the STL to use malloc and to free memory as
1750 soon as possible by globally disabling memory caching.
1751 With 3.2.2 and later, you should export the environment variable
1752 GLIBCPP_FORCE_NEW before running your program.
1753 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1754 simply vanish (it is still not clear to me, whether this means that
1755 STL std::string leaks or if valgrind believes it leaks...).
1756 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1757 running bin/gdcmTests makeDicomDir):
1758 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1759 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1761 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1762 SegFaulting (I drowned in DicomDir related code when trying to
1763 understand why the list is empty...).
1764 * src/gdcmDocument.h: first BSD license header try.
1765 * Doc/License.txt added.
1767 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1768 * src/gdcmDocument.[h|cxx]:
1769 - Clean up of the Transfer related predicates. They are now all based
1770 on new method isGivenTransferSyntax, that (should) handle properly
1771 the padding problem.
1772 - general clean up, simplification, and coding style.
1773 - Specific clean up of Parse7FE0() (umproperly named actually).
1774 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1776 2004-06-14 Jean-Pierre Roux
1778 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1779 - fix the display of SQItem ordinal number
1780 - add the GetSQItemByOrdinalNumber method
1781 - remove some useless never written private methods
1783 2004-06-14 Jean-Pierre Roux
1785 - adding a constructor taking a gdcmDocEntry as an input param
1786 - ReplaceOrCreateByNumber now returns :
1787 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1788 a gdcmValEntry * if a string value is passed as a param
1790 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1791 according to the param type (no longer sets a gdcmDocEntry)
1792 - GetValEntryByNumber, GetBinEntryByNumber added
1793 - NewValEntryByNumber and NewBinEntryByNumber added
1795 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1797 - GetSQItemNumber and SetSQItemNumber added, to provide
1798 a (relative) Item identier inside a given Sequence
1799 \warning : some pb remaining around this number
1801 - AddEntry now takes the Item Number as a param
1803 - adding a constructor taking a gdcmDocEntry as an input param
1805 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1806 * Memory leak hunt with the following command:
1807 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1808 --show-reachable=yes gdcmTests PrintDocument
1809 It looks like many (all?) leaks are due to the STL (or a bad usage
1810 of the STL. The lines producing the leaks now have a comment with
1811 a "MEMORY LEAK" tag: you can retrieve them with
1812 grep "MEMORY LEAK" src/*
1813 Here are two typical examples which I can't help fixing:
1818 char * test = "babo";
1819 name = test; //// <--- valgrind detects 960 bytes lost in
1820 //// call to std::string::operator=(char const*)
1821 name.clear(); //// Doesn't help !
1829 std::cout << "Type a bunch of characters followed by RETURN: ";
1830 getline(std::cin, line); //// <--- valgrind dectects a loss
1831 //// of 1320 bytes in call to
1832 /// std::basic_istream<>& std::getline<>
1838 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1839 * src/gdcmHeader.[cxx|h]:
1840 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1841 and related, moved away to gdcmDocument.
1842 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1843 the corresponding protected accessors of inherited class
1844 gdcmDocument, removed ! As a consequence gdcmFile had to be
1845 declared friend of class gdcmDocument (see below).
1846 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1847 - Clean up of undefined or unused methods.
1848 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1849 account the changes to gdcmHeader.h).
1850 * src/gdcmDocument.h:
1851 - gdcmFile is now a friend class (in order to take into account the
1852 changes to gdcmHeader.h).
1853 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1854 (see changes to gdcmHeader.h).
1855 - Accessors (reading on the form GetEntry*) are now public.
1856 - Clean up of undefined or unused methods.
1857 * src/gdcmDocument.cxx:
1858 - adaptation to changes to gdcmDocument.h
1859 - ::OpenFile now writes a verbose message when file cannot be opened.
1860 - some std::string properly set to VRKey
1861 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1862 references to gdcmDocument.
1863 * Test/TestFindTags.cxx: changed accordingly to above changes.
1864 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1865 cvs repository gdcmData.
1867 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1868 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1869 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1870 conflicts with gdcmValEntry::voidArea.
1871 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1872 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1873 Value representation between StringRepresentable and BinaryRepresentable.
1874 * src/gdcmDocument.cxx:
1875 - method ParseDES: proper indentation restored and usage of
1876 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1877 - method LoadDocEntry: the fingerprint left in the SetValue() of
1878 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1879 removed. Reverting to previous code segment with the proper
1880 dynamic_cast< gdcmValEntry* >.
1881 Note: this was (partially) breaking the python test suite
1882 (gdcmPython/testSuite.py) that made usage of the above
1883 fingerprint to check presence of "Pixel Data".
1884 * src/gdcmDocEntry.h: coding style.
1885 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1886 now taken into account.
1887 * gdcmPython/gdcm.i: adaptation to the new internal representation
1888 of gdcm (exit gdcmParser, hello gdcmDocument).
1889 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1891 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1892 anymore, but instead prints the loaded Python dictionary.
1893 * .... alas, the python testSuite is still broken.
1895 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1898 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1899 * src/gdcmUtil.h : export methods
1901 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1904 * Initial addition of automatic python testing
1905 * Initial addition of automatic image comparison
1907 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1908 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1909 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1911 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1912 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1913 * Test/ShowDicom.cxx : bug fix for msvc compilation
1914 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1916 2004-05-04 Jean-Pierre Roux
1917 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1918 new concepts (and new classes) :
1919 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1920 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1921 - Sequence Doc Entries (gdcmSeqEntries)
1922 a Sequence is composed of Items.
1923 Each item is a set of Doc Entries (this is recursive)
1924 The non uniqueness of the 'Dicom tag' is due to this recursivity
1925 (never taken into account)
1926 Our unability to add a new 'entry' in the header
1927 at the proper location (neither in the H-Table (map or multimap),
1928 nor in the Chained List is also due to this recursivity.
1929 Don't try, right now, to use/modify/compile these new sources :
1930 nothing is finished.
1931 We just commit all the stuff, 'as is', in order not to loose it.
1933 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1934 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1936 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1937 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1938 file prefix (SetFilePrefix)
1940 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * Add a new test: ShowDicom, for now this is just the c++ version of
1942 checkRead.sh, later it will be able to compare the image read against a
1944 * Replace the DEBUG on the stack with a global entry in cmake interface:
1945 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1947 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1948 * Add an example subdir, with a real example on how to read + write a
1951 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1952 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1953 * Doc/CMakeLists.txt: the main page is now properly differentiated
1954 between the developper and user version.
1955 * Doc/doxygen.config.in: dropped search related obsolete flags
1956 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1958 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * DEVELOPPER: added some helpfull comments for compile/test/install
1962 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1963 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1964 src directory, now generated in the build dir.
1965 2. Tests as mentionned smarter
1967 4. Add a new method in gdcmDict that return the PubDict by name
1968 this is interesting for 3rd party lib like ITK,
1969 where we could set the institution name / patient name...
1971 * ENH: 1. Now the test suite is working for real
1972 2. All binaries are now output in the gdcm-bin directory
1973 (this was not true before)
1975 2004-04-28 Jean-Pierre Roux
1976 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1977 SeQuence indented printing of Dicom Header.
1978 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1979 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1980 Computation of SQDepthLevel is now part of gdcmHeader constructor
1981 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1982 tree-like structure of a Dicom Header.
1983 * FIX Test code cleaning
1985 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1986 * ENH: Adding automatic testing
1987 1. Need a DartConfig.cmake to submit to public
1988 2. Add a test driver gdcmTest.cxx
1989 3. gdcmTestMain, an helper for the main test driver gdcmTest
1990 4. Files in Test don't have a main anymore, this becomes interesting
1991 when we add more and more tests, thus dsw don't have to load
1993 * ENH: Adding a GDCM_DATA_ROOT for testing
1994 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1995 one file instead of seven + some small cleanup
1997 2004-04-22 Jean-Pierre Roux
1998 * ENH Minor changes to the Print() methods.
1999 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
2000 Header printing. Example given with :
2001 > PrintHeader fileName 2 new
2002 (SQ based tree-like structure still to be done for the Header ...)
2004 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
2006 1. I have added some unsigned where needed
2007 2. Some function parameter not used -> (void)
2008 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
2009 4. g++ don't like character '\' in comment
2010 5. #define jpeg_create_decompress jCreaDecompress
2011 this really need to be fixed
2012 6. virtualize destructor of gdcmObject ... leakage
2013 7. sscanf(g->first.c_str(),"%x",&gr_bid);
2014 this also really need to be fixed
2015 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
2016 remove compression file
2017 (as we only do decompression, right ?)
2018 * ENH: Change malloc/calloc/free with c++ equivalent
2020 2004-04-21 Jean-Pierre Roux
2021 * FIX gdcmHeaderHelper::GetXSpacing
2022 when a single value is found (bug ?), xpacing is now
2023 defaulted to yspacing
2025 2004-04-19 Jean-Pierre Roux
2026 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
2027 * ENH add parameters :
2028 bool exception_on_error = false,
2029 bool enable_sequences = false,
2030 bool ignore_shadow = false
2031 to the gdcmFile constructors to be full gdcmParser compliant
2032 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
2033 to allow reading of PAPYRUS 3.0 files
2035 2004-04-06 Jean-Pierre Roux
2036 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
2038 2004-04-02 Jean-Pierre Roux
2039 * ADD : Test/checksequence.sh, for a general recap on SQ pb
2040 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
2041 for Philips spurious Tag fffe|0000 while rewritting Dicom files
2043 2004-03-30 Jean-Pierre Roux
2044 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
2045 for ACR file, written out as DICOM files (hope so...)
2047 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
2049 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
2050 moved to base class gdcmParser and only the specialisation is kept
2052 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
2053 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
2054 already does the job.
2055 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
2056 (to be consistent with gdcmParser::WriteEntries).
2058 2004-03-30 Benoit Regrain
2059 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
2060 upate of the object's instance. It's passed to 2 in the unfavorable
2061 case : one in the ExecuteInformation, one in the ExecuteData
2063 2004-03-29 Jean-Pierre Roux
2064 * ENH : Check on file type to be written moved
2065 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
2066 * FIX : gdcmObject::ResetBoundaries now stops properly
2067 when end-of-list is reached
2068 : gdcmVersion modified (as Benoit Regrain asked)
2070 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2071 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
2072 * src/gdcmUtil.cxx: added forgotten iostream include.
2073 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
2074 equivalent to ExplicitVR in existing code).
2076 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2077 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
2078 now contains all the gdcmGlobal related code.
2079 * minor coding style and doxygenation changes.
2081 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
2083 now contains all the Debug related code.
2084 * minor clean-up of includes in src/*.cxx
2085 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
2086 CreateCleanString) removed.
2087 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
2088 * Doc/DoxyMainPageUser.txt added.
2089 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
2090 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
2091 src/gdcmDirList.cxx)
2093 2004-03-24 Jean-Pierre Roux
2094 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
2096 2004-03-23 Jean-Pierre Roux
2097 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
2098 big endian made volumes
2099 * ENH Now gdcmParser constructor and destructor are protected to forbid
2100 end user to instanciate class gdcmParser
2101 (only gdcmHeader and gdcmDicomDir are meaningfull)
2103 2004-03-22 Benoit Regrain
2104 * FIX : src/gdcmDicomDir.cxx : make windows compilable
2105 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
2106 gdcmSerie to gdcmDicomDirSerie
2108 2004-03-19 Jean-Pierre Roux
2109 * ENH Now the tree-like structure describing a DICOMDIR comming from
2110 an already existing DICOMDIR file is consistent with
2111 the home-made tree-like structure build ex-nihilo
2112 or build from the files held (recursively) in a Directory
2113 functions gdcmDicomDir::CheckBoundaries()
2114 gdcmObject::SetBoundaries() added
2116 2004-03-17 Jean-Pierre Roux
2117 * REM (Eric Boix bug) : removal of meaningless
2118 gdcmDicomDirImage::NewImage function.
2119 * FIX now file names and directory name are written properly in the
2121 * FIX now gdcmDicomDir constructor may be call without any trick
2124 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
2126 of gdcmDicomDirImage::NewImage as empty function.
2128 2004-02-28 Jean-Pierre Roux
2129 * ENH add gdcmDicomDir:NewPatient
2130 add gdcmDicomDirPatient:NewStudy
2131 add gdcmDicomDirStudy:NewSerie
2132 add gdcmDicomDirSerie:NewImage
2133 to allow making gdcDicomDir object.
2134 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
2135 (as opposite to the gdcmHeader chained list)
2137 2004-02-11 Benoit Regrain
2138 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
2139 when using from python
2141 2004-02-10 Benoit Regrain
2142 * FIX : bug fix in the gdcmDirList for the recursivity in directories
2143 * FIX : in gdcmDicomDir when the directory is empty
2144 * ENH : add callback and methods to get the progression of dicomDir
2147 2004-02-06 Jean-Pierre Roux
2148 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
2149 - GDCM_META added to gdcmDicomDirType
2150 - class gdcmMeta created
2151 * ENH : - A brief summary is now displayed at the beginning of
2152 'testDicomDir' to help disaster magnitude estimation
2153 * REM : Now useless Test/explDICOMDIR.cxx
2155 2004-02-05 Benoit Regrain
2156 * ENH : add methods in gdcmObject to get the hash table or the list of
2158 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
2159 * FIX : wrapping python for TagHeaderEntryHT
2161 2004-02-04 Benoit Regrain
2162 * FIX : even length for some strings when writting the dicom dir
2163 * FIX : sort the images in the dicom dir
2164 * FIX : Bug fix for python use of dicom dir
2165 * ADD : a python demo
2167 2004-02-04 Jean-Pierre Roux
2168 * FIX : Final solution (?) for icone embedded images
2169 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
2170 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
2171 add groups 6002, 6004, 6006, to allow 'clean' parsing of
2172 gdcmData/gdcm-MR-SIEMENS-16.acr1
2173 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
2174 to make full checking easier
2176 2004-02-04 Benoit Regrain
2177 * FIX : WriteEntries : coding style & logic in parameters
2178 * FIX : Set the elements to create the DicomDir in a dictionary file
2180 2004-02-03 Benoit Regrain
2181 * gdcmDirList : to parse a hard drive directory in recursive (or not)
2182 * gdcmDicomDir : add the load of directory
2183 * Bug fix and print add-on
2185 2004-02-03 Jean-Pierre Roux
2186 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
2187 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
2188 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
2189 * FIX gdcmParser.cxx : 'group length' elements are now considered
2190 as integers, even for shadow groups, when file is Implicit VR
2192 2004-02-02 Jean-Pierre Roux
2193 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
2195 of the last synonym :-(
2196 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
2198 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
2199 * FIX taking into account the possible 7fe0,0010 multiplicity
2200 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
2201 to allow removal of references to 7fe0,0010, to deal with
2202 ACR-NEMA images, when 0028,0200 is meaningfull
2204 2004-01-31 Jean-Pierre Roux
2205 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
2206 no longer writes 'Un' on disk
2207 * FIX SQ elements with actual length are now dealt with corectly
2208 * FIX gdcmFile::WriteBase make the difference, for color images, between
2209 the length (for Palette expanded images)
2210 and Raw Length (non expanded image + Palette)
2211 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
2212 (that broke Write). Replaced by UL.
2213 Aware user will reload the field if he
2214 thinks it's necesssary
2216 2004-01-30 Jean-Pierre Roux
2217 * gdcmParser::CheckSwap() now defaults the filetype to ACR
2218 when 'dirty Acr' is found, to be compliant with the new
2219 IsReadable() methods.
2221 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
2222 (no DOUBLE images in kosher DICOM,
2223 but so usefull for people that miss them ;-)
2225 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
2226 DICOMDIR related utilities (not checked as Windoze compliant)
2228 2004-01-28 Jean-Pierre Roux
2229 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
2231 2004-01-27 Jean-Pierre Roux
2232 * gdcmParser constructor has a new boolean param,'ignore_shadow',
2233 to allow skipping the shadow elements, to save memory space.
2234 The TRUE value for this param has to be used
2235 with a FALSE value for the 'enable_sequence' param.
2236 ('public elements' may be embedded in 'shadow Sequences')
2237 * gdcmHeader methods now deal with 'embedded icones images' in the header
2238 (even when an 'icone image sequence' is announced by the
2239 element (0x0088,0x0200), but there is NO icone at all ...
2241 * gdcmHeader sometimes Image Location value doesn't follow
2242 the supposed processor endianity (see gdcmData/cr172241.dcm).
2245 * gdcmHeader add the method
2246 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
2247 to get *all* the Header Entries with the same tag.
2248 GetHeaderEntrySameName is probabely *useless*
2249 (no meaning : Name is *not* an identifier within the Dictionary)
2251 2004-01-26 Benoit Regrain
2252 * Bug fix in the print of hexadecimal representations. Remove long fields
2253 in the print and add a third level of print to print them
2255 2004-01-23 Benoit Regrain
2256 * Bug fix on field having a VR = 'UI'. Assume that is a string field
2257 * Bug fix on test suite after remove the strip made on not string fields
2258 * Split the IsReadable method between gdcmParser which test that the file
2259 is dicom and gdcmHeader which test that it's an image file
2261 2004-01-22 Benoit Regrain
2262 * DicomDir : clean code, add methods, set variables in protected or private
2263 * gdcmUtil : bug fix for the clean string method
2265 2004-01-19 Benoit Regrain
2266 * Add the use of shadow dictionaries
2267 * bug fix and coding style
2269 2004-01-19 Benoit Regrain
2270 * src/gdcmFile.cxx : bug fix concerning the close of file
2271 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
2272 * Add the update of header entries using the shadow library
2274 2004-01-19 Benoit Regrain
2275 * removal of file gdcmHeader2.cxx
2276 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
2277 inheriting from gdcmParser. This split is to prepare the integration
2278 of dicom dir parsing
2279 * bug fix under python
2281 2004-01-16 Jean-Pierre Roux
2282 * REM removal of class gdcmHeaderEntrySet
2283 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
2284 * ADD add file gdcmHeader2.cxx
2285 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
2287 2004-01-15 Benoit Regrain
2288 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
2289 entries created while parsing the header. Thus, they will be destroyed
2290 when the gdcmDictSet will be destroyed
2291 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
2294 2004-01-15 Benoit Regrain
2295 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
2296 made a fatal error because of the memory release at the end of program.
2297 The problem was in vtkGdcmReader::ExecuteData where we were allocate
2298 some memory and vtk seems to have some problems with that.
2299 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
2301 2004-01-14 Benoit Regrain
2302 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
2303 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
2304 * src/*.[h|cxx] : make changes due to class name changes
2305 * gdcmPython/demo/*.py : bug fix due to method names
2307 2004-01-13 Benoit Regrain
2308 * src/*.[h|cxx] : coding style
2309 * vtk/*.[h|cxx] : coding style
2311 2004-01-13 Benoit Regrain
2312 * gdcmPython/testSuite.py : test the readable flag of file for tests
2313 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
2314 It's lied to the stl compilation by MSVC (windows, always windows...)
2315 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
2317 2004-01-12 Benoit Regrain
2318 * src/*.h : add comments
2319 * src/gdcmDictSet.h : set the method BuildDictPath in public
2320 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionary file other than to be
2321 directly setted in the source code
2322 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionary files loaded by
2325 2004-01-09 Benoit Regrain
2326 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
2327 * setup.py : use a reference to gdcmVERSION
2329 2004-01-07 Benoit Regrain
2330 * Modification to compile with the distutils.
2333 2003-12-10 Benoit Regrain
2334 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
2335 can use a gdcmHeaderHelper to load data
2336 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
2337 made in the source code
2339 2003-12-10 Benoit Regrain
2340 * Update Windows projects and .cvsignore files
2342 2003-11-12 Jean-Pierre Roux
2343 * ENH gdcmHeader constructor has one more parameter (default value : false)
2344 that allows the user to 'go inside' the SeQuences only
2346 gdcmElValSet:Print takes it into account
2348 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2349 * ENH: Update gdcmPython/CMakeLists
2350 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
2351 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
2353 2003-11-10 Jean-Pierre Roux
2354 * FIX : gdcmHeader::LoadElements is now based
2355 on the ListTag listElem member,
2356 not longer on the TagElValueHT tagHt member
2357 * ENH : PrintPubElVal shows (temporarily) both results,
2358 with the tagHt member and the listElem member.
2359 (it's easier to 'see' the problems when using Printheader)
2361 * FIX : old private member LgrElem is now splitted into
2362 ReadLength : Length actually found on disk (updated only
2363 if bug fixing is necessary), for internal
2365 UsableLength : Updated by FixFoundLength, to fix a bug
2366 or to allow Parser going on.
2367 Will allow to re-write a kosher header when a SeQuence
2368 with a length (not 0000) is found
2369 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
2370 because gdcmElValSet::Add does not update ListElem
2373 2003-11-07 Jean-Pierre Roux
2374 * FIX misstyping in Transfert Syntax name table
2375 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
2376 when they have an actual length (not 0000 nor FFFFF)
2377 (Nobody should care of it, but DICOMDIR explorers)
2379 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2380 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
2382 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2383 * ENH: vtkGdcmReader now supports LUT !
2384 (vtkgdcmViewer for now is not able to use them though)
2386 2003-11-05 Jean-Pierre Roux
2387 * in testSuite.py : new files names for checking the package
2388 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
2389 that returns the pixel area size to the *aware* (vtk) user
2390 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
2392 2003-11-05 Benoit Regrain
2393 * in testSuite.py : Modify the rules for checking the paths
2394 : Explicit error messages
2395 * in __init__.py : Related modif
2397 2003-11-03 Jean-Pierre Roux
2398 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
2399 to be used by aware (vtk) users that want to manage
2400 LUT (and no to turn the PALETTE image into an RGB pixels one)
2401 * GetPixelType now returns 8U for 24 Bits images
2402 (vtkGdcmReader compliant)
2404 2003-10-31 Jean-Pierre Roux
2405 * Removal of *all* gdcmData images and add them again
2406 in order to loose the 'history' of un-anonymised images
2408 2003-10-31 Jean-Pierre Roux
2409 * RMV : removal of useless jBitsInJsample.h
2410 for both 8 and 12 Bits JPEG Lossy Libraries
2412 2003-10-31 Jean-Pierre Roux
2413 * ENH : Add the functions gdcmFile::GetImageDataRaw
2414 gdcmFile::GetImageDataIntoVectorRaw
2415 that act as GetImageData and GetImageDataIntoVector
2416 except the making of an RGB Plane from Gray Plane + LUT
2417 Intended to aware (vtk) users who know how to manage
2420 GetLUTRGBA return a R,G,B,A LUT if any
2421 lgrTotaleRaw gives the 'Raw' length
2422 GetImageDataRaw returns the gray Plane
2423 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
2424 (They stay Grey, just like with other Dicom viewers :-(
2426 2003-10-30 Jean-Pierre Roux
2427 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
2429 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2430 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
2431 being coherents dicom files.
2433 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2434 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
2436 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
2437 * ENH: Two steps is necessary to please VC++ compiler...
2438 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
2439 * ENH: Add include dir to medcon lib
2440 * FIX: only one function is being exported for now !
2441 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
2443 2003-10-29 Jean-Pierre Roux
2444 * adding gdcmHeader::GetLUTRGBA
2445 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
2446 --> Mathieu, the modif u're waiting for is not yet committed
2447 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
2449 2003-10-27 Jean-Pierre Roux
2450 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
2451 00191113.dcm DermaColorLossLess.dcm
2452 MxTwinLossLess.dcm RadBWLossLess.dcm
2453 * ENH: For version prior to vtkImageViewer2 -r 1.19
2454 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
2456 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2457 * Removal of ido stuff in CMakeLists.txt
2459 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2460 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
2461 * FIX: remove a call to ->Modified ... see comments
2462 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
2464 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2465 * FIX: Problem with path for libvtkgdcmPython
2466 * ENH: Try adding a search script for python site-package
2467 * RMV: Remove some file from medcon lib that are not necessary
2468 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
2469 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
2470 * FIX: More pragma disable fro VC++,
2471 I don't think I break something as it is also disable in VTK/ITK.
2472 But it fasten debug compilation time.
2474 2003-10-23 Jean-Pierre Roux
2475 * gdcm now deals with 16 Bits Run Length Encoded images
2476 (they are compressed as 2 planes images,
2477 one for the high Bytes, the other for low Bytes)
2479 2003-10-22 Jean-Pierre Roux
2480 * Now CheckRead takes into account :
2481 - the bugged 'Leonardo' Siemens images
2482 - the XA images, sent thru the burning VPRO station
2483 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
2486 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2487 * FIX: When copying a Makefile.am to CMakeLists.txt
2488 one should remove the '\'
2490 2003-10-22 Jean-Pierre Roux
2491 * in gdcmData adding a bugged 'Leonardo' Siemens image
2492 (wrong lengths in header)
2493 OK with gdcm, KO with the other viewers :-)
2494 * add a GE dlx XA image, thru the VEPRO burning station
2497 2003-10-21 Jean-Pierre Roux
2498 * in gdcmData add the checkvtkgdcmViewer.sh shell script
2499 for a brutal checking of vtkgdcmViewer compliance
2501 2003-10-21 Jean-Pierre Roux
2502 * add the files for 'xmedcon' Jpeg Lossless library
2503 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2505 2003-10-21 Jean-Pierre Roux
2506 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2508 2003-10-21 Jean-Pierre Roux
2509 * garbage Siemens 'Leonardo' images dealt with
2510 (the patch is easy to remove)
2511 * cosmetic changes to avoid warnings
2513 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2514 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2515 no need to press 'r' now.
2517 2003-10-20 Jean-Pierre Roux
2518 * upgrade of checkRead.sh checkWrite.sh according
2519 to new Jpeg Lossless decompressor
2520 * add US.3405.1.dcm, a genuine RGB medical file ...
2521 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2522 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2524 2003-10-15 Jean-Pierre Roux
2525 * general anonymisation in gdcmData
2526 * adding the 'color files' from
2527 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2528 * adding some well knowed bugged-header images
2529 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2530 waiting for their inclusion in Python testsuite
2532 2003-10-15 Jean-Pierre Roux
2533 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2534 no longer seg faults when file is not found
2536 2003-10-14 Jean-Pierre Roux
2537 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2540 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2541 * TODO: *.in file to genereate a UseGDCM later
2543 2003-10-14 Jean-Pierre Roux
2544 * Some supposed-to-be Dicom Images have no preamble.
2545 OpenFile takes it into account
2546 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2547 * Missing elements added in dicomV3.dic
2548 (just to be affraid : have a look at
2549 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2550 and do it again next year ;->
2552 2003-10-13 Jean-Pierre Roux
2553 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2554 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2555 But there are NOT. It's fixed !
2557 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2558 * FIX: "jpeglib.h" was not found on VC++
2559 * FIX: vtkgdcm was not being installed
2561 2003-10-10 Jean-Pierre Roux
2562 * ENH : OpenFile closes the file if it *really* doesn't look like
2563 an ACR-NEMA / DICOM one.
2564 * FIX : testWrite no longer writes an empty file if the source file
2565 is not gdcm Readable
2566 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2569 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2570 * FIX: CMake generate now documentation
2571 * ENH: out of source doc build !
2572 * ENH: Generate both user and dev documentation
2573 * ENH: Should work on windows too
2574 * ENH: Only one doxygen config.in file is needed
2575 * FIX: make install should be ok now on ùnix plateform
2576 * FIX: PATH to dictionary was wrong (missing /)
2577 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2579 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2580 * vtkGdcmReader is now able to read rgb dicom file.
2581 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2582 * added a gdcmViewer to vtk test, use mouse to control
2583 window level & window width
2585 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2586 * CMake-ification of gdcm, we have now two build system
2587 * FIX: on cygwin Wsock32 doesn't exist
2588 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2590 2003-10-06 Emanuel Ollart
2591 * FIX : compilation process wad broken.
2592 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2594 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2595 * change gdcmViewer -> vtkgdcmViewer
2596 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2598 2003-10-06 Jean-Pierre Roux
2599 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2600 ( e.g : well known GE images with a wrong elem length,
2601 : Philips MRI Images with a wrong Huffman table)
2602 * still to be done : allow the reading of bugged LEONARDO Siemens images
2604 2003-10-03 Jean-Pierre Roux
2605 * Odd length strings are padded with '\0' (not with spaces,
2606 to remain compliant with already defined strings,
2607 like Transfert Syntax UID and others)
2609 2003-10-03 Jean-Pierre Roux
2610 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2611 to allow displaying RGB images (not only by affim ;-)
2613 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2614 * vtkGdcmReader is now able to read rgb dicom file.
2615 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2617 2003-10-03 Jean-Pierre Roux
2618 * A few nasty patches to allow the reading of a lot of nasty images
2619 ( e.g : well known GE images with a wrong elem length,
2620 : Philips MRI Images with a wrong Huffman table)
2621 * still to be done : allow the reading of bugged LEONARDO Siemens images
2623 2003-10-03 Jean-Pierre Roux
2624 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2626 2003-10-03 Jean-Pierre Roux
2627 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2628 to allow displaying RGB images (not only by affim ;-)
2630 2003-10-03 Jean-Pierre Roux
2631 * gdcmFile::GetImageDataIntoVector now
2632 - deals with MultiFrames MultiFragments Run Length Encoded files
2633 - deals with YcBcR (YBR_FULL) files
2634 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2635 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2637 (no sample found :-(
2639 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2640 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2641 Two reasons: - clear things
2642 - third parties acces gdcm through header files, so won't
2643 suffer anymore VC++ complains
2645 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2646 * add argv[1] in testvtkGdcmReader.cxx
2649 2003-09-24 Jean-Pierre Roux
2650 * The lines are now eigthy characters long.for
2651 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2653 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2654 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2655 char* to std::string. Thus, the use of strdup becomes useless. (see
2656 previous commis of Malaterre)
2657 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2658 before the last Malaterre's commit.
2660 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2661 * This commit should fix the Debug building under VC++, the problem
2662 was mainly a mixture of debug and release lib being loaded at startup.
2663 * I also remove a depency to a specific C function: strdup. Because I had
2664 to force the link to msvcrtd (whereas strdup is in libc).
2666 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2667 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2668 located in the gdcmCommon.h file. All use of reference of tha has been
2669 changed to now use the variable GDCM_UNFOUND.
2671 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2673 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2674 Dicom dictionary. The test suite can now be run again. Note:
2675 I'm note very happy with the " (RET)" changes. I believe this
2676 RETAINED comment should be dropped when parsing the dictionary.
2677 - PACKAGER corrected
2679 - AUTHORS updated and now in alphabetical order
2680 * Makefile.am now exports gdcm.dsw for Windoze users.
2682 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2683 * cygwin complains about missing std:: in subdir Test/
2685 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2686 * remove some methods that are now in gdcmHeaderHelper
2688 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2689 * vtkGdcmReader set spacing and origin correctly
2691 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2692 * Fix a few delete/delete[] mismatch
2694 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2695 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2696 interpretation to data given by gdcmHeader. For instance there are
2697 heuristics to get informations (look at different places).
2698 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2699 sorting DICOM images based on different strategies.
2700 * modified Makefiles accordingly.
2702 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2703 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2704 when building in debug mode
2705 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2706 src/win32/gdcmdll.dsp
2707 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2709 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2710 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2713 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2714 * src/win32/libgdcmjpeg12.dsp was not dos format
2715 * src/win32/libgdcmjpeg12.dsp :
2716 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2717 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2719 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2720 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2722 * src/gdcmFile.cxx : bug fix in affectation type
2723 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2724 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2725 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2726 symbols... future problem ?
2728 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2729 * src/win32/libgdcmijpeg12.dsp was missing
2730 * modified gdcm.dsw accordingly
2732 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2733 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2735 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2736 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2737 commit of JPR (before his hollidays to facilitate our work).
2738 * setup.py : bug fix in code. Modifications made while the last commit
2739 of JPR. The code hasn't been tested before the commit... it's so
2740 useless to make that (for best programmer that is JPR) !!!
2742 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * tagged the current version as Version0_3 (i.e. version 0.3)
2745 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2746 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2747 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2748 * *.dsp : modifications to use new libgdcmijpeg8 library
2749 * setup.py : bug fix on VTKPATH variable
2750 * PACKAGER : adding all concerning windows
2752 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2755 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2756 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2757 test suite reported error.
2758 * PACKAGER file added (describes what a packager must do when
2759 packaging a new release).
2760 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2761 * configure.in: upgraded version number to 0.3.0
2762 * fixing build of rpm (through rpm -ta):
2763 - Doc/Makefile.am exports proper doxygen files
2764 - src/jpeg/libijg8/Makefile.am exports the include files.
2766 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2767 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2768 * src/gdcmHeader.h : formatting code
2770 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2771 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2772 We were obtaining error message from vtk. Now, creation of file list
2773 is made in an internal list to prevent this problem.
2774 Bug fix when output is empty.
2775 Bug fix in update of progress value. Previous commit for this was a bad
2777 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2779 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2780 * src/gdcmHeader.h : added method to get the file name
2781 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2782 files. Added method to remove all files on the input
2783 Added FIXME comment concerning the bad parsing of header made by
2784 ExecuteInformation method (in ExecuteData method)
2786 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2788 when using make instal.
2789 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2790 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2792 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2793 * setup.py : adding include dir of jpeg lib to compile all sources
2794 * */Win32/*.dsp : JPR fix for windows compilation
2796 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2797 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2799 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2800 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2802 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2803 * setup.py is again effective on un*x (takes into account the
2804 addon of the jpeg library)
2805 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2806 * Doc/Doxy* updated (includes above enhancements)
2807 * INSTALL now points to web documentation
2809 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2810 * src/gdcmHeader.h doesn't make unnecessary reference to
2812 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2814 * src/gdcm*.[cxx|h] :
2815 - to allow compilation with gcc 3.x
2816 -- clean up of STL usage (added explicit usage of std::)
2817 -- small fixes on exceptions.
2818 Note: linking not tested !
2819 - clean of doxygen comments to avoid warnings at documentation
2821 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2822 dependent convertion).
2824 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * Clean up of previous JPR garbage commit (not even commented in the
2827 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2828 - moved all jpeg related files from src to src/jpeg/libijg8, with
2829 addition/modification of Makefile.am and configure.in.
2830 - the testSuite is still brain damage (not guilty).
2832 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2833 * WrapVTK.py : modifications to get correctly vtk source files to
2835 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2836 (FileName -> Filename)
2838 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * vtk/vtkGdcmReader.[cxx/h]:
2840 - UpdateProgress method should now be effective
2841 - removed the limitation on having only images loaded (as opposed
2843 - when building a stack of images/volume, a lesser number of
2844 gdcmHeader and gdcmFile instances should be used (hopefully
2845 accelerating things).
2846 - when building a stack of images/volumes, files which are not
2847 loadable (wrong path-filename, wrong permissions on existing file,
2848 or file not parsable by gdcm) are replaced with a black image
2849 in the stack (for the caller to notice the problem).
2851 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2854 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2855 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2856 between standard library (std) and vtk library (problems are found
2857 under Windows... thanks Windows !)
2859 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2860 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2862 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2864 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2867 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * When compiling with distutils (see setup.py) the C++ compiler is
2869 called with different flags than the default ones (with automake).
2870 In order to fix all those warning, I compiled gdcm with the command
2871 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2872 and went for warning fixes:
2873 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2874 up from unused variables.
2875 - vtk/vtkGdcmReader.cxx: potential bug fix.
2876 * src/gdcmHeader.h: Doxygen warning cleanup
2878 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * gdcmPython/gdcm.i:
2880 - typemaps correction to take into account the systematic replacement
2881 of "using namespace std" with std:: prefix e.g. std::list,
2882 std::string... (cf changes of 2003-05-21).
2883 - gdcmGlob global variable of type gdcmGlobal (defined in
2884 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2885 exported to Python a as cvar.
2886 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2887 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2888 gdcmDictSet.GetPubDictTagNames() and
2889 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2890 C++ static methods).
2891 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2892 with the above changes.
2894 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2895 * setup.py, manifest.in : bug fix under linux
2897 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2898 * Modification of setup.py to compile vtk part too. Then, we have 2
2899 wrappers which must work with same distutils. For that, we have a
2900 generic distutils in distusiltsWrapping.py ; with :
2901 - build_extWrap class to wrap generically all extensions,
2902 - ExtensionWrap base class for all wrapping extension that contains
2904 - Wrapper interface which wrap sources
2905 + In WrapSwig.py we have extension and wrapper for Swig
2906 + In WrapVTK.py we have extension and wrapper for VTK
2907 * MANIFEST.in : modifications to consider vtk directory and new python
2908 files for compilation
2910 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2911 * Added python wrappers of vtkGdcmReader vtk class (see the
2912 source in vtk/vtkGdcmReader.cxx) :
2913 - vtk/Makefile.am now builds a library
2914 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2915 python library (as opposed to _gdcm.so wich are the python
2916 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2917 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2919 - configure.in has an additional flag --enable-vtk that needs
2920 to be set to enable compilation of vtk related code, that is:
2921 + vtk/vtkGdcmReader.so and
2922 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2923 + gdcmPython/vtkgdcmPython.so (see above)
2924 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2925 be read when compressed or when HighBit + 1 != BitsStored),
2926 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2927 the usage of the python wrapper of vtkGdcmReader vtk class.
2928 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2929 * src/*.[h] all occurences of stl classes are now prefixed with
2930 std::, and all occurences of "using namespace std;" where removed.
2931 This is to avoid pollution of global namespace in included files.
2932 Apparently vtk does not avoid this pitfall: when using both
2933 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2934 collision of various stl members (principally cout...).
2935 * gdcmPython/testSuite.py now cleanly removes temprory generated
2937 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2938 comply with above changes)
2940 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2941 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2942 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2943 vtk data structure (an image Flip was required).
2944 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2945 * cosmetic changes in documentation.
2947 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2948 * src/gdcmHeader.cxx: the constructor no longer exits when an
2949 unexisting file is given as argument.
2950 * The subdirectory Data (containing all the images used for the
2951 test suite) is not part of this repository anymore. A new module
2952 containing those images is now available at
2953 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2954 with the name gdcmData.
2955 All the python scripts (including the package initialisation file
2956 gdcmPython/__init__.py) were adapated to take this change into
2957 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2959 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2960 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2961 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2962 demo of the usage of this class.
2963 Compilation of this vtk part is only done when using the --enable-vtk
2964 at configure (or autogen.sh) stage.
2966 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2967 * More memory link related corrections and documentation fixes.
2969 - maximum info is obtained with a command of the form:
2970 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2971 --show-reachable=yes PrintHeader
2972 - the remaining reachable blocks seem to come from the STL
2973 allocation scheme through the usage of map and list. It looks
2974 like this memory cannot be freed but it is not a memory leak
2975 (in fact further invocation to the STL would recollect the
2976 unused memory allthough it cannot explicitely be freed).
2977 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2978 of displaying an image parsed with gdcm and displayed with VTK.
2979 Note: some images don't seem to work e.g.
2980 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2981 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2982 Allthough this weakens the semantics, it is a ditch attempt to
2983 make gdcm more thread friendly.
2985 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2986 * Memory link hunt (by using valgrind through the command
2987 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2988 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2989 gdcmHeader::_dicom_vr.
2990 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2991 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2993 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2995 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2996 * src/Makefile.am now exports all the necessary include files at
3000 * UpdateGroupLength replaced by new one
3003 * UpdateGroupLength re-written using H-Table
3004 (named UpdateGroupLengthNew untill checks are over)
3006 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
3007 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
3008 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
3010 - gdcmHeader::GetPubElValSet removed.
3011 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
3012 UpdateGroupLength, WriteElements, Write.
3013 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
3014 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
3015 carried the same semantics.
3016 - src/gdcmHeaderIdo.cxx changed accordingly.
3017 - gdcmFile::WriteBase now regroups all the codes from previous
3018 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
3019 - enum FileType moved to gdcmCommon.h
3020 * src/gdcmHeader.cxx AddDefault trashed
3021 * gdcmGetXSize added
3022 * getimageDataSize now calls gdcmGetXSize
3023 * Test/*.cxx changed to agree with above changes
3025 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3026 * src/gdcmHeader.h: LoadElements() is not a public method anymore
3027 (to avoid double call by end user).
3028 * Test/*.cxx LoadElements() doesn't need to be called explicitely
3029 by end user, since gdcmHeader::gdcmHeader now handles it.
3031 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3032 * gdcm/Doc many doxygen changes:
3033 - Doxyfile now has two different versions, DoxyfileUsers that generates
3034 the html.users end users oriented documentation and
3035 DoxyfileDeveloppers that generates the html.developper developper
3036 oriented documentation.
3037 - README changed accordingly
3038 - requirement.txt removed (old design info moved to TODO).
3039 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
3040 DoxyMainPage.txt, DoxyPython.txt provide more information.
3041 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
3042 be updated by simply regenerating the docs with doxygen and copying
3043 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
3044 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
3045 all the tests in the form "if (<map>.count() >1)" were removed.
3046 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
3047 ill-formed documentation sections.
3048 * src/gdcmHeader.cxx: ditto
3050 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3051 * setup.py fixed for un*x (needed macro for stdint.h)
3052 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
3053 un*ces with sh-utils test utility.
3054 * gdcmPython/demo/test.py renamed to PrintHeader.py
3055 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
3056 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
3057 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
3058 * src/gdcm*.cxx JPR's bad inclusion fixed.
3060 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3061 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
3062 * gdcmPython/demo/test.py changed accordingly.
3064 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3065 * gdcmPython/Makefile.am fixed linking against libstdc++
3066 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
3067 * Swig subdir (historical tests of swig version 1.3.17++) removed
3068 * Test/testChangeEntete.cxx some lines commented out in order to make
3070 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
3071 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
3073 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3074 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
3075 hence the user doesn't need this explicit call.
3076 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
3077 i.e. LoadElements() call removed.
3078 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
3079 - src/Makefile.am declares the proper flag for g++.
3080 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
3081 for adding user defined new tags.
3082 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
3083 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
3084 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
3086 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
3087 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
3088 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
3089 src/Makefile.am : the project should properly compile and install
3090 with the autotools, included the python wrappers part.
3091 * gdcm.spec.in : added a spec file for RPM packaging.
3093 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3094 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
3096 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3097 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3098 to exported to the environement (see gdcmPython/testSuite.py
3100 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
3101 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
3102 ElValue class renamed to gdcmElValue for obvious consistency reasons.
3103 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
3104 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
3106 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3107 * gdcmPython/__init__.py doesn't crash anymore when running in
3108 in InstallMode or PreInstallMode but with an environment given
3109 value of GDCM_DICT_PATH.
3110 * src/gdcmDictSet.[cxx/h] coding style.
3112 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3113 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
3114 * src/gdcm.h general comments moved to TODO, and README
3115 * src/gdcm.h should now be seen as a user commodity (including it
3116 should suffice to fully use gdcm). It is nowhere including within
3117 any of the kernel files src/*.cxx and src/*.h.
3119 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3120 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
3121 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
3123 * src/gdcm*.cxx only include their corresponding include file
3124 (as opposed to gdcm.h)
3125 * gdcmPython/gdcm.i changed accordingly
3126 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
3127 the autogen.sh generated "make snapshot" command to work.
3128 * autogen.sh removed history related references to crea package.
3130 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3131 * distutilsSwigCPlusPlus.py work around some swig portability
3134 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3135 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3136 was done in a last ditch attempt to get setup.py _really_
3137 operationnal. The python/gdcmPython layaout add the advantage
3138 of hidding away the python related distutils specific files
3139 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
3140 Alas, the src directory was out of scope (i.e. it's relative
3141 position to setup.py was ../src) which made things impossible to
3142 handle (see previous version of python/setup.py). Crossing fingers...
3144 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3145 * python/setup.py now works on Un*x. (harder than I thougth)
3146 * python/distutilsSwigCPlusPlus.py can now have include files
3147 among the list of sources.
3149 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3150 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
3151 * modifications in MSVC projects
3153 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3154 * As stated by the first lines of Test/ExceptionAndPython/README, it
3155 looks like we can move back to original usage of exception within
3156 src/gdcm* and hence remove the errno stuff that was introduced
3157 as a quick and dirty fixture of this problem (added to the TODO).
3158 * Doc/Doxyfile configuration file for Doxygen and corresponding
3159 README file for usage added.
3160 * Test/testWrite.cxx added. This new test comes from a split of
3161 test.cxx that is now reverted to its original purpous i.e.
3162 testing the proper parsing of a Dicom related file.
3163 testWrite.cxx concentrates on testing the IO part of gdcm.
3164 * Test/bug1.cxx (containing a bug on WIn32) added.
3165 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
3166 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
3167 whose purpose is to publish the content of the TagNames of the
3168 Dicom public dictionary were not accessible without an
3169 instance of class gdcmHeader.
3170 - those methods are now static methods of gdcmDictSet and hence
3171 require no instances at all to be invocated.
3172 - within gdcmDictSet this change required to change some method
3173 to class methods (i.e. are now static) among which SetDictPath
3174 (renamed to BuildDictPath) and LoadDefaultPubDict.
3175 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
3176 the above changes by calling the new method classes of gdcmDictSet.
3177 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
3178 the above to be effective.
3179 * python/gdcmPython: in order to wrap properly the above changes
3180 for Python, swig version now needs to be > 1.3.17.
3181 * python/gdcmPython/Makefile fixed to adapt itself to new
3182 configure/make shema introduced by Johan Montagnat (thanks for the
3183 contribution). Alas this Makefile cannot be turned into a proper
3184 Makefile.am without some heavy changes in the configure.in
3185 (for python dectection).
3186 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
3187 now avoids publishing the empty entries.
3189 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3190 * python/setup.py : bug fix concerning install under windows
3191 ExtraPath reused :-P
3192 * gdcm.dsw : bug fix concerning path for libraries for python !!!
3194 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
3195 * Dicts/dicomV3.dic : remove double spaces !!!
3196 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
3197 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
3200 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3201 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
3202 method. Doxygenation.
3203 * src/gdcm.h clean up of JPR spurious comments.
3205 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3206 * python/distutilsSwigCPlusPlus.py now properly collects the
3207 shadow classes generated by "swig -c++" (gdcm.py in our case)
3208 when using "python setup.py install".
3209 * python/gdcmPython/__init__.py imports gdcm.py and only manually
3210 reexports the working classes.
3211 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
3212 by the classical C errno scheme. This is to prevent an obscure
3213 behavior of the python wrappers when importing wxPython.wx prior
3214 to gdcmPython (which ended up in an abort call). An illustration
3215 of this oddity can be found in the Test/ExceptionAndPython
3216 subdir (see the README file). This problem probably due to
3217 an combination of g++ and dynamic loading.
3218 * added Test/ExceptionAndPython (see above)
3220 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3221 * Changed the layout of the python part to avoid bloating main
3222 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
3223 i.e. the distutils arsenal. All the python related stuff is
3224 again in a python subdir, but the package itself is now in
3226 * setup.py was cleaned up:
3227 - pythonIncludePath removed
3228 - python setup.py bdist target is now functional.
3229 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
3230 collision with other packages). gdcmPython/demo/*.py changed
3233 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3234 * python subdir moved to gdcmPython (preparation of distutils packaging).
3235 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
3236 distutils installer is operational.
3237 * - gdcmPython/__init__.py now properly loads the swig generated
3238 shadow classes (from gdcm.py).
3239 - gdcmPython/demo/*.py changed to import the package gdcmPython
3240 instead of gdcmPython/demo/load.py.
3241 - gdcmPython/testSuite.py changed to import the package gdcmPython.
3243 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3244 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
3245 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
3246 entries within the associated public Dicom dictionary resp. the same
3247 information but sorted by the fourth field (PAT, IMG, DIR) of the
3249 - Dicts/dicomV3.dic Entries which had an unspecified fourth field
3250 are now in the "???" group.
3251 - python/gdcm.i changed accordingly,
3252 - python/demo/printGroupedPublicDict.py added, that gives an example
3253 of the above new functionalities in Python.
3255 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3256 * src/gdcm.h, gdcmHeader.cxx:
3257 - historic references to glib's g_malloc and g_free (#defined)
3258 were definitively removed.
3259 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
3260 * src/gdcmElValSet.cxx:
3261 - GetElement(guint32, guint32) renamed to GetElementByNumber.
3262 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
3263 - GetElValue(string) renamed to GetElValueByName.
3264 - Added GetElementByName(string).
3265 * src/gdcmHeader.cxx: added
3266 - GetPubElValRepByNumber(guint16, guint16)
3267 - GetPubElValRepByName(string)
3268 - GetShaElValRepByNumber(guint16, guint16)
3269 - GetShaElValRepByName(string)
3270 - GetShaElValByNumber(guint16, guint16)
3271 - GetShaElValRepByName(string)
3272 - GetElValRepByNumber(guint16, guint16)
3273 - GetElValRepByName(string)
3274 - GetElValByNumber(guint16, guint16)
3275 - GetElValRepByName(string)
3276 * Doc/requirements.txt added.
3278 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3279 * Test/Makefile building now depends on the one of libgdcm.so
3280 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
3281 pixel data) aware which enables finding the address (offset) of
3282 the pixel data of JPEG encoded DICOM files. This leaves only a single
3283 file in the testSuite whose pixel data address (offset) is unknown.
3284 * python/testSuite.py changed accordingly.
3286 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
3287 * VC++ has some strong limitations when working with the STL, as stated
3288 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
3289 "Also note that some STL containers (map, set, queue, list, deque)
3290 cannot be exported. [...]
3291 Some STL classes contain nested classes. These classes can not
3293 This is caused by a designed limitation that once a template
3294 class is instantiated, it can not be re-instantiated and
3296 Since our usage of map<> is ubiquitous in gdcm, this "designed
3297 limitation" of VC++ is a pitfall.
3298 Hence the Python wrappers of gdcm cannot be incrementally linked
3299 against the c++ dynamic library. The dirty but only workaround is
3300 to forget about incremental link of dynamic libraries and to generate
3301 the Python wrappers library with the inclusions of the underlying C++
3303 The following modifications concern this matter on Win32/VC++:
3304 - wrapping python correct with standalone wrapped dll (don't use separate
3305 dll under windows !!!!)
3306 - python21_d debug mode enabled (ask Frog how to use it :-)
3307 - NO problem with having an STL member of class for example string in C++
3308 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
3309 - Python test of dcmlib in Python is ok under windows on a large set
3311 * removed glib references
3312 * typedef's inserted in gdcm.i for correct swig type management
3314 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3315 * python/demo/*.py load.py extracted from test.py. Added explore.py
3316 that only displays required tags and testAll.py that parses all
3317 the files of the testsuite without using unittest.
3318 * python/testSuite.py other additional test on new files added.
3319 * Data/* new test files added accordingly to the testSuite.
3320 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
3321 the vr in the file differs from the one of the dictionary.
3323 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3324 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
3325 values, but limits itself to values which are below a user specified
3326 size (by default 1024 bytes).
3327 * python/gdcm.i : elements not loaded (because their size is above the
3328 user specified treshold) are exported with their TagKey as key of the
3329 python dictionary. This enables the testsuite to make some checks
3330 on the unloaded elements (since we have their offset and size).
3331 * python/testSuite.py
3332 - now tests for the existence and proper value of the pixel data
3333 - two new examples added.
3334 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
3336 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3337 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
3338 aware. See the strategy comments in gdcmHeader::FindLength().
3339 * Test/test.cxx now accepts a filename as first argument.
3340 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
3341 * python/testSuite.py changed to integrate test on above files.
3343 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3344 * Dicts/dicomV3.dic removed all the trailing (RET) when the
3345 the vr was also RET.
3346 * python/testSuite.py more tests added.
3348 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3349 * python/testSuite.py unittest test suite added (uses Data)
3350 * Data/* dcm and acr files for the test suite.
3351 * glib dependance removed from un*x version. We now use ISO C99
3352 7.18 Integer types (see stdint.h)
3353 - python/Makefile, src/Makefile src/gdcm.h
3354 * src/ when an explicit vr (like dicom files) suddenly poped an
3355 implicit element we use to mark the underlying DictEntry of the
3356 concerned ElValue with "Implicit". This strategy was damageable
3357 too the public or provite dictionaries, since some of their vr
3358 would be changed. Since Header::FindLength heavily relies on the
3359 detection by Header::FindVR of falsely explicit elements, I
3360 added an extra ImplicitVr member to ElValue (boolean).
3361 The rest of the changes we the necessary adaptations.
3363 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3364 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
3366 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
3368 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3369 * Adaptation for porting to VC++:
3371 o forced to use std namespace (for string to be known)
3372 o all class use __declspec export style on WIN32
3373 - src/gdcmUtil.cxx new Exit method that wraps the exit call
3374 (in stdlib.h on Win32 but in std:: for gcc)
3375 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
3376 variable GDCM_DICT_PATH.
3377 * src/gdcmHeader.cxx verbose comments made discrete.
3379 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3380 * python/gdcm.i: added a typemap that converts a C++ hashing table
3381 to native Python dictionary.
3382 * python/demo/test.py:
3383 - now uses the native dictionary for exploration of gdcmHeader.
3384 - takes an optional filename argument (the file to parse).
3385 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
3386 PubElVals hashing table.
3387 * Dicts/dicomV3.dic removed error prone trailing spaces.
3389 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3390 * Python wrapping process moved away from src/Makefile to
3391 newly created python/Makefile (as well as gdcm.i)
3392 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
3393 * src/gdcmHeader::FindLength only looks for current vr when necessary.
3394 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
3395 from the environement variable GDCM_DICT_PATH (when existing).
3396 * src/gdcmDict::GetTag bug fix.
3398 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3399 * Straightforward temporary fixes for swig to build the python wrappers.
3400 src/Makefile now has a python working entry [by working we mean
3401 that we can import the shadow classes without errors].
3403 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3404 * hashtest.cxx removed (since already in Test)
3405 * src/gdcmlib.h renamed to src/gdcm.h
3406 * src/dcm.i renamed to src/gdcm.i
3407 * src/Makefile prepared for python wrapping
3409 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3410 * src/gdcmHeader.cxx :
3411 - Parsing of header is now separated from loading of element values
3412 (see gdcmHeader::LoadElements).
3413 - general clean up of hopefully all file access (creation of
3414 ReadInt16 and ReadInt32)
3416 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3417 * src/gdcmHeader.cxx :
3418 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
3420 - SetLgrElem renamed to SetLength
3421 - GetLgrElem renamed to GetLength
3422 - ~gdcmHeader() made virtual to pesky warning messages at compile.
3423 * src/gdcmElValSet.cxx fixed both GetElValue methods
3424 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
3425 due to IdoDude was cleaned out.
3427 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3428 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
3429 concentrates on finding the value representation (when it exists).
3430 RecupLgr now only finds the element value length, and it avoids
3431 returning the unecessary skL (skipped length).
3432 Also, offsetCourant was simply removed (with taille_fich) since
3433 it was redundant with the File position internals (by using
3434 ftell and fseek). This also made skL (see above in RecupLgr) usage
3436 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
3437 on the libido specificities which are handled through class
3439 * Test/implicit_vr.dcm dicom v3 in implicit value representation
3442 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3443 * Truckload of changes. Parsing of header is barely functional
3444 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
3446 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3447 * src/gdcmHeader.cxx many addons of low level methods
3449 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3450 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
3451 and _IdDcmSWAP_LONG.
3453 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
3454 * This corresponds to all the changes decided at the meeting of
3455 May 23 2002. Needless to say we are running late...