1 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
3 to exported to the environement (see gdcmPython/testSuite.py
5 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
6 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
7 ElValue class renamed to gdcmElValue for obvious consistency reasons.
9 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
10 * gdcmPython/__init__.py doesn't crash anymore when running in
11 in InstallMode or PreInstallMode but with an environement given
12 value of GDCM_DICT_PATH.
13 * src/gdcmDictSet.[cxx/h] coding style.
15 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
16 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
17 * src/gdcm.h general comments moved to TODO, and README
18 * src/gdcm.h should now be seen as a user commodity (including it
19 should suffice to fully use gdcm). It is nowhere including within
20 any of the kernel files src/*.cxx and src/*.h.
22 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
23 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
24 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
26 * src/gdcm*.cxx only include their corresponding include file
27 (as opposed to gdcm.h)
28 * gdcmPython/gdcm.i changed accordingly
29 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
30 the autogen.sh generated "make snapshot" command to work.
31 * autogen.sh removed history related references to crea package.
33 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
34 * distutilsSwigCPlusPlus.py work around some swig portability
37 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
38 * Eventually, python/gdcmPython was renamed to gdcmPython. This
39 was done in a last ditch attempt to get setup.py _really_
40 operationnal. The python/gdcmPython layaout add the advantage
41 of hidding away the python related distutils specific files
42 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
43 Alas, the src directory was out of scope (i.e. it's relative
44 position to setup.py was ../src) which made things impossible to
45 handle (see previous version of python/setup.py). Crossing fingers...
47 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * python/setup.py now works on Un*x. (harder than I thougth)
49 * python/distutilsSwigCPlusPlus.py can now have include files
50 among the list of sources.
52 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
53 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
54 * modifications in MSVC projects
56 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
57 * As stated by the first lines of Test/ExceptionAndPython/README, it
58 looks like we can move back to original usage of exception within
59 src/gdcm* and hence remove the errno stuff that was introduced
60 as a quick and dirty fixture of this problem (added to the TODO).
61 * Doc/Doxyfile configuration file for Doxygen and corresponding
62 README file for usage added.
63 * Test/testWrite.cxx added. This new test comes from a split of
64 test.cxx that is now reverted to its original purpous i.e.
65 testing the proper parsing of a Dicom related file.
66 testWrite.cxx concentrates on testing the IO part of gdcm.
67 * Test/bug1.cxx (containing a bug on WIn32) added.
68 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
69 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
70 whose purpose is to publish the content of the TagNames of the
71 Dicom public dictionnary were not accessible without an
72 instance of class gdcmHeader.
73 - those methods are now static methods of gdcmDictSet and hence
74 require no instances at all to be invocated.
75 - within gdcmDictSet this change required to change some method
76 to class methods (i.e. are now static) among which SetDictPath
77 (renamed to BuildDictPath) and LoadDefaultPubDict.
78 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
79 the above changes by calling the new method classes of gdcmDictSet.
80 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
81 the above to be effective.
82 * python/gdcmPython: in order to wrap properly the above changes
83 for Python, swig version now needs to be > 1.3.17.
84 * python/gdcmPython/Makefile fixed to adapt itself to new
85 configure/make shema introduced by Johan Montagnat (thanks for the
86 contribution). Alas this Makefile cannot be turned into a proper
87 Makefile.am without some heavy changes in the configure.in
88 (for python dectection).
89 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
90 now avoids publishing the empty entries.
92 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * python/setup.py : bug fix concerning install under windows
95 * gdcm.dsw : bug fix concerning path for libraries for python !!!
97 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * Dicts/dicomV3.dic : remove double spaces !!!
99 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
100 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
103 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
104 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
105 method. Doxygenation.
106 * src/gdcm.h clean up of JPR spurious comments.
108 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * python/distutilsSwigCPlusPlus.py now properly collects the
110 shadow classes generated by "swig -c++" (gdcm.py in our case)
111 when using "python setup.py install".
112 * python/gdcmPython/__init__.py imports gdcm.py and only manually
113 reexports the working classes.
114 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
115 by the classical C errno scheme. This is to prevent an obscure
116 behavior of the python wrappers when importing wxPython.wx prior
117 to gdcmPython (which ended up in an abort call). An illustration
118 of this oddity can be found in the Test/ExceptionAndPython
119 subdir (see the README file). This problem probably due to
120 an combination of g++ and dynamic loading.
121 * added Test/ExceptionAndPython (see above)
123 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * Changed the layout of the python part to avoid bloating main
125 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
126 i.e. the distutils arsenal. All the python related stuff is
127 again in a python subdir, but the package itself is now in
129 * setup.py was cleaned up:
130 - pythonIncludePath removed
131 - python setup.py bdist target is now functional.
132 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
133 collision with other packages). gdcmPython/demo/*.py changed
135 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
136 * python subdir moved to gdcmPython (preparation of distutils packaging).
137 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
138 distutils installer is operational.
139 * - gdcmPython/__init__.py now properly loads the swig generated
140 shadow classes (from gdcm.py).
141 - gdcmPython/demo/*.py changed to import the package gdcmPython
142 instead of gdcmPython/demo/load.py.
143 - gdcmPython/testSuite.py changed to import the package gdcmPython.
146 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
148 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
149 entries within the associated public Dicom dictionary resp. the same
150 information but sorted by the fourth field (PAT, IMG, DIR) of the
152 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
153 are now in the "???" group.
154 - python/gdcm.i changed accordingly,
155 - python/demo/printGroupedPublicDict.py added, that gives an example
156 of the above new functionalities in Python.
158 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
159 * src/gdcm.h, gdcmHeader.cxx:
160 - historic references to glib's g_malloc and g_free (#defined)
161 were definitively removed.
162 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
163 * src/gdcmElValSet.cxx:
164 - GetElement(guint32, guint32) renamed to GetElementByNumber.
165 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
166 - GetElValue(string) renamed to GetElValueByName.
167 - Added GetElementByName(string).
168 * src/gdcmHeader.cxx: added
169 - GetPubElValRepByNumber(guint16, guint16)
170 - GetPubElValRepByName(string)
171 - GetShaElValRepByNumber(guint16, guint16)
172 - GetShaElValRepByName(string)
173 - GetShaElValByNumber(guint16, guint16)
174 - GetShaElValRepByName(string)
175 - GetElValRepByNumber(guint16, guint16)
176 - GetElValRepByName(string)
177 - GetElValByNumber(guint16, guint16)
178 - GetElValRepByName(string)
179 * Doc/requirements.txt added.
181 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * Test/Makefile building now depends on the one of libgdcm.so
183 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
184 pixel data) aware which enables finding the address (offset) of
185 the pixel data of JPEG encoded DICOM files. This leaves only a single
186 file in the testSuite whose pixel data address (offset) is unknown.
187 * python/testSuite.py changed accordingly.
189 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
190 * VC++ has some strong limitations when working with the STL, as stated
191 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
192 "Also note that some STL containers (map, set, queue, list, deque)
193 cannot be exported. [...]
194 Some STL classes contain nested classes. These classes can not
196 This is caused by a designed limitation that once a template
197 class is instantiated, it can not be re-instantiated and
199 Since our usage of map<> is ubiquitous in gdcm, this "designed
200 limitation" of VC++ is a pitfall.
201 Hence the Python wrappers of gdcm cannot be incrementally linked
202 against the c++ dynamic library. The dirty but only workaround is
203 to forget about incremental link of dynamic libraries and to generate
204 the Python wrappers library with the inclusions of the underlying C++
206 The following modifications concern this matter on Win32/VC++:
207 - wrapping python correct with standalone wrapped dll (don't use separate
208 dll under windows !!!!)
209 - python21_d debug mode enabled (ask Frog how to use it :-)
210 - NO problem with having an STL member of class for example string in C++
211 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
212 - Python test of dcmlib in Python is ok under windows on a large set
214 * removed glib references
215 * typedef's inserted in gdcm.i for correct swig type management
217 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
218 * python/demo/*.py load.py extracted from test.py. Added explore.py
219 that only displays required tags and testAll.py that parses all
220 the files of the testsuite without using unittest.
221 * python/testSuite.py other additional test on new files added.
222 * Data/* new test files added accordingly to the testSuite.
223 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
224 the vr in the file differs from the one of the dictionary.
226 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
227 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
228 values, but limits itself to values which are below a user specified
229 size (by default 1024 bytes).
230 * python/gdcm.i : elements not loaded (because their size is above the
231 user specified treshold) are exported with their TagKey as key of the
232 python dictionary. This enables the testsuite to make some checks
233 on the unloaded elements (since we have their offset and size).
234 * python/testSuite.py
235 - now tests for the existence and proper value of the pixel data
236 - two new examples added.
237 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
239 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
241 aware. See the strategy comments in gdcmHeader::FindeLength().
242 * Test/test.cxx now accepts a filename as first argument.
243 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
244 * python/testSuite.py changed to integrate test on above files.
246 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Dicts/dicomV3.dic removed all the trailing (RET) when the
249 * python/testSuite.py more tests added.
251 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * python/testSuite.py unittest test suite added (uses Data)
253 * Data/* dcm and acr files for the test suite.
254 * glib dependance removed from un*x version. We now use ISO C99
255 7.18 Integer types (see stdint.h)
256 - python/Makefile, src/Makefile src/gdcm.h
257 * src/ when an explicit vr (like dicom files) suddenly poped an
258 implicit element we use to mark the underlying DictEntry of the
259 concerned ElValue with "Implicit". This strategy was damageable
260 too the public or provite dictionaries, since some of their vr
261 would be changed. Since Header::FindLength heavily relies on the
262 detection by Header::FindVR of falsely explicit elements, I
263 added an extra ImplicitVr member to ElValue (boolean).
264 The rest of the changes we the necessary adaptations.
266 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
269 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
271 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
272 * Adaptation for porting to VC++:
274 o forced to use std namespace (for string to be known)
275 o all class use __declspec export style on WIN32
276 - src/gdcmUtil.cxx new Exit method that wraps the exit call
277 (in stdlib.h on Win32 but in std:: for gcc)
278 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
279 variable GDCM_DICT_PATH.
280 * src/gdcmHeader.cxx verbose comments made discrete.
282 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * python/gdcm.i: added a typemap that converts a C++ hashing table
284 to native Python dictionary.
285 * python/demo/test.py:
286 - now uses the native dictionary for exploration of gdcmHeader.
287 - takes an optional filename argument (the file to parse).
288 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
289 PubElVals hashing table.
290 * Dicts/dicomV3.dic removed error prone trailing spaces.
292 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * Python wrapping process moved away from src/Makefile to
294 newly created python/Makefile (as well as gdcm.i)
295 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
296 * src/gdcmHeader::FindLength only looks for current vr when necessary.
297 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
298 from the environement variable GDCM_DICT_PATH (when existing).
299 * src/gdcmDict::GetTag bug fix.
301 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
302 * Straightforward temporary fixes for swig to build the python wrappers.
303 src/Makefile now has a python working entry [by working we mean
304 that we can import de shadow classes without errors].
306 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
307 * hashtest.cxx removed (since allready in Test)
308 * src/gdcmlib.h renamed to src/gdcm.h
309 * src/dcm.i renamed to src/gdcm.i
310 * src/Makefile prepared for python wrapping
312 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
313 * src/gdcmHeader.cxx :
314 - Parsing of header is now separated from loading of element values
315 (see gdcmHeader::LoadElements).
316 - general clean up of hopefully all file access (creation of
317 ReadInt16 and ReadInt32)
319 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * src/gdcmHeader.cxx :
321 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
323 - SetLgrElem renamed to SetLength
324 - GetLgrElem renamed to GetLength
325 - ~gdcmHeader() made virtual to pesky warning messages at compile.
326 * src/gdcmElValSet.cxx fixed both GetElValue methods
327 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
328 due to IdoDude was cleaned out.
330 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
331 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
332 concentrates on finding the value representation (when it exists).
333 RecupLgr now only finds the element value length, and it avoids
334 returning the unecessary skL (skipped length).
335 Also, offsetCourant was simply removed (with taille_fich) since
336 it was redundant with the File position internals (by using
337 ftell and fseek). This also made skL (see above in RecupLgr) usage
339 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
340 on the libido specificities which are handled through class
342 * Test/implicit_vr.dcm dicom v3 in implicit value representation
345 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * Truckload of changes. Parsing of header is barely functional
347 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
349 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * src/gdcmHeader.cxx many addons of low level methods
352 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
356 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * This corresponds to all the changes decided at the meeting of
358 May 23 2002. Needless to say we are running late...