1 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Eventually, python/gdcmPython was renamed to gdcmPython. This
3 was done in a last ditch attempt to get setup.py _really_
4 operationnal. The python/gdcmPython layaout add the advantage
5 of hidding away the python related distutils specific files
6 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
7 Alas, the src directory was out of scope (i.e. it's relative
8 position to setup.py was ../src) which made things impossible to
9 handle (see previous version of python/setup.py). Crossing fingers...
11 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * python/setup.py now works on Un*x. (harder than I thougth)
13 * python/distutilsSwigCPlusPlus.py can now have include files
14 among the list of sources.
16 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
18 * modifications in MSVC projects
20 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
21 * As stated by the first lines of Test/ExceptionAndPython/README, it
22 looks like we can move back to original usage of exception within
23 src/gdcm* and hence remove the errno stuff that was introduced
24 as a quick and dirty fixture of this problem (added to the TODO).
25 * Doc/Doxyfile configuration file for Doxygen and corresponding
26 README file for usage added.
27 * Test/testWrite.cxx added. This new test comes from a split of
28 test.cxx that is now reverted to its original purpous i.e.
29 testing the proper parsing of a Dicom related file.
30 testWrite.cxx concentrates on testing the IO part of gdcm.
31 * Test/bug1.cxx (containing a bug on WIn32) added.
32 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
33 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
34 whose purpose is to publish the content of the TagNames of the
35 Dicom public dictionnary were not accessible without an
36 instance of class gdcmHeader.
37 - those methods are now static methods of gdcmDictSet and hence
38 require no instances at all to be invocated.
39 - within gdcmDictSet this change required to change some method
40 to class methods (i.e. are now static) among which SetDictPath
41 (renamed to BuildDictPath) and LoadDefaultPubDict.
42 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
43 the above changes by calling the new method classes of gdcmDictSet.
44 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
45 the above to be effective.
46 * python/gdcmPython: in order to wrap properly the above changes
47 for Python, swig version now needs to be > 1.3.17.
48 * python/gdcmPython/Makefile fixed to adapt itself to new
49 configure/make shema introduced by Johan Montagnat (thanks for the
50 contribution). Alas this Makefile cannot be turned into a proper
51 Makefile.am without some heavy changes in the configure.in
52 (for python dectection).
53 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
54 now avoids publishing the empty entries.
56 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * python/setup.py : bug fix concerning install under windows
59 * gdcm.dsw : bug fix concerning path for libraries for python !!!
61 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * Dicts/dicomV3.dic : remove double spaces !!!
63 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
64 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
67 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
68 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
70 * src/gdcm.h clean up of JPR spurious comments.
72 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
73 * python/distutilsSwigCPlusPlus.py now properly collects the
74 shadow classes generated by "swig -c++" (gdcm.py in our case)
75 when using "python setup.py install".
76 * python/gdcmPython/__init__.py imports gdcm.py and only manually
77 reexports the working classes.
78 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
79 by the classical C errno scheme. This is to prevent an obscure
80 behavior of the python wrappers when importing wxPython.wx prior
81 to gdcmPython (which ended up in an abort call). An illustration
82 of this oddity can be found in the Test/ExceptionAndPython
83 subdir (see the README file). This problem probably due to
84 an combination of g++ and dynamic loading.
85 * added Test/ExceptionAndPython (see above)
87 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
88 * Changed the layout of the python part to avoid bloating main
89 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
90 i.e. the distutils arsenal. All the python related stuff is
91 again in a python subdir, but the package itself is now in
93 * setup.py was cleaned up:
94 - pythonIncludePath removed
95 - python setup.py bdist target is now functional.
96 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
97 collision with other packages). gdcmPython/demo/*.py changed
99 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
100 * python subdir moved to gdcmPython (preparation of distutils packaging).
101 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
102 distutils installer is operational.
103 * - gdcmPython/__init__.py now properly loads the swig generated
104 shadow classes (from gdcm.py).
105 - gdcmPython/demo/*.py changed to import the package gdcmPython
106 instead of gdcmPython/demo/load.py.
107 - gdcmPython/testSuite.py changed to import the package gdcmPython.
110 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
111 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
112 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
113 entries within the associated public Dicom dictionary resp. the same
114 information but sorted by the fourth field (PAT, IMG, DIR) of the
116 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
117 are now in the "???" group.
118 - python/gdcm.i changed accordingly,
119 - python/demo/printGroupedPublicDict.py added, that gives an example
120 of the above new functionalities in Python.
122 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
123 * src/gdcm.h, gdcmHeader.cxx:
124 - historic references to glib's g_malloc and g_free (#defined)
125 were definitively removed.
126 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
127 * src/gdcmElValSet.cxx:
128 - GetElement(guint32, guint32) renamed to GetElementByNumber.
129 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
130 - GetElValue(string) renamed to GetElValueByName.
131 - Added GetElementByName(string).
132 * src/gdcmHeader.cxx: added
133 - GetPubElValRepByNumber(guint16, guint16)
134 - GetPubElValRepByName(string)
135 - GetShaElValRepByNumber(guint16, guint16)
136 - GetShaElValRepByName(string)
137 - GetShaElValByNumber(guint16, guint16)
138 - GetShaElValRepByName(string)
139 - GetElValRepByNumber(guint16, guint16)
140 - GetElValRepByName(string)
141 - GetElValByNumber(guint16, guint16)
142 - GetElValRepByName(string)
143 * Doc/requirements.txt added.
145 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 * Test/Makefile building now depends on the one of libgdcm.so
147 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
148 pixel data) aware which enables finding the address (offset) of
149 the pixel data of JPEG encoded DICOM files. This leaves only a single
150 file in the testSuite whose pixel data address (offset) is unknown.
151 * python/testSuite.py changed accordingly.
153 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
154 * VC++ has some strong limitations when working with the STL, as stated
155 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
156 "Also note that some STL containers (map, set, queue, list, deque)
157 cannot be exported. [...]
158 Some STL classes contain nested classes. These classes can not
160 This is caused by a designed limitation that once a template
161 class is instantiated, it can not be re-instantiated and
163 Since our usage of map<> is ubiquitous in gdcm, this "designed
164 limitation" of VC++ is a pitfall.
165 Hence the Python wrappers of gdcm cannot be incrementally linked
166 against the c++ dynamic library. The dirty but only workaround is
167 to forget about incremental link of dynamic libraries and to generate
168 the Python wrappers library with the inclusions of the underlying C++
170 The following modifications concern this matter on Win32/VC++:
171 - wrapping python correct with standalone wrapped dll (don't use separate
172 dll under windows !!!!)
173 - python21_d debug mode enabled (ask Frog how to use it :-)
174 - NO problem with having an STL member of class for example string in C++
175 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
176 - Python test of dcmlib in Python is ok under windows on a large set
178 * removed glib references
179 * typedef's inserted in gdcm.i for correct swig type management
181 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * python/demo/*.py load.py extracted from test.py. Added explore.py
183 that only displays required tags and testAll.py that parses all
184 the files of the testsuite without using unittest.
185 * python/testSuite.py other additional test on new files added.
186 * Data/* new test files added accordingly to the testSuite.
187 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
188 the vr in the file differs from the one of the dictionary.
190 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
191 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
192 values, but limits itself to values which are below a user specified
193 size (by default 1024 bytes).
194 * python/gdcm.i : elements not loaded (because their size is above the
195 user specified treshold) are exported with their TagKey as key of the
196 python dictionary. This enables the testsuite to make some checks
197 on the unloaded elements (since we have their offset and size).
198 * python/testSuite.py
199 - now tests for the existence and proper value of the pixel data
200 - two new examples added.
201 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
203 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
204 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
205 aware. See the strategy comments in gdcmHeader::FindeLength().
206 * Test/test.cxx now accepts a filename as first argument.
207 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
208 * python/testSuite.py changed to integrate test on above files.
210 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * Dicts/dicomV3.dic removed all the trailing (RET) when the
213 * python/testSuite.py more tests added.
215 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * python/testSuite.py unittest test suite added (uses Data)
217 * Data/* dcm and acr files for the test suite.
218 * glib dependance removed from un*x version. We now use ISO C99
219 7.18 Integer types (see stdint.h)
220 - python/Makefile, src/Makefile src/gdcm.h
221 * src/ when an explicit vr (like dicom files) suddenly poped an
222 implicit element we use to mark the underlying DictEntry of the
223 concerned ElValue with "Implicit". This strategy was damageable
224 too the public or provite dictionaries, since some of their vr
225 would be changed. Since Header::FindLength heavily relies on the
226 detection by Header::FindVR of falsely explicit elements, I
227 added an extra ImplicitVr member to ElValue (boolean).
228 The rest of the changes we the necessary adaptations.
230 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
231 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
233 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
235 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
236 * Adaptation for porting to VC++:
238 o forced to use std namespace (for string to be known)
239 o all class use __declspec export style on WIN32
240 - src/gdcmUtil.cxx new Exit method that wraps the exit call
241 (in stdlib.h on Win32 but in std:: for gcc)
242 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
243 variable GDCM_DICT_PATH.
244 * src/gdcmHeader.cxx verbose comments made discrete.
246 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * python/gdcm.i: added a typemap that converts a C++ hashing table
248 to native Python dictionary.
249 * python/demo/test.py:
250 - now uses the native dictionary for exploration of gdcmHeader.
251 - takes an optional filename argument (the file to parse).
252 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
253 PubElVals hashing table.
254 * Dicts/dicomV3.dic removed error prone trailing spaces.
256 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
257 * Python wrapping process moved away from src/Makefile to
258 newly created python/Makefile (as well as gdcm.i)
259 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
260 * src/gdcmHeader::FindLength only looks for current vr when necessary.
261 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
262 from the environement variable GDCM_DICT_PATH (when existing).
263 * src/gdcmDict::GetTag bug fix.
265 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
266 * Straightforward temporary fixes for swig to build the python wrappers.
267 src/Makefile now has a python working entry [by working we mean
268 that we can import de shadow classes without errors].
270 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * hashtest.cxx removed (since allready in Test)
272 * src/gdcmlib.h renamed to src/gdcm.h
273 * src/dcm.i renamed to src/gdcm.i
274 * src/Makefile prepared for python wrapping
276 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
277 * src/gdcmHeader.cxx :
278 - Parsing of header is now separated from loading of element values
279 (see gdcmHeader::LoadElements).
280 - general clean up of hopefully all file access (creation of
281 ReadInt16 and ReadInt32)
283 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * src/gdcmHeader.cxx :
285 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
287 - SetLgrElem renamed to SetLength
288 - GetLgrElem renamed to GetLength
289 - ~gdcmHeader() made virtual to pesky warning messages at compile.
290 * src/gdcmElValSet.cxx fixed both GetElValue methods
291 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
292 due to IdoDude was cleaned out.
294 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
296 concentrates on finding the value representation (when it exists).
297 RecupLgr now only finds the element value length, and it avoids
298 returning the unecessary skL (skipped length).
299 Also, offsetCourant was simply removed (with taille_fich) since
300 it was redundant with the File position internals (by using
301 ftell and fseek). This also made skL (see above in RecupLgr) usage
303 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
304 on the libido specificities which are handled through class
306 * Test/implicit_vr.dcm dicom v3 in implicit value representation
309 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
310 * Truckload of changes. Parsing of header is barely functional
311 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
313 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * src/gdcmHeader.cxx many addons of low level methods
316 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
320 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * This corresponds to all the changes decided at the meeting of
322 May 23 2002. Needless to say we are running late...