1 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * CMake-ification of gdcm, we have now two build system
3 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
4 * vtkGdcmReader is now able to read rgb dicom file.
5 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
6 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
8 Two reasons: - clear things
9 - third parties acces gdcm through header files, so won't
10 suffer anymore VC++ complains
12 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
13 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
14 char* to std::string. Thus, the use of strdup becoomes useless. (see
15 previous commis of Malaterre)
16 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
17 before the last Malaterre's commit.
19 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
20 * This commit should fix the Debug building under VC++, the problem
21 was mainly a mixture of debug and release lib being loaded at startup.
22 * I also remove a depency to a specific C function: strdup. Because I had
23 to force the link to msvcrtd (whereas strdup is in libc).
25 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
27 located in the gdcmCommon.h file. All use of reference of tha has been
28 changed to now use the variable GDCM_UNFOUND.
30 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
32 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
33 Dicom dictionary. The test suite can now be run again. Note:
34 I'm note very happy with the " (RET)" changes. I believe this
35 RETAINED comment should be dropped when parsing the dictionary.
38 - AUTHORS updated and now in alphabetical order
39 * Makefile.am now exports gdcm.dsw for Windoze users.
41 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
42 * cygwin complains about missing std:: in subdir Test/
44 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
45 * remove some methods that are now in gdcmHeaderHelper
47 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
48 * vtkGdcmReader set spacing and origin correctly
50 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * Fix a few delete/delete[] mismatch
53 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
54 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
55 interpretation to data given by gdcmHeader. For instance there are
56 heuristics to get informations (look at different places).
57 * it also include a specific class: gdcmSerieHeaderHelper devoted to
58 sorting DICOM images based on different strategies.
59 * modified Makefiles accordingly.
61 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
62 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
63 when building in debug mode
64 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
66 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
68 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
69 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks to valgrind.
71 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
72 * src/win32/libgdcmjpeg12.dsp was not dos format
73 * src/win32/libgdcmjpeg12.dsp : libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
74 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
76 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
79 * src/gdcmFile.cxx : bug fix in affectation type
80 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
81 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
82 * Modifs of MVSC projects to compile them. Not concerning 2 identic
83 symbols... futur problem ?
85 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
86 * src/win32/libgdcmijpeg12.dsp was missing
87 * modified gdcm.dsw accordingly
89 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
90 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
92 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
94 commit of JPR (before his hollidays to facilitate our work).
95 * setup.py : bug fix in code. Modifications made while the last commit
96 of JPR. The code hasn't been tested before the commit... it's so
97 useless to make that (for best programmer that is JPR) !!!
99 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
100 * tagged the current version as Version0_3 (i.e. version 0.3)
102 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
103 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
104 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
105 * *.dsp : modifications to use new libgdcmijpeg8 library
106 * setup.py : bug fix on VTKPATH variable
107 * PACKAGER : adding all concerning windows
109 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
110 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
112 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
113 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
114 test suite reported error.
115 * PACKAGER file added (describes what a packager must do when
116 packaging a new release).
117 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
118 * configure.in: upgraded version number to 0.3.0
119 * fixing build of rpm (through rpm -ta):
120 - Doc/Makefile.am exports proper doxygen files
121 - src/jpeg/libijg8/Makefile.am exports the include files.
123 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
125 * src/gdcmHeader.h : formatting code
127 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
129 We were obtaining error message from vtk. Now, creation of file list
130 is made in an internal list to prevent this problem.
131 Bug fix when output is empty.
132 Bug fix in update of progress value. Previous commit for this was a bad
134 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
136 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * src/gdcmHeader.h : added method to get the file name
138 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
139 files. Added method to remove all files on the input
140 Added FIXME comment concerning the bad parsing of header made by
141 ExecuteInformation method (in ExecuteData method)
143 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
144 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
145 when using make instal.
146 * src/gdcmFile.cxx : bug fix under Window after JPR commit
147 RQ : the JPR doesn't appear in the ChangeLog... normal for him
149 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * setup.py : adding include dir of jpeg lib to compile all sources
151 * */Win32/*.dsp : JPR fix for windows compilation
153 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
156 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
157 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
159 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * setup.py is again effective on un*x (takes into account the
161 addon of the jpeg library)
162 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
163 * Doc/Doxy* updated (includes above enhancements)
164 * INSTALL now points to web documentation
166 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * src/gdcmHeader.h doesn't make unnecessary reference to
169 * gdcmPython/Makefile.am now avoids calling the wrappers for the
171 * src/gdcm*.[cxx|h] :
172 - to allow compilation with gcc 3.x
173 -- clean up of STL usage (added explicit usage of std::)
174 -- small fixes on exceptions.
175 Note: linking not tested !
176 - clean of doxygen comments to avoid warnings at documentation
178 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
179 dependent convertion).
181 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
182 * Clean up of previous JPR garbage commit (not even commented in the
184 - Test/Makefile.am removed the reference to unexisting testTS.cxx
185 - moved all jpeg related files from src to src/jpeg/libijg8, with
186 addition/modification of Makefile.am and configure.in.
187 - the testSuite is still brain damage (not guilty).
189 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * WrapVTK.py : modifications to get correctly vtk source files to
192 * vtk/vtkGdcmReader.cxx : modification for an already existing name
193 (FileName -> Filename)
195 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
196 * vtk/vtkGdcmReader.[cxx/h]:
197 - UpdateProgress method should now be effective
198 - removed the limitation on having only images loaded (as opposed
200 - when building a stack of images/volume, a lesser number of
201 gdcmHeader and gdcmFile instances should be used (hopefully
202 accelerating things).
203 - when building a stack of images/volumes, files which are not
204 loadable (wrong path-filename, wrong permissions on existing file,
205 or file not parsable by gdcm) are replaced with a black image
206 in the stack (for the caller to notice the problem).
208 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
209 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
211 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
213 between standard library (std) and vtk library (problems are found
214 under Windows... thanks Windows !)
216 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
219 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
221 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
222 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
224 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * When compiling with distutils (see setup.py) the C++ compiler is
226 called with different flags than the default ones (with automake).
227 In order to fix all those warning, I compiled gdcm with the command
228 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
229 and went for warning fixes:
230 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
231 up from unused variables.
232 - vtk/vtkGdcmReader.cxx: potential bug fix.
233 * src/gdcmHeader.h: Doxygen warning cleanup
235 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
237 - typemaps correction to take into account the systematic replacement
238 of "using namespace std" with std:: prefix e.g. std::list,
239 std::string... (cf changes of 2003-05-21).
240 - gdcmGlob global variable of type gdcmGlobal (defined in
241 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
242 exported to Python a as cvar.
243 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
244 and GetPubDictTagNamesByCategory() as a replacement for deprecated
245 gdcmDictSet.GetPubDictTagNames() and
246 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
248 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
249 with the above changes.
251 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * setup.py, manifest.in : bug fix under linux
254 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
255 * Modification of setup.py to compile vtk part too. Then, we have 2
256 wrappers which must work with same distutils. For that, we have a
257 generic distutils in distusiltsWrapping.py ; with :
258 - build_extWrap class to wrap generically all extensions,
259 - ExtensionWrap base class for all wrapping extension that contains
261 - Wrapper interface which wrap sources
262 + In WrapSwig.py we have extension and wrapper for Swig
263 + In WrapVTK.py we have extension and wrapper for VTK
264 * MANIFEST.in : modifications to consider vtk directory and new python
265 files for compilation
267 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
268 * Added python wrappers of vtkGdcmReader vtk class (see the
269 source in vtk/vtkGdcmReader.cxx) :
270 - vtk/Makefile.am now builds a library
271 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
272 python library (as opposed to _gdcm.so wich are the python
273 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
274 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
276 - configure.in has an additional flag --enable-vtk that needs
277 to be set to enable compilation of vtk related code, that is:
278 + vtk/vtkGdcmReader.so and
279 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
280 + gdcmPython/vtkgdcmPython.so (see above)
281 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
282 be read when compressed or when HighBit + 1 != BitsStored),
283 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
284 the usage of the python wrapper of vtkGdcmReader vtk class.
285 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
286 * src/*.[h] all occurences of stl classes are now prefixed with
287 std::, and all occurences of "using namespace std;" where removed.
288 This is to avoid pollution of global namespace in included files.
289 Apparently vtk does not avoid this pitfall: when using both
290 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
291 collision of various stl members (principally cout...).
292 * gdcmPython/testSuite.py now cleanly removes temprory generated
294 * gdcmPython/gdcm.i now declares a typemap for std::string (to
295 comply with above changes)
297 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
298 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
299 * vtk/vtkGdcmReader.cxx now properly inports the image in the
300 vtk data structure (an image Flip was required).
301 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
302 * cosmetic changes in documentation.
304 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
305 * src/gdcmHeader.cxx: the constructor no longer exits when an
306 unexisting file is given as argument.
307 * The subdirectory Data (containing all the images used for the
308 test suite) is not part of this repository anymore. A new module
309 containing those images is now available at
310 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
311 with the name gdcmData.
312 All the python scripts (including the package initialisation file
313 gdcmPython/__init__.py) were adapated to take this change into
314 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
316 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
317 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
318 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
319 demo of the usage of this class.
320 Compilation of this vtk part is only done when using the --enable-vtk
321 at configure (or autogen.sh) stage.
323 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
324 * More memmory link related corrections and documentation fixes.
326 - maximum info is obtained with a command of the form:
327 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
328 --show-reachable=yes PrintHeader
329 - the remaining reachable blocks seem to come from the STL
330 allocation scheme through the usage of map and list. It looks
331 like this memory cannot be freed but it is not a memory leak
332 (in fact further invocation to the STL would recollect the
333 unused memory allthough it cannot explicitely be freed).
334 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
335 of displaying an image parsed with gdcm and displayed with VTK.
336 Note: some images don't seem to work e.g.
337 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
338 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
339 Allthough this weakens the semantics, it is a ditch attempt to
340 make gdcm more thread friendly.
342 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
343 * Memory link hunt (by using valgrind through the command
344 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
345 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
346 gdcmHeader::_dicom_vr.
347 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
348 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
350 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
352 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
353 * src/Makefile.am now exports all the necessary include files at
357 * UpdateGroupLength replaced by new one
360 * UpdateGroupLength re-written using H-Table
361 (named UpdateGroupLengthNew untill checks are over)
363 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
364 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
365 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
367 - gdcmHeader::GetPubElValSet removed.
368 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
369 UpdateGroupLength, WriteElements, Write.
370 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
371 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
372 carried the same semantics.
373 - src/gdcmHeaderIdo.cxx changed accordingly.
374 - gdcmFile::WriteBase now regroups all the codes from previous
375 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
376 - enum FileType moved to gdcmCommon.h
377 * src/gdcmHeader.cxx AddDefault trashed
379 * getimageDataSize now calls gdcmGetXSize
380 * Test/*.cxx changed to agree with above changes
382 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * src/gdcmHeader.h: LoadElements() is not a public method anymore
384 (to avoid double call by end user).
385 * Test/*.cxx LoadElements() doesn't need to be called explicitely
386 by end user, since gdcmHeader::gdcmHeader now handles it.
388 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * gdcm/Doc many doxygen changes:
390 - Doxyfile now has two different versions, DoxyfileUsers that generates
391 the html.users end users oriented documentation and
392 DoxyfileDeveloppers that generates the html.developper developper
393 oriented documentation.
394 - README changed accordingly
395 - requirement.txt removed (old design info moved to TODO).
396 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
397 DoxyMainPage.txt, DoxyPython.txt provide more information.
398 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
399 be updated by simply regenerating the docs with doxygen and copying
400 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
401 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
402 all the tests in the form "if (<map>.count() >1)" were removed.
403 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
404 ill-formed documentation sections.
405 * src/gdcmHeader.cxx: ditto
407 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
408 * setup.py fixed for un*x (needed macro for stdint.h)
409 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
410 un*ces with sh-utils test utility.
411 * gdcmPython/demo/test.py renamed to PrintHeader.py
412 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
413 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
414 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
415 * src/gdcm*.cxx JPR's bad inclusion fixed.
417 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
419 * gdcmPython/demo/test.py changed accordingly.
421 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * gdcmPython/Makefile.am fixed linking against libstdc++
423 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
424 * Swig subdir (historical tests of swig version 1.3.17++) removed
425 * Test/testChangeEntete.cxx some lines commented out in order to make
427 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
428 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
430 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
432 hence the user doesn't need this explicit call.
433 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
434 i.e. LoadElements() call removed.
435 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
436 - src/Makefile.am declares the proper flag for g++.
437 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
438 for adding user defined new tags.
439 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
440 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
441 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
443 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
444 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
445 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
446 src/Makefile.am : the project should properly compile and install
447 with the autotools, included the python wrappers part.
448 * gdcm.spec.in : added a spec file for RPM packaging.
450 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
451 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
453 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
455 to exported to the environement (see gdcmPython/testSuite.py
457 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
458 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
459 ElValue class renamed to gdcmElValue for obvious consistency reasons.
460 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
461 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
463 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * gdcmPython/__init__.py doesn't crash anymore when running in
465 in InstallMode or PreInstallMode but with an environement given
466 value of GDCM_DICT_PATH.
467 * src/gdcmDictSet.[cxx/h] coding style.
469 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
471 * src/gdcm.h general comments moved to TODO, and README
472 * src/gdcm.h should now be seen as a user commodity (including it
473 should suffice to fully use gdcm). It is nowhere including within
474 any of the kernel files src/*.cxx and src/*.h.
476 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
478 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
480 * src/gdcm*.cxx only include their corresponding include file
481 (as opposed to gdcm.h)
482 * gdcmPython/gdcm.i changed accordingly
483 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
484 the autogen.sh generated "make snapshot" command to work.
485 * autogen.sh removed history related references to crea package.
487 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * distutilsSwigCPlusPlus.py work around some swig portability
491 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * Eventually, python/gdcmPython was renamed to gdcmPython. This
493 was done in a last ditch attempt to get setup.py _really_
494 operationnal. The python/gdcmPython layaout add the advantage
495 of hidding away the python related distutils specific files
496 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
497 Alas, the src directory was out of scope (i.e. it's relative
498 position to setup.py was ../src) which made things impossible to
499 handle (see previous version of python/setup.py). Crossing fingers...
501 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * python/setup.py now works on Un*x. (harder than I thougth)
503 * python/distutilsSwigCPlusPlus.py can now have include files
504 among the list of sources.
506 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
508 * modifications in MSVC projects
510 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
511 * As stated by the first lines of Test/ExceptionAndPython/README, it
512 looks like we can move back to original usage of exception within
513 src/gdcm* and hence remove the errno stuff that was introduced
514 as a quick and dirty fixture of this problem (added to the TODO).
515 * Doc/Doxyfile configuration file for Doxygen and corresponding
516 README file for usage added.
517 * Test/testWrite.cxx added. This new test comes from a split of
518 test.cxx that is now reverted to its original purpous i.e.
519 testing the proper parsing of a Dicom related file.
520 testWrite.cxx concentrates on testing the IO part of gdcm.
521 * Test/bug1.cxx (containing a bug on WIn32) added.
522 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
523 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
524 whose purpose is to publish the content of the TagNames of the
525 Dicom public dictionnary were not accessible without an
526 instance of class gdcmHeader.
527 - those methods are now static methods of gdcmDictSet and hence
528 require no instances at all to be invocated.
529 - within gdcmDictSet this change required to change some method
530 to class methods (i.e. are now static) among which SetDictPath
531 (renamed to BuildDictPath) and LoadDefaultPubDict.
532 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
533 the above changes by calling the new method classes of gdcmDictSet.
534 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
535 the above to be effective.
536 * python/gdcmPython: in order to wrap properly the above changes
537 for Python, swig version now needs to be > 1.3.17.
538 * python/gdcmPython/Makefile fixed to adapt itself to new
539 configure/make shema introduced by Johan Montagnat (thanks for the
540 contribution). Alas this Makefile cannot be turned into a proper
541 Makefile.am without some heavy changes in the configure.in
542 (for python dectection).
543 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
544 now avoids publishing the empty entries.
546 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
547 * python/setup.py : bug fix concerning install under windows
549 * gdcm.dsw : bug fix concerning path for libraries for python !!!
551 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
552 * Dicts/dicomV3.dic : remove double spaces !!!
553 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
554 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
557 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
559 method. Doxygenation.
560 * src/gdcm.h clean up of JPR spurious comments.
562 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * python/distutilsSwigCPlusPlus.py now properly collects the
564 shadow classes generated by "swig -c++" (gdcm.py in our case)
565 when using "python setup.py install".
566 * python/gdcmPython/__init__.py imports gdcm.py and only manually
567 reexports the working classes.
568 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
569 by the classical C errno scheme. This is to prevent an obscure
570 behavior of the python wrappers when importing wxPython.wx prior
571 to gdcmPython (which ended up in an abort call). An illustration
572 of this oddity can be found in the Test/ExceptionAndPython
573 subdir (see the README file). This problem probably due to
574 an combination of g++ and dynamic loading.
575 * added Test/ExceptionAndPython (see above)
577 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * Changed the layout of the python part to avoid bloating main
579 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
580 i.e. the distutils arsenal. All the python related stuff is
581 again in a python subdir, but the package itself is now in
583 * setup.py was cleaned up:
584 - pythonIncludePath removed
585 - python setup.py bdist target is now functional.
586 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
587 collision with other packages). gdcmPython/demo/*.py changed
590 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * python subdir moved to gdcmPython (preparation of distutils packaging).
592 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
593 distutils installer is operational.
594 * - gdcmPython/__init__.py now properly loads the swig generated
595 shadow classes (from gdcm.py).
596 - gdcmPython/demo/*.py changed to import the package gdcmPython
597 instead of gdcmPython/demo/load.py.
598 - gdcmPython/testSuite.py changed to import the package gdcmPython.
600 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
602 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
603 entries within the associated public Dicom dictionary resp. the same
604 information but sorted by the fourth field (PAT, IMG, DIR) of the
606 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
607 are now in the "???" group.
608 - python/gdcm.i changed accordingly,
609 - python/demo/printGroupedPublicDict.py added, that gives an example
610 of the above new functionalities in Python.
612 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * src/gdcm.h, gdcmHeader.cxx:
614 - historic references to glib's g_malloc and g_free (#defined)
615 were definitively removed.
616 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
617 * src/gdcmElValSet.cxx:
618 - GetElement(guint32, guint32) renamed to GetElementByNumber.
619 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
620 - GetElValue(string) renamed to GetElValueByName.
621 - Added GetElementByName(string).
622 * src/gdcmHeader.cxx: added
623 - GetPubElValRepByNumber(guint16, guint16)
624 - GetPubElValRepByName(string)
625 - GetShaElValRepByNumber(guint16, guint16)
626 - GetShaElValRepByName(string)
627 - GetShaElValByNumber(guint16, guint16)
628 - GetShaElValRepByName(string)
629 - GetElValRepByNumber(guint16, guint16)
630 - GetElValRepByName(string)
631 - GetElValByNumber(guint16, guint16)
632 - GetElValRepByName(string)
633 * Doc/requirements.txt added.
635 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
636 * Test/Makefile building now depends on the one of libgdcm.so
637 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
638 pixel data) aware which enables finding the address (offset) of
639 the pixel data of JPEG encoded DICOM files. This leaves only a single
640 file in the testSuite whose pixel data address (offset) is unknown.
641 * python/testSuite.py changed accordingly.
643 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
644 * VC++ has some strong limitations when working with the STL, as stated
645 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
646 "Also note that some STL containers (map, set, queue, list, deque)
647 cannot be exported. [...]
648 Some STL classes contain nested classes. These classes can not
650 This is caused by a designed limitation that once a template
651 class is instantiated, it can not be re-instantiated and
653 Since our usage of map<> is ubiquitous in gdcm, this "designed
654 limitation" of VC++ is a pitfall.
655 Hence the Python wrappers of gdcm cannot be incrementally linked
656 against the c++ dynamic library. The dirty but only workaround is
657 to forget about incremental link of dynamic libraries and to generate
658 the Python wrappers library with the inclusions of the underlying C++
660 The following modifications concern this matter on Win32/VC++:
661 - wrapping python correct with standalone wrapped dll (don't use separate
662 dll under windows !!!!)
663 - python21_d debug mode enabled (ask Frog how to use it :-)
664 - NO problem with having an STL member of class for example string in C++
665 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
666 - Python test of dcmlib in Python is ok under windows on a large set
668 * removed glib references
669 * typedef's inserted in gdcm.i for correct swig type management
671 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * python/demo/*.py load.py extracted from test.py. Added explore.py
673 that only displays required tags and testAll.py that parses all
674 the files of the testsuite without using unittest.
675 * python/testSuite.py other additional test on new files added.
676 * Data/* new test files added accordingly to the testSuite.
677 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
678 the vr in the file differs from the one of the dictionary.
680 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
682 values, but limits itself to values which are below a user specified
683 size (by default 1024 bytes).
684 * python/gdcm.i : elements not loaded (because their size is above the
685 user specified treshold) are exported with their TagKey as key of the
686 python dictionary. This enables the testsuite to make some checks
687 on the unloaded elements (since we have their offset and size).
688 * python/testSuite.py
689 - now tests for the existence and proper value of the pixel data
690 - two new examples added.
691 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
693 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
695 aware. See the strategy comments in gdcmHeader::FindeLength().
696 * Test/test.cxx now accepts a filename as first argument.
697 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
698 * python/testSuite.py changed to integrate test on above files.
700 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * Dicts/dicomV3.dic removed all the trailing (RET) when the
703 * python/testSuite.py more tests added.
705 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * python/testSuite.py unittest test suite added (uses Data)
707 * Data/* dcm and acr files for the test suite.
708 * glib dependance removed from un*x version. We now use ISO C99
709 7.18 Integer types (see stdint.h)
710 - python/Makefile, src/Makefile src/gdcm.h
711 * src/ when an explicit vr (like dicom files) suddenly poped an
712 implicit element we use to mark the underlying DictEntry of the
713 concerned ElValue with "Implicit". This strategy was damageable
714 too the public or provite dictionaries, since some of their vr
715 would be changed. Since Header::FindLength heavily relies on the
716 detection by Header::FindVR of falsely explicit elements, I
717 added an extra ImplicitVr member to ElValue (boolean).
718 The rest of the changes we the necessary adaptations.
720 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
723 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
725 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * Adaptation for porting to VC++:
728 o forced to use std namespace (for string to be known)
729 o all class use __declspec export style on WIN32
730 - src/gdcmUtil.cxx new Exit method that wraps the exit call
731 (in stdlib.h on Win32 but in std:: for gcc)
732 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
733 variable GDCM_DICT_PATH.
734 * src/gdcmHeader.cxx verbose comments made discrete.
736 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
737 * python/gdcm.i: added a typemap that converts a C++ hashing table
738 to native Python dictionary.
739 * python/demo/test.py:
740 - now uses the native dictionary for exploration of gdcmHeader.
741 - takes an optional filename argument (the file to parse).
742 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
743 PubElVals hashing table.
744 * Dicts/dicomV3.dic removed error prone trailing spaces.
746 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * Python wrapping process moved away from src/Makefile to
748 newly created python/Makefile (as well as gdcm.i)
749 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
750 * src/gdcmHeader::FindLength only looks for current vr when necessary.
751 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
752 from the environement variable GDCM_DICT_PATH (when existing).
753 * src/gdcmDict::GetTag bug fix.
755 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * Straightforward temporary fixes for swig to build the python wrappers.
757 src/Makefile now has a python working entry [by working we mean
758 that we can import de shadow classes without errors].
760 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * hashtest.cxx removed (since allready in Test)
762 * src/gdcmlib.h renamed to src/gdcm.h
763 * src/dcm.i renamed to src/gdcm.i
764 * src/Makefile prepared for python wrapping
766 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * src/gdcmHeader.cxx :
768 - Parsing of header is now separated from loading of element values
769 (see gdcmHeader::LoadElements).
770 - general clean up of hopefully all file access (creation of
771 ReadInt16 and ReadInt32)
773 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * src/gdcmHeader.cxx :
775 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
777 - SetLgrElem renamed to SetLength
778 - GetLgrElem renamed to GetLength
779 - ~gdcmHeader() made virtual to pesky warning messages at compile.
780 * src/gdcmElValSet.cxx fixed both GetElValue methods
781 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
782 due to IdoDude was cleaned out.
784 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
786 concentrates on finding the value representation (when it exists).
787 RecupLgr now only finds the element value length, and it avoids
788 returning the unecessary skL (skipped length).
789 Also, offsetCourant was simply removed (with taille_fich) since
790 it was redundant with the File position internals (by using
791 ftell and fseek). This also made skL (see above in RecupLgr) usage
793 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
794 on the libido specificities which are handled through class
796 * Test/implicit_vr.dcm dicom v3 in implicit value representation
799 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * Truckload of changes. Parsing of header is barely functional
801 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
803 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * src/gdcmHeader.cxx many addons of low level methods
806 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
807 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
810 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
811 * This corresponds to all the changes decided at the meeting of
812 May 23 2002. Needless to say we are running late...