1 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
3 char* to std::string. Thus, the use of strdup becoomes useless. (see
4 previous commis of Malaterre)
5 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
6 before the last Malaterre's commit.
8 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
9 * This commit should fix the Debug building under VC++, the problem
10 was mainly a mixture of debug and release lib being loaded at startup.
11 * I also remove a depency to a specific C function: strdup. Because I had
12 to force the link to msvcrtd (whereas strdup is in libc).
14 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
16 located in the gdcmCommon.h file. All use of reference of tha has been
17 changed to now use the variable GDCM_UNFOUND.
19 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
21 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
22 Dicom dictionary. The test suite can now be run again. Note:
23 I'm note very happy with the " (RET)" changes. I believe this
24 RETAINED comment should be dropped when parsing the dictionary.
27 - AUTHORS updated and now in alphabetical order
28 * Makefile.am now exports gdcm.dsw for Windoze users.
30 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
31 * cygwin complains about missing std:: in subdir Test/
33 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
34 * remove some methods that are now in gdcmHeaderHelper
36 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
37 * vtkGdcmReader set spacing and origin correctly
39 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
40 * Fix a few delete/delete[] mismatch
42 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
43 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
44 interpretation to data given by gdcmHeader. For instance there are
45 heuristics to get informations (look at different places).
46 * it also include a specific class: gdcmSerieHeaderHelper devoted to
47 sorting DICOM images based on different strategies.
48 * modified Makefiles accordingly.
50 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
51 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
52 when building in debug mode
53 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
55 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
57 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
58 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks to valgrind.
60 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * src/win32/libgdcmjpeg12.dsp was not dos format
62 * src/win32/libgdcmjpeg12.dsp : libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
63 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
65 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
68 * src/gdcmFile.cxx : bug fix in affectation type
69 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
70 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
71 * Modifs of MVSC projects to compile them. Not concerning 2 identic
72 symbols... futur problem ?
74 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 * src/win32/libgdcmijpeg12.dsp was missing
76 * modified gdcm.dsw accordingly
78 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
79 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
81 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
83 commit of JPR (before his hollidays to facilitate our work).
84 * setup.py : bug fix in code. Modifications made while the last commit
85 of JPR. The code hasn't been tested before the commit... it's so
86 useless to make that (for best programmer that is JPR) !!!
88 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
89 * tagged the current version as Version0_3 (i.e. version 0.3)
91 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
93 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
94 * *.dsp : modifications to use new libgdcmijpeg8 library
95 * setup.py : bug fix on VTKPATH variable
96 * PACKAGER : adding all concerning windows
98 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
99 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
101 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
102 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
103 test suite reported error.
104 * PACKAGER file added (describes what a packager must do when
105 packaging a new release).
106 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
107 * configure.in: upgraded version number to 0.3.0
108 * fixing build of rpm (through rpm -ta):
109 - Doc/Makefile.am exports proper doxygen files
110 - src/jpeg/libijg8/Makefile.am exports the include files.
112 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
114 * src/gdcmHeader.h : formatting code
116 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
118 We were obtaining error message from vtk. Now, creation of file list
119 is made in an internal list to prevent this problem.
120 Bug fix when output is empty.
121 Bug fix in update of progress value. Previous commit for this was a bad
123 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
125 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * src/gdcmHeader.h : added method to get the file name
127 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
128 files. Added method to remove all files on the input
129 Added FIXME comment concerning the bad parsing of header made by
130 ExecuteInformation method (in ExecuteData method)
132 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
134 when using make instal.
135 * src/gdcmFile.cxx : bug fix under Window after JPR commit
136 RQ : the JPR doesn't appear in the ChangeLog... normal for him
138 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * setup.py : adding include dir of jpeg lib to compile all sources
140 * */Win32/*.dsp : JPR fix for windows compilation
142 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
143 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
145 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
146 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
148 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
149 * setup.py is again effective on un*x (takes into account the
150 addon of the jpeg library)
151 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
152 * Doc/Doxy* updated (includes above enhancements)
153 * INSTALL now points to web documentation
155 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
156 * src/gdcmHeader.h doesn't make unnecessary reference to
158 * gdcmPython/Makefile.am now avoids calling the wrappers for the
160 * src/gdcm*.[cxx|h] :
161 - to allow compilation with gcc 3.x
162 -- clean up of STL usage (added explicit usage of std::)
163 -- small fixes on exceptions.
164 Note: linking not tested !
165 - clean of doxygen comments to avoid warnings at documentation
167 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
168 dependent convertion).
170 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
171 * Clean up of previous JPR garbage commit (not even commented in the
173 - Test/Makefile.am removed the reference to unexisting testTS.cxx
174 - moved all jpeg related files from src to src/jpeg/libijg8, with
175 addition/modification of Makefile.am and configure.in.
176 - the testSuite is still brain damage (not guilty).
178 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * WrapVTK.py : modifications to get correctly vtk source files to
181 * vtk/vtkGdcmReader.cxx : modification for an already existing name
182 (FileName -> Filename)
184 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * vtk/vtkGdcmReader.[cxx/h]:
186 - UpdateProgress method should now be effective
187 - removed the limitation on having only images loaded (as opposed
189 - when building a stack of images/volume, a lesser number of
190 gdcmHeader and gdcmFile instances should be used (hopefully
191 accelerating things).
192 - when building a stack of images/volumes, files which are not
193 loadable (wrong path-filename, wrong permissions on existing file,
194 or file not parsable by gdcm) are replaced with a black image
195 in the stack (for the caller to notice the problem).
197 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
200 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
202 between standard library (std) and vtk library (problems are found
203 under Windows... thanks Windows !)
205 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
206 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
208 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
210 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
211 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
213 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * When compiling with distutils (see setup.py) the C++ compiler is
215 called with different flags than the default ones (with automake).
216 In order to fix all those warning, I compiled gdcm with the command
217 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
218 and went for warning fixes:
219 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
220 up from unused variables.
221 - vtk/vtkGdcmReader.cxx: potential bug fix.
222 * src/gdcmHeader.h: Doxygen warning cleanup
224 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
226 - typemaps correction to take into account the systematic replacement
227 of "using namespace std" with std:: prefix e.g. std::list,
228 std::string... (cf changes of 2003-05-21).
229 - gdcmGlob global variable of type gdcmGlobal (defined in
230 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
231 exported to Python a as cvar.
232 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
233 and GetPubDictTagNamesByCategory() as a replacement for deprecated
234 gdcmDictSet.GetPubDictTagNames() and
235 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
237 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
238 with the above changes.
240 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * setup.py, manifest.in : bug fix under linux
243 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Modification of setup.py to compile vtk part too. Then, we have 2
245 wrappers which must work with same distutils. For that, we have a
246 generic distutils in distusiltsWrapping.py ; with :
247 - build_extWrap class to wrap generically all extensions,
248 - ExtensionWrap base class for all wrapping extension that contains
250 - Wrapper interface which wrap sources
251 + In WrapSwig.py we have extension and wrapper for Swig
252 + In WrapVTK.py we have extension and wrapper for VTK
253 * MANIFEST.in : modifications to consider vtk directory and new python
254 files for compilation
256 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
257 * Added python wrappers of vtkGdcmReader vtk class (see the
258 source in vtk/vtkGdcmReader.cxx) :
259 - vtk/Makefile.am now builds a library
260 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
261 python library (as opposed to _gdcm.so wich are the python
262 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
263 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
265 - configure.in has an additional flag --enable-vtk that needs
266 to be set to enable compilation of vtk related code, that is:
267 + vtk/vtkGdcmReader.so and
268 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
269 + gdcmPython/vtkgdcmPython.so (see above)
270 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
271 be read when compressed or when HighBit + 1 != BitsStored),
272 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
273 the usage of the python wrapper of vtkGdcmReader vtk class.
274 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
275 * src/*.[h] all occurences of stl classes are now prefixed with
276 std::, and all occurences of "using namespace std;" where removed.
277 This is to avoid pollution of global namespace in included files.
278 Apparently vtk does not avoid this pitfall: when using both
279 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
280 collision of various stl members (principally cout...).
281 * gdcmPython/testSuite.py now cleanly removes temprory generated
283 * gdcmPython/gdcm.i now declares a typemap for std::string (to
284 comply with above changes)
286 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
287 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
288 * vtk/vtkGdcmReader.cxx now properly inports the image in the
289 vtk data structure (an image Flip was required).
290 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
291 * cosmetic changes in documentation.
293 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
294 * src/gdcmHeader.cxx: the constructor no longer exits when an
295 unexisting file is given as argument.
296 * The subdirectory Data (containing all the images used for the
297 test suite) is not part of this repository anymore. A new module
298 containing those images is now available at
299 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
300 with the name gdcmData.
301 All the python scripts (including the package initialisation file
302 gdcmPython/__init__.py) were adapated to take this change into
303 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
305 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
306 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
307 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
308 demo of the usage of this class.
309 Compilation of this vtk part is only done when using the --enable-vtk
310 at configure (or autogen.sh) stage.
312 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
313 * More memmory link related corrections and documentation fixes.
315 - maximum info is obtained with a command of the form:
316 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
317 --show-reachable=yes PrintHeader
318 - the remaining reachable blocks seem to come from the STL
319 allocation scheme through the usage of map and list. It looks
320 like this memory cannot be freed but it is not a memory leak
321 (in fact further invocation to the STL would recollect the
322 unused memory allthough it cannot explicitely be freed).
323 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
324 of displaying an image parsed with gdcm and displayed with VTK.
325 Note: some images don't seem to work e.g.
326 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
327 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
328 Allthough this weakens the semantics, it is a ditch attempt to
329 make gdcm more thread friendly.
331 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
332 * Memory link hunt (by using valgrind through the command
333 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
334 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
335 gdcmHeader::_dicom_vr.
336 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
337 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
339 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
341 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
342 * src/Makefile.am now exports all the necessary include files at
346 * UpdateGroupLength replaced by new one
349 * UpdateGroupLength re-written using H-Table
350 (named UpdateGroupLengthNew untill checks are over)
352 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
353 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
354 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
356 - gdcmHeader::GetPubElValSet removed.
357 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
358 UpdateGroupLength, WriteElements, Write.
359 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
360 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
361 carried the same semantics.
362 - src/gdcmHeaderIdo.cxx changed accordingly.
363 - gdcmFile::WriteBase now regroups all the codes from previous
364 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
365 - enum FileType moved to gdcmCommon.h
366 * src/gdcmHeader.cxx AddDefault trashed
368 * getimageDataSize now calls gdcmGetXSize
369 * Test/*.cxx changed to agree with above changes
371 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
372 * src/gdcmHeader.h: LoadElements() is not a public method anymore
373 (to avoid double call by end user).
374 * Test/*.cxx LoadElements() doesn't need to be called explicitely
375 by end user, since gdcmHeader::gdcmHeader now handles it.
377 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * gdcm/Doc many doxygen changes:
379 - Doxyfile now has two different versions, DoxyfileUsers that generates
380 the html.users end users oriented documentation and
381 DoxyfileDeveloppers that generates the html.developper developper
382 oriented documentation.
383 - README changed accordingly
384 - requirement.txt removed (old design info moved to TODO).
385 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
386 DoxyMainPage.txt, DoxyPython.txt provide more information.
387 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
388 be updated by simply regenerating the docs with doxygen and copying
389 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
390 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
391 all the tests in the form "if (<map>.count() >1)" were removed.
392 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
393 ill-formed documentation sections.
394 * src/gdcmHeader.cxx: ditto
396 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * setup.py fixed for un*x (needed macro for stdint.h)
398 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
399 un*ces with sh-utils test utility.
400 * gdcmPython/demo/test.py renamed to PrintHeader.py
401 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
402 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
403 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
404 * src/gdcm*.cxx JPR's bad inclusion fixed.
406 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
408 * gdcmPython/demo/test.py changed accordingly.
410 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * gdcmPython/Makefile.am fixed linking against libstdc++
412 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
413 * Swig subdir (historical tests of swig version 1.3.17++) removed
414 * Test/testChangeEntete.cxx some lines commented out in order to make
416 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
417 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
419 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
420 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
421 hence the user doesn't need this explicit call.
422 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
423 i.e. LoadElements() call removed.
424 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
425 - src/Makefile.am declares the proper flag for g++.
426 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
427 for adding user defined new tags.
428 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
429 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
430 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
432 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
433 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
434 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
435 src/Makefile.am : the project should properly compile and install
436 with the autotools, included the python wrappers part.
437 * gdcm.spec.in : added a spec file for RPM packaging.
439 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
440 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
442 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
444 to exported to the environement (see gdcmPython/testSuite.py
446 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
447 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
448 ElValue class renamed to gdcmElValue for obvious consistency reasons.
449 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
450 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
452 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * gdcmPython/__init__.py doesn't crash anymore when running in
454 in InstallMode or PreInstallMode but with an environement given
455 value of GDCM_DICT_PATH.
456 * src/gdcmDictSet.[cxx/h] coding style.
458 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
460 * src/gdcm.h general comments moved to TODO, and README
461 * src/gdcm.h should now be seen as a user commodity (including it
462 should suffice to fully use gdcm). It is nowhere including within
463 any of the kernel files src/*.cxx and src/*.h.
465 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
467 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
469 * src/gdcm*.cxx only include their corresponding include file
470 (as opposed to gdcm.h)
471 * gdcmPython/gdcm.i changed accordingly
472 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
473 the autogen.sh generated "make snapshot" command to work.
474 * autogen.sh removed history related references to crea package.
476 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
477 * distutilsSwigCPlusPlus.py work around some swig portability
480 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * Eventually, python/gdcmPython was renamed to gdcmPython. This
482 was done in a last ditch attempt to get setup.py _really_
483 operationnal. The python/gdcmPython layaout add the advantage
484 of hidding away the python related distutils specific files
485 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
486 Alas, the src directory was out of scope (i.e. it's relative
487 position to setup.py was ../src) which made things impossible to
488 handle (see previous version of python/setup.py). Crossing fingers...
490 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
491 * python/setup.py now works on Un*x. (harder than I thougth)
492 * python/distutilsSwigCPlusPlus.py can now have include files
493 among the list of sources.
495 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
496 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
497 * modifications in MSVC projects
499 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * As stated by the first lines of Test/ExceptionAndPython/README, it
501 looks like we can move back to original usage of exception within
502 src/gdcm* and hence remove the errno stuff that was introduced
503 as a quick and dirty fixture of this problem (added to the TODO).
504 * Doc/Doxyfile configuration file for Doxygen and corresponding
505 README file for usage added.
506 * Test/testWrite.cxx added. This new test comes from a split of
507 test.cxx that is now reverted to its original purpous i.e.
508 testing the proper parsing of a Dicom related file.
509 testWrite.cxx concentrates on testing the IO part of gdcm.
510 * Test/bug1.cxx (containing a bug on WIn32) added.
511 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
512 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
513 whose purpose is to publish the content of the TagNames of the
514 Dicom public dictionnary were not accessible without an
515 instance of class gdcmHeader.
516 - those methods are now static methods of gdcmDictSet and hence
517 require no instances at all to be invocated.
518 - within gdcmDictSet this change required to change some method
519 to class methods (i.e. are now static) among which SetDictPath
520 (renamed to BuildDictPath) and LoadDefaultPubDict.
521 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
522 the above changes by calling the new method classes of gdcmDictSet.
523 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
524 the above to be effective.
525 * python/gdcmPython: in order to wrap properly the above changes
526 for Python, swig version now needs to be > 1.3.17.
527 * python/gdcmPython/Makefile fixed to adapt itself to new
528 configure/make shema introduced by Johan Montagnat (thanks for the
529 contribution). Alas this Makefile cannot be turned into a proper
530 Makefile.am without some heavy changes in the configure.in
531 (for python dectection).
532 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
533 now avoids publishing the empty entries.
535 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * python/setup.py : bug fix concerning install under windows
538 * gdcm.dsw : bug fix concerning path for libraries for python !!!
540 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
541 * Dicts/dicomV3.dic : remove double spaces !!!
542 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
543 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
546 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
548 method. Doxygenation.
549 * src/gdcm.h clean up of JPR spurious comments.
551 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * python/distutilsSwigCPlusPlus.py now properly collects the
553 shadow classes generated by "swig -c++" (gdcm.py in our case)
554 when using "python setup.py install".
555 * python/gdcmPython/__init__.py imports gdcm.py and only manually
556 reexports the working classes.
557 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
558 by the classical C errno scheme. This is to prevent an obscure
559 behavior of the python wrappers when importing wxPython.wx prior
560 to gdcmPython (which ended up in an abort call). An illustration
561 of this oddity can be found in the Test/ExceptionAndPython
562 subdir (see the README file). This problem probably due to
563 an combination of g++ and dynamic loading.
564 * added Test/ExceptionAndPython (see above)
566 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
567 * Changed the layout of the python part to avoid bloating main
568 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
569 i.e. the distutils arsenal. All the python related stuff is
570 again in a python subdir, but the package itself is now in
572 * setup.py was cleaned up:
573 - pythonIncludePath removed
574 - python setup.py bdist target is now functional.
575 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
576 collision with other packages). gdcmPython/demo/*.py changed
579 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * python subdir moved to gdcmPython (preparation of distutils packaging).
581 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
582 distutils installer is operational.
583 * - gdcmPython/__init__.py now properly loads the swig generated
584 shadow classes (from gdcm.py).
585 - gdcmPython/demo/*.py changed to import the package gdcmPython
586 instead of gdcmPython/demo/load.py.
587 - gdcmPython/testSuite.py changed to import the package gdcmPython.
589 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
590 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
591 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
592 entries within the associated public Dicom dictionary resp. the same
593 information but sorted by the fourth field (PAT, IMG, DIR) of the
595 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
596 are now in the "???" group.
597 - python/gdcm.i changed accordingly,
598 - python/demo/printGroupedPublicDict.py added, that gives an example
599 of the above new functionalities in Python.
601 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * src/gdcm.h, gdcmHeader.cxx:
603 - historic references to glib's g_malloc and g_free (#defined)
604 were definitively removed.
605 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
606 * src/gdcmElValSet.cxx:
607 - GetElement(guint32, guint32) renamed to GetElementByNumber.
608 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
609 - GetElValue(string) renamed to GetElValueByName.
610 - Added GetElementByName(string).
611 * src/gdcmHeader.cxx: added
612 - GetPubElValRepByNumber(guint16, guint16)
613 - GetPubElValRepByName(string)
614 - GetShaElValRepByNumber(guint16, guint16)
615 - GetShaElValRepByName(string)
616 - GetShaElValByNumber(guint16, guint16)
617 - GetShaElValRepByName(string)
618 - GetElValRepByNumber(guint16, guint16)
619 - GetElValRepByName(string)
620 - GetElValByNumber(guint16, guint16)
621 - GetElValRepByName(string)
622 * Doc/requirements.txt added.
624 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * Test/Makefile building now depends on the one of libgdcm.so
626 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
627 pixel data) aware which enables finding the address (offset) of
628 the pixel data of JPEG encoded DICOM files. This leaves only a single
629 file in the testSuite whose pixel data address (offset) is unknown.
630 * python/testSuite.py changed accordingly.
632 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
633 * VC++ has some strong limitations when working with the STL, as stated
634 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
635 "Also note that some STL containers (map, set, queue, list, deque)
636 cannot be exported. [...]
637 Some STL classes contain nested classes. These classes can not
639 This is caused by a designed limitation that once a template
640 class is instantiated, it can not be re-instantiated and
642 Since our usage of map<> is ubiquitous in gdcm, this "designed
643 limitation" of VC++ is a pitfall.
644 Hence the Python wrappers of gdcm cannot be incrementally linked
645 against the c++ dynamic library. The dirty but only workaround is
646 to forget about incremental link of dynamic libraries and to generate
647 the Python wrappers library with the inclusions of the underlying C++
649 The following modifications concern this matter on Win32/VC++:
650 - wrapping python correct with standalone wrapped dll (don't use separate
651 dll under windows !!!!)
652 - python21_d debug mode enabled (ask Frog how to use it :-)
653 - NO problem with having an STL member of class for example string in C++
654 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
655 - Python test of dcmlib in Python is ok under windows on a large set
657 * removed glib references
658 * typedef's inserted in gdcm.i for correct swig type management
660 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * python/demo/*.py load.py extracted from test.py. Added explore.py
662 that only displays required tags and testAll.py that parses all
663 the files of the testsuite without using unittest.
664 * python/testSuite.py other additional test on new files added.
665 * Data/* new test files added accordingly to the testSuite.
666 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
667 the vr in the file differs from the one of the dictionary.
669 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
671 values, but limits itself to values which are below a user specified
672 size (by default 1024 bytes).
673 * python/gdcm.i : elements not loaded (because their size is above the
674 user specified treshold) are exported with their TagKey as key of the
675 python dictionary. This enables the testsuite to make some checks
676 on the unloaded elements (since we have their offset and size).
677 * python/testSuite.py
678 - now tests for the existence and proper value of the pixel data
679 - two new examples added.
680 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
682 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
684 aware. See the strategy comments in gdcmHeader::FindeLength().
685 * Test/test.cxx now accepts a filename as first argument.
686 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
687 * python/testSuite.py changed to integrate test on above files.
689 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * Dicts/dicomV3.dic removed all the trailing (RET) when the
692 * python/testSuite.py more tests added.
694 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
695 * python/testSuite.py unittest test suite added (uses Data)
696 * Data/* dcm and acr files for the test suite.
697 * glib dependance removed from un*x version. We now use ISO C99
698 7.18 Integer types (see stdint.h)
699 - python/Makefile, src/Makefile src/gdcm.h
700 * src/ when an explicit vr (like dicom files) suddenly poped an
701 implicit element we use to mark the underlying DictEntry of the
702 concerned ElValue with "Implicit". This strategy was damageable
703 too the public or provite dictionaries, since some of their vr
704 would be changed. Since Header::FindLength heavily relies on the
705 detection by Header::FindVR of falsely explicit elements, I
706 added an extra ImplicitVr member to ElValue (boolean).
707 The rest of the changes we the necessary adaptations.
709 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
712 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
714 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
715 * Adaptation for porting to VC++:
717 o forced to use std namespace (for string to be known)
718 o all class use __declspec export style on WIN32
719 - src/gdcmUtil.cxx new Exit method that wraps the exit call
720 (in stdlib.h on Win32 but in std:: for gcc)
721 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
722 variable GDCM_DICT_PATH.
723 * src/gdcmHeader.cxx verbose comments made discrete.
725 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * python/gdcm.i: added a typemap that converts a C++ hashing table
727 to native Python dictionary.
728 * python/demo/test.py:
729 - now uses the native dictionary for exploration of gdcmHeader.
730 - takes an optional filename argument (the file to parse).
731 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
732 PubElVals hashing table.
733 * Dicts/dicomV3.dic removed error prone trailing spaces.
735 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * Python wrapping process moved away from src/Makefile to
737 newly created python/Makefile (as well as gdcm.i)
738 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
739 * src/gdcmHeader::FindLength only looks for current vr when necessary.
740 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
741 from the environement variable GDCM_DICT_PATH (when existing).
742 * src/gdcmDict::GetTag bug fix.
744 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * Straightforward temporary fixes for swig to build the python wrappers.
746 src/Makefile now has a python working entry [by working we mean
747 that we can import de shadow classes without errors].
749 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * hashtest.cxx removed (since allready in Test)
751 * src/gdcmlib.h renamed to src/gdcm.h
752 * src/dcm.i renamed to src/gdcm.i
753 * src/Makefile prepared for python wrapping
755 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
756 * src/gdcmHeader.cxx :
757 - Parsing of header is now separated from loading of element values
758 (see gdcmHeader::LoadElements).
759 - general clean up of hopefully all file access (creation of
760 ReadInt16 and ReadInt32)
762 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
763 * src/gdcmHeader.cxx :
764 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
766 - SetLgrElem renamed to SetLength
767 - GetLgrElem renamed to GetLength
768 - ~gdcmHeader() made virtual to pesky warning messages at compile.
769 * src/gdcmElValSet.cxx fixed both GetElValue methods
770 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
771 due to IdoDude was cleaned out.
773 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
775 concentrates on finding the value representation (when it exists).
776 RecupLgr now only finds the element value length, and it avoids
777 returning the unecessary skL (skipped length).
778 Also, offsetCourant was simply removed (with taille_fich) since
779 it was redundant with the File position internals (by using
780 ftell and fseek). This also made skL (see above in RecupLgr) usage
782 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
783 on the libido specificities which are handled through class
785 * Test/implicit_vr.dcm dicom v3 in implicit value representation
788 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * Truckload of changes. Parsing of header is barely functional
790 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
792 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
793 * src/gdcmHeader.cxx many addons of low level methods
795 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
796 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
799 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
800 * This corresponds to all the changes decided at the meeting of
801 May 23 2002. Needless to say we are running late...