1 2004-07-27 Jean-Pierre Roux
2 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
3 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
5 2004-07-21 Jean-Pierre Roux
6 * FIX Now, Parsing and Printing a DICOMDIR do work!
7 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
9 2004-07-20 Jean-Pierre Roux
10 * FIX Some brain damaged headers have Zero-Lenght fields
11 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
13 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
15 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
16 variable (instance of gdcmDebug) by a definition macro, and the instance
17 is now in static in the gdcmDebug class
18 * src/gdcmSQItem.h : (FIXME) remove an undefined method
19 * Test/PrintAllDocument.cxx : bug fix in the result of the test
21 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
22 * WARNING: ctest now depends more tightly on gdcmData. You should
23 check out gdcmData properly for things to run smoothly...
24 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
25 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
26 we need the pixels not be loaded in order to use the ValEntry
27 that displays position and size).
28 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
29 This is a C++ based equivalent of gdcmPython/testSuite.py that should
30 be deprecated. If you have any doubts about the advantages of a
31 modern scripting language (read Python) versus grass root C++ (i.e.
32 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
33 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
34 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
35 Anyhow, consider documenting the gdcmData images in
36 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
38 * Test/CMakeLists.txt:
39 - now uses TestAllEntryVerify.cxx
40 - specific comments on oldACR00001.ima (now renamed in gdcmData
41 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
42 gdcmData/TestAllEntryVerifyReference.txt
45 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
46 * src/*.[h|cxx] : typedef clean up
47 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
48 - TagKey renamed to gdcmTagKey (for external usage)
49 - VRKey renamed to gdcmVRKey (for external usage)
50 - removal of typedef duplication.
51 - Removed all unecessary inline keyword from class inline definitions.
52 - Some method|function(void) declarations replaced with method|function().
53 * src/jpeg/libijg12/jdhuff12.c:
54 - printf polluting ctest removed.
55 - TAB removal for comminting
57 - TestAllReadCompareDicom.cxx: added a test that compares all the
58 images in gdcmDataImages.h with corresponding images in
59 gdcmData/BaselineDicom/. When baseline images are not present
60 this test creates them.
61 Note: we need to validate each reference image, but before that
62 I'd like to rename them with a more explicit name...
63 - CMakeLists.txt: changed accordingly.
64 * Example/*.cxx: examples now only include gdcm.h (as opposed to
65 including each header needed).
67 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
68 * Test/*.cxx and Example/*.cxx: moved some examples away from the
69 test suite to the Example directory. Are concerned:
75 * Test/CMakeLists.txt: added some comments on reasons for black listing
76 image gdcmData/oldACR00001.ima
78 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
79 * Test/CmakeList.txt: removed the following from black list (to be coherent
80 with removal from gdcmData):
81 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
82 - gdcm-MR-PHILIPS-16.dcm
84 Added the following because after last cvs update, they cause
85 ctest -R TestReadWriteReadCompare
87 - gdcm-MR-SIEMENS-16-1.acr
89 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
90 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
91 new comments in this file) we temporarily (sigh) move to a weaker
93 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
94 we don't need to black list the following images anymore:
95 - 8BitsUncompressedColor.dcm
97 - US-PAL-8-10x-echo.dcm
98 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
99 fixes and the beautified code ;-)
100 This fixes the bug introduced in version 1.42 (when beautifying)
101 that made the parsing of 8BitsRunLengthColor.dcm unproper.
102 Note: ctest was blind to this bug (this means we need to still
103 improve the test suite). The bug could be detected by using
104 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
106 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
107 and by displaying the (garbage) produced file temp.XDCM...
109 2004-06-29 Jean-Pierre Roux
110 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
111 - replace by uggly but working old code :-(
112 A lot of things should be OK again.
113 It's really urgent to have a test suite that *tests*,
114 to prevent Frog's beautifying sessions to break all the stuff
115 (twice, withing a fortnigh ...)
117 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
119 redundancy) to added Test/TestReadWriteReadCompare.cxx
120 * Test/CmakeList.txt: because the compare test of
121 Test/TestReadWriteReadCompare.cxx fails, the following images are
122 black listed: - 8BitsUncompressedColor.dcm
124 - US-PAL-8-10x-echo.dcm
125 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
126 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
127 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
128 and ad-hoc kludge. This kludge is now removed, and on encountering
129 such an image (OB field brain damaged) we set errno. Then in
130 ::FindDocLength() we "fix" the length as being ALL what remains
131 in the file (until EOF). We then proceed, hoping for the best...
132 This fixes a SegFault in ShowDicom when trying to write such an
134 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
135 (because TestWriteRead breaks on it, after a non conformal commit?).
136 ctest now runs properly, except for MakeDicomDir (which was allways
137 broken) and the Python related stuff (still not fixed).
139 2004-06-24 Jean-Pierre Roux
140 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
141 FIX : Test/TestReadWrite now iterates on all the file names
142 (instead of infinite loop)
143 ENH : Test/TestWriteRead now iterates on all the file names
145 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
148 2004-06-24 Jean-Pierre Roux
149 FIX : - now Write drops LUT Descriptors and LUTs (if any)
150 when SamplesPerPixel =3
151 - now Write is no longer confused by
152 'BitsAllocated = 12" and 'BitsStored=12"
153 - "UN" value representation Elements are now written correctly
154 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
155 ENH : - now gdcmHeader has its own Write methods
156 (in order to split the job that has not to be done
159 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
161 loop on the same image until memory went out.
162 Note: this means we still have gobs of memory loss in PrintDocument
163 * src/gdcmDocument.cxx: fixes problem on parsing on file
164 gdcmData/16BitsJpegLosslessGrayScale.dcm.
166 2004-06-24 Jean-Pierre Roux
167 FIX : Write - All the Sequences and Sequence Item are now written
168 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
169 is added a the end, when necessary.
170 - A lot of brain-damaged images, that were read correctly are
171 now written correctly
172 - length compatible BinEntry are now loaded correctly
173 (even for odd groups)
174 Note : only Explicit Value Representation was checked.
175 (question : is implicit VR really necessary for gdcm ?)
177 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
178 * DEVELOPPER: added a proposition of coding style.
179 * src/gdcmDocEntry.h: removed every inline declaration (for test of
182 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
184 Use the gdcmDocEntry::Print() and Write() instead.
185 * src/gdcmDocument.cxx: bug fix.
187 2004-06-22 Jean-Pierre Roux
188 FIX : gdcmDocument.cxx
189 - Now we do recognize the JpegLossLess format (there was a misstyping in
190 code 'beautyfication' :-(
191 - Now we automaticaticaly load the Luts, if any
193 2004-06-22 Jean-Pierre Roux
194 In order : to write Sequences, whatever their imbrication level,
195 : to allow user to create his own Sequences
196 a lot of modif where necessary (adding, moving, or virtualising methods)
198 WARNING : save your own sources *before* cvs up !
201 ADD virtual void Write(FILE *fp, FileType filetype);
204 ADD virtual void Write(FILE *fp, FileType filetype);
205 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
208 ADD virtual void Write (FILE *fp, FileType filetype)=0;
209 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
210 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
211 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
212 ADD std::string GetEntryByName(TagName name);
213 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
215 std::string vr = "unkn",
216 std::string fourth = "unkn",
217 std::string name = "unkn");
218 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
219 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
220 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
221 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
222 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
223 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
224 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
225 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
228 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
229 ADD virtual std::string GetEntryByName (TagName tagName);
230 ADD virtual std::string GetEntryVRByName (TagName tagName);
231 REM virtual bool Write(FILE *, FileType);
232 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
233 FILE *_fp, FileType type);
234 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
235 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
236 REM virtual bool WriteEntries(FILE *_fp,FileType type);
237 REM virtual std::string GetEntryByName (std::string tagName);
238 REM virtual std::string GetEntryVRByName (std::string tagName);
239 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
240 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
241 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
243 std::string vr = "unkn",
244 std::string fourth = "unkn",
245 std::string name = "unkn");
246 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
247 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
248 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
249 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
252 ADD virtual void Write(FILE *fp, FileType filetype);
255 ADD virtual void Write(FILE *fp,FileType filetype);
258 ADD virtual void Write(FILE *fp, FileType filetype);
259 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
260 REM std::string GetEntryByNumber(guint16 group, guint16 element);
261 REM std::string GetEntryByName(TagName name);
264 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
266 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
268 The default constructor invoked by the line
269 gdcmHeader *f1 = new gdcmHeader( header );
270 was gdcmHeader::gdcmHeader(bool) instead of the expected
271 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
272 Hence the parsing wasn't executed... See also below.
273 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
274 as explicit constructor didn't do the trick to fix the above problem.
275 Could anyone explain why ?
276 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
277 properly calls gdcmValEntry::Print() (that was weed out from
278 code related to gdcmBinEntry).
280 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
281 * In order to fix memory leaks:
282 - Test/TestWriteSimple.cxx: added cleaning of free store through
284 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
285 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
286 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
287 (through the call to ::AddDicomDirMeta()) or the destructor
288 would crash when deleting uninitialized ::metaElems].
289 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
290 - src/gdcmDocument.cxx:
291 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
293 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
294 was causing memory leaks.
295 - src/gdcmSQItem.cxx:
296 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
297 cleanly handled with polymophism: sorry but my milage is low).
298 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
299 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
300 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
301 This avoids SegFaulting.
302 - src/gdcmSQItem.h: coding style.
304 - Test/TestWriteSimple still severely sucks. The output image content
305 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
306 damaged when displayed with vtkgdcmViewer.
307 - on memory leaks: TestWriteSimple leaks really less (see entry
308 of 2004-06-18 in Changelog file for the call to valgrind).
309 - on segfaults: ctest now passes all the tests but one (no more
311 * Erroneous leading white fix:
312 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
313 white[s] (as opposed to from >> xxx, that removes it [them].
314 - src/gdcmTS.cxx: ditto.
315 - gdcmPython/testSuite.py: dirty related kludge removed.
316 * src/*: remaining references to gdcmParser removed.
317 * src/*[cxx|h]: added copy[way]left header.
320 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * In order to fix writing of dicom files:
322 - Test/TestWriteSimple.cxx: a simpler example of writing.
323 - Test/CMakeLists.txt changed accordingly.
324 - src/gdcmDocument.cxx:
325 -- The destructor now recursilvely removes potential sequences.
326 -- Bug fix in ::IsJPEG2000()
327 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
328 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
330 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
331 to only declared) and build on top of
332 ::GetDocEntryByNumber(guint16, guint16).
333 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
334 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
335 for usage in destructor and treatement of promotion in
336 ::ReplaceOrCreateByNumber().
337 - src/gdcmSQItem.cxx: destructor should better handle his job.
338 Test/TestWriteSimple now runs (or at least it DOES something).
339 * We can now start hutting memory links. A good starting point is:
340 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
341 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
342 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
344 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * Valgrind note: after Mathieu Malaterre teached me how to read
346 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
348 Using gcc, you can force the STL to use malloc and to free memory as
349 soon as possible by globally disabling memory caching.
350 With 3.2.2 and later, you should export the environment variable
351 GLIBCPP_FORCE_NEW before running your program.
352 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
353 simply vanish (it is still not clear to me, whether this means that
354 STL std::string leaks or if valgrind believes it leaks...).
355 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
356 running bin/gdcmTests makeDicomDir):
357 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
358 - Test/makeDicomDir.cxx now properly traps empty lists and returns
360 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
361 SegFaulting (I drowned in DicomDir related code when trying to
362 understand why the list is empty...).
363 * src/gdcmDocument.h: first BSD license header try.
364 * Doc/License.txt added.
366 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * src/gdcmDocument.[h|cxx]:
368 - Clean up of the Transfer related predicates. They are now all based
369 on new method isGivenTransferSyntax, that (should) handle properly
371 - general clean up, simplification, and coding style.
372 - Specific clean up of Parse7FE0() (umproperly named actually).
373 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
375 2004-06-14 Jean-Pierre Roux
377 - fix the display of Sequence Delimitor (SQDepthLevel pb)
378 - fix the display of SQItem ordinal number
379 - add the GetSQItemByOrdinalNumber method
380 - remove some useless never written private methods
382 2004-06-14 Jean-Pierre Roux
384 - adding a constructor taking a gdcmDocEntry as an input param
385 - ReplaceOrCreateByNumber now returns :
386 a gdcmBinEntry * if a Binary (void *) value is passed as a param
387 a gdcmValEntry * if a string value is passed as a param
389 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
390 according to the param type (no longer sets a gdcmDocEntry)
391 - GetValEntryByNumber, GetBinEntryByNumber added
392 - NewValEntryByNumber and NewBinEntryByNumber added
394 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
396 - GetSQItemNumber and SetSQItemNumber added, to provide
397 a (relative) Item identier inside a given Sequence
398 \warning : some pb remaining around this number
400 - AddEntry now takes the Item Number as a param
402 - adding a constructor taking a gdcmDocEntry as an input param
404 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * Memory leak hunt with the following command:
406 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
407 --show-reachable=yes gdcmTests PrintDocument
408 It looks like many (all?) leaks are due to the STL (or a bad usage
409 of the STL. The lines producing the leaks now have a comment with
410 a "MEMORY LEAK" tag: you can retrieve them with
411 grep "MEMORY LEAK" src/*
412 Here are two typical examples which I can't help fixing:
417 char * test = "babo";
418 name = test; //// <--- valgrind detects 960 bytes lost in
419 //// call to std::string::operator=(char const*)
420 name.clear(); //// Doesn't help !
428 std::cout << "Type a bunch of characters followed by RETURN: ";
429 getline(std::cin, line); //// <--- valgrind dectects a loss
430 //// of 1320 bytes in call to
431 /// std::basic_istream<>& std::getline<>
437 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * src/gdcmHeader.[cxx|h]:
439 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
440 and related, moved away to gdcmDocument.
441 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
442 the corresponding protected accessors of inherited class
443 gdcmDocument, removed ! As a consequence gdcmFile had to be
444 declared friend of class gdcmDocument (see below).
445 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
446 - Clean up of undefined or unused methods.
447 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
448 account the changes to gdcmHeader.h).
449 * src/gdcmDocument.h:
450 - gdcmFile is now a friend class (in order to take into account the
451 changes to gdcmHeader.h).
452 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
453 (see changes to gdcmHeader.h).
454 - Accessors (reading on the form GetEntry*) are now public.
455 - Clean up of undefined or unused methods.
456 * src/gdcmDocument.cxx:
457 - adaptation to changes to gdcmDocument.h
458 - ::OpenFile now writes a verbose message when file cannot be opened.
459 - some std::string properly set to VRKey
460 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
461 references to gdcmDocument.
462 * Test/TestFindTags.cxx: changed accordingly to above changes.
463 * gdcmPython/testSuite.py: adapted to renaming of acr files in
464 cvs repository gdcmData.
466 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
468 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
469 conflicts with gdcmValEntry::voidArea.
470 * src/gdcmValEntry.cxx: unmatching comment wiped out.
471 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
472 Value representation between StringRepresentable and BinaryRepresentable.
473 * src/gdcmDocument.cxx:
474 - method ParseDES: proper indentation restored and usage of
475 gdcmVR::IsVROfGdcmStringRepresentable wired in.
476 - method LoadDocEntry: the fingerprint left in the SetValue() of
477 unloaded entries (length > MaxSizeLoadEntry) had curiously been
478 removed. Reverting to previous code segment with the proper
479 dynamic_cast< gdcmValEntry* >.
480 Note: this was (partially) breaking the python test suite
481 (gdcmPython/testSuite.py) that made usage of the above
482 fingerprint to check presence of "Pixel Data".
483 * src/gdcmDocEntry.h: coding style.
484 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
485 now taken into account.
486 * gdcmPython/gdcm.i: adaptation to the new internal representation
487 of gdcm (exit gdcmParser, hello gdcmDocument).
488 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
490 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
491 anymore, but instead prints the loaded Python dictionary.
492 * .... alas, the python testSuite is still broken.
494 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
495 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
497 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
498 * src/gdcmUtil.h : export methods
500 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
503 * Initial addition of automatic python testing
504 * Initial addition of automatic image comparison
506 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
507 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
508 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
510 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
511 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
512 * Test/ShowDicom.cxx : bug fix for msvc compilation
513 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
515 2004-05-04 Jean-Pierre Roux
516 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
517 new concepts (and new classes) :
518 a 'gdcmDocument' is composed of a set of Doc Entries, that are
519 - elementary gdcmDocEntries (former gdcmHeaderEntries)
520 - Sequence Doc Entries (gdcmSeqEntries)
521 a Sequence is composed of Items.
522 Each item is a set of Doc Entries (this is recursive)
523 The non uniqueness of the 'Dicom tag' is due to this recursivity
524 (never taken into account)
525 Our unability to add a new 'entry' in the header
526 at the proper location (neither in the H-Table (map or multimap),
527 nor in the Chained List is also due to this recursivity.
528 Don't try, right now, to use/modify/compile these new sources :
530 We just commit all the stuff, 'as is', in order not to loose it.
532 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
533 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
535 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
536 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
537 file prefix (SetFilePrefix)
539 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
540 * Add a new test: ShowDicom, for now this is just the c++ version of
541 checkRead.sh, later it will be able to compare the image read against a
543 * Replace the DEBUG on the stack with a global entry in cmake interface:
544 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
546 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * Add an example subdir, with a real example on how to read + write a
550 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
552 * Doc/CMakeLists.txt: the main page is now properly differentiated
553 between the developper and user version.
554 * Doc/doxygen.config.in: dropped search related obsolete flags
555 * src/gdcmParser.h, gdcmHeader.h: doxygenation
557 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * DEVELOPPER: added some helpfull comments for compile/test/install
561 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
562 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
563 src directory, now generated in the build dir.
564 2. Tests as mentionned smarter
566 4. Add a new method in gdcmDict that return the PubDict by name
567 this is interesting for 3rd party lib like ITK,
568 where we could set the institution name / patient name...
570 * ENH: 1. Now the test suite is working for real
571 2. All binaries are now output in the gdcm-bin directory
572 (this was not true before)
574 2004-04-28 Jean-Pierre Roux
575 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
576 SeQuence indented printing of Dicom Header.
577 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
578 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
579 Computation of SQDepthLevel is now part of gdcmHeader constructor
580 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
581 tree-like structure of a Dicom Header.
582 * FIX Test code cleaning
584 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
585 * ENH: Adding automatic testing
586 1. Need a DartConfig.cmake to submit to public
587 2. Add a test driver gdcmTest.cxx
588 3. gdcmTestMain, an helper for the main test driver gdcmTest
589 4. Files in Test don't have a main anymore, this becomes interesting
590 when we add more and more tests, thus dsw don't have to load
592 * ENH: Adding a GDCM_DATA_ROOT for testing
593 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
594 one file instead of seven + some small cleanup
596 2004-04-22 Jean-Pierre Roux
597 * ENH Minor changes to the Print() methods.
598 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
599 Header printing. Example given with :
600 > PrintHeader fileName 2 new
601 (SQ based tree-like structure still to be done for the Header ...)
603 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
604 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
605 1. I have added some unsigned where needed
606 2. Some function parameter not used -> (void)
607 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
608 4. g++ don't like character '\' in comment
609 5. #define jpeg_create_decompress jCreaDecompress
610 this really need to be fixed
611 6. virtualize destructor of gdcmObject ... leakage
612 7. sscanf(g->first.c_str(),"%x",&gr_bid);
613 this also really need to be fixed
614 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
615 remove compression file
616 (as we only do decompression, right ?)
617 * ENH: Change malloc/calloc/free with c++ equivalent
619 2004-04-21 Jean-Pierre Roux
620 * FIX gdcmHeaderHelper::GetXSpacing
621 when a single value is found (bug ?), xpacing is now
622 defaulted to yspacing
624 2004-04-19 Jean-Pierre Roux
625 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
626 * ENH add parameters :
627 bool exception_on_error = false,
628 bool enable_sequences = false,
629 bool ignore_shadow = false
630 to the gdcmFile constructors to be full gdcmParser compliant
631 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
632 to allow reading of PAPYRUS 3.0 files
634 2004-04-06 Jean-Pierre Roux
635 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
637 2004-04-02 Jean-Pierre Roux
638 * ADD : Test/checksequence.sh, for a general recap on SQ pb
639 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
640 for Philips spurious Tag fffe|0000 while rewritting Dicom files
642 2004-03-30 Jean-Pierre Roux
643 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
644 for ACR file, written out as DICOM files (hope so...)
646 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
648 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
649 moved to base class gdcmParser and only the specialisation is kept
651 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
652 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
653 already does the job.
654 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
655 (to be consistent with gdcmParser::WriteEntries).
657 2004-03-30 Benoit Regrain
658 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
659 upate of the object's instance. It's passed to 2 in the unfavorable
660 case : one in the ExecuteInformation, one in the ExecuteData
662 2004-03-29 Jean-Pierre Roux
663 * ENH : Check on file type to be written moved
664 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
665 * FIX : gdcmObject::ResetBoundaries now stops properly
666 when end-of-list is reached
667 : gdcmVersion modified (as Benoit Regrain asked)
669 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
671 * src/gdcmUtil.cxx: added forgotten iostream include.
672 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
673 equivalent to ExplicitVR in existing code).
675 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
677 now contains all the gdcmGlobal related code.
678 * minor coding style and doxygenation changes.
680 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
682 now contains all the Debug related code.
683 * minor clean-up of includes in src/*.cxx
684 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
685 CreateCleanString) removed.
686 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
687 * Doc/DoxyMainPageUser.txt added.
688 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
689 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
692 2004-03-24 Jean-Pierre Roux
693 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
695 2004-03-23 Jean-Pierre Roux
696 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
697 big endian made volumes
698 * ENH Now gdcmParser constructor and destructor are protected to forbid
699 end user to instanciate class gdcmParser
700 (only gdcmHeader and gdcmDicomDir are meaningfull)
702 2004-03-22 Benoit Regrain
703 * FIX : src/gdcmDicomDir.cxx : make windows compilable
704 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
705 gdcmSerie to gdcmDicomDirSerie
707 2004-03-19 Jean-Pierre Roux
708 * ENH Now the tree-like structure describing a DICOMDIR comming from
709 an already existing DICOMDIR file is consistent with
710 the home-made tree-like structure build ex-nihilo
711 or build from the files held (recursively) in a Directory
712 functions gdcmDicomDir::CheckBoundaries()
713 gdcmObject::SetBoundaries() added
715 2004-03-17 Jean-Pierre Roux
716 * REM (Eric Boix bug) : removal of meaningless
717 gdcmDicomDirImage::NewImage function.
718 * FIX now file names and directory name are written properly in the
720 * FIX now gdcmDicomDir constructor may be call without any trick
723 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
725 of gdcmDicomDirImage::NewImage as empty function.
727 2004-02-28 Jean-Pierre Roux
728 * ENH add gdcmDicomDir:NewPatient
729 add gdcmDicomDirPatient:NewStudy
730 add gdcmDicomDirStudy:NewSerie
731 add gdcmDicomDirSerie:NewImage
732 to allow making gdcDicomDir object.
733 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
734 (as opposite to the gdcmHeader chained list)
736 2004-02-11 Benoit Regrain
737 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
738 when using from python
740 2004-02-10 Benoit Regrain
741 * FIX : bug fix in the gdcmDirList for the recursivity in directories
742 * FIX : in gdcmDicomDir when the directory is empty
743 * ENH : add callback and methods to get the progression of dicomDir
746 2004-02-06 Jean-Pierre Roux
747 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
748 - GDCM_META added to gdcmDicomDirType
749 - class gdcmMeta created
750 * ENH : - A brief summary is now displayed at the beginning of
751 'testDicomDir' to help disaster magnitude estimation
752 * REM : Now useless Test/explDICOMDIR.cxx
754 2004-02-05 Benoit Regrain
755 * ENH : add methods in gdcmObject to get the hash table or the list of
757 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
758 * FIX : wrapping python for TagHeaderEntryHT
760 2004-02-04 Benoit Regrain
761 * FIX : even length for some strings when writting the dicom dir
762 * FIX : sort the images in the dicom dir
763 * FIX : Bug fix for python use of dicom dir
764 * ADD : a python demo
766 2004-02-04 Jean-Pierre Roux
767 * FIX : Final solution (?) for icone embedded images
768 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
769 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
770 add groups 6002, 6004, 6006, to allow 'clean' parsing of
771 gdcmData/gdcm-MR-SIEMENS-16.acr1
772 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
773 to make full checking easier
775 2004-02-04 Benoit Regrain
776 * FIX : WriteEntries : coding style & logic in parameters
777 * FIX : Set the elements to create the DicomDir in a dictionary file
779 2004-02-03 Benoit Regrain
780 * gdcmDirList : to parse a hard drive directory in recursive (or not)
781 * gdcmDicomDir : add the load of directory
782 * Bug fix and print add-on
784 2004-02-03 Jean-Pierre Roux
785 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
786 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
787 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
788 * FIX gdcmParser.cxx : 'group length' elements are now considered
789 as integers, even for shadow groups, when file is Implicit VR
791 2004-02-02 Jean-Pierre Roux
792 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
794 of the last synonym :-(
795 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
797 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
798 * FIX taking into account the possible 7fe0,0010 multiplicity
799 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
800 to allow removal of references to 7fe0,0010, to deal with
801 ACR-NEMA images, when 0028,0200 is meaningfull
803 2004-01-31 Jean-Pierre Roux
804 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
805 no longer writes 'Un' on disk
806 * FIX SQ elements with actual length are now dealt with corectly
807 * FIX gdcmFile::WriteBase make the difference, for color images, between
808 the length (for Palette expanded images)
809 and Raw Length (non expanded image + Palette)
810 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
811 (that broke Write). Replaced by UL.
812 Aware user will reload the field if he
813 thinks it's necesssary
815 2004-01-30 Jean-Pierre Roux
816 * gdcmParser::CheckSwap() now defaults the filetype to ACR
817 when 'dirty Acr' is found, to be compliant with the new
818 IsReadable() methods.
820 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
821 (no DOUBLE images in kosher DICOM,
822 but so usefull for people that miss them ;-)
824 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
825 DICOMDIR related utilities (not checked as Windoze compliant)
827 2004-01-28 Jean-Pierre Roux
828 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
830 2004-01-27 Jean-Pierre Roux
831 * gdcmParser constructor has a new boolean param,'ignore_shadow',
832 to allow skipping the shadow elements, to save memory space.
833 The TRUE value for this param has to be used
834 with a FALSE value for the 'enable_sequence' param.
835 ('public elements' may be embedded in 'shadow Sequences')
836 * gdcmHeader methods now deal with 'embedded icones images' in the header
837 (even when an 'icone image sequence' is announced by the
838 element (0x0088,0x0200), but there is NO icone at all ...
840 * gdcmHeader sometimes Image Location value doesn't follow
841 the supposed processor endianity (see gdcmData/cr172241.dcm).
844 * gdcmHeader add the method
845 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
846 to get *all* the Header Entries with the same tag.
847 GetHeaderEntrySameName is probabely *useless*
848 (no meaning : Name is *not* an identifier within the Dictionnary)
850 2004-01-26 Benoit Regrain
851 * Bug fix in the print of hexadecimal representations. Remove long fields
852 in the print and add a third level of print to print them
854 2004-01-23 Benoit Regrain
855 * Bug fix on field having a VR = 'UI'. Assume that is a string field
856 * Bug fix on test suite after remove the strip made on not string fields
857 * Split the IsReadable method between gdcmParser which test that the file
858 is dicom and gdcmHeader which test that it's an image file
860 2004-01-22 Benoit Regrain
861 * DicomDir : clean code, add methods, set variables in protected or private
862 * gdcmUtil : bug fix for the clean string method
864 2004-01-19 Benoit Regrain
865 * Add the use of shadow dictionaries
866 * bug fix and coding style
868 2004-01-19 Benoit Regrain
869 * src/gdcmFile.cxx : bug fix concerning the close of file
870 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
871 * Add the update of header entries using the shadow library
873 2004-01-19 Benoit Regrain
874 * removal of file gdcmHeader2.cxx
875 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
876 inheriting from gdcmParser. This split is to prepare the integration
878 * bug fix under python
880 2004-01-16 Jean-Pierre Roux
881 * REM removal of class gdcmHeaderEntrySet
882 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
883 * ADD add file gdcmHeader2.cxx
884 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
886 2004-01-15 Benoit Regrain
887 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
888 entries created while parsing the header. Thus, they will be destroyed
889 when the gdcmDictSet will be destroyed
890 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
893 2004-01-15 Benoit Regrain
894 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
895 made a fatal error because of the memory release at the end of program.
896 The problem was in vtkGdcmReader::ExecuteData where we were allocate
897 some memory and vtk seems to have some problems with that.
898 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
900 2004-01-14 Benoit Regrain
901 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
902 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
903 * src/*.[h|cxx] : make changes due to class name changes
904 * gdcmPython/demo/*.py : bug fix due to method names
906 2004-01-13 Benoit Regrain
907 * src/*.[h|cxx] : coding style
908 * vtk/*.[h|cxx] : coding style
910 2004-01-13 Benoit Regrain
911 * gdcmPython/testSuite.py : test the readable flag of file for tests
912 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
913 It's lied to the stl compilation by MSVC (windows, always windows...)
914 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
916 2004-01-12 Benoit Regrain
917 * src/*.h : add comments
918 * src/gdcmDictSet.h : set the method BuildDictPath in public
919 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
920 directly setted in the source code
921 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
924 2004-01-09 Benoit Regrain
925 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
926 * setup.py : use a reference to gdcmVERSION
928 2004-01-07 Benoit Regrain
929 * Modification to compile with the distutils.
932 2003-12-10 Benoit Regrain
933 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
934 can use a gdcmHeaderHelper to load datas
935 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
936 made in the source code
938 2003-12-10 Benoit Regrain
939 * Update Windows projects and .cvsignore files
941 2003-11-12 Jean-Pierre Roux
942 * ENH gdcmHeader constructor has one more parameter (default value : false)
943 that allows the user to 'go inside' the SeQuences only
945 gdcmElValSet:Print takes it into account
947 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
948 * ENH: Update gdcmPython/CMakeLists
949 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
950 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
952 2003-11-10 Jean-Pierre Roux
953 * FIX : gdcmHeader::LoadElements is now based
954 on the ListTag listElem member,
955 not longer on the TagElValueHT tagHt member
956 * ENH : PrintPubElVal shows (temporarily) both results,
957 with the tagHt member and the listElem member.
958 (it's easier to 'see' the problems when using Printheader)
960 * FIX : old private member LgrElem is now splitted into
961 ReadLength : Length actually found on disk (updated only
962 if bug fixing is necessary), for internal
964 UsableLength : Updated by FixFoundLength, to fix a bug
965 or to allow Parser going on.
966 Will allow to re-write a kosher header when a SeQuence
967 with a length (not 0000) is found
968 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
969 because gdcmElValSet::Add does not update ListElem
972 2003-11-07 Jean-Pierre Roux
973 * FIX misstyping in Transfert Syntax name table
974 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
975 when they have an actual length (not 0000 nor FFFFF)
976 (Nobody should care of it, but DICOMDIR explorers)
978 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
979 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
981 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
982 * ENH: vtkGdcmReader now supports LUT !
983 (vtkgdcmViewer for now is not able to use them though)
985 2003-11-05 Jean-Pierre Roux
986 * in testSuite.py : new files names for checking the package
987 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
988 that returns the pixel area size to the *aware* (vtk) user
989 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
991 2003-11-05 Benoit Regrain
992 * in testSuite.py : Modify the rules for checking the paths
993 : Explicit error messages
994 * in __init__.py : Related modif
996 2003-11-03 Jean-Pierre Roux
997 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
998 to be used by aware (vtk) users that want to manage
999 LUT (and no to turn the PALETTE image into an RGB pixels one)
1000 * GetPixelType now returns 8U for 24 Bits images
1001 (vtkGdcmReader compliant)
1003 2003-10-31 Jean-Pierre Roux
1004 * Removal of *all* gdcmData images and add them again
1005 in order to loose the 'history' of un-anonymised images
1007 2003-10-31 Jean-Pierre Roux
1008 * RMV : removal of useless jBitsInJsample.h
1009 for both 8 and 12 Bits JPEG Lossy Libraries
1011 2003-10-31 Jean-Pierre Roux
1012 * ENH : Add the functions gdcmFile::GetImageDataRaw
1013 gdcmFile::GetImageDataIntoVectorRaw
1014 that act as GetImageData and GetImageDataIntoVector
1015 except the making of an RGB Plane from Gray Plane + LUT
1016 Intended to aware (vtk) users who know how to manage
1019 GetLUTRGBA return a R,G,B,A LUT if any
1020 lgrTotaleRaw gives the 'Raw' length
1021 GetImageDataRaw returns the gray Plane
1022 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1023 (They stay Grey, just like with other Dicom viewers :-(
1025 2003-10-30 Jean-Pierre Roux
1026 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1028 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1029 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1030 being coherents dicom files.
1032 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1035 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1036 * ENH: Two steps is necessary to please VC++ compiler...
1037 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1038 * ENH: Add include dir to medcon lib
1039 * FIX: only one function is being exported for now !
1040 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1042 2003-10-29 Jean-Pierre Roux
1043 * adding gdcmHeader::GetLUTRGBA
1044 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1045 --> Mathieu, the modif u're waiting for is not yet committed
1046 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1048 2003-10-27 Jean-Pierre Roux
1049 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1050 00191113.dcm DermaColorLossLess.dcm
1051 MxTwinLossLess.dcm RadBWLossLess.dcm
1052 * ENH: For version prior to vtkImageViewer2 -r 1.19
1053 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1055 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1056 * Removal of ido stuff in CMakeLists.txt
1058 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1059 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1060 * FIX: remove a call to ->Modified ... see comments
1061 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1063 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1064 * FIX: Problem with path for libvtkgdcmPython
1065 * ENH: Try adding a search script for python site-package
1066 * RMV: Remove some file from medcon lib that are not necessary
1067 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1068 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1069 * FIX: More pragma disable fro VC++,
1070 I don't think I break something as it is also disable in VTK/ITK.
1071 But it fasten debug compilation time.
1073 2003-10-23 Jean-Pierre Roux
1074 * gdcm now deals with 16 Bits Run Length Encoded images
1075 (they are compressed as 2 planes images,
1076 one for the high Bytes, the other for low Bytes)
1078 2003-10-22 Jean-Pierre Roux
1079 * Now CheckRead takes into account :
1080 - the bugged 'Leonardo' Siemens images
1081 - the XA images, sent thru the burning VPRO station
1082 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1085 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1086 * FIX: When copying a Makefile.am to CMakeLists.txt
1087 one should remove the '\'
1089 2003-10-22 Jean-Pierre Roux
1090 * in gdcmData adding a bugged 'Leonardo' Siemens image
1091 (wrong lengths in header)
1092 OK with gdcm, KO with the other viewers :-)
1093 * add a GE dlx XA image, thru the VEPRO burning station
1096 2003-10-21 Jean-Pierre Roux
1097 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1098 for a brutal checking of vtkgdcmViewer compliance
1100 2003-10-21 Jean-Pierre Roux
1101 * add the files for 'xmedcon' Jpeg Lossless library
1102 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1104 2003-10-21 Jean-Pierre Roux
1105 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1107 2003-10-21 Jean-Pierre Roux
1108 * garbage Siemens 'Leonardo' images dealt with
1109 (the patch is easy to remove)
1110 * cosmetic changes to avoid warnings
1112 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1113 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1114 no need to press 'r' now.
1116 2003-10-20 Jean-Pierre Roux
1117 * upgrade of checkRead.sh checkWrite.sh according
1118 to new Jpeg Lossless decompressor
1119 * add US.3405.1.dcm, a genuine RGB medical file ...
1120 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1121 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1123 2003-10-15 Jean-Pierre Roux
1124 * general anonymisation in gdcmData
1125 * adding the 'color files' from
1126 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1127 * adding some well knowed bugged-header images
1128 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1129 waiting for their inclusion in Python testsuite
1131 2003-10-15 Jean-Pierre Roux
1132 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1133 no longer seg faults when file is not found
1135 2003-10-14 Jean-Pierre Roux
1136 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1139 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1140 * TODO: *.in file to genereate a UseGDCM later
1142 2003-10-14 Jean-Pierre Roux
1143 * Some supposed-to-be Dicom Images have no preamble.
1144 OpenFile takes it into account
1145 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1146 * Missing elements added in dicomV3.dic
1147 (just to be affraid : have a look at
1148 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1149 and do it again next year ;->
1151 2003-10-13 Jean-Pierre Roux
1152 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1153 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1154 But there are NOT. It's fixed !
1156 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1157 * FIX: "jpeglib.h" was not found on VC++
1158 * FIX: vtkgdcm was not being installed
1160 2003-10-10 Jean-Pierre Roux
1161 * ENH : OpenFile closes the file if it *really* doesn't look like
1162 an ACR-NEMA / DICOM one.
1163 * FIX : testWrite no longer writes an empty file if the source file
1164 is not gdcm Readable
1165 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1168 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1169 * FIX: CMake generate now documentation
1170 * ENH: out of source doc build !
1171 * ENH: Generate both user and dev documentation
1172 * ENH: Should work on windows too
1173 * ENH: Only one doxygen config.in file is needed
1174 * FIX: make install should be ok now on ùnix plateform
1175 * FIX: PATH to dictionary was wrong (missing /)
1176 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1178 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1179 * vtkGdcmReader is now able to read rgb dicom file.
1180 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1181 * added a gdcmViewer to vtk test, use mouse to control
1182 window level & window width
1184 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1185 * CMake-ification of gdcm, we have now two build system
1186 * FIX: on cygwin Wsock32 doesn't exist
1187 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1189 2003-10-06 Emanuel Ollart
1190 * FIX : compilation process wad broken.
1191 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1193 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1194 * change gdcmViewer -> vtkgdcmViewer
1195 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1197 2003-10-06 Jean-Pierre Roux
1198 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1199 ( e.g : well known GE images with a wrong elem length,
1200 : Philips MRI Images with a wrong Huffman table)
1201 * still to be done : allow the reading of bugged LEONARDO Siemens images
1203 2003-10-03 Jean-Pierre Roux
1204 * Odd length strings are padded with '\0' (not with spaces,
1205 to remain compliant with already defined strings,
1206 like Transfert Syntax UID and others)
1208 2003-10-03 Jean-Pierre Roux
1209 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1210 to allow displaying RGB images (not only by affim ;-)
1212 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1213 * vtkGdcmReader is now able to read rgb dicom file.
1214 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1216 2003-10-03 Jean-Pierre Roux
1217 * A few nasty patches to allow the reading of a lot of nasty images
1218 ( e.g : well known GE images with a wrong elem length,
1219 : Philips MRI Images with a wrong Huffman table)
1220 * still to be done : allow the reading of bugged LEONARDO Siemens images
1222 2003-10-03 Jean-Pierre Roux
1223 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1225 2003-10-03 Jean-Pierre Roux
1226 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1227 to allow displaying RGB images (not only by affim ;-)
1229 2003-10-03 Jean-Pierre Roux
1230 * gdcmFile::GetImageDataIntoVector now
1231 - deals with MultiFrames MultiFragments Run Length Encoded files
1232 - deals with YcBcR (YBR_FULL) files
1233 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1234 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1236 (no sample found :-(
1238 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1239 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1240 Two reasons: - clear things
1241 - third parties acces gdcm through header files, so won't
1242 suffer anymore VC++ complains
1244 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1245 * add argv[1] in testvtkGdcmReader.cxx
1248 2003-09-24 Jean-Pierre Roux
1249 * The lines are now eigthy characters long.for
1250 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1252 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1253 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1254 char* to std::string. Thus, the use of strdup becomes useless. (see
1255 previous commis of Malaterre)
1256 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1257 before the last Malaterre's commit.
1259 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1260 * This commit should fix the Debug building under VC++, the problem
1261 was mainly a mixture of debug and release lib being loaded at startup.
1262 * I also remove a depency to a specific C function: strdup. Because I had
1263 to force the link to msvcrtd (whereas strdup is in libc).
1265 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1266 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1267 located in the gdcmCommon.h file. All use of reference of tha has been
1268 changed to now use the variable GDCM_UNFOUND.
1270 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1272 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1273 Dicom dictionary. The test suite can now be run again. Note:
1274 I'm note very happy with the " (RET)" changes. I believe this
1275 RETAINED comment should be dropped when parsing the dictionary.
1276 - PACKAGER corrected
1278 - AUTHORS updated and now in alphabetical order
1279 * Makefile.am now exports gdcm.dsw for Windoze users.
1281 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1282 * cygwin complains about missing std:: in subdir Test/
1284 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1285 * remove some methods that are now in gdcmHeaderHelper
1287 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1288 * vtkGdcmReader set spacing and origin correctly
1290 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1291 * Fix a few delete/delete[] mismatch
1293 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1294 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1295 interpretation to data given by gdcmHeader. For instance there are
1296 heuristics to get informations (look at different places).
1297 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1298 sorting DICOM images based on different strategies.
1299 * modified Makefiles accordingly.
1301 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1302 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1303 when building in debug mode
1304 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1305 src/win32/gdcmdll.dsp
1306 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1308 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1312 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1313 * src/win32/libgdcmjpeg12.dsp was not dos format
1314 * src/win32/libgdcmjpeg12.dsp :
1315 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1316 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1318 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1321 * src/gdcmFile.cxx : bug fix in affectation type
1322 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1323 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1324 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1325 symbols... future problem ?
1327 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * src/win32/libgdcmijpeg12.dsp was missing
1329 * modified gdcm.dsw accordingly
1331 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1332 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1334 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1335 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1336 commit of JPR (before his hollidays to facilitate our work).
1337 * setup.py : bug fix in code. Modifications made while the last commit
1338 of JPR. The code hasn't been tested before the commit... it's so
1339 useless to make that (for best programmer that is JPR) !!!
1341 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1342 * tagged the current version as Version0_3 (i.e. version 0.3)
1344 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1345 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1346 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1347 * *.dsp : modifications to use new libgdcmijpeg8 library
1348 * setup.py : bug fix on VTKPATH variable
1349 * PACKAGER : adding all concerning windows
1351 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1352 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1354 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1355 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1356 test suite reported error.
1357 * PACKAGER file added (describes what a packager must do when
1358 packaging a new release).
1359 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1360 * configure.in: upgraded version number to 0.3.0
1361 * fixing build of rpm (through rpm -ta):
1362 - Doc/Makefile.am exports proper doxygen files
1363 - src/jpeg/libijg8/Makefile.am exports the include files.
1365 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1366 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1367 * src/gdcmHeader.h : formatting code
1369 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1370 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1371 We were obtaining error message from vtk. Now, creation of file list
1372 is made in an internal list to prevent this problem.
1373 Bug fix when output is empty.
1374 Bug fix in update of progress value. Previous commit for this was a bad
1376 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1378 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1379 * src/gdcmHeader.h : added method to get the file name
1380 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1381 files. Added method to remove all files on the input
1382 Added FIXME comment concerning the bad parsing of header made by
1383 ExecuteInformation method (in ExecuteData method)
1385 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1386 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1387 when using make instal.
1388 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1389 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1391 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1392 * setup.py : adding include dir of jpeg lib to compile all sources
1393 * */Win32/*.dsp : JPR fix for windows compilation
1395 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1396 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1398 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1399 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1401 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1402 * setup.py is again effective on un*x (takes into account the
1403 addon of the jpeg library)
1404 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1405 * Doc/Doxy* updated (includes above enhancements)
1406 * INSTALL now points to web documentation
1408 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * src/gdcmHeader.h doesn't make unnecessary reference to
1411 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1413 * src/gdcm*.[cxx|h] :
1414 - to allow compilation with gcc 3.x
1415 -- clean up of STL usage (added explicit usage of std::)
1416 -- small fixes on exceptions.
1417 Note: linking not tested !
1418 - clean of doxygen comments to avoid warnings at documentation
1420 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1421 dependent convertion).
1423 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1424 * Clean up of previous JPR garbage commit (not even commented in the
1426 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1427 - moved all jpeg related files from src to src/jpeg/libijg8, with
1428 addition/modification of Makefile.am and configure.in.
1429 - the testSuite is still brain damage (not guilty).
1431 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1432 * WrapVTK.py : modifications to get correctly vtk source files to
1434 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1435 (FileName -> Filename)
1437 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1438 * vtk/vtkGdcmReader.[cxx/h]:
1439 - UpdateProgress method should now be effective
1440 - removed the limitation on having only images loaded (as opposed
1442 - when building a stack of images/volume, a lesser number of
1443 gdcmHeader and gdcmFile instances should be used (hopefully
1444 accelerating things).
1445 - when building a stack of images/volumes, files which are not
1446 loadable (wrong path-filename, wrong permissions on existing file,
1447 or file not parsable by gdcm) are replaced with a black image
1448 in the stack (for the caller to notice the problem).
1450 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1451 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1453 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1454 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1455 between standard library (std) and vtk library (problems are found
1456 under Windows... thanks Windows !)
1458 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1459 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1461 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1463 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1466 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * When compiling with distutils (see setup.py) the C++ compiler is
1468 called with different flags than the default ones (with automake).
1469 In order to fix all those warning, I compiled gdcm with the command
1470 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1471 and went for warning fixes:
1472 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1473 up from unused variables.
1474 - vtk/vtkGdcmReader.cxx: potential bug fix.
1475 * src/gdcmHeader.h: Doxygen warning cleanup
1477 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1478 * gdcmPython/gdcm.i:
1479 - typemaps correction to take into account the systematic replacement
1480 of "using namespace std" with std:: prefix e.g. std::list,
1481 std::string... (cf changes of 2003-05-21).
1482 - gdcmGlob global variable of type gdcmGlobal (defined in
1483 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1484 exported to Python a as cvar.
1485 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1486 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1487 gdcmDictSet.GetPubDictTagNames() and
1488 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1489 C++ static methods).
1490 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1491 with the above changes.
1493 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1494 * setup.py, manifest.in : bug fix under linux
1496 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1497 * Modification of setup.py to compile vtk part too. Then, we have 2
1498 wrappers which must work with same distutils. For that, we have a
1499 generic distutils in distusiltsWrapping.py ; with :
1500 - build_extWrap class to wrap generically all extensions,
1501 - ExtensionWrap base class for all wrapping extension that contains
1503 - Wrapper interface which wrap sources
1504 + In WrapSwig.py we have extension and wrapper for Swig
1505 + In WrapVTK.py we have extension and wrapper for VTK
1506 * MANIFEST.in : modifications to consider vtk directory and new python
1507 files for compilation
1509 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1510 * Added python wrappers of vtkGdcmReader vtk class (see the
1511 source in vtk/vtkGdcmReader.cxx) :
1512 - vtk/Makefile.am now builds a library
1513 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1514 python library (as opposed to _gdcm.so wich are the python
1515 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1516 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1518 - configure.in has an additional flag --enable-vtk that needs
1519 to be set to enable compilation of vtk related code, that is:
1520 + vtk/vtkGdcmReader.so and
1521 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1522 + gdcmPython/vtkgdcmPython.so (see above)
1523 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1524 be read when compressed or when HighBit + 1 != BitsStored),
1525 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1526 the usage of the python wrapper of vtkGdcmReader vtk class.
1527 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1528 * src/*.[h] all occurences of stl classes are now prefixed with
1529 std::, and all occurences of "using namespace std;" where removed.
1530 This is to avoid pollution of global namespace in included files.
1531 Apparently vtk does not avoid this pitfall: when using both
1532 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1533 collision of various stl members (principally cout...).
1534 * gdcmPython/testSuite.py now cleanly removes temprory generated
1536 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1537 comply with above changes)
1539 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1540 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1541 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1542 vtk data structure (an image Flip was required).
1543 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1544 * cosmetic changes in documentation.
1546 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1547 * src/gdcmHeader.cxx: the constructor no longer exits when an
1548 unexisting file is given as argument.
1549 * The subdirectory Data (containing all the images used for the
1550 test suite) is not part of this repository anymore. A new module
1551 containing those images is now available at
1552 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1553 with the name gdcmData.
1554 All the python scripts (including the package initialisation file
1555 gdcmPython/__init__.py) were adapated to take this change into
1556 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1558 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1559 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1560 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1561 demo of the usage of this class.
1562 Compilation of this vtk part is only done when using the --enable-vtk
1563 at configure (or autogen.sh) stage.
1565 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1566 * More memory link related corrections and documentation fixes.
1568 - maximum info is obtained with a command of the form:
1569 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1570 --show-reachable=yes PrintHeader
1571 - the remaining reachable blocks seem to come from the STL
1572 allocation scheme through the usage of map and list. It looks
1573 like this memory cannot be freed but it is not a memory leak
1574 (in fact further invocation to the STL would recollect the
1575 unused memory allthough it cannot explicitely be freed).
1576 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1577 of displaying an image parsed with gdcm and displayed with VTK.
1578 Note: some images don't seem to work e.g.
1579 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1580 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1581 Allthough this weakens the semantics, it is a ditch attempt to
1582 make gdcm more thread friendly.
1584 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1585 * Memory link hunt (by using valgrind through the command
1586 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1587 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1588 gdcmHeader::_dicom_vr.
1589 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1590 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1592 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1594 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1595 * src/Makefile.am now exports all the necessary include files at
1599 * UpdateGroupLength replaced by new one
1602 * UpdateGroupLength re-written using H-Table
1603 (named UpdateGroupLengthNew untill checks are over)
1605 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1606 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1607 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1609 - gdcmHeader::GetPubElValSet removed.
1610 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1611 UpdateGroupLength, WriteElements, Write.
1612 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1613 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1614 carried the same semantics.
1615 - src/gdcmHeaderIdo.cxx changed accordingly.
1616 - gdcmFile::WriteBase now regroups all the codes from previous
1617 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1618 - enum FileType moved to gdcmCommon.h
1619 * src/gdcmHeader.cxx AddDefault trashed
1620 * gdcmGetXSize added
1621 * getimageDataSize now calls gdcmGetXSize
1622 * Test/*.cxx changed to agree with above changes
1624 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1625 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1626 (to avoid double call by end user).
1627 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1628 by end user, since gdcmHeader::gdcmHeader now handles it.
1630 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1631 * gdcm/Doc many doxygen changes:
1632 - Doxyfile now has two different versions, DoxyfileUsers that generates
1633 the html.users end users oriented documentation and
1634 DoxyfileDeveloppers that generates the html.developper developper
1635 oriented documentation.
1636 - README changed accordingly
1637 - requirement.txt removed (old design info moved to TODO).
1638 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1639 DoxyMainPage.txt, DoxyPython.txt provide more information.
1640 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1641 be updated by simply regenerating the docs with doxygen and copying
1642 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1643 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1644 all the tests in the form "if (<map>.count() >1)" were removed.
1645 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1646 ill-formed documentation sections.
1647 * src/gdcmHeader.cxx: ditto
1649 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1650 * setup.py fixed for un*x (needed macro for stdint.h)
1651 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1652 un*ces with sh-utils test utility.
1653 * gdcmPython/demo/test.py renamed to PrintHeader.py
1654 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1655 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1656 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1657 * src/gdcm*.cxx JPR's bad inclusion fixed.
1659 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1660 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1661 * gdcmPython/demo/test.py changed accordingly.
1663 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1664 * gdcmPython/Makefile.am fixed linking against libstdc++
1665 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1666 * Swig subdir (historical tests of swig version 1.3.17++) removed
1667 * Test/testChangeEntete.cxx some lines commented out in order to make
1669 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1670 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1672 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1673 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1674 hence the user doesn't need this explicit call.
1675 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1676 i.e. LoadElements() call removed.
1677 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1678 - src/Makefile.am declares the proper flag for g++.
1679 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1680 for adding user defined new tags.
1681 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1682 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1683 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1685 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1686 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1687 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1688 src/Makefile.am : the project should properly compile and install
1689 with the autotools, included the python wrappers part.
1690 * gdcm.spec.in : added a spec file for RPM packaging.
1692 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1693 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1695 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1696 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1697 to exported to the environement (see gdcmPython/testSuite.py
1699 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1700 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1701 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1702 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1703 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1705 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1706 * gdcmPython/__init__.py doesn't crash anymore when running in
1707 in InstallMode or PreInstallMode but with an environement given
1708 value of GDCM_DICT_PATH.
1709 * src/gdcmDictSet.[cxx/h] coding style.
1711 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1712 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1713 * src/gdcm.h general comments moved to TODO, and README
1714 * src/gdcm.h should now be seen as a user commodity (including it
1715 should suffice to fully use gdcm). It is nowhere including within
1716 any of the kernel files src/*.cxx and src/*.h.
1718 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1719 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1720 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1722 * src/gdcm*.cxx only include their corresponding include file
1723 (as opposed to gdcm.h)
1724 * gdcmPython/gdcm.i changed accordingly
1725 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1726 the autogen.sh generated "make snapshot" command to work.
1727 * autogen.sh removed history related references to crea package.
1729 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1730 * distutilsSwigCPlusPlus.py work around some swig portability
1733 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1734 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1735 was done in a last ditch attempt to get setup.py _really_
1736 operationnal. The python/gdcmPython layaout add the advantage
1737 of hidding away the python related distutils specific files
1738 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1739 Alas, the src directory was out of scope (i.e. it's relative
1740 position to setup.py was ../src) which made things impossible to
1741 handle (see previous version of python/setup.py). Crossing fingers...
1743 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1744 * python/setup.py now works on Un*x. (harder than I thougth)
1745 * python/distutilsSwigCPlusPlus.py can now have include files
1746 among the list of sources.
1748 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1749 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1750 * modifications in MSVC projects
1752 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1753 * As stated by the first lines of Test/ExceptionAndPython/README, it
1754 looks like we can move back to original usage of exception within
1755 src/gdcm* and hence remove the errno stuff that was introduced
1756 as a quick and dirty fixture of this problem (added to the TODO).
1757 * Doc/Doxyfile configuration file for Doxygen and corresponding
1758 README file for usage added.
1759 * Test/testWrite.cxx added. This new test comes from a split of
1760 test.cxx that is now reverted to its original purpous i.e.
1761 testing the proper parsing of a Dicom related file.
1762 testWrite.cxx concentrates on testing the IO part of gdcm.
1763 * Test/bug1.cxx (containing a bug on WIn32) added.
1764 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1765 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1766 whose purpose is to publish the content of the TagNames of the
1767 Dicom public dictionnary were not accessible without an
1768 instance of class gdcmHeader.
1769 - those methods are now static methods of gdcmDictSet and hence
1770 require no instances at all to be invocated.
1771 - within gdcmDictSet this change required to change some method
1772 to class methods (i.e. are now static) among which SetDictPath
1773 (renamed to BuildDictPath) and LoadDefaultPubDict.
1774 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1775 the above changes by calling the new method classes of gdcmDictSet.
1776 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1777 the above to be effective.
1778 * python/gdcmPython: in order to wrap properly the above changes
1779 for Python, swig version now needs to be > 1.3.17.
1780 * python/gdcmPython/Makefile fixed to adapt itself to new
1781 configure/make shema introduced by Johan Montagnat (thanks for the
1782 contribution). Alas this Makefile cannot be turned into a proper
1783 Makefile.am without some heavy changes in the configure.in
1784 (for python dectection).
1785 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1786 now avoids publishing the empty entries.
1788 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1789 * python/setup.py : bug fix concerning install under windows
1790 ExtraPath reused :-P
1791 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1793 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1794 * Dicts/dicomV3.dic : remove double spaces !!!
1795 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1796 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1799 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1800 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1801 method. Doxygenation.
1802 * src/gdcm.h clean up of JPR spurious comments.
1804 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * python/distutilsSwigCPlusPlus.py now properly collects the
1806 shadow classes generated by "swig -c++" (gdcm.py in our case)
1807 when using "python setup.py install".
1808 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1809 reexports the working classes.
1810 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1811 by the classical C errno scheme. This is to prevent an obscure
1812 behavior of the python wrappers when importing wxPython.wx prior
1813 to gdcmPython (which ended up in an abort call). An illustration
1814 of this oddity can be found in the Test/ExceptionAndPython
1815 subdir (see the README file). This problem probably due to
1816 an combination of g++ and dynamic loading.
1817 * added Test/ExceptionAndPython (see above)
1819 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1820 * Changed the layout of the python part to avoid bloating main
1821 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1822 i.e. the distutils arsenal. All the python related stuff is
1823 again in a python subdir, but the package itself is now in
1825 * setup.py was cleaned up:
1826 - pythonIncludePath removed
1827 - python setup.py bdist target is now functional.
1828 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1829 collision with other packages). gdcmPython/demo/*.py changed
1832 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1833 * python subdir moved to gdcmPython (preparation of distutils packaging).
1834 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1835 distutils installer is operational.
1836 * - gdcmPython/__init__.py now properly loads the swig generated
1837 shadow classes (from gdcm.py).
1838 - gdcmPython/demo/*.py changed to import the package gdcmPython
1839 instead of gdcmPython/demo/load.py.
1840 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1842 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1843 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1844 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1845 entries within the associated public Dicom dictionary resp. the same
1846 information but sorted by the fourth field (PAT, IMG, DIR) of the
1848 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1849 are now in the "???" group.
1850 - python/gdcm.i changed accordingly,
1851 - python/demo/printGroupedPublicDict.py added, that gives an example
1852 of the above new functionalities in Python.
1854 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1855 * src/gdcm.h, gdcmHeader.cxx:
1856 - historic references to glib's g_malloc and g_free (#defined)
1857 were definitively removed.
1858 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1859 * src/gdcmElValSet.cxx:
1860 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1861 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1862 - GetElValue(string) renamed to GetElValueByName.
1863 - Added GetElementByName(string).
1864 * src/gdcmHeader.cxx: added
1865 - GetPubElValRepByNumber(guint16, guint16)
1866 - GetPubElValRepByName(string)
1867 - GetShaElValRepByNumber(guint16, guint16)
1868 - GetShaElValRepByName(string)
1869 - GetShaElValByNumber(guint16, guint16)
1870 - GetShaElValRepByName(string)
1871 - GetElValRepByNumber(guint16, guint16)
1872 - GetElValRepByName(string)
1873 - GetElValByNumber(guint16, guint16)
1874 - GetElValRepByName(string)
1875 * Doc/requirements.txt added.
1877 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1878 * Test/Makefile building now depends on the one of libgdcm.so
1879 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1880 pixel data) aware which enables finding the address (offset) of
1881 the pixel data of JPEG encoded DICOM files. This leaves only a single
1882 file in the testSuite whose pixel data address (offset) is unknown.
1883 * python/testSuite.py changed accordingly.
1885 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1886 * VC++ has some strong limitations when working with the STL, as stated
1887 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1888 "Also note that some STL containers (map, set, queue, list, deque)
1889 cannot be exported. [...]
1890 Some STL classes contain nested classes. These classes can not
1892 This is caused by a designed limitation that once a template
1893 class is instantiated, it can not be re-instantiated and
1895 Since our usage of map<> is ubiquitous in gdcm, this "designed
1896 limitation" of VC++ is a pitfall.
1897 Hence the Python wrappers of gdcm cannot be incrementally linked
1898 against the c++ dynamic library. The dirty but only workaround is
1899 to forget about incremental link of dynamic libraries and to generate
1900 the Python wrappers library with the inclusions of the underlying C++
1902 The following modifications concern this matter on Win32/VC++:
1903 - wrapping python correct with standalone wrapped dll (don't use separate
1904 dll under windows !!!!)
1905 - python21_d debug mode enabled (ask Frog how to use it :-)
1906 - NO problem with having an STL member of class for example string in C++
1907 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1908 - Python test of dcmlib in Python is ok under windows on a large set
1910 * removed glib references
1911 * typedef's inserted in gdcm.i for correct swig type management
1913 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1914 * python/demo/*.py load.py extracted from test.py. Added explore.py
1915 that only displays required tags and testAll.py that parses all
1916 the files of the testsuite without using unittest.
1917 * python/testSuite.py other additional test on new files added.
1918 * Data/* new test files added accordingly to the testSuite.
1919 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1920 the vr in the file differs from the one of the dictionary.
1922 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1924 values, but limits itself to values which are below a user specified
1925 size (by default 1024 bytes).
1926 * python/gdcm.i : elements not loaded (because their size is above the
1927 user specified treshold) are exported with their TagKey as key of the
1928 python dictionary. This enables the testsuite to make some checks
1929 on the unloaded elements (since we have their offset and size).
1930 * python/testSuite.py
1931 - now tests for the existence and proper value of the pixel data
1932 - two new examples added.
1933 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1935 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1936 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1937 aware. See the strategy comments in gdcmHeader::FindeLength().
1938 * Test/test.cxx now accepts a filename as first argument.
1939 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1940 * python/testSuite.py changed to integrate test on above files.
1942 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1944 the vr was also RET.
1945 * python/testSuite.py more tests added.
1947 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * python/testSuite.py unittest test suite added (uses Data)
1949 * Data/* dcm and acr files for the test suite.
1950 * glib dependance removed from un*x version. We now use ISO C99
1951 7.18 Integer types (see stdint.h)
1952 - python/Makefile, src/Makefile src/gdcm.h
1953 * src/ when an explicit vr (like dicom files) suddenly poped an
1954 implicit element we use to mark the underlying DictEntry of the
1955 concerned ElValue with "Implicit". This strategy was damageable
1956 too the public or provite dictionaries, since some of their vr
1957 would be changed. Since Header::FindLength heavily relies on the
1958 detection by Header::FindVR of falsely explicit elements, I
1959 added an extra ImplicitVr member to ElValue (boolean).
1960 The rest of the changes we the necessary adaptations.
1962 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1963 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1965 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1967 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * Adaptation for porting to VC++:
1970 o forced to use std namespace (for string to be known)
1971 o all class use __declspec export style on WIN32
1972 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1973 (in stdlib.h on Win32 but in std:: for gcc)
1974 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1975 variable GDCM_DICT_PATH.
1976 * src/gdcmHeader.cxx verbose comments made discrete.
1978 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1979 * python/gdcm.i: added a typemap that converts a C++ hashing table
1980 to native Python dictionary.
1981 * python/demo/test.py:
1982 - now uses the native dictionary for exploration of gdcmHeader.
1983 - takes an optional filename argument (the file to parse).
1984 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1985 PubElVals hashing table.
1986 * Dicts/dicomV3.dic removed error prone trailing spaces.
1988 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * Python wrapping process moved away from src/Makefile to
1990 newly created python/Makefile (as well as gdcm.i)
1991 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1992 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1993 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1994 from the environement variable GDCM_DICT_PATH (when existing).
1995 * src/gdcmDict::GetTag bug fix.
1997 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * Straightforward temporary fixes for swig to build the python wrappers.
1999 src/Makefile now has a python working entry [by working we mean
2000 that we can import de shadow classes without errors].
2002 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2003 * hashtest.cxx removed (since allready in Test)
2004 * src/gdcmlib.h renamed to src/gdcm.h
2005 * src/dcm.i renamed to src/gdcm.i
2006 * src/Makefile prepared for python wrapping
2008 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * src/gdcmHeader.cxx :
2010 - Parsing of header is now separated from loading of element values
2011 (see gdcmHeader::LoadElements).
2012 - general clean up of hopefully all file access (creation of
2013 ReadInt16 and ReadInt32)
2015 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * src/gdcmHeader.cxx :
2017 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2019 - SetLgrElem renamed to SetLength
2020 - GetLgrElem renamed to GetLength
2021 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2022 * src/gdcmElValSet.cxx fixed both GetElValue methods
2023 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2024 due to IdoDude was cleaned out.
2026 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2027 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2028 concentrates on finding the value representation (when it exists).
2029 RecupLgr now only finds the element value length, and it avoids
2030 returning the unecessary skL (skipped length).
2031 Also, offsetCourant was simply removed (with taille_fich) since
2032 it was redundant with the File position internals (by using
2033 ftell and fseek). This also made skL (see above in RecupLgr) usage
2035 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2036 on the libido specificities which are handled through class
2038 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2041 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * Truckload of changes. Parsing of header is barely functional
2043 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2045 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * src/gdcmHeader.cxx many addons of low level methods
2048 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2050 and _IdDcmSWAP_LONG.
2052 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * This corresponds to all the changes decided at the meeting of
2054 May 23 2002. Needless to say we are running late...