1 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Amelioration of code, remove some code copy. For the loading of
3 BinEntry (in gdcmDocument), add the test to verify if the file is already
6 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
8 remove a DocEntry in the header (push an empty DocEntry)
9 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
10 lines. Bug fix in the initialization of the PixelConvert and the
12 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
13 use in TestCopyDicom (now this test can run under windows... but fails)
14 * Test/TestCopyDicom.cxx : amelioration of the test :
15 - test the pixels written
16 - add test points to quickly find where is the error
17 - can set a file name input and output in arguments
18 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
19 amelioration of the test output
21 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
22 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
23 all replaced DocEntry's
24 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
25 Now, each needed DocEntry to modify is duplicated, modified and inserted
26 to the header using DocEntryArchive. Thus, after save, we can restore the
29 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
30 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
32 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
34 correct to copy it. The DictEntry is specified at the DocEntry creation,
35 then, it musn't change in the time.
36 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
37 header correctly. At this time, the change is only made for the first
38 level of the Document. In the future, it might consider sequences.
39 The change is made by replacing a DocEntry by an other that is created
40 outside the class. The old value is kept. When we restore the header
41 status, the added DocEntry is deleted and replaced by the old value.
42 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
43 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
44 set the write type to explicit VR, implicit VR or ACR. Add methods to set
45 the write mode to native, decompressed or RGB (but not used at this time)
47 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
49 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
51 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
53 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
55 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
56 set because already copied when copying the BinEntry's of the header
57 * Test/TestAllReadCompareDicom.cxx : remove warnings
59 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
61 Two problems appear when doing it :
62 - with the gdcmFile : when the GetImageData method is called, the pixels
63 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
64 datas (pixels). And each structure destruct the datas when it's
65 destructed. So we have two destructions for the same datas. To solve it,
66 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
67 datas or not. If it doesn't own datas, then they will not destroyed by
69 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
70 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
71 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
72 create a double destruction of the same DocEntry's. So, to solve it,
73 the TagHT is simply cleared and the DicomDir* elements are destroyed.
74 * TODO : add an entry concerning memory leaks in the DicomDir
76 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
78 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
81 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
83 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
84 after it have been deleted
86 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * FIX: src/* fix the doxygen warnings.
88 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
89 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
90 was erroneously defined with a size of 15 instead of 16. [many thanks
91 to Jean Michel Rouet for pointing out this bug].
93 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
94 1. Finish merging JMR patch for writting DICOM from scratch
95 2. Fix -hopefully- bug with MONOCHROME and space vs null character
96 3. Use const ref when possible
97 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
98 5. A few more comments
99 6. CreateUniqueUID can now be called without parameter"
101 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
102 * ENH: Slightly bigger patch:
103 1. Getting toward full integration of JMR patch for writting dicom from scratch
104 2. Update Test to test part of this patch: CreateUniqueUID
105 3. File was not close properly in gdcmDict
106 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
107 5. Use of const ref instead of copy (speed issue)
108 6. Remove temporary (duplicate) string in TranslateToKey
109 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
110 8. Do not repeat virtual in subclasses
111 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
113 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
114 * Apply first patch toward better string comparison when dealing with broken
115 DICOM files. Essentially the string could be padded with a space instead
116 of a null character as defined by standard
118 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
120 because never used... and in the same time, that's remove some memory leaks
122 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmFile.cxx : now delete the PixelConvert instance.
124 * In examples and tests : change the type of image data variables from void*
125 to uint8_t*. Remmove all delete on image data variables
127 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
129 Verify the file pointer value before open the file, and if it's not null,
130 a verbose message is generated.
131 Close correctly the file when the file isn't considered dicom-like. The
132 correctly close is a call to CloseFile.
133 When closing the file pointer, test if its not null to close the file.
134 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
135 file. For an uncompressed image, the copied datas correspond in the least
136 case to the image size (calculated) or the image size specified in the
137 header. A verbose is generated if these two size mismatch
139 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
141 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
142 break under windows (with msvc6 compilation).
144 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
146 compiling with MSVC6)
148 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * Bugs fix for the Windows build with VC6
150 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
151 needed (only for projects required VTK). If the VTK is included in all
152 projects, there is conflicts with the jpeg lib of vtk when compiling the
153 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
154 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
155 when compiling the gdcm_wrap.cxx file (created by the compilation of the
157 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
158 (like it's already made for the cout use). Otherwise, conflict with the
161 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
162 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
164 - comments on the DicomDir::Method related usage added.
165 - now that we use the namespace gdcm, a lot of internal classes do
166 NOT need to be wrapped anymore.
167 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
168 DicomDir::Method) new example added.
170 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
171 * Improve string manipulation. I now inforce the notion of 'DicomString'
172 A DicomString can contain as many \0 as they want
173 and it is *always* of even length.
174 We only support odd length for very rare case.
175 And in the near future this should be removed.
177 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
178 * /binary_write/ gdcm source. Now even on big endian we are writting
179 little endian. This should -heopfully- fix some tests
181 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
182 * Now the dictionary is compiled into gdcm lib. This is a default
183 behavior, thus any dic file specified is picked before failback to
184 the one comiled into lib
186 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
187 * Change internals for gdcmDict. Don't use any 'new' any more.
188 This should definitely solve any leak problem, and we should be
189 as fast as before, as long as don't modify too much the dictionary.
191 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * STYLE: ivars should start with a capital letter.
193 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
194 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
196 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
197 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
198 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
199 new 2004 dictionaries added (thanks to JPR).
200 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
201 * CLEANUP_ROUND (15) for gdcmPixelConvert
202 - RLEFrame::NumberFragments is now of type unsigned int
203 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
204 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
207 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
208 * Initial work in gathering all transfer syntax accessors. clearly
209 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
210 ivars, but only one transfersyntax (class) ivar with equivalent method on
213 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
214 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
215 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
216 discussed (plus I didn't like having a 2000 lines patch not commited)
218 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
219 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
220 * CLEANUP_ROUND (14) for gdcmPixelConvert
221 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
222 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
223 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
225 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
226 anymore and hence avoids storing a copy of PixelConvert::Decompressed
227 into File::Pixel_Data.
229 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
230 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
231 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
232 * CLEANUP_ROUND (13) for gdcmPixelConvert
233 Substituted File::ParsePixelData() with PixelConvert::Print() new
235 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
236 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
237 method to those classes.
238 - src/gdcmFile.[cxx|h]:
239 -- Added a ::Print() method.
240 -- PixelConverter is now a reference instead of a member.
241 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
242 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
244 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
245 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
246 collaboration diagram and inheritance diagram should be generated with
248 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
249 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
250 pointlessly wrapped (see
251 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
252 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
253 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
254 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
255 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
256 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
257 -- File::Initialise: PixelConverter setup moved away to
258 PixelConverter::GrabInformationsFromHeader()
259 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
260 interpretation moved away to PixelConverter::BuildRGBImage()
262 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
263 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
264 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
266 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
267 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
268 displayed on Win32 when a brutal abort() occurs (because of uncatched
269 exception). See TODO new entry of this commit for more on this.
270 * TODO added new entry.
271 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
272 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
273 - HandleColor is no longer called from gdcmFile.cxx
274 - gdcmPixelConvert.cxx clean up on method arguments and internal
275 variable names for semantical coherence.
277 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
278 * Finished lossless transition, not only do we now read all lossless jpeg
279 images, without the need of the Cornwell lib, but we do read them properly now
280 * To reduce code (well to avoid code duplication), I defined a common place
281 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
282 redefine symbols. This is not prefect but this the best solution I found for a
283 compilation time jpeg option.
285 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
286 * Update jpeg ijg lib to support lossless jpeg implementation
287 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
289 * Also added a special copyright for dcmtk since we use their bugfixes.
292 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
293 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
294 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
295 matters, as stated in warning note at begining of %include section).
296 * src/gdcmDicomDir*.[cxx|h]: coding style
297 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
298 * src/gdcmJpeg8.cxx: doxygen fix.
299 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
300 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
301 from File:: to PixelConvert::.
303 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
304 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
305 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
306 - more code moved away from File:: to PixelConvert::
307 - fat setup of PixelConverter set in place in File::Initialise.
309 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
310 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
311 namespace at the file system level. So now you should convert your examples
313 gdcmHeader -> gdcm::Header
314 It would be nice if people keep in mind to no open the namespace, since it
315 allows compilation on broken plateform which were defining common symbol in
316 the standart namespace (like LP, Unknown ...)
318 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
319 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
320 The JPEG fragments are now parsed at the same stage than the RLE
321 information. All code related to JPEG is now in gdcmPixelConvert:
322 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
323 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
324 export a gdcmFile:: method. Those are simply global functions
325 (for the time being this is better than having them attach to
326 either gdcmFile:: or gdcmPixelConvert::).
327 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
328 and stores the result in a gdcmJPEGFragmentsInfo.
329 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
330 code (among other stuff) moved away from gdcmFile:; to
333 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
335 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
336 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
337 clean up of RLE related code.
338 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
339 - src/gdcmRLE.cxx removed
340 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
341 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
342 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
343 * CLEANUP_ROUND (9) for gdcmPixelConvert
344 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
345 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
346 away from gdcmFile:: to gdcmPixelConvert::.
348 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
349 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
350 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
351 This is because Parse7Fe0 used to parse the pixels to compute the
352 length. This task was passed over to FindDocEntryLengthOB() a long
353 time ago, EXCEPT I had forgotten the OW case...
354 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
355 we just recylce the code for parsing RLE fragments and computing
357 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
358 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
359 with the retired Parse7Fe0().
360 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
361 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
363 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
364 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
365 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
366 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
367 - src/CMakeLists.txt: alphabetic order reodering + new entries.
368 * CLEANUP_ROUND (4) for gdcmPixelConvert
369 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
370 to return an unused length.
372 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
373 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
374 this should be cleanner from the plane view. The iostream are erally a pain
375 to use to do simple stuff.
377 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
378 * Redo the compilation of the ijg jpeg library. Now only one source is
379 necesseray. No need to rename file by hand what so ever. CMake handle the
380 copying of the file within different directory, configure header file to
381 modify some symbol. The only addition made to ijg wasd a mangle table so
382 that symbol are different wether we are within 8bits or 12bits.
384 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
385 * Added documentation of vtkgdcmReader on Website:
386 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
387 with it's binary name).
388 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
389 the Website to be more complete.
390 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
391 doxygenated documentation.
392 - Doc/DoxyVtkGdcmReaderExamples.txt added
393 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
394 DoxyVtkGdmReaderExamples.html )
395 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
396 * CLEANUP_ROUND (3) for gdcmPixelConvert
397 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
399 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
400 * CLEANUP_ROUND (2) for gdcmPixelConvert
401 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
403 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
404 * CLEANUP_ROUND for gdcmPixelConvert:
405 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
406 - src/gdcmPixelStuff[h|cxx] removed
407 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
408 - src/CMakeLists.txt changed accordingly
410 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
411 gdcmVersion.py moved to newly created ATTIC related
412 gdcmPython/SetupOldies/ directory.
413 * Autotools clean up:
414 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
415 - autogen.sh configure.in acinclude.m4 python.m4 removed
417 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/*.cxx *.h Reference to License.htm fixed to License.html.
419 * Doc/CMakeLists.txt, doxygen.config.in: fix.
420 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
422 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * TODO updated with Mathieu suggestions. I proposed a template for
424 describing TODO entries and used it for new entries.
425 * Added Doc/Website/CodingStyle.html, Developpers.html,
426 DeveloppersPython.html, GdcmDataCvs.html and
427 DownloadVersion0_1.html, DownloadVersion0_3.html.
428 * Some Doc/*.txt Doxygen files (which do not really concern the
429 documentation itself, but the website) moved to html and
430 placed in directory Doc/Website:
431 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
432 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
433 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
434 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
435 * CMakeLists.txt changed accordingly.
436 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
437 DeveloppersPython.html
438 * INSTALL nows refers to Doc/Website/Installation.html
440 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * Added Doc/Website directory, that contains a first raw version
444 2004-09-23 Jean-Pierre Roux
445 * FIX In order not to be poluted any longer by casting problems,
446 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
447 we can now delete[] it safely
448 * VoidArea is now called BinArea (less confusing name),
449 and all the methods called ...VoidArea... are now ... BinArea...
450 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
452 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
453 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
454 clear) TagHT, which is an inherited member of gdcmElementSet. It is
455 up to the destructor of gdcmElementSet to clean up TagHt and it's
458 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * Test/CMakeLists.txt: update to follow gdcmData renamings.
460 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
462 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
463 * ENH: added some utility method that builds a flat dictionnary
464 holding all the Dicom entries contained in the recursive structure
465 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
467 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
468 BuildFlatHashTable() that build a flat dictionary.
469 - src/gdcmElementSet.h: added a new private GetTag() accessor.
470 gdcmDocument is now a friend of gdcmElementSet.
471 - src/gdcmElementSet.cxx: clean up.
472 - Example/FlatHashTablePrint.cxx added.
473 - Example/CmakeLists.txt changed accordingly
475 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
476 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
477 moved away from gdcmDocEntrySet (since this class is an abstract class
478 acting like an interface). SQDepthLevel and BaseTagKey are now
480 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
481 and associated accessors. Doxygenation of the class.
482 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
484 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
485 Use SQDepthLevel accessor instead. ::Print() adapted.
486 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
487 - src/gdcmDocument.cxx changed accordingly.
489 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
491 - The following is the doxygen comment of the typedef declaration
492 of gdcmagKey in src/gdcmCommon.h:
493 gdcmTagKey is made to old an "universal" (as in URL, Universal
494 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
495 A dicom tag allways has a group and an element, but a set of tags
496 embeded in various (optionally nested) sequences and sharing
497 the same group and element all share the same (group, element)
498 "identifier". Hence the (group, element) cannot be used as an
499 identifier (in gdcm we shall refer to a "TagKey") of a tag.
500 In order to construct a proper tag identifier (i.e. a key) we
501 consider the following definition of a TagKey:
502 - let Group, Element be the string representation of the
503 group and element dicom tag members,
504 - let ItemNumber be the string representation of the integer
505 index of the considered item number of a sequence,
506 Let the key of a tag embeded in a sequence, noted SeqTag, be
508 /ItemNumber#Group|Element
509 where "/", "#" and "|" are characters acting as separators.
510 Then the general form of a gdcmTagKey is given by:
511 Group|Element<SeqTag>
512 where <SeqTag> means NO or many instances of SeqTag.
513 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
516 but the gdcmTagKey of a tag "embeded" is the first item of
517 a sequence, itself nested in the third item of a sequence is the
519 0004|1220/2#0008|0082/0#0008|0090
520 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
521 order to hold the new sequence compatible key. Previously, the
522 GetKey() method would look in the underlying gdcmDictEntry.
523 - src/gdcmDocEntry.cxx:
524 -- constructor now copies the underlying DictEntry key, in the local
526 -- ::Print: displays the member Key, instead of the (group, element).
527 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
528 - src/gdcmDocEntrySet.h:xi
529 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
530 -- now has a new BaseTagKey member.
532 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
533 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
535 This poses the problem with the semantics of the following lines
536 LoadEntryVoidArea(0x0028,0x1201); // R LUT
537 LoadEntryVoidArea(0x0028,0x1202); // G LUT
538 LoadEntryVoidArea(0x0028,0x1203); // B LUT
539 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
540 to the long FIXME note for what the problem is. Nevertheless in
541 order to get things working the dicom dictionary was altered !
542 Please fix things urgently...
543 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
544 information), see above note on moving the member VoidArea. Nevertheless
545 the following entries previously correctly set as US are now inproperly
547 0028 1201 OW IMG Red Palette Color Lookup Table Data
548 0028 1202 OW IMG Green Palette Color Lookup Table Data
549 0028 1203 OW IMG Blue Palette Color Lookup Table Data
550 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
551 of gdcmDocEntry moved to gdcmSeqEntry.
552 * src/gdcmSeqEntry.cxx: STYLE.
554 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
555 * Test/TestAllEntryVerify.cxx minor fix and added comments.
557 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * gdcmPython/testSuite.py: all the test suite in python is now moved
559 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
560 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
561 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
563 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
564 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
565 to avoid inclusion recursion until STL is reached.
566 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
567 mecanism. errno.h is not included in gdcm anymore.
568 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
569 (gdcmFormatError now inherits from gdcmFormatUnexpected).
571 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
572 gdcmData/TestAllEntryVerifyReference.txt
573 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
574 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
575 exception_on_error parameter.
576 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
577 - vtk/vtkGdcmReader.cxx changed accordingly,
578 - Example/*.cxx and Test/*.cxx changed accordingly.
580 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
582 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
583 enable_sequences removed from gdcmHeader constructor and dependencies.
584 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
585 * gdcmPython/demo/PrintHeader.py: dummy fix.
586 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
587 skip_shadow removed from gdcmHeader constructor and dependencies.
588 * Example/*.cxx and Test/*.cxx changed accordingly.
590 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
592 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
594 2004-07-21 Jean-Pierre Roux
595 * FIX Now, Parsing and Printing a DICOMDIR do work!
596 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
598 2004-07-20 Jean-Pierre Roux
599 * FIX Some brain damaged headers have Zero-Lenght fields
600 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
602 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
603 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
604 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
605 variable (instance of gdcmDebug) by a definition macro, and the instance
606 is now in static in the gdcmDebug class
607 * src/gdcmSQItem.h : (FIXME) remove an undefined method
608 * Test/PrintAllDocument.cxx : bug fix in the result of the test
610 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * WARNING: ctest now depends more tightly on gdcmData. You should
612 check out gdcmData properly for things to run smoothly...
613 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
614 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
615 we need the pixels not be loaded in order to use the ValEntry
616 that displays position and size).
617 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
618 This is a C++ based equivalent of gdcmPython/testSuite.py that should
619 be deprecated. If you have any doubts about the advantages of a
620 modern scripting language (read Python) versus grass root C++ (i.e.
621 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
622 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
623 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
624 Anyhow, consider documenting the gdcmData images in
625 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
627 * Test/CMakeLists.txt:
628 - now uses TestAllEntryVerify.cxx
629 - specific comments on oldACR00001.ima (now renamed in gdcmData
630 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
631 gdcmData/TestAllEntryVerifyReference.txt
634 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * src/*.[h|cxx] : typedef clean up
636 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
637 - TagKey renamed to gdcmTagKey (for external usage)
638 - VRKey renamed to gdcmVRKey (for external usage)
639 - removal of typedef duplication.
640 - Removed all unecessary inline keyword from class inline definitions.
641 - Some method|function(void) declarations replaced with method|function().
642 * src/jpeg/libijg12/jdhuff12.c:
643 - printf polluting ctest removed.
644 - TAB removal for comminting
646 - TestAllReadCompareDicom.cxx: added a test that compares all the
647 images in gdcmDataImages.h with corresponding images in
648 gdcmData/BaselineDicom/. When baseline images are not present
649 this test creates them.
650 Note: we need to validate each reference image, but before that
651 I'd like to rename them with a more explicit name...
652 - CMakeLists.txt: changed accordingly.
653 * Example/*.cxx: examples now only include gdcm.h (as opposed to
654 including each header needed).
656 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
657 * Test/*.cxx and Example/*.cxx: moved some examples away from the
658 test suite to the Example directory. Are concerned:
663 - TestWriteSimple.cxx
664 * Test/CMakeLists.txt: added some comments on reasons for black listing
665 image gdcmData/oldACR00001.ima
667 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Test/CmakeList.txt: removed the following from black list (to be coherent
669 with removal from gdcmData):
670 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
671 - gdcm-MR-PHILIPS-16.dcm
673 Added the following because after last cvs update, they cause
674 ctest -R TestReadWriteReadCompare
676 - gdcm-MR-SIEMENS-16-1.acr
678 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
679 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
680 new comments in this file) we temporarily (sigh) move to a weaker
682 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
683 we don't need to black list the following images anymore:
684 - 8BitsUncompressedColor.dcm
686 - US-PAL-8-10x-echo.dcm
687 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
688 fixes and the beautified code ;-)
689 This fixes the bug introduced in version 1.42 (when beautifying)
690 that made the parsing of 8BitsRunLengthColor.dcm unproper.
691 Note: ctest was blind to this bug (this means we need to still
692 improve the test suite). The bug could be detected by using
693 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
695 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
696 and by displaying the (garbage) produced file temp.XDCM...
698 2004-06-29 Jean-Pierre Roux
699 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
700 - replace by uggly but working old code :-(
701 A lot of things should be OK again.
702 It's really urgent to have a test suite that *tests*,
703 to prevent Frog's beautifying sessions to break all the stuff
704 (twice, withing a fortnigh ...)
706 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
707 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
708 redundancy) to added Test/TestReadWriteReadCompare.cxx
709 * Test/CmakeList.txt: because the compare test of
710 Test/TestReadWriteReadCompare.cxx fails, the following images are
711 black listed: - 8BitsUncompressedColor.dcm
713 - US-PAL-8-10x-echo.dcm
714 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
715 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
716 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
717 and ad-hoc kludge. This kludge is now removed, and on encountering
718 such an image (OB field brain damaged) we set errno. Then in
719 ::FindDocLength() we "fix" the length as being ALL what remains
720 in the file (until EOF). We then proceed, hoping for the best...
721 This fixes a SegFault in ShowDicom when trying to write such an
723 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
724 (because TestWriteRead breaks on it, after a non conformal commit?).
725 ctest now runs properly, except for MakeDicomDir (which was allways
726 broken) and the Python related stuff (still not fixed).
728 2004-06-24 Jean-Pierre Roux
729 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
730 FIX : Test/TestReadWrite now iterates on all the file names
731 (instead of infinite loop)
732 ENH : Test/TestWriteRead now iterates on all the file names
734 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
737 2004-06-24 Jean-Pierre Roux
738 FIX : - now Write drops LUT Descriptors and LUTs (if any)
739 when SamplesPerPixel =3
740 - now Write is no longer confused by
741 'BitsAllocated = 12" and 'BitsStored=12"
742 - "UN" value representation Elements are now written correctly
743 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
744 ENH : - now gdcmHeader has its own Write methods
745 (in order to split the job that has not to be done
748 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
750 loop on the same image until memory went out.
751 Note: this means we still have gobs of memory loss in PrintDocument
752 * src/gdcmDocument.cxx: fixes problem on parsing on file
753 gdcmData/16BitsJpegLosslessGrayScale.dcm.
755 2004-06-24 Jean-Pierre Roux
756 FIX : Write - All the Sequences and Sequence Item are now written
757 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
758 is added a the end, when necessary.
759 - A lot of brain-damaged images, that were read correctly are
760 now written correctly
761 - length compatible BinEntry are now loaded correctly
762 (even for odd groups)
763 Note : only Explicit Value Representation was checked.
764 (question : is implicit VR really necessary for gdcm ?)
766 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
767 * DEVELOPPER: added a proposition of coding style.
768 * src/gdcmDocEntry.h: removed every inline declaration (for test of
771 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
773 Use the gdcmDocEntry::Print() and Write() instead.
774 * src/gdcmDocument.cxx: bug fix.
776 2004-06-22 Jean-Pierre Roux
777 FIX : gdcmDocument.cxx
778 - Now we do recognize the JpegLossLess format (there was a misstyping in
779 code 'beautyfication' :-(
780 - Now we automaticaticaly load the Luts, if any
782 2004-06-22 Jean-Pierre Roux
783 In order : to write Sequences, whatever their imbrication level,
784 : to allow user to create his own Sequences
785 a lot of modif where necessary (adding, moving, or virtualising methods)
787 WARNING : save your own sources *before* cvs up !
790 ADD virtual void Write(FILE *fp, FileType filetype);
793 ADD virtual void Write(FILE *fp, FileType filetype);
794 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
797 ADD virtual void Write (FILE *fp, FileType filetype)=0;
798 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
799 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
800 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
801 ADD std::string GetEntryByName(TagName name);
802 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
804 std::string vr = "unkn",
805 std::string fourth = "unkn",
806 std::string name = "unkn");
807 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
808 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
809 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
810 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
811 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
812 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
813 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
814 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
817 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
818 ADD virtual std::string GetEntryByName (TagName tagName);
819 ADD virtual std::string GetEntryVRByName (TagName tagName);
820 REM virtual bool Write(FILE *, FileType);
821 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
822 FILE *_fp, FileType type);
823 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
824 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
825 REM virtual bool WriteEntries(FILE *_fp,FileType type);
826 REM virtual std::string GetEntryByName (std::string tagName);
827 REM virtual std::string GetEntryVRByName (std::string tagName);
828 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
829 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
830 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
832 std::string vr = "unkn",
833 std::string fourth = "unkn",
834 std::string name = "unkn");
835 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
836 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
837 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
838 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
841 ADD virtual void Write(FILE *fp, FileType filetype);
844 ADD virtual void Write(FILE *fp,FileType filetype);
847 ADD virtual void Write(FILE *fp, FileType filetype);
848 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
849 REM std::string GetEntryByNumber(guint16 group, guint16 element);
850 REM std::string GetEntryByName(TagName name);
853 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
855 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
857 The default constructor invoked by the line
858 gdcmHeader *f1 = new gdcmHeader( header );
859 was gdcmHeader::gdcmHeader(bool) instead of the expected
860 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
861 Hence the parsing wasn't executed... See also below.
862 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
863 as explicit constructor didn't do the trick to fix the above problem.
864 Could anyone explain why ?
865 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
866 properly calls gdcmValEntry::Print() (that was weed out from
867 code related to gdcmBinEntry).
869 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * In order to fix memory leaks:
871 - Test/TestWriteSimple.cxx: added cleaning of free store through
873 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
874 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
875 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
876 (through the call to ::AddDicomDirMeta()) or the destructor
877 would crash when deleting uninitialized ::metaElems].
878 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
879 - src/gdcmDocument.cxx:
880 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
882 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
883 was causing memory leaks.
884 - src/gdcmSQItem.cxx:
885 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
886 cleanly handled with polymophism: sorry but my milage is low).
887 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
888 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
889 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
890 This avoids SegFaulting.
891 - src/gdcmSQItem.h: coding style.
893 - Test/TestWriteSimple still severely sucks. The output image content
894 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
895 damaged when displayed with vtkgdcmViewer.
896 - on memory leaks: TestWriteSimple leaks really less (see entry
897 of 2004-06-18 in Changelog file for the call to valgrind).
898 - on segfaults: ctest now passes all the tests but one (no more
900 * Erroneous leading white fix:
901 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
902 white[s] (as opposed to from >> xxx, that removes it [them].
903 - src/gdcmTS.cxx: ditto.
904 - gdcmPython/testSuite.py: dirty related kludge removed.
905 * src/*: remaining references to gdcmParser removed.
906 * src/*[cxx|h]: added copy[way]left header.
909 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
910 * In order to fix writing of dicom files:
911 - Test/TestWriteSimple.cxx: a simpler example of writing.
912 - Test/CMakeLists.txt changed accordingly.
913 - src/gdcmDocument.cxx:
914 -- The destructor now recursilvely removes potential sequences.
915 -- Bug fix in ::IsJPEG2000()
916 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
917 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
919 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
920 to only declared) and build on top of
921 ::GetDocEntryByNumber(guint16, guint16).
922 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
923 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
924 for usage in destructor and treatement of promotion in
925 ::ReplaceOrCreateByNumber().
926 - src/gdcmSQItem.cxx: destructor should better handle his job.
927 Test/TestWriteSimple now runs (or at least it DOES something).
928 * We can now start hutting memory links. A good starting point is:
929 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
930 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
931 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
933 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * Valgrind note: after Mathieu Malaterre teached me how to read
935 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
937 Using gcc, you can force the STL to use malloc and to free memory as
938 soon as possible by globally disabling memory caching.
939 With 3.2.2 and later, you should export the environment variable
940 GLIBCPP_FORCE_NEW before running your program.
941 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
942 simply vanish (it is still not clear to me, whether this means that
943 STL std::string leaks or if valgrind believes it leaks...).
944 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
945 running bin/gdcmTests makeDicomDir):
946 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
947 - Test/makeDicomDir.cxx now properly traps empty lists and returns
949 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
950 SegFaulting (I drowned in DicomDir related code when trying to
951 understand why the list is empty...).
952 * src/gdcmDocument.h: first BSD license header try.
953 * Doc/License.txt added.
955 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
956 * src/gdcmDocument.[h|cxx]:
957 - Clean up of the Transfer related predicates. They are now all based
958 on new method isGivenTransferSyntax, that (should) handle properly
960 - general clean up, simplification, and coding style.
961 - Specific clean up of Parse7FE0() (umproperly named actually).
962 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
964 2004-06-14 Jean-Pierre Roux
966 - fix the display of Sequence Delimitor (SQDepthLevel pb)
967 - fix the display of SQItem ordinal number
968 - add the GetSQItemByOrdinalNumber method
969 - remove some useless never written private methods
971 2004-06-14 Jean-Pierre Roux
973 - adding a constructor taking a gdcmDocEntry as an input param
974 - ReplaceOrCreateByNumber now returns :
975 a gdcmBinEntry * if a Binary (void *) value is passed as a param
976 a gdcmValEntry * if a string value is passed as a param
978 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
979 according to the param type (no longer sets a gdcmDocEntry)
980 - GetValEntryByNumber, GetBinEntryByNumber added
981 - NewValEntryByNumber and NewBinEntryByNumber added
983 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
985 - GetSQItemNumber and SetSQItemNumber added, to provide
986 a (relative) Item identier inside a given Sequence
987 \warning : some pb remaining around this number
989 - AddEntry now takes the Item Number as a param
991 - adding a constructor taking a gdcmDocEntry as an input param
993 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * Memory leak hunt with the following command:
995 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
996 --show-reachable=yes gdcmTests PrintDocument
997 It looks like many (all?) leaks are due to the STL (or a bad usage
998 of the STL. The lines producing the leaks now have a comment with
999 a "MEMORY LEAK" tag: you can retrieve them with
1000 grep "MEMORY LEAK" src/*
1001 Here are two typical examples which I can't help fixing:
1006 char * test = "babo";
1007 name = test; //// <--- valgrind detects 960 bytes lost in
1008 //// call to std::string::operator=(char const*)
1009 name.clear(); //// Doesn't help !
1017 std::cout << "Type a bunch of characters followed by RETURN: ";
1018 getline(std::cin, line); //// <--- valgrind dectects a loss
1019 //// of 1320 bytes in call to
1020 /// std::basic_istream<>& std::getline<>
1026 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * src/gdcmHeader.[cxx|h]:
1028 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1029 and related, moved away to gdcmDocument.
1030 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1031 the corresponding protected accessors of inherited class
1032 gdcmDocument, removed ! As a consequence gdcmFile had to be
1033 declared friend of class gdcmDocument (see below).
1034 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1035 - Clean up of undefined or unused methods.
1036 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1037 account the changes to gdcmHeader.h).
1038 * src/gdcmDocument.h:
1039 - gdcmFile is now a friend class (in order to take into account the
1040 changes to gdcmHeader.h).
1041 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1042 (see changes to gdcmHeader.h).
1043 - Accessors (reading on the form GetEntry*) are now public.
1044 - Clean up of undefined or unused methods.
1045 * src/gdcmDocument.cxx:
1046 - adaptation to changes to gdcmDocument.h
1047 - ::OpenFile now writes a verbose message when file cannot be opened.
1048 - some std::string properly set to VRKey
1049 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1050 references to gdcmDocument.
1051 * Test/TestFindTags.cxx: changed accordingly to above changes.
1052 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1053 cvs repository gdcmData.
1055 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1056 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1057 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1058 conflicts with gdcmValEntry::voidArea.
1059 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1060 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1061 Value representation between StringRepresentable and BinaryRepresentable.
1062 * src/gdcmDocument.cxx:
1063 - method ParseDES: proper indentation restored and usage of
1064 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1065 - method LoadDocEntry: the fingerprint left in the SetValue() of
1066 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1067 removed. Reverting to previous code segment with the proper
1068 dynamic_cast< gdcmValEntry* >.
1069 Note: this was (partially) breaking the python test suite
1070 (gdcmPython/testSuite.py) that made usage of the above
1071 fingerprint to check presence of "Pixel Data".
1072 * src/gdcmDocEntry.h: coding style.
1073 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1074 now taken into account.
1075 * gdcmPython/gdcm.i: adaptation to the new internal representation
1076 of gdcm (exit gdcmParser, hello gdcmDocument).
1077 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1079 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1080 anymore, but instead prints the loaded Python dictionary.
1081 * .... alas, the python testSuite is still broken.
1083 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1084 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1086 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1087 * src/gdcmUtil.h : export methods
1089 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1090 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1092 * Initial addition of automatic python testing
1093 * Initial addition of automatic image comparison
1095 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1096 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1097 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1099 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1100 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1101 * Test/ShowDicom.cxx : bug fix for msvc compilation
1102 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1104 2004-05-04 Jean-Pierre Roux
1105 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1106 new concepts (and new classes) :
1107 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1108 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1109 - Sequence Doc Entries (gdcmSeqEntries)
1110 a Sequence is composed of Items.
1111 Each item is a set of Doc Entries (this is recursive)
1112 The non uniqueness of the 'Dicom tag' is due to this recursivity
1113 (never taken into account)
1114 Our unability to add a new 'entry' in the header
1115 at the proper location (neither in the H-Table (map or multimap),
1116 nor in the Chained List is also due to this recursivity.
1117 Don't try, right now, to use/modify/compile these new sources :
1118 nothing is finished.
1119 We just commit all the stuff, 'as is', in order not to loose it.
1121 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1122 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1124 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1125 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1126 file prefix (SetFilePrefix)
1128 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1129 * Add a new test: ShowDicom, for now this is just the c++ version of
1130 checkRead.sh, later it will be able to compare the image read against a
1132 * Replace the DEBUG on the stack with a global entry in cmake interface:
1133 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1135 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1136 * Add an example subdir, with a real example on how to read + write a
1139 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1141 * Doc/CMakeLists.txt: the main page is now properly differentiated
1142 between the developper and user version.
1143 * Doc/doxygen.config.in: dropped search related obsolete flags
1144 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1146 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1147 * DEVELOPPER: added some helpfull comments for compile/test/install
1150 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1151 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1152 src directory, now generated in the build dir.
1153 2. Tests as mentionned smarter
1155 4. Add a new method in gdcmDict that return the PubDict by name
1156 this is interesting for 3rd party lib like ITK,
1157 where we could set the institution name / patient name...
1159 * ENH: 1. Now the test suite is working for real
1160 2. All binaries are now output in the gdcm-bin directory
1161 (this was not true before)
1163 2004-04-28 Jean-Pierre Roux
1164 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1165 SeQuence indented printing of Dicom Header.
1166 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1167 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1168 Computation of SQDepthLevel is now part of gdcmHeader constructor
1169 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1170 tree-like structure of a Dicom Header.
1171 * FIX Test code cleaning
1173 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * ENH: Adding automatic testing
1175 1. Need a DartConfig.cmake to submit to public
1176 2. Add a test driver gdcmTest.cxx
1177 3. gdcmTestMain, an helper for the main test driver gdcmTest
1178 4. Files in Test don't have a main anymore, this becomes interesting
1179 when we add more and more tests, thus dsw don't have to load
1181 * ENH: Adding a GDCM_DATA_ROOT for testing
1182 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1183 one file instead of seven + some small cleanup
1185 2004-04-22 Jean-Pierre Roux
1186 * ENH Minor changes to the Print() methods.
1187 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1188 Header printing. Example given with :
1189 > PrintHeader fileName 2 new
1190 (SQ based tree-like structure still to be done for the Header ...)
1192 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1193 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1194 1. I have added some unsigned where needed
1195 2. Some function parameter not used -> (void)
1196 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1197 4. g++ don't like character '\' in comment
1198 5. #define jpeg_create_decompress jCreaDecompress
1199 this really need to be fixed
1200 6. virtualize destructor of gdcmObject ... leakage
1201 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1202 this also really need to be fixed
1203 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1204 remove compression file
1205 (as we only do decompression, right ?)
1206 * ENH: Change malloc/calloc/free with c++ equivalent
1208 2004-04-21 Jean-Pierre Roux
1209 * FIX gdcmHeaderHelper::GetXSpacing
1210 when a single value is found (bug ?), xpacing is now
1211 defaulted to yspacing
1213 2004-04-19 Jean-Pierre Roux
1214 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1215 * ENH add parameters :
1216 bool exception_on_error = false,
1217 bool enable_sequences = false,
1218 bool ignore_shadow = false
1219 to the gdcmFile constructors to be full gdcmParser compliant
1220 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1221 to allow reading of PAPYRUS 3.0 files
1223 2004-04-06 Jean-Pierre Roux
1224 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1226 2004-04-02 Jean-Pierre Roux
1227 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1228 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1229 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1231 2004-03-30 Jean-Pierre Roux
1232 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1233 for ACR file, written out as DICOM files (hope so...)
1235 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1236 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1237 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1238 moved to base class gdcmParser and only the specialisation is kept
1240 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1241 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1242 already does the job.
1243 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1244 (to be consistent with gdcmParser::WriteEntries).
1246 2004-03-30 Benoit Regrain
1247 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1248 upate of the object's instance. It's passed to 2 in the unfavorable
1249 case : one in the ExecuteInformation, one in the ExecuteData
1251 2004-03-29 Jean-Pierre Roux
1252 * ENH : Check on file type to be written moved
1253 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1254 * FIX : gdcmObject::ResetBoundaries now stops properly
1255 when end-of-list is reached
1256 : gdcmVersion modified (as Benoit Regrain asked)
1258 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1260 * src/gdcmUtil.cxx: added forgotten iostream include.
1261 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1262 equivalent to ExplicitVR in existing code).
1264 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1266 now contains all the gdcmGlobal related code.
1267 * minor coding style and doxygenation changes.
1269 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1270 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1271 now contains all the Debug related code.
1272 * minor clean-up of includes in src/*.cxx
1273 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1274 CreateCleanString) removed.
1275 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1276 * Doc/DoxyMainPageUser.txt added.
1277 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1278 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1279 src/gdcmDirList.cxx)
1281 2004-03-24 Jean-Pierre Roux
1282 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1284 2004-03-23 Jean-Pierre Roux
1285 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1286 big endian made volumes
1287 * ENH Now gdcmParser constructor and destructor are protected to forbid
1288 end user to instanciate class gdcmParser
1289 (only gdcmHeader and gdcmDicomDir are meaningfull)
1291 2004-03-22 Benoit Regrain
1292 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1293 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1294 gdcmSerie to gdcmDicomDirSerie
1296 2004-03-19 Jean-Pierre Roux
1297 * ENH Now the tree-like structure describing a DICOMDIR comming from
1298 an already existing DICOMDIR file is consistent with
1299 the home-made tree-like structure build ex-nihilo
1300 or build from the files held (recursively) in a Directory
1301 functions gdcmDicomDir::CheckBoundaries()
1302 gdcmObject::SetBoundaries() added
1304 2004-03-17 Jean-Pierre Roux
1305 * REM (Eric Boix bug) : removal of meaningless
1306 gdcmDicomDirImage::NewImage function.
1307 * FIX now file names and directory name are written properly in the
1309 * FIX now gdcmDicomDir constructor may be call without any trick
1312 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1313 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1314 of gdcmDicomDirImage::NewImage as empty function.
1316 2004-02-28 Jean-Pierre Roux
1317 * ENH add gdcmDicomDir:NewPatient
1318 add gdcmDicomDirPatient:NewStudy
1319 add gdcmDicomDirStudy:NewSerie
1320 add gdcmDicomDirSerie:NewImage
1321 to allow making gdcDicomDir object.
1322 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1323 (as opposite to the gdcmHeader chained list)
1325 2004-02-11 Benoit Regrain
1326 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1327 when using from python
1329 2004-02-10 Benoit Regrain
1330 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1331 * FIX : in gdcmDicomDir when the directory is empty
1332 * ENH : add callback and methods to get the progression of dicomDir
1335 2004-02-06 Jean-Pierre Roux
1336 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1337 - GDCM_META added to gdcmDicomDirType
1338 - class gdcmMeta created
1339 * ENH : - A brief summary is now displayed at the beginning of
1340 'testDicomDir' to help disaster magnitude estimation
1341 * REM : Now useless Test/explDICOMDIR.cxx
1343 2004-02-05 Benoit Regrain
1344 * ENH : add methods in gdcmObject to get the hash table or the list of
1346 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1347 * FIX : wrapping python for TagHeaderEntryHT
1349 2004-02-04 Benoit Regrain
1350 * FIX : even length for some strings when writting the dicom dir
1351 * FIX : sort the images in the dicom dir
1352 * FIX : Bug fix for python use of dicom dir
1353 * ADD : a python demo
1355 2004-02-04 Jean-Pierre Roux
1356 * FIX : Final solution (?) for icone embedded images
1357 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1358 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1359 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1360 gdcmData/gdcm-MR-SIEMENS-16.acr1
1361 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1362 to make full checking easier
1364 2004-02-04 Benoit Regrain
1365 * FIX : WriteEntries : coding style & logic in parameters
1366 * FIX : Set the elements to create the DicomDir in a dictionary file
1368 2004-02-03 Benoit Regrain
1369 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1370 * gdcmDicomDir : add the load of directory
1371 * Bug fix and print add-on
1373 2004-02-03 Jean-Pierre Roux
1374 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1375 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1376 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1377 * FIX gdcmParser.cxx : 'group length' elements are now considered
1378 as integers, even for shadow groups, when file is Implicit VR
1380 2004-02-02 Jean-Pierre Roux
1381 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1383 of the last synonym :-(
1384 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1386 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1387 * FIX taking into account the possible 7fe0,0010 multiplicity
1388 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1389 to allow removal of references to 7fe0,0010, to deal with
1390 ACR-NEMA images, when 0028,0200 is meaningfull
1392 2004-01-31 Jean-Pierre Roux
1393 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1394 no longer writes 'Un' on disk
1395 * FIX SQ elements with actual length are now dealt with corectly
1396 * FIX gdcmFile::WriteBase make the difference, for color images, between
1397 the length (for Palette expanded images)
1398 and Raw Length (non expanded image + Palette)
1399 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1400 (that broke Write). Replaced by UL.
1401 Aware user will reload the field if he
1402 thinks it's necesssary
1404 2004-01-30 Jean-Pierre Roux
1405 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1406 when 'dirty Acr' is found, to be compliant with the new
1407 IsReadable() methods.
1409 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1410 (no DOUBLE images in kosher DICOM,
1411 but so usefull for people that miss them ;-)
1413 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1414 DICOMDIR related utilities (not checked as Windoze compliant)
1416 2004-01-28 Jean-Pierre Roux
1417 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1419 2004-01-27 Jean-Pierre Roux
1420 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1421 to allow skipping the shadow elements, to save memory space.
1422 The TRUE value for this param has to be used
1423 with a FALSE value for the 'enable_sequence' param.
1424 ('public elements' may be embedded in 'shadow Sequences')
1425 * gdcmHeader methods now deal with 'embedded icones images' in the header
1426 (even when an 'icone image sequence' is announced by the
1427 element (0x0088,0x0200), but there is NO icone at all ...
1429 * gdcmHeader sometimes Image Location value doesn't follow
1430 the supposed processor endianity (see gdcmData/cr172241.dcm).
1433 * gdcmHeader add the method
1434 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1435 to get *all* the Header Entries with the same tag.
1436 GetHeaderEntrySameName is probabely *useless*
1437 (no meaning : Name is *not* an identifier within the Dictionnary)
1439 2004-01-26 Benoit Regrain
1440 * Bug fix in the print of hexadecimal representations. Remove long fields
1441 in the print and add a third level of print to print them
1443 2004-01-23 Benoit Regrain
1444 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1445 * Bug fix on test suite after remove the strip made on not string fields
1446 * Split the IsReadable method between gdcmParser which test that the file
1447 is dicom and gdcmHeader which test that it's an image file
1449 2004-01-22 Benoit Regrain
1450 * DicomDir : clean code, add methods, set variables in protected or private
1451 * gdcmUtil : bug fix for the clean string method
1453 2004-01-19 Benoit Regrain
1454 * Add the use of shadow dictionaries
1455 * bug fix and coding style
1457 2004-01-19 Benoit Regrain
1458 * src/gdcmFile.cxx : bug fix concerning the close of file
1459 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1460 * Add the update of header entries using the shadow library
1462 2004-01-19 Benoit Regrain
1463 * removal of file gdcmHeader2.cxx
1464 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1465 inheriting from gdcmParser. This split is to prepare the integration
1466 of dicom dir parsing
1467 * bug fix under python
1469 2004-01-16 Jean-Pierre Roux
1470 * REM removal of class gdcmHeaderEntrySet
1471 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1472 * ADD add file gdcmHeader2.cxx
1473 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1475 2004-01-15 Benoit Regrain
1476 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1477 entries created while parsing the header. Thus, they will be destroyed
1478 when the gdcmDictSet will be destroyed
1479 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1482 2004-01-15 Benoit Regrain
1483 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1484 made a fatal error because of the memory release at the end of program.
1485 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1486 some memory and vtk seems to have some problems with that.
1487 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1489 2004-01-14 Benoit Regrain
1490 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1491 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1492 * src/*.[h|cxx] : make changes due to class name changes
1493 * gdcmPython/demo/*.py : bug fix due to method names
1495 2004-01-13 Benoit Regrain
1496 * src/*.[h|cxx] : coding style
1497 * vtk/*.[h|cxx] : coding style
1499 2004-01-13 Benoit Regrain
1500 * gdcmPython/testSuite.py : test the readable flag of file for tests
1501 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1502 It's lied to the stl compilation by MSVC (windows, always windows...)
1503 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1505 2004-01-12 Benoit Regrain
1506 * src/*.h : add comments
1507 * src/gdcmDictSet.h : set the method BuildDictPath in public
1508 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1509 directly setted in the source code
1510 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1513 2004-01-09 Benoit Regrain
1514 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1515 * setup.py : use a reference to gdcmVERSION
1517 2004-01-07 Benoit Regrain
1518 * Modification to compile with the distutils.
1521 2003-12-10 Benoit Regrain
1522 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1523 can use a gdcmHeaderHelper to load datas
1524 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1525 made in the source code
1527 2003-12-10 Benoit Regrain
1528 * Update Windows projects and .cvsignore files
1530 2003-11-12 Jean-Pierre Roux
1531 * ENH gdcmHeader constructor has one more parameter (default value : false)
1532 that allows the user to 'go inside' the SeQuences only
1534 gdcmElValSet:Print takes it into account
1536 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * ENH: Update gdcmPython/CMakeLists
1538 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1539 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1541 2003-11-10 Jean-Pierre Roux
1542 * FIX : gdcmHeader::LoadElements is now based
1543 on the ListTag listElem member,
1544 not longer on the TagElValueHT tagHt member
1545 * ENH : PrintPubElVal shows (temporarily) both results,
1546 with the tagHt member and the listElem member.
1547 (it's easier to 'see' the problems when using Printheader)
1549 * FIX : old private member LgrElem is now splitted into
1550 ReadLength : Length actually found on disk (updated only
1551 if bug fixing is necessary), for internal
1553 UsableLength : Updated by FixFoundLength, to fix a bug
1554 or to allow Parser going on.
1555 Will allow to re-write a kosher header when a SeQuence
1556 with a length (not 0000) is found
1557 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1558 because gdcmElValSet::Add does not update ListElem
1561 2003-11-07 Jean-Pierre Roux
1562 * FIX misstyping in Transfert Syntax name table
1563 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1564 when they have an actual length (not 0000 nor FFFFF)
1565 (Nobody should care of it, but DICOMDIR explorers)
1567 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1568 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1570 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1571 * ENH: vtkGdcmReader now supports LUT !
1572 (vtkgdcmViewer for now is not able to use them though)
1574 2003-11-05 Jean-Pierre Roux
1575 * in testSuite.py : new files names for checking the package
1576 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1577 that returns the pixel area size to the *aware* (vtk) user
1578 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1580 2003-11-05 Benoit Regrain
1581 * in testSuite.py : Modify the rules for checking the paths
1582 : Explicit error messages
1583 * in __init__.py : Related modif
1585 2003-11-03 Jean-Pierre Roux
1586 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1587 to be used by aware (vtk) users that want to manage
1588 LUT (and no to turn the PALETTE image into an RGB pixels one)
1589 * GetPixelType now returns 8U for 24 Bits images
1590 (vtkGdcmReader compliant)
1592 2003-10-31 Jean-Pierre Roux
1593 * Removal of *all* gdcmData images and add them again
1594 in order to loose the 'history' of un-anonymised images
1596 2003-10-31 Jean-Pierre Roux
1597 * RMV : removal of useless jBitsInJsample.h
1598 for both 8 and 12 Bits JPEG Lossy Libraries
1600 2003-10-31 Jean-Pierre Roux
1601 * ENH : Add the functions gdcmFile::GetImageDataRaw
1602 gdcmFile::GetImageDataIntoVectorRaw
1603 that act as GetImageData and GetImageDataIntoVector
1604 except the making of an RGB Plane from Gray Plane + LUT
1605 Intended to aware (vtk) users who know how to manage
1608 GetLUTRGBA return a R,G,B,A LUT if any
1609 lgrTotaleRaw gives the 'Raw' length
1610 GetImageDataRaw returns the gray Plane
1611 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1612 (They stay Grey, just like with other Dicom viewers :-(
1614 2003-10-30 Jean-Pierre Roux
1615 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1617 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1618 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1619 being coherents dicom files.
1621 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1624 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1625 * ENH: Two steps is necessary to please VC++ compiler...
1626 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1627 * ENH: Add include dir to medcon lib
1628 * FIX: only one function is being exported for now !
1629 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1631 2003-10-29 Jean-Pierre Roux
1632 * adding gdcmHeader::GetLUTRGBA
1633 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1634 --> Mathieu, the modif u're waiting for is not yet committed
1635 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1637 2003-10-27 Jean-Pierre Roux
1638 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1639 00191113.dcm DermaColorLossLess.dcm
1640 MxTwinLossLess.dcm RadBWLossLess.dcm
1641 * ENH: For version prior to vtkImageViewer2 -r 1.19
1642 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1644 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * Removal of ido stuff in CMakeLists.txt
1647 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1648 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1649 * FIX: remove a call to ->Modified ... see comments
1650 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1652 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1653 * FIX: Problem with path for libvtkgdcmPython
1654 * ENH: Try adding a search script for python site-package
1655 * RMV: Remove some file from medcon lib that are not necessary
1656 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1657 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1658 * FIX: More pragma disable fro VC++,
1659 I don't think I break something as it is also disable in VTK/ITK.
1660 But it fasten debug compilation time.
1662 2003-10-23 Jean-Pierre Roux
1663 * gdcm now deals with 16 Bits Run Length Encoded images
1664 (they are compressed as 2 planes images,
1665 one for the high Bytes, the other for low Bytes)
1667 2003-10-22 Jean-Pierre Roux
1668 * Now CheckRead takes into account :
1669 - the bugged 'Leonardo' Siemens images
1670 - the XA images, sent thru the burning VPRO station
1671 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1674 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1675 * FIX: When copying a Makefile.am to CMakeLists.txt
1676 one should remove the '\'
1678 2003-10-22 Jean-Pierre Roux
1679 * in gdcmData adding a bugged 'Leonardo' Siemens image
1680 (wrong lengths in header)
1681 OK with gdcm, KO with the other viewers :-)
1682 * add a GE dlx XA image, thru the VEPRO burning station
1685 2003-10-21 Jean-Pierre Roux
1686 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1687 for a brutal checking of vtkgdcmViewer compliance
1689 2003-10-21 Jean-Pierre Roux
1690 * add the files for 'xmedcon' Jpeg Lossless library
1691 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1693 2003-10-21 Jean-Pierre Roux
1694 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1696 2003-10-21 Jean-Pierre Roux
1697 * garbage Siemens 'Leonardo' images dealt with
1698 (the patch is easy to remove)
1699 * cosmetic changes to avoid warnings
1701 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1702 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1703 no need to press 'r' now.
1705 2003-10-20 Jean-Pierre Roux
1706 * upgrade of checkRead.sh checkWrite.sh according
1707 to new Jpeg Lossless decompressor
1708 * add US.3405.1.dcm, a genuine RGB medical file ...
1709 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1710 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1712 2003-10-15 Jean-Pierre Roux
1713 * general anonymisation in gdcmData
1714 * adding the 'color files' from
1715 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1716 * adding some well knowed bugged-header images
1717 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1718 waiting for their inclusion in Python testsuite
1720 2003-10-15 Jean-Pierre Roux
1721 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1722 no longer seg faults when file is not found
1724 2003-10-14 Jean-Pierre Roux
1725 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1728 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1729 * TODO: *.in file to genereate a UseGDCM later
1731 2003-10-14 Jean-Pierre Roux
1732 * Some supposed-to-be Dicom Images have no preamble.
1733 OpenFile takes it into account
1734 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1735 * Missing elements added in dicomV3.dic
1736 (just to be affraid : have a look at
1737 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1738 and do it again next year ;->
1740 2003-10-13 Jean-Pierre Roux
1741 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1742 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1743 But there are NOT. It's fixed !
1745 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1746 * FIX: "jpeglib.h" was not found on VC++
1747 * FIX: vtkgdcm was not being installed
1749 2003-10-10 Jean-Pierre Roux
1750 * ENH : OpenFile closes the file if it *really* doesn't look like
1751 an ACR-NEMA / DICOM one.
1752 * FIX : testWrite no longer writes an empty file if the source file
1753 is not gdcm Readable
1754 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1757 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1758 * FIX: CMake generate now documentation
1759 * ENH: out of source doc build !
1760 * ENH: Generate both user and dev documentation
1761 * ENH: Should work on windows too
1762 * ENH: Only one doxygen config.in file is needed
1763 * FIX: make install should be ok now on ùnix plateform
1764 * FIX: PATH to dictionary was wrong (missing /)
1765 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1767 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1768 * vtkGdcmReader is now able to read rgb dicom file.
1769 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1770 * added a gdcmViewer to vtk test, use mouse to control
1771 window level & window width
1773 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * CMake-ification of gdcm, we have now two build system
1775 * FIX: on cygwin Wsock32 doesn't exist
1776 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1778 2003-10-06 Emanuel Ollart
1779 * FIX : compilation process wad broken.
1780 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1782 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * change gdcmViewer -> vtkgdcmViewer
1784 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1786 2003-10-06 Jean-Pierre Roux
1787 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1788 ( e.g : well known GE images with a wrong elem length,
1789 : Philips MRI Images with a wrong Huffman table)
1790 * still to be done : allow the reading of bugged LEONARDO Siemens images
1792 2003-10-03 Jean-Pierre Roux
1793 * Odd length strings are padded with '\0' (not with spaces,
1794 to remain compliant with already defined strings,
1795 like Transfert Syntax UID and others)
1797 2003-10-03 Jean-Pierre Roux
1798 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1799 to allow displaying RGB images (not only by affim ;-)
1801 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * vtkGdcmReader is now able to read rgb dicom file.
1803 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1805 2003-10-03 Jean-Pierre Roux
1806 * A few nasty patches to allow the reading of a lot of nasty images
1807 ( e.g : well known GE images with a wrong elem length,
1808 : Philips MRI Images with a wrong Huffman table)
1809 * still to be done : allow the reading of bugged LEONARDO Siemens images
1811 2003-10-03 Jean-Pierre Roux
1812 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1814 2003-10-03 Jean-Pierre Roux
1815 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1816 to allow displaying RGB images (not only by affim ;-)
1818 2003-10-03 Jean-Pierre Roux
1819 * gdcmFile::GetImageDataIntoVector now
1820 - deals with MultiFrames MultiFragments Run Length Encoded files
1821 - deals with YcBcR (YBR_FULL) files
1822 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1823 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1825 (no sample found :-(
1827 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1828 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1829 Two reasons: - clear things
1830 - third parties acces gdcm through header files, so won't
1831 suffer anymore VC++ complains
1833 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1834 * add argv[1] in testvtkGdcmReader.cxx
1837 2003-09-24 Jean-Pierre Roux
1838 * The lines are now eigthy characters long.for
1839 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1841 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1842 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1843 char* to std::string. Thus, the use of strdup becomes useless. (see
1844 previous commis of Malaterre)
1845 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1846 before the last Malaterre's commit.
1848 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1849 * This commit should fix the Debug building under VC++, the problem
1850 was mainly a mixture of debug and release lib being loaded at startup.
1851 * I also remove a depency to a specific C function: strdup. Because I had
1852 to force the link to msvcrtd (whereas strdup is in libc).
1854 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1856 located in the gdcmCommon.h file. All use of reference of tha has been
1857 changed to now use the variable GDCM_UNFOUND.
1859 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1861 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1862 Dicom dictionary. The test suite can now be run again. Note:
1863 I'm note very happy with the " (RET)" changes. I believe this
1864 RETAINED comment should be dropped when parsing the dictionary.
1865 - PACKAGER corrected
1867 - AUTHORS updated and now in alphabetical order
1868 * Makefile.am now exports gdcm.dsw for Windoze users.
1870 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * cygwin complains about missing std:: in subdir Test/
1873 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1874 * remove some methods that are now in gdcmHeaderHelper
1876 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * vtkGdcmReader set spacing and origin correctly
1879 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * Fix a few delete/delete[] mismatch
1882 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1884 interpretation to data given by gdcmHeader. For instance there are
1885 heuristics to get informations (look at different places).
1886 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1887 sorting DICOM images based on different strategies.
1888 * modified Makefiles accordingly.
1890 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1891 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1892 when building in debug mode
1893 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1894 src/win32/gdcmdll.dsp
1895 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1897 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1898 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1901 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * src/win32/libgdcmjpeg12.dsp was not dos format
1903 * src/win32/libgdcmjpeg12.dsp :
1904 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1905 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1907 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1908 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1910 * src/gdcmFile.cxx : bug fix in affectation type
1911 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1912 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1913 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1914 symbols... future problem ?
1916 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * src/win32/libgdcmijpeg12.dsp was missing
1918 * modified gdcm.dsw accordingly
1920 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1923 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1924 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1925 commit of JPR (before his hollidays to facilitate our work).
1926 * setup.py : bug fix in code. Modifications made while the last commit
1927 of JPR. The code hasn't been tested before the commit... it's so
1928 useless to make that (for best programmer that is JPR) !!!
1930 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1931 * tagged the current version as Version0_3 (i.e. version 0.3)
1933 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1934 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1935 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1936 * *.dsp : modifications to use new libgdcmijpeg8 library
1937 * setup.py : bug fix on VTKPATH variable
1938 * PACKAGER : adding all concerning windows
1940 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1941 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1943 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1944 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1945 test suite reported error.
1946 * PACKAGER file added (describes what a packager must do when
1947 packaging a new release).
1948 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1949 * configure.in: upgraded version number to 0.3.0
1950 * fixing build of rpm (through rpm -ta):
1951 - Doc/Makefile.am exports proper doxygen files
1952 - src/jpeg/libijg8/Makefile.am exports the include files.
1954 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1955 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1956 * src/gdcmHeader.h : formatting code
1958 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1959 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1960 We were obtaining error message from vtk. Now, creation of file list
1961 is made in an internal list to prevent this problem.
1962 Bug fix when output is empty.
1963 Bug fix in update of progress value. Previous commit for this was a bad
1965 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1967 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1968 * src/gdcmHeader.h : added method to get the file name
1969 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1970 files. Added method to remove all files on the input
1971 Added FIXME comment concerning the bad parsing of header made by
1972 ExecuteInformation method (in ExecuteData method)
1974 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1976 when using make instal.
1977 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1978 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1980 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1981 * setup.py : adding include dir of jpeg lib to compile all sources
1982 * */Win32/*.dsp : JPR fix for windows compilation
1984 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1985 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1987 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1988 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1990 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1991 * setup.py is again effective on un*x (takes into account the
1992 addon of the jpeg library)
1993 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1994 * Doc/Doxy* updated (includes above enhancements)
1995 * INSTALL now points to web documentation
1997 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * src/gdcmHeader.h doesn't make unnecessary reference to
2000 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2002 * src/gdcm*.[cxx|h] :
2003 - to allow compilation with gcc 3.x
2004 -- clean up of STL usage (added explicit usage of std::)
2005 -- small fixes on exceptions.
2006 Note: linking not tested !
2007 - clean of doxygen comments to avoid warnings at documentation
2009 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2010 dependent convertion).
2012 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2013 * Clean up of previous JPR garbage commit (not even commented in the
2015 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2016 - moved all jpeg related files from src to src/jpeg/libijg8, with
2017 addition/modification of Makefile.am and configure.in.
2018 - the testSuite is still brain damage (not guilty).
2020 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2021 * WrapVTK.py : modifications to get correctly vtk source files to
2023 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2024 (FileName -> Filename)
2026 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2027 * vtk/vtkGdcmReader.[cxx/h]:
2028 - UpdateProgress method should now be effective
2029 - removed the limitation on having only images loaded (as opposed
2031 - when building a stack of images/volume, a lesser number of
2032 gdcmHeader and gdcmFile instances should be used (hopefully
2033 accelerating things).
2034 - when building a stack of images/volumes, files which are not
2035 loadable (wrong path-filename, wrong permissions on existing file,
2036 or file not parsable by gdcm) are replaced with a black image
2037 in the stack (for the caller to notice the problem).
2039 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2040 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2042 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2043 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2044 between standard library (std) and vtk library (problems are found
2045 under Windows... thanks Windows !)
2047 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2050 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2052 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2055 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * When compiling with distutils (see setup.py) the C++ compiler is
2057 called with different flags than the default ones (with automake).
2058 In order to fix all those warning, I compiled gdcm with the command
2059 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2060 and went for warning fixes:
2061 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2062 up from unused variables.
2063 - vtk/vtkGdcmReader.cxx: potential bug fix.
2064 * src/gdcmHeader.h: Doxygen warning cleanup
2066 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2067 * gdcmPython/gdcm.i:
2068 - typemaps correction to take into account the systematic replacement
2069 of "using namespace std" with std:: prefix e.g. std::list,
2070 std::string... (cf changes of 2003-05-21).
2071 - gdcmGlob global variable of type gdcmGlobal (defined in
2072 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2073 exported to Python a as cvar.
2074 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2075 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2076 gdcmDictSet.GetPubDictTagNames() and
2077 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2078 C++ static methods).
2079 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2080 with the above changes.
2082 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2083 * setup.py, manifest.in : bug fix under linux
2085 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2086 * Modification of setup.py to compile vtk part too. Then, we have 2
2087 wrappers which must work with same distutils. For that, we have a
2088 generic distutils in distusiltsWrapping.py ; with :
2089 - build_extWrap class to wrap generically all extensions,
2090 - ExtensionWrap base class for all wrapping extension that contains
2092 - Wrapper interface which wrap sources
2093 + In WrapSwig.py we have extension and wrapper for Swig
2094 + In WrapVTK.py we have extension and wrapper for VTK
2095 * MANIFEST.in : modifications to consider vtk directory and new python
2096 files for compilation
2098 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2099 * Added python wrappers of vtkGdcmReader vtk class (see the
2100 source in vtk/vtkGdcmReader.cxx) :
2101 - vtk/Makefile.am now builds a library
2102 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2103 python library (as opposed to _gdcm.so wich are the python
2104 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2105 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2107 - configure.in has an additional flag --enable-vtk that needs
2108 to be set to enable compilation of vtk related code, that is:
2109 + vtk/vtkGdcmReader.so and
2110 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2111 + gdcmPython/vtkgdcmPython.so (see above)
2112 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2113 be read when compressed or when HighBit + 1 != BitsStored),
2114 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2115 the usage of the python wrapper of vtkGdcmReader vtk class.
2116 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2117 * src/*.[h] all occurences of stl classes are now prefixed with
2118 std::, and all occurences of "using namespace std;" where removed.
2119 This is to avoid pollution of global namespace in included files.
2120 Apparently vtk does not avoid this pitfall: when using both
2121 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2122 collision of various stl members (principally cout...).
2123 * gdcmPython/testSuite.py now cleanly removes temprory generated
2125 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2126 comply with above changes)
2128 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2129 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2130 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2131 vtk data structure (an image Flip was required).
2132 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2133 * cosmetic changes in documentation.
2135 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2136 * src/gdcmHeader.cxx: the constructor no longer exits when an
2137 unexisting file is given as argument.
2138 * The subdirectory Data (containing all the images used for the
2139 test suite) is not part of this repository anymore. A new module
2140 containing those images is now available at
2141 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2142 with the name gdcmData.
2143 All the python scripts (including the package initialisation file
2144 gdcmPython/__init__.py) were adapated to take this change into
2145 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2147 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2148 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2149 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2150 demo of the usage of this class.
2151 Compilation of this vtk part is only done when using the --enable-vtk
2152 at configure (or autogen.sh) stage.
2154 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2155 * More memory link related corrections and documentation fixes.
2157 - maximum info is obtained with a command of the form:
2158 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2159 --show-reachable=yes PrintHeader
2160 - the remaining reachable blocks seem to come from the STL
2161 allocation scheme through the usage of map and list. It looks
2162 like this memory cannot be freed but it is not a memory leak
2163 (in fact further invocation to the STL would recollect the
2164 unused memory allthough it cannot explicitely be freed).
2165 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2166 of displaying an image parsed with gdcm and displayed with VTK.
2167 Note: some images don't seem to work e.g.
2168 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2169 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2170 Allthough this weakens the semantics, it is a ditch attempt to
2171 make gdcm more thread friendly.
2173 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2174 * Memory link hunt (by using valgrind through the command
2175 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2176 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2177 gdcmHeader::_dicom_vr.
2178 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2179 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2181 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2183 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2184 * src/Makefile.am now exports all the necessary include files at
2188 * UpdateGroupLength replaced by new one
2191 * UpdateGroupLength re-written using H-Table
2192 (named UpdateGroupLengthNew untill checks are over)
2194 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2195 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2196 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2198 - gdcmHeader::GetPubElValSet removed.
2199 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2200 UpdateGroupLength, WriteElements, Write.
2201 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2202 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2203 carried the same semantics.
2204 - src/gdcmHeaderIdo.cxx changed accordingly.
2205 - gdcmFile::WriteBase now regroups all the codes from previous
2206 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2207 - enum FileType moved to gdcmCommon.h
2208 * src/gdcmHeader.cxx AddDefault trashed
2209 * gdcmGetXSize added
2210 * getimageDataSize now calls gdcmGetXSize
2211 * Test/*.cxx changed to agree with above changes
2213 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2215 (to avoid double call by end user).
2216 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2217 by end user, since gdcmHeader::gdcmHeader now handles it.
2219 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2220 * gdcm/Doc many doxygen changes:
2221 - Doxyfile now has two different versions, DoxyfileUsers that generates
2222 the html.users end users oriented documentation and
2223 DoxyfileDeveloppers that generates the html.developper developper
2224 oriented documentation.
2225 - README changed accordingly
2226 - requirement.txt removed (old design info moved to TODO).
2227 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2228 DoxyMainPage.txt, DoxyPython.txt provide more information.
2229 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2230 be updated by simply regenerating the docs with doxygen and copying
2231 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2232 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2233 all the tests in the form "if (<map>.count() >1)" were removed.
2234 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2235 ill-formed documentation sections.
2236 * src/gdcmHeader.cxx: ditto
2238 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2239 * setup.py fixed for un*x (needed macro for stdint.h)
2240 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2241 un*ces with sh-utils test utility.
2242 * gdcmPython/demo/test.py renamed to PrintHeader.py
2243 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2244 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2245 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2246 * src/gdcm*.cxx JPR's bad inclusion fixed.
2248 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2250 * gdcmPython/demo/test.py changed accordingly.
2252 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * gdcmPython/Makefile.am fixed linking against libstdc++
2254 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2255 * Swig subdir (historical tests of swig version 1.3.17++) removed
2256 * Test/testChangeEntete.cxx some lines commented out in order to make
2258 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2259 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2261 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2262 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2263 hence the user doesn't need this explicit call.
2264 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2265 i.e. LoadElements() call removed.
2266 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2267 - src/Makefile.am declares the proper flag for g++.
2268 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2269 for adding user defined new tags.
2270 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2271 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2272 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2274 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2275 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2276 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2277 src/Makefile.am : the project should properly compile and install
2278 with the autotools, included the python wrappers part.
2279 * gdcm.spec.in : added a spec file for RPM packaging.
2281 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2282 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2284 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2285 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2286 to exported to the environement (see gdcmPython/testSuite.py
2288 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2289 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2290 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2291 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2292 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2294 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2295 * gdcmPython/__init__.py doesn't crash anymore when running in
2296 in InstallMode or PreInstallMode but with an environement given
2297 value of GDCM_DICT_PATH.
2298 * src/gdcmDictSet.[cxx/h] coding style.
2300 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2301 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2302 * src/gdcm.h general comments moved to TODO, and README
2303 * src/gdcm.h should now be seen as a user commodity (including it
2304 should suffice to fully use gdcm). It is nowhere including within
2305 any of the kernel files src/*.cxx and src/*.h.
2307 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2309 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2311 * src/gdcm*.cxx only include their corresponding include file
2312 (as opposed to gdcm.h)
2313 * gdcmPython/gdcm.i changed accordingly
2314 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2315 the autogen.sh generated "make snapshot" command to work.
2316 * autogen.sh removed history related references to crea package.
2318 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2319 * distutilsSwigCPlusPlus.py work around some swig portability
2322 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2324 was done in a last ditch attempt to get setup.py _really_
2325 operationnal. The python/gdcmPython layaout add the advantage
2326 of hidding away the python related distutils specific files
2327 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2328 Alas, the src directory was out of scope (i.e. it's relative
2329 position to setup.py was ../src) which made things impossible to
2330 handle (see previous version of python/setup.py). Crossing fingers...
2332 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2333 * python/setup.py now works on Un*x. (harder than I thougth)
2334 * python/distutilsSwigCPlusPlus.py can now have include files
2335 among the list of sources.
2337 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2338 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2339 * modifications in MSVC projects
2341 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * As stated by the first lines of Test/ExceptionAndPython/README, it
2343 looks like we can move back to original usage of exception within
2344 src/gdcm* and hence remove the errno stuff that was introduced
2345 as a quick and dirty fixture of this problem (added to the TODO).
2346 * Doc/Doxyfile configuration file for Doxygen and corresponding
2347 README file for usage added.
2348 * Test/testWrite.cxx added. This new test comes from a split of
2349 test.cxx that is now reverted to its original purpous i.e.
2350 testing the proper parsing of a Dicom related file.
2351 testWrite.cxx concentrates on testing the IO part of gdcm.
2352 * Test/bug1.cxx (containing a bug on WIn32) added.
2353 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2354 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2355 whose purpose is to publish the content of the TagNames of the
2356 Dicom public dictionnary were not accessible without an
2357 instance of class gdcmHeader.
2358 - those methods are now static methods of gdcmDictSet and hence
2359 require no instances at all to be invocated.
2360 - within gdcmDictSet this change required to change some method
2361 to class methods (i.e. are now static) among which SetDictPath
2362 (renamed to BuildDictPath) and LoadDefaultPubDict.
2363 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2364 the above changes by calling the new method classes of gdcmDictSet.
2365 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2366 the above to be effective.
2367 * python/gdcmPython: in order to wrap properly the above changes
2368 for Python, swig version now needs to be > 1.3.17.
2369 * python/gdcmPython/Makefile fixed to adapt itself to new
2370 configure/make shema introduced by Johan Montagnat (thanks for the
2371 contribution). Alas this Makefile cannot be turned into a proper
2372 Makefile.am without some heavy changes in the configure.in
2373 (for python dectection).
2374 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2375 now avoids publishing the empty entries.
2377 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2378 * python/setup.py : bug fix concerning install under windows
2379 ExtraPath reused :-P
2380 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2382 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2383 * Dicts/dicomV3.dic : remove double spaces !!!
2384 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2385 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2388 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2389 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2390 method. Doxygenation.
2391 * src/gdcm.h clean up of JPR spurious comments.
2393 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2394 * python/distutilsSwigCPlusPlus.py now properly collects the
2395 shadow classes generated by "swig -c++" (gdcm.py in our case)
2396 when using "python setup.py install".
2397 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2398 reexports the working classes.
2399 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2400 by the classical C errno scheme. This is to prevent an obscure
2401 behavior of the python wrappers when importing wxPython.wx prior
2402 to gdcmPython (which ended up in an abort call). An illustration
2403 of this oddity can be found in the Test/ExceptionAndPython
2404 subdir (see the README file). This problem probably due to
2405 an combination of g++ and dynamic loading.
2406 * added Test/ExceptionAndPython (see above)
2408 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * Changed the layout of the python part to avoid bloating main
2410 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2411 i.e. the distutils arsenal. All the python related stuff is
2412 again in a python subdir, but the package itself is now in
2414 * setup.py was cleaned up:
2415 - pythonIncludePath removed
2416 - python setup.py bdist target is now functional.
2417 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2418 collision with other packages). gdcmPython/demo/*.py changed
2421 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2422 * python subdir moved to gdcmPython (preparation of distutils packaging).
2423 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2424 distutils installer is operational.
2425 * - gdcmPython/__init__.py now properly loads the swig generated
2426 shadow classes (from gdcm.py).
2427 - gdcmPython/demo/*.py changed to import the package gdcmPython
2428 instead of gdcmPython/demo/load.py.
2429 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2431 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2433 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2434 entries within the associated public Dicom dictionary resp. the same
2435 information but sorted by the fourth field (PAT, IMG, DIR) of the
2437 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2438 are now in the "???" group.
2439 - python/gdcm.i changed accordingly,
2440 - python/demo/printGroupedPublicDict.py added, that gives an example
2441 of the above new functionalities in Python.
2443 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2444 * src/gdcm.h, gdcmHeader.cxx:
2445 - historic references to glib's g_malloc and g_free (#defined)
2446 were definitively removed.
2447 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2448 * src/gdcmElValSet.cxx:
2449 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2450 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2451 - GetElValue(string) renamed to GetElValueByName.
2452 - Added GetElementByName(string).
2453 * src/gdcmHeader.cxx: added
2454 - GetPubElValRepByNumber(guint16, guint16)
2455 - GetPubElValRepByName(string)
2456 - GetShaElValRepByNumber(guint16, guint16)
2457 - GetShaElValRepByName(string)
2458 - GetShaElValByNumber(guint16, guint16)
2459 - GetShaElValRepByName(string)
2460 - GetElValRepByNumber(guint16, guint16)
2461 - GetElValRepByName(string)
2462 - GetElValByNumber(guint16, guint16)
2463 - GetElValRepByName(string)
2464 * Doc/requirements.txt added.
2466 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2467 * Test/Makefile building now depends on the one of libgdcm.so
2468 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2469 pixel data) aware which enables finding the address (offset) of
2470 the pixel data of JPEG encoded DICOM files. This leaves only a single
2471 file in the testSuite whose pixel data address (offset) is unknown.
2472 * python/testSuite.py changed accordingly.
2474 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2475 * VC++ has some strong limitations when working with the STL, as stated
2476 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2477 "Also note that some STL containers (map, set, queue, list, deque)
2478 cannot be exported. [...]
2479 Some STL classes contain nested classes. These classes can not
2481 This is caused by a designed limitation that once a template
2482 class is instantiated, it can not be re-instantiated and
2484 Since our usage of map<> is ubiquitous in gdcm, this "designed
2485 limitation" of VC++ is a pitfall.
2486 Hence the Python wrappers of gdcm cannot be incrementally linked
2487 against the c++ dynamic library. The dirty but only workaround is
2488 to forget about incremental link of dynamic libraries and to generate
2489 the Python wrappers library with the inclusions of the underlying C++
2491 The following modifications concern this matter on Win32/VC++:
2492 - wrapping python correct with standalone wrapped dll (don't use separate
2493 dll under windows !!!!)
2494 - python21_d debug mode enabled (ask Frog how to use it :-)
2495 - NO problem with having an STL member of class for example string in C++
2496 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2497 - Python test of dcmlib in Python is ok under windows on a large set
2499 * removed glib references
2500 * typedef's inserted in gdcm.i for correct swig type management
2502 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2503 * python/demo/*.py load.py extracted from test.py. Added explore.py
2504 that only displays required tags and testAll.py that parses all
2505 the files of the testsuite without using unittest.
2506 * python/testSuite.py other additional test on new files added.
2507 * Data/* new test files added accordingly to the testSuite.
2508 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2509 the vr in the file differs from the one of the dictionary.
2511 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2513 values, but limits itself to values which are below a user specified
2514 size (by default 1024 bytes).
2515 * python/gdcm.i : elements not loaded (because their size is above the
2516 user specified treshold) are exported with their TagKey as key of the
2517 python dictionary. This enables the testsuite to make some checks
2518 on the unloaded elements (since we have their offset and size).
2519 * python/testSuite.py
2520 - now tests for the existence and proper value of the pixel data
2521 - two new examples added.
2522 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2524 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2525 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2526 aware. See the strategy comments in gdcmHeader::FindeLength().
2527 * Test/test.cxx now accepts a filename as first argument.
2528 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2529 * python/testSuite.py changed to integrate test on above files.
2531 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2532 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2533 the vr was also RET.
2534 * python/testSuite.py more tests added.
2536 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * python/testSuite.py unittest test suite added (uses Data)
2538 * Data/* dcm and acr files for the test suite.
2539 * glib dependance removed from un*x version. We now use ISO C99
2540 7.18 Integer types (see stdint.h)
2541 - python/Makefile, src/Makefile src/gdcm.h
2542 * src/ when an explicit vr (like dicom files) suddenly poped an
2543 implicit element we use to mark the underlying DictEntry of the
2544 concerned ElValue with "Implicit". This strategy was damageable
2545 too the public or provite dictionaries, since some of their vr
2546 would be changed. Since Header::FindLength heavily relies on the
2547 detection by Header::FindVR of falsely explicit elements, I
2548 added an extra ImplicitVr member to ElValue (boolean).
2549 The rest of the changes we the necessary adaptations.
2551 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2554 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2556 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * Adaptation for porting to VC++:
2559 o forced to use std namespace (for string to be known)
2560 o all class use __declspec export style on WIN32
2561 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2562 (in stdlib.h on Win32 but in std:: for gcc)
2563 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2564 variable GDCM_DICT_PATH.
2565 * src/gdcmHeader.cxx verbose comments made discrete.
2567 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2568 * python/gdcm.i: added a typemap that converts a C++ hashing table
2569 to native Python dictionary.
2570 * python/demo/test.py:
2571 - now uses the native dictionary for exploration of gdcmHeader.
2572 - takes an optional filename argument (the file to parse).
2573 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2574 PubElVals hashing table.
2575 * Dicts/dicomV3.dic removed error prone trailing spaces.
2577 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * Python wrapping process moved away from src/Makefile to
2579 newly created python/Makefile (as well as gdcm.i)
2580 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2581 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2582 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2583 from the environement variable GDCM_DICT_PATH (when existing).
2584 * src/gdcmDict::GetTag bug fix.
2586 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * Straightforward temporary fixes for swig to build the python wrappers.
2588 src/Makefile now has a python working entry [by working we mean
2589 that we can import de shadow classes without errors].
2591 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * hashtest.cxx removed (since allready in Test)
2593 * src/gdcmlib.h renamed to src/gdcm.h
2594 * src/dcm.i renamed to src/gdcm.i
2595 * src/Makefile prepared for python wrapping
2597 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * src/gdcmHeader.cxx :
2599 - Parsing of header is now separated from loading of element values
2600 (see gdcmHeader::LoadElements).
2601 - general clean up of hopefully all file access (creation of
2602 ReadInt16 and ReadInt32)
2604 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2605 * src/gdcmHeader.cxx :
2606 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2608 - SetLgrElem renamed to SetLength
2609 - GetLgrElem renamed to GetLength
2610 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2611 * src/gdcmElValSet.cxx fixed both GetElValue methods
2612 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2613 due to IdoDude was cleaned out.
2615 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2617 concentrates on finding the value representation (when it exists).
2618 RecupLgr now only finds the element value length, and it avoids
2619 returning the unecessary skL (skipped length).
2620 Also, offsetCourant was simply removed (with taille_fich) since
2621 it was redundant with the File position internals (by using
2622 ftell and fseek). This also made skL (see above in RecupLgr) usage
2624 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2625 on the libido specificities which are handled through class
2627 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2630 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2631 * Truckload of changes. Parsing of header is barely functional
2632 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2634 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * src/gdcmHeader.cxx many addons of low level methods
2637 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2639 and _IdDcmSWAP_LONG.
2641 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * This corresponds to all the changes decided at the meeting of
2643 May 23 2002. Needless to say we are running late...