1 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * WARNING: ctest now depends more tightly on gdcmData. You should
3 check out gdcmData properly for things to run smoothly...
4 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
5 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
6 we need the pixels not be loaded in order to use the ValEntry
7 that displays position and size).
8 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
9 This is a C++ based equivalent of gdcmPython/testSuite.py that should
10 be deprecated. If you have any doubts about the advantages of a
11 modern scripting language (read Python) versus grass root C++ (i.e.
12 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
13 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
14 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
15 Anyhow, consider documenting the gdcmData images in
16 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
18 * Test/CMakeLists.txt:
19 - now uses TestAllEntryVerify.cxx
20 - specific comments on oldACR00001.ima (now renamed in gdcmData
21 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
22 gdcmData/TestAllEntryVerifyReference.txt
25 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
26 * src/*.[h|cxx] : typedef clean up
27 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
28 - TagKey renamed to gdcmTagKey (for external usage)
29 - VRKey renamed to gdcmVRKey (for external usage)
30 - removal of typedef duplication.
31 - Removed all unecessary inline keyword from class inline definitions.
32 - Some method|function(void) declarations replaced with method|function().
33 * src/jpeg/libijg12/jdhuff12.c:
34 - printf polluting ctest removed.
35 - TAB removal for comminting
37 - TestAllReadCompareDicom.cxx: added a test that compares all the
38 images in gdcmDataImages.h with corresponding images in
39 gdcmData/BaselineDicom/. When baseline images are not present
40 this test creates them.
41 Note: we need to validate each reference image, but before that
42 I'd like to rename them with a more explicit name...
43 - CMakeLists.txt: changed accordingly.
44 * Example/*.cxx: examples now only include gdcm.h (as opposed to
45 including each header needed).
47 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
48 * Test/*.cxx and Example/*.cxx: moved some examples away from the
49 test suite to the Example directory. Are concerned:
55 * Test/CMakeLists.txt: added some comments on reasons for black listing
56 image gdcmData/oldACR00001.ima
58 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
59 * Test/CmakeList.txt: removed the following from black list (to be coherent
60 with removal from gdcmData):
61 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
62 - gdcm-MR-PHILIPS-16.dcm
64 Added the following because after last cvs update, they cause
65 ctest -R TestReadWriteReadCompare
67 - gdcm-MR-SIEMENS-16-1.acr
69 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
70 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
71 new comments in this file) we temporarily (sigh) move to a weaker
73 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
74 we don't need to black list the following images anymore:
75 - 8BitsUncompressedColor.dcm
77 - US-PAL-8-10x-echo.dcm
78 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
79 fixes and the beautified code ;-)
80 This fixes the bug introduced in version 1.42 (when beautifying)
81 that made the parsing of 8BitsRunLengthColor.dcm unproper.
82 Note: ctest was blind to this bug (this means we need to still
83 improve the test suite). The bug could be detected by using
84 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
86 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
87 and by displaying the (garbage) produced file temp.XDCM...
89 2004-06-29 Jean-Pierre Roux
90 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
91 - replace by uggly but working old code :-(
92 A lot of things should be OK again.
93 It's really urgent to have a test suite that *tests*,
94 to prevent Frog's beautifying sessions to break all the stuff
95 (twice, withing a fortnigh ...)
97 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
99 redundancy) to added Test/TestReadWriteReadCompare.cxx
100 * Test/CmakeList.txt: because the compare test of
101 Test/TestReadWriteReadCompare.cxx fails, the following images are
102 black listed: - 8BitsUncompressedColor.dcm
104 - US-PAL-8-10x-echo.dcm
105 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
106 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
107 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
108 and ad-hoc kludge. This kludge is now removed, and on encountering
109 such an image (OB field brain damaged) we set errno. Then in
110 ::FindDocLength() we "fix" the length as being ALL what remains
111 in the file (until EOF). We then proceed, hoping for the best...
112 This fixes a SegFault in ShowDicom when trying to write such an
114 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
115 (because TestWriteRead breaks on it, after a non conformal commit?).
116 ctest now runs properly, except for MakeDicomDir (which was allways
117 broken) and the Python related stuff (still not fixed).
119 2004-06-24 Jean-Pierre Roux
120 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
121 FIX : Test/TestReadWrite now iterates on all the file names
122 (instead of infinite loop)
123 ENH : Test/TestWriteRead now iterates on all the file names
125 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
126 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
128 2004-06-24 Jean-Pierre Roux
129 FIX : - now Write drops LUT Descriptors and LUTs (if any)
130 when SamplesPerPixel =3
131 - now Write is no longer confused by
132 'BitsAllocated = 12" and 'BitsStored=12"
133 - "UN" value representation Elements are now written correctly
134 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
135 ENH : - now gdcmHeader has its own Write methods
136 (in order to split the job that has not to be done
139 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
140 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
141 loop on the same image until memory went out.
142 Note: this means we still have gobs of memory loss in PrintDocument
143 * src/gdcmDocument.cxx: fixes problem on parsing on file
144 gdcmData/16BitsJpegLosslessGrayScale.dcm.
146 2004-06-24 Jean-Pierre Roux
147 FIX : Write - All the Sequences and Sequence Item are now written
148 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
149 is added a the end, when necessary.
150 - A lot of brain-damaged images, that were read correctly are
151 now written correctly
152 - length compatible BinEntry are now loaded correctly
153 (even for odd groups)
154 Note : only Explicit Value Representation was checked.
155 (question : is implicit VR really necessary for gdcm ?)
157 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * DEVELOPPER: added a proposition of coding style.
159 * src/gdcmDocEntry.h: removed every inline declaration (for test of
162 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
163 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
164 Use the gdcmDocEntry::Print() and Write() instead.
165 * src/gdcmDocument.cxx: bug fix.
167 2004-06-22 Jean-Pierre Roux
168 FIX : gdcmDocument.cxx
169 - Now we do recognize the JpegLossLess format (there was a misstyping in
170 code 'beautyfication' :-(
171 - Now we automaticaticaly load the Luts, if any
173 2004-06-22 Jean-Pierre Roux
174 In order : to write Sequences, whatever their imbrication level,
175 : to allow user to create his own Sequences
176 a lot of modif where necessary (adding, moving, or virtualising methods)
178 WARNING : save your own sources *before* cvs up !
181 ADD virtual void Write(FILE *fp, FileType filetype);
184 ADD virtual void Write(FILE *fp, FileType filetype);
185 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
188 ADD virtual void Write (FILE *fp, FileType filetype)=0;
189 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
190 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
191 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
192 ADD std::string GetEntryByName(TagName name);
193 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
195 std::string vr = "unkn",
196 std::string fourth = "unkn",
197 std::string name = "unkn");
198 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
199 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
200 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
201 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
202 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
203 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
204 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
205 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
208 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
209 ADD virtual std::string GetEntryByName (TagName tagName);
210 ADD virtual std::string GetEntryVRByName (TagName tagName);
211 REM virtual bool Write(FILE *, FileType);
212 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
213 FILE *_fp, FileType type);
214 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
215 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
216 REM virtual bool WriteEntries(FILE *_fp,FileType type);
217 REM virtual std::string GetEntryByName (std::string tagName);
218 REM virtual std::string GetEntryVRByName (std::string tagName);
219 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
220 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
221 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
223 std::string vr = "unkn",
224 std::string fourth = "unkn",
225 std::string name = "unkn");
226 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
227 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
228 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
229 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
232 ADD virtual void Write(FILE *fp, FileType filetype);
235 ADD virtual void Write(FILE *fp,FileType filetype);
238 ADD virtual void Write(FILE *fp, FileType filetype);
239 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
240 REM std::string GetEntryByNumber(guint16 group, guint16 element);
241 REM std::string GetEntryByName(TagName name);
244 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
246 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
248 The default constructor invoked by the line
249 gdcmHeader *f1 = new gdcmHeader( header );
250 was gdcmHeader::gdcmHeader(bool) instead of the expected
251 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
252 Hence the parsing wasn't executed... See also below.
253 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
254 as explicit constructor didn't do the trick to fix the above problem.
255 Could anyone explain why ?
256 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
257 properly calls gdcmValEntry::Print() (that was weed out from
258 code related to gdcmBinEntry).
260 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * In order to fix memory leaks:
262 - Test/TestWriteSimple.cxx: added cleaning of free store through
264 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
265 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
266 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
267 (through the call to ::AddDicomDirMeta()) or the destructor
268 would crash when deleting uninitialized ::metaElems].
269 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
270 - src/gdcmDocument.cxx:
271 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
273 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
274 was causing memory leaks.
275 - src/gdcmSQItem.cxx:
276 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
277 cleanly handled with polymophism: sorry but my milage is low).
278 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
279 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
280 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
281 This avoids SegFaulting.
282 - src/gdcmSQItem.h: coding style.
284 - Test/TestWriteSimple still severely sucks. The output image content
285 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
286 damaged when displayed with vtkgdcmViewer.
287 - on memory leaks: TestWriteSimple leaks really less (see entry
288 of 2004-06-18 in Changelog file for the call to valgrind).
289 - on segfaults: ctest now passes all the tests but one (no more
291 * Erroneous leading white fix:
292 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
293 white[s] (as opposed to from >> xxx, that removes it [them].
294 - src/gdcmTS.cxx: ditto.
295 - gdcmPython/testSuite.py: dirty related kludge removed.
296 * src/*: remaining references to gdcmParser removed.
297 * src/*[cxx|h]: added copy[way]left header.
300 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
301 * In order to fix writing of dicom files:
302 - Test/TestWriteSimple.cxx: a simpler example of writing.
303 - Test/CMakeLists.txt changed accordingly.
304 - src/gdcmDocument.cxx:
305 -- The destructor now recursilvely removes potential sequences.
306 -- Bug fix in ::IsJPEG2000()
307 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
308 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
310 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
311 to only declared) and build on top of
312 ::GetDocEntryByNumber(guint16, guint16).
313 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
314 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
315 for usage in destructor and treatement of promotion in
316 ::ReplaceOrCreateByNumber().
317 - src/gdcmSQItem.cxx: destructor should better handle his job.
318 Test/TestWriteSimple now runs (or at least it DOES something).
319 * We can now start hutting memory links. A good starting point is:
320 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
321 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
322 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
324 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * Valgrind note: after Mathieu Malaterre teached me how to read
326 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
328 Using gcc, you can force the STL to use malloc and to free memory as
329 soon as possible by globally disabling memory caching.
330 With 3.2.2 and later, you should export the environment variable
331 GLIBCPP_FORCE_NEW before running your program.
332 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
333 simply vanish (it is still not clear to me, whether this means that
334 STL std::string leaks or if valgrind believes it leaks...).
335 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
336 running bin/gdcmTests makeDicomDir):
337 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
338 - Test/makeDicomDir.cxx now properly traps empty lists and returns
340 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
341 SegFaulting (I drowned in DicomDir related code when trying to
342 understand why the list is empty...).
343 * src/gdcmDocument.h: first BSD license header try.
344 * Doc/License.txt added.
346 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
347 * src/gdcmDocument.[h|cxx]:
348 - Clean up of the Transfer related predicates. They are now all based
349 on new method isGivenTransferSyntax, that (should) handle properly
351 - general clean up, simplification, and coding style.
352 - Specific clean up of Parse7FE0() (umproperly named actually).
353 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
355 2004-06-14 Jean-Pierre Roux
357 - fix the display of Sequence Delimitor (SQDepthLevel pb)
358 - fix the display of SQItem ordinal number
359 - add the GetSQItemByOrdinalNumber method
360 - remove some useless never written private methods
362 2004-06-14 Jean-Pierre Roux
364 - adding a constructor taking a gdcmDocEntry as an input param
365 - ReplaceOrCreateByNumber now returns :
366 a gdcmBinEntry * if a Binary (void *) value is passed as a param
367 a gdcmValEntry * if a string value is passed as a param
369 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
370 according to the param type (no longer sets a gdcmDocEntry)
371 - GetValEntryByNumber, GetBinEntryByNumber added
372 - NewValEntryByNumber and NewBinEntryByNumber added
374 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
376 - GetSQItemNumber and SetSQItemNumber added, to provide
377 a (relative) Item identier inside a given Sequence
378 \warning : some pb remaining around this number
380 - AddEntry now takes the Item Number as a param
382 - adding a constructor taking a gdcmDocEntry as an input param
384 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
385 * Memory leak hunt with the following command:
386 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
387 --show-reachable=yes gdcmTests PrintDocument
388 It looks like many (all?) leaks are due to the STL (or a bad usage
389 of the STL. The lines producing the leaks now have a comment with
390 a "MEMORY LEAK" tag: you can retrieve them with
391 grep "MEMORY LEAK" src/*
392 Here are two typical examples which I can't help fixing:
397 char * test = "babo";
398 name = test; //// <--- valgrind detects 960 bytes lost in
399 //// call to std::string::operator=(char const*)
400 name.clear(); //// Doesn't help !
408 std::cout << "Type a bunch of characters followed by RETURN: ";
409 getline(std::cin, line); //// <--- valgrind dectects a loss
410 //// of 1320 bytes in call to
411 /// std::basic_istream<>& std::getline<>
417 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/gdcmHeader.[cxx|h]:
419 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
420 and related, moved away to gdcmDocument.
421 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
422 the corresponding protected accessors of inherited class
423 gdcmDocument, removed ! As a consequence gdcmFile had to be
424 declared friend of class gdcmDocument (see below).
425 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
426 - Clean up of undefined or unused methods.
427 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
428 account the changes to gdcmHeader.h).
429 * src/gdcmDocument.h:
430 - gdcmFile is now a friend class (in order to take into account the
431 changes to gdcmHeader.h).
432 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
433 (see changes to gdcmHeader.h).
434 - Accessors (reading on the form GetEntry*) are now public.
435 - Clean up of undefined or unused methods.
436 * src/gdcmDocument.cxx:
437 - adaptation to changes to gdcmDocument.h
438 - ::OpenFile now writes a verbose message when file cannot be opened.
439 - some std::string properly set to VRKey
440 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
441 references to gdcmDocument.
442 * Test/TestFindTags.cxx: changed accordingly to above changes.
443 * gdcmPython/testSuite.py: adapted to renaming of acr files in
444 cvs repository gdcmData.
446 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
448 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
449 conflicts with gdcmValEntry::voidArea.
450 * src/gdcmValEntry.cxx: unmatching comment wiped out.
451 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
452 Value representation between StringRepresentable and BinaryRepresentable.
453 * src/gdcmDocument.cxx:
454 - method ParseDES: proper indentation restored and usage of
455 gdcmVR::IsVROfGdcmStringRepresentable wired in.
456 - method LoadDocEntry: the fingerprint left in the SetValue() of
457 unloaded entries (length > MaxSizeLoadEntry) had curiously been
458 removed. Reverting to previous code segment with the proper
459 dynamic_cast< gdcmValEntry* >.
460 Note: this was (partially) breaking the python test suite
461 (gdcmPython/testSuite.py) that made usage of the above
462 fingerprint to check presence of "Pixel Data".
463 * src/gdcmDocEntry.h: coding style.
464 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
465 now taken into account.
466 * gdcmPython/gdcm.i: adaptation to the new internal representation
467 of gdcm (exit gdcmParser, hello gdcmDocument).
468 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
470 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
471 anymore, but instead prints the loaded Python dictionary.
472 * .... alas, the python testSuite is still broken.
474 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
475 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
477 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
478 * src/gdcmUtil.h : export methods
480 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
481 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
483 * Initial addition of automatic python testing
484 * Initial addition of automatic image comparison
486 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
487 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
488 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
490 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
491 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
492 * Test/ShowDicom.cxx : bug fix for msvc compilation
493 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
495 2004-05-04 Jean-Pierre Roux
496 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
497 new concepts (and new classes) :
498 a 'gdcmDocument' is composed of a set of Doc Entries, that are
499 - elementary gdcmDocEntries (former gdcmHeaderEntries)
500 - Sequence Doc Entries (gdcmSeqEntries)
501 a Sequence is composed of Items.
502 Each item is a set of Doc Entries (this is recursive)
503 The non uniqueness of the 'Dicom tag' is due to this recursivity
504 (never taken into account)
505 Our unability to add a new 'entry' in the header
506 at the proper location (neither in the H-Table (map or multimap),
507 nor in the Chained List is also due to this recursivity.
508 Don't try, right now, to use/modify/compile these new sources :
510 We just commit all the stuff, 'as is', in order not to loose it.
512 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
513 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
515 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
516 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
517 file prefix (SetFilePrefix)
519 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
520 * Add a new test: ShowDicom, for now this is just the c++ version of
521 checkRead.sh, later it will be able to compare the image read against a
523 * Replace the DEBUG on the stack with a global entry in cmake interface:
524 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
526 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
527 * Add an example subdir, with a real example on how to read + write a
530 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
532 * Doc/CMakeLists.txt: the main page is now properly differentiated
533 between the developper and user version.
534 * Doc/doxygen.config.in: dropped search related obsolete flags
535 * src/gdcmParser.h, gdcmHeader.h: doxygenation
537 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
538 * DEVELOPPER: added some helpfull comments for compile/test/install
541 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
542 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
543 src directory, now generated in the build dir.
544 2. Tests as mentionned smarter
546 4. Add a new method in gdcmDict that return the PubDict by name
547 this is interesting for 3rd party lib like ITK,
548 where we could set the institution name / patient name...
550 * ENH: 1. Now the test suite is working for real
551 2. All binaries are now output in the gdcm-bin directory
552 (this was not true before)
554 2004-04-28 Jean-Pierre Roux
555 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
556 SeQuence indented printing of Dicom Header.
557 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
558 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
559 Computation of SQDepthLevel is now part of gdcmHeader constructor
560 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
561 tree-like structure of a Dicom Header.
562 * FIX Test code cleaning
564 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
565 * ENH: Adding automatic testing
566 1. Need a DartConfig.cmake to submit to public
567 2. Add a test driver gdcmTest.cxx
568 3. gdcmTestMain, an helper for the main test driver gdcmTest
569 4. Files in Test don't have a main anymore, this becomes interesting
570 when we add more and more tests, thus dsw don't have to load
572 * ENH: Adding a GDCM_DATA_ROOT for testing
573 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
574 one file instead of seven + some small cleanup
576 2004-04-22 Jean-Pierre Roux
577 * ENH Minor changes to the Print() methods.
578 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
579 Header printing. Example given with :
580 > PrintHeader fileName 2 new
581 (SQ based tree-like structure still to be done for the Header ...)
583 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
584 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
585 1. I have added some unsigned where needed
586 2. Some function parameter not used -> (void)
587 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
588 4. g++ don't like character '\' in comment
589 5. #define jpeg_create_decompress jCreaDecompress
590 this really need to be fixed
591 6. virtualize destructor of gdcmObject ... leakage
592 7. sscanf(g->first.c_str(),"%x",&gr_bid);
593 this also really need to be fixed
594 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
595 remove compression file
596 (as we only do decompression, right ?)
597 * ENH: Change malloc/calloc/free with c++ equivalent
599 2004-04-21 Jean-Pierre Roux
600 * FIX gdcmHeaderHelper::GetXSpacing
601 when a single value is found (bug ?), xpacing is now
602 defaulted to yspacing
604 2004-04-19 Jean-Pierre Roux
605 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
606 * ENH add parameters :
607 bool exception_on_error = false,
608 bool enable_sequences = false,
609 bool ignore_shadow = false
610 to the gdcmFile constructors to be full gdcmParser compliant
611 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
612 to allow reading of PAPYRUS 3.0 files
614 2004-04-06 Jean-Pierre Roux
615 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
617 2004-04-02 Jean-Pierre Roux
618 * ADD : Test/checksequence.sh, for a general recap on SQ pb
619 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
620 for Philips spurious Tag fffe|0000 while rewritting Dicom files
622 2004-03-30 Jean-Pierre Roux
623 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
624 for ACR file, written out as DICOM files (hope so...)
626 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
628 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
629 moved to base class gdcmParser and only the specialisation is kept
631 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
632 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
633 already does the job.
634 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
635 (to be consistent with gdcmParser::WriteEntries).
637 2004-03-30 Benoit Regrain
638 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
639 upate of the object's instance. It's passed to 2 in the unfavorable
640 case : one in the ExecuteInformation, one in the ExecuteData
642 2004-03-29 Jean-Pierre Roux
643 * ENH : Check on file type to be written moved
644 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
645 * FIX : gdcmObject::ResetBoundaries now stops properly
646 when end-of-list is reached
647 : gdcmVersion modified (as Benoit Regrain asked)
649 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
651 * src/gdcmUtil.cxx: added forgotten iostream include.
652 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
653 equivalent to ExplicitVR in existing code).
655 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
657 now contains all the gdcmGlobal related code.
658 * minor coding style and doxygenation changes.
660 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
662 now contains all the Debug related code.
663 * minor clean-up of includes in src/*.cxx
664 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
665 CreateCleanString) removed.
666 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
667 * Doc/DoxyMainPageUser.txt added.
668 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
669 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
672 2004-03-24 Jean-Pierre Roux
673 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
675 2004-03-23 Jean-Pierre Roux
676 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
677 big endian made volumes
678 * ENH Now gdcmParser constructor and destructor are protected to forbid
679 end user to instanciate class gdcmParser
680 (only gdcmHeader and gdcmDicomDir are meaningfull)
682 2004-03-22 Benoit Regrain
683 * FIX : src/gdcmDicomDir.cxx : make windows compilable
684 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
685 gdcmSerie to gdcmDicomDirSerie
687 2004-03-19 Jean-Pierre Roux
688 * ENH Now the tree-like structure describing a DICOMDIR comming from
689 an already existing DICOMDIR file is consistent with
690 the home-made tree-like structure build ex-nihilo
691 or build from the files held (recursively) in a Directory
692 functions gdcmDicomDir::CheckBoundaries()
693 gdcmObject::SetBoundaries() added
695 2004-03-17 Jean-Pierre Roux
696 * REM (Eric Boix bug) : removal of meaningless
697 gdcmDicomDirImage::NewImage function.
698 * FIX now file names and directory name are written properly in the
700 * FIX now gdcmDicomDir constructor may be call without any trick
703 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
705 of gdcmDicomDirImage::NewImage as empty function.
707 2004-02-28 Jean-Pierre Roux
708 * ENH add gdcmDicomDir:NewPatient
709 add gdcmDicomDirPatient:NewStudy
710 add gdcmDicomDirStudy:NewSerie
711 add gdcmDicomDirSerie:NewImage
712 to allow making gdcDicomDir object.
713 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
714 (as opposite to the gdcmHeader chained list)
716 2004-02-11 Benoit Regrain
717 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
718 when using from python
720 2004-02-10 Benoit Regrain
721 * FIX : bug fix in the gdcmDirList for the recursivity in directories
722 * FIX : in gdcmDicomDir when the directory is empty
723 * ENH : add callback and methods to get the progression of dicomDir
726 2004-02-06 Jean-Pierre Roux
727 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
728 - GDCM_META added to gdcmDicomDirType
729 - class gdcmMeta created
730 * ENH : - A brief summary is now displayed at the beginning of
731 'testDicomDir' to help disaster magnitude estimation
732 * REM : Now useless Test/explDICOMDIR.cxx
734 2004-02-05 Benoit Regrain
735 * ENH : add methods in gdcmObject to get the hash table or the list of
737 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
738 * FIX : wrapping python for TagHeaderEntryHT
740 2004-02-04 Benoit Regrain
741 * FIX : even length for some strings when writting the dicom dir
742 * FIX : sort the images in the dicom dir
743 * FIX : Bug fix for python use of dicom dir
744 * ADD : a python demo
746 2004-02-04 Jean-Pierre Roux
747 * FIX : Final solution (?) for icone embedded images
748 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
749 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
750 add groups 6002, 6004, 6006, to allow 'clean' parsing of
751 gdcmData/gdcm-MR-SIEMENS-16.acr1
752 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
753 to make full checking easier
755 2004-02-04 Benoit Regrain
756 * FIX : WriteEntries : coding style & logic in parameters
757 * FIX : Set the elements to create the DicomDir in a dictionary file
759 2004-02-03 Benoit Regrain
760 * gdcmDirList : to parse a hard drive directory in recursive (or not)
761 * gdcmDicomDir : add the load of directory
762 * Bug fix and print add-on
764 2004-02-03 Jean-Pierre Roux
765 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
766 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
767 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
768 * FIX gdcmParser.cxx : 'group length' elements are now considered
769 as integers, even for shadow groups, when file is Implicit VR
771 2004-02-02 Jean-Pierre Roux
772 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
774 of the last synonym :-(
775 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
777 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
778 * FIX taking into account the possible 7fe0,0010 multiplicity
779 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
780 to allow removal of references to 7fe0,0010, to deal with
781 ACR-NEMA images, when 0028,0200 is meaningfull
783 2004-01-31 Jean-Pierre Roux
784 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
785 no longer writes 'Un' on disk
786 * FIX SQ elements with actual length are now dealt with corectly
787 * FIX gdcmFile::WriteBase make the difference, for color images, between
788 the length (for Palette expanded images)
789 and Raw Length (non expanded image + Palette)
790 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
791 (that broke Write). Replaced by UL.
792 Aware user will reload the field if he
793 thinks it's necesssary
795 2004-01-30 Jean-Pierre Roux
796 * gdcmParser::CheckSwap() now defaults the filetype to ACR
797 when 'dirty Acr' is found, to be compliant with the new
798 IsReadable() methods.
800 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
801 (no DOUBLE images in kosher DICOM,
802 but so usefull for people that miss them ;-)
804 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
805 DICOMDIR related utilities (not checked as Windoze compliant)
807 2004-01-28 Jean-Pierre Roux
808 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
810 2004-01-27 Jean-Pierre Roux
811 * gdcmParser constructor has a new boolean param,'ignore_shadow',
812 to allow skipping the shadow elements, to save memory space.
813 The TRUE value for this param has to be used
814 with a FALSE value for the 'enable_sequence' param.
815 ('public elements' may be embedded in 'shadow Sequences')
816 * gdcmHeader methods now deal with 'embedded icones images' in the header
817 (even when an 'icone image sequence' is announced by the
818 element (0x0088,0x0200), but there is NO icone at all ...
820 * gdcmHeader sometimes Image Location value doesn't follow
821 the supposed processor endianity (see gdcmData/cr172241.dcm).
824 * gdcmHeader add the method
825 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
826 to get *all* the Header Entries with the same tag.
827 GetHeaderEntrySameName is probabely *useless*
828 (no meaning : Name is *not* an identifier within the Dictionnary)
830 2004-01-26 Benoit Regrain
831 * Bug fix in the print of hexadecimal representations. Remove long fields
832 in the print and add a third level of print to print them
834 2004-01-23 Benoit Regrain
835 * Bug fix on field having a VR = 'UI'. Assume that is a string field
836 * Bug fix on test suite after remove the strip made on not string fields
837 * Split the IsReadable method between gdcmParser which test that the file
838 is dicom and gdcmHeader which test that it's an image file
840 2004-01-22 Benoit Regrain
841 * DicomDir : clean code, add methods, set variables in protected or private
842 * gdcmUtil : bug fix for the clean string method
844 2004-01-19 Benoit Regrain
845 * Add the use of shadow dictionaries
846 * bug fix and coding style
848 2004-01-19 Benoit Regrain
849 * src/gdcmFile.cxx : bug fix concerning the close of file
850 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
851 * Add the update of header entries using the shadow library
853 2004-01-19 Benoit Regrain
854 * removal of file gdcmHeader2.cxx
855 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
856 inheriting from gdcmParser. This split is to prepare the integration
858 * bug fix under python
860 2004-01-16 Jean-Pierre Roux
861 * REM removal of class gdcmHeaderEntrySet
862 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
863 * ADD add file gdcmHeader2.cxx
864 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
866 2004-01-15 Benoit Regrain
867 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
868 entries created while parsing the header. Thus, they will be destroyed
869 when the gdcmDictSet will be destroyed
870 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
873 2004-01-15 Benoit Regrain
874 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
875 made a fatal error because of the memory release at the end of program.
876 The problem was in vtkGdcmReader::ExecuteData where we were allocate
877 some memory and vtk seems to have some problems with that.
878 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
880 2004-01-14 Benoit Regrain
881 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
882 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
883 * src/*.[h|cxx] : make changes due to class name changes
884 * gdcmPython/demo/*.py : bug fix due to method names
886 2004-01-13 Benoit Regrain
887 * src/*.[h|cxx] : coding style
888 * vtk/*.[h|cxx] : coding style
890 2004-01-13 Benoit Regrain
891 * gdcmPython/testSuite.py : test the readable flag of file for tests
892 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
893 It's lied to the stl compilation by MSVC (windows, always windows...)
894 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
896 2004-01-12 Benoit Regrain
897 * src/*.h : add comments
898 * src/gdcmDictSet.h : set the method BuildDictPath in public
899 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
900 directly setted in the source code
901 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
904 2004-01-09 Benoit Regrain
905 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
906 * setup.py : use a reference to gdcmVERSION
908 2004-01-07 Benoit Regrain
909 * Modification to compile with the distutils.
912 2003-12-10 Benoit Regrain
913 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
914 can use a gdcmHeaderHelper to load datas
915 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
916 made in the source code
918 2003-12-10 Benoit Regrain
919 * Update Windows projects and .cvsignore files
921 2003-11-12 Jean-Pierre Roux
922 * ENH gdcmHeader constructor has one more parameter (default value : false)
923 that allows the user to 'go inside' the SeQuences only
925 gdcmElValSet:Print takes it into account
927 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
928 * ENH: Update gdcmPython/CMakeLists
929 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
930 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
932 2003-11-10 Jean-Pierre Roux
933 * FIX : gdcmHeader::LoadElements is now based
934 on the ListTag listElem member,
935 not longer on the TagElValueHT tagHt member
936 * ENH : PrintPubElVal shows (temporarily) both results,
937 with the tagHt member and the listElem member.
938 (it's easier to 'see' the problems when using Printheader)
940 * FIX : old private member LgrElem is now splitted into
941 ReadLength : Length actually found on disk (updated only
942 if bug fixing is necessary), for internal
944 UsableLength : Updated by FixFoundLength, to fix a bug
945 or to allow Parser going on.
946 Will allow to re-write a kosher header when a SeQuence
947 with a length (not 0000) is found
948 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
949 because gdcmElValSet::Add does not update ListElem
952 2003-11-07 Jean-Pierre Roux
953 * FIX misstyping in Transfert Syntax name table
954 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
955 when they have an actual length (not 0000 nor FFFFF)
956 (Nobody should care of it, but DICOMDIR explorers)
958 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
959 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
961 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
962 * ENH: vtkGdcmReader now supports LUT !
963 (vtkgdcmViewer for now is not able to use them though)
965 2003-11-05 Jean-Pierre Roux
966 * in testSuite.py : new files names for checking the package
967 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
968 that returns the pixel area size to the *aware* (vtk) user
969 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
971 2003-11-05 Benoit Regrain
972 * in testSuite.py : Modify the rules for checking the paths
973 : Explicit error messages
974 * in __init__.py : Related modif
976 2003-11-03 Jean-Pierre Roux
977 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
978 to be used by aware (vtk) users that want to manage
979 LUT (and no to turn the PALETTE image into an RGB pixels one)
980 * GetPixelType now returns 8U for 24 Bits images
981 (vtkGdcmReader compliant)
983 2003-10-31 Jean-Pierre Roux
984 * Removal of *all* gdcmData images and add them again
985 in order to loose the 'history' of un-anonymised images
987 2003-10-31 Jean-Pierre Roux
988 * RMV : removal of useless jBitsInJsample.h
989 for both 8 and 12 Bits JPEG Lossy Libraries
991 2003-10-31 Jean-Pierre Roux
992 * ENH : Add the functions gdcmFile::GetImageDataRaw
993 gdcmFile::GetImageDataIntoVectorRaw
994 that act as GetImageData and GetImageDataIntoVector
995 except the making of an RGB Plane from Gray Plane + LUT
996 Intended to aware (vtk) users who know how to manage
999 GetLUTRGBA return a R,G,B,A LUT if any
1000 lgrTotaleRaw gives the 'Raw' length
1001 GetImageDataRaw returns the gray Plane
1002 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1003 (They stay Grey, just like with other Dicom viewers :-(
1005 2003-10-30 Jean-Pierre Roux
1006 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1008 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1009 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1010 being coherents dicom files.
1012 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1015 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1016 * ENH: Two steps is necessary to please VC++ compiler...
1017 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1018 * ENH: Add include dir to medcon lib
1019 * FIX: only one function is being exported for now !
1020 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1022 2003-10-29 Jean-Pierre Roux
1023 * adding gdcmHeader::GetLUTRGBA
1024 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1025 --> Mathieu, the modif u're waiting for is not yet committed
1026 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1028 2003-10-27 Jean-Pierre Roux
1029 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1030 00191113.dcm DermaColorLossLess.dcm
1031 MxTwinLossLess.dcm RadBWLossLess.dcm
1032 * ENH: For version prior to vtkImageViewer2 -r 1.19
1033 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1035 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * Removal of ido stuff in CMakeLists.txt
1038 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1039 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1040 * FIX: remove a call to ->Modified ... see comments
1041 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1043 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * FIX: Problem with path for libvtkgdcmPython
1045 * ENH: Try adding a search script for python site-package
1046 * RMV: Remove some file from medcon lib that are not necessary
1047 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1048 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1049 * FIX: More pragma disable fro VC++,
1050 I don't think I break something as it is also disable in VTK/ITK.
1051 But it fasten debug compilation time.
1053 2003-10-23 Jean-Pierre Roux
1054 * gdcm now deals with 16 Bits Run Length Encoded images
1055 (they are compressed as 2 planes images,
1056 one for the high Bytes, the other for low Bytes)
1058 2003-10-22 Jean-Pierre Roux
1059 * Now CheckRead takes into account :
1060 - the bugged 'Leonardo' Siemens images
1061 - the XA images, sent thru the burning VPRO station
1062 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1065 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * FIX: When copying a Makefile.am to CMakeLists.txt
1067 one should remove the '\'
1069 2003-10-22 Jean-Pierre Roux
1070 * in gdcmData adding a bugged 'Leonardo' Siemens image
1071 (wrong lengths in header)
1072 OK with gdcm, KO with the other viewers :-)
1073 * add a GE dlx XA image, thru the VEPRO burning station
1076 2003-10-21 Jean-Pierre Roux
1077 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1078 for a brutal checking of vtkgdcmViewer compliance
1080 2003-10-21 Jean-Pierre Roux
1081 * add the files for 'xmedcon' Jpeg Lossless library
1082 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1084 2003-10-21 Jean-Pierre Roux
1085 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1087 2003-10-21 Jean-Pierre Roux
1088 * garbage Siemens 'Leonardo' images dealt with
1089 (the patch is easy to remove)
1090 * cosmetic changes to avoid warnings
1092 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1094 no need to press 'r' now.
1096 2003-10-20 Jean-Pierre Roux
1097 * upgrade of checkRead.sh checkWrite.sh according
1098 to new Jpeg Lossless decompressor
1099 * add US.3405.1.dcm, a genuine RGB medical file ...
1100 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1101 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1103 2003-10-15 Jean-Pierre Roux
1104 * general anonymisation in gdcmData
1105 * adding the 'color files' from
1106 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1107 * adding some well knowed bugged-header images
1108 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1109 waiting for their inclusion in Python testsuite
1111 2003-10-15 Jean-Pierre Roux
1112 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1113 no longer seg faults when file is not found
1115 2003-10-14 Jean-Pierre Roux
1116 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1119 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * TODO: *.in file to genereate a UseGDCM later
1122 2003-10-14 Jean-Pierre Roux
1123 * Some supposed-to-be Dicom Images have no preamble.
1124 OpenFile takes it into account
1125 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1126 * Missing elements added in dicomV3.dic
1127 (just to be affraid : have a look at
1128 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1129 and do it again next year ;->
1131 2003-10-13 Jean-Pierre Roux
1132 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1133 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1134 But there are NOT. It's fixed !
1136 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1137 * FIX: "jpeglib.h" was not found on VC++
1138 * FIX: vtkgdcm was not being installed
1140 2003-10-10 Jean-Pierre Roux
1141 * ENH : OpenFile closes the file if it *really* doesn't look like
1142 an ACR-NEMA / DICOM one.
1143 * FIX : testWrite no longer writes an empty file if the source file
1144 is not gdcm Readable
1145 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1148 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1149 * FIX: CMake generate now documentation
1150 * ENH: out of source doc build !
1151 * ENH: Generate both user and dev documentation
1152 * ENH: Should work on windows too
1153 * ENH: Only one doxygen config.in file is needed
1154 * FIX: make install should be ok now on ùnix plateform
1155 * FIX: PATH to dictionary was wrong (missing /)
1156 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1158 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1159 * vtkGdcmReader is now able to read rgb dicom file.
1160 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1161 * added a gdcmViewer to vtk test, use mouse to control
1162 window level & window width
1164 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1165 * CMake-ification of gdcm, we have now two build system
1166 * FIX: on cygwin Wsock32 doesn't exist
1167 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1169 2003-10-06 Emanuel Ollart
1170 * FIX : compilation process wad broken.
1171 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1173 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * change gdcmViewer -> vtkgdcmViewer
1175 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1177 2003-10-06 Jean-Pierre Roux
1178 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1179 ( e.g : well known GE images with a wrong elem length,
1180 : Philips MRI Images with a wrong Huffman table)
1181 * still to be done : allow the reading of bugged LEONARDO Siemens images
1183 2003-10-03 Jean-Pierre Roux
1184 * Odd length strings are padded with '\0' (not with spaces,
1185 to remain compliant with already defined strings,
1186 like Transfert Syntax UID and others)
1188 2003-10-03 Jean-Pierre Roux
1189 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1190 to allow displaying RGB images (not only by affim ;-)
1192 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1193 * vtkGdcmReader is now able to read rgb dicom file.
1194 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1196 2003-10-03 Jean-Pierre Roux
1197 * A few nasty patches to allow the reading of a lot of nasty images
1198 ( e.g : well known GE images with a wrong elem length,
1199 : Philips MRI Images with a wrong Huffman table)
1200 * still to be done : allow the reading of bugged LEONARDO Siemens images
1202 2003-10-03 Jean-Pierre Roux
1203 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1205 2003-10-03 Jean-Pierre Roux
1206 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1207 to allow displaying RGB images (not only by affim ;-)
1209 2003-10-03 Jean-Pierre Roux
1210 * gdcmFile::GetImageDataIntoVector now
1211 - deals with MultiFrames MultiFragments Run Length Encoded files
1212 - deals with YcBcR (YBR_FULL) files
1213 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1214 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1216 (no sample found :-(
1218 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1219 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1220 Two reasons: - clear things
1221 - third parties acces gdcm through header files, so won't
1222 suffer anymore VC++ complains
1224 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1225 * add argv[1] in testvtkGdcmReader.cxx
1228 2003-09-24 Jean-Pierre Roux
1229 * The lines are now eigthy characters long.for
1230 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1232 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1233 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1234 char* to std::string. Thus, the use of strdup becomes useless. (see
1235 previous commis of Malaterre)
1236 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1237 before the last Malaterre's commit.
1239 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1240 * This commit should fix the Debug building under VC++, the problem
1241 was mainly a mixture of debug and release lib being loaded at startup.
1242 * I also remove a depency to a specific C function: strdup. Because I had
1243 to force the link to msvcrtd (whereas strdup is in libc).
1245 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1246 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1247 located in the gdcmCommon.h file. All use of reference of tha has been
1248 changed to now use the variable GDCM_UNFOUND.
1250 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1252 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1253 Dicom dictionary. The test suite can now be run again. Note:
1254 I'm note very happy with the " (RET)" changes. I believe this
1255 RETAINED comment should be dropped when parsing the dictionary.
1256 - PACKAGER corrected
1258 - AUTHORS updated and now in alphabetical order
1259 * Makefile.am now exports gdcm.dsw for Windoze users.
1261 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1262 * cygwin complains about missing std:: in subdir Test/
1264 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1265 * remove some methods that are now in gdcmHeaderHelper
1267 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1268 * vtkGdcmReader set spacing and origin correctly
1270 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 * Fix a few delete/delete[] mismatch
1273 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1274 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1275 interpretation to data given by gdcmHeader. For instance there are
1276 heuristics to get informations (look at different places).
1277 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1278 sorting DICOM images based on different strategies.
1279 * modified Makefiles accordingly.
1281 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1282 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1283 when building in debug mode
1284 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1285 src/win32/gdcmdll.dsp
1286 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1288 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1289 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1292 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1293 * src/win32/libgdcmjpeg12.dsp was not dos format
1294 * src/win32/libgdcmjpeg12.dsp :
1295 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1296 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1298 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1299 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1301 * src/gdcmFile.cxx : bug fix in affectation type
1302 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1303 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1304 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1305 symbols... future problem ?
1307 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1308 * src/win32/libgdcmijpeg12.dsp was missing
1309 * modified gdcm.dsw accordingly
1311 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1312 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1314 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1315 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1316 commit of JPR (before his hollidays to facilitate our work).
1317 * setup.py : bug fix in code. Modifications made while the last commit
1318 of JPR. The code hasn't been tested before the commit... it's so
1319 useless to make that (for best programmer that is JPR) !!!
1321 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1322 * tagged the current version as Version0_3 (i.e. version 0.3)
1324 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1325 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1326 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1327 * *.dsp : modifications to use new libgdcmijpeg8 library
1328 * setup.py : bug fix on VTKPATH variable
1329 * PACKAGER : adding all concerning windows
1331 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1334 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1335 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1336 test suite reported error.
1337 * PACKAGER file added (describes what a packager must do when
1338 packaging a new release).
1339 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1340 * configure.in: upgraded version number to 0.3.0
1341 * fixing build of rpm (through rpm -ta):
1342 - Doc/Makefile.am exports proper doxygen files
1343 - src/jpeg/libijg8/Makefile.am exports the include files.
1345 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1346 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1347 * src/gdcmHeader.h : formatting code
1349 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1350 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1351 We were obtaining error message from vtk. Now, creation of file list
1352 is made in an internal list to prevent this problem.
1353 Bug fix when output is empty.
1354 Bug fix in update of progress value. Previous commit for this was a bad
1356 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1358 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1359 * src/gdcmHeader.h : added method to get the file name
1360 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1361 files. Added method to remove all files on the input
1362 Added FIXME comment concerning the bad parsing of header made by
1363 ExecuteInformation method (in ExecuteData method)
1365 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1366 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1367 when using make instal.
1368 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1369 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1371 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1372 * setup.py : adding include dir of jpeg lib to compile all sources
1373 * */Win32/*.dsp : JPR fix for windows compilation
1375 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1376 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1378 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1379 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1381 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1382 * setup.py is again effective on un*x (takes into account the
1383 addon of the jpeg library)
1384 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1385 * Doc/Doxy* updated (includes above enhancements)
1386 * INSTALL now points to web documentation
1388 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1389 * src/gdcmHeader.h doesn't make unnecessary reference to
1391 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1393 * src/gdcm*.[cxx|h] :
1394 - to allow compilation with gcc 3.x
1395 -- clean up of STL usage (added explicit usage of std::)
1396 -- small fixes on exceptions.
1397 Note: linking not tested !
1398 - clean of doxygen comments to avoid warnings at documentation
1400 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1401 dependent convertion).
1403 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * Clean up of previous JPR garbage commit (not even commented in the
1406 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1407 - moved all jpeg related files from src to src/jpeg/libijg8, with
1408 addition/modification of Makefile.am and configure.in.
1409 - the testSuite is still brain damage (not guilty).
1411 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1412 * WrapVTK.py : modifications to get correctly vtk source files to
1414 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1415 (FileName -> Filename)
1417 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1418 * vtk/vtkGdcmReader.[cxx/h]:
1419 - UpdateProgress method should now be effective
1420 - removed the limitation on having only images loaded (as opposed
1422 - when building a stack of images/volume, a lesser number of
1423 gdcmHeader and gdcmFile instances should be used (hopefully
1424 accelerating things).
1425 - when building a stack of images/volumes, files which are not
1426 loadable (wrong path-filename, wrong permissions on existing file,
1427 or file not parsable by gdcm) are replaced with a black image
1428 in the stack (for the caller to notice the problem).
1430 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1431 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1433 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1435 between standard library (std) and vtk library (problems are found
1436 under Windows... thanks Windows !)
1438 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1439 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1441 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1443 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1444 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1446 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * When compiling with distutils (see setup.py) the C++ compiler is
1448 called with different flags than the default ones (with automake).
1449 In order to fix all those warning, I compiled gdcm with the command
1450 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1451 and went for warning fixes:
1452 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1453 up from unused variables.
1454 - vtk/vtkGdcmReader.cxx: potential bug fix.
1455 * src/gdcmHeader.h: Doxygen warning cleanup
1457 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1458 * gdcmPython/gdcm.i:
1459 - typemaps correction to take into account the systematic replacement
1460 of "using namespace std" with std:: prefix e.g. std::list,
1461 std::string... (cf changes of 2003-05-21).
1462 - gdcmGlob global variable of type gdcmGlobal (defined in
1463 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1464 exported to Python a as cvar.
1465 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1466 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1467 gdcmDictSet.GetPubDictTagNames() and
1468 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1469 C++ static methods).
1470 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1471 with the above changes.
1473 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1474 * setup.py, manifest.in : bug fix under linux
1476 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1477 * Modification of setup.py to compile vtk part too. Then, we have 2
1478 wrappers which must work with same distutils. For that, we have a
1479 generic distutils in distusiltsWrapping.py ; with :
1480 - build_extWrap class to wrap generically all extensions,
1481 - ExtensionWrap base class for all wrapping extension that contains
1483 - Wrapper interface which wrap sources
1484 + In WrapSwig.py we have extension and wrapper for Swig
1485 + In WrapVTK.py we have extension and wrapper for VTK
1486 * MANIFEST.in : modifications to consider vtk directory and new python
1487 files for compilation
1489 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1490 * Added python wrappers of vtkGdcmReader vtk class (see the
1491 source in vtk/vtkGdcmReader.cxx) :
1492 - vtk/Makefile.am now builds a library
1493 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1494 python library (as opposed to _gdcm.so wich are the python
1495 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1496 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1498 - configure.in has an additional flag --enable-vtk that needs
1499 to be set to enable compilation of vtk related code, that is:
1500 + vtk/vtkGdcmReader.so and
1501 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1502 + gdcmPython/vtkgdcmPython.so (see above)
1503 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1504 be read when compressed or when HighBit + 1 != BitsStored),
1505 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1506 the usage of the python wrapper of vtkGdcmReader vtk class.
1507 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1508 * src/*.[h] all occurences of stl classes are now prefixed with
1509 std::, and all occurences of "using namespace std;" where removed.
1510 This is to avoid pollution of global namespace in included files.
1511 Apparently vtk does not avoid this pitfall: when using both
1512 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1513 collision of various stl members (principally cout...).
1514 * gdcmPython/testSuite.py now cleanly removes temprory generated
1516 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1517 comply with above changes)
1519 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1520 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1521 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1522 vtk data structure (an image Flip was required).
1523 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1524 * cosmetic changes in documentation.
1526 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1527 * src/gdcmHeader.cxx: the constructor no longer exits when an
1528 unexisting file is given as argument.
1529 * The subdirectory Data (containing all the images used for the
1530 test suite) is not part of this repository anymore. A new module
1531 containing those images is now available at
1532 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1533 with the name gdcmData.
1534 All the python scripts (including the package initialisation file
1535 gdcmPython/__init__.py) were adapated to take this change into
1536 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1538 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1539 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1540 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1541 demo of the usage of this class.
1542 Compilation of this vtk part is only done when using the --enable-vtk
1543 at configure (or autogen.sh) stage.
1545 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1546 * More memory link related corrections and documentation fixes.
1548 - maximum info is obtained with a command of the form:
1549 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1550 --show-reachable=yes PrintHeader
1551 - the remaining reachable blocks seem to come from the STL
1552 allocation scheme through the usage of map and list. It looks
1553 like this memory cannot be freed but it is not a memory leak
1554 (in fact further invocation to the STL would recollect the
1555 unused memory allthough it cannot explicitely be freed).
1556 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1557 of displaying an image parsed with gdcm and displayed with VTK.
1558 Note: some images don't seem to work e.g.
1559 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1560 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1561 Allthough this weakens the semantics, it is a ditch attempt to
1562 make gdcm more thread friendly.
1564 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1565 * Memory link hunt (by using valgrind through the command
1566 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1567 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1568 gdcmHeader::_dicom_vr.
1569 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1570 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1572 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1574 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1575 * src/Makefile.am now exports all the necessary include files at
1579 * UpdateGroupLength replaced by new one
1582 * UpdateGroupLength re-written using H-Table
1583 (named UpdateGroupLengthNew untill checks are over)
1585 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1586 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1587 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1589 - gdcmHeader::GetPubElValSet removed.
1590 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1591 UpdateGroupLength, WriteElements, Write.
1592 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1593 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1594 carried the same semantics.
1595 - src/gdcmHeaderIdo.cxx changed accordingly.
1596 - gdcmFile::WriteBase now regroups all the codes from previous
1597 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1598 - enum FileType moved to gdcmCommon.h
1599 * src/gdcmHeader.cxx AddDefault trashed
1600 * gdcmGetXSize added
1601 * getimageDataSize now calls gdcmGetXSize
1602 * Test/*.cxx changed to agree with above changes
1604 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1605 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1606 (to avoid double call by end user).
1607 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1608 by end user, since gdcmHeader::gdcmHeader now handles it.
1610 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1611 * gdcm/Doc many doxygen changes:
1612 - Doxyfile now has two different versions, DoxyfileUsers that generates
1613 the html.users end users oriented documentation and
1614 DoxyfileDeveloppers that generates the html.developper developper
1615 oriented documentation.
1616 - README changed accordingly
1617 - requirement.txt removed (old design info moved to TODO).
1618 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1619 DoxyMainPage.txt, DoxyPython.txt provide more information.
1620 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1621 be updated by simply regenerating the docs with doxygen and copying
1622 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1623 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1624 all the tests in the form "if (<map>.count() >1)" were removed.
1625 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1626 ill-formed documentation sections.
1627 * src/gdcmHeader.cxx: ditto
1629 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1630 * setup.py fixed for un*x (needed macro for stdint.h)
1631 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1632 un*ces with sh-utils test utility.
1633 * gdcmPython/demo/test.py renamed to PrintHeader.py
1634 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1635 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1636 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1637 * src/gdcm*.cxx JPR's bad inclusion fixed.
1639 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1640 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1641 * gdcmPython/demo/test.py changed accordingly.
1643 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1644 * gdcmPython/Makefile.am fixed linking against libstdc++
1645 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1646 * Swig subdir (historical tests of swig version 1.3.17++) removed
1647 * Test/testChangeEntete.cxx some lines commented out in order to make
1649 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1650 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1652 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1653 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1654 hence the user doesn't need this explicit call.
1655 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1656 i.e. LoadElements() call removed.
1657 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1658 - src/Makefile.am declares the proper flag for g++.
1659 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1660 for adding user defined new tags.
1661 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1662 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1663 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1665 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1666 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1667 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1668 src/Makefile.am : the project should properly compile and install
1669 with the autotools, included the python wrappers part.
1670 * gdcm.spec.in : added a spec file for RPM packaging.
1672 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1673 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1675 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1676 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1677 to exported to the environement (see gdcmPython/testSuite.py
1679 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1680 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1681 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1682 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1683 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1685 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1686 * gdcmPython/__init__.py doesn't crash anymore when running in
1687 in InstallMode or PreInstallMode but with an environement given
1688 value of GDCM_DICT_PATH.
1689 * src/gdcmDictSet.[cxx/h] coding style.
1691 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1692 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1693 * src/gdcm.h general comments moved to TODO, and README
1694 * src/gdcm.h should now be seen as a user commodity (including it
1695 should suffice to fully use gdcm). It is nowhere including within
1696 any of the kernel files src/*.cxx and src/*.h.
1698 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1700 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1702 * src/gdcm*.cxx only include their corresponding include file
1703 (as opposed to gdcm.h)
1704 * gdcmPython/gdcm.i changed accordingly
1705 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1706 the autogen.sh generated "make snapshot" command to work.
1707 * autogen.sh removed history related references to crea package.
1709 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1710 * distutilsSwigCPlusPlus.py work around some swig portability
1713 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1714 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1715 was done in a last ditch attempt to get setup.py _really_
1716 operationnal. The python/gdcmPython layaout add the advantage
1717 of hidding away the python related distutils specific files
1718 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1719 Alas, the src directory was out of scope (i.e. it's relative
1720 position to setup.py was ../src) which made things impossible to
1721 handle (see previous version of python/setup.py). Crossing fingers...
1723 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1724 * python/setup.py now works on Un*x. (harder than I thougth)
1725 * python/distutilsSwigCPlusPlus.py can now have include files
1726 among the list of sources.
1728 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1729 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1730 * modifications in MSVC projects
1732 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1733 * As stated by the first lines of Test/ExceptionAndPython/README, it
1734 looks like we can move back to original usage of exception within
1735 src/gdcm* and hence remove the errno stuff that was introduced
1736 as a quick and dirty fixture of this problem (added to the TODO).
1737 * Doc/Doxyfile configuration file for Doxygen and corresponding
1738 README file for usage added.
1739 * Test/testWrite.cxx added. This new test comes from a split of
1740 test.cxx that is now reverted to its original purpous i.e.
1741 testing the proper parsing of a Dicom related file.
1742 testWrite.cxx concentrates on testing the IO part of gdcm.
1743 * Test/bug1.cxx (containing a bug on WIn32) added.
1744 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1745 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1746 whose purpose is to publish the content of the TagNames of the
1747 Dicom public dictionnary were not accessible without an
1748 instance of class gdcmHeader.
1749 - those methods are now static methods of gdcmDictSet and hence
1750 require no instances at all to be invocated.
1751 - within gdcmDictSet this change required to change some method
1752 to class methods (i.e. are now static) among which SetDictPath
1753 (renamed to BuildDictPath) and LoadDefaultPubDict.
1754 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1755 the above changes by calling the new method classes of gdcmDictSet.
1756 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1757 the above to be effective.
1758 * python/gdcmPython: in order to wrap properly the above changes
1759 for Python, swig version now needs to be > 1.3.17.
1760 * python/gdcmPython/Makefile fixed to adapt itself to new
1761 configure/make shema introduced by Johan Montagnat (thanks for the
1762 contribution). Alas this Makefile cannot be turned into a proper
1763 Makefile.am without some heavy changes in the configure.in
1764 (for python dectection).
1765 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1766 now avoids publishing the empty entries.
1768 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1769 * python/setup.py : bug fix concerning install under windows
1770 ExtraPath reused :-P
1771 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1773 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1774 * Dicts/dicomV3.dic : remove double spaces !!!
1775 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1776 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1779 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1781 method. Doxygenation.
1782 * src/gdcm.h clean up of JPR spurious comments.
1784 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * python/distutilsSwigCPlusPlus.py now properly collects the
1786 shadow classes generated by "swig -c++" (gdcm.py in our case)
1787 when using "python setup.py install".
1788 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1789 reexports the working classes.
1790 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1791 by the classical C errno scheme. This is to prevent an obscure
1792 behavior of the python wrappers when importing wxPython.wx prior
1793 to gdcmPython (which ended up in an abort call). An illustration
1794 of this oddity can be found in the Test/ExceptionAndPython
1795 subdir (see the README file). This problem probably due to
1796 an combination of g++ and dynamic loading.
1797 * added Test/ExceptionAndPython (see above)
1799 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1800 * Changed the layout of the python part to avoid bloating main
1801 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1802 i.e. the distutils arsenal. All the python related stuff is
1803 again in a python subdir, but the package itself is now in
1805 * setup.py was cleaned up:
1806 - pythonIncludePath removed
1807 - python setup.py bdist target is now functional.
1808 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1809 collision with other packages). gdcmPython/demo/*.py changed
1812 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1813 * python subdir moved to gdcmPython (preparation of distutils packaging).
1814 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1815 distutils installer is operational.
1816 * - gdcmPython/__init__.py now properly loads the swig generated
1817 shadow classes (from gdcm.py).
1818 - gdcmPython/demo/*.py changed to import the package gdcmPython
1819 instead of gdcmPython/demo/load.py.
1820 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1822 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1824 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1825 entries within the associated public Dicom dictionary resp. the same
1826 information but sorted by the fourth field (PAT, IMG, DIR) of the
1828 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1829 are now in the "???" group.
1830 - python/gdcm.i changed accordingly,
1831 - python/demo/printGroupedPublicDict.py added, that gives an example
1832 of the above new functionalities in Python.
1834 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1835 * src/gdcm.h, gdcmHeader.cxx:
1836 - historic references to glib's g_malloc and g_free (#defined)
1837 were definitively removed.
1838 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1839 * src/gdcmElValSet.cxx:
1840 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1841 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1842 - GetElValue(string) renamed to GetElValueByName.
1843 - Added GetElementByName(string).
1844 * src/gdcmHeader.cxx: added
1845 - GetPubElValRepByNumber(guint16, guint16)
1846 - GetPubElValRepByName(string)
1847 - GetShaElValRepByNumber(guint16, guint16)
1848 - GetShaElValRepByName(string)
1849 - GetShaElValByNumber(guint16, guint16)
1850 - GetShaElValRepByName(string)
1851 - GetElValRepByNumber(guint16, guint16)
1852 - GetElValRepByName(string)
1853 - GetElValByNumber(guint16, guint16)
1854 - GetElValRepByName(string)
1855 * Doc/requirements.txt added.
1857 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * Test/Makefile building now depends on the one of libgdcm.so
1859 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1860 pixel data) aware which enables finding the address (offset) of
1861 the pixel data of JPEG encoded DICOM files. This leaves only a single
1862 file in the testSuite whose pixel data address (offset) is unknown.
1863 * python/testSuite.py changed accordingly.
1865 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1866 * VC++ has some strong limitations when working with the STL, as stated
1867 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1868 "Also note that some STL containers (map, set, queue, list, deque)
1869 cannot be exported. [...]
1870 Some STL classes contain nested classes. These classes can not
1872 This is caused by a designed limitation that once a template
1873 class is instantiated, it can not be re-instantiated and
1875 Since our usage of map<> is ubiquitous in gdcm, this "designed
1876 limitation" of VC++ is a pitfall.
1877 Hence the Python wrappers of gdcm cannot be incrementally linked
1878 against the c++ dynamic library. The dirty but only workaround is
1879 to forget about incremental link of dynamic libraries and to generate
1880 the Python wrappers library with the inclusions of the underlying C++
1882 The following modifications concern this matter on Win32/VC++:
1883 - wrapping python correct with standalone wrapped dll (don't use separate
1884 dll under windows !!!!)
1885 - python21_d debug mode enabled (ask Frog how to use it :-)
1886 - NO problem with having an STL member of class for example string in C++
1887 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1888 - Python test of dcmlib in Python is ok under windows on a large set
1890 * removed glib references
1891 * typedef's inserted in gdcm.i for correct swig type management
1893 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1894 * python/demo/*.py load.py extracted from test.py. Added explore.py
1895 that only displays required tags and testAll.py that parses all
1896 the files of the testsuite without using unittest.
1897 * python/testSuite.py other additional test on new files added.
1898 * Data/* new test files added accordingly to the testSuite.
1899 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1900 the vr in the file differs from the one of the dictionary.
1902 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1903 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1904 values, but limits itself to values which are below a user specified
1905 size (by default 1024 bytes).
1906 * python/gdcm.i : elements not loaded (because their size is above the
1907 user specified treshold) are exported with their TagKey as key of the
1908 python dictionary. This enables the testsuite to make some checks
1909 on the unloaded elements (since we have their offset and size).
1910 * python/testSuite.py
1911 - now tests for the existence and proper value of the pixel data
1912 - two new examples added.
1913 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1915 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1916 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1917 aware. See the strategy comments in gdcmHeader::FindeLength().
1918 * Test/test.cxx now accepts a filename as first argument.
1919 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1920 * python/testSuite.py changed to integrate test on above files.
1922 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1923 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1924 the vr was also RET.
1925 * python/testSuite.py more tests added.
1927 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1928 * python/testSuite.py unittest test suite added (uses Data)
1929 * Data/* dcm and acr files for the test suite.
1930 * glib dependance removed from un*x version. We now use ISO C99
1931 7.18 Integer types (see stdint.h)
1932 - python/Makefile, src/Makefile src/gdcm.h
1933 * src/ when an explicit vr (like dicom files) suddenly poped an
1934 implicit element we use to mark the underlying DictEntry of the
1935 concerned ElValue with "Implicit". This strategy was damageable
1936 too the public or provite dictionaries, since some of their vr
1937 would be changed. Since Header::FindLength heavily relies on the
1938 detection by Header::FindVR of falsely explicit elements, I
1939 added an extra ImplicitVr member to ElValue (boolean).
1940 The rest of the changes we the necessary adaptations.
1942 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1945 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1947 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * Adaptation for porting to VC++:
1950 o forced to use std namespace (for string to be known)
1951 o all class use __declspec export style on WIN32
1952 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1953 (in stdlib.h on Win32 but in std:: for gcc)
1954 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1955 variable GDCM_DICT_PATH.
1956 * src/gdcmHeader.cxx verbose comments made discrete.
1958 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * python/gdcm.i: added a typemap that converts a C++ hashing table
1960 to native Python dictionary.
1961 * python/demo/test.py:
1962 - now uses the native dictionary for exploration of gdcmHeader.
1963 - takes an optional filename argument (the file to parse).
1964 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1965 PubElVals hashing table.
1966 * Dicts/dicomV3.dic removed error prone trailing spaces.
1968 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * Python wrapping process moved away from src/Makefile to
1970 newly created python/Makefile (as well as gdcm.i)
1971 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1972 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1973 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1974 from the environement variable GDCM_DICT_PATH (when existing).
1975 * src/gdcmDict::GetTag bug fix.
1977 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * Straightforward temporary fixes for swig to build the python wrappers.
1979 src/Makefile now has a python working entry [by working we mean
1980 that we can import de shadow classes without errors].
1982 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1983 * hashtest.cxx removed (since allready in Test)
1984 * src/gdcmlib.h renamed to src/gdcm.h
1985 * src/dcm.i renamed to src/gdcm.i
1986 * src/Makefile prepared for python wrapping
1988 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1989 * src/gdcmHeader.cxx :
1990 - Parsing of header is now separated from loading of element values
1991 (see gdcmHeader::LoadElements).
1992 - general clean up of hopefully all file access (creation of
1993 ReadInt16 and ReadInt32)
1995 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * src/gdcmHeader.cxx :
1997 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1999 - SetLgrElem renamed to SetLength
2000 - GetLgrElem renamed to GetLength
2001 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2002 * src/gdcmElValSet.cxx fixed both GetElValue methods
2003 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2004 due to IdoDude was cleaned out.
2006 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2007 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2008 concentrates on finding the value representation (when it exists).
2009 RecupLgr now only finds the element value length, and it avoids
2010 returning the unecessary skL (skipped length).
2011 Also, offsetCourant was simply removed (with taille_fich) since
2012 it was redundant with the File position internals (by using
2013 ftell and fseek). This also made skL (see above in RecupLgr) usage
2015 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2016 on the libido specificities which are handled through class
2018 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2021 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * Truckload of changes. Parsing of header is barely functional
2023 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2025 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2026 * src/gdcmHeader.cxx many addons of low level methods
2028 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2030 and _IdDcmSWAP_LONG.
2032 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2033 * This corresponds to all the changes decided at the meeting of
2034 May 23 2002. Needless to say we are running late...