1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
3 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
6 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
8 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
9 after it have been deleted
11 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
12 * FIX: src/* fix the doxygen warnings.
14 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
15 1. Finish merging JMR patch for writting DICOM from scratch
16 2. Fix -hopefully- bug with MONOCHROME and space vs null character
17 3. Use const ref when possible
18 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
19 5. A few more comments
20 6. CreateUniqueUID can now be called without parameter"
22 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
23 * ENH: Slightly bigger patch:
24 1. Getting toward full integration of JMR patch for writting dicom from scratch
25 2. Update Test to test part of this patch: CreateUniqueUID
26 3. File was not close properly in gdcmDict
27 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
28 5. Use of const ref instead of copy (speed issue)
29 6. Remove temporary (duplicate) string in TranslateToKey
30 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
31 8. Do not repeat virtual in subclasses
32 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
34 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
35 * Apply first patch toward better string comparison when dealing with broken
36 DICOM files. Essentially the string could be padded with a space instead
37 of a null character as defined by standard
39 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
41 because never used... and in the same time, that's remove some memory leaks
43 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmFile.cxx : now delete the PixelConvert instance.
45 * In examples and tests : change the type of image data variables from void*
46 to uint8_t*. Remmove all delete on image data variables
48 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
50 Verify the file pointer value before open the file, and if it's not null,
51 a verbose message is generated.
52 Close correctly the file when the file isn't considered dicom-like. The
53 correctly close is a call to CloseFile.
54 When closing the file pointer, test if its not null to close the file.
55 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
56 file. For an uncompressed image, the copied datas correspond in the least
57 case to the image size (calculated) or the image size specified in the
58 header. A verbose is generated if these two size mismatch
60 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
62 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
63 break under windows (with msvc6 compilation).
65 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
69 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * Bugs fix for the Windows build with VC6
71 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
72 needed (only for projects required VTK). If the VTK is included in all
73 projects, there is conflicts with the jpeg lib of vtk when compiling the
74 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
75 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
76 when compiling the gdcm_wrap.cxx file (created by the compilation of the
78 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
79 (like it's already made for the cout use). Otherwise, conflict with the
82 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
83 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
85 - comments on the DicomDir::Method related usage added.
86 - now that we use the namespace gdcm, a lot of internal classes do
87 NOT need to be wrapped anymore.
88 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
89 DicomDir::Method) new example added.
91 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
92 * Improve string manipulation. I now inforce the notion of 'DicomString'
93 A DicomString can contain as many \0 as they want
94 and it is *always* of even length.
95 We only support odd length for very rare case.
96 And in the near future this should be removed.
98 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
99 * /binary_write/ gdcm source. Now even on big endian we are writting
100 little endian. This should -heopfully- fix some tests
102 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
103 * Now the dictionary is compiled into gdcm lib. This is a default
104 behavior, thus any dic file specified is picked before failback to
105 the one comiled into lib
107 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
108 * Change internals for gdcmDict. Don't use any 'new' any more.
109 This should definitely solve any leak problem, and we should be
110 as fast as before, as long as don't modify too much the dictionary.
112 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
113 * STYLE: ivars should start with a capital letter.
114 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
115 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
117 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
118 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
119 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
120 new 2004 dictionaries added (thanks to JPR).
121 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
122 * CLEANUP_ROUND (15) for gdcmPixelConvert
123 - RLEFrame::NumberFragments is now of type unsigned int
124 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
125 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
128 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
129 * Initial work in gathering all transfer syntax accessors. clearly
130 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
131 ivars, but only one transfersyntax (class) ivar with equivalent method on
134 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
135 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
136 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
137 discussed (plus I didn't like having a 2000 lines patch not commited)
139 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
140 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
141 * CLEANUP_ROUND (14) for gdcmPixelConvert
142 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
143 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
144 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
146 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
147 anymore and hence avoids storing a copy of PixelConvert::Decompressed
148 into File::Pixel_Data.
150 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
151 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
152 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
153 * CLEANUP_ROUND (13) for gdcmPixelConvert
154 Substituted File::ParsePixelData() with PixelConvert::Print() new
156 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
157 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
158 method to those classes.
159 - src/gdcmFile.[cxx|h]:
160 -- Added a ::Print() method.
161 -- PixelConverter is now a reference instead of a member.
162 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
163 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
165 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
166 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
167 collaboration diagram and inheritance diagram should be generated with
169 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
170 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
171 pointlessly wrapped (see
172 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
173 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
174 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
175 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
176 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
177 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
178 -- File::Initialise: PixelConverter setup moved away to
179 PixelConverter::GrabInformationsFromHeader()
180 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
181 interpretation moved away to PixelConverter::BuildRGBImage()
183 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
184 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
185 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
187 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
189 displayed on Win32 when a brutal abort() occurs (because of uncatched
190 exception). See TODO new entry of this commit for more on this.
191 * TODO added new entry.
192 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
193 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
194 - HandleColor is no longer called from gdcmFile.cxx
195 - gdcmPixelConvert.cxx clean up on method arguments and internal
196 variable names for semantical coherence.
198 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
199 * Finished lossless transition, not only do we now read all lossless jpeg
200 images, without the need of the Cornwell lib, but we do read them properly now
201 * To reduce code (well to avoid code duplication), I defined a common place
202 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
203 redefine symbols. This is not prefect but this the best solution I found for a
204 compilation time jpeg option.
206 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
207 * Update jpeg ijg lib to support lossless jpeg implementation
208 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
210 * Also added a special copyright for dcmtk since we use their bugfixes.
213 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
215 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
216 matters, as stated in warning note at begining of %include section).
217 * src/gdcmDicomDir*.[cxx|h]: coding style
218 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
219 * src/gdcmJpeg8.cxx: doxygen fix.
220 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
221 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
222 from File:: to PixelConvert::.
224 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
225 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
226 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
227 - more code moved away from File:: to PixelConvert::
228 - fat setup of PixelConverter set in place in File::Initialise.
230 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
232 namespace at the file system level. So now you should convert your examples
234 gdcmHeader -> gdcm::Header
235 It would be nice if people keep in mind to no open the namespace, since it
236 allows compilation on broken plateform which were defining common symbol in
237 the standart namespace (like LP, Unknown ...)
239 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
240 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
241 The JPEG fragments are now parsed at the same stage than the RLE
242 information. All code related to JPEG is now in gdcmPixelConvert:
243 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
244 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
245 export a gdcmFile:: method. Those are simply global functions
246 (for the time being this is better than having them attach to
247 either gdcmFile:: or gdcmPixelConvert::).
248 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
249 and stores the result in a gdcmJPEGFragmentsInfo.
250 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
251 code (among other stuff) moved away from gdcmFile:; to
254 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
255 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
256 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
257 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
258 clean up of RLE related code.
259 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
260 - src/gdcmRLE.cxx removed
261 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
262 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
263 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
264 * CLEANUP_ROUND (9) for gdcmPixelConvert
265 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
266 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
267 away from gdcmFile:: to gdcmPixelConvert::.
269 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
271 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
272 This is because Parse7Fe0 used to parse the pixels to compute the
273 length. This task was passed over to FindDocEntryLengthOB() a long
274 time ago, EXCEPT I had forgotten the OW case...
275 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
276 we just recylce the code for parsing RLE fragments and computing
278 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
279 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
280 with the retired Parse7Fe0().
281 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
282 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
284 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
285 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
286 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
287 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
288 - src/CMakeLists.txt: alphabetic order reodering + new entries.
289 * CLEANUP_ROUND (4) for gdcmPixelConvert
290 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
291 to return an unused length.
293 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
294 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
295 this should be cleanner from the plane view. The iostream are erally a pain
296 to use to do simple stuff.
298 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
299 * Redo the compilation of the ijg jpeg library. Now only one source is
300 necesseray. No need to rename file by hand what so ever. CMake handle the
301 copying of the file within different directory, configure header file to
302 modify some symbol. The only addition made to ijg wasd a mangle table so
303 that symbol are different wether we are within 8bits or 12bits.
305 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
306 * Added documentation of vtkgdcmReader on Website:
307 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
308 with it's binary name).
309 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
310 the Website to be more complete.
311 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
312 doxygenated documentation.
313 - Doc/DoxyVtkGdcmReaderExamples.txt added
314 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
315 DoxyVtkGdmReaderExamples.html )
316 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
317 * CLEANUP_ROUND (3) for gdcmPixelConvert
318 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
320 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
321 * CLEANUP_ROUND (2) for gdcmPixelConvert
322 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
324 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * CLEANUP_ROUND for gdcmPixelConvert:
326 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
327 - src/gdcmPixelStuff[h|cxx] removed
328 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
329 - src/CMakeLists.txt changed accordingly
331 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
332 gdcmVersion.py moved to newly created ATTIC related
333 gdcmPython/SetupOldies/ directory.
334 * Autotools clean up:
335 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
336 - autogen.sh configure.in acinclude.m4 python.m4 removed
338 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
339 * src/*.cxx *.h Reference to License.htm fixed to License.html.
340 * Doc/CMakeLists.txt, doxygen.config.in: fix.
341 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
343 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
344 * TODO updated with Mathieu suggestions. I proposed a template for
345 describing TODO entries and used it for new entries.
346 * Added Doc/Website/CodingStyle.html, Developpers.html,
347 DeveloppersPython.html, GdcmDataCvs.html and
348 DownloadVersion0_1.html, DownloadVersion0_3.html.
349 * Some Doc/*.txt Doxygen files (which do not really concern the
350 documentation itself, but the website) moved to html and
351 placed in directory Doc/Website:
352 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
353 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
354 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
355 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
356 * CMakeLists.txt changed accordingly.
357 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
358 DeveloppersPython.html
359 * INSTALL nows refers to Doc/Website/Installation.html
361 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
362 * Added Doc/Website directory, that contains a first raw version
365 2004-09-23 Jean-Pierre Roux
366 * FIX In order not to be poluted any longer by casting problems,
367 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
368 we can now delete[] it safely
369 * VoidArea is now called BinArea (less confusing name),
370 and all the methods called ...VoidArea... are now ... BinArea...
371 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
373 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
375 clear) TagHT, which is an inherited member of gdcmElementSet. It is
376 up to the destructor of gdcmElementSet to clean up TagHt and it's
379 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
380 * Test/CMakeLists.txt: update to follow gdcmData renamings.
381 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
383 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
384 * ENH: added some utility method that builds a flat dictionnary
385 holding all the Dicom entries contained in the recursive structure
386 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
388 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
389 BuildFlatHashTable() that build a flat dictionary.
390 - src/gdcmElementSet.h: added a new private GetTag() accessor.
391 gdcmDocument is now a friend of gdcmElementSet.
392 - src/gdcmElementSet.cxx: clean up.
393 - Example/FlatHashTablePrint.cxx added.
394 - Example/CmakeLists.txt changed accordingly
396 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
397 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
398 moved away from gdcmDocEntrySet (since this class is an abstract class
399 acting like an interface). SQDepthLevel and BaseTagKey are now
401 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
402 and associated accessors. Doxygenation of the class.
403 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
405 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
406 Use SQDepthLevel accessor instead. ::Print() adapted.
407 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
408 - src/gdcmDocument.cxx changed accordingly.
410 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
411 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
412 - The following is the doxygen comment of the typedef declaration
413 of gdcmagKey in src/gdcmCommon.h:
414 gdcmTagKey is made to old an "universal" (as in URL, Universal
415 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
416 A dicom tag allways has a group and an element, but a set of tags
417 embeded in various (optionally nested) sequences and sharing
418 the same group and element all share the same (group, element)
419 "identifier". Hence the (group, element) cannot be used as an
420 identifier (in gdcm we shall refer to a "TagKey") of a tag.
421 In order to construct a proper tag identifier (i.e. a key) we
422 consider the following definition of a TagKey:
423 - let Group, Element be the string representation of the
424 group and element dicom tag members,
425 - let ItemNumber be the string representation of the integer
426 index of the considered item number of a sequence,
427 Let the key of a tag embeded in a sequence, noted SeqTag, be
429 /ItemNumber#Group|Element
430 where "/", "#" and "|" are characters acting as separators.
431 Then the general form of a gdcmTagKey is given by:
432 Group|Element<SeqTag>
433 where <SeqTag> means NO or many instances of SeqTag.
434 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
437 but the gdcmTagKey of a tag "embeded" is the first item of
438 a sequence, itself nested in the third item of a sequence is the
440 0004|1220/2#0008|0082/0#0008|0090
441 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
442 order to hold the new sequence compatible key. Previously, the
443 GetKey() method would look in the underlying gdcmDictEntry.
444 - src/gdcmDocEntry.cxx:
445 -- constructor now copies the underlying DictEntry key, in the local
447 -- ::Print: displays the member Key, instead of the (group, element).
448 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
449 - src/gdcmDocEntrySet.h:xi
450 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
451 -- now has a new BaseTagKey member.
453 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
454 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
456 This poses the problem with the semantics of the following lines
457 LoadEntryVoidArea(0x0028,0x1201); // R LUT
458 LoadEntryVoidArea(0x0028,0x1202); // G LUT
459 LoadEntryVoidArea(0x0028,0x1203); // B LUT
460 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
461 to the long FIXME note for what the problem is. Nevertheless in
462 order to get things working the dicom dictionary was altered !
463 Please fix things urgently...
464 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
465 information), see above note on moving the member VoidArea. Nevertheless
466 the following entries previously correctly set as US are now inproperly
468 0028 1201 OW IMG Red Palette Color Lookup Table Data
469 0028 1202 OW IMG Green Palette Color Lookup Table Data
470 0028 1203 OW IMG Blue Palette Color Lookup Table Data
471 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
472 of gdcmDocEntry moved to gdcmSeqEntry.
473 * src/gdcmSeqEntry.cxx: STYLE.
475 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
476 * Test/TestAllEntryVerify.cxx minor fix and added comments.
478 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
479 * gdcmPython/testSuite.py: all the test suite in python is now moved
480 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
481 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
482 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
484 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
486 to avoid inclusion recursion until STL is reached.
487 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
488 mecanism. errno.h is not included in gdcm anymore.
489 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
490 (gdcmFormatError now inherits from gdcmFormatUnexpected).
492 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
493 gdcmData/TestAllEntryVerifyReference.txt
494 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
495 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
496 exception_on_error parameter.
497 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
498 - vtk/vtkGdcmReader.cxx changed accordingly,
499 - Example/*.cxx and Test/*.cxx changed accordingly.
501 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
503 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
504 enable_sequences removed from gdcmHeader constructor and dependencies.
505 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
506 * gdcmPython/demo/PrintHeader.py: dummy fix.
507 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
508 skip_shadow removed from gdcmHeader constructor and dependencies.
509 * Example/*.cxx and Test/*.cxx changed accordingly.
511 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
513 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
515 2004-07-21 Jean-Pierre Roux
516 * FIX Now, Parsing and Printing a DICOMDIR do work!
517 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
519 2004-07-20 Jean-Pierre Roux
520 * FIX Some brain damaged headers have Zero-Lenght fields
521 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
523 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
524 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
525 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
526 variable (instance of gdcmDebug) by a definition macro, and the instance
527 is now in static in the gdcmDebug class
528 * src/gdcmSQItem.h : (FIXME) remove an undefined method
529 * Test/PrintAllDocument.cxx : bug fix in the result of the test
531 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * WARNING: ctest now depends more tightly on gdcmData. You should
533 check out gdcmData properly for things to run smoothly...
534 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
535 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
536 we need the pixels not be loaded in order to use the ValEntry
537 that displays position and size).
538 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
539 This is a C++ based equivalent of gdcmPython/testSuite.py that should
540 be deprecated. If you have any doubts about the advantages of a
541 modern scripting language (read Python) versus grass root C++ (i.e.
542 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
543 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
544 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
545 Anyhow, consider documenting the gdcmData images in
546 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
548 * Test/CMakeLists.txt:
549 - now uses TestAllEntryVerify.cxx
550 - specific comments on oldACR00001.ima (now renamed in gdcmData
551 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
552 gdcmData/TestAllEntryVerifyReference.txt
555 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * src/*.[h|cxx] : typedef clean up
557 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
558 - TagKey renamed to gdcmTagKey (for external usage)
559 - VRKey renamed to gdcmVRKey (for external usage)
560 - removal of typedef duplication.
561 - Removed all unecessary inline keyword from class inline definitions.
562 - Some method|function(void) declarations replaced with method|function().
563 * src/jpeg/libijg12/jdhuff12.c:
564 - printf polluting ctest removed.
565 - TAB removal for comminting
567 - TestAllReadCompareDicom.cxx: added a test that compares all the
568 images in gdcmDataImages.h with corresponding images in
569 gdcmData/BaselineDicom/. When baseline images are not present
570 this test creates them.
571 Note: we need to validate each reference image, but before that
572 I'd like to rename them with a more explicit name...
573 - CMakeLists.txt: changed accordingly.
574 * Example/*.cxx: examples now only include gdcm.h (as opposed to
575 including each header needed).
577 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * Test/*.cxx and Example/*.cxx: moved some examples away from the
579 test suite to the Example directory. Are concerned:
584 - TestWriteSimple.cxx
585 * Test/CMakeLists.txt: added some comments on reasons for black listing
586 image gdcmData/oldACR00001.ima
588 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * Test/CmakeList.txt: removed the following from black list (to be coherent
590 with removal from gdcmData):
591 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
592 - gdcm-MR-PHILIPS-16.dcm
594 Added the following because after last cvs update, they cause
595 ctest -R TestReadWriteReadCompare
597 - gdcm-MR-SIEMENS-16-1.acr
599 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
600 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
601 new comments in this file) we temporarily (sigh) move to a weaker
603 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
604 we don't need to black list the following images anymore:
605 - 8BitsUncompressedColor.dcm
607 - US-PAL-8-10x-echo.dcm
608 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
609 fixes and the beautified code ;-)
610 This fixes the bug introduced in version 1.42 (when beautifying)
611 that made the parsing of 8BitsRunLengthColor.dcm unproper.
612 Note: ctest was blind to this bug (this means we need to still
613 improve the test suite). The bug could be detected by using
614 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
616 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
617 and by displaying the (garbage) produced file temp.XDCM...
619 2004-06-29 Jean-Pierre Roux
620 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
621 - replace by uggly but working old code :-(
622 A lot of things should be OK again.
623 It's really urgent to have a test suite that *tests*,
624 to prevent Frog's beautifying sessions to break all the stuff
625 (twice, withing a fortnigh ...)
627 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
629 redundancy) to added Test/TestReadWriteReadCompare.cxx
630 * Test/CmakeList.txt: because the compare test of
631 Test/TestReadWriteReadCompare.cxx fails, the following images are
632 black listed: - 8BitsUncompressedColor.dcm
634 - US-PAL-8-10x-echo.dcm
635 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
636 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
637 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
638 and ad-hoc kludge. This kludge is now removed, and on encountering
639 such an image (OB field brain damaged) we set errno. Then in
640 ::FindDocLength() we "fix" the length as being ALL what remains
641 in the file (until EOF). We then proceed, hoping for the best...
642 This fixes a SegFault in ShowDicom when trying to write such an
644 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
645 (because TestWriteRead breaks on it, after a non conformal commit?).
646 ctest now runs properly, except for MakeDicomDir (which was allways
647 broken) and the Python related stuff (still not fixed).
649 2004-06-24 Jean-Pierre Roux
650 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
651 FIX : Test/TestReadWrite now iterates on all the file names
652 (instead of infinite loop)
653 ENH : Test/TestWriteRead now iterates on all the file names
655 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
658 2004-06-24 Jean-Pierre Roux
659 FIX : - now Write drops LUT Descriptors and LUTs (if any)
660 when SamplesPerPixel =3
661 - now Write is no longer confused by
662 'BitsAllocated = 12" and 'BitsStored=12"
663 - "UN" value representation Elements are now written correctly
664 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
665 ENH : - now gdcmHeader has its own Write methods
666 (in order to split the job that has not to be done
669 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
670 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
671 loop on the same image until memory went out.
672 Note: this means we still have gobs of memory loss in PrintDocument
673 * src/gdcmDocument.cxx: fixes problem on parsing on file
674 gdcmData/16BitsJpegLosslessGrayScale.dcm.
676 2004-06-24 Jean-Pierre Roux
677 FIX : Write - All the Sequences and Sequence Item are now written
678 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
679 is added a the end, when necessary.
680 - A lot of brain-damaged images, that were read correctly are
681 now written correctly
682 - length compatible BinEntry are now loaded correctly
683 (even for odd groups)
684 Note : only Explicit Value Representation was checked.
685 (question : is implicit VR really necessary for gdcm ?)
687 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * DEVELOPPER: added a proposition of coding style.
689 * src/gdcmDocEntry.h: removed every inline declaration (for test of
692 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
694 Use the gdcmDocEntry::Print() and Write() instead.
695 * src/gdcmDocument.cxx: bug fix.
697 2004-06-22 Jean-Pierre Roux
698 FIX : gdcmDocument.cxx
699 - Now we do recognize the JpegLossLess format (there was a misstyping in
700 code 'beautyfication' :-(
701 - Now we automaticaticaly load the Luts, if any
703 2004-06-22 Jean-Pierre Roux
704 In order : to write Sequences, whatever their imbrication level,
705 : to allow user to create his own Sequences
706 a lot of modif where necessary (adding, moving, or virtualising methods)
708 WARNING : save your own sources *before* cvs up !
711 ADD virtual void Write(FILE *fp, FileType filetype);
714 ADD virtual void Write(FILE *fp, FileType filetype);
715 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
718 ADD virtual void Write (FILE *fp, FileType filetype)=0;
719 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
720 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
721 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
722 ADD std::string GetEntryByName(TagName name);
723 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
725 std::string vr = "unkn",
726 std::string fourth = "unkn",
727 std::string name = "unkn");
728 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
729 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
730 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
731 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
732 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
733 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
734 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
735 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
738 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
739 ADD virtual std::string GetEntryByName (TagName tagName);
740 ADD virtual std::string GetEntryVRByName (TagName tagName);
741 REM virtual bool Write(FILE *, FileType);
742 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
743 FILE *_fp, FileType type);
744 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
745 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
746 REM virtual bool WriteEntries(FILE *_fp,FileType type);
747 REM virtual std::string GetEntryByName (std::string tagName);
748 REM virtual std::string GetEntryVRByName (std::string tagName);
749 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
750 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
751 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
753 std::string vr = "unkn",
754 std::string fourth = "unkn",
755 std::string name = "unkn");
756 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
757 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
758 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
759 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
762 ADD virtual void Write(FILE *fp, FileType filetype);
765 ADD virtual void Write(FILE *fp,FileType filetype);
768 ADD virtual void Write(FILE *fp, FileType filetype);
769 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
770 REM std::string GetEntryByNumber(guint16 group, guint16 element);
771 REM std::string GetEntryByName(TagName name);
774 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
776 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
777 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
778 The default constructor invoked by the line
779 gdcmHeader *f1 = new gdcmHeader( header );
780 was gdcmHeader::gdcmHeader(bool) instead of the expected
781 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
782 Hence the parsing wasn't executed... See also below.
783 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
784 as explicit constructor didn't do the trick to fix the above problem.
785 Could anyone explain why ?
786 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
787 properly calls gdcmValEntry::Print() (that was weed out from
788 code related to gdcmBinEntry).
790 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * In order to fix memory leaks:
792 - Test/TestWriteSimple.cxx: added cleaning of free store through
794 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
795 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
796 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
797 (through the call to ::AddDicomDirMeta()) or the destructor
798 would crash when deleting uninitialized ::metaElems].
799 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
800 - src/gdcmDocument.cxx:
801 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
803 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
804 was causing memory leaks.
805 - src/gdcmSQItem.cxx:
806 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
807 cleanly handled with polymophism: sorry but my milage is low).
808 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
809 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
810 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
811 This avoids SegFaulting.
812 - src/gdcmSQItem.h: coding style.
814 - Test/TestWriteSimple still severely sucks. The output image content
815 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
816 damaged when displayed with vtkgdcmViewer.
817 - on memory leaks: TestWriteSimple leaks really less (see entry
818 of 2004-06-18 in Changelog file for the call to valgrind).
819 - on segfaults: ctest now passes all the tests but one (no more
821 * Erroneous leading white fix:
822 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
823 white[s] (as opposed to from >> xxx, that removes it [them].
824 - src/gdcmTS.cxx: ditto.
825 - gdcmPython/testSuite.py: dirty related kludge removed.
826 * src/*: remaining references to gdcmParser removed.
827 * src/*[cxx|h]: added copy[way]left header.
830 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * In order to fix writing of dicom files:
832 - Test/TestWriteSimple.cxx: a simpler example of writing.
833 - Test/CMakeLists.txt changed accordingly.
834 - src/gdcmDocument.cxx:
835 -- The destructor now recursilvely removes potential sequences.
836 -- Bug fix in ::IsJPEG2000()
837 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
838 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
840 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
841 to only declared) and build on top of
842 ::GetDocEntryByNumber(guint16, guint16).
843 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
844 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
845 for usage in destructor and treatement of promotion in
846 ::ReplaceOrCreateByNumber().
847 - src/gdcmSQItem.cxx: destructor should better handle his job.
848 Test/TestWriteSimple now runs (or at least it DOES something).
849 * We can now start hutting memory links. A good starting point is:
850 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
851 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
852 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
854 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
855 * Valgrind note: after Mathieu Malaterre teached me how to read
856 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
858 Using gcc, you can force the STL to use malloc and to free memory as
859 soon as possible by globally disabling memory caching.
860 With 3.2.2 and later, you should export the environment variable
861 GLIBCPP_FORCE_NEW before running your program.
862 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
863 simply vanish (it is still not clear to me, whether this means that
864 STL std::string leaks or if valgrind believes it leaks...).
865 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
866 running bin/gdcmTests makeDicomDir):
867 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
868 - Test/makeDicomDir.cxx now properly traps empty lists and returns
870 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
871 SegFaulting (I drowned in DicomDir related code when trying to
872 understand why the list is empty...).
873 * src/gdcmDocument.h: first BSD license header try.
874 * Doc/License.txt added.
876 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
877 * src/gdcmDocument.[h|cxx]:
878 - Clean up of the Transfer related predicates. They are now all based
879 on new method isGivenTransferSyntax, that (should) handle properly
881 - general clean up, simplification, and coding style.
882 - Specific clean up of Parse7FE0() (umproperly named actually).
883 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
885 2004-06-14 Jean-Pierre Roux
887 - fix the display of Sequence Delimitor (SQDepthLevel pb)
888 - fix the display of SQItem ordinal number
889 - add the GetSQItemByOrdinalNumber method
890 - remove some useless never written private methods
892 2004-06-14 Jean-Pierre Roux
894 - adding a constructor taking a gdcmDocEntry as an input param
895 - ReplaceOrCreateByNumber now returns :
896 a gdcmBinEntry * if a Binary (void *) value is passed as a param
897 a gdcmValEntry * if a string value is passed as a param
899 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
900 according to the param type (no longer sets a gdcmDocEntry)
901 - GetValEntryByNumber, GetBinEntryByNumber added
902 - NewValEntryByNumber and NewBinEntryByNumber added
904 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
906 - GetSQItemNumber and SetSQItemNumber added, to provide
907 a (relative) Item identier inside a given Sequence
908 \warning : some pb remaining around this number
910 - AddEntry now takes the Item Number as a param
912 - adding a constructor taking a gdcmDocEntry as an input param
914 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
915 * Memory leak hunt with the following command:
916 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
917 --show-reachable=yes gdcmTests PrintDocument
918 It looks like many (all?) leaks are due to the STL (or a bad usage
919 of the STL. The lines producing the leaks now have a comment with
920 a "MEMORY LEAK" tag: you can retrieve them with
921 grep "MEMORY LEAK" src/*
922 Here are two typical examples which I can't help fixing:
927 char * test = "babo";
928 name = test; //// <--- valgrind detects 960 bytes lost in
929 //// call to std::string::operator=(char const*)
930 name.clear(); //// Doesn't help !
938 std::cout << "Type a bunch of characters followed by RETURN: ";
939 getline(std::cin, line); //// <--- valgrind dectects a loss
940 //// of 1320 bytes in call to
941 /// std::basic_istream<>& std::getline<>
947 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
948 * src/gdcmHeader.[cxx|h]:
949 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
950 and related, moved away to gdcmDocument.
951 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
952 the corresponding protected accessors of inherited class
953 gdcmDocument, removed ! As a consequence gdcmFile had to be
954 declared friend of class gdcmDocument (see below).
955 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
956 - Clean up of undefined or unused methods.
957 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
958 account the changes to gdcmHeader.h).
959 * src/gdcmDocument.h:
960 - gdcmFile is now a friend class (in order to take into account the
961 changes to gdcmHeader.h).
962 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
963 (see changes to gdcmHeader.h).
964 - Accessors (reading on the form GetEntry*) are now public.
965 - Clean up of undefined or unused methods.
966 * src/gdcmDocument.cxx:
967 - adaptation to changes to gdcmDocument.h
968 - ::OpenFile now writes a verbose message when file cannot be opened.
969 - some std::string properly set to VRKey
970 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
971 references to gdcmDocument.
972 * Test/TestFindTags.cxx: changed accordingly to above changes.
973 * gdcmPython/testSuite.py: adapted to renaming of acr files in
974 cvs repository gdcmData.
976 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
978 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
979 conflicts with gdcmValEntry::voidArea.
980 * src/gdcmValEntry.cxx: unmatching comment wiped out.
981 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
982 Value representation between StringRepresentable and BinaryRepresentable.
983 * src/gdcmDocument.cxx:
984 - method ParseDES: proper indentation restored and usage of
985 gdcmVR::IsVROfGdcmStringRepresentable wired in.
986 - method LoadDocEntry: the fingerprint left in the SetValue() of
987 unloaded entries (length > MaxSizeLoadEntry) had curiously been
988 removed. Reverting to previous code segment with the proper
989 dynamic_cast< gdcmValEntry* >.
990 Note: this was (partially) breaking the python test suite
991 (gdcmPython/testSuite.py) that made usage of the above
992 fingerprint to check presence of "Pixel Data".
993 * src/gdcmDocEntry.h: coding style.
994 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
995 now taken into account.
996 * gdcmPython/gdcm.i: adaptation to the new internal representation
997 of gdcm (exit gdcmParser, hello gdcmDocument).
998 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1000 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1001 anymore, but instead prints the loaded Python dictionary.
1002 * .... alas, the python testSuite is still broken.
1004 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1005 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1007 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1008 * src/gdcmUtil.h : export methods
1010 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1011 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1013 * Initial addition of automatic python testing
1014 * Initial addition of automatic image comparison
1016 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1017 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1018 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1020 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1021 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1022 * Test/ShowDicom.cxx : bug fix for msvc compilation
1023 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1025 2004-05-04 Jean-Pierre Roux
1026 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1027 new concepts (and new classes) :
1028 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1029 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1030 - Sequence Doc Entries (gdcmSeqEntries)
1031 a Sequence is composed of Items.
1032 Each item is a set of Doc Entries (this is recursive)
1033 The non uniqueness of the 'Dicom tag' is due to this recursivity
1034 (never taken into account)
1035 Our unability to add a new 'entry' in the header
1036 at the proper location (neither in the H-Table (map or multimap),
1037 nor in the Chained List is also due to this recursivity.
1038 Don't try, right now, to use/modify/compile these new sources :
1039 nothing is finished.
1040 We just commit all the stuff, 'as is', in order not to loose it.
1042 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1043 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1045 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1046 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1047 file prefix (SetFilePrefix)
1049 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1050 * Add a new test: ShowDicom, for now this is just the c++ version of
1051 checkRead.sh, later it will be able to compare the image read against a
1053 * Replace the DEBUG on the stack with a global entry in cmake interface:
1054 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1056 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1057 * Add an example subdir, with a real example on how to read + write a
1060 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1061 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1062 * Doc/CMakeLists.txt: the main page is now properly differentiated
1063 between the developper and user version.
1064 * Doc/doxygen.config.in: dropped search related obsolete flags
1065 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1067 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * DEVELOPPER: added some helpfull comments for compile/test/install
1071 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1072 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1073 src directory, now generated in the build dir.
1074 2. Tests as mentionned smarter
1076 4. Add a new method in gdcmDict that return the PubDict by name
1077 this is interesting for 3rd party lib like ITK,
1078 where we could set the institution name / patient name...
1080 * ENH: 1. Now the test suite is working for real
1081 2. All binaries are now output in the gdcm-bin directory
1082 (this was not true before)
1084 2004-04-28 Jean-Pierre Roux
1085 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1086 SeQuence indented printing of Dicom Header.
1087 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1088 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1089 Computation of SQDepthLevel is now part of gdcmHeader constructor
1090 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1091 tree-like structure of a Dicom Header.
1092 * FIX Test code cleaning
1094 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1095 * ENH: Adding automatic testing
1096 1. Need a DartConfig.cmake to submit to public
1097 2. Add a test driver gdcmTest.cxx
1098 3. gdcmTestMain, an helper for the main test driver gdcmTest
1099 4. Files in Test don't have a main anymore, this becomes interesting
1100 when we add more and more tests, thus dsw don't have to load
1102 * ENH: Adding a GDCM_DATA_ROOT for testing
1103 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1104 one file instead of seven + some small cleanup
1106 2004-04-22 Jean-Pierre Roux
1107 * ENH Minor changes to the Print() methods.
1108 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1109 Header printing. Example given with :
1110 > PrintHeader fileName 2 new
1111 (SQ based tree-like structure still to be done for the Header ...)
1113 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1114 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1115 1. I have added some unsigned where needed
1116 2. Some function parameter not used -> (void)
1117 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1118 4. g++ don't like character '\' in comment
1119 5. #define jpeg_create_decompress jCreaDecompress
1120 this really need to be fixed
1121 6. virtualize destructor of gdcmObject ... leakage
1122 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1123 this also really need to be fixed
1124 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1125 remove compression file
1126 (as we only do decompression, right ?)
1127 * ENH: Change malloc/calloc/free with c++ equivalent
1129 2004-04-21 Jean-Pierre Roux
1130 * FIX gdcmHeaderHelper::GetXSpacing
1131 when a single value is found (bug ?), xpacing is now
1132 defaulted to yspacing
1134 2004-04-19 Jean-Pierre Roux
1135 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1136 * ENH add parameters :
1137 bool exception_on_error = false,
1138 bool enable_sequences = false,
1139 bool ignore_shadow = false
1140 to the gdcmFile constructors to be full gdcmParser compliant
1141 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1142 to allow reading of PAPYRUS 3.0 files
1144 2004-04-06 Jean-Pierre Roux
1145 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1147 2004-04-02 Jean-Pierre Roux
1148 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1149 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1150 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1152 2004-03-30 Jean-Pierre Roux
1153 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1154 for ACR file, written out as DICOM files (hope so...)
1156 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1158 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1159 moved to base class gdcmParser and only the specialisation is kept
1161 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1162 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1163 already does the job.
1164 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1165 (to be consistent with gdcmParser::WriteEntries).
1167 2004-03-30 Benoit Regrain
1168 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1169 upate of the object's instance. It's passed to 2 in the unfavorable
1170 case : one in the ExecuteInformation, one in the ExecuteData
1172 2004-03-29 Jean-Pierre Roux
1173 * ENH : Check on file type to be written moved
1174 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1175 * FIX : gdcmObject::ResetBoundaries now stops properly
1176 when end-of-list is reached
1177 : gdcmVersion modified (as Benoit Regrain asked)
1179 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1180 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1181 * src/gdcmUtil.cxx: added forgotten iostream include.
1182 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1183 equivalent to ExplicitVR in existing code).
1185 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1186 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1187 now contains all the gdcmGlobal related code.
1188 * minor coding style and doxygenation changes.
1190 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1192 now contains all the Debug related code.
1193 * minor clean-up of includes in src/*.cxx
1194 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1195 CreateCleanString) removed.
1196 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1197 * Doc/DoxyMainPageUser.txt added.
1198 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1199 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1200 src/gdcmDirList.cxx)
1202 2004-03-24 Jean-Pierre Roux
1203 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1205 2004-03-23 Jean-Pierre Roux
1206 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1207 big endian made volumes
1208 * ENH Now gdcmParser constructor and destructor are protected to forbid
1209 end user to instanciate class gdcmParser
1210 (only gdcmHeader and gdcmDicomDir are meaningfull)
1212 2004-03-22 Benoit Regrain
1213 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1214 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1215 gdcmSerie to gdcmDicomDirSerie
1217 2004-03-19 Jean-Pierre Roux
1218 * ENH Now the tree-like structure describing a DICOMDIR comming from
1219 an already existing DICOMDIR file is consistent with
1220 the home-made tree-like structure build ex-nihilo
1221 or build from the files held (recursively) in a Directory
1222 functions gdcmDicomDir::CheckBoundaries()
1223 gdcmObject::SetBoundaries() added
1225 2004-03-17 Jean-Pierre Roux
1226 * REM (Eric Boix bug) : removal of meaningless
1227 gdcmDicomDirImage::NewImage function.
1228 * FIX now file names and directory name are written properly in the
1230 * FIX now gdcmDicomDir constructor may be call without any trick
1233 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1235 of gdcmDicomDirImage::NewImage as empty function.
1237 2004-02-28 Jean-Pierre Roux
1238 * ENH add gdcmDicomDir:NewPatient
1239 add gdcmDicomDirPatient:NewStudy
1240 add gdcmDicomDirStudy:NewSerie
1241 add gdcmDicomDirSerie:NewImage
1242 to allow making gdcDicomDir object.
1243 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1244 (as opposite to the gdcmHeader chained list)
1246 2004-02-11 Benoit Regrain
1247 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1248 when using from python
1250 2004-02-10 Benoit Regrain
1251 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1252 * FIX : in gdcmDicomDir when the directory is empty
1253 * ENH : add callback and methods to get the progression of dicomDir
1256 2004-02-06 Jean-Pierre Roux
1257 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1258 - GDCM_META added to gdcmDicomDirType
1259 - class gdcmMeta created
1260 * ENH : - A brief summary is now displayed at the beginning of
1261 'testDicomDir' to help disaster magnitude estimation
1262 * REM : Now useless Test/explDICOMDIR.cxx
1264 2004-02-05 Benoit Regrain
1265 * ENH : add methods in gdcmObject to get the hash table or the list of
1267 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1268 * FIX : wrapping python for TagHeaderEntryHT
1270 2004-02-04 Benoit Regrain
1271 * FIX : even length for some strings when writting the dicom dir
1272 * FIX : sort the images in the dicom dir
1273 * FIX : Bug fix for python use of dicom dir
1274 * ADD : a python demo
1276 2004-02-04 Jean-Pierre Roux
1277 * FIX : Final solution (?) for icone embedded images
1278 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1279 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1280 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1281 gdcmData/gdcm-MR-SIEMENS-16.acr1
1282 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1283 to make full checking easier
1285 2004-02-04 Benoit Regrain
1286 * FIX : WriteEntries : coding style & logic in parameters
1287 * FIX : Set the elements to create the DicomDir in a dictionary file
1289 2004-02-03 Benoit Regrain
1290 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1291 * gdcmDicomDir : add the load of directory
1292 * Bug fix and print add-on
1294 2004-02-03 Jean-Pierre Roux
1295 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1296 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1297 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1298 * FIX gdcmParser.cxx : 'group length' elements are now considered
1299 as integers, even for shadow groups, when file is Implicit VR
1301 2004-02-02 Jean-Pierre Roux
1302 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1304 of the last synonym :-(
1305 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1307 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1308 * FIX taking into account the possible 7fe0,0010 multiplicity
1309 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1310 to allow removal of references to 7fe0,0010, to deal with
1311 ACR-NEMA images, when 0028,0200 is meaningfull
1313 2004-01-31 Jean-Pierre Roux
1314 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1315 no longer writes 'Un' on disk
1316 * FIX SQ elements with actual length are now dealt with corectly
1317 * FIX gdcmFile::WriteBase make the difference, for color images, between
1318 the length (for Palette expanded images)
1319 and Raw Length (non expanded image + Palette)
1320 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1321 (that broke Write). Replaced by UL.
1322 Aware user will reload the field if he
1323 thinks it's necesssary
1325 2004-01-30 Jean-Pierre Roux
1326 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1327 when 'dirty Acr' is found, to be compliant with the new
1328 IsReadable() methods.
1330 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1331 (no DOUBLE images in kosher DICOM,
1332 but so usefull for people that miss them ;-)
1334 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1335 DICOMDIR related utilities (not checked as Windoze compliant)
1337 2004-01-28 Jean-Pierre Roux
1338 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1340 2004-01-27 Jean-Pierre Roux
1341 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1342 to allow skipping the shadow elements, to save memory space.
1343 The TRUE value for this param has to be used
1344 with a FALSE value for the 'enable_sequence' param.
1345 ('public elements' may be embedded in 'shadow Sequences')
1346 * gdcmHeader methods now deal with 'embedded icones images' in the header
1347 (even when an 'icone image sequence' is announced by the
1348 element (0x0088,0x0200), but there is NO icone at all ...
1350 * gdcmHeader sometimes Image Location value doesn't follow
1351 the supposed processor endianity (see gdcmData/cr172241.dcm).
1354 * gdcmHeader add the method
1355 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1356 to get *all* the Header Entries with the same tag.
1357 GetHeaderEntrySameName is probabely *useless*
1358 (no meaning : Name is *not* an identifier within the Dictionnary)
1360 2004-01-26 Benoit Regrain
1361 * Bug fix in the print of hexadecimal representations. Remove long fields
1362 in the print and add a third level of print to print them
1364 2004-01-23 Benoit Regrain
1365 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1366 * Bug fix on test suite after remove the strip made on not string fields
1367 * Split the IsReadable method between gdcmParser which test that the file
1368 is dicom and gdcmHeader which test that it's an image file
1370 2004-01-22 Benoit Regrain
1371 * DicomDir : clean code, add methods, set variables in protected or private
1372 * gdcmUtil : bug fix for the clean string method
1374 2004-01-19 Benoit Regrain
1375 * Add the use of shadow dictionaries
1376 * bug fix and coding style
1378 2004-01-19 Benoit Regrain
1379 * src/gdcmFile.cxx : bug fix concerning the close of file
1380 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1381 * Add the update of header entries using the shadow library
1383 2004-01-19 Benoit Regrain
1384 * removal of file gdcmHeader2.cxx
1385 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1386 inheriting from gdcmParser. This split is to prepare the integration
1387 of dicom dir parsing
1388 * bug fix under python
1390 2004-01-16 Jean-Pierre Roux
1391 * REM removal of class gdcmHeaderEntrySet
1392 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1393 * ADD add file gdcmHeader2.cxx
1394 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1396 2004-01-15 Benoit Regrain
1397 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1398 entries created while parsing the header. Thus, they will be destroyed
1399 when the gdcmDictSet will be destroyed
1400 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1403 2004-01-15 Benoit Regrain
1404 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1405 made a fatal error because of the memory release at the end of program.
1406 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1407 some memory and vtk seems to have some problems with that.
1408 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1410 2004-01-14 Benoit Regrain
1411 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1412 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1413 * src/*.[h|cxx] : make changes due to class name changes
1414 * gdcmPython/demo/*.py : bug fix due to method names
1416 2004-01-13 Benoit Regrain
1417 * src/*.[h|cxx] : coding style
1418 * vtk/*.[h|cxx] : coding style
1420 2004-01-13 Benoit Regrain
1421 * gdcmPython/testSuite.py : test the readable flag of file for tests
1422 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1423 It's lied to the stl compilation by MSVC (windows, always windows...)
1424 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1426 2004-01-12 Benoit Regrain
1427 * src/*.h : add comments
1428 * src/gdcmDictSet.h : set the method BuildDictPath in public
1429 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1430 directly setted in the source code
1431 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1434 2004-01-09 Benoit Regrain
1435 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1436 * setup.py : use a reference to gdcmVERSION
1438 2004-01-07 Benoit Regrain
1439 * Modification to compile with the distutils.
1442 2003-12-10 Benoit Regrain
1443 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1444 can use a gdcmHeaderHelper to load datas
1445 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1446 made in the source code
1448 2003-12-10 Benoit Regrain
1449 * Update Windows projects and .cvsignore files
1451 2003-11-12 Jean-Pierre Roux
1452 * ENH gdcmHeader constructor has one more parameter (default value : false)
1453 that allows the user to 'go inside' the SeQuences only
1455 gdcmElValSet:Print takes it into account
1457 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * ENH: Update gdcmPython/CMakeLists
1459 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1460 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1462 2003-11-10 Jean-Pierre Roux
1463 * FIX : gdcmHeader::LoadElements is now based
1464 on the ListTag listElem member,
1465 not longer on the TagElValueHT tagHt member
1466 * ENH : PrintPubElVal shows (temporarily) both results,
1467 with the tagHt member and the listElem member.
1468 (it's easier to 'see' the problems when using Printheader)
1470 * FIX : old private member LgrElem is now splitted into
1471 ReadLength : Length actually found on disk (updated only
1472 if bug fixing is necessary), for internal
1474 UsableLength : Updated by FixFoundLength, to fix a bug
1475 or to allow Parser going on.
1476 Will allow to re-write a kosher header when a SeQuence
1477 with a length (not 0000) is found
1478 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1479 because gdcmElValSet::Add does not update ListElem
1482 2003-11-07 Jean-Pierre Roux
1483 * FIX misstyping in Transfert Syntax name table
1484 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1485 when they have an actual length (not 0000 nor FFFFF)
1486 (Nobody should care of it, but DICOMDIR explorers)
1488 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1489 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1491 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1492 * ENH: vtkGdcmReader now supports LUT !
1493 (vtkgdcmViewer for now is not able to use them though)
1495 2003-11-05 Jean-Pierre Roux
1496 * in testSuite.py : new files names for checking the package
1497 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1498 that returns the pixel area size to the *aware* (vtk) user
1499 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1501 2003-11-05 Benoit Regrain
1502 * in testSuite.py : Modify the rules for checking the paths
1503 : Explicit error messages
1504 * in __init__.py : Related modif
1506 2003-11-03 Jean-Pierre Roux
1507 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1508 to be used by aware (vtk) users that want to manage
1509 LUT (and no to turn the PALETTE image into an RGB pixels one)
1510 * GetPixelType now returns 8U for 24 Bits images
1511 (vtkGdcmReader compliant)
1513 2003-10-31 Jean-Pierre Roux
1514 * Removal of *all* gdcmData images and add them again
1515 in order to loose the 'history' of un-anonymised images
1517 2003-10-31 Jean-Pierre Roux
1518 * RMV : removal of useless jBitsInJsample.h
1519 for both 8 and 12 Bits JPEG Lossy Libraries
1521 2003-10-31 Jean-Pierre Roux
1522 * ENH : Add the functions gdcmFile::GetImageDataRaw
1523 gdcmFile::GetImageDataIntoVectorRaw
1524 that act as GetImageData and GetImageDataIntoVector
1525 except the making of an RGB Plane from Gray Plane + LUT
1526 Intended to aware (vtk) users who know how to manage
1529 GetLUTRGBA return a R,G,B,A LUT if any
1530 lgrTotaleRaw gives the 'Raw' length
1531 GetImageDataRaw returns the gray Plane
1532 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1533 (They stay Grey, just like with other Dicom viewers :-(
1535 2003-10-30 Jean-Pierre Roux
1536 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1538 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1539 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1540 being coherents dicom files.
1542 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1545 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1546 * ENH: Two steps is necessary to please VC++ compiler...
1547 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1548 * ENH: Add include dir to medcon lib
1549 * FIX: only one function is being exported for now !
1550 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1552 2003-10-29 Jean-Pierre Roux
1553 * adding gdcmHeader::GetLUTRGBA
1554 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1555 --> Mathieu, the modif u're waiting for is not yet committed
1556 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1558 2003-10-27 Jean-Pierre Roux
1559 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1560 00191113.dcm DermaColorLossLess.dcm
1561 MxTwinLossLess.dcm RadBWLossLess.dcm
1562 * ENH: For version prior to vtkImageViewer2 -r 1.19
1563 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1565 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1566 * Removal of ido stuff in CMakeLists.txt
1568 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1569 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1570 * FIX: remove a call to ->Modified ... see comments
1571 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1573 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1574 * FIX: Problem with path for libvtkgdcmPython
1575 * ENH: Try adding a search script for python site-package
1576 * RMV: Remove some file from medcon lib that are not necessary
1577 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1578 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1579 * FIX: More pragma disable fro VC++,
1580 I don't think I break something as it is also disable in VTK/ITK.
1581 But it fasten debug compilation time.
1583 2003-10-23 Jean-Pierre Roux
1584 * gdcm now deals with 16 Bits Run Length Encoded images
1585 (they are compressed as 2 planes images,
1586 one for the high Bytes, the other for low Bytes)
1588 2003-10-22 Jean-Pierre Roux
1589 * Now CheckRead takes into account :
1590 - the bugged 'Leonardo' Siemens images
1591 - the XA images, sent thru the burning VPRO station
1592 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1595 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1596 * FIX: When copying a Makefile.am to CMakeLists.txt
1597 one should remove the '\'
1599 2003-10-22 Jean-Pierre Roux
1600 * in gdcmData adding a bugged 'Leonardo' Siemens image
1601 (wrong lengths in header)
1602 OK with gdcm, KO with the other viewers :-)
1603 * add a GE dlx XA image, thru the VEPRO burning station
1606 2003-10-21 Jean-Pierre Roux
1607 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1608 for a brutal checking of vtkgdcmViewer compliance
1610 2003-10-21 Jean-Pierre Roux
1611 * add the files for 'xmedcon' Jpeg Lossless library
1612 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1614 2003-10-21 Jean-Pierre Roux
1615 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1617 2003-10-21 Jean-Pierre Roux
1618 * garbage Siemens 'Leonardo' images dealt with
1619 (the patch is easy to remove)
1620 * cosmetic changes to avoid warnings
1622 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1623 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1624 no need to press 'r' now.
1626 2003-10-20 Jean-Pierre Roux
1627 * upgrade of checkRead.sh checkWrite.sh according
1628 to new Jpeg Lossless decompressor
1629 * add US.3405.1.dcm, a genuine RGB medical file ...
1630 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1631 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1633 2003-10-15 Jean-Pierre Roux
1634 * general anonymisation in gdcmData
1635 * adding the 'color files' from
1636 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1637 * adding some well knowed bugged-header images
1638 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1639 waiting for their inclusion in Python testsuite
1641 2003-10-15 Jean-Pierre Roux
1642 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1643 no longer seg faults when file is not found
1645 2003-10-14 Jean-Pierre Roux
1646 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1649 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1650 * TODO: *.in file to genereate a UseGDCM later
1652 2003-10-14 Jean-Pierre Roux
1653 * Some supposed-to-be Dicom Images have no preamble.
1654 OpenFile takes it into account
1655 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1656 * Missing elements added in dicomV3.dic
1657 (just to be affraid : have a look at
1658 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1659 and do it again next year ;->
1661 2003-10-13 Jean-Pierre Roux
1662 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1663 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1664 But there are NOT. It's fixed !
1666 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1667 * FIX: "jpeglib.h" was not found on VC++
1668 * FIX: vtkgdcm was not being installed
1670 2003-10-10 Jean-Pierre Roux
1671 * ENH : OpenFile closes the file if it *really* doesn't look like
1672 an ACR-NEMA / DICOM one.
1673 * FIX : testWrite no longer writes an empty file if the source file
1674 is not gdcm Readable
1675 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1678 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * FIX: CMake generate now documentation
1680 * ENH: out of source doc build !
1681 * ENH: Generate both user and dev documentation
1682 * ENH: Should work on windows too
1683 * ENH: Only one doxygen config.in file is needed
1684 * FIX: make install should be ok now on ùnix plateform
1685 * FIX: PATH to dictionary was wrong (missing /)
1686 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1688 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * vtkGdcmReader is now able to read rgb dicom file.
1690 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1691 * added a gdcmViewer to vtk test, use mouse to control
1692 window level & window width
1694 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1695 * CMake-ification of gdcm, we have now two build system
1696 * FIX: on cygwin Wsock32 doesn't exist
1697 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1699 2003-10-06 Emanuel Ollart
1700 * FIX : compilation process wad broken.
1701 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1703 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1704 * change gdcmViewer -> vtkgdcmViewer
1705 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1707 2003-10-06 Jean-Pierre Roux
1708 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1709 ( e.g : well known GE images with a wrong elem length,
1710 : Philips MRI Images with a wrong Huffman table)
1711 * still to be done : allow the reading of bugged LEONARDO Siemens images
1713 2003-10-03 Jean-Pierre Roux
1714 * Odd length strings are padded with '\0' (not with spaces,
1715 to remain compliant with already defined strings,
1716 like Transfert Syntax UID and others)
1718 2003-10-03 Jean-Pierre Roux
1719 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1720 to allow displaying RGB images (not only by affim ;-)
1722 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1723 * vtkGdcmReader is now able to read rgb dicom file.
1724 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1726 2003-10-03 Jean-Pierre Roux
1727 * A few nasty patches to allow the reading of a lot of nasty images
1728 ( e.g : well known GE images with a wrong elem length,
1729 : Philips MRI Images with a wrong Huffman table)
1730 * still to be done : allow the reading of bugged LEONARDO Siemens images
1732 2003-10-03 Jean-Pierre Roux
1733 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1735 2003-10-03 Jean-Pierre Roux
1736 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1737 to allow displaying RGB images (not only by affim ;-)
1739 2003-10-03 Jean-Pierre Roux
1740 * gdcmFile::GetImageDataIntoVector now
1741 - deals with MultiFrames MultiFragments Run Length Encoded files
1742 - deals with YcBcR (YBR_FULL) files
1743 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1744 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1746 (no sample found :-(
1748 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1749 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1750 Two reasons: - clear things
1751 - third parties acces gdcm through header files, so won't
1752 suffer anymore VC++ complains
1754 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1755 * add argv[1] in testvtkGdcmReader.cxx
1758 2003-09-24 Jean-Pierre Roux
1759 * The lines are now eigthy characters long.for
1760 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1762 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1763 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1764 char* to std::string. Thus, the use of strdup becomes useless. (see
1765 previous commis of Malaterre)
1766 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1767 before the last Malaterre's commit.
1769 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * This commit should fix the Debug building under VC++, the problem
1771 was mainly a mixture of debug and release lib being loaded at startup.
1772 * I also remove a depency to a specific C function: strdup. Because I had
1773 to force the link to msvcrtd (whereas strdup is in libc).
1775 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1776 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1777 located in the gdcmCommon.h file. All use of reference of tha has been
1778 changed to now use the variable GDCM_UNFOUND.
1780 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1782 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1783 Dicom dictionary. The test suite can now be run again. Note:
1784 I'm note very happy with the " (RET)" changes. I believe this
1785 RETAINED comment should be dropped when parsing the dictionary.
1786 - PACKAGER corrected
1788 - AUTHORS updated and now in alphabetical order
1789 * Makefile.am now exports gdcm.dsw for Windoze users.
1791 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1792 * cygwin complains about missing std:: in subdir Test/
1794 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * remove some methods that are now in gdcmHeaderHelper
1797 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1798 * vtkGdcmReader set spacing and origin correctly
1800 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1801 * Fix a few delete/delete[] mismatch
1803 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1805 interpretation to data given by gdcmHeader. For instance there are
1806 heuristics to get informations (look at different places).
1807 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1808 sorting DICOM images based on different strategies.
1809 * modified Makefiles accordingly.
1811 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1812 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1813 when building in debug mode
1814 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1815 src/win32/gdcmdll.dsp
1816 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1818 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1822 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1823 * src/win32/libgdcmjpeg12.dsp was not dos format
1824 * src/win32/libgdcmjpeg12.dsp :
1825 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1826 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1828 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1829 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1831 * src/gdcmFile.cxx : bug fix in affectation type
1832 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1833 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1834 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1835 symbols... future problem ?
1837 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1838 * src/win32/libgdcmijpeg12.dsp was missing
1839 * modified gdcm.dsw accordingly
1841 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1842 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1844 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1845 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1846 commit of JPR (before his hollidays to facilitate our work).
1847 * setup.py : bug fix in code. Modifications made while the last commit
1848 of JPR. The code hasn't been tested before the commit... it's so
1849 useless to make that (for best programmer that is JPR) !!!
1851 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1852 * tagged the current version as Version0_3 (i.e. version 0.3)
1854 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1855 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1856 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1857 * *.dsp : modifications to use new libgdcmijpeg8 library
1858 * setup.py : bug fix on VTKPATH variable
1859 * PACKAGER : adding all concerning windows
1861 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1864 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1865 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1866 test suite reported error.
1867 * PACKAGER file added (describes what a packager must do when
1868 packaging a new release).
1869 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1870 * configure.in: upgraded version number to 0.3.0
1871 * fixing build of rpm (through rpm -ta):
1872 - Doc/Makefile.am exports proper doxygen files
1873 - src/jpeg/libijg8/Makefile.am exports the include files.
1875 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1876 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1877 * src/gdcmHeader.h : formatting code
1879 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1880 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1881 We were obtaining error message from vtk. Now, creation of file list
1882 is made in an internal list to prevent this problem.
1883 Bug fix when output is empty.
1884 Bug fix in update of progress value. Previous commit for this was a bad
1886 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1888 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1889 * src/gdcmHeader.h : added method to get the file name
1890 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1891 files. Added method to remove all files on the input
1892 Added FIXME comment concerning the bad parsing of header made by
1893 ExecuteInformation method (in ExecuteData method)
1895 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1896 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1897 when using make instal.
1898 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1899 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1901 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1902 * setup.py : adding include dir of jpeg lib to compile all sources
1903 * */Win32/*.dsp : JPR fix for windows compilation
1905 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1906 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1908 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1909 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1911 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1912 * setup.py is again effective on un*x (takes into account the
1913 addon of the jpeg library)
1914 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1915 * Doc/Doxy* updated (includes above enhancements)
1916 * INSTALL now points to web documentation
1918 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1919 * src/gdcmHeader.h doesn't make unnecessary reference to
1921 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1923 * src/gdcm*.[cxx|h] :
1924 - to allow compilation with gcc 3.x
1925 -- clean up of STL usage (added explicit usage of std::)
1926 -- small fixes on exceptions.
1927 Note: linking not tested !
1928 - clean of doxygen comments to avoid warnings at documentation
1930 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1931 dependent convertion).
1933 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1934 * Clean up of previous JPR garbage commit (not even commented in the
1936 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1937 - moved all jpeg related files from src to src/jpeg/libijg8, with
1938 addition/modification of Makefile.am and configure.in.
1939 - the testSuite is still brain damage (not guilty).
1941 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1942 * WrapVTK.py : modifications to get correctly vtk source files to
1944 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1945 (FileName -> Filename)
1947 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1948 * vtk/vtkGdcmReader.[cxx/h]:
1949 - UpdateProgress method should now be effective
1950 - removed the limitation on having only images loaded (as opposed
1952 - when building a stack of images/volume, a lesser number of
1953 gdcmHeader and gdcmFile instances should be used (hopefully
1954 accelerating things).
1955 - when building a stack of images/volumes, files which are not
1956 loadable (wrong path-filename, wrong permissions on existing file,
1957 or file not parsable by gdcm) are replaced with a black image
1958 in the stack (for the caller to notice the problem).
1960 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1961 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1963 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1964 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1965 between standard library (std) and vtk library (problems are found
1966 under Windows... thanks Windows !)
1968 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1969 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1971 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1973 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1974 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1976 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1977 * When compiling with distutils (see setup.py) the C++ compiler is
1978 called with different flags than the default ones (with automake).
1979 In order to fix all those warning, I compiled gdcm with the command
1980 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1981 and went for warning fixes:
1982 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1983 up from unused variables.
1984 - vtk/vtkGdcmReader.cxx: potential bug fix.
1985 * src/gdcmHeader.h: Doxygen warning cleanup
1987 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * gdcmPython/gdcm.i:
1989 - typemaps correction to take into account the systematic replacement
1990 of "using namespace std" with std:: prefix e.g. std::list,
1991 std::string... (cf changes of 2003-05-21).
1992 - gdcmGlob global variable of type gdcmGlobal (defined in
1993 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1994 exported to Python a as cvar.
1995 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1996 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1997 gdcmDictSet.GetPubDictTagNames() and
1998 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1999 C++ static methods).
2000 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2001 with the above changes.
2003 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2004 * setup.py, manifest.in : bug fix under linux
2006 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2007 * Modification of setup.py to compile vtk part too. Then, we have 2
2008 wrappers which must work with same distutils. For that, we have a
2009 generic distutils in distusiltsWrapping.py ; with :
2010 - build_extWrap class to wrap generically all extensions,
2011 - ExtensionWrap base class for all wrapping extension that contains
2013 - Wrapper interface which wrap sources
2014 + In WrapSwig.py we have extension and wrapper for Swig
2015 + In WrapVTK.py we have extension and wrapper for VTK
2016 * MANIFEST.in : modifications to consider vtk directory and new python
2017 files for compilation
2019 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2020 * Added python wrappers of vtkGdcmReader vtk class (see the
2021 source in vtk/vtkGdcmReader.cxx) :
2022 - vtk/Makefile.am now builds a library
2023 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2024 python library (as opposed to _gdcm.so wich are the python
2025 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2026 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2028 - configure.in has an additional flag --enable-vtk that needs
2029 to be set to enable compilation of vtk related code, that is:
2030 + vtk/vtkGdcmReader.so and
2031 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2032 + gdcmPython/vtkgdcmPython.so (see above)
2033 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2034 be read when compressed or when HighBit + 1 != BitsStored),
2035 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2036 the usage of the python wrapper of vtkGdcmReader vtk class.
2037 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2038 * src/*.[h] all occurences of stl classes are now prefixed with
2039 std::, and all occurences of "using namespace std;" where removed.
2040 This is to avoid pollution of global namespace in included files.
2041 Apparently vtk does not avoid this pitfall: when using both
2042 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2043 collision of various stl members (principally cout...).
2044 * gdcmPython/testSuite.py now cleanly removes temprory generated
2046 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2047 comply with above changes)
2049 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2050 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2051 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2052 vtk data structure (an image Flip was required).
2053 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2054 * cosmetic changes in documentation.
2056 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2057 * src/gdcmHeader.cxx: the constructor no longer exits when an
2058 unexisting file is given as argument.
2059 * The subdirectory Data (containing all the images used for the
2060 test suite) is not part of this repository anymore. A new module
2061 containing those images is now available at
2062 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2063 with the name gdcmData.
2064 All the python scripts (including the package initialisation file
2065 gdcmPython/__init__.py) were adapated to take this change into
2066 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2068 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2069 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2070 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2071 demo of the usage of this class.
2072 Compilation of this vtk part is only done when using the --enable-vtk
2073 at configure (or autogen.sh) stage.
2075 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2076 * More memory link related corrections and documentation fixes.
2078 - maximum info is obtained with a command of the form:
2079 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2080 --show-reachable=yes PrintHeader
2081 - the remaining reachable blocks seem to come from the STL
2082 allocation scheme through the usage of map and list. It looks
2083 like this memory cannot be freed but it is not a memory leak
2084 (in fact further invocation to the STL would recollect the
2085 unused memory allthough it cannot explicitely be freed).
2086 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2087 of displaying an image parsed with gdcm and displayed with VTK.
2088 Note: some images don't seem to work e.g.
2089 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2090 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2091 Allthough this weakens the semantics, it is a ditch attempt to
2092 make gdcm more thread friendly.
2094 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2095 * Memory link hunt (by using valgrind through the command
2096 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2097 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2098 gdcmHeader::_dicom_vr.
2099 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2100 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2102 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2104 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2105 * src/Makefile.am now exports all the necessary include files at
2109 * UpdateGroupLength replaced by new one
2112 * UpdateGroupLength re-written using H-Table
2113 (named UpdateGroupLengthNew untill checks are over)
2115 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2116 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2117 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2119 - gdcmHeader::GetPubElValSet removed.
2120 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2121 UpdateGroupLength, WriteElements, Write.
2122 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2123 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2124 carried the same semantics.
2125 - src/gdcmHeaderIdo.cxx changed accordingly.
2126 - gdcmFile::WriteBase now regroups all the codes from previous
2127 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2128 - enum FileType moved to gdcmCommon.h
2129 * src/gdcmHeader.cxx AddDefault trashed
2130 * gdcmGetXSize added
2131 * getimageDataSize now calls gdcmGetXSize
2132 * Test/*.cxx changed to agree with above changes
2134 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2136 (to avoid double call by end user).
2137 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2138 by end user, since gdcmHeader::gdcmHeader now handles it.
2140 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * gdcm/Doc many doxygen changes:
2142 - Doxyfile now has two different versions, DoxyfileUsers that generates
2143 the html.users end users oriented documentation and
2144 DoxyfileDeveloppers that generates the html.developper developper
2145 oriented documentation.
2146 - README changed accordingly
2147 - requirement.txt removed (old design info moved to TODO).
2148 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2149 DoxyMainPage.txt, DoxyPython.txt provide more information.
2150 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2151 be updated by simply regenerating the docs with doxygen and copying
2152 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2153 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2154 all the tests in the form "if (<map>.count() >1)" were removed.
2155 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2156 ill-formed documentation sections.
2157 * src/gdcmHeader.cxx: ditto
2159 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2160 * setup.py fixed for un*x (needed macro for stdint.h)
2161 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2162 un*ces with sh-utils test utility.
2163 * gdcmPython/demo/test.py renamed to PrintHeader.py
2164 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2165 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2166 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2167 * src/gdcm*.cxx JPR's bad inclusion fixed.
2169 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2170 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2171 * gdcmPython/demo/test.py changed accordingly.
2173 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * gdcmPython/Makefile.am fixed linking against libstdc++
2175 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2176 * Swig subdir (historical tests of swig version 1.3.17++) removed
2177 * Test/testChangeEntete.cxx some lines commented out in order to make
2179 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2180 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2182 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2184 hence the user doesn't need this explicit call.
2185 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2186 i.e. LoadElements() call removed.
2187 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2188 - src/Makefile.am declares the proper flag for g++.
2189 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2190 for adding user defined new tags.
2191 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2192 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2193 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2195 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2196 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2197 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2198 src/Makefile.am : the project should properly compile and install
2199 with the autotools, included the python wrappers part.
2200 * gdcm.spec.in : added a spec file for RPM packaging.
2202 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2203 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2205 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2207 to exported to the environement (see gdcmPython/testSuite.py
2209 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2210 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2211 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2212 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2213 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2215 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * gdcmPython/__init__.py doesn't crash anymore when running in
2217 in InstallMode or PreInstallMode but with an environement given
2218 value of GDCM_DICT_PATH.
2219 * src/gdcmDictSet.[cxx/h] coding style.
2221 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2223 * src/gdcm.h general comments moved to TODO, and README
2224 * src/gdcm.h should now be seen as a user commodity (including it
2225 should suffice to fully use gdcm). It is nowhere including within
2226 any of the kernel files src/*.cxx and src/*.h.
2228 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2229 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2230 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2232 * src/gdcm*.cxx only include their corresponding include file
2233 (as opposed to gdcm.h)
2234 * gdcmPython/gdcm.i changed accordingly
2235 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2236 the autogen.sh generated "make snapshot" command to work.
2237 * autogen.sh removed history related references to crea package.
2239 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * distutilsSwigCPlusPlus.py work around some swig portability
2243 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2245 was done in a last ditch attempt to get setup.py _really_
2246 operationnal. The python/gdcmPython layaout add the advantage
2247 of hidding away the python related distutils specific files
2248 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2249 Alas, the src directory was out of scope (i.e. it's relative
2250 position to setup.py was ../src) which made things impossible to
2251 handle (see previous version of python/setup.py). Crossing fingers...
2253 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * python/setup.py now works on Un*x. (harder than I thougth)
2255 * python/distutilsSwigCPlusPlus.py can now have include files
2256 among the list of sources.
2258 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2259 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2260 * modifications in MSVC projects
2262 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * As stated by the first lines of Test/ExceptionAndPython/README, it
2264 looks like we can move back to original usage of exception within
2265 src/gdcm* and hence remove the errno stuff that was introduced
2266 as a quick and dirty fixture of this problem (added to the TODO).
2267 * Doc/Doxyfile configuration file for Doxygen and corresponding
2268 README file for usage added.
2269 * Test/testWrite.cxx added. This new test comes from a split of
2270 test.cxx that is now reverted to its original purpous i.e.
2271 testing the proper parsing of a Dicom related file.
2272 testWrite.cxx concentrates on testing the IO part of gdcm.
2273 * Test/bug1.cxx (containing a bug on WIn32) added.
2274 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2275 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2276 whose purpose is to publish the content of the TagNames of the
2277 Dicom public dictionnary were not accessible without an
2278 instance of class gdcmHeader.
2279 - those methods are now static methods of gdcmDictSet and hence
2280 require no instances at all to be invocated.
2281 - within gdcmDictSet this change required to change some method
2282 to class methods (i.e. are now static) among which SetDictPath
2283 (renamed to BuildDictPath) and LoadDefaultPubDict.
2284 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2285 the above changes by calling the new method classes of gdcmDictSet.
2286 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2287 the above to be effective.
2288 * python/gdcmPython: in order to wrap properly the above changes
2289 for Python, swig version now needs to be > 1.3.17.
2290 * python/gdcmPython/Makefile fixed to adapt itself to new
2291 configure/make shema introduced by Johan Montagnat (thanks for the
2292 contribution). Alas this Makefile cannot be turned into a proper
2293 Makefile.am without some heavy changes in the configure.in
2294 (for python dectection).
2295 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2296 now avoids publishing the empty entries.
2298 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2299 * python/setup.py : bug fix concerning install under windows
2300 ExtraPath reused :-P
2301 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2303 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2304 * Dicts/dicomV3.dic : remove double spaces !!!
2305 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2306 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2309 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2310 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2311 method. Doxygenation.
2312 * src/gdcm.h clean up of JPR spurious comments.
2314 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2315 * python/distutilsSwigCPlusPlus.py now properly collects the
2316 shadow classes generated by "swig -c++" (gdcm.py in our case)
2317 when using "python setup.py install".
2318 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2319 reexports the working classes.
2320 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2321 by the classical C errno scheme. This is to prevent an obscure
2322 behavior of the python wrappers when importing wxPython.wx prior
2323 to gdcmPython (which ended up in an abort call). An illustration
2324 of this oddity can be found in the Test/ExceptionAndPython
2325 subdir (see the README file). This problem probably due to
2326 an combination of g++ and dynamic loading.
2327 * added Test/ExceptionAndPython (see above)
2329 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2330 * Changed the layout of the python part to avoid bloating main
2331 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2332 i.e. the distutils arsenal. All the python related stuff is
2333 again in a python subdir, but the package itself is now in
2335 * setup.py was cleaned up:
2336 - pythonIncludePath removed
2337 - python setup.py bdist target is now functional.
2338 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2339 collision with other packages). gdcmPython/demo/*.py changed
2342 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * python subdir moved to gdcmPython (preparation of distutils packaging).
2344 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2345 distutils installer is operational.
2346 * - gdcmPython/__init__.py now properly loads the swig generated
2347 shadow classes (from gdcm.py).
2348 - gdcmPython/demo/*.py changed to import the package gdcmPython
2349 instead of gdcmPython/demo/load.py.
2350 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2352 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2353 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2354 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2355 entries within the associated public Dicom dictionary resp. the same
2356 information but sorted by the fourth field (PAT, IMG, DIR) of the
2358 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2359 are now in the "???" group.
2360 - python/gdcm.i changed accordingly,
2361 - python/demo/printGroupedPublicDict.py added, that gives an example
2362 of the above new functionalities in Python.
2364 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * src/gdcm.h, gdcmHeader.cxx:
2366 - historic references to glib's g_malloc and g_free (#defined)
2367 were definitively removed.
2368 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2369 * src/gdcmElValSet.cxx:
2370 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2371 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2372 - GetElValue(string) renamed to GetElValueByName.
2373 - Added GetElementByName(string).
2374 * src/gdcmHeader.cxx: added
2375 - GetPubElValRepByNumber(guint16, guint16)
2376 - GetPubElValRepByName(string)
2377 - GetShaElValRepByNumber(guint16, guint16)
2378 - GetShaElValRepByName(string)
2379 - GetShaElValByNumber(guint16, guint16)
2380 - GetShaElValRepByName(string)
2381 - GetElValRepByNumber(guint16, guint16)
2382 - GetElValRepByName(string)
2383 - GetElValByNumber(guint16, guint16)
2384 - GetElValRepByName(string)
2385 * Doc/requirements.txt added.
2387 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * Test/Makefile building now depends on the one of libgdcm.so
2389 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2390 pixel data) aware which enables finding the address (offset) of
2391 the pixel data of JPEG encoded DICOM files. This leaves only a single
2392 file in the testSuite whose pixel data address (offset) is unknown.
2393 * python/testSuite.py changed accordingly.
2395 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2396 * VC++ has some strong limitations when working with the STL, as stated
2397 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2398 "Also note that some STL containers (map, set, queue, list, deque)
2399 cannot be exported. [...]
2400 Some STL classes contain nested classes. These classes can not
2402 This is caused by a designed limitation that once a template
2403 class is instantiated, it can not be re-instantiated and
2405 Since our usage of map<> is ubiquitous in gdcm, this "designed
2406 limitation" of VC++ is a pitfall.
2407 Hence the Python wrappers of gdcm cannot be incrementally linked
2408 against the c++ dynamic library. The dirty but only workaround is
2409 to forget about incremental link of dynamic libraries and to generate
2410 the Python wrappers library with the inclusions of the underlying C++
2412 The following modifications concern this matter on Win32/VC++:
2413 - wrapping python correct with standalone wrapped dll (don't use separate
2414 dll under windows !!!!)
2415 - python21_d debug mode enabled (ask Frog how to use it :-)
2416 - NO problem with having an STL member of class for example string in C++
2417 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2418 - Python test of dcmlib in Python is ok under windows on a large set
2420 * removed glib references
2421 * typedef's inserted in gdcm.i for correct swig type management
2423 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * python/demo/*.py load.py extracted from test.py. Added explore.py
2425 that only displays required tags and testAll.py that parses all
2426 the files of the testsuite without using unittest.
2427 * python/testSuite.py other additional test on new files added.
2428 * Data/* new test files added accordingly to the testSuite.
2429 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2430 the vr in the file differs from the one of the dictionary.
2432 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2434 values, but limits itself to values which are below a user specified
2435 size (by default 1024 bytes).
2436 * python/gdcm.i : elements not loaded (because their size is above the
2437 user specified treshold) are exported with their TagKey as key of the
2438 python dictionary. This enables the testsuite to make some checks
2439 on the unloaded elements (since we have their offset and size).
2440 * python/testSuite.py
2441 - now tests for the existence and proper value of the pixel data
2442 - two new examples added.
2443 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2445 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2447 aware. See the strategy comments in gdcmHeader::FindeLength().
2448 * Test/test.cxx now accepts a filename as first argument.
2449 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2450 * python/testSuite.py changed to integrate test on above files.
2452 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2453 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2454 the vr was also RET.
2455 * python/testSuite.py more tests added.
2457 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * python/testSuite.py unittest test suite added (uses Data)
2459 * Data/* dcm and acr files for the test suite.
2460 * glib dependance removed from un*x version. We now use ISO C99
2461 7.18 Integer types (see stdint.h)
2462 - python/Makefile, src/Makefile src/gdcm.h
2463 * src/ when an explicit vr (like dicom files) suddenly poped an
2464 implicit element we use to mark the underlying DictEntry of the
2465 concerned ElValue with "Implicit". This strategy was damageable
2466 too the public or provite dictionaries, since some of their vr
2467 would be changed. Since Header::FindLength heavily relies on the
2468 detection by Header::FindVR of falsely explicit elements, I
2469 added an extra ImplicitVr member to ElValue (boolean).
2470 The rest of the changes we the necessary adaptations.
2472 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2475 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2477 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * Adaptation for porting to VC++:
2480 o forced to use std namespace (for string to be known)
2481 o all class use __declspec export style on WIN32
2482 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2483 (in stdlib.h on Win32 but in std:: for gcc)
2484 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2485 variable GDCM_DICT_PATH.
2486 * src/gdcmHeader.cxx verbose comments made discrete.
2488 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * python/gdcm.i: added a typemap that converts a C++ hashing table
2490 to native Python dictionary.
2491 * python/demo/test.py:
2492 - now uses the native dictionary for exploration of gdcmHeader.
2493 - takes an optional filename argument (the file to parse).
2494 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2495 PubElVals hashing table.
2496 * Dicts/dicomV3.dic removed error prone trailing spaces.
2498 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * Python wrapping process moved away from src/Makefile to
2500 newly created python/Makefile (as well as gdcm.i)
2501 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2502 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2503 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2504 from the environement variable GDCM_DICT_PATH (when existing).
2505 * src/gdcmDict::GetTag bug fix.
2507 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * Straightforward temporary fixes for swig to build the python wrappers.
2509 src/Makefile now has a python working entry [by working we mean
2510 that we can import de shadow classes without errors].
2512 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2513 * hashtest.cxx removed (since allready in Test)
2514 * src/gdcmlib.h renamed to src/gdcm.h
2515 * src/dcm.i renamed to src/gdcm.i
2516 * src/Makefile prepared for python wrapping
2518 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2519 * src/gdcmHeader.cxx :
2520 - Parsing of header is now separated from loading of element values
2521 (see gdcmHeader::LoadElements).
2522 - general clean up of hopefully all file access (creation of
2523 ReadInt16 and ReadInt32)
2525 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2526 * src/gdcmHeader.cxx :
2527 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2529 - SetLgrElem renamed to SetLength
2530 - GetLgrElem renamed to GetLength
2531 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2532 * src/gdcmElValSet.cxx fixed both GetElValue methods
2533 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2534 due to IdoDude was cleaned out.
2536 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2538 concentrates on finding the value representation (when it exists).
2539 RecupLgr now only finds the element value length, and it avoids
2540 returning the unecessary skL (skipped length).
2541 Also, offsetCourant was simply removed (with taille_fich) since
2542 it was redundant with the File position internals (by using
2543 ftell and fseek). This also made skL (see above in RecupLgr) usage
2545 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2546 on the libido specificities which are handled through class
2548 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2551 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * Truckload of changes. Parsing of header is barely functional
2553 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2555 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * src/gdcmHeader.cxx many addons of low level methods
2558 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2559 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2560 and _IdDcmSWAP_LONG.
2562 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2563 * This corresponds to all the changes decided at the meeting of
2564 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob