1 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
4 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
6 future, with convertion)
7 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
8 and ImageDataSize values. Remove the method to get the PixelReadConverter
9 from the output of the class
11 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
12 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
14 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
16 and vtkErrorMacro use.
17 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
19 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
22 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
23 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
24 The string leaves only in the fonction. So when we make a .c_str(), we
25 get the pointeur on the first element, element that will be destroyed
26 immediately after thee instruction.
27 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
28 file has been opened : the test must be made on the content of the
29 pointer and not directly on the pointer !
32 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
34 the python part recompiles
36 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
38 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
39 X session is killed (for my computer... it seems to not be identic on
42 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
44 avoid problems (otherwise, the difference test between the visible image
45 and the reference is incorrect. If the reference is greater than the
46 screen resolution, it's produce errors).
47 Can be used for only one image. Can be used with a visible flag.
48 * vtk/vtkGdcmReader.cxx : remove commented codes.
49 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
50 under windows at compilation
51 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
53 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
55 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
57 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
58 tests on the image size X, Y, Z
60 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
61 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
62 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
63 between the class name and the file name
65 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * src/ : fix compilation warnings for the Write method (2 different
67 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
68 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
69 variable... create a static method in gdcm::Document to access to
70 this variable content.
72 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
74 file, to be accessed by other files (like gdcmFile). Remove commented
75 code. Move the change of the header to the gdcmFile, using the
77 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
78 To be sure of that (and simplify calls), the Write of the header now
79 gets a file name and not a file pointer (std::ifstream).
80 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
81 DocEntryArchive. Remove all open of the written file
83 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
86 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
88 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
90 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
91 some corresponding methods. Write correctly the file and check before
93 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
94 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
95 is now on RGB datas (as before my last commit
96 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
98 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
100 Add a print information of the type of the entry
101 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
102 It was in the gdcmFile, and all write have been regrouped
103 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
104 Write correctly all dicom files (in decompressed mode only at this time)
105 * Test/ : test on files are now made using Raw datas and not color datas if
107 * Example/PrintFile.cxx : add more printings
109 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
110 * Amelioration of code, remove some code copy. For the loading of
111 BinEntry (in gdcmDocument), add the test to verify if the file is already
114 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
116 remove a DocEntry in the header (push an empty DocEntry)
117 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
118 lines. Bug fix in the initialization of the PixelConvert and the
120 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
121 use in TestCopyDicom (now this test can run under windows... but fails)
122 * Test/TestCopyDicom.cxx : amelioration of the test :
123 - test the pixels written
124 - add test points to quickly find where is the error
125 - can set a file name input and output in arguments
126 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
127 amelioration of the test output
129 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
131 all replaced DocEntry's
132 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
133 Now, each needed DocEntry to modify is duplicated, modified and inserted
134 to the header using DocEntryArchive. Thus, after save, we can restore the
135 header initial state.
137 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
140 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
142 correct to copy it. The DictEntry is specified at the DocEntry creation,
143 then, it musn't change in the time.
144 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
145 header correctly. At this time, the change is only made for the first
146 level of the Document. In the future, it might consider sequences.
147 The change is made by replacing a DocEntry by an other that is created
148 outside the class. The old value is kept. When we restore the header
149 status, the added DocEntry is deleted and replaced by the old value.
150 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
151 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
152 set the write type to explicit VR, implicit VR or ACR. Add methods to set
153 the write mode to native, decompressed or RGB (but not used at this time)
155 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
157 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
159 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
161 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
163 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
164 set because already copied when copying the BinEntry's of the header
165 * Test/TestAllReadCompareDicom.cxx : remove warnings
167 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
168 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
169 Two problems appear when doing it :
170 - with the gdcmFile : when the GetImageData method is called, the pixels
171 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
172 datas (pixels). And each structure destruct the datas when it's
173 destructed. So we have two destructions for the same datas. To solve it,
174 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
175 datas or not. If it doesn't own datas, then they will not destroyed by
177 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
178 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
179 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
180 create a double destruction of the same DocEntry's. So, to solve it,
181 the TagHT is simply cleared and the DicomDir* elements are destroyed.
182 * TODO : add an entry concerning memory leaks in the DicomDir
184 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
186 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
189 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
191 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
192 after it have been deleted
194 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * FIX: src/* fix the doxygen warnings.
196 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
197 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
198 was erroneously defined with a size of 15 instead of 16. [many thanks
199 to Jean Michel Rouet for pointing out this bug].
201 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
202 1. Finish merging JMR patch for writting DICOM from scratch
203 2. Fix -hopefully- bug with MONOCHROME and space vs null character
204 3. Use const ref when possible
205 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
206 5. A few more comments
207 6. CreateUniqueUID can now be called without parameter"
209 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
210 * ENH: Slightly bigger patch:
211 1. Getting toward full integration of JMR patch for writting dicom from scratch
212 2. Update Test to test part of this patch: CreateUniqueUID
213 3. File was not close properly in gdcmDict
214 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
215 5. Use of const ref instead of copy (speed issue)
216 6. Remove temporary (duplicate) string in TranslateToKey
217 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
218 8. Do not repeat virtual in subclasses
219 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
221 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
222 * Apply first patch toward better string comparison when dealing with broken
223 DICOM files. Essentially the string could be padded with a space instead
224 of a null character as defined by standard
226 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
228 because never used... and in the same time, that's remove some memory leaks
230 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmFile.cxx : now delete the PixelConvert instance.
232 * In examples and tests : change the type of image data variables from void*
233 to uint8_t*. Remmove all delete on image data variables
235 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
237 Verify the file pointer value before open the file, and if it's not null,
238 a verbose message is generated.
239 Close correctly the file when the file isn't considered dicom-like. The
240 correctly close is a call to CloseFile.
241 When closing the file pointer, test if its not null to close the file.
242 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
243 file. For an uncompressed image, the copied datas correspond in the least
244 case to the image size (calculated) or the image size specified in the
245 header. A verbose is generated if these two size mismatch
247 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
249 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
250 break under windows (with msvc6 compilation).
252 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
254 compiling with MSVC6)
256 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * Bugs fix for the Windows build with VC6
258 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
259 needed (only for projects required VTK). If the VTK is included in all
260 projects, there is conflicts with the jpeg lib of vtk when compiling the
261 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
262 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
263 when compiling the gdcm_wrap.cxx file (created by the compilation of the
265 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
266 (like it's already made for the cout use). Otherwise, conflict with the
269 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
270 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
272 - comments on the DicomDir::Method related usage added.
273 - now that we use the namespace gdcm, a lot of internal classes do
274 NOT need to be wrapped anymore.
275 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
276 DicomDir::Method) new example added.
278 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
279 * Improve string manipulation. I now inforce the notion of 'DicomString'
280 A DicomString can contain as many \0 as they want
281 and it is *always* of even length.
282 We only support odd length for very rare case.
283 And in the near future this should be removed.
285 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
286 * /binary_write/ gdcm source. Now even on big endian we are writting
287 little endian. This should -heopfully- fix some tests
289 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * Now the dictionary is compiled into gdcm lib. This is a default
291 behavior, thus any dic file specified is picked before failback to
292 the one comiled into lib
294 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * Change internals for gdcmDict. Don't use any 'new' any more.
296 This should definitely solve any leak problem, and we should be
297 as fast as before, as long as don't modify too much the dictionary.
299 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * STYLE: ivars should start with a capital letter.
301 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
302 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
304 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
306 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
307 new 2004 dictionaries added (thanks to JPR).
308 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
309 * CLEANUP_ROUND (15) for gdcmPixelConvert
310 - RLEFrame::NumberFragments is now of type unsigned int
311 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
312 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
315 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Initial work in gathering all transfer syntax accessors. clearly
317 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
318 ivars, but only one transfersyntax (class) ivar with equivalent method on
321 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
322 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
323 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
324 discussed (plus I didn't like having a 2000 lines patch not commited)
326 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
327 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
328 * CLEANUP_ROUND (14) for gdcmPixelConvert
329 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
330 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
331 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
333 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
334 anymore and hence avoids storing a copy of PixelConvert::Decompressed
335 into File::Pixel_Data.
337 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
339 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
340 * CLEANUP_ROUND (13) for gdcmPixelConvert
341 Substituted File::ParsePixelData() with PixelConvert::Print() new
343 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
344 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
345 method to those classes.
346 - src/gdcmFile.[cxx|h]:
347 -- Added a ::Print() method.
348 -- PixelConverter is now a reference instead of a member.
349 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
350 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
352 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
353 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
354 collaboration diagram and inheritance diagram should be generated with
356 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
357 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
358 pointlessly wrapped (see
359 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
360 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
361 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
362 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
363 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
364 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
365 -- File::Initialise: PixelConverter setup moved away to
366 PixelConverter::GrabInformationsFromHeader()
367 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
368 interpretation moved away to PixelConverter::BuildRGBImage()
370 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
372 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
374 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
376 displayed on Win32 when a brutal abort() occurs (because of uncatched
377 exception). See TODO new entry of this commit for more on this.
378 * TODO added new entry.
379 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
380 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
381 - HandleColor is no longer called from gdcmFile.cxx
382 - gdcmPixelConvert.cxx clean up on method arguments and internal
383 variable names for semantical coherence.
385 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
386 * Finished lossless transition, not only do we now read all lossless jpeg
387 images, without the need of the Cornwell lib, but we do read them properly now
388 * To reduce code (well to avoid code duplication), I defined a common place
389 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
390 redefine symbols. This is not prefect but this the best solution I found for a
391 compilation time jpeg option.
393 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
394 * Update jpeg ijg lib to support lossless jpeg implementation
395 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
397 * Also added a special copyright for dcmtk since we use their bugfixes.
400 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
402 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
403 matters, as stated in warning note at begining of %include section).
404 * src/gdcmDicomDir*.[cxx|h]: coding style
405 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
406 * src/gdcmJpeg8.cxx: doxygen fix.
407 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
408 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
409 from File:: to PixelConvert::.
411 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
413 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
414 - more code moved away from File:: to PixelConvert::
415 - fat setup of PixelConverter set in place in File::Initialise.
417 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
418 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
419 namespace at the file system level. So now you should convert your examples
421 gdcmHeader -> gdcm::Header
422 It would be nice if people keep in mind to no open the namespace, since it
423 allows compilation on broken plateform which were defining common symbol in
424 the standart namespace (like LP, Unknown ...)
426 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
427 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
428 The JPEG fragments are now parsed at the same stage than the RLE
429 information. All code related to JPEG is now in gdcmPixelConvert:
430 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
431 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
432 export a gdcmFile:: method. Those are simply global functions
433 (for the time being this is better than having them attach to
434 either gdcmFile:: or gdcmPixelConvert::).
435 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
436 and stores the result in a gdcmJPEGFragmentsInfo.
437 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
438 code (among other stuff) moved away from gdcmFile:; to
441 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
443 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
444 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
445 clean up of RLE related code.
446 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
447 - src/gdcmRLE.cxx removed
448 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
449 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
450 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
451 * CLEANUP_ROUND (9) for gdcmPixelConvert
452 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
453 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
454 away from gdcmFile:: to gdcmPixelConvert::.
456 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
457 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
458 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
459 This is because Parse7Fe0 used to parse the pixels to compute the
460 length. This task was passed over to FindDocEntryLengthOB() a long
461 time ago, EXCEPT I had forgotten the OW case...
462 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
463 we just recylce the code for parsing RLE fragments and computing
465 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
466 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
467 with the retired Parse7Fe0().
468 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
469 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
471 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
473 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
474 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
475 - src/CMakeLists.txt: alphabetic order reodering + new entries.
476 * CLEANUP_ROUND (4) for gdcmPixelConvert
477 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
478 to return an unused length.
480 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
481 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
482 this should be cleanner from the plane view. The iostream are erally a pain
483 to use to do simple stuff.
485 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
486 * Redo the compilation of the ijg jpeg library. Now only one source is
487 necesseray. No need to rename file by hand what so ever. CMake handle the
488 copying of the file within different directory, configure header file to
489 modify some symbol. The only addition made to ijg wasd a mangle table so
490 that symbol are different wether we are within 8bits or 12bits.
492 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * Added documentation of vtkgdcmReader on Website:
494 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
495 with it's binary name).
496 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
497 the Website to be more complete.
498 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
499 doxygenated documentation.
500 - Doc/DoxyVtkGdcmReaderExamples.txt added
501 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
502 DoxyVtkGdmReaderExamples.html )
503 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
504 * CLEANUP_ROUND (3) for gdcmPixelConvert
505 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
507 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * CLEANUP_ROUND (2) for gdcmPixelConvert
509 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
511 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * CLEANUP_ROUND for gdcmPixelConvert:
513 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
514 - src/gdcmPixelStuff[h|cxx] removed
515 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
516 - src/CMakeLists.txt changed accordingly
518 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
519 gdcmVersion.py moved to newly created ATTIC related
520 gdcmPython/SetupOldies/ directory.
521 * Autotools clean up:
522 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
523 - autogen.sh configure.in acinclude.m4 python.m4 removed
525 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * src/*.cxx *.h Reference to License.htm fixed to License.html.
527 * Doc/CMakeLists.txt, doxygen.config.in: fix.
528 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
530 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * TODO updated with Mathieu suggestions. I proposed a template for
532 describing TODO entries and used it for new entries.
533 * Added Doc/Website/CodingStyle.html, Developpers.html,
534 DeveloppersPython.html, GdcmDataCvs.html and
535 DownloadVersion0_1.html, DownloadVersion0_3.html.
536 * Some Doc/*.txt Doxygen files (which do not really concern the
537 documentation itself, but the website) moved to html and
538 placed in directory Doc/Website:
539 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
540 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
541 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
542 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
543 * CMakeLists.txt changed accordingly.
544 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
545 DeveloppersPython.html
546 * INSTALL nows refers to Doc/Website/Installation.html
548 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * Added Doc/Website directory, that contains a first raw version
552 2004-09-23 Jean-Pierre Roux
553 * FIX In order not to be poluted any longer by casting problems,
554 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
555 we can now delete[] it safely
556 * VoidArea is now called BinArea (less confusing name),
557 and all the methods called ...VoidArea... are now ... BinArea...
558 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
560 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
562 clear) TagHT, which is an inherited member of gdcmElementSet. It is
563 up to the destructor of gdcmElementSet to clean up TagHt and it's
566 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
567 * Test/CMakeLists.txt: update to follow gdcmData renamings.
568 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
570 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * ENH: added some utility method that builds a flat dictionnary
572 holding all the Dicom entries contained in the recursive structure
573 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
575 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
576 BuildFlatHashTable() that build a flat dictionary.
577 - src/gdcmElementSet.h: added a new private GetTag() accessor.
578 gdcmDocument is now a friend of gdcmElementSet.
579 - src/gdcmElementSet.cxx: clean up.
580 - Example/FlatHashTablePrint.cxx added.
581 - Example/CmakeLists.txt changed accordingly
583 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
585 moved away from gdcmDocEntrySet (since this class is an abstract class
586 acting like an interface). SQDepthLevel and BaseTagKey are now
588 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
589 and associated accessors. Doxygenation of the class.
590 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
592 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
593 Use SQDepthLevel accessor instead. ::Print() adapted.
594 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
595 - src/gdcmDocument.cxx changed accordingly.
597 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
598 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
599 - The following is the doxygen comment of the typedef declaration
600 of gdcmagKey in src/gdcmCommon.h:
601 gdcmTagKey is made to old an "universal" (as in URL, Universal
602 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
603 A dicom tag allways has a group and an element, but a set of tags
604 embeded in various (optionally nested) sequences and sharing
605 the same group and element all share the same (group, element)
606 "identifier". Hence the (group, element) cannot be used as an
607 identifier (in gdcm we shall refer to a "TagKey") of a tag.
608 In order to construct a proper tag identifier (i.e. a key) we
609 consider the following definition of a TagKey:
610 - let Group, Element be the string representation of the
611 group and element dicom tag members,
612 - let ItemNumber be the string representation of the integer
613 index of the considered item number of a sequence,
614 Let the key of a tag embeded in a sequence, noted SeqTag, be
616 /ItemNumber#Group|Element
617 where "/", "#" and "|" are characters acting as separators.
618 Then the general form of a gdcmTagKey is given by:
619 Group|Element<SeqTag>
620 where <SeqTag> means NO or many instances of SeqTag.
621 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
624 but the gdcmTagKey of a tag "embeded" is the first item of
625 a sequence, itself nested in the third item of a sequence is the
627 0004|1220/2#0008|0082/0#0008|0090
628 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
629 order to hold the new sequence compatible key. Previously, the
630 GetKey() method would look in the underlying gdcmDictEntry.
631 - src/gdcmDocEntry.cxx:
632 -- constructor now copies the underlying DictEntry key, in the local
634 -- ::Print: displays the member Key, instead of the (group, element).
635 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
636 - src/gdcmDocEntrySet.h:xi
637 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
638 -- now has a new BaseTagKey member.
640 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
641 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
643 This poses the problem with the semantics of the following lines
644 LoadEntryVoidArea(0x0028,0x1201); // R LUT
645 LoadEntryVoidArea(0x0028,0x1202); // G LUT
646 LoadEntryVoidArea(0x0028,0x1203); // B LUT
647 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
648 to the long FIXME note for what the problem is. Nevertheless in
649 order to get things working the dicom dictionary was altered !
650 Please fix things urgently...
651 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
652 information), see above note on moving the member VoidArea. Nevertheless
653 the following entries previously correctly set as US are now inproperly
655 0028 1201 OW IMG Red Palette Color Lookup Table Data
656 0028 1202 OW IMG Green Palette Color Lookup Table Data
657 0028 1203 OW IMG Blue Palette Color Lookup Table Data
658 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
659 of gdcmDocEntry moved to gdcmSeqEntry.
660 * src/gdcmSeqEntry.cxx: STYLE.
662 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
663 * Test/TestAllEntryVerify.cxx minor fix and added comments.
665 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * gdcmPython/testSuite.py: all the test suite in python is now moved
667 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
668 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
669 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
671 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
672 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
673 to avoid inclusion recursion until STL is reached.
674 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
675 mecanism. errno.h is not included in gdcm anymore.
676 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
677 (gdcmFormatError now inherits from gdcmFormatUnexpected).
679 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
680 gdcmData/TestAllEntryVerifyReference.txt
681 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
682 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
683 exception_on_error parameter.
684 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
685 - vtk/vtkGdcmReader.cxx changed accordingly,
686 - Example/*.cxx and Test/*.cxx changed accordingly.
688 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
690 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
691 enable_sequences removed from gdcmHeader constructor and dependencies.
692 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
693 * gdcmPython/demo/PrintHeader.py: dummy fix.
694 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
695 skip_shadow removed from gdcmHeader constructor and dependencies.
696 * Example/*.cxx and Test/*.cxx changed accordingly.
698 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
700 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
702 2004-07-21 Jean-Pierre Roux
703 * FIX Now, Parsing and Printing a DICOMDIR do work!
704 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
706 2004-07-20 Jean-Pierre Roux
707 * FIX Some brain damaged headers have Zero-Lenght fields
708 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
710 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
711 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
712 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
713 variable (instance of gdcmDebug) by a definition macro, and the instance
714 is now in static in the gdcmDebug class
715 * src/gdcmSQItem.h : (FIXME) remove an undefined method
716 * Test/PrintAllDocument.cxx : bug fix in the result of the test
718 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * WARNING: ctest now depends more tightly on gdcmData. You should
720 check out gdcmData properly for things to run smoothly...
721 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
722 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
723 we need the pixels not be loaded in order to use the ValEntry
724 that displays position and size).
725 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
726 This is a C++ based equivalent of gdcmPython/testSuite.py that should
727 be deprecated. If you have any doubts about the advantages of a
728 modern scripting language (read Python) versus grass root C++ (i.e.
729 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
730 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
731 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
732 Anyhow, consider documenting the gdcmData images in
733 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
735 * Test/CMakeLists.txt:
736 - now uses TestAllEntryVerify.cxx
737 - specific comments on oldACR00001.ima (now renamed in gdcmData
738 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
739 gdcmData/TestAllEntryVerifyReference.txt
742 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
743 * src/*.[h|cxx] : typedef clean up
744 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
745 - TagKey renamed to gdcmTagKey (for external usage)
746 - VRKey renamed to gdcmVRKey (for external usage)
747 - removal of typedef duplication.
748 - Removed all unecessary inline keyword from class inline definitions.
749 - Some method|function(void) declarations replaced with method|function().
750 * src/jpeg/libijg12/jdhuff12.c:
751 - printf polluting ctest removed.
752 - TAB removal for comminting
754 - TestAllReadCompareDicom.cxx: added a test that compares all the
755 images in gdcmDataImages.h with corresponding images in
756 gdcmData/BaselineDicom/. When baseline images are not present
757 this test creates them.
758 Note: we need to validate each reference image, but before that
759 I'd like to rename them with a more explicit name...
760 - CMakeLists.txt: changed accordingly.
761 * Example/*.cxx: examples now only include gdcm.h (as opposed to
762 including each header needed).
764 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
765 * Test/*.cxx and Example/*.cxx: moved some examples away from the
766 test suite to the Example directory. Are concerned:
771 - TestWriteSimple.cxx
772 * Test/CMakeLists.txt: added some comments on reasons for black listing
773 image gdcmData/oldACR00001.ima
775 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * Test/CmakeList.txt: removed the following from black list (to be coherent
777 with removal from gdcmData):
778 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
779 - gdcm-MR-PHILIPS-16.dcm
781 Added the following because after last cvs update, they cause
782 ctest -R TestReadWriteReadCompare
784 - gdcm-MR-SIEMENS-16-1.acr
786 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
787 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
788 new comments in this file) we temporarily (sigh) move to a weaker
790 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
791 we don't need to black list the following images anymore:
792 - 8BitsUncompressedColor.dcm
794 - US-PAL-8-10x-echo.dcm
795 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
796 fixes and the beautified code ;-)
797 This fixes the bug introduced in version 1.42 (when beautifying)
798 that made the parsing of 8BitsRunLengthColor.dcm unproper.
799 Note: ctest was blind to this bug (this means we need to still
800 improve the test suite). The bug could be detected by using
801 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
803 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
804 and by displaying the (garbage) produced file temp.XDCM...
806 2004-06-29 Jean-Pierre Roux
807 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
808 - replace by uggly but working old code :-(
809 A lot of things should be OK again.
810 It's really urgent to have a test suite that *tests*,
811 to prevent Frog's beautifying sessions to break all the stuff
812 (twice, withing a fortnigh ...)
814 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
816 redundancy) to added Test/TestReadWriteReadCompare.cxx
817 * Test/CmakeList.txt: because the compare test of
818 Test/TestReadWriteReadCompare.cxx fails, the following images are
819 black listed: - 8BitsUncompressedColor.dcm
821 - US-PAL-8-10x-echo.dcm
822 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
823 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
824 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
825 and ad-hoc kludge. This kludge is now removed, and on encountering
826 such an image (OB field brain damaged) we set errno. Then in
827 ::FindDocLength() we "fix" the length as being ALL what remains
828 in the file (until EOF). We then proceed, hoping for the best...
829 This fixes a SegFault in ShowDicom when trying to write such an
831 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
832 (because TestWriteRead breaks on it, after a non conformal commit?).
833 ctest now runs properly, except for MakeDicomDir (which was allways
834 broken) and the Python related stuff (still not fixed).
836 2004-06-24 Jean-Pierre Roux
837 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
838 FIX : Test/TestReadWrite now iterates on all the file names
839 (instead of infinite loop)
840 ENH : Test/TestWriteRead now iterates on all the file names
842 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
843 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
845 2004-06-24 Jean-Pierre Roux
846 FIX : - now Write drops LUT Descriptors and LUTs (if any)
847 when SamplesPerPixel =3
848 - now Write is no longer confused by
849 'BitsAllocated = 12" and 'BitsStored=12"
850 - "UN" value representation Elements are now written correctly
851 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
852 ENH : - now gdcmHeader has its own Write methods
853 (in order to split the job that has not to be done
856 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
857 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
858 loop on the same image until memory went out.
859 Note: this means we still have gobs of memory loss in PrintDocument
860 * src/gdcmDocument.cxx: fixes problem on parsing on file
861 gdcmData/16BitsJpegLosslessGrayScale.dcm.
863 2004-06-24 Jean-Pierre Roux
864 FIX : Write - All the Sequences and Sequence Item are now written
865 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
866 is added a the end, when necessary.
867 - A lot of brain-damaged images, that were read correctly are
868 now written correctly
869 - length compatible BinEntry are now loaded correctly
870 (even for odd groups)
871 Note : only Explicit Value Representation was checked.
872 (question : is implicit VR really necessary for gdcm ?)
874 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
875 * DEVELOPPER: added a proposition of coding style.
876 * src/gdcmDocEntry.h: removed every inline declaration (for test of
879 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
881 Use the gdcmDocEntry::Print() and Write() instead.
882 * src/gdcmDocument.cxx: bug fix.
884 2004-06-22 Jean-Pierre Roux
885 FIX : gdcmDocument.cxx
886 - Now we do recognize the JpegLossLess format (there was a misstyping in
887 code 'beautyfication' :-(
888 - Now we automaticaticaly load the Luts, if any
890 2004-06-22 Jean-Pierre Roux
891 In order : to write Sequences, whatever their imbrication level,
892 : to allow user to create his own Sequences
893 a lot of modif where necessary (adding, moving, or virtualising methods)
895 WARNING : save your own sources *before* cvs up !
898 ADD virtual void Write(FILE *fp, FileType filetype);
901 ADD virtual void Write(FILE *fp, FileType filetype);
902 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
905 ADD virtual void Write (FILE *fp, FileType filetype)=0;
906 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
907 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
908 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
909 ADD std::string GetEntryByName(TagName name);
910 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
912 std::string vr = "unkn",
913 std::string fourth = "unkn",
914 std::string name = "unkn");
915 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
916 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
917 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
918 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
919 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
920 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
921 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
922 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
925 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
926 ADD virtual std::string GetEntryByName (TagName tagName);
927 ADD virtual std::string GetEntryVRByName (TagName tagName);
928 REM virtual bool Write(FILE *, FileType);
929 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
930 FILE *_fp, FileType type);
931 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
932 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
933 REM virtual bool WriteEntries(FILE *_fp,FileType type);
934 REM virtual std::string GetEntryByName (std::string tagName);
935 REM virtual std::string GetEntryVRByName (std::string tagName);
936 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
937 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
938 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
940 std::string vr = "unkn",
941 std::string fourth = "unkn",
942 std::string name = "unkn");
943 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
944 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
945 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
946 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
949 ADD virtual void Write(FILE *fp, FileType filetype);
952 ADD virtual void Write(FILE *fp,FileType filetype);
955 ADD virtual void Write(FILE *fp, FileType filetype);
956 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
957 REM std::string GetEntryByNumber(guint16 group, guint16 element);
958 REM std::string GetEntryByName(TagName name);
961 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
963 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
965 The default constructor invoked by the line
966 gdcmHeader *f1 = new gdcmHeader( header );
967 was gdcmHeader::gdcmHeader(bool) instead of the expected
968 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
969 Hence the parsing wasn't executed... See also below.
970 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
971 as explicit constructor didn't do the trick to fix the above problem.
972 Could anyone explain why ?
973 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
974 properly calls gdcmValEntry::Print() (that was weed out from
975 code related to gdcmBinEntry).
977 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
978 * In order to fix memory leaks:
979 - Test/TestWriteSimple.cxx: added cleaning of free store through
981 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
982 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
983 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
984 (through the call to ::AddDicomDirMeta()) or the destructor
985 would crash when deleting uninitialized ::metaElems].
986 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
987 - src/gdcmDocument.cxx:
988 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
990 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
991 was causing memory leaks.
992 - src/gdcmSQItem.cxx:
993 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
994 cleanly handled with polymophism: sorry but my milage is low).
995 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
996 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
997 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
998 This avoids SegFaulting.
999 - src/gdcmSQItem.h: coding style.
1001 - Test/TestWriteSimple still severely sucks. The output image content
1002 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1003 damaged when displayed with vtkgdcmViewer.
1004 - on memory leaks: TestWriteSimple leaks really less (see entry
1005 of 2004-06-18 in Changelog file for the call to valgrind).
1006 - on segfaults: ctest now passes all the tests but one (no more
1008 * Erroneous leading white fix:
1009 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1010 white[s] (as opposed to from >> xxx, that removes it [them].
1011 - src/gdcmTS.cxx: ditto.
1012 - gdcmPython/testSuite.py: dirty related kludge removed.
1013 * src/*: remaining references to gdcmParser removed.
1014 * src/*[cxx|h]: added copy[way]left header.
1017 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * In order to fix writing of dicom files:
1019 - Test/TestWriteSimple.cxx: a simpler example of writing.
1020 - Test/CMakeLists.txt changed accordingly.
1021 - src/gdcmDocument.cxx:
1022 -- The destructor now recursilvely removes potential sequences.
1023 -- Bug fix in ::IsJPEG2000()
1024 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1025 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1027 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1028 to only declared) and build on top of
1029 ::GetDocEntryByNumber(guint16, guint16).
1030 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1031 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1032 for usage in destructor and treatement of promotion in
1033 ::ReplaceOrCreateByNumber().
1034 - src/gdcmSQItem.cxx: destructor should better handle his job.
1035 Test/TestWriteSimple now runs (or at least it DOES something).
1036 * We can now start hutting memory links. A good starting point is:
1037 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1038 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1039 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1041 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1042 * Valgrind note: after Mathieu Malaterre teached me how to read
1043 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1045 Using gcc, you can force the STL to use malloc and to free memory as
1046 soon as possible by globally disabling memory caching.
1047 With 3.2.2 and later, you should export the environment variable
1048 GLIBCPP_FORCE_NEW before running your program.
1049 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1050 simply vanish (it is still not clear to me, whether this means that
1051 STL std::string leaks or if valgrind believes it leaks...).
1052 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1053 running bin/gdcmTests makeDicomDir):
1054 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1055 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1057 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1058 SegFaulting (I drowned in DicomDir related code when trying to
1059 understand why the list is empty...).
1060 * src/gdcmDocument.h: first BSD license header try.
1061 * Doc/License.txt added.
1063 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1064 * src/gdcmDocument.[h|cxx]:
1065 - Clean up of the Transfer related predicates. They are now all based
1066 on new method isGivenTransferSyntax, that (should) handle properly
1067 the padding problem.
1068 - general clean up, simplification, and coding style.
1069 - Specific clean up of Parse7FE0() (umproperly named actually).
1070 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1072 2004-06-14 Jean-Pierre Roux
1074 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1075 - fix the display of SQItem ordinal number
1076 - add the GetSQItemByOrdinalNumber method
1077 - remove some useless never written private methods
1079 2004-06-14 Jean-Pierre Roux
1081 - adding a constructor taking a gdcmDocEntry as an input param
1082 - ReplaceOrCreateByNumber now returns :
1083 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1084 a gdcmValEntry * if a string value is passed as a param
1086 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1087 according to the param type (no longer sets a gdcmDocEntry)
1088 - GetValEntryByNumber, GetBinEntryByNumber added
1089 - NewValEntryByNumber and NewBinEntryByNumber added
1091 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1093 - GetSQItemNumber and SetSQItemNumber added, to provide
1094 a (relative) Item identier inside a given Sequence
1095 \warning : some pb remaining around this number
1097 - AddEntry now takes the Item Number as a param
1099 - adding a constructor taking a gdcmDocEntry as an input param
1101 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1102 * Memory leak hunt with the following command:
1103 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1104 --show-reachable=yes gdcmTests PrintDocument
1105 It looks like many (all?) leaks are due to the STL (or a bad usage
1106 of the STL. The lines producing the leaks now have a comment with
1107 a "MEMORY LEAK" tag: you can retrieve them with
1108 grep "MEMORY LEAK" src/*
1109 Here are two typical examples which I can't help fixing:
1114 char * test = "babo";
1115 name = test; //// <--- valgrind detects 960 bytes lost in
1116 //// call to std::string::operator=(char const*)
1117 name.clear(); //// Doesn't help !
1125 std::cout << "Type a bunch of characters followed by RETURN: ";
1126 getline(std::cin, line); //// <--- valgrind dectects a loss
1127 //// of 1320 bytes in call to
1128 /// std::basic_istream<>& std::getline<>
1134 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * src/gdcmHeader.[cxx|h]:
1136 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1137 and related, moved away to gdcmDocument.
1138 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1139 the corresponding protected accessors of inherited class
1140 gdcmDocument, removed ! As a consequence gdcmFile had to be
1141 declared friend of class gdcmDocument (see below).
1142 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1143 - Clean up of undefined or unused methods.
1144 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1145 account the changes to gdcmHeader.h).
1146 * src/gdcmDocument.h:
1147 - gdcmFile is now a friend class (in order to take into account the
1148 changes to gdcmHeader.h).
1149 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1150 (see changes to gdcmHeader.h).
1151 - Accessors (reading on the form GetEntry*) are now public.
1152 - Clean up of undefined or unused methods.
1153 * src/gdcmDocument.cxx:
1154 - adaptation to changes to gdcmDocument.h
1155 - ::OpenFile now writes a verbose message when file cannot be opened.
1156 - some std::string properly set to VRKey
1157 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1158 references to gdcmDocument.
1159 * Test/TestFindTags.cxx: changed accordingly to above changes.
1160 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1161 cvs repository gdcmData.
1163 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1164 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1165 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1166 conflicts with gdcmValEntry::voidArea.
1167 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1168 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1169 Value representation between StringRepresentable and BinaryRepresentable.
1170 * src/gdcmDocument.cxx:
1171 - method ParseDES: proper indentation restored and usage of
1172 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1173 - method LoadDocEntry: the fingerprint left in the SetValue() of
1174 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1175 removed. Reverting to previous code segment with the proper
1176 dynamic_cast< gdcmValEntry* >.
1177 Note: this was (partially) breaking the python test suite
1178 (gdcmPython/testSuite.py) that made usage of the above
1179 fingerprint to check presence of "Pixel Data".
1180 * src/gdcmDocEntry.h: coding style.
1181 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1182 now taken into account.
1183 * gdcmPython/gdcm.i: adaptation to the new internal representation
1184 of gdcm (exit gdcmParser, hello gdcmDocument).
1185 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1187 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1188 anymore, but instead prints the loaded Python dictionary.
1189 * .... alas, the python testSuite is still broken.
1191 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1192 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1194 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1195 * src/gdcmUtil.h : export methods
1197 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1198 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1200 * Initial addition of automatic python testing
1201 * Initial addition of automatic image comparison
1203 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1204 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1205 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1207 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1208 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1209 * Test/ShowDicom.cxx : bug fix for msvc compilation
1210 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1212 2004-05-04 Jean-Pierre Roux
1213 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1214 new concepts (and new classes) :
1215 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1216 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1217 - Sequence Doc Entries (gdcmSeqEntries)
1218 a Sequence is composed of Items.
1219 Each item is a set of Doc Entries (this is recursive)
1220 The non uniqueness of the 'Dicom tag' is due to this recursivity
1221 (never taken into account)
1222 Our unability to add a new 'entry' in the header
1223 at the proper location (neither in the H-Table (map or multimap),
1224 nor in the Chained List is also due to this recursivity.
1225 Don't try, right now, to use/modify/compile these new sources :
1226 nothing is finished.
1227 We just commit all the stuff, 'as is', in order not to loose it.
1229 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1230 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1232 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1233 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1234 file prefix (SetFilePrefix)
1236 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1237 * Add a new test: ShowDicom, for now this is just the c++ version of
1238 checkRead.sh, later it will be able to compare the image read against a
1240 * Replace the DEBUG on the stack with a global entry in cmake interface:
1241 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1243 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1244 * Add an example subdir, with a real example on how to read + write a
1247 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1248 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1249 * Doc/CMakeLists.txt: the main page is now properly differentiated
1250 between the developper and user version.
1251 * Doc/doxygen.config.in: dropped search related obsolete flags
1252 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1254 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1255 * DEVELOPPER: added some helpfull comments for compile/test/install
1258 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1259 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1260 src directory, now generated in the build dir.
1261 2. Tests as mentionned smarter
1263 4. Add a new method in gdcmDict that return the PubDict by name
1264 this is interesting for 3rd party lib like ITK,
1265 where we could set the institution name / patient name...
1267 * ENH: 1. Now the test suite is working for real
1268 2. All binaries are now output in the gdcm-bin directory
1269 (this was not true before)
1271 2004-04-28 Jean-Pierre Roux
1272 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1273 SeQuence indented printing of Dicom Header.
1274 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1275 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1276 Computation of SQDepthLevel is now part of gdcmHeader constructor
1277 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1278 tree-like structure of a Dicom Header.
1279 * FIX Test code cleaning
1281 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1282 * ENH: Adding automatic testing
1283 1. Need a DartConfig.cmake to submit to public
1284 2. Add a test driver gdcmTest.cxx
1285 3. gdcmTestMain, an helper for the main test driver gdcmTest
1286 4. Files in Test don't have a main anymore, this becomes interesting
1287 when we add more and more tests, thus dsw don't have to load
1289 * ENH: Adding a GDCM_DATA_ROOT for testing
1290 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1291 one file instead of seven + some small cleanup
1293 2004-04-22 Jean-Pierre Roux
1294 * ENH Minor changes to the Print() methods.
1295 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1296 Header printing. Example given with :
1297 > PrintHeader fileName 2 new
1298 (SQ based tree-like structure still to be done for the Header ...)
1300 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1302 1. I have added some unsigned where needed
1303 2. Some function parameter not used -> (void)
1304 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1305 4. g++ don't like character '\' in comment
1306 5. #define jpeg_create_decompress jCreaDecompress
1307 this really need to be fixed
1308 6. virtualize destructor of gdcmObject ... leakage
1309 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1310 this also really need to be fixed
1311 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1312 remove compression file
1313 (as we only do decompression, right ?)
1314 * ENH: Change malloc/calloc/free with c++ equivalent
1316 2004-04-21 Jean-Pierre Roux
1317 * FIX gdcmHeaderHelper::GetXSpacing
1318 when a single value is found (bug ?), xpacing is now
1319 defaulted to yspacing
1321 2004-04-19 Jean-Pierre Roux
1322 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1323 * ENH add parameters :
1324 bool exception_on_error = false,
1325 bool enable_sequences = false,
1326 bool ignore_shadow = false
1327 to the gdcmFile constructors to be full gdcmParser compliant
1328 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1329 to allow reading of PAPYRUS 3.0 files
1331 2004-04-06 Jean-Pierre Roux
1332 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1334 2004-04-02 Jean-Pierre Roux
1335 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1336 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1337 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1339 2004-03-30 Jean-Pierre Roux
1340 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1341 for ACR file, written out as DICOM files (hope so...)
1343 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1345 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1346 moved to base class gdcmParser and only the specialisation is kept
1348 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1349 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1350 already does the job.
1351 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1352 (to be consistent with gdcmParser::WriteEntries).
1354 2004-03-30 Benoit Regrain
1355 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1356 upate of the object's instance. It's passed to 2 in the unfavorable
1357 case : one in the ExecuteInformation, one in the ExecuteData
1359 2004-03-29 Jean-Pierre Roux
1360 * ENH : Check on file type to be written moved
1361 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1362 * FIX : gdcmObject::ResetBoundaries now stops properly
1363 when end-of-list is reached
1364 : gdcmVersion modified (as Benoit Regrain asked)
1366 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1368 * src/gdcmUtil.cxx: added forgotten iostream include.
1369 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1370 equivalent to ExplicitVR in existing code).
1372 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1373 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1374 now contains all the gdcmGlobal related code.
1375 * minor coding style and doxygenation changes.
1377 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1378 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1379 now contains all the Debug related code.
1380 * minor clean-up of includes in src/*.cxx
1381 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1382 CreateCleanString) removed.
1383 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1384 * Doc/DoxyMainPageUser.txt added.
1385 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1386 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1387 src/gdcmDirList.cxx)
1389 2004-03-24 Jean-Pierre Roux
1390 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1392 2004-03-23 Jean-Pierre Roux
1393 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1394 big endian made volumes
1395 * ENH Now gdcmParser constructor and destructor are protected to forbid
1396 end user to instanciate class gdcmParser
1397 (only gdcmHeader and gdcmDicomDir are meaningfull)
1399 2004-03-22 Benoit Regrain
1400 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1401 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1402 gdcmSerie to gdcmDicomDirSerie
1404 2004-03-19 Jean-Pierre Roux
1405 * ENH Now the tree-like structure describing a DICOMDIR comming from
1406 an already existing DICOMDIR file is consistent with
1407 the home-made tree-like structure build ex-nihilo
1408 or build from the files held (recursively) in a Directory
1409 functions gdcmDicomDir::CheckBoundaries()
1410 gdcmObject::SetBoundaries() added
1412 2004-03-17 Jean-Pierre Roux
1413 * REM (Eric Boix bug) : removal of meaningless
1414 gdcmDicomDirImage::NewImage function.
1415 * FIX now file names and directory name are written properly in the
1417 * FIX now gdcmDicomDir constructor may be call without any trick
1420 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1422 of gdcmDicomDirImage::NewImage as empty function.
1424 2004-02-28 Jean-Pierre Roux
1425 * ENH add gdcmDicomDir:NewPatient
1426 add gdcmDicomDirPatient:NewStudy
1427 add gdcmDicomDirStudy:NewSerie
1428 add gdcmDicomDirSerie:NewImage
1429 to allow making gdcDicomDir object.
1430 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1431 (as opposite to the gdcmHeader chained list)
1433 2004-02-11 Benoit Regrain
1434 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1435 when using from python
1437 2004-02-10 Benoit Regrain
1438 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1439 * FIX : in gdcmDicomDir when the directory is empty
1440 * ENH : add callback and methods to get the progression of dicomDir
1443 2004-02-06 Jean-Pierre Roux
1444 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1445 - GDCM_META added to gdcmDicomDirType
1446 - class gdcmMeta created
1447 * ENH : - A brief summary is now displayed at the beginning of
1448 'testDicomDir' to help disaster magnitude estimation
1449 * REM : Now useless Test/explDICOMDIR.cxx
1451 2004-02-05 Benoit Regrain
1452 * ENH : add methods in gdcmObject to get the hash table or the list of
1454 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1455 * FIX : wrapping python for TagHeaderEntryHT
1457 2004-02-04 Benoit Regrain
1458 * FIX : even length for some strings when writting the dicom dir
1459 * FIX : sort the images in the dicom dir
1460 * FIX : Bug fix for python use of dicom dir
1461 * ADD : a python demo
1463 2004-02-04 Jean-Pierre Roux
1464 * FIX : Final solution (?) for icone embedded images
1465 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1466 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1467 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1468 gdcmData/gdcm-MR-SIEMENS-16.acr1
1469 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1470 to make full checking easier
1472 2004-02-04 Benoit Regrain
1473 * FIX : WriteEntries : coding style & logic in parameters
1474 * FIX : Set the elements to create the DicomDir in a dictionary file
1476 2004-02-03 Benoit Regrain
1477 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1478 * gdcmDicomDir : add the load of directory
1479 * Bug fix and print add-on
1481 2004-02-03 Jean-Pierre Roux
1482 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1483 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1484 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1485 * FIX gdcmParser.cxx : 'group length' elements are now considered
1486 as integers, even for shadow groups, when file is Implicit VR
1488 2004-02-02 Jean-Pierre Roux
1489 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1491 of the last synonym :-(
1492 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1494 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1495 * FIX taking into account the possible 7fe0,0010 multiplicity
1496 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1497 to allow removal of references to 7fe0,0010, to deal with
1498 ACR-NEMA images, when 0028,0200 is meaningfull
1500 2004-01-31 Jean-Pierre Roux
1501 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1502 no longer writes 'Un' on disk
1503 * FIX SQ elements with actual length are now dealt with corectly
1504 * FIX gdcmFile::WriteBase make the difference, for color images, between
1505 the length (for Palette expanded images)
1506 and Raw Length (non expanded image + Palette)
1507 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1508 (that broke Write). Replaced by UL.
1509 Aware user will reload the field if he
1510 thinks it's necesssary
1512 2004-01-30 Jean-Pierre Roux
1513 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1514 when 'dirty Acr' is found, to be compliant with the new
1515 IsReadable() methods.
1517 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1518 (no DOUBLE images in kosher DICOM,
1519 but so usefull for people that miss them ;-)
1521 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1522 DICOMDIR related utilities (not checked as Windoze compliant)
1524 2004-01-28 Jean-Pierre Roux
1525 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1527 2004-01-27 Jean-Pierre Roux
1528 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1529 to allow skipping the shadow elements, to save memory space.
1530 The TRUE value for this param has to be used
1531 with a FALSE value for the 'enable_sequence' param.
1532 ('public elements' may be embedded in 'shadow Sequences')
1533 * gdcmHeader methods now deal with 'embedded icones images' in the header
1534 (even when an 'icone image sequence' is announced by the
1535 element (0x0088,0x0200), but there is NO icone at all ...
1537 * gdcmHeader sometimes Image Location value doesn't follow
1538 the supposed processor endianity (see gdcmData/cr172241.dcm).
1541 * gdcmHeader add the method
1542 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1543 to get *all* the Header Entries with the same tag.
1544 GetHeaderEntrySameName is probabely *useless*
1545 (no meaning : Name is *not* an identifier within the Dictionnary)
1547 2004-01-26 Benoit Regrain
1548 * Bug fix in the print of hexadecimal representations. Remove long fields
1549 in the print and add a third level of print to print them
1551 2004-01-23 Benoit Regrain
1552 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1553 * Bug fix on test suite after remove the strip made on not string fields
1554 * Split the IsReadable method between gdcmParser which test that the file
1555 is dicom and gdcmHeader which test that it's an image file
1557 2004-01-22 Benoit Regrain
1558 * DicomDir : clean code, add methods, set variables in protected or private
1559 * gdcmUtil : bug fix for the clean string method
1561 2004-01-19 Benoit Regrain
1562 * Add the use of shadow dictionaries
1563 * bug fix and coding style
1565 2004-01-19 Benoit Regrain
1566 * src/gdcmFile.cxx : bug fix concerning the close of file
1567 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1568 * Add the update of header entries using the shadow library
1570 2004-01-19 Benoit Regrain
1571 * removal of file gdcmHeader2.cxx
1572 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1573 inheriting from gdcmParser. This split is to prepare the integration
1574 of dicom dir parsing
1575 * bug fix under python
1577 2004-01-16 Jean-Pierre Roux
1578 * REM removal of class gdcmHeaderEntrySet
1579 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1580 * ADD add file gdcmHeader2.cxx
1581 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1583 2004-01-15 Benoit Regrain
1584 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1585 entries created while parsing the header. Thus, they will be destroyed
1586 when the gdcmDictSet will be destroyed
1587 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1590 2004-01-15 Benoit Regrain
1591 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1592 made a fatal error because of the memory release at the end of program.
1593 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1594 some memory and vtk seems to have some problems with that.
1595 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1597 2004-01-14 Benoit Regrain
1598 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1599 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1600 * src/*.[h|cxx] : make changes due to class name changes
1601 * gdcmPython/demo/*.py : bug fix due to method names
1603 2004-01-13 Benoit Regrain
1604 * src/*.[h|cxx] : coding style
1605 * vtk/*.[h|cxx] : coding style
1607 2004-01-13 Benoit Regrain
1608 * gdcmPython/testSuite.py : test the readable flag of file for tests
1609 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1610 It's lied to the stl compilation by MSVC (windows, always windows...)
1611 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1613 2004-01-12 Benoit Regrain
1614 * src/*.h : add comments
1615 * src/gdcmDictSet.h : set the method BuildDictPath in public
1616 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1617 directly setted in the source code
1618 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1621 2004-01-09 Benoit Regrain
1622 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1623 * setup.py : use a reference to gdcmVERSION
1625 2004-01-07 Benoit Regrain
1626 * Modification to compile with the distutils.
1629 2003-12-10 Benoit Regrain
1630 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1631 can use a gdcmHeaderHelper to load datas
1632 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1633 made in the source code
1635 2003-12-10 Benoit Regrain
1636 * Update Windows projects and .cvsignore files
1638 2003-11-12 Jean-Pierre Roux
1639 * ENH gdcmHeader constructor has one more parameter (default value : false)
1640 that allows the user to 'go inside' the SeQuences only
1642 gdcmElValSet:Print takes it into account
1644 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1645 * ENH: Update gdcmPython/CMakeLists
1646 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1647 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1649 2003-11-10 Jean-Pierre Roux
1650 * FIX : gdcmHeader::LoadElements is now based
1651 on the ListTag listElem member,
1652 not longer on the TagElValueHT tagHt member
1653 * ENH : PrintPubElVal shows (temporarily) both results,
1654 with the tagHt member and the listElem member.
1655 (it's easier to 'see' the problems when using Printheader)
1657 * FIX : old private member LgrElem is now splitted into
1658 ReadLength : Length actually found on disk (updated only
1659 if bug fixing is necessary), for internal
1661 UsableLength : Updated by FixFoundLength, to fix a bug
1662 or to allow Parser going on.
1663 Will allow to re-write a kosher header when a SeQuence
1664 with a length (not 0000) is found
1665 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1666 because gdcmElValSet::Add does not update ListElem
1669 2003-11-07 Jean-Pierre Roux
1670 * FIX misstyping in Transfert Syntax name table
1671 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1672 when they have an actual length (not 0000 nor FFFFF)
1673 (Nobody should care of it, but DICOMDIR explorers)
1675 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1676 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1678 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1679 * ENH: vtkGdcmReader now supports LUT !
1680 (vtkgdcmViewer for now is not able to use them though)
1682 2003-11-05 Jean-Pierre Roux
1683 * in testSuite.py : new files names for checking the package
1684 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1685 that returns the pixel area size to the *aware* (vtk) user
1686 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1688 2003-11-05 Benoit Regrain
1689 * in testSuite.py : Modify the rules for checking the paths
1690 : Explicit error messages
1691 * in __init__.py : Related modif
1693 2003-11-03 Jean-Pierre Roux
1694 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1695 to be used by aware (vtk) users that want to manage
1696 LUT (and no to turn the PALETTE image into an RGB pixels one)
1697 * GetPixelType now returns 8U for 24 Bits images
1698 (vtkGdcmReader compliant)
1700 2003-10-31 Jean-Pierre Roux
1701 * Removal of *all* gdcmData images and add them again
1702 in order to loose the 'history' of un-anonymised images
1704 2003-10-31 Jean-Pierre Roux
1705 * RMV : removal of useless jBitsInJsample.h
1706 for both 8 and 12 Bits JPEG Lossy Libraries
1708 2003-10-31 Jean-Pierre Roux
1709 * ENH : Add the functions gdcmFile::GetImageDataRaw
1710 gdcmFile::GetImageDataIntoVectorRaw
1711 that act as GetImageData and GetImageDataIntoVector
1712 except the making of an RGB Plane from Gray Plane + LUT
1713 Intended to aware (vtk) users who know how to manage
1716 GetLUTRGBA return a R,G,B,A LUT if any
1717 lgrTotaleRaw gives the 'Raw' length
1718 GetImageDataRaw returns the gray Plane
1719 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1720 (They stay Grey, just like with other Dicom viewers :-(
1722 2003-10-30 Jean-Pierre Roux
1723 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1725 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1726 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1727 being coherents dicom files.
1729 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1732 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1733 * ENH: Two steps is necessary to please VC++ compiler...
1734 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1735 * ENH: Add include dir to medcon lib
1736 * FIX: only one function is being exported for now !
1737 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1739 2003-10-29 Jean-Pierre Roux
1740 * adding gdcmHeader::GetLUTRGBA
1741 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1742 --> Mathieu, the modif u're waiting for is not yet committed
1743 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1745 2003-10-27 Jean-Pierre Roux
1746 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1747 00191113.dcm DermaColorLossLess.dcm
1748 MxTwinLossLess.dcm RadBWLossLess.dcm
1749 * ENH: For version prior to vtkImageViewer2 -r 1.19
1750 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1752 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * Removal of ido stuff in CMakeLists.txt
1755 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1757 * FIX: remove a call to ->Modified ... see comments
1758 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1760 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * FIX: Problem with path for libvtkgdcmPython
1762 * ENH: Try adding a search script for python site-package
1763 * RMV: Remove some file from medcon lib that are not necessary
1764 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1765 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1766 * FIX: More pragma disable fro VC++,
1767 I don't think I break something as it is also disable in VTK/ITK.
1768 But it fasten debug compilation time.
1770 2003-10-23 Jean-Pierre Roux
1771 * gdcm now deals with 16 Bits Run Length Encoded images
1772 (they are compressed as 2 planes images,
1773 one for the high Bytes, the other for low Bytes)
1775 2003-10-22 Jean-Pierre Roux
1776 * Now CheckRead takes into account :
1777 - the bugged 'Leonardo' Siemens images
1778 - the XA images, sent thru the burning VPRO station
1779 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1782 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1783 * FIX: When copying a Makefile.am to CMakeLists.txt
1784 one should remove the '\'
1786 2003-10-22 Jean-Pierre Roux
1787 * in gdcmData adding a bugged 'Leonardo' Siemens image
1788 (wrong lengths in header)
1789 OK with gdcm, KO with the other viewers :-)
1790 * add a GE dlx XA image, thru the VEPRO burning station
1793 2003-10-21 Jean-Pierre Roux
1794 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1795 for a brutal checking of vtkgdcmViewer compliance
1797 2003-10-21 Jean-Pierre Roux
1798 * add the files for 'xmedcon' Jpeg Lossless library
1799 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1801 2003-10-21 Jean-Pierre Roux
1802 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1804 2003-10-21 Jean-Pierre Roux
1805 * garbage Siemens 'Leonardo' images dealt with
1806 (the patch is easy to remove)
1807 * cosmetic changes to avoid warnings
1809 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1810 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1811 no need to press 'r' now.
1813 2003-10-20 Jean-Pierre Roux
1814 * upgrade of checkRead.sh checkWrite.sh according
1815 to new Jpeg Lossless decompressor
1816 * add US.3405.1.dcm, a genuine RGB medical file ...
1817 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1818 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1820 2003-10-15 Jean-Pierre Roux
1821 * general anonymisation in gdcmData
1822 * adding the 'color files' from
1823 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1824 * adding some well knowed bugged-header images
1825 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1826 waiting for their inclusion in Python testsuite
1828 2003-10-15 Jean-Pierre Roux
1829 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1830 no longer seg faults when file is not found
1832 2003-10-14 Jean-Pierre Roux
1833 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1836 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * TODO: *.in file to genereate a UseGDCM later
1839 2003-10-14 Jean-Pierre Roux
1840 * Some supposed-to-be Dicom Images have no preamble.
1841 OpenFile takes it into account
1842 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1843 * Missing elements added in dicomV3.dic
1844 (just to be affraid : have a look at
1845 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1846 and do it again next year ;->
1848 2003-10-13 Jean-Pierre Roux
1849 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1850 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1851 But there are NOT. It's fixed !
1853 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1854 * FIX: "jpeglib.h" was not found on VC++
1855 * FIX: vtkgdcm was not being installed
1857 2003-10-10 Jean-Pierre Roux
1858 * ENH : OpenFile closes the file if it *really* doesn't look like
1859 an ACR-NEMA / DICOM one.
1860 * FIX : testWrite no longer writes an empty file if the source file
1861 is not gdcm Readable
1862 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1865 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * FIX: CMake generate now documentation
1867 * ENH: out of source doc build !
1868 * ENH: Generate both user and dev documentation
1869 * ENH: Should work on windows too
1870 * ENH: Only one doxygen config.in file is needed
1871 * FIX: make install should be ok now on ùnix plateform
1872 * FIX: PATH to dictionary was wrong (missing /)
1873 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1875 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1876 * vtkGdcmReader is now able to read rgb dicom file.
1877 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1878 * added a gdcmViewer to vtk test, use mouse to control
1879 window level & window width
1881 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1882 * CMake-ification of gdcm, we have now two build system
1883 * FIX: on cygwin Wsock32 doesn't exist
1884 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1886 2003-10-06 Emanuel Ollart
1887 * FIX : compilation process wad broken.
1888 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1890 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1891 * change gdcmViewer -> vtkgdcmViewer
1892 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1894 2003-10-06 Jean-Pierre Roux
1895 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1896 ( e.g : well known GE images with a wrong elem length,
1897 : Philips MRI Images with a wrong Huffman table)
1898 * still to be done : allow the reading of bugged LEONARDO Siemens images
1900 2003-10-03 Jean-Pierre Roux
1901 * Odd length strings are padded with '\0' (not with spaces,
1902 to remain compliant with already defined strings,
1903 like Transfert Syntax UID and others)
1905 2003-10-03 Jean-Pierre Roux
1906 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1907 to allow displaying RGB images (not only by affim ;-)
1909 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1910 * vtkGdcmReader is now able to read rgb dicom file.
1911 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1913 2003-10-03 Jean-Pierre Roux
1914 * A few nasty patches to allow the reading of a lot of nasty images
1915 ( e.g : well known GE images with a wrong elem length,
1916 : Philips MRI Images with a wrong Huffman table)
1917 * still to be done : allow the reading of bugged LEONARDO Siemens images
1919 2003-10-03 Jean-Pierre Roux
1920 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1922 2003-10-03 Jean-Pierre Roux
1923 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1924 to allow displaying RGB images (not only by affim ;-)
1926 2003-10-03 Jean-Pierre Roux
1927 * gdcmFile::GetImageDataIntoVector now
1928 - deals with MultiFrames MultiFragments Run Length Encoded files
1929 - deals with YcBcR (YBR_FULL) files
1930 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1931 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1933 (no sample found :-(
1935 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1936 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1937 Two reasons: - clear things
1938 - third parties acces gdcm through header files, so won't
1939 suffer anymore VC++ complains
1941 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1942 * add argv[1] in testvtkGdcmReader.cxx
1945 2003-09-24 Jean-Pierre Roux
1946 * The lines are now eigthy characters long.for
1947 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1949 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1950 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1951 char* to std::string. Thus, the use of strdup becomes useless. (see
1952 previous commis of Malaterre)
1953 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1954 before the last Malaterre's commit.
1956 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * This commit should fix the Debug building under VC++, the problem
1958 was mainly a mixture of debug and release lib being loaded at startup.
1959 * I also remove a depency to a specific C function: strdup. Because I had
1960 to force the link to msvcrtd (whereas strdup is in libc).
1962 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1963 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1964 located in the gdcmCommon.h file. All use of reference of tha has been
1965 changed to now use the variable GDCM_UNFOUND.
1967 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1969 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1970 Dicom dictionary. The test suite can now be run again. Note:
1971 I'm note very happy with the " (RET)" changes. I believe this
1972 RETAINED comment should be dropped when parsing the dictionary.
1973 - PACKAGER corrected
1975 - AUTHORS updated and now in alphabetical order
1976 * Makefile.am now exports gdcm.dsw for Windoze users.
1978 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1979 * cygwin complains about missing std:: in subdir Test/
1981 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1982 * remove some methods that are now in gdcmHeaderHelper
1984 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * vtkGdcmReader set spacing and origin correctly
1987 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * Fix a few delete/delete[] mismatch
1990 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1992 interpretation to data given by gdcmHeader. For instance there are
1993 heuristics to get informations (look at different places).
1994 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1995 sorting DICOM images based on different strategies.
1996 * modified Makefiles accordingly.
1998 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2000 when building in debug mode
2001 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2002 src/win32/gdcmdll.dsp
2003 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2005 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2006 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2009 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2010 * src/win32/libgdcmjpeg12.dsp was not dos format
2011 * src/win32/libgdcmjpeg12.dsp :
2012 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2013 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2015 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2016 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2018 * src/gdcmFile.cxx : bug fix in affectation type
2019 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2020 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2021 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2022 symbols... future problem ?
2024 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2025 * src/win32/libgdcmijpeg12.dsp was missing
2026 * modified gdcm.dsw accordingly
2028 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2029 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2031 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2032 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2033 commit of JPR (before his hollidays to facilitate our work).
2034 * setup.py : bug fix in code. Modifications made while the last commit
2035 of JPR. The code hasn't been tested before the commit... it's so
2036 useless to make that (for best programmer that is JPR) !!!
2038 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * tagged the current version as Version0_3 (i.e. version 0.3)
2041 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2042 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2043 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2044 * *.dsp : modifications to use new libgdcmijpeg8 library
2045 * setup.py : bug fix on VTKPATH variable
2046 * PACKAGER : adding all concerning windows
2048 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2051 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2052 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2053 test suite reported error.
2054 * PACKAGER file added (describes what a packager must do when
2055 packaging a new release).
2056 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2057 * configure.in: upgraded version number to 0.3.0
2058 * fixing build of rpm (through rpm -ta):
2059 - Doc/Makefile.am exports proper doxygen files
2060 - src/jpeg/libijg8/Makefile.am exports the include files.
2062 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2063 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2064 * src/gdcmHeader.h : formatting code
2066 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2067 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2068 We were obtaining error message from vtk. Now, creation of file list
2069 is made in an internal list to prevent this problem.
2070 Bug fix when output is empty.
2071 Bug fix in update of progress value. Previous commit for this was a bad
2073 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2075 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2076 * src/gdcmHeader.h : added method to get the file name
2077 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2078 files. Added method to remove all files on the input
2079 Added FIXME comment concerning the bad parsing of header made by
2080 ExecuteInformation method (in ExecuteData method)
2082 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2083 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2084 when using make instal.
2085 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2086 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2088 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2089 * setup.py : adding include dir of jpeg lib to compile all sources
2090 * */Win32/*.dsp : JPR fix for windows compilation
2092 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2093 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2095 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2096 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2098 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2099 * setup.py is again effective on un*x (takes into account the
2100 addon of the jpeg library)
2101 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2102 * Doc/Doxy* updated (includes above enhancements)
2103 * INSTALL now points to web documentation
2105 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2106 * src/gdcmHeader.h doesn't make unnecessary reference to
2108 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2110 * src/gdcm*.[cxx|h] :
2111 - to allow compilation with gcc 3.x
2112 -- clean up of STL usage (added explicit usage of std::)
2113 -- small fixes on exceptions.
2114 Note: linking not tested !
2115 - clean of doxygen comments to avoid warnings at documentation
2117 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2118 dependent convertion).
2120 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2121 * Clean up of previous JPR garbage commit (not even commented in the
2123 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2124 - moved all jpeg related files from src to src/jpeg/libijg8, with
2125 addition/modification of Makefile.am and configure.in.
2126 - the testSuite is still brain damage (not guilty).
2128 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2129 * WrapVTK.py : modifications to get correctly vtk source files to
2131 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2132 (FileName -> Filename)
2134 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2135 * vtk/vtkGdcmReader.[cxx/h]:
2136 - UpdateProgress method should now be effective
2137 - removed the limitation on having only images loaded (as opposed
2139 - when building a stack of images/volume, a lesser number of
2140 gdcmHeader and gdcmFile instances should be used (hopefully
2141 accelerating things).
2142 - when building a stack of images/volumes, files which are not
2143 loadable (wrong path-filename, wrong permissions on existing file,
2144 or file not parsable by gdcm) are replaced with a black image
2145 in the stack (for the caller to notice the problem).
2147 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2150 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2151 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2152 between standard library (std) and vtk library (problems are found
2153 under Windows... thanks Windows !)
2155 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2156 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2158 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2160 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2163 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * When compiling with distutils (see setup.py) the C++ compiler is
2165 called with different flags than the default ones (with automake).
2166 In order to fix all those warning, I compiled gdcm with the command
2167 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2168 and went for warning fixes:
2169 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2170 up from unused variables.
2171 - vtk/vtkGdcmReader.cxx: potential bug fix.
2172 * src/gdcmHeader.h: Doxygen warning cleanup
2174 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2175 * gdcmPython/gdcm.i:
2176 - typemaps correction to take into account the systematic replacement
2177 of "using namespace std" with std:: prefix e.g. std::list,
2178 std::string... (cf changes of 2003-05-21).
2179 - gdcmGlob global variable of type gdcmGlobal (defined in
2180 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2181 exported to Python a as cvar.
2182 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2183 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2184 gdcmDictSet.GetPubDictTagNames() and
2185 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2186 C++ static methods).
2187 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2188 with the above changes.
2190 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2191 * setup.py, manifest.in : bug fix under linux
2193 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2194 * Modification of setup.py to compile vtk part too. Then, we have 2
2195 wrappers which must work with same distutils. For that, we have a
2196 generic distutils in distusiltsWrapping.py ; with :
2197 - build_extWrap class to wrap generically all extensions,
2198 - ExtensionWrap base class for all wrapping extension that contains
2200 - Wrapper interface which wrap sources
2201 + In WrapSwig.py we have extension and wrapper for Swig
2202 + In WrapVTK.py we have extension and wrapper for VTK
2203 * MANIFEST.in : modifications to consider vtk directory and new python
2204 files for compilation
2206 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2207 * Added python wrappers of vtkGdcmReader vtk class (see the
2208 source in vtk/vtkGdcmReader.cxx) :
2209 - vtk/Makefile.am now builds a library
2210 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2211 python library (as opposed to _gdcm.so wich are the python
2212 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2213 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2215 - configure.in has an additional flag --enable-vtk that needs
2216 to be set to enable compilation of vtk related code, that is:
2217 + vtk/vtkGdcmReader.so and
2218 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2219 + gdcmPython/vtkgdcmPython.so (see above)
2220 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2221 be read when compressed or when HighBit + 1 != BitsStored),
2222 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2223 the usage of the python wrapper of vtkGdcmReader vtk class.
2224 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2225 * src/*.[h] all occurences of stl classes are now prefixed with
2226 std::, and all occurences of "using namespace std;" where removed.
2227 This is to avoid pollution of global namespace in included files.
2228 Apparently vtk does not avoid this pitfall: when using both
2229 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2230 collision of various stl members (principally cout...).
2231 * gdcmPython/testSuite.py now cleanly removes temprory generated
2233 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2234 comply with above changes)
2236 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2237 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2238 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2239 vtk data structure (an image Flip was required).
2240 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2241 * cosmetic changes in documentation.
2243 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2244 * src/gdcmHeader.cxx: the constructor no longer exits when an
2245 unexisting file is given as argument.
2246 * The subdirectory Data (containing all the images used for the
2247 test suite) is not part of this repository anymore. A new module
2248 containing those images is now available at
2249 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2250 with the name gdcmData.
2251 All the python scripts (including the package initialisation file
2252 gdcmPython/__init__.py) were adapated to take this change into
2253 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2255 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2256 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2257 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2258 demo of the usage of this class.
2259 Compilation of this vtk part is only done when using the --enable-vtk
2260 at configure (or autogen.sh) stage.
2262 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2263 * More memory link related corrections and documentation fixes.
2265 - maximum info is obtained with a command of the form:
2266 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2267 --show-reachable=yes PrintHeader
2268 - the remaining reachable blocks seem to come from the STL
2269 allocation scheme through the usage of map and list. It looks
2270 like this memory cannot be freed but it is not a memory leak
2271 (in fact further invocation to the STL would recollect the
2272 unused memory allthough it cannot explicitely be freed).
2273 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2274 of displaying an image parsed with gdcm and displayed with VTK.
2275 Note: some images don't seem to work e.g.
2276 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2277 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2278 Allthough this weakens the semantics, it is a ditch attempt to
2279 make gdcm more thread friendly.
2281 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2282 * Memory link hunt (by using valgrind through the command
2283 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2284 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2285 gdcmHeader::_dicom_vr.
2286 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2287 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2289 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2291 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2292 * src/Makefile.am now exports all the necessary include files at
2296 * UpdateGroupLength replaced by new one
2299 * UpdateGroupLength re-written using H-Table
2300 (named UpdateGroupLengthNew untill checks are over)
2302 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2303 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2304 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2306 - gdcmHeader::GetPubElValSet removed.
2307 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2308 UpdateGroupLength, WriteElements, Write.
2309 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2310 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2311 carried the same semantics.
2312 - src/gdcmHeaderIdo.cxx changed accordingly.
2313 - gdcmFile::WriteBase now regroups all the codes from previous
2314 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2315 - enum FileType moved to gdcmCommon.h
2316 * src/gdcmHeader.cxx AddDefault trashed
2317 * gdcmGetXSize added
2318 * getimageDataSize now calls gdcmGetXSize
2319 * Test/*.cxx changed to agree with above changes
2321 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2323 (to avoid double call by end user).
2324 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2325 by end user, since gdcmHeader::gdcmHeader now handles it.
2327 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2328 * gdcm/Doc many doxygen changes:
2329 - Doxyfile now has two different versions, DoxyfileUsers that generates
2330 the html.users end users oriented documentation and
2331 DoxyfileDeveloppers that generates the html.developper developper
2332 oriented documentation.
2333 - README changed accordingly
2334 - requirement.txt removed (old design info moved to TODO).
2335 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2336 DoxyMainPage.txt, DoxyPython.txt provide more information.
2337 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2338 be updated by simply regenerating the docs with doxygen and copying
2339 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2340 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2341 all the tests in the form "if (<map>.count() >1)" were removed.
2342 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2343 ill-formed documentation sections.
2344 * src/gdcmHeader.cxx: ditto
2346 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * setup.py fixed for un*x (needed macro for stdint.h)
2348 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2349 un*ces with sh-utils test utility.
2350 * gdcmPython/demo/test.py renamed to PrintHeader.py
2351 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2352 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2353 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2354 * src/gdcm*.cxx JPR's bad inclusion fixed.
2356 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2358 * gdcmPython/demo/test.py changed accordingly.
2360 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2361 * gdcmPython/Makefile.am fixed linking against libstdc++
2362 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2363 * Swig subdir (historical tests of swig version 1.3.17++) removed
2364 * Test/testChangeEntete.cxx some lines commented out in order to make
2366 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2367 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2369 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2370 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2371 hence the user doesn't need this explicit call.
2372 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2373 i.e. LoadElements() call removed.
2374 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2375 - src/Makefile.am declares the proper flag for g++.
2376 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2377 for adding user defined new tags.
2378 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2379 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2380 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2382 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2383 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2384 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2385 src/Makefile.am : the project should properly compile and install
2386 with the autotools, included the python wrappers part.
2387 * gdcm.spec.in : added a spec file for RPM packaging.
2389 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2390 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2392 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2393 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2394 to exported to the environement (see gdcmPython/testSuite.py
2396 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2397 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2398 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2399 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2400 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2402 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2403 * gdcmPython/__init__.py doesn't crash anymore when running in
2404 in InstallMode or PreInstallMode but with an environement given
2405 value of GDCM_DICT_PATH.
2406 * src/gdcmDictSet.[cxx/h] coding style.
2408 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2410 * src/gdcm.h general comments moved to TODO, and README
2411 * src/gdcm.h should now be seen as a user commodity (including it
2412 should suffice to fully use gdcm). It is nowhere including within
2413 any of the kernel files src/*.cxx and src/*.h.
2415 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2417 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2419 * src/gdcm*.cxx only include their corresponding include file
2420 (as opposed to gdcm.h)
2421 * gdcmPython/gdcm.i changed accordingly
2422 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2423 the autogen.sh generated "make snapshot" command to work.
2424 * autogen.sh removed history related references to crea package.
2426 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * distutilsSwigCPlusPlus.py work around some swig portability
2430 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2432 was done in a last ditch attempt to get setup.py _really_
2433 operationnal. The python/gdcmPython layaout add the advantage
2434 of hidding away the python related distutils specific files
2435 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2436 Alas, the src directory was out of scope (i.e. it's relative
2437 position to setup.py was ../src) which made things impossible to
2438 handle (see previous version of python/setup.py). Crossing fingers...
2440 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * python/setup.py now works on Un*x. (harder than I thougth)
2442 * python/distutilsSwigCPlusPlus.py can now have include files
2443 among the list of sources.
2445 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2446 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2447 * modifications in MSVC projects
2449 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * As stated by the first lines of Test/ExceptionAndPython/README, it
2451 looks like we can move back to original usage of exception within
2452 src/gdcm* and hence remove the errno stuff that was introduced
2453 as a quick and dirty fixture of this problem (added to the TODO).
2454 * Doc/Doxyfile configuration file for Doxygen and corresponding
2455 README file for usage added.
2456 * Test/testWrite.cxx added. This new test comes from a split of
2457 test.cxx that is now reverted to its original purpous i.e.
2458 testing the proper parsing of a Dicom related file.
2459 testWrite.cxx concentrates on testing the IO part of gdcm.
2460 * Test/bug1.cxx (containing a bug on WIn32) added.
2461 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2462 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2463 whose purpose is to publish the content of the TagNames of the
2464 Dicom public dictionnary were not accessible without an
2465 instance of class gdcmHeader.
2466 - those methods are now static methods of gdcmDictSet and hence
2467 require no instances at all to be invocated.
2468 - within gdcmDictSet this change required to change some method
2469 to class methods (i.e. are now static) among which SetDictPath
2470 (renamed to BuildDictPath) and LoadDefaultPubDict.
2471 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2472 the above changes by calling the new method classes of gdcmDictSet.
2473 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2474 the above to be effective.
2475 * python/gdcmPython: in order to wrap properly the above changes
2476 for Python, swig version now needs to be > 1.3.17.
2477 * python/gdcmPython/Makefile fixed to adapt itself to new
2478 configure/make shema introduced by Johan Montagnat (thanks for the
2479 contribution). Alas this Makefile cannot be turned into a proper
2480 Makefile.am without some heavy changes in the configure.in
2481 (for python dectection).
2482 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2483 now avoids publishing the empty entries.
2485 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2486 * python/setup.py : bug fix concerning install under windows
2487 ExtraPath reused :-P
2488 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2490 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2491 * Dicts/dicomV3.dic : remove double spaces !!!
2492 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2493 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2496 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2497 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2498 method. Doxygenation.
2499 * src/gdcm.h clean up of JPR spurious comments.
2501 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2502 * python/distutilsSwigCPlusPlus.py now properly collects the
2503 shadow classes generated by "swig -c++" (gdcm.py in our case)
2504 when using "python setup.py install".
2505 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2506 reexports the working classes.
2507 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2508 by the classical C errno scheme. This is to prevent an obscure
2509 behavior of the python wrappers when importing wxPython.wx prior
2510 to gdcmPython (which ended up in an abort call). An illustration
2511 of this oddity can be found in the Test/ExceptionAndPython
2512 subdir (see the README file). This problem probably due to
2513 an combination of g++ and dynamic loading.
2514 * added Test/ExceptionAndPython (see above)
2516 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * Changed the layout of the python part to avoid bloating main
2518 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2519 i.e. the distutils arsenal. All the python related stuff is
2520 again in a python subdir, but the package itself is now in
2522 * setup.py was cleaned up:
2523 - pythonIncludePath removed
2524 - python setup.py bdist target is now functional.
2525 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2526 collision with other packages). gdcmPython/demo/*.py changed
2529 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * python subdir moved to gdcmPython (preparation of distutils packaging).
2531 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2532 distutils installer is operational.
2533 * - gdcmPython/__init__.py now properly loads the swig generated
2534 shadow classes (from gdcm.py).
2535 - gdcmPython/demo/*.py changed to import the package gdcmPython
2536 instead of gdcmPython/demo/load.py.
2537 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2539 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2540 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2541 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2542 entries within the associated public Dicom dictionary resp. the same
2543 information but sorted by the fourth field (PAT, IMG, DIR) of the
2545 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2546 are now in the "???" group.
2547 - python/gdcm.i changed accordingly,
2548 - python/demo/printGroupedPublicDict.py added, that gives an example
2549 of the above new functionalities in Python.
2551 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * src/gdcm.h, gdcmHeader.cxx:
2553 - historic references to glib's g_malloc and g_free (#defined)
2554 were definitively removed.
2555 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2556 * src/gdcmElValSet.cxx:
2557 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2558 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2559 - GetElValue(string) renamed to GetElValueByName.
2560 - Added GetElementByName(string).
2561 * src/gdcmHeader.cxx: added
2562 - GetPubElValRepByNumber(guint16, guint16)
2563 - GetPubElValRepByName(string)
2564 - GetShaElValRepByNumber(guint16, guint16)
2565 - GetShaElValRepByName(string)
2566 - GetShaElValByNumber(guint16, guint16)
2567 - GetShaElValRepByName(string)
2568 - GetElValRepByNumber(guint16, guint16)
2569 - GetElValRepByName(string)
2570 - GetElValByNumber(guint16, guint16)
2571 - GetElValRepByName(string)
2572 * Doc/requirements.txt added.
2574 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2575 * Test/Makefile building now depends on the one of libgdcm.so
2576 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2577 pixel data) aware which enables finding the address (offset) of
2578 the pixel data of JPEG encoded DICOM files. This leaves only a single
2579 file in the testSuite whose pixel data address (offset) is unknown.
2580 * python/testSuite.py changed accordingly.
2582 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2583 * VC++ has some strong limitations when working with the STL, as stated
2584 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2585 "Also note that some STL containers (map, set, queue, list, deque)
2586 cannot be exported. [...]
2587 Some STL classes contain nested classes. These classes can not
2589 This is caused by a designed limitation that once a template
2590 class is instantiated, it can not be re-instantiated and
2592 Since our usage of map<> is ubiquitous in gdcm, this "designed
2593 limitation" of VC++ is a pitfall.
2594 Hence the Python wrappers of gdcm cannot be incrementally linked
2595 against the c++ dynamic library. The dirty but only workaround is
2596 to forget about incremental link of dynamic libraries and to generate
2597 the Python wrappers library with the inclusions of the underlying C++
2599 The following modifications concern this matter on Win32/VC++:
2600 - wrapping python correct with standalone wrapped dll (don't use separate
2601 dll under windows !!!!)
2602 - python21_d debug mode enabled (ask Frog how to use it :-)
2603 - NO problem with having an STL member of class for example string in C++
2604 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2605 - Python test of dcmlib in Python is ok under windows on a large set
2607 * removed glib references
2608 * typedef's inserted in gdcm.i for correct swig type management
2610 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * python/demo/*.py load.py extracted from test.py. Added explore.py
2612 that only displays required tags and testAll.py that parses all
2613 the files of the testsuite without using unittest.
2614 * python/testSuite.py other additional test on new files added.
2615 * Data/* new test files added accordingly to the testSuite.
2616 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2617 the vr in the file differs from the one of the dictionary.
2619 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2620 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2621 values, but limits itself to values which are below a user specified
2622 size (by default 1024 bytes).
2623 * python/gdcm.i : elements not loaded (because their size is above the
2624 user specified treshold) are exported with their TagKey as key of the
2625 python dictionary. This enables the testsuite to make some checks
2626 on the unloaded elements (since we have their offset and size).
2627 * python/testSuite.py
2628 - now tests for the existence and proper value of the pixel data
2629 - two new examples added.
2630 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2632 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2634 aware. See the strategy comments in gdcmHeader::FindeLength().
2635 * Test/test.cxx now accepts a filename as first argument.
2636 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2637 * python/testSuite.py changed to integrate test on above files.
2639 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2640 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2641 the vr was also RET.
2642 * python/testSuite.py more tests added.
2644 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * python/testSuite.py unittest test suite added (uses Data)
2646 * Data/* dcm and acr files for the test suite.
2647 * glib dependance removed from un*x version. We now use ISO C99
2648 7.18 Integer types (see stdint.h)
2649 - python/Makefile, src/Makefile src/gdcm.h
2650 * src/ when an explicit vr (like dicom files) suddenly poped an
2651 implicit element we use to mark the underlying DictEntry of the
2652 concerned ElValue with "Implicit". This strategy was damageable
2653 too the public or provite dictionaries, since some of their vr
2654 would be changed. Since Header::FindLength heavily relies on the
2655 detection by Header::FindVR of falsely explicit elements, I
2656 added an extra ImplicitVr member to ElValue (boolean).
2657 The rest of the changes we the necessary adaptations.
2659 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2662 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2664 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * Adaptation for porting to VC++:
2667 o forced to use std namespace (for string to be known)
2668 o all class use __declspec export style on WIN32
2669 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2670 (in stdlib.h on Win32 but in std:: for gcc)
2671 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2672 variable GDCM_DICT_PATH.
2673 * src/gdcmHeader.cxx verbose comments made discrete.
2675 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * python/gdcm.i: added a typemap that converts a C++ hashing table
2677 to native Python dictionary.
2678 * python/demo/test.py:
2679 - now uses the native dictionary for exploration of gdcmHeader.
2680 - takes an optional filename argument (the file to parse).
2681 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2682 PubElVals hashing table.
2683 * Dicts/dicomV3.dic removed error prone trailing spaces.
2685 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * Python wrapping process moved away from src/Makefile to
2687 newly created python/Makefile (as well as gdcm.i)
2688 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2689 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2690 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2691 from the environement variable GDCM_DICT_PATH (when existing).
2692 * src/gdcmDict::GetTag bug fix.
2694 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * Straightforward temporary fixes for swig to build the python wrappers.
2696 src/Makefile now has a python working entry [by working we mean
2697 that we can import de shadow classes without errors].
2699 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * hashtest.cxx removed (since allready in Test)
2701 * src/gdcmlib.h renamed to src/gdcm.h
2702 * src/dcm.i renamed to src/gdcm.i
2703 * src/Makefile prepared for python wrapping
2705 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * src/gdcmHeader.cxx :
2707 - Parsing of header is now separated from loading of element values
2708 (see gdcmHeader::LoadElements).
2709 - general clean up of hopefully all file access (creation of
2710 ReadInt16 and ReadInt32)
2712 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcmHeader.cxx :
2714 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2716 - SetLgrElem renamed to SetLength
2717 - GetLgrElem renamed to GetLength
2718 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2719 * src/gdcmElValSet.cxx fixed both GetElValue methods
2720 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2721 due to IdoDude was cleaned out.
2723 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2724 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2725 concentrates on finding the value representation (when it exists).
2726 RecupLgr now only finds the element value length, and it avoids
2727 returning the unecessary skL (skipped length).
2728 Also, offsetCourant was simply removed (with taille_fich) since
2729 it was redundant with the File position internals (by using
2730 ftell and fseek). This also made skL (see above in RecupLgr) usage
2732 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2733 on the libido specificities which are handled through class
2735 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2738 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * Truckload of changes. Parsing of header is barely functional
2740 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2742 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2743 * src/gdcmHeader.cxx many addons of low level methods
2745 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2746 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2747 and _IdDcmSWAP_LONG.
2749 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * This corresponds to all the changes decided at the meeting of
2751 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob