1 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Bug fix due my last commit (compilation under Windows).
3 * Example/Volume2Dicom : bug fix in the file and reformatting source code
5 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
7 - Remove printf / sprintf
8 - include iostream AFTER gdcm so we don't get warnings
9 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
11 - Also remove tons of include from header files, hopefully this should
12 speeup the compilation time, since it was becoming a dog slow.
13 - Remove gdcm.h as it include way too many files and slow down compilation
14 (plus it is not up to date)
15 - remove 'using namespace std' this is BAD !
17 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * Remove memory leaks on the DicomDir
19 * Remove some useless datas in DicomDirObject
20 * Add usefull methods in SQItem, to be complient withe the ElementSet
22 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
25 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
27 future, with convertion)
28 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
29 and ImageDataSize values. Remove the method to get the PixelReadConverter
30 from the output of the class
32 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
35 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
37 and vtkErrorMacro use.
38 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
40 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
43 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
44 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
45 The string leaves only in the fonction. So when we make a .c_str(), we
46 get the pointeur on the first element, element that will be destroyed
47 immediately after thee instruction.
48 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
49 file has been opened : the test must be made on the content of the
50 pointer and not directly on the pointer !
53 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
55 the python part recompiles
57 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
59 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
60 X session is killed (for my computer... it seems to not be identic on
63 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
65 avoid problems (otherwise, the difference test between the visible image
66 and the reference is incorrect. If the reference is greater than the
67 screen resolution, it's produce errors).
68 Can be used for only one image. Can be used with a visible flag.
69 * vtk/vtkGdcmReader.cxx : remove commented codes.
70 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
71 under windows at compilation
72 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
74 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
76 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
78 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
79 tests on the image size X, Y, Z
81 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
83 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
84 between the class name and the file name
86 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/ : fix compilation warnings for the Write method (2 different
88 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
89 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
90 variable... create a static method in gdcm::Document to access to
91 this variable content.
93 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
95 file, to be accessed by other files (like gdcmFile). Remove commented
96 code. Move the change of the header to the gdcmFile, using the
98 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
99 To be sure of that (and simplify calls), the Write of the header now
100 gets a file name and not a file pointer (std::ifstream).
101 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
102 DocEntryArchive. Remove all open of the written file
104 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
107 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
109 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
111 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
112 some corresponding methods. Write correctly the file and check before
114 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
115 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
116 is now on RGB datas (as before my last commit
117 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
119 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
121 Add a print information of the type of the entry
122 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
123 It was in the gdcmFile, and all write have been regrouped
124 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
125 Write correctly all dicom files (in decompressed mode only at this time)
126 * Test/ : test on files are now made using Raw datas and not color datas if
128 * Example/PrintFile.cxx : add more printings
130 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Amelioration of code, remove some code copy. For the loading of
132 BinEntry (in gdcmDocument), add the test to verify if the file is already
135 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
137 remove a DocEntry in the header (push an empty DocEntry)
138 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
139 lines. Bug fix in the initialization of the PixelConvert and the
141 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
142 use in TestCopyDicom (now this test can run under windows... but fails)
143 * Test/TestCopyDicom.cxx : amelioration of the test :
144 - test the pixels written
145 - add test points to quickly find where is the error
146 - can set a file name input and output in arguments
147 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
148 amelioration of the test output
150 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
152 all replaced DocEntry's
153 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
154 Now, each needed DocEntry to modify is duplicated, modified and inserted
155 to the header using DocEntryArchive. Thus, after save, we can restore the
156 header initial state.
158 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
161 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
163 correct to copy it. The DictEntry is specified at the DocEntry creation,
164 then, it musn't change in the time.
165 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
166 header correctly. At this time, the change is only made for the first
167 level of the Document. In the future, it might consider sequences.
168 The change is made by replacing a DocEntry by an other that is created
169 outside the class. The old value is kept. When we restore the header
170 status, the added DocEntry is deleted and replaced by the old value.
171 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
172 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
173 set the write type to explicit VR, implicit VR or ACR. Add methods to set
174 the write mode to native, decompressed or RGB (but not used at this time)
176 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
178 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
180 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
182 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
184 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
185 set because already copied when copying the BinEntry's of the header
186 * Test/TestAllReadCompareDicom.cxx : remove warnings
188 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
189 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
190 Two problems appear when doing it :
191 - with the gdcmFile : when the GetImageData method is called, the pixels
192 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
193 datas (pixels). And each structure destruct the datas when it's
194 destructed. So we have two destructions for the same datas. To solve it,
195 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
196 datas or not. If it doesn't own datas, then they will not destroyed by
198 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
199 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
200 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
201 create a double destruction of the same DocEntry's. So, to solve it,
202 the TagHT is simply cleared and the DicomDir* elements are destroyed.
203 * TODO : add an entry concerning memory leaks in the DicomDir
205 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
207 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
210 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
212 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
213 after it have been deleted
215 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
216 * FIX: src/* fix the doxygen warnings.
217 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
218 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
219 was erroneously defined with a size of 15 instead of 16. [many thanks
220 to Jean Michel Rouet for pointing out this bug].
222 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
223 1. Finish merging JMR patch for writting DICOM from scratch
224 2. Fix -hopefully- bug with MONOCHROME and space vs null character
225 3. Use const ref when possible
226 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
227 5. A few more comments
228 6. CreateUniqueUID can now be called without parameter"
230 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
231 * ENH: Slightly bigger patch:
232 1. Getting toward full integration of JMR patch for writting dicom from scratch
233 2. Update Test to test part of this patch: CreateUniqueUID
234 3. File was not close properly in gdcmDict
235 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
236 5. Use of const ref instead of copy (speed issue)
237 6. Remove temporary (duplicate) string in TranslateToKey
238 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
239 8. Do not repeat virtual in subclasses
240 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
242 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
243 * Apply first patch toward better string comparison when dealing with broken
244 DICOM files. Essentially the string could be padded with a space instead
245 of a null character as defined by standard
247 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
249 because never used... and in the same time, that's remove some memory leaks
251 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
252 * src/gdcmFile.cxx : now delete the PixelConvert instance.
253 * In examples and tests : change the type of image data variables from void*
254 to uint8_t*. Remmove all delete on image data variables
256 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
258 Verify the file pointer value before open the file, and if it's not null,
259 a verbose message is generated.
260 Close correctly the file when the file isn't considered dicom-like. The
261 correctly close is a call to CloseFile.
262 When closing the file pointer, test if its not null to close the file.
263 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
264 file. For an uncompressed image, the copied datas correspond in the least
265 case to the image size (calculated) or the image size specified in the
266 header. A verbose is generated if these two size mismatch
268 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
269 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
270 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
271 break under windows (with msvc6 compilation).
273 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
275 compiling with MSVC6)
277 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
278 * Bugs fix for the Windows build with VC6
279 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
280 needed (only for projects required VTK). If the VTK is included in all
281 projects, there is conflicts with the jpeg lib of vtk when compiling the
282 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
283 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
284 when compiling the gdcm_wrap.cxx file (created by the compilation of the
286 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
287 (like it's already made for the cout use). Otherwise, conflict with the
290 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
293 - comments on the DicomDir::Method related usage added.
294 - now that we use the namespace gdcm, a lot of internal classes do
295 NOT need to be wrapped anymore.
296 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
297 DicomDir::Method) new example added.
299 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
300 * Improve string manipulation. I now inforce the notion of 'DicomString'
301 A DicomString can contain as many \0 as they want
302 and it is *always* of even length.
303 We only support odd length for very rare case.
304 And in the near future this should be removed.
306 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
307 * /binary_write/ gdcm source. Now even on big endian we are writting
308 little endian. This should -heopfully- fix some tests
310 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * Now the dictionary is compiled into gdcm lib. This is a default
312 behavior, thus any dic file specified is picked before failback to
313 the one comiled into lib
315 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * Change internals for gdcmDict. Don't use any 'new' any more.
317 This should definitely solve any leak problem, and we should be
318 as fast as before, as long as don't modify too much the dictionary.
320 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 * STYLE: ivars should start with a capital letter.
322 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
323 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
325 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
326 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
327 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
328 new 2004 dictionaries added (thanks to JPR).
329 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
330 * CLEANUP_ROUND (15) for gdcmPixelConvert
331 - RLEFrame::NumberFragments is now of type unsigned int
332 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
333 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
336 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
337 * Initial work in gathering all transfer syntax accessors. clearly
338 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
339 ivars, but only one transfersyntax (class) ivar with equivalent method on
342 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
343 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
344 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
345 discussed (plus I didn't like having a 2000 lines patch not commited)
347 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
349 * CLEANUP_ROUND (14) for gdcmPixelConvert
350 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
351 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
352 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
354 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
355 anymore and hence avoids storing a copy of PixelConvert::Decompressed
356 into File::Pixel_Data.
358 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
360 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
361 * CLEANUP_ROUND (13) for gdcmPixelConvert
362 Substituted File::ParsePixelData() with PixelConvert::Print() new
364 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
365 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
366 method to those classes.
367 - src/gdcmFile.[cxx|h]:
368 -- Added a ::Print() method.
369 -- PixelConverter is now a reference instead of a member.
370 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
371 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
373 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
375 collaboration diagram and inheritance diagram should be generated with
377 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
378 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
379 pointlessly wrapped (see
380 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
381 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
382 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
383 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
384 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
385 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
386 -- File::Initialise: PixelConverter setup moved away to
387 PixelConverter::GrabInformationsFromHeader()
388 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
389 interpretation moved away to PixelConverter::BuildRGBImage()
391 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
392 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
393 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
395 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
397 displayed on Win32 when a brutal abort() occurs (because of uncatched
398 exception). See TODO new entry of this commit for more on this.
399 * TODO added new entry.
400 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
401 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
402 - HandleColor is no longer called from gdcmFile.cxx
403 - gdcmPixelConvert.cxx clean up on method arguments and internal
404 variable names for semantical coherence.
406 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
407 * Finished lossless transition, not only do we now read all lossless jpeg
408 images, without the need of the Cornwell lib, but we do read them properly now
409 * To reduce code (well to avoid code duplication), I defined a common place
410 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
411 redefine symbols. This is not prefect but this the best solution I found for a
412 compilation time jpeg option.
414 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
415 * Update jpeg ijg lib to support lossless jpeg implementation
416 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
418 * Also added a special copyright for dcmtk since we use their bugfixes.
421 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
423 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
424 matters, as stated in warning note at begining of %include section).
425 * src/gdcmDicomDir*.[cxx|h]: coding style
426 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
427 * src/gdcmJpeg8.cxx: doxygen fix.
428 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
429 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
430 from File:: to PixelConvert::.
432 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
434 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
435 - more code moved away from File:: to PixelConvert::
436 - fat setup of PixelConverter set in place in File::Initialise.
438 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
439 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
440 namespace at the file system level. So now you should convert your examples
442 gdcmHeader -> gdcm::Header
443 It would be nice if people keep in mind to no open the namespace, since it
444 allows compilation on broken plateform which were defining common symbol in
445 the standart namespace (like LP, Unknown ...)
447 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
448 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
449 The JPEG fragments are now parsed at the same stage than the RLE
450 information. All code related to JPEG is now in gdcmPixelConvert:
451 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
452 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
453 export a gdcmFile:: method. Those are simply global functions
454 (for the time being this is better than having them attach to
455 either gdcmFile:: or gdcmPixelConvert::).
456 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
457 and stores the result in a gdcmJPEGFragmentsInfo.
458 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
459 code (among other stuff) moved away from gdcmFile:; to
462 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
463 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
464 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
465 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
466 clean up of RLE related code.
467 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
468 - src/gdcmRLE.cxx removed
469 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
470 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
471 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
472 * CLEANUP_ROUND (9) for gdcmPixelConvert
473 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
474 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
475 away from gdcmFile:: to gdcmPixelConvert::.
477 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
479 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
480 This is because Parse7Fe0 used to parse the pixels to compute the
481 length. This task was passed over to FindDocEntryLengthOB() a long
482 time ago, EXCEPT I had forgotten the OW case...
483 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
484 we just recylce the code for parsing RLE fragments and computing
486 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
487 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
488 with the retired Parse7Fe0().
489 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
490 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
492 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
493 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
494 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
495 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
496 - src/CMakeLists.txt: alphabetic order reodering + new entries.
497 * CLEANUP_ROUND (4) for gdcmPixelConvert
498 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
499 to return an unused length.
501 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
502 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
503 this should be cleanner from the plane view. The iostream are erally a pain
504 to use to do simple stuff.
506 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
507 * Redo the compilation of the ijg jpeg library. Now only one source is
508 necesseray. No need to rename file by hand what so ever. CMake handle the
509 copying of the file within different directory, configure header file to
510 modify some symbol. The only addition made to ijg wasd a mangle table so
511 that symbol are different wether we are within 8bits or 12bits.
513 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * Added documentation of vtkgdcmReader on Website:
515 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
516 with it's binary name).
517 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
518 the Website to be more complete.
519 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
520 doxygenated documentation.
521 - Doc/DoxyVtkGdcmReaderExamples.txt added
522 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
523 DoxyVtkGdmReaderExamples.html )
524 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
525 * CLEANUP_ROUND (3) for gdcmPixelConvert
526 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
528 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
529 * CLEANUP_ROUND (2) for gdcmPixelConvert
530 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
532 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * CLEANUP_ROUND for gdcmPixelConvert:
534 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
535 - src/gdcmPixelStuff[h|cxx] removed
536 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
537 - src/CMakeLists.txt changed accordingly
539 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
540 gdcmVersion.py moved to newly created ATTIC related
541 gdcmPython/SetupOldies/ directory.
542 * Autotools clean up:
543 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
544 - autogen.sh configure.in acinclude.m4 python.m4 removed
546 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * src/*.cxx *.h Reference to License.htm fixed to License.html.
548 * Doc/CMakeLists.txt, doxygen.config.in: fix.
549 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
551 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * TODO updated with Mathieu suggestions. I proposed a template for
553 describing TODO entries and used it for new entries.
554 * Added Doc/Website/CodingStyle.html, Developpers.html,
555 DeveloppersPython.html, GdcmDataCvs.html and
556 DownloadVersion0_1.html, DownloadVersion0_3.html.
557 * Some Doc/*.txt Doxygen files (which do not really concern the
558 documentation itself, but the website) moved to html and
559 placed in directory Doc/Website:
560 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
561 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
562 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
563 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
564 * CMakeLists.txt changed accordingly.
565 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
566 DeveloppersPython.html
567 * INSTALL nows refers to Doc/Website/Installation.html
569 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
570 * Added Doc/Website directory, that contains a first raw version
573 2004-09-23 Jean-Pierre Roux
574 * FIX In order not to be poluted any longer by casting problems,
575 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
576 we can now delete[] it safely
577 * VoidArea is now called BinArea (less confusing name),
578 and all the methods called ...VoidArea... are now ... BinArea...
579 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
581 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
583 clear) TagHT, which is an inherited member of gdcmElementSet. It is
584 up to the destructor of gdcmElementSet to clean up TagHt and it's
587 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * Test/CMakeLists.txt: update to follow gdcmData renamings.
589 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
591 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * ENH: added some utility method that builds a flat dictionnary
593 holding all the Dicom entries contained in the recursive structure
594 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
596 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
597 BuildFlatHashTable() that build a flat dictionary.
598 - src/gdcmElementSet.h: added a new private GetTag() accessor.
599 gdcmDocument is now a friend of gdcmElementSet.
600 - src/gdcmElementSet.cxx: clean up.
601 - Example/FlatHashTablePrint.cxx added.
602 - Example/CmakeLists.txt changed accordingly
604 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
606 moved away from gdcmDocEntrySet (since this class is an abstract class
607 acting like an interface). SQDepthLevel and BaseTagKey are now
609 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
610 and associated accessors. Doxygenation of the class.
611 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
613 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
614 Use SQDepthLevel accessor instead. ::Print() adapted.
615 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
616 - src/gdcmDocument.cxx changed accordingly.
618 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
619 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
620 - The following is the doxygen comment of the typedef declaration
621 of gdcmagKey in src/gdcmCommon.h:
622 gdcmTagKey is made to old an "universal" (as in URL, Universal
623 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
624 A dicom tag allways has a group and an element, but a set of tags
625 embeded in various (optionally nested) sequences and sharing
626 the same group and element all share the same (group, element)
627 "identifier". Hence the (group, element) cannot be used as an
628 identifier (in gdcm we shall refer to a "TagKey") of a tag.
629 In order to construct a proper tag identifier (i.e. a key) we
630 consider the following definition of a TagKey:
631 - let Group, Element be the string representation of the
632 group and element dicom tag members,
633 - let ItemNumber be the string representation of the integer
634 index of the considered item number of a sequence,
635 Let the key of a tag embeded in a sequence, noted SeqTag, be
637 /ItemNumber#Group|Element
638 where "/", "#" and "|" are characters acting as separators.
639 Then the general form of a gdcmTagKey is given by:
640 Group|Element<SeqTag>
641 where <SeqTag> means NO or many instances of SeqTag.
642 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
645 but the gdcmTagKey of a tag "embeded" is the first item of
646 a sequence, itself nested in the third item of a sequence is the
648 0004|1220/2#0008|0082/0#0008|0090
649 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
650 order to hold the new sequence compatible key. Previously, the
651 GetKey() method would look in the underlying gdcmDictEntry.
652 - src/gdcmDocEntry.cxx:
653 -- constructor now copies the underlying DictEntry key, in the local
655 -- ::Print: displays the member Key, instead of the (group, element).
656 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
657 - src/gdcmDocEntrySet.h:xi
658 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
659 -- now has a new BaseTagKey member.
661 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
662 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
664 This poses the problem with the semantics of the following lines
665 LoadEntryVoidArea(0x0028,0x1201); // R LUT
666 LoadEntryVoidArea(0x0028,0x1202); // G LUT
667 LoadEntryVoidArea(0x0028,0x1203); // B LUT
668 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
669 to the long FIXME note for what the problem is. Nevertheless in
670 order to get things working the dicom dictionary was altered !
671 Please fix things urgently...
672 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
673 information), see above note on moving the member VoidArea. Nevertheless
674 the following entries previously correctly set as US are now inproperly
676 0028 1201 OW IMG Red Palette Color Lookup Table Data
677 0028 1202 OW IMG Green Palette Color Lookup Table Data
678 0028 1203 OW IMG Blue Palette Color Lookup Table Data
679 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
680 of gdcmDocEntry moved to gdcmSeqEntry.
681 * src/gdcmSeqEntry.cxx: STYLE.
683 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
684 * Test/TestAllEntryVerify.cxx minor fix and added comments.
686 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * gdcmPython/testSuite.py: all the test suite in python is now moved
688 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
689 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
690 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
692 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
693 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
694 to avoid inclusion recursion until STL is reached.
695 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
696 mecanism. errno.h is not included in gdcm anymore.
697 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
698 (gdcmFormatError now inherits from gdcmFormatUnexpected).
700 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
701 gdcmData/TestAllEntryVerifyReference.txt
702 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
703 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
704 exception_on_error parameter.
705 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
706 - vtk/vtkGdcmReader.cxx changed accordingly,
707 - Example/*.cxx and Test/*.cxx changed accordingly.
709 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
711 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
712 enable_sequences removed from gdcmHeader constructor and dependencies.
713 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
714 * gdcmPython/demo/PrintHeader.py: dummy fix.
715 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
716 skip_shadow removed from gdcmHeader constructor and dependencies.
717 * Example/*.cxx and Test/*.cxx changed accordingly.
719 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
721 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
723 2004-07-21 Jean-Pierre Roux
724 * FIX Now, Parsing and Printing a DICOMDIR do work!
725 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
727 2004-07-20 Jean-Pierre Roux
728 * FIX Some brain damaged headers have Zero-Lenght fields
729 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
731 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
732 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
733 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
734 variable (instance of gdcmDebug) by a definition macro, and the instance
735 is now in static in the gdcmDebug class
736 * src/gdcmSQItem.h : (FIXME) remove an undefined method
737 * Test/PrintAllDocument.cxx : bug fix in the result of the test
739 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * WARNING: ctest now depends more tightly on gdcmData. You should
741 check out gdcmData properly for things to run smoothly...
742 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
743 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
744 we need the pixels not be loaded in order to use the ValEntry
745 that displays position and size).
746 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
747 This is a C++ based equivalent of gdcmPython/testSuite.py that should
748 be deprecated. If you have any doubts about the advantages of a
749 modern scripting language (read Python) versus grass root C++ (i.e.
750 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
751 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
752 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
753 Anyhow, consider documenting the gdcmData images in
754 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
756 * Test/CMakeLists.txt:
757 - now uses TestAllEntryVerify.cxx
758 - specific comments on oldACR00001.ima (now renamed in gdcmData
759 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
760 gdcmData/TestAllEntryVerifyReference.txt
763 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
764 * src/*.[h|cxx] : typedef clean up
765 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
766 - TagKey renamed to gdcmTagKey (for external usage)
767 - VRKey renamed to gdcmVRKey (for external usage)
768 - removal of typedef duplication.
769 - Removed all unecessary inline keyword from class inline definitions.
770 - Some method|function(void) declarations replaced with method|function().
771 * src/jpeg/libijg12/jdhuff12.c:
772 - printf polluting ctest removed.
773 - TAB removal for comminting
775 - TestAllReadCompareDicom.cxx: added a test that compares all the
776 images in gdcmDataImages.h with corresponding images in
777 gdcmData/BaselineDicom/. When baseline images are not present
778 this test creates them.
779 Note: we need to validate each reference image, but before that
780 I'd like to rename them with a more explicit name...
781 - CMakeLists.txt: changed accordingly.
782 * Example/*.cxx: examples now only include gdcm.h (as opposed to
783 including each header needed).
785 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
786 * Test/*.cxx and Example/*.cxx: moved some examples away from the
787 test suite to the Example directory. Are concerned:
792 - TestWriteSimple.cxx
793 * Test/CMakeLists.txt: added some comments on reasons for black listing
794 image gdcmData/oldACR00001.ima
796 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * Test/CmakeList.txt: removed the following from black list (to be coherent
798 with removal from gdcmData):
799 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
800 - gdcm-MR-PHILIPS-16.dcm
802 Added the following because after last cvs update, they cause
803 ctest -R TestReadWriteReadCompare
805 - gdcm-MR-SIEMENS-16-1.acr
807 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
808 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
809 new comments in this file) we temporarily (sigh) move to a weaker
811 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
812 we don't need to black list the following images anymore:
813 - 8BitsUncompressedColor.dcm
815 - US-PAL-8-10x-echo.dcm
816 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
817 fixes and the beautified code ;-)
818 This fixes the bug introduced in version 1.42 (when beautifying)
819 that made the parsing of 8BitsRunLengthColor.dcm unproper.
820 Note: ctest was blind to this bug (this means we need to still
821 improve the test suite). The bug could be detected by using
822 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
824 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
825 and by displaying the (garbage) produced file temp.XDCM...
827 2004-06-29 Jean-Pierre Roux
828 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
829 - replace by uggly but working old code :-(
830 A lot of things should be OK again.
831 It's really urgent to have a test suite that *tests*,
832 to prevent Frog's beautifying sessions to break all the stuff
833 (twice, withing a fortnigh ...)
835 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
837 redundancy) to added Test/TestReadWriteReadCompare.cxx
838 * Test/CmakeList.txt: because the compare test of
839 Test/TestReadWriteReadCompare.cxx fails, the following images are
840 black listed: - 8BitsUncompressedColor.dcm
842 - US-PAL-8-10x-echo.dcm
843 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
844 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
845 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
846 and ad-hoc kludge. This kludge is now removed, and on encountering
847 such an image (OB field brain damaged) we set errno. Then in
848 ::FindDocLength() we "fix" the length as being ALL what remains
849 in the file (until EOF). We then proceed, hoping for the best...
850 This fixes a SegFault in ShowDicom when trying to write such an
852 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
853 (because TestWriteRead breaks on it, after a non conformal commit?).
854 ctest now runs properly, except for MakeDicomDir (which was allways
855 broken) and the Python related stuff (still not fixed).
857 2004-06-24 Jean-Pierre Roux
858 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
859 FIX : Test/TestReadWrite now iterates on all the file names
860 (instead of infinite loop)
861 ENH : Test/TestWriteRead now iterates on all the file names
863 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
866 2004-06-24 Jean-Pierre Roux
867 FIX : - now Write drops LUT Descriptors and LUTs (if any)
868 when SamplesPerPixel =3
869 - now Write is no longer confused by
870 'BitsAllocated = 12" and 'BitsStored=12"
871 - "UN" value representation Elements are now written correctly
872 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
873 ENH : - now gdcmHeader has its own Write methods
874 (in order to split the job that has not to be done
877 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
878 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
879 loop on the same image until memory went out.
880 Note: this means we still have gobs of memory loss in PrintDocument
881 * src/gdcmDocument.cxx: fixes problem on parsing on file
882 gdcmData/16BitsJpegLosslessGrayScale.dcm.
884 2004-06-24 Jean-Pierre Roux
885 FIX : Write - All the Sequences and Sequence Item are now written
886 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
887 is added a the end, when necessary.
888 - A lot of brain-damaged images, that were read correctly are
889 now written correctly
890 - length compatible BinEntry are now loaded correctly
891 (even for odd groups)
892 Note : only Explicit Value Representation was checked.
893 (question : is implicit VR really necessary for gdcm ?)
895 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * DEVELOPPER: added a proposition of coding style.
897 * src/gdcmDocEntry.h: removed every inline declaration (for test of
900 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
901 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
902 Use the gdcmDocEntry::Print() and Write() instead.
903 * src/gdcmDocument.cxx: bug fix.
905 2004-06-22 Jean-Pierre Roux
906 FIX : gdcmDocument.cxx
907 - Now we do recognize the JpegLossLess format (there was a misstyping in
908 code 'beautyfication' :-(
909 - Now we automaticaticaly load the Luts, if any
911 2004-06-22 Jean-Pierre Roux
912 In order : to write Sequences, whatever their imbrication level,
913 : to allow user to create his own Sequences
914 a lot of modif where necessary (adding, moving, or virtualising methods)
916 WARNING : save your own sources *before* cvs up !
919 ADD virtual void Write(FILE *fp, FileType filetype);
922 ADD virtual void Write(FILE *fp, FileType filetype);
923 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
926 ADD virtual void Write (FILE *fp, FileType filetype)=0;
927 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
928 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
929 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
930 ADD std::string GetEntryByName(TagName name);
931 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
933 std::string vr = "unkn",
934 std::string fourth = "unkn",
935 std::string name = "unkn");
936 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
937 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
938 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
939 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
940 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
941 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
942 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
943 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
946 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
947 ADD virtual std::string GetEntryByName (TagName tagName);
948 ADD virtual std::string GetEntryVRByName (TagName tagName);
949 REM virtual bool Write(FILE *, FileType);
950 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
951 FILE *_fp, FileType type);
952 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
953 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
954 REM virtual bool WriteEntries(FILE *_fp,FileType type);
955 REM virtual std::string GetEntryByName (std::string tagName);
956 REM virtual std::string GetEntryVRByName (std::string tagName);
957 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
958 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
959 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
961 std::string vr = "unkn",
962 std::string fourth = "unkn",
963 std::string name = "unkn");
964 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
965 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
966 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
967 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
970 ADD virtual void Write(FILE *fp, FileType filetype);
973 ADD virtual void Write(FILE *fp,FileType filetype);
976 ADD virtual void Write(FILE *fp, FileType filetype);
977 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
978 REM std::string GetEntryByNumber(guint16 group, guint16 element);
979 REM std::string GetEntryByName(TagName name);
982 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
984 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
985 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
986 The default constructor invoked by the line
987 gdcmHeader *f1 = new gdcmHeader( header );
988 was gdcmHeader::gdcmHeader(bool) instead of the expected
989 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
990 Hence the parsing wasn't executed... See also below.
991 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
992 as explicit constructor didn't do the trick to fix the above problem.
993 Could anyone explain why ?
994 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
995 properly calls gdcmValEntry::Print() (that was weed out from
996 code related to gdcmBinEntry).
998 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * In order to fix memory leaks:
1000 - Test/TestWriteSimple.cxx: added cleaning of free store through
1002 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1003 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1004 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1005 (through the call to ::AddDicomDirMeta()) or the destructor
1006 would crash when deleting uninitialized ::metaElems].
1007 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1008 - src/gdcmDocument.cxx:
1009 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1010 from dynamic stores.
1011 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1012 was causing memory leaks.
1013 - src/gdcmSQItem.cxx:
1014 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1015 cleanly handled with polymophism: sorry but my milage is low).
1016 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1017 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1018 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1019 This avoids SegFaulting.
1020 - src/gdcmSQItem.h: coding style.
1022 - Test/TestWriteSimple still severely sucks. The output image content
1023 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1024 damaged when displayed with vtkgdcmViewer.
1025 - on memory leaks: TestWriteSimple leaks really less (see entry
1026 of 2004-06-18 in Changelog file for the call to valgrind).
1027 - on segfaults: ctest now passes all the tests but one (no more
1029 * Erroneous leading white fix:
1030 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1031 white[s] (as opposed to from >> xxx, that removes it [them].
1032 - src/gdcmTS.cxx: ditto.
1033 - gdcmPython/testSuite.py: dirty related kludge removed.
1034 * src/*: remaining references to gdcmParser removed.
1035 * src/*[cxx|h]: added copy[way]left header.
1038 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1039 * In order to fix writing of dicom files:
1040 - Test/TestWriteSimple.cxx: a simpler example of writing.
1041 - Test/CMakeLists.txt changed accordingly.
1042 - src/gdcmDocument.cxx:
1043 -- The destructor now recursilvely removes potential sequences.
1044 -- Bug fix in ::IsJPEG2000()
1045 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1046 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1048 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1049 to only declared) and build on top of
1050 ::GetDocEntryByNumber(guint16, guint16).
1051 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1052 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1053 for usage in destructor and treatement of promotion in
1054 ::ReplaceOrCreateByNumber().
1055 - src/gdcmSQItem.cxx: destructor should better handle his job.
1056 Test/TestWriteSimple now runs (or at least it DOES something).
1057 * We can now start hutting memory links. A good starting point is:
1058 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1059 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1060 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1062 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * Valgrind note: after Mathieu Malaterre teached me how to read
1064 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1066 Using gcc, you can force the STL to use malloc and to free memory as
1067 soon as possible by globally disabling memory caching.
1068 With 3.2.2 and later, you should export the environment variable
1069 GLIBCPP_FORCE_NEW before running your program.
1070 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1071 simply vanish (it is still not clear to me, whether this means that
1072 STL std::string leaks or if valgrind believes it leaks...).
1073 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1074 running bin/gdcmTests makeDicomDir):
1075 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1076 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1078 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1079 SegFaulting (I drowned in DicomDir related code when trying to
1080 understand why the list is empty...).
1081 * src/gdcmDocument.h: first BSD license header try.
1082 * Doc/License.txt added.
1084 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1085 * src/gdcmDocument.[h|cxx]:
1086 - Clean up of the Transfer related predicates. They are now all based
1087 on new method isGivenTransferSyntax, that (should) handle properly
1088 the padding problem.
1089 - general clean up, simplification, and coding style.
1090 - Specific clean up of Parse7FE0() (umproperly named actually).
1091 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1093 2004-06-14 Jean-Pierre Roux
1095 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1096 - fix the display of SQItem ordinal number
1097 - add the GetSQItemByOrdinalNumber method
1098 - remove some useless never written private methods
1100 2004-06-14 Jean-Pierre Roux
1102 - adding a constructor taking a gdcmDocEntry as an input param
1103 - ReplaceOrCreateByNumber now returns :
1104 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1105 a gdcmValEntry * if a string value is passed as a param
1107 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1108 according to the param type (no longer sets a gdcmDocEntry)
1109 - GetValEntryByNumber, GetBinEntryByNumber added
1110 - NewValEntryByNumber and NewBinEntryByNumber added
1112 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1114 - GetSQItemNumber and SetSQItemNumber added, to provide
1115 a (relative) Item identier inside a given Sequence
1116 \warning : some pb remaining around this number
1118 - AddEntry now takes the Item Number as a param
1120 - adding a constructor taking a gdcmDocEntry as an input param
1122 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * Memory leak hunt with the following command:
1124 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1125 --show-reachable=yes gdcmTests PrintDocument
1126 It looks like many (all?) leaks are due to the STL (or a bad usage
1127 of the STL. The lines producing the leaks now have a comment with
1128 a "MEMORY LEAK" tag: you can retrieve them with
1129 grep "MEMORY LEAK" src/*
1130 Here are two typical examples which I can't help fixing:
1135 char * test = "babo";
1136 name = test; //// <--- valgrind detects 960 bytes lost in
1137 //// call to std::string::operator=(char const*)
1138 name.clear(); //// Doesn't help !
1146 std::cout << "Type a bunch of characters followed by RETURN: ";
1147 getline(std::cin, line); //// <--- valgrind dectects a loss
1148 //// of 1320 bytes in call to
1149 /// std::basic_istream<>& std::getline<>
1155 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1156 * src/gdcmHeader.[cxx|h]:
1157 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1158 and related, moved away to gdcmDocument.
1159 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1160 the corresponding protected accessors of inherited class
1161 gdcmDocument, removed ! As a consequence gdcmFile had to be
1162 declared friend of class gdcmDocument (see below).
1163 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1164 - Clean up of undefined or unused methods.
1165 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1166 account the changes to gdcmHeader.h).
1167 * src/gdcmDocument.h:
1168 - gdcmFile is now a friend class (in order to take into account the
1169 changes to gdcmHeader.h).
1170 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1171 (see changes to gdcmHeader.h).
1172 - Accessors (reading on the form GetEntry*) are now public.
1173 - Clean up of undefined or unused methods.
1174 * src/gdcmDocument.cxx:
1175 - adaptation to changes to gdcmDocument.h
1176 - ::OpenFile now writes a verbose message when file cannot be opened.
1177 - some std::string properly set to VRKey
1178 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1179 references to gdcmDocument.
1180 * Test/TestFindTags.cxx: changed accordingly to above changes.
1181 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1182 cvs repository gdcmData.
1184 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1185 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1186 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1187 conflicts with gdcmValEntry::voidArea.
1188 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1189 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1190 Value representation between StringRepresentable and BinaryRepresentable.
1191 * src/gdcmDocument.cxx:
1192 - method ParseDES: proper indentation restored and usage of
1193 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1194 - method LoadDocEntry: the fingerprint left in the SetValue() of
1195 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1196 removed. Reverting to previous code segment with the proper
1197 dynamic_cast< gdcmValEntry* >.
1198 Note: this was (partially) breaking the python test suite
1199 (gdcmPython/testSuite.py) that made usage of the above
1200 fingerprint to check presence of "Pixel Data".
1201 * src/gdcmDocEntry.h: coding style.
1202 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1203 now taken into account.
1204 * gdcmPython/gdcm.i: adaptation to the new internal representation
1205 of gdcm (exit gdcmParser, hello gdcmDocument).
1206 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1208 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1209 anymore, but instead prints the loaded Python dictionary.
1210 * .... alas, the python testSuite is still broken.
1212 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1213 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1215 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1216 * src/gdcmUtil.h : export methods
1218 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1219 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1221 * Initial addition of automatic python testing
1222 * Initial addition of automatic image comparison
1224 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1225 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1226 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1228 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1229 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1230 * Test/ShowDicom.cxx : bug fix for msvc compilation
1231 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1233 2004-05-04 Jean-Pierre Roux
1234 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1235 new concepts (and new classes) :
1236 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1237 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1238 - Sequence Doc Entries (gdcmSeqEntries)
1239 a Sequence is composed of Items.
1240 Each item is a set of Doc Entries (this is recursive)
1241 The non uniqueness of the 'Dicom tag' is due to this recursivity
1242 (never taken into account)
1243 Our unability to add a new 'entry' in the header
1244 at the proper location (neither in the H-Table (map or multimap),
1245 nor in the Chained List is also due to this recursivity.
1246 Don't try, right now, to use/modify/compile these new sources :
1247 nothing is finished.
1248 We just commit all the stuff, 'as is', in order not to loose it.
1250 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1251 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1253 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1254 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1255 file prefix (SetFilePrefix)
1257 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1258 * Add a new test: ShowDicom, for now this is just the c++ version of
1259 checkRead.sh, later it will be able to compare the image read against a
1261 * Replace the DEBUG on the stack with a global entry in cmake interface:
1262 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1264 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1265 * Add an example subdir, with a real example on how to read + write a
1268 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1269 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1270 * Doc/CMakeLists.txt: the main page is now properly differentiated
1271 between the developper and user version.
1272 * Doc/doxygen.config.in: dropped search related obsolete flags
1273 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1275 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1276 * DEVELOPPER: added some helpfull comments for compile/test/install
1279 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1280 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1281 src directory, now generated in the build dir.
1282 2. Tests as mentionned smarter
1284 4. Add a new method in gdcmDict that return the PubDict by name
1285 this is interesting for 3rd party lib like ITK,
1286 where we could set the institution name / patient name...
1288 * ENH: 1. Now the test suite is working for real
1289 2. All binaries are now output in the gdcm-bin directory
1290 (this was not true before)
1292 2004-04-28 Jean-Pierre Roux
1293 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1294 SeQuence indented printing of Dicom Header.
1295 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1296 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1297 Computation of SQDepthLevel is now part of gdcmHeader constructor
1298 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1299 tree-like structure of a Dicom Header.
1300 * FIX Test code cleaning
1302 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1303 * ENH: Adding automatic testing
1304 1. Need a DartConfig.cmake to submit to public
1305 2. Add a test driver gdcmTest.cxx
1306 3. gdcmTestMain, an helper for the main test driver gdcmTest
1307 4. Files in Test don't have a main anymore, this becomes interesting
1308 when we add more and more tests, thus dsw don't have to load
1310 * ENH: Adding a GDCM_DATA_ROOT for testing
1311 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1312 one file instead of seven + some small cleanup
1314 2004-04-22 Jean-Pierre Roux
1315 * ENH Minor changes to the Print() methods.
1316 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1317 Header printing. Example given with :
1318 > PrintHeader fileName 2 new
1319 (SQ based tree-like structure still to be done for the Header ...)
1321 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1323 1. I have added some unsigned where needed
1324 2. Some function parameter not used -> (void)
1325 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1326 4. g++ don't like character '\' in comment
1327 5. #define jpeg_create_decompress jCreaDecompress
1328 this really need to be fixed
1329 6. virtualize destructor of gdcmObject ... leakage
1330 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1331 this also really need to be fixed
1332 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1333 remove compression file
1334 (as we only do decompression, right ?)
1335 * ENH: Change malloc/calloc/free with c++ equivalent
1337 2004-04-21 Jean-Pierre Roux
1338 * FIX gdcmHeaderHelper::GetXSpacing
1339 when a single value is found (bug ?), xpacing is now
1340 defaulted to yspacing
1342 2004-04-19 Jean-Pierre Roux
1343 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1344 * ENH add parameters :
1345 bool exception_on_error = false,
1346 bool enable_sequences = false,
1347 bool ignore_shadow = false
1348 to the gdcmFile constructors to be full gdcmParser compliant
1349 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1350 to allow reading of PAPYRUS 3.0 files
1352 2004-04-06 Jean-Pierre Roux
1353 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1355 2004-04-02 Jean-Pierre Roux
1356 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1357 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1358 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1360 2004-03-30 Jean-Pierre Roux
1361 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1362 for ACR file, written out as DICOM files (hope so...)
1364 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1366 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1367 moved to base class gdcmParser and only the specialisation is kept
1369 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1370 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1371 already does the job.
1372 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1373 (to be consistent with gdcmParser::WriteEntries).
1375 2004-03-30 Benoit Regrain
1376 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1377 upate of the object's instance. It's passed to 2 in the unfavorable
1378 case : one in the ExecuteInformation, one in the ExecuteData
1380 2004-03-29 Jean-Pierre Roux
1381 * ENH : Check on file type to be written moved
1382 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1383 * FIX : gdcmObject::ResetBoundaries now stops properly
1384 when end-of-list is reached
1385 : gdcmVersion modified (as Benoit Regrain asked)
1387 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1388 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1389 * src/gdcmUtil.cxx: added forgotten iostream include.
1390 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1391 equivalent to ExplicitVR in existing code).
1393 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1394 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1395 now contains all the gdcmGlobal related code.
1396 * minor coding style and doxygenation changes.
1398 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1399 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1400 now contains all the Debug related code.
1401 * minor clean-up of includes in src/*.cxx
1402 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1403 CreateCleanString) removed.
1404 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1405 * Doc/DoxyMainPageUser.txt added.
1406 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1407 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1408 src/gdcmDirList.cxx)
1410 2004-03-24 Jean-Pierre Roux
1411 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1413 2004-03-23 Jean-Pierre Roux
1414 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1415 big endian made volumes
1416 * ENH Now gdcmParser constructor and destructor are protected to forbid
1417 end user to instanciate class gdcmParser
1418 (only gdcmHeader and gdcmDicomDir are meaningfull)
1420 2004-03-22 Benoit Regrain
1421 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1422 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1423 gdcmSerie to gdcmDicomDirSerie
1425 2004-03-19 Jean-Pierre Roux
1426 * ENH Now the tree-like structure describing a DICOMDIR comming from
1427 an already existing DICOMDIR file is consistent with
1428 the home-made tree-like structure build ex-nihilo
1429 or build from the files held (recursively) in a Directory
1430 functions gdcmDicomDir::CheckBoundaries()
1431 gdcmObject::SetBoundaries() added
1433 2004-03-17 Jean-Pierre Roux
1434 * REM (Eric Boix bug) : removal of meaningless
1435 gdcmDicomDirImage::NewImage function.
1436 * FIX now file names and directory name are written properly in the
1438 * FIX now gdcmDicomDir constructor may be call without any trick
1441 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1442 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1443 of gdcmDicomDirImage::NewImage as empty function.
1445 2004-02-28 Jean-Pierre Roux
1446 * ENH add gdcmDicomDir:NewPatient
1447 add gdcmDicomDirPatient:NewStudy
1448 add gdcmDicomDirStudy:NewSerie
1449 add gdcmDicomDirSerie:NewImage
1450 to allow making gdcDicomDir object.
1451 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1452 (as opposite to the gdcmHeader chained list)
1454 2004-02-11 Benoit Regrain
1455 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1456 when using from python
1458 2004-02-10 Benoit Regrain
1459 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1460 * FIX : in gdcmDicomDir when the directory is empty
1461 * ENH : add callback and methods to get the progression of dicomDir
1464 2004-02-06 Jean-Pierre Roux
1465 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1466 - GDCM_META added to gdcmDicomDirType
1467 - class gdcmMeta created
1468 * ENH : - A brief summary is now displayed at the beginning of
1469 'testDicomDir' to help disaster magnitude estimation
1470 * REM : Now useless Test/explDICOMDIR.cxx
1472 2004-02-05 Benoit Regrain
1473 * ENH : add methods in gdcmObject to get the hash table or the list of
1475 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1476 * FIX : wrapping python for TagHeaderEntryHT
1478 2004-02-04 Benoit Regrain
1479 * FIX : even length for some strings when writting the dicom dir
1480 * FIX : sort the images in the dicom dir
1481 * FIX : Bug fix for python use of dicom dir
1482 * ADD : a python demo
1484 2004-02-04 Jean-Pierre Roux
1485 * FIX : Final solution (?) for icone embedded images
1486 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1487 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1488 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1489 gdcmData/gdcm-MR-SIEMENS-16.acr1
1490 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1491 to make full checking easier
1493 2004-02-04 Benoit Regrain
1494 * FIX : WriteEntries : coding style & logic in parameters
1495 * FIX : Set the elements to create the DicomDir in a dictionary file
1497 2004-02-03 Benoit Regrain
1498 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1499 * gdcmDicomDir : add the load of directory
1500 * Bug fix and print add-on
1502 2004-02-03 Jean-Pierre Roux
1503 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1504 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1505 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1506 * FIX gdcmParser.cxx : 'group length' elements are now considered
1507 as integers, even for shadow groups, when file is Implicit VR
1509 2004-02-02 Jean-Pierre Roux
1510 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1512 of the last synonym :-(
1513 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1515 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1516 * FIX taking into account the possible 7fe0,0010 multiplicity
1517 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1518 to allow removal of references to 7fe0,0010, to deal with
1519 ACR-NEMA images, when 0028,0200 is meaningfull
1521 2004-01-31 Jean-Pierre Roux
1522 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1523 no longer writes 'Un' on disk
1524 * FIX SQ elements with actual length are now dealt with corectly
1525 * FIX gdcmFile::WriteBase make the difference, for color images, between
1526 the length (for Palette expanded images)
1527 and Raw Length (non expanded image + Palette)
1528 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1529 (that broke Write). Replaced by UL.
1530 Aware user will reload the field if he
1531 thinks it's necesssary
1533 2004-01-30 Jean-Pierre Roux
1534 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1535 when 'dirty Acr' is found, to be compliant with the new
1536 IsReadable() methods.
1538 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1539 (no DOUBLE images in kosher DICOM,
1540 but so usefull for people that miss them ;-)
1542 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1543 DICOMDIR related utilities (not checked as Windoze compliant)
1545 2004-01-28 Jean-Pierre Roux
1546 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1548 2004-01-27 Jean-Pierre Roux
1549 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1550 to allow skipping the shadow elements, to save memory space.
1551 The TRUE value for this param has to be used
1552 with a FALSE value for the 'enable_sequence' param.
1553 ('public elements' may be embedded in 'shadow Sequences')
1554 * gdcmHeader methods now deal with 'embedded icones images' in the header
1555 (even when an 'icone image sequence' is announced by the
1556 element (0x0088,0x0200), but there is NO icone at all ...
1558 * gdcmHeader sometimes Image Location value doesn't follow
1559 the supposed processor endianity (see gdcmData/cr172241.dcm).
1562 * gdcmHeader add the method
1563 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1564 to get *all* the Header Entries with the same tag.
1565 GetHeaderEntrySameName is probabely *useless*
1566 (no meaning : Name is *not* an identifier within the Dictionnary)
1568 2004-01-26 Benoit Regrain
1569 * Bug fix in the print of hexadecimal representations. Remove long fields
1570 in the print and add a third level of print to print them
1572 2004-01-23 Benoit Regrain
1573 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1574 * Bug fix on test suite after remove the strip made on not string fields
1575 * Split the IsReadable method between gdcmParser which test that the file
1576 is dicom and gdcmHeader which test that it's an image file
1578 2004-01-22 Benoit Regrain
1579 * DicomDir : clean code, add methods, set variables in protected or private
1580 * gdcmUtil : bug fix for the clean string method
1582 2004-01-19 Benoit Regrain
1583 * Add the use of shadow dictionaries
1584 * bug fix and coding style
1586 2004-01-19 Benoit Regrain
1587 * src/gdcmFile.cxx : bug fix concerning the close of file
1588 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1589 * Add the update of header entries using the shadow library
1591 2004-01-19 Benoit Regrain
1592 * removal of file gdcmHeader2.cxx
1593 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1594 inheriting from gdcmParser. This split is to prepare the integration
1595 of dicom dir parsing
1596 * bug fix under python
1598 2004-01-16 Jean-Pierre Roux
1599 * REM removal of class gdcmHeaderEntrySet
1600 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1601 * ADD add file gdcmHeader2.cxx
1602 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1604 2004-01-15 Benoit Regrain
1605 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1606 entries created while parsing the header. Thus, they will be destroyed
1607 when the gdcmDictSet will be destroyed
1608 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1611 2004-01-15 Benoit Regrain
1612 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1613 made a fatal error because of the memory release at the end of program.
1614 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1615 some memory and vtk seems to have some problems with that.
1616 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1618 2004-01-14 Benoit Regrain
1619 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1620 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1621 * src/*.[h|cxx] : make changes due to class name changes
1622 * gdcmPython/demo/*.py : bug fix due to method names
1624 2004-01-13 Benoit Regrain
1625 * src/*.[h|cxx] : coding style
1626 * vtk/*.[h|cxx] : coding style
1628 2004-01-13 Benoit Regrain
1629 * gdcmPython/testSuite.py : test the readable flag of file for tests
1630 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1631 It's lied to the stl compilation by MSVC (windows, always windows...)
1632 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1634 2004-01-12 Benoit Regrain
1635 * src/*.h : add comments
1636 * src/gdcmDictSet.h : set the method BuildDictPath in public
1637 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1638 directly setted in the source code
1639 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1642 2004-01-09 Benoit Regrain
1643 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1644 * setup.py : use a reference to gdcmVERSION
1646 2004-01-07 Benoit Regrain
1647 * Modification to compile with the distutils.
1650 2003-12-10 Benoit Regrain
1651 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1652 can use a gdcmHeaderHelper to load datas
1653 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1654 made in the source code
1656 2003-12-10 Benoit Regrain
1657 * Update Windows projects and .cvsignore files
1659 2003-11-12 Jean-Pierre Roux
1660 * ENH gdcmHeader constructor has one more parameter (default value : false)
1661 that allows the user to 'go inside' the SeQuences only
1663 gdcmElValSet:Print takes it into account
1665 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * ENH: Update gdcmPython/CMakeLists
1667 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1668 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1670 2003-11-10 Jean-Pierre Roux
1671 * FIX : gdcmHeader::LoadElements is now based
1672 on the ListTag listElem member,
1673 not longer on the TagElValueHT tagHt member
1674 * ENH : PrintPubElVal shows (temporarily) both results,
1675 with the tagHt member and the listElem member.
1676 (it's easier to 'see' the problems when using Printheader)
1678 * FIX : old private member LgrElem is now splitted into
1679 ReadLength : Length actually found on disk (updated only
1680 if bug fixing is necessary), for internal
1682 UsableLength : Updated by FixFoundLength, to fix a bug
1683 or to allow Parser going on.
1684 Will allow to re-write a kosher header when a SeQuence
1685 with a length (not 0000) is found
1686 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1687 because gdcmElValSet::Add does not update ListElem
1690 2003-11-07 Jean-Pierre Roux
1691 * FIX misstyping in Transfert Syntax name table
1692 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1693 when they have an actual length (not 0000 nor FFFFF)
1694 (Nobody should care of it, but DICOMDIR explorers)
1696 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1697 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1699 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * ENH: vtkGdcmReader now supports LUT !
1701 (vtkgdcmViewer for now is not able to use them though)
1703 2003-11-05 Jean-Pierre Roux
1704 * in testSuite.py : new files names for checking the package
1705 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1706 that returns the pixel area size to the *aware* (vtk) user
1707 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1709 2003-11-05 Benoit Regrain
1710 * in testSuite.py : Modify the rules for checking the paths
1711 : Explicit error messages
1712 * in __init__.py : Related modif
1714 2003-11-03 Jean-Pierre Roux
1715 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1716 to be used by aware (vtk) users that want to manage
1717 LUT (and no to turn the PALETTE image into an RGB pixels one)
1718 * GetPixelType now returns 8U for 24 Bits images
1719 (vtkGdcmReader compliant)
1721 2003-10-31 Jean-Pierre Roux
1722 * Removal of *all* gdcmData images and add them again
1723 in order to loose the 'history' of un-anonymised images
1725 2003-10-31 Jean-Pierre Roux
1726 * RMV : removal of useless jBitsInJsample.h
1727 for both 8 and 12 Bits JPEG Lossy Libraries
1729 2003-10-31 Jean-Pierre Roux
1730 * ENH : Add the functions gdcmFile::GetImageDataRaw
1731 gdcmFile::GetImageDataIntoVectorRaw
1732 that act as GetImageData and GetImageDataIntoVector
1733 except the making of an RGB Plane from Gray Plane + LUT
1734 Intended to aware (vtk) users who know how to manage
1737 GetLUTRGBA return a R,G,B,A LUT if any
1738 lgrTotaleRaw gives the 'Raw' length
1739 GetImageDataRaw returns the gray Plane
1740 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1741 (They stay Grey, just like with other Dicom viewers :-(
1743 2003-10-30 Jean-Pierre Roux
1744 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1746 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1747 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1748 being coherents dicom files.
1750 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1751 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1753 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1754 * ENH: Two steps is necessary to please VC++ compiler...
1755 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1756 * ENH: Add include dir to medcon lib
1757 * FIX: only one function is being exported for now !
1758 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1760 2003-10-29 Jean-Pierre Roux
1761 * adding gdcmHeader::GetLUTRGBA
1762 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1763 --> Mathieu, the modif u're waiting for is not yet committed
1764 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1766 2003-10-27 Jean-Pierre Roux
1767 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1768 00191113.dcm DermaColorLossLess.dcm
1769 MxTwinLossLess.dcm RadBWLossLess.dcm
1770 * ENH: For version prior to vtkImageViewer2 -r 1.19
1771 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1773 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1774 * Removal of ido stuff in CMakeLists.txt
1776 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1777 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1778 * FIX: remove a call to ->Modified ... see comments
1779 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1781 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1782 * FIX: Problem with path for libvtkgdcmPython
1783 * ENH: Try adding a search script for python site-package
1784 * RMV: Remove some file from medcon lib that are not necessary
1785 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1786 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1787 * FIX: More pragma disable fro VC++,
1788 I don't think I break something as it is also disable in VTK/ITK.
1789 But it fasten debug compilation time.
1791 2003-10-23 Jean-Pierre Roux
1792 * gdcm now deals with 16 Bits Run Length Encoded images
1793 (they are compressed as 2 planes images,
1794 one for the high Bytes, the other for low Bytes)
1796 2003-10-22 Jean-Pierre Roux
1797 * Now CheckRead takes into account :
1798 - the bugged 'Leonardo' Siemens images
1799 - the XA images, sent thru the burning VPRO station
1800 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1803 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1804 * FIX: When copying a Makefile.am to CMakeLists.txt
1805 one should remove the '\'
1807 2003-10-22 Jean-Pierre Roux
1808 * in gdcmData adding a bugged 'Leonardo' Siemens image
1809 (wrong lengths in header)
1810 OK with gdcm, KO with the other viewers :-)
1811 * add a GE dlx XA image, thru the VEPRO burning station
1814 2003-10-21 Jean-Pierre Roux
1815 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1816 for a brutal checking of vtkgdcmViewer compliance
1818 2003-10-21 Jean-Pierre Roux
1819 * add the files for 'xmedcon' Jpeg Lossless library
1820 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1822 2003-10-21 Jean-Pierre Roux
1823 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1825 2003-10-21 Jean-Pierre Roux
1826 * garbage Siemens 'Leonardo' images dealt with
1827 (the patch is easy to remove)
1828 * cosmetic changes to avoid warnings
1830 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1831 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1832 no need to press 'r' now.
1834 2003-10-20 Jean-Pierre Roux
1835 * upgrade of checkRead.sh checkWrite.sh according
1836 to new Jpeg Lossless decompressor
1837 * add US.3405.1.dcm, a genuine RGB medical file ...
1838 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1839 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1841 2003-10-15 Jean-Pierre Roux
1842 * general anonymisation in gdcmData
1843 * adding the 'color files' from
1844 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1845 * adding some well knowed bugged-header images
1846 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1847 waiting for their inclusion in Python testsuite
1849 2003-10-15 Jean-Pierre Roux
1850 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1851 no longer seg faults when file is not found
1853 2003-10-14 Jean-Pierre Roux
1854 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1857 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1858 * TODO: *.in file to genereate a UseGDCM later
1860 2003-10-14 Jean-Pierre Roux
1861 * Some supposed-to-be Dicom Images have no preamble.
1862 OpenFile takes it into account
1863 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1864 * Missing elements added in dicomV3.dic
1865 (just to be affraid : have a look at
1866 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1867 and do it again next year ;->
1869 2003-10-13 Jean-Pierre Roux
1870 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1871 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1872 But there are NOT. It's fixed !
1874 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * FIX: "jpeglib.h" was not found on VC++
1876 * FIX: vtkgdcm was not being installed
1878 2003-10-10 Jean-Pierre Roux
1879 * ENH : OpenFile closes the file if it *really* doesn't look like
1880 an ACR-NEMA / DICOM one.
1881 * FIX : testWrite no longer writes an empty file if the source file
1882 is not gdcm Readable
1883 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1886 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * FIX: CMake generate now documentation
1888 * ENH: out of source doc build !
1889 * ENH: Generate both user and dev documentation
1890 * ENH: Should work on windows too
1891 * ENH: Only one doxygen config.in file is needed
1892 * FIX: make install should be ok now on ùnix plateform
1893 * FIX: PATH to dictionary was wrong (missing /)
1894 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1896 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1897 * vtkGdcmReader is now able to read rgb dicom file.
1898 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1899 * added a gdcmViewer to vtk test, use mouse to control
1900 window level & window width
1902 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * CMake-ification of gdcm, we have now two build system
1904 * FIX: on cygwin Wsock32 doesn't exist
1905 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1907 2003-10-06 Emanuel Ollart
1908 * FIX : compilation process wad broken.
1909 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1911 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * change gdcmViewer -> vtkgdcmViewer
1913 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1915 2003-10-06 Jean-Pierre Roux
1916 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1917 ( e.g : well known GE images with a wrong elem length,
1918 : Philips MRI Images with a wrong Huffman table)
1919 * still to be done : allow the reading of bugged LEONARDO Siemens images
1921 2003-10-03 Jean-Pierre Roux
1922 * Odd length strings are padded with '\0' (not with spaces,
1923 to remain compliant with already defined strings,
1924 like Transfert Syntax UID and others)
1926 2003-10-03 Jean-Pierre Roux
1927 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1928 to allow displaying RGB images (not only by affim ;-)
1930 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * vtkGdcmReader is now able to read rgb dicom file.
1932 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1934 2003-10-03 Jean-Pierre Roux
1935 * A few nasty patches to allow the reading of a lot of nasty images
1936 ( e.g : well known GE images with a wrong elem length,
1937 : Philips MRI Images with a wrong Huffman table)
1938 * still to be done : allow the reading of bugged LEONARDO Siemens images
1940 2003-10-03 Jean-Pierre Roux
1941 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1943 2003-10-03 Jean-Pierre Roux
1944 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1945 to allow displaying RGB images (not only by affim ;-)
1947 2003-10-03 Jean-Pierre Roux
1948 * gdcmFile::GetImageDataIntoVector now
1949 - deals with MultiFrames MultiFragments Run Length Encoded files
1950 - deals with YcBcR (YBR_FULL) files
1951 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1952 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1954 (no sample found :-(
1956 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1958 Two reasons: - clear things
1959 - third parties acces gdcm through header files, so won't
1960 suffer anymore VC++ complains
1962 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1963 * add argv[1] in testvtkGdcmReader.cxx
1966 2003-09-24 Jean-Pierre Roux
1967 * The lines are now eigthy characters long.for
1968 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1970 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1971 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1972 char* to std::string. Thus, the use of strdup becomes useless. (see
1973 previous commis of Malaterre)
1974 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1975 before the last Malaterre's commit.
1977 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1978 * This commit should fix the Debug building under VC++, the problem
1979 was mainly a mixture of debug and release lib being loaded at startup.
1980 * I also remove a depency to a specific C function: strdup. Because I had
1981 to force the link to msvcrtd (whereas strdup is in libc).
1983 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1984 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1985 located in the gdcmCommon.h file. All use of reference of tha has been
1986 changed to now use the variable GDCM_UNFOUND.
1988 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1990 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1991 Dicom dictionary. The test suite can now be run again. Note:
1992 I'm note very happy with the " (RET)" changes. I believe this
1993 RETAINED comment should be dropped when parsing the dictionary.
1994 - PACKAGER corrected
1996 - AUTHORS updated and now in alphabetical order
1997 * Makefile.am now exports gdcm.dsw for Windoze users.
1999 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * cygwin complains about missing std:: in subdir Test/
2002 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2003 * remove some methods that are now in gdcmHeaderHelper
2005 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2006 * vtkGdcmReader set spacing and origin correctly
2008 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2009 * Fix a few delete/delete[] mismatch
2011 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2013 interpretation to data given by gdcmHeader. For instance there are
2014 heuristics to get informations (look at different places).
2015 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2016 sorting DICOM images based on different strategies.
2017 * modified Makefiles accordingly.
2019 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2020 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2021 when building in debug mode
2022 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2023 src/win32/gdcmdll.dsp
2024 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2026 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2030 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2031 * src/win32/libgdcmjpeg12.dsp was not dos format
2032 * src/win32/libgdcmjpeg12.dsp :
2033 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2034 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2036 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2037 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2039 * src/gdcmFile.cxx : bug fix in affectation type
2040 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2041 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2042 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2043 symbols... future problem ?
2045 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * src/win32/libgdcmijpeg12.dsp was missing
2047 * modified gdcm.dsw accordingly
2049 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2050 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2052 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2053 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2054 commit of JPR (before his hollidays to facilitate our work).
2055 * setup.py : bug fix in code. Modifications made while the last commit
2056 of JPR. The code hasn't been tested before the commit... it's so
2057 useless to make that (for best programmer that is JPR) !!!
2059 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * tagged the current version as Version0_3 (i.e. version 0.3)
2062 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2063 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2064 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2065 * *.dsp : modifications to use new libgdcmijpeg8 library
2066 * setup.py : bug fix on VTKPATH variable
2067 * PACKAGER : adding all concerning windows
2069 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2072 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2073 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2074 test suite reported error.
2075 * PACKAGER file added (describes what a packager must do when
2076 packaging a new release).
2077 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2078 * configure.in: upgraded version number to 0.3.0
2079 * fixing build of rpm (through rpm -ta):
2080 - Doc/Makefile.am exports proper doxygen files
2081 - src/jpeg/libijg8/Makefile.am exports the include files.
2083 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2084 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2085 * src/gdcmHeader.h : formatting code
2087 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2088 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2089 We were obtaining error message from vtk. Now, creation of file list
2090 is made in an internal list to prevent this problem.
2091 Bug fix when output is empty.
2092 Bug fix in update of progress value. Previous commit for this was a bad
2094 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2096 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2097 * src/gdcmHeader.h : added method to get the file name
2098 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2099 files. Added method to remove all files on the input
2100 Added FIXME comment concerning the bad parsing of header made by
2101 ExecuteInformation method (in ExecuteData method)
2103 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2105 when using make instal.
2106 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2107 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2109 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2110 * setup.py : adding include dir of jpeg lib to compile all sources
2111 * */Win32/*.dsp : JPR fix for windows compilation
2113 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2114 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2116 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2117 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2119 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * setup.py is again effective on un*x (takes into account the
2121 addon of the jpeg library)
2122 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2123 * Doc/Doxy* updated (includes above enhancements)
2124 * INSTALL now points to web documentation
2126 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2127 * src/gdcmHeader.h doesn't make unnecessary reference to
2129 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2131 * src/gdcm*.[cxx|h] :
2132 - to allow compilation with gcc 3.x
2133 -- clean up of STL usage (added explicit usage of std::)
2134 -- small fixes on exceptions.
2135 Note: linking not tested !
2136 - clean of doxygen comments to avoid warnings at documentation
2138 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2139 dependent convertion).
2141 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2142 * Clean up of previous JPR garbage commit (not even commented in the
2144 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2145 - moved all jpeg related files from src to src/jpeg/libijg8, with
2146 addition/modification of Makefile.am and configure.in.
2147 - the testSuite is still brain damage (not guilty).
2149 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2150 * WrapVTK.py : modifications to get correctly vtk source files to
2152 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2153 (FileName -> Filename)
2155 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2156 * vtk/vtkGdcmReader.[cxx/h]:
2157 - UpdateProgress method should now be effective
2158 - removed the limitation on having only images loaded (as opposed
2160 - when building a stack of images/volume, a lesser number of
2161 gdcmHeader and gdcmFile instances should be used (hopefully
2162 accelerating things).
2163 - when building a stack of images/volumes, files which are not
2164 loadable (wrong path-filename, wrong permissions on existing file,
2165 or file not parsable by gdcm) are replaced with a black image
2166 in the stack (for the caller to notice the problem).
2168 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2171 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2172 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2173 between standard library (std) and vtk library (problems are found
2174 under Windows... thanks Windows !)
2176 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2179 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2181 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2182 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2184 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2185 * When compiling with distutils (see setup.py) the C++ compiler is
2186 called with different flags than the default ones (with automake).
2187 In order to fix all those warning, I compiled gdcm with the command
2188 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2189 and went for warning fixes:
2190 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2191 up from unused variables.
2192 - vtk/vtkGdcmReader.cxx: potential bug fix.
2193 * src/gdcmHeader.h: Doxygen warning cleanup
2195 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * gdcmPython/gdcm.i:
2197 - typemaps correction to take into account the systematic replacement
2198 of "using namespace std" with std:: prefix e.g. std::list,
2199 std::string... (cf changes of 2003-05-21).
2200 - gdcmGlob global variable of type gdcmGlobal (defined in
2201 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2202 exported to Python a as cvar.
2203 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2204 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2205 gdcmDictSet.GetPubDictTagNames() and
2206 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2207 C++ static methods).
2208 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2209 with the above changes.
2211 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2212 * setup.py, manifest.in : bug fix under linux
2214 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * Modification of setup.py to compile vtk part too. Then, we have 2
2216 wrappers which must work with same distutils. For that, we have a
2217 generic distutils in distusiltsWrapping.py ; with :
2218 - build_extWrap class to wrap generically all extensions,
2219 - ExtensionWrap base class for all wrapping extension that contains
2221 - Wrapper interface which wrap sources
2222 + In WrapSwig.py we have extension and wrapper for Swig
2223 + In WrapVTK.py we have extension and wrapper for VTK
2224 * MANIFEST.in : modifications to consider vtk directory and new python
2225 files for compilation
2227 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2228 * Added python wrappers of vtkGdcmReader vtk class (see the
2229 source in vtk/vtkGdcmReader.cxx) :
2230 - vtk/Makefile.am now builds a library
2231 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2232 python library (as opposed to _gdcm.so wich are the python
2233 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2234 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2236 - configure.in has an additional flag --enable-vtk that needs
2237 to be set to enable compilation of vtk related code, that is:
2238 + vtk/vtkGdcmReader.so and
2239 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2240 + gdcmPython/vtkgdcmPython.so (see above)
2241 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2242 be read when compressed or when HighBit + 1 != BitsStored),
2243 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2244 the usage of the python wrapper of vtkGdcmReader vtk class.
2245 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2246 * src/*.[h] all occurences of stl classes are now prefixed with
2247 std::, and all occurences of "using namespace std;" where removed.
2248 This is to avoid pollution of global namespace in included files.
2249 Apparently vtk does not avoid this pitfall: when using both
2250 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2251 collision of various stl members (principally cout...).
2252 * gdcmPython/testSuite.py now cleanly removes temprory generated
2254 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2255 comply with above changes)
2257 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2258 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2259 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2260 vtk data structure (an image Flip was required).
2261 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2262 * cosmetic changes in documentation.
2264 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2265 * src/gdcmHeader.cxx: the constructor no longer exits when an
2266 unexisting file is given as argument.
2267 * The subdirectory Data (containing all the images used for the
2268 test suite) is not part of this repository anymore. A new module
2269 containing those images is now available at
2270 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2271 with the name gdcmData.
2272 All the python scripts (including the package initialisation file
2273 gdcmPython/__init__.py) were adapated to take this change into
2274 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2276 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2277 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2278 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2279 demo of the usage of this class.
2280 Compilation of this vtk part is only done when using the --enable-vtk
2281 at configure (or autogen.sh) stage.
2283 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2284 * More memory link related corrections and documentation fixes.
2286 - maximum info is obtained with a command of the form:
2287 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2288 --show-reachable=yes PrintHeader
2289 - the remaining reachable blocks seem to come from the STL
2290 allocation scheme through the usage of map and list. It looks
2291 like this memory cannot be freed but it is not a memory leak
2292 (in fact further invocation to the STL would recollect the
2293 unused memory allthough it cannot explicitely be freed).
2294 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2295 of displaying an image parsed with gdcm and displayed with VTK.
2296 Note: some images don't seem to work e.g.
2297 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2298 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2299 Allthough this weakens the semantics, it is a ditch attempt to
2300 make gdcm more thread friendly.
2302 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2303 * Memory link hunt (by using valgrind through the command
2304 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2305 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2306 gdcmHeader::_dicom_vr.
2307 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2308 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2310 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2312 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2313 * src/Makefile.am now exports all the necessary include files at
2317 * UpdateGroupLength replaced by new one
2320 * UpdateGroupLength re-written using H-Table
2321 (named UpdateGroupLengthNew untill checks are over)
2323 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2324 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2325 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2327 - gdcmHeader::GetPubElValSet removed.
2328 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2329 UpdateGroupLength, WriteElements, Write.
2330 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2331 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2332 carried the same semantics.
2333 - src/gdcmHeaderIdo.cxx changed accordingly.
2334 - gdcmFile::WriteBase now regroups all the codes from previous
2335 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2336 - enum FileType moved to gdcmCommon.h
2337 * src/gdcmHeader.cxx AddDefault trashed
2338 * gdcmGetXSize added
2339 * getimageDataSize now calls gdcmGetXSize
2340 * Test/*.cxx changed to agree with above changes
2342 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2344 (to avoid double call by end user).
2345 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2346 by end user, since gdcmHeader::gdcmHeader now handles it.
2348 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * gdcm/Doc many doxygen changes:
2350 - Doxyfile now has two different versions, DoxyfileUsers that generates
2351 the html.users end users oriented documentation and
2352 DoxyfileDeveloppers that generates the html.developper developper
2353 oriented documentation.
2354 - README changed accordingly
2355 - requirement.txt removed (old design info moved to TODO).
2356 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2357 DoxyMainPage.txt, DoxyPython.txt provide more information.
2358 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2359 be updated by simply regenerating the docs with doxygen and copying
2360 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2361 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2362 all the tests in the form "if (<map>.count() >1)" were removed.
2363 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2364 ill-formed documentation sections.
2365 * src/gdcmHeader.cxx: ditto
2367 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * setup.py fixed for un*x (needed macro for stdint.h)
2369 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2370 un*ces with sh-utils test utility.
2371 * gdcmPython/demo/test.py renamed to PrintHeader.py
2372 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2373 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2374 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2375 * src/gdcm*.cxx JPR's bad inclusion fixed.
2377 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2379 * gdcmPython/demo/test.py changed accordingly.
2381 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * gdcmPython/Makefile.am fixed linking against libstdc++
2383 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2384 * Swig subdir (historical tests of swig version 1.3.17++) removed
2385 * Test/testChangeEntete.cxx some lines commented out in order to make
2387 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2388 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2390 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2392 hence the user doesn't need this explicit call.
2393 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2394 i.e. LoadElements() call removed.
2395 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2396 - src/Makefile.am declares the proper flag for g++.
2397 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2398 for adding user defined new tags.
2399 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2400 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2401 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2403 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2404 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2405 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2406 src/Makefile.am : the project should properly compile and install
2407 with the autotools, included the python wrappers part.
2408 * gdcm.spec.in : added a spec file for RPM packaging.
2410 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2411 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2413 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2414 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2415 to exported to the environement (see gdcmPython/testSuite.py
2417 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2418 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2419 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2420 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2421 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2423 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * gdcmPython/__init__.py doesn't crash anymore when running in
2425 in InstallMode or PreInstallMode but with an environement given
2426 value of GDCM_DICT_PATH.
2427 * src/gdcmDictSet.[cxx/h] coding style.
2429 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2431 * src/gdcm.h general comments moved to TODO, and README
2432 * src/gdcm.h should now be seen as a user commodity (including it
2433 should suffice to fully use gdcm). It is nowhere including within
2434 any of the kernel files src/*.cxx and src/*.h.
2436 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2438 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2440 * src/gdcm*.cxx only include their corresponding include file
2441 (as opposed to gdcm.h)
2442 * gdcmPython/gdcm.i changed accordingly
2443 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2444 the autogen.sh generated "make snapshot" command to work.
2445 * autogen.sh removed history related references to crea package.
2447 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * distutilsSwigCPlusPlus.py work around some swig portability
2451 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2453 was done in a last ditch attempt to get setup.py _really_
2454 operationnal. The python/gdcmPython layaout add the advantage
2455 of hidding away the python related distutils specific files
2456 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2457 Alas, the src directory was out of scope (i.e. it's relative
2458 position to setup.py was ../src) which made things impossible to
2459 handle (see previous version of python/setup.py). Crossing fingers...
2461 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2462 * python/setup.py now works on Un*x. (harder than I thougth)
2463 * python/distutilsSwigCPlusPlus.py can now have include files
2464 among the list of sources.
2466 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2467 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2468 * modifications in MSVC projects
2470 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * As stated by the first lines of Test/ExceptionAndPython/README, it
2472 looks like we can move back to original usage of exception within
2473 src/gdcm* and hence remove the errno stuff that was introduced
2474 as a quick and dirty fixture of this problem (added to the TODO).
2475 * Doc/Doxyfile configuration file for Doxygen and corresponding
2476 README file for usage added.
2477 * Test/testWrite.cxx added. This new test comes from a split of
2478 test.cxx that is now reverted to its original purpous i.e.
2479 testing the proper parsing of a Dicom related file.
2480 testWrite.cxx concentrates on testing the IO part of gdcm.
2481 * Test/bug1.cxx (containing a bug on WIn32) added.
2482 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2483 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2484 whose purpose is to publish the content of the TagNames of the
2485 Dicom public dictionnary were not accessible without an
2486 instance of class gdcmHeader.
2487 - those methods are now static methods of gdcmDictSet and hence
2488 require no instances at all to be invocated.
2489 - within gdcmDictSet this change required to change some method
2490 to class methods (i.e. are now static) among which SetDictPath
2491 (renamed to BuildDictPath) and LoadDefaultPubDict.
2492 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2493 the above changes by calling the new method classes of gdcmDictSet.
2494 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2495 the above to be effective.
2496 * python/gdcmPython: in order to wrap properly the above changes
2497 for Python, swig version now needs to be > 1.3.17.
2498 * python/gdcmPython/Makefile fixed to adapt itself to new
2499 configure/make shema introduced by Johan Montagnat (thanks for the
2500 contribution). Alas this Makefile cannot be turned into a proper
2501 Makefile.am without some heavy changes in the configure.in
2502 (for python dectection).
2503 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2504 now avoids publishing the empty entries.
2506 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2507 * python/setup.py : bug fix concerning install under windows
2508 ExtraPath reused :-P
2509 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2511 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2512 * Dicts/dicomV3.dic : remove double spaces !!!
2513 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2514 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2517 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2519 method. Doxygenation.
2520 * src/gdcm.h clean up of JPR spurious comments.
2522 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * python/distutilsSwigCPlusPlus.py now properly collects the
2524 shadow classes generated by "swig -c++" (gdcm.py in our case)
2525 when using "python setup.py install".
2526 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2527 reexports the working classes.
2528 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2529 by the classical C errno scheme. This is to prevent an obscure
2530 behavior of the python wrappers when importing wxPython.wx prior
2531 to gdcmPython (which ended up in an abort call). An illustration
2532 of this oddity can be found in the Test/ExceptionAndPython
2533 subdir (see the README file). This problem probably due to
2534 an combination of g++ and dynamic loading.
2535 * added Test/ExceptionAndPython (see above)
2537 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2538 * Changed the layout of the python part to avoid bloating main
2539 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2540 i.e. the distutils arsenal. All the python related stuff is
2541 again in a python subdir, but the package itself is now in
2543 * setup.py was cleaned up:
2544 - pythonIncludePath removed
2545 - python setup.py bdist target is now functional.
2546 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2547 collision with other packages). gdcmPython/demo/*.py changed
2550 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2551 * python subdir moved to gdcmPython (preparation of distutils packaging).
2552 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2553 distutils installer is operational.
2554 * - gdcmPython/__init__.py now properly loads the swig generated
2555 shadow classes (from gdcm.py).
2556 - gdcmPython/demo/*.py changed to import the package gdcmPython
2557 instead of gdcmPython/demo/load.py.
2558 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2560 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2562 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2563 entries within the associated public Dicom dictionary resp. the same
2564 information but sorted by the fourth field (PAT, IMG, DIR) of the
2566 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2567 are now in the "???" group.
2568 - python/gdcm.i changed accordingly,
2569 - python/demo/printGroupedPublicDict.py added, that gives an example
2570 of the above new functionalities in Python.
2572 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcm.h, gdcmHeader.cxx:
2574 - historic references to glib's g_malloc and g_free (#defined)
2575 were definitively removed.
2576 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2577 * src/gdcmElValSet.cxx:
2578 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2579 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2580 - GetElValue(string) renamed to GetElValueByName.
2581 - Added GetElementByName(string).
2582 * src/gdcmHeader.cxx: added
2583 - GetPubElValRepByNumber(guint16, guint16)
2584 - GetPubElValRepByName(string)
2585 - GetShaElValRepByNumber(guint16, guint16)
2586 - GetShaElValRepByName(string)
2587 - GetShaElValByNumber(guint16, guint16)
2588 - GetShaElValRepByName(string)
2589 - GetElValRepByNumber(guint16, guint16)
2590 - GetElValRepByName(string)
2591 - GetElValByNumber(guint16, guint16)
2592 - GetElValRepByName(string)
2593 * Doc/requirements.txt added.
2595 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2596 * Test/Makefile building now depends on the one of libgdcm.so
2597 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2598 pixel data) aware which enables finding the address (offset) of
2599 the pixel data of JPEG encoded DICOM files. This leaves only a single
2600 file in the testSuite whose pixel data address (offset) is unknown.
2601 * python/testSuite.py changed accordingly.
2603 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2604 * VC++ has some strong limitations when working with the STL, as stated
2605 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2606 "Also note that some STL containers (map, set, queue, list, deque)
2607 cannot be exported. [...]
2608 Some STL classes contain nested classes. These classes can not
2610 This is caused by a designed limitation that once a template
2611 class is instantiated, it can not be re-instantiated and
2613 Since our usage of map<> is ubiquitous in gdcm, this "designed
2614 limitation" of VC++ is a pitfall.
2615 Hence the Python wrappers of gdcm cannot be incrementally linked
2616 against the c++ dynamic library. The dirty but only workaround is
2617 to forget about incremental link of dynamic libraries and to generate
2618 the Python wrappers library with the inclusions of the underlying C++
2620 The following modifications concern this matter on Win32/VC++:
2621 - wrapping python correct with standalone wrapped dll (don't use separate
2622 dll under windows !!!!)
2623 - python21_d debug mode enabled (ask Frog how to use it :-)
2624 - NO problem with having an STL member of class for example string in C++
2625 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2626 - Python test of dcmlib in Python is ok under windows on a large set
2628 * removed glib references
2629 * typedef's inserted in gdcm.i for correct swig type management
2631 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * python/demo/*.py load.py extracted from test.py. Added explore.py
2633 that only displays required tags and testAll.py that parses all
2634 the files of the testsuite without using unittest.
2635 * python/testSuite.py other additional test on new files added.
2636 * Data/* new test files added accordingly to the testSuite.
2637 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2638 the vr in the file differs from the one of the dictionary.
2640 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2642 values, but limits itself to values which are below a user specified
2643 size (by default 1024 bytes).
2644 * python/gdcm.i : elements not loaded (because their size is above the
2645 user specified treshold) are exported with their TagKey as key of the
2646 python dictionary. This enables the testsuite to make some checks
2647 on the unloaded elements (since we have their offset and size).
2648 * python/testSuite.py
2649 - now tests for the existence and proper value of the pixel data
2650 - two new examples added.
2651 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2653 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2655 aware. See the strategy comments in gdcmHeader::FindeLength().
2656 * Test/test.cxx now accepts a filename as first argument.
2657 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2658 * python/testSuite.py changed to integrate test on above files.
2660 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2661 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2662 the vr was also RET.
2663 * python/testSuite.py more tests added.
2665 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * python/testSuite.py unittest test suite added (uses Data)
2667 * Data/* dcm and acr files for the test suite.
2668 * glib dependance removed from un*x version. We now use ISO C99
2669 7.18 Integer types (see stdint.h)
2670 - python/Makefile, src/Makefile src/gdcm.h
2671 * src/ when an explicit vr (like dicom files) suddenly poped an
2672 implicit element we use to mark the underlying DictEntry of the
2673 concerned ElValue with "Implicit". This strategy was damageable
2674 too the public or provite dictionaries, since some of their vr
2675 would be changed. Since Header::FindLength heavily relies on the
2676 detection by Header::FindVR of falsely explicit elements, I
2677 added an extra ImplicitVr member to ElValue (boolean).
2678 The rest of the changes we the necessary adaptations.
2680 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2681 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2683 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2685 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2686 * Adaptation for porting to VC++:
2688 o forced to use std namespace (for string to be known)
2689 o all class use __declspec export style on WIN32
2690 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2691 (in stdlib.h on Win32 but in std:: for gcc)
2692 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2693 variable GDCM_DICT_PATH.
2694 * src/gdcmHeader.cxx verbose comments made discrete.
2696 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * python/gdcm.i: added a typemap that converts a C++ hashing table
2698 to native Python dictionary.
2699 * python/demo/test.py:
2700 - now uses the native dictionary for exploration of gdcmHeader.
2701 - takes an optional filename argument (the file to parse).
2702 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2703 PubElVals hashing table.
2704 * Dicts/dicomV3.dic removed error prone trailing spaces.
2706 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2707 * Python wrapping process moved away from src/Makefile to
2708 newly created python/Makefile (as well as gdcm.i)
2709 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2710 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2711 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2712 from the environement variable GDCM_DICT_PATH (when existing).
2713 * src/gdcmDict::GetTag bug fix.
2715 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2716 * Straightforward temporary fixes for swig to build the python wrappers.
2717 src/Makefile now has a python working entry [by working we mean
2718 that we can import de shadow classes without errors].
2720 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * hashtest.cxx removed (since allready in Test)
2722 * src/gdcmlib.h renamed to src/gdcm.h
2723 * src/dcm.i renamed to src/gdcm.i
2724 * src/Makefile prepared for python wrapping
2726 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2727 * src/gdcmHeader.cxx :
2728 - Parsing of header is now separated from loading of element values
2729 (see gdcmHeader::LoadElements).
2730 - general clean up of hopefully all file access (creation of
2731 ReadInt16 and ReadInt32)
2733 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * src/gdcmHeader.cxx :
2735 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2737 - SetLgrElem renamed to SetLength
2738 - GetLgrElem renamed to GetLength
2739 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2740 * src/gdcmElValSet.cxx fixed both GetElValue methods
2741 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2742 due to IdoDude was cleaned out.
2744 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2746 concentrates on finding the value representation (when it exists).
2747 RecupLgr now only finds the element value length, and it avoids
2748 returning the unecessary skL (skipped length).
2749 Also, offsetCourant was simply removed (with taille_fich) since
2750 it was redundant with the File position internals (by using
2751 ftell and fseek). This also made skL (see above in RecupLgr) usage
2753 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2754 on the libido specificities which are handled through class
2756 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2759 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2760 * Truckload of changes. Parsing of header is barely functional
2761 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2763 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * src/gdcmHeader.cxx many addons of low level methods
2766 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2767 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2768 and _IdDcmSWAP_LONG.
2770 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * This corresponds to all the changes decided at the meeting of
2772 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob