1 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/ : fix compilation warnings for the Write method (2 different
3 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
5 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
7 file, to be accessed by other files (like gdcmFile). Remove commented
8 code. Move the change of the header to the gdcmFile, using the
10 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
11 To be sure of that (and simplify calls), the Write of the header now
12 gets a file name and not a file pointer (std::ifstream).
13 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
14 DocEntryArchive. Remove all open of the written file
16 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
19 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
21 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
23 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
24 some corresponding methods. Write correctly the file and check before
26 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
27 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
28 is now on RGB datas (as before my last commit
29 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
31 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
33 Add a print information of the type of the entry
34 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
35 It was in the gdcmFile, and all write have been regrouped
36 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
37 Write correctly all dicom files (in decompressed mode only at this time)
38 * Test/ : test on files are now made using Raw datas and not color datas if
40 * Example/PrintFile.cxx : add more printings
42 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Amelioration of code, remove some code copy. For the loading of
44 BinEntry (in gdcmDocument), add the test to verify if the file is already
47 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
49 remove a DocEntry in the header (push an empty DocEntry)
50 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
51 lines. Bug fix in the initialization of the PixelConvert and the
53 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
54 use in TestCopyDicom (now this test can run under windows... but fails)
55 * Test/TestCopyDicom.cxx : amelioration of the test :
56 - test the pixels written
57 - add test points to quickly find where is the error
58 - can set a file name input and output in arguments
59 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
60 amelioration of the test output
62 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
64 all replaced DocEntry's
65 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
66 Now, each needed DocEntry to modify is duplicated, modified and inserted
67 to the header using DocEntryArchive. Thus, after save, we can restore the
70 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
71 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
73 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
75 correct to copy it. The DictEntry is specified at the DocEntry creation,
76 then, it musn't change in the time.
77 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
78 header correctly. At this time, the change is only made for the first
79 level of the Document. In the future, it might consider sequences.
80 The change is made by replacing a DocEntry by an other that is created
81 outside the class. The old value is kept. When we restore the header
82 status, the added DocEntry is deleted and replaced by the old value.
83 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
84 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
85 set the write type to explicit VR, implicit VR or ACR. Add methods to set
86 the write mode to native, decompressed or RGB (but not used at this time)
88 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
90 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
92 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
93 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
94 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
96 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
97 set because already copied when copying the BinEntry's of the header
98 * Test/TestAllReadCompareDicom.cxx : remove warnings
100 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
102 Two problems appear when doing it :
103 - with the gdcmFile : when the GetImageData method is called, the pixels
104 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
105 datas (pixels). And each structure destruct the datas when it's
106 destructed. So we have two destructions for the same datas. To solve it,
107 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
108 datas or not. If it doesn't own datas, then they will not destroyed by
110 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
111 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
112 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
113 create a double destruction of the same DocEntry's. So, to solve it,
114 the TagHT is simply cleared and the DicomDir* elements are destroyed.
115 * TODO : add an entry concerning memory leaks in the DicomDir
117 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
119 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
122 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
124 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
125 after it have been deleted
127 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
128 * FIX: src/* fix the doxygen warnings.
129 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
130 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
131 was erroneously defined with a size of 15 instead of 16. [many thanks
132 to Jean Michel Rouet for pointing out this bug].
134 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
135 1. Finish merging JMR patch for writting DICOM from scratch
136 2. Fix -hopefully- bug with MONOCHROME and space vs null character
137 3. Use const ref when possible
138 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
139 5. A few more comments
140 6. CreateUniqueUID can now be called without parameter"
142 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 * ENH: Slightly bigger patch:
144 1. Getting toward full integration of JMR patch for writting dicom from scratch
145 2. Update Test to test part of this patch: CreateUniqueUID
146 3. File was not close properly in gdcmDict
147 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
148 5. Use of const ref instead of copy (speed issue)
149 6. Remove temporary (duplicate) string in TranslateToKey
150 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
151 8. Do not repeat virtual in subclasses
152 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
154 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
155 * Apply first patch toward better string comparison when dealing with broken
156 DICOM files. Essentially the string could be padded with a space instead
157 of a null character as defined by standard
159 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
160 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
161 because never used... and in the same time, that's remove some memory leaks
163 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * src/gdcmFile.cxx : now delete the PixelConvert instance.
165 * In examples and tests : change the type of image data variables from void*
166 to uint8_t*. Remmove all delete on image data variables
168 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
170 Verify the file pointer value before open the file, and if it's not null,
171 a verbose message is generated.
172 Close correctly the file when the file isn't considered dicom-like. The
173 correctly close is a call to CloseFile.
174 When closing the file pointer, test if its not null to close the file.
175 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
176 file. For an uncompressed image, the copied datas correspond in the least
177 case to the image size (calculated) or the image size specified in the
178 header. A verbose is generated if these two size mismatch
180 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
182 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
183 break under windows (with msvc6 compilation).
185 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
187 compiling with MSVC6)
189 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * Bugs fix for the Windows build with VC6
191 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
192 needed (only for projects required VTK). If the VTK is included in all
193 projects, there is conflicts with the jpeg lib of vtk when compiling the
194 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
195 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
196 when compiling the gdcm_wrap.cxx file (created by the compilation of the
198 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
199 (like it's already made for the cout use). Otherwise, conflict with the
202 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
203 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
205 - comments on the DicomDir::Method related usage added.
206 - now that we use the namespace gdcm, a lot of internal classes do
207 NOT need to be wrapped anymore.
208 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
209 DicomDir::Method) new example added.
211 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Improve string manipulation. I now inforce the notion of 'DicomString'
213 A DicomString can contain as many \0 as they want
214 and it is *always* of even length.
215 We only support odd length for very rare case.
216 And in the near future this should be removed.
218 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
219 * /binary_write/ gdcm source. Now even on big endian we are writting
220 little endian. This should -heopfully- fix some tests
222 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
223 * Now the dictionary is compiled into gdcm lib. This is a default
224 behavior, thus any dic file specified is picked before failback to
225 the one comiled into lib
227 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
228 * Change internals for gdcmDict. Don't use any 'new' any more.
229 This should definitely solve any leak problem, and we should be
230 as fast as before, as long as don't modify too much the dictionary.
232 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
233 * STYLE: ivars should start with a capital letter.
234 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
235 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
237 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
238 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
239 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
240 new 2004 dictionaries added (thanks to JPR).
241 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
242 * CLEANUP_ROUND (15) for gdcmPixelConvert
243 - RLEFrame::NumberFragments is now of type unsigned int
244 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
245 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
248 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
249 * Initial work in gathering all transfer syntax accessors. clearly
250 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
251 ivars, but only one transfersyntax (class) ivar with equivalent method on
254 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
256 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
257 discussed (plus I didn't like having a 2000 lines patch not commited)
259 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
260 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
261 * CLEANUP_ROUND (14) for gdcmPixelConvert
262 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
263 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
264 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
266 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
267 anymore and hence avoids storing a copy of PixelConvert::Decompressed
268 into File::Pixel_Data.
270 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
272 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
273 * CLEANUP_ROUND (13) for gdcmPixelConvert
274 Substituted File::ParsePixelData() with PixelConvert::Print() new
276 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
277 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
278 method to those classes.
279 - src/gdcmFile.[cxx|h]:
280 -- Added a ::Print() method.
281 -- PixelConverter is now a reference instead of a member.
282 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
283 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
285 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
287 collaboration diagram and inheritance diagram should be generated with
289 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
290 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
291 pointlessly wrapped (see
292 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
293 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
294 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
295 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
296 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
297 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
298 -- File::Initialise: PixelConverter setup moved away to
299 PixelConverter::GrabInformationsFromHeader()
300 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
301 interpretation moved away to PixelConverter::BuildRGBImage()
303 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
304 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
305 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
307 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
308 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
309 displayed on Win32 when a brutal abort() occurs (because of uncatched
310 exception). See TODO new entry of this commit for more on this.
311 * TODO added new entry.
312 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
313 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
314 - HandleColor is no longer called from gdcmFile.cxx
315 - gdcmPixelConvert.cxx clean up on method arguments and internal
316 variable names for semantical coherence.
318 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
319 * Finished lossless transition, not only do we now read all lossless jpeg
320 images, without the need of the Cornwell lib, but we do read them properly now
321 * To reduce code (well to avoid code duplication), I defined a common place
322 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
323 redefine symbols. This is not prefect but this the best solution I found for a
324 compilation time jpeg option.
326 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
327 * Update jpeg ijg lib to support lossless jpeg implementation
328 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
330 * Also added a special copyright for dcmtk since we use their bugfixes.
333 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
335 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
336 matters, as stated in warning note at begining of %include section).
337 * src/gdcmDicomDir*.[cxx|h]: coding style
338 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
339 * src/gdcmJpeg8.cxx: doxygen fix.
340 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
341 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
342 from File:: to PixelConvert::.
344 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
345 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
346 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
347 - more code moved away from File:: to PixelConvert::
348 - fat setup of PixelConverter set in place in File::Initialise.
350 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
351 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
352 namespace at the file system level. So now you should convert your examples
354 gdcmHeader -> gdcm::Header
355 It would be nice if people keep in mind to no open the namespace, since it
356 allows compilation on broken plateform which were defining common symbol in
357 the standart namespace (like LP, Unknown ...)
359 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
361 The JPEG fragments are now parsed at the same stage than the RLE
362 information. All code related to JPEG is now in gdcmPixelConvert:
363 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
364 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
365 export a gdcmFile:: method. Those are simply global functions
366 (for the time being this is better than having them attach to
367 either gdcmFile:: or gdcmPixelConvert::).
368 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
369 and stores the result in a gdcmJPEGFragmentsInfo.
370 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
371 code (among other stuff) moved away from gdcmFile:; to
374 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
376 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
377 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
378 clean up of RLE related code.
379 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
380 - src/gdcmRLE.cxx removed
381 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
382 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
383 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
384 * CLEANUP_ROUND (9) for gdcmPixelConvert
385 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
386 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
387 away from gdcmFile:: to gdcmPixelConvert::.
389 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
391 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
392 This is because Parse7Fe0 used to parse the pixels to compute the
393 length. This task was passed over to FindDocEntryLengthOB() a long
394 time ago, EXCEPT I had forgotten the OW case...
395 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
396 we just recylce the code for parsing RLE fragments and computing
398 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
399 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
400 with the retired Parse7Fe0().
401 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
402 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
404 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
405 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
406 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
407 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
408 - src/CMakeLists.txt: alphabetic order reodering + new entries.
409 * CLEANUP_ROUND (4) for gdcmPixelConvert
410 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
411 to return an unused length.
413 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
414 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
415 this should be cleanner from the plane view. The iostream are erally a pain
416 to use to do simple stuff.
418 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * Redo the compilation of the ijg jpeg library. Now only one source is
420 necesseray. No need to rename file by hand what so ever. CMake handle the
421 copying of the file within different directory, configure header file to
422 modify some symbol. The only addition made to ijg wasd a mangle table so
423 that symbol are different wether we are within 8bits or 12bits.
425 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * Added documentation of vtkgdcmReader on Website:
427 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
428 with it's binary name).
429 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
430 the Website to be more complete.
431 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
432 doxygenated documentation.
433 - Doc/DoxyVtkGdcmReaderExamples.txt added
434 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
435 DoxyVtkGdmReaderExamples.html )
436 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
437 * CLEANUP_ROUND (3) for gdcmPixelConvert
438 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
440 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
441 * CLEANUP_ROUND (2) for gdcmPixelConvert
442 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
444 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * CLEANUP_ROUND for gdcmPixelConvert:
446 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
447 - src/gdcmPixelStuff[h|cxx] removed
448 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
449 - src/CMakeLists.txt changed accordingly
451 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
452 gdcmVersion.py moved to newly created ATTIC related
453 gdcmPython/SetupOldies/ directory.
454 * Autotools clean up:
455 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
456 - autogen.sh configure.in acinclude.m4 python.m4 removed
458 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * src/*.cxx *.h Reference to License.htm fixed to License.html.
460 * Doc/CMakeLists.txt, doxygen.config.in: fix.
461 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
463 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * TODO updated with Mathieu suggestions. I proposed a template for
465 describing TODO entries and used it for new entries.
466 * Added Doc/Website/CodingStyle.html, Developpers.html,
467 DeveloppersPython.html, GdcmDataCvs.html and
468 DownloadVersion0_1.html, DownloadVersion0_3.html.
469 * Some Doc/*.txt Doxygen files (which do not really concern the
470 documentation itself, but the website) moved to html and
471 placed in directory Doc/Website:
472 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
473 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
474 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
475 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
476 * CMakeLists.txt changed accordingly.
477 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
478 DeveloppersPython.html
479 * INSTALL nows refers to Doc/Website/Installation.html
481 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * Added Doc/Website directory, that contains a first raw version
485 2004-09-23 Jean-Pierre Roux
486 * FIX In order not to be poluted any longer by casting problems,
487 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
488 we can now delete[] it safely
489 * VoidArea is now called BinArea (less confusing name),
490 and all the methods called ...VoidArea... are now ... BinArea...
491 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
493 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
495 clear) TagHT, which is an inherited member of gdcmElementSet. It is
496 up to the destructor of gdcmElementSet to clean up TagHt and it's
499 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * Test/CMakeLists.txt: update to follow gdcmData renamings.
501 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
503 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
504 * ENH: added some utility method that builds a flat dictionnary
505 holding all the Dicom entries contained in the recursive structure
506 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
508 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
509 BuildFlatHashTable() that build a flat dictionary.
510 - src/gdcmElementSet.h: added a new private GetTag() accessor.
511 gdcmDocument is now a friend of gdcmElementSet.
512 - src/gdcmElementSet.cxx: clean up.
513 - Example/FlatHashTablePrint.cxx added.
514 - Example/CmakeLists.txt changed accordingly
516 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
518 moved away from gdcmDocEntrySet (since this class is an abstract class
519 acting like an interface). SQDepthLevel and BaseTagKey are now
521 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
522 and associated accessors. Doxygenation of the class.
523 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
525 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
526 Use SQDepthLevel accessor instead. ::Print() adapted.
527 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
528 - src/gdcmDocument.cxx changed accordingly.
530 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
532 - The following is the doxygen comment of the typedef declaration
533 of gdcmagKey in src/gdcmCommon.h:
534 gdcmTagKey is made to old an "universal" (as in URL, Universal
535 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
536 A dicom tag allways has a group and an element, but a set of tags
537 embeded in various (optionally nested) sequences and sharing
538 the same group and element all share the same (group, element)
539 "identifier". Hence the (group, element) cannot be used as an
540 identifier (in gdcm we shall refer to a "TagKey") of a tag.
541 In order to construct a proper tag identifier (i.e. a key) we
542 consider the following definition of a TagKey:
543 - let Group, Element be the string representation of the
544 group and element dicom tag members,
545 - let ItemNumber be the string representation of the integer
546 index of the considered item number of a sequence,
547 Let the key of a tag embeded in a sequence, noted SeqTag, be
549 /ItemNumber#Group|Element
550 where "/", "#" and "|" are characters acting as separators.
551 Then the general form of a gdcmTagKey is given by:
552 Group|Element<SeqTag>
553 where <SeqTag> means NO or many instances of SeqTag.
554 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
557 but the gdcmTagKey of a tag "embeded" is the first item of
558 a sequence, itself nested in the third item of a sequence is the
560 0004|1220/2#0008|0082/0#0008|0090
561 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
562 order to hold the new sequence compatible key. Previously, the
563 GetKey() method would look in the underlying gdcmDictEntry.
564 - src/gdcmDocEntry.cxx:
565 -- constructor now copies the underlying DictEntry key, in the local
567 -- ::Print: displays the member Key, instead of the (group, element).
568 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
569 - src/gdcmDocEntrySet.h:xi
570 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
571 -- now has a new BaseTagKey member.
573 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
574 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
576 This poses the problem with the semantics of the following lines
577 LoadEntryVoidArea(0x0028,0x1201); // R LUT
578 LoadEntryVoidArea(0x0028,0x1202); // G LUT
579 LoadEntryVoidArea(0x0028,0x1203); // B LUT
580 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
581 to the long FIXME note for what the problem is. Nevertheless in
582 order to get things working the dicom dictionary was altered !
583 Please fix things urgently...
584 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
585 information), see above note on moving the member VoidArea. Nevertheless
586 the following entries previously correctly set as US are now inproperly
588 0028 1201 OW IMG Red Palette Color Lookup Table Data
589 0028 1202 OW IMG Green Palette Color Lookup Table Data
590 0028 1203 OW IMG Blue Palette Color Lookup Table Data
591 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
592 of gdcmDocEntry moved to gdcmSeqEntry.
593 * src/gdcmSeqEntry.cxx: STYLE.
595 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
596 * Test/TestAllEntryVerify.cxx minor fix and added comments.
598 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * gdcmPython/testSuite.py: all the test suite in python is now moved
600 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
601 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
602 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
604 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
605 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
606 to avoid inclusion recursion until STL is reached.
607 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
608 mecanism. errno.h is not included in gdcm anymore.
609 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
610 (gdcmFormatError now inherits from gdcmFormatUnexpected).
612 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
613 gdcmData/TestAllEntryVerifyReference.txt
614 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
615 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
616 exception_on_error parameter.
617 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
618 - vtk/vtkGdcmReader.cxx changed accordingly,
619 - Example/*.cxx and Test/*.cxx changed accordingly.
621 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
623 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
624 enable_sequences removed from gdcmHeader constructor and dependencies.
625 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
626 * gdcmPython/demo/PrintHeader.py: dummy fix.
627 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
628 skip_shadow removed from gdcmHeader constructor and dependencies.
629 * Example/*.cxx and Test/*.cxx changed accordingly.
631 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
632 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
633 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
635 2004-07-21 Jean-Pierre Roux
636 * FIX Now, Parsing and Printing a DICOMDIR do work!
637 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
639 2004-07-20 Jean-Pierre Roux
640 * FIX Some brain damaged headers have Zero-Lenght fields
641 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
643 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
644 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
645 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
646 variable (instance of gdcmDebug) by a definition macro, and the instance
647 is now in static in the gdcmDebug class
648 * src/gdcmSQItem.h : (FIXME) remove an undefined method
649 * Test/PrintAllDocument.cxx : bug fix in the result of the test
651 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * WARNING: ctest now depends more tightly on gdcmData. You should
653 check out gdcmData properly for things to run smoothly...
654 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
655 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
656 we need the pixels not be loaded in order to use the ValEntry
657 that displays position and size).
658 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
659 This is a C++ based equivalent of gdcmPython/testSuite.py that should
660 be deprecated. If you have any doubts about the advantages of a
661 modern scripting language (read Python) versus grass root C++ (i.e.
662 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
663 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
664 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
665 Anyhow, consider documenting the gdcmData images in
666 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
668 * Test/CMakeLists.txt:
669 - now uses TestAllEntryVerify.cxx
670 - specific comments on oldACR00001.ima (now renamed in gdcmData
671 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
672 gdcmData/TestAllEntryVerifyReference.txt
675 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * src/*.[h|cxx] : typedef clean up
677 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
678 - TagKey renamed to gdcmTagKey (for external usage)
679 - VRKey renamed to gdcmVRKey (for external usage)
680 - removal of typedef duplication.
681 - Removed all unecessary inline keyword from class inline definitions.
682 - Some method|function(void) declarations replaced with method|function().
683 * src/jpeg/libijg12/jdhuff12.c:
684 - printf polluting ctest removed.
685 - TAB removal for comminting
687 - TestAllReadCompareDicom.cxx: added a test that compares all the
688 images in gdcmDataImages.h with corresponding images in
689 gdcmData/BaselineDicom/. When baseline images are not present
690 this test creates them.
691 Note: we need to validate each reference image, but before that
692 I'd like to rename them with a more explicit name...
693 - CMakeLists.txt: changed accordingly.
694 * Example/*.cxx: examples now only include gdcm.h (as opposed to
695 including each header needed).
697 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
698 * Test/*.cxx and Example/*.cxx: moved some examples away from the
699 test suite to the Example directory. Are concerned:
704 - TestWriteSimple.cxx
705 * Test/CMakeLists.txt: added some comments on reasons for black listing
706 image gdcmData/oldACR00001.ima
708 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * Test/CmakeList.txt: removed the following from black list (to be coherent
710 with removal from gdcmData):
711 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
712 - gdcm-MR-PHILIPS-16.dcm
714 Added the following because after last cvs update, they cause
715 ctest -R TestReadWriteReadCompare
717 - gdcm-MR-SIEMENS-16-1.acr
719 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
720 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
721 new comments in this file) we temporarily (sigh) move to a weaker
723 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
724 we don't need to black list the following images anymore:
725 - 8BitsUncompressedColor.dcm
727 - US-PAL-8-10x-echo.dcm
728 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
729 fixes and the beautified code ;-)
730 This fixes the bug introduced in version 1.42 (when beautifying)
731 that made the parsing of 8BitsRunLengthColor.dcm unproper.
732 Note: ctest was blind to this bug (this means we need to still
733 improve the test suite). The bug could be detected by using
734 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
736 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
737 and by displaying the (garbage) produced file temp.XDCM...
739 2004-06-29 Jean-Pierre Roux
740 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
741 - replace by uggly but working old code :-(
742 A lot of things should be OK again.
743 It's really urgent to have a test suite that *tests*,
744 to prevent Frog's beautifying sessions to break all the stuff
745 (twice, withing a fortnigh ...)
747 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
749 redundancy) to added Test/TestReadWriteReadCompare.cxx
750 * Test/CmakeList.txt: because the compare test of
751 Test/TestReadWriteReadCompare.cxx fails, the following images are
752 black listed: - 8BitsUncompressedColor.dcm
754 - US-PAL-8-10x-echo.dcm
755 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
756 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
757 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
758 and ad-hoc kludge. This kludge is now removed, and on encountering
759 such an image (OB field brain damaged) we set errno. Then in
760 ::FindDocLength() we "fix" the length as being ALL what remains
761 in the file (until EOF). We then proceed, hoping for the best...
762 This fixes a SegFault in ShowDicom when trying to write such an
764 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
765 (because TestWriteRead breaks on it, after a non conformal commit?).
766 ctest now runs properly, except for MakeDicomDir (which was allways
767 broken) and the Python related stuff (still not fixed).
769 2004-06-24 Jean-Pierre Roux
770 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
771 FIX : Test/TestReadWrite now iterates on all the file names
772 (instead of infinite loop)
773 ENH : Test/TestWriteRead now iterates on all the file names
775 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
776 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
778 2004-06-24 Jean-Pierre Roux
779 FIX : - now Write drops LUT Descriptors and LUTs (if any)
780 when SamplesPerPixel =3
781 - now Write is no longer confused by
782 'BitsAllocated = 12" and 'BitsStored=12"
783 - "UN" value representation Elements are now written correctly
784 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
785 ENH : - now gdcmHeader has its own Write methods
786 (in order to split the job that has not to be done
789 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
790 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
791 loop on the same image until memory went out.
792 Note: this means we still have gobs of memory loss in PrintDocument
793 * src/gdcmDocument.cxx: fixes problem on parsing on file
794 gdcmData/16BitsJpegLosslessGrayScale.dcm.
796 2004-06-24 Jean-Pierre Roux
797 FIX : Write - All the Sequences and Sequence Item are now written
798 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
799 is added a the end, when necessary.
800 - A lot of brain-damaged images, that were read correctly are
801 now written correctly
802 - length compatible BinEntry are now loaded correctly
803 (even for odd groups)
804 Note : only Explicit Value Representation was checked.
805 (question : is implicit VR really necessary for gdcm ?)
807 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * DEVELOPPER: added a proposition of coding style.
809 * src/gdcmDocEntry.h: removed every inline declaration (for test of
812 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
814 Use the gdcmDocEntry::Print() and Write() instead.
815 * src/gdcmDocument.cxx: bug fix.
817 2004-06-22 Jean-Pierre Roux
818 FIX : gdcmDocument.cxx
819 - Now we do recognize the JpegLossLess format (there was a misstyping in
820 code 'beautyfication' :-(
821 - Now we automaticaticaly load the Luts, if any
823 2004-06-22 Jean-Pierre Roux
824 In order : to write Sequences, whatever their imbrication level,
825 : to allow user to create his own Sequences
826 a lot of modif where necessary (adding, moving, or virtualising methods)
828 WARNING : save your own sources *before* cvs up !
831 ADD virtual void Write(FILE *fp, FileType filetype);
834 ADD virtual void Write(FILE *fp, FileType filetype);
835 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
838 ADD virtual void Write (FILE *fp, FileType filetype)=0;
839 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
840 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
841 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
842 ADD std::string GetEntryByName(TagName name);
843 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
845 std::string vr = "unkn",
846 std::string fourth = "unkn",
847 std::string name = "unkn");
848 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
849 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
850 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
851 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
852 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
853 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
854 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
855 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
858 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
859 ADD virtual std::string GetEntryByName (TagName tagName);
860 ADD virtual std::string GetEntryVRByName (TagName tagName);
861 REM virtual bool Write(FILE *, FileType);
862 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
863 FILE *_fp, FileType type);
864 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
865 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
866 REM virtual bool WriteEntries(FILE *_fp,FileType type);
867 REM virtual std::string GetEntryByName (std::string tagName);
868 REM virtual std::string GetEntryVRByName (std::string tagName);
869 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
870 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
871 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
873 std::string vr = "unkn",
874 std::string fourth = "unkn",
875 std::string name = "unkn");
876 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
877 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
878 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
879 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
882 ADD virtual void Write(FILE *fp, FileType filetype);
885 ADD virtual void Write(FILE *fp,FileType filetype);
888 ADD virtual void Write(FILE *fp, FileType filetype);
889 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
890 REM std::string GetEntryByNumber(guint16 group, guint16 element);
891 REM std::string GetEntryByName(TagName name);
894 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
896 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
897 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
898 The default constructor invoked by the line
899 gdcmHeader *f1 = new gdcmHeader( header );
900 was gdcmHeader::gdcmHeader(bool) instead of the expected
901 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
902 Hence the parsing wasn't executed... See also below.
903 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
904 as explicit constructor didn't do the trick to fix the above problem.
905 Could anyone explain why ?
906 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
907 properly calls gdcmValEntry::Print() (that was weed out from
908 code related to gdcmBinEntry).
910 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
911 * In order to fix memory leaks:
912 - Test/TestWriteSimple.cxx: added cleaning of free store through
914 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
915 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
916 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
917 (through the call to ::AddDicomDirMeta()) or the destructor
918 would crash when deleting uninitialized ::metaElems].
919 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
920 - src/gdcmDocument.cxx:
921 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
923 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
924 was causing memory leaks.
925 - src/gdcmSQItem.cxx:
926 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
927 cleanly handled with polymophism: sorry but my milage is low).
928 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
929 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
930 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
931 This avoids SegFaulting.
932 - src/gdcmSQItem.h: coding style.
934 - Test/TestWriteSimple still severely sucks. The output image content
935 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
936 damaged when displayed with vtkgdcmViewer.
937 - on memory leaks: TestWriteSimple leaks really less (see entry
938 of 2004-06-18 in Changelog file for the call to valgrind).
939 - on segfaults: ctest now passes all the tests but one (no more
941 * Erroneous leading white fix:
942 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
943 white[s] (as opposed to from >> xxx, that removes it [them].
944 - src/gdcmTS.cxx: ditto.
945 - gdcmPython/testSuite.py: dirty related kludge removed.
946 * src/*: remaining references to gdcmParser removed.
947 * src/*[cxx|h]: added copy[way]left header.
950 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
951 * In order to fix writing of dicom files:
952 - Test/TestWriteSimple.cxx: a simpler example of writing.
953 - Test/CMakeLists.txt changed accordingly.
954 - src/gdcmDocument.cxx:
955 -- The destructor now recursilvely removes potential sequences.
956 -- Bug fix in ::IsJPEG2000()
957 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
958 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
960 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
961 to only declared) and build on top of
962 ::GetDocEntryByNumber(guint16, guint16).
963 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
964 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
965 for usage in destructor and treatement of promotion in
966 ::ReplaceOrCreateByNumber().
967 - src/gdcmSQItem.cxx: destructor should better handle his job.
968 Test/TestWriteSimple now runs (or at least it DOES something).
969 * We can now start hutting memory links. A good starting point is:
970 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
971 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
972 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
974 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
975 * Valgrind note: after Mathieu Malaterre teached me how to read
976 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
978 Using gcc, you can force the STL to use malloc and to free memory as
979 soon as possible by globally disabling memory caching.
980 With 3.2.2 and later, you should export the environment variable
981 GLIBCPP_FORCE_NEW before running your program.
982 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
983 simply vanish (it is still not clear to me, whether this means that
984 STL std::string leaks or if valgrind believes it leaks...).
985 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
986 running bin/gdcmTests makeDicomDir):
987 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
988 - Test/makeDicomDir.cxx now properly traps empty lists and returns
990 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
991 SegFaulting (I drowned in DicomDir related code when trying to
992 understand why the list is empty...).
993 * src/gdcmDocument.h: first BSD license header try.
994 * Doc/License.txt added.
996 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
997 * src/gdcmDocument.[h|cxx]:
998 - Clean up of the Transfer related predicates. They are now all based
999 on new method isGivenTransferSyntax, that (should) handle properly
1000 the padding problem.
1001 - general clean up, simplification, and coding style.
1002 - Specific clean up of Parse7FE0() (umproperly named actually).
1003 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1005 2004-06-14 Jean-Pierre Roux
1007 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1008 - fix the display of SQItem ordinal number
1009 - add the GetSQItemByOrdinalNumber method
1010 - remove some useless never written private methods
1012 2004-06-14 Jean-Pierre Roux
1014 - adding a constructor taking a gdcmDocEntry as an input param
1015 - ReplaceOrCreateByNumber now returns :
1016 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1017 a gdcmValEntry * if a string value is passed as a param
1019 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1020 according to the param type (no longer sets a gdcmDocEntry)
1021 - GetValEntryByNumber, GetBinEntryByNumber added
1022 - NewValEntryByNumber and NewBinEntryByNumber added
1024 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1026 - GetSQItemNumber and SetSQItemNumber added, to provide
1027 a (relative) Item identier inside a given Sequence
1028 \warning : some pb remaining around this number
1030 - AddEntry now takes the Item Number as a param
1032 - adding a constructor taking a gdcmDocEntry as an input param
1034 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1035 * Memory leak hunt with the following command:
1036 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1037 --show-reachable=yes gdcmTests PrintDocument
1038 It looks like many (all?) leaks are due to the STL (or a bad usage
1039 of the STL. The lines producing the leaks now have a comment with
1040 a "MEMORY LEAK" tag: you can retrieve them with
1041 grep "MEMORY LEAK" src/*
1042 Here are two typical examples which I can't help fixing:
1047 char * test = "babo";
1048 name = test; //// <--- valgrind detects 960 bytes lost in
1049 //// call to std::string::operator=(char const*)
1050 name.clear(); //// Doesn't help !
1058 std::cout << "Type a bunch of characters followed by RETURN: ";
1059 getline(std::cin, line); //// <--- valgrind dectects a loss
1060 //// of 1320 bytes in call to
1061 /// std::basic_istream<>& std::getline<>
1067 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1068 * src/gdcmHeader.[cxx|h]:
1069 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1070 and related, moved away to gdcmDocument.
1071 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1072 the corresponding protected accessors of inherited class
1073 gdcmDocument, removed ! As a consequence gdcmFile had to be
1074 declared friend of class gdcmDocument (see below).
1075 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1076 - Clean up of undefined or unused methods.
1077 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1078 account the changes to gdcmHeader.h).
1079 * src/gdcmDocument.h:
1080 - gdcmFile is now a friend class (in order to take into account the
1081 changes to gdcmHeader.h).
1082 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1083 (see changes to gdcmHeader.h).
1084 - Accessors (reading on the form GetEntry*) are now public.
1085 - Clean up of undefined or unused methods.
1086 * src/gdcmDocument.cxx:
1087 - adaptation to changes to gdcmDocument.h
1088 - ::OpenFile now writes a verbose message when file cannot be opened.
1089 - some std::string properly set to VRKey
1090 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1091 references to gdcmDocument.
1092 * Test/TestFindTags.cxx: changed accordingly to above changes.
1093 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1094 cvs repository gdcmData.
1096 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1098 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1099 conflicts with gdcmValEntry::voidArea.
1100 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1101 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1102 Value representation between StringRepresentable and BinaryRepresentable.
1103 * src/gdcmDocument.cxx:
1104 - method ParseDES: proper indentation restored and usage of
1105 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1106 - method LoadDocEntry: the fingerprint left in the SetValue() of
1107 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1108 removed. Reverting to previous code segment with the proper
1109 dynamic_cast< gdcmValEntry* >.
1110 Note: this was (partially) breaking the python test suite
1111 (gdcmPython/testSuite.py) that made usage of the above
1112 fingerprint to check presence of "Pixel Data".
1113 * src/gdcmDocEntry.h: coding style.
1114 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1115 now taken into account.
1116 * gdcmPython/gdcm.i: adaptation to the new internal representation
1117 of gdcm (exit gdcmParser, hello gdcmDocument).
1118 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1120 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1121 anymore, but instead prints the loaded Python dictionary.
1122 * .... alas, the python testSuite is still broken.
1124 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1125 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1127 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1128 * src/gdcmUtil.h : export methods
1130 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1131 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1133 * Initial addition of automatic python testing
1134 * Initial addition of automatic image comparison
1136 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1137 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1138 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1140 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1141 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1142 * Test/ShowDicom.cxx : bug fix for msvc compilation
1143 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1145 2004-05-04 Jean-Pierre Roux
1146 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1147 new concepts (and new classes) :
1148 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1149 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1150 - Sequence Doc Entries (gdcmSeqEntries)
1151 a Sequence is composed of Items.
1152 Each item is a set of Doc Entries (this is recursive)
1153 The non uniqueness of the 'Dicom tag' is due to this recursivity
1154 (never taken into account)
1155 Our unability to add a new 'entry' in the header
1156 at the proper location (neither in the H-Table (map or multimap),
1157 nor in the Chained List is also due to this recursivity.
1158 Don't try, right now, to use/modify/compile these new sources :
1159 nothing is finished.
1160 We just commit all the stuff, 'as is', in order not to loose it.
1162 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1163 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1165 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1166 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1167 file prefix (SetFilePrefix)
1169 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1170 * Add a new test: ShowDicom, for now this is just the c++ version of
1171 checkRead.sh, later it will be able to compare the image read against a
1173 * Replace the DEBUG on the stack with a global entry in cmake interface:
1174 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1176 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1177 * Add an example subdir, with a real example on how to read + write a
1180 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1181 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1182 * Doc/CMakeLists.txt: the main page is now properly differentiated
1183 between the developper and user version.
1184 * Doc/doxygen.config.in: dropped search related obsolete flags
1185 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1187 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1188 * DEVELOPPER: added some helpfull comments for compile/test/install
1191 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1192 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1193 src directory, now generated in the build dir.
1194 2. Tests as mentionned smarter
1196 4. Add a new method in gdcmDict that return the PubDict by name
1197 this is interesting for 3rd party lib like ITK,
1198 where we could set the institution name / patient name...
1200 * ENH: 1. Now the test suite is working for real
1201 2. All binaries are now output in the gdcm-bin directory
1202 (this was not true before)
1204 2004-04-28 Jean-Pierre Roux
1205 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1206 SeQuence indented printing of Dicom Header.
1207 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1208 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1209 Computation of SQDepthLevel is now part of gdcmHeader constructor
1210 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1211 tree-like structure of a Dicom Header.
1212 * FIX Test code cleaning
1214 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1215 * ENH: Adding automatic testing
1216 1. Need a DartConfig.cmake to submit to public
1217 2. Add a test driver gdcmTest.cxx
1218 3. gdcmTestMain, an helper for the main test driver gdcmTest
1219 4. Files in Test don't have a main anymore, this becomes interesting
1220 when we add more and more tests, thus dsw don't have to load
1222 * ENH: Adding a GDCM_DATA_ROOT for testing
1223 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1224 one file instead of seven + some small cleanup
1226 2004-04-22 Jean-Pierre Roux
1227 * ENH Minor changes to the Print() methods.
1228 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1229 Header printing. Example given with :
1230 > PrintHeader fileName 2 new
1231 (SQ based tree-like structure still to be done for the Header ...)
1233 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1234 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1235 1. I have added some unsigned where needed
1236 2. Some function parameter not used -> (void)
1237 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1238 4. g++ don't like character '\' in comment
1239 5. #define jpeg_create_decompress jCreaDecompress
1240 this really need to be fixed
1241 6. virtualize destructor of gdcmObject ... leakage
1242 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1243 this also really need to be fixed
1244 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1245 remove compression file
1246 (as we only do decompression, right ?)
1247 * ENH: Change malloc/calloc/free with c++ equivalent
1249 2004-04-21 Jean-Pierre Roux
1250 * FIX gdcmHeaderHelper::GetXSpacing
1251 when a single value is found (bug ?), xpacing is now
1252 defaulted to yspacing
1254 2004-04-19 Jean-Pierre Roux
1255 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1256 * ENH add parameters :
1257 bool exception_on_error = false,
1258 bool enable_sequences = false,
1259 bool ignore_shadow = false
1260 to the gdcmFile constructors to be full gdcmParser compliant
1261 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1262 to allow reading of PAPYRUS 3.0 files
1264 2004-04-06 Jean-Pierre Roux
1265 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1267 2004-04-02 Jean-Pierre Roux
1268 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1269 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1270 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1272 2004-03-30 Jean-Pierre Roux
1273 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1274 for ACR file, written out as DICOM files (hope so...)
1276 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1277 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1278 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1279 moved to base class gdcmParser and only the specialisation is kept
1281 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1282 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1283 already does the job.
1284 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1285 (to be consistent with gdcmParser::WriteEntries).
1287 2004-03-30 Benoit Regrain
1288 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1289 upate of the object's instance. It's passed to 2 in the unfavorable
1290 case : one in the ExecuteInformation, one in the ExecuteData
1292 2004-03-29 Jean-Pierre Roux
1293 * ENH : Check on file type to be written moved
1294 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1295 * FIX : gdcmObject::ResetBoundaries now stops properly
1296 when end-of-list is reached
1297 : gdcmVersion modified (as Benoit Regrain asked)
1299 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1300 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1301 * src/gdcmUtil.cxx: added forgotten iostream include.
1302 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1303 equivalent to ExplicitVR in existing code).
1305 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1306 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1307 now contains all the gdcmGlobal related code.
1308 * minor coding style and doxygenation changes.
1310 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1312 now contains all the Debug related code.
1313 * minor clean-up of includes in src/*.cxx
1314 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1315 CreateCleanString) removed.
1316 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1317 * Doc/DoxyMainPageUser.txt added.
1318 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1319 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1320 src/gdcmDirList.cxx)
1322 2004-03-24 Jean-Pierre Roux
1323 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1325 2004-03-23 Jean-Pierre Roux
1326 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1327 big endian made volumes
1328 * ENH Now gdcmParser constructor and destructor are protected to forbid
1329 end user to instanciate class gdcmParser
1330 (only gdcmHeader and gdcmDicomDir are meaningfull)
1332 2004-03-22 Benoit Regrain
1333 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1334 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1335 gdcmSerie to gdcmDicomDirSerie
1337 2004-03-19 Jean-Pierre Roux
1338 * ENH Now the tree-like structure describing a DICOMDIR comming from
1339 an already existing DICOMDIR file is consistent with
1340 the home-made tree-like structure build ex-nihilo
1341 or build from the files held (recursively) in a Directory
1342 functions gdcmDicomDir::CheckBoundaries()
1343 gdcmObject::SetBoundaries() added
1345 2004-03-17 Jean-Pierre Roux
1346 * REM (Eric Boix bug) : removal of meaningless
1347 gdcmDicomDirImage::NewImage function.
1348 * FIX now file names and directory name are written properly in the
1350 * FIX now gdcmDicomDir constructor may be call without any trick
1353 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1354 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1355 of gdcmDicomDirImage::NewImage as empty function.
1357 2004-02-28 Jean-Pierre Roux
1358 * ENH add gdcmDicomDir:NewPatient
1359 add gdcmDicomDirPatient:NewStudy
1360 add gdcmDicomDirStudy:NewSerie
1361 add gdcmDicomDirSerie:NewImage
1362 to allow making gdcDicomDir object.
1363 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1364 (as opposite to the gdcmHeader chained list)
1366 2004-02-11 Benoit Regrain
1367 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1368 when using from python
1370 2004-02-10 Benoit Regrain
1371 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1372 * FIX : in gdcmDicomDir when the directory is empty
1373 * ENH : add callback and methods to get the progression of dicomDir
1376 2004-02-06 Jean-Pierre Roux
1377 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1378 - GDCM_META added to gdcmDicomDirType
1379 - class gdcmMeta created
1380 * ENH : - A brief summary is now displayed at the beginning of
1381 'testDicomDir' to help disaster magnitude estimation
1382 * REM : Now useless Test/explDICOMDIR.cxx
1384 2004-02-05 Benoit Regrain
1385 * ENH : add methods in gdcmObject to get the hash table or the list of
1387 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1388 * FIX : wrapping python for TagHeaderEntryHT
1390 2004-02-04 Benoit Regrain
1391 * FIX : even length for some strings when writting the dicom dir
1392 * FIX : sort the images in the dicom dir
1393 * FIX : Bug fix for python use of dicom dir
1394 * ADD : a python demo
1396 2004-02-04 Jean-Pierre Roux
1397 * FIX : Final solution (?) for icone embedded images
1398 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1399 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1400 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1401 gdcmData/gdcm-MR-SIEMENS-16.acr1
1402 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1403 to make full checking easier
1405 2004-02-04 Benoit Regrain
1406 * FIX : WriteEntries : coding style & logic in parameters
1407 * FIX : Set the elements to create the DicomDir in a dictionary file
1409 2004-02-03 Benoit Regrain
1410 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1411 * gdcmDicomDir : add the load of directory
1412 * Bug fix and print add-on
1414 2004-02-03 Jean-Pierre Roux
1415 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1416 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1417 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1418 * FIX gdcmParser.cxx : 'group length' elements are now considered
1419 as integers, even for shadow groups, when file is Implicit VR
1421 2004-02-02 Jean-Pierre Roux
1422 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1424 of the last synonym :-(
1425 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1427 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1428 * FIX taking into account the possible 7fe0,0010 multiplicity
1429 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1430 to allow removal of references to 7fe0,0010, to deal with
1431 ACR-NEMA images, when 0028,0200 is meaningfull
1433 2004-01-31 Jean-Pierre Roux
1434 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1435 no longer writes 'Un' on disk
1436 * FIX SQ elements with actual length are now dealt with corectly
1437 * FIX gdcmFile::WriteBase make the difference, for color images, between
1438 the length (for Palette expanded images)
1439 and Raw Length (non expanded image + Palette)
1440 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1441 (that broke Write). Replaced by UL.
1442 Aware user will reload the field if he
1443 thinks it's necesssary
1445 2004-01-30 Jean-Pierre Roux
1446 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1447 when 'dirty Acr' is found, to be compliant with the new
1448 IsReadable() methods.
1450 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1451 (no DOUBLE images in kosher DICOM,
1452 but so usefull for people that miss them ;-)
1454 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1455 DICOMDIR related utilities (not checked as Windoze compliant)
1457 2004-01-28 Jean-Pierre Roux
1458 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1460 2004-01-27 Jean-Pierre Roux
1461 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1462 to allow skipping the shadow elements, to save memory space.
1463 The TRUE value for this param has to be used
1464 with a FALSE value for the 'enable_sequence' param.
1465 ('public elements' may be embedded in 'shadow Sequences')
1466 * gdcmHeader methods now deal with 'embedded icones images' in the header
1467 (even when an 'icone image sequence' is announced by the
1468 element (0x0088,0x0200), but there is NO icone at all ...
1470 * gdcmHeader sometimes Image Location value doesn't follow
1471 the supposed processor endianity (see gdcmData/cr172241.dcm).
1474 * gdcmHeader add the method
1475 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1476 to get *all* the Header Entries with the same tag.
1477 GetHeaderEntrySameName is probabely *useless*
1478 (no meaning : Name is *not* an identifier within the Dictionnary)
1480 2004-01-26 Benoit Regrain
1481 * Bug fix in the print of hexadecimal representations. Remove long fields
1482 in the print and add a third level of print to print them
1484 2004-01-23 Benoit Regrain
1485 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1486 * Bug fix on test suite after remove the strip made on not string fields
1487 * Split the IsReadable method between gdcmParser which test that the file
1488 is dicom and gdcmHeader which test that it's an image file
1490 2004-01-22 Benoit Regrain
1491 * DicomDir : clean code, add methods, set variables in protected or private
1492 * gdcmUtil : bug fix for the clean string method
1494 2004-01-19 Benoit Regrain
1495 * Add the use of shadow dictionaries
1496 * bug fix and coding style
1498 2004-01-19 Benoit Regrain
1499 * src/gdcmFile.cxx : bug fix concerning the close of file
1500 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1501 * Add the update of header entries using the shadow library
1503 2004-01-19 Benoit Regrain
1504 * removal of file gdcmHeader2.cxx
1505 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1506 inheriting from gdcmParser. This split is to prepare the integration
1507 of dicom dir parsing
1508 * bug fix under python
1510 2004-01-16 Jean-Pierre Roux
1511 * REM removal of class gdcmHeaderEntrySet
1512 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1513 * ADD add file gdcmHeader2.cxx
1514 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1516 2004-01-15 Benoit Regrain
1517 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1518 entries created while parsing the header. Thus, they will be destroyed
1519 when the gdcmDictSet will be destroyed
1520 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1523 2004-01-15 Benoit Regrain
1524 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1525 made a fatal error because of the memory release at the end of program.
1526 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1527 some memory and vtk seems to have some problems with that.
1528 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1530 2004-01-14 Benoit Regrain
1531 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1532 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1533 * src/*.[h|cxx] : make changes due to class name changes
1534 * gdcmPython/demo/*.py : bug fix due to method names
1536 2004-01-13 Benoit Regrain
1537 * src/*.[h|cxx] : coding style
1538 * vtk/*.[h|cxx] : coding style
1540 2004-01-13 Benoit Regrain
1541 * gdcmPython/testSuite.py : test the readable flag of file for tests
1542 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1543 It's lied to the stl compilation by MSVC (windows, always windows...)
1544 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1546 2004-01-12 Benoit Regrain
1547 * src/*.h : add comments
1548 * src/gdcmDictSet.h : set the method BuildDictPath in public
1549 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1550 directly setted in the source code
1551 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1554 2004-01-09 Benoit Regrain
1555 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1556 * setup.py : use a reference to gdcmVERSION
1558 2004-01-07 Benoit Regrain
1559 * Modification to compile with the distutils.
1562 2003-12-10 Benoit Regrain
1563 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1564 can use a gdcmHeaderHelper to load datas
1565 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1566 made in the source code
1568 2003-12-10 Benoit Regrain
1569 * Update Windows projects and .cvsignore files
1571 2003-11-12 Jean-Pierre Roux
1572 * ENH gdcmHeader constructor has one more parameter (default value : false)
1573 that allows the user to 'go inside' the SeQuences only
1575 gdcmElValSet:Print takes it into account
1577 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1578 * ENH: Update gdcmPython/CMakeLists
1579 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1580 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1582 2003-11-10 Jean-Pierre Roux
1583 * FIX : gdcmHeader::LoadElements is now based
1584 on the ListTag listElem member,
1585 not longer on the TagElValueHT tagHt member
1586 * ENH : PrintPubElVal shows (temporarily) both results,
1587 with the tagHt member and the listElem member.
1588 (it's easier to 'see' the problems when using Printheader)
1590 * FIX : old private member LgrElem is now splitted into
1591 ReadLength : Length actually found on disk (updated only
1592 if bug fixing is necessary), for internal
1594 UsableLength : Updated by FixFoundLength, to fix a bug
1595 or to allow Parser going on.
1596 Will allow to re-write a kosher header when a SeQuence
1597 with a length (not 0000) is found
1598 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1599 because gdcmElValSet::Add does not update ListElem
1602 2003-11-07 Jean-Pierre Roux
1603 * FIX misstyping in Transfert Syntax name table
1604 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1605 when they have an actual length (not 0000 nor FFFFF)
1606 (Nobody should care of it, but DICOMDIR explorers)
1608 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1609 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1611 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * ENH: vtkGdcmReader now supports LUT !
1613 (vtkgdcmViewer for now is not able to use them though)
1615 2003-11-05 Jean-Pierre Roux
1616 * in testSuite.py : new files names for checking the package
1617 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1618 that returns the pixel area size to the *aware* (vtk) user
1619 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1621 2003-11-05 Benoit Regrain
1622 * in testSuite.py : Modify the rules for checking the paths
1623 : Explicit error messages
1624 * in __init__.py : Related modif
1626 2003-11-03 Jean-Pierre Roux
1627 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1628 to be used by aware (vtk) users that want to manage
1629 LUT (and no to turn the PALETTE image into an RGB pixels one)
1630 * GetPixelType now returns 8U for 24 Bits images
1631 (vtkGdcmReader compliant)
1633 2003-10-31 Jean-Pierre Roux
1634 * Removal of *all* gdcmData images and add them again
1635 in order to loose the 'history' of un-anonymised images
1637 2003-10-31 Jean-Pierre Roux
1638 * RMV : removal of useless jBitsInJsample.h
1639 for both 8 and 12 Bits JPEG Lossy Libraries
1641 2003-10-31 Jean-Pierre Roux
1642 * ENH : Add the functions gdcmFile::GetImageDataRaw
1643 gdcmFile::GetImageDataIntoVectorRaw
1644 that act as GetImageData and GetImageDataIntoVector
1645 except the making of an RGB Plane from Gray Plane + LUT
1646 Intended to aware (vtk) users who know how to manage
1649 GetLUTRGBA return a R,G,B,A LUT if any
1650 lgrTotaleRaw gives the 'Raw' length
1651 GetImageDataRaw returns the gray Plane
1652 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1653 (They stay Grey, just like with other Dicom viewers :-(
1655 2003-10-30 Jean-Pierre Roux
1656 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1658 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1660 being coherents dicom files.
1662 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1663 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1665 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1666 * ENH: Two steps is necessary to please VC++ compiler...
1667 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1668 * ENH: Add include dir to medcon lib
1669 * FIX: only one function is being exported for now !
1670 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1672 2003-10-29 Jean-Pierre Roux
1673 * adding gdcmHeader::GetLUTRGBA
1674 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1675 --> Mathieu, the modif u're waiting for is not yet committed
1676 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1678 2003-10-27 Jean-Pierre Roux
1679 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1680 00191113.dcm DermaColorLossLess.dcm
1681 MxTwinLossLess.dcm RadBWLossLess.dcm
1682 * ENH: For version prior to vtkImageViewer2 -r 1.19
1683 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1685 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1686 * Removal of ido stuff in CMakeLists.txt
1688 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1690 * FIX: remove a call to ->Modified ... see comments
1691 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1693 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1694 * FIX: Problem with path for libvtkgdcmPython
1695 * ENH: Try adding a search script for python site-package
1696 * RMV: Remove some file from medcon lib that are not necessary
1697 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1698 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1699 * FIX: More pragma disable fro VC++,
1700 I don't think I break something as it is also disable in VTK/ITK.
1701 But it fasten debug compilation time.
1703 2003-10-23 Jean-Pierre Roux
1704 * gdcm now deals with 16 Bits Run Length Encoded images
1705 (they are compressed as 2 planes images,
1706 one for the high Bytes, the other for low Bytes)
1708 2003-10-22 Jean-Pierre Roux
1709 * Now CheckRead takes into account :
1710 - the bugged 'Leonardo' Siemens images
1711 - the XA images, sent thru the burning VPRO station
1712 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1715 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * FIX: When copying a Makefile.am to CMakeLists.txt
1717 one should remove the '\'
1719 2003-10-22 Jean-Pierre Roux
1720 * in gdcmData adding a bugged 'Leonardo' Siemens image
1721 (wrong lengths in header)
1722 OK with gdcm, KO with the other viewers :-)
1723 * add a GE dlx XA image, thru the VEPRO burning station
1726 2003-10-21 Jean-Pierre Roux
1727 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1728 for a brutal checking of vtkgdcmViewer compliance
1730 2003-10-21 Jean-Pierre Roux
1731 * add the files for 'xmedcon' Jpeg Lossless library
1732 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1734 2003-10-21 Jean-Pierre Roux
1735 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1737 2003-10-21 Jean-Pierre Roux
1738 * garbage Siemens 'Leonardo' images dealt with
1739 (the patch is easy to remove)
1740 * cosmetic changes to avoid warnings
1742 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1743 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1744 no need to press 'r' now.
1746 2003-10-20 Jean-Pierre Roux
1747 * upgrade of checkRead.sh checkWrite.sh according
1748 to new Jpeg Lossless decompressor
1749 * add US.3405.1.dcm, a genuine RGB medical file ...
1750 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1751 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1753 2003-10-15 Jean-Pierre Roux
1754 * general anonymisation in gdcmData
1755 * adding the 'color files' from
1756 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1757 * adding some well knowed bugged-header images
1758 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1759 waiting for their inclusion in Python testsuite
1761 2003-10-15 Jean-Pierre Roux
1762 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1763 no longer seg faults when file is not found
1765 2003-10-14 Jean-Pierre Roux
1766 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1769 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * TODO: *.in file to genereate a UseGDCM later
1772 2003-10-14 Jean-Pierre Roux
1773 * Some supposed-to-be Dicom Images have no preamble.
1774 OpenFile takes it into account
1775 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1776 * Missing elements added in dicomV3.dic
1777 (just to be affraid : have a look at
1778 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1779 and do it again next year ;->
1781 2003-10-13 Jean-Pierre Roux
1782 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1783 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1784 But there are NOT. It's fixed !
1786 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1787 * FIX: "jpeglib.h" was not found on VC++
1788 * FIX: vtkgdcm was not being installed
1790 2003-10-10 Jean-Pierre Roux
1791 * ENH : OpenFile closes the file if it *really* doesn't look like
1792 an ACR-NEMA / DICOM one.
1793 * FIX : testWrite no longer writes an empty file if the source file
1794 is not gdcm Readable
1795 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1798 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1799 * FIX: CMake generate now documentation
1800 * ENH: out of source doc build !
1801 * ENH: Generate both user and dev documentation
1802 * ENH: Should work on windows too
1803 * ENH: Only one doxygen config.in file is needed
1804 * FIX: make install should be ok now on ùnix plateform
1805 * FIX: PATH to dictionary was wrong (missing /)
1806 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1808 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1809 * vtkGdcmReader is now able to read rgb dicom file.
1810 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1811 * added a gdcmViewer to vtk test, use mouse to control
1812 window level & window width
1814 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * CMake-ification of gdcm, we have now two build system
1816 * FIX: on cygwin Wsock32 doesn't exist
1817 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1819 2003-10-06 Emanuel Ollart
1820 * FIX : compilation process wad broken.
1821 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1823 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * change gdcmViewer -> vtkgdcmViewer
1825 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1827 2003-10-06 Jean-Pierre Roux
1828 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1829 ( e.g : well known GE images with a wrong elem length,
1830 : Philips MRI Images with a wrong Huffman table)
1831 * still to be done : allow the reading of bugged LEONARDO Siemens images
1833 2003-10-03 Jean-Pierre Roux
1834 * Odd length strings are padded with '\0' (not with spaces,
1835 to remain compliant with already defined strings,
1836 like Transfert Syntax UID and others)
1838 2003-10-03 Jean-Pierre Roux
1839 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1840 to allow displaying RGB images (not only by affim ;-)
1842 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * vtkGdcmReader is now able to read rgb dicom file.
1844 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1846 2003-10-03 Jean-Pierre Roux
1847 * A few nasty patches to allow the reading of a lot of nasty images
1848 ( e.g : well known GE images with a wrong elem length,
1849 : Philips MRI Images with a wrong Huffman table)
1850 * still to be done : allow the reading of bugged LEONARDO Siemens images
1852 2003-10-03 Jean-Pierre Roux
1853 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1855 2003-10-03 Jean-Pierre Roux
1856 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1857 to allow displaying RGB images (not only by affim ;-)
1859 2003-10-03 Jean-Pierre Roux
1860 * gdcmFile::GetImageDataIntoVector now
1861 - deals with MultiFrames MultiFragments Run Length Encoded files
1862 - deals with YcBcR (YBR_FULL) files
1863 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1864 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1866 (no sample found :-(
1868 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1870 Two reasons: - clear things
1871 - third parties acces gdcm through header files, so won't
1872 suffer anymore VC++ complains
1874 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * add argv[1] in testvtkGdcmReader.cxx
1878 2003-09-24 Jean-Pierre Roux
1879 * The lines are now eigthy characters long.for
1880 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1882 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1883 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1884 char* to std::string. Thus, the use of strdup becomes useless. (see
1885 previous commis of Malaterre)
1886 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1887 before the last Malaterre's commit.
1889 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * This commit should fix the Debug building under VC++, the problem
1891 was mainly a mixture of debug and release lib being loaded at startup.
1892 * I also remove a depency to a specific C function: strdup. Because I had
1893 to force the link to msvcrtd (whereas strdup is in libc).
1895 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1897 located in the gdcmCommon.h file. All use of reference of tha has been
1898 changed to now use the variable GDCM_UNFOUND.
1900 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1902 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1903 Dicom dictionary. The test suite can now be run again. Note:
1904 I'm note very happy with the " (RET)" changes. I believe this
1905 RETAINED comment should be dropped when parsing the dictionary.
1906 - PACKAGER corrected
1908 - AUTHORS updated and now in alphabetical order
1909 * Makefile.am now exports gdcm.dsw for Windoze users.
1911 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1912 * cygwin complains about missing std:: in subdir Test/
1914 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1915 * remove some methods that are now in gdcmHeaderHelper
1917 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * vtkGdcmReader set spacing and origin correctly
1920 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * Fix a few delete/delete[] mismatch
1923 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1925 interpretation to data given by gdcmHeader. For instance there are
1926 heuristics to get informations (look at different places).
1927 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1928 sorting DICOM images based on different strategies.
1929 * modified Makefiles accordingly.
1931 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1933 when building in debug mode
1934 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1935 src/win32/gdcmdll.dsp
1936 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1938 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1942 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1943 * src/win32/libgdcmjpeg12.dsp was not dos format
1944 * src/win32/libgdcmjpeg12.dsp :
1945 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1946 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1948 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1949 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1951 * src/gdcmFile.cxx : bug fix in affectation type
1952 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1953 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1954 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1955 symbols... future problem ?
1957 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * src/win32/libgdcmijpeg12.dsp was missing
1959 * modified gdcm.dsw accordingly
1961 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1964 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1965 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1966 commit of JPR (before his hollidays to facilitate our work).
1967 * setup.py : bug fix in code. Modifications made while the last commit
1968 of JPR. The code hasn't been tested before the commit... it's so
1969 useless to make that (for best programmer that is JPR) !!!
1971 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1972 * tagged the current version as Version0_3 (i.e. version 0.3)
1974 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1975 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1976 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1977 * *.dsp : modifications to use new libgdcmijpeg8 library
1978 * setup.py : bug fix on VTKPATH variable
1979 * PACKAGER : adding all concerning windows
1981 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1984 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1985 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1986 test suite reported error.
1987 * PACKAGER file added (describes what a packager must do when
1988 packaging a new release).
1989 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1990 * configure.in: upgraded version number to 0.3.0
1991 * fixing build of rpm (through rpm -ta):
1992 - Doc/Makefile.am exports proper doxygen files
1993 - src/jpeg/libijg8/Makefile.am exports the include files.
1995 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1996 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1997 * src/gdcmHeader.h : formatting code
1999 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2000 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2001 We were obtaining error message from vtk. Now, creation of file list
2002 is made in an internal list to prevent this problem.
2003 Bug fix when output is empty.
2004 Bug fix in update of progress value. Previous commit for this was a bad
2006 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2008 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2009 * src/gdcmHeader.h : added method to get the file name
2010 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2011 files. Added method to remove all files on the input
2012 Added FIXME comment concerning the bad parsing of header made by
2013 ExecuteInformation method (in ExecuteData method)
2015 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2017 when using make instal.
2018 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2019 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2021 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2022 * setup.py : adding include dir of jpeg lib to compile all sources
2023 * */Win32/*.dsp : JPR fix for windows compilation
2025 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2026 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2028 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2029 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2031 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2032 * setup.py is again effective on un*x (takes into account the
2033 addon of the jpeg library)
2034 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2035 * Doc/Doxy* updated (includes above enhancements)
2036 * INSTALL now points to web documentation
2038 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * src/gdcmHeader.h doesn't make unnecessary reference to
2041 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2043 * src/gdcm*.[cxx|h] :
2044 - to allow compilation with gcc 3.x
2045 -- clean up of STL usage (added explicit usage of std::)
2046 -- small fixes on exceptions.
2047 Note: linking not tested !
2048 - clean of doxygen comments to avoid warnings at documentation
2050 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2051 dependent convertion).
2053 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2054 * Clean up of previous JPR garbage commit (not even commented in the
2056 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2057 - moved all jpeg related files from src to src/jpeg/libijg8, with
2058 addition/modification of Makefile.am and configure.in.
2059 - the testSuite is still brain damage (not guilty).
2061 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2062 * WrapVTK.py : modifications to get correctly vtk source files to
2064 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2065 (FileName -> Filename)
2067 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * vtk/vtkGdcmReader.[cxx/h]:
2069 - UpdateProgress method should now be effective
2070 - removed the limitation on having only images loaded (as opposed
2072 - when building a stack of images/volume, a lesser number of
2073 gdcmHeader and gdcmFile instances should be used (hopefully
2074 accelerating things).
2075 - when building a stack of images/volumes, files which are not
2076 loadable (wrong path-filename, wrong permissions on existing file,
2077 or file not parsable by gdcm) are replaced with a black image
2078 in the stack (for the caller to notice the problem).
2080 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2083 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2084 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2085 between standard library (std) and vtk library (problems are found
2086 under Windows... thanks Windows !)
2088 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2091 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2093 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2096 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2097 * When compiling with distutils (see setup.py) the C++ compiler is
2098 called with different flags than the default ones (with automake).
2099 In order to fix all those warning, I compiled gdcm with the command
2100 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2101 and went for warning fixes:
2102 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2103 up from unused variables.
2104 - vtk/vtkGdcmReader.cxx: potential bug fix.
2105 * src/gdcmHeader.h: Doxygen warning cleanup
2107 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * gdcmPython/gdcm.i:
2109 - typemaps correction to take into account the systematic replacement
2110 of "using namespace std" with std:: prefix e.g. std::list,
2111 std::string... (cf changes of 2003-05-21).
2112 - gdcmGlob global variable of type gdcmGlobal (defined in
2113 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2114 exported to Python a as cvar.
2115 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2116 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2117 gdcmDictSet.GetPubDictTagNames() and
2118 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2119 C++ static methods).
2120 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2121 with the above changes.
2123 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2124 * setup.py, manifest.in : bug fix under linux
2126 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2127 * Modification of setup.py to compile vtk part too. Then, we have 2
2128 wrappers which must work with same distutils. For that, we have a
2129 generic distutils in distusiltsWrapping.py ; with :
2130 - build_extWrap class to wrap generically all extensions,
2131 - ExtensionWrap base class for all wrapping extension that contains
2133 - Wrapper interface which wrap sources
2134 + In WrapSwig.py we have extension and wrapper for Swig
2135 + In WrapVTK.py we have extension and wrapper for VTK
2136 * MANIFEST.in : modifications to consider vtk directory and new python
2137 files for compilation
2139 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2140 * Added python wrappers of vtkGdcmReader vtk class (see the
2141 source in vtk/vtkGdcmReader.cxx) :
2142 - vtk/Makefile.am now builds a library
2143 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2144 python library (as opposed to _gdcm.so wich are the python
2145 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2146 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2148 - configure.in has an additional flag --enable-vtk that needs
2149 to be set to enable compilation of vtk related code, that is:
2150 + vtk/vtkGdcmReader.so and
2151 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2152 + gdcmPython/vtkgdcmPython.so (see above)
2153 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2154 be read when compressed or when HighBit + 1 != BitsStored),
2155 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2156 the usage of the python wrapper of vtkGdcmReader vtk class.
2157 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2158 * src/*.[h] all occurences of stl classes are now prefixed with
2159 std::, and all occurences of "using namespace std;" where removed.
2160 This is to avoid pollution of global namespace in included files.
2161 Apparently vtk does not avoid this pitfall: when using both
2162 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2163 collision of various stl members (principally cout...).
2164 * gdcmPython/testSuite.py now cleanly removes temprory generated
2166 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2167 comply with above changes)
2169 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2170 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2171 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2172 vtk data structure (an image Flip was required).
2173 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2174 * cosmetic changes in documentation.
2176 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2177 * src/gdcmHeader.cxx: the constructor no longer exits when an
2178 unexisting file is given as argument.
2179 * The subdirectory Data (containing all the images used for the
2180 test suite) is not part of this repository anymore. A new module
2181 containing those images is now available at
2182 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2183 with the name gdcmData.
2184 All the python scripts (including the package initialisation file
2185 gdcmPython/__init__.py) were adapated to take this change into
2186 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2188 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2189 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2190 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2191 demo of the usage of this class.
2192 Compilation of this vtk part is only done when using the --enable-vtk
2193 at configure (or autogen.sh) stage.
2195 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2196 * More memory link related corrections and documentation fixes.
2198 - maximum info is obtained with a command of the form:
2199 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2200 --show-reachable=yes PrintHeader
2201 - the remaining reachable blocks seem to come from the STL
2202 allocation scheme through the usage of map and list. It looks
2203 like this memory cannot be freed but it is not a memory leak
2204 (in fact further invocation to the STL would recollect the
2205 unused memory allthough it cannot explicitely be freed).
2206 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2207 of displaying an image parsed with gdcm and displayed with VTK.
2208 Note: some images don't seem to work e.g.
2209 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2210 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2211 Allthough this weakens the semantics, it is a ditch attempt to
2212 make gdcm more thread friendly.
2214 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2215 * Memory link hunt (by using valgrind through the command
2216 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2217 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2218 gdcmHeader::_dicom_vr.
2219 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2220 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2222 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2224 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2225 * src/Makefile.am now exports all the necessary include files at
2229 * UpdateGroupLength replaced by new one
2232 * UpdateGroupLength re-written using H-Table
2233 (named UpdateGroupLengthNew untill checks are over)
2235 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2236 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2237 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2239 - gdcmHeader::GetPubElValSet removed.
2240 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2241 UpdateGroupLength, WriteElements, Write.
2242 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2243 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2244 carried the same semantics.
2245 - src/gdcmHeaderIdo.cxx changed accordingly.
2246 - gdcmFile::WriteBase now regroups all the codes from previous
2247 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2248 - enum FileType moved to gdcmCommon.h
2249 * src/gdcmHeader.cxx AddDefault trashed
2250 * gdcmGetXSize added
2251 * getimageDataSize now calls gdcmGetXSize
2252 * Test/*.cxx changed to agree with above changes
2254 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2256 (to avoid double call by end user).
2257 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2258 by end user, since gdcmHeader::gdcmHeader now handles it.
2260 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * gdcm/Doc many doxygen changes:
2262 - Doxyfile now has two different versions, DoxyfileUsers that generates
2263 the html.users end users oriented documentation and
2264 DoxyfileDeveloppers that generates the html.developper developper
2265 oriented documentation.
2266 - README changed accordingly
2267 - requirement.txt removed (old design info moved to TODO).
2268 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2269 DoxyMainPage.txt, DoxyPython.txt provide more information.
2270 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2271 be updated by simply regenerating the docs with doxygen and copying
2272 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2273 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2274 all the tests in the form "if (<map>.count() >1)" were removed.
2275 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2276 ill-formed documentation sections.
2277 * src/gdcmHeader.cxx: ditto
2279 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2280 * setup.py fixed for un*x (needed macro for stdint.h)
2281 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2282 un*ces with sh-utils test utility.
2283 * gdcmPython/demo/test.py renamed to PrintHeader.py
2284 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2285 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2286 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2287 * src/gdcm*.cxx JPR's bad inclusion fixed.
2289 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2290 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2291 * gdcmPython/demo/test.py changed accordingly.
2293 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * gdcmPython/Makefile.am fixed linking against libstdc++
2295 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2296 * Swig subdir (historical tests of swig version 1.3.17++) removed
2297 * Test/testChangeEntete.cxx some lines commented out in order to make
2299 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2300 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2302 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2303 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2304 hence the user doesn't need this explicit call.
2305 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2306 i.e. LoadElements() call removed.
2307 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2308 - src/Makefile.am declares the proper flag for g++.
2309 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2310 for adding user defined new tags.
2311 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2312 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2313 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2315 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2316 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2317 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2318 src/Makefile.am : the project should properly compile and install
2319 with the autotools, included the python wrappers part.
2320 * gdcm.spec.in : added a spec file for RPM packaging.
2322 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2323 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2325 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2326 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2327 to exported to the environement (see gdcmPython/testSuite.py
2329 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2330 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2331 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2332 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2333 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2335 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * gdcmPython/__init__.py doesn't crash anymore when running in
2337 in InstallMode or PreInstallMode but with an environement given
2338 value of GDCM_DICT_PATH.
2339 * src/gdcmDictSet.[cxx/h] coding style.
2341 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2343 * src/gdcm.h general comments moved to TODO, and README
2344 * src/gdcm.h should now be seen as a user commodity (including it
2345 should suffice to fully use gdcm). It is nowhere including within
2346 any of the kernel files src/*.cxx and src/*.h.
2348 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2350 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2352 * src/gdcm*.cxx only include their corresponding include file
2353 (as opposed to gdcm.h)
2354 * gdcmPython/gdcm.i changed accordingly
2355 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2356 the autogen.sh generated "make snapshot" command to work.
2357 * autogen.sh removed history related references to crea package.
2359 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * distutilsSwigCPlusPlus.py work around some swig portability
2363 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2364 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2365 was done in a last ditch attempt to get setup.py _really_
2366 operationnal. The python/gdcmPython layaout add the advantage
2367 of hidding away the python related distutils specific files
2368 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2369 Alas, the src directory was out of scope (i.e. it's relative
2370 position to setup.py was ../src) which made things impossible to
2371 handle (see previous version of python/setup.py). Crossing fingers...
2373 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2374 * python/setup.py now works on Un*x. (harder than I thougth)
2375 * python/distutilsSwigCPlusPlus.py can now have include files
2376 among the list of sources.
2378 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2379 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2380 * modifications in MSVC projects
2382 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * As stated by the first lines of Test/ExceptionAndPython/README, it
2384 looks like we can move back to original usage of exception within
2385 src/gdcm* and hence remove the errno stuff that was introduced
2386 as a quick and dirty fixture of this problem (added to the TODO).
2387 * Doc/Doxyfile configuration file for Doxygen and corresponding
2388 README file for usage added.
2389 * Test/testWrite.cxx added. This new test comes from a split of
2390 test.cxx that is now reverted to its original purpous i.e.
2391 testing the proper parsing of a Dicom related file.
2392 testWrite.cxx concentrates on testing the IO part of gdcm.
2393 * Test/bug1.cxx (containing a bug on WIn32) added.
2394 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2395 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2396 whose purpose is to publish the content of the TagNames of the
2397 Dicom public dictionnary were not accessible without an
2398 instance of class gdcmHeader.
2399 - those methods are now static methods of gdcmDictSet and hence
2400 require no instances at all to be invocated.
2401 - within gdcmDictSet this change required to change some method
2402 to class methods (i.e. are now static) among which SetDictPath
2403 (renamed to BuildDictPath) and LoadDefaultPubDict.
2404 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2405 the above changes by calling the new method classes of gdcmDictSet.
2406 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2407 the above to be effective.
2408 * python/gdcmPython: in order to wrap properly the above changes
2409 for Python, swig version now needs to be > 1.3.17.
2410 * python/gdcmPython/Makefile fixed to adapt itself to new
2411 configure/make shema introduced by Johan Montagnat (thanks for the
2412 contribution). Alas this Makefile cannot be turned into a proper
2413 Makefile.am without some heavy changes in the configure.in
2414 (for python dectection).
2415 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2416 now avoids publishing the empty entries.
2418 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2419 * python/setup.py : bug fix concerning install under windows
2420 ExtraPath reused :-P
2421 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2423 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2424 * Dicts/dicomV3.dic : remove double spaces !!!
2425 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2426 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2429 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2430 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2431 method. Doxygenation.
2432 * src/gdcm.h clean up of JPR spurious comments.
2434 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2435 * python/distutilsSwigCPlusPlus.py now properly collects the
2436 shadow classes generated by "swig -c++" (gdcm.py in our case)
2437 when using "python setup.py install".
2438 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2439 reexports the working classes.
2440 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2441 by the classical C errno scheme. This is to prevent an obscure
2442 behavior of the python wrappers when importing wxPython.wx prior
2443 to gdcmPython (which ended up in an abort call). An illustration
2444 of this oddity can be found in the Test/ExceptionAndPython
2445 subdir (see the README file). This problem probably due to
2446 an combination of g++ and dynamic loading.
2447 * added Test/ExceptionAndPython (see above)
2449 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * Changed the layout of the python part to avoid bloating main
2451 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2452 i.e. the distutils arsenal. All the python related stuff is
2453 again in a python subdir, but the package itself is now in
2455 * setup.py was cleaned up:
2456 - pythonIncludePath removed
2457 - python setup.py bdist target is now functional.
2458 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2459 collision with other packages). gdcmPython/demo/*.py changed
2462 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2463 * python subdir moved to gdcmPython (preparation of distutils packaging).
2464 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2465 distutils installer is operational.
2466 * - gdcmPython/__init__.py now properly loads the swig generated
2467 shadow classes (from gdcm.py).
2468 - gdcmPython/demo/*.py changed to import the package gdcmPython
2469 instead of gdcmPython/demo/load.py.
2470 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2472 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2474 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2475 entries within the associated public Dicom dictionary resp. the same
2476 information but sorted by the fourth field (PAT, IMG, DIR) of the
2478 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2479 are now in the "???" group.
2480 - python/gdcm.i changed accordingly,
2481 - python/demo/printGroupedPublicDict.py added, that gives an example
2482 of the above new functionalities in Python.
2484 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2485 * src/gdcm.h, gdcmHeader.cxx:
2486 - historic references to glib's g_malloc and g_free (#defined)
2487 were definitively removed.
2488 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2489 * src/gdcmElValSet.cxx:
2490 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2491 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2492 - GetElValue(string) renamed to GetElValueByName.
2493 - Added GetElementByName(string).
2494 * src/gdcmHeader.cxx: added
2495 - GetPubElValRepByNumber(guint16, guint16)
2496 - GetPubElValRepByName(string)
2497 - GetShaElValRepByNumber(guint16, guint16)
2498 - GetShaElValRepByName(string)
2499 - GetShaElValByNumber(guint16, guint16)
2500 - GetShaElValRepByName(string)
2501 - GetElValRepByNumber(guint16, guint16)
2502 - GetElValRepByName(string)
2503 - GetElValByNumber(guint16, guint16)
2504 - GetElValRepByName(string)
2505 * Doc/requirements.txt added.
2507 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * Test/Makefile building now depends on the one of libgdcm.so
2509 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2510 pixel data) aware which enables finding the address (offset) of
2511 the pixel data of JPEG encoded DICOM files. This leaves only a single
2512 file in the testSuite whose pixel data address (offset) is unknown.
2513 * python/testSuite.py changed accordingly.
2515 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2516 * VC++ has some strong limitations when working with the STL, as stated
2517 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2518 "Also note that some STL containers (map, set, queue, list, deque)
2519 cannot be exported. [...]
2520 Some STL classes contain nested classes. These classes can not
2522 This is caused by a designed limitation that once a template
2523 class is instantiated, it can not be re-instantiated and
2525 Since our usage of map<> is ubiquitous in gdcm, this "designed
2526 limitation" of VC++ is a pitfall.
2527 Hence the Python wrappers of gdcm cannot be incrementally linked
2528 against the c++ dynamic library. The dirty but only workaround is
2529 to forget about incremental link of dynamic libraries and to generate
2530 the Python wrappers library with the inclusions of the underlying C++
2532 The following modifications concern this matter on Win32/VC++:
2533 - wrapping python correct with standalone wrapped dll (don't use separate
2534 dll under windows !!!!)
2535 - python21_d debug mode enabled (ask Frog how to use it :-)
2536 - NO problem with having an STL member of class for example string in C++
2537 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2538 - Python test of dcmlib in Python is ok under windows on a large set
2540 * removed glib references
2541 * typedef's inserted in gdcm.i for correct swig type management
2543 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2544 * python/demo/*.py load.py extracted from test.py. Added explore.py
2545 that only displays required tags and testAll.py that parses all
2546 the files of the testsuite without using unittest.
2547 * python/testSuite.py other additional test on new files added.
2548 * Data/* new test files added accordingly to the testSuite.
2549 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2550 the vr in the file differs from the one of the dictionary.
2552 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2553 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2554 values, but limits itself to values which are below a user specified
2555 size (by default 1024 bytes).
2556 * python/gdcm.i : elements not loaded (because their size is above the
2557 user specified treshold) are exported with their TagKey as key of the
2558 python dictionary. This enables the testsuite to make some checks
2559 on the unloaded elements (since we have their offset and size).
2560 * python/testSuite.py
2561 - now tests for the existence and proper value of the pixel data
2562 - two new examples added.
2563 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2565 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2567 aware. See the strategy comments in gdcmHeader::FindeLength().
2568 * Test/test.cxx now accepts a filename as first argument.
2569 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2570 * python/testSuite.py changed to integrate test on above files.
2572 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2574 the vr was also RET.
2575 * python/testSuite.py more tests added.
2577 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2578 * python/testSuite.py unittest test suite added (uses Data)
2579 * Data/* dcm and acr files for the test suite.
2580 * glib dependance removed from un*x version. We now use ISO C99
2581 7.18 Integer types (see stdint.h)
2582 - python/Makefile, src/Makefile src/gdcm.h
2583 * src/ when an explicit vr (like dicom files) suddenly poped an
2584 implicit element we use to mark the underlying DictEntry of the
2585 concerned ElValue with "Implicit". This strategy was damageable
2586 too the public or provite dictionaries, since some of their vr
2587 would be changed. Since Header::FindLength heavily relies on the
2588 detection by Header::FindVR of falsely explicit elements, I
2589 added an extra ImplicitVr member to ElValue (boolean).
2590 The rest of the changes we the necessary adaptations.
2592 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2595 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2597 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * Adaptation for porting to VC++:
2600 o forced to use std namespace (for string to be known)
2601 o all class use __declspec export style on WIN32
2602 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2603 (in stdlib.h on Win32 but in std:: for gcc)
2604 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2605 variable GDCM_DICT_PATH.
2606 * src/gdcmHeader.cxx verbose comments made discrete.
2608 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2609 * python/gdcm.i: added a typemap that converts a C++ hashing table
2610 to native Python dictionary.
2611 * python/demo/test.py:
2612 - now uses the native dictionary for exploration of gdcmHeader.
2613 - takes an optional filename argument (the file to parse).
2614 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2615 PubElVals hashing table.
2616 * Dicts/dicomV3.dic removed error prone trailing spaces.
2618 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * Python wrapping process moved away from src/Makefile to
2620 newly created python/Makefile (as well as gdcm.i)
2621 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2622 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2623 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2624 from the environement variable GDCM_DICT_PATH (when existing).
2625 * src/gdcmDict::GetTag bug fix.
2627 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * Straightforward temporary fixes for swig to build the python wrappers.
2629 src/Makefile now has a python working entry [by working we mean
2630 that we can import de shadow classes without errors].
2632 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2633 * hashtest.cxx removed (since allready in Test)
2634 * src/gdcmlib.h renamed to src/gdcm.h
2635 * src/dcm.i renamed to src/gdcm.i
2636 * src/Makefile prepared for python wrapping
2638 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2639 * src/gdcmHeader.cxx :
2640 - Parsing of header is now separated from loading of element values
2641 (see gdcmHeader::LoadElements).
2642 - general clean up of hopefully all file access (creation of
2643 ReadInt16 and ReadInt32)
2645 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2646 * src/gdcmHeader.cxx :
2647 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2649 - SetLgrElem renamed to SetLength
2650 - GetLgrElem renamed to GetLength
2651 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2652 * src/gdcmElValSet.cxx fixed both GetElValue methods
2653 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2654 due to IdoDude was cleaned out.
2656 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2657 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2658 concentrates on finding the value representation (when it exists).
2659 RecupLgr now only finds the element value length, and it avoids
2660 returning the unecessary skL (skipped length).
2661 Also, offsetCourant was simply removed (with taille_fich) since
2662 it was redundant with the File position internals (by using
2663 ftell and fseek). This also made skL (see above in RecupLgr) usage
2665 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2666 on the libido specificities which are handled through class
2668 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2671 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * Truckload of changes. Parsing of header is barely functional
2673 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2675 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * src/gdcmHeader.cxx many addons of low level methods
2678 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2679 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2680 and _IdDcmSWAP_LONG.
2682 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * This corresponds to all the changes decided at the meeting of
2684 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob