1 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
3 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
5 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
7 At this time, this image isn't readable by e-film... waiting JPR help to
10 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
12 DocEntry. Now use methods of the Document !
14 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * Test/ShowDicomSeq.cxx : bug fix
17 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
19 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
20 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
21 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
23 * Test/TestCopyRescaleDicom.cxx : remove unused variable
24 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
25 containing found sequences
27 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
30 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
31 Some fields in BinEntry must be copied to not seg fault when making the :
32 gdcm::File *copy = new gdcm::File( copyH );
33 and tests are now made on good variables
35 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
37 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
39 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
40 * Add vtkGdcmWriter example and test
42 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Test/TestUtil.cxx : reformat the source code
44 * vtk/vtkGdcmReader.cxx : remove and change prints
45 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
47 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
48 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
50 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
52 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
54 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
56 by an eof to prevent all bad read of the file... and in this case, the
59 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Example/Volume2Dicom.cxx : comment unused variables
61 * Test/PrintDicomDir.cxx : comment unused variables
62 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
63 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
64 method that is redondant with AddEntry.
65 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
68 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * Bug fix due my last commit (compilation under Windows).
70 * Example/Volume2Dicom : bug fix in the file and reformatting source code
71 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
73 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
75 - Remove printf / sprintf
76 - include iostream AFTER gdcm so we don't get warnings
77 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
79 - Also remove tons of include from header files, hopefully this should
80 speeup the compilation time, since it was becoming a dog slow.
81 - Remove gdcm.h as it include way too many files and slow down compilation
82 (plus it is not up to date)
83 - remove 'using namespace std' this is BAD !
85 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * Remove memory leaks on the DicomDir
87 * Remove some useless datas in DicomDirObject
88 * Add usefull methods in SQItem, to be complient withe the ElementSet
90 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
91 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
93 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
94 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
95 future, with convertion)
96 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
97 and ImageDataSize values. Remove the method to get the PixelReadConverter
98 from the output of the class
100 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
101 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
103 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
105 and vtkErrorMacro use.
106 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
108 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
111 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
112 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
113 The string leaves only in the fonction. So when we make a .c_str(), we
114 get the pointeur on the first element, element that will be destroyed
115 immediately after thee instruction.
116 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
117 file has been opened : the test must be made on the content of the
118 pointer and not directly on the pointer !
121 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
123 the python part recompiles
125 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
126 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
127 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
128 X session is killed (for my computer... it seems to not be identic on
131 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
133 avoid problems (otherwise, the difference test between the visible image
134 and the reference is incorrect. If the reference is greater than the
135 screen resolution, it's produce errors).
136 Can be used for only one image. Can be used with a visible flag.
137 * vtk/vtkGdcmReader.cxx : remove commented codes.
138 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
139 under windows at compilation
140 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
142 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
144 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
145 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
146 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
147 tests on the image size X, Y, Z
149 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
151 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
152 between the class name and the file name
154 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * src/ : fix compilation warnings for the Write method (2 different
156 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
157 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
158 variable... create a static method in gdcm::Document to access to
159 this variable content.
161 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
163 file, to be accessed by other files (like gdcmFile). Remove commented
164 code. Move the change of the header to the gdcmFile, using the
166 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
167 To be sure of that (and simplify calls), the Write of the header now
168 gets a file name and not a file pointer (std::ifstream).
169 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
170 DocEntryArchive. Remove all open of the written file
172 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
175 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
177 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
179 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
180 some corresponding methods. Write correctly the file and check before
182 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
183 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
184 is now on RGB datas (as before my last commit
185 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
187 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
189 Add a print information of the type of the entry
190 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
191 It was in the gdcmFile, and all write have been regrouped
192 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
193 Write correctly all dicom files (in decompressed mode only at this time)
194 * Test/ : test on files are now made using Raw datas and not color datas if
196 * Example/PrintFile.cxx : add more printings
198 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
199 * Amelioration of code, remove some code copy. For the loading of
200 BinEntry (in gdcmDocument), add the test to verify if the file is already
203 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
205 remove a DocEntry in the header (push an empty DocEntry)
206 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
207 lines. Bug fix in the initialization of the PixelConvert and the
209 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
210 use in TestCopyDicom (now this test can run under windows... but fails)
211 * Test/TestCopyDicom.cxx : amelioration of the test :
212 - test the pixels written
213 - add test points to quickly find where is the error
214 - can set a file name input and output in arguments
215 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
216 amelioration of the test output
218 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
220 all replaced DocEntry's
221 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
222 Now, each needed DocEntry to modify is duplicated, modified and inserted
223 to the header using DocEntryArchive. Thus, after save, we can restore the
224 header initial state.
226 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
229 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
231 correct to copy it. The DictEntry is specified at the DocEntry creation,
232 then, it musn't change in the time.
233 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
234 header correctly. At this time, the change is only made for the first
235 level of the Document. In the future, it might consider sequences.
236 The change is made by replacing a DocEntry by an other that is created
237 outside the class. The old value is kept. When we restore the header
238 status, the added DocEntry is deleted and replaced by the old value.
239 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
240 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
241 set the write type to explicit VR, implicit VR or ACR. Add methods to set
242 the write mode to native, decompressed or RGB (but not used at this time)
244 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
246 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
248 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
250 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
252 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
253 set because already copied when copying the BinEntry's of the header
254 * Test/TestAllReadCompareDicom.cxx : remove warnings
256 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
258 Two problems appear when doing it :
259 - with the gdcmFile : when the GetImageData method is called, the pixels
260 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
261 datas (pixels). And each structure destruct the datas when it's
262 destructed. So we have two destructions for the same datas. To solve it,
263 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
264 datas or not. If it doesn't own datas, then they will not destroyed by
266 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
267 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
268 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
269 create a double destruction of the same DocEntry's. So, to solve it,
270 the TagHT is simply cleared and the DicomDir* elements are destroyed.
271 * TODO : add an entry concerning memory leaks in the DicomDir
273 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
275 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
278 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
280 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
281 after it have been deleted
283 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
284 * FIX: src/* fix the doxygen warnings.
285 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
286 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
287 was erroneously defined with a size of 15 instead of 16. [many thanks
288 to Jean Michel Rouet for pointing out this bug].
290 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
291 1. Finish merging JMR patch for writting DICOM from scratch
292 2. Fix -hopefully- bug with MONOCHROME and space vs null character
293 3. Use const ref when possible
294 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
295 5. A few more comments
296 6. CreateUniqueUID can now be called without parameter"
298 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
299 * ENH: Slightly bigger patch:
300 1. Getting toward full integration of JMR patch for writting dicom from scratch
301 2. Update Test to test part of this patch: CreateUniqueUID
302 3. File was not close properly in gdcmDict
303 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
304 5. Use of const ref instead of copy (speed issue)
305 6. Remove temporary (duplicate) string in TranslateToKey
306 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
307 8. Do not repeat virtual in subclasses
308 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
310 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
311 * Apply first patch toward better string comparison when dealing with broken
312 DICOM files. Essentially the string could be padded with a space instead
313 of a null character as defined by standard
315 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
317 because never used... and in the same time, that's remove some memory leaks
319 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * src/gdcmFile.cxx : now delete the PixelConvert instance.
321 * In examples and tests : change the type of image data variables from void*
322 to uint8_t*. Remmove all delete on image data variables
324 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
326 Verify the file pointer value before open the file, and if it's not null,
327 a verbose message is generated.
328 Close correctly the file when the file isn't considered dicom-like. The
329 correctly close is a call to CloseFile.
330 When closing the file pointer, test if its not null to close the file.
331 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
332 file. For an uncompressed image, the copied datas correspond in the least
333 case to the image size (calculated) or the image size specified in the
334 header. A verbose is generated if these two size mismatch
336 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
338 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
339 break under windows (with msvc6 compilation).
341 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
343 compiling with MSVC6)
345 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * Bugs fix for the Windows build with VC6
347 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
348 needed (only for projects required VTK). If the VTK is included in all
349 projects, there is conflicts with the jpeg lib of vtk when compiling the
350 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
351 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
352 when compiling the gdcm_wrap.cxx file (created by the compilation of the
354 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
355 (like it's already made for the cout use). Otherwise, conflict with the
358 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
361 - comments on the DicomDir::Method related usage added.
362 - now that we use the namespace gdcm, a lot of internal classes do
363 NOT need to be wrapped anymore.
364 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
365 DicomDir::Method) new example added.
367 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Improve string manipulation. I now inforce the notion of 'DicomString'
369 A DicomString can contain as many \0 as they want
370 and it is *always* of even length.
371 We only support odd length for very rare case.
372 And in the near future this should be removed.
374 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 * /binary_write/ gdcm source. Now even on big endian we are writting
376 little endian. This should -heopfully- fix some tests
378 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Now the dictionary is compiled into gdcm lib. This is a default
380 behavior, thus any dic file specified is picked before failback to
381 the one comiled into lib
383 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Change internals for gdcmDict. Don't use any 'new' any more.
385 This should definitely solve any leak problem, and we should be
386 as fast as before, as long as don't modify too much the dictionary.
388 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
389 * STYLE: ivars should start with a capital letter.
390 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
391 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
393 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
395 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
396 new 2004 dictionaries added (thanks to JPR).
397 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
398 * CLEANUP_ROUND (15) for gdcmPixelConvert
399 - RLEFrame::NumberFragments is now of type unsigned int
400 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
401 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
404 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * Initial work in gathering all transfer syntax accessors. clearly
406 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
407 ivars, but only one transfersyntax (class) ivar with equivalent method on
410 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
412 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
413 discussed (plus I didn't like having a 2000 lines patch not commited)
415 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
417 * CLEANUP_ROUND (14) for gdcmPixelConvert
418 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
419 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
420 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
422 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
423 anymore and hence avoids storing a copy of PixelConvert::Decompressed
424 into File::Pixel_Data.
426 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
427 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
428 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
429 * CLEANUP_ROUND (13) for gdcmPixelConvert
430 Substituted File::ParsePixelData() with PixelConvert::Print() new
432 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
433 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
434 method to those classes.
435 - src/gdcmFile.[cxx|h]:
436 -- Added a ::Print() method.
437 -- PixelConverter is now a reference instead of a member.
438 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
439 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
441 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
442 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
443 collaboration diagram and inheritance diagram should be generated with
445 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
446 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
447 pointlessly wrapped (see
448 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
449 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
450 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
451 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
452 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
453 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
454 -- File::Initialise: PixelConverter setup moved away to
455 PixelConverter::GrabInformationsFromHeader()
456 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
457 interpretation moved away to PixelConverter::BuildRGBImage()
459 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
460 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
461 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
463 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
465 displayed on Win32 when a brutal abort() occurs (because of uncatched
466 exception). See TODO new entry of this commit for more on this.
467 * TODO added new entry.
468 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
469 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
470 - HandleColor is no longer called from gdcmFile.cxx
471 - gdcmPixelConvert.cxx clean up on method arguments and internal
472 variable names for semantical coherence.
474 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
475 * Finished lossless transition, not only do we now read all lossless jpeg
476 images, without the need of the Cornwell lib, but we do read them properly now
477 * To reduce code (well to avoid code duplication), I defined a common place
478 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
479 redefine symbols. This is not prefect but this the best solution I found for a
480 compilation time jpeg option.
482 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Update jpeg ijg lib to support lossless jpeg implementation
484 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
486 * Also added a special copyright for dcmtk since we use their bugfixes.
489 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
491 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
492 matters, as stated in warning note at begining of %include section).
493 * src/gdcmDicomDir*.[cxx|h]: coding style
494 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
495 * src/gdcmJpeg8.cxx: doxygen fix.
496 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
497 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
498 from File:: to PixelConvert::.
500 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
501 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
502 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
503 - more code moved away from File:: to PixelConvert::
504 - fat setup of PixelConverter set in place in File::Initialise.
506 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
507 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
508 namespace at the file system level. So now you should convert your examples
510 gdcmHeader -> gdcm::Header
511 It would be nice if people keep in mind to no open the namespace, since it
512 allows compilation on broken plateform which were defining common symbol in
513 the standart namespace (like LP, Unknown ...)
515 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
516 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
517 The JPEG fragments are now parsed at the same stage than the RLE
518 information. All code related to JPEG is now in gdcmPixelConvert:
519 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
520 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
521 export a gdcmFile:: method. Those are simply global functions
522 (for the time being this is better than having them attach to
523 either gdcmFile:: or gdcmPixelConvert::).
524 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
525 and stores the result in a gdcmJPEGFragmentsInfo.
526 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
527 code (among other stuff) moved away from gdcmFile:; to
530 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
532 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
533 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
534 clean up of RLE related code.
535 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
536 - src/gdcmRLE.cxx removed
537 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
538 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
539 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
540 * CLEANUP_ROUND (9) for gdcmPixelConvert
541 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
542 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
543 away from gdcmFile:: to gdcmPixelConvert::.
545 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
547 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
548 This is because Parse7Fe0 used to parse the pixels to compute the
549 length. This task was passed over to FindDocEntryLengthOB() a long
550 time ago, EXCEPT I had forgotten the OW case...
551 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
552 we just recylce the code for parsing RLE fragments and computing
554 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
555 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
556 with the retired Parse7Fe0().
557 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
558 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
560 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
562 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
563 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
564 - src/CMakeLists.txt: alphabetic order reodering + new entries.
565 * CLEANUP_ROUND (4) for gdcmPixelConvert
566 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
567 to return an unused length.
569 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
570 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
571 this should be cleanner from the plane view. The iostream are erally a pain
572 to use to do simple stuff.
574 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
575 * Redo the compilation of the ijg jpeg library. Now only one source is
576 necesseray. No need to rename file by hand what so ever. CMake handle the
577 copying of the file within different directory, configure header file to
578 modify some symbol. The only addition made to ijg wasd a mangle table so
579 that symbol are different wether we are within 8bits or 12bits.
581 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * Added documentation of vtkgdcmReader on Website:
583 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
584 with it's binary name).
585 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
586 the Website to be more complete.
587 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
588 doxygenated documentation.
589 - Doc/DoxyVtkGdcmReaderExamples.txt added
590 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
591 DoxyVtkGdmReaderExamples.html )
592 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
593 * CLEANUP_ROUND (3) for gdcmPixelConvert
594 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
596 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * CLEANUP_ROUND (2) for gdcmPixelConvert
598 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
600 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
601 * CLEANUP_ROUND for gdcmPixelConvert:
602 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
603 - src/gdcmPixelStuff[h|cxx] removed
604 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
605 - src/CMakeLists.txt changed accordingly
607 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
608 gdcmVersion.py moved to newly created ATTIC related
609 gdcmPython/SetupOldies/ directory.
610 * Autotools clean up:
611 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
612 - autogen.sh configure.in acinclude.m4 python.m4 removed
614 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * src/*.cxx *.h Reference to License.htm fixed to License.html.
616 * Doc/CMakeLists.txt, doxygen.config.in: fix.
617 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
619 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * TODO updated with Mathieu suggestions. I proposed a template for
621 describing TODO entries and used it for new entries.
622 * Added Doc/Website/CodingStyle.html, Developpers.html,
623 DeveloppersPython.html, GdcmDataCvs.html and
624 DownloadVersion0_1.html, DownloadVersion0_3.html.
625 * Some Doc/*.txt Doxygen files (which do not really concern the
626 documentation itself, but the website) moved to html and
627 placed in directory Doc/Website:
628 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
629 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
630 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
631 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
632 * CMakeLists.txt changed accordingly.
633 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
634 DeveloppersPython.html
635 * INSTALL nows refers to Doc/Website/Installation.html
637 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
638 * Added Doc/Website directory, that contains a first raw version
641 2004-09-23 Jean-Pierre Roux
642 * FIX In order not to be poluted any longer by casting problems,
643 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
644 we can now delete[] it safely
645 * VoidArea is now called BinArea (less confusing name),
646 and all the methods called ...VoidArea... are now ... BinArea...
647 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
649 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
651 clear) TagHT, which is an inherited member of gdcmElementSet. It is
652 up to the destructor of gdcmElementSet to clean up TagHt and it's
655 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * Test/CMakeLists.txt: update to follow gdcmData renamings.
657 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
659 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
660 * ENH: added some utility method that builds a flat dictionnary
661 holding all the Dicom entries contained in the recursive structure
662 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
664 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
665 BuildFlatHashTable() that build a flat dictionary.
666 - src/gdcmElementSet.h: added a new private GetTag() accessor.
667 gdcmDocument is now a friend of gdcmElementSet.
668 - src/gdcmElementSet.cxx: clean up.
669 - Example/FlatHashTablePrint.cxx added.
670 - Example/CmakeLists.txt changed accordingly
672 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
674 moved away from gdcmDocEntrySet (since this class is an abstract class
675 acting like an interface). SQDepthLevel and BaseTagKey are now
677 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
678 and associated accessors. Doxygenation of the class.
679 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
681 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
682 Use SQDepthLevel accessor instead. ::Print() adapted.
683 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
684 - src/gdcmDocument.cxx changed accordingly.
686 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
688 - The following is the doxygen comment of the typedef declaration
689 of gdcmagKey in src/gdcmCommon.h:
690 gdcmTagKey is made to old an "universal" (as in URL, Universal
691 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
692 A dicom tag allways has a group and an element, but a set of tags
693 embeded in various (optionally nested) sequences and sharing
694 the same group and element all share the same (group, element)
695 "identifier". Hence the (group, element) cannot be used as an
696 identifier (in gdcm we shall refer to a "TagKey") of a tag.
697 In order to construct a proper tag identifier (i.e. a key) we
698 consider the following definition of a TagKey:
699 - let Group, Element be the string representation of the
700 group and element dicom tag members,
701 - let ItemNumber be the string representation of the integer
702 index of the considered item number of a sequence,
703 Let the key of a tag embeded in a sequence, noted SeqTag, be
705 /ItemNumber#Group|Element
706 where "/", "#" and "|" are characters acting as separators.
707 Then the general form of a gdcmTagKey is given by:
708 Group|Element<SeqTag>
709 where <SeqTag> means NO or many instances of SeqTag.
710 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
713 but the gdcmTagKey of a tag "embeded" is the first item of
714 a sequence, itself nested in the third item of a sequence is the
716 0004|1220/2#0008|0082/0#0008|0090
717 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
718 order to hold the new sequence compatible key. Previously, the
719 GetKey() method would look in the underlying gdcmDictEntry.
720 - src/gdcmDocEntry.cxx:
721 -- constructor now copies the underlying DictEntry key, in the local
723 -- ::Print: displays the member Key, instead of the (group, element).
724 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
725 - src/gdcmDocEntrySet.h:xi
726 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
727 -- now has a new BaseTagKey member.
729 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
730 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
732 This poses the problem with the semantics of the following lines
733 LoadEntryVoidArea(0x0028,0x1201); // R LUT
734 LoadEntryVoidArea(0x0028,0x1202); // G LUT
735 LoadEntryVoidArea(0x0028,0x1203); // B LUT
736 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
737 to the long FIXME note for what the problem is. Nevertheless in
738 order to get things working the dicom dictionary was altered !
739 Please fix things urgently...
740 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
741 information), see above note on moving the member VoidArea. Nevertheless
742 the following entries previously correctly set as US are now inproperly
744 0028 1201 OW IMG Red Palette Color Lookup Table Data
745 0028 1202 OW IMG Green Palette Color Lookup Table Data
746 0028 1203 OW IMG Blue Palette Color Lookup Table Data
747 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
748 of gdcmDocEntry moved to gdcmSeqEntry.
749 * src/gdcmSeqEntry.cxx: STYLE.
751 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * Test/TestAllEntryVerify.cxx minor fix and added comments.
754 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * gdcmPython/testSuite.py: all the test suite in python is now moved
756 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
757 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
758 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
760 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
761 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
762 to avoid inclusion recursion until STL is reached.
763 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
764 mecanism. errno.h is not included in gdcm anymore.
765 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
766 (gdcmFormatError now inherits from gdcmFormatUnexpected).
768 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
769 gdcmData/TestAllEntryVerifyReference.txt
770 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
771 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
772 exception_on_error parameter.
773 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
774 - vtk/vtkGdcmReader.cxx changed accordingly,
775 - Example/*.cxx and Test/*.cxx changed accordingly.
777 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
778 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
779 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
780 enable_sequences removed from gdcmHeader constructor and dependencies.
781 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
782 * gdcmPython/demo/PrintHeader.py: dummy fix.
783 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
784 skip_shadow removed from gdcmHeader constructor and dependencies.
785 * Example/*.cxx and Test/*.cxx changed accordingly.
787 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
788 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
789 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
791 2004-07-21 Jean-Pierre Roux
792 * FIX Now, Parsing and Printing a DICOMDIR do work!
793 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
795 2004-07-20 Jean-Pierre Roux
796 * FIX Some brain damaged headers have Zero-Lenght fields
797 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
799 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
800 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
801 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
802 variable (instance of gdcmDebug) by a definition macro, and the instance
803 is now in static in the gdcmDebug class
804 * src/gdcmSQItem.h : (FIXME) remove an undefined method
805 * Test/PrintAllDocument.cxx : bug fix in the result of the test
807 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * WARNING: ctest now depends more tightly on gdcmData. You should
809 check out gdcmData properly for things to run smoothly...
810 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
811 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
812 we need the pixels not be loaded in order to use the ValEntry
813 that displays position and size).
814 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
815 This is a C++ based equivalent of gdcmPython/testSuite.py that should
816 be deprecated. If you have any doubts about the advantages of a
817 modern scripting language (read Python) versus grass root C++ (i.e.
818 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
819 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
820 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
821 Anyhow, consider documenting the gdcmData images in
822 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
824 * Test/CMakeLists.txt:
825 - now uses TestAllEntryVerify.cxx
826 - specific comments on oldACR00001.ima (now renamed in gdcmData
827 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
828 gdcmData/TestAllEntryVerifyReference.txt
831 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
832 * src/*.[h|cxx] : typedef clean up
833 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
834 - TagKey renamed to gdcmTagKey (for external usage)
835 - VRKey renamed to gdcmVRKey (for external usage)
836 - removal of typedef duplication.
837 - Removed all unecessary inline keyword from class inline definitions.
838 - Some method|function(void) declarations replaced with method|function().
839 * src/jpeg/libijg12/jdhuff12.c:
840 - printf polluting ctest removed.
841 - TAB removal for comminting
843 - TestAllReadCompareDicom.cxx: added a test that compares all the
844 images in gdcmDataImages.h with corresponding images in
845 gdcmData/BaselineDicom/. When baseline images are not present
846 this test creates them.
847 Note: we need to validate each reference image, but before that
848 I'd like to rename them with a more explicit name...
849 - CMakeLists.txt: changed accordingly.
850 * Example/*.cxx: examples now only include gdcm.h (as opposed to
851 including each header needed).
853 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
854 * Test/*.cxx and Example/*.cxx: moved some examples away from the
855 test suite to the Example directory. Are concerned:
860 - TestWriteSimple.cxx
861 * Test/CMakeLists.txt: added some comments on reasons for black listing
862 image gdcmData/oldACR00001.ima
864 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * Test/CmakeList.txt: removed the following from black list (to be coherent
866 with removal from gdcmData):
867 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
868 - gdcm-MR-PHILIPS-16.dcm
870 Added the following because after last cvs update, they cause
871 ctest -R TestReadWriteReadCompare
873 - gdcm-MR-SIEMENS-16-1.acr
875 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
876 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
877 new comments in this file) we temporarily (sigh) move to a weaker
879 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
880 we don't need to black list the following images anymore:
881 - 8BitsUncompressedColor.dcm
883 - US-PAL-8-10x-echo.dcm
884 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
885 fixes and the beautified code ;-)
886 This fixes the bug introduced in version 1.42 (when beautifying)
887 that made the parsing of 8BitsRunLengthColor.dcm unproper.
888 Note: ctest was blind to this bug (this means we need to still
889 improve the test suite). The bug could be detected by using
890 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
892 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
893 and by displaying the (garbage) produced file temp.XDCM...
895 2004-06-29 Jean-Pierre Roux
896 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
897 - replace by uggly but working old code :-(
898 A lot of things should be OK again.
899 It's really urgent to have a test suite that *tests*,
900 to prevent Frog's beautifying sessions to break all the stuff
901 (twice, withing a fortnigh ...)
903 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
905 redundancy) to added Test/TestReadWriteReadCompare.cxx
906 * Test/CmakeList.txt: because the compare test of
907 Test/TestReadWriteReadCompare.cxx fails, the following images are
908 black listed: - 8BitsUncompressedColor.dcm
910 - US-PAL-8-10x-echo.dcm
911 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
912 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
913 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
914 and ad-hoc kludge. This kludge is now removed, and on encountering
915 such an image (OB field brain damaged) we set errno. Then in
916 ::FindDocLength() we "fix" the length as being ALL what remains
917 in the file (until EOF). We then proceed, hoping for the best...
918 This fixes a SegFault in ShowDicom when trying to write such an
920 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
921 (because TestWriteRead breaks on it, after a non conformal commit?).
922 ctest now runs properly, except for MakeDicomDir (which was allways
923 broken) and the Python related stuff (still not fixed).
925 2004-06-24 Jean-Pierre Roux
926 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
927 FIX : Test/TestReadWrite now iterates on all the file names
928 (instead of infinite loop)
929 ENH : Test/TestWriteRead now iterates on all the file names
931 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
932 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
934 2004-06-24 Jean-Pierre Roux
935 FIX : - now Write drops LUT Descriptors and LUTs (if any)
936 when SamplesPerPixel =3
937 - now Write is no longer confused by
938 'BitsAllocated = 12" and 'BitsStored=12"
939 - "UN" value representation Elements are now written correctly
940 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
941 ENH : - now gdcmHeader has its own Write methods
942 (in order to split the job that has not to be done
945 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
947 loop on the same image until memory went out.
948 Note: this means we still have gobs of memory loss in PrintDocument
949 * src/gdcmDocument.cxx: fixes problem on parsing on file
950 gdcmData/16BitsJpegLosslessGrayScale.dcm.
952 2004-06-24 Jean-Pierre Roux
953 FIX : Write - All the Sequences and Sequence Item are now written
954 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
955 is added a the end, when necessary.
956 - A lot of brain-damaged images, that were read correctly are
957 now written correctly
958 - length compatible BinEntry are now loaded correctly
959 (even for odd groups)
960 Note : only Explicit Value Representation was checked.
961 (question : is implicit VR really necessary for gdcm ?)
963 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
964 * DEVELOPPER: added a proposition of coding style.
965 * src/gdcmDocEntry.h: removed every inline declaration (for test of
968 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
969 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
970 Use the gdcmDocEntry::Print() and Write() instead.
971 * src/gdcmDocument.cxx: bug fix.
973 2004-06-22 Jean-Pierre Roux
974 FIX : gdcmDocument.cxx
975 - Now we do recognize the JpegLossLess format (there was a misstyping in
976 code 'beautyfication' :-(
977 - Now we automaticaticaly load the Luts, if any
979 2004-06-22 Jean-Pierre Roux
980 In order : to write Sequences, whatever their imbrication level,
981 : to allow user to create his own Sequences
982 a lot of modif where necessary (adding, moving, or virtualising methods)
984 WARNING : save your own sources *before* cvs up !
987 ADD virtual void Write(FILE *fp, FileType filetype);
990 ADD virtual void Write(FILE *fp, FileType filetype);
991 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
994 ADD virtual void Write (FILE *fp, FileType filetype)=0;
995 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
996 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
997 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
998 ADD std::string GetEntryByName(TagName name);
999 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1001 std::string vr = "unkn",
1002 std::string fourth = "unkn",
1003 std::string name = "unkn");
1004 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1005 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1006 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1007 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1008 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1009 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1010 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1011 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1014 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1015 ADD virtual std::string GetEntryByName (TagName tagName);
1016 ADD virtual std::string GetEntryVRByName (TagName tagName);
1017 REM virtual bool Write(FILE *, FileType);
1018 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1019 FILE *_fp, FileType type);
1020 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1021 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1022 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1023 REM virtual std::string GetEntryByName (std::string tagName);
1024 REM virtual std::string GetEntryVRByName (std::string tagName);
1025 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1026 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1027 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1029 std::string vr = "unkn",
1030 std::string fourth = "unkn",
1031 std::string name = "unkn");
1032 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1033 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1034 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1035 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1038 ADD virtual void Write(FILE *fp, FileType filetype);
1041 ADD virtual void Write(FILE *fp,FileType filetype);
1044 ADD virtual void Write(FILE *fp, FileType filetype);
1045 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1046 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1047 REM std::string GetEntryByName(TagName name);
1050 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1052 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1054 The default constructor invoked by the line
1055 gdcmHeader *f1 = new gdcmHeader( header );
1056 was gdcmHeader::gdcmHeader(bool) instead of the expected
1057 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1058 Hence the parsing wasn't executed... See also below.
1059 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1060 as explicit constructor didn't do the trick to fix the above problem.
1061 Could anyone explain why ?
1062 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1063 properly calls gdcmValEntry::Print() (that was weed out from
1064 code related to gdcmBinEntry).
1066 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1067 * In order to fix memory leaks:
1068 - Test/TestWriteSimple.cxx: added cleaning of free store through
1070 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1071 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1072 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1073 (through the call to ::AddDicomDirMeta()) or the destructor
1074 would crash when deleting uninitialized ::metaElems].
1075 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1076 - src/gdcmDocument.cxx:
1077 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1078 from dynamic stores.
1079 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1080 was causing memory leaks.
1081 - src/gdcmSQItem.cxx:
1082 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1083 cleanly handled with polymophism: sorry but my milage is low).
1084 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1085 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1086 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1087 This avoids SegFaulting.
1088 - src/gdcmSQItem.h: coding style.
1090 - Test/TestWriteSimple still severely sucks. The output image content
1091 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1092 damaged when displayed with vtkgdcmViewer.
1093 - on memory leaks: TestWriteSimple leaks really less (see entry
1094 of 2004-06-18 in Changelog file for the call to valgrind).
1095 - on segfaults: ctest now passes all the tests but one (no more
1097 * Erroneous leading white fix:
1098 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1099 white[s] (as opposed to from >> xxx, that removes it [them].
1100 - src/gdcmTS.cxx: ditto.
1101 - gdcmPython/testSuite.py: dirty related kludge removed.
1102 * src/*: remaining references to gdcmParser removed.
1103 * src/*[cxx|h]: added copy[way]left header.
1106 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1107 * In order to fix writing of dicom files:
1108 - Test/TestWriteSimple.cxx: a simpler example of writing.
1109 - Test/CMakeLists.txt changed accordingly.
1110 - src/gdcmDocument.cxx:
1111 -- The destructor now recursilvely removes potential sequences.
1112 -- Bug fix in ::IsJPEG2000()
1113 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1114 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1116 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1117 to only declared) and build on top of
1118 ::GetDocEntryByNumber(guint16, guint16).
1119 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1120 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1121 for usage in destructor and treatement of promotion in
1122 ::ReplaceOrCreateByNumber().
1123 - src/gdcmSQItem.cxx: destructor should better handle his job.
1124 Test/TestWriteSimple now runs (or at least it DOES something).
1125 * We can now start hutting memory links. A good starting point is:
1126 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1127 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1128 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1130 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1131 * Valgrind note: after Mathieu Malaterre teached me how to read
1132 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1134 Using gcc, you can force the STL to use malloc and to free memory as
1135 soon as possible by globally disabling memory caching.
1136 With 3.2.2 and later, you should export the environment variable
1137 GLIBCPP_FORCE_NEW before running your program.
1138 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1139 simply vanish (it is still not clear to me, whether this means that
1140 STL std::string leaks or if valgrind believes it leaks...).
1141 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1142 running bin/gdcmTests makeDicomDir):
1143 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1144 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1146 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1147 SegFaulting (I drowned in DicomDir related code when trying to
1148 understand why the list is empty...).
1149 * src/gdcmDocument.h: first BSD license header try.
1150 * Doc/License.txt added.
1152 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1153 * src/gdcmDocument.[h|cxx]:
1154 - Clean up of the Transfer related predicates. They are now all based
1155 on new method isGivenTransferSyntax, that (should) handle properly
1156 the padding problem.
1157 - general clean up, simplification, and coding style.
1158 - Specific clean up of Parse7FE0() (umproperly named actually).
1159 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1161 2004-06-14 Jean-Pierre Roux
1163 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1164 - fix the display of SQItem ordinal number
1165 - add the GetSQItemByOrdinalNumber method
1166 - remove some useless never written private methods
1168 2004-06-14 Jean-Pierre Roux
1170 - adding a constructor taking a gdcmDocEntry as an input param
1171 - ReplaceOrCreateByNumber now returns :
1172 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1173 a gdcmValEntry * if a string value is passed as a param
1175 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1176 according to the param type (no longer sets a gdcmDocEntry)
1177 - GetValEntryByNumber, GetBinEntryByNumber added
1178 - NewValEntryByNumber and NewBinEntryByNumber added
1180 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1182 - GetSQItemNumber and SetSQItemNumber added, to provide
1183 a (relative) Item identier inside a given Sequence
1184 \warning : some pb remaining around this number
1186 - AddEntry now takes the Item Number as a param
1188 - adding a constructor taking a gdcmDocEntry as an input param
1190 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * Memory leak hunt with the following command:
1192 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1193 --show-reachable=yes gdcmTests PrintDocument
1194 It looks like many (all?) leaks are due to the STL (or a bad usage
1195 of the STL. The lines producing the leaks now have a comment with
1196 a "MEMORY LEAK" tag: you can retrieve them with
1197 grep "MEMORY LEAK" src/*
1198 Here are two typical examples which I can't help fixing:
1203 char * test = "babo";
1204 name = test; //// <--- valgrind detects 960 bytes lost in
1205 //// call to std::string::operator=(char const*)
1206 name.clear(); //// Doesn't help !
1214 std::cout << "Type a bunch of characters followed by RETURN: ";
1215 getline(std::cin, line); //// <--- valgrind dectects a loss
1216 //// of 1320 bytes in call to
1217 /// std::basic_istream<>& std::getline<>
1223 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1224 * src/gdcmHeader.[cxx|h]:
1225 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1226 and related, moved away to gdcmDocument.
1227 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1228 the corresponding protected accessors of inherited class
1229 gdcmDocument, removed ! As a consequence gdcmFile had to be
1230 declared friend of class gdcmDocument (see below).
1231 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1232 - Clean up of undefined or unused methods.
1233 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1234 account the changes to gdcmHeader.h).
1235 * src/gdcmDocument.h:
1236 - gdcmFile is now a friend class (in order to take into account the
1237 changes to gdcmHeader.h).
1238 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1239 (see changes to gdcmHeader.h).
1240 - Accessors (reading on the form GetEntry*) are now public.
1241 - Clean up of undefined or unused methods.
1242 * src/gdcmDocument.cxx:
1243 - adaptation to changes to gdcmDocument.h
1244 - ::OpenFile now writes a verbose message when file cannot be opened.
1245 - some std::string properly set to VRKey
1246 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1247 references to gdcmDocument.
1248 * Test/TestFindTags.cxx: changed accordingly to above changes.
1249 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1250 cvs repository gdcmData.
1252 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1253 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1254 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1255 conflicts with gdcmValEntry::voidArea.
1256 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1257 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1258 Value representation between StringRepresentable and BinaryRepresentable.
1259 * src/gdcmDocument.cxx:
1260 - method ParseDES: proper indentation restored and usage of
1261 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1262 - method LoadDocEntry: the fingerprint left in the SetValue() of
1263 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1264 removed. Reverting to previous code segment with the proper
1265 dynamic_cast< gdcmValEntry* >.
1266 Note: this was (partially) breaking the python test suite
1267 (gdcmPython/testSuite.py) that made usage of the above
1268 fingerprint to check presence of "Pixel Data".
1269 * src/gdcmDocEntry.h: coding style.
1270 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1271 now taken into account.
1272 * gdcmPython/gdcm.i: adaptation to the new internal representation
1273 of gdcm (exit gdcmParser, hello gdcmDocument).
1274 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1276 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1277 anymore, but instead prints the loaded Python dictionary.
1278 * .... alas, the python testSuite is still broken.
1280 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1281 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1283 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1284 * src/gdcmUtil.h : export methods
1286 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1287 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1289 * Initial addition of automatic python testing
1290 * Initial addition of automatic image comparison
1292 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1293 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1294 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1296 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1297 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1298 * Test/ShowDicom.cxx : bug fix for msvc compilation
1299 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1301 2004-05-04 Jean-Pierre Roux
1302 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1303 new concepts (and new classes) :
1304 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1305 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1306 - Sequence Doc Entries (gdcmSeqEntries)
1307 a Sequence is composed of Items.
1308 Each item is a set of Doc Entries (this is recursive)
1309 The non uniqueness of the 'Dicom tag' is due to this recursivity
1310 (never taken into account)
1311 Our unability to add a new 'entry' in the header
1312 at the proper location (neither in the H-Table (map or multimap),
1313 nor in the Chained List is also due to this recursivity.
1314 Don't try, right now, to use/modify/compile these new sources :
1315 nothing is finished.
1316 We just commit all the stuff, 'as is', in order not to loose it.
1318 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1319 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1321 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1322 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1323 file prefix (SetFilePrefix)
1325 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1326 * Add a new test: ShowDicom, for now this is just the c++ version of
1327 checkRead.sh, later it will be able to compare the image read against a
1329 * Replace the DEBUG on the stack with a global entry in cmake interface:
1330 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1332 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1333 * Add an example subdir, with a real example on how to read + write a
1336 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1338 * Doc/CMakeLists.txt: the main page is now properly differentiated
1339 between the developper and user version.
1340 * Doc/doxygen.config.in: dropped search related obsolete flags
1341 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1343 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1344 * DEVELOPPER: added some helpfull comments for compile/test/install
1347 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1348 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1349 src directory, now generated in the build dir.
1350 2. Tests as mentionned smarter
1352 4. Add a new method in gdcmDict that return the PubDict by name
1353 this is interesting for 3rd party lib like ITK,
1354 where we could set the institution name / patient name...
1356 * ENH: 1. Now the test suite is working for real
1357 2. All binaries are now output in the gdcm-bin directory
1358 (this was not true before)
1360 2004-04-28 Jean-Pierre Roux
1361 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1362 SeQuence indented printing of Dicom Header.
1363 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1364 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1365 Computation of SQDepthLevel is now part of gdcmHeader constructor
1366 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1367 tree-like structure of a Dicom Header.
1368 * FIX Test code cleaning
1370 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1371 * ENH: Adding automatic testing
1372 1. Need a DartConfig.cmake to submit to public
1373 2. Add a test driver gdcmTest.cxx
1374 3. gdcmTestMain, an helper for the main test driver gdcmTest
1375 4. Files in Test don't have a main anymore, this becomes interesting
1376 when we add more and more tests, thus dsw don't have to load
1378 * ENH: Adding a GDCM_DATA_ROOT for testing
1379 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1380 one file instead of seven + some small cleanup
1382 2004-04-22 Jean-Pierre Roux
1383 * ENH Minor changes to the Print() methods.
1384 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1385 Header printing. Example given with :
1386 > PrintHeader fileName 2 new
1387 (SQ based tree-like structure still to be done for the Header ...)
1389 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1390 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1391 1. I have added some unsigned where needed
1392 2. Some function parameter not used -> (void)
1393 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1394 4. g++ don't like character '\' in comment
1395 5. #define jpeg_create_decompress jCreaDecompress
1396 this really need to be fixed
1397 6. virtualize destructor of gdcmObject ... leakage
1398 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1399 this also really need to be fixed
1400 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1401 remove compression file
1402 (as we only do decompression, right ?)
1403 * ENH: Change malloc/calloc/free with c++ equivalent
1405 2004-04-21 Jean-Pierre Roux
1406 * FIX gdcmHeaderHelper::GetXSpacing
1407 when a single value is found (bug ?), xpacing is now
1408 defaulted to yspacing
1410 2004-04-19 Jean-Pierre Roux
1411 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1412 * ENH add parameters :
1413 bool exception_on_error = false,
1414 bool enable_sequences = false,
1415 bool ignore_shadow = false
1416 to the gdcmFile constructors to be full gdcmParser compliant
1417 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1418 to allow reading of PAPYRUS 3.0 files
1420 2004-04-06 Jean-Pierre Roux
1421 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1423 2004-04-02 Jean-Pierre Roux
1424 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1425 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1426 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1428 2004-03-30 Jean-Pierre Roux
1429 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1430 for ACR file, written out as DICOM files (hope so...)
1432 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1434 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1435 moved to base class gdcmParser and only the specialisation is kept
1437 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1438 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1439 already does the job.
1440 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1441 (to be consistent with gdcmParser::WriteEntries).
1443 2004-03-30 Benoit Regrain
1444 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1445 upate of the object's instance. It's passed to 2 in the unfavorable
1446 case : one in the ExecuteInformation, one in the ExecuteData
1448 2004-03-29 Jean-Pierre Roux
1449 * ENH : Check on file type to be written moved
1450 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1451 * FIX : gdcmObject::ResetBoundaries now stops properly
1452 when end-of-list is reached
1453 : gdcmVersion modified (as Benoit Regrain asked)
1455 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1457 * src/gdcmUtil.cxx: added forgotten iostream include.
1458 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1459 equivalent to ExplicitVR in existing code).
1461 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1462 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1463 now contains all the gdcmGlobal related code.
1464 * minor coding style and doxygenation changes.
1466 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1467 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1468 now contains all the Debug related code.
1469 * minor clean-up of includes in src/*.cxx
1470 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1471 CreateCleanString) removed.
1472 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1473 * Doc/DoxyMainPageUser.txt added.
1474 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1475 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1476 src/gdcmDirList.cxx)
1478 2004-03-24 Jean-Pierre Roux
1479 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1481 2004-03-23 Jean-Pierre Roux
1482 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1483 big endian made volumes
1484 * ENH Now gdcmParser constructor and destructor are protected to forbid
1485 end user to instanciate class gdcmParser
1486 (only gdcmHeader and gdcmDicomDir are meaningfull)
1488 2004-03-22 Benoit Regrain
1489 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1490 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1491 gdcmSerie to gdcmDicomDirSerie
1493 2004-03-19 Jean-Pierre Roux
1494 * ENH Now the tree-like structure describing a DICOMDIR comming from
1495 an already existing DICOMDIR file is consistent with
1496 the home-made tree-like structure build ex-nihilo
1497 or build from the files held (recursively) in a Directory
1498 functions gdcmDicomDir::CheckBoundaries()
1499 gdcmObject::SetBoundaries() added
1501 2004-03-17 Jean-Pierre Roux
1502 * REM (Eric Boix bug) : removal of meaningless
1503 gdcmDicomDirImage::NewImage function.
1504 * FIX now file names and directory name are written properly in the
1506 * FIX now gdcmDicomDir constructor may be call without any trick
1509 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1510 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1511 of gdcmDicomDirImage::NewImage as empty function.
1513 2004-02-28 Jean-Pierre Roux
1514 * ENH add gdcmDicomDir:NewPatient
1515 add gdcmDicomDirPatient:NewStudy
1516 add gdcmDicomDirStudy:NewSerie
1517 add gdcmDicomDirSerie:NewImage
1518 to allow making gdcDicomDir object.
1519 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1520 (as opposite to the gdcmHeader chained list)
1522 2004-02-11 Benoit Regrain
1523 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1524 when using from python
1526 2004-02-10 Benoit Regrain
1527 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1528 * FIX : in gdcmDicomDir when the directory is empty
1529 * ENH : add callback and methods to get the progression of dicomDir
1532 2004-02-06 Jean-Pierre Roux
1533 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1534 - GDCM_META added to gdcmDicomDirType
1535 - class gdcmMeta created
1536 * ENH : - A brief summary is now displayed at the beginning of
1537 'testDicomDir' to help disaster magnitude estimation
1538 * REM : Now useless Test/explDICOMDIR.cxx
1540 2004-02-05 Benoit Regrain
1541 * ENH : add methods in gdcmObject to get the hash table or the list of
1543 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1544 * FIX : wrapping python for TagHeaderEntryHT
1546 2004-02-04 Benoit Regrain
1547 * FIX : even length for some strings when writting the dicom dir
1548 * FIX : sort the images in the dicom dir
1549 * FIX : Bug fix for python use of dicom dir
1550 * ADD : a python demo
1552 2004-02-04 Jean-Pierre Roux
1553 * FIX : Final solution (?) for icone embedded images
1554 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1555 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1556 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1557 gdcmData/gdcm-MR-SIEMENS-16.acr1
1558 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1559 to make full checking easier
1561 2004-02-04 Benoit Regrain
1562 * FIX : WriteEntries : coding style & logic in parameters
1563 * FIX : Set the elements to create the DicomDir in a dictionary file
1565 2004-02-03 Benoit Regrain
1566 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1567 * gdcmDicomDir : add the load of directory
1568 * Bug fix and print add-on
1570 2004-02-03 Jean-Pierre Roux
1571 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1572 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1573 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1574 * FIX gdcmParser.cxx : 'group length' elements are now considered
1575 as integers, even for shadow groups, when file is Implicit VR
1577 2004-02-02 Jean-Pierre Roux
1578 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1580 of the last synonym :-(
1581 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1583 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1584 * FIX taking into account the possible 7fe0,0010 multiplicity
1585 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1586 to allow removal of references to 7fe0,0010, to deal with
1587 ACR-NEMA images, when 0028,0200 is meaningfull
1589 2004-01-31 Jean-Pierre Roux
1590 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1591 no longer writes 'Un' on disk
1592 * FIX SQ elements with actual length are now dealt with corectly
1593 * FIX gdcmFile::WriteBase make the difference, for color images, between
1594 the length (for Palette expanded images)
1595 and Raw Length (non expanded image + Palette)
1596 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1597 (that broke Write). Replaced by UL.
1598 Aware user will reload the field if he
1599 thinks it's necesssary
1601 2004-01-30 Jean-Pierre Roux
1602 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1603 when 'dirty Acr' is found, to be compliant with the new
1604 IsReadable() methods.
1606 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1607 (no DOUBLE images in kosher DICOM,
1608 but so usefull for people that miss them ;-)
1610 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1611 DICOMDIR related utilities (not checked as Windoze compliant)
1613 2004-01-28 Jean-Pierre Roux
1614 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1616 2004-01-27 Jean-Pierre Roux
1617 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1618 to allow skipping the shadow elements, to save memory space.
1619 The TRUE value for this param has to be used
1620 with a FALSE value for the 'enable_sequence' param.
1621 ('public elements' may be embedded in 'shadow Sequences')
1622 * gdcmHeader methods now deal with 'embedded icones images' in the header
1623 (even when an 'icone image sequence' is announced by the
1624 element (0x0088,0x0200), but there is NO icone at all ...
1626 * gdcmHeader sometimes Image Location value doesn't follow
1627 the supposed processor endianity (see gdcmData/cr172241.dcm).
1630 * gdcmHeader add the method
1631 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1632 to get *all* the Header Entries with the same tag.
1633 GetHeaderEntrySameName is probabely *useless*
1634 (no meaning : Name is *not* an identifier within the Dictionnary)
1636 2004-01-26 Benoit Regrain
1637 * Bug fix in the print of hexadecimal representations. Remove long fields
1638 in the print and add a third level of print to print them
1640 2004-01-23 Benoit Regrain
1641 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1642 * Bug fix on test suite after remove the strip made on not string fields
1643 * Split the IsReadable method between gdcmParser which test that the file
1644 is dicom and gdcmHeader which test that it's an image file
1646 2004-01-22 Benoit Regrain
1647 * DicomDir : clean code, add methods, set variables in protected or private
1648 * gdcmUtil : bug fix for the clean string method
1650 2004-01-19 Benoit Regrain
1651 * Add the use of shadow dictionaries
1652 * bug fix and coding style
1654 2004-01-19 Benoit Regrain
1655 * src/gdcmFile.cxx : bug fix concerning the close of file
1656 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1657 * Add the update of header entries using the shadow library
1659 2004-01-19 Benoit Regrain
1660 * removal of file gdcmHeader2.cxx
1661 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1662 inheriting from gdcmParser. This split is to prepare the integration
1663 of dicom dir parsing
1664 * bug fix under python
1666 2004-01-16 Jean-Pierre Roux
1667 * REM removal of class gdcmHeaderEntrySet
1668 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1669 * ADD add file gdcmHeader2.cxx
1670 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1672 2004-01-15 Benoit Regrain
1673 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1674 entries created while parsing the header. Thus, they will be destroyed
1675 when the gdcmDictSet will be destroyed
1676 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1679 2004-01-15 Benoit Regrain
1680 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1681 made a fatal error because of the memory release at the end of program.
1682 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1683 some memory and vtk seems to have some problems with that.
1684 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1686 2004-01-14 Benoit Regrain
1687 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1688 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1689 * src/*.[h|cxx] : make changes due to class name changes
1690 * gdcmPython/demo/*.py : bug fix due to method names
1692 2004-01-13 Benoit Regrain
1693 * src/*.[h|cxx] : coding style
1694 * vtk/*.[h|cxx] : coding style
1696 2004-01-13 Benoit Regrain
1697 * gdcmPython/testSuite.py : test the readable flag of file for tests
1698 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1699 It's lied to the stl compilation by MSVC (windows, always windows...)
1700 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1702 2004-01-12 Benoit Regrain
1703 * src/*.h : add comments
1704 * src/gdcmDictSet.h : set the method BuildDictPath in public
1705 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1706 directly setted in the source code
1707 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1710 2004-01-09 Benoit Regrain
1711 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1712 * setup.py : use a reference to gdcmVERSION
1714 2004-01-07 Benoit Regrain
1715 * Modification to compile with the distutils.
1718 2003-12-10 Benoit Regrain
1719 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1720 can use a gdcmHeaderHelper to load datas
1721 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1722 made in the source code
1724 2003-12-10 Benoit Regrain
1725 * Update Windows projects and .cvsignore files
1727 2003-11-12 Jean-Pierre Roux
1728 * ENH gdcmHeader constructor has one more parameter (default value : false)
1729 that allows the user to 'go inside' the SeQuences only
1731 gdcmElValSet:Print takes it into account
1733 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1734 * ENH: Update gdcmPython/CMakeLists
1735 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1736 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1738 2003-11-10 Jean-Pierre Roux
1739 * FIX : gdcmHeader::LoadElements is now based
1740 on the ListTag listElem member,
1741 not longer on the TagElValueHT tagHt member
1742 * ENH : PrintPubElVal shows (temporarily) both results,
1743 with the tagHt member and the listElem member.
1744 (it's easier to 'see' the problems when using Printheader)
1746 * FIX : old private member LgrElem is now splitted into
1747 ReadLength : Length actually found on disk (updated only
1748 if bug fixing is necessary), for internal
1750 UsableLength : Updated by FixFoundLength, to fix a bug
1751 or to allow Parser going on.
1752 Will allow to re-write a kosher header when a SeQuence
1753 with a length (not 0000) is found
1754 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1755 because gdcmElValSet::Add does not update ListElem
1758 2003-11-07 Jean-Pierre Roux
1759 * FIX misstyping in Transfert Syntax name table
1760 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1761 when they have an actual length (not 0000 nor FFFFF)
1762 (Nobody should care of it, but DICOMDIR explorers)
1764 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1767 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1768 * ENH: vtkGdcmReader now supports LUT !
1769 (vtkgdcmViewer for now is not able to use them though)
1771 2003-11-05 Jean-Pierre Roux
1772 * in testSuite.py : new files names for checking the package
1773 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1774 that returns the pixel area size to the *aware* (vtk) user
1775 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1777 2003-11-05 Benoit Regrain
1778 * in testSuite.py : Modify the rules for checking the paths
1779 : Explicit error messages
1780 * in __init__.py : Related modif
1782 2003-11-03 Jean-Pierre Roux
1783 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1784 to be used by aware (vtk) users that want to manage
1785 LUT (and no to turn the PALETTE image into an RGB pixels one)
1786 * GetPixelType now returns 8U for 24 Bits images
1787 (vtkGdcmReader compliant)
1789 2003-10-31 Jean-Pierre Roux
1790 * Removal of *all* gdcmData images and add them again
1791 in order to loose the 'history' of un-anonymised images
1793 2003-10-31 Jean-Pierre Roux
1794 * RMV : removal of useless jBitsInJsample.h
1795 for both 8 and 12 Bits JPEG Lossy Libraries
1797 2003-10-31 Jean-Pierre Roux
1798 * ENH : Add the functions gdcmFile::GetImageDataRaw
1799 gdcmFile::GetImageDataIntoVectorRaw
1800 that act as GetImageData and GetImageDataIntoVector
1801 except the making of an RGB Plane from Gray Plane + LUT
1802 Intended to aware (vtk) users who know how to manage
1805 GetLUTRGBA return a R,G,B,A LUT if any
1806 lgrTotaleRaw gives the 'Raw' length
1807 GetImageDataRaw returns the gray Plane
1808 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1809 (They stay Grey, just like with other Dicom viewers :-(
1811 2003-10-30 Jean-Pierre Roux
1812 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1814 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1816 being coherents dicom files.
1818 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1821 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1822 * ENH: Two steps is necessary to please VC++ compiler...
1823 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1824 * ENH: Add include dir to medcon lib
1825 * FIX: only one function is being exported for now !
1826 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1828 2003-10-29 Jean-Pierre Roux
1829 * adding gdcmHeader::GetLUTRGBA
1830 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1831 --> Mathieu, the modif u're waiting for is not yet committed
1832 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1834 2003-10-27 Jean-Pierre Roux
1835 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1836 00191113.dcm DermaColorLossLess.dcm
1837 MxTwinLossLess.dcm RadBWLossLess.dcm
1838 * ENH: For version prior to vtkImageViewer2 -r 1.19
1839 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1841 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1842 * Removal of ido stuff in CMakeLists.txt
1844 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1846 * FIX: remove a call to ->Modified ... see comments
1847 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1849 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * FIX: Problem with path for libvtkgdcmPython
1851 * ENH: Try adding a search script for python site-package
1852 * RMV: Remove some file from medcon lib that are not necessary
1853 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1854 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1855 * FIX: More pragma disable fro VC++,
1856 I don't think I break something as it is also disable in VTK/ITK.
1857 But it fasten debug compilation time.
1859 2003-10-23 Jean-Pierre Roux
1860 * gdcm now deals with 16 Bits Run Length Encoded images
1861 (they are compressed as 2 planes images,
1862 one for the high Bytes, the other for low Bytes)
1864 2003-10-22 Jean-Pierre Roux
1865 * Now CheckRead takes into account :
1866 - the bugged 'Leonardo' Siemens images
1867 - the XA images, sent thru the burning VPRO station
1868 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1871 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * FIX: When copying a Makefile.am to CMakeLists.txt
1873 one should remove the '\'
1875 2003-10-22 Jean-Pierre Roux
1876 * in gdcmData adding a bugged 'Leonardo' Siemens image
1877 (wrong lengths in header)
1878 OK with gdcm, KO with the other viewers :-)
1879 * add a GE dlx XA image, thru the VEPRO burning station
1882 2003-10-21 Jean-Pierre Roux
1883 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1884 for a brutal checking of vtkgdcmViewer compliance
1886 2003-10-21 Jean-Pierre Roux
1887 * add the files for 'xmedcon' Jpeg Lossless library
1888 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1890 2003-10-21 Jean-Pierre Roux
1891 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1893 2003-10-21 Jean-Pierre Roux
1894 * garbage Siemens 'Leonardo' images dealt with
1895 (the patch is easy to remove)
1896 * cosmetic changes to avoid warnings
1898 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1899 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1900 no need to press 'r' now.
1902 2003-10-20 Jean-Pierre Roux
1903 * upgrade of checkRead.sh checkWrite.sh according
1904 to new Jpeg Lossless decompressor
1905 * add US.3405.1.dcm, a genuine RGB medical file ...
1906 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1907 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1909 2003-10-15 Jean-Pierre Roux
1910 * general anonymisation in gdcmData
1911 * adding the 'color files' from
1912 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1913 * adding some well knowed bugged-header images
1914 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1915 waiting for their inclusion in Python testsuite
1917 2003-10-15 Jean-Pierre Roux
1918 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1919 no longer seg faults when file is not found
1921 2003-10-14 Jean-Pierre Roux
1922 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1925 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * TODO: *.in file to genereate a UseGDCM later
1928 2003-10-14 Jean-Pierre Roux
1929 * Some supposed-to-be Dicom Images have no preamble.
1930 OpenFile takes it into account
1931 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1932 * Missing elements added in dicomV3.dic
1933 (just to be affraid : have a look at
1934 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1935 and do it again next year ;->
1937 2003-10-13 Jean-Pierre Roux
1938 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1939 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1940 But there are NOT. It's fixed !
1942 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1943 * FIX: "jpeglib.h" was not found on VC++
1944 * FIX: vtkgdcm was not being installed
1946 2003-10-10 Jean-Pierre Roux
1947 * ENH : OpenFile closes the file if it *really* doesn't look like
1948 an ACR-NEMA / DICOM one.
1949 * FIX : testWrite no longer writes an empty file if the source file
1950 is not gdcm Readable
1951 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1954 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1955 * FIX: CMake generate now documentation
1956 * ENH: out of source doc build !
1957 * ENH: Generate both user and dev documentation
1958 * ENH: Should work on windows too
1959 * ENH: Only one doxygen config.in file is needed
1960 * FIX: make install should be ok now on ùnix plateform
1961 * FIX: PATH to dictionary was wrong (missing /)
1962 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1964 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * vtkGdcmReader is now able to read rgb dicom file.
1966 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1967 * added a gdcmViewer to vtk test, use mouse to control
1968 window level & window width
1970 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * CMake-ification of gdcm, we have now two build system
1972 * FIX: on cygwin Wsock32 doesn't exist
1973 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1975 2003-10-06 Emanuel Ollart
1976 * FIX : compilation process wad broken.
1977 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1979 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1980 * change gdcmViewer -> vtkgdcmViewer
1981 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1983 2003-10-06 Jean-Pierre Roux
1984 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1985 ( e.g : well known GE images with a wrong elem length,
1986 : Philips MRI Images with a wrong Huffman table)
1987 * still to be done : allow the reading of bugged LEONARDO Siemens images
1989 2003-10-03 Jean-Pierre Roux
1990 * Odd length strings are padded with '\0' (not with spaces,
1991 to remain compliant with already defined strings,
1992 like Transfert Syntax UID and others)
1994 2003-10-03 Jean-Pierre Roux
1995 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1996 to allow displaying RGB images (not only by affim ;-)
1998 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * vtkGdcmReader is now able to read rgb dicom file.
2000 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2002 2003-10-03 Jean-Pierre Roux
2003 * A few nasty patches to allow the reading of a lot of nasty images
2004 ( e.g : well known GE images with a wrong elem length,
2005 : Philips MRI Images with a wrong Huffman table)
2006 * still to be done : allow the reading of bugged LEONARDO Siemens images
2008 2003-10-03 Jean-Pierre Roux
2009 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2011 2003-10-03 Jean-Pierre Roux
2012 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2013 to allow displaying RGB images (not only by affim ;-)
2015 2003-10-03 Jean-Pierre Roux
2016 * gdcmFile::GetImageDataIntoVector now
2017 - deals with MultiFrames MultiFragments Run Length Encoded files
2018 - deals with YcBcR (YBR_FULL) files
2019 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2020 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2022 (no sample found :-(
2024 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2025 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2026 Two reasons: - clear things
2027 - third parties acces gdcm through header files, so won't
2028 suffer anymore VC++ complains
2030 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2031 * add argv[1] in testvtkGdcmReader.cxx
2034 2003-09-24 Jean-Pierre Roux
2035 * The lines are now eigthy characters long.for
2036 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2038 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2039 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2040 char* to std::string. Thus, the use of strdup becomes useless. (see
2041 previous commis of Malaterre)
2042 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2043 before the last Malaterre's commit.
2045 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * This commit should fix the Debug building under VC++, the problem
2047 was mainly a mixture of debug and release lib being loaded at startup.
2048 * I also remove a depency to a specific C function: strdup. Because I had
2049 to force the link to msvcrtd (whereas strdup is in libc).
2051 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2052 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2053 located in the gdcmCommon.h file. All use of reference of tha has been
2054 changed to now use the variable GDCM_UNFOUND.
2056 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2058 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2059 Dicom dictionary. The test suite can now be run again. Note:
2060 I'm note very happy with the " (RET)" changes. I believe this
2061 RETAINED comment should be dropped when parsing the dictionary.
2062 - PACKAGER corrected
2064 - AUTHORS updated and now in alphabetical order
2065 * Makefile.am now exports gdcm.dsw for Windoze users.
2067 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * cygwin complains about missing std:: in subdir Test/
2070 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * remove some methods that are now in gdcmHeaderHelper
2073 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2074 * vtkGdcmReader set spacing and origin correctly
2076 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2077 * Fix a few delete/delete[] mismatch
2079 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2080 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2081 interpretation to data given by gdcmHeader. For instance there are
2082 heuristics to get informations (look at different places).
2083 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2084 sorting DICOM images based on different strategies.
2085 * modified Makefiles accordingly.
2087 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2089 when building in debug mode
2090 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2091 src/win32/gdcmdll.dsp
2092 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2094 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2095 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2098 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2099 * src/win32/libgdcmjpeg12.dsp was not dos format
2100 * src/win32/libgdcmjpeg12.dsp :
2101 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2102 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2104 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2105 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2107 * src/gdcmFile.cxx : bug fix in affectation type
2108 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2109 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2110 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2111 symbols... future problem ?
2113 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * src/win32/libgdcmijpeg12.dsp was missing
2115 * modified gdcm.dsw accordingly
2117 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2118 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2120 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2121 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2122 commit of JPR (before his hollidays to facilitate our work).
2123 * setup.py : bug fix in code. Modifications made while the last commit
2124 of JPR. The code hasn't been tested before the commit... it's so
2125 useless to make that (for best programmer that is JPR) !!!
2127 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * tagged the current version as Version0_3 (i.e. version 0.3)
2130 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2131 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2132 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2133 * *.dsp : modifications to use new libgdcmijpeg8 library
2134 * setup.py : bug fix on VTKPATH variable
2135 * PACKAGER : adding all concerning windows
2137 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2140 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2141 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2142 test suite reported error.
2143 * PACKAGER file added (describes what a packager must do when
2144 packaging a new release).
2145 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2146 * configure.in: upgraded version number to 0.3.0
2147 * fixing build of rpm (through rpm -ta):
2148 - Doc/Makefile.am exports proper doxygen files
2149 - src/jpeg/libijg8/Makefile.am exports the include files.
2151 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2152 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2153 * src/gdcmHeader.h : formatting code
2155 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2157 We were obtaining error message from vtk. Now, creation of file list
2158 is made in an internal list to prevent this problem.
2159 Bug fix when output is empty.
2160 Bug fix in update of progress value. Previous commit for this was a bad
2162 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2164 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2165 * src/gdcmHeader.h : added method to get the file name
2166 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2167 files. Added method to remove all files on the input
2168 Added FIXME comment concerning the bad parsing of header made by
2169 ExecuteInformation method (in ExecuteData method)
2171 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2173 when using make instal.
2174 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2175 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2177 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * setup.py : adding include dir of jpeg lib to compile all sources
2179 * */Win32/*.dsp : JPR fix for windows compilation
2181 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2182 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2184 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2185 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2187 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2188 * setup.py is again effective on un*x (takes into account the
2189 addon of the jpeg library)
2190 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2191 * Doc/Doxy* updated (includes above enhancements)
2192 * INSTALL now points to web documentation
2194 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * src/gdcmHeader.h doesn't make unnecessary reference to
2197 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2199 * src/gdcm*.[cxx|h] :
2200 - to allow compilation with gcc 3.x
2201 -- clean up of STL usage (added explicit usage of std::)
2202 -- small fixes on exceptions.
2203 Note: linking not tested !
2204 - clean of doxygen comments to avoid warnings at documentation
2206 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2207 dependent convertion).
2209 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * Clean up of previous JPR garbage commit (not even commented in the
2212 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2213 - moved all jpeg related files from src to src/jpeg/libijg8, with
2214 addition/modification of Makefile.am and configure.in.
2215 - the testSuite is still brain damage (not guilty).
2217 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2218 * WrapVTK.py : modifications to get correctly vtk source files to
2220 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2221 (FileName -> Filename)
2223 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader.[cxx/h]:
2225 - UpdateProgress method should now be effective
2226 - removed the limitation on having only images loaded (as opposed
2228 - when building a stack of images/volume, a lesser number of
2229 gdcmHeader and gdcmFile instances should be used (hopefully
2230 accelerating things).
2231 - when building a stack of images/volumes, files which are not
2232 loadable (wrong path-filename, wrong permissions on existing file,
2233 or file not parsable by gdcm) are replaced with a black image
2234 in the stack (for the caller to notice the problem).
2236 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2237 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2239 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2241 between standard library (std) and vtk library (problems are found
2242 under Windows... thanks Windows !)
2244 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2245 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2247 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2249 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2252 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2253 * When compiling with distutils (see setup.py) the C++ compiler is
2254 called with different flags than the default ones (with automake).
2255 In order to fix all those warning, I compiled gdcm with the command
2256 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2257 and went for warning fixes:
2258 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2259 up from unused variables.
2260 - vtk/vtkGdcmReader.cxx: potential bug fix.
2261 * src/gdcmHeader.h: Doxygen warning cleanup
2263 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * gdcmPython/gdcm.i:
2265 - typemaps correction to take into account the systematic replacement
2266 of "using namespace std" with std:: prefix e.g. std::list,
2267 std::string... (cf changes of 2003-05-21).
2268 - gdcmGlob global variable of type gdcmGlobal (defined in
2269 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2270 exported to Python a as cvar.
2271 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2272 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2273 gdcmDictSet.GetPubDictTagNames() and
2274 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2275 C++ static methods).
2276 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2277 with the above changes.
2279 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2280 * setup.py, manifest.in : bug fix under linux
2282 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2283 * Modification of setup.py to compile vtk part too. Then, we have 2
2284 wrappers which must work with same distutils. For that, we have a
2285 generic distutils in distusiltsWrapping.py ; with :
2286 - build_extWrap class to wrap generically all extensions,
2287 - ExtensionWrap base class for all wrapping extension that contains
2289 - Wrapper interface which wrap sources
2290 + In WrapSwig.py we have extension and wrapper for Swig
2291 + In WrapVTK.py we have extension and wrapper for VTK
2292 * MANIFEST.in : modifications to consider vtk directory and new python
2293 files for compilation
2295 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2296 * Added python wrappers of vtkGdcmReader vtk class (see the
2297 source in vtk/vtkGdcmReader.cxx) :
2298 - vtk/Makefile.am now builds a library
2299 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2300 python library (as opposed to _gdcm.so wich are the python
2301 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2302 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2304 - configure.in has an additional flag --enable-vtk that needs
2305 to be set to enable compilation of vtk related code, that is:
2306 + vtk/vtkGdcmReader.so and
2307 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2308 + gdcmPython/vtkgdcmPython.so (see above)
2309 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2310 be read when compressed or when HighBit + 1 != BitsStored),
2311 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2312 the usage of the python wrapper of vtkGdcmReader vtk class.
2313 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2314 * src/*.[h] all occurences of stl classes are now prefixed with
2315 std::, and all occurences of "using namespace std;" where removed.
2316 This is to avoid pollution of global namespace in included files.
2317 Apparently vtk does not avoid this pitfall: when using both
2318 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2319 collision of various stl members (principally cout...).
2320 * gdcmPython/testSuite.py now cleanly removes temprory generated
2322 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2323 comply with above changes)
2325 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2326 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2327 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2328 vtk data structure (an image Flip was required).
2329 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2330 * cosmetic changes in documentation.
2332 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2333 * src/gdcmHeader.cxx: the constructor no longer exits when an
2334 unexisting file is given as argument.
2335 * The subdirectory Data (containing all the images used for the
2336 test suite) is not part of this repository anymore. A new module
2337 containing those images is now available at
2338 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2339 with the name gdcmData.
2340 All the python scripts (including the package initialisation file
2341 gdcmPython/__init__.py) were adapated to take this change into
2342 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2344 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2345 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2346 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2347 demo of the usage of this class.
2348 Compilation of this vtk part is only done when using the --enable-vtk
2349 at configure (or autogen.sh) stage.
2351 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2352 * More memory link related corrections and documentation fixes.
2354 - maximum info is obtained with a command of the form:
2355 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2356 --show-reachable=yes PrintHeader
2357 - the remaining reachable blocks seem to come from the STL
2358 allocation scheme through the usage of map and list. It looks
2359 like this memory cannot be freed but it is not a memory leak
2360 (in fact further invocation to the STL would recollect the
2361 unused memory allthough it cannot explicitely be freed).
2362 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2363 of displaying an image parsed with gdcm and displayed with VTK.
2364 Note: some images don't seem to work e.g.
2365 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2366 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2367 Allthough this weakens the semantics, it is a ditch attempt to
2368 make gdcm more thread friendly.
2370 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2371 * Memory link hunt (by using valgrind through the command
2372 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2373 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2374 gdcmHeader::_dicom_vr.
2375 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2376 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2378 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2380 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2381 * src/Makefile.am now exports all the necessary include files at
2385 * UpdateGroupLength replaced by new one
2388 * UpdateGroupLength re-written using H-Table
2389 (named UpdateGroupLengthNew untill checks are over)
2391 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2392 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2393 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2395 - gdcmHeader::GetPubElValSet removed.
2396 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2397 UpdateGroupLength, WriteElements, Write.
2398 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2399 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2400 carried the same semantics.
2401 - src/gdcmHeaderIdo.cxx changed accordingly.
2402 - gdcmFile::WriteBase now regroups all the codes from previous
2403 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2404 - enum FileType moved to gdcmCommon.h
2405 * src/gdcmHeader.cxx AddDefault trashed
2406 * gdcmGetXSize added
2407 * getimageDataSize now calls gdcmGetXSize
2408 * Test/*.cxx changed to agree with above changes
2410 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2412 (to avoid double call by end user).
2413 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2414 by end user, since gdcmHeader::gdcmHeader now handles it.
2416 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * gdcm/Doc many doxygen changes:
2418 - Doxyfile now has two different versions, DoxyfileUsers that generates
2419 the html.users end users oriented documentation and
2420 DoxyfileDeveloppers that generates the html.developper developper
2421 oriented documentation.
2422 - README changed accordingly
2423 - requirement.txt removed (old design info moved to TODO).
2424 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2425 DoxyMainPage.txt, DoxyPython.txt provide more information.
2426 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2427 be updated by simply regenerating the docs with doxygen and copying
2428 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2429 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2430 all the tests in the form "if (<map>.count() >1)" were removed.
2431 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2432 ill-formed documentation sections.
2433 * src/gdcmHeader.cxx: ditto
2435 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * setup.py fixed for un*x (needed macro for stdint.h)
2437 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2438 un*ces with sh-utils test utility.
2439 * gdcmPython/demo/test.py renamed to PrintHeader.py
2440 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2441 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2442 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2443 * src/gdcm*.cxx JPR's bad inclusion fixed.
2445 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2447 * gdcmPython/demo/test.py changed accordingly.
2449 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * gdcmPython/Makefile.am fixed linking against libstdc++
2451 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2452 * Swig subdir (historical tests of swig version 1.3.17++) removed
2453 * Test/testChangeEntete.cxx some lines commented out in order to make
2455 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2456 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2458 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2459 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2460 hence the user doesn't need this explicit call.
2461 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2462 i.e. LoadElements() call removed.
2463 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2464 - src/Makefile.am declares the proper flag for g++.
2465 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2466 for adding user defined new tags.
2467 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2468 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2469 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2471 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2472 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2473 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2474 src/Makefile.am : the project should properly compile and install
2475 with the autotools, included the python wrappers part.
2476 * gdcm.spec.in : added a spec file for RPM packaging.
2478 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2479 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2481 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2483 to exported to the environement (see gdcmPython/testSuite.py
2485 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2486 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2487 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2488 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2489 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2491 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * gdcmPython/__init__.py doesn't crash anymore when running in
2493 in InstallMode or PreInstallMode but with an environement given
2494 value of GDCM_DICT_PATH.
2495 * src/gdcmDictSet.[cxx/h] coding style.
2497 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2498 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2499 * src/gdcm.h general comments moved to TODO, and README
2500 * src/gdcm.h should now be seen as a user commodity (including it
2501 should suffice to fully use gdcm). It is nowhere including within
2502 any of the kernel files src/*.cxx and src/*.h.
2504 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2506 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2508 * src/gdcm*.cxx only include their corresponding include file
2509 (as opposed to gdcm.h)
2510 * gdcmPython/gdcm.i changed accordingly
2511 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2512 the autogen.sh generated "make snapshot" command to work.
2513 * autogen.sh removed history related references to crea package.
2515 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * distutilsSwigCPlusPlus.py work around some swig portability
2519 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2521 was done in a last ditch attempt to get setup.py _really_
2522 operationnal. The python/gdcmPython layaout add the advantage
2523 of hidding away the python related distutils specific files
2524 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2525 Alas, the src directory was out of scope (i.e. it's relative
2526 position to setup.py was ../src) which made things impossible to
2527 handle (see previous version of python/setup.py). Crossing fingers...
2529 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * python/setup.py now works on Un*x. (harder than I thougth)
2531 * python/distutilsSwigCPlusPlus.py can now have include files
2532 among the list of sources.
2534 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2535 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2536 * modifications in MSVC projects
2538 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2539 * As stated by the first lines of Test/ExceptionAndPython/README, it
2540 looks like we can move back to original usage of exception within
2541 src/gdcm* and hence remove the errno stuff that was introduced
2542 as a quick and dirty fixture of this problem (added to the TODO).
2543 * Doc/Doxyfile configuration file for Doxygen and corresponding
2544 README file for usage added.
2545 * Test/testWrite.cxx added. This new test comes from a split of
2546 test.cxx that is now reverted to its original purpous i.e.
2547 testing the proper parsing of a Dicom related file.
2548 testWrite.cxx concentrates on testing the IO part of gdcm.
2549 * Test/bug1.cxx (containing a bug on WIn32) added.
2550 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2551 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2552 whose purpose is to publish the content of the TagNames of the
2553 Dicom public dictionnary were not accessible without an
2554 instance of class gdcmHeader.
2555 - those methods are now static methods of gdcmDictSet and hence
2556 require no instances at all to be invocated.
2557 - within gdcmDictSet this change required to change some method
2558 to class methods (i.e. are now static) among which SetDictPath
2559 (renamed to BuildDictPath) and LoadDefaultPubDict.
2560 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2561 the above changes by calling the new method classes of gdcmDictSet.
2562 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2563 the above to be effective.
2564 * python/gdcmPython: in order to wrap properly the above changes
2565 for Python, swig version now needs to be > 1.3.17.
2566 * python/gdcmPython/Makefile fixed to adapt itself to new
2567 configure/make shema introduced by Johan Montagnat (thanks for the
2568 contribution). Alas this Makefile cannot be turned into a proper
2569 Makefile.am without some heavy changes in the configure.in
2570 (for python dectection).
2571 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2572 now avoids publishing the empty entries.
2574 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2575 * python/setup.py : bug fix concerning install under windows
2576 ExtraPath reused :-P
2577 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2579 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2580 * Dicts/dicomV3.dic : remove double spaces !!!
2581 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2582 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2585 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2586 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2587 method. Doxygenation.
2588 * src/gdcm.h clean up of JPR spurious comments.
2590 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2591 * python/distutilsSwigCPlusPlus.py now properly collects the
2592 shadow classes generated by "swig -c++" (gdcm.py in our case)
2593 when using "python setup.py install".
2594 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2595 reexports the working classes.
2596 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2597 by the classical C errno scheme. This is to prevent an obscure
2598 behavior of the python wrappers when importing wxPython.wx prior
2599 to gdcmPython (which ended up in an abort call). An illustration
2600 of this oddity can be found in the Test/ExceptionAndPython
2601 subdir (see the README file). This problem probably due to
2602 an combination of g++ and dynamic loading.
2603 * added Test/ExceptionAndPython (see above)
2605 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2606 * Changed the layout of the python part to avoid bloating main
2607 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2608 i.e. the distutils arsenal. All the python related stuff is
2609 again in a python subdir, but the package itself is now in
2611 * setup.py was cleaned up:
2612 - pythonIncludePath removed
2613 - python setup.py bdist target is now functional.
2614 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2615 collision with other packages). gdcmPython/demo/*.py changed
2618 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * python subdir moved to gdcmPython (preparation of distutils packaging).
2620 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2621 distutils installer is operational.
2622 * - gdcmPython/__init__.py now properly loads the swig generated
2623 shadow classes (from gdcm.py).
2624 - gdcmPython/demo/*.py changed to import the package gdcmPython
2625 instead of gdcmPython/demo/load.py.
2626 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2628 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2629 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2630 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2631 entries within the associated public Dicom dictionary resp. the same
2632 information but sorted by the fourth field (PAT, IMG, DIR) of the
2634 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2635 are now in the "???" group.
2636 - python/gdcm.i changed accordingly,
2637 - python/demo/printGroupedPublicDict.py added, that gives an example
2638 of the above new functionalities in Python.
2640 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2641 * src/gdcm.h, gdcmHeader.cxx:
2642 - historic references to glib's g_malloc and g_free (#defined)
2643 were definitively removed.
2644 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2645 * src/gdcmElValSet.cxx:
2646 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2647 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2648 - GetElValue(string) renamed to GetElValueByName.
2649 - Added GetElementByName(string).
2650 * src/gdcmHeader.cxx: added
2651 - GetPubElValRepByNumber(guint16, guint16)
2652 - GetPubElValRepByName(string)
2653 - GetShaElValRepByNumber(guint16, guint16)
2654 - GetShaElValRepByName(string)
2655 - GetShaElValByNumber(guint16, guint16)
2656 - GetShaElValRepByName(string)
2657 - GetElValRepByNumber(guint16, guint16)
2658 - GetElValRepByName(string)
2659 - GetElValByNumber(guint16, guint16)
2660 - GetElValRepByName(string)
2661 * Doc/requirements.txt added.
2663 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2664 * Test/Makefile building now depends on the one of libgdcm.so
2665 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2666 pixel data) aware which enables finding the address (offset) of
2667 the pixel data of JPEG encoded DICOM files. This leaves only a single
2668 file in the testSuite whose pixel data address (offset) is unknown.
2669 * python/testSuite.py changed accordingly.
2671 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2672 * VC++ has some strong limitations when working with the STL, as stated
2673 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2674 "Also note that some STL containers (map, set, queue, list, deque)
2675 cannot be exported. [...]
2676 Some STL classes contain nested classes. These classes can not
2678 This is caused by a designed limitation that once a template
2679 class is instantiated, it can not be re-instantiated and
2681 Since our usage of map<> is ubiquitous in gdcm, this "designed
2682 limitation" of VC++ is a pitfall.
2683 Hence the Python wrappers of gdcm cannot be incrementally linked
2684 against the c++ dynamic library. The dirty but only workaround is
2685 to forget about incremental link of dynamic libraries and to generate
2686 the Python wrappers library with the inclusions of the underlying C++
2688 The following modifications concern this matter on Win32/VC++:
2689 - wrapping python correct with standalone wrapped dll (don't use separate
2690 dll under windows !!!!)
2691 - python21_d debug mode enabled (ask Frog how to use it :-)
2692 - NO problem with having an STL member of class for example string in C++
2693 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2694 - Python test of dcmlib in Python is ok under windows on a large set
2696 * removed glib references
2697 * typedef's inserted in gdcm.i for correct swig type management
2699 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * python/demo/*.py load.py extracted from test.py. Added explore.py
2701 that only displays required tags and testAll.py that parses all
2702 the files of the testsuite without using unittest.
2703 * python/testSuite.py other additional test on new files added.
2704 * Data/* new test files added accordingly to the testSuite.
2705 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2706 the vr in the file differs from the one of the dictionary.
2708 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2710 values, but limits itself to values which are below a user specified
2711 size (by default 1024 bytes).
2712 * python/gdcm.i : elements not loaded (because their size is above the
2713 user specified treshold) are exported with their TagKey as key of the
2714 python dictionary. This enables the testsuite to make some checks
2715 on the unloaded elements (since we have their offset and size).
2716 * python/testSuite.py
2717 - now tests for the existence and proper value of the pixel data
2718 - two new examples added.
2719 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2721 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2722 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2723 aware. See the strategy comments in gdcmHeader::FindeLength().
2724 * Test/test.cxx now accepts a filename as first argument.
2725 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2726 * python/testSuite.py changed to integrate test on above files.
2728 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2730 the vr was also RET.
2731 * python/testSuite.py more tests added.
2733 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2734 * python/testSuite.py unittest test suite added (uses Data)
2735 * Data/* dcm and acr files for the test suite.
2736 * glib dependance removed from un*x version. We now use ISO C99
2737 7.18 Integer types (see stdint.h)
2738 - python/Makefile, src/Makefile src/gdcm.h
2739 * src/ when an explicit vr (like dicom files) suddenly poped an
2740 implicit element we use to mark the underlying DictEntry of the
2741 concerned ElValue with "Implicit". This strategy was damageable
2742 too the public or provite dictionaries, since some of their vr
2743 would be changed. Since Header::FindLength heavily relies on the
2744 detection by Header::FindVR of falsely explicit elements, I
2745 added an extra ImplicitVr member to ElValue (boolean).
2746 The rest of the changes we the necessary adaptations.
2748 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2751 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2753 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2754 * Adaptation for porting to VC++:
2756 o forced to use std namespace (for string to be known)
2757 o all class use __declspec export style on WIN32
2758 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2759 (in stdlib.h on Win32 but in std:: for gcc)
2760 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2761 variable GDCM_DICT_PATH.
2762 * src/gdcmHeader.cxx verbose comments made discrete.
2764 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2765 * python/gdcm.i: added a typemap that converts a C++ hashing table
2766 to native Python dictionary.
2767 * python/demo/test.py:
2768 - now uses the native dictionary for exploration of gdcmHeader.
2769 - takes an optional filename argument (the file to parse).
2770 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2771 PubElVals hashing table.
2772 * Dicts/dicomV3.dic removed error prone trailing spaces.
2774 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * Python wrapping process moved away from src/Makefile to
2776 newly created python/Makefile (as well as gdcm.i)
2777 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2778 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2779 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2780 from the environement variable GDCM_DICT_PATH (when existing).
2781 * src/gdcmDict::GetTag bug fix.
2783 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * Straightforward temporary fixes for swig to build the python wrappers.
2785 src/Makefile now has a python working entry [by working we mean
2786 that we can import de shadow classes without errors].
2788 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2789 * hashtest.cxx removed (since allready in Test)
2790 * src/gdcmlib.h renamed to src/gdcm.h
2791 * src/dcm.i renamed to src/gdcm.i
2792 * src/Makefile prepared for python wrapping
2794 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * src/gdcmHeader.cxx :
2796 - Parsing of header is now separated from loading of element values
2797 (see gdcmHeader::LoadElements).
2798 - general clean up of hopefully all file access (creation of
2799 ReadInt16 and ReadInt32)
2801 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * src/gdcmHeader.cxx :
2803 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2805 - SetLgrElem renamed to SetLength
2806 - GetLgrElem renamed to GetLength
2807 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2808 * src/gdcmElValSet.cxx fixed both GetElValue methods
2809 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2810 due to IdoDude was cleaned out.
2812 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2814 concentrates on finding the value representation (when it exists).
2815 RecupLgr now only finds the element value length, and it avoids
2816 returning the unecessary skL (skipped length).
2817 Also, offsetCourant was simply removed (with taille_fich) since
2818 it was redundant with the File position internals (by using
2819 ftell and fseek). This also made skL (see above in RecupLgr) usage
2821 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2822 on the libido specificities which are handled through class
2824 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2827 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * Truckload of changes. Parsing of header is barely functional
2829 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2831 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * src/gdcmHeader.cxx many addons of low level methods
2834 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2836 and _IdDcmSWAP_LONG.
2838 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2839 * This corresponds to all the changes decided at the meeting of
2840 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob