1 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
4 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
5 * src/gdcmHeader.h: LoadElements() is not a public method anymore
6 (to avoid double call by end user).
7 * Test/*.cxx LoadElements() doesn't need to be called explicitely
8 by end user, since gdcmHeader::gdcmHeader now handles it.
10 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * gdcm/Doc many doxygen changes:
12 - Doxyfile now has two different versions, DoxyfileUsers that generates
13 the html.users end users oriented documentation and
14 DoxyfileDeveloppers that generates the html.developper developper
15 oriented documentation.
16 - README changed accordingly
17 - requirement.txt removed (old design info moved to TODO).
18 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
19 DoxyMainPage.txt, DoxyPython.txt provide more information.
20 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
21 be updated by simply regenerating the docs with doxygen and copying
22 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
23 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
24 all the tests in the form "if (<map>.count() >1)" were removed.
25 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
26 ill-formed documentation sections.
27 * src/gdcmHeader.cxx: ditto
29 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * setup.py fixed for un*x (needed macro for stdint.h)
31 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
32 un*ces with sh-utils test utility.
33 * gdcmPython/demo/test.py renamed to PrintHeader.py
34 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
35 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
36 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
37 * src/gdcm*.cxx JPR's bad inclusion fixed.
39 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
41 * gdcmPython/demo/test.py changed accordingly.
43 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
44 * gdcmPython/Makefile.am fixed linking against libstdc++
45 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
46 * Swig subdir (historical tests of swig version 1.3.17++) removed
47 * Test/testChangeEntete.cxx some lines commented out in order to make
49 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
50 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
52 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
54 hence the user doesn't need this explicit call.
55 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
56 i.e. LoadElements() call removed.
57 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
58 - src/Makefile.am declares the proper flag for g++.
59 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
60 for adding user defined new tags.
61 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
62 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
63 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
65 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
66 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
67 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
68 src/Makefile.am : the project should properly compile and install
69 with the autotools, included the python wrappers part.
70 * gdcm.spec.in : added a spec file for RPM packaging.
72 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
75 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
77 to exported to the environement (see gdcmPython/testSuite.py
79 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
80 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
81 ElValue class renamed to gdcmElValue for obvious consistency reasons.
82 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
83 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
85 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
86 * gdcmPython/__init__.py doesn't crash anymore when running in
87 in InstallMode or PreInstallMode but with an environement given
88 value of GDCM_DICT_PATH.
89 * src/gdcmDictSet.[cxx/h] coding style.
91 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
92 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
93 * src/gdcm.h general comments moved to TODO, and README
94 * src/gdcm.h should now be seen as a user commodity (including it
95 should suffice to fully use gdcm). It is nowhere including within
96 any of the kernel files src/*.cxx and src/*.h.
98 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
99 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
100 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
102 * src/gdcm*.cxx only include their corresponding include file
103 (as opposed to gdcm.h)
104 * gdcmPython/gdcm.i changed accordingly
105 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
106 the autogen.sh generated "make snapshot" command to work.
107 * autogen.sh removed history related references to crea package.
109 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
110 * distutilsSwigCPlusPlus.py work around some swig portability
113 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * Eventually, python/gdcmPython was renamed to gdcmPython. This
115 was done in a last ditch attempt to get setup.py _really_
116 operationnal. The python/gdcmPython layaout add the advantage
117 of hidding away the python related distutils specific files
118 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
119 Alas, the src directory was out of scope (i.e. it's relative
120 position to setup.py was ../src) which made things impossible to
121 handle (see previous version of python/setup.py). Crossing fingers...
123 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * python/setup.py now works on Un*x. (harder than I thougth)
125 * python/distutilsSwigCPlusPlus.py can now have include files
126 among the list of sources.
128 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
130 * modifications in MSVC projects
132 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
133 * As stated by the first lines of Test/ExceptionAndPython/README, it
134 looks like we can move back to original usage of exception within
135 src/gdcm* and hence remove the errno stuff that was introduced
136 as a quick and dirty fixture of this problem (added to the TODO).
137 * Doc/Doxyfile configuration file for Doxygen and corresponding
138 README file for usage added.
139 * Test/testWrite.cxx added. This new test comes from a split of
140 test.cxx that is now reverted to its original purpous i.e.
141 testing the proper parsing of a Dicom related file.
142 testWrite.cxx concentrates on testing the IO part of gdcm.
143 * Test/bug1.cxx (containing a bug on WIn32) added.
144 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
145 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
146 whose purpose is to publish the content of the TagNames of the
147 Dicom public dictionnary were not accessible without an
148 instance of class gdcmHeader.
149 - those methods are now static methods of gdcmDictSet and hence
150 require no instances at all to be invocated.
151 - within gdcmDictSet this change required to change some method
152 to class methods (i.e. are now static) among which SetDictPath
153 (renamed to BuildDictPath) and LoadDefaultPubDict.
154 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
155 the above changes by calling the new method classes of gdcmDictSet.
156 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
157 the above to be effective.
158 * python/gdcmPython: in order to wrap properly the above changes
159 for Python, swig version now needs to be > 1.3.17.
160 * python/gdcmPython/Makefile fixed to adapt itself to new
161 configure/make shema introduced by Johan Montagnat (thanks for the
162 contribution). Alas this Makefile cannot be turned into a proper
163 Makefile.am without some heavy changes in the configure.in
164 (for python dectection).
165 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
166 now avoids publishing the empty entries.
168 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * python/setup.py : bug fix concerning install under windows
171 * gdcm.dsw : bug fix concerning path for libraries for python !!!
173 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
174 * Dicts/dicomV3.dic : remove double spaces !!!
175 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
176 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
179 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
180 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
181 method. Doxygenation.
182 * src/gdcm.h clean up of JPR spurious comments.
184 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * python/distutilsSwigCPlusPlus.py now properly collects the
186 shadow classes generated by "swig -c++" (gdcm.py in our case)
187 when using "python setup.py install".
188 * python/gdcmPython/__init__.py imports gdcm.py and only manually
189 reexports the working classes.
190 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
191 by the classical C errno scheme. This is to prevent an obscure
192 behavior of the python wrappers when importing wxPython.wx prior
193 to gdcmPython (which ended up in an abort call). An illustration
194 of this oddity can be found in the Test/ExceptionAndPython
195 subdir (see the README file). This problem probably due to
196 an combination of g++ and dynamic loading.
197 * added Test/ExceptionAndPython (see above)
199 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
200 * Changed the layout of the python part to avoid bloating main
201 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
202 i.e. the distutils arsenal. All the python related stuff is
203 again in a python subdir, but the package itself is now in
205 * setup.py was cleaned up:
206 - pythonIncludePath removed
207 - python setup.py bdist target is now functional.
208 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
209 collision with other packages). gdcmPython/demo/*.py changed
211 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
212 * python subdir moved to gdcmPython (preparation of distutils packaging).
213 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
214 distutils installer is operational.
215 * - gdcmPython/__init__.py now properly loads the swig generated
216 shadow classes (from gdcm.py).
217 - gdcmPython/demo/*.py changed to import the package gdcmPython
218 instead of gdcmPython/demo/load.py.
219 - gdcmPython/testSuite.py changed to import the package gdcmPython.
222 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
223 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
224 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
225 entries within the associated public Dicom dictionary resp. the same
226 information but sorted by the fourth field (PAT, IMG, DIR) of the
228 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
229 are now in the "???" group.
230 - python/gdcm.i changed accordingly,
231 - python/demo/printGroupedPublicDict.py added, that gives an example
232 of the above new functionalities in Python.
234 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
235 * src/gdcm.h, gdcmHeader.cxx:
236 - historic references to glib's g_malloc and g_free (#defined)
237 were definitively removed.
238 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
239 * src/gdcmElValSet.cxx:
240 - GetElement(guint32, guint32) renamed to GetElementByNumber.
241 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
242 - GetElValue(string) renamed to GetElValueByName.
243 - Added GetElementByName(string).
244 * src/gdcmHeader.cxx: added
245 - GetPubElValRepByNumber(guint16, guint16)
246 - GetPubElValRepByName(string)
247 - GetShaElValRepByNumber(guint16, guint16)
248 - GetShaElValRepByName(string)
249 - GetShaElValByNumber(guint16, guint16)
250 - GetShaElValRepByName(string)
251 - GetElValRepByNumber(guint16, guint16)
252 - GetElValRepByName(string)
253 - GetElValByNumber(guint16, guint16)
254 - GetElValRepByName(string)
255 * Doc/requirements.txt added.
257 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * Test/Makefile building now depends on the one of libgdcm.so
259 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
260 pixel data) aware which enables finding the address (offset) of
261 the pixel data of JPEG encoded DICOM files. This leaves only a single
262 file in the testSuite whose pixel data address (offset) is unknown.
263 * python/testSuite.py changed accordingly.
265 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
266 * VC++ has some strong limitations when working with the STL, as stated
267 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
268 "Also note that some STL containers (map, set, queue, list, deque)
269 cannot be exported. [...]
270 Some STL classes contain nested classes. These classes can not
272 This is caused by a designed limitation that once a template
273 class is instantiated, it can not be re-instantiated and
275 Since our usage of map<> is ubiquitous in gdcm, this "designed
276 limitation" of VC++ is a pitfall.
277 Hence the Python wrappers of gdcm cannot be incrementally linked
278 against the c++ dynamic library. The dirty but only workaround is
279 to forget about incremental link of dynamic libraries and to generate
280 the Python wrappers library with the inclusions of the underlying C++
282 The following modifications concern this matter on Win32/VC++:
283 - wrapping python correct with standalone wrapped dll (don't use separate
284 dll under windows !!!!)
285 - python21_d debug mode enabled (ask Frog how to use it :-)
286 - NO problem with having an STL member of class for example string in C++
287 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
288 - Python test of dcmlib in Python is ok under windows on a large set
290 * removed glib references
291 * typedef's inserted in gdcm.i for correct swig type management
293 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * python/demo/*.py load.py extracted from test.py. Added explore.py
295 that only displays required tags and testAll.py that parses all
296 the files of the testsuite without using unittest.
297 * python/testSuite.py other additional test on new files added.
298 * Data/* new test files added accordingly to the testSuite.
299 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
300 the vr in the file differs from the one of the dictionary.
302 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
304 values, but limits itself to values which are below a user specified
305 size (by default 1024 bytes).
306 * python/gdcm.i : elements not loaded (because their size is above the
307 user specified treshold) are exported with their TagKey as key of the
308 python dictionary. This enables the testsuite to make some checks
309 on the unloaded elements (since we have their offset and size).
310 * python/testSuite.py
311 - now tests for the existence and proper value of the pixel data
312 - two new examples added.
313 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
315 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
316 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
317 aware. See the strategy comments in gdcmHeader::FindeLength().
318 * Test/test.cxx now accepts a filename as first argument.
319 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
320 * python/testSuite.py changed to integrate test on above files.
322 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
323 * Dicts/dicomV3.dic removed all the trailing (RET) when the
325 * python/testSuite.py more tests added.
327 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * python/testSuite.py unittest test suite added (uses Data)
329 * Data/* dcm and acr files for the test suite.
330 * glib dependance removed from un*x version. We now use ISO C99
331 7.18 Integer types (see stdint.h)
332 - python/Makefile, src/Makefile src/gdcm.h
333 * src/ when an explicit vr (like dicom files) suddenly poped an
334 implicit element we use to mark the underlying DictEntry of the
335 concerned ElValue with "Implicit". This strategy was damageable
336 too the public or provite dictionaries, since some of their vr
337 would be changed. Since Header::FindLength heavily relies on the
338 detection by Header::FindVR of falsely explicit elements, I
339 added an extra ImplicitVr member to ElValue (boolean).
340 The rest of the changes we the necessary adaptations.
342 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
345 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
347 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
348 * Adaptation for porting to VC++:
350 o forced to use std namespace (for string to be known)
351 o all class use __declspec export style on WIN32
352 - src/gdcmUtil.cxx new Exit method that wraps the exit call
353 (in stdlib.h on Win32 but in std:: for gcc)
354 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
355 variable GDCM_DICT_PATH.
356 * src/gdcmHeader.cxx verbose comments made discrete.
358 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
359 * python/gdcm.i: added a typemap that converts a C++ hashing table
360 to native Python dictionary.
361 * python/demo/test.py:
362 - now uses the native dictionary for exploration of gdcmHeader.
363 - takes an optional filename argument (the file to parse).
364 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
365 PubElVals hashing table.
366 * Dicts/dicomV3.dic removed error prone trailing spaces.
368 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * Python wrapping process moved away from src/Makefile to
370 newly created python/Makefile (as well as gdcm.i)
371 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
372 * src/gdcmHeader::FindLength only looks for current vr when necessary.
373 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
374 from the environement variable GDCM_DICT_PATH (when existing).
375 * src/gdcmDict::GetTag bug fix.
377 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * Straightforward temporary fixes for swig to build the python wrappers.
379 src/Makefile now has a python working entry [by working we mean
380 that we can import de shadow classes without errors].
382 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * hashtest.cxx removed (since allready in Test)
384 * src/gdcmlib.h renamed to src/gdcm.h
385 * src/dcm.i renamed to src/gdcm.i
386 * src/Makefile prepared for python wrapping
388 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * src/gdcmHeader.cxx :
390 - Parsing of header is now separated from loading of element values
391 (see gdcmHeader::LoadElements).
392 - general clean up of hopefully all file access (creation of
393 ReadInt16 and ReadInt32)
395 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * src/gdcmHeader.cxx :
397 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
399 - SetLgrElem renamed to SetLength
400 - GetLgrElem renamed to GetLength
401 - ~gdcmHeader() made virtual to pesky warning messages at compile.
402 * src/gdcmElValSet.cxx fixed both GetElValue methods
403 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
404 due to IdoDude was cleaned out.
406 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
408 concentrates on finding the value representation (when it exists).
409 RecupLgr now only finds the element value length, and it avoids
410 returning the unecessary skL (skipped length).
411 Also, offsetCourant was simply removed (with taille_fich) since
412 it was redundant with the File position internals (by using
413 ftell and fseek). This also made skL (see above in RecupLgr) usage
415 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
416 on the libido specificities which are handled through class
418 * Test/implicit_vr.dcm dicom v3 in implicit value representation
421 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * Truckload of changes. Parsing of header is barely functional
423 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
425 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * src/gdcmHeader.cxx many addons of low level methods
428 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
429 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
432 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * This corresponds to all the changes decided at the meeting of
434 May 23 2002. Needless to say we are running late...