1 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * In order to fix memory leaks:
3 - Test/TestWriteSimple.cxx: added cleaning of free store through
5 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
6 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
7 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
8 (through the call to ::AddDicomDirMeta()) or the destructor
9 would crash when deleting uninitialized ::metaElems].
10 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
11 - src/gdcmDocument.cxx:
12 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
14 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
15 was causing memory leaks.
17 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
18 cleanly handled with polymophism: sorry but my milage is low).
19 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
20 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
21 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
22 This avoids SegFaulting.
23 - src/gdcmSQItem.h: coding style.
25 - Test/TestWriteSimple still severely sucks. The output image content
26 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
27 damaged when displayed with vtkgdcmViewer.
28 - on memory leaks: TestWriteSimple leaks really less (see entry
29 of 2004-06-18 in Changelog file for the call to valgrind).
30 - on segfaults: ctest now passes all the tests but one (no more
32 * Erroneous leading white fix:
33 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
34 white[s] (as opposed to from >> xxx, that removes it [them].
35 - src/gdcmTS.cxx: ditto.
36 - gdcmPython/testSuite.py: dirty related kludge removed.
37 * src/*: remaining references to gdcmParser removed.
38 * src/*[cxx|h]: added copy[way]left header.
40 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * In order to fix writing of dicom files:
42 - Test/TestWriteSimple.cxx: a simpler example of writing.
43 - Test/CMakeLists.txt changed accordingly.
44 - src/gdcmDocument.cxx:
45 -- The destructor now recursilvely removes potential sequences.
46 -- Bug fix in ::IsJPEG2000()
47 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
48 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
50 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
51 to only declared) and build on top of
52 ::GetDocEntryByNumber(guint16, guint16).
53 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
54 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
55 for usage in destructor and treatement of promotion in
56 ::ReplaceOrCreateByNumber().
57 - src/gdcmSQItem.cxx: destructor should better handle his job.
58 Test/TestWriteSimple now runs (or at least it DOES something).
59 * We can now start hutting memory links. A good starting point is:
60 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
61 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
62 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
64 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
65 * Valgrind note: after Mathieu Malaterre teached me how to read
66 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
68 Using gcc, you can force the STL to use malloc and to free memory as
69 soon as possible by globally disabling memory caching.
70 With 3.2.2 and later, you should export the environment variable
71 GLIBCPP_FORCE_NEW before running your program.
72 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
73 simply vanish (it is still not clear to me, whether this means that
74 STL std::string leaks or if valgrind believes it leaks...).
75 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
76 running bin/gdcmTests makeDicomDir):
77 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
78 - Test/makeDicomDir.cxx now properly traps empty lists and returns
80 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
81 SegFaulting (I drowned in DicomDir related code when trying to
82 understand why the list is empty...).
83 * src/gdcmDocument.h: first BSD license header try.
84 * Doc/License.txt added.
86 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
87 * src/gdcmDocument.[h|cxx]:
88 - Clean up of the Transfer related predicates. They are now all based
89 on new method isGivenTransferSyntax, that (should) handle properly
91 - general clean up, simplification, and coding style.
92 - Specific clean up of Parse7FE0() (umproperly named actually).
93 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
95 2004-06-14 Jean-Pierre Roux
97 - fix the display of Sequence Delimitor (SQDepthLevel pb)
98 - fix the display of SQItem ordinal number
99 - add the GetSQItemByOrdinalNumber method
100 - remove some useless never written private methods
102 2004-06-14 Jean-Pierre Roux
104 - adding a constructor taking a gdcmDocEntry as an input param
105 - ReplaceOrCreateByNumber now returns :
106 a gdcmBinEntry * if a Binary (void *) value is passed as a param
107 a gdcmValEntry * if a string value is passed as a param
109 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
110 according to the param type (no longer sets a gdcmDocEntry)
111 - GetValEntryByNumber, GetBinEntryByNumber added
112 - NewValEntryByNumber and NewBinEntryByNumber added
114 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
116 - GetSQItemNumber and SetSQItemNumber added, to provide
117 a (relative) Item identier inside a given Sequence
118 \warning : some pb remaining around this number
120 - AddEntry now takes the Item Number as a param
122 - adding a constructor taking a gdcmDocEntry as an input param
124 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
125 * Memory leak hunt with the following command:
126 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
127 --show-reachable=yes gdcmTests PrintDocument
128 It looks like many (all?) leaks are due to the STL (or a bad usage
129 of the STL. The lines producing the leaks now have a comment with
130 a "MEMORY LEAK" tag: you can retrieve them with
131 grep "MEMORY LEAK" src/*
132 Here are two typical examples which I can't help fixing:
137 char * test = "babo";
138 name = test; //// <--- valgrind detects 960 bytes lost in
139 //// call to std::string::operator=(char const*)
140 name.clear(); //// Doesn't help !
148 std::cout << "Type a bunch of characters followed by RETURN: ";
149 getline(std::cin, line); //// <--- valgrind dectects a loss
150 //// of 1320 bytes in call to
151 /// std::basic_istream<>& std::getline<>
157 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
158 * src/gdcmHeader.[cxx|h]:
159 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
160 and related, moved away to gdcmDocument.
161 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
162 the corresponding protected accessors of inherited class
163 gdcmDocument, removed ! As a consequence gdcmFile had to be
164 declared friend of class gdcmDocument (see below).
165 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
166 - Clean up of undefined or unused methods.
167 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
168 account the changes to gdcmHeader.h).
169 * src/gdcmDocument.h:
170 - gdcmFile is now a friend class (in order to take into account the
171 changes to gdcmHeader.h).
172 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
173 (see changes to gdcmHeader.h).
174 - Accessors (reading on the form GetEntry*) are now public.
175 - Clean up of undefined or unused methods.
176 * src/gdcmDocument.cxx:
177 - adaptation to changes to gdcmDocument.h
178 - ::OpenFile now writes a verbose message when file cannot be opened.
179 - some std::string properly set to VRKey
180 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
181 references to gdcmDocument.
182 * Test/TestFindTags.cxx: changed accordingly to above changes.
183 * gdcmPython/testSuite.py: adapted to renaming of acr files in
184 cvs repository gdcmData.
186 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
187 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
188 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
189 conflicts with gdcmValEntry::voidArea.
190 * src/gdcmValEntry.cxx: unmatching comment wiped out.
191 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
192 Value representation between StringRepresentable and BinaryRepresentable.
193 * src/gdcmDocument.cxx:
194 - method ParseDES: proper indentation restored and usage of
195 gdcmVR::IsVROfGdcmStringRepresentable wired in.
196 - method LoadDocEntry: the fingerprint left in the SetValue() of
197 unloaded entries (length > MaxSizeLoadEntry) had curiously been
198 removed. Reverting to previous code segment with the proper
199 dynamic_cast< gdcmValEntry* >.
200 Note: this was (partially) breaking the python test suite
201 (gdcmPython/testSuite.py) that made usage of the above
202 fingerprint to check presence of "Pixel Data".
203 * src/gdcmDocEntry.h: coding style.
204 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
205 now taken into account.
206 * gdcmPython/gdcm.i: adaptation to the new internal representation
207 of gdcm (exit gdcmParser, hello gdcmDocument).
208 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
210 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
211 anymore, but instead prints the loaded Python dictionary.
212 * .... alas, the python testSuite is still broken.
214 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
217 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
218 * src/gdcmUtil.h : export methods
220 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
221 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
223 * Initial addition of automatic python testing
224 * Initial addition of automatic image comparison
226 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
228 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
230 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
232 * Test/ShowDicom.cxx : bug fix for msvc compilation
233 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
235 2004-05-04 Jean-Pierre Roux
236 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
237 new concepts (and new classes) :
238 a 'gdcmDocument' is composed of a set of Doc Entries, that are
239 - elementary gdcmDocEntries (former gdcmHeaderEntries)
240 - Sequence Doc Entries (gdcmSeqEntries)
241 a Sequence is composed of Items.
242 Each item is a set of Doc Entries (this is recursive)
243 The non uniqueness of the 'Dicom tag' is due to this recursivity
244 (never taken into account)
245 Our unability to add a new 'entry' in the header
246 at the proper location (neither in the H-Table (map or multimap),
247 nor in the Chained List is also due to this recursivity.
248 Don't try, right now, to use/modify/compile these new sources :
250 We just commit all the stuff, 'as is', in order not to loose it.
252 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
255 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
257 file prefix (SetFilePrefix)
259 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
260 * Add a new test: ShowDicom, for now this is just the c++ version of
261 checkRead.sh, later it will be able to compare the image read against a
263 * Replace the DEBUG on the stack with a global entry in cmake interface:
264 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
266 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
267 * Add an example subdir, with a real example on how to read + write a
270 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
271 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
272 * Doc/CMakeLists.txt: the main page is now properly differentiated
273 between the developper and user version.
274 * Doc/doxygen.config.in: dropped search related obsolete flags
275 * src/gdcmParser.h, gdcmHeader.h: doxygenation
277 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
278 * DEVELOPPER: added some helpfull comments for compile/test/install
281 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
283 src directory, now generated in the build dir.
284 2. Tests as mentionned smarter
286 4. Add a new method in gdcmDict that return the PubDict by name
287 this is interesting for 3rd party lib like ITK,
288 where we could set the institution name / patient name...
290 * ENH: 1. Now the test suite is working for real
291 2. All binaries are now output in the gdcm-bin directory
292 (this was not true before)
294 2004-04-28 Jean-Pierre Roux
295 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
296 SeQuence indented printing of Dicom Header.
297 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
298 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
299 Computation of SQDepthLevel is now part of gdcmHeader constructor
300 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
301 tree-like structure of a Dicom Header.
302 * FIX Test code cleaning
304 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
305 * ENH: Adding automatic testing
306 1. Need a DartConfig.cmake to submit to public
307 2. Add a test driver gdcmTest.cxx
308 3. gdcmTestMain, an helper for the main test driver gdcmTest
309 4. Files in Test don't have a main anymore, this becomes interesting
310 when we add more and more tests, thus dsw don't have to load
312 * ENH: Adding a GDCM_DATA_ROOT for testing
313 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
314 one file instead of seven + some small cleanup
316 2004-04-22 Jean-Pierre Roux
317 * ENH Minor changes to the Print() methods.
318 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
319 Header printing. Example given with :
320 > PrintHeader fileName 2 new
321 (SQ based tree-like structure still to be done for the Header ...)
323 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
324 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
325 1. I have added some unsigned where needed
326 2. Some function parameter not used -> (void)
327 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
328 4. g++ don't like character '\' in comment
329 5. #define jpeg_create_decompress jCreaDecompress
330 this really need to be fixed
331 6. virtualize destructor of gdcmObject ... leakage
332 7. sscanf(g->first.c_str(),"%x",&gr_bid);
333 this also really need to be fixed
334 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
335 remove compression file
336 (as we only do decompression, right ?)
337 * ENH: Change malloc/calloc/free with c++ equivalent
339 2004-04-21 Jean-Pierre Roux
340 * FIX gdcmHeaderHelper::GetXSpacing
341 when a single value is found (bug ?), xpacing is now
342 defaulted to yspacing
344 2004-04-19 Jean-Pierre Roux
345 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
346 * ENH add parameters :
347 bool exception_on_error = false,
348 bool enable_sequences = false,
349 bool ignore_shadow = false
350 to the gdcmFile constructors to be full gdcmParser compliant
351 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
352 to allow reading of PAPYRUS 3.0 files
354 2004-04-06 Jean-Pierre Roux
355 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
357 2004-04-02 Jean-Pierre Roux
358 * ADD : Test/checksequence.sh, for a general recap on SQ pb
359 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
360 for Philips spurious Tag fffe|0000 while rewritting Dicom files
362 2004-03-30 Jean-Pierre Roux
363 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
364 for ACR file, written out as DICOM files (hope so...)
366 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
367 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
368 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
369 moved to base class gdcmParser and only the specialisation is kept
371 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
372 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
373 already does the job.
374 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
375 (to be consistent with gdcmParser::WriteEntries).
377 2004-03-30 Benoit Regrain
378 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
379 upate of the object's instance. It's passed to 2 in the unfavorable
380 case : one in the ExecuteInformation, one in the ExecuteData
382 2004-03-29 Jean-Pierre Roux
383 * ENH : Check on file type to be written moved
384 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
385 * FIX : gdcmObject::ResetBoundaries now stops properly
386 when end-of-list is reached
387 : gdcmVersion modified (as Benoit Regrain asked)
389 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
391 * src/gdcmUtil.cxx: added forgotten iostream include.
392 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
393 equivalent to ExplicitVR in existing code).
395 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
397 now contains all the gdcmGlobal related code.
398 * minor coding style and doxygenation changes.
400 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
402 now contains all the Debug related code.
403 * minor clean-up of includes in src/*.cxx
404 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
405 CreateCleanString) removed.
406 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
407 * Doc/DoxyMainPageUser.txt added.
408 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
409 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
412 2004-03-24 Jean-Pierre Roux
413 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
415 2004-03-23 Jean-Pierre Roux
416 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
417 big endian made volumes
418 * ENH Now gdcmParser constructor and destructor are protected to forbid
419 end user to instanciate class gdcmParser
420 (only gdcmHeader and gdcmDicomDir are meaningfull)
422 2004-03-22 Benoit Regrain
423 * FIX : src/gdcmDicomDir.cxx : make windows compilable
424 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
425 gdcmSerie to gdcmDicomDirSerie
427 2004-03-19 Jean-Pierre Roux
428 * ENH Now the tree-like structure describing a DICOMDIR comming from
429 an already existing DICOMDIR file is consistent with
430 the home-made tree-like structure build ex-nihilo
431 or build from the files held (recursively) in a Directory
432 functions gdcmDicomDir::CheckBoundaries()
433 gdcmObject::SetBoundaries() added
435 2004-03-17 Jean-Pierre Roux
436 * REM (Eric Boix bug) : removal of meaningless
437 gdcmDicomDirImage::NewImage function.
438 * FIX now file names and directory name are written properly in the
440 * FIX now gdcmDicomDir constructor may be call without any trick
443 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
444 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
445 of gdcmDicomDirImage::NewImage as empty function.
447 2004-02-28 Jean-Pierre Roux
448 * ENH add gdcmDicomDir:NewPatient
449 add gdcmDicomDirPatient:NewStudy
450 add gdcmDicomDirStudy:NewSerie
451 add gdcmDicomDirSerie:NewImage
452 to allow making gdcDicomDir object.
453 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
454 (as opposite to the gdcmHeader chained list)
456 2004-02-11 Benoit Regrain
457 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
458 when using from python
460 2004-02-10 Benoit Regrain
461 * FIX : bug fix in the gdcmDirList for the recursivity in directories
462 * FIX : in gdcmDicomDir when the directory is empty
463 * ENH : add callback and methods to get the progression of dicomDir
466 2004-02-06 Jean-Pierre Roux
467 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
468 - GDCM_META added to gdcmDicomDirType
469 - class gdcmMeta created
470 * ENH : - A brief summary is now displayed at the beginning of
471 'testDicomDir' to help disaster magnitude estimation
472 * REM : Now useless Test/explDICOMDIR.cxx
474 2004-02-05 Benoit Regrain
475 * ENH : add methods in gdcmObject to get the hash table or the list of
477 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
478 * FIX : wrapping python for TagHeaderEntryHT
480 2004-02-04 Benoit Regrain
481 * FIX : even length for some strings when writting the dicom dir
482 * FIX : sort the images in the dicom dir
483 * FIX : Bug fix for python use of dicom dir
484 * ADD : a python demo
486 2004-02-04 Jean-Pierre Roux
487 * FIX : Final solution (?) for icone embedded images
488 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
489 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
490 add groups 6002, 6004, 6006, to allow 'clean' parsing of
491 gdcmData/gdcm-MR-SIEMENS-16.acr1
492 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
493 to make full checking easier
495 2004-02-04 Benoit Regrain
496 * FIX : WriteEntries : coding style & logic in parameters
497 * FIX : Set the elements to create the DicomDir in a dictionary file
499 2004-02-03 Benoit Regrain
500 * gdcmDirList : to parse a hard drive directory in recursive (or not)
501 * gdcmDicomDir : add the load of directory
502 * Bug fix and print add-on
504 2004-02-03 Jean-Pierre Roux
505 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
506 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
507 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
508 * FIX gdcmParser.cxx : 'group length' elements are now considered
509 as integers, even for shadow groups, when file is Implicit VR
511 2004-02-02 Jean-Pierre Roux
512 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
514 of the last synonym :-(
515 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
517 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
518 * FIX taking into account the possible 7fe0,0010 multiplicity
519 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
520 to allow removal of references to 7fe0,0010, to deal with
521 ACR-NEMA images, when 0028,0200 is meaningfull
523 2004-01-31 Jean-Pierre Roux
524 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
525 no longer writes 'Un' on disk
526 * FIX SQ elements with actual length are now dealt with corectly
527 * FIX gdcmFile::WriteBase make the difference, for color images, between
528 the length (for Palette expanded images)
529 and Raw Length (non expanded image + Palette)
530 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
531 (that broke Write). Replaced by UL.
532 Aware user will reload the field if he
533 thinks it's necesssary
535 2004-01-30 Jean-Pierre Roux
536 * gdcmParser::CheckSwap() now defaults the filetype to ACR
537 when 'dirty Acr' is found, to be compliant with the new
538 IsReadable() methods.
540 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
541 (no DOUBLE images in kosher DICOM,
542 but so usefull for people that miss them ;-)
544 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
545 DICOMDIR related utilities (not checked as Windoze compliant)
547 2004-01-28 Jean-Pierre Roux
548 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
550 2004-01-27 Jean-Pierre Roux
551 * gdcmParser constructor has a new boolean param,'ignore_shadow',
552 to allow skipping the shadow elements, to save memory space.
553 The TRUE value for this param has to be used
554 with a FALSE value for the 'enable_sequence' param.
555 ('public elements' may be embedded in 'shadow Sequences')
556 * gdcmHeader methods now deal with 'embedded icones images' in the header
557 (even when an 'icone image sequence' is announced by the
558 element (0x0088,0x0200), but there is NO icone at all ...
560 * gdcmHeader sometimes Image Location value doesn't follow
561 the supposed processor endianity (see gdcmData/cr172241.dcm).
564 * gdcmHeader add the method
565 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
566 to get *all* the Header Entries with the same tag.
567 GetHeaderEntrySameName is probabely *useless*
568 (no meaning : Name is *not* an identifier within the Dictionnary)
570 2004-01-26 Benoit Regrain
571 * Bug fix in the print of hexadecimal representations. Remove long fields
572 in the print and add a third level of print to print them
574 2004-01-23 Benoit Regrain
575 * Bug fix on field having a VR = 'UI'. Assume that is a string field
576 * Bug fix on test suite after remove the strip made on not string fields
577 * Split the IsReadable method between gdcmParser which test that the file
578 is dicom and gdcmHeader which test that it's an image file
580 2004-01-22 Benoit Regrain
581 * DicomDir : clean code, add methods, set variables in protected or private
582 * gdcmUtil : bug fix for the clean string method
584 2004-01-19 Benoit Regrain
585 * Add the use of shadow dictionaries
586 * bug fix and coding style
588 2004-01-19 Benoit Regrain
589 * src/gdcmFile.cxx : bug fix concerning the close of file
590 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
591 * Add the update of header entries using the shadow library
593 2004-01-19 Benoit Regrain
594 * removal of file gdcmHeader2.cxx
595 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
596 inheriting from gdcmParser. This split is to prepare the integration
598 * bug fix under python
600 2004-01-16 Jean-Pierre Roux
601 * REM removal of class gdcmHeaderEntrySet
602 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
603 * ADD add file gdcmHeader2.cxx
604 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
606 2004-01-15 Benoit Regrain
607 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
608 entries created while parsing the header. Thus, they will be destroyed
609 when the gdcmDictSet will be destroyed
610 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
613 2004-01-15 Benoit Regrain
614 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
615 made a fatal error because of the memory release at the end of program.
616 The problem was in vtkGdcmReader::ExecuteData where we were allocate
617 some memory and vtk seems to have some problems with that.
618 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
620 2004-01-14 Benoit Regrain
621 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
622 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
623 * src/*.[h|cxx] : make changes due to class name changes
624 * gdcmPython/demo/*.py : bug fix due to method names
626 2004-01-13 Benoit Regrain
627 * src/*.[h|cxx] : coding style
628 * vtk/*.[h|cxx] : coding style
630 2004-01-13 Benoit Regrain
631 * gdcmPython/testSuite.py : test the readable flag of file for tests
632 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
633 It's lied to the stl compilation by MSVC (windows, always windows...)
634 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
636 2004-01-12 Benoit Regrain
637 * src/*.h : add comments
638 * src/gdcmDictSet.h : set the method BuildDictPath in public
639 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
640 directly setted in the source code
641 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
644 2004-01-09 Benoit Regrain
645 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
646 * setup.py : use a reference to gdcmVERSION
648 2004-01-07 Benoit Regrain
649 * Modification to compile with the distutils.
652 2003-12-10 Benoit Regrain
653 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
654 can use a gdcmHeaderHelper to load datas
655 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
656 made in the source code
658 2003-12-10 Benoit Regrain
659 * Update Windows projects and .cvsignore files
661 2003-11-12 Jean-Pierre Roux
662 * ENH gdcmHeader constructor has one more parameter (default value : false)
663 that allows the user to 'go inside' the SeQuences only
665 gdcmElValSet:Print takes it into account
667 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
668 * ENH: Update gdcmPython/CMakeLists
669 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
670 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
672 2003-11-10 Jean-Pierre Roux
673 * FIX : gdcmHeader::LoadElements is now based
674 on the ListTag listElem member,
675 not longer on the TagElValueHT tagHt member
676 * ENH : PrintPubElVal shows (temporarily) both results,
677 with the tagHt member and the listElem member.
678 (it's easier to 'see' the problems when using Printheader)
680 * FIX : old private member LgrElem is now splitted into
681 ReadLength : Length actually found on disk (updated only
682 if bug fixing is necessary), for internal
684 UsableLength : Updated by FixFoundLength, to fix a bug
685 or to allow Parser going on.
686 Will allow to re-write a kosher header when a SeQuence
687 with a length (not 0000) is found
688 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
689 because gdcmElValSet::Add does not update ListElem
692 2003-11-07 Jean-Pierre Roux
693 * FIX misstyping in Transfert Syntax name table
694 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
695 when they have an actual length (not 0000 nor FFFFF)
696 (Nobody should care of it, but DICOMDIR explorers)
698 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
699 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
701 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
702 * ENH: vtkGdcmReader now supports LUT !
703 (vtkgdcmViewer for now is not able to use them though)
705 2003-11-05 Jean-Pierre Roux
706 * in testSuite.py : new files names for checking the package
707 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
708 that returns the pixel area size to the *aware* (vtk) user
709 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
711 2003-11-05 Benoit Regrain
712 * in testSuite.py : Modify the rules for checking the paths
713 : Explicit error messages
714 * in __init__.py : Related modif
716 2003-11-03 Jean-Pierre Roux
717 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
718 to be used by aware (vtk) users that want to manage
719 LUT (and no to turn the PALETTE image into an RGB pixels one)
720 * GetPixelType now returns 8U for 24 Bits images
721 (vtkGdcmReader compliant)
723 2003-10-31 Jean-Pierre Roux
724 * Removal of *all* gdcmData images and add them again
725 in order to loose the 'history' of un-anonymised images
727 2003-10-31 Jean-Pierre Roux
728 * RMV : removal of useless jBitsInJsample.h
729 for both 8 and 12 Bits JPEG Lossy Libraries
731 2003-10-31 Jean-Pierre Roux
732 * ENH : Add the functions gdcmFile::GetImageDataRaw
733 gdcmFile::GetImageDataIntoVectorRaw
734 that act as GetImageData and GetImageDataIntoVector
735 except the making of an RGB Plane from Gray Plane + LUT
736 Intended to aware (vtk) users who know how to manage
739 GetLUTRGBA return a R,G,B,A LUT if any
740 lgrTotaleRaw gives the 'Raw' length
741 GetImageDataRaw returns the gray Plane
742 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
743 (They stay Grey, just like with other Dicom viewers :-(
745 2003-10-30 Jean-Pierre Roux
746 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
748 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
749 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
750 being coherents dicom files.
752 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
755 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
756 * ENH: Two steps is necessary to please VC++ compiler...
757 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
758 * ENH: Add include dir to medcon lib
759 * FIX: only one function is being exported for now !
760 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
762 2003-10-29 Jean-Pierre Roux
763 * adding gdcmHeader::GetLUTRGBA
764 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
765 --> Mathieu, the modif u're waiting for is not yet committed
766 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
768 2003-10-27 Jean-Pierre Roux
769 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
770 00191113.dcm DermaColorLossLess.dcm
771 MxTwinLossLess.dcm RadBWLossLess.dcm
772 * ENH: For version prior to vtkImageViewer2 -r 1.19
773 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
775 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
776 * Removal of ido stuff in CMakeLists.txt
778 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
779 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
780 * FIX: remove a call to ->Modified ... see comments
781 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
783 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
784 * FIX: Problem with path for libvtkgdcmPython
785 * ENH: Try adding a search script for python site-package
786 * RMV: Remove some file from medcon lib that are not necessary
787 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
788 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
789 * FIX: More pragma disable fro VC++,
790 I don't think I break something as it is also disable in VTK/ITK.
791 But it fasten debug compilation time.
793 2003-10-23 Jean-Pierre Roux
794 * gdcm now deals with 16 Bits Run Length Encoded images
795 (they are compressed as 2 planes images,
796 one for the high Bytes, the other for low Bytes)
798 2003-10-22 Jean-Pierre Roux
799 * Now CheckRead takes into account :
800 - the bugged 'Leonardo' Siemens images
801 - the XA images, sent thru the burning VPRO station
802 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
805 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
806 * FIX: When copying a Makefile.am to CMakeLists.txt
807 one should remove the '\'
809 2003-10-22 Jean-Pierre Roux
810 * in gdcmData adding a bugged 'Leonardo' Siemens image
811 (wrong lengths in header)
812 OK with gdcm, KO with the other viewers :-)
813 * add a GE dlx XA image, thru the VEPRO burning station
816 2003-10-21 Jean-Pierre Roux
817 * in gdcmData add the checkvtkgdcmViewer.sh shell script
818 for a brutal checking of vtkgdcmViewer compliance
820 2003-10-21 Jean-Pierre Roux
821 * add the files for 'xmedcon' Jpeg Lossless library
822 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
824 2003-10-21 Jean-Pierre Roux
825 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
827 2003-10-21 Jean-Pierre Roux
828 * garbage Siemens 'Leonardo' images dealt with
829 (the patch is easy to remove)
830 * cosmetic changes to avoid warnings
832 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
833 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
834 no need to press 'r' now.
836 2003-10-20 Jean-Pierre Roux
837 * upgrade of checkRead.sh checkWrite.sh according
838 to new Jpeg Lossless decompressor
839 * add US.3405.1.dcm, a genuine RGB medical file ...
840 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
841 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
843 2003-10-15 Jean-Pierre Roux
844 * general anonymisation in gdcmData
845 * adding the 'color files' from
846 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
847 * adding some well knowed bugged-header images
848 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
849 waiting for their inclusion in Python testsuite
851 2003-10-15 Jean-Pierre Roux
852 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
853 no longer seg faults when file is not found
855 2003-10-14 Jean-Pierre Roux
856 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
859 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
860 * TODO: *.in file to genereate a UseGDCM later
862 2003-10-14 Jean-Pierre Roux
863 * Some supposed-to-be Dicom Images have no preamble.
864 OpenFile takes it into account
865 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
866 * Missing elements added in dicomV3.dic
867 (just to be affraid : have a look at
868 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
869 and do it again next year ;->
871 2003-10-13 Jean-Pierre Roux
872 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
873 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
874 But there are NOT. It's fixed !
876 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
877 * FIX: "jpeglib.h" was not found on VC++
878 * FIX: vtkgdcm was not being installed
880 2003-10-10 Jean-Pierre Roux
881 * ENH : OpenFile closes the file if it *really* doesn't look like
882 an ACR-NEMA / DICOM one.
883 * FIX : testWrite no longer writes an empty file if the source file
885 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
888 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
889 * FIX: CMake generate now documentation
890 * ENH: out of source doc build !
891 * ENH: Generate both user and dev documentation
892 * ENH: Should work on windows too
893 * ENH: Only one doxygen config.in file is needed
894 * FIX: make install should be ok now on ùnix plateform
895 * FIX: PATH to dictionary was wrong (missing /)
896 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
898 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
899 * vtkGdcmReader is now able to read rgb dicom file.
900 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
901 * added a gdcmViewer to vtk test, use mouse to control
902 window level & window width
904 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
905 * CMake-ification of gdcm, we have now two build system
906 * FIX: on cygwin Wsock32 doesn't exist
907 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
909 2003-10-06 Emanuel Ollart
910 * FIX : compilation process wad broken.
911 Changed gdcmViewer_sources to vtkgdcmViewer_sources
913 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
914 * change gdcmViewer -> vtkgdcmViewer
915 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
917 2003-10-06 Jean-Pierre Roux
918 * FIX :A few nasty patches to allow the reading of a lot of nasty images
919 ( e.g : well known GE images with a wrong elem length,
920 : Philips MRI Images with a wrong Huffman table)
921 * still to be done : allow the reading of bugged LEONARDO Siemens images
923 2003-10-03 Jean-Pierre Roux
924 * Odd length strings are padded with '\0' (not with spaces,
925 to remain compliant with already defined strings,
926 like Transfert Syntax UID and others)
928 2003-10-03 Jean-Pierre Roux
929 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
930 to allow displaying RGB images (not only by affim ;-)
932 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
933 * vtkGdcmReader is now able to read rgb dicom file.
934 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
936 2003-10-03 Jean-Pierre Roux
937 * A few nasty patches to allow the reading of a lot of nasty images
938 ( e.g : well known GE images with a wrong elem length,
939 : Philips MRI Images with a wrong Huffman table)
940 * still to be done : allow the reading of bugged LEONARDO Siemens images
942 2003-10-03 Jean-Pierre Roux
943 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
945 2003-10-03 Jean-Pierre Roux
946 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
947 to allow displaying RGB images (not only by affim ;-)
949 2003-10-03 Jean-Pierre Roux
950 * gdcmFile::GetImageDataIntoVector now
951 - deals with MultiFrames MultiFragments Run Length Encoded files
952 - deals with YcBcR (YBR_FULL) files
953 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
954 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
958 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
959 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
960 Two reasons: - clear things
961 - third parties acces gdcm through header files, so won't
962 suffer anymore VC++ complains
964 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
965 * add argv[1] in testvtkGdcmReader.cxx
968 2003-09-24 Jean-Pierre Roux
969 * The lines are now eigthy characters long.for
970 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
972 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
973 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
974 char* to std::string. Thus, the use of strdup becomes useless. (see
975 previous commis of Malaterre)
976 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
977 before the last Malaterre's commit.
979 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
980 * This commit should fix the Debug building under VC++, the problem
981 was mainly a mixture of debug and release lib being loaded at startup.
982 * I also remove a depency to a specific C function: strdup. Because I had
983 to force the link to msvcrtd (whereas strdup is in libc).
985 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
986 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
987 located in the gdcmCommon.h file. All use of reference of tha has been
988 changed to now use the variable GDCM_UNFOUND.
990 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
992 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
993 Dicom dictionary. The test suite can now be run again. Note:
994 I'm note very happy with the " (RET)" changes. I believe this
995 RETAINED comment should be dropped when parsing the dictionary.
998 - AUTHORS updated and now in alphabetical order
999 * Makefile.am now exports gdcm.dsw for Windoze users.
1001 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1002 * cygwin complains about missing std:: in subdir Test/
1004 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1005 * remove some methods that are now in gdcmHeaderHelper
1007 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1008 * vtkGdcmReader set spacing and origin correctly
1010 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1011 * Fix a few delete/delete[] mismatch
1013 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1014 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1015 interpretation to data given by gdcmHeader. For instance there are
1016 heuristics to get informations (look at different places).
1017 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1018 sorting DICOM images based on different strategies.
1019 * modified Makefiles accordingly.
1021 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1023 when building in debug mode
1024 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1025 src/win32/gdcmdll.dsp
1026 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1028 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1029 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1032 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * src/win32/libgdcmjpeg12.dsp was not dos format
1034 * src/win32/libgdcmjpeg12.dsp :
1035 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1036 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1038 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1039 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1041 * src/gdcmFile.cxx : bug fix in affectation type
1042 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1043 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1044 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1045 symbols... future problem ?
1047 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1048 * src/win32/libgdcmijpeg12.dsp was missing
1049 * modified gdcm.dsw accordingly
1051 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1052 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1054 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1055 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1056 commit of JPR (before his hollidays to facilitate our work).
1057 * setup.py : bug fix in code. Modifications made while the last commit
1058 of JPR. The code hasn't been tested before the commit... it's so
1059 useless to make that (for best programmer that is JPR) !!!
1061 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1062 * tagged the current version as Version0_3 (i.e. version 0.3)
1064 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1065 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1066 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1067 * *.dsp : modifications to use new libgdcmijpeg8 library
1068 * setup.py : bug fix on VTKPATH variable
1069 * PACKAGER : adding all concerning windows
1071 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1072 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1074 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1075 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1076 test suite reported error.
1077 * PACKAGER file added (describes what a packager must do when
1078 packaging a new release).
1079 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1080 * configure.in: upgraded version number to 0.3.0
1081 * fixing build of rpm (through rpm -ta):
1082 - Doc/Makefile.am exports proper doxygen files
1083 - src/jpeg/libijg8/Makefile.am exports the include files.
1085 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1086 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1087 * src/gdcmHeader.h : formatting code
1089 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1090 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1091 We were obtaining error message from vtk. Now, creation of file list
1092 is made in an internal list to prevent this problem.
1093 Bug fix when output is empty.
1094 Bug fix in update of progress value. Previous commit for this was a bad
1096 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1098 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1099 * src/gdcmHeader.h : added method to get the file name
1100 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1101 files. Added method to remove all files on the input
1102 Added FIXME comment concerning the bad parsing of header made by
1103 ExecuteInformation method (in ExecuteData method)
1105 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1106 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1107 when using make instal.
1108 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1109 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1111 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1112 * setup.py : adding include dir of jpeg lib to compile all sources
1113 * */Win32/*.dsp : JPR fix for windows compilation
1115 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1116 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1118 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1119 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1121 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * setup.py is again effective on un*x (takes into account the
1123 addon of the jpeg library)
1124 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1125 * Doc/Doxy* updated (includes above enhancements)
1126 * INSTALL now points to web documentation
1128 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1129 * src/gdcmHeader.h doesn't make unnecessary reference to
1131 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1133 * src/gdcm*.[cxx|h] :
1134 - to allow compilation with gcc 3.x
1135 -- clean up of STL usage (added explicit usage of std::)
1136 -- small fixes on exceptions.
1137 Note: linking not tested !
1138 - clean of doxygen comments to avoid warnings at documentation
1140 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1141 dependent convertion).
1143 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * Clean up of previous JPR garbage commit (not even commented in the
1146 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1147 - moved all jpeg related files from src to src/jpeg/libijg8, with
1148 addition/modification of Makefile.am and configure.in.
1149 - the testSuite is still brain damage (not guilty).
1151 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1152 * WrapVTK.py : modifications to get correctly vtk source files to
1154 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1155 (FileName -> Filename)
1157 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1158 * vtk/vtkGdcmReader.[cxx/h]:
1159 - UpdateProgress method should now be effective
1160 - removed the limitation on having only images loaded (as opposed
1162 - when building a stack of images/volume, a lesser number of
1163 gdcmHeader and gdcmFile instances should be used (hopefully
1164 accelerating things).
1165 - when building a stack of images/volumes, files which are not
1166 loadable (wrong path-filename, wrong permissions on existing file,
1167 or file not parsable by gdcm) are replaced with a black image
1168 in the stack (for the caller to notice the problem).
1170 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1171 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1173 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1174 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1175 between standard library (std) and vtk library (problems are found
1176 under Windows... thanks Windows !)
1178 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1181 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1183 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1184 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1186 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * When compiling with distutils (see setup.py) the C++ compiler is
1188 called with different flags than the default ones (with automake).
1189 In order to fix all those warning, I compiled gdcm with the command
1190 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1191 and went for warning fixes:
1192 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1193 up from unused variables.
1194 - vtk/vtkGdcmReader.cxx: potential bug fix.
1195 * src/gdcmHeader.h: Doxygen warning cleanup
1197 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * gdcmPython/gdcm.i:
1199 - typemaps correction to take into account the systematic replacement
1200 of "using namespace std" with std:: prefix e.g. std::list,
1201 std::string... (cf changes of 2003-05-21).
1202 - gdcmGlob global variable of type gdcmGlobal (defined in
1203 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1204 exported to Python a as cvar.
1205 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1206 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1207 gdcmDictSet.GetPubDictTagNames() and
1208 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1209 C++ static methods).
1210 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1211 with the above changes.
1213 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1214 * setup.py, manifest.in : bug fix under linux
1216 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1217 * Modification of setup.py to compile vtk part too. Then, we have 2
1218 wrappers which must work with same distutils. For that, we have a
1219 generic distutils in distusiltsWrapping.py ; with :
1220 - build_extWrap class to wrap generically all extensions,
1221 - ExtensionWrap base class for all wrapping extension that contains
1223 - Wrapper interface which wrap sources
1224 + In WrapSwig.py we have extension and wrapper for Swig
1225 + In WrapVTK.py we have extension and wrapper for VTK
1226 * MANIFEST.in : modifications to consider vtk directory and new python
1227 files for compilation
1229 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1230 * Added python wrappers of vtkGdcmReader vtk class (see the
1231 source in vtk/vtkGdcmReader.cxx) :
1232 - vtk/Makefile.am now builds a library
1233 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1234 python library (as opposed to _gdcm.so wich are the python
1235 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1236 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1238 - configure.in has an additional flag --enable-vtk that needs
1239 to be set to enable compilation of vtk related code, that is:
1240 + vtk/vtkGdcmReader.so and
1241 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1242 + gdcmPython/vtkgdcmPython.so (see above)
1243 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1244 be read when compressed or when HighBit + 1 != BitsStored),
1245 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1246 the usage of the python wrapper of vtkGdcmReader vtk class.
1247 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1248 * src/*.[h] all occurences of stl classes are now prefixed with
1249 std::, and all occurences of "using namespace std;" where removed.
1250 This is to avoid pollution of global namespace in included files.
1251 Apparently vtk does not avoid this pitfall: when using both
1252 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1253 collision of various stl members (principally cout...).
1254 * gdcmPython/testSuite.py now cleanly removes temprory generated
1256 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1257 comply with above changes)
1259 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1260 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1261 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1262 vtk data structure (an image Flip was required).
1263 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1264 * cosmetic changes in documentation.
1266 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1267 * src/gdcmHeader.cxx: the constructor no longer exits when an
1268 unexisting file is given as argument.
1269 * The subdirectory Data (containing all the images used for the
1270 test suite) is not part of this repository anymore. A new module
1271 containing those images is now available at
1272 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1273 with the name gdcmData.
1274 All the python scripts (including the package initialisation file
1275 gdcmPython/__init__.py) were adapated to take this change into
1276 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1278 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1279 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1280 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1281 demo of the usage of this class.
1282 Compilation of this vtk part is only done when using the --enable-vtk
1283 at configure (or autogen.sh) stage.
1285 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1286 * More memory link related corrections and documentation fixes.
1288 - maximum info is obtained with a command of the form:
1289 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1290 --show-reachable=yes PrintHeader
1291 - the remaining reachable blocks seem to come from the STL
1292 allocation scheme through the usage of map and list. It looks
1293 like this memory cannot be freed but it is not a memory leak
1294 (in fact further invocation to the STL would recollect the
1295 unused memory allthough it cannot explicitely be freed).
1296 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1297 of displaying an image parsed with gdcm and displayed with VTK.
1298 Note: some images don't seem to work e.g.
1299 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1300 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1301 Allthough this weakens the semantics, it is a ditch attempt to
1302 make gdcm more thread friendly.
1304 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1305 * Memory link hunt (by using valgrind through the command
1306 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1307 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1308 gdcmHeader::_dicom_vr.
1309 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1310 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1312 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1314 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1315 * src/Makefile.am now exports all the necessary include files at
1319 * UpdateGroupLength replaced by new one
1322 * UpdateGroupLength re-written using H-Table
1323 (named UpdateGroupLengthNew untill checks are over)
1325 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1326 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1327 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1329 - gdcmHeader::GetPubElValSet removed.
1330 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1331 UpdateGroupLength, WriteElements, Write.
1332 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1333 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1334 carried the same semantics.
1335 - src/gdcmHeaderIdo.cxx changed accordingly.
1336 - gdcmFile::WriteBase now regroups all the codes from previous
1337 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1338 - enum FileType moved to gdcmCommon.h
1339 * src/gdcmHeader.cxx AddDefault trashed
1340 * gdcmGetXSize added
1341 * getimageDataSize now calls gdcmGetXSize
1342 * Test/*.cxx changed to agree with above changes
1344 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1345 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1346 (to avoid double call by end user).
1347 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1348 by end user, since gdcmHeader::gdcmHeader now handles it.
1350 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1351 * gdcm/Doc many doxygen changes:
1352 - Doxyfile now has two different versions, DoxyfileUsers that generates
1353 the html.users end users oriented documentation and
1354 DoxyfileDeveloppers that generates the html.developper developper
1355 oriented documentation.
1356 - README changed accordingly
1357 - requirement.txt removed (old design info moved to TODO).
1358 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1359 DoxyMainPage.txt, DoxyPython.txt provide more information.
1360 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1361 be updated by simply regenerating the docs with doxygen and copying
1362 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1363 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1364 all the tests in the form "if (<map>.count() >1)" were removed.
1365 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1366 ill-formed documentation sections.
1367 * src/gdcmHeader.cxx: ditto
1369 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1370 * setup.py fixed for un*x (needed macro for stdint.h)
1371 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1372 un*ces with sh-utils test utility.
1373 * gdcmPython/demo/test.py renamed to PrintHeader.py
1374 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1375 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1376 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1377 * src/gdcm*.cxx JPR's bad inclusion fixed.
1379 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1380 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1381 * gdcmPython/demo/test.py changed accordingly.
1383 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1384 * gdcmPython/Makefile.am fixed linking against libstdc++
1385 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1386 * Swig subdir (historical tests of swig version 1.3.17++) removed
1387 * Test/testChangeEntete.cxx some lines commented out in order to make
1389 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1390 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1392 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1394 hence the user doesn't need this explicit call.
1395 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1396 i.e. LoadElements() call removed.
1397 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1398 - src/Makefile.am declares the proper flag for g++.
1399 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1400 for adding user defined new tags.
1401 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1402 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1403 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1405 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1406 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1407 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1408 src/Makefile.am : the project should properly compile and install
1409 with the autotools, included the python wrappers part.
1410 * gdcm.spec.in : added a spec file for RPM packaging.
1412 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1413 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1415 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1416 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1417 to exported to the environement (see gdcmPython/testSuite.py
1419 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1420 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1421 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1422 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1423 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1425 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1426 * gdcmPython/__init__.py doesn't crash anymore when running in
1427 in InstallMode or PreInstallMode but with an environement given
1428 value of GDCM_DICT_PATH.
1429 * src/gdcmDictSet.[cxx/h] coding style.
1431 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1432 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1433 * src/gdcm.h general comments moved to TODO, and README
1434 * src/gdcm.h should now be seen as a user commodity (including it
1435 should suffice to fully use gdcm). It is nowhere including within
1436 any of the kernel files src/*.cxx and src/*.h.
1438 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1439 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1440 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1442 * src/gdcm*.cxx only include their corresponding include file
1443 (as opposed to gdcm.h)
1444 * gdcmPython/gdcm.i changed accordingly
1445 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1446 the autogen.sh generated "make snapshot" command to work.
1447 * autogen.sh removed history related references to crea package.
1449 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * distutilsSwigCPlusPlus.py work around some swig portability
1453 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1454 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1455 was done in a last ditch attempt to get setup.py _really_
1456 operationnal. The python/gdcmPython layaout add the advantage
1457 of hidding away the python related distutils specific files
1458 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1459 Alas, the src directory was out of scope (i.e. it's relative
1460 position to setup.py was ../src) which made things impossible to
1461 handle (see previous version of python/setup.py). Crossing fingers...
1463 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1464 * python/setup.py now works on Un*x. (harder than I thougth)
1465 * python/distutilsSwigCPlusPlus.py can now have include files
1466 among the list of sources.
1468 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1469 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1470 * modifications in MSVC projects
1472 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1473 * As stated by the first lines of Test/ExceptionAndPython/README, it
1474 looks like we can move back to original usage of exception within
1475 src/gdcm* and hence remove the errno stuff that was introduced
1476 as a quick and dirty fixture of this problem (added to the TODO).
1477 * Doc/Doxyfile configuration file for Doxygen and corresponding
1478 README file for usage added.
1479 * Test/testWrite.cxx added. This new test comes from a split of
1480 test.cxx that is now reverted to its original purpous i.e.
1481 testing the proper parsing of a Dicom related file.
1482 testWrite.cxx concentrates on testing the IO part of gdcm.
1483 * Test/bug1.cxx (containing a bug on WIn32) added.
1484 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1485 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1486 whose purpose is to publish the content of the TagNames of the
1487 Dicom public dictionnary were not accessible without an
1488 instance of class gdcmHeader.
1489 - those methods are now static methods of gdcmDictSet and hence
1490 require no instances at all to be invocated.
1491 - within gdcmDictSet this change required to change some method
1492 to class methods (i.e. are now static) among which SetDictPath
1493 (renamed to BuildDictPath) and LoadDefaultPubDict.
1494 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1495 the above changes by calling the new method classes of gdcmDictSet.
1496 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1497 the above to be effective.
1498 * python/gdcmPython: in order to wrap properly the above changes
1499 for Python, swig version now needs to be > 1.3.17.
1500 * python/gdcmPython/Makefile fixed to adapt itself to new
1501 configure/make shema introduced by Johan Montagnat (thanks for the
1502 contribution). Alas this Makefile cannot be turned into a proper
1503 Makefile.am without some heavy changes in the configure.in
1504 (for python dectection).
1505 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1506 now avoids publishing the empty entries.
1508 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1509 * python/setup.py : bug fix concerning install under windows
1510 ExtraPath reused :-P
1511 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1513 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1514 * Dicts/dicomV3.dic : remove double spaces !!!
1515 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1516 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1519 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1521 method. Doxygenation.
1522 * src/gdcm.h clean up of JPR spurious comments.
1524 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1525 * python/distutilsSwigCPlusPlus.py now properly collects the
1526 shadow classes generated by "swig -c++" (gdcm.py in our case)
1527 when using "python setup.py install".
1528 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1529 reexports the working classes.
1530 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1531 by the classical C errno scheme. This is to prevent an obscure
1532 behavior of the python wrappers when importing wxPython.wx prior
1533 to gdcmPython (which ended up in an abort call). An illustration
1534 of this oddity can be found in the Test/ExceptionAndPython
1535 subdir (see the README file). This problem probably due to
1536 an combination of g++ and dynamic loading.
1537 * added Test/ExceptionAndPython (see above)
1539 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * Changed the layout of the python part to avoid bloating main
1541 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1542 i.e. the distutils arsenal. All the python related stuff is
1543 again in a python subdir, but the package itself is now in
1545 * setup.py was cleaned up:
1546 - pythonIncludePath removed
1547 - python setup.py bdist target is now functional.
1548 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1549 collision with other packages). gdcmPython/demo/*.py changed
1552 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1553 * python subdir moved to gdcmPython (preparation of distutils packaging).
1554 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1555 distutils installer is operational.
1556 * - gdcmPython/__init__.py now properly loads the swig generated
1557 shadow classes (from gdcm.py).
1558 - gdcmPython/demo/*.py changed to import the package gdcmPython
1559 instead of gdcmPython/demo/load.py.
1560 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1562 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1563 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1564 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1565 entries within the associated public Dicom dictionary resp. the same
1566 information but sorted by the fourth field (PAT, IMG, DIR) of the
1568 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1569 are now in the "???" group.
1570 - python/gdcm.i changed accordingly,
1571 - python/demo/printGroupedPublicDict.py added, that gives an example
1572 of the above new functionalities in Python.
1574 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1575 * src/gdcm.h, gdcmHeader.cxx:
1576 - historic references to glib's g_malloc and g_free (#defined)
1577 were definitively removed.
1578 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1579 * src/gdcmElValSet.cxx:
1580 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1581 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1582 - GetElValue(string) renamed to GetElValueByName.
1583 - Added GetElementByName(string).
1584 * src/gdcmHeader.cxx: added
1585 - GetPubElValRepByNumber(guint16, guint16)
1586 - GetPubElValRepByName(string)
1587 - GetShaElValRepByNumber(guint16, guint16)
1588 - GetShaElValRepByName(string)
1589 - GetShaElValByNumber(guint16, guint16)
1590 - GetShaElValRepByName(string)
1591 - GetElValRepByNumber(guint16, guint16)
1592 - GetElValRepByName(string)
1593 - GetElValByNumber(guint16, guint16)
1594 - GetElValRepByName(string)
1595 * Doc/requirements.txt added.
1597 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1598 * Test/Makefile building now depends on the one of libgdcm.so
1599 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1600 pixel data) aware which enables finding the address (offset) of
1601 the pixel data of JPEG encoded DICOM files. This leaves only a single
1602 file in the testSuite whose pixel data address (offset) is unknown.
1603 * python/testSuite.py changed accordingly.
1605 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1606 * VC++ has some strong limitations when working with the STL, as stated
1607 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1608 "Also note that some STL containers (map, set, queue, list, deque)
1609 cannot be exported. [...]
1610 Some STL classes contain nested classes. These classes can not
1612 This is caused by a designed limitation that once a template
1613 class is instantiated, it can not be re-instantiated and
1615 Since our usage of map<> is ubiquitous in gdcm, this "designed
1616 limitation" of VC++ is a pitfall.
1617 Hence the Python wrappers of gdcm cannot be incrementally linked
1618 against the c++ dynamic library. The dirty but only workaround is
1619 to forget about incremental link of dynamic libraries and to generate
1620 the Python wrappers library with the inclusions of the underlying C++
1622 The following modifications concern this matter on Win32/VC++:
1623 - wrapping python correct with standalone wrapped dll (don't use separate
1624 dll under windows !!!!)
1625 - python21_d debug mode enabled (ask Frog how to use it :-)
1626 - NO problem with having an STL member of class for example string in C++
1627 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1628 - Python test of dcmlib in Python is ok under windows on a large set
1630 * removed glib references
1631 * typedef's inserted in gdcm.i for correct swig type management
1633 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1634 * python/demo/*.py load.py extracted from test.py. Added explore.py
1635 that only displays required tags and testAll.py that parses all
1636 the files of the testsuite without using unittest.
1637 * python/testSuite.py other additional test on new files added.
1638 * Data/* new test files added accordingly to the testSuite.
1639 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1640 the vr in the file differs from the one of the dictionary.
1642 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1643 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1644 values, but limits itself to values which are below a user specified
1645 size (by default 1024 bytes).
1646 * python/gdcm.i : elements not loaded (because their size is above the
1647 user specified treshold) are exported with their TagKey as key of the
1648 python dictionary. This enables the testsuite to make some checks
1649 on the unloaded elements (since we have their offset and size).
1650 * python/testSuite.py
1651 - now tests for the existence and proper value of the pixel data
1652 - two new examples added.
1653 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1655 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1656 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1657 aware. See the strategy comments in gdcmHeader::FindeLength().
1658 * Test/test.cxx now accepts a filename as first argument.
1659 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1660 * python/testSuite.py changed to integrate test on above files.
1662 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1663 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1664 the vr was also RET.
1665 * python/testSuite.py more tests added.
1667 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1668 * python/testSuite.py unittest test suite added (uses Data)
1669 * Data/* dcm and acr files for the test suite.
1670 * glib dependance removed from un*x version. We now use ISO C99
1671 7.18 Integer types (see stdint.h)
1672 - python/Makefile, src/Makefile src/gdcm.h
1673 * src/ when an explicit vr (like dicom files) suddenly poped an
1674 implicit element we use to mark the underlying DictEntry of the
1675 concerned ElValue with "Implicit". This strategy was damageable
1676 too the public or provite dictionaries, since some of their vr
1677 would be changed. Since Header::FindLength heavily relies on the
1678 detection by Header::FindVR of falsely explicit elements, I
1679 added an extra ImplicitVr member to ElValue (boolean).
1680 The rest of the changes we the necessary adaptations.
1682 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1683 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1685 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1687 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1688 * Adaptation for porting to VC++:
1690 o forced to use std namespace (for string to be known)
1691 o all class use __declspec export style on WIN32
1692 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1693 (in stdlib.h on Win32 but in std:: for gcc)
1694 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1695 variable GDCM_DICT_PATH.
1696 * src/gdcmHeader.cxx verbose comments made discrete.
1698 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * python/gdcm.i: added a typemap that converts a C++ hashing table
1700 to native Python dictionary.
1701 * python/demo/test.py:
1702 - now uses the native dictionary for exploration of gdcmHeader.
1703 - takes an optional filename argument (the file to parse).
1704 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1705 PubElVals hashing table.
1706 * Dicts/dicomV3.dic removed error prone trailing spaces.
1708 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1709 * Python wrapping process moved away from src/Makefile to
1710 newly created python/Makefile (as well as gdcm.i)
1711 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1712 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1713 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1714 from the environement variable GDCM_DICT_PATH (when existing).
1715 * src/gdcmDict::GetTag bug fix.
1717 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1718 * Straightforward temporary fixes for swig to build the python wrappers.
1719 src/Makefile now has a python working entry [by working we mean
1720 that we can import de shadow classes without errors].
1722 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1723 * hashtest.cxx removed (since allready in Test)
1724 * src/gdcmlib.h renamed to src/gdcm.h
1725 * src/dcm.i renamed to src/gdcm.i
1726 * src/Makefile prepared for python wrapping
1728 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * src/gdcmHeader.cxx :
1730 - Parsing of header is now separated from loading of element values
1731 (see gdcmHeader::LoadElements).
1732 - general clean up of hopefully all file access (creation of
1733 ReadInt16 and ReadInt32)
1735 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1736 * src/gdcmHeader.cxx :
1737 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1739 - SetLgrElem renamed to SetLength
1740 - GetLgrElem renamed to GetLength
1741 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1742 * src/gdcmElValSet.cxx fixed both GetElValue methods
1743 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1744 due to IdoDude was cleaned out.
1746 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1748 concentrates on finding the value representation (when it exists).
1749 RecupLgr now only finds the element value length, and it avoids
1750 returning the unecessary skL (skipped length).
1751 Also, offsetCourant was simply removed (with taille_fich) since
1752 it was redundant with the File position internals (by using
1753 ftell and fseek). This also made skL (see above in RecupLgr) usage
1755 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1756 on the libido specificities which are handled through class
1758 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1761 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1762 * Truckload of changes. Parsing of header is barely functional
1763 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1765 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1766 * src/gdcmHeader.cxx many addons of low level methods
1768 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1769 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1770 and _IdDcmSWAP_LONG.
1772 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1773 * This corresponds to all the changes decided at the meeting of
1774 May 23 2002. Needless to say we are running late...