1 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
4 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
5 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
6 The string leaves only in the fonction. So when we make a .c_str(), we
7 get the pointeur on the first element, element that will be destroyed
8 immediately after thee instruction.
9 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
10 file has been opened : the test must be made on the content of the
11 pointer and not directly on the pointer !
14 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
16 the python part recompiles
18 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
20 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
21 X session is killed (for my computer... it seems to not be identic on
24 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
26 avoid problems (otherwise, the difference test between the visible image
27 and the reference is incorrect. If the reference is greater than the
28 screen resolution, it's produce errors).
29 Can be used for only one image. Can be used with a visible flag.
30 * vtk/vtkGdcmReader.cxx : remove commented codes.
31 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
32 under windows at compilation
33 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
35 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
37 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
38 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
39 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
40 tests on the image size X, Y, Z
42 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
44 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
45 between the class name and the file name
47 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/ : fix compilation warnings for the Write method (2 different
49 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
50 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
51 variable... create a static method in gdcm::Document to access to
52 this variable content.
54 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
55 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
56 file, to be accessed by other files (like gdcmFile). Remove commented
57 code. Move the change of the header to the gdcmFile, using the
59 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
60 To be sure of that (and simplify calls), the Write of the header now
61 gets a file name and not a file pointer (std::ifstream).
62 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
63 DocEntryArchive. Remove all open of the written file
65 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
68 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
70 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
72 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
73 some corresponding methods. Write correctly the file and check before
75 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
76 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
77 is now on RGB datas (as before my last commit
78 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
80 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
82 Add a print information of the type of the entry
83 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
84 It was in the gdcmFile, and all write have been regrouped
85 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
86 Write correctly all dicom files (in decompressed mode only at this time)
87 * Test/ : test on files are now made using Raw datas and not color datas if
89 * Example/PrintFile.cxx : add more printings
91 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * Amelioration of code, remove some code copy. For the loading of
93 BinEntry (in gdcmDocument), add the test to verify if the file is already
96 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
98 remove a DocEntry in the header (push an empty DocEntry)
99 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
100 lines. Bug fix in the initialization of the PixelConvert and the
102 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
103 use in TestCopyDicom (now this test can run under windows... but fails)
104 * Test/TestCopyDicom.cxx : amelioration of the test :
105 - test the pixels written
106 - add test points to quickly find where is the error
107 - can set a file name input and output in arguments
108 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
109 amelioration of the test output
111 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
113 all replaced DocEntry's
114 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
115 Now, each needed DocEntry to modify is duplicated, modified and inserted
116 to the header using DocEntryArchive. Thus, after save, we can restore the
117 header initial state.
119 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
122 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
124 correct to copy it. The DictEntry is specified at the DocEntry creation,
125 then, it musn't change in the time.
126 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
127 header correctly. At this time, the change is only made for the first
128 level of the Document. In the future, it might consider sequences.
129 The change is made by replacing a DocEntry by an other that is created
130 outside the class. The old value is kept. When we restore the header
131 status, the added DocEntry is deleted and replaced by the old value.
132 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
133 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
134 set the write type to explicit VR, implicit VR or ACR. Add methods to set
135 the write mode to native, decompressed or RGB (but not used at this time)
137 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
138 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
139 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
141 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
143 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
145 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
146 set because already copied when copying the BinEntry's of the header
147 * Test/TestAllReadCompareDicom.cxx : remove warnings
149 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
151 Two problems appear when doing it :
152 - with the gdcmFile : when the GetImageData method is called, the pixels
153 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
154 datas (pixels). And each structure destruct the datas when it's
155 destructed. So we have two destructions for the same datas. To solve it,
156 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
157 datas or not. If it doesn't own datas, then they will not destroyed by
159 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
160 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
161 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
162 create a double destruction of the same DocEntry's. So, to solve it,
163 the TagHT is simply cleared and the DicomDir* elements are destroyed.
164 * TODO : add an entry concerning memory leaks in the DicomDir
166 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
168 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
171 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
173 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
174 after it have been deleted
176 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
177 * FIX: src/* fix the doxygen warnings.
178 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
179 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
180 was erroneously defined with a size of 15 instead of 16. [many thanks
181 to Jean Michel Rouet for pointing out this bug].
183 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
184 1. Finish merging JMR patch for writting DICOM from scratch
185 2. Fix -hopefully- bug with MONOCHROME and space vs null character
186 3. Use const ref when possible
187 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
188 5. A few more comments
189 6. CreateUniqueUID can now be called without parameter"
191 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 * ENH: Slightly bigger patch:
193 1. Getting toward full integration of JMR patch for writting dicom from scratch
194 2. Update Test to test part of this patch: CreateUniqueUID
195 3. File was not close properly in gdcmDict
196 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
197 5. Use of const ref instead of copy (speed issue)
198 6. Remove temporary (duplicate) string in TranslateToKey
199 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
200 8. Do not repeat virtual in subclasses
201 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
203 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
204 * Apply first patch toward better string comparison when dealing with broken
205 DICOM files. Essentially the string could be padded with a space instead
206 of a null character as defined by standard
208 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
209 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
210 because never used... and in the same time, that's remove some memory leaks
212 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmFile.cxx : now delete the PixelConvert instance.
214 * In examples and tests : change the type of image data variables from void*
215 to uint8_t*. Remmove all delete on image data variables
217 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
219 Verify the file pointer value before open the file, and if it's not null,
220 a verbose message is generated.
221 Close correctly the file when the file isn't considered dicom-like. The
222 correctly close is a call to CloseFile.
223 When closing the file pointer, test if its not null to close the file.
224 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
225 file. For an uncompressed image, the copied datas correspond in the least
226 case to the image size (calculated) or the image size specified in the
227 header. A verbose is generated if these two size mismatch
229 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
231 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
232 break under windows (with msvc6 compilation).
234 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
235 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
236 compiling with MSVC6)
238 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * Bugs fix for the Windows build with VC6
240 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
241 needed (only for projects required VTK). If the VTK is included in all
242 projects, there is conflicts with the jpeg lib of vtk when compiling the
243 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
244 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
245 when compiling the gdcm_wrap.cxx file (created by the compilation of the
247 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
248 (like it's already made for the cout use). Otherwise, conflict with the
251 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
252 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
254 - comments on the DicomDir::Method related usage added.
255 - now that we use the namespace gdcm, a lot of internal classes do
256 NOT need to be wrapped anymore.
257 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
258 DicomDir::Method) new example added.
260 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
261 * Improve string manipulation. I now inforce the notion of 'DicomString'
262 A DicomString can contain as many \0 as they want
263 and it is *always* of even length.
264 We only support odd length for very rare case.
265 And in the near future this should be removed.
267 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
268 * /binary_write/ gdcm source. Now even on big endian we are writting
269 little endian. This should -heopfully- fix some tests
271 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
272 * Now the dictionary is compiled into gdcm lib. This is a default
273 behavior, thus any dic file specified is picked before failback to
274 the one comiled into lib
276 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * Change internals for gdcmDict. Don't use any 'new' any more.
278 This should definitely solve any leak problem, and we should be
279 as fast as before, as long as don't modify too much the dictionary.
281 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 * STYLE: ivars should start with a capital letter.
283 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
284 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
286 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
287 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
288 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
289 new 2004 dictionaries added (thanks to JPR).
290 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
291 * CLEANUP_ROUND (15) for gdcmPixelConvert
292 - RLEFrame::NumberFragments is now of type unsigned int
293 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
294 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
297 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
298 * Initial work in gathering all transfer syntax accessors. clearly
299 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
300 ivars, but only one transfersyntax (class) ivar with equivalent method on
303 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
304 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
305 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
306 discussed (plus I didn't like having a 2000 lines patch not commited)
308 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
309 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
310 * CLEANUP_ROUND (14) for gdcmPixelConvert
311 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
312 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
313 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
315 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
316 anymore and hence avoids storing a copy of PixelConvert::Decompressed
317 into File::Pixel_Data.
319 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
321 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
322 * CLEANUP_ROUND (13) for gdcmPixelConvert
323 Substituted File::ParsePixelData() with PixelConvert::Print() new
325 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
326 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
327 method to those classes.
328 - src/gdcmFile.[cxx|h]:
329 -- Added a ::Print() method.
330 -- PixelConverter is now a reference instead of a member.
331 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
332 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
334 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
335 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
336 collaboration diagram and inheritance diagram should be generated with
338 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
339 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
340 pointlessly wrapped (see
341 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
342 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
343 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
344 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
345 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
346 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
347 -- File::Initialise: PixelConverter setup moved away to
348 PixelConverter::GrabInformationsFromHeader()
349 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
350 interpretation moved away to PixelConverter::BuildRGBImage()
352 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
354 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
356 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
357 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
358 displayed on Win32 when a brutal abort() occurs (because of uncatched
359 exception). See TODO new entry of this commit for more on this.
360 * TODO added new entry.
361 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
362 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
363 - HandleColor is no longer called from gdcmFile.cxx
364 - gdcmPixelConvert.cxx clean up on method arguments and internal
365 variable names for semantical coherence.
367 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
368 * Finished lossless transition, not only do we now read all lossless jpeg
369 images, without the need of the Cornwell lib, but we do read them properly now
370 * To reduce code (well to avoid code duplication), I defined a common place
371 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
372 redefine symbols. This is not prefect but this the best solution I found for a
373 compilation time jpeg option.
375 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * Update jpeg ijg lib to support lossless jpeg implementation
377 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
379 * Also added a special copyright for dcmtk since we use their bugfixes.
382 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
383 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
384 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
385 matters, as stated in warning note at begining of %include section).
386 * src/gdcmDicomDir*.[cxx|h]: coding style
387 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
388 * src/gdcmJpeg8.cxx: doxygen fix.
389 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
390 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
391 from File:: to PixelConvert::.
393 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
394 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
395 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
396 - more code moved away from File:: to PixelConvert::
397 - fat setup of PixelConverter set in place in File::Initialise.
399 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
400 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
401 namespace at the file system level. So now you should convert your examples
403 gdcmHeader -> gdcm::Header
404 It would be nice if people keep in mind to no open the namespace, since it
405 allows compilation on broken plateform which were defining common symbol in
406 the standart namespace (like LP, Unknown ...)
408 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
409 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
410 The JPEG fragments are now parsed at the same stage than the RLE
411 information. All code related to JPEG is now in gdcmPixelConvert:
412 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
413 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
414 export a gdcmFile:: method. Those are simply global functions
415 (for the time being this is better than having them attach to
416 either gdcmFile:: or gdcmPixelConvert::).
417 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
418 and stores the result in a gdcmJPEGFragmentsInfo.
419 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
420 code (among other stuff) moved away from gdcmFile:; to
423 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
424 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
425 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
426 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
427 clean up of RLE related code.
428 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
429 - src/gdcmRLE.cxx removed
430 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
431 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
432 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
433 * CLEANUP_ROUND (9) for gdcmPixelConvert
434 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
435 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
436 away from gdcmFile:: to gdcmPixelConvert::.
438 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
439 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
440 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
441 This is because Parse7Fe0 used to parse the pixels to compute the
442 length. This task was passed over to FindDocEntryLengthOB() a long
443 time ago, EXCEPT I had forgotten the OW case...
444 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
445 we just recylce the code for parsing RLE fragments and computing
447 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
448 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
449 with the retired Parse7Fe0().
450 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
451 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
453 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
454 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
455 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
456 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
457 - src/CMakeLists.txt: alphabetic order reodering + new entries.
458 * CLEANUP_ROUND (4) for gdcmPixelConvert
459 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
460 to return an unused length.
462 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
463 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
464 this should be cleanner from the plane view. The iostream are erally a pain
465 to use to do simple stuff.
467 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Redo the compilation of the ijg jpeg library. Now only one source is
469 necesseray. No need to rename file by hand what so ever. CMake handle the
470 copying of the file within different directory, configure header file to
471 modify some symbol. The only addition made to ijg wasd a mangle table so
472 that symbol are different wether we are within 8bits or 12bits.
474 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * Added documentation of vtkgdcmReader on Website:
476 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
477 with it's binary name).
478 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
479 the Website to be more complete.
480 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
481 doxygenated documentation.
482 - Doc/DoxyVtkGdcmReaderExamples.txt added
483 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
484 DoxyVtkGdmReaderExamples.html )
485 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
486 * CLEANUP_ROUND (3) for gdcmPixelConvert
487 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
489 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * CLEANUP_ROUND (2) for gdcmPixelConvert
491 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
493 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * CLEANUP_ROUND for gdcmPixelConvert:
495 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
496 - src/gdcmPixelStuff[h|cxx] removed
497 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
498 - src/CMakeLists.txt changed accordingly
500 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
501 gdcmVersion.py moved to newly created ATTIC related
502 gdcmPython/SetupOldies/ directory.
503 * Autotools clean up:
504 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
505 - autogen.sh configure.in acinclude.m4 python.m4 removed
507 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * src/*.cxx *.h Reference to License.htm fixed to License.html.
509 * Doc/CMakeLists.txt, doxygen.config.in: fix.
510 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
512 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * TODO updated with Mathieu suggestions. I proposed a template for
514 describing TODO entries and used it for new entries.
515 * Added Doc/Website/CodingStyle.html, Developpers.html,
516 DeveloppersPython.html, GdcmDataCvs.html and
517 DownloadVersion0_1.html, DownloadVersion0_3.html.
518 * Some Doc/*.txt Doxygen files (which do not really concern the
519 documentation itself, but the website) moved to html and
520 placed in directory Doc/Website:
521 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
522 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
523 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
524 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
525 * CMakeLists.txt changed accordingly.
526 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
527 DeveloppersPython.html
528 * INSTALL nows refers to Doc/Website/Installation.html
530 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * Added Doc/Website directory, that contains a first raw version
534 2004-09-23 Jean-Pierre Roux
535 * FIX In order not to be poluted any longer by casting problems,
536 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
537 we can now delete[] it safely
538 * VoidArea is now called BinArea (less confusing name),
539 and all the methods called ...VoidArea... are now ... BinArea...
540 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
542 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
544 clear) TagHT, which is an inherited member of gdcmElementSet. It is
545 up to the destructor of gdcmElementSet to clean up TagHt and it's
548 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
549 * Test/CMakeLists.txt: update to follow gdcmData renamings.
550 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
552 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
553 * ENH: added some utility method that builds a flat dictionnary
554 holding all the Dicom entries contained in the recursive structure
555 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
557 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
558 BuildFlatHashTable() that build a flat dictionary.
559 - src/gdcmElementSet.h: added a new private GetTag() accessor.
560 gdcmDocument is now a friend of gdcmElementSet.
561 - src/gdcmElementSet.cxx: clean up.
562 - Example/FlatHashTablePrint.cxx added.
563 - Example/CmakeLists.txt changed accordingly
565 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
566 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
567 moved away from gdcmDocEntrySet (since this class is an abstract class
568 acting like an interface). SQDepthLevel and BaseTagKey are now
570 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
571 and associated accessors. Doxygenation of the class.
572 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
574 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
575 Use SQDepthLevel accessor instead. ::Print() adapted.
576 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
577 - src/gdcmDocument.cxx changed accordingly.
579 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
581 - The following is the doxygen comment of the typedef declaration
582 of gdcmagKey in src/gdcmCommon.h:
583 gdcmTagKey is made to old an "universal" (as in URL, Universal
584 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
585 A dicom tag allways has a group and an element, but a set of tags
586 embeded in various (optionally nested) sequences and sharing
587 the same group and element all share the same (group, element)
588 "identifier". Hence the (group, element) cannot be used as an
589 identifier (in gdcm we shall refer to a "TagKey") of a tag.
590 In order to construct a proper tag identifier (i.e. a key) we
591 consider the following definition of a TagKey:
592 - let Group, Element be the string representation of the
593 group and element dicom tag members,
594 - let ItemNumber be the string representation of the integer
595 index of the considered item number of a sequence,
596 Let the key of a tag embeded in a sequence, noted SeqTag, be
598 /ItemNumber#Group|Element
599 where "/", "#" and "|" are characters acting as separators.
600 Then the general form of a gdcmTagKey is given by:
601 Group|Element<SeqTag>
602 where <SeqTag> means NO or many instances of SeqTag.
603 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
606 but the gdcmTagKey of a tag "embeded" is the first item of
607 a sequence, itself nested in the third item of a sequence is the
609 0004|1220/2#0008|0082/0#0008|0090
610 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
611 order to hold the new sequence compatible key. Previously, the
612 GetKey() method would look in the underlying gdcmDictEntry.
613 - src/gdcmDocEntry.cxx:
614 -- constructor now copies the underlying DictEntry key, in the local
616 -- ::Print: displays the member Key, instead of the (group, element).
617 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
618 - src/gdcmDocEntrySet.h:xi
619 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
620 -- now has a new BaseTagKey member.
622 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
623 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
625 This poses the problem with the semantics of the following lines
626 LoadEntryVoidArea(0x0028,0x1201); // R LUT
627 LoadEntryVoidArea(0x0028,0x1202); // G LUT
628 LoadEntryVoidArea(0x0028,0x1203); // B LUT
629 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
630 to the long FIXME note for what the problem is. Nevertheless in
631 order to get things working the dicom dictionary was altered !
632 Please fix things urgently...
633 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
634 information), see above note on moving the member VoidArea. Nevertheless
635 the following entries previously correctly set as US are now inproperly
637 0028 1201 OW IMG Red Palette Color Lookup Table Data
638 0028 1202 OW IMG Green Palette Color Lookup Table Data
639 0028 1203 OW IMG Blue Palette Color Lookup Table Data
640 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
641 of gdcmDocEntry moved to gdcmSeqEntry.
642 * src/gdcmSeqEntry.cxx: STYLE.
644 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * Test/TestAllEntryVerify.cxx minor fix and added comments.
647 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * gdcmPython/testSuite.py: all the test suite in python is now moved
649 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
650 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
651 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
653 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
655 to avoid inclusion recursion until STL is reached.
656 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
657 mecanism. errno.h is not included in gdcm anymore.
658 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
659 (gdcmFormatError now inherits from gdcmFormatUnexpected).
661 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
662 gdcmData/TestAllEntryVerifyReference.txt
663 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
664 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
665 exception_on_error parameter.
666 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
667 - vtk/vtkGdcmReader.cxx changed accordingly,
668 - Example/*.cxx and Test/*.cxx changed accordingly.
670 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
671 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
672 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
673 enable_sequences removed from gdcmHeader constructor and dependencies.
674 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
675 * gdcmPython/demo/PrintHeader.py: dummy fix.
676 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
677 skip_shadow removed from gdcmHeader constructor and dependencies.
678 * Example/*.cxx and Test/*.cxx changed accordingly.
680 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
682 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
684 2004-07-21 Jean-Pierre Roux
685 * FIX Now, Parsing and Printing a DICOMDIR do work!
686 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
688 2004-07-20 Jean-Pierre Roux
689 * FIX Some brain damaged headers have Zero-Lenght fields
690 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
692 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
693 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
694 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
695 variable (instance of gdcmDebug) by a definition macro, and the instance
696 is now in static in the gdcmDebug class
697 * src/gdcmSQItem.h : (FIXME) remove an undefined method
698 * Test/PrintAllDocument.cxx : bug fix in the result of the test
700 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
701 * WARNING: ctest now depends more tightly on gdcmData. You should
702 check out gdcmData properly for things to run smoothly...
703 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
704 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
705 we need the pixels not be loaded in order to use the ValEntry
706 that displays position and size).
707 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
708 This is a C++ based equivalent of gdcmPython/testSuite.py that should
709 be deprecated. If you have any doubts about the advantages of a
710 modern scripting language (read Python) versus grass root C++ (i.e.
711 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
712 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
713 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
714 Anyhow, consider documenting the gdcmData images in
715 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
717 * Test/CMakeLists.txt:
718 - now uses TestAllEntryVerify.cxx
719 - specific comments on oldACR00001.ima (now renamed in gdcmData
720 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
721 gdcmData/TestAllEntryVerifyReference.txt
724 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
725 * src/*.[h|cxx] : typedef clean up
726 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
727 - TagKey renamed to gdcmTagKey (for external usage)
728 - VRKey renamed to gdcmVRKey (for external usage)
729 - removal of typedef duplication.
730 - Removed all unecessary inline keyword from class inline definitions.
731 - Some method|function(void) declarations replaced with method|function().
732 * src/jpeg/libijg12/jdhuff12.c:
733 - printf polluting ctest removed.
734 - TAB removal for comminting
736 - TestAllReadCompareDicom.cxx: added a test that compares all the
737 images in gdcmDataImages.h with corresponding images in
738 gdcmData/BaselineDicom/. When baseline images are not present
739 this test creates them.
740 Note: we need to validate each reference image, but before that
741 I'd like to rename them with a more explicit name...
742 - CMakeLists.txt: changed accordingly.
743 * Example/*.cxx: examples now only include gdcm.h (as opposed to
744 including each header needed).
746 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
747 * Test/*.cxx and Example/*.cxx: moved some examples away from the
748 test suite to the Example directory. Are concerned:
753 - TestWriteSimple.cxx
754 * Test/CMakeLists.txt: added some comments on reasons for black listing
755 image gdcmData/oldACR00001.ima
757 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
758 * Test/CmakeList.txt: removed the following from black list (to be coherent
759 with removal from gdcmData):
760 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
761 - gdcm-MR-PHILIPS-16.dcm
763 Added the following because after last cvs update, they cause
764 ctest -R TestReadWriteReadCompare
766 - gdcm-MR-SIEMENS-16-1.acr
768 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
769 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
770 new comments in this file) we temporarily (sigh) move to a weaker
772 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
773 we don't need to black list the following images anymore:
774 - 8BitsUncompressedColor.dcm
776 - US-PAL-8-10x-echo.dcm
777 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
778 fixes and the beautified code ;-)
779 This fixes the bug introduced in version 1.42 (when beautifying)
780 that made the parsing of 8BitsRunLengthColor.dcm unproper.
781 Note: ctest was blind to this bug (this means we need to still
782 improve the test suite). The bug could be detected by using
783 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
785 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
786 and by displaying the (garbage) produced file temp.XDCM...
788 2004-06-29 Jean-Pierre Roux
789 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
790 - replace by uggly but working old code :-(
791 A lot of things should be OK again.
792 It's really urgent to have a test suite that *tests*,
793 to prevent Frog's beautifying sessions to break all the stuff
794 (twice, withing a fortnigh ...)
796 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
797 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
798 redundancy) to added Test/TestReadWriteReadCompare.cxx
799 * Test/CmakeList.txt: because the compare test of
800 Test/TestReadWriteReadCompare.cxx fails, the following images are
801 black listed: - 8BitsUncompressedColor.dcm
803 - US-PAL-8-10x-echo.dcm
804 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
805 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
806 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
807 and ad-hoc kludge. This kludge is now removed, and on encountering
808 such an image (OB field brain damaged) we set errno. Then in
809 ::FindDocLength() we "fix" the length as being ALL what remains
810 in the file (until EOF). We then proceed, hoping for the best...
811 This fixes a SegFault in ShowDicom when trying to write such an
813 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
814 (because TestWriteRead breaks on it, after a non conformal commit?).
815 ctest now runs properly, except for MakeDicomDir (which was allways
816 broken) and the Python related stuff (still not fixed).
818 2004-06-24 Jean-Pierre Roux
819 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
820 FIX : Test/TestReadWrite now iterates on all the file names
821 (instead of infinite loop)
822 ENH : Test/TestWriteRead now iterates on all the file names
824 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
827 2004-06-24 Jean-Pierre Roux
828 FIX : - now Write drops LUT Descriptors and LUTs (if any)
829 when SamplesPerPixel =3
830 - now Write is no longer confused by
831 'BitsAllocated = 12" and 'BitsStored=12"
832 - "UN" value representation Elements are now written correctly
833 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
834 ENH : - now gdcmHeader has its own Write methods
835 (in order to split the job that has not to be done
838 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
840 loop on the same image until memory went out.
841 Note: this means we still have gobs of memory loss in PrintDocument
842 * src/gdcmDocument.cxx: fixes problem on parsing on file
843 gdcmData/16BitsJpegLosslessGrayScale.dcm.
845 2004-06-24 Jean-Pierre Roux
846 FIX : Write - All the Sequences and Sequence Item are now written
847 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
848 is added a the end, when necessary.
849 - A lot of brain-damaged images, that were read correctly are
850 now written correctly
851 - length compatible BinEntry are now loaded correctly
852 (even for odd groups)
853 Note : only Explicit Value Representation was checked.
854 (question : is implicit VR really necessary for gdcm ?)
856 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
857 * DEVELOPPER: added a proposition of coding style.
858 * src/gdcmDocEntry.h: removed every inline declaration (for test of
861 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
863 Use the gdcmDocEntry::Print() and Write() instead.
864 * src/gdcmDocument.cxx: bug fix.
866 2004-06-22 Jean-Pierre Roux
867 FIX : gdcmDocument.cxx
868 - Now we do recognize the JpegLossLess format (there was a misstyping in
869 code 'beautyfication' :-(
870 - Now we automaticaticaly load the Luts, if any
872 2004-06-22 Jean-Pierre Roux
873 In order : to write Sequences, whatever their imbrication level,
874 : to allow user to create his own Sequences
875 a lot of modif where necessary (adding, moving, or virtualising methods)
877 WARNING : save your own sources *before* cvs up !
880 ADD virtual void Write(FILE *fp, FileType filetype);
883 ADD virtual void Write(FILE *fp, FileType filetype);
884 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
887 ADD virtual void Write (FILE *fp, FileType filetype)=0;
888 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
889 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
890 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
891 ADD std::string GetEntryByName(TagName name);
892 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
894 std::string vr = "unkn",
895 std::string fourth = "unkn",
896 std::string name = "unkn");
897 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
898 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
899 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
900 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
901 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
902 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
903 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
904 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
907 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
908 ADD virtual std::string GetEntryByName (TagName tagName);
909 ADD virtual std::string GetEntryVRByName (TagName tagName);
910 REM virtual bool Write(FILE *, FileType);
911 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
912 FILE *_fp, FileType type);
913 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
914 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
915 REM virtual bool WriteEntries(FILE *_fp,FileType type);
916 REM virtual std::string GetEntryByName (std::string tagName);
917 REM virtual std::string GetEntryVRByName (std::string tagName);
918 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
919 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
920 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
922 std::string vr = "unkn",
923 std::string fourth = "unkn",
924 std::string name = "unkn");
925 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
926 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
927 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
928 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
931 ADD virtual void Write(FILE *fp, FileType filetype);
934 ADD virtual void Write(FILE *fp,FileType filetype);
937 ADD virtual void Write(FILE *fp, FileType filetype);
938 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
939 REM std::string GetEntryByNumber(guint16 group, guint16 element);
940 REM std::string GetEntryByName(TagName name);
943 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
945 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
946 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
947 The default constructor invoked by the line
948 gdcmHeader *f1 = new gdcmHeader( header );
949 was gdcmHeader::gdcmHeader(bool) instead of the expected
950 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
951 Hence the parsing wasn't executed... See also below.
952 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
953 as explicit constructor didn't do the trick to fix the above problem.
954 Could anyone explain why ?
955 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
956 properly calls gdcmValEntry::Print() (that was weed out from
957 code related to gdcmBinEntry).
959 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * In order to fix memory leaks:
961 - Test/TestWriteSimple.cxx: added cleaning of free store through
963 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
964 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
965 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
966 (through the call to ::AddDicomDirMeta()) or the destructor
967 would crash when deleting uninitialized ::metaElems].
968 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
969 - src/gdcmDocument.cxx:
970 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
972 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
973 was causing memory leaks.
974 - src/gdcmSQItem.cxx:
975 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
976 cleanly handled with polymophism: sorry but my milage is low).
977 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
978 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
979 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
980 This avoids SegFaulting.
981 - src/gdcmSQItem.h: coding style.
983 - Test/TestWriteSimple still severely sucks. The output image content
984 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
985 damaged when displayed with vtkgdcmViewer.
986 - on memory leaks: TestWriteSimple leaks really less (see entry
987 of 2004-06-18 in Changelog file for the call to valgrind).
988 - on segfaults: ctest now passes all the tests but one (no more
990 * Erroneous leading white fix:
991 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
992 white[s] (as opposed to from >> xxx, that removes it [them].
993 - src/gdcmTS.cxx: ditto.
994 - gdcmPython/testSuite.py: dirty related kludge removed.
995 * src/*: remaining references to gdcmParser removed.
996 * src/*[cxx|h]: added copy[way]left header.
999 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * In order to fix writing of dicom files:
1001 - Test/TestWriteSimple.cxx: a simpler example of writing.
1002 - Test/CMakeLists.txt changed accordingly.
1003 - src/gdcmDocument.cxx:
1004 -- The destructor now recursilvely removes potential sequences.
1005 -- Bug fix in ::IsJPEG2000()
1006 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1007 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1009 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1010 to only declared) and build on top of
1011 ::GetDocEntryByNumber(guint16, guint16).
1012 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1013 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1014 for usage in destructor and treatement of promotion in
1015 ::ReplaceOrCreateByNumber().
1016 - src/gdcmSQItem.cxx: destructor should better handle his job.
1017 Test/TestWriteSimple now runs (or at least it DOES something).
1018 * We can now start hutting memory links. A good starting point is:
1019 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1020 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1021 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1023 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1024 * Valgrind note: after Mathieu Malaterre teached me how to read
1025 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1027 Using gcc, you can force the STL to use malloc and to free memory as
1028 soon as possible by globally disabling memory caching.
1029 With 3.2.2 and later, you should export the environment variable
1030 GLIBCPP_FORCE_NEW before running your program.
1031 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1032 simply vanish (it is still not clear to me, whether this means that
1033 STL std::string leaks or if valgrind believes it leaks...).
1034 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1035 running bin/gdcmTests makeDicomDir):
1036 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1037 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1039 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1040 SegFaulting (I drowned in DicomDir related code when trying to
1041 understand why the list is empty...).
1042 * src/gdcmDocument.h: first BSD license header try.
1043 * Doc/License.txt added.
1045 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1046 * src/gdcmDocument.[h|cxx]:
1047 - Clean up of the Transfer related predicates. They are now all based
1048 on new method isGivenTransferSyntax, that (should) handle properly
1049 the padding problem.
1050 - general clean up, simplification, and coding style.
1051 - Specific clean up of Parse7FE0() (umproperly named actually).
1052 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1054 2004-06-14 Jean-Pierre Roux
1056 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1057 - fix the display of SQItem ordinal number
1058 - add the GetSQItemByOrdinalNumber method
1059 - remove some useless never written private methods
1061 2004-06-14 Jean-Pierre Roux
1063 - adding a constructor taking a gdcmDocEntry as an input param
1064 - ReplaceOrCreateByNumber now returns :
1065 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1066 a gdcmValEntry * if a string value is passed as a param
1068 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1069 according to the param type (no longer sets a gdcmDocEntry)
1070 - GetValEntryByNumber, GetBinEntryByNumber added
1071 - NewValEntryByNumber and NewBinEntryByNumber added
1073 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1075 - GetSQItemNumber and SetSQItemNumber added, to provide
1076 a (relative) Item identier inside a given Sequence
1077 \warning : some pb remaining around this number
1079 - AddEntry now takes the Item Number as a param
1081 - adding a constructor taking a gdcmDocEntry as an input param
1083 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1084 * Memory leak hunt with the following command:
1085 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1086 --show-reachable=yes gdcmTests PrintDocument
1087 It looks like many (all?) leaks are due to the STL (or a bad usage
1088 of the STL. The lines producing the leaks now have a comment with
1089 a "MEMORY LEAK" tag: you can retrieve them with
1090 grep "MEMORY LEAK" src/*
1091 Here are two typical examples which I can't help fixing:
1096 char * test = "babo";
1097 name = test; //// <--- valgrind detects 960 bytes lost in
1098 //// call to std::string::operator=(char const*)
1099 name.clear(); //// Doesn't help !
1107 std::cout << "Type a bunch of characters followed by RETURN: ";
1108 getline(std::cin, line); //// <--- valgrind dectects a loss
1109 //// of 1320 bytes in call to
1110 /// std::basic_istream<>& std::getline<>
1116 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * src/gdcmHeader.[cxx|h]:
1118 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1119 and related, moved away to gdcmDocument.
1120 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1121 the corresponding protected accessors of inherited class
1122 gdcmDocument, removed ! As a consequence gdcmFile had to be
1123 declared friend of class gdcmDocument (see below).
1124 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1125 - Clean up of undefined or unused methods.
1126 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1127 account the changes to gdcmHeader.h).
1128 * src/gdcmDocument.h:
1129 - gdcmFile is now a friend class (in order to take into account the
1130 changes to gdcmHeader.h).
1131 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1132 (see changes to gdcmHeader.h).
1133 - Accessors (reading on the form GetEntry*) are now public.
1134 - Clean up of undefined or unused methods.
1135 * src/gdcmDocument.cxx:
1136 - adaptation to changes to gdcmDocument.h
1137 - ::OpenFile now writes a verbose message when file cannot be opened.
1138 - some std::string properly set to VRKey
1139 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1140 references to gdcmDocument.
1141 * Test/TestFindTags.cxx: changed accordingly to above changes.
1142 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1143 cvs repository gdcmData.
1145 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1146 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1147 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1148 conflicts with gdcmValEntry::voidArea.
1149 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1150 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1151 Value representation between StringRepresentable and BinaryRepresentable.
1152 * src/gdcmDocument.cxx:
1153 - method ParseDES: proper indentation restored and usage of
1154 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1155 - method LoadDocEntry: the fingerprint left in the SetValue() of
1156 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1157 removed. Reverting to previous code segment with the proper
1158 dynamic_cast< gdcmValEntry* >.
1159 Note: this was (partially) breaking the python test suite
1160 (gdcmPython/testSuite.py) that made usage of the above
1161 fingerprint to check presence of "Pixel Data".
1162 * src/gdcmDocEntry.h: coding style.
1163 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1164 now taken into account.
1165 * gdcmPython/gdcm.i: adaptation to the new internal representation
1166 of gdcm (exit gdcmParser, hello gdcmDocument).
1167 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1169 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1170 anymore, but instead prints the loaded Python dictionary.
1171 * .... alas, the python testSuite is still broken.
1173 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1174 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1176 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1177 * src/gdcmUtil.h : export methods
1179 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1180 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1182 * Initial addition of automatic python testing
1183 * Initial addition of automatic image comparison
1185 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1186 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1187 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1189 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1190 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1191 * Test/ShowDicom.cxx : bug fix for msvc compilation
1192 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1194 2004-05-04 Jean-Pierre Roux
1195 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1196 new concepts (and new classes) :
1197 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1198 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1199 - Sequence Doc Entries (gdcmSeqEntries)
1200 a Sequence is composed of Items.
1201 Each item is a set of Doc Entries (this is recursive)
1202 The non uniqueness of the 'Dicom tag' is due to this recursivity
1203 (never taken into account)
1204 Our unability to add a new 'entry' in the header
1205 at the proper location (neither in the H-Table (map or multimap),
1206 nor in the Chained List is also due to this recursivity.
1207 Don't try, right now, to use/modify/compile these new sources :
1208 nothing is finished.
1209 We just commit all the stuff, 'as is', in order not to loose it.
1211 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1212 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1214 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1215 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1216 file prefix (SetFilePrefix)
1218 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1219 * Add a new test: ShowDicom, for now this is just the c++ version of
1220 checkRead.sh, later it will be able to compare the image read against a
1222 * Replace the DEBUG on the stack with a global entry in cmake interface:
1223 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1225 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1226 * Add an example subdir, with a real example on how to read + write a
1229 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1230 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1231 * Doc/CMakeLists.txt: the main page is now properly differentiated
1232 between the developper and user version.
1233 * Doc/doxygen.config.in: dropped search related obsolete flags
1234 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1236 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * DEVELOPPER: added some helpfull comments for compile/test/install
1240 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1241 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1242 src directory, now generated in the build dir.
1243 2. Tests as mentionned smarter
1245 4. Add a new method in gdcmDict that return the PubDict by name
1246 this is interesting for 3rd party lib like ITK,
1247 where we could set the institution name / patient name...
1249 * ENH: 1. Now the test suite is working for real
1250 2. All binaries are now output in the gdcm-bin directory
1251 (this was not true before)
1253 2004-04-28 Jean-Pierre Roux
1254 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1255 SeQuence indented printing of Dicom Header.
1256 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1257 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1258 Computation of SQDepthLevel is now part of gdcmHeader constructor
1259 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1260 tree-like structure of a Dicom Header.
1261 * FIX Test code cleaning
1263 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1264 * ENH: Adding automatic testing
1265 1. Need a DartConfig.cmake to submit to public
1266 2. Add a test driver gdcmTest.cxx
1267 3. gdcmTestMain, an helper for the main test driver gdcmTest
1268 4. Files in Test don't have a main anymore, this becomes interesting
1269 when we add more and more tests, thus dsw don't have to load
1271 * ENH: Adding a GDCM_DATA_ROOT for testing
1272 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1273 one file instead of seven + some small cleanup
1275 2004-04-22 Jean-Pierre Roux
1276 * ENH Minor changes to the Print() methods.
1277 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1278 Header printing. Example given with :
1279 > PrintHeader fileName 2 new
1280 (SQ based tree-like structure still to be done for the Header ...)
1282 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1283 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1284 1. I have added some unsigned where needed
1285 2. Some function parameter not used -> (void)
1286 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1287 4. g++ don't like character '\' in comment
1288 5. #define jpeg_create_decompress jCreaDecompress
1289 this really need to be fixed
1290 6. virtualize destructor of gdcmObject ... leakage
1291 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1292 this also really need to be fixed
1293 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1294 remove compression file
1295 (as we only do decompression, right ?)
1296 * ENH: Change malloc/calloc/free with c++ equivalent
1298 2004-04-21 Jean-Pierre Roux
1299 * FIX gdcmHeaderHelper::GetXSpacing
1300 when a single value is found (bug ?), xpacing is now
1301 defaulted to yspacing
1303 2004-04-19 Jean-Pierre Roux
1304 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1305 * ENH add parameters :
1306 bool exception_on_error = false,
1307 bool enable_sequences = false,
1308 bool ignore_shadow = false
1309 to the gdcmFile constructors to be full gdcmParser compliant
1310 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1311 to allow reading of PAPYRUS 3.0 files
1313 2004-04-06 Jean-Pierre Roux
1314 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1316 2004-04-02 Jean-Pierre Roux
1317 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1318 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1319 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1321 2004-03-30 Jean-Pierre Roux
1322 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1323 for ACR file, written out as DICOM files (hope so...)
1325 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1327 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1328 moved to base class gdcmParser and only the specialisation is kept
1330 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1331 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1332 already does the job.
1333 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1334 (to be consistent with gdcmParser::WriteEntries).
1336 2004-03-30 Benoit Regrain
1337 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1338 upate of the object's instance. It's passed to 2 in the unfavorable
1339 case : one in the ExecuteInformation, one in the ExecuteData
1341 2004-03-29 Jean-Pierre Roux
1342 * ENH : Check on file type to be written moved
1343 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1344 * FIX : gdcmObject::ResetBoundaries now stops properly
1345 when end-of-list is reached
1346 : gdcmVersion modified (as Benoit Regrain asked)
1348 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1350 * src/gdcmUtil.cxx: added forgotten iostream include.
1351 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1352 equivalent to ExplicitVR in existing code).
1354 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1355 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1356 now contains all the gdcmGlobal related code.
1357 * minor coding style and doxygenation changes.
1359 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1360 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1361 now contains all the Debug related code.
1362 * minor clean-up of includes in src/*.cxx
1363 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1364 CreateCleanString) removed.
1365 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1366 * Doc/DoxyMainPageUser.txt added.
1367 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1368 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1369 src/gdcmDirList.cxx)
1371 2004-03-24 Jean-Pierre Roux
1372 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1374 2004-03-23 Jean-Pierre Roux
1375 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1376 big endian made volumes
1377 * ENH Now gdcmParser constructor and destructor are protected to forbid
1378 end user to instanciate class gdcmParser
1379 (only gdcmHeader and gdcmDicomDir are meaningfull)
1381 2004-03-22 Benoit Regrain
1382 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1383 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1384 gdcmSerie to gdcmDicomDirSerie
1386 2004-03-19 Jean-Pierre Roux
1387 * ENH Now the tree-like structure describing a DICOMDIR comming from
1388 an already existing DICOMDIR file is consistent with
1389 the home-made tree-like structure build ex-nihilo
1390 or build from the files held (recursively) in a Directory
1391 functions gdcmDicomDir::CheckBoundaries()
1392 gdcmObject::SetBoundaries() added
1394 2004-03-17 Jean-Pierre Roux
1395 * REM (Eric Boix bug) : removal of meaningless
1396 gdcmDicomDirImage::NewImage function.
1397 * FIX now file names and directory name are written properly in the
1399 * FIX now gdcmDicomDir constructor may be call without any trick
1402 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1403 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1404 of gdcmDicomDirImage::NewImage as empty function.
1406 2004-02-28 Jean-Pierre Roux
1407 * ENH add gdcmDicomDir:NewPatient
1408 add gdcmDicomDirPatient:NewStudy
1409 add gdcmDicomDirStudy:NewSerie
1410 add gdcmDicomDirSerie:NewImage
1411 to allow making gdcDicomDir object.
1412 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1413 (as opposite to the gdcmHeader chained list)
1415 2004-02-11 Benoit Regrain
1416 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1417 when using from python
1419 2004-02-10 Benoit Regrain
1420 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1421 * FIX : in gdcmDicomDir when the directory is empty
1422 * ENH : add callback and methods to get the progression of dicomDir
1425 2004-02-06 Jean-Pierre Roux
1426 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1427 - GDCM_META added to gdcmDicomDirType
1428 - class gdcmMeta created
1429 * ENH : - A brief summary is now displayed at the beginning of
1430 'testDicomDir' to help disaster magnitude estimation
1431 * REM : Now useless Test/explDICOMDIR.cxx
1433 2004-02-05 Benoit Regrain
1434 * ENH : add methods in gdcmObject to get the hash table or the list of
1436 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1437 * FIX : wrapping python for TagHeaderEntryHT
1439 2004-02-04 Benoit Regrain
1440 * FIX : even length for some strings when writting the dicom dir
1441 * FIX : sort the images in the dicom dir
1442 * FIX : Bug fix for python use of dicom dir
1443 * ADD : a python demo
1445 2004-02-04 Jean-Pierre Roux
1446 * FIX : Final solution (?) for icone embedded images
1447 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1448 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1449 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1450 gdcmData/gdcm-MR-SIEMENS-16.acr1
1451 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1452 to make full checking easier
1454 2004-02-04 Benoit Regrain
1455 * FIX : WriteEntries : coding style & logic in parameters
1456 * FIX : Set the elements to create the DicomDir in a dictionary file
1458 2004-02-03 Benoit Regrain
1459 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1460 * gdcmDicomDir : add the load of directory
1461 * Bug fix and print add-on
1463 2004-02-03 Jean-Pierre Roux
1464 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1465 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1466 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1467 * FIX gdcmParser.cxx : 'group length' elements are now considered
1468 as integers, even for shadow groups, when file is Implicit VR
1470 2004-02-02 Jean-Pierre Roux
1471 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1473 of the last synonym :-(
1474 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1476 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1477 * FIX taking into account the possible 7fe0,0010 multiplicity
1478 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1479 to allow removal of references to 7fe0,0010, to deal with
1480 ACR-NEMA images, when 0028,0200 is meaningfull
1482 2004-01-31 Jean-Pierre Roux
1483 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1484 no longer writes 'Un' on disk
1485 * FIX SQ elements with actual length are now dealt with corectly
1486 * FIX gdcmFile::WriteBase make the difference, for color images, between
1487 the length (for Palette expanded images)
1488 and Raw Length (non expanded image + Palette)
1489 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1490 (that broke Write). Replaced by UL.
1491 Aware user will reload the field if he
1492 thinks it's necesssary
1494 2004-01-30 Jean-Pierre Roux
1495 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1496 when 'dirty Acr' is found, to be compliant with the new
1497 IsReadable() methods.
1499 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1500 (no DOUBLE images in kosher DICOM,
1501 but so usefull for people that miss them ;-)
1503 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1504 DICOMDIR related utilities (not checked as Windoze compliant)
1506 2004-01-28 Jean-Pierre Roux
1507 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1509 2004-01-27 Jean-Pierre Roux
1510 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1511 to allow skipping the shadow elements, to save memory space.
1512 The TRUE value for this param has to be used
1513 with a FALSE value for the 'enable_sequence' param.
1514 ('public elements' may be embedded in 'shadow Sequences')
1515 * gdcmHeader methods now deal with 'embedded icones images' in the header
1516 (even when an 'icone image sequence' is announced by the
1517 element (0x0088,0x0200), but there is NO icone at all ...
1519 * gdcmHeader sometimes Image Location value doesn't follow
1520 the supposed processor endianity (see gdcmData/cr172241.dcm).
1523 * gdcmHeader add the method
1524 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1525 to get *all* the Header Entries with the same tag.
1526 GetHeaderEntrySameName is probabely *useless*
1527 (no meaning : Name is *not* an identifier within the Dictionnary)
1529 2004-01-26 Benoit Regrain
1530 * Bug fix in the print of hexadecimal representations. Remove long fields
1531 in the print and add a third level of print to print them
1533 2004-01-23 Benoit Regrain
1534 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1535 * Bug fix on test suite after remove the strip made on not string fields
1536 * Split the IsReadable method between gdcmParser which test that the file
1537 is dicom and gdcmHeader which test that it's an image file
1539 2004-01-22 Benoit Regrain
1540 * DicomDir : clean code, add methods, set variables in protected or private
1541 * gdcmUtil : bug fix for the clean string method
1543 2004-01-19 Benoit Regrain
1544 * Add the use of shadow dictionaries
1545 * bug fix and coding style
1547 2004-01-19 Benoit Regrain
1548 * src/gdcmFile.cxx : bug fix concerning the close of file
1549 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1550 * Add the update of header entries using the shadow library
1552 2004-01-19 Benoit Regrain
1553 * removal of file gdcmHeader2.cxx
1554 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1555 inheriting from gdcmParser. This split is to prepare the integration
1556 of dicom dir parsing
1557 * bug fix under python
1559 2004-01-16 Jean-Pierre Roux
1560 * REM removal of class gdcmHeaderEntrySet
1561 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1562 * ADD add file gdcmHeader2.cxx
1563 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1565 2004-01-15 Benoit Regrain
1566 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1567 entries created while parsing the header. Thus, they will be destroyed
1568 when the gdcmDictSet will be destroyed
1569 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1572 2004-01-15 Benoit Regrain
1573 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1574 made a fatal error because of the memory release at the end of program.
1575 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1576 some memory and vtk seems to have some problems with that.
1577 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1579 2004-01-14 Benoit Regrain
1580 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1581 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1582 * src/*.[h|cxx] : make changes due to class name changes
1583 * gdcmPython/demo/*.py : bug fix due to method names
1585 2004-01-13 Benoit Regrain
1586 * src/*.[h|cxx] : coding style
1587 * vtk/*.[h|cxx] : coding style
1589 2004-01-13 Benoit Regrain
1590 * gdcmPython/testSuite.py : test the readable flag of file for tests
1591 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1592 It's lied to the stl compilation by MSVC (windows, always windows...)
1593 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1595 2004-01-12 Benoit Regrain
1596 * src/*.h : add comments
1597 * src/gdcmDictSet.h : set the method BuildDictPath in public
1598 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1599 directly setted in the source code
1600 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1603 2004-01-09 Benoit Regrain
1604 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1605 * setup.py : use a reference to gdcmVERSION
1607 2004-01-07 Benoit Regrain
1608 * Modification to compile with the distutils.
1611 2003-12-10 Benoit Regrain
1612 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1613 can use a gdcmHeaderHelper to load datas
1614 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1615 made in the source code
1617 2003-12-10 Benoit Regrain
1618 * Update Windows projects and .cvsignore files
1620 2003-11-12 Jean-Pierre Roux
1621 * ENH gdcmHeader constructor has one more parameter (default value : false)
1622 that allows the user to 'go inside' the SeQuences only
1624 gdcmElValSet:Print takes it into account
1626 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1627 * ENH: Update gdcmPython/CMakeLists
1628 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1629 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1631 2003-11-10 Jean-Pierre Roux
1632 * FIX : gdcmHeader::LoadElements is now based
1633 on the ListTag listElem member,
1634 not longer on the TagElValueHT tagHt member
1635 * ENH : PrintPubElVal shows (temporarily) both results,
1636 with the tagHt member and the listElem member.
1637 (it's easier to 'see' the problems when using Printheader)
1639 * FIX : old private member LgrElem is now splitted into
1640 ReadLength : Length actually found on disk (updated only
1641 if bug fixing is necessary), for internal
1643 UsableLength : Updated by FixFoundLength, to fix a bug
1644 or to allow Parser going on.
1645 Will allow to re-write a kosher header when a SeQuence
1646 with a length (not 0000) is found
1647 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1648 because gdcmElValSet::Add does not update ListElem
1651 2003-11-07 Jean-Pierre Roux
1652 * FIX misstyping in Transfert Syntax name table
1653 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1654 when they have an actual length (not 0000 nor FFFFF)
1655 (Nobody should care of it, but DICOMDIR explorers)
1657 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1658 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1660 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1661 * ENH: vtkGdcmReader now supports LUT !
1662 (vtkgdcmViewer for now is not able to use them though)
1664 2003-11-05 Jean-Pierre Roux
1665 * in testSuite.py : new files names for checking the package
1666 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1667 that returns the pixel area size to the *aware* (vtk) user
1668 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1670 2003-11-05 Benoit Regrain
1671 * in testSuite.py : Modify the rules for checking the paths
1672 : Explicit error messages
1673 * in __init__.py : Related modif
1675 2003-11-03 Jean-Pierre Roux
1676 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1677 to be used by aware (vtk) users that want to manage
1678 LUT (and no to turn the PALETTE image into an RGB pixels one)
1679 * GetPixelType now returns 8U for 24 Bits images
1680 (vtkGdcmReader compliant)
1682 2003-10-31 Jean-Pierre Roux
1683 * Removal of *all* gdcmData images and add them again
1684 in order to loose the 'history' of un-anonymised images
1686 2003-10-31 Jean-Pierre Roux
1687 * RMV : removal of useless jBitsInJsample.h
1688 for both 8 and 12 Bits JPEG Lossy Libraries
1690 2003-10-31 Jean-Pierre Roux
1691 * ENH : Add the functions gdcmFile::GetImageDataRaw
1692 gdcmFile::GetImageDataIntoVectorRaw
1693 that act as GetImageData and GetImageDataIntoVector
1694 except the making of an RGB Plane from Gray Plane + LUT
1695 Intended to aware (vtk) users who know how to manage
1698 GetLUTRGBA return a R,G,B,A LUT if any
1699 lgrTotaleRaw gives the 'Raw' length
1700 GetImageDataRaw returns the gray Plane
1701 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1702 (They stay Grey, just like with other Dicom viewers :-(
1704 2003-10-30 Jean-Pierre Roux
1705 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1707 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1709 being coherents dicom files.
1711 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1714 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1715 * ENH: Two steps is necessary to please VC++ compiler...
1716 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1717 * ENH: Add include dir to medcon lib
1718 * FIX: only one function is being exported for now !
1719 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1721 2003-10-29 Jean-Pierre Roux
1722 * adding gdcmHeader::GetLUTRGBA
1723 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1724 --> Mathieu, the modif u're waiting for is not yet committed
1725 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1727 2003-10-27 Jean-Pierre Roux
1728 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1729 00191113.dcm DermaColorLossLess.dcm
1730 MxTwinLossLess.dcm RadBWLossLess.dcm
1731 * ENH: For version prior to vtkImageViewer2 -r 1.19
1732 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1734 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1735 * Removal of ido stuff in CMakeLists.txt
1737 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1738 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1739 * FIX: remove a call to ->Modified ... see comments
1740 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1742 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1743 * FIX: Problem with path for libvtkgdcmPython
1744 * ENH: Try adding a search script for python site-package
1745 * RMV: Remove some file from medcon lib that are not necessary
1746 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1747 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1748 * FIX: More pragma disable fro VC++,
1749 I don't think I break something as it is also disable in VTK/ITK.
1750 But it fasten debug compilation time.
1752 2003-10-23 Jean-Pierre Roux
1753 * gdcm now deals with 16 Bits Run Length Encoded images
1754 (they are compressed as 2 planes images,
1755 one for the high Bytes, the other for low Bytes)
1757 2003-10-22 Jean-Pierre Roux
1758 * Now CheckRead takes into account :
1759 - the bugged 'Leonardo' Siemens images
1760 - the XA images, sent thru the burning VPRO station
1761 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1764 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1765 * FIX: When copying a Makefile.am to CMakeLists.txt
1766 one should remove the '\'
1768 2003-10-22 Jean-Pierre Roux
1769 * in gdcmData adding a bugged 'Leonardo' Siemens image
1770 (wrong lengths in header)
1771 OK with gdcm, KO with the other viewers :-)
1772 * add a GE dlx XA image, thru the VEPRO burning station
1775 2003-10-21 Jean-Pierre Roux
1776 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1777 for a brutal checking of vtkgdcmViewer compliance
1779 2003-10-21 Jean-Pierre Roux
1780 * add the files for 'xmedcon' Jpeg Lossless library
1781 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1783 2003-10-21 Jean-Pierre Roux
1784 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1786 2003-10-21 Jean-Pierre Roux
1787 * garbage Siemens 'Leonardo' images dealt with
1788 (the patch is easy to remove)
1789 * cosmetic changes to avoid warnings
1791 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1792 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1793 no need to press 'r' now.
1795 2003-10-20 Jean-Pierre Roux
1796 * upgrade of checkRead.sh checkWrite.sh according
1797 to new Jpeg Lossless decompressor
1798 * add US.3405.1.dcm, a genuine RGB medical file ...
1799 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1800 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1802 2003-10-15 Jean-Pierre Roux
1803 * general anonymisation in gdcmData
1804 * adding the 'color files' from
1805 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1806 * adding some well knowed bugged-header images
1807 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1808 waiting for their inclusion in Python testsuite
1810 2003-10-15 Jean-Pierre Roux
1811 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1812 no longer seg faults when file is not found
1814 2003-10-14 Jean-Pierre Roux
1815 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1818 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * TODO: *.in file to genereate a UseGDCM later
1821 2003-10-14 Jean-Pierre Roux
1822 * Some supposed-to-be Dicom Images have no preamble.
1823 OpenFile takes it into account
1824 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1825 * Missing elements added in dicomV3.dic
1826 (just to be affraid : have a look at
1827 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1828 and do it again next year ;->
1830 2003-10-13 Jean-Pierre Roux
1831 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1832 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1833 But there are NOT. It's fixed !
1835 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1836 * FIX: "jpeglib.h" was not found on VC++
1837 * FIX: vtkgdcm was not being installed
1839 2003-10-10 Jean-Pierre Roux
1840 * ENH : OpenFile closes the file if it *really* doesn't look like
1841 an ACR-NEMA / DICOM one.
1842 * FIX : testWrite no longer writes an empty file if the source file
1843 is not gdcm Readable
1844 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1847 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1848 * FIX: CMake generate now documentation
1849 * ENH: out of source doc build !
1850 * ENH: Generate both user and dev documentation
1851 * ENH: Should work on windows too
1852 * ENH: Only one doxygen config.in file is needed
1853 * FIX: make install should be ok now on ùnix plateform
1854 * FIX: PATH to dictionary was wrong (missing /)
1855 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1857 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1858 * vtkGdcmReader is now able to read rgb dicom file.
1859 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1860 * added a gdcmViewer to vtk test, use mouse to control
1861 window level & window width
1863 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1864 * CMake-ification of gdcm, we have now two build system
1865 * FIX: on cygwin Wsock32 doesn't exist
1866 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1868 2003-10-06 Emanuel Ollart
1869 * FIX : compilation process wad broken.
1870 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1872 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * change gdcmViewer -> vtkgdcmViewer
1874 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1876 2003-10-06 Jean-Pierre Roux
1877 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1878 ( e.g : well known GE images with a wrong elem length,
1879 : Philips MRI Images with a wrong Huffman table)
1880 * still to be done : allow the reading of bugged LEONARDO Siemens images
1882 2003-10-03 Jean-Pierre Roux
1883 * Odd length strings are padded with '\0' (not with spaces,
1884 to remain compliant with already defined strings,
1885 like Transfert Syntax UID and others)
1887 2003-10-03 Jean-Pierre Roux
1888 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1889 to allow displaying RGB images (not only by affim ;-)
1891 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * vtkGdcmReader is now able to read rgb dicom file.
1893 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1895 2003-10-03 Jean-Pierre Roux
1896 * A few nasty patches to allow the reading of a lot of nasty images
1897 ( e.g : well known GE images with a wrong elem length,
1898 : Philips MRI Images with a wrong Huffman table)
1899 * still to be done : allow the reading of bugged LEONARDO Siemens images
1901 2003-10-03 Jean-Pierre Roux
1902 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1904 2003-10-03 Jean-Pierre Roux
1905 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1906 to allow displaying RGB images (not only by affim ;-)
1908 2003-10-03 Jean-Pierre Roux
1909 * gdcmFile::GetImageDataIntoVector now
1910 - deals with MultiFrames MultiFragments Run Length Encoded files
1911 - deals with YcBcR (YBR_FULL) files
1912 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1913 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1915 (no sample found :-(
1917 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1919 Two reasons: - clear things
1920 - third parties acces gdcm through header files, so won't
1921 suffer anymore VC++ complains
1923 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1924 * add argv[1] in testvtkGdcmReader.cxx
1927 2003-09-24 Jean-Pierre Roux
1928 * The lines are now eigthy characters long.for
1929 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1931 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1932 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1933 char* to std::string. Thus, the use of strdup becomes useless. (see
1934 previous commis of Malaterre)
1935 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1936 before the last Malaterre's commit.
1938 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * This commit should fix the Debug building under VC++, the problem
1940 was mainly a mixture of debug and release lib being loaded at startup.
1941 * I also remove a depency to a specific C function: strdup. Because I had
1942 to force the link to msvcrtd (whereas strdup is in libc).
1944 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1945 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1946 located in the gdcmCommon.h file. All use of reference of tha has been
1947 changed to now use the variable GDCM_UNFOUND.
1949 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1951 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1952 Dicom dictionary. The test suite can now be run again. Note:
1953 I'm note very happy with the " (RET)" changes. I believe this
1954 RETAINED comment should be dropped when parsing the dictionary.
1955 - PACKAGER corrected
1957 - AUTHORS updated and now in alphabetical order
1958 * Makefile.am now exports gdcm.dsw for Windoze users.
1960 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1961 * cygwin complains about missing std:: in subdir Test/
1963 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1964 * remove some methods that are now in gdcmHeaderHelper
1966 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * vtkGdcmReader set spacing and origin correctly
1969 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1970 * Fix a few delete/delete[] mismatch
1972 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1974 interpretation to data given by gdcmHeader. For instance there are
1975 heuristics to get informations (look at different places).
1976 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1977 sorting DICOM images based on different strategies.
1978 * modified Makefiles accordingly.
1980 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1982 when building in debug mode
1983 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1984 src/win32/gdcmdll.dsp
1985 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1987 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1991 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1992 * src/win32/libgdcmjpeg12.dsp was not dos format
1993 * src/win32/libgdcmjpeg12.dsp :
1994 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1995 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1997 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1998 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2000 * src/gdcmFile.cxx : bug fix in affectation type
2001 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2002 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2003 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2004 symbols... future problem ?
2006 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2007 * src/win32/libgdcmijpeg12.dsp was missing
2008 * modified gdcm.dsw accordingly
2010 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2013 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2014 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2015 commit of JPR (before his hollidays to facilitate our work).
2016 * setup.py : bug fix in code. Modifications made while the last commit
2017 of JPR. The code hasn't been tested before the commit... it's so
2018 useless to make that (for best programmer that is JPR) !!!
2020 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2021 * tagged the current version as Version0_3 (i.e. version 0.3)
2023 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2024 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2025 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2026 * *.dsp : modifications to use new libgdcmijpeg8 library
2027 * setup.py : bug fix on VTKPATH variable
2028 * PACKAGER : adding all concerning windows
2030 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2031 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2033 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2034 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2035 test suite reported error.
2036 * PACKAGER file added (describes what a packager must do when
2037 packaging a new release).
2038 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2039 * configure.in: upgraded version number to 0.3.0
2040 * fixing build of rpm (through rpm -ta):
2041 - Doc/Makefile.am exports proper doxygen files
2042 - src/jpeg/libijg8/Makefile.am exports the include files.
2044 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2045 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2046 * src/gdcmHeader.h : formatting code
2048 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2049 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2050 We were obtaining error message from vtk. Now, creation of file list
2051 is made in an internal list to prevent this problem.
2052 Bug fix when output is empty.
2053 Bug fix in update of progress value. Previous commit for this was a bad
2055 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2057 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2058 * src/gdcmHeader.h : added method to get the file name
2059 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2060 files. Added method to remove all files on the input
2061 Added FIXME comment concerning the bad parsing of header made by
2062 ExecuteInformation method (in ExecuteData method)
2064 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2066 when using make instal.
2067 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2068 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2070 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2071 * setup.py : adding include dir of jpeg lib to compile all sources
2072 * */Win32/*.dsp : JPR fix for windows compilation
2074 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2075 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2077 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2078 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2080 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * setup.py is again effective on un*x (takes into account the
2082 addon of the jpeg library)
2083 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2084 * Doc/Doxy* updated (includes above enhancements)
2085 * INSTALL now points to web documentation
2087 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * src/gdcmHeader.h doesn't make unnecessary reference to
2090 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2092 * src/gdcm*.[cxx|h] :
2093 - to allow compilation with gcc 3.x
2094 -- clean up of STL usage (added explicit usage of std::)
2095 -- small fixes on exceptions.
2096 Note: linking not tested !
2097 - clean of doxygen comments to avoid warnings at documentation
2099 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2100 dependent convertion).
2102 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2103 * Clean up of previous JPR garbage commit (not even commented in the
2105 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2106 - moved all jpeg related files from src to src/jpeg/libijg8, with
2107 addition/modification of Makefile.am and configure.in.
2108 - the testSuite is still brain damage (not guilty).
2110 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2111 * WrapVTK.py : modifications to get correctly vtk source files to
2113 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2114 (FileName -> Filename)
2116 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2117 * vtk/vtkGdcmReader.[cxx/h]:
2118 - UpdateProgress method should now be effective
2119 - removed the limitation on having only images loaded (as opposed
2121 - when building a stack of images/volume, a lesser number of
2122 gdcmHeader and gdcmFile instances should be used (hopefully
2123 accelerating things).
2124 - when building a stack of images/volumes, files which are not
2125 loadable (wrong path-filename, wrong permissions on existing file,
2126 or file not parsable by gdcm) are replaced with a black image
2127 in the stack (for the caller to notice the problem).
2129 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2130 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2132 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2133 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2134 between standard library (std) and vtk library (problems are found
2135 under Windows... thanks Windows !)
2137 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2140 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2142 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2145 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * When compiling with distutils (see setup.py) the C++ compiler is
2147 called with different flags than the default ones (with automake).
2148 In order to fix all those warning, I compiled gdcm with the command
2149 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2150 and went for warning fixes:
2151 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2152 up from unused variables.
2153 - vtk/vtkGdcmReader.cxx: potential bug fix.
2154 * src/gdcmHeader.h: Doxygen warning cleanup
2156 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * gdcmPython/gdcm.i:
2158 - typemaps correction to take into account the systematic replacement
2159 of "using namespace std" with std:: prefix e.g. std::list,
2160 std::string... (cf changes of 2003-05-21).
2161 - gdcmGlob global variable of type gdcmGlobal (defined in
2162 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2163 exported to Python a as cvar.
2164 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2165 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2166 gdcmDictSet.GetPubDictTagNames() and
2167 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2168 C++ static methods).
2169 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2170 with the above changes.
2172 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2173 * setup.py, manifest.in : bug fix under linux
2175 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2176 * Modification of setup.py to compile vtk part too. Then, we have 2
2177 wrappers which must work with same distutils. For that, we have a
2178 generic distutils in distusiltsWrapping.py ; with :
2179 - build_extWrap class to wrap generically all extensions,
2180 - ExtensionWrap base class for all wrapping extension that contains
2182 - Wrapper interface which wrap sources
2183 + In WrapSwig.py we have extension and wrapper for Swig
2184 + In WrapVTK.py we have extension and wrapper for VTK
2185 * MANIFEST.in : modifications to consider vtk directory and new python
2186 files for compilation
2188 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2189 * Added python wrappers of vtkGdcmReader vtk class (see the
2190 source in vtk/vtkGdcmReader.cxx) :
2191 - vtk/Makefile.am now builds a library
2192 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2193 python library (as opposed to _gdcm.so wich are the python
2194 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2195 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2197 - configure.in has an additional flag --enable-vtk that needs
2198 to be set to enable compilation of vtk related code, that is:
2199 + vtk/vtkGdcmReader.so and
2200 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2201 + gdcmPython/vtkgdcmPython.so (see above)
2202 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2203 be read when compressed or when HighBit + 1 != BitsStored),
2204 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2205 the usage of the python wrapper of vtkGdcmReader vtk class.
2206 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2207 * src/*.[h] all occurences of stl classes are now prefixed with
2208 std::, and all occurences of "using namespace std;" where removed.
2209 This is to avoid pollution of global namespace in included files.
2210 Apparently vtk does not avoid this pitfall: when using both
2211 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2212 collision of various stl members (principally cout...).
2213 * gdcmPython/testSuite.py now cleanly removes temprory generated
2215 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2216 comply with above changes)
2218 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2219 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2220 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2221 vtk data structure (an image Flip was required).
2222 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2223 * cosmetic changes in documentation.
2225 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2226 * src/gdcmHeader.cxx: the constructor no longer exits when an
2227 unexisting file is given as argument.
2228 * The subdirectory Data (containing all the images used for the
2229 test suite) is not part of this repository anymore. A new module
2230 containing those images is now available at
2231 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2232 with the name gdcmData.
2233 All the python scripts (including the package initialisation file
2234 gdcmPython/__init__.py) were adapated to take this change into
2235 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2237 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2238 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2239 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2240 demo of the usage of this class.
2241 Compilation of this vtk part is only done when using the --enable-vtk
2242 at configure (or autogen.sh) stage.
2244 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2245 * More memory link related corrections and documentation fixes.
2247 - maximum info is obtained with a command of the form:
2248 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2249 --show-reachable=yes PrintHeader
2250 - the remaining reachable blocks seem to come from the STL
2251 allocation scheme through the usage of map and list. It looks
2252 like this memory cannot be freed but it is not a memory leak
2253 (in fact further invocation to the STL would recollect the
2254 unused memory allthough it cannot explicitely be freed).
2255 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2256 of displaying an image parsed with gdcm and displayed with VTK.
2257 Note: some images don't seem to work e.g.
2258 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2259 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2260 Allthough this weakens the semantics, it is a ditch attempt to
2261 make gdcm more thread friendly.
2263 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2264 * Memory link hunt (by using valgrind through the command
2265 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2266 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2267 gdcmHeader::_dicom_vr.
2268 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2269 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2271 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2273 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2274 * src/Makefile.am now exports all the necessary include files at
2278 * UpdateGroupLength replaced by new one
2281 * UpdateGroupLength re-written using H-Table
2282 (named UpdateGroupLengthNew untill checks are over)
2284 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2285 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2286 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2288 - gdcmHeader::GetPubElValSet removed.
2289 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2290 UpdateGroupLength, WriteElements, Write.
2291 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2292 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2293 carried the same semantics.
2294 - src/gdcmHeaderIdo.cxx changed accordingly.
2295 - gdcmFile::WriteBase now regroups all the codes from previous
2296 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2297 - enum FileType moved to gdcmCommon.h
2298 * src/gdcmHeader.cxx AddDefault trashed
2299 * gdcmGetXSize added
2300 * getimageDataSize now calls gdcmGetXSize
2301 * Test/*.cxx changed to agree with above changes
2303 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2304 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2305 (to avoid double call by end user).
2306 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2307 by end user, since gdcmHeader::gdcmHeader now handles it.
2309 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2310 * gdcm/Doc many doxygen changes:
2311 - Doxyfile now has two different versions, DoxyfileUsers that generates
2312 the html.users end users oriented documentation and
2313 DoxyfileDeveloppers that generates the html.developper developper
2314 oriented documentation.
2315 - README changed accordingly
2316 - requirement.txt removed (old design info moved to TODO).
2317 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2318 DoxyMainPage.txt, DoxyPython.txt provide more information.
2319 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2320 be updated by simply regenerating the docs with doxygen and copying
2321 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2322 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2323 all the tests in the form "if (<map>.count() >1)" were removed.
2324 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2325 ill-formed documentation sections.
2326 * src/gdcmHeader.cxx: ditto
2328 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * setup.py fixed for un*x (needed macro for stdint.h)
2330 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2331 un*ces with sh-utils test utility.
2332 * gdcmPython/demo/test.py renamed to PrintHeader.py
2333 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2334 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2335 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2336 * src/gdcm*.cxx JPR's bad inclusion fixed.
2338 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2339 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2340 * gdcmPython/demo/test.py changed accordingly.
2342 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2343 * gdcmPython/Makefile.am fixed linking against libstdc++
2344 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2345 * Swig subdir (historical tests of swig version 1.3.17++) removed
2346 * Test/testChangeEntete.cxx some lines commented out in order to make
2348 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2349 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2351 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2353 hence the user doesn't need this explicit call.
2354 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2355 i.e. LoadElements() call removed.
2356 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2357 - src/Makefile.am declares the proper flag for g++.
2358 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2359 for adding user defined new tags.
2360 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2361 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2362 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2364 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2365 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2366 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2367 src/Makefile.am : the project should properly compile and install
2368 with the autotools, included the python wrappers part.
2369 * gdcm.spec.in : added a spec file for RPM packaging.
2371 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2372 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2374 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2376 to exported to the environement (see gdcmPython/testSuite.py
2378 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2379 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2380 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2381 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2382 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2384 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * gdcmPython/__init__.py doesn't crash anymore when running in
2386 in InstallMode or PreInstallMode but with an environement given
2387 value of GDCM_DICT_PATH.
2388 * src/gdcmDictSet.[cxx/h] coding style.
2390 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2392 * src/gdcm.h general comments moved to TODO, and README
2393 * src/gdcm.h should now be seen as a user commodity (including it
2394 should suffice to fully use gdcm). It is nowhere including within
2395 any of the kernel files src/*.cxx and src/*.h.
2397 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2398 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2399 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2401 * src/gdcm*.cxx only include their corresponding include file
2402 (as opposed to gdcm.h)
2403 * gdcmPython/gdcm.i changed accordingly
2404 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2405 the autogen.sh generated "make snapshot" command to work.
2406 * autogen.sh removed history related references to crea package.
2408 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * distutilsSwigCPlusPlus.py work around some swig portability
2412 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2414 was done in a last ditch attempt to get setup.py _really_
2415 operationnal. The python/gdcmPython layaout add the advantage
2416 of hidding away the python related distutils specific files
2417 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2418 Alas, the src directory was out of scope (i.e. it's relative
2419 position to setup.py was ../src) which made things impossible to
2420 handle (see previous version of python/setup.py). Crossing fingers...
2422 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2423 * python/setup.py now works on Un*x. (harder than I thougth)
2424 * python/distutilsSwigCPlusPlus.py can now have include files
2425 among the list of sources.
2427 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2428 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2429 * modifications in MSVC projects
2431 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * As stated by the first lines of Test/ExceptionAndPython/README, it
2433 looks like we can move back to original usage of exception within
2434 src/gdcm* and hence remove the errno stuff that was introduced
2435 as a quick and dirty fixture of this problem (added to the TODO).
2436 * Doc/Doxyfile configuration file for Doxygen and corresponding
2437 README file for usage added.
2438 * Test/testWrite.cxx added. This new test comes from a split of
2439 test.cxx that is now reverted to its original purpous i.e.
2440 testing the proper parsing of a Dicom related file.
2441 testWrite.cxx concentrates on testing the IO part of gdcm.
2442 * Test/bug1.cxx (containing a bug on WIn32) added.
2443 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2444 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2445 whose purpose is to publish the content of the TagNames of the
2446 Dicom public dictionnary were not accessible without an
2447 instance of class gdcmHeader.
2448 - those methods are now static methods of gdcmDictSet and hence
2449 require no instances at all to be invocated.
2450 - within gdcmDictSet this change required to change some method
2451 to class methods (i.e. are now static) among which SetDictPath
2452 (renamed to BuildDictPath) and LoadDefaultPubDict.
2453 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2454 the above changes by calling the new method classes of gdcmDictSet.
2455 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2456 the above to be effective.
2457 * python/gdcmPython: in order to wrap properly the above changes
2458 for Python, swig version now needs to be > 1.3.17.
2459 * python/gdcmPython/Makefile fixed to adapt itself to new
2460 configure/make shema introduced by Johan Montagnat (thanks for the
2461 contribution). Alas this Makefile cannot be turned into a proper
2462 Makefile.am without some heavy changes in the configure.in
2463 (for python dectection).
2464 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2465 now avoids publishing the empty entries.
2467 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2468 * python/setup.py : bug fix concerning install under windows
2469 ExtraPath reused :-P
2470 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2472 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2473 * Dicts/dicomV3.dic : remove double spaces !!!
2474 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2475 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2478 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2480 method. Doxygenation.
2481 * src/gdcm.h clean up of JPR spurious comments.
2483 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * python/distutilsSwigCPlusPlus.py now properly collects the
2485 shadow classes generated by "swig -c++" (gdcm.py in our case)
2486 when using "python setup.py install".
2487 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2488 reexports the working classes.
2489 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2490 by the classical C errno scheme. This is to prevent an obscure
2491 behavior of the python wrappers when importing wxPython.wx prior
2492 to gdcmPython (which ended up in an abort call). An illustration
2493 of this oddity can be found in the Test/ExceptionAndPython
2494 subdir (see the README file). This problem probably due to
2495 an combination of g++ and dynamic loading.
2496 * added Test/ExceptionAndPython (see above)
2498 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * Changed the layout of the python part to avoid bloating main
2500 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2501 i.e. the distutils arsenal. All the python related stuff is
2502 again in a python subdir, but the package itself is now in
2504 * setup.py was cleaned up:
2505 - pythonIncludePath removed
2506 - python setup.py bdist target is now functional.
2507 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2508 collision with other packages). gdcmPython/demo/*.py changed
2511 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * python subdir moved to gdcmPython (preparation of distutils packaging).
2513 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2514 distutils installer is operational.
2515 * - gdcmPython/__init__.py now properly loads the swig generated
2516 shadow classes (from gdcm.py).
2517 - gdcmPython/demo/*.py changed to import the package gdcmPython
2518 instead of gdcmPython/demo/load.py.
2519 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2521 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2523 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2524 entries within the associated public Dicom dictionary resp. the same
2525 information but sorted by the fourth field (PAT, IMG, DIR) of the
2527 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2528 are now in the "???" group.
2529 - python/gdcm.i changed accordingly,
2530 - python/demo/printGroupedPublicDict.py added, that gives an example
2531 of the above new functionalities in Python.
2533 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * src/gdcm.h, gdcmHeader.cxx:
2535 - historic references to glib's g_malloc and g_free (#defined)
2536 were definitively removed.
2537 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2538 * src/gdcmElValSet.cxx:
2539 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2540 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2541 - GetElValue(string) renamed to GetElValueByName.
2542 - Added GetElementByName(string).
2543 * src/gdcmHeader.cxx: added
2544 - GetPubElValRepByNumber(guint16, guint16)
2545 - GetPubElValRepByName(string)
2546 - GetShaElValRepByNumber(guint16, guint16)
2547 - GetShaElValRepByName(string)
2548 - GetShaElValByNumber(guint16, guint16)
2549 - GetShaElValRepByName(string)
2550 - GetElValRepByNumber(guint16, guint16)
2551 - GetElValRepByName(string)
2552 - GetElValByNumber(guint16, guint16)
2553 - GetElValRepByName(string)
2554 * Doc/requirements.txt added.
2556 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * Test/Makefile building now depends on the one of libgdcm.so
2558 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2559 pixel data) aware which enables finding the address (offset) of
2560 the pixel data of JPEG encoded DICOM files. This leaves only a single
2561 file in the testSuite whose pixel data address (offset) is unknown.
2562 * python/testSuite.py changed accordingly.
2564 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2565 * VC++ has some strong limitations when working with the STL, as stated
2566 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2567 "Also note that some STL containers (map, set, queue, list, deque)
2568 cannot be exported. [...]
2569 Some STL classes contain nested classes. These classes can not
2571 This is caused by a designed limitation that once a template
2572 class is instantiated, it can not be re-instantiated and
2574 Since our usage of map<> is ubiquitous in gdcm, this "designed
2575 limitation" of VC++ is a pitfall.
2576 Hence the Python wrappers of gdcm cannot be incrementally linked
2577 against the c++ dynamic library. The dirty but only workaround is
2578 to forget about incremental link of dynamic libraries and to generate
2579 the Python wrappers library with the inclusions of the underlying C++
2581 The following modifications concern this matter on Win32/VC++:
2582 - wrapping python correct with standalone wrapped dll (don't use separate
2583 dll under windows !!!!)
2584 - python21_d debug mode enabled (ask Frog how to use it :-)
2585 - NO problem with having an STL member of class for example string in C++
2586 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2587 - Python test of dcmlib in Python is ok under windows on a large set
2589 * removed glib references
2590 * typedef's inserted in gdcm.i for correct swig type management
2592 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * python/demo/*.py load.py extracted from test.py. Added explore.py
2594 that only displays required tags and testAll.py that parses all
2595 the files of the testsuite without using unittest.
2596 * python/testSuite.py other additional test on new files added.
2597 * Data/* new test files added accordingly to the testSuite.
2598 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2599 the vr in the file differs from the one of the dictionary.
2601 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2603 values, but limits itself to values which are below a user specified
2604 size (by default 1024 bytes).
2605 * python/gdcm.i : elements not loaded (because their size is above the
2606 user specified treshold) are exported with their TagKey as key of the
2607 python dictionary. This enables the testsuite to make some checks
2608 on the unloaded elements (since we have their offset and size).
2609 * python/testSuite.py
2610 - now tests for the existence and proper value of the pixel data
2611 - two new examples added.
2612 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2614 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2616 aware. See the strategy comments in gdcmHeader::FindeLength().
2617 * Test/test.cxx now accepts a filename as first argument.
2618 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2619 * python/testSuite.py changed to integrate test on above files.
2621 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2622 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2623 the vr was also RET.
2624 * python/testSuite.py more tests added.
2626 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2627 * python/testSuite.py unittest test suite added (uses Data)
2628 * Data/* dcm and acr files for the test suite.
2629 * glib dependance removed from un*x version. We now use ISO C99
2630 7.18 Integer types (see stdint.h)
2631 - python/Makefile, src/Makefile src/gdcm.h
2632 * src/ when an explicit vr (like dicom files) suddenly poped an
2633 implicit element we use to mark the underlying DictEntry of the
2634 concerned ElValue with "Implicit". This strategy was damageable
2635 too the public or provite dictionaries, since some of their vr
2636 would be changed. Since Header::FindLength heavily relies on the
2637 detection by Header::FindVR of falsely explicit elements, I
2638 added an extra ImplicitVr member to ElValue (boolean).
2639 The rest of the changes we the necessary adaptations.
2641 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2644 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2646 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2647 * Adaptation for porting to VC++:
2649 o forced to use std namespace (for string to be known)
2650 o all class use __declspec export style on WIN32
2651 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2652 (in stdlib.h on Win32 but in std:: for gcc)
2653 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2654 variable GDCM_DICT_PATH.
2655 * src/gdcmHeader.cxx verbose comments made discrete.
2657 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2658 * python/gdcm.i: added a typemap that converts a C++ hashing table
2659 to native Python dictionary.
2660 * python/demo/test.py:
2661 - now uses the native dictionary for exploration of gdcmHeader.
2662 - takes an optional filename argument (the file to parse).
2663 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2664 PubElVals hashing table.
2665 * Dicts/dicomV3.dic removed error prone trailing spaces.
2667 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2668 * Python wrapping process moved away from src/Makefile to
2669 newly created python/Makefile (as well as gdcm.i)
2670 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2671 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2672 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2673 from the environement variable GDCM_DICT_PATH (when existing).
2674 * src/gdcmDict::GetTag bug fix.
2676 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2677 * Straightforward temporary fixes for swig to build the python wrappers.
2678 src/Makefile now has a python working entry [by working we mean
2679 that we can import de shadow classes without errors].
2681 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2682 * hashtest.cxx removed (since allready in Test)
2683 * src/gdcmlib.h renamed to src/gdcm.h
2684 * src/dcm.i renamed to src/gdcm.i
2685 * src/Makefile prepared for python wrapping
2687 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * src/gdcmHeader.cxx :
2689 - Parsing of header is now separated from loading of element values
2690 (see gdcmHeader::LoadElements).
2691 - general clean up of hopefully all file access (creation of
2692 ReadInt16 and ReadInt32)
2694 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * src/gdcmHeader.cxx :
2696 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2698 - SetLgrElem renamed to SetLength
2699 - GetLgrElem renamed to GetLength
2700 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2701 * src/gdcmElValSet.cxx fixed both GetElValue methods
2702 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2703 due to IdoDude was cleaned out.
2705 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2706 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2707 concentrates on finding the value representation (when it exists).
2708 RecupLgr now only finds the element value length, and it avoids
2709 returning the unecessary skL (skipped length).
2710 Also, offsetCourant was simply removed (with taille_fich) since
2711 it was redundant with the File position internals (by using
2712 ftell and fseek). This also made skL (see above in RecupLgr) usage
2714 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2715 on the libido specificities which are handled through class
2717 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2720 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2721 * Truckload of changes. Parsing of header is barely functional
2722 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2724 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * src/gdcmHeader.cxx many addons of low level methods
2727 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2729 and _IdDcmSWAP_LONG.
2731 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2732 * This corresponds to all the changes decided at the meeting of
2733 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob