1 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
3 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
5 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
7 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
8 * src/gdcmDocEntry.cxx : amelioration of print
10 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
11 * ADD : Add the method Util::IsCurrentProcessorBigEndian
12 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
13 * ADD Method Document::ComputeGroupLength
14 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
15 in order to allow further VR modification by user
16 * REM : removal of once-called method File::WriteBase
17 integration of its code in formerly one-line method File::Write
19 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
21 replace the different values "??", "Unkn", "Unknown".
22 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
23 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
24 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
25 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
27 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
30 * Set the gdcm::Base class to some Printable classes
32 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * src/gdcmFile.[h|cxx] : add the Print method
34 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
35 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
36 * src/gdcmDocument.h : remove the PrintLevel informations
37 * Example/PrintFile.cxx : use the new gdcm::File::Print
39 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
40 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
41 problems when compiling with the python wrapping
43 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
45 writting in ImplicitVR
47 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
48 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
49 JPEG decompression, especially when dicom frames are split into several
50 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
51 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
53 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
54 * src/gdcmHeader.cxx : change the initialisation of default header.
55 Now, this header is readable by gdm, e-film, DicomWorks
57 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
59 Rename Decompressed to Raw
60 * Use the API changes in gdcm::File.
61 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
64 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
66 each added entry in the header. Replace the 'Planes' field by the 'Number
69 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
71 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
73 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
75 At this time, this image isn't readable by e-film... waiting JPR help to
78 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
79 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
80 DocEntry. Now use methods of the Document !
82 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Test/ShowDicomSeq.cxx : bug fix
85 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
87 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
88 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
89 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
91 * Test/TestCopyRescaleDicom.cxx : remove unused variable
92 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
93 containing found sequences
95 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
98 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
99 Some fields in BinEntry must be copied to not seg fault when making the :
100 gdcm::File *copy = new gdcm::File( copyH );
101 and tests are now made on good variables
103 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
104 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
105 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
107 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
108 * Add vtkGdcmWriter example and test
110 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * Test/TestUtil.cxx : reformat the source code
112 * vtk/vtkGdcmReader.cxx : remove and change prints
113 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
115 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
116 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
118 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
120 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
122 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
124 by an eof to prevent all bad read of the file... and in this case, the
127 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * Example/Volume2Dicom.cxx : comment unused variables
129 * Test/PrintDicomDir.cxx : comment unused variables
130 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
131 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
132 method that is redondant with AddEntry.
133 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
136 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
137 * Bug fix due my last commit (compilation under Windows).
138 * Example/Volume2Dicom : bug fix in the file and reformatting source code
139 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
141 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
143 - Remove printf / sprintf
144 - include iostream AFTER gdcm so we don't get warnings
145 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
147 - Also remove tons of include from header files, hopefully this should
148 speeup the compilation time, since it was becoming a dog slow.
149 - Remove gdcm.h as it include way too many files and slow down compilation
150 (plus it is not up to date)
151 - remove 'using namespace std' this is BAD !
153 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * Remove memory leaks on the DicomDir
155 * Remove some useless datas in DicomDirObject
156 * Add usefull methods in SQItem, to be complient withe the ElementSet
158 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
161 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
163 future, with convertion)
164 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
165 and ImageDataSize values. Remove the method to get the PixelReadConverter
166 from the output of the class
168 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
171 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
173 and vtkErrorMacro use.
174 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
176 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
177 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
179 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
180 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
181 The string leaves only in the fonction. So when we make a .c_str(), we
182 get the pointeur on the first element, element that will be destroyed
183 immediately after thee instruction.
184 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
185 file has been opened : the test must be made on the content of the
186 pointer and not directly on the pointer !
189 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
191 the python part recompiles
193 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
195 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
196 X session is killed (for my computer... it seems to not be identic on
199 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
201 avoid problems (otherwise, the difference test between the visible image
202 and the reference is incorrect. If the reference is greater than the
203 screen resolution, it's produce errors).
204 Can be used for only one image. Can be used with a visible flag.
205 * vtk/vtkGdcmReader.cxx : remove commented codes.
206 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
207 under windows at compilation
208 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
210 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
212 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
214 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
215 tests on the image size X, Y, Z
217 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
219 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
220 between the class name and the file name
222 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/ : fix compilation warnings for the Write method (2 different
224 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
225 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
226 variable... create a static method in gdcm::Document to access to
227 this variable content.
229 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
230 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
231 file, to be accessed by other files (like gdcmFile). Remove commented
232 code. Move the change of the header to the gdcmFile, using the
234 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
235 To be sure of that (and simplify calls), the Write of the header now
236 gets a file name and not a file pointer (std::ifstream).
237 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
238 DocEntryArchive. Remove all open of the written file
240 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
243 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
245 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
247 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
248 some corresponding methods. Write correctly the file and check before
250 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
251 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
252 is now on RGB datas (as before my last commit
253 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
255 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
256 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
257 Add a print information of the type of the entry
258 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
259 It was in the gdcmFile, and all write have been regrouped
260 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
261 Write correctly all dicom files (in decompressed mode only at this time)
262 * Test/ : test on files are now made using Raw datas and not color datas if
264 * Example/PrintFile.cxx : add more printings
266 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * Amelioration of code, remove some code copy. For the loading of
268 BinEntry (in gdcmDocument), add the test to verify if the file is already
271 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
273 remove a DocEntry in the header (push an empty DocEntry)
274 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
275 lines. Bug fix in the initialization of the PixelConvert and the
277 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
278 use in TestCopyDicom (now this test can run under windows... but fails)
279 * Test/TestCopyDicom.cxx : amelioration of the test :
280 - test the pixels written
281 - add test points to quickly find where is the error
282 - can set a file name input and output in arguments
283 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
284 amelioration of the test output
286 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
288 all replaced DocEntry's
289 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
290 Now, each needed DocEntry to modify is duplicated, modified and inserted
291 to the header using DocEntryArchive. Thus, after save, we can restore the
292 header initial state.
294 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
295 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
297 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
298 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
299 correct to copy it. The DictEntry is specified at the DocEntry creation,
300 then, it musn't change in the time.
301 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
302 header correctly. At this time, the change is only made for the first
303 level of the Document. In the future, it might consider sequences.
304 The change is made by replacing a DocEntry by an other that is created
305 outside the class. The old value is kept. When we restore the header
306 status, the added DocEntry is deleted and replaced by the old value.
307 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
308 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
309 set the write type to explicit VR, implicit VR or ACR. Add methods to set
310 the write mode to native, decompressed or RGB (but not used at this time)
312 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
313 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
314 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
316 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
318 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
320 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
321 set because already copied when copying the BinEntry's of the header
322 * Test/TestAllReadCompareDicom.cxx : remove warnings
324 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
325 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
326 Two problems appear when doing it :
327 - with the gdcmFile : when the GetImageData method is called, the pixels
328 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
329 datas (pixels). And each structure destruct the datas when it's
330 destructed. So we have two destructions for the same datas. To solve it,
331 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
332 datas or not. If it doesn't own datas, then they will not destroyed by
334 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
335 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
336 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
337 create a double destruction of the same DocEntry's. So, to solve it,
338 the TagHT is simply cleared and the DicomDir* elements are destroyed.
339 * TODO : add an entry concerning memory leaks in the DicomDir
341 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
343 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
346 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
347 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
348 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
349 after it have been deleted
351 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * FIX: src/* fix the doxygen warnings.
353 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
354 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
355 was erroneously defined with a size of 15 instead of 16. [many thanks
356 to Jean Michel Rouet for pointing out this bug].
358 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 1. Finish merging JMR patch for writting DICOM from scratch
360 2. Fix -hopefully- bug with MONOCHROME and space vs null character
361 3. Use const ref when possible
362 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
363 5. A few more comments
364 6. CreateUniqueUID can now be called without parameter"
366 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
367 * ENH: Slightly bigger patch:
368 1. Getting toward full integration of JMR patch for writting dicom from scratch
369 2. Update Test to test part of this patch: CreateUniqueUID
370 3. File was not close properly in gdcmDict
371 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
372 5. Use of const ref instead of copy (speed issue)
373 6. Remove temporary (duplicate) string in TranslateToKey
374 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
375 8. Do not repeat virtual in subclasses
376 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
378 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Apply first patch toward better string comparison when dealing with broken
380 DICOM files. Essentially the string could be padded with a space instead
381 of a null character as defined by standard
383 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
384 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
385 because never used... and in the same time, that's remove some memory leaks
387 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmFile.cxx : now delete the PixelConvert instance.
389 * In examples and tests : change the type of image data variables from void*
390 to uint8_t*. Remmove all delete on image data variables
392 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
393 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
394 Verify the file pointer value before open the file, and if it's not null,
395 a verbose message is generated.
396 Close correctly the file when the file isn't considered dicom-like. The
397 correctly close is a call to CloseFile.
398 When closing the file pointer, test if its not null to close the file.
399 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
400 file. For an uncompressed image, the copied datas correspond in the least
401 case to the image size (calculated) or the image size specified in the
402 header. A verbose is generated if these two size mismatch
404 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
405 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
406 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
407 break under windows (with msvc6 compilation).
409 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
410 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
411 compiling with MSVC6)
413 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * Bugs fix for the Windows build with VC6
415 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
416 needed (only for projects required VTK). If the VTK is included in all
417 projects, there is conflicts with the jpeg lib of vtk when compiling the
418 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
419 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
420 when compiling the gdcm_wrap.cxx file (created by the compilation of the
422 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
423 (like it's already made for the cout use). Otherwise, conflict with the
426 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
427 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
429 - comments on the DicomDir::Method related usage added.
430 - now that we use the namespace gdcm, a lot of internal classes do
431 NOT need to be wrapped anymore.
432 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
433 DicomDir::Method) new example added.
435 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
436 * Improve string manipulation. I now inforce the notion of 'DicomString'
437 A DicomString can contain as many \0 as they want
438 and it is *always* of even length.
439 We only support odd length for very rare case.
440 And in the near future this should be removed.
442 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
443 * /binary_write/ gdcm source. Now even on big endian we are writting
444 little endian. This should -heopfully- fix some tests
446 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * Now the dictionary is compiled into gdcm lib. This is a default
448 behavior, thus any dic file specified is picked before failback to
449 the one comiled into lib
451 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 * Change internals for gdcmDict. Don't use any 'new' any more.
453 This should definitely solve any leak problem, and we should be
454 as fast as before, as long as don't modify too much the dictionary.
456 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
457 * STYLE: ivars should start with a capital letter.
458 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
459 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
461 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
463 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
464 new 2004 dictionaries added (thanks to JPR).
465 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
466 * CLEANUP_ROUND (15) for gdcmPixelConvert
467 - RLEFrame::NumberFragments is now of type unsigned int
468 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
469 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
472 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * Initial work in gathering all transfer syntax accessors. clearly
474 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
475 ivars, but only one transfersyntax (class) ivar with equivalent method on
478 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
479 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
480 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
481 discussed (plus I didn't like having a 2000 lines patch not commited)
483 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
484 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
485 * CLEANUP_ROUND (14) for gdcmPixelConvert
486 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
487 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
488 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
490 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
491 anymore and hence avoids storing a copy of PixelConvert::Decompressed
492 into File::Pixel_Data.
494 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
495 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
496 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
497 * CLEANUP_ROUND (13) for gdcmPixelConvert
498 Substituted File::ParsePixelData() with PixelConvert::Print() new
500 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
501 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
502 method to those classes.
503 - src/gdcmFile.[cxx|h]:
504 -- Added a ::Print() method.
505 -- PixelConverter is now a reference instead of a member.
506 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
507 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
509 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
510 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
511 collaboration diagram and inheritance diagram should be generated with
513 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
514 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
515 pointlessly wrapped (see
516 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
517 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
518 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
519 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
520 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
521 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
522 -- File::Initialise: PixelConverter setup moved away to
523 PixelConverter::GrabInformationsFromHeader()
524 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
525 interpretation moved away to PixelConverter::BuildRGBImage()
527 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
528 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
529 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
531 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
532 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
533 displayed on Win32 when a brutal abort() occurs (because of uncatched
534 exception). See TODO new entry of this commit for more on this.
535 * TODO added new entry.
536 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
537 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
538 - HandleColor is no longer called from gdcmFile.cxx
539 - gdcmPixelConvert.cxx clean up on method arguments and internal
540 variable names for semantical coherence.
542 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
543 * Finished lossless transition, not only do we now read all lossless jpeg
544 images, without the need of the Cornwell lib, but we do read them properly now
545 * To reduce code (well to avoid code duplication), I defined a common place
546 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
547 redefine symbols. This is not prefect but this the best solution I found for a
548 compilation time jpeg option.
550 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
551 * Update jpeg ijg lib to support lossless jpeg implementation
552 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
554 * Also added a special copyright for dcmtk since we use their bugfixes.
557 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
559 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
560 matters, as stated in warning note at begining of %include section).
561 * src/gdcmDicomDir*.[cxx|h]: coding style
562 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
563 * src/gdcmJpeg8.cxx: doxygen fix.
564 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
565 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
566 from File:: to PixelConvert::.
568 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
569 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
570 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
571 - more code moved away from File:: to PixelConvert::
572 - fat setup of PixelConverter set in place in File::Initialise.
574 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
575 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
576 namespace at the file system level. So now you should convert your examples
578 gdcmHeader -> gdcm::Header
579 It would be nice if people keep in mind to no open the namespace, since it
580 allows compilation on broken plateform which were defining common symbol in
581 the standart namespace (like LP, Unknown ...)
583 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
584 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
585 The JPEG fragments are now parsed at the same stage than the RLE
586 information. All code related to JPEG is now in gdcmPixelConvert:
587 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
588 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
589 export a gdcmFile:: method. Those are simply global functions
590 (for the time being this is better than having them attach to
591 either gdcmFile:: or gdcmPixelConvert::).
592 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
593 and stores the result in a gdcmJPEGFragmentsInfo.
594 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
595 code (among other stuff) moved away from gdcmFile:; to
598 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
599 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
600 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
601 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
602 clean up of RLE related code.
603 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
604 - src/gdcmRLE.cxx removed
605 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
606 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
607 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
608 * CLEANUP_ROUND (9) for gdcmPixelConvert
609 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
610 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
611 away from gdcmFile:: to gdcmPixelConvert::.
613 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
614 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
615 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
616 This is because Parse7Fe0 used to parse the pixels to compute the
617 length. This task was passed over to FindDocEntryLengthOB() a long
618 time ago, EXCEPT I had forgotten the OW case...
619 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
620 we just recylce the code for parsing RLE fragments and computing
622 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
623 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
624 with the retired Parse7Fe0().
625 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
626 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
628 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
630 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
631 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
632 - src/CMakeLists.txt: alphabetic order reodering + new entries.
633 * CLEANUP_ROUND (4) for gdcmPixelConvert
634 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
635 to return an unused length.
637 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
638 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
639 this should be cleanner from the plane view. The iostream are erally a pain
640 to use to do simple stuff.
642 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
643 * Redo the compilation of the ijg jpeg library. Now only one source is
644 necesseray. No need to rename file by hand what so ever. CMake handle the
645 copying of the file within different directory, configure header file to
646 modify some symbol. The only addition made to ijg wasd a mangle table so
647 that symbol are different wether we are within 8bits or 12bits.
649 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * Added documentation of vtkgdcmReader on Website:
651 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
652 with it's binary name).
653 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
654 the Website to be more complete.
655 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
656 doxygenated documentation.
657 - Doc/DoxyVtkGdcmReaderExamples.txt added
658 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
659 DoxyVtkGdmReaderExamples.html )
660 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
661 * CLEANUP_ROUND (3) for gdcmPixelConvert
662 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
664 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
665 * CLEANUP_ROUND (2) for gdcmPixelConvert
666 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
668 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * CLEANUP_ROUND for gdcmPixelConvert:
670 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
671 - src/gdcmPixelStuff[h|cxx] removed
672 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
673 - src/CMakeLists.txt changed accordingly
675 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
676 gdcmVersion.py moved to newly created ATTIC related
677 gdcmPython/SetupOldies/ directory.
678 * Autotools clean up:
679 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
680 - autogen.sh configure.in acinclude.m4 python.m4 removed
682 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * src/*.cxx *.h Reference to License.htm fixed to License.html.
684 * Doc/CMakeLists.txt, doxygen.config.in: fix.
685 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
687 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * TODO updated with Mathieu suggestions. I proposed a template for
689 describing TODO entries and used it for new entries.
690 * Added Doc/Website/CodingStyle.html, Developpers.html,
691 DeveloppersPython.html, GdcmDataCvs.html and
692 DownloadVersion0_1.html, DownloadVersion0_3.html.
693 * Some Doc/*.txt Doxygen files (which do not really concern the
694 documentation itself, but the website) moved to html and
695 placed in directory Doc/Website:
696 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
697 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
698 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
699 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
700 * CMakeLists.txt changed accordingly.
701 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
702 DeveloppersPython.html
703 * INSTALL nows refers to Doc/Website/Installation.html
705 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
706 * Added Doc/Website directory, that contains a first raw version
709 2004-09-23 Jean-Pierre Roux
710 * FIX In order not to be poluted any longer by casting problems,
711 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
712 we can now delete[] it safely
713 * VoidArea is now called BinArea (less confusing name),
714 and all the methods called ...VoidArea... are now ... BinArea...
715 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
717 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
719 clear) TagHT, which is an inherited member of gdcmElementSet. It is
720 up to the destructor of gdcmElementSet to clean up TagHt and it's
723 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * Test/CMakeLists.txt: update to follow gdcmData renamings.
725 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
727 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * ENH: added some utility method that builds a flat dictionnary
729 holding all the Dicom entries contained in the recursive structure
730 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
732 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
733 BuildFlatHashTable() that build a flat dictionary.
734 - src/gdcmElementSet.h: added a new private GetTag() accessor.
735 gdcmDocument is now a friend of gdcmElementSet.
736 - src/gdcmElementSet.cxx: clean up.
737 - Example/FlatHashTablePrint.cxx added.
738 - Example/CmakeLists.txt changed accordingly
740 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
742 moved away from gdcmDocEntrySet (since this class is an abstract class
743 acting like an interface). SQDepthLevel and BaseTagKey are now
745 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
746 and associated accessors. Doxygenation of the class.
747 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
749 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
750 Use SQDepthLevel accessor instead. ::Print() adapted.
751 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
752 - src/gdcmDocument.cxx changed accordingly.
754 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
756 - The following is the doxygen comment of the typedef declaration
757 of gdcmagKey in src/gdcmCommon.h:
758 gdcmTagKey is made to old an "universal" (as in URL, Universal
759 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
760 A dicom tag allways has a group and an element, but a set of tags
761 embeded in various (optionally nested) sequences and sharing
762 the same group and element all share the same (group, element)
763 "identifier". Hence the (group, element) cannot be used as an
764 identifier (in gdcm we shall refer to a "TagKey") of a tag.
765 In order to construct a proper tag identifier (i.e. a key) we
766 consider the following definition of a TagKey:
767 - let Group, Element be the string representation of the
768 group and element dicom tag members,
769 - let ItemNumber be the string representation of the integer
770 index of the considered item number of a sequence,
771 Let the key of a tag embeded in a sequence, noted SeqTag, be
773 /ItemNumber#Group|Element
774 where "/", "#" and "|" are characters acting as separators.
775 Then the general form of a gdcmTagKey is given by:
776 Group|Element<SeqTag>
777 where <SeqTag> means NO or many instances of SeqTag.
778 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
781 but the gdcmTagKey of a tag "embeded" is the first item of
782 a sequence, itself nested in the third item of a sequence is the
784 0004|1220/2#0008|0082/0#0008|0090
785 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
786 order to hold the new sequence compatible key. Previously, the
787 GetKey() method would look in the underlying gdcmDictEntry.
788 - src/gdcmDocEntry.cxx:
789 -- constructor now copies the underlying DictEntry key, in the local
791 -- ::Print: displays the member Key, instead of the (group, element).
792 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
793 - src/gdcmDocEntrySet.h:xi
794 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
795 -- now has a new BaseTagKey member.
797 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
798 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
800 This poses the problem with the semantics of the following lines
801 LoadEntryVoidArea(0x0028,0x1201); // R LUT
802 LoadEntryVoidArea(0x0028,0x1202); // G LUT
803 LoadEntryVoidArea(0x0028,0x1203); // B LUT
804 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
805 to the long FIXME note for what the problem is. Nevertheless in
806 order to get things working the dicom dictionary was altered !
807 Please fix things urgently...
808 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
809 information), see above note on moving the member VoidArea. Nevertheless
810 the following entries previously correctly set as US are now inproperly
812 0028 1201 OW IMG Red Palette Color Lookup Table Data
813 0028 1202 OW IMG Green Palette Color Lookup Table Data
814 0028 1203 OW IMG Blue Palette Color Lookup Table Data
815 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
816 of gdcmDocEntry moved to gdcmSeqEntry.
817 * src/gdcmSeqEntry.cxx: STYLE.
819 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * Test/TestAllEntryVerify.cxx minor fix and added comments.
822 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * gdcmPython/testSuite.py: all the test suite in python is now moved
824 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
825 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
826 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
828 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
829 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
830 to avoid inclusion recursion until STL is reached.
831 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
832 mecanism. errno.h is not included in gdcm anymore.
833 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
834 (gdcmFormatError now inherits from gdcmFormatUnexpected).
836 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
837 gdcmData/TestAllEntryVerifyReference.txt
838 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
839 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
840 exception_on_error parameter.
841 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
842 - vtk/vtkGdcmReader.cxx changed accordingly,
843 - Example/*.cxx and Test/*.cxx changed accordingly.
845 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
846 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
847 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
848 enable_sequences removed from gdcmHeader constructor and dependencies.
849 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
850 * gdcmPython/demo/PrintHeader.py: dummy fix.
851 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
852 skip_shadow removed from gdcmHeader constructor and dependencies.
853 * Example/*.cxx and Test/*.cxx changed accordingly.
855 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
857 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
859 2004-07-21 Jean-Pierre Roux
860 * FIX Now, Parsing and Printing a DICOMDIR do work!
861 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
863 2004-07-20 Jean-Pierre Roux
864 * FIX Some brain damaged headers have Zero-Lenght fields
865 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
867 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
868 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
869 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
870 variable (instance of gdcmDebug) by a definition macro, and the instance
871 is now in static in the gdcmDebug class
872 * src/gdcmSQItem.h : (FIXME) remove an undefined method
873 * Test/PrintAllDocument.cxx : bug fix in the result of the test
875 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
876 * WARNING: ctest now depends more tightly on gdcmData. You should
877 check out gdcmData properly for things to run smoothly...
878 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
879 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
880 we need the pixels not be loaded in order to use the ValEntry
881 that displays position and size).
882 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
883 This is a C++ based equivalent of gdcmPython/testSuite.py that should
884 be deprecated. If you have any doubts about the advantages of a
885 modern scripting language (read Python) versus grass root C++ (i.e.
886 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
887 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
888 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
889 Anyhow, consider documenting the gdcmData images in
890 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
892 * Test/CMakeLists.txt:
893 - now uses TestAllEntryVerify.cxx
894 - specific comments on oldACR00001.ima (now renamed in gdcmData
895 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
896 gdcmData/TestAllEntryVerifyReference.txt
899 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * src/*.[h|cxx] : typedef clean up
901 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
902 - TagKey renamed to gdcmTagKey (for external usage)
903 - VRKey renamed to gdcmVRKey (for external usage)
904 - removal of typedef duplication.
905 - Removed all unecessary inline keyword from class inline definitions.
906 - Some method|function(void) declarations replaced with method|function().
907 * src/jpeg/libijg12/jdhuff12.c:
908 - printf polluting ctest removed.
909 - TAB removal for comminting
911 - TestAllReadCompareDicom.cxx: added a test that compares all the
912 images in gdcmDataImages.h with corresponding images in
913 gdcmData/BaselineDicom/. When baseline images are not present
914 this test creates them.
915 Note: we need to validate each reference image, but before that
916 I'd like to rename them with a more explicit name...
917 - CMakeLists.txt: changed accordingly.
918 * Example/*.cxx: examples now only include gdcm.h (as opposed to
919 including each header needed).
921 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
922 * Test/*.cxx and Example/*.cxx: moved some examples away from the
923 test suite to the Example directory. Are concerned:
928 - TestWriteSimple.cxx
929 * Test/CMakeLists.txt: added some comments on reasons for black listing
930 image gdcmData/oldACR00001.ima
932 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
933 * Test/CmakeList.txt: removed the following from black list (to be coherent
934 with removal from gdcmData):
935 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
936 - gdcm-MR-PHILIPS-16.dcm
938 Added the following because after last cvs update, they cause
939 ctest -R TestReadWriteReadCompare
941 - gdcm-MR-SIEMENS-16-1.acr
943 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
944 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
945 new comments in this file) we temporarily (sigh) move to a weaker
947 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
948 we don't need to black list the following images anymore:
949 - 8BitsUncompressedColor.dcm
951 - US-PAL-8-10x-echo.dcm
952 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
953 fixes and the beautified code ;-)
954 This fixes the bug introduced in version 1.42 (when beautifying)
955 that made the parsing of 8BitsRunLengthColor.dcm unproper.
956 Note: ctest was blind to this bug (this means we need to still
957 improve the test suite). The bug could be detected by using
958 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
960 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
961 and by displaying the (garbage) produced file temp.XDCM...
963 2004-06-29 Jean-Pierre Roux
964 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
965 - replace by uggly but working old code :-(
966 A lot of things should be OK again.
967 It's really urgent to have a test suite that *tests*,
968 to prevent Frog's beautifying sessions to break all the stuff
969 (twice, withing a fortnigh ...)
971 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
972 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
973 redundancy) to added Test/TestReadWriteReadCompare.cxx
974 * Test/CmakeList.txt: because the compare test of
975 Test/TestReadWriteReadCompare.cxx fails, the following images are
976 black listed: - 8BitsUncompressedColor.dcm
978 - US-PAL-8-10x-echo.dcm
979 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
980 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
981 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
982 and ad-hoc kludge. This kludge is now removed, and on encountering
983 such an image (OB field brain damaged) we set errno. Then in
984 ::FindDocLength() we "fix" the length as being ALL what remains
985 in the file (until EOF). We then proceed, hoping for the best...
986 This fixes a SegFault in ShowDicom when trying to write such an
988 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
989 (because TestWriteRead breaks on it, after a non conformal commit?).
990 ctest now runs properly, except for MakeDicomDir (which was allways
991 broken) and the Python related stuff (still not fixed).
993 2004-06-24 Jean-Pierre Roux
994 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
995 FIX : Test/TestReadWrite now iterates on all the file names
996 (instead of infinite loop)
997 ENH : Test/TestWriteRead now iterates on all the file names
999 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1000 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1002 2004-06-24 Jean-Pierre Roux
1003 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1004 when SamplesPerPixel =3
1005 - now Write is no longer confused by
1006 'BitsAllocated = 12" and 'BitsStored=12"
1007 - "UN" value representation Elements are now written correctly
1008 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1009 ENH : - now gdcmHeader has its own Write methods
1010 (in order to split the job that has not to be done
1013 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1014 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1015 loop on the same image until memory went out.
1016 Note: this means we still have gobs of memory loss in PrintDocument
1017 * src/gdcmDocument.cxx: fixes problem on parsing on file
1018 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1020 2004-06-24 Jean-Pierre Roux
1021 FIX : Write - All the Sequences and Sequence Item are now written
1022 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1023 is added a the end, when necessary.
1024 - A lot of brain-damaged images, that were read correctly are
1025 now written correctly
1026 - length compatible BinEntry are now loaded correctly
1027 (even for odd groups)
1028 Note : only Explicit Value Representation was checked.
1029 (question : is implicit VR really necessary for gdcm ?)
1031 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * DEVELOPPER: added a proposition of coding style.
1033 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1036 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1037 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1038 Use the gdcmDocEntry::Print() and Write() instead.
1039 * src/gdcmDocument.cxx: bug fix.
1041 2004-06-22 Jean-Pierre Roux
1042 FIX : gdcmDocument.cxx
1043 - Now we do recognize the JpegLossLess format (there was a misstyping in
1044 code 'beautyfication' :-(
1045 - Now we automaticaticaly load the Luts, if any
1047 2004-06-22 Jean-Pierre Roux
1048 In order : to write Sequences, whatever their imbrication level,
1049 : to allow user to create his own Sequences
1050 a lot of modif where necessary (adding, moving, or virtualising methods)
1052 WARNING : save your own sources *before* cvs up !
1055 ADD virtual void Write(FILE *fp, FileType filetype);
1058 ADD virtual void Write(FILE *fp, FileType filetype);
1059 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1062 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1063 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1064 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1065 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1066 ADD std::string GetEntryByName(TagName name);
1067 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1069 std::string vr = "unkn",
1070 std::string fourth = "unkn",
1071 std::string name = "unkn");
1072 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1073 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1074 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1075 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1076 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1077 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1078 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1079 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1082 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1083 ADD virtual std::string GetEntryByName (TagName tagName);
1084 ADD virtual std::string GetEntryVRByName (TagName tagName);
1085 REM virtual bool Write(FILE *, FileType);
1086 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1087 FILE *_fp, FileType type);
1088 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1089 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1090 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1091 REM virtual std::string GetEntryByName (std::string tagName);
1092 REM virtual std::string GetEntryVRByName (std::string tagName);
1093 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1094 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1095 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1097 std::string vr = "unkn",
1098 std::string fourth = "unkn",
1099 std::string name = "unkn");
1100 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1101 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1102 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1103 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1106 ADD virtual void Write(FILE *fp, FileType filetype);
1109 ADD virtual void Write(FILE *fp,FileType filetype);
1112 ADD virtual void Write(FILE *fp, FileType filetype);
1113 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1114 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1115 REM std::string GetEntryByName(TagName name);
1118 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1120 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1121 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1122 The default constructor invoked by the line
1123 gdcmHeader *f1 = new gdcmHeader( header );
1124 was gdcmHeader::gdcmHeader(bool) instead of the expected
1125 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1126 Hence the parsing wasn't executed... See also below.
1127 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1128 as explicit constructor didn't do the trick to fix the above problem.
1129 Could anyone explain why ?
1130 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1131 properly calls gdcmValEntry::Print() (that was weed out from
1132 code related to gdcmBinEntry).
1134 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1135 * In order to fix memory leaks:
1136 - Test/TestWriteSimple.cxx: added cleaning of free store through
1138 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1139 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1140 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1141 (through the call to ::AddDicomDirMeta()) or the destructor
1142 would crash when deleting uninitialized ::metaElems].
1143 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1144 - src/gdcmDocument.cxx:
1145 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1146 from dynamic stores.
1147 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1148 was causing memory leaks.
1149 - src/gdcmSQItem.cxx:
1150 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1151 cleanly handled with polymophism: sorry but my milage is low).
1152 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1153 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1154 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1155 This avoids SegFaulting.
1156 - src/gdcmSQItem.h: coding style.
1158 - Test/TestWriteSimple still severely sucks. The output image content
1159 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1160 damaged when displayed with vtkgdcmViewer.
1161 - on memory leaks: TestWriteSimple leaks really less (see entry
1162 of 2004-06-18 in Changelog file for the call to valgrind).
1163 - on segfaults: ctest now passes all the tests but one (no more
1165 * Erroneous leading white fix:
1166 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1167 white[s] (as opposed to from >> xxx, that removes it [them].
1168 - src/gdcmTS.cxx: ditto.
1169 - gdcmPython/testSuite.py: dirty related kludge removed.
1170 * src/*: remaining references to gdcmParser removed.
1171 * src/*[cxx|h]: added copy[way]left header.
1174 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1175 * In order to fix writing of dicom files:
1176 - Test/TestWriteSimple.cxx: a simpler example of writing.
1177 - Test/CMakeLists.txt changed accordingly.
1178 - src/gdcmDocument.cxx:
1179 -- The destructor now recursilvely removes potential sequences.
1180 -- Bug fix in ::IsJPEG2000()
1181 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1182 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1184 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1185 to only declared) and build on top of
1186 ::GetDocEntryByNumber(guint16, guint16).
1187 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1188 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1189 for usage in destructor and treatement of promotion in
1190 ::ReplaceOrCreateByNumber().
1191 - src/gdcmSQItem.cxx: destructor should better handle his job.
1192 Test/TestWriteSimple now runs (or at least it DOES something).
1193 * We can now start hutting memory links. A good starting point is:
1194 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1195 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1196 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1198 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1199 * Valgrind note: after Mathieu Malaterre teached me how to read
1200 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1202 Using gcc, you can force the STL to use malloc and to free memory as
1203 soon as possible by globally disabling memory caching.
1204 With 3.2.2 and later, you should export the environment variable
1205 GLIBCPP_FORCE_NEW before running your program.
1206 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1207 simply vanish (it is still not clear to me, whether this means that
1208 STL std::string leaks or if valgrind believes it leaks...).
1209 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1210 running bin/gdcmTests makeDicomDir):
1211 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1212 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1214 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1215 SegFaulting (I drowned in DicomDir related code when trying to
1216 understand why the list is empty...).
1217 * src/gdcmDocument.h: first BSD license header try.
1218 * Doc/License.txt added.
1220 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * src/gdcmDocument.[h|cxx]:
1222 - Clean up of the Transfer related predicates. They are now all based
1223 on new method isGivenTransferSyntax, that (should) handle properly
1224 the padding problem.
1225 - general clean up, simplification, and coding style.
1226 - Specific clean up of Parse7FE0() (umproperly named actually).
1227 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1229 2004-06-14 Jean-Pierre Roux
1231 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1232 - fix the display of SQItem ordinal number
1233 - add the GetSQItemByOrdinalNumber method
1234 - remove some useless never written private methods
1236 2004-06-14 Jean-Pierre Roux
1238 - adding a constructor taking a gdcmDocEntry as an input param
1239 - ReplaceOrCreateByNumber now returns :
1240 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1241 a gdcmValEntry * if a string value is passed as a param
1243 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1244 according to the param type (no longer sets a gdcmDocEntry)
1245 - GetValEntryByNumber, GetBinEntryByNumber added
1246 - NewValEntryByNumber and NewBinEntryByNumber added
1248 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1250 - GetSQItemNumber and SetSQItemNumber added, to provide
1251 a (relative) Item identier inside a given Sequence
1252 \warning : some pb remaining around this number
1254 - AddEntry now takes the Item Number as a param
1256 - adding a constructor taking a gdcmDocEntry as an input param
1258 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1259 * Memory leak hunt with the following command:
1260 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1261 --show-reachable=yes gdcmTests PrintDocument
1262 It looks like many (all?) leaks are due to the STL (or a bad usage
1263 of the STL. The lines producing the leaks now have a comment with
1264 a "MEMORY LEAK" tag: you can retrieve them with
1265 grep "MEMORY LEAK" src/*
1266 Here are two typical examples which I can't help fixing:
1271 char * test = "babo";
1272 name = test; //// <--- valgrind detects 960 bytes lost in
1273 //// call to std::string::operator=(char const*)
1274 name.clear(); //// Doesn't help !
1282 std::cout << "Type a bunch of characters followed by RETURN: ";
1283 getline(std::cin, line); //// <--- valgrind dectects a loss
1284 //// of 1320 bytes in call to
1285 /// std::basic_istream<>& std::getline<>
1291 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1292 * src/gdcmHeader.[cxx|h]:
1293 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1294 and related, moved away to gdcmDocument.
1295 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1296 the corresponding protected accessors of inherited class
1297 gdcmDocument, removed ! As a consequence gdcmFile had to be
1298 declared friend of class gdcmDocument (see below).
1299 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1300 - Clean up of undefined or unused methods.
1301 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1302 account the changes to gdcmHeader.h).
1303 * src/gdcmDocument.h:
1304 - gdcmFile is now a friend class (in order to take into account the
1305 changes to gdcmHeader.h).
1306 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1307 (see changes to gdcmHeader.h).
1308 - Accessors (reading on the form GetEntry*) are now public.
1309 - Clean up of undefined or unused methods.
1310 * src/gdcmDocument.cxx:
1311 - adaptation to changes to gdcmDocument.h
1312 - ::OpenFile now writes a verbose message when file cannot be opened.
1313 - some std::string properly set to VRKey
1314 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1315 references to gdcmDocument.
1316 * Test/TestFindTags.cxx: changed accordingly to above changes.
1317 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1318 cvs repository gdcmData.
1320 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1321 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1322 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1323 conflicts with gdcmValEntry::voidArea.
1324 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1325 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1326 Value representation between StringRepresentable and BinaryRepresentable.
1327 * src/gdcmDocument.cxx:
1328 - method ParseDES: proper indentation restored and usage of
1329 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1330 - method LoadDocEntry: the fingerprint left in the SetValue() of
1331 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1332 removed. Reverting to previous code segment with the proper
1333 dynamic_cast< gdcmValEntry* >.
1334 Note: this was (partially) breaking the python test suite
1335 (gdcmPython/testSuite.py) that made usage of the above
1336 fingerprint to check presence of "Pixel Data".
1337 * src/gdcmDocEntry.h: coding style.
1338 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1339 now taken into account.
1340 * gdcmPython/gdcm.i: adaptation to the new internal representation
1341 of gdcm (exit gdcmParser, hello gdcmDocument).
1342 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1344 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1345 anymore, but instead prints the loaded Python dictionary.
1346 * .... alas, the python testSuite is still broken.
1348 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1349 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1351 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1352 * src/gdcmUtil.h : export methods
1354 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1357 * Initial addition of automatic python testing
1358 * Initial addition of automatic image comparison
1360 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1361 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1362 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1364 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1365 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1366 * Test/ShowDicom.cxx : bug fix for msvc compilation
1367 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1369 2004-05-04 Jean-Pierre Roux
1370 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1371 new concepts (and new classes) :
1372 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1373 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1374 - Sequence Doc Entries (gdcmSeqEntries)
1375 a Sequence is composed of Items.
1376 Each item is a set of Doc Entries (this is recursive)
1377 The non uniqueness of the 'Dicom tag' is due to this recursivity
1378 (never taken into account)
1379 Our unability to add a new 'entry' in the header
1380 at the proper location (neither in the H-Table (map or multimap),
1381 nor in the Chained List is also due to this recursivity.
1382 Don't try, right now, to use/modify/compile these new sources :
1383 nothing is finished.
1384 We just commit all the stuff, 'as is', in order not to loose it.
1386 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1387 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1389 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1390 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1391 file prefix (SetFilePrefix)
1393 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1394 * Add a new test: ShowDicom, for now this is just the c++ version of
1395 checkRead.sh, later it will be able to compare the image read against a
1397 * Replace the DEBUG on the stack with a global entry in cmake interface:
1398 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1400 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1401 * Add an example subdir, with a real example on how to read + write a
1404 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1405 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1406 * Doc/CMakeLists.txt: the main page is now properly differentiated
1407 between the developper and user version.
1408 * Doc/doxygen.config.in: dropped search related obsolete flags
1409 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1411 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1412 * DEVELOPPER: added some helpfull comments for compile/test/install
1415 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1417 src directory, now generated in the build dir.
1418 2. Tests as mentionned smarter
1420 4. Add a new method in gdcmDict that return the PubDict by name
1421 this is interesting for 3rd party lib like ITK,
1422 where we could set the institution name / patient name...
1424 * ENH: 1. Now the test suite is working for real
1425 2. All binaries are now output in the gdcm-bin directory
1426 (this was not true before)
1428 2004-04-28 Jean-Pierre Roux
1429 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1430 SeQuence indented printing of Dicom Header.
1431 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1432 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1433 Computation of SQDepthLevel is now part of gdcmHeader constructor
1434 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1435 tree-like structure of a Dicom Header.
1436 * FIX Test code cleaning
1438 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1439 * ENH: Adding automatic testing
1440 1. Need a DartConfig.cmake to submit to public
1441 2. Add a test driver gdcmTest.cxx
1442 3. gdcmTestMain, an helper for the main test driver gdcmTest
1443 4. Files in Test don't have a main anymore, this becomes interesting
1444 when we add more and more tests, thus dsw don't have to load
1446 * ENH: Adding a GDCM_DATA_ROOT for testing
1447 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1448 one file instead of seven + some small cleanup
1450 2004-04-22 Jean-Pierre Roux
1451 * ENH Minor changes to the Print() methods.
1452 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1453 Header printing. Example given with :
1454 > PrintHeader fileName 2 new
1455 (SQ based tree-like structure still to be done for the Header ...)
1457 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1459 1. I have added some unsigned where needed
1460 2. Some function parameter not used -> (void)
1461 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1462 4. g++ don't like character '\' in comment
1463 5. #define jpeg_create_decompress jCreaDecompress
1464 this really need to be fixed
1465 6. virtualize destructor of gdcmObject ... leakage
1466 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1467 this also really need to be fixed
1468 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1469 remove compression file
1470 (as we only do decompression, right ?)
1471 * ENH: Change malloc/calloc/free with c++ equivalent
1473 2004-04-21 Jean-Pierre Roux
1474 * FIX gdcmHeaderHelper::GetXSpacing
1475 when a single value is found (bug ?), xpacing is now
1476 defaulted to yspacing
1478 2004-04-19 Jean-Pierre Roux
1479 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1480 * ENH add parameters :
1481 bool exception_on_error = false,
1482 bool enable_sequences = false,
1483 bool ignore_shadow = false
1484 to the gdcmFile constructors to be full gdcmParser compliant
1485 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1486 to allow reading of PAPYRUS 3.0 files
1488 2004-04-06 Jean-Pierre Roux
1489 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1491 2004-04-02 Jean-Pierre Roux
1492 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1493 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1494 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1496 2004-03-30 Jean-Pierre Roux
1497 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1498 for ACR file, written out as DICOM files (hope so...)
1500 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1502 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1503 moved to base class gdcmParser and only the specialisation is kept
1505 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1506 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1507 already does the job.
1508 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1509 (to be consistent with gdcmParser::WriteEntries).
1511 2004-03-30 Benoit Regrain
1512 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1513 upate of the object's instance. It's passed to 2 in the unfavorable
1514 case : one in the ExecuteInformation, one in the ExecuteData
1516 2004-03-29 Jean-Pierre Roux
1517 * ENH : Check on file type to be written moved
1518 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1519 * FIX : gdcmObject::ResetBoundaries now stops properly
1520 when end-of-list is reached
1521 : gdcmVersion modified (as Benoit Regrain asked)
1523 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1524 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1525 * src/gdcmUtil.cxx: added forgotten iostream include.
1526 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1527 equivalent to ExplicitVR in existing code).
1529 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1530 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1531 now contains all the gdcmGlobal related code.
1532 * minor coding style and doxygenation changes.
1534 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1535 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1536 now contains all the Debug related code.
1537 * minor clean-up of includes in src/*.cxx
1538 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1539 CreateCleanString) removed.
1540 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1541 * Doc/DoxyMainPageUser.txt added.
1542 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1543 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1544 src/gdcmDirList.cxx)
1546 2004-03-24 Jean-Pierre Roux
1547 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1549 2004-03-23 Jean-Pierre Roux
1550 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1551 big endian made volumes
1552 * ENH Now gdcmParser constructor and destructor are protected to forbid
1553 end user to instanciate class gdcmParser
1554 (only gdcmHeader and gdcmDicomDir are meaningfull)
1556 2004-03-22 Benoit Regrain
1557 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1558 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1559 gdcmSerie to gdcmDicomDirSerie
1561 2004-03-19 Jean-Pierre Roux
1562 * ENH Now the tree-like structure describing a DICOMDIR comming from
1563 an already existing DICOMDIR file is consistent with
1564 the home-made tree-like structure build ex-nihilo
1565 or build from the files held (recursively) in a Directory
1566 functions gdcmDicomDir::CheckBoundaries()
1567 gdcmObject::SetBoundaries() added
1569 2004-03-17 Jean-Pierre Roux
1570 * REM (Eric Boix bug) : removal of meaningless
1571 gdcmDicomDirImage::NewImage function.
1572 * FIX now file names and directory name are written properly in the
1574 * FIX now gdcmDicomDir constructor may be call without any trick
1577 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1578 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1579 of gdcmDicomDirImage::NewImage as empty function.
1581 2004-02-28 Jean-Pierre Roux
1582 * ENH add gdcmDicomDir:NewPatient
1583 add gdcmDicomDirPatient:NewStudy
1584 add gdcmDicomDirStudy:NewSerie
1585 add gdcmDicomDirSerie:NewImage
1586 to allow making gdcDicomDir object.
1587 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1588 (as opposite to the gdcmHeader chained list)
1590 2004-02-11 Benoit Regrain
1591 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1592 when using from python
1594 2004-02-10 Benoit Regrain
1595 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1596 * FIX : in gdcmDicomDir when the directory is empty
1597 * ENH : add callback and methods to get the progression of dicomDir
1600 2004-02-06 Jean-Pierre Roux
1601 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1602 - GDCM_META added to gdcmDicomDirType
1603 - class gdcmMeta created
1604 * ENH : - A brief summary is now displayed at the beginning of
1605 'testDicomDir' to help disaster magnitude estimation
1606 * REM : Now useless Test/explDICOMDIR.cxx
1608 2004-02-05 Benoit Regrain
1609 * ENH : add methods in gdcmObject to get the hash table or the list of
1611 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1612 * FIX : wrapping python for TagHeaderEntryHT
1614 2004-02-04 Benoit Regrain
1615 * FIX : even length for some strings when writting the dicom dir
1616 * FIX : sort the images in the dicom dir
1617 * FIX : Bug fix for python use of dicom dir
1618 * ADD : a python demo
1620 2004-02-04 Jean-Pierre Roux
1621 * FIX : Final solution (?) for icone embedded images
1622 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1623 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1624 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1625 gdcmData/gdcm-MR-SIEMENS-16.acr1
1626 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1627 to make full checking easier
1629 2004-02-04 Benoit Regrain
1630 * FIX : WriteEntries : coding style & logic in parameters
1631 * FIX : Set the elements to create the DicomDir in a dictionary file
1633 2004-02-03 Benoit Regrain
1634 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1635 * gdcmDicomDir : add the load of directory
1636 * Bug fix and print add-on
1638 2004-02-03 Jean-Pierre Roux
1639 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1640 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1641 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1642 * FIX gdcmParser.cxx : 'group length' elements are now considered
1643 as integers, even for shadow groups, when file is Implicit VR
1645 2004-02-02 Jean-Pierre Roux
1646 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1648 of the last synonym :-(
1649 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1651 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1652 * FIX taking into account the possible 7fe0,0010 multiplicity
1653 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1654 to allow removal of references to 7fe0,0010, to deal with
1655 ACR-NEMA images, when 0028,0200 is meaningfull
1657 2004-01-31 Jean-Pierre Roux
1658 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1659 no longer writes 'Un' on disk
1660 * FIX SQ elements with actual length are now dealt with corectly
1661 * FIX gdcmFile::WriteBase make the difference, for color images, between
1662 the length (for Palette expanded images)
1663 and Raw Length (non expanded image + Palette)
1664 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1665 (that broke Write). Replaced by UL.
1666 Aware user will reload the field if he
1667 thinks it's necesssary
1669 2004-01-30 Jean-Pierre Roux
1670 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1671 when 'dirty Acr' is found, to be compliant with the new
1672 IsReadable() methods.
1674 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1675 (no DOUBLE images in kosher DICOM,
1676 but so usefull for people that miss them ;-)
1678 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1679 DICOMDIR related utilities (not checked as Windoze compliant)
1681 2004-01-28 Jean-Pierre Roux
1682 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1684 2004-01-27 Jean-Pierre Roux
1685 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1686 to allow skipping the shadow elements, to save memory space.
1687 The TRUE value for this param has to be used
1688 with a FALSE value for the 'enable_sequence' param.
1689 ('public elements' may be embedded in 'shadow Sequences')
1690 * gdcmHeader methods now deal with 'embedded icones images' in the header
1691 (even when an 'icone image sequence' is announced by the
1692 element (0x0088,0x0200), but there is NO icone at all ...
1694 * gdcmHeader sometimes Image Location value doesn't follow
1695 the supposed processor endianity (see gdcmData/cr172241.dcm).
1698 * gdcmHeader add the method
1699 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1700 to get *all* the Header Entries with the same tag.
1701 GetHeaderEntrySameName is probabely *useless*
1702 (no meaning : Name is *not* an identifier within the Dictionnary)
1704 2004-01-26 Benoit Regrain
1705 * Bug fix in the print of hexadecimal representations. Remove long fields
1706 in the print and add a third level of print to print them
1708 2004-01-23 Benoit Regrain
1709 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1710 * Bug fix on test suite after remove the strip made on not string fields
1711 * Split the IsReadable method between gdcmParser which test that the file
1712 is dicom and gdcmHeader which test that it's an image file
1714 2004-01-22 Benoit Regrain
1715 * DicomDir : clean code, add methods, set variables in protected or private
1716 * gdcmUtil : bug fix for the clean string method
1718 2004-01-19 Benoit Regrain
1719 * Add the use of shadow dictionaries
1720 * bug fix and coding style
1722 2004-01-19 Benoit Regrain
1723 * src/gdcmFile.cxx : bug fix concerning the close of file
1724 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1725 * Add the update of header entries using the shadow library
1727 2004-01-19 Benoit Regrain
1728 * removal of file gdcmHeader2.cxx
1729 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1730 inheriting from gdcmParser. This split is to prepare the integration
1731 of dicom dir parsing
1732 * bug fix under python
1734 2004-01-16 Jean-Pierre Roux
1735 * REM removal of class gdcmHeaderEntrySet
1736 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1737 * ADD add file gdcmHeader2.cxx
1738 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1740 2004-01-15 Benoit Regrain
1741 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1742 entries created while parsing the header. Thus, they will be destroyed
1743 when the gdcmDictSet will be destroyed
1744 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1747 2004-01-15 Benoit Regrain
1748 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1749 made a fatal error because of the memory release at the end of program.
1750 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1751 some memory and vtk seems to have some problems with that.
1752 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1754 2004-01-14 Benoit Regrain
1755 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1756 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1757 * src/*.[h|cxx] : make changes due to class name changes
1758 * gdcmPython/demo/*.py : bug fix due to method names
1760 2004-01-13 Benoit Regrain
1761 * src/*.[h|cxx] : coding style
1762 * vtk/*.[h|cxx] : coding style
1764 2004-01-13 Benoit Regrain
1765 * gdcmPython/testSuite.py : test the readable flag of file for tests
1766 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1767 It's lied to the stl compilation by MSVC (windows, always windows...)
1768 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1770 2004-01-12 Benoit Regrain
1771 * src/*.h : add comments
1772 * src/gdcmDictSet.h : set the method BuildDictPath in public
1773 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1774 directly setted in the source code
1775 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1778 2004-01-09 Benoit Regrain
1779 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1780 * setup.py : use a reference to gdcmVERSION
1782 2004-01-07 Benoit Regrain
1783 * Modification to compile with the distutils.
1786 2003-12-10 Benoit Regrain
1787 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1788 can use a gdcmHeaderHelper to load datas
1789 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1790 made in the source code
1792 2003-12-10 Benoit Regrain
1793 * Update Windows projects and .cvsignore files
1795 2003-11-12 Jean-Pierre Roux
1796 * ENH gdcmHeader constructor has one more parameter (default value : false)
1797 that allows the user to 'go inside' the SeQuences only
1799 gdcmElValSet:Print takes it into account
1801 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1802 * ENH: Update gdcmPython/CMakeLists
1803 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1804 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1806 2003-11-10 Jean-Pierre Roux
1807 * FIX : gdcmHeader::LoadElements is now based
1808 on the ListTag listElem member,
1809 not longer on the TagElValueHT tagHt member
1810 * ENH : PrintPubElVal shows (temporarily) both results,
1811 with the tagHt member and the listElem member.
1812 (it's easier to 'see' the problems when using Printheader)
1814 * FIX : old private member LgrElem is now splitted into
1815 ReadLength : Length actually found on disk (updated only
1816 if bug fixing is necessary), for internal
1818 UsableLength : Updated by FixFoundLength, to fix a bug
1819 or to allow Parser going on.
1820 Will allow to re-write a kosher header when a SeQuence
1821 with a length (not 0000) is found
1822 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1823 because gdcmElValSet::Add does not update ListElem
1826 2003-11-07 Jean-Pierre Roux
1827 * FIX misstyping in Transfert Syntax name table
1828 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1829 when they have an actual length (not 0000 nor FFFFF)
1830 (Nobody should care of it, but DICOMDIR explorers)
1832 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1833 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1835 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1836 * ENH: vtkGdcmReader now supports LUT !
1837 (vtkgdcmViewer for now is not able to use them though)
1839 2003-11-05 Jean-Pierre Roux
1840 * in testSuite.py : new files names for checking the package
1841 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1842 that returns the pixel area size to the *aware* (vtk) user
1843 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1845 2003-11-05 Benoit Regrain
1846 * in testSuite.py : Modify the rules for checking the paths
1847 : Explicit error messages
1848 * in __init__.py : Related modif
1850 2003-11-03 Jean-Pierre Roux
1851 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1852 to be used by aware (vtk) users that want to manage
1853 LUT (and no to turn the PALETTE image into an RGB pixels one)
1854 * GetPixelType now returns 8U for 24 Bits images
1855 (vtkGdcmReader compliant)
1857 2003-10-31 Jean-Pierre Roux
1858 * Removal of *all* gdcmData images and add them again
1859 in order to loose the 'history' of un-anonymised images
1861 2003-10-31 Jean-Pierre Roux
1862 * RMV : removal of useless jBitsInJsample.h
1863 for both 8 and 12 Bits JPEG Lossy Libraries
1865 2003-10-31 Jean-Pierre Roux
1866 * ENH : Add the functions gdcmFile::GetImageDataRaw
1867 gdcmFile::GetImageDataIntoVectorRaw
1868 that act as GetImageData and GetImageDataIntoVector
1869 except the making of an RGB Plane from Gray Plane + LUT
1870 Intended to aware (vtk) users who know how to manage
1873 GetLUTRGBA return a R,G,B,A LUT if any
1874 lgrTotaleRaw gives the 'Raw' length
1875 GetImageDataRaw returns the gray Plane
1876 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1877 (They stay Grey, just like with other Dicom viewers :-(
1879 2003-10-30 Jean-Pierre Roux
1880 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1882 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1883 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1884 being coherents dicom files.
1886 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1889 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1890 * ENH: Two steps is necessary to please VC++ compiler...
1891 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1892 * ENH: Add include dir to medcon lib
1893 * FIX: only one function is being exported for now !
1894 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1896 2003-10-29 Jean-Pierre Roux
1897 * adding gdcmHeader::GetLUTRGBA
1898 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1899 --> Mathieu, the modif u're waiting for is not yet committed
1900 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1902 2003-10-27 Jean-Pierre Roux
1903 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1904 00191113.dcm DermaColorLossLess.dcm
1905 MxTwinLossLess.dcm RadBWLossLess.dcm
1906 * ENH: For version prior to vtkImageViewer2 -r 1.19
1907 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1909 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1910 * Removal of ido stuff in CMakeLists.txt
1912 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1913 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1914 * FIX: remove a call to ->Modified ... see comments
1915 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1917 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1918 * FIX: Problem with path for libvtkgdcmPython
1919 * ENH: Try adding a search script for python site-package
1920 * RMV: Remove some file from medcon lib that are not necessary
1921 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1922 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1923 * FIX: More pragma disable fro VC++,
1924 I don't think I break something as it is also disable in VTK/ITK.
1925 But it fasten debug compilation time.
1927 2003-10-23 Jean-Pierre Roux
1928 * gdcm now deals with 16 Bits Run Length Encoded images
1929 (they are compressed as 2 planes images,
1930 one for the high Bytes, the other for low Bytes)
1932 2003-10-22 Jean-Pierre Roux
1933 * Now CheckRead takes into account :
1934 - the bugged 'Leonardo' Siemens images
1935 - the XA images, sent thru the burning VPRO station
1936 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1939 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1940 * FIX: When copying a Makefile.am to CMakeLists.txt
1941 one should remove the '\'
1943 2003-10-22 Jean-Pierre Roux
1944 * in gdcmData adding a bugged 'Leonardo' Siemens image
1945 (wrong lengths in header)
1946 OK with gdcm, KO with the other viewers :-)
1947 * add a GE dlx XA image, thru the VEPRO burning station
1950 2003-10-21 Jean-Pierre Roux
1951 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1952 for a brutal checking of vtkgdcmViewer compliance
1954 2003-10-21 Jean-Pierre Roux
1955 * add the files for 'xmedcon' Jpeg Lossless library
1956 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1958 2003-10-21 Jean-Pierre Roux
1959 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1961 2003-10-21 Jean-Pierre Roux
1962 * garbage Siemens 'Leonardo' images dealt with
1963 (the patch is easy to remove)
1964 * cosmetic changes to avoid warnings
1966 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1968 no need to press 'r' now.
1970 2003-10-20 Jean-Pierre Roux
1971 * upgrade of checkRead.sh checkWrite.sh according
1972 to new Jpeg Lossless decompressor
1973 * add US.3405.1.dcm, a genuine RGB medical file ...
1974 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1975 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1977 2003-10-15 Jean-Pierre Roux
1978 * general anonymisation in gdcmData
1979 * adding the 'color files' from
1980 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1981 * adding some well knowed bugged-header images
1982 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1983 waiting for their inclusion in Python testsuite
1985 2003-10-15 Jean-Pierre Roux
1986 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1987 no longer seg faults when file is not found
1989 2003-10-14 Jean-Pierre Roux
1990 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1993 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1994 * TODO: *.in file to genereate a UseGDCM later
1996 2003-10-14 Jean-Pierre Roux
1997 * Some supposed-to-be Dicom Images have no preamble.
1998 OpenFile takes it into account
1999 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2000 * Missing elements added in dicomV3.dic
2001 (just to be affraid : have a look at
2002 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2003 and do it again next year ;->
2005 2003-10-13 Jean-Pierre Roux
2006 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2007 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2008 But there are NOT. It's fixed !
2010 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * FIX: "jpeglib.h" was not found on VC++
2012 * FIX: vtkgdcm was not being installed
2014 2003-10-10 Jean-Pierre Roux
2015 * ENH : OpenFile closes the file if it *really* doesn't look like
2016 an ACR-NEMA / DICOM one.
2017 * FIX : testWrite no longer writes an empty file if the source file
2018 is not gdcm Readable
2019 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2022 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2023 * FIX: CMake generate now documentation
2024 * ENH: out of source doc build !
2025 * ENH: Generate both user and dev documentation
2026 * ENH: Should work on windows too
2027 * ENH: Only one doxygen config.in file is needed
2028 * FIX: make install should be ok now on ùnix plateform
2029 * FIX: PATH to dictionary was wrong (missing /)
2030 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2032 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2033 * vtkGdcmReader is now able to read rgb dicom file.
2034 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2035 * added a gdcmViewer to vtk test, use mouse to control
2036 window level & window width
2038 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * CMake-ification of gdcm, we have now two build system
2040 * FIX: on cygwin Wsock32 doesn't exist
2041 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2043 2003-10-06 Emanuel Ollart
2044 * FIX : compilation process wad broken.
2045 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2047 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2048 * change gdcmViewer -> vtkgdcmViewer
2049 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2051 2003-10-06 Jean-Pierre Roux
2052 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2053 ( e.g : well known GE images with a wrong elem length,
2054 : Philips MRI Images with a wrong Huffman table)
2055 * still to be done : allow the reading of bugged LEONARDO Siemens images
2057 2003-10-03 Jean-Pierre Roux
2058 * Odd length strings are padded with '\0' (not with spaces,
2059 to remain compliant with already defined strings,
2060 like Transfert Syntax UID and others)
2062 2003-10-03 Jean-Pierre Roux
2063 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2064 to allow displaying RGB images (not only by affim ;-)
2066 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * vtkGdcmReader is now able to read rgb dicom file.
2068 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2070 2003-10-03 Jean-Pierre Roux
2071 * A few nasty patches to allow the reading of a lot of nasty images
2072 ( e.g : well known GE images with a wrong elem length,
2073 : Philips MRI Images with a wrong Huffman table)
2074 * still to be done : allow the reading of bugged LEONARDO Siemens images
2076 2003-10-03 Jean-Pierre Roux
2077 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2079 2003-10-03 Jean-Pierre Roux
2080 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2081 to allow displaying RGB images (not only by affim ;-)
2083 2003-10-03 Jean-Pierre Roux
2084 * gdcmFile::GetImageDataIntoVector now
2085 - deals with MultiFrames MultiFragments Run Length Encoded files
2086 - deals with YcBcR (YBR_FULL) files
2087 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2088 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2090 (no sample found :-(
2092 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2093 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2094 Two reasons: - clear things
2095 - third parties acces gdcm through header files, so won't
2096 suffer anymore VC++ complains
2098 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2099 * add argv[1] in testvtkGdcmReader.cxx
2102 2003-09-24 Jean-Pierre Roux
2103 * The lines are now eigthy characters long.for
2104 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2106 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2107 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2108 char* to std::string. Thus, the use of strdup becomes useless. (see
2109 previous commis of Malaterre)
2110 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2111 before the last Malaterre's commit.
2113 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * This commit should fix the Debug building under VC++, the problem
2115 was mainly a mixture of debug and release lib being loaded at startup.
2116 * I also remove a depency to a specific C function: strdup. Because I had
2117 to force the link to msvcrtd (whereas strdup is in libc).
2119 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2120 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2121 located in the gdcmCommon.h file. All use of reference of tha has been
2122 changed to now use the variable GDCM_UNFOUND.
2124 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2126 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2127 Dicom dictionary. The test suite can now be run again. Note:
2128 I'm note very happy with the " (RET)" changes. I believe this
2129 RETAINED comment should be dropped when parsing the dictionary.
2130 - PACKAGER corrected
2132 - AUTHORS updated and now in alphabetical order
2133 * Makefile.am now exports gdcm.dsw for Windoze users.
2135 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2136 * cygwin complains about missing std:: in subdir Test/
2138 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2139 * remove some methods that are now in gdcmHeaderHelper
2141 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2142 * vtkGdcmReader set spacing and origin correctly
2144 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2145 * Fix a few delete/delete[] mismatch
2147 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2148 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2149 interpretation to data given by gdcmHeader. For instance there are
2150 heuristics to get informations (look at different places).
2151 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2152 sorting DICOM images based on different strategies.
2153 * modified Makefiles accordingly.
2155 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2156 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2157 when building in debug mode
2158 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2159 src/win32/gdcmdll.dsp
2160 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2162 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2163 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2166 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2167 * src/win32/libgdcmjpeg12.dsp was not dos format
2168 * src/win32/libgdcmjpeg12.dsp :
2169 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2170 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2172 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2173 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2175 * src/gdcmFile.cxx : bug fix in affectation type
2176 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2177 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2178 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2179 symbols... future problem ?
2181 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2182 * src/win32/libgdcmijpeg12.dsp was missing
2183 * modified gdcm.dsw accordingly
2185 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2188 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2189 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2190 commit of JPR (before his hollidays to facilitate our work).
2191 * setup.py : bug fix in code. Modifications made while the last commit
2192 of JPR. The code hasn't been tested before the commit... it's so
2193 useless to make that (for best programmer that is JPR) !!!
2195 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2196 * tagged the current version as Version0_3 (i.e. version 0.3)
2198 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2199 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2200 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2201 * *.dsp : modifications to use new libgdcmijpeg8 library
2202 * setup.py : bug fix on VTKPATH variable
2203 * PACKAGER : adding all concerning windows
2205 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2208 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2209 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2210 test suite reported error.
2211 * PACKAGER file added (describes what a packager must do when
2212 packaging a new release).
2213 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2214 * configure.in: upgraded version number to 0.3.0
2215 * fixing build of rpm (through rpm -ta):
2216 - Doc/Makefile.am exports proper doxygen files
2217 - src/jpeg/libijg8/Makefile.am exports the include files.
2219 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2220 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2221 * src/gdcmHeader.h : formatting code
2223 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2225 We were obtaining error message from vtk. Now, creation of file list
2226 is made in an internal list to prevent this problem.
2227 Bug fix when output is empty.
2228 Bug fix in update of progress value. Previous commit for this was a bad
2230 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2232 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2233 * src/gdcmHeader.h : added method to get the file name
2234 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2235 files. Added method to remove all files on the input
2236 Added FIXME comment concerning the bad parsing of header made by
2237 ExecuteInformation method (in ExecuteData method)
2239 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2241 when using make instal.
2242 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2243 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2245 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2246 * setup.py : adding include dir of jpeg lib to compile all sources
2247 * */Win32/*.dsp : JPR fix for windows compilation
2249 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2250 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2252 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2253 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2255 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * setup.py is again effective on un*x (takes into account the
2257 addon of the jpeg library)
2258 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2259 * Doc/Doxy* updated (includes above enhancements)
2260 * INSTALL now points to web documentation
2262 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2263 * src/gdcmHeader.h doesn't make unnecessary reference to
2265 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2267 * src/gdcm*.[cxx|h] :
2268 - to allow compilation with gcc 3.x
2269 -- clean up of STL usage (added explicit usage of std::)
2270 -- small fixes on exceptions.
2271 Note: linking not tested !
2272 - clean of doxygen comments to avoid warnings at documentation
2274 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2275 dependent convertion).
2277 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2278 * Clean up of previous JPR garbage commit (not even commented in the
2280 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2281 - moved all jpeg related files from src to src/jpeg/libijg8, with
2282 addition/modification of Makefile.am and configure.in.
2283 - the testSuite is still brain damage (not guilty).
2285 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2286 * WrapVTK.py : modifications to get correctly vtk source files to
2288 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2289 (FileName -> Filename)
2291 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * vtk/vtkGdcmReader.[cxx/h]:
2293 - UpdateProgress method should now be effective
2294 - removed the limitation on having only images loaded (as opposed
2296 - when building a stack of images/volume, a lesser number of
2297 gdcmHeader and gdcmFile instances should be used (hopefully
2298 accelerating things).
2299 - when building a stack of images/volumes, files which are not
2300 loadable (wrong path-filename, wrong permissions on existing file,
2301 or file not parsable by gdcm) are replaced with a black image
2302 in the stack (for the caller to notice the problem).
2304 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2305 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2307 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2308 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2309 between standard library (std) and vtk library (problems are found
2310 under Windows... thanks Windows !)
2312 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2315 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2317 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2320 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2321 * When compiling with distutils (see setup.py) the C++ compiler is
2322 called with different flags than the default ones (with automake).
2323 In order to fix all those warning, I compiled gdcm with the command
2324 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2325 and went for warning fixes:
2326 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2327 up from unused variables.
2328 - vtk/vtkGdcmReader.cxx: potential bug fix.
2329 * src/gdcmHeader.h: Doxygen warning cleanup
2331 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2332 * gdcmPython/gdcm.i:
2333 - typemaps correction to take into account the systematic replacement
2334 of "using namespace std" with std:: prefix e.g. std::list,
2335 std::string... (cf changes of 2003-05-21).
2336 - gdcmGlob global variable of type gdcmGlobal (defined in
2337 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2338 exported to Python a as cvar.
2339 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2340 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2341 gdcmDictSet.GetPubDictTagNames() and
2342 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2343 C++ static methods).
2344 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2345 with the above changes.
2347 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2348 * setup.py, manifest.in : bug fix under linux
2350 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2351 * Modification of setup.py to compile vtk part too. Then, we have 2
2352 wrappers which must work with same distutils. For that, we have a
2353 generic distutils in distusiltsWrapping.py ; with :
2354 - build_extWrap class to wrap generically all extensions,
2355 - ExtensionWrap base class for all wrapping extension that contains
2357 - Wrapper interface which wrap sources
2358 + In WrapSwig.py we have extension and wrapper for Swig
2359 + In WrapVTK.py we have extension and wrapper for VTK
2360 * MANIFEST.in : modifications to consider vtk directory and new python
2361 files for compilation
2363 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2364 * Added python wrappers of vtkGdcmReader vtk class (see the
2365 source in vtk/vtkGdcmReader.cxx) :
2366 - vtk/Makefile.am now builds a library
2367 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2368 python library (as opposed to _gdcm.so wich are the python
2369 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2370 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2372 - configure.in has an additional flag --enable-vtk that needs
2373 to be set to enable compilation of vtk related code, that is:
2374 + vtk/vtkGdcmReader.so and
2375 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2376 + gdcmPython/vtkgdcmPython.so (see above)
2377 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2378 be read when compressed or when HighBit + 1 != BitsStored),
2379 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2380 the usage of the python wrapper of vtkGdcmReader vtk class.
2381 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2382 * src/*.[h] all occurences of stl classes are now prefixed with
2383 std::, and all occurences of "using namespace std;" where removed.
2384 This is to avoid pollution of global namespace in included files.
2385 Apparently vtk does not avoid this pitfall: when using both
2386 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2387 collision of various stl members (principally cout...).
2388 * gdcmPython/testSuite.py now cleanly removes temprory generated
2390 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2391 comply with above changes)
2393 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2394 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2395 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2396 vtk data structure (an image Flip was required).
2397 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2398 * cosmetic changes in documentation.
2400 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2401 * src/gdcmHeader.cxx: the constructor no longer exits when an
2402 unexisting file is given as argument.
2403 * The subdirectory Data (containing all the images used for the
2404 test suite) is not part of this repository anymore. A new module
2405 containing those images is now available at
2406 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2407 with the name gdcmData.
2408 All the python scripts (including the package initialisation file
2409 gdcmPython/__init__.py) were adapated to take this change into
2410 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2412 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2413 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2414 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2415 demo of the usage of this class.
2416 Compilation of this vtk part is only done when using the --enable-vtk
2417 at configure (or autogen.sh) stage.
2419 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2420 * More memory link related corrections and documentation fixes.
2422 - maximum info is obtained with a command of the form:
2423 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2424 --show-reachable=yes PrintHeader
2425 - the remaining reachable blocks seem to come from the STL
2426 allocation scheme through the usage of map and list. It looks
2427 like this memory cannot be freed but it is not a memory leak
2428 (in fact further invocation to the STL would recollect the
2429 unused memory allthough it cannot explicitely be freed).
2430 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2431 of displaying an image parsed with gdcm and displayed with VTK.
2432 Note: some images don't seem to work e.g.
2433 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2434 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2435 Allthough this weakens the semantics, it is a ditch attempt to
2436 make gdcm more thread friendly.
2438 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2439 * Memory link hunt (by using valgrind through the command
2440 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2441 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2442 gdcmHeader::_dicom_vr.
2443 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2444 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2446 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2448 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2449 * src/Makefile.am now exports all the necessary include files at
2453 * UpdateGroupLength replaced by new one
2456 * UpdateGroupLength re-written using H-Table
2457 (named UpdateGroupLengthNew untill checks are over)
2459 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2460 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2461 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2463 - gdcmHeader::GetPubElValSet removed.
2464 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2465 UpdateGroupLength, WriteElements, Write.
2466 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2467 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2468 carried the same semantics.
2469 - src/gdcmHeaderIdo.cxx changed accordingly.
2470 - gdcmFile::WriteBase now regroups all the codes from previous
2471 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2472 - enum FileType moved to gdcmCommon.h
2473 * src/gdcmHeader.cxx AddDefault trashed
2474 * gdcmGetXSize added
2475 * getimageDataSize now calls gdcmGetXSize
2476 * Test/*.cxx changed to agree with above changes
2478 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2480 (to avoid double call by end user).
2481 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2482 by end user, since gdcmHeader::gdcmHeader now handles it.
2484 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2485 * gdcm/Doc many doxygen changes:
2486 - Doxyfile now has two different versions, DoxyfileUsers that generates
2487 the html.users end users oriented documentation and
2488 DoxyfileDeveloppers that generates the html.developper developper
2489 oriented documentation.
2490 - README changed accordingly
2491 - requirement.txt removed (old design info moved to TODO).
2492 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2493 DoxyMainPage.txt, DoxyPython.txt provide more information.
2494 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2495 be updated by simply regenerating the docs with doxygen and copying
2496 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2497 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2498 all the tests in the form "if (<map>.count() >1)" were removed.
2499 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2500 ill-formed documentation sections.
2501 * src/gdcmHeader.cxx: ditto
2503 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * setup.py fixed for un*x (needed macro for stdint.h)
2505 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2506 un*ces with sh-utils test utility.
2507 * gdcmPython/demo/test.py renamed to PrintHeader.py
2508 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2509 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2510 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2511 * src/gdcm*.cxx JPR's bad inclusion fixed.
2513 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2515 * gdcmPython/demo/test.py changed accordingly.
2517 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * gdcmPython/Makefile.am fixed linking against libstdc++
2519 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2520 * Swig subdir (historical tests of swig version 1.3.17++) removed
2521 * Test/testChangeEntete.cxx some lines commented out in order to make
2523 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2524 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2526 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2527 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2528 hence the user doesn't need this explicit call.
2529 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2530 i.e. LoadElements() call removed.
2531 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2532 - src/Makefile.am declares the proper flag for g++.
2533 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2534 for adding user defined new tags.
2535 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2536 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2537 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2539 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2540 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2541 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2542 src/Makefile.am : the project should properly compile and install
2543 with the autotools, included the python wrappers part.
2544 * gdcm.spec.in : added a spec file for RPM packaging.
2546 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2547 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2549 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2551 to exported to the environement (see gdcmPython/testSuite.py
2553 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2554 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2555 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2556 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2557 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2559 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * gdcmPython/__init__.py doesn't crash anymore when running in
2561 in InstallMode or PreInstallMode but with an environement given
2562 value of GDCM_DICT_PATH.
2563 * src/gdcmDictSet.[cxx/h] coding style.
2565 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2567 * src/gdcm.h general comments moved to TODO, and README
2568 * src/gdcm.h should now be seen as a user commodity (including it
2569 should suffice to fully use gdcm). It is nowhere including within
2570 any of the kernel files src/*.cxx and src/*.h.
2572 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2573 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2574 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2576 * src/gdcm*.cxx only include their corresponding include file
2577 (as opposed to gdcm.h)
2578 * gdcmPython/gdcm.i changed accordingly
2579 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2580 the autogen.sh generated "make snapshot" command to work.
2581 * autogen.sh removed history related references to crea package.
2583 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2584 * distutilsSwigCPlusPlus.py work around some swig portability
2587 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2589 was done in a last ditch attempt to get setup.py _really_
2590 operationnal. The python/gdcmPython layaout add the advantage
2591 of hidding away the python related distutils specific files
2592 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2593 Alas, the src directory was out of scope (i.e. it's relative
2594 position to setup.py was ../src) which made things impossible to
2595 handle (see previous version of python/setup.py). Crossing fingers...
2597 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2598 * python/setup.py now works on Un*x. (harder than I thougth)
2599 * python/distutilsSwigCPlusPlus.py can now have include files
2600 among the list of sources.
2602 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2603 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2604 * modifications in MSVC projects
2606 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * As stated by the first lines of Test/ExceptionAndPython/README, it
2608 looks like we can move back to original usage of exception within
2609 src/gdcm* and hence remove the errno stuff that was introduced
2610 as a quick and dirty fixture of this problem (added to the TODO).
2611 * Doc/Doxyfile configuration file for Doxygen and corresponding
2612 README file for usage added.
2613 * Test/testWrite.cxx added. This new test comes from a split of
2614 test.cxx that is now reverted to its original purpous i.e.
2615 testing the proper parsing of a Dicom related file.
2616 testWrite.cxx concentrates on testing the IO part of gdcm.
2617 * Test/bug1.cxx (containing a bug on WIn32) added.
2618 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2619 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2620 whose purpose is to publish the content of the TagNames of the
2621 Dicom public dictionnary were not accessible without an
2622 instance of class gdcmHeader.
2623 - those methods are now static methods of gdcmDictSet and hence
2624 require no instances at all to be invocated.
2625 - within gdcmDictSet this change required to change some method
2626 to class methods (i.e. are now static) among which SetDictPath
2627 (renamed to BuildDictPath) and LoadDefaultPubDict.
2628 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2629 the above changes by calling the new method classes of gdcmDictSet.
2630 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2631 the above to be effective.
2632 * python/gdcmPython: in order to wrap properly the above changes
2633 for Python, swig version now needs to be > 1.3.17.
2634 * python/gdcmPython/Makefile fixed to adapt itself to new
2635 configure/make shema introduced by Johan Montagnat (thanks for the
2636 contribution). Alas this Makefile cannot be turned into a proper
2637 Makefile.am without some heavy changes in the configure.in
2638 (for python dectection).
2639 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2640 now avoids publishing the empty entries.
2642 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2643 * python/setup.py : bug fix concerning install under windows
2644 ExtraPath reused :-P
2645 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2647 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2648 * Dicts/dicomV3.dic : remove double spaces !!!
2649 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2650 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2653 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2655 method. Doxygenation.
2656 * src/gdcm.h clean up of JPR spurious comments.
2658 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * python/distutilsSwigCPlusPlus.py now properly collects the
2660 shadow classes generated by "swig -c++" (gdcm.py in our case)
2661 when using "python setup.py install".
2662 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2663 reexports the working classes.
2664 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2665 by the classical C errno scheme. This is to prevent an obscure
2666 behavior of the python wrappers when importing wxPython.wx prior
2667 to gdcmPython (which ended up in an abort call). An illustration
2668 of this oddity can be found in the Test/ExceptionAndPython
2669 subdir (see the README file). This problem probably due to
2670 an combination of g++ and dynamic loading.
2671 * added Test/ExceptionAndPython (see above)
2673 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * Changed the layout of the python part to avoid bloating main
2675 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2676 i.e. the distutils arsenal. All the python related stuff is
2677 again in a python subdir, but the package itself is now in
2679 * setup.py was cleaned up:
2680 - pythonIncludePath removed
2681 - python setup.py bdist target is now functional.
2682 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2683 collision with other packages). gdcmPython/demo/*.py changed
2686 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2687 * python subdir moved to gdcmPython (preparation of distutils packaging).
2688 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2689 distutils installer is operational.
2690 * - gdcmPython/__init__.py now properly loads the swig generated
2691 shadow classes (from gdcm.py).
2692 - gdcmPython/demo/*.py changed to import the package gdcmPython
2693 instead of gdcmPython/demo/load.py.
2694 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2696 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2697 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2698 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2699 entries within the associated public Dicom dictionary resp. the same
2700 information but sorted by the fourth field (PAT, IMG, DIR) of the
2702 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2703 are now in the "???" group.
2704 - python/gdcm.i changed accordingly,
2705 - python/demo/printGroupedPublicDict.py added, that gives an example
2706 of the above new functionalities in Python.
2708 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * src/gdcm.h, gdcmHeader.cxx:
2710 - historic references to glib's g_malloc and g_free (#defined)
2711 were definitively removed.
2712 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2713 * src/gdcmElValSet.cxx:
2714 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2715 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2716 - GetElValue(string) renamed to GetElValueByName.
2717 - Added GetElementByName(string).
2718 * src/gdcmHeader.cxx: added
2719 - GetPubElValRepByNumber(guint16, guint16)
2720 - GetPubElValRepByName(string)
2721 - GetShaElValRepByNumber(guint16, guint16)
2722 - GetShaElValRepByName(string)
2723 - GetShaElValByNumber(guint16, guint16)
2724 - GetShaElValRepByName(string)
2725 - GetElValRepByNumber(guint16, guint16)
2726 - GetElValRepByName(string)
2727 - GetElValByNumber(guint16, guint16)
2728 - GetElValRepByName(string)
2729 * Doc/requirements.txt added.
2731 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2732 * Test/Makefile building now depends on the one of libgdcm.so
2733 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2734 pixel data) aware which enables finding the address (offset) of
2735 the pixel data of JPEG encoded DICOM files. This leaves only a single
2736 file in the testSuite whose pixel data address (offset) is unknown.
2737 * python/testSuite.py changed accordingly.
2739 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2740 * VC++ has some strong limitations when working with the STL, as stated
2741 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2742 "Also note that some STL containers (map, set, queue, list, deque)
2743 cannot be exported. [...]
2744 Some STL classes contain nested classes. These classes can not
2746 This is caused by a designed limitation that once a template
2747 class is instantiated, it can not be re-instantiated and
2749 Since our usage of map<> is ubiquitous in gdcm, this "designed
2750 limitation" of VC++ is a pitfall.
2751 Hence the Python wrappers of gdcm cannot be incrementally linked
2752 against the c++ dynamic library. The dirty but only workaround is
2753 to forget about incremental link of dynamic libraries and to generate
2754 the Python wrappers library with the inclusions of the underlying C++
2756 The following modifications concern this matter on Win32/VC++:
2757 - wrapping python correct with standalone wrapped dll (don't use separate
2758 dll under windows !!!!)
2759 - python21_d debug mode enabled (ask Frog how to use it :-)
2760 - NO problem with having an STL member of class for example string in C++
2761 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2762 - Python test of dcmlib in Python is ok under windows on a large set
2764 * removed glib references
2765 * typedef's inserted in gdcm.i for correct swig type management
2767 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * python/demo/*.py load.py extracted from test.py. Added explore.py
2769 that only displays required tags and testAll.py that parses all
2770 the files of the testsuite without using unittest.
2771 * python/testSuite.py other additional test on new files added.
2772 * Data/* new test files added accordingly to the testSuite.
2773 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2774 the vr in the file differs from the one of the dictionary.
2776 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2777 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2778 values, but limits itself to values which are below a user specified
2779 size (by default 1024 bytes).
2780 * python/gdcm.i : elements not loaded (because their size is above the
2781 user specified treshold) are exported with their TagKey as key of the
2782 python dictionary. This enables the testsuite to make some checks
2783 on the unloaded elements (since we have their offset and size).
2784 * python/testSuite.py
2785 - now tests for the existence and proper value of the pixel data
2786 - two new examples added.
2787 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2789 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2790 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2791 aware. See the strategy comments in gdcmHeader::FindeLength().
2792 * Test/test.cxx now accepts a filename as first argument.
2793 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2794 * python/testSuite.py changed to integrate test on above files.
2796 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2797 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2798 the vr was also RET.
2799 * python/testSuite.py more tests added.
2801 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * python/testSuite.py unittest test suite added (uses Data)
2803 * Data/* dcm and acr files for the test suite.
2804 * glib dependance removed from un*x version. We now use ISO C99
2805 7.18 Integer types (see stdint.h)
2806 - python/Makefile, src/Makefile src/gdcm.h
2807 * src/ when an explicit vr (like dicom files) suddenly poped an
2808 implicit element we use to mark the underlying DictEntry of the
2809 concerned ElValue with "Implicit". This strategy was damageable
2810 too the public or provite dictionaries, since some of their vr
2811 would be changed. Since Header::FindLength heavily relies on the
2812 detection by Header::FindVR of falsely explicit elements, I
2813 added an extra ImplicitVr member to ElValue (boolean).
2814 The rest of the changes we the necessary adaptations.
2816 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2817 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2819 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2821 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2822 * Adaptation for porting to VC++:
2824 o forced to use std namespace (for string to be known)
2825 o all class use __declspec export style on WIN32
2826 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2827 (in stdlib.h on Win32 but in std:: for gcc)
2828 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2829 variable GDCM_DICT_PATH.
2830 * src/gdcmHeader.cxx verbose comments made discrete.
2832 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * python/gdcm.i: added a typemap that converts a C++ hashing table
2834 to native Python dictionary.
2835 * python/demo/test.py:
2836 - now uses the native dictionary for exploration of gdcmHeader.
2837 - takes an optional filename argument (the file to parse).
2838 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2839 PubElVals hashing table.
2840 * Dicts/dicomV3.dic removed error prone trailing spaces.
2842 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * Python wrapping process moved away from src/Makefile to
2844 newly created python/Makefile (as well as gdcm.i)
2845 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2846 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2847 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2848 from the environement variable GDCM_DICT_PATH (when existing).
2849 * src/gdcmDict::GetTag bug fix.
2851 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2852 * Straightforward temporary fixes for swig to build the python wrappers.
2853 src/Makefile now has a python working entry [by working we mean
2854 that we can import de shadow classes without errors].
2856 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2857 * hashtest.cxx removed (since allready in Test)
2858 * src/gdcmlib.h renamed to src/gdcm.h
2859 * src/dcm.i renamed to src/gdcm.i
2860 * src/Makefile prepared for python wrapping
2862 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2863 * src/gdcmHeader.cxx :
2864 - Parsing of header is now separated from loading of element values
2865 (see gdcmHeader::LoadElements).
2866 - general clean up of hopefully all file access (creation of
2867 ReadInt16 and ReadInt32)
2869 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2870 * src/gdcmHeader.cxx :
2871 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2873 - SetLgrElem renamed to SetLength
2874 - GetLgrElem renamed to GetLength
2875 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2876 * src/gdcmElValSet.cxx fixed both GetElValue methods
2877 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2878 due to IdoDude was cleaned out.
2880 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2881 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2882 concentrates on finding the value representation (when it exists).
2883 RecupLgr now only finds the element value length, and it avoids
2884 returning the unecessary skL (skipped length).
2885 Also, offsetCourant was simply removed (with taille_fich) since
2886 it was redundant with the File position internals (by using
2887 ftell and fseek). This also made skL (see above in RecupLgr) usage
2889 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2890 on the libido specificities which are handled through class
2892 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2895 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * Truckload of changes. Parsing of header is barely functional
2897 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2899 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2900 * src/gdcmHeader.cxx many addons of low level methods
2902 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2903 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2904 and _IdDcmSWAP_LONG.
2906 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * This corresponds to all the changes decided at the meeting of
2908 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob