1 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
3 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
4 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
5 - src/CMakeLists.txt: alphabetic order reodering + new entries.
6 * CLEANUP_ROUND (4) for gdcmPixelConvert
7 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
8 to return an unused length.
10 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
11 * Added documentation of vtkgdcmReader on Website:
12 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
13 with it's binary name).
14 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
15 the Website to be more complete.
16 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
17 doxygenated documentation.
18 - Doc/DoxyVtkGdcmReaderExamples.txt added
19 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
20 DoxyVtkGdmReaderExamples.html )
21 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
22 * CLEANUP_ROUND (3) for gdcmPixelConvert
23 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
25 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
26 * CLEANUP_ROUND (2) for gdcmPixelConvert
27 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
29 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
30 * CLEANUP_ROUND for gdcmPixelConvert:
31 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
32 - src/gdcmPixelStuff[h|cxx] removed
33 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
34 - src/CMakeLists.txt changed accordingly
36 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
37 gdcmVersion.py moved to newly created ATTIC related
38 gdcmPython/SetupOldies/ directory.
40 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
41 - autogen.sh configure.in acinclude.m4 python.m4 removed
43 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
44 * src/*.cxx *.h Reference to License.htm fixed to License.html.
45 * Doc/CMakeLists.txt, doxygen.config.in: fix.
46 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
48 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
49 * TODO updated with Mathieu suggestions. I proposed a template for
50 describing TODO entries and used it for new entries.
51 * Added Doc/Website/CodingStyle.html, Developpers.html,
52 DeveloppersPython.html, GdcmDataCvs.html and
53 DownloadVersion0_1.html, DownloadVersion0_3.html.
54 * Some Doc/*.txt Doxygen files (which do not really concern the
55 documentation itself, but the website) moved to html and
56 placed in directory Doc/Website:
57 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
58 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
59 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
60 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
61 * CMakeLists.txt changed accordingly.
62 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
63 DeveloppersPython.html
64 * INSTALL nows refers to Doc/Website/Installation.html
66 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
67 * Added Doc/Website directory, that contains a first raw version
70 2004-09-23 Jean-Pierre Roux
71 * FIX In order not to be poluted any longer by casting problems,
72 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
73 we can now delete[] it safely
74 * VoidArea is now called BinArea (less confusing name),
75 and all the methods called ...VoidArea... are now ... BinArea...
76 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
78 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
79 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
80 clear) TagHT, which is an inherited member of gdcmElementSet. It is
81 up to the destructor of gdcmElementSet to clean up TagHt and it's
84 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
85 * Test/CMakeLists.txt: update to follow gdcmData renamings.
86 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
88 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
89 * ENH: added some utility method that builds a flat dictionnary
90 holding all the Dicom entries contained in the recursive structure
91 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
93 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
94 BuildFlatHashTable() that build a flat dictionary.
95 - src/gdcmElementSet.h: added a new private GetTag() accessor.
96 gdcmDocument is now a friend of gdcmElementSet.
97 - src/gdcmElementSet.cxx: clean up.
98 - Example/FlatHashTablePrint.cxx added.
99 - Example/CmakeLists.txt changed accordingly
101 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
102 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
103 moved away from gdcmDocEntrySet (since this class is an abstract class
104 acting like an interface). SQDepthLevel and BaseTagKey are now
106 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
107 and associated accessors. Doxygenation of the class.
108 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
110 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
111 Use SQDepthLevel accessor instead. ::Print() adapted.
112 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
113 - src/gdcmDocument.cxx changed accordingly.
115 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
116 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
117 - The following is the doxygen comment of the typedef declaration
118 of gdcmagKey in src/gdcmCommon.h:
119 gdcmTagKey is made to old an "universal" (as in URL, Universal
120 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
121 A dicom tag allways has a group and an element, but a set of tags
122 embeded in various (optionally nested) sequences and sharing
123 the same group and element all share the same (group, element)
124 "identifier". Hence the (group, element) cannot be used as an
125 identifier (in gdcm we shall refer to a "TagKey") of a tag.
126 In order to construct a proper tag identifier (i.e. a key) we
127 consider the following definition of a TagKey:
128 - let Group, Element be the string representation of the
129 group and element dicom tag members,
130 - let ItemNumber be the string representation of the integer
131 index of the considered item number of a sequence,
132 Let the key of a tag embeded in a sequence, noted SeqTag, be
134 /ItemNumber#Group|Element
135 where "/", "#" and "|" are characters acting as separators.
136 Then the general form of a gdcmTagKey is given by:
137 Group|Element<SeqTag>
138 where <SeqTag> means NO or many instances of SeqTag.
139 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
142 but the gdcmTagKey of a tag "embeded" is the first item of
143 a sequence, itself nested in the third item of a sequence is the
145 0004|1220/2#0008|0082/0#0008|0090
146 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
147 order to hold the new sequence compatible key. Previously, the
148 GetKey() method would look in the underlying gdcmDictEntry.
149 - src/gdcmDocEntry.cxx:
150 -- constructor now copies the underlying DictEntry key, in the local
152 -- ::Print: displays the member Key, instead of the (group, element).
153 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
154 - src/gdcmDocEntrySet.h:xi
155 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
156 -- now has a new BaseTagKey member.
158 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
159 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
161 This poses the problem with the semantics of the following lines
162 LoadEntryVoidArea(0x0028,0x1201); // R LUT
163 LoadEntryVoidArea(0x0028,0x1202); // G LUT
164 LoadEntryVoidArea(0x0028,0x1203); // B LUT
165 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
166 to the long FIXME note for what the problem is. Nevertheless in
167 order to get things working the dicom dictionary was altered !
168 Please fix things urgently...
169 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
170 information), see above note on moving the member VoidArea. Nevertheless
171 the following entries previously correctly set as US are now inproperly
173 0028 1201 OW IMG Red Palette Color Lookup Table Data
174 0028 1202 OW IMG Green Palette Color Lookup Table Data
175 0028 1203 OW IMG Blue Palette Color Lookup Table Data
176 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
177 of gdcmDocEntry moved to gdcmSeqEntry.
178 * src/gdcmSeqEntry.cxx: STYLE.
180 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
181 * Test/TestAllEntryVerify.cxx minor fix and added comments.
183 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
184 * gdcmPython/testSuite.py: all the test suite in python is now moved
185 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
186 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
187 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
189 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
191 to avoid inclusion recursion until STL is reached.
192 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
193 mecanism. errno.h is not included in gdcm anymore.
194 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
195 (gdcmFormatError now inherits from gdcmFormatUnexpected).
197 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
198 gdcmData/TestAllEntryVerifyReference.txt
199 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
200 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
201 exception_on_error parameter.
202 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
203 - vtk/vtkGdcmReader.cxx changed accordingly,
204 - Example/*.cxx and Test/*.cxx changed accordingly.
206 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
207 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
208 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
209 enable_sequences removed from gdcmHeader constructor and dependencies.
210 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
211 * gdcmPython/demo/PrintHeader.py: dummy fix.
212 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
213 skip_shadow removed from gdcmHeader constructor and dependencies.
214 * Example/*.cxx and Test/*.cxx changed accordingly.
216 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
217 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
218 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
220 2004-07-21 Jean-Pierre Roux
221 * FIX Now, Parsing and Printing a DICOMDIR do work!
222 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
224 2004-07-20 Jean-Pierre Roux
225 * FIX Some brain damaged headers have Zero-Lenght fields
226 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
228 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
230 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
231 variable (instance of gdcmDebug) by a definition macro, and the instance
232 is now in static in the gdcmDebug class
233 * src/gdcmSQItem.h : (FIXME) remove an undefined method
234 * Test/PrintAllDocument.cxx : bug fix in the result of the test
236 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
237 * WARNING: ctest now depends more tightly on gdcmData. You should
238 check out gdcmData properly for things to run smoothly...
239 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
240 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
241 we need the pixels not be loaded in order to use the ValEntry
242 that displays position and size).
243 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
244 This is a C++ based equivalent of gdcmPython/testSuite.py that should
245 be deprecated. If you have any doubts about the advantages of a
246 modern scripting language (read Python) versus grass root C++ (i.e.
247 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
248 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
249 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
250 Anyhow, consider documenting the gdcmData images in
251 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
253 * Test/CMakeLists.txt:
254 - now uses TestAllEntryVerify.cxx
255 - specific comments on oldACR00001.ima (now renamed in gdcmData
256 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
257 gdcmData/TestAllEntryVerifyReference.txt
260 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
261 * src/*.[h|cxx] : typedef clean up
262 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
263 - TagKey renamed to gdcmTagKey (for external usage)
264 - VRKey renamed to gdcmVRKey (for external usage)
265 - removal of typedef duplication.
266 - Removed all unecessary inline keyword from class inline definitions.
267 - Some method|function(void) declarations replaced with method|function().
268 * src/jpeg/libijg12/jdhuff12.c:
269 - printf polluting ctest removed.
270 - TAB removal for comminting
272 - TestAllReadCompareDicom.cxx: added a test that compares all the
273 images in gdcmDataImages.h with corresponding images in
274 gdcmData/BaselineDicom/. When baseline images are not present
275 this test creates them.
276 Note: we need to validate each reference image, but before that
277 I'd like to rename them with a more explicit name...
278 - CMakeLists.txt: changed accordingly.
279 * Example/*.cxx: examples now only include gdcm.h (as opposed to
280 including each header needed).
282 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * Test/*.cxx and Example/*.cxx: moved some examples away from the
284 test suite to the Example directory. Are concerned:
289 - TestWriteSimple.cxx
290 * Test/CMakeLists.txt: added some comments on reasons for black listing
291 image gdcmData/oldACR00001.ima
293 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
294 * Test/CmakeList.txt: removed the following from black list (to be coherent
295 with removal from gdcmData):
296 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
297 - gdcm-MR-PHILIPS-16.dcm
299 Added the following because after last cvs update, they cause
300 ctest -R TestReadWriteReadCompare
302 - gdcm-MR-SIEMENS-16-1.acr
304 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
305 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
306 new comments in this file) we temporarily (sigh) move to a weaker
308 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
309 we don't need to black list the following images anymore:
310 - 8BitsUncompressedColor.dcm
312 - US-PAL-8-10x-echo.dcm
313 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
314 fixes and the beautified code ;-)
315 This fixes the bug introduced in version 1.42 (when beautifying)
316 that made the parsing of 8BitsRunLengthColor.dcm unproper.
317 Note: ctest was blind to this bug (this means we need to still
318 improve the test suite). The bug could be detected by using
319 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
321 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
322 and by displaying the (garbage) produced file temp.XDCM...
324 2004-06-29 Jean-Pierre Roux
325 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
326 - replace by uggly but working old code :-(
327 A lot of things should be OK again.
328 It's really urgent to have a test suite that *tests*,
329 to prevent Frog's beautifying sessions to break all the stuff
330 (twice, withing a fortnigh ...)
332 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
334 redundancy) to added Test/TestReadWriteReadCompare.cxx
335 * Test/CmakeList.txt: because the compare test of
336 Test/TestReadWriteReadCompare.cxx fails, the following images are
337 black listed: - 8BitsUncompressedColor.dcm
339 - US-PAL-8-10x-echo.dcm
340 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
341 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
342 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
343 and ad-hoc kludge. This kludge is now removed, and on encountering
344 such an image (OB field brain damaged) we set errno. Then in
345 ::FindDocLength() we "fix" the length as being ALL what remains
346 in the file (until EOF). We then proceed, hoping for the best...
347 This fixes a SegFault in ShowDicom when trying to write such an
349 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
350 (because TestWriteRead breaks on it, after a non conformal commit?).
351 ctest now runs properly, except for MakeDicomDir (which was allways
352 broken) and the Python related stuff (still not fixed).
354 2004-06-24 Jean-Pierre Roux
355 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
356 FIX : Test/TestReadWrite now iterates on all the file names
357 (instead of infinite loop)
358 ENH : Test/TestWriteRead now iterates on all the file names
360 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
361 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
363 2004-06-24 Jean-Pierre Roux
364 FIX : - now Write drops LUT Descriptors and LUTs (if any)
365 when SamplesPerPixel =3
366 - now Write is no longer confused by
367 'BitsAllocated = 12" and 'BitsStored=12"
368 - "UN" value representation Elements are now written correctly
369 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
370 ENH : - now gdcmHeader has its own Write methods
371 (in order to split the job that has not to be done
374 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
375 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
376 loop on the same image until memory went out.
377 Note: this means we still have gobs of memory loss in PrintDocument
378 * src/gdcmDocument.cxx: fixes problem on parsing on file
379 gdcmData/16BitsJpegLosslessGrayScale.dcm.
381 2004-06-24 Jean-Pierre Roux
382 FIX : Write - All the Sequences and Sequence Item are now written
383 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
384 is added a the end, when necessary.
385 - A lot of brain-damaged images, that were read correctly are
386 now written correctly
387 - length compatible BinEntry are now loaded correctly
388 (even for odd groups)
389 Note : only Explicit Value Representation was checked.
390 (question : is implicit VR really necessary for gdcm ?)
392 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * DEVELOPPER: added a proposition of coding style.
394 * src/gdcmDocEntry.h: removed every inline declaration (for test of
397 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
398 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
399 Use the gdcmDocEntry::Print() and Write() instead.
400 * src/gdcmDocument.cxx: bug fix.
402 2004-06-22 Jean-Pierre Roux
403 FIX : gdcmDocument.cxx
404 - Now we do recognize the JpegLossLess format (there was a misstyping in
405 code 'beautyfication' :-(
406 - Now we automaticaticaly load the Luts, if any
408 2004-06-22 Jean-Pierre Roux
409 In order : to write Sequences, whatever their imbrication level,
410 : to allow user to create his own Sequences
411 a lot of modif where necessary (adding, moving, or virtualising methods)
413 WARNING : save your own sources *before* cvs up !
416 ADD virtual void Write(FILE *fp, FileType filetype);
419 ADD virtual void Write(FILE *fp, FileType filetype);
420 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
423 ADD virtual void Write (FILE *fp, FileType filetype)=0;
424 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
425 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
426 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
427 ADD std::string GetEntryByName(TagName name);
428 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
430 std::string vr = "unkn",
431 std::string fourth = "unkn",
432 std::string name = "unkn");
433 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
434 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
435 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
436 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
437 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
438 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
439 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
440 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
443 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
444 ADD virtual std::string GetEntryByName (TagName tagName);
445 ADD virtual std::string GetEntryVRByName (TagName tagName);
446 REM virtual bool Write(FILE *, FileType);
447 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
448 FILE *_fp, FileType type);
449 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
450 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
451 REM virtual bool WriteEntries(FILE *_fp,FileType type);
452 REM virtual std::string GetEntryByName (std::string tagName);
453 REM virtual std::string GetEntryVRByName (std::string tagName);
454 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
455 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
456 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
458 std::string vr = "unkn",
459 std::string fourth = "unkn",
460 std::string name = "unkn");
461 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
462 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
463 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
464 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
467 ADD virtual void Write(FILE *fp, FileType filetype);
470 ADD virtual void Write(FILE *fp,FileType filetype);
473 ADD virtual void Write(FILE *fp, FileType filetype);
474 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
475 REM std::string GetEntryByNumber(guint16 group, guint16 element);
476 REM std::string GetEntryByName(TagName name);
479 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
481 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
483 The default constructor invoked by the line
484 gdcmHeader *f1 = new gdcmHeader( header );
485 was gdcmHeader::gdcmHeader(bool) instead of the expected
486 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
487 Hence the parsing wasn't executed... See also below.
488 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
489 as explicit constructor didn't do the trick to fix the above problem.
490 Could anyone explain why ?
491 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
492 properly calls gdcmValEntry::Print() (that was weed out from
493 code related to gdcmBinEntry).
495 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
496 * In order to fix memory leaks:
497 - Test/TestWriteSimple.cxx: added cleaning of free store through
499 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
500 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
501 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
502 (through the call to ::AddDicomDirMeta()) or the destructor
503 would crash when deleting uninitialized ::metaElems].
504 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
505 - src/gdcmDocument.cxx:
506 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
508 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
509 was causing memory leaks.
510 - src/gdcmSQItem.cxx:
511 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
512 cleanly handled with polymophism: sorry but my milage is low).
513 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
514 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
515 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
516 This avoids SegFaulting.
517 - src/gdcmSQItem.h: coding style.
519 - Test/TestWriteSimple still severely sucks. The output image content
520 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
521 damaged when displayed with vtkgdcmViewer.
522 - on memory leaks: TestWriteSimple leaks really less (see entry
523 of 2004-06-18 in Changelog file for the call to valgrind).
524 - on segfaults: ctest now passes all the tests but one (no more
526 * Erroneous leading white fix:
527 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
528 white[s] (as opposed to from >> xxx, that removes it [them].
529 - src/gdcmTS.cxx: ditto.
530 - gdcmPython/testSuite.py: dirty related kludge removed.
531 * src/*: remaining references to gdcmParser removed.
532 * src/*[cxx|h]: added copy[way]left header.
535 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * In order to fix writing of dicom files:
537 - Test/TestWriteSimple.cxx: a simpler example of writing.
538 - Test/CMakeLists.txt changed accordingly.
539 - src/gdcmDocument.cxx:
540 -- The destructor now recursilvely removes potential sequences.
541 -- Bug fix in ::IsJPEG2000()
542 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
543 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
545 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
546 to only declared) and build on top of
547 ::GetDocEntryByNumber(guint16, guint16).
548 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
549 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
550 for usage in destructor and treatement of promotion in
551 ::ReplaceOrCreateByNumber().
552 - src/gdcmSQItem.cxx: destructor should better handle his job.
553 Test/TestWriteSimple now runs (or at least it DOES something).
554 * We can now start hutting memory links. A good starting point is:
555 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
556 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
557 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
559 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * Valgrind note: after Mathieu Malaterre teached me how to read
561 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
563 Using gcc, you can force the STL to use malloc and to free memory as
564 soon as possible by globally disabling memory caching.
565 With 3.2.2 and later, you should export the environment variable
566 GLIBCPP_FORCE_NEW before running your program.
567 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
568 simply vanish (it is still not clear to me, whether this means that
569 STL std::string leaks or if valgrind believes it leaks...).
570 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
571 running bin/gdcmTests makeDicomDir):
572 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
573 - Test/makeDicomDir.cxx now properly traps empty lists and returns
575 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
576 SegFaulting (I drowned in DicomDir related code when trying to
577 understand why the list is empty...).
578 * src/gdcmDocument.h: first BSD license header try.
579 * Doc/License.txt added.
581 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * src/gdcmDocument.[h|cxx]:
583 - Clean up of the Transfer related predicates. They are now all based
584 on new method isGivenTransferSyntax, that (should) handle properly
586 - general clean up, simplification, and coding style.
587 - Specific clean up of Parse7FE0() (umproperly named actually).
588 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
590 2004-06-14 Jean-Pierre Roux
592 - fix the display of Sequence Delimitor (SQDepthLevel pb)
593 - fix the display of SQItem ordinal number
594 - add the GetSQItemByOrdinalNumber method
595 - remove some useless never written private methods
597 2004-06-14 Jean-Pierre Roux
599 - adding a constructor taking a gdcmDocEntry as an input param
600 - ReplaceOrCreateByNumber now returns :
601 a gdcmBinEntry * if a Binary (void *) value is passed as a param
602 a gdcmValEntry * if a string value is passed as a param
604 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
605 according to the param type (no longer sets a gdcmDocEntry)
606 - GetValEntryByNumber, GetBinEntryByNumber added
607 - NewValEntryByNumber and NewBinEntryByNumber added
609 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
611 - GetSQItemNumber and SetSQItemNumber added, to provide
612 a (relative) Item identier inside a given Sequence
613 \warning : some pb remaining around this number
615 - AddEntry now takes the Item Number as a param
617 - adding a constructor taking a gdcmDocEntry as an input param
619 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
620 * Memory leak hunt with the following command:
621 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
622 --show-reachable=yes gdcmTests PrintDocument
623 It looks like many (all?) leaks are due to the STL (or a bad usage
624 of the STL. The lines producing the leaks now have a comment with
625 a "MEMORY LEAK" tag: you can retrieve them with
626 grep "MEMORY LEAK" src/*
627 Here are two typical examples which I can't help fixing:
632 char * test = "babo";
633 name = test; //// <--- valgrind detects 960 bytes lost in
634 //// call to std::string::operator=(char const*)
635 name.clear(); //// Doesn't help !
643 std::cout << "Type a bunch of characters followed by RETURN: ";
644 getline(std::cin, line); //// <--- valgrind dectects a loss
645 //// of 1320 bytes in call to
646 /// std::basic_istream<>& std::getline<>
652 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * src/gdcmHeader.[cxx|h]:
654 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
655 and related, moved away to gdcmDocument.
656 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
657 the corresponding protected accessors of inherited class
658 gdcmDocument, removed ! As a consequence gdcmFile had to be
659 declared friend of class gdcmDocument (see below).
660 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
661 - Clean up of undefined or unused methods.
662 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
663 account the changes to gdcmHeader.h).
664 * src/gdcmDocument.h:
665 - gdcmFile is now a friend class (in order to take into account the
666 changes to gdcmHeader.h).
667 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
668 (see changes to gdcmHeader.h).
669 - Accessors (reading on the form GetEntry*) are now public.
670 - Clean up of undefined or unused methods.
671 * src/gdcmDocument.cxx:
672 - adaptation to changes to gdcmDocument.h
673 - ::OpenFile now writes a verbose message when file cannot be opened.
674 - some std::string properly set to VRKey
675 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
676 references to gdcmDocument.
677 * Test/TestFindTags.cxx: changed accordingly to above changes.
678 * gdcmPython/testSuite.py: adapted to renaming of acr files in
679 cvs repository gdcmData.
681 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
682 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
683 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
684 conflicts with gdcmValEntry::voidArea.
685 * src/gdcmValEntry.cxx: unmatching comment wiped out.
686 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
687 Value representation between StringRepresentable and BinaryRepresentable.
688 * src/gdcmDocument.cxx:
689 - method ParseDES: proper indentation restored and usage of
690 gdcmVR::IsVROfGdcmStringRepresentable wired in.
691 - method LoadDocEntry: the fingerprint left in the SetValue() of
692 unloaded entries (length > MaxSizeLoadEntry) had curiously been
693 removed. Reverting to previous code segment with the proper
694 dynamic_cast< gdcmValEntry* >.
695 Note: this was (partially) breaking the python test suite
696 (gdcmPython/testSuite.py) that made usage of the above
697 fingerprint to check presence of "Pixel Data".
698 * src/gdcmDocEntry.h: coding style.
699 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
700 now taken into account.
701 * gdcmPython/gdcm.i: adaptation to the new internal representation
702 of gdcm (exit gdcmParser, hello gdcmDocument).
703 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
705 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
706 anymore, but instead prints the loaded Python dictionary.
707 * .... alas, the python testSuite is still broken.
709 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
710 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
712 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
713 * src/gdcmUtil.h : export methods
715 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
716 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
718 * Initial addition of automatic python testing
719 * Initial addition of automatic image comparison
721 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
722 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
723 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
725 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
726 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
727 * Test/ShowDicom.cxx : bug fix for msvc compilation
728 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
730 2004-05-04 Jean-Pierre Roux
731 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
732 new concepts (and new classes) :
733 a 'gdcmDocument' is composed of a set of Doc Entries, that are
734 - elementary gdcmDocEntries (former gdcmHeaderEntries)
735 - Sequence Doc Entries (gdcmSeqEntries)
736 a Sequence is composed of Items.
737 Each item is a set of Doc Entries (this is recursive)
738 The non uniqueness of the 'Dicom tag' is due to this recursivity
739 (never taken into account)
740 Our unability to add a new 'entry' in the header
741 at the proper location (neither in the H-Table (map or multimap),
742 nor in the Chained List is also due to this recursivity.
743 Don't try, right now, to use/modify/compile these new sources :
745 We just commit all the stuff, 'as is', in order not to loose it.
747 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
748 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
750 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
751 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
752 file prefix (SetFilePrefix)
754 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
755 * Add a new test: ShowDicom, for now this is just the c++ version of
756 checkRead.sh, later it will be able to compare the image read against a
758 * Replace the DEBUG on the stack with a global entry in cmake interface:
759 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
761 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
762 * Add an example subdir, with a real example on how to read + write a
765 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
767 * Doc/CMakeLists.txt: the main page is now properly differentiated
768 between the developper and user version.
769 * Doc/doxygen.config.in: dropped search related obsolete flags
770 * src/gdcmParser.h, gdcmHeader.h: doxygenation
772 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
773 * DEVELOPPER: added some helpfull comments for compile/test/install
776 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
777 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
778 src directory, now generated in the build dir.
779 2. Tests as mentionned smarter
781 4. Add a new method in gdcmDict that return the PubDict by name
782 this is interesting for 3rd party lib like ITK,
783 where we could set the institution name / patient name...
785 * ENH: 1. Now the test suite is working for real
786 2. All binaries are now output in the gdcm-bin directory
787 (this was not true before)
789 2004-04-28 Jean-Pierre Roux
790 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
791 SeQuence indented printing of Dicom Header.
792 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
793 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
794 Computation of SQDepthLevel is now part of gdcmHeader constructor
795 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
796 tree-like structure of a Dicom Header.
797 * FIX Test code cleaning
799 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
800 * ENH: Adding automatic testing
801 1. Need a DartConfig.cmake to submit to public
802 2. Add a test driver gdcmTest.cxx
803 3. gdcmTestMain, an helper for the main test driver gdcmTest
804 4. Files in Test don't have a main anymore, this becomes interesting
805 when we add more and more tests, thus dsw don't have to load
807 * ENH: Adding a GDCM_DATA_ROOT for testing
808 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
809 one file instead of seven + some small cleanup
811 2004-04-22 Jean-Pierre Roux
812 * ENH Minor changes to the Print() methods.
813 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
814 Header printing. Example given with :
815 > PrintHeader fileName 2 new
816 (SQ based tree-like structure still to be done for the Header ...)
818 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
819 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
820 1. I have added some unsigned where needed
821 2. Some function parameter not used -> (void)
822 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
823 4. g++ don't like character '\' in comment
824 5. #define jpeg_create_decompress jCreaDecompress
825 this really need to be fixed
826 6. virtualize destructor of gdcmObject ... leakage
827 7. sscanf(g->first.c_str(),"%x",&gr_bid);
828 this also really need to be fixed
829 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
830 remove compression file
831 (as we only do decompression, right ?)
832 * ENH: Change malloc/calloc/free with c++ equivalent
834 2004-04-21 Jean-Pierre Roux
835 * FIX gdcmHeaderHelper::GetXSpacing
836 when a single value is found (bug ?), xpacing is now
837 defaulted to yspacing
839 2004-04-19 Jean-Pierre Roux
840 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
841 * ENH add parameters :
842 bool exception_on_error = false,
843 bool enable_sequences = false,
844 bool ignore_shadow = false
845 to the gdcmFile constructors to be full gdcmParser compliant
846 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
847 to allow reading of PAPYRUS 3.0 files
849 2004-04-06 Jean-Pierre Roux
850 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
852 2004-04-02 Jean-Pierre Roux
853 * ADD : Test/checksequence.sh, for a general recap on SQ pb
854 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
855 for Philips spurious Tag fffe|0000 while rewritting Dicom files
857 2004-03-30 Jean-Pierre Roux
858 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
859 for ACR file, written out as DICOM files (hope so...)
861 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
863 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
864 moved to base class gdcmParser and only the specialisation is kept
866 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
867 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
868 already does the job.
869 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
870 (to be consistent with gdcmParser::WriteEntries).
872 2004-03-30 Benoit Regrain
873 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
874 upate of the object's instance. It's passed to 2 in the unfavorable
875 case : one in the ExecuteInformation, one in the ExecuteData
877 2004-03-29 Jean-Pierre Roux
878 * ENH : Check on file type to be written moved
879 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
880 * FIX : gdcmObject::ResetBoundaries now stops properly
881 when end-of-list is reached
882 : gdcmVersion modified (as Benoit Regrain asked)
884 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
885 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
886 * src/gdcmUtil.cxx: added forgotten iostream include.
887 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
888 equivalent to ExplicitVR in existing code).
890 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
891 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
892 now contains all the gdcmGlobal related code.
893 * minor coding style and doxygenation changes.
895 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
896 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
897 now contains all the Debug related code.
898 * minor clean-up of includes in src/*.cxx
899 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
900 CreateCleanString) removed.
901 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
902 * Doc/DoxyMainPageUser.txt added.
903 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
904 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
907 2004-03-24 Jean-Pierre Roux
908 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
910 2004-03-23 Jean-Pierre Roux
911 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
912 big endian made volumes
913 * ENH Now gdcmParser constructor and destructor are protected to forbid
914 end user to instanciate class gdcmParser
915 (only gdcmHeader and gdcmDicomDir are meaningfull)
917 2004-03-22 Benoit Regrain
918 * FIX : src/gdcmDicomDir.cxx : make windows compilable
919 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
920 gdcmSerie to gdcmDicomDirSerie
922 2004-03-19 Jean-Pierre Roux
923 * ENH Now the tree-like structure describing a DICOMDIR comming from
924 an already existing DICOMDIR file is consistent with
925 the home-made tree-like structure build ex-nihilo
926 or build from the files held (recursively) in a Directory
927 functions gdcmDicomDir::CheckBoundaries()
928 gdcmObject::SetBoundaries() added
930 2004-03-17 Jean-Pierre Roux
931 * REM (Eric Boix bug) : removal of meaningless
932 gdcmDicomDirImage::NewImage function.
933 * FIX now file names and directory name are written properly in the
935 * FIX now gdcmDicomDir constructor may be call without any trick
938 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
939 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
940 of gdcmDicomDirImage::NewImage as empty function.
942 2004-02-28 Jean-Pierre Roux
943 * ENH add gdcmDicomDir:NewPatient
944 add gdcmDicomDirPatient:NewStudy
945 add gdcmDicomDirStudy:NewSerie
946 add gdcmDicomDirSerie:NewImage
947 to allow making gdcDicomDir object.
948 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
949 (as opposite to the gdcmHeader chained list)
951 2004-02-11 Benoit Regrain
952 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
953 when using from python
955 2004-02-10 Benoit Regrain
956 * FIX : bug fix in the gdcmDirList for the recursivity in directories
957 * FIX : in gdcmDicomDir when the directory is empty
958 * ENH : add callback and methods to get the progression of dicomDir
961 2004-02-06 Jean-Pierre Roux
962 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
963 - GDCM_META added to gdcmDicomDirType
964 - class gdcmMeta created
965 * ENH : - A brief summary is now displayed at the beginning of
966 'testDicomDir' to help disaster magnitude estimation
967 * REM : Now useless Test/explDICOMDIR.cxx
969 2004-02-05 Benoit Regrain
970 * ENH : add methods in gdcmObject to get the hash table or the list of
972 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
973 * FIX : wrapping python for TagHeaderEntryHT
975 2004-02-04 Benoit Regrain
976 * FIX : even length for some strings when writting the dicom dir
977 * FIX : sort the images in the dicom dir
978 * FIX : Bug fix for python use of dicom dir
979 * ADD : a python demo
981 2004-02-04 Jean-Pierre Roux
982 * FIX : Final solution (?) for icone embedded images
983 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
984 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
985 add groups 6002, 6004, 6006, to allow 'clean' parsing of
986 gdcmData/gdcm-MR-SIEMENS-16.acr1
987 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
988 to make full checking easier
990 2004-02-04 Benoit Regrain
991 * FIX : WriteEntries : coding style & logic in parameters
992 * FIX : Set the elements to create the DicomDir in a dictionary file
994 2004-02-03 Benoit Regrain
995 * gdcmDirList : to parse a hard drive directory in recursive (or not)
996 * gdcmDicomDir : add the load of directory
997 * Bug fix and print add-on
999 2004-02-03 Jean-Pierre Roux
1000 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1001 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1002 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1003 * FIX gdcmParser.cxx : 'group length' elements are now considered
1004 as integers, even for shadow groups, when file is Implicit VR
1006 2004-02-02 Jean-Pierre Roux
1007 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1009 of the last synonym :-(
1010 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1012 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1013 * FIX taking into account the possible 7fe0,0010 multiplicity
1014 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1015 to allow removal of references to 7fe0,0010, to deal with
1016 ACR-NEMA images, when 0028,0200 is meaningfull
1018 2004-01-31 Jean-Pierre Roux
1019 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1020 no longer writes 'Un' on disk
1021 * FIX SQ elements with actual length are now dealt with corectly
1022 * FIX gdcmFile::WriteBase make the difference, for color images, between
1023 the length (for Palette expanded images)
1024 and Raw Length (non expanded image + Palette)
1025 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1026 (that broke Write). Replaced by UL.
1027 Aware user will reload the field if he
1028 thinks it's necesssary
1030 2004-01-30 Jean-Pierre Roux
1031 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1032 when 'dirty Acr' is found, to be compliant with the new
1033 IsReadable() methods.
1035 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1036 (no DOUBLE images in kosher DICOM,
1037 but so usefull for people that miss them ;-)
1039 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1040 DICOMDIR related utilities (not checked as Windoze compliant)
1042 2004-01-28 Jean-Pierre Roux
1043 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1045 2004-01-27 Jean-Pierre Roux
1046 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1047 to allow skipping the shadow elements, to save memory space.
1048 The TRUE value for this param has to be used
1049 with a FALSE value for the 'enable_sequence' param.
1050 ('public elements' may be embedded in 'shadow Sequences')
1051 * gdcmHeader methods now deal with 'embedded icones images' in the header
1052 (even when an 'icone image sequence' is announced by the
1053 element (0x0088,0x0200), but there is NO icone at all ...
1055 * gdcmHeader sometimes Image Location value doesn't follow
1056 the supposed processor endianity (see gdcmData/cr172241.dcm).
1059 * gdcmHeader add the method
1060 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1061 to get *all* the Header Entries with the same tag.
1062 GetHeaderEntrySameName is probabely *useless*
1063 (no meaning : Name is *not* an identifier within the Dictionnary)
1065 2004-01-26 Benoit Regrain
1066 * Bug fix in the print of hexadecimal representations. Remove long fields
1067 in the print and add a third level of print to print them
1069 2004-01-23 Benoit Regrain
1070 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1071 * Bug fix on test suite after remove the strip made on not string fields
1072 * Split the IsReadable method between gdcmParser which test that the file
1073 is dicom and gdcmHeader which test that it's an image file
1075 2004-01-22 Benoit Regrain
1076 * DicomDir : clean code, add methods, set variables in protected or private
1077 * gdcmUtil : bug fix for the clean string method
1079 2004-01-19 Benoit Regrain
1080 * Add the use of shadow dictionaries
1081 * bug fix and coding style
1083 2004-01-19 Benoit Regrain
1084 * src/gdcmFile.cxx : bug fix concerning the close of file
1085 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1086 * Add the update of header entries using the shadow library
1088 2004-01-19 Benoit Regrain
1089 * removal of file gdcmHeader2.cxx
1090 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1091 inheriting from gdcmParser. This split is to prepare the integration
1092 of dicom dir parsing
1093 * bug fix under python
1095 2004-01-16 Jean-Pierre Roux
1096 * REM removal of class gdcmHeaderEntrySet
1097 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1098 * ADD add file gdcmHeader2.cxx
1099 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1101 2004-01-15 Benoit Regrain
1102 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1103 entries created while parsing the header. Thus, they will be destroyed
1104 when the gdcmDictSet will be destroyed
1105 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1108 2004-01-15 Benoit Regrain
1109 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1110 made a fatal error because of the memory release at the end of program.
1111 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1112 some memory and vtk seems to have some problems with that.
1113 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1115 2004-01-14 Benoit Regrain
1116 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1117 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1118 * src/*.[h|cxx] : make changes due to class name changes
1119 * gdcmPython/demo/*.py : bug fix due to method names
1121 2004-01-13 Benoit Regrain
1122 * src/*.[h|cxx] : coding style
1123 * vtk/*.[h|cxx] : coding style
1125 2004-01-13 Benoit Regrain
1126 * gdcmPython/testSuite.py : test the readable flag of file for tests
1127 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1128 It's lied to the stl compilation by MSVC (windows, always windows...)
1129 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1131 2004-01-12 Benoit Regrain
1132 * src/*.h : add comments
1133 * src/gdcmDictSet.h : set the method BuildDictPath in public
1134 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1135 directly setted in the source code
1136 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1139 2004-01-09 Benoit Regrain
1140 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1141 * setup.py : use a reference to gdcmVERSION
1143 2004-01-07 Benoit Regrain
1144 * Modification to compile with the distutils.
1147 2003-12-10 Benoit Regrain
1148 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1149 can use a gdcmHeaderHelper to load datas
1150 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1151 made in the source code
1153 2003-12-10 Benoit Regrain
1154 * Update Windows projects and .cvsignore files
1156 2003-11-12 Jean-Pierre Roux
1157 * ENH gdcmHeader constructor has one more parameter (default value : false)
1158 that allows the user to 'go inside' the SeQuences only
1160 gdcmElValSet:Print takes it into account
1162 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1163 * ENH: Update gdcmPython/CMakeLists
1164 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1165 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1167 2003-11-10 Jean-Pierre Roux
1168 * FIX : gdcmHeader::LoadElements is now based
1169 on the ListTag listElem member,
1170 not longer on the TagElValueHT tagHt member
1171 * ENH : PrintPubElVal shows (temporarily) both results,
1172 with the tagHt member and the listElem member.
1173 (it's easier to 'see' the problems when using Printheader)
1175 * FIX : old private member LgrElem is now splitted into
1176 ReadLength : Length actually found on disk (updated only
1177 if bug fixing is necessary), for internal
1179 UsableLength : Updated by FixFoundLength, to fix a bug
1180 or to allow Parser going on.
1181 Will allow to re-write a kosher header when a SeQuence
1182 with a length (not 0000) is found
1183 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1184 because gdcmElValSet::Add does not update ListElem
1187 2003-11-07 Jean-Pierre Roux
1188 * FIX misstyping in Transfert Syntax name table
1189 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1190 when they have an actual length (not 0000 nor FFFFF)
1191 (Nobody should care of it, but DICOMDIR explorers)
1193 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1194 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1196 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1197 * ENH: vtkGdcmReader now supports LUT !
1198 (vtkgdcmViewer for now is not able to use them though)
1200 2003-11-05 Jean-Pierre Roux
1201 * in testSuite.py : new files names for checking the package
1202 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1203 that returns the pixel area size to the *aware* (vtk) user
1204 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1206 2003-11-05 Benoit Regrain
1207 * in testSuite.py : Modify the rules for checking the paths
1208 : Explicit error messages
1209 * in __init__.py : Related modif
1211 2003-11-03 Jean-Pierre Roux
1212 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1213 to be used by aware (vtk) users that want to manage
1214 LUT (and no to turn the PALETTE image into an RGB pixels one)
1215 * GetPixelType now returns 8U for 24 Bits images
1216 (vtkGdcmReader compliant)
1218 2003-10-31 Jean-Pierre Roux
1219 * Removal of *all* gdcmData images and add them again
1220 in order to loose the 'history' of un-anonymised images
1222 2003-10-31 Jean-Pierre Roux
1223 * RMV : removal of useless jBitsInJsample.h
1224 for both 8 and 12 Bits JPEG Lossy Libraries
1226 2003-10-31 Jean-Pierre Roux
1227 * ENH : Add the functions gdcmFile::GetImageDataRaw
1228 gdcmFile::GetImageDataIntoVectorRaw
1229 that act as GetImageData and GetImageDataIntoVector
1230 except the making of an RGB Plane from Gray Plane + LUT
1231 Intended to aware (vtk) users who know how to manage
1234 GetLUTRGBA return a R,G,B,A LUT if any
1235 lgrTotaleRaw gives the 'Raw' length
1236 GetImageDataRaw returns the gray Plane
1237 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1238 (They stay Grey, just like with other Dicom viewers :-(
1240 2003-10-30 Jean-Pierre Roux
1241 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1243 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1244 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1245 being coherents dicom files.
1247 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1248 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1250 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1251 * ENH: Two steps is necessary to please VC++ compiler...
1252 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1253 * ENH: Add include dir to medcon lib
1254 * FIX: only one function is being exported for now !
1255 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1257 2003-10-29 Jean-Pierre Roux
1258 * adding gdcmHeader::GetLUTRGBA
1259 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1260 --> Mathieu, the modif u're waiting for is not yet committed
1261 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1263 2003-10-27 Jean-Pierre Roux
1264 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1265 00191113.dcm DermaColorLossLess.dcm
1266 MxTwinLossLess.dcm RadBWLossLess.dcm
1267 * ENH: For version prior to vtkImageViewer2 -r 1.19
1268 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1270 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1271 * Removal of ido stuff in CMakeLists.txt
1273 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1274 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1275 * FIX: remove a call to ->Modified ... see comments
1276 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1278 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1279 * FIX: Problem with path for libvtkgdcmPython
1280 * ENH: Try adding a search script for python site-package
1281 * RMV: Remove some file from medcon lib that are not necessary
1282 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1283 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1284 * FIX: More pragma disable fro VC++,
1285 I don't think I break something as it is also disable in VTK/ITK.
1286 But it fasten debug compilation time.
1288 2003-10-23 Jean-Pierre Roux
1289 * gdcm now deals with 16 Bits Run Length Encoded images
1290 (they are compressed as 2 planes images,
1291 one for the high Bytes, the other for low Bytes)
1293 2003-10-22 Jean-Pierre Roux
1294 * Now CheckRead takes into account :
1295 - the bugged 'Leonardo' Siemens images
1296 - the XA images, sent thru the burning VPRO station
1297 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1300 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * FIX: When copying a Makefile.am to CMakeLists.txt
1302 one should remove the '\'
1304 2003-10-22 Jean-Pierre Roux
1305 * in gdcmData adding a bugged 'Leonardo' Siemens image
1306 (wrong lengths in header)
1307 OK with gdcm, KO with the other viewers :-)
1308 * add a GE dlx XA image, thru the VEPRO burning station
1311 2003-10-21 Jean-Pierre Roux
1312 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1313 for a brutal checking of vtkgdcmViewer compliance
1315 2003-10-21 Jean-Pierre Roux
1316 * add the files for 'xmedcon' Jpeg Lossless library
1317 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1319 2003-10-21 Jean-Pierre Roux
1320 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1322 2003-10-21 Jean-Pierre Roux
1323 * garbage Siemens 'Leonardo' images dealt with
1324 (the patch is easy to remove)
1325 * cosmetic changes to avoid warnings
1327 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1328 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1329 no need to press 'r' now.
1331 2003-10-20 Jean-Pierre Roux
1332 * upgrade of checkRead.sh checkWrite.sh according
1333 to new Jpeg Lossless decompressor
1334 * add US.3405.1.dcm, a genuine RGB medical file ...
1335 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1336 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1338 2003-10-15 Jean-Pierre Roux
1339 * general anonymisation in gdcmData
1340 * adding the 'color files' from
1341 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1342 * adding some well knowed bugged-header images
1343 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1344 waiting for their inclusion in Python testsuite
1346 2003-10-15 Jean-Pierre Roux
1347 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1348 no longer seg faults when file is not found
1350 2003-10-14 Jean-Pierre Roux
1351 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1354 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1355 * TODO: *.in file to genereate a UseGDCM later
1357 2003-10-14 Jean-Pierre Roux
1358 * Some supposed-to-be Dicom Images have no preamble.
1359 OpenFile takes it into account
1360 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1361 * Missing elements added in dicomV3.dic
1362 (just to be affraid : have a look at
1363 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1364 and do it again next year ;->
1366 2003-10-13 Jean-Pierre Roux
1367 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1368 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1369 But there are NOT. It's fixed !
1371 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1372 * FIX: "jpeglib.h" was not found on VC++
1373 * FIX: vtkgdcm was not being installed
1375 2003-10-10 Jean-Pierre Roux
1376 * ENH : OpenFile closes the file if it *really* doesn't look like
1377 an ACR-NEMA / DICOM one.
1378 * FIX : testWrite no longer writes an empty file if the source file
1379 is not gdcm Readable
1380 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1383 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1384 * FIX: CMake generate now documentation
1385 * ENH: out of source doc build !
1386 * ENH: Generate both user and dev documentation
1387 * ENH: Should work on windows too
1388 * ENH: Only one doxygen config.in file is needed
1389 * FIX: make install should be ok now on ùnix plateform
1390 * FIX: PATH to dictionary was wrong (missing /)
1391 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1393 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1394 * vtkGdcmReader is now able to read rgb dicom file.
1395 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1396 * added a gdcmViewer to vtk test, use mouse to control
1397 window level & window width
1399 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1400 * CMake-ification of gdcm, we have now two build system
1401 * FIX: on cygwin Wsock32 doesn't exist
1402 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1404 2003-10-06 Emanuel Ollart
1405 * FIX : compilation process wad broken.
1406 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1408 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1409 * change gdcmViewer -> vtkgdcmViewer
1410 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1412 2003-10-06 Jean-Pierre Roux
1413 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1414 ( e.g : well known GE images with a wrong elem length,
1415 : Philips MRI Images with a wrong Huffman table)
1416 * still to be done : allow the reading of bugged LEONARDO Siemens images
1418 2003-10-03 Jean-Pierre Roux
1419 * Odd length strings are padded with '\0' (not with spaces,
1420 to remain compliant with already defined strings,
1421 like Transfert Syntax UID and others)
1423 2003-10-03 Jean-Pierre Roux
1424 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1425 to allow displaying RGB images (not only by affim ;-)
1427 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * vtkGdcmReader is now able to read rgb dicom file.
1429 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1431 2003-10-03 Jean-Pierre Roux
1432 * A few nasty patches to allow the reading of a lot of nasty images
1433 ( e.g : well known GE images with a wrong elem length,
1434 : Philips MRI Images with a wrong Huffman table)
1435 * still to be done : allow the reading of bugged LEONARDO Siemens images
1437 2003-10-03 Jean-Pierre Roux
1438 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1440 2003-10-03 Jean-Pierre Roux
1441 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1442 to allow displaying RGB images (not only by affim ;-)
1444 2003-10-03 Jean-Pierre Roux
1445 * gdcmFile::GetImageDataIntoVector now
1446 - deals with MultiFrames MultiFragments Run Length Encoded files
1447 - deals with YcBcR (YBR_FULL) files
1448 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1449 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1451 (no sample found :-(
1453 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1454 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1455 Two reasons: - clear things
1456 - third parties acces gdcm through header files, so won't
1457 suffer anymore VC++ complains
1459 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * add argv[1] in testvtkGdcmReader.cxx
1463 2003-09-24 Jean-Pierre Roux
1464 * The lines are now eigthy characters long.for
1465 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1467 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1468 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1469 char* to std::string. Thus, the use of strdup becomes useless. (see
1470 previous commis of Malaterre)
1471 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1472 before the last Malaterre's commit.
1474 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1475 * This commit should fix the Debug building under VC++, the problem
1476 was mainly a mixture of debug and release lib being loaded at startup.
1477 * I also remove a depency to a specific C function: strdup. Because I had
1478 to force the link to msvcrtd (whereas strdup is in libc).
1480 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1481 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1482 located in the gdcmCommon.h file. All use of reference of tha has been
1483 changed to now use the variable GDCM_UNFOUND.
1485 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1487 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1488 Dicom dictionary. The test suite can now be run again. Note:
1489 I'm note very happy with the " (RET)" changes. I believe this
1490 RETAINED comment should be dropped when parsing the dictionary.
1491 - PACKAGER corrected
1493 - AUTHORS updated and now in alphabetical order
1494 * Makefile.am now exports gdcm.dsw for Windoze users.
1496 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1497 * cygwin complains about missing std:: in subdir Test/
1499 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * remove some methods that are now in gdcmHeaderHelper
1502 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1503 * vtkGdcmReader set spacing and origin correctly
1505 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * Fix a few delete/delete[] mismatch
1508 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1509 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1510 interpretation to data given by gdcmHeader. For instance there are
1511 heuristics to get informations (look at different places).
1512 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1513 sorting DICOM images based on different strategies.
1514 * modified Makefiles accordingly.
1516 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1517 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1518 when building in debug mode
1519 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1520 src/win32/gdcmdll.dsp
1521 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1523 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1524 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1527 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1528 * src/win32/libgdcmjpeg12.dsp was not dos format
1529 * src/win32/libgdcmjpeg12.dsp :
1530 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1531 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1533 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1534 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1536 * src/gdcmFile.cxx : bug fix in affectation type
1537 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1538 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1539 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1540 symbols... future problem ?
1542 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1543 * src/win32/libgdcmijpeg12.dsp was missing
1544 * modified gdcm.dsw accordingly
1546 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1547 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1549 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1550 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1551 commit of JPR (before his hollidays to facilitate our work).
1552 * setup.py : bug fix in code. Modifications made while the last commit
1553 of JPR. The code hasn't been tested before the commit... it's so
1554 useless to make that (for best programmer that is JPR) !!!
1556 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1557 * tagged the current version as Version0_3 (i.e. version 0.3)
1559 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1560 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1561 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1562 * *.dsp : modifications to use new libgdcmijpeg8 library
1563 * setup.py : bug fix on VTKPATH variable
1564 * PACKAGER : adding all concerning windows
1566 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1567 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1569 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1570 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1571 test suite reported error.
1572 * PACKAGER file added (describes what a packager must do when
1573 packaging a new release).
1574 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1575 * configure.in: upgraded version number to 0.3.0
1576 * fixing build of rpm (through rpm -ta):
1577 - Doc/Makefile.am exports proper doxygen files
1578 - src/jpeg/libijg8/Makefile.am exports the include files.
1580 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1581 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1582 * src/gdcmHeader.h : formatting code
1584 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1585 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1586 We were obtaining error message from vtk. Now, creation of file list
1587 is made in an internal list to prevent this problem.
1588 Bug fix when output is empty.
1589 Bug fix in update of progress value. Previous commit for this was a bad
1591 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1593 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1594 * src/gdcmHeader.h : added method to get the file name
1595 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1596 files. Added method to remove all files on the input
1597 Added FIXME comment concerning the bad parsing of header made by
1598 ExecuteInformation method (in ExecuteData method)
1600 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1601 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1602 when using make instal.
1603 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1604 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1606 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1607 * setup.py : adding include dir of jpeg lib to compile all sources
1608 * */Win32/*.dsp : JPR fix for windows compilation
1610 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1611 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1613 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1614 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1616 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1617 * setup.py is again effective on un*x (takes into account the
1618 addon of the jpeg library)
1619 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1620 * Doc/Doxy* updated (includes above enhancements)
1621 * INSTALL now points to web documentation
1623 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1624 * src/gdcmHeader.h doesn't make unnecessary reference to
1626 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1628 * src/gdcm*.[cxx|h] :
1629 - to allow compilation with gcc 3.x
1630 -- clean up of STL usage (added explicit usage of std::)
1631 -- small fixes on exceptions.
1632 Note: linking not tested !
1633 - clean of doxygen comments to avoid warnings at documentation
1635 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1636 dependent convertion).
1638 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1639 * Clean up of previous JPR garbage commit (not even commented in the
1641 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1642 - moved all jpeg related files from src to src/jpeg/libijg8, with
1643 addition/modification of Makefile.am and configure.in.
1644 - the testSuite is still brain damage (not guilty).
1646 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1647 * WrapVTK.py : modifications to get correctly vtk source files to
1649 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1650 (FileName -> Filename)
1652 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1653 * vtk/vtkGdcmReader.[cxx/h]:
1654 - UpdateProgress method should now be effective
1655 - removed the limitation on having only images loaded (as opposed
1657 - when building a stack of images/volume, a lesser number of
1658 gdcmHeader and gdcmFile instances should be used (hopefully
1659 accelerating things).
1660 - when building a stack of images/volumes, files which are not
1661 loadable (wrong path-filename, wrong permissions on existing file,
1662 or file not parsable by gdcm) are replaced with a black image
1663 in the stack (for the caller to notice the problem).
1665 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1666 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1668 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1669 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1670 between standard library (std) and vtk library (problems are found
1671 under Windows... thanks Windows !)
1673 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1674 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1676 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1678 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1681 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1682 * When compiling with distutils (see setup.py) the C++ compiler is
1683 called with different flags than the default ones (with automake).
1684 In order to fix all those warning, I compiled gdcm with the command
1685 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1686 and went for warning fixes:
1687 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1688 up from unused variables.
1689 - vtk/vtkGdcmReader.cxx: potential bug fix.
1690 * src/gdcmHeader.h: Doxygen warning cleanup
1692 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1693 * gdcmPython/gdcm.i:
1694 - typemaps correction to take into account the systematic replacement
1695 of "using namespace std" with std:: prefix e.g. std::list,
1696 std::string... (cf changes of 2003-05-21).
1697 - gdcmGlob global variable of type gdcmGlobal (defined in
1698 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1699 exported to Python a as cvar.
1700 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1701 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1702 gdcmDictSet.GetPubDictTagNames() and
1703 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1704 C++ static methods).
1705 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1706 with the above changes.
1708 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1709 * setup.py, manifest.in : bug fix under linux
1711 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1712 * Modification of setup.py to compile vtk part too. Then, we have 2
1713 wrappers which must work with same distutils. For that, we have a
1714 generic distutils in distusiltsWrapping.py ; with :
1715 - build_extWrap class to wrap generically all extensions,
1716 - ExtensionWrap base class for all wrapping extension that contains
1718 - Wrapper interface which wrap sources
1719 + In WrapSwig.py we have extension and wrapper for Swig
1720 + In WrapVTK.py we have extension and wrapper for VTK
1721 * MANIFEST.in : modifications to consider vtk directory and new python
1722 files for compilation
1724 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1725 * Added python wrappers of vtkGdcmReader vtk class (see the
1726 source in vtk/vtkGdcmReader.cxx) :
1727 - vtk/Makefile.am now builds a library
1728 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1729 python library (as opposed to _gdcm.so wich are the python
1730 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1731 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1733 - configure.in has an additional flag --enable-vtk that needs
1734 to be set to enable compilation of vtk related code, that is:
1735 + vtk/vtkGdcmReader.so and
1736 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1737 + gdcmPython/vtkgdcmPython.so (see above)
1738 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1739 be read when compressed or when HighBit + 1 != BitsStored),
1740 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1741 the usage of the python wrapper of vtkGdcmReader vtk class.
1742 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1743 * src/*.[h] all occurences of stl classes are now prefixed with
1744 std::, and all occurences of "using namespace std;" where removed.
1745 This is to avoid pollution of global namespace in included files.
1746 Apparently vtk does not avoid this pitfall: when using both
1747 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1748 collision of various stl members (principally cout...).
1749 * gdcmPython/testSuite.py now cleanly removes temprory generated
1751 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1752 comply with above changes)
1754 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1755 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1756 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1757 vtk data structure (an image Flip was required).
1758 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1759 * cosmetic changes in documentation.
1761 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1762 * src/gdcmHeader.cxx: the constructor no longer exits when an
1763 unexisting file is given as argument.
1764 * The subdirectory Data (containing all the images used for the
1765 test suite) is not part of this repository anymore. A new module
1766 containing those images is now available at
1767 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1768 with the name gdcmData.
1769 All the python scripts (including the package initialisation file
1770 gdcmPython/__init__.py) were adapated to take this change into
1771 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1773 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1774 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1775 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1776 demo of the usage of this class.
1777 Compilation of this vtk part is only done when using the --enable-vtk
1778 at configure (or autogen.sh) stage.
1780 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1781 * More memory link related corrections and documentation fixes.
1783 - maximum info is obtained with a command of the form:
1784 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1785 --show-reachable=yes PrintHeader
1786 - the remaining reachable blocks seem to come from the STL
1787 allocation scheme through the usage of map and list. It looks
1788 like this memory cannot be freed but it is not a memory leak
1789 (in fact further invocation to the STL would recollect the
1790 unused memory allthough it cannot explicitely be freed).
1791 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1792 of displaying an image parsed with gdcm and displayed with VTK.
1793 Note: some images don't seem to work e.g.
1794 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1795 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1796 Allthough this weakens the semantics, it is a ditch attempt to
1797 make gdcm more thread friendly.
1799 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1800 * Memory link hunt (by using valgrind through the command
1801 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1802 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1803 gdcmHeader::_dicom_vr.
1804 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1805 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1807 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1809 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1810 * src/Makefile.am now exports all the necessary include files at
1814 * UpdateGroupLength replaced by new one
1817 * UpdateGroupLength re-written using H-Table
1818 (named UpdateGroupLengthNew untill checks are over)
1820 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1821 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1822 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1824 - gdcmHeader::GetPubElValSet removed.
1825 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1826 UpdateGroupLength, WriteElements, Write.
1827 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1828 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1829 carried the same semantics.
1830 - src/gdcmHeaderIdo.cxx changed accordingly.
1831 - gdcmFile::WriteBase now regroups all the codes from previous
1832 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1833 - enum FileType moved to gdcmCommon.h
1834 * src/gdcmHeader.cxx AddDefault trashed
1835 * gdcmGetXSize added
1836 * getimageDataSize now calls gdcmGetXSize
1837 * Test/*.cxx changed to agree with above changes
1839 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1840 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1841 (to avoid double call by end user).
1842 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1843 by end user, since gdcmHeader::gdcmHeader now handles it.
1845 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1846 * gdcm/Doc many doxygen changes:
1847 - Doxyfile now has two different versions, DoxyfileUsers that generates
1848 the html.users end users oriented documentation and
1849 DoxyfileDeveloppers that generates the html.developper developper
1850 oriented documentation.
1851 - README changed accordingly
1852 - requirement.txt removed (old design info moved to TODO).
1853 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1854 DoxyMainPage.txt, DoxyPython.txt provide more information.
1855 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1856 be updated by simply regenerating the docs with doxygen and copying
1857 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1858 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1859 all the tests in the form "if (<map>.count() >1)" were removed.
1860 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1861 ill-formed documentation sections.
1862 * src/gdcmHeader.cxx: ditto
1864 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1865 * setup.py fixed for un*x (needed macro for stdint.h)
1866 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1867 un*ces with sh-utils test utility.
1868 * gdcmPython/demo/test.py renamed to PrintHeader.py
1869 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1870 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1871 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1872 * src/gdcm*.cxx JPR's bad inclusion fixed.
1874 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1876 * gdcmPython/demo/test.py changed accordingly.
1878 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * gdcmPython/Makefile.am fixed linking against libstdc++
1880 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1881 * Swig subdir (historical tests of swig version 1.3.17++) removed
1882 * Test/testChangeEntete.cxx some lines commented out in order to make
1884 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1885 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1887 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1888 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1889 hence the user doesn't need this explicit call.
1890 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1891 i.e. LoadElements() call removed.
1892 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1893 - src/Makefile.am declares the proper flag for g++.
1894 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1895 for adding user defined new tags.
1896 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1897 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1898 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1900 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1901 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1902 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1903 src/Makefile.am : the project should properly compile and install
1904 with the autotools, included the python wrappers part.
1905 * gdcm.spec.in : added a spec file for RPM packaging.
1907 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1908 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1910 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1911 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1912 to exported to the environement (see gdcmPython/testSuite.py
1914 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1915 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1916 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1917 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1918 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1920 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * gdcmPython/__init__.py doesn't crash anymore when running in
1922 in InstallMode or PreInstallMode but with an environement given
1923 value of GDCM_DICT_PATH.
1924 * src/gdcmDictSet.[cxx/h] coding style.
1926 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1928 * src/gdcm.h general comments moved to TODO, and README
1929 * src/gdcm.h should now be seen as a user commodity (including it
1930 should suffice to fully use gdcm). It is nowhere including within
1931 any of the kernel files src/*.cxx and src/*.h.
1933 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1934 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1935 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1937 * src/gdcm*.cxx only include their corresponding include file
1938 (as opposed to gdcm.h)
1939 * gdcmPython/gdcm.i changed accordingly
1940 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1941 the autogen.sh generated "make snapshot" command to work.
1942 * autogen.sh removed history related references to crea package.
1944 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1945 * distutilsSwigCPlusPlus.py work around some swig portability
1948 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1949 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1950 was done in a last ditch attempt to get setup.py _really_
1951 operationnal. The python/gdcmPython layaout add the advantage
1952 of hidding away the python related distutils specific files
1953 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1954 Alas, the src directory was out of scope (i.e. it's relative
1955 position to setup.py was ../src) which made things impossible to
1956 handle (see previous version of python/setup.py). Crossing fingers...
1958 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1959 * python/setup.py now works on Un*x. (harder than I thougth)
1960 * python/distutilsSwigCPlusPlus.py can now have include files
1961 among the list of sources.
1963 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1964 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1965 * modifications in MSVC projects
1967 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * As stated by the first lines of Test/ExceptionAndPython/README, it
1969 looks like we can move back to original usage of exception within
1970 src/gdcm* and hence remove the errno stuff that was introduced
1971 as a quick and dirty fixture of this problem (added to the TODO).
1972 * Doc/Doxyfile configuration file for Doxygen and corresponding
1973 README file for usage added.
1974 * Test/testWrite.cxx added. This new test comes from a split of
1975 test.cxx that is now reverted to its original purpous i.e.
1976 testing the proper parsing of a Dicom related file.
1977 testWrite.cxx concentrates on testing the IO part of gdcm.
1978 * Test/bug1.cxx (containing a bug on WIn32) added.
1979 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1980 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1981 whose purpose is to publish the content of the TagNames of the
1982 Dicom public dictionnary were not accessible without an
1983 instance of class gdcmHeader.
1984 - those methods are now static methods of gdcmDictSet and hence
1985 require no instances at all to be invocated.
1986 - within gdcmDictSet this change required to change some method
1987 to class methods (i.e. are now static) among which SetDictPath
1988 (renamed to BuildDictPath) and LoadDefaultPubDict.
1989 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1990 the above changes by calling the new method classes of gdcmDictSet.
1991 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1992 the above to be effective.
1993 * python/gdcmPython: in order to wrap properly the above changes
1994 for Python, swig version now needs to be > 1.3.17.
1995 * python/gdcmPython/Makefile fixed to adapt itself to new
1996 configure/make shema introduced by Johan Montagnat (thanks for the
1997 contribution). Alas this Makefile cannot be turned into a proper
1998 Makefile.am without some heavy changes in the configure.in
1999 (for python dectection).
2000 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2001 now avoids publishing the empty entries.
2003 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2004 * python/setup.py : bug fix concerning install under windows
2005 ExtraPath reused :-P
2006 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2008 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2009 * Dicts/dicomV3.dic : remove double spaces !!!
2010 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2011 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2014 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2015 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2016 method. Doxygenation.
2017 * src/gdcm.h clean up of JPR spurious comments.
2019 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2020 * python/distutilsSwigCPlusPlus.py now properly collects the
2021 shadow classes generated by "swig -c++" (gdcm.py in our case)
2022 when using "python setup.py install".
2023 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2024 reexports the working classes.
2025 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2026 by the classical C errno scheme. This is to prevent an obscure
2027 behavior of the python wrappers when importing wxPython.wx prior
2028 to gdcmPython (which ended up in an abort call). An illustration
2029 of this oddity can be found in the Test/ExceptionAndPython
2030 subdir (see the README file). This problem probably due to
2031 an combination of g++ and dynamic loading.
2032 * added Test/ExceptionAndPython (see above)
2034 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2035 * Changed the layout of the python part to avoid bloating main
2036 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2037 i.e. the distutils arsenal. All the python related stuff is
2038 again in a python subdir, but the package itself is now in
2040 * setup.py was cleaned up:
2041 - pythonIncludePath removed
2042 - python setup.py bdist target is now functional.
2043 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2044 collision with other packages). gdcmPython/demo/*.py changed
2047 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2048 * python subdir moved to gdcmPython (preparation of distutils packaging).
2049 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2050 distutils installer is operational.
2051 * - gdcmPython/__init__.py now properly loads the swig generated
2052 shadow classes (from gdcm.py).
2053 - gdcmPython/demo/*.py changed to import the package gdcmPython
2054 instead of gdcmPython/demo/load.py.
2055 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2057 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2059 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2060 entries within the associated public Dicom dictionary resp. the same
2061 information but sorted by the fourth field (PAT, IMG, DIR) of the
2063 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2064 are now in the "???" group.
2065 - python/gdcm.i changed accordingly,
2066 - python/demo/printGroupedPublicDict.py added, that gives an example
2067 of the above new functionalities in Python.
2069 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2070 * src/gdcm.h, gdcmHeader.cxx:
2071 - historic references to glib's g_malloc and g_free (#defined)
2072 were definitively removed.
2073 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2074 * src/gdcmElValSet.cxx:
2075 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2076 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2077 - GetElValue(string) renamed to GetElValueByName.
2078 - Added GetElementByName(string).
2079 * src/gdcmHeader.cxx: added
2080 - GetPubElValRepByNumber(guint16, guint16)
2081 - GetPubElValRepByName(string)
2082 - GetShaElValRepByNumber(guint16, guint16)
2083 - GetShaElValRepByName(string)
2084 - GetShaElValByNumber(guint16, guint16)
2085 - GetShaElValRepByName(string)
2086 - GetElValRepByNumber(guint16, guint16)
2087 - GetElValRepByName(string)
2088 - GetElValByNumber(guint16, guint16)
2089 - GetElValRepByName(string)
2090 * Doc/requirements.txt added.
2092 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * Test/Makefile building now depends on the one of libgdcm.so
2094 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2095 pixel data) aware which enables finding the address (offset) of
2096 the pixel data of JPEG encoded DICOM files. This leaves only a single
2097 file in the testSuite whose pixel data address (offset) is unknown.
2098 * python/testSuite.py changed accordingly.
2100 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2101 * VC++ has some strong limitations when working with the STL, as stated
2102 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2103 "Also note that some STL containers (map, set, queue, list, deque)
2104 cannot be exported. [...]
2105 Some STL classes contain nested classes. These classes can not
2107 This is caused by a designed limitation that once a template
2108 class is instantiated, it can not be re-instantiated and
2110 Since our usage of map<> is ubiquitous in gdcm, this "designed
2111 limitation" of VC++ is a pitfall.
2112 Hence the Python wrappers of gdcm cannot be incrementally linked
2113 against the c++ dynamic library. The dirty but only workaround is
2114 to forget about incremental link of dynamic libraries and to generate
2115 the Python wrappers library with the inclusions of the underlying C++
2117 The following modifications concern this matter on Win32/VC++:
2118 - wrapping python correct with standalone wrapped dll (don't use separate
2119 dll under windows !!!!)
2120 - python21_d debug mode enabled (ask Frog how to use it :-)
2121 - NO problem with having an STL member of class for example string in C++
2122 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2123 - Python test of dcmlib in Python is ok under windows on a large set
2125 * removed glib references
2126 * typedef's inserted in gdcm.i for correct swig type management
2128 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * python/demo/*.py load.py extracted from test.py. Added explore.py
2130 that only displays required tags and testAll.py that parses all
2131 the files of the testsuite without using unittest.
2132 * python/testSuite.py other additional test on new files added.
2133 * Data/* new test files added accordingly to the testSuite.
2134 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2135 the vr in the file differs from the one of the dictionary.
2137 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2139 values, but limits itself to values which are below a user specified
2140 size (by default 1024 bytes).
2141 * python/gdcm.i : elements not loaded (because their size is above the
2142 user specified treshold) are exported with their TagKey as key of the
2143 python dictionary. This enables the testsuite to make some checks
2144 on the unloaded elements (since we have their offset and size).
2145 * python/testSuite.py
2146 - now tests for the existence and proper value of the pixel data
2147 - two new examples added.
2148 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2150 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2151 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2152 aware. See the strategy comments in gdcmHeader::FindeLength().
2153 * Test/test.cxx now accepts a filename as first argument.
2154 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2155 * python/testSuite.py changed to integrate test on above files.
2157 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2158 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2159 the vr was also RET.
2160 * python/testSuite.py more tests added.
2162 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2163 * python/testSuite.py unittest test suite added (uses Data)
2164 * Data/* dcm and acr files for the test suite.
2165 * glib dependance removed from un*x version. We now use ISO C99
2166 7.18 Integer types (see stdint.h)
2167 - python/Makefile, src/Makefile src/gdcm.h
2168 * src/ when an explicit vr (like dicom files) suddenly poped an
2169 implicit element we use to mark the underlying DictEntry of the
2170 concerned ElValue with "Implicit". This strategy was damageable
2171 too the public or provite dictionaries, since some of their vr
2172 would be changed. Since Header::FindLength heavily relies on the
2173 detection by Header::FindVR of falsely explicit elements, I
2174 added an extra ImplicitVr member to ElValue (boolean).
2175 The rest of the changes we the necessary adaptations.
2177 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2178 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2180 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2182 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * Adaptation for porting to VC++:
2185 o forced to use std namespace (for string to be known)
2186 o all class use __declspec export style on WIN32
2187 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2188 (in stdlib.h on Win32 but in std:: for gcc)
2189 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2190 variable GDCM_DICT_PATH.
2191 * src/gdcmHeader.cxx verbose comments made discrete.
2193 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * python/gdcm.i: added a typemap that converts a C++ hashing table
2195 to native Python dictionary.
2196 * python/demo/test.py:
2197 - now uses the native dictionary for exploration of gdcmHeader.
2198 - takes an optional filename argument (the file to parse).
2199 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2200 PubElVals hashing table.
2201 * Dicts/dicomV3.dic removed error prone trailing spaces.
2203 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * Python wrapping process moved away from src/Makefile to
2205 newly created python/Makefile (as well as gdcm.i)
2206 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2207 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2208 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2209 from the environement variable GDCM_DICT_PATH (when existing).
2210 * src/gdcmDict::GetTag bug fix.
2212 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2213 * Straightforward temporary fixes for swig to build the python wrappers.
2214 src/Makefile now has a python working entry [by working we mean
2215 that we can import de shadow classes without errors].
2217 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * hashtest.cxx removed (since allready in Test)
2219 * src/gdcmlib.h renamed to src/gdcm.h
2220 * src/dcm.i renamed to src/gdcm.i
2221 * src/Makefile prepared for python wrapping
2223 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * src/gdcmHeader.cxx :
2225 - Parsing of header is now separated from loading of element values
2226 (see gdcmHeader::LoadElements).
2227 - general clean up of hopefully all file access (creation of
2228 ReadInt16 and ReadInt32)
2230 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2231 * src/gdcmHeader.cxx :
2232 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2234 - SetLgrElem renamed to SetLength
2235 - GetLgrElem renamed to GetLength
2236 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2237 * src/gdcmElValSet.cxx fixed both GetElValue methods
2238 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2239 due to IdoDude was cleaned out.
2241 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2243 concentrates on finding the value representation (when it exists).
2244 RecupLgr now only finds the element value length, and it avoids
2245 returning the unecessary skL (skipped length).
2246 Also, offsetCourant was simply removed (with taille_fich) since
2247 it was redundant with the File position internals (by using
2248 ftell and fseek). This also made skL (see above in RecupLgr) usage
2250 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2251 on the libido specificities which are handled through class
2253 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2256 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2257 * Truckload of changes. Parsing of header is barely functional
2258 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2260 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2261 * src/gdcmHeader.cxx many addons of low level methods
2263 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2265 and _IdDcmSWAP_LONG.
2267 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * This corresponds to all the changes decided at the meeting of
2269 May 23 2002. Needless to say we are running late...