1 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
3 problems when compiling with the python wrapping
5 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
9 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
10 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
11 JPEG decompression, especially when dicom frames are split into several
12 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
13 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
15 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
16 * src/gdcmHeader.cxx : change the initialisation of default header.
17 Now, this header is readable by gdm, e-film, DicomWorks
19 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
21 Rename Decompressed to Raw
22 * Use the API changes in gdcm::File.
23 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
26 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
28 each added entry in the header. Replace the 'Planes' field by the 'Number
31 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
33 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
35 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
37 At this time, this image isn't readable by e-film... waiting JPR help to
40 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
41 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
42 DocEntry. Now use methods of the Document !
44 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
45 * Test/ShowDicomSeq.cxx : bug fix
47 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
49 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
50 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
51 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
53 * Test/TestCopyRescaleDicom.cxx : remove unused variable
54 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
55 containing found sequences
57 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
60 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
61 Some fields in BinEntry must be copied to not seg fault when making the :
62 gdcm::File *copy = new gdcm::File( copyH );
63 and tests are now made on good variables
65 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
66 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
67 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
69 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
70 * Add vtkGdcmWriter example and test
72 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
73 * Test/TestUtil.cxx : reformat the source code
74 * vtk/vtkGdcmReader.cxx : remove and change prints
75 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
77 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
78 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
80 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
82 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
84 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
86 by an eof to prevent all bad read of the file... and in this case, the
89 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Example/Volume2Dicom.cxx : comment unused variables
91 * Test/PrintDicomDir.cxx : comment unused variables
92 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
93 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
94 method that is redondant with AddEntry.
95 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
98 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * Bug fix due my last commit (compilation under Windows).
100 * Example/Volume2Dicom : bug fix in the file and reformatting source code
101 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
103 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
105 - Remove printf / sprintf
106 - include iostream AFTER gdcm so we don't get warnings
107 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
109 - Also remove tons of include from header files, hopefully this should
110 speeup the compilation time, since it was becoming a dog slow.
111 - Remove gdcm.h as it include way too many files and slow down compilation
112 (plus it is not up to date)
113 - remove 'using namespace std' this is BAD !
115 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Remove memory leaks on the DicomDir
117 * Remove some useless datas in DicomDirObject
118 * Add usefull methods in SQItem, to be complient withe the ElementSet
120 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
123 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
125 future, with convertion)
126 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
127 and ImageDataSize values. Remove the method to get the PixelReadConverter
128 from the output of the class
130 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
133 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
134 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
135 and vtkErrorMacro use.
136 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
138 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
141 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
142 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
143 The string leaves only in the fonction. So when we make a .c_str(), we
144 get the pointeur on the first element, element that will be destroyed
145 immediately after thee instruction.
146 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
147 file has been opened : the test must be made on the content of the
148 pointer and not directly on the pointer !
151 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
152 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
153 the python part recompiles
155 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
156 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
157 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
158 X session is killed (for my computer... it seems to not be identic on
161 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
163 avoid problems (otherwise, the difference test between the visible image
164 and the reference is incorrect. If the reference is greater than the
165 screen resolution, it's produce errors).
166 Can be used for only one image. Can be used with a visible flag.
167 * vtk/vtkGdcmReader.cxx : remove commented codes.
168 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
169 under windows at compilation
170 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
172 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
174 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
176 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
177 tests on the image size X, Y, Z
179 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
181 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
182 between the class name and the file name
184 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * src/ : fix compilation warnings for the Write method (2 different
186 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
187 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
188 variable... create a static method in gdcm::Document to access to
189 this variable content.
191 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
192 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
193 file, to be accessed by other files (like gdcmFile). Remove commented
194 code. Move the change of the header to the gdcmFile, using the
196 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
197 To be sure of that (and simplify calls), the Write of the header now
198 gets a file name and not a file pointer (std::ifstream).
199 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
200 DocEntryArchive. Remove all open of the written file
202 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
205 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
207 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
209 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
210 some corresponding methods. Write correctly the file and check before
212 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
213 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
214 is now on RGB datas (as before my last commit
215 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
217 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
219 Add a print information of the type of the entry
220 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
221 It was in the gdcmFile, and all write have been regrouped
222 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
223 Write correctly all dicom files (in decompressed mode only at this time)
224 * Test/ : test on files are now made using Raw datas and not color datas if
226 * Example/PrintFile.cxx : add more printings
228 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * Amelioration of code, remove some code copy. For the loading of
230 BinEntry (in gdcmDocument), add the test to verify if the file is already
233 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
235 remove a DocEntry in the header (push an empty DocEntry)
236 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
237 lines. Bug fix in the initialization of the PixelConvert and the
239 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
240 use in TestCopyDicom (now this test can run under windows... but fails)
241 * Test/TestCopyDicom.cxx : amelioration of the test :
242 - test the pixels written
243 - add test points to quickly find where is the error
244 - can set a file name input and output in arguments
245 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
246 amelioration of the test output
248 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
249 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
250 all replaced DocEntry's
251 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
252 Now, each needed DocEntry to modify is duplicated, modified and inserted
253 to the header using DocEntryArchive. Thus, after save, we can restore the
254 header initial state.
256 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
259 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
261 correct to copy it. The DictEntry is specified at the DocEntry creation,
262 then, it musn't change in the time.
263 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
264 header correctly. At this time, the change is only made for the first
265 level of the Document. In the future, it might consider sequences.
266 The change is made by replacing a DocEntry by an other that is created
267 outside the class. The old value is kept. When we restore the header
268 status, the added DocEntry is deleted and replaced by the old value.
269 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
270 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
271 set the write type to explicit VR, implicit VR or ACR. Add methods to set
272 the write mode to native, decompressed or RGB (but not used at this time)
274 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
276 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
278 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
279 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
280 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
282 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
283 set because already copied when copying the BinEntry's of the header
284 * Test/TestAllReadCompareDicom.cxx : remove warnings
286 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
287 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
288 Two problems appear when doing it :
289 - with the gdcmFile : when the GetImageData method is called, the pixels
290 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
291 datas (pixels). And each structure destruct the datas when it's
292 destructed. So we have two destructions for the same datas. To solve it,
293 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
294 datas or not. If it doesn't own datas, then they will not destroyed by
296 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
297 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
298 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
299 create a double destruction of the same DocEntry's. So, to solve it,
300 the TagHT is simply cleared and the DicomDir* elements are destroyed.
301 * TODO : add an entry concerning memory leaks in the DicomDir
303 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
304 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
305 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
308 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
309 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
310 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
311 after it have been deleted
313 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * FIX: src/* fix the doxygen warnings.
315 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
316 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
317 was erroneously defined with a size of 15 instead of 16. [many thanks
318 to Jean Michel Rouet for pointing out this bug].
320 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
321 1. Finish merging JMR patch for writting DICOM from scratch
322 2. Fix -hopefully- bug with MONOCHROME and space vs null character
323 3. Use const ref when possible
324 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
325 5. A few more comments
326 6. CreateUniqueUID can now be called without parameter"
328 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
329 * ENH: Slightly bigger patch:
330 1. Getting toward full integration of JMR patch for writting dicom from scratch
331 2. Update Test to test part of this patch: CreateUniqueUID
332 3. File was not close properly in gdcmDict
333 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
334 5. Use of const ref instead of copy (speed issue)
335 6. Remove temporary (duplicate) string in TranslateToKey
336 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
337 8. Do not repeat virtual in subclasses
338 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
340 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * Apply first patch toward better string comparison when dealing with broken
342 DICOM files. Essentially the string could be padded with a space instead
343 of a null character as defined by standard
345 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
347 because never used... and in the same time, that's remove some memory leaks
349 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
350 * src/gdcmFile.cxx : now delete the PixelConvert instance.
351 * In examples and tests : change the type of image data variables from void*
352 to uint8_t*. Remmove all delete on image data variables
354 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
355 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
356 Verify the file pointer value before open the file, and if it's not null,
357 a verbose message is generated.
358 Close correctly the file when the file isn't considered dicom-like. The
359 correctly close is a call to CloseFile.
360 When closing the file pointer, test if its not null to close the file.
361 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
362 file. For an uncompressed image, the copied datas correspond in the least
363 case to the image size (calculated) or the image size specified in the
364 header. A verbose is generated if these two size mismatch
366 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
367 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
368 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
369 break under windows (with msvc6 compilation).
371 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
372 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
373 compiling with MSVC6)
375 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
376 * Bugs fix for the Windows build with VC6
377 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
378 needed (only for projects required VTK). If the VTK is included in all
379 projects, there is conflicts with the jpeg lib of vtk when compiling the
380 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
381 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
382 when compiling the gdcm_wrap.cxx file (created by the compilation of the
384 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
385 (like it's already made for the cout use). Otherwise, conflict with the
388 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
389 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
391 - comments on the DicomDir::Method related usage added.
392 - now that we use the namespace gdcm, a lot of internal classes do
393 NOT need to be wrapped anymore.
394 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
395 DicomDir::Method) new example added.
397 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
398 * Improve string manipulation. I now inforce the notion of 'DicomString'
399 A DicomString can contain as many \0 as they want
400 and it is *always* of even length.
401 We only support odd length for very rare case.
402 And in the near future this should be removed.
404 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
405 * /binary_write/ gdcm source. Now even on big endian we are writting
406 little endian. This should -heopfully- fix some tests
408 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
409 * Now the dictionary is compiled into gdcm lib. This is a default
410 behavior, thus any dic file specified is picked before failback to
411 the one comiled into lib
413 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
414 * Change internals for gdcmDict. Don't use any 'new' any more.
415 This should definitely solve any leak problem, and we should be
416 as fast as before, as long as don't modify too much the dictionary.
418 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
419 * STYLE: ivars should start with a capital letter.
420 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
421 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
423 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
424 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
425 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
426 new 2004 dictionaries added (thanks to JPR).
427 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
428 * CLEANUP_ROUND (15) for gdcmPixelConvert
429 - RLEFrame::NumberFragments is now of type unsigned int
430 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
431 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
434 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
435 * Initial work in gathering all transfer syntax accessors. clearly
436 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
437 ivars, but only one transfersyntax (class) ivar with equivalent method on
440 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
442 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
443 discussed (plus I didn't like having a 2000 lines patch not commited)
445 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
446 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
447 * CLEANUP_ROUND (14) for gdcmPixelConvert
448 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
449 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
450 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
452 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
453 anymore and hence avoids storing a copy of PixelConvert::Decompressed
454 into File::Pixel_Data.
456 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
457 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
458 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
459 * CLEANUP_ROUND (13) for gdcmPixelConvert
460 Substituted File::ParsePixelData() with PixelConvert::Print() new
462 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
463 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
464 method to those classes.
465 - src/gdcmFile.[cxx|h]:
466 -- Added a ::Print() method.
467 -- PixelConverter is now a reference instead of a member.
468 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
469 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
471 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
472 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
473 collaboration diagram and inheritance diagram should be generated with
475 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
476 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
477 pointlessly wrapped (see
478 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
479 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
480 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
481 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
482 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
483 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
484 -- File::Initialise: PixelConverter setup moved away to
485 PixelConverter::GrabInformationsFromHeader()
486 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
487 interpretation moved away to PixelConverter::BuildRGBImage()
489 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
490 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
491 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
493 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
494 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
495 displayed on Win32 when a brutal abort() occurs (because of uncatched
496 exception). See TODO new entry of this commit for more on this.
497 * TODO added new entry.
498 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
499 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
500 - HandleColor is no longer called from gdcmFile.cxx
501 - gdcmPixelConvert.cxx clean up on method arguments and internal
502 variable names for semantical coherence.
504 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
505 * Finished lossless transition, not only do we now read all lossless jpeg
506 images, without the need of the Cornwell lib, but we do read them properly now
507 * To reduce code (well to avoid code duplication), I defined a common place
508 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
509 redefine symbols. This is not prefect but this the best solution I found for a
510 compilation time jpeg option.
512 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
513 * Update jpeg ijg lib to support lossless jpeg implementation
514 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
516 * Also added a special copyright for dcmtk since we use their bugfixes.
519 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
521 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
522 matters, as stated in warning note at begining of %include section).
523 * src/gdcmDicomDir*.[cxx|h]: coding style
524 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
525 * src/gdcmJpeg8.cxx: doxygen fix.
526 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
527 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
528 from File:: to PixelConvert::.
530 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
531 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
532 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
533 - more code moved away from File:: to PixelConvert::
534 - fat setup of PixelConverter set in place in File::Initialise.
536 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
537 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
538 namespace at the file system level. So now you should convert your examples
540 gdcmHeader -> gdcm::Header
541 It would be nice if people keep in mind to no open the namespace, since it
542 allows compilation on broken plateform which were defining common symbol in
543 the standart namespace (like LP, Unknown ...)
545 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
546 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
547 The JPEG fragments are now parsed at the same stage than the RLE
548 information. All code related to JPEG is now in gdcmPixelConvert:
549 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
550 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
551 export a gdcmFile:: method. Those are simply global functions
552 (for the time being this is better than having them attach to
553 either gdcmFile:: or gdcmPixelConvert::).
554 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
555 and stores the result in a gdcmJPEGFragmentsInfo.
556 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
557 code (among other stuff) moved away from gdcmFile:; to
560 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
562 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
563 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
564 clean up of RLE related code.
565 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
566 - src/gdcmRLE.cxx removed
567 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
568 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
569 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
570 * CLEANUP_ROUND (9) for gdcmPixelConvert
571 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
572 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
573 away from gdcmFile:: to gdcmPixelConvert::.
575 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
577 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
578 This is because Parse7Fe0 used to parse the pixels to compute the
579 length. This task was passed over to FindDocEntryLengthOB() a long
580 time ago, EXCEPT I had forgotten the OW case...
581 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
582 we just recylce the code for parsing RLE fragments and computing
584 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
585 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
586 with the retired Parse7Fe0().
587 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
588 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
590 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
591 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
592 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
593 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
594 - src/CMakeLists.txt: alphabetic order reodering + new entries.
595 * CLEANUP_ROUND (4) for gdcmPixelConvert
596 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
597 to return an unused length.
599 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
600 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
601 this should be cleanner from the plane view. The iostream are erally a pain
602 to use to do simple stuff.
604 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
605 * Redo the compilation of the ijg jpeg library. Now only one source is
606 necesseray. No need to rename file by hand what so ever. CMake handle the
607 copying of the file within different directory, configure header file to
608 modify some symbol. The only addition made to ijg wasd a mangle table so
609 that symbol are different wether we are within 8bits or 12bits.
611 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * Added documentation of vtkgdcmReader on Website:
613 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
614 with it's binary name).
615 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
616 the Website to be more complete.
617 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
618 doxygenated documentation.
619 - Doc/DoxyVtkGdcmReaderExamples.txt added
620 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
621 DoxyVtkGdmReaderExamples.html )
622 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
623 * CLEANUP_ROUND (3) for gdcmPixelConvert
624 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
626 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
627 * CLEANUP_ROUND (2) for gdcmPixelConvert
628 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
630 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * CLEANUP_ROUND for gdcmPixelConvert:
632 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
633 - src/gdcmPixelStuff[h|cxx] removed
634 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
635 - src/CMakeLists.txt changed accordingly
637 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
638 gdcmVersion.py moved to newly created ATTIC related
639 gdcmPython/SetupOldies/ directory.
640 * Autotools clean up:
641 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
642 - autogen.sh configure.in acinclude.m4 python.m4 removed
644 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * src/*.cxx *.h Reference to License.htm fixed to License.html.
646 * Doc/CMakeLists.txt, doxygen.config.in: fix.
647 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
649 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
650 * TODO updated with Mathieu suggestions. I proposed a template for
651 describing TODO entries and used it for new entries.
652 * Added Doc/Website/CodingStyle.html, Developpers.html,
653 DeveloppersPython.html, GdcmDataCvs.html and
654 DownloadVersion0_1.html, DownloadVersion0_3.html.
655 * Some Doc/*.txt Doxygen files (which do not really concern the
656 documentation itself, but the website) moved to html and
657 placed in directory Doc/Website:
658 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
659 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
660 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
661 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
662 * CMakeLists.txt changed accordingly.
663 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
664 DeveloppersPython.html
665 * INSTALL nows refers to Doc/Website/Installation.html
667 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
668 * Added Doc/Website directory, that contains a first raw version
671 2004-09-23 Jean-Pierre Roux
672 * FIX In order not to be poluted any longer by casting problems,
673 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
674 we can now delete[] it safely
675 * VoidArea is now called BinArea (less confusing name),
676 and all the methods called ...VoidArea... are now ... BinArea...
677 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
679 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
681 clear) TagHT, which is an inherited member of gdcmElementSet. It is
682 up to the destructor of gdcmElementSet to clean up TagHt and it's
685 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
686 * Test/CMakeLists.txt: update to follow gdcmData renamings.
687 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
689 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
690 * ENH: added some utility method that builds a flat dictionnary
691 holding all the Dicom entries contained in the recursive structure
692 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
694 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
695 BuildFlatHashTable() that build a flat dictionary.
696 - src/gdcmElementSet.h: added a new private GetTag() accessor.
697 gdcmDocument is now a friend of gdcmElementSet.
698 - src/gdcmElementSet.cxx: clean up.
699 - Example/FlatHashTablePrint.cxx added.
700 - Example/CmakeLists.txt changed accordingly
702 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
704 moved away from gdcmDocEntrySet (since this class is an abstract class
705 acting like an interface). SQDepthLevel and BaseTagKey are now
707 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
708 and associated accessors. Doxygenation of the class.
709 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
711 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
712 Use SQDepthLevel accessor instead. ::Print() adapted.
713 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
714 - src/gdcmDocument.cxx changed accordingly.
716 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
717 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
718 - The following is the doxygen comment of the typedef declaration
719 of gdcmagKey in src/gdcmCommon.h:
720 gdcmTagKey is made to old an "universal" (as in URL, Universal
721 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
722 A dicom tag allways has a group and an element, but a set of tags
723 embeded in various (optionally nested) sequences and sharing
724 the same group and element all share the same (group, element)
725 "identifier". Hence the (group, element) cannot be used as an
726 identifier (in gdcm we shall refer to a "TagKey") of a tag.
727 In order to construct a proper tag identifier (i.e. a key) we
728 consider the following definition of a TagKey:
729 - let Group, Element be the string representation of the
730 group and element dicom tag members,
731 - let ItemNumber be the string representation of the integer
732 index of the considered item number of a sequence,
733 Let the key of a tag embeded in a sequence, noted SeqTag, be
735 /ItemNumber#Group|Element
736 where "/", "#" and "|" are characters acting as separators.
737 Then the general form of a gdcmTagKey is given by:
738 Group|Element<SeqTag>
739 where <SeqTag> means NO or many instances of SeqTag.
740 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
743 but the gdcmTagKey of a tag "embeded" is the first item of
744 a sequence, itself nested in the third item of a sequence is the
746 0004|1220/2#0008|0082/0#0008|0090
747 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
748 order to hold the new sequence compatible key. Previously, the
749 GetKey() method would look in the underlying gdcmDictEntry.
750 - src/gdcmDocEntry.cxx:
751 -- constructor now copies the underlying DictEntry key, in the local
753 -- ::Print: displays the member Key, instead of the (group, element).
754 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
755 - src/gdcmDocEntrySet.h:xi
756 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
757 -- now has a new BaseTagKey member.
759 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
760 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
762 This poses the problem with the semantics of the following lines
763 LoadEntryVoidArea(0x0028,0x1201); // R LUT
764 LoadEntryVoidArea(0x0028,0x1202); // G LUT
765 LoadEntryVoidArea(0x0028,0x1203); // B LUT
766 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
767 to the long FIXME note for what the problem is. Nevertheless in
768 order to get things working the dicom dictionary was altered !
769 Please fix things urgently...
770 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
771 information), see above note on moving the member VoidArea. Nevertheless
772 the following entries previously correctly set as US are now inproperly
774 0028 1201 OW IMG Red Palette Color Lookup Table Data
775 0028 1202 OW IMG Green Palette Color Lookup Table Data
776 0028 1203 OW IMG Blue Palette Color Lookup Table Data
777 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
778 of gdcmDocEntry moved to gdcmSeqEntry.
779 * src/gdcmSeqEntry.cxx: STYLE.
781 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * Test/TestAllEntryVerify.cxx minor fix and added comments.
784 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * gdcmPython/testSuite.py: all the test suite in python is now moved
786 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
787 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
788 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
790 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
791 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
792 to avoid inclusion recursion until STL is reached.
793 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
794 mecanism. errno.h is not included in gdcm anymore.
795 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
796 (gdcmFormatError now inherits from gdcmFormatUnexpected).
798 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
799 gdcmData/TestAllEntryVerifyReference.txt
800 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
801 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
802 exception_on_error parameter.
803 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
804 - vtk/vtkGdcmReader.cxx changed accordingly,
805 - Example/*.cxx and Test/*.cxx changed accordingly.
807 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
808 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
809 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
810 enable_sequences removed from gdcmHeader constructor and dependencies.
811 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
812 * gdcmPython/demo/PrintHeader.py: dummy fix.
813 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
814 skip_shadow removed from gdcmHeader constructor and dependencies.
815 * Example/*.cxx and Test/*.cxx changed accordingly.
817 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
818 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
819 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
821 2004-07-21 Jean-Pierre Roux
822 * FIX Now, Parsing and Printing a DICOMDIR do work!
823 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
825 2004-07-20 Jean-Pierre Roux
826 * FIX Some brain damaged headers have Zero-Lenght fields
827 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
829 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
830 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
831 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
832 variable (instance of gdcmDebug) by a definition macro, and the instance
833 is now in static in the gdcmDebug class
834 * src/gdcmSQItem.h : (FIXME) remove an undefined method
835 * Test/PrintAllDocument.cxx : bug fix in the result of the test
837 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * WARNING: ctest now depends more tightly on gdcmData. You should
839 check out gdcmData properly for things to run smoothly...
840 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
841 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
842 we need the pixels not be loaded in order to use the ValEntry
843 that displays position and size).
844 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
845 This is a C++ based equivalent of gdcmPython/testSuite.py that should
846 be deprecated. If you have any doubts about the advantages of a
847 modern scripting language (read Python) versus grass root C++ (i.e.
848 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
849 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
850 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
851 Anyhow, consider documenting the gdcmData images in
852 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
854 * Test/CMakeLists.txt:
855 - now uses TestAllEntryVerify.cxx
856 - specific comments on oldACR00001.ima (now renamed in gdcmData
857 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
858 gdcmData/TestAllEntryVerifyReference.txt
861 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * src/*.[h|cxx] : typedef clean up
863 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
864 - TagKey renamed to gdcmTagKey (for external usage)
865 - VRKey renamed to gdcmVRKey (for external usage)
866 - removal of typedef duplication.
867 - Removed all unecessary inline keyword from class inline definitions.
868 - Some method|function(void) declarations replaced with method|function().
869 * src/jpeg/libijg12/jdhuff12.c:
870 - printf polluting ctest removed.
871 - TAB removal for comminting
873 - TestAllReadCompareDicom.cxx: added a test that compares all the
874 images in gdcmDataImages.h with corresponding images in
875 gdcmData/BaselineDicom/. When baseline images are not present
876 this test creates them.
877 Note: we need to validate each reference image, but before that
878 I'd like to rename them with a more explicit name...
879 - CMakeLists.txt: changed accordingly.
880 * Example/*.cxx: examples now only include gdcm.h (as opposed to
881 including each header needed).
883 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
884 * Test/*.cxx and Example/*.cxx: moved some examples away from the
885 test suite to the Example directory. Are concerned:
890 - TestWriteSimple.cxx
891 * Test/CMakeLists.txt: added some comments on reasons for black listing
892 image gdcmData/oldACR00001.ima
894 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * Test/CmakeList.txt: removed the following from black list (to be coherent
896 with removal from gdcmData):
897 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
898 - gdcm-MR-PHILIPS-16.dcm
900 Added the following because after last cvs update, they cause
901 ctest -R TestReadWriteReadCompare
903 - gdcm-MR-SIEMENS-16-1.acr
905 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
906 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
907 new comments in this file) we temporarily (sigh) move to a weaker
909 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
910 we don't need to black list the following images anymore:
911 - 8BitsUncompressedColor.dcm
913 - US-PAL-8-10x-echo.dcm
914 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
915 fixes and the beautified code ;-)
916 This fixes the bug introduced in version 1.42 (when beautifying)
917 that made the parsing of 8BitsRunLengthColor.dcm unproper.
918 Note: ctest was blind to this bug (this means we need to still
919 improve the test suite). The bug could be detected by using
920 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
922 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
923 and by displaying the (garbage) produced file temp.XDCM...
925 2004-06-29 Jean-Pierre Roux
926 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
927 - replace by uggly but working old code :-(
928 A lot of things should be OK again.
929 It's really urgent to have a test suite that *tests*,
930 to prevent Frog's beautifying sessions to break all the stuff
931 (twice, withing a fortnigh ...)
933 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
934 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
935 redundancy) to added Test/TestReadWriteReadCompare.cxx
936 * Test/CmakeList.txt: because the compare test of
937 Test/TestReadWriteReadCompare.cxx fails, the following images are
938 black listed: - 8BitsUncompressedColor.dcm
940 - US-PAL-8-10x-echo.dcm
941 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
942 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
943 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
944 and ad-hoc kludge. This kludge is now removed, and on encountering
945 such an image (OB field brain damaged) we set errno. Then in
946 ::FindDocLength() we "fix" the length as being ALL what remains
947 in the file (until EOF). We then proceed, hoping for the best...
948 This fixes a SegFault in ShowDicom when trying to write such an
950 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
951 (because TestWriteRead breaks on it, after a non conformal commit?).
952 ctest now runs properly, except for MakeDicomDir (which was allways
953 broken) and the Python related stuff (still not fixed).
955 2004-06-24 Jean-Pierre Roux
956 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
957 FIX : Test/TestReadWrite now iterates on all the file names
958 (instead of infinite loop)
959 ENH : Test/TestWriteRead now iterates on all the file names
961 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
962 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
964 2004-06-24 Jean-Pierre Roux
965 FIX : - now Write drops LUT Descriptors and LUTs (if any)
966 when SamplesPerPixel =3
967 - now Write is no longer confused by
968 'BitsAllocated = 12" and 'BitsStored=12"
969 - "UN" value representation Elements are now written correctly
970 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
971 ENH : - now gdcmHeader has its own Write methods
972 (in order to split the job that has not to be done
975 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
976 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
977 loop on the same image until memory went out.
978 Note: this means we still have gobs of memory loss in PrintDocument
979 * src/gdcmDocument.cxx: fixes problem on parsing on file
980 gdcmData/16BitsJpegLosslessGrayScale.dcm.
982 2004-06-24 Jean-Pierre Roux
983 FIX : Write - All the Sequences and Sequence Item are now written
984 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
985 is added a the end, when necessary.
986 - A lot of brain-damaged images, that were read correctly are
987 now written correctly
988 - length compatible BinEntry are now loaded correctly
989 (even for odd groups)
990 Note : only Explicit Value Representation was checked.
991 (question : is implicit VR really necessary for gdcm ?)
993 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
994 * DEVELOPPER: added a proposition of coding style.
995 * src/gdcmDocEntry.h: removed every inline declaration (for test of
998 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
999 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1000 Use the gdcmDocEntry::Print() and Write() instead.
1001 * src/gdcmDocument.cxx: bug fix.
1003 2004-06-22 Jean-Pierre Roux
1004 FIX : gdcmDocument.cxx
1005 - Now we do recognize the JpegLossLess format (there was a misstyping in
1006 code 'beautyfication' :-(
1007 - Now we automaticaticaly load the Luts, if any
1009 2004-06-22 Jean-Pierre Roux
1010 In order : to write Sequences, whatever their imbrication level,
1011 : to allow user to create his own Sequences
1012 a lot of modif where necessary (adding, moving, or virtualising methods)
1014 WARNING : save your own sources *before* cvs up !
1017 ADD virtual void Write(FILE *fp, FileType filetype);
1020 ADD virtual void Write(FILE *fp, FileType filetype);
1021 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1024 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1025 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1026 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1027 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1028 ADD std::string GetEntryByName(TagName name);
1029 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1031 std::string vr = "unkn",
1032 std::string fourth = "unkn",
1033 std::string name = "unkn");
1034 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1035 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1036 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1037 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1038 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1039 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1040 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1041 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1044 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1045 ADD virtual std::string GetEntryByName (TagName tagName);
1046 ADD virtual std::string GetEntryVRByName (TagName tagName);
1047 REM virtual bool Write(FILE *, FileType);
1048 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1049 FILE *_fp, FileType type);
1050 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1051 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1052 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1053 REM virtual std::string GetEntryByName (std::string tagName);
1054 REM virtual std::string GetEntryVRByName (std::string tagName);
1055 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1056 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1057 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1059 std::string vr = "unkn",
1060 std::string fourth = "unkn",
1061 std::string name = "unkn");
1062 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1063 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1064 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1065 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1068 ADD virtual void Write(FILE *fp, FileType filetype);
1071 ADD virtual void Write(FILE *fp,FileType filetype);
1074 ADD virtual void Write(FILE *fp, FileType filetype);
1075 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1076 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1077 REM std::string GetEntryByName(TagName name);
1080 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1082 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1084 The default constructor invoked by the line
1085 gdcmHeader *f1 = new gdcmHeader( header );
1086 was gdcmHeader::gdcmHeader(bool) instead of the expected
1087 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1088 Hence the parsing wasn't executed... See also below.
1089 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1090 as explicit constructor didn't do the trick to fix the above problem.
1091 Could anyone explain why ?
1092 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1093 properly calls gdcmValEntry::Print() (that was weed out from
1094 code related to gdcmBinEntry).
1096 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * In order to fix memory leaks:
1098 - Test/TestWriteSimple.cxx: added cleaning of free store through
1100 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1101 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1102 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1103 (through the call to ::AddDicomDirMeta()) or the destructor
1104 would crash when deleting uninitialized ::metaElems].
1105 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1106 - src/gdcmDocument.cxx:
1107 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1108 from dynamic stores.
1109 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1110 was causing memory leaks.
1111 - src/gdcmSQItem.cxx:
1112 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1113 cleanly handled with polymophism: sorry but my milage is low).
1114 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1115 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1116 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1117 This avoids SegFaulting.
1118 - src/gdcmSQItem.h: coding style.
1120 - Test/TestWriteSimple still severely sucks. The output image content
1121 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1122 damaged when displayed with vtkgdcmViewer.
1123 - on memory leaks: TestWriteSimple leaks really less (see entry
1124 of 2004-06-18 in Changelog file for the call to valgrind).
1125 - on segfaults: ctest now passes all the tests but one (no more
1127 * Erroneous leading white fix:
1128 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1129 white[s] (as opposed to from >> xxx, that removes it [them].
1130 - src/gdcmTS.cxx: ditto.
1131 - gdcmPython/testSuite.py: dirty related kludge removed.
1132 * src/*: remaining references to gdcmParser removed.
1133 * src/*[cxx|h]: added copy[way]left header.
1136 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * In order to fix writing of dicom files:
1138 - Test/TestWriteSimple.cxx: a simpler example of writing.
1139 - Test/CMakeLists.txt changed accordingly.
1140 - src/gdcmDocument.cxx:
1141 -- The destructor now recursilvely removes potential sequences.
1142 -- Bug fix in ::IsJPEG2000()
1143 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1144 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1146 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1147 to only declared) and build on top of
1148 ::GetDocEntryByNumber(guint16, guint16).
1149 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1150 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1151 for usage in destructor and treatement of promotion in
1152 ::ReplaceOrCreateByNumber().
1153 - src/gdcmSQItem.cxx: destructor should better handle his job.
1154 Test/TestWriteSimple now runs (or at least it DOES something).
1155 * We can now start hutting memory links. A good starting point is:
1156 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1157 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1158 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1160 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1161 * Valgrind note: after Mathieu Malaterre teached me how to read
1162 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1164 Using gcc, you can force the STL to use malloc and to free memory as
1165 soon as possible by globally disabling memory caching.
1166 With 3.2.2 and later, you should export the environment variable
1167 GLIBCPP_FORCE_NEW before running your program.
1168 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1169 simply vanish (it is still not clear to me, whether this means that
1170 STL std::string leaks or if valgrind believes it leaks...).
1171 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1172 running bin/gdcmTests makeDicomDir):
1173 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1174 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1176 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1177 SegFaulting (I drowned in DicomDir related code when trying to
1178 understand why the list is empty...).
1179 * src/gdcmDocument.h: first BSD license header try.
1180 * Doc/License.txt added.
1182 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1183 * src/gdcmDocument.[h|cxx]:
1184 - Clean up of the Transfer related predicates. They are now all based
1185 on new method isGivenTransferSyntax, that (should) handle properly
1186 the padding problem.
1187 - general clean up, simplification, and coding style.
1188 - Specific clean up of Parse7FE0() (umproperly named actually).
1189 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1191 2004-06-14 Jean-Pierre Roux
1193 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1194 - fix the display of SQItem ordinal number
1195 - add the GetSQItemByOrdinalNumber method
1196 - remove some useless never written private methods
1198 2004-06-14 Jean-Pierre Roux
1200 - adding a constructor taking a gdcmDocEntry as an input param
1201 - ReplaceOrCreateByNumber now returns :
1202 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1203 a gdcmValEntry * if a string value is passed as a param
1205 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1206 according to the param type (no longer sets a gdcmDocEntry)
1207 - GetValEntryByNumber, GetBinEntryByNumber added
1208 - NewValEntryByNumber and NewBinEntryByNumber added
1210 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1212 - GetSQItemNumber and SetSQItemNumber added, to provide
1213 a (relative) Item identier inside a given Sequence
1214 \warning : some pb remaining around this number
1216 - AddEntry now takes the Item Number as a param
1218 - adding a constructor taking a gdcmDocEntry as an input param
1220 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1221 * Memory leak hunt with the following command:
1222 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1223 --show-reachable=yes gdcmTests PrintDocument
1224 It looks like many (all?) leaks are due to the STL (or a bad usage
1225 of the STL. The lines producing the leaks now have a comment with
1226 a "MEMORY LEAK" tag: you can retrieve them with
1227 grep "MEMORY LEAK" src/*
1228 Here are two typical examples which I can't help fixing:
1233 char * test = "babo";
1234 name = test; //// <--- valgrind detects 960 bytes lost in
1235 //// call to std::string::operator=(char const*)
1236 name.clear(); //// Doesn't help !
1244 std::cout << "Type a bunch of characters followed by RETURN: ";
1245 getline(std::cin, line); //// <--- valgrind dectects a loss
1246 //// of 1320 bytes in call to
1247 /// std::basic_istream<>& std::getline<>
1253 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1254 * src/gdcmHeader.[cxx|h]:
1255 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1256 and related, moved away to gdcmDocument.
1257 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1258 the corresponding protected accessors of inherited class
1259 gdcmDocument, removed ! As a consequence gdcmFile had to be
1260 declared friend of class gdcmDocument (see below).
1261 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1262 - Clean up of undefined or unused methods.
1263 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1264 account the changes to gdcmHeader.h).
1265 * src/gdcmDocument.h:
1266 - gdcmFile is now a friend class (in order to take into account the
1267 changes to gdcmHeader.h).
1268 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1269 (see changes to gdcmHeader.h).
1270 - Accessors (reading on the form GetEntry*) are now public.
1271 - Clean up of undefined or unused methods.
1272 * src/gdcmDocument.cxx:
1273 - adaptation to changes to gdcmDocument.h
1274 - ::OpenFile now writes a verbose message when file cannot be opened.
1275 - some std::string properly set to VRKey
1276 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1277 references to gdcmDocument.
1278 * Test/TestFindTags.cxx: changed accordingly to above changes.
1279 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1280 cvs repository gdcmData.
1282 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1283 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1284 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1285 conflicts with gdcmValEntry::voidArea.
1286 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1287 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1288 Value representation between StringRepresentable and BinaryRepresentable.
1289 * src/gdcmDocument.cxx:
1290 - method ParseDES: proper indentation restored and usage of
1291 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1292 - method LoadDocEntry: the fingerprint left in the SetValue() of
1293 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1294 removed. Reverting to previous code segment with the proper
1295 dynamic_cast< gdcmValEntry* >.
1296 Note: this was (partially) breaking the python test suite
1297 (gdcmPython/testSuite.py) that made usage of the above
1298 fingerprint to check presence of "Pixel Data".
1299 * src/gdcmDocEntry.h: coding style.
1300 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1301 now taken into account.
1302 * gdcmPython/gdcm.i: adaptation to the new internal representation
1303 of gdcm (exit gdcmParser, hello gdcmDocument).
1304 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1306 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1307 anymore, but instead prints the loaded Python dictionary.
1308 * .... alas, the python testSuite is still broken.
1310 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1311 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1313 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1314 * src/gdcmUtil.h : export methods
1316 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1317 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1319 * Initial addition of automatic python testing
1320 * Initial addition of automatic image comparison
1322 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1323 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1324 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1326 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1327 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1328 * Test/ShowDicom.cxx : bug fix for msvc compilation
1329 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1331 2004-05-04 Jean-Pierre Roux
1332 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1333 new concepts (and new classes) :
1334 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1335 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1336 - Sequence Doc Entries (gdcmSeqEntries)
1337 a Sequence is composed of Items.
1338 Each item is a set of Doc Entries (this is recursive)
1339 The non uniqueness of the 'Dicom tag' is due to this recursivity
1340 (never taken into account)
1341 Our unability to add a new 'entry' in the header
1342 at the proper location (neither in the H-Table (map or multimap),
1343 nor in the Chained List is also due to this recursivity.
1344 Don't try, right now, to use/modify/compile these new sources :
1345 nothing is finished.
1346 We just commit all the stuff, 'as is', in order not to loose it.
1348 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1349 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1351 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1353 file prefix (SetFilePrefix)
1355 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1356 * Add a new test: ShowDicom, for now this is just the c++ version of
1357 checkRead.sh, later it will be able to compare the image read against a
1359 * Replace the DEBUG on the stack with a global entry in cmake interface:
1360 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1362 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1363 * Add an example subdir, with a real example on how to read + write a
1366 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1367 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1368 * Doc/CMakeLists.txt: the main page is now properly differentiated
1369 between the developper and user version.
1370 * Doc/doxygen.config.in: dropped search related obsolete flags
1371 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1373 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1374 * DEVELOPPER: added some helpfull comments for compile/test/install
1377 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1378 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1379 src directory, now generated in the build dir.
1380 2. Tests as mentionned smarter
1382 4. Add a new method in gdcmDict that return the PubDict by name
1383 this is interesting for 3rd party lib like ITK,
1384 where we could set the institution name / patient name...
1386 * ENH: 1. Now the test suite is working for real
1387 2. All binaries are now output in the gdcm-bin directory
1388 (this was not true before)
1390 2004-04-28 Jean-Pierre Roux
1391 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1392 SeQuence indented printing of Dicom Header.
1393 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1394 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1395 Computation of SQDepthLevel is now part of gdcmHeader constructor
1396 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1397 tree-like structure of a Dicom Header.
1398 * FIX Test code cleaning
1400 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1401 * ENH: Adding automatic testing
1402 1. Need a DartConfig.cmake to submit to public
1403 2. Add a test driver gdcmTest.cxx
1404 3. gdcmTestMain, an helper for the main test driver gdcmTest
1405 4. Files in Test don't have a main anymore, this becomes interesting
1406 when we add more and more tests, thus dsw don't have to load
1408 * ENH: Adding a GDCM_DATA_ROOT for testing
1409 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1410 one file instead of seven + some small cleanup
1412 2004-04-22 Jean-Pierre Roux
1413 * ENH Minor changes to the Print() methods.
1414 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1415 Header printing. Example given with :
1416 > PrintHeader fileName 2 new
1417 (SQ based tree-like structure still to be done for the Header ...)
1419 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1421 1. I have added some unsigned where needed
1422 2. Some function parameter not used -> (void)
1423 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1424 4. g++ don't like character '\' in comment
1425 5. #define jpeg_create_decompress jCreaDecompress
1426 this really need to be fixed
1427 6. virtualize destructor of gdcmObject ... leakage
1428 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1429 this also really need to be fixed
1430 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1431 remove compression file
1432 (as we only do decompression, right ?)
1433 * ENH: Change malloc/calloc/free with c++ equivalent
1435 2004-04-21 Jean-Pierre Roux
1436 * FIX gdcmHeaderHelper::GetXSpacing
1437 when a single value is found (bug ?), xpacing is now
1438 defaulted to yspacing
1440 2004-04-19 Jean-Pierre Roux
1441 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1442 * ENH add parameters :
1443 bool exception_on_error = false,
1444 bool enable_sequences = false,
1445 bool ignore_shadow = false
1446 to the gdcmFile constructors to be full gdcmParser compliant
1447 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1448 to allow reading of PAPYRUS 3.0 files
1450 2004-04-06 Jean-Pierre Roux
1451 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1453 2004-04-02 Jean-Pierre Roux
1454 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1455 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1456 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1458 2004-03-30 Jean-Pierre Roux
1459 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1460 for ACR file, written out as DICOM files (hope so...)
1462 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1464 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1465 moved to base class gdcmParser and only the specialisation is kept
1467 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1468 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1469 already does the job.
1470 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1471 (to be consistent with gdcmParser::WriteEntries).
1473 2004-03-30 Benoit Regrain
1474 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1475 upate of the object's instance. It's passed to 2 in the unfavorable
1476 case : one in the ExecuteInformation, one in the ExecuteData
1478 2004-03-29 Jean-Pierre Roux
1479 * ENH : Check on file type to be written moved
1480 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1481 * FIX : gdcmObject::ResetBoundaries now stops properly
1482 when end-of-list is reached
1483 : gdcmVersion modified (as Benoit Regrain asked)
1485 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1486 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1487 * src/gdcmUtil.cxx: added forgotten iostream include.
1488 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1489 equivalent to ExplicitVR in existing code).
1491 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1492 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1493 now contains all the gdcmGlobal related code.
1494 * minor coding style and doxygenation changes.
1496 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1498 now contains all the Debug related code.
1499 * minor clean-up of includes in src/*.cxx
1500 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1501 CreateCleanString) removed.
1502 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1503 * Doc/DoxyMainPageUser.txt added.
1504 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1505 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1506 src/gdcmDirList.cxx)
1508 2004-03-24 Jean-Pierre Roux
1509 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1511 2004-03-23 Jean-Pierre Roux
1512 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1513 big endian made volumes
1514 * ENH Now gdcmParser constructor and destructor are protected to forbid
1515 end user to instanciate class gdcmParser
1516 (only gdcmHeader and gdcmDicomDir are meaningfull)
1518 2004-03-22 Benoit Regrain
1519 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1520 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1521 gdcmSerie to gdcmDicomDirSerie
1523 2004-03-19 Jean-Pierre Roux
1524 * ENH Now the tree-like structure describing a DICOMDIR comming from
1525 an already existing DICOMDIR file is consistent with
1526 the home-made tree-like structure build ex-nihilo
1527 or build from the files held (recursively) in a Directory
1528 functions gdcmDicomDir::CheckBoundaries()
1529 gdcmObject::SetBoundaries() added
1531 2004-03-17 Jean-Pierre Roux
1532 * REM (Eric Boix bug) : removal of meaningless
1533 gdcmDicomDirImage::NewImage function.
1534 * FIX now file names and directory name are written properly in the
1536 * FIX now gdcmDicomDir constructor may be call without any trick
1539 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1541 of gdcmDicomDirImage::NewImage as empty function.
1543 2004-02-28 Jean-Pierre Roux
1544 * ENH add gdcmDicomDir:NewPatient
1545 add gdcmDicomDirPatient:NewStudy
1546 add gdcmDicomDirStudy:NewSerie
1547 add gdcmDicomDirSerie:NewImage
1548 to allow making gdcDicomDir object.
1549 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1550 (as opposite to the gdcmHeader chained list)
1552 2004-02-11 Benoit Regrain
1553 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1554 when using from python
1556 2004-02-10 Benoit Regrain
1557 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1558 * FIX : in gdcmDicomDir when the directory is empty
1559 * ENH : add callback and methods to get the progression of dicomDir
1562 2004-02-06 Jean-Pierre Roux
1563 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1564 - GDCM_META added to gdcmDicomDirType
1565 - class gdcmMeta created
1566 * ENH : - A brief summary is now displayed at the beginning of
1567 'testDicomDir' to help disaster magnitude estimation
1568 * REM : Now useless Test/explDICOMDIR.cxx
1570 2004-02-05 Benoit Regrain
1571 * ENH : add methods in gdcmObject to get the hash table or the list of
1573 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1574 * FIX : wrapping python for TagHeaderEntryHT
1576 2004-02-04 Benoit Regrain
1577 * FIX : even length for some strings when writting the dicom dir
1578 * FIX : sort the images in the dicom dir
1579 * FIX : Bug fix for python use of dicom dir
1580 * ADD : a python demo
1582 2004-02-04 Jean-Pierre Roux
1583 * FIX : Final solution (?) for icone embedded images
1584 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1585 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1586 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1587 gdcmData/gdcm-MR-SIEMENS-16.acr1
1588 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1589 to make full checking easier
1591 2004-02-04 Benoit Regrain
1592 * FIX : WriteEntries : coding style & logic in parameters
1593 * FIX : Set the elements to create the DicomDir in a dictionary file
1595 2004-02-03 Benoit Regrain
1596 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1597 * gdcmDicomDir : add the load of directory
1598 * Bug fix and print add-on
1600 2004-02-03 Jean-Pierre Roux
1601 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1602 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1603 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1604 * FIX gdcmParser.cxx : 'group length' elements are now considered
1605 as integers, even for shadow groups, when file is Implicit VR
1607 2004-02-02 Jean-Pierre Roux
1608 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1610 of the last synonym :-(
1611 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1613 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1614 * FIX taking into account the possible 7fe0,0010 multiplicity
1615 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1616 to allow removal of references to 7fe0,0010, to deal with
1617 ACR-NEMA images, when 0028,0200 is meaningfull
1619 2004-01-31 Jean-Pierre Roux
1620 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1621 no longer writes 'Un' on disk
1622 * FIX SQ elements with actual length are now dealt with corectly
1623 * FIX gdcmFile::WriteBase make the difference, for color images, between
1624 the length (for Palette expanded images)
1625 and Raw Length (non expanded image + Palette)
1626 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1627 (that broke Write). Replaced by UL.
1628 Aware user will reload the field if he
1629 thinks it's necesssary
1631 2004-01-30 Jean-Pierre Roux
1632 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1633 when 'dirty Acr' is found, to be compliant with the new
1634 IsReadable() methods.
1636 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1637 (no DOUBLE images in kosher DICOM,
1638 but so usefull for people that miss them ;-)
1640 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1641 DICOMDIR related utilities (not checked as Windoze compliant)
1643 2004-01-28 Jean-Pierre Roux
1644 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1646 2004-01-27 Jean-Pierre Roux
1647 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1648 to allow skipping the shadow elements, to save memory space.
1649 The TRUE value for this param has to be used
1650 with a FALSE value for the 'enable_sequence' param.
1651 ('public elements' may be embedded in 'shadow Sequences')
1652 * gdcmHeader methods now deal with 'embedded icones images' in the header
1653 (even when an 'icone image sequence' is announced by the
1654 element (0x0088,0x0200), but there is NO icone at all ...
1656 * gdcmHeader sometimes Image Location value doesn't follow
1657 the supposed processor endianity (see gdcmData/cr172241.dcm).
1660 * gdcmHeader add the method
1661 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1662 to get *all* the Header Entries with the same tag.
1663 GetHeaderEntrySameName is probabely *useless*
1664 (no meaning : Name is *not* an identifier within the Dictionnary)
1666 2004-01-26 Benoit Regrain
1667 * Bug fix in the print of hexadecimal representations. Remove long fields
1668 in the print and add a third level of print to print them
1670 2004-01-23 Benoit Regrain
1671 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1672 * Bug fix on test suite after remove the strip made on not string fields
1673 * Split the IsReadable method between gdcmParser which test that the file
1674 is dicom and gdcmHeader which test that it's an image file
1676 2004-01-22 Benoit Regrain
1677 * DicomDir : clean code, add methods, set variables in protected or private
1678 * gdcmUtil : bug fix for the clean string method
1680 2004-01-19 Benoit Regrain
1681 * Add the use of shadow dictionaries
1682 * bug fix and coding style
1684 2004-01-19 Benoit Regrain
1685 * src/gdcmFile.cxx : bug fix concerning the close of file
1686 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1687 * Add the update of header entries using the shadow library
1689 2004-01-19 Benoit Regrain
1690 * removal of file gdcmHeader2.cxx
1691 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1692 inheriting from gdcmParser. This split is to prepare the integration
1693 of dicom dir parsing
1694 * bug fix under python
1696 2004-01-16 Jean-Pierre Roux
1697 * REM removal of class gdcmHeaderEntrySet
1698 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1699 * ADD add file gdcmHeader2.cxx
1700 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1702 2004-01-15 Benoit Regrain
1703 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1704 entries created while parsing the header. Thus, they will be destroyed
1705 when the gdcmDictSet will be destroyed
1706 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1709 2004-01-15 Benoit Regrain
1710 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1711 made a fatal error because of the memory release at the end of program.
1712 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1713 some memory and vtk seems to have some problems with that.
1714 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1716 2004-01-14 Benoit Regrain
1717 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1718 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1719 * src/*.[h|cxx] : make changes due to class name changes
1720 * gdcmPython/demo/*.py : bug fix due to method names
1722 2004-01-13 Benoit Regrain
1723 * src/*.[h|cxx] : coding style
1724 * vtk/*.[h|cxx] : coding style
1726 2004-01-13 Benoit Regrain
1727 * gdcmPython/testSuite.py : test the readable flag of file for tests
1728 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1729 It's lied to the stl compilation by MSVC (windows, always windows...)
1730 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1732 2004-01-12 Benoit Regrain
1733 * src/*.h : add comments
1734 * src/gdcmDictSet.h : set the method BuildDictPath in public
1735 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1736 directly setted in the source code
1737 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1740 2004-01-09 Benoit Regrain
1741 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1742 * setup.py : use a reference to gdcmVERSION
1744 2004-01-07 Benoit Regrain
1745 * Modification to compile with the distutils.
1748 2003-12-10 Benoit Regrain
1749 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1750 can use a gdcmHeaderHelper to load datas
1751 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1752 made in the source code
1754 2003-12-10 Benoit Regrain
1755 * Update Windows projects and .cvsignore files
1757 2003-11-12 Jean-Pierre Roux
1758 * ENH gdcmHeader constructor has one more parameter (default value : false)
1759 that allows the user to 'go inside' the SeQuences only
1761 gdcmElValSet:Print takes it into account
1763 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1764 * ENH: Update gdcmPython/CMakeLists
1765 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1766 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1768 2003-11-10 Jean-Pierre Roux
1769 * FIX : gdcmHeader::LoadElements is now based
1770 on the ListTag listElem member,
1771 not longer on the TagElValueHT tagHt member
1772 * ENH : PrintPubElVal shows (temporarily) both results,
1773 with the tagHt member and the listElem member.
1774 (it's easier to 'see' the problems when using Printheader)
1776 * FIX : old private member LgrElem is now splitted into
1777 ReadLength : Length actually found on disk (updated only
1778 if bug fixing is necessary), for internal
1780 UsableLength : Updated by FixFoundLength, to fix a bug
1781 or to allow Parser going on.
1782 Will allow to re-write a kosher header when a SeQuence
1783 with a length (not 0000) is found
1784 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1785 because gdcmElValSet::Add does not update ListElem
1788 2003-11-07 Jean-Pierre Roux
1789 * FIX misstyping in Transfert Syntax name table
1790 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1791 when they have an actual length (not 0000 nor FFFFF)
1792 (Nobody should care of it, but DICOMDIR explorers)
1794 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1795 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1797 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1798 * ENH: vtkGdcmReader now supports LUT !
1799 (vtkgdcmViewer for now is not able to use them though)
1801 2003-11-05 Jean-Pierre Roux
1802 * in testSuite.py : new files names for checking the package
1803 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1804 that returns the pixel area size to the *aware* (vtk) user
1805 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1807 2003-11-05 Benoit Regrain
1808 * in testSuite.py : Modify the rules for checking the paths
1809 : Explicit error messages
1810 * in __init__.py : Related modif
1812 2003-11-03 Jean-Pierre Roux
1813 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1814 to be used by aware (vtk) users that want to manage
1815 LUT (and no to turn the PALETTE image into an RGB pixels one)
1816 * GetPixelType now returns 8U for 24 Bits images
1817 (vtkGdcmReader compliant)
1819 2003-10-31 Jean-Pierre Roux
1820 * Removal of *all* gdcmData images and add them again
1821 in order to loose the 'history' of un-anonymised images
1823 2003-10-31 Jean-Pierre Roux
1824 * RMV : removal of useless jBitsInJsample.h
1825 for both 8 and 12 Bits JPEG Lossy Libraries
1827 2003-10-31 Jean-Pierre Roux
1828 * ENH : Add the functions gdcmFile::GetImageDataRaw
1829 gdcmFile::GetImageDataIntoVectorRaw
1830 that act as GetImageData and GetImageDataIntoVector
1831 except the making of an RGB Plane from Gray Plane + LUT
1832 Intended to aware (vtk) users who know how to manage
1835 GetLUTRGBA return a R,G,B,A LUT if any
1836 lgrTotaleRaw gives the 'Raw' length
1837 GetImageDataRaw returns the gray Plane
1838 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1839 (They stay Grey, just like with other Dicom viewers :-(
1841 2003-10-30 Jean-Pierre Roux
1842 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1844 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1845 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1846 being coherents dicom files.
1848 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1849 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1851 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1852 * ENH: Two steps is necessary to please VC++ compiler...
1853 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1854 * ENH: Add include dir to medcon lib
1855 * FIX: only one function is being exported for now !
1856 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1858 2003-10-29 Jean-Pierre Roux
1859 * adding gdcmHeader::GetLUTRGBA
1860 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1861 --> Mathieu, the modif u're waiting for is not yet committed
1862 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1864 2003-10-27 Jean-Pierre Roux
1865 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1866 00191113.dcm DermaColorLossLess.dcm
1867 MxTwinLossLess.dcm RadBWLossLess.dcm
1868 * ENH: For version prior to vtkImageViewer2 -r 1.19
1869 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1871 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * Removal of ido stuff in CMakeLists.txt
1874 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1875 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1876 * FIX: remove a call to ->Modified ... see comments
1877 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1879 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * FIX: Problem with path for libvtkgdcmPython
1881 * ENH: Try adding a search script for python site-package
1882 * RMV: Remove some file from medcon lib that are not necessary
1883 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1884 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1885 * FIX: More pragma disable fro VC++,
1886 I don't think I break something as it is also disable in VTK/ITK.
1887 But it fasten debug compilation time.
1889 2003-10-23 Jean-Pierre Roux
1890 * gdcm now deals with 16 Bits Run Length Encoded images
1891 (they are compressed as 2 planes images,
1892 one for the high Bytes, the other for low Bytes)
1894 2003-10-22 Jean-Pierre Roux
1895 * Now CheckRead takes into account :
1896 - the bugged 'Leonardo' Siemens images
1897 - the XA images, sent thru the burning VPRO station
1898 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1901 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1902 * FIX: When copying a Makefile.am to CMakeLists.txt
1903 one should remove the '\'
1905 2003-10-22 Jean-Pierre Roux
1906 * in gdcmData adding a bugged 'Leonardo' Siemens image
1907 (wrong lengths in header)
1908 OK with gdcm, KO with the other viewers :-)
1909 * add a GE dlx XA image, thru the VEPRO burning station
1912 2003-10-21 Jean-Pierre Roux
1913 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1914 for a brutal checking of vtkgdcmViewer compliance
1916 2003-10-21 Jean-Pierre Roux
1917 * add the files for 'xmedcon' Jpeg Lossless library
1918 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1920 2003-10-21 Jean-Pierre Roux
1921 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1923 2003-10-21 Jean-Pierre Roux
1924 * garbage Siemens 'Leonardo' images dealt with
1925 (the patch is easy to remove)
1926 * cosmetic changes to avoid warnings
1928 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1930 no need to press 'r' now.
1932 2003-10-20 Jean-Pierre Roux
1933 * upgrade of checkRead.sh checkWrite.sh according
1934 to new Jpeg Lossless decompressor
1935 * add US.3405.1.dcm, a genuine RGB medical file ...
1936 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1937 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1939 2003-10-15 Jean-Pierre Roux
1940 * general anonymisation in gdcmData
1941 * adding the 'color files' from
1942 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1943 * adding some well knowed bugged-header images
1944 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1945 waiting for their inclusion in Python testsuite
1947 2003-10-15 Jean-Pierre Roux
1948 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1949 no longer seg faults when file is not found
1951 2003-10-14 Jean-Pierre Roux
1952 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1955 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * TODO: *.in file to genereate a UseGDCM later
1958 2003-10-14 Jean-Pierre Roux
1959 * Some supposed-to-be Dicom Images have no preamble.
1960 OpenFile takes it into account
1961 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1962 * Missing elements added in dicomV3.dic
1963 (just to be affraid : have a look at
1964 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1965 and do it again next year ;->
1967 2003-10-13 Jean-Pierre Roux
1968 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1969 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1970 But there are NOT. It's fixed !
1972 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * FIX: "jpeglib.h" was not found on VC++
1974 * FIX: vtkgdcm was not being installed
1976 2003-10-10 Jean-Pierre Roux
1977 * ENH : OpenFile closes the file if it *really* doesn't look like
1978 an ACR-NEMA / DICOM one.
1979 * FIX : testWrite no longer writes an empty file if the source file
1980 is not gdcm Readable
1981 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1984 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1985 * FIX: CMake generate now documentation
1986 * ENH: out of source doc build !
1987 * ENH: Generate both user and dev documentation
1988 * ENH: Should work on windows too
1989 * ENH: Only one doxygen config.in file is needed
1990 * FIX: make install should be ok now on ùnix plateform
1991 * FIX: PATH to dictionary was wrong (missing /)
1992 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1994 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * vtkGdcmReader is now able to read rgb dicom file.
1996 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1997 * added a gdcmViewer to vtk test, use mouse to control
1998 window level & window width
2000 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2001 * CMake-ification of gdcm, we have now two build system
2002 * FIX: on cygwin Wsock32 doesn't exist
2003 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2005 2003-10-06 Emanuel Ollart
2006 * FIX : compilation process wad broken.
2007 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2009 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2010 * change gdcmViewer -> vtkgdcmViewer
2011 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2013 2003-10-06 Jean-Pierre Roux
2014 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2015 ( e.g : well known GE images with a wrong elem length,
2016 : Philips MRI Images with a wrong Huffman table)
2017 * still to be done : allow the reading of bugged LEONARDO Siemens images
2019 2003-10-03 Jean-Pierre Roux
2020 * Odd length strings are padded with '\0' (not with spaces,
2021 to remain compliant with already defined strings,
2022 like Transfert Syntax UID and others)
2024 2003-10-03 Jean-Pierre Roux
2025 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2026 to allow displaying RGB images (not only by affim ;-)
2028 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2029 * vtkGdcmReader is now able to read rgb dicom file.
2030 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2032 2003-10-03 Jean-Pierre Roux
2033 * A few nasty patches to allow the reading of a lot of nasty images
2034 ( e.g : well known GE images with a wrong elem length,
2035 : Philips MRI Images with a wrong Huffman table)
2036 * still to be done : allow the reading of bugged LEONARDO Siemens images
2038 2003-10-03 Jean-Pierre Roux
2039 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2041 2003-10-03 Jean-Pierre Roux
2042 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2043 to allow displaying RGB images (not only by affim ;-)
2045 2003-10-03 Jean-Pierre Roux
2046 * gdcmFile::GetImageDataIntoVector now
2047 - deals with MultiFrames MultiFragments Run Length Encoded files
2048 - deals with YcBcR (YBR_FULL) files
2049 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2050 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2052 (no sample found :-(
2054 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2056 Two reasons: - clear things
2057 - third parties acces gdcm through header files, so won't
2058 suffer anymore VC++ complains
2060 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * add argv[1] in testvtkGdcmReader.cxx
2064 2003-09-24 Jean-Pierre Roux
2065 * The lines are now eigthy characters long.for
2066 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2068 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2069 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2070 char* to std::string. Thus, the use of strdup becomes useless. (see
2071 previous commis of Malaterre)
2072 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2073 before the last Malaterre's commit.
2075 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * This commit should fix the Debug building under VC++, the problem
2077 was mainly a mixture of debug and release lib being loaded at startup.
2078 * I also remove a depency to a specific C function: strdup. Because I had
2079 to force the link to msvcrtd (whereas strdup is in libc).
2081 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2082 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2083 located in the gdcmCommon.h file. All use of reference of tha has been
2084 changed to now use the variable GDCM_UNFOUND.
2086 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2088 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2089 Dicom dictionary. The test suite can now be run again. Note:
2090 I'm note very happy with the " (RET)" changes. I believe this
2091 RETAINED comment should be dropped when parsing the dictionary.
2092 - PACKAGER corrected
2094 - AUTHORS updated and now in alphabetical order
2095 * Makefile.am now exports gdcm.dsw for Windoze users.
2097 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2098 * cygwin complains about missing std:: in subdir Test/
2100 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2101 * remove some methods that are now in gdcmHeaderHelper
2103 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2104 * vtkGdcmReader set spacing and origin correctly
2106 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2107 * Fix a few delete/delete[] mismatch
2109 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2110 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2111 interpretation to data given by gdcmHeader. For instance there are
2112 heuristics to get informations (look at different places).
2113 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2114 sorting DICOM images based on different strategies.
2115 * modified Makefiles accordingly.
2117 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2118 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2119 when building in debug mode
2120 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2121 src/win32/gdcmdll.dsp
2122 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2124 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2125 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2128 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2129 * src/win32/libgdcmjpeg12.dsp was not dos format
2130 * src/win32/libgdcmjpeg12.dsp :
2131 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2132 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2134 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2135 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2137 * src/gdcmFile.cxx : bug fix in affectation type
2138 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2139 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2140 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2141 symbols... future problem ?
2143 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2144 * src/win32/libgdcmijpeg12.dsp was missing
2145 * modified gdcm.dsw accordingly
2147 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2148 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2150 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2151 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2152 commit of JPR (before his hollidays to facilitate our work).
2153 * setup.py : bug fix in code. Modifications made while the last commit
2154 of JPR. The code hasn't been tested before the commit... it's so
2155 useless to make that (for best programmer that is JPR) !!!
2157 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2158 * tagged the current version as Version0_3 (i.e. version 0.3)
2160 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2161 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2162 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2163 * *.dsp : modifications to use new libgdcmijpeg8 library
2164 * setup.py : bug fix on VTKPATH variable
2165 * PACKAGER : adding all concerning windows
2167 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2170 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2171 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2172 test suite reported error.
2173 * PACKAGER file added (describes what a packager must do when
2174 packaging a new release).
2175 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2176 * configure.in: upgraded version number to 0.3.0
2177 * fixing build of rpm (through rpm -ta):
2178 - Doc/Makefile.am exports proper doxygen files
2179 - src/jpeg/libijg8/Makefile.am exports the include files.
2181 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2182 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2183 * src/gdcmHeader.h : formatting code
2185 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2186 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2187 We were obtaining error message from vtk. Now, creation of file list
2188 is made in an internal list to prevent this problem.
2189 Bug fix when output is empty.
2190 Bug fix in update of progress value. Previous commit for this was a bad
2192 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2194 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2195 * src/gdcmHeader.h : added method to get the file name
2196 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2197 files. Added method to remove all files on the input
2198 Added FIXME comment concerning the bad parsing of header made by
2199 ExecuteInformation method (in ExecuteData method)
2201 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2202 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2203 when using make instal.
2204 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2205 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2207 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2208 * setup.py : adding include dir of jpeg lib to compile all sources
2209 * */Win32/*.dsp : JPR fix for windows compilation
2211 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2212 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2214 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2215 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2217 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * setup.py is again effective on un*x (takes into account the
2219 addon of the jpeg library)
2220 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2221 * Doc/Doxy* updated (includes above enhancements)
2222 * INSTALL now points to web documentation
2224 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2225 * src/gdcmHeader.h doesn't make unnecessary reference to
2227 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2229 * src/gdcm*.[cxx|h] :
2230 - to allow compilation with gcc 3.x
2231 -- clean up of STL usage (added explicit usage of std::)
2232 -- small fixes on exceptions.
2233 Note: linking not tested !
2234 - clean of doxygen comments to avoid warnings at documentation
2236 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2237 dependent convertion).
2239 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * Clean up of previous JPR garbage commit (not even commented in the
2242 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2243 - moved all jpeg related files from src to src/jpeg/libijg8, with
2244 addition/modification of Makefile.am and configure.in.
2245 - the testSuite is still brain damage (not guilty).
2247 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2248 * WrapVTK.py : modifications to get correctly vtk source files to
2250 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2251 (FileName -> Filename)
2253 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * vtk/vtkGdcmReader.[cxx/h]:
2255 - UpdateProgress method should now be effective
2256 - removed the limitation on having only images loaded (as opposed
2258 - when building a stack of images/volume, a lesser number of
2259 gdcmHeader and gdcmFile instances should be used (hopefully
2260 accelerating things).
2261 - when building a stack of images/volumes, files which are not
2262 loadable (wrong path-filename, wrong permissions on existing file,
2263 or file not parsable by gdcm) are replaced with a black image
2264 in the stack (for the caller to notice the problem).
2266 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2269 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2270 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2271 between standard library (std) and vtk library (problems are found
2272 under Windows... thanks Windows !)
2274 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2275 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2277 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2279 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2280 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2282 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2283 * When compiling with distutils (see setup.py) the C++ compiler is
2284 called with different flags than the default ones (with automake).
2285 In order to fix all those warning, I compiled gdcm with the command
2286 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2287 and went for warning fixes:
2288 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2289 up from unused variables.
2290 - vtk/vtkGdcmReader.cxx: potential bug fix.
2291 * src/gdcmHeader.h: Doxygen warning cleanup
2293 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * gdcmPython/gdcm.i:
2295 - typemaps correction to take into account the systematic replacement
2296 of "using namespace std" with std:: prefix e.g. std::list,
2297 std::string... (cf changes of 2003-05-21).
2298 - gdcmGlob global variable of type gdcmGlobal (defined in
2299 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2300 exported to Python a as cvar.
2301 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2302 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2303 gdcmDictSet.GetPubDictTagNames() and
2304 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2305 C++ static methods).
2306 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2307 with the above changes.
2309 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2310 * setup.py, manifest.in : bug fix under linux
2312 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2313 * Modification of setup.py to compile vtk part too. Then, we have 2
2314 wrappers which must work with same distutils. For that, we have a
2315 generic distutils in distusiltsWrapping.py ; with :
2316 - build_extWrap class to wrap generically all extensions,
2317 - ExtensionWrap base class for all wrapping extension that contains
2319 - Wrapper interface which wrap sources
2320 + In WrapSwig.py we have extension and wrapper for Swig
2321 + In WrapVTK.py we have extension and wrapper for VTK
2322 * MANIFEST.in : modifications to consider vtk directory and new python
2323 files for compilation
2325 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2326 * Added python wrappers of vtkGdcmReader vtk class (see the
2327 source in vtk/vtkGdcmReader.cxx) :
2328 - vtk/Makefile.am now builds a library
2329 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2330 python library (as opposed to _gdcm.so wich are the python
2331 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2332 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2334 - configure.in has an additional flag --enable-vtk that needs
2335 to be set to enable compilation of vtk related code, that is:
2336 + vtk/vtkGdcmReader.so and
2337 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2338 + gdcmPython/vtkgdcmPython.so (see above)
2339 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2340 be read when compressed or when HighBit + 1 != BitsStored),
2341 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2342 the usage of the python wrapper of vtkGdcmReader vtk class.
2343 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2344 * src/*.[h] all occurences of stl classes are now prefixed with
2345 std::, and all occurences of "using namespace std;" where removed.
2346 This is to avoid pollution of global namespace in included files.
2347 Apparently vtk does not avoid this pitfall: when using both
2348 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2349 collision of various stl members (principally cout...).
2350 * gdcmPython/testSuite.py now cleanly removes temprory generated
2352 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2353 comply with above changes)
2355 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2356 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2357 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2358 vtk data structure (an image Flip was required).
2359 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2360 * cosmetic changes in documentation.
2362 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2363 * src/gdcmHeader.cxx: the constructor no longer exits when an
2364 unexisting file is given as argument.
2365 * The subdirectory Data (containing all the images used for the
2366 test suite) is not part of this repository anymore. A new module
2367 containing those images is now available at
2368 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2369 with the name gdcmData.
2370 All the python scripts (including the package initialisation file
2371 gdcmPython/__init__.py) were adapated to take this change into
2372 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2374 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2375 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2376 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2377 demo of the usage of this class.
2378 Compilation of this vtk part is only done when using the --enable-vtk
2379 at configure (or autogen.sh) stage.
2381 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2382 * More memory link related corrections and documentation fixes.
2384 - maximum info is obtained with a command of the form:
2385 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2386 --show-reachable=yes PrintHeader
2387 - the remaining reachable blocks seem to come from the STL
2388 allocation scheme through the usage of map and list. It looks
2389 like this memory cannot be freed but it is not a memory leak
2390 (in fact further invocation to the STL would recollect the
2391 unused memory allthough it cannot explicitely be freed).
2392 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2393 of displaying an image parsed with gdcm and displayed with VTK.
2394 Note: some images don't seem to work e.g.
2395 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2396 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2397 Allthough this weakens the semantics, it is a ditch attempt to
2398 make gdcm more thread friendly.
2400 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2401 * Memory link hunt (by using valgrind through the command
2402 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2403 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2404 gdcmHeader::_dicom_vr.
2405 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2406 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2408 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2410 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2411 * src/Makefile.am now exports all the necessary include files at
2415 * UpdateGroupLength replaced by new one
2418 * UpdateGroupLength re-written using H-Table
2419 (named UpdateGroupLengthNew untill checks are over)
2421 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2422 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2423 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2425 - gdcmHeader::GetPubElValSet removed.
2426 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2427 UpdateGroupLength, WriteElements, Write.
2428 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2429 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2430 carried the same semantics.
2431 - src/gdcmHeaderIdo.cxx changed accordingly.
2432 - gdcmFile::WriteBase now regroups all the codes from previous
2433 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2434 - enum FileType moved to gdcmCommon.h
2435 * src/gdcmHeader.cxx AddDefault trashed
2436 * gdcmGetXSize added
2437 * getimageDataSize now calls gdcmGetXSize
2438 * Test/*.cxx changed to agree with above changes
2440 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2442 (to avoid double call by end user).
2443 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2444 by end user, since gdcmHeader::gdcmHeader now handles it.
2446 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * gdcm/Doc many doxygen changes:
2448 - Doxyfile now has two different versions, DoxyfileUsers that generates
2449 the html.users end users oriented documentation and
2450 DoxyfileDeveloppers that generates the html.developper developper
2451 oriented documentation.
2452 - README changed accordingly
2453 - requirement.txt removed (old design info moved to TODO).
2454 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2455 DoxyMainPage.txt, DoxyPython.txt provide more information.
2456 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2457 be updated by simply regenerating the docs with doxygen and copying
2458 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2459 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2460 all the tests in the form "if (<map>.count() >1)" were removed.
2461 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2462 ill-formed documentation sections.
2463 * src/gdcmHeader.cxx: ditto
2465 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * setup.py fixed for un*x (needed macro for stdint.h)
2467 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2468 un*ces with sh-utils test utility.
2469 * gdcmPython/demo/test.py renamed to PrintHeader.py
2470 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2471 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2472 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2473 * src/gdcm*.cxx JPR's bad inclusion fixed.
2475 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2477 * gdcmPython/demo/test.py changed accordingly.
2479 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2480 * gdcmPython/Makefile.am fixed linking against libstdc++
2481 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2482 * Swig subdir (historical tests of swig version 1.3.17++) removed
2483 * Test/testChangeEntete.cxx some lines commented out in order to make
2485 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2486 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2488 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2490 hence the user doesn't need this explicit call.
2491 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2492 i.e. LoadElements() call removed.
2493 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2494 - src/Makefile.am declares the proper flag for g++.
2495 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2496 for adding user defined new tags.
2497 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2498 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2499 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2501 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2502 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2503 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2504 src/Makefile.am : the project should properly compile and install
2505 with the autotools, included the python wrappers part.
2506 * gdcm.spec.in : added a spec file for RPM packaging.
2508 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2509 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2511 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2513 to exported to the environement (see gdcmPython/testSuite.py
2515 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2516 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2517 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2518 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2519 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2521 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * gdcmPython/__init__.py doesn't crash anymore when running in
2523 in InstallMode or PreInstallMode but with an environement given
2524 value of GDCM_DICT_PATH.
2525 * src/gdcmDictSet.[cxx/h] coding style.
2527 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2528 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2529 * src/gdcm.h general comments moved to TODO, and README
2530 * src/gdcm.h should now be seen as a user commodity (including it
2531 should suffice to fully use gdcm). It is nowhere including within
2532 any of the kernel files src/*.cxx and src/*.h.
2534 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2536 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2538 * src/gdcm*.cxx only include their corresponding include file
2539 (as opposed to gdcm.h)
2540 * gdcmPython/gdcm.i changed accordingly
2541 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2542 the autogen.sh generated "make snapshot" command to work.
2543 * autogen.sh removed history related references to crea package.
2545 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2546 * distutilsSwigCPlusPlus.py work around some swig portability
2549 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2550 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2551 was done in a last ditch attempt to get setup.py _really_
2552 operationnal. The python/gdcmPython layaout add the advantage
2553 of hidding away the python related distutils specific files
2554 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2555 Alas, the src directory was out of scope (i.e. it's relative
2556 position to setup.py was ../src) which made things impossible to
2557 handle (see previous version of python/setup.py). Crossing fingers...
2559 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * python/setup.py now works on Un*x. (harder than I thougth)
2561 * python/distutilsSwigCPlusPlus.py can now have include files
2562 among the list of sources.
2564 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2565 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2566 * modifications in MSVC projects
2568 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2569 * As stated by the first lines of Test/ExceptionAndPython/README, it
2570 looks like we can move back to original usage of exception within
2571 src/gdcm* and hence remove the errno stuff that was introduced
2572 as a quick and dirty fixture of this problem (added to the TODO).
2573 * Doc/Doxyfile configuration file for Doxygen and corresponding
2574 README file for usage added.
2575 * Test/testWrite.cxx added. This new test comes from a split of
2576 test.cxx that is now reverted to its original purpous i.e.
2577 testing the proper parsing of a Dicom related file.
2578 testWrite.cxx concentrates on testing the IO part of gdcm.
2579 * Test/bug1.cxx (containing a bug on WIn32) added.
2580 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2581 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2582 whose purpose is to publish the content of the TagNames of the
2583 Dicom public dictionnary were not accessible without an
2584 instance of class gdcmHeader.
2585 - those methods are now static methods of gdcmDictSet and hence
2586 require no instances at all to be invocated.
2587 - within gdcmDictSet this change required to change some method
2588 to class methods (i.e. are now static) among which SetDictPath
2589 (renamed to BuildDictPath) and LoadDefaultPubDict.
2590 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2591 the above changes by calling the new method classes of gdcmDictSet.
2592 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2593 the above to be effective.
2594 * python/gdcmPython: in order to wrap properly the above changes
2595 for Python, swig version now needs to be > 1.3.17.
2596 * python/gdcmPython/Makefile fixed to adapt itself to new
2597 configure/make shema introduced by Johan Montagnat (thanks for the
2598 contribution). Alas this Makefile cannot be turned into a proper
2599 Makefile.am without some heavy changes in the configure.in
2600 (for python dectection).
2601 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2602 now avoids publishing the empty entries.
2604 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2605 * python/setup.py : bug fix concerning install under windows
2606 ExtraPath reused :-P
2607 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2609 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2610 * Dicts/dicomV3.dic : remove double spaces !!!
2611 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2612 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2615 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2616 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2617 method. Doxygenation.
2618 * src/gdcm.h clean up of JPR spurious comments.
2620 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2621 * python/distutilsSwigCPlusPlus.py now properly collects the
2622 shadow classes generated by "swig -c++" (gdcm.py in our case)
2623 when using "python setup.py install".
2624 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2625 reexports the working classes.
2626 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2627 by the classical C errno scheme. This is to prevent an obscure
2628 behavior of the python wrappers when importing wxPython.wx prior
2629 to gdcmPython (which ended up in an abort call). An illustration
2630 of this oddity can be found in the Test/ExceptionAndPython
2631 subdir (see the README file). This problem probably due to
2632 an combination of g++ and dynamic loading.
2633 * added Test/ExceptionAndPython (see above)
2635 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2636 * Changed the layout of the python part to avoid bloating main
2637 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2638 i.e. the distutils arsenal. All the python related stuff is
2639 again in a python subdir, but the package itself is now in
2641 * setup.py was cleaned up:
2642 - pythonIncludePath removed
2643 - python setup.py bdist target is now functional.
2644 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2645 collision with other packages). gdcmPython/demo/*.py changed
2648 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2649 * python subdir moved to gdcmPython (preparation of distutils packaging).
2650 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2651 distutils installer is operational.
2652 * - gdcmPython/__init__.py now properly loads the swig generated
2653 shadow classes (from gdcm.py).
2654 - gdcmPython/demo/*.py changed to import the package gdcmPython
2655 instead of gdcmPython/demo/load.py.
2656 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2658 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2660 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2661 entries within the associated public Dicom dictionary resp. the same
2662 information but sorted by the fourth field (PAT, IMG, DIR) of the
2664 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2665 are now in the "???" group.
2666 - python/gdcm.i changed accordingly,
2667 - python/demo/printGroupedPublicDict.py added, that gives an example
2668 of the above new functionalities in Python.
2670 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2671 * src/gdcm.h, gdcmHeader.cxx:
2672 - historic references to glib's g_malloc and g_free (#defined)
2673 were definitively removed.
2674 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2675 * src/gdcmElValSet.cxx:
2676 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2677 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2678 - GetElValue(string) renamed to GetElValueByName.
2679 - Added GetElementByName(string).
2680 * src/gdcmHeader.cxx: added
2681 - GetPubElValRepByNumber(guint16, guint16)
2682 - GetPubElValRepByName(string)
2683 - GetShaElValRepByNumber(guint16, guint16)
2684 - GetShaElValRepByName(string)
2685 - GetShaElValByNumber(guint16, guint16)
2686 - GetShaElValRepByName(string)
2687 - GetElValRepByNumber(guint16, guint16)
2688 - GetElValRepByName(string)
2689 - GetElValByNumber(guint16, guint16)
2690 - GetElValRepByName(string)
2691 * Doc/requirements.txt added.
2693 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2694 * Test/Makefile building now depends on the one of libgdcm.so
2695 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2696 pixel data) aware which enables finding the address (offset) of
2697 the pixel data of JPEG encoded DICOM files. This leaves only a single
2698 file in the testSuite whose pixel data address (offset) is unknown.
2699 * python/testSuite.py changed accordingly.
2701 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2702 * VC++ has some strong limitations when working with the STL, as stated
2703 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2704 "Also note that some STL containers (map, set, queue, list, deque)
2705 cannot be exported. [...]
2706 Some STL classes contain nested classes. These classes can not
2708 This is caused by a designed limitation that once a template
2709 class is instantiated, it can not be re-instantiated and
2711 Since our usage of map<> is ubiquitous in gdcm, this "designed
2712 limitation" of VC++ is a pitfall.
2713 Hence the Python wrappers of gdcm cannot be incrementally linked
2714 against the c++ dynamic library. The dirty but only workaround is
2715 to forget about incremental link of dynamic libraries and to generate
2716 the Python wrappers library with the inclusions of the underlying C++
2718 The following modifications concern this matter on Win32/VC++:
2719 - wrapping python correct with standalone wrapped dll (don't use separate
2720 dll under windows !!!!)
2721 - python21_d debug mode enabled (ask Frog how to use it :-)
2722 - NO problem with having an STL member of class for example string in C++
2723 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2724 - Python test of dcmlib in Python is ok under windows on a large set
2726 * removed glib references
2727 * typedef's inserted in gdcm.i for correct swig type management
2729 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * python/demo/*.py load.py extracted from test.py. Added explore.py
2731 that only displays required tags and testAll.py that parses all
2732 the files of the testsuite without using unittest.
2733 * python/testSuite.py other additional test on new files added.
2734 * Data/* new test files added accordingly to the testSuite.
2735 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2736 the vr in the file differs from the one of the dictionary.
2738 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2740 values, but limits itself to values which are below a user specified
2741 size (by default 1024 bytes).
2742 * python/gdcm.i : elements not loaded (because their size is above the
2743 user specified treshold) are exported with their TagKey as key of the
2744 python dictionary. This enables the testsuite to make some checks
2745 on the unloaded elements (since we have their offset and size).
2746 * python/testSuite.py
2747 - now tests for the existence and proper value of the pixel data
2748 - two new examples added.
2749 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2751 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2752 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2753 aware. See the strategy comments in gdcmHeader::FindeLength().
2754 * Test/test.cxx now accepts a filename as first argument.
2755 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2756 * python/testSuite.py changed to integrate test on above files.
2758 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2759 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2760 the vr was also RET.
2761 * python/testSuite.py more tests added.
2763 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2764 * python/testSuite.py unittest test suite added (uses Data)
2765 * Data/* dcm and acr files for the test suite.
2766 * glib dependance removed from un*x version. We now use ISO C99
2767 7.18 Integer types (see stdint.h)
2768 - python/Makefile, src/Makefile src/gdcm.h
2769 * src/ when an explicit vr (like dicom files) suddenly poped an
2770 implicit element we use to mark the underlying DictEntry of the
2771 concerned ElValue with "Implicit". This strategy was damageable
2772 too the public or provite dictionaries, since some of their vr
2773 would be changed. Since Header::FindLength heavily relies on the
2774 detection by Header::FindVR of falsely explicit elements, I
2775 added an extra ImplicitVr member to ElValue (boolean).
2776 The rest of the changes we the necessary adaptations.
2778 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2781 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2783 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * Adaptation for porting to VC++:
2786 o forced to use std namespace (for string to be known)
2787 o all class use __declspec export style on WIN32
2788 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2789 (in stdlib.h on Win32 but in std:: for gcc)
2790 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2791 variable GDCM_DICT_PATH.
2792 * src/gdcmHeader.cxx verbose comments made discrete.
2794 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2795 * python/gdcm.i: added a typemap that converts a C++ hashing table
2796 to native Python dictionary.
2797 * python/demo/test.py:
2798 - now uses the native dictionary for exploration of gdcmHeader.
2799 - takes an optional filename argument (the file to parse).
2800 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2801 PubElVals hashing table.
2802 * Dicts/dicomV3.dic removed error prone trailing spaces.
2804 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * Python wrapping process moved away from src/Makefile to
2806 newly created python/Makefile (as well as gdcm.i)
2807 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2808 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2809 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2810 from the environement variable GDCM_DICT_PATH (when existing).
2811 * src/gdcmDict::GetTag bug fix.
2813 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2814 * Straightforward temporary fixes for swig to build the python wrappers.
2815 src/Makefile now has a python working entry [by working we mean
2816 that we can import de shadow classes without errors].
2818 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * hashtest.cxx removed (since allready in Test)
2820 * src/gdcmlib.h renamed to src/gdcm.h
2821 * src/dcm.i renamed to src/gdcm.i
2822 * src/Makefile prepared for python wrapping
2824 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2825 * src/gdcmHeader.cxx :
2826 - Parsing of header is now separated from loading of element values
2827 (see gdcmHeader::LoadElements).
2828 - general clean up of hopefully all file access (creation of
2829 ReadInt16 and ReadInt32)
2831 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2832 * src/gdcmHeader.cxx :
2833 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2835 - SetLgrElem renamed to SetLength
2836 - GetLgrElem renamed to GetLength
2837 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2838 * src/gdcmElValSet.cxx fixed both GetElValue methods
2839 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2840 due to IdoDude was cleaned out.
2842 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2843 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2844 concentrates on finding the value representation (when it exists).
2845 RecupLgr now only finds the element value length, and it avoids
2846 returning the unecessary skL (skipped length).
2847 Also, offsetCourant was simply removed (with taille_fich) since
2848 it was redundant with the File position internals (by using
2849 ftell and fseek). This also made skL (see above in RecupLgr) usage
2851 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2852 on the libido specificities which are handled through class
2854 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2857 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2858 * Truckload of changes. Parsing of header is barely functional
2859 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2861 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2862 * src/gdcmHeader.cxx many addons of low level methods
2864 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2865 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2866 and _IdDcmSWAP_LONG.
2868 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2869 * This corresponds to all the changes decided at the meeting of
2870 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob