1 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
4 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
5 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
7 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
9 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
12 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
13 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
14 The string leaves only in the fonction. So when we make a .c_str(), we
15 get the pointeur on the first element, element that will be destroyed
16 immediately after thee instruction.
17 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
18 file has been opened : the test must be made on the content of the
19 pointer and not directly on the pointer !
22 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
23 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
24 the python part recompiles
26 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
28 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
29 X session is killed (for my computer... it seems to not be identic on
32 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
33 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
34 avoid problems (otherwise, the difference test between the visible image
35 and the reference is incorrect. If the reference is greater than the
36 screen resolution, it's produce errors).
37 Can be used for only one image. Can be used with a visible flag.
38 * vtk/vtkGdcmReader.cxx : remove commented codes.
39 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
40 under windows at compilation
41 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
43 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
45 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
47 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
48 tests on the image size X, Y, Z
50 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
52 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
53 between the class name and the file name
55 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/ : fix compilation warnings for the Write method (2 different
57 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
58 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
59 variable... create a static method in gdcm::Document to access to
60 this variable content.
62 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
63 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
64 file, to be accessed by other files (like gdcmFile). Remove commented
65 code. Move the change of the header to the gdcmFile, using the
67 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
68 To be sure of that (and simplify calls), the Write of the header now
69 gets a file name and not a file pointer (std::ifstream).
70 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
71 DocEntryArchive. Remove all open of the written file
73 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
76 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
78 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
80 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
81 some corresponding methods. Write correctly the file and check before
83 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
84 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
85 is now on RGB datas (as before my last commit
86 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
88 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
90 Add a print information of the type of the entry
91 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
92 It was in the gdcmFile, and all write have been regrouped
93 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
94 Write correctly all dicom files (in decompressed mode only at this time)
95 * Test/ : test on files are now made using Raw datas and not color datas if
97 * Example/PrintFile.cxx : add more printings
99 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Amelioration of code, remove some code copy. For the loading of
101 BinEntry (in gdcmDocument), add the test to verify if the file is already
104 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
106 remove a DocEntry in the header (push an empty DocEntry)
107 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
108 lines. Bug fix in the initialization of the PixelConvert and the
110 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
111 use in TestCopyDicom (now this test can run under windows... but fails)
112 * Test/TestCopyDicom.cxx : amelioration of the test :
113 - test the pixels written
114 - add test points to quickly find where is the error
115 - can set a file name input and output in arguments
116 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
117 amelioration of the test output
119 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
121 all replaced DocEntry's
122 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
123 Now, each needed DocEntry to modify is duplicated, modified and inserted
124 to the header using DocEntryArchive. Thus, after save, we can restore the
125 header initial state.
127 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
130 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
131 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
132 correct to copy it. The DictEntry is specified at the DocEntry creation,
133 then, it musn't change in the time.
134 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
135 header correctly. At this time, the change is only made for the first
136 level of the Document. In the future, it might consider sequences.
137 The change is made by replacing a DocEntry by an other that is created
138 outside the class. The old value is kept. When we restore the header
139 status, the added DocEntry is deleted and replaced by the old value.
140 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
141 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
142 set the write type to explicit VR, implicit VR or ACR. Add methods to set
143 the write mode to native, decompressed or RGB (but not used at this time)
145 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
147 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
149 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
151 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
153 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
154 set because already copied when copying the BinEntry's of the header
155 * Test/TestAllReadCompareDicom.cxx : remove warnings
157 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
159 Two problems appear when doing it :
160 - with the gdcmFile : when the GetImageData method is called, the pixels
161 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
162 datas (pixels). And each structure destruct the datas when it's
163 destructed. So we have two destructions for the same datas. To solve it,
164 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
165 datas or not. If it doesn't own datas, then they will not destroyed by
167 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
168 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
169 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
170 create a double destruction of the same DocEntry's. So, to solve it,
171 the TagHT is simply cleared and the DicomDir* elements are destroyed.
172 * TODO : add an entry concerning memory leaks in the DicomDir
174 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
176 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
179 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
180 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
181 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
182 after it have been deleted
184 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * FIX: src/* fix the doxygen warnings.
186 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
187 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
188 was erroneously defined with a size of 15 instead of 16. [many thanks
189 to Jean Michel Rouet for pointing out this bug].
191 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
192 1. Finish merging JMR patch for writting DICOM from scratch
193 2. Fix -hopefully- bug with MONOCHROME and space vs null character
194 3. Use const ref when possible
195 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
196 5. A few more comments
197 6. CreateUniqueUID can now be called without parameter"
199 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
200 * ENH: Slightly bigger patch:
201 1. Getting toward full integration of JMR patch for writting dicom from scratch
202 2. Update Test to test part of this patch: CreateUniqueUID
203 3. File was not close properly in gdcmDict
204 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
205 5. Use of const ref instead of copy (speed issue)
206 6. Remove temporary (duplicate) string in TranslateToKey
207 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
208 8. Do not repeat virtual in subclasses
209 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
211 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
212 * Apply first patch toward better string comparison when dealing with broken
213 DICOM files. Essentially the string could be padded with a space instead
214 of a null character as defined by standard
216 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
218 because never used... and in the same time, that's remove some memory leaks
220 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmFile.cxx : now delete the PixelConvert instance.
222 * In examples and tests : change the type of image data variables from void*
223 to uint8_t*. Remmove all delete on image data variables
225 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
227 Verify the file pointer value before open the file, and if it's not null,
228 a verbose message is generated.
229 Close correctly the file when the file isn't considered dicom-like. The
230 correctly close is a call to CloseFile.
231 When closing the file pointer, test if its not null to close the file.
232 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
233 file. For an uncompressed image, the copied datas correspond in the least
234 case to the image size (calculated) or the image size specified in the
235 header. A verbose is generated if these two size mismatch
237 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
239 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
240 break under windows (with msvc6 compilation).
242 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
243 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
244 compiling with MSVC6)
246 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
247 * Bugs fix for the Windows build with VC6
248 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
249 needed (only for projects required VTK). If the VTK is included in all
250 projects, there is conflicts with the jpeg lib of vtk when compiling the
251 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
252 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
253 when compiling the gdcm_wrap.cxx file (created by the compilation of the
255 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
256 (like it's already made for the cout use). Otherwise, conflict with the
259 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
260 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
262 - comments on the DicomDir::Method related usage added.
263 - now that we use the namespace gdcm, a lot of internal classes do
264 NOT need to be wrapped anymore.
265 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
266 DicomDir::Method) new example added.
268 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
269 * Improve string manipulation. I now inforce the notion of 'DicomString'
270 A DicomString can contain as many \0 as they want
271 and it is *always* of even length.
272 We only support odd length for very rare case.
273 And in the near future this should be removed.
275 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
276 * /binary_write/ gdcm source. Now even on big endian we are writting
277 little endian. This should -heopfully- fix some tests
279 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
280 * Now the dictionary is compiled into gdcm lib. This is a default
281 behavior, thus any dic file specified is picked before failback to
282 the one comiled into lib
284 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * Change internals for gdcmDict. Don't use any 'new' any more.
286 This should definitely solve any leak problem, and we should be
287 as fast as before, as long as don't modify too much the dictionary.
289 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * STYLE: ivars should start with a capital letter.
291 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
292 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
294 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
295 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
296 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
297 new 2004 dictionaries added (thanks to JPR).
298 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
299 * CLEANUP_ROUND (15) for gdcmPixelConvert
300 - RLEFrame::NumberFragments is now of type unsigned int
301 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
302 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
305 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
306 * Initial work in gathering all transfer syntax accessors. clearly
307 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
308 ivars, but only one transfersyntax (class) ivar with equivalent method on
311 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
312 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
313 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
314 discussed (plus I didn't like having a 2000 lines patch not commited)
316 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
317 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
318 * CLEANUP_ROUND (14) for gdcmPixelConvert
319 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
320 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
321 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
323 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
324 anymore and hence avoids storing a copy of PixelConvert::Decompressed
325 into File::Pixel_Data.
327 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
329 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
330 * CLEANUP_ROUND (13) for gdcmPixelConvert
331 Substituted File::ParsePixelData() with PixelConvert::Print() new
333 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
334 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
335 method to those classes.
336 - src/gdcmFile.[cxx|h]:
337 -- Added a ::Print() method.
338 -- PixelConverter is now a reference instead of a member.
339 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
340 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
342 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
343 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
344 collaboration diagram and inheritance diagram should be generated with
346 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
347 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
348 pointlessly wrapped (see
349 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
350 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
351 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
352 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
353 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
354 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
355 -- File::Initialise: PixelConverter setup moved away to
356 PixelConverter::GrabInformationsFromHeader()
357 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
358 interpretation moved away to PixelConverter::BuildRGBImage()
360 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
361 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
362 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
364 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
366 displayed on Win32 when a brutal abort() occurs (because of uncatched
367 exception). See TODO new entry of this commit for more on this.
368 * TODO added new entry.
369 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
370 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
371 - HandleColor is no longer called from gdcmFile.cxx
372 - gdcmPixelConvert.cxx clean up on method arguments and internal
373 variable names for semantical coherence.
375 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
376 * Finished lossless transition, not only do we now read all lossless jpeg
377 images, without the need of the Cornwell lib, but we do read them properly now
378 * To reduce code (well to avoid code duplication), I defined a common place
379 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
380 redefine symbols. This is not prefect but this the best solution I found for a
381 compilation time jpeg option.
383 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
384 * Update jpeg ijg lib to support lossless jpeg implementation
385 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
387 * Also added a special copyright for dcmtk since we use their bugfixes.
390 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
391 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
392 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
393 matters, as stated in warning note at begining of %include section).
394 * src/gdcmDicomDir*.[cxx|h]: coding style
395 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
396 * src/gdcmJpeg8.cxx: doxygen fix.
397 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
398 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
399 from File:: to PixelConvert::.
401 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
402 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
403 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
404 - more code moved away from File:: to PixelConvert::
405 - fat setup of PixelConverter set in place in File::Initialise.
407 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
408 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
409 namespace at the file system level. So now you should convert your examples
411 gdcmHeader -> gdcm::Header
412 It would be nice if people keep in mind to no open the namespace, since it
413 allows compilation on broken plateform which were defining common symbol in
414 the standart namespace (like LP, Unknown ...)
416 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
417 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
418 The JPEG fragments are now parsed at the same stage than the RLE
419 information. All code related to JPEG is now in gdcmPixelConvert:
420 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
421 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
422 export a gdcmFile:: method. Those are simply global functions
423 (for the time being this is better than having them attach to
424 either gdcmFile:: or gdcmPixelConvert::).
425 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
426 and stores the result in a gdcmJPEGFragmentsInfo.
427 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
428 code (among other stuff) moved away from gdcmFile:; to
431 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
433 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
434 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
435 clean up of RLE related code.
436 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
437 - src/gdcmRLE.cxx removed
438 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
439 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
440 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
441 * CLEANUP_ROUND (9) for gdcmPixelConvert
442 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
443 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
444 away from gdcmFile:: to gdcmPixelConvert::.
446 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
447 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
448 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
449 This is because Parse7Fe0 used to parse the pixels to compute the
450 length. This task was passed over to FindDocEntryLengthOB() a long
451 time ago, EXCEPT I had forgotten the OW case...
452 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
453 we just recylce the code for parsing RLE fragments and computing
455 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
456 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
457 with the retired Parse7Fe0().
458 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
459 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
461 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
462 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
463 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
464 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
465 - src/CMakeLists.txt: alphabetic order reodering + new entries.
466 * CLEANUP_ROUND (4) for gdcmPixelConvert
467 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
468 to return an unused length.
470 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
472 this should be cleanner from the plane view. The iostream are erally a pain
473 to use to do simple stuff.
475 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
476 * Redo the compilation of the ijg jpeg library. Now only one source is
477 necesseray. No need to rename file by hand what so ever. CMake handle the
478 copying of the file within different directory, configure header file to
479 modify some symbol. The only addition made to ijg wasd a mangle table so
480 that symbol are different wether we are within 8bits or 12bits.
482 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
483 * Added documentation of vtkgdcmReader on Website:
484 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
485 with it's binary name).
486 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
487 the Website to be more complete.
488 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
489 doxygenated documentation.
490 - Doc/DoxyVtkGdcmReaderExamples.txt added
491 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
492 DoxyVtkGdmReaderExamples.html )
493 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
494 * CLEANUP_ROUND (3) for gdcmPixelConvert
495 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
497 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
498 * CLEANUP_ROUND (2) for gdcmPixelConvert
499 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
501 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
502 * CLEANUP_ROUND for gdcmPixelConvert:
503 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
504 - src/gdcmPixelStuff[h|cxx] removed
505 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
506 - src/CMakeLists.txt changed accordingly
508 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
509 gdcmVersion.py moved to newly created ATTIC related
510 gdcmPython/SetupOldies/ directory.
511 * Autotools clean up:
512 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
513 - autogen.sh configure.in acinclude.m4 python.m4 removed
515 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
516 * src/*.cxx *.h Reference to License.htm fixed to License.html.
517 * Doc/CMakeLists.txt, doxygen.config.in: fix.
518 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
520 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
521 * TODO updated with Mathieu suggestions. I proposed a template for
522 describing TODO entries and used it for new entries.
523 * Added Doc/Website/CodingStyle.html, Developpers.html,
524 DeveloppersPython.html, GdcmDataCvs.html and
525 DownloadVersion0_1.html, DownloadVersion0_3.html.
526 * Some Doc/*.txt Doxygen files (which do not really concern the
527 documentation itself, but the website) moved to html and
528 placed in directory Doc/Website:
529 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
530 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
531 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
532 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
533 * CMakeLists.txt changed accordingly.
534 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
535 DeveloppersPython.html
536 * INSTALL nows refers to Doc/Website/Installation.html
538 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * Added Doc/Website directory, that contains a first raw version
542 2004-09-23 Jean-Pierre Roux
543 * FIX In order not to be poluted any longer by casting problems,
544 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
545 we can now delete[] it safely
546 * VoidArea is now called BinArea (less confusing name),
547 and all the methods called ...VoidArea... are now ... BinArea...
548 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
550 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
551 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
552 clear) TagHT, which is an inherited member of gdcmElementSet. It is
553 up to the destructor of gdcmElementSet to clean up TagHt and it's
556 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * Test/CMakeLists.txt: update to follow gdcmData renamings.
558 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
560 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
561 * ENH: added some utility method that builds a flat dictionnary
562 holding all the Dicom entries contained in the recursive structure
563 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
565 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
566 BuildFlatHashTable() that build a flat dictionary.
567 - src/gdcmElementSet.h: added a new private GetTag() accessor.
568 gdcmDocument is now a friend of gdcmElementSet.
569 - src/gdcmElementSet.cxx: clean up.
570 - Example/FlatHashTablePrint.cxx added.
571 - Example/CmakeLists.txt changed accordingly
573 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
575 moved away from gdcmDocEntrySet (since this class is an abstract class
576 acting like an interface). SQDepthLevel and BaseTagKey are now
578 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
579 and associated accessors. Doxygenation of the class.
580 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
582 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
583 Use SQDepthLevel accessor instead. ::Print() adapted.
584 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
585 - src/gdcmDocument.cxx changed accordingly.
587 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
589 - The following is the doxygen comment of the typedef declaration
590 of gdcmagKey in src/gdcmCommon.h:
591 gdcmTagKey is made to old an "universal" (as in URL, Universal
592 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
593 A dicom tag allways has a group and an element, but a set of tags
594 embeded in various (optionally nested) sequences and sharing
595 the same group and element all share the same (group, element)
596 "identifier". Hence the (group, element) cannot be used as an
597 identifier (in gdcm we shall refer to a "TagKey") of a tag.
598 In order to construct a proper tag identifier (i.e. a key) we
599 consider the following definition of a TagKey:
600 - let Group, Element be the string representation of the
601 group and element dicom tag members,
602 - let ItemNumber be the string representation of the integer
603 index of the considered item number of a sequence,
604 Let the key of a tag embeded in a sequence, noted SeqTag, be
606 /ItemNumber#Group|Element
607 where "/", "#" and "|" are characters acting as separators.
608 Then the general form of a gdcmTagKey is given by:
609 Group|Element<SeqTag>
610 where <SeqTag> means NO or many instances of SeqTag.
611 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
614 but the gdcmTagKey of a tag "embeded" is the first item of
615 a sequence, itself nested in the third item of a sequence is the
617 0004|1220/2#0008|0082/0#0008|0090
618 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
619 order to hold the new sequence compatible key. Previously, the
620 GetKey() method would look in the underlying gdcmDictEntry.
621 - src/gdcmDocEntry.cxx:
622 -- constructor now copies the underlying DictEntry key, in the local
624 -- ::Print: displays the member Key, instead of the (group, element).
625 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
626 - src/gdcmDocEntrySet.h:xi
627 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
628 -- now has a new BaseTagKey member.
630 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
631 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
633 This poses the problem with the semantics of the following lines
634 LoadEntryVoidArea(0x0028,0x1201); // R LUT
635 LoadEntryVoidArea(0x0028,0x1202); // G LUT
636 LoadEntryVoidArea(0x0028,0x1203); // B LUT
637 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
638 to the long FIXME note for what the problem is. Nevertheless in
639 order to get things working the dicom dictionary was altered !
640 Please fix things urgently...
641 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
642 information), see above note on moving the member VoidArea. Nevertheless
643 the following entries previously correctly set as US are now inproperly
645 0028 1201 OW IMG Red Palette Color Lookup Table Data
646 0028 1202 OW IMG Green Palette Color Lookup Table Data
647 0028 1203 OW IMG Blue Palette Color Lookup Table Data
648 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
649 of gdcmDocEntry moved to gdcmSeqEntry.
650 * src/gdcmSeqEntry.cxx: STYLE.
652 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * Test/TestAllEntryVerify.cxx minor fix and added comments.
655 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * gdcmPython/testSuite.py: all the test suite in python is now moved
657 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
658 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
659 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
661 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
662 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
663 to avoid inclusion recursion until STL is reached.
664 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
665 mecanism. errno.h is not included in gdcm anymore.
666 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
667 (gdcmFormatError now inherits from gdcmFormatUnexpected).
669 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
670 gdcmData/TestAllEntryVerifyReference.txt
671 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
672 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
673 exception_on_error parameter.
674 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
675 - vtk/vtkGdcmReader.cxx changed accordingly,
676 - Example/*.cxx and Test/*.cxx changed accordingly.
678 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
679 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
680 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
681 enable_sequences removed from gdcmHeader constructor and dependencies.
682 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
683 * gdcmPython/demo/PrintHeader.py: dummy fix.
684 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
685 skip_shadow removed from gdcmHeader constructor and dependencies.
686 * Example/*.cxx and Test/*.cxx changed accordingly.
688 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
689 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
690 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
692 2004-07-21 Jean-Pierre Roux
693 * FIX Now, Parsing and Printing a DICOMDIR do work!
694 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
696 2004-07-20 Jean-Pierre Roux
697 * FIX Some brain damaged headers have Zero-Lenght fields
698 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
700 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
702 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
703 variable (instance of gdcmDebug) by a definition macro, and the instance
704 is now in static in the gdcmDebug class
705 * src/gdcmSQItem.h : (FIXME) remove an undefined method
706 * Test/PrintAllDocument.cxx : bug fix in the result of the test
708 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * WARNING: ctest now depends more tightly on gdcmData. You should
710 check out gdcmData properly for things to run smoothly...
711 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
712 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
713 we need the pixels not be loaded in order to use the ValEntry
714 that displays position and size).
715 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
716 This is a C++ based equivalent of gdcmPython/testSuite.py that should
717 be deprecated. If you have any doubts about the advantages of a
718 modern scripting language (read Python) versus grass root C++ (i.e.
719 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
720 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
721 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
722 Anyhow, consider documenting the gdcmData images in
723 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
725 * Test/CMakeLists.txt:
726 - now uses TestAllEntryVerify.cxx
727 - specific comments on oldACR00001.ima (now renamed in gdcmData
728 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
729 gdcmData/TestAllEntryVerifyReference.txt
732 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
733 * src/*.[h|cxx] : typedef clean up
734 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
735 - TagKey renamed to gdcmTagKey (for external usage)
736 - VRKey renamed to gdcmVRKey (for external usage)
737 - removal of typedef duplication.
738 - Removed all unecessary inline keyword from class inline definitions.
739 - Some method|function(void) declarations replaced with method|function().
740 * src/jpeg/libijg12/jdhuff12.c:
741 - printf polluting ctest removed.
742 - TAB removal for comminting
744 - TestAllReadCompareDicom.cxx: added a test that compares all the
745 images in gdcmDataImages.h with corresponding images in
746 gdcmData/BaselineDicom/. When baseline images are not present
747 this test creates them.
748 Note: we need to validate each reference image, but before that
749 I'd like to rename them with a more explicit name...
750 - CMakeLists.txt: changed accordingly.
751 * Example/*.cxx: examples now only include gdcm.h (as opposed to
752 including each header needed).
754 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
755 * Test/*.cxx and Example/*.cxx: moved some examples away from the
756 test suite to the Example directory. Are concerned:
761 - TestWriteSimple.cxx
762 * Test/CMakeLists.txt: added some comments on reasons for black listing
763 image gdcmData/oldACR00001.ima
765 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * Test/CmakeList.txt: removed the following from black list (to be coherent
767 with removal from gdcmData):
768 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
769 - gdcm-MR-PHILIPS-16.dcm
771 Added the following because after last cvs update, they cause
772 ctest -R TestReadWriteReadCompare
774 - gdcm-MR-SIEMENS-16-1.acr
776 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
777 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
778 new comments in this file) we temporarily (sigh) move to a weaker
780 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
781 we don't need to black list the following images anymore:
782 - 8BitsUncompressedColor.dcm
784 - US-PAL-8-10x-echo.dcm
785 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
786 fixes and the beautified code ;-)
787 This fixes the bug introduced in version 1.42 (when beautifying)
788 that made the parsing of 8BitsRunLengthColor.dcm unproper.
789 Note: ctest was blind to this bug (this means we need to still
790 improve the test suite). The bug could be detected by using
791 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
793 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
794 and by displaying the (garbage) produced file temp.XDCM...
796 2004-06-29 Jean-Pierre Roux
797 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
798 - replace by uggly but working old code :-(
799 A lot of things should be OK again.
800 It's really urgent to have a test suite that *tests*,
801 to prevent Frog's beautifying sessions to break all the stuff
802 (twice, withing a fortnigh ...)
804 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
805 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
806 redundancy) to added Test/TestReadWriteReadCompare.cxx
807 * Test/CmakeList.txt: because the compare test of
808 Test/TestReadWriteReadCompare.cxx fails, the following images are
809 black listed: - 8BitsUncompressedColor.dcm
811 - US-PAL-8-10x-echo.dcm
812 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
813 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
814 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
815 and ad-hoc kludge. This kludge is now removed, and on encountering
816 such an image (OB field brain damaged) we set errno. Then in
817 ::FindDocLength() we "fix" the length as being ALL what remains
818 in the file (until EOF). We then proceed, hoping for the best...
819 This fixes a SegFault in ShowDicom when trying to write such an
821 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
822 (because TestWriteRead breaks on it, after a non conformal commit?).
823 ctest now runs properly, except for MakeDicomDir (which was allways
824 broken) and the Python related stuff (still not fixed).
826 2004-06-24 Jean-Pierre Roux
827 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
828 FIX : Test/TestReadWrite now iterates on all the file names
829 (instead of infinite loop)
830 ENH : Test/TestWriteRead now iterates on all the file names
832 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
835 2004-06-24 Jean-Pierre Roux
836 FIX : - now Write drops LUT Descriptors and LUTs (if any)
837 when SamplesPerPixel =3
838 - now Write is no longer confused by
839 'BitsAllocated = 12" and 'BitsStored=12"
840 - "UN" value representation Elements are now written correctly
841 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
842 ENH : - now gdcmHeader has its own Write methods
843 (in order to split the job that has not to be done
846 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
847 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
848 loop on the same image until memory went out.
849 Note: this means we still have gobs of memory loss in PrintDocument
850 * src/gdcmDocument.cxx: fixes problem on parsing on file
851 gdcmData/16BitsJpegLosslessGrayScale.dcm.
853 2004-06-24 Jean-Pierre Roux
854 FIX : Write - All the Sequences and Sequence Item are now written
855 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
856 is added a the end, when necessary.
857 - A lot of brain-damaged images, that were read correctly are
858 now written correctly
859 - length compatible BinEntry are now loaded correctly
860 (even for odd groups)
861 Note : only Explicit Value Representation was checked.
862 (question : is implicit VR really necessary for gdcm ?)
864 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
865 * DEVELOPPER: added a proposition of coding style.
866 * src/gdcmDocEntry.h: removed every inline declaration (for test of
869 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
871 Use the gdcmDocEntry::Print() and Write() instead.
872 * src/gdcmDocument.cxx: bug fix.
874 2004-06-22 Jean-Pierre Roux
875 FIX : gdcmDocument.cxx
876 - Now we do recognize the JpegLossLess format (there was a misstyping in
877 code 'beautyfication' :-(
878 - Now we automaticaticaly load the Luts, if any
880 2004-06-22 Jean-Pierre Roux
881 In order : to write Sequences, whatever their imbrication level,
882 : to allow user to create his own Sequences
883 a lot of modif where necessary (adding, moving, or virtualising methods)
885 WARNING : save your own sources *before* cvs up !
888 ADD virtual void Write(FILE *fp, FileType filetype);
891 ADD virtual void Write(FILE *fp, FileType filetype);
892 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
895 ADD virtual void Write (FILE *fp, FileType filetype)=0;
896 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
897 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
898 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
899 ADD std::string GetEntryByName(TagName name);
900 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
902 std::string vr = "unkn",
903 std::string fourth = "unkn",
904 std::string name = "unkn");
905 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
906 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
907 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
908 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
909 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
910 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
911 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
912 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
915 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
916 ADD virtual std::string GetEntryByName (TagName tagName);
917 ADD virtual std::string GetEntryVRByName (TagName tagName);
918 REM virtual bool Write(FILE *, FileType);
919 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
920 FILE *_fp, FileType type);
921 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
922 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
923 REM virtual bool WriteEntries(FILE *_fp,FileType type);
924 REM virtual std::string GetEntryByName (std::string tagName);
925 REM virtual std::string GetEntryVRByName (std::string tagName);
926 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
927 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
928 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
930 std::string vr = "unkn",
931 std::string fourth = "unkn",
932 std::string name = "unkn");
933 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
934 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
935 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
936 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
939 ADD virtual void Write(FILE *fp, FileType filetype);
942 ADD virtual void Write(FILE *fp,FileType filetype);
945 ADD virtual void Write(FILE *fp, FileType filetype);
946 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
947 REM std::string GetEntryByNumber(guint16 group, guint16 element);
948 REM std::string GetEntryByName(TagName name);
951 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
953 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
954 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
955 The default constructor invoked by the line
956 gdcmHeader *f1 = new gdcmHeader( header );
957 was gdcmHeader::gdcmHeader(bool) instead of the expected
958 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
959 Hence the parsing wasn't executed... See also below.
960 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
961 as explicit constructor didn't do the trick to fix the above problem.
962 Could anyone explain why ?
963 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
964 properly calls gdcmValEntry::Print() (that was weed out from
965 code related to gdcmBinEntry).
967 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
968 * In order to fix memory leaks:
969 - Test/TestWriteSimple.cxx: added cleaning of free store through
971 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
972 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
973 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
974 (through the call to ::AddDicomDirMeta()) or the destructor
975 would crash when deleting uninitialized ::metaElems].
976 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
977 - src/gdcmDocument.cxx:
978 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
980 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
981 was causing memory leaks.
982 - src/gdcmSQItem.cxx:
983 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
984 cleanly handled with polymophism: sorry but my milage is low).
985 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
986 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
987 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
988 This avoids SegFaulting.
989 - src/gdcmSQItem.h: coding style.
991 - Test/TestWriteSimple still severely sucks. The output image content
992 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
993 damaged when displayed with vtkgdcmViewer.
994 - on memory leaks: TestWriteSimple leaks really less (see entry
995 of 2004-06-18 in Changelog file for the call to valgrind).
996 - on segfaults: ctest now passes all the tests but one (no more
998 * Erroneous leading white fix:
999 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1000 white[s] (as opposed to from >> xxx, that removes it [them].
1001 - src/gdcmTS.cxx: ditto.
1002 - gdcmPython/testSuite.py: dirty related kludge removed.
1003 * src/*: remaining references to gdcmParser removed.
1004 * src/*[cxx|h]: added copy[way]left header.
1007 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1008 * In order to fix writing of dicom files:
1009 - Test/TestWriteSimple.cxx: a simpler example of writing.
1010 - Test/CMakeLists.txt changed accordingly.
1011 - src/gdcmDocument.cxx:
1012 -- The destructor now recursilvely removes potential sequences.
1013 -- Bug fix in ::IsJPEG2000()
1014 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1015 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1017 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1018 to only declared) and build on top of
1019 ::GetDocEntryByNumber(guint16, guint16).
1020 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1021 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1022 for usage in destructor and treatement of promotion in
1023 ::ReplaceOrCreateByNumber().
1024 - src/gdcmSQItem.cxx: destructor should better handle his job.
1025 Test/TestWriteSimple now runs (or at least it DOES something).
1026 * We can now start hutting memory links. A good starting point is:
1027 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1028 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1029 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1031 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1032 * Valgrind note: after Mathieu Malaterre teached me how to read
1033 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1035 Using gcc, you can force the STL to use malloc and to free memory as
1036 soon as possible by globally disabling memory caching.
1037 With 3.2.2 and later, you should export the environment variable
1038 GLIBCPP_FORCE_NEW before running your program.
1039 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1040 simply vanish (it is still not clear to me, whether this means that
1041 STL std::string leaks or if valgrind believes it leaks...).
1042 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1043 running bin/gdcmTests makeDicomDir):
1044 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1045 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1047 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1048 SegFaulting (I drowned in DicomDir related code when trying to
1049 understand why the list is empty...).
1050 * src/gdcmDocument.h: first BSD license header try.
1051 * Doc/License.txt added.
1053 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1054 * src/gdcmDocument.[h|cxx]:
1055 - Clean up of the Transfer related predicates. They are now all based
1056 on new method isGivenTransferSyntax, that (should) handle properly
1057 the padding problem.
1058 - general clean up, simplification, and coding style.
1059 - Specific clean up of Parse7FE0() (umproperly named actually).
1060 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1062 2004-06-14 Jean-Pierre Roux
1064 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1065 - fix the display of SQItem ordinal number
1066 - add the GetSQItemByOrdinalNumber method
1067 - remove some useless never written private methods
1069 2004-06-14 Jean-Pierre Roux
1071 - adding a constructor taking a gdcmDocEntry as an input param
1072 - ReplaceOrCreateByNumber now returns :
1073 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1074 a gdcmValEntry * if a string value is passed as a param
1076 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1077 according to the param type (no longer sets a gdcmDocEntry)
1078 - GetValEntryByNumber, GetBinEntryByNumber added
1079 - NewValEntryByNumber and NewBinEntryByNumber added
1081 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1083 - GetSQItemNumber and SetSQItemNumber added, to provide
1084 a (relative) Item identier inside a given Sequence
1085 \warning : some pb remaining around this number
1087 - AddEntry now takes the Item Number as a param
1089 - adding a constructor taking a gdcmDocEntry as an input param
1091 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1092 * Memory leak hunt with the following command:
1093 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1094 --show-reachable=yes gdcmTests PrintDocument
1095 It looks like many (all?) leaks are due to the STL (or a bad usage
1096 of the STL. The lines producing the leaks now have a comment with
1097 a "MEMORY LEAK" tag: you can retrieve them with
1098 grep "MEMORY LEAK" src/*
1099 Here are two typical examples which I can't help fixing:
1104 char * test = "babo";
1105 name = test; //// <--- valgrind detects 960 bytes lost in
1106 //// call to std::string::operator=(char const*)
1107 name.clear(); //// Doesn't help !
1115 std::cout << "Type a bunch of characters followed by RETURN: ";
1116 getline(std::cin, line); //// <--- valgrind dectects a loss
1117 //// of 1320 bytes in call to
1118 /// std::basic_istream<>& std::getline<>
1124 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * src/gdcmHeader.[cxx|h]:
1126 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1127 and related, moved away to gdcmDocument.
1128 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1129 the corresponding protected accessors of inherited class
1130 gdcmDocument, removed ! As a consequence gdcmFile had to be
1131 declared friend of class gdcmDocument (see below).
1132 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1133 - Clean up of undefined or unused methods.
1134 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1135 account the changes to gdcmHeader.h).
1136 * src/gdcmDocument.h:
1137 - gdcmFile is now a friend class (in order to take into account the
1138 changes to gdcmHeader.h).
1139 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1140 (see changes to gdcmHeader.h).
1141 - Accessors (reading on the form GetEntry*) are now public.
1142 - Clean up of undefined or unused methods.
1143 * src/gdcmDocument.cxx:
1144 - adaptation to changes to gdcmDocument.h
1145 - ::OpenFile now writes a verbose message when file cannot be opened.
1146 - some std::string properly set to VRKey
1147 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1148 references to gdcmDocument.
1149 * Test/TestFindTags.cxx: changed accordingly to above changes.
1150 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1151 cvs repository gdcmData.
1153 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1154 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1155 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1156 conflicts with gdcmValEntry::voidArea.
1157 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1158 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1159 Value representation between StringRepresentable and BinaryRepresentable.
1160 * src/gdcmDocument.cxx:
1161 - method ParseDES: proper indentation restored and usage of
1162 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1163 - method LoadDocEntry: the fingerprint left in the SetValue() of
1164 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1165 removed. Reverting to previous code segment with the proper
1166 dynamic_cast< gdcmValEntry* >.
1167 Note: this was (partially) breaking the python test suite
1168 (gdcmPython/testSuite.py) that made usage of the above
1169 fingerprint to check presence of "Pixel Data".
1170 * src/gdcmDocEntry.h: coding style.
1171 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1172 now taken into account.
1173 * gdcmPython/gdcm.i: adaptation to the new internal representation
1174 of gdcm (exit gdcmParser, hello gdcmDocument).
1175 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1177 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1178 anymore, but instead prints the loaded Python dictionary.
1179 * .... alas, the python testSuite is still broken.
1181 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1182 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1184 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1185 * src/gdcmUtil.h : export methods
1187 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1188 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1190 * Initial addition of automatic python testing
1191 * Initial addition of automatic image comparison
1193 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1194 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1195 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1197 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1198 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1199 * Test/ShowDicom.cxx : bug fix for msvc compilation
1200 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1202 2004-05-04 Jean-Pierre Roux
1203 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1204 new concepts (and new classes) :
1205 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1206 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1207 - Sequence Doc Entries (gdcmSeqEntries)
1208 a Sequence is composed of Items.
1209 Each item is a set of Doc Entries (this is recursive)
1210 The non uniqueness of the 'Dicom tag' is due to this recursivity
1211 (never taken into account)
1212 Our unability to add a new 'entry' in the header
1213 at the proper location (neither in the H-Table (map or multimap),
1214 nor in the Chained List is also due to this recursivity.
1215 Don't try, right now, to use/modify/compile these new sources :
1216 nothing is finished.
1217 We just commit all the stuff, 'as is', in order not to loose it.
1219 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1220 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1222 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1223 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1224 file prefix (SetFilePrefix)
1226 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1227 * Add a new test: ShowDicom, for now this is just the c++ version of
1228 checkRead.sh, later it will be able to compare the image read against a
1230 * Replace the DEBUG on the stack with a global entry in cmake interface:
1231 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1233 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1234 * Add an example subdir, with a real example on how to read + write a
1237 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1238 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1239 * Doc/CMakeLists.txt: the main page is now properly differentiated
1240 between the developper and user version.
1241 * Doc/doxygen.config.in: dropped search related obsolete flags
1242 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1244 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1245 * DEVELOPPER: added some helpfull comments for compile/test/install
1248 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1249 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1250 src directory, now generated in the build dir.
1251 2. Tests as mentionned smarter
1253 4. Add a new method in gdcmDict that return the PubDict by name
1254 this is interesting for 3rd party lib like ITK,
1255 where we could set the institution name / patient name...
1257 * ENH: 1. Now the test suite is working for real
1258 2. All binaries are now output in the gdcm-bin directory
1259 (this was not true before)
1261 2004-04-28 Jean-Pierre Roux
1262 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1263 SeQuence indented printing of Dicom Header.
1264 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1265 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1266 Computation of SQDepthLevel is now part of gdcmHeader constructor
1267 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1268 tree-like structure of a Dicom Header.
1269 * FIX Test code cleaning
1271 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1272 * ENH: Adding automatic testing
1273 1. Need a DartConfig.cmake to submit to public
1274 2. Add a test driver gdcmTest.cxx
1275 3. gdcmTestMain, an helper for the main test driver gdcmTest
1276 4. Files in Test don't have a main anymore, this becomes interesting
1277 when we add more and more tests, thus dsw don't have to load
1279 * ENH: Adding a GDCM_DATA_ROOT for testing
1280 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1281 one file instead of seven + some small cleanup
1283 2004-04-22 Jean-Pierre Roux
1284 * ENH Minor changes to the Print() methods.
1285 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1286 Header printing. Example given with :
1287 > PrintHeader fileName 2 new
1288 (SQ based tree-like structure still to be done for the Header ...)
1290 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1291 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1292 1. I have added some unsigned where needed
1293 2. Some function parameter not used -> (void)
1294 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1295 4. g++ don't like character '\' in comment
1296 5. #define jpeg_create_decompress jCreaDecompress
1297 this really need to be fixed
1298 6. virtualize destructor of gdcmObject ... leakage
1299 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1300 this also really need to be fixed
1301 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1302 remove compression file
1303 (as we only do decompression, right ?)
1304 * ENH: Change malloc/calloc/free with c++ equivalent
1306 2004-04-21 Jean-Pierre Roux
1307 * FIX gdcmHeaderHelper::GetXSpacing
1308 when a single value is found (bug ?), xpacing is now
1309 defaulted to yspacing
1311 2004-04-19 Jean-Pierre Roux
1312 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1313 * ENH add parameters :
1314 bool exception_on_error = false,
1315 bool enable_sequences = false,
1316 bool ignore_shadow = false
1317 to the gdcmFile constructors to be full gdcmParser compliant
1318 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1319 to allow reading of PAPYRUS 3.0 files
1321 2004-04-06 Jean-Pierre Roux
1322 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1324 2004-04-02 Jean-Pierre Roux
1325 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1326 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1327 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1329 2004-03-30 Jean-Pierre Roux
1330 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1331 for ACR file, written out as DICOM files (hope so...)
1333 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1334 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1335 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1336 moved to base class gdcmParser and only the specialisation is kept
1338 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1339 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1340 already does the job.
1341 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1342 (to be consistent with gdcmParser::WriteEntries).
1344 2004-03-30 Benoit Regrain
1345 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1346 upate of the object's instance. It's passed to 2 in the unfavorable
1347 case : one in the ExecuteInformation, one in the ExecuteData
1349 2004-03-29 Jean-Pierre Roux
1350 * ENH : Check on file type to be written moved
1351 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1352 * FIX : gdcmObject::ResetBoundaries now stops properly
1353 when end-of-list is reached
1354 : gdcmVersion modified (as Benoit Regrain asked)
1356 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1357 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1358 * src/gdcmUtil.cxx: added forgotten iostream include.
1359 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1360 equivalent to ExplicitVR in existing code).
1362 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1363 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1364 now contains all the gdcmGlobal related code.
1365 * minor coding style and doxygenation changes.
1367 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1368 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1369 now contains all the Debug related code.
1370 * minor clean-up of includes in src/*.cxx
1371 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1372 CreateCleanString) removed.
1373 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1374 * Doc/DoxyMainPageUser.txt added.
1375 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1376 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1377 src/gdcmDirList.cxx)
1379 2004-03-24 Jean-Pierre Roux
1380 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1382 2004-03-23 Jean-Pierre Roux
1383 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1384 big endian made volumes
1385 * ENH Now gdcmParser constructor and destructor are protected to forbid
1386 end user to instanciate class gdcmParser
1387 (only gdcmHeader and gdcmDicomDir are meaningfull)
1389 2004-03-22 Benoit Regrain
1390 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1391 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1392 gdcmSerie to gdcmDicomDirSerie
1394 2004-03-19 Jean-Pierre Roux
1395 * ENH Now the tree-like structure describing a DICOMDIR comming from
1396 an already existing DICOMDIR file is consistent with
1397 the home-made tree-like structure build ex-nihilo
1398 or build from the files held (recursively) in a Directory
1399 functions gdcmDicomDir::CheckBoundaries()
1400 gdcmObject::SetBoundaries() added
1402 2004-03-17 Jean-Pierre Roux
1403 * REM (Eric Boix bug) : removal of meaningless
1404 gdcmDicomDirImage::NewImage function.
1405 * FIX now file names and directory name are written properly in the
1407 * FIX now gdcmDicomDir constructor may be call without any trick
1410 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1411 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1412 of gdcmDicomDirImage::NewImage as empty function.
1414 2004-02-28 Jean-Pierre Roux
1415 * ENH add gdcmDicomDir:NewPatient
1416 add gdcmDicomDirPatient:NewStudy
1417 add gdcmDicomDirStudy:NewSerie
1418 add gdcmDicomDirSerie:NewImage
1419 to allow making gdcDicomDir object.
1420 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1421 (as opposite to the gdcmHeader chained list)
1423 2004-02-11 Benoit Regrain
1424 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1425 when using from python
1427 2004-02-10 Benoit Regrain
1428 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1429 * FIX : in gdcmDicomDir when the directory is empty
1430 * ENH : add callback and methods to get the progression of dicomDir
1433 2004-02-06 Jean-Pierre Roux
1434 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1435 - GDCM_META added to gdcmDicomDirType
1436 - class gdcmMeta created
1437 * ENH : - A brief summary is now displayed at the beginning of
1438 'testDicomDir' to help disaster magnitude estimation
1439 * REM : Now useless Test/explDICOMDIR.cxx
1441 2004-02-05 Benoit Regrain
1442 * ENH : add methods in gdcmObject to get the hash table or the list of
1444 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1445 * FIX : wrapping python for TagHeaderEntryHT
1447 2004-02-04 Benoit Regrain
1448 * FIX : even length for some strings when writting the dicom dir
1449 * FIX : sort the images in the dicom dir
1450 * FIX : Bug fix for python use of dicom dir
1451 * ADD : a python demo
1453 2004-02-04 Jean-Pierre Roux
1454 * FIX : Final solution (?) for icone embedded images
1455 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1456 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1457 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1458 gdcmData/gdcm-MR-SIEMENS-16.acr1
1459 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1460 to make full checking easier
1462 2004-02-04 Benoit Regrain
1463 * FIX : WriteEntries : coding style & logic in parameters
1464 * FIX : Set the elements to create the DicomDir in a dictionary file
1466 2004-02-03 Benoit Regrain
1467 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1468 * gdcmDicomDir : add the load of directory
1469 * Bug fix and print add-on
1471 2004-02-03 Jean-Pierre Roux
1472 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1473 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1474 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1475 * FIX gdcmParser.cxx : 'group length' elements are now considered
1476 as integers, even for shadow groups, when file is Implicit VR
1478 2004-02-02 Jean-Pierre Roux
1479 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1481 of the last synonym :-(
1482 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1484 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1485 * FIX taking into account the possible 7fe0,0010 multiplicity
1486 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1487 to allow removal of references to 7fe0,0010, to deal with
1488 ACR-NEMA images, when 0028,0200 is meaningfull
1490 2004-01-31 Jean-Pierre Roux
1491 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1492 no longer writes 'Un' on disk
1493 * FIX SQ elements with actual length are now dealt with corectly
1494 * FIX gdcmFile::WriteBase make the difference, for color images, between
1495 the length (for Palette expanded images)
1496 and Raw Length (non expanded image + Palette)
1497 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1498 (that broke Write). Replaced by UL.
1499 Aware user will reload the field if he
1500 thinks it's necesssary
1502 2004-01-30 Jean-Pierre Roux
1503 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1504 when 'dirty Acr' is found, to be compliant with the new
1505 IsReadable() methods.
1507 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1508 (no DOUBLE images in kosher DICOM,
1509 but so usefull for people that miss them ;-)
1511 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1512 DICOMDIR related utilities (not checked as Windoze compliant)
1514 2004-01-28 Jean-Pierre Roux
1515 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1517 2004-01-27 Jean-Pierre Roux
1518 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1519 to allow skipping the shadow elements, to save memory space.
1520 The TRUE value for this param has to be used
1521 with a FALSE value for the 'enable_sequence' param.
1522 ('public elements' may be embedded in 'shadow Sequences')
1523 * gdcmHeader methods now deal with 'embedded icones images' in the header
1524 (even when an 'icone image sequence' is announced by the
1525 element (0x0088,0x0200), but there is NO icone at all ...
1527 * gdcmHeader sometimes Image Location value doesn't follow
1528 the supposed processor endianity (see gdcmData/cr172241.dcm).
1531 * gdcmHeader add the method
1532 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1533 to get *all* the Header Entries with the same tag.
1534 GetHeaderEntrySameName is probabely *useless*
1535 (no meaning : Name is *not* an identifier within the Dictionnary)
1537 2004-01-26 Benoit Regrain
1538 * Bug fix in the print of hexadecimal representations. Remove long fields
1539 in the print and add a third level of print to print them
1541 2004-01-23 Benoit Regrain
1542 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1543 * Bug fix on test suite after remove the strip made on not string fields
1544 * Split the IsReadable method between gdcmParser which test that the file
1545 is dicom and gdcmHeader which test that it's an image file
1547 2004-01-22 Benoit Regrain
1548 * DicomDir : clean code, add methods, set variables in protected or private
1549 * gdcmUtil : bug fix for the clean string method
1551 2004-01-19 Benoit Regrain
1552 * Add the use of shadow dictionaries
1553 * bug fix and coding style
1555 2004-01-19 Benoit Regrain
1556 * src/gdcmFile.cxx : bug fix concerning the close of file
1557 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1558 * Add the update of header entries using the shadow library
1560 2004-01-19 Benoit Regrain
1561 * removal of file gdcmHeader2.cxx
1562 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1563 inheriting from gdcmParser. This split is to prepare the integration
1564 of dicom dir parsing
1565 * bug fix under python
1567 2004-01-16 Jean-Pierre Roux
1568 * REM removal of class gdcmHeaderEntrySet
1569 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1570 * ADD add file gdcmHeader2.cxx
1571 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1573 2004-01-15 Benoit Regrain
1574 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1575 entries created while parsing the header. Thus, they will be destroyed
1576 when the gdcmDictSet will be destroyed
1577 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1580 2004-01-15 Benoit Regrain
1581 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1582 made a fatal error because of the memory release at the end of program.
1583 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1584 some memory and vtk seems to have some problems with that.
1585 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1587 2004-01-14 Benoit Regrain
1588 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1589 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1590 * src/*.[h|cxx] : make changes due to class name changes
1591 * gdcmPython/demo/*.py : bug fix due to method names
1593 2004-01-13 Benoit Regrain
1594 * src/*.[h|cxx] : coding style
1595 * vtk/*.[h|cxx] : coding style
1597 2004-01-13 Benoit Regrain
1598 * gdcmPython/testSuite.py : test the readable flag of file for tests
1599 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1600 It's lied to the stl compilation by MSVC (windows, always windows...)
1601 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1603 2004-01-12 Benoit Regrain
1604 * src/*.h : add comments
1605 * src/gdcmDictSet.h : set the method BuildDictPath in public
1606 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1607 directly setted in the source code
1608 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1611 2004-01-09 Benoit Regrain
1612 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1613 * setup.py : use a reference to gdcmVERSION
1615 2004-01-07 Benoit Regrain
1616 * Modification to compile with the distutils.
1619 2003-12-10 Benoit Regrain
1620 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1621 can use a gdcmHeaderHelper to load datas
1622 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1623 made in the source code
1625 2003-12-10 Benoit Regrain
1626 * Update Windows projects and .cvsignore files
1628 2003-11-12 Jean-Pierre Roux
1629 * ENH gdcmHeader constructor has one more parameter (default value : false)
1630 that allows the user to 'go inside' the SeQuences only
1632 gdcmElValSet:Print takes it into account
1634 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1635 * ENH: Update gdcmPython/CMakeLists
1636 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1637 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1639 2003-11-10 Jean-Pierre Roux
1640 * FIX : gdcmHeader::LoadElements is now based
1641 on the ListTag listElem member,
1642 not longer on the TagElValueHT tagHt member
1643 * ENH : PrintPubElVal shows (temporarily) both results,
1644 with the tagHt member and the listElem member.
1645 (it's easier to 'see' the problems when using Printheader)
1647 * FIX : old private member LgrElem is now splitted into
1648 ReadLength : Length actually found on disk (updated only
1649 if bug fixing is necessary), for internal
1651 UsableLength : Updated by FixFoundLength, to fix a bug
1652 or to allow Parser going on.
1653 Will allow to re-write a kosher header when a SeQuence
1654 with a length (not 0000) is found
1655 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1656 because gdcmElValSet::Add does not update ListElem
1659 2003-11-07 Jean-Pierre Roux
1660 * FIX misstyping in Transfert Syntax name table
1661 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1662 when they have an actual length (not 0000 nor FFFFF)
1663 (Nobody should care of it, but DICOMDIR explorers)
1665 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1666 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1668 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1669 * ENH: vtkGdcmReader now supports LUT !
1670 (vtkgdcmViewer for now is not able to use them though)
1672 2003-11-05 Jean-Pierre Roux
1673 * in testSuite.py : new files names for checking the package
1674 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1675 that returns the pixel area size to the *aware* (vtk) user
1676 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1678 2003-11-05 Benoit Regrain
1679 * in testSuite.py : Modify the rules for checking the paths
1680 : Explicit error messages
1681 * in __init__.py : Related modif
1683 2003-11-03 Jean-Pierre Roux
1684 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1685 to be used by aware (vtk) users that want to manage
1686 LUT (and no to turn the PALETTE image into an RGB pixels one)
1687 * GetPixelType now returns 8U for 24 Bits images
1688 (vtkGdcmReader compliant)
1690 2003-10-31 Jean-Pierre Roux
1691 * Removal of *all* gdcmData images and add them again
1692 in order to loose the 'history' of un-anonymised images
1694 2003-10-31 Jean-Pierre Roux
1695 * RMV : removal of useless jBitsInJsample.h
1696 for both 8 and 12 Bits JPEG Lossy Libraries
1698 2003-10-31 Jean-Pierre Roux
1699 * ENH : Add the functions gdcmFile::GetImageDataRaw
1700 gdcmFile::GetImageDataIntoVectorRaw
1701 that act as GetImageData and GetImageDataIntoVector
1702 except the making of an RGB Plane from Gray Plane + LUT
1703 Intended to aware (vtk) users who know how to manage
1706 GetLUTRGBA return a R,G,B,A LUT if any
1707 lgrTotaleRaw gives the 'Raw' length
1708 GetImageDataRaw returns the gray Plane
1709 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1710 (They stay Grey, just like with other Dicom viewers :-(
1712 2003-10-30 Jean-Pierre Roux
1713 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1715 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1716 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1717 being coherents dicom files.
1719 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1720 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1722 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1723 * ENH: Two steps is necessary to please VC++ compiler...
1724 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1725 * ENH: Add include dir to medcon lib
1726 * FIX: only one function is being exported for now !
1727 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1729 2003-10-29 Jean-Pierre Roux
1730 * adding gdcmHeader::GetLUTRGBA
1731 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1732 --> Mathieu, the modif u're waiting for is not yet committed
1733 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1735 2003-10-27 Jean-Pierre Roux
1736 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1737 00191113.dcm DermaColorLossLess.dcm
1738 MxTwinLossLess.dcm RadBWLossLess.dcm
1739 * ENH: For version prior to vtkImageViewer2 -r 1.19
1740 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1742 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1743 * Removal of ido stuff in CMakeLists.txt
1745 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1746 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1747 * FIX: remove a call to ->Modified ... see comments
1748 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1750 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1751 * FIX: Problem with path for libvtkgdcmPython
1752 * ENH: Try adding a search script for python site-package
1753 * RMV: Remove some file from medcon lib that are not necessary
1754 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1755 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1756 * FIX: More pragma disable fro VC++,
1757 I don't think I break something as it is also disable in VTK/ITK.
1758 But it fasten debug compilation time.
1760 2003-10-23 Jean-Pierre Roux
1761 * gdcm now deals with 16 Bits Run Length Encoded images
1762 (they are compressed as 2 planes images,
1763 one for the high Bytes, the other for low Bytes)
1765 2003-10-22 Jean-Pierre Roux
1766 * Now CheckRead takes into account :
1767 - the bugged 'Leonardo' Siemens images
1768 - the XA images, sent thru the burning VPRO station
1769 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1772 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1773 * FIX: When copying a Makefile.am to CMakeLists.txt
1774 one should remove the '\'
1776 2003-10-22 Jean-Pierre Roux
1777 * in gdcmData adding a bugged 'Leonardo' Siemens image
1778 (wrong lengths in header)
1779 OK with gdcm, KO with the other viewers :-)
1780 * add a GE dlx XA image, thru the VEPRO burning station
1783 2003-10-21 Jean-Pierre Roux
1784 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1785 for a brutal checking of vtkgdcmViewer compliance
1787 2003-10-21 Jean-Pierre Roux
1788 * add the files for 'xmedcon' Jpeg Lossless library
1789 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1791 2003-10-21 Jean-Pierre Roux
1792 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1794 2003-10-21 Jean-Pierre Roux
1795 * garbage Siemens 'Leonardo' images dealt with
1796 (the patch is easy to remove)
1797 * cosmetic changes to avoid warnings
1799 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1801 no need to press 'r' now.
1803 2003-10-20 Jean-Pierre Roux
1804 * upgrade of checkRead.sh checkWrite.sh according
1805 to new Jpeg Lossless decompressor
1806 * add US.3405.1.dcm, a genuine RGB medical file ...
1807 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1808 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1810 2003-10-15 Jean-Pierre Roux
1811 * general anonymisation in gdcmData
1812 * adding the 'color files' from
1813 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1814 * adding some well knowed bugged-header images
1815 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1816 waiting for their inclusion in Python testsuite
1818 2003-10-15 Jean-Pierre Roux
1819 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1820 no longer seg faults when file is not found
1822 2003-10-14 Jean-Pierre Roux
1823 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1826 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1827 * TODO: *.in file to genereate a UseGDCM later
1829 2003-10-14 Jean-Pierre Roux
1830 * Some supposed-to-be Dicom Images have no preamble.
1831 OpenFile takes it into account
1832 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1833 * Missing elements added in dicomV3.dic
1834 (just to be affraid : have a look at
1835 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1836 and do it again next year ;->
1838 2003-10-13 Jean-Pierre Roux
1839 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1840 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1841 But there are NOT. It's fixed !
1843 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1844 * FIX: "jpeglib.h" was not found on VC++
1845 * FIX: vtkgdcm was not being installed
1847 2003-10-10 Jean-Pierre Roux
1848 * ENH : OpenFile closes the file if it *really* doesn't look like
1849 an ACR-NEMA / DICOM one.
1850 * FIX : testWrite no longer writes an empty file if the source file
1851 is not gdcm Readable
1852 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1855 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1856 * FIX: CMake generate now documentation
1857 * ENH: out of source doc build !
1858 * ENH: Generate both user and dev documentation
1859 * ENH: Should work on windows too
1860 * ENH: Only one doxygen config.in file is needed
1861 * FIX: make install should be ok now on ùnix plateform
1862 * FIX: PATH to dictionary was wrong (missing /)
1863 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1865 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1866 * vtkGdcmReader is now able to read rgb dicom file.
1867 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1868 * added a gdcmViewer to vtk test, use mouse to control
1869 window level & window width
1871 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1872 * CMake-ification of gdcm, we have now two build system
1873 * FIX: on cygwin Wsock32 doesn't exist
1874 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1876 2003-10-06 Emanuel Ollart
1877 * FIX : compilation process wad broken.
1878 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1880 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1881 * change gdcmViewer -> vtkgdcmViewer
1882 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1884 2003-10-06 Jean-Pierre Roux
1885 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1886 ( e.g : well known GE images with a wrong elem length,
1887 : Philips MRI Images with a wrong Huffman table)
1888 * still to be done : allow the reading of bugged LEONARDO Siemens images
1890 2003-10-03 Jean-Pierre Roux
1891 * Odd length strings are padded with '\0' (not with spaces,
1892 to remain compliant with already defined strings,
1893 like Transfert Syntax UID and others)
1895 2003-10-03 Jean-Pierre Roux
1896 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1897 to allow displaying RGB images (not only by affim ;-)
1899 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1900 * vtkGdcmReader is now able to read rgb dicom file.
1901 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1903 2003-10-03 Jean-Pierre Roux
1904 * A few nasty patches to allow the reading of a lot of nasty images
1905 ( e.g : well known GE images with a wrong elem length,
1906 : Philips MRI Images with a wrong Huffman table)
1907 * still to be done : allow the reading of bugged LEONARDO Siemens images
1909 2003-10-03 Jean-Pierre Roux
1910 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1912 2003-10-03 Jean-Pierre Roux
1913 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1914 to allow displaying RGB images (not only by affim ;-)
1916 2003-10-03 Jean-Pierre Roux
1917 * gdcmFile::GetImageDataIntoVector now
1918 - deals with MultiFrames MultiFragments Run Length Encoded files
1919 - deals with YcBcR (YBR_FULL) files
1920 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1921 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1923 (no sample found :-(
1925 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1927 Two reasons: - clear things
1928 - third parties acces gdcm through header files, so won't
1929 suffer anymore VC++ complains
1931 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1932 * add argv[1] in testvtkGdcmReader.cxx
1935 2003-09-24 Jean-Pierre Roux
1936 * The lines are now eigthy characters long.for
1937 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1939 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1940 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1941 char* to std::string. Thus, the use of strdup becomes useless. (see
1942 previous commis of Malaterre)
1943 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1944 before the last Malaterre's commit.
1946 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * This commit should fix the Debug building under VC++, the problem
1948 was mainly a mixture of debug and release lib being loaded at startup.
1949 * I also remove a depency to a specific C function: strdup. Because I had
1950 to force the link to msvcrtd (whereas strdup is in libc).
1952 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1953 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1954 located in the gdcmCommon.h file. All use of reference of tha has been
1955 changed to now use the variable GDCM_UNFOUND.
1957 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1959 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1960 Dicom dictionary. The test suite can now be run again. Note:
1961 I'm note very happy with the " (RET)" changes. I believe this
1962 RETAINED comment should be dropped when parsing the dictionary.
1963 - PACKAGER corrected
1965 - AUTHORS updated and now in alphabetical order
1966 * Makefile.am now exports gdcm.dsw for Windoze users.
1968 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * cygwin complains about missing std:: in subdir Test/
1971 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1972 * remove some methods that are now in gdcmHeaderHelper
1974 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1975 * vtkGdcmReader set spacing and origin correctly
1977 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1978 * Fix a few delete/delete[] mismatch
1980 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1981 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1982 interpretation to data given by gdcmHeader. For instance there are
1983 heuristics to get informations (look at different places).
1984 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1985 sorting DICOM images based on different strategies.
1986 * modified Makefiles accordingly.
1988 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1989 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1990 when building in debug mode
1991 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1992 src/win32/gdcmdll.dsp
1993 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1995 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1996 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1999 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2000 * src/win32/libgdcmjpeg12.dsp was not dos format
2001 * src/win32/libgdcmjpeg12.dsp :
2002 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2003 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2005 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2006 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2008 * src/gdcmFile.cxx : bug fix in affectation type
2009 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2010 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2011 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2012 symbols... future problem ?
2014 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * src/win32/libgdcmijpeg12.dsp was missing
2016 * modified gdcm.dsw accordingly
2018 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2019 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2021 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2022 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2023 commit of JPR (before his hollidays to facilitate our work).
2024 * setup.py : bug fix in code. Modifications made while the last commit
2025 of JPR. The code hasn't been tested before the commit... it's so
2026 useless to make that (for best programmer that is JPR) !!!
2028 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2029 * tagged the current version as Version0_3 (i.e. version 0.3)
2031 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2032 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2033 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2034 * *.dsp : modifications to use new libgdcmijpeg8 library
2035 * setup.py : bug fix on VTKPATH variable
2036 * PACKAGER : adding all concerning windows
2038 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2039 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2041 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2042 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2043 test suite reported error.
2044 * PACKAGER file added (describes what a packager must do when
2045 packaging a new release).
2046 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2047 * configure.in: upgraded version number to 0.3.0
2048 * fixing build of rpm (through rpm -ta):
2049 - Doc/Makefile.am exports proper doxygen files
2050 - src/jpeg/libijg8/Makefile.am exports the include files.
2052 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2053 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2054 * src/gdcmHeader.h : formatting code
2056 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2057 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2058 We were obtaining error message from vtk. Now, creation of file list
2059 is made in an internal list to prevent this problem.
2060 Bug fix when output is empty.
2061 Bug fix in update of progress value. Previous commit for this was a bad
2063 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2065 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2066 * src/gdcmHeader.h : added method to get the file name
2067 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2068 files. Added method to remove all files on the input
2069 Added FIXME comment concerning the bad parsing of header made by
2070 ExecuteInformation method (in ExecuteData method)
2072 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2073 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2074 when using make instal.
2075 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2076 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2078 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2079 * setup.py : adding include dir of jpeg lib to compile all sources
2080 * */Win32/*.dsp : JPR fix for windows compilation
2082 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2083 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2085 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2086 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2088 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2089 * setup.py is again effective on un*x (takes into account the
2090 addon of the jpeg library)
2091 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2092 * Doc/Doxy* updated (includes above enhancements)
2093 * INSTALL now points to web documentation
2095 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2096 * src/gdcmHeader.h doesn't make unnecessary reference to
2098 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2100 * src/gdcm*.[cxx|h] :
2101 - to allow compilation with gcc 3.x
2102 -- clean up of STL usage (added explicit usage of std::)
2103 -- small fixes on exceptions.
2104 Note: linking not tested !
2105 - clean of doxygen comments to avoid warnings at documentation
2107 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2108 dependent convertion).
2110 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * Clean up of previous JPR garbage commit (not even commented in the
2113 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2114 - moved all jpeg related files from src to src/jpeg/libijg8, with
2115 addition/modification of Makefile.am and configure.in.
2116 - the testSuite is still brain damage (not guilty).
2118 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2119 * WrapVTK.py : modifications to get correctly vtk source files to
2121 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2122 (FileName -> Filename)
2124 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2125 * vtk/vtkGdcmReader.[cxx/h]:
2126 - UpdateProgress method should now be effective
2127 - removed the limitation on having only images loaded (as opposed
2129 - when building a stack of images/volume, a lesser number of
2130 gdcmHeader and gdcmFile instances should be used (hopefully
2131 accelerating things).
2132 - when building a stack of images/volumes, files which are not
2133 loadable (wrong path-filename, wrong permissions on existing file,
2134 or file not parsable by gdcm) are replaced with a black image
2135 in the stack (for the caller to notice the problem).
2137 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2140 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2141 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2142 between standard library (std) and vtk library (problems are found
2143 under Windows... thanks Windows !)
2145 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2148 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2150 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2151 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2153 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * When compiling with distutils (see setup.py) the C++ compiler is
2155 called with different flags than the default ones (with automake).
2156 In order to fix all those warning, I compiled gdcm with the command
2157 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2158 and went for warning fixes:
2159 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2160 up from unused variables.
2161 - vtk/vtkGdcmReader.cxx: potential bug fix.
2162 * src/gdcmHeader.h: Doxygen warning cleanup
2164 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2165 * gdcmPython/gdcm.i:
2166 - typemaps correction to take into account the systematic replacement
2167 of "using namespace std" with std:: prefix e.g. std::list,
2168 std::string... (cf changes of 2003-05-21).
2169 - gdcmGlob global variable of type gdcmGlobal (defined in
2170 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2171 exported to Python a as cvar.
2172 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2173 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2174 gdcmDictSet.GetPubDictTagNames() and
2175 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2176 C++ static methods).
2177 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2178 with the above changes.
2180 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2181 * setup.py, manifest.in : bug fix under linux
2183 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2184 * Modification of setup.py to compile vtk part too. Then, we have 2
2185 wrappers which must work with same distutils. For that, we have a
2186 generic distutils in distusiltsWrapping.py ; with :
2187 - build_extWrap class to wrap generically all extensions,
2188 - ExtensionWrap base class for all wrapping extension that contains
2190 - Wrapper interface which wrap sources
2191 + In WrapSwig.py we have extension and wrapper for Swig
2192 + In WrapVTK.py we have extension and wrapper for VTK
2193 * MANIFEST.in : modifications to consider vtk directory and new python
2194 files for compilation
2196 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2197 * Added python wrappers of vtkGdcmReader vtk class (see the
2198 source in vtk/vtkGdcmReader.cxx) :
2199 - vtk/Makefile.am now builds a library
2200 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2201 python library (as opposed to _gdcm.so wich are the python
2202 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2203 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2205 - configure.in has an additional flag --enable-vtk that needs
2206 to be set to enable compilation of vtk related code, that is:
2207 + vtk/vtkGdcmReader.so and
2208 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2209 + gdcmPython/vtkgdcmPython.so (see above)
2210 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2211 be read when compressed or when HighBit + 1 != BitsStored),
2212 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2213 the usage of the python wrapper of vtkGdcmReader vtk class.
2214 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2215 * src/*.[h] all occurences of stl classes are now prefixed with
2216 std::, and all occurences of "using namespace std;" where removed.
2217 This is to avoid pollution of global namespace in included files.
2218 Apparently vtk does not avoid this pitfall: when using both
2219 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2220 collision of various stl members (principally cout...).
2221 * gdcmPython/testSuite.py now cleanly removes temprory generated
2223 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2224 comply with above changes)
2226 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2227 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2228 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2229 vtk data structure (an image Flip was required).
2230 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2231 * cosmetic changes in documentation.
2233 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2234 * src/gdcmHeader.cxx: the constructor no longer exits when an
2235 unexisting file is given as argument.
2236 * The subdirectory Data (containing all the images used for the
2237 test suite) is not part of this repository anymore. A new module
2238 containing those images is now available at
2239 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2240 with the name gdcmData.
2241 All the python scripts (including the package initialisation file
2242 gdcmPython/__init__.py) were adapated to take this change into
2243 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2245 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2246 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2247 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2248 demo of the usage of this class.
2249 Compilation of this vtk part is only done when using the --enable-vtk
2250 at configure (or autogen.sh) stage.
2252 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2253 * More memory link related corrections and documentation fixes.
2255 - maximum info is obtained with a command of the form:
2256 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2257 --show-reachable=yes PrintHeader
2258 - the remaining reachable blocks seem to come from the STL
2259 allocation scheme through the usage of map and list. It looks
2260 like this memory cannot be freed but it is not a memory leak
2261 (in fact further invocation to the STL would recollect the
2262 unused memory allthough it cannot explicitely be freed).
2263 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2264 of displaying an image parsed with gdcm and displayed with VTK.
2265 Note: some images don't seem to work e.g.
2266 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2267 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2268 Allthough this weakens the semantics, it is a ditch attempt to
2269 make gdcm more thread friendly.
2271 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2272 * Memory link hunt (by using valgrind through the command
2273 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2274 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2275 gdcmHeader::_dicom_vr.
2276 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2277 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2279 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2281 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2282 * src/Makefile.am now exports all the necessary include files at
2286 * UpdateGroupLength replaced by new one
2289 * UpdateGroupLength re-written using H-Table
2290 (named UpdateGroupLengthNew untill checks are over)
2292 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2293 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2294 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2296 - gdcmHeader::GetPubElValSet removed.
2297 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2298 UpdateGroupLength, WriteElements, Write.
2299 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2300 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2301 carried the same semantics.
2302 - src/gdcmHeaderIdo.cxx changed accordingly.
2303 - gdcmFile::WriteBase now regroups all the codes from previous
2304 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2305 - enum FileType moved to gdcmCommon.h
2306 * src/gdcmHeader.cxx AddDefault trashed
2307 * gdcmGetXSize added
2308 * getimageDataSize now calls gdcmGetXSize
2309 * Test/*.cxx changed to agree with above changes
2311 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2312 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2313 (to avoid double call by end user).
2314 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2315 by end user, since gdcmHeader::gdcmHeader now handles it.
2317 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2318 * gdcm/Doc many doxygen changes:
2319 - Doxyfile now has two different versions, DoxyfileUsers that generates
2320 the html.users end users oriented documentation and
2321 DoxyfileDeveloppers that generates the html.developper developper
2322 oriented documentation.
2323 - README changed accordingly
2324 - requirement.txt removed (old design info moved to TODO).
2325 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2326 DoxyMainPage.txt, DoxyPython.txt provide more information.
2327 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2328 be updated by simply regenerating the docs with doxygen and copying
2329 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2330 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2331 all the tests in the form "if (<map>.count() >1)" were removed.
2332 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2333 ill-formed documentation sections.
2334 * src/gdcmHeader.cxx: ditto
2336 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * setup.py fixed for un*x (needed macro for stdint.h)
2338 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2339 un*ces with sh-utils test utility.
2340 * gdcmPython/demo/test.py renamed to PrintHeader.py
2341 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2342 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2343 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2344 * src/gdcm*.cxx JPR's bad inclusion fixed.
2346 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2348 * gdcmPython/demo/test.py changed accordingly.
2350 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2351 * gdcmPython/Makefile.am fixed linking against libstdc++
2352 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2353 * Swig subdir (historical tests of swig version 1.3.17++) removed
2354 * Test/testChangeEntete.cxx some lines commented out in order to make
2356 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2357 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2359 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2360 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2361 hence the user doesn't need this explicit call.
2362 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2363 i.e. LoadElements() call removed.
2364 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2365 - src/Makefile.am declares the proper flag for g++.
2366 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2367 for adding user defined new tags.
2368 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2369 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2370 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2372 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2373 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2374 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2375 src/Makefile.am : the project should properly compile and install
2376 with the autotools, included the python wrappers part.
2377 * gdcm.spec.in : added a spec file for RPM packaging.
2379 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2380 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2382 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2384 to exported to the environement (see gdcmPython/testSuite.py
2386 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2387 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2388 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2389 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2390 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2392 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2393 * gdcmPython/__init__.py doesn't crash anymore when running in
2394 in InstallMode or PreInstallMode but with an environement given
2395 value of GDCM_DICT_PATH.
2396 * src/gdcmDictSet.[cxx/h] coding style.
2398 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2399 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2400 * src/gdcm.h general comments moved to TODO, and README
2401 * src/gdcm.h should now be seen as a user commodity (including it
2402 should suffice to fully use gdcm). It is nowhere including within
2403 any of the kernel files src/*.cxx and src/*.h.
2405 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2406 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2407 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2409 * src/gdcm*.cxx only include their corresponding include file
2410 (as opposed to gdcm.h)
2411 * gdcmPython/gdcm.i changed accordingly
2412 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2413 the autogen.sh generated "make snapshot" command to work.
2414 * autogen.sh removed history related references to crea package.
2416 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2417 * distutilsSwigCPlusPlus.py work around some swig portability
2420 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2421 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2422 was done in a last ditch attempt to get setup.py _really_
2423 operationnal. The python/gdcmPython layaout add the advantage
2424 of hidding away the python related distutils specific files
2425 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2426 Alas, the src directory was out of scope (i.e. it's relative
2427 position to setup.py was ../src) which made things impossible to
2428 handle (see previous version of python/setup.py). Crossing fingers...
2430 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * python/setup.py now works on Un*x. (harder than I thougth)
2432 * python/distutilsSwigCPlusPlus.py can now have include files
2433 among the list of sources.
2435 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2436 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2437 * modifications in MSVC projects
2439 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2440 * As stated by the first lines of Test/ExceptionAndPython/README, it
2441 looks like we can move back to original usage of exception within
2442 src/gdcm* and hence remove the errno stuff that was introduced
2443 as a quick and dirty fixture of this problem (added to the TODO).
2444 * Doc/Doxyfile configuration file for Doxygen and corresponding
2445 README file for usage added.
2446 * Test/testWrite.cxx added. This new test comes from a split of
2447 test.cxx that is now reverted to its original purpous i.e.
2448 testing the proper parsing of a Dicom related file.
2449 testWrite.cxx concentrates on testing the IO part of gdcm.
2450 * Test/bug1.cxx (containing a bug on WIn32) added.
2451 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2452 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2453 whose purpose is to publish the content of the TagNames of the
2454 Dicom public dictionnary were not accessible without an
2455 instance of class gdcmHeader.
2456 - those methods are now static methods of gdcmDictSet and hence
2457 require no instances at all to be invocated.
2458 - within gdcmDictSet this change required to change some method
2459 to class methods (i.e. are now static) among which SetDictPath
2460 (renamed to BuildDictPath) and LoadDefaultPubDict.
2461 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2462 the above changes by calling the new method classes of gdcmDictSet.
2463 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2464 the above to be effective.
2465 * python/gdcmPython: in order to wrap properly the above changes
2466 for Python, swig version now needs to be > 1.3.17.
2467 * python/gdcmPython/Makefile fixed to adapt itself to new
2468 configure/make shema introduced by Johan Montagnat (thanks for the
2469 contribution). Alas this Makefile cannot be turned into a proper
2470 Makefile.am without some heavy changes in the configure.in
2471 (for python dectection).
2472 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2473 now avoids publishing the empty entries.
2475 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2476 * python/setup.py : bug fix concerning install under windows
2477 ExtraPath reused :-P
2478 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2480 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2481 * Dicts/dicomV3.dic : remove double spaces !!!
2482 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2483 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2486 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2487 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2488 method. Doxygenation.
2489 * src/gdcm.h clean up of JPR spurious comments.
2491 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2492 * python/distutilsSwigCPlusPlus.py now properly collects the
2493 shadow classes generated by "swig -c++" (gdcm.py in our case)
2494 when using "python setup.py install".
2495 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2496 reexports the working classes.
2497 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2498 by the classical C errno scheme. This is to prevent an obscure
2499 behavior of the python wrappers when importing wxPython.wx prior
2500 to gdcmPython (which ended up in an abort call). An illustration
2501 of this oddity can be found in the Test/ExceptionAndPython
2502 subdir (see the README file). This problem probably due to
2503 an combination of g++ and dynamic loading.
2504 * added Test/ExceptionAndPython (see above)
2506 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * Changed the layout of the python part to avoid bloating main
2508 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2509 i.e. the distutils arsenal. All the python related stuff is
2510 again in a python subdir, but the package itself is now in
2512 * setup.py was cleaned up:
2513 - pythonIncludePath removed
2514 - python setup.py bdist target is now functional.
2515 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2516 collision with other packages). gdcmPython/demo/*.py changed
2519 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * python subdir moved to gdcmPython (preparation of distutils packaging).
2521 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2522 distutils installer is operational.
2523 * - gdcmPython/__init__.py now properly loads the swig generated
2524 shadow classes (from gdcm.py).
2525 - gdcmPython/demo/*.py changed to import the package gdcmPython
2526 instead of gdcmPython/demo/load.py.
2527 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2529 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2531 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2532 entries within the associated public Dicom dictionary resp. the same
2533 information but sorted by the fourth field (PAT, IMG, DIR) of the
2535 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2536 are now in the "???" group.
2537 - python/gdcm.i changed accordingly,
2538 - python/demo/printGroupedPublicDict.py added, that gives an example
2539 of the above new functionalities in Python.
2541 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2542 * src/gdcm.h, gdcmHeader.cxx:
2543 - historic references to glib's g_malloc and g_free (#defined)
2544 were definitively removed.
2545 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2546 * src/gdcmElValSet.cxx:
2547 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2548 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2549 - GetElValue(string) renamed to GetElValueByName.
2550 - Added GetElementByName(string).
2551 * src/gdcmHeader.cxx: added
2552 - GetPubElValRepByNumber(guint16, guint16)
2553 - GetPubElValRepByName(string)
2554 - GetShaElValRepByNumber(guint16, guint16)
2555 - GetShaElValRepByName(string)
2556 - GetShaElValByNumber(guint16, guint16)
2557 - GetShaElValRepByName(string)
2558 - GetElValRepByNumber(guint16, guint16)
2559 - GetElValRepByName(string)
2560 - GetElValByNumber(guint16, guint16)
2561 - GetElValRepByName(string)
2562 * Doc/requirements.txt added.
2564 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * Test/Makefile building now depends on the one of libgdcm.so
2566 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2567 pixel data) aware which enables finding the address (offset) of
2568 the pixel data of JPEG encoded DICOM files. This leaves only a single
2569 file in the testSuite whose pixel data address (offset) is unknown.
2570 * python/testSuite.py changed accordingly.
2572 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2573 * VC++ has some strong limitations when working with the STL, as stated
2574 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2575 "Also note that some STL containers (map, set, queue, list, deque)
2576 cannot be exported. [...]
2577 Some STL classes contain nested classes. These classes can not
2579 This is caused by a designed limitation that once a template
2580 class is instantiated, it can not be re-instantiated and
2582 Since our usage of map<> is ubiquitous in gdcm, this "designed
2583 limitation" of VC++ is a pitfall.
2584 Hence the Python wrappers of gdcm cannot be incrementally linked
2585 against the c++ dynamic library. The dirty but only workaround is
2586 to forget about incremental link of dynamic libraries and to generate
2587 the Python wrappers library with the inclusions of the underlying C++
2589 The following modifications concern this matter on Win32/VC++:
2590 - wrapping python correct with standalone wrapped dll (don't use separate
2591 dll under windows !!!!)
2592 - python21_d debug mode enabled (ask Frog how to use it :-)
2593 - NO problem with having an STL member of class for example string in C++
2594 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2595 - Python test of dcmlib in Python is ok under windows on a large set
2597 * removed glib references
2598 * typedef's inserted in gdcm.i for correct swig type management
2600 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2601 * python/demo/*.py load.py extracted from test.py. Added explore.py
2602 that only displays required tags and testAll.py that parses all
2603 the files of the testsuite without using unittest.
2604 * python/testSuite.py other additional test on new files added.
2605 * Data/* new test files added accordingly to the testSuite.
2606 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2607 the vr in the file differs from the one of the dictionary.
2609 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2611 values, but limits itself to values which are below a user specified
2612 size (by default 1024 bytes).
2613 * python/gdcm.i : elements not loaded (because their size is above the
2614 user specified treshold) are exported with their TagKey as key of the
2615 python dictionary. This enables the testsuite to make some checks
2616 on the unloaded elements (since we have their offset and size).
2617 * python/testSuite.py
2618 - now tests for the existence and proper value of the pixel data
2619 - two new examples added.
2620 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2622 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2624 aware. See the strategy comments in gdcmHeader::FindeLength().
2625 * Test/test.cxx now accepts a filename as first argument.
2626 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2627 * python/testSuite.py changed to integrate test on above files.
2629 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2631 the vr was also RET.
2632 * python/testSuite.py more tests added.
2634 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * python/testSuite.py unittest test suite added (uses Data)
2636 * Data/* dcm and acr files for the test suite.
2637 * glib dependance removed from un*x version. We now use ISO C99
2638 7.18 Integer types (see stdint.h)
2639 - python/Makefile, src/Makefile src/gdcm.h
2640 * src/ when an explicit vr (like dicom files) suddenly poped an
2641 implicit element we use to mark the underlying DictEntry of the
2642 concerned ElValue with "Implicit". This strategy was damageable
2643 too the public or provite dictionaries, since some of their vr
2644 would be changed. Since Header::FindLength heavily relies on the
2645 detection by Header::FindVR of falsely explicit elements, I
2646 added an extra ImplicitVr member to ElValue (boolean).
2647 The rest of the changes we the necessary adaptations.
2649 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2650 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2652 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2654 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * Adaptation for porting to VC++:
2657 o forced to use std namespace (for string to be known)
2658 o all class use __declspec export style on WIN32
2659 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2660 (in stdlib.h on Win32 but in std:: for gcc)
2661 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2662 variable GDCM_DICT_PATH.
2663 * src/gdcmHeader.cxx verbose comments made discrete.
2665 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * python/gdcm.i: added a typemap that converts a C++ hashing table
2667 to native Python dictionary.
2668 * python/demo/test.py:
2669 - now uses the native dictionary for exploration of gdcmHeader.
2670 - takes an optional filename argument (the file to parse).
2671 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2672 PubElVals hashing table.
2673 * Dicts/dicomV3.dic removed error prone trailing spaces.
2675 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2676 * Python wrapping process moved away from src/Makefile to
2677 newly created python/Makefile (as well as gdcm.i)
2678 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2679 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2680 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2681 from the environement variable GDCM_DICT_PATH (when existing).
2682 * src/gdcmDict::GetTag bug fix.
2684 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2685 * Straightforward temporary fixes for swig to build the python wrappers.
2686 src/Makefile now has a python working entry [by working we mean
2687 that we can import de shadow classes without errors].
2689 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * hashtest.cxx removed (since allready in Test)
2691 * src/gdcmlib.h renamed to src/gdcm.h
2692 * src/dcm.i renamed to src/gdcm.i
2693 * src/Makefile prepared for python wrapping
2695 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * src/gdcmHeader.cxx :
2697 - Parsing of header is now separated from loading of element values
2698 (see gdcmHeader::LoadElements).
2699 - general clean up of hopefully all file access (creation of
2700 ReadInt16 and ReadInt32)
2702 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * src/gdcmHeader.cxx :
2704 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2706 - SetLgrElem renamed to SetLength
2707 - GetLgrElem renamed to GetLength
2708 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2709 * src/gdcmElValSet.cxx fixed both GetElValue methods
2710 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2711 due to IdoDude was cleaned out.
2713 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2714 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2715 concentrates on finding the value representation (when it exists).
2716 RecupLgr now only finds the element value length, and it avoids
2717 returning the unecessary skL (skipped length).
2718 Also, offsetCourant was simply removed (with taille_fich) since
2719 it was redundant with the File position internals (by using
2720 ftell and fseek). This also made skL (see above in RecupLgr) usage
2722 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2723 on the libido specificities which are handled through class
2725 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2728 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2729 * Truckload of changes. Parsing of header is barely functional
2730 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2732 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2733 * src/gdcmHeader.cxx many addons of low level methods
2735 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2737 and _IdDcmSWAP_LONG.
2739 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * This corresponds to all the changes decided at the meeting of
2741 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob