1 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
3 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
5 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
6 * Add vtkGdcmWriter example and test
8 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * Test/TestUtil.cxx : reformat the source code
10 * vtk/vtkGdcmReader.cxx : remove and change prints
11 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
13 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
14 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
16 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
18 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
20 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
22 by an eof to prevent all bad read of the file... and in this case, the
25 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
26 * Example/Volume2Dicom.cxx : comment unused variables
27 * Test/PrintDicomDir.cxx : comment unused variables
28 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
29 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
30 method that is redondant with AddEntry.
31 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
34 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
35 * Bug fix due my last commit (compilation under Windows).
36 * Example/Volume2Dicom : bug fix in the file and reformatting source code
37 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
39 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
41 - Remove printf / sprintf
42 - include iostream AFTER gdcm so we don't get warnings
43 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
45 - Also remove tons of include from header files, hopefully this should
46 speeup the compilation time, since it was becoming a dog slow.
47 - Remove gdcm.h as it include way too many files and slow down compilation
48 (plus it is not up to date)
49 - remove 'using namespace std' this is BAD !
51 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
52 * Remove memory leaks on the DicomDir
53 * Remove some useless datas in DicomDirObject
54 * Add usefull methods in SQItem, to be complient withe the ElementSet
56 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
57 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
59 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
61 future, with convertion)
62 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
63 and ImageDataSize values. Remove the method to get the PixelReadConverter
64 from the output of the class
66 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
67 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
69 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
71 and vtkErrorMacro use.
72 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
74 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
77 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
78 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
79 The string leaves only in the fonction. So when we make a .c_str(), we
80 get the pointeur on the first element, element that will be destroyed
81 immediately after thee instruction.
82 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
83 file has been opened : the test must be made on the content of the
84 pointer and not directly on the pointer !
87 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
89 the python part recompiles
91 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
93 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
94 X session is killed (for my computer... it seems to not be identic on
97 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
99 avoid problems (otherwise, the difference test between the visible image
100 and the reference is incorrect. If the reference is greater than the
101 screen resolution, it's produce errors).
102 Can be used for only one image. Can be used with a visible flag.
103 * vtk/vtkGdcmReader.cxx : remove commented codes.
104 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
105 under windows at compilation
106 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
108 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
110 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
111 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
112 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
113 tests on the image size X, Y, Z
115 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
116 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
117 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
118 between the class name and the file name
120 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
121 * src/ : fix compilation warnings for the Write method (2 different
122 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
123 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
124 variable... create a static method in gdcm::Document to access to
125 this variable content.
127 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
129 file, to be accessed by other files (like gdcmFile). Remove commented
130 code. Move the change of the header to the gdcmFile, using the
132 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
133 To be sure of that (and simplify calls), the Write of the header now
134 gets a file name and not a file pointer (std::ifstream).
135 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
136 DocEntryArchive. Remove all open of the written file
138 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
141 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
142 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
143 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
145 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
146 some corresponding methods. Write correctly the file and check before
148 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
149 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
150 is now on RGB datas (as before my last commit
151 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
153 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
154 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
155 Add a print information of the type of the entry
156 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
157 It was in the gdcmFile, and all write have been regrouped
158 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
159 Write correctly all dicom files (in decompressed mode only at this time)
160 * Test/ : test on files are now made using Raw datas and not color datas if
162 * Example/PrintFile.cxx : add more printings
164 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
165 * Amelioration of code, remove some code copy. For the loading of
166 BinEntry (in gdcmDocument), add the test to verify if the file is already
169 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
171 remove a DocEntry in the header (push an empty DocEntry)
172 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
173 lines. Bug fix in the initialization of the PixelConvert and the
175 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
176 use in TestCopyDicom (now this test can run under windows... but fails)
177 * Test/TestCopyDicom.cxx : amelioration of the test :
178 - test the pixels written
179 - add test points to quickly find where is the error
180 - can set a file name input and output in arguments
181 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
182 amelioration of the test output
184 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
186 all replaced DocEntry's
187 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
188 Now, each needed DocEntry to modify is duplicated, modified and inserted
189 to the header using DocEntryArchive. Thus, after save, we can restore the
190 header initial state.
192 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
195 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
196 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
197 correct to copy it. The DictEntry is specified at the DocEntry creation,
198 then, it musn't change in the time.
199 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
200 header correctly. At this time, the change is only made for the first
201 level of the Document. In the future, it might consider sequences.
202 The change is made by replacing a DocEntry by an other that is created
203 outside the class. The old value is kept. When we restore the header
204 status, the added DocEntry is deleted and replaced by the old value.
205 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
206 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
207 set the write type to explicit VR, implicit VR or ACR. Add methods to set
208 the write mode to native, decompressed or RGB (but not used at this time)
210 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
211 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
212 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
214 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
216 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
218 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
219 set because already copied when copying the BinEntry's of the header
220 * Test/TestAllReadCompareDicom.cxx : remove warnings
222 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
224 Two problems appear when doing it :
225 - with the gdcmFile : when the GetImageData method is called, the pixels
226 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
227 datas (pixels). And each structure destruct the datas when it's
228 destructed. So we have two destructions for the same datas. To solve it,
229 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
230 datas or not. If it doesn't own datas, then they will not destroyed by
232 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
233 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
234 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
235 create a double destruction of the same DocEntry's. So, to solve it,
236 the TagHT is simply cleared and the DicomDir* elements are destroyed.
237 * TODO : add an entry concerning memory leaks in the DicomDir
239 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
241 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
244 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
246 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
247 after it have been deleted
249 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
250 * FIX: src/* fix the doxygen warnings.
251 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
252 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
253 was erroneously defined with a size of 15 instead of 16. [many thanks
254 to Jean Michel Rouet for pointing out this bug].
256 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
257 1. Finish merging JMR patch for writting DICOM from scratch
258 2. Fix -hopefully- bug with MONOCHROME and space vs null character
259 3. Use const ref when possible
260 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
261 5. A few more comments
262 6. CreateUniqueUID can now be called without parameter"
264 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 * ENH: Slightly bigger patch:
266 1. Getting toward full integration of JMR patch for writting dicom from scratch
267 2. Update Test to test part of this patch: CreateUniqueUID
268 3. File was not close properly in gdcmDict
269 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
270 5. Use of const ref instead of copy (speed issue)
271 6. Remove temporary (duplicate) string in TranslateToKey
272 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
273 8. Do not repeat virtual in subclasses
274 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
276 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
277 * Apply first patch toward better string comparison when dealing with broken
278 DICOM files. Essentially the string could be padded with a space instead
279 of a null character as defined by standard
281 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
282 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
283 because never used... and in the same time, that's remove some memory leaks
285 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
286 * src/gdcmFile.cxx : now delete the PixelConvert instance.
287 * In examples and tests : change the type of image data variables from void*
288 to uint8_t*. Remmove all delete on image data variables
290 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
292 Verify the file pointer value before open the file, and if it's not null,
293 a verbose message is generated.
294 Close correctly the file when the file isn't considered dicom-like. The
295 correctly close is a call to CloseFile.
296 When closing the file pointer, test if its not null to close the file.
297 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
298 file. For an uncompressed image, the copied datas correspond in the least
299 case to the image size (calculated) or the image size specified in the
300 header. A verbose is generated if these two size mismatch
302 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
304 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
305 break under windows (with msvc6 compilation).
307 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
308 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
309 compiling with MSVC6)
311 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * Bugs fix for the Windows build with VC6
313 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
314 needed (only for projects required VTK). If the VTK is included in all
315 projects, there is conflicts with the jpeg lib of vtk when compiling the
316 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
317 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
318 when compiling the gdcm_wrap.cxx file (created by the compilation of the
320 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
321 (like it's already made for the cout use). Otherwise, conflict with the
324 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
325 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
327 - comments on the DicomDir::Method related usage added.
328 - now that we use the namespace gdcm, a lot of internal classes do
329 NOT need to be wrapped anymore.
330 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
331 DicomDir::Method) new example added.
333 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
334 * Improve string manipulation. I now inforce the notion of 'DicomString'
335 A DicomString can contain as many \0 as they want
336 and it is *always* of even length.
337 We only support odd length for very rare case.
338 And in the near future this should be removed.
340 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
341 * /binary_write/ gdcm source. Now even on big endian we are writting
342 little endian. This should -heopfully- fix some tests
344 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Now the dictionary is compiled into gdcm lib. This is a default
346 behavior, thus any dic file specified is picked before failback to
347 the one comiled into lib
349 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
350 * Change internals for gdcmDict. Don't use any 'new' any more.
351 This should definitely solve any leak problem, and we should be
352 as fast as before, as long as don't modify too much the dictionary.
354 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
355 * STYLE: ivars should start with a capital letter.
356 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
357 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
359 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
361 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
362 new 2004 dictionaries added (thanks to JPR).
363 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
364 * CLEANUP_ROUND (15) for gdcmPixelConvert
365 - RLEFrame::NumberFragments is now of type unsigned int
366 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
367 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
370 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * Initial work in gathering all transfer syntax accessors. clearly
372 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
373 ivars, but only one transfersyntax (class) ivar with equivalent method on
376 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
378 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
379 discussed (plus I didn't like having a 2000 lines patch not commited)
381 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
382 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
383 * CLEANUP_ROUND (14) for gdcmPixelConvert
384 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
385 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
386 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
388 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
389 anymore and hence avoids storing a copy of PixelConvert::Decompressed
390 into File::Pixel_Data.
392 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
393 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
394 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
395 * CLEANUP_ROUND (13) for gdcmPixelConvert
396 Substituted File::ParsePixelData() with PixelConvert::Print() new
398 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
399 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
400 method to those classes.
401 - src/gdcmFile.[cxx|h]:
402 -- Added a ::Print() method.
403 -- PixelConverter is now a reference instead of a member.
404 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
405 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
407 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
408 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
409 collaboration diagram and inheritance diagram should be generated with
411 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
412 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
413 pointlessly wrapped (see
414 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
415 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
416 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
417 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
418 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
419 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
420 -- File::Initialise: PixelConverter setup moved away to
421 PixelConverter::GrabInformationsFromHeader()
422 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
423 interpretation moved away to PixelConverter::BuildRGBImage()
425 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
426 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
427 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
429 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
430 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
431 displayed on Win32 when a brutal abort() occurs (because of uncatched
432 exception). See TODO new entry of this commit for more on this.
433 * TODO added new entry.
434 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
435 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
436 - HandleColor is no longer called from gdcmFile.cxx
437 - gdcmPixelConvert.cxx clean up on method arguments and internal
438 variable names for semantical coherence.
440 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
441 * Finished lossless transition, not only do we now read all lossless jpeg
442 images, without the need of the Cornwell lib, but we do read them properly now
443 * To reduce code (well to avoid code duplication), I defined a common place
444 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
445 redefine symbols. This is not prefect but this the best solution I found for a
446 compilation time jpeg option.
448 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 * Update jpeg ijg lib to support lossless jpeg implementation
450 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
452 * Also added a special copyright for dcmtk since we use their bugfixes.
455 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
456 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
457 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
458 matters, as stated in warning note at begining of %include section).
459 * src/gdcmDicomDir*.[cxx|h]: coding style
460 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
461 * src/gdcmJpeg8.cxx: doxygen fix.
462 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
463 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
464 from File:: to PixelConvert::.
466 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
468 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
469 - more code moved away from File:: to PixelConvert::
470 - fat setup of PixelConverter set in place in File::Initialise.
472 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
474 namespace at the file system level. So now you should convert your examples
476 gdcmHeader -> gdcm::Header
477 It would be nice if people keep in mind to no open the namespace, since it
478 allows compilation on broken plateform which were defining common symbol in
479 the standart namespace (like LP, Unknown ...)
481 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
482 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
483 The JPEG fragments are now parsed at the same stage than the RLE
484 information. All code related to JPEG is now in gdcmPixelConvert:
485 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
486 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
487 export a gdcmFile:: method. Those are simply global functions
488 (for the time being this is better than having them attach to
489 either gdcmFile:: or gdcmPixelConvert::).
490 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
491 and stores the result in a gdcmJPEGFragmentsInfo.
492 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
493 code (among other stuff) moved away from gdcmFile:; to
496 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
498 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
499 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
500 clean up of RLE related code.
501 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
502 - src/gdcmRLE.cxx removed
503 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
504 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
505 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
506 * CLEANUP_ROUND (9) for gdcmPixelConvert
507 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
508 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
509 away from gdcmFile:: to gdcmPixelConvert::.
511 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
513 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
514 This is because Parse7Fe0 used to parse the pixels to compute the
515 length. This task was passed over to FindDocEntryLengthOB() a long
516 time ago, EXCEPT I had forgotten the OW case...
517 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
518 we just recylce the code for parsing RLE fragments and computing
520 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
521 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
522 with the retired Parse7Fe0().
523 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
524 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
526 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
528 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
529 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
530 - src/CMakeLists.txt: alphabetic order reodering + new entries.
531 * CLEANUP_ROUND (4) for gdcmPixelConvert
532 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
533 to return an unused length.
535 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
536 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
537 this should be cleanner from the plane view. The iostream are erally a pain
538 to use to do simple stuff.
540 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
541 * Redo the compilation of the ijg jpeg library. Now only one source is
542 necesseray. No need to rename file by hand what so ever. CMake handle the
543 copying of the file within different directory, configure header file to
544 modify some symbol. The only addition made to ijg wasd a mangle table so
545 that symbol are different wether we are within 8bits or 12bits.
547 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * Added documentation of vtkgdcmReader on Website:
549 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
550 with it's binary name).
551 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
552 the Website to be more complete.
553 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
554 doxygenated documentation.
555 - Doc/DoxyVtkGdcmReaderExamples.txt added
556 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
557 DoxyVtkGdmReaderExamples.html )
558 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
559 * CLEANUP_ROUND (3) for gdcmPixelConvert
560 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
562 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
563 * CLEANUP_ROUND (2) for gdcmPixelConvert
564 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
566 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
567 * CLEANUP_ROUND for gdcmPixelConvert:
568 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
569 - src/gdcmPixelStuff[h|cxx] removed
570 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
571 - src/CMakeLists.txt changed accordingly
573 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
574 gdcmVersion.py moved to newly created ATTIC related
575 gdcmPython/SetupOldies/ directory.
576 * Autotools clean up:
577 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
578 - autogen.sh configure.in acinclude.m4 python.m4 removed
580 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
581 * src/*.cxx *.h Reference to License.htm fixed to License.html.
582 * Doc/CMakeLists.txt, doxygen.config.in: fix.
583 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
585 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
586 * TODO updated with Mathieu suggestions. I proposed a template for
587 describing TODO entries and used it for new entries.
588 * Added Doc/Website/CodingStyle.html, Developpers.html,
589 DeveloppersPython.html, GdcmDataCvs.html and
590 DownloadVersion0_1.html, DownloadVersion0_3.html.
591 * Some Doc/*.txt Doxygen files (which do not really concern the
592 documentation itself, but the website) moved to html and
593 placed in directory Doc/Website:
594 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
595 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
596 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
597 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
598 * CMakeLists.txt changed accordingly.
599 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
600 DeveloppersPython.html
601 * INSTALL nows refers to Doc/Website/Installation.html
603 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * Added Doc/Website directory, that contains a first raw version
607 2004-09-23 Jean-Pierre Roux
608 * FIX In order not to be poluted any longer by casting problems,
609 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
610 we can now delete[] it safely
611 * VoidArea is now called BinArea (less confusing name),
612 and all the methods called ...VoidArea... are now ... BinArea...
613 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
615 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
616 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
617 clear) TagHT, which is an inherited member of gdcmElementSet. It is
618 up to the destructor of gdcmElementSet to clean up TagHt and it's
621 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * Test/CMakeLists.txt: update to follow gdcmData renamings.
623 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
625 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
626 * ENH: added some utility method that builds a flat dictionnary
627 holding all the Dicom entries contained in the recursive structure
628 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
630 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
631 BuildFlatHashTable() that build a flat dictionary.
632 - src/gdcmElementSet.h: added a new private GetTag() accessor.
633 gdcmDocument is now a friend of gdcmElementSet.
634 - src/gdcmElementSet.cxx: clean up.
635 - Example/FlatHashTablePrint.cxx added.
636 - Example/CmakeLists.txt changed accordingly
638 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
639 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
640 moved away from gdcmDocEntrySet (since this class is an abstract class
641 acting like an interface). SQDepthLevel and BaseTagKey are now
643 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
644 and associated accessors. Doxygenation of the class.
645 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
647 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
648 Use SQDepthLevel accessor instead. ::Print() adapted.
649 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
650 - src/gdcmDocument.cxx changed accordingly.
652 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
653 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
654 - The following is the doxygen comment of the typedef declaration
655 of gdcmagKey in src/gdcmCommon.h:
656 gdcmTagKey is made to old an "universal" (as in URL, Universal
657 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
658 A dicom tag allways has a group and an element, but a set of tags
659 embeded in various (optionally nested) sequences and sharing
660 the same group and element all share the same (group, element)
661 "identifier". Hence the (group, element) cannot be used as an
662 identifier (in gdcm we shall refer to a "TagKey") of a tag.
663 In order to construct a proper tag identifier (i.e. a key) we
664 consider the following definition of a TagKey:
665 - let Group, Element be the string representation of the
666 group and element dicom tag members,
667 - let ItemNumber be the string representation of the integer
668 index of the considered item number of a sequence,
669 Let the key of a tag embeded in a sequence, noted SeqTag, be
671 /ItemNumber#Group|Element
672 where "/", "#" and "|" are characters acting as separators.
673 Then the general form of a gdcmTagKey is given by:
674 Group|Element<SeqTag>
675 where <SeqTag> means NO or many instances of SeqTag.
676 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
679 but the gdcmTagKey of a tag "embeded" is the first item of
680 a sequence, itself nested in the third item of a sequence is the
682 0004|1220/2#0008|0082/0#0008|0090
683 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
684 order to hold the new sequence compatible key. Previously, the
685 GetKey() method would look in the underlying gdcmDictEntry.
686 - src/gdcmDocEntry.cxx:
687 -- constructor now copies the underlying DictEntry key, in the local
689 -- ::Print: displays the member Key, instead of the (group, element).
690 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
691 - src/gdcmDocEntrySet.h:xi
692 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
693 -- now has a new BaseTagKey member.
695 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
696 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
698 This poses the problem with the semantics of the following lines
699 LoadEntryVoidArea(0x0028,0x1201); // R LUT
700 LoadEntryVoidArea(0x0028,0x1202); // G LUT
701 LoadEntryVoidArea(0x0028,0x1203); // B LUT
702 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
703 to the long FIXME note for what the problem is. Nevertheless in
704 order to get things working the dicom dictionary was altered !
705 Please fix things urgently...
706 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
707 information), see above note on moving the member VoidArea. Nevertheless
708 the following entries previously correctly set as US are now inproperly
710 0028 1201 OW IMG Red Palette Color Lookup Table Data
711 0028 1202 OW IMG Green Palette Color Lookup Table Data
712 0028 1203 OW IMG Blue Palette Color Lookup Table Data
713 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
714 of gdcmDocEntry moved to gdcmSeqEntry.
715 * src/gdcmSeqEntry.cxx: STYLE.
717 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * Test/TestAllEntryVerify.cxx minor fix and added comments.
720 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
721 * gdcmPython/testSuite.py: all the test suite in python is now moved
722 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
723 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
724 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
726 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
727 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
728 to avoid inclusion recursion until STL is reached.
729 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
730 mecanism. errno.h is not included in gdcm anymore.
731 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
732 (gdcmFormatError now inherits from gdcmFormatUnexpected).
734 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
735 gdcmData/TestAllEntryVerifyReference.txt
736 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
737 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
738 exception_on_error parameter.
739 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
740 - vtk/vtkGdcmReader.cxx changed accordingly,
741 - Example/*.cxx and Test/*.cxx changed accordingly.
743 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
745 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
746 enable_sequences removed from gdcmHeader constructor and dependencies.
747 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
748 * gdcmPython/demo/PrintHeader.py: dummy fix.
749 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
750 skip_shadow removed from gdcmHeader constructor and dependencies.
751 * Example/*.cxx and Test/*.cxx changed accordingly.
753 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
754 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
755 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
757 2004-07-21 Jean-Pierre Roux
758 * FIX Now, Parsing and Printing a DICOMDIR do work!
759 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
761 2004-07-20 Jean-Pierre Roux
762 * FIX Some brain damaged headers have Zero-Lenght fields
763 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
765 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
766 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
767 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
768 variable (instance of gdcmDebug) by a definition macro, and the instance
769 is now in static in the gdcmDebug class
770 * src/gdcmSQItem.h : (FIXME) remove an undefined method
771 * Test/PrintAllDocument.cxx : bug fix in the result of the test
773 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * WARNING: ctest now depends more tightly on gdcmData. You should
775 check out gdcmData properly for things to run smoothly...
776 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
777 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
778 we need the pixels not be loaded in order to use the ValEntry
779 that displays position and size).
780 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
781 This is a C++ based equivalent of gdcmPython/testSuite.py that should
782 be deprecated. If you have any doubts about the advantages of a
783 modern scripting language (read Python) versus grass root C++ (i.e.
784 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
785 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
786 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
787 Anyhow, consider documenting the gdcmData images in
788 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
790 * Test/CMakeLists.txt:
791 - now uses TestAllEntryVerify.cxx
792 - specific comments on oldACR00001.ima (now renamed in gdcmData
793 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
794 gdcmData/TestAllEntryVerifyReference.txt
797 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
798 * src/*.[h|cxx] : typedef clean up
799 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
800 - TagKey renamed to gdcmTagKey (for external usage)
801 - VRKey renamed to gdcmVRKey (for external usage)
802 - removal of typedef duplication.
803 - Removed all unecessary inline keyword from class inline definitions.
804 - Some method|function(void) declarations replaced with method|function().
805 * src/jpeg/libijg12/jdhuff12.c:
806 - printf polluting ctest removed.
807 - TAB removal for comminting
809 - TestAllReadCompareDicom.cxx: added a test that compares all the
810 images in gdcmDataImages.h with corresponding images in
811 gdcmData/BaselineDicom/. When baseline images are not present
812 this test creates them.
813 Note: we need to validate each reference image, but before that
814 I'd like to rename them with a more explicit name...
815 - CMakeLists.txt: changed accordingly.
816 * Example/*.cxx: examples now only include gdcm.h (as opposed to
817 including each header needed).
819 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
820 * Test/*.cxx and Example/*.cxx: moved some examples away from the
821 test suite to the Example directory. Are concerned:
826 - TestWriteSimple.cxx
827 * Test/CMakeLists.txt: added some comments on reasons for black listing
828 image gdcmData/oldACR00001.ima
830 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
831 * Test/CmakeList.txt: removed the following from black list (to be coherent
832 with removal from gdcmData):
833 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
834 - gdcm-MR-PHILIPS-16.dcm
836 Added the following because after last cvs update, they cause
837 ctest -R TestReadWriteReadCompare
839 - gdcm-MR-SIEMENS-16-1.acr
841 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
842 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
843 new comments in this file) we temporarily (sigh) move to a weaker
845 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
846 we don't need to black list the following images anymore:
847 - 8BitsUncompressedColor.dcm
849 - US-PAL-8-10x-echo.dcm
850 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
851 fixes and the beautified code ;-)
852 This fixes the bug introduced in version 1.42 (when beautifying)
853 that made the parsing of 8BitsRunLengthColor.dcm unproper.
854 Note: ctest was blind to this bug (this means we need to still
855 improve the test suite). The bug could be detected by using
856 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
858 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
859 and by displaying the (garbage) produced file temp.XDCM...
861 2004-06-29 Jean-Pierre Roux
862 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
863 - replace by uggly but working old code :-(
864 A lot of things should be OK again.
865 It's really urgent to have a test suite that *tests*,
866 to prevent Frog's beautifying sessions to break all the stuff
867 (twice, withing a fortnigh ...)
869 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
870 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
871 redundancy) to added Test/TestReadWriteReadCompare.cxx
872 * Test/CmakeList.txt: because the compare test of
873 Test/TestReadWriteReadCompare.cxx fails, the following images are
874 black listed: - 8BitsUncompressedColor.dcm
876 - US-PAL-8-10x-echo.dcm
877 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
878 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
879 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
880 and ad-hoc kludge. This kludge is now removed, and on encountering
881 such an image (OB field brain damaged) we set errno. Then in
882 ::FindDocLength() we "fix" the length as being ALL what remains
883 in the file (until EOF). We then proceed, hoping for the best...
884 This fixes a SegFault in ShowDicom when trying to write such an
886 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
887 (because TestWriteRead breaks on it, after a non conformal commit?).
888 ctest now runs properly, except for MakeDicomDir (which was allways
889 broken) and the Python related stuff (still not fixed).
891 2004-06-24 Jean-Pierre Roux
892 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
893 FIX : Test/TestReadWrite now iterates on all the file names
894 (instead of infinite loop)
895 ENH : Test/TestWriteRead now iterates on all the file names
897 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
898 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
900 2004-06-24 Jean-Pierre Roux
901 FIX : - now Write drops LUT Descriptors and LUTs (if any)
902 when SamplesPerPixel =3
903 - now Write is no longer confused by
904 'BitsAllocated = 12" and 'BitsStored=12"
905 - "UN" value representation Elements are now written correctly
906 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
907 ENH : - now gdcmHeader has its own Write methods
908 (in order to split the job that has not to be done
911 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
912 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
913 loop on the same image until memory went out.
914 Note: this means we still have gobs of memory loss in PrintDocument
915 * src/gdcmDocument.cxx: fixes problem on parsing on file
916 gdcmData/16BitsJpegLosslessGrayScale.dcm.
918 2004-06-24 Jean-Pierre Roux
919 FIX : Write - All the Sequences and Sequence Item are now written
920 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
921 is added a the end, when necessary.
922 - A lot of brain-damaged images, that were read correctly are
923 now written correctly
924 - length compatible BinEntry are now loaded correctly
925 (even for odd groups)
926 Note : only Explicit Value Representation was checked.
927 (question : is implicit VR really necessary for gdcm ?)
929 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
930 * DEVELOPPER: added a proposition of coding style.
931 * src/gdcmDocEntry.h: removed every inline declaration (for test of
934 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
936 Use the gdcmDocEntry::Print() and Write() instead.
937 * src/gdcmDocument.cxx: bug fix.
939 2004-06-22 Jean-Pierre Roux
940 FIX : gdcmDocument.cxx
941 - Now we do recognize the JpegLossLess format (there was a misstyping in
942 code 'beautyfication' :-(
943 - Now we automaticaticaly load the Luts, if any
945 2004-06-22 Jean-Pierre Roux
946 In order : to write Sequences, whatever their imbrication level,
947 : to allow user to create his own Sequences
948 a lot of modif where necessary (adding, moving, or virtualising methods)
950 WARNING : save your own sources *before* cvs up !
953 ADD virtual void Write(FILE *fp, FileType filetype);
956 ADD virtual void Write(FILE *fp, FileType filetype);
957 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
960 ADD virtual void Write (FILE *fp, FileType filetype)=0;
961 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
962 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
963 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
964 ADD std::string GetEntryByName(TagName name);
965 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
967 std::string vr = "unkn",
968 std::string fourth = "unkn",
969 std::string name = "unkn");
970 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
971 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
972 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
973 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
974 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
975 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
976 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
977 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
980 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
981 ADD virtual std::string GetEntryByName (TagName tagName);
982 ADD virtual std::string GetEntryVRByName (TagName tagName);
983 REM virtual bool Write(FILE *, FileType);
984 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
985 FILE *_fp, FileType type);
986 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
987 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
988 REM virtual bool WriteEntries(FILE *_fp,FileType type);
989 REM virtual std::string GetEntryByName (std::string tagName);
990 REM virtual std::string GetEntryVRByName (std::string tagName);
991 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
992 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
993 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
995 std::string vr = "unkn",
996 std::string fourth = "unkn",
997 std::string name = "unkn");
998 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
999 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1000 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1001 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1004 ADD virtual void Write(FILE *fp, FileType filetype);
1007 ADD virtual void Write(FILE *fp,FileType filetype);
1010 ADD virtual void Write(FILE *fp, FileType filetype);
1011 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1012 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1013 REM std::string GetEntryByName(TagName name);
1016 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1018 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1020 The default constructor invoked by the line
1021 gdcmHeader *f1 = new gdcmHeader( header );
1022 was gdcmHeader::gdcmHeader(bool) instead of the expected
1023 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1024 Hence the parsing wasn't executed... See also below.
1025 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1026 as explicit constructor didn't do the trick to fix the above problem.
1027 Could anyone explain why ?
1028 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1029 properly calls gdcmValEntry::Print() (that was weed out from
1030 code related to gdcmBinEntry).
1032 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1033 * In order to fix memory leaks:
1034 - Test/TestWriteSimple.cxx: added cleaning of free store through
1036 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1037 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1038 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1039 (through the call to ::AddDicomDirMeta()) or the destructor
1040 would crash when deleting uninitialized ::metaElems].
1041 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1042 - src/gdcmDocument.cxx:
1043 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1044 from dynamic stores.
1045 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1046 was causing memory leaks.
1047 - src/gdcmSQItem.cxx:
1048 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1049 cleanly handled with polymophism: sorry but my milage is low).
1050 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1051 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1052 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1053 This avoids SegFaulting.
1054 - src/gdcmSQItem.h: coding style.
1056 - Test/TestWriteSimple still severely sucks. The output image content
1057 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1058 damaged when displayed with vtkgdcmViewer.
1059 - on memory leaks: TestWriteSimple leaks really less (see entry
1060 of 2004-06-18 in Changelog file for the call to valgrind).
1061 - on segfaults: ctest now passes all the tests but one (no more
1063 * Erroneous leading white fix:
1064 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1065 white[s] (as opposed to from >> xxx, that removes it [them].
1066 - src/gdcmTS.cxx: ditto.
1067 - gdcmPython/testSuite.py: dirty related kludge removed.
1068 * src/*: remaining references to gdcmParser removed.
1069 * src/*[cxx|h]: added copy[way]left header.
1072 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * In order to fix writing of dicom files:
1074 - Test/TestWriteSimple.cxx: a simpler example of writing.
1075 - Test/CMakeLists.txt changed accordingly.
1076 - src/gdcmDocument.cxx:
1077 -- The destructor now recursilvely removes potential sequences.
1078 -- Bug fix in ::IsJPEG2000()
1079 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1080 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1082 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1083 to only declared) and build on top of
1084 ::GetDocEntryByNumber(guint16, guint16).
1085 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1086 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1087 for usage in destructor and treatement of promotion in
1088 ::ReplaceOrCreateByNumber().
1089 - src/gdcmSQItem.cxx: destructor should better handle his job.
1090 Test/TestWriteSimple now runs (or at least it DOES something).
1091 * We can now start hutting memory links. A good starting point is:
1092 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1093 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1094 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1096 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1097 * Valgrind note: after Mathieu Malaterre teached me how to read
1098 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1100 Using gcc, you can force the STL to use malloc and to free memory as
1101 soon as possible by globally disabling memory caching.
1102 With 3.2.2 and later, you should export the environment variable
1103 GLIBCPP_FORCE_NEW before running your program.
1104 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1105 simply vanish (it is still not clear to me, whether this means that
1106 STL std::string leaks or if valgrind believes it leaks...).
1107 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1108 running bin/gdcmTests makeDicomDir):
1109 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1110 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1112 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1113 SegFaulting (I drowned in DicomDir related code when trying to
1114 understand why the list is empty...).
1115 * src/gdcmDocument.h: first BSD license header try.
1116 * Doc/License.txt added.
1118 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1119 * src/gdcmDocument.[h|cxx]:
1120 - Clean up of the Transfer related predicates. They are now all based
1121 on new method isGivenTransferSyntax, that (should) handle properly
1122 the padding problem.
1123 - general clean up, simplification, and coding style.
1124 - Specific clean up of Parse7FE0() (umproperly named actually).
1125 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1127 2004-06-14 Jean-Pierre Roux
1129 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1130 - fix the display of SQItem ordinal number
1131 - add the GetSQItemByOrdinalNumber method
1132 - remove some useless never written private methods
1134 2004-06-14 Jean-Pierre Roux
1136 - adding a constructor taking a gdcmDocEntry as an input param
1137 - ReplaceOrCreateByNumber now returns :
1138 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1139 a gdcmValEntry * if a string value is passed as a param
1141 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1142 according to the param type (no longer sets a gdcmDocEntry)
1143 - GetValEntryByNumber, GetBinEntryByNumber added
1144 - NewValEntryByNumber and NewBinEntryByNumber added
1146 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1148 - GetSQItemNumber and SetSQItemNumber added, to provide
1149 a (relative) Item identier inside a given Sequence
1150 \warning : some pb remaining around this number
1152 - AddEntry now takes the Item Number as a param
1154 - adding a constructor taking a gdcmDocEntry as an input param
1156 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1157 * Memory leak hunt with the following command:
1158 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1159 --show-reachable=yes gdcmTests PrintDocument
1160 It looks like many (all?) leaks are due to the STL (or a bad usage
1161 of the STL. The lines producing the leaks now have a comment with
1162 a "MEMORY LEAK" tag: you can retrieve them with
1163 grep "MEMORY LEAK" src/*
1164 Here are two typical examples which I can't help fixing:
1169 char * test = "babo";
1170 name = test; //// <--- valgrind detects 960 bytes lost in
1171 //// call to std::string::operator=(char const*)
1172 name.clear(); //// Doesn't help !
1180 std::cout << "Type a bunch of characters followed by RETURN: ";
1181 getline(std::cin, line); //// <--- valgrind dectects a loss
1182 //// of 1320 bytes in call to
1183 /// std::basic_istream<>& std::getline<>
1189 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * src/gdcmHeader.[cxx|h]:
1191 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1192 and related, moved away to gdcmDocument.
1193 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1194 the corresponding protected accessors of inherited class
1195 gdcmDocument, removed ! As a consequence gdcmFile had to be
1196 declared friend of class gdcmDocument (see below).
1197 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1198 - Clean up of undefined or unused methods.
1199 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1200 account the changes to gdcmHeader.h).
1201 * src/gdcmDocument.h:
1202 - gdcmFile is now a friend class (in order to take into account the
1203 changes to gdcmHeader.h).
1204 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1205 (see changes to gdcmHeader.h).
1206 - Accessors (reading on the form GetEntry*) are now public.
1207 - Clean up of undefined or unused methods.
1208 * src/gdcmDocument.cxx:
1209 - adaptation to changes to gdcmDocument.h
1210 - ::OpenFile now writes a verbose message when file cannot be opened.
1211 - some std::string properly set to VRKey
1212 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1213 references to gdcmDocument.
1214 * Test/TestFindTags.cxx: changed accordingly to above changes.
1215 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1216 cvs repository gdcmData.
1218 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1220 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1221 conflicts with gdcmValEntry::voidArea.
1222 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1223 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1224 Value representation between StringRepresentable and BinaryRepresentable.
1225 * src/gdcmDocument.cxx:
1226 - method ParseDES: proper indentation restored and usage of
1227 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1228 - method LoadDocEntry: the fingerprint left in the SetValue() of
1229 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1230 removed. Reverting to previous code segment with the proper
1231 dynamic_cast< gdcmValEntry* >.
1232 Note: this was (partially) breaking the python test suite
1233 (gdcmPython/testSuite.py) that made usage of the above
1234 fingerprint to check presence of "Pixel Data".
1235 * src/gdcmDocEntry.h: coding style.
1236 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1237 now taken into account.
1238 * gdcmPython/gdcm.i: adaptation to the new internal representation
1239 of gdcm (exit gdcmParser, hello gdcmDocument).
1240 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1242 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1243 anymore, but instead prints the loaded Python dictionary.
1244 * .... alas, the python testSuite is still broken.
1246 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1247 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1249 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1250 * src/gdcmUtil.h : export methods
1252 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1253 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1255 * Initial addition of automatic python testing
1256 * Initial addition of automatic image comparison
1258 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1259 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1260 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1262 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1263 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1264 * Test/ShowDicom.cxx : bug fix for msvc compilation
1265 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1267 2004-05-04 Jean-Pierre Roux
1268 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1269 new concepts (and new classes) :
1270 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1271 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1272 - Sequence Doc Entries (gdcmSeqEntries)
1273 a Sequence is composed of Items.
1274 Each item is a set of Doc Entries (this is recursive)
1275 The non uniqueness of the 'Dicom tag' is due to this recursivity
1276 (never taken into account)
1277 Our unability to add a new 'entry' in the header
1278 at the proper location (neither in the H-Table (map or multimap),
1279 nor in the Chained List is also due to this recursivity.
1280 Don't try, right now, to use/modify/compile these new sources :
1281 nothing is finished.
1282 We just commit all the stuff, 'as is', in order not to loose it.
1284 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1285 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1287 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1288 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1289 file prefix (SetFilePrefix)
1291 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * Add a new test: ShowDicom, for now this is just the c++ version of
1293 checkRead.sh, later it will be able to compare the image read against a
1295 * Replace the DEBUG on the stack with a global entry in cmake interface:
1296 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1298 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1299 * Add an example subdir, with a real example on how to read + write a
1302 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1304 * Doc/CMakeLists.txt: the main page is now properly differentiated
1305 between the developper and user version.
1306 * Doc/doxygen.config.in: dropped search related obsolete flags
1307 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1309 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1310 * DEVELOPPER: added some helpfull comments for compile/test/install
1313 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1314 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1315 src directory, now generated in the build dir.
1316 2. Tests as mentionned smarter
1318 4. Add a new method in gdcmDict that return the PubDict by name
1319 this is interesting for 3rd party lib like ITK,
1320 where we could set the institution name / patient name...
1322 * ENH: 1. Now the test suite is working for real
1323 2. All binaries are now output in the gdcm-bin directory
1324 (this was not true before)
1326 2004-04-28 Jean-Pierre Roux
1327 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1328 SeQuence indented printing of Dicom Header.
1329 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1330 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1331 Computation of SQDepthLevel is now part of gdcmHeader constructor
1332 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1333 tree-like structure of a Dicom Header.
1334 * FIX Test code cleaning
1336 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1337 * ENH: Adding automatic testing
1338 1. Need a DartConfig.cmake to submit to public
1339 2. Add a test driver gdcmTest.cxx
1340 3. gdcmTestMain, an helper for the main test driver gdcmTest
1341 4. Files in Test don't have a main anymore, this becomes interesting
1342 when we add more and more tests, thus dsw don't have to load
1344 * ENH: Adding a GDCM_DATA_ROOT for testing
1345 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1346 one file instead of seven + some small cleanup
1348 2004-04-22 Jean-Pierre Roux
1349 * ENH Minor changes to the Print() methods.
1350 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1351 Header printing. Example given with :
1352 > PrintHeader fileName 2 new
1353 (SQ based tree-like structure still to be done for the Header ...)
1355 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1356 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1357 1. I have added some unsigned where needed
1358 2. Some function parameter not used -> (void)
1359 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1360 4. g++ don't like character '\' in comment
1361 5. #define jpeg_create_decompress jCreaDecompress
1362 this really need to be fixed
1363 6. virtualize destructor of gdcmObject ... leakage
1364 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1365 this also really need to be fixed
1366 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1367 remove compression file
1368 (as we only do decompression, right ?)
1369 * ENH: Change malloc/calloc/free with c++ equivalent
1371 2004-04-21 Jean-Pierre Roux
1372 * FIX gdcmHeaderHelper::GetXSpacing
1373 when a single value is found (bug ?), xpacing is now
1374 defaulted to yspacing
1376 2004-04-19 Jean-Pierre Roux
1377 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1378 * ENH add parameters :
1379 bool exception_on_error = false,
1380 bool enable_sequences = false,
1381 bool ignore_shadow = false
1382 to the gdcmFile constructors to be full gdcmParser compliant
1383 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1384 to allow reading of PAPYRUS 3.0 files
1386 2004-04-06 Jean-Pierre Roux
1387 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1389 2004-04-02 Jean-Pierre Roux
1390 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1391 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1392 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1394 2004-03-30 Jean-Pierre Roux
1395 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1396 for ACR file, written out as DICOM files (hope so...)
1398 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1399 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1400 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1401 moved to base class gdcmParser and only the specialisation is kept
1403 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1404 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1405 already does the job.
1406 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1407 (to be consistent with gdcmParser::WriteEntries).
1409 2004-03-30 Benoit Regrain
1410 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1411 upate of the object's instance. It's passed to 2 in the unfavorable
1412 case : one in the ExecuteInformation, one in the ExecuteData
1414 2004-03-29 Jean-Pierre Roux
1415 * ENH : Check on file type to be written moved
1416 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1417 * FIX : gdcmObject::ResetBoundaries now stops properly
1418 when end-of-list is reached
1419 : gdcmVersion modified (as Benoit Regrain asked)
1421 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1422 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1423 * src/gdcmUtil.cxx: added forgotten iostream include.
1424 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1425 equivalent to ExplicitVR in existing code).
1427 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1428 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1429 now contains all the gdcmGlobal related code.
1430 * minor coding style and doxygenation changes.
1432 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1433 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1434 now contains all the Debug related code.
1435 * minor clean-up of includes in src/*.cxx
1436 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1437 CreateCleanString) removed.
1438 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1439 * Doc/DoxyMainPageUser.txt added.
1440 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1441 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1442 src/gdcmDirList.cxx)
1444 2004-03-24 Jean-Pierre Roux
1445 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1447 2004-03-23 Jean-Pierre Roux
1448 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1449 big endian made volumes
1450 * ENH Now gdcmParser constructor and destructor are protected to forbid
1451 end user to instanciate class gdcmParser
1452 (only gdcmHeader and gdcmDicomDir are meaningfull)
1454 2004-03-22 Benoit Regrain
1455 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1456 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1457 gdcmSerie to gdcmDicomDirSerie
1459 2004-03-19 Jean-Pierre Roux
1460 * ENH Now the tree-like structure describing a DICOMDIR comming from
1461 an already existing DICOMDIR file is consistent with
1462 the home-made tree-like structure build ex-nihilo
1463 or build from the files held (recursively) in a Directory
1464 functions gdcmDicomDir::CheckBoundaries()
1465 gdcmObject::SetBoundaries() added
1467 2004-03-17 Jean-Pierre Roux
1468 * REM (Eric Boix bug) : removal of meaningless
1469 gdcmDicomDirImage::NewImage function.
1470 * FIX now file names and directory name are written properly in the
1472 * FIX now gdcmDicomDir constructor may be call without any trick
1475 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1476 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1477 of gdcmDicomDirImage::NewImage as empty function.
1479 2004-02-28 Jean-Pierre Roux
1480 * ENH add gdcmDicomDir:NewPatient
1481 add gdcmDicomDirPatient:NewStudy
1482 add gdcmDicomDirStudy:NewSerie
1483 add gdcmDicomDirSerie:NewImage
1484 to allow making gdcDicomDir object.
1485 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1486 (as opposite to the gdcmHeader chained list)
1488 2004-02-11 Benoit Regrain
1489 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1490 when using from python
1492 2004-02-10 Benoit Regrain
1493 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1494 * FIX : in gdcmDicomDir when the directory is empty
1495 * ENH : add callback and methods to get the progression of dicomDir
1498 2004-02-06 Jean-Pierre Roux
1499 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1500 - GDCM_META added to gdcmDicomDirType
1501 - class gdcmMeta created
1502 * ENH : - A brief summary is now displayed at the beginning of
1503 'testDicomDir' to help disaster magnitude estimation
1504 * REM : Now useless Test/explDICOMDIR.cxx
1506 2004-02-05 Benoit Regrain
1507 * ENH : add methods in gdcmObject to get the hash table or the list of
1509 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1510 * FIX : wrapping python for TagHeaderEntryHT
1512 2004-02-04 Benoit Regrain
1513 * FIX : even length for some strings when writting the dicom dir
1514 * FIX : sort the images in the dicom dir
1515 * FIX : Bug fix for python use of dicom dir
1516 * ADD : a python demo
1518 2004-02-04 Jean-Pierre Roux
1519 * FIX : Final solution (?) for icone embedded images
1520 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1521 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1522 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1523 gdcmData/gdcm-MR-SIEMENS-16.acr1
1524 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1525 to make full checking easier
1527 2004-02-04 Benoit Regrain
1528 * FIX : WriteEntries : coding style & logic in parameters
1529 * FIX : Set the elements to create the DicomDir in a dictionary file
1531 2004-02-03 Benoit Regrain
1532 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1533 * gdcmDicomDir : add the load of directory
1534 * Bug fix and print add-on
1536 2004-02-03 Jean-Pierre Roux
1537 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1538 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1539 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1540 * FIX gdcmParser.cxx : 'group length' elements are now considered
1541 as integers, even for shadow groups, when file is Implicit VR
1543 2004-02-02 Jean-Pierre Roux
1544 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1546 of the last synonym :-(
1547 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1549 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1550 * FIX taking into account the possible 7fe0,0010 multiplicity
1551 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1552 to allow removal of references to 7fe0,0010, to deal with
1553 ACR-NEMA images, when 0028,0200 is meaningfull
1555 2004-01-31 Jean-Pierre Roux
1556 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1557 no longer writes 'Un' on disk
1558 * FIX SQ elements with actual length are now dealt with corectly
1559 * FIX gdcmFile::WriteBase make the difference, for color images, between
1560 the length (for Palette expanded images)
1561 and Raw Length (non expanded image + Palette)
1562 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1563 (that broke Write). Replaced by UL.
1564 Aware user will reload the field if he
1565 thinks it's necesssary
1567 2004-01-30 Jean-Pierre Roux
1568 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1569 when 'dirty Acr' is found, to be compliant with the new
1570 IsReadable() methods.
1572 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1573 (no DOUBLE images in kosher DICOM,
1574 but so usefull for people that miss them ;-)
1576 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1577 DICOMDIR related utilities (not checked as Windoze compliant)
1579 2004-01-28 Jean-Pierre Roux
1580 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1582 2004-01-27 Jean-Pierre Roux
1583 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1584 to allow skipping the shadow elements, to save memory space.
1585 The TRUE value for this param has to be used
1586 with a FALSE value for the 'enable_sequence' param.
1587 ('public elements' may be embedded in 'shadow Sequences')
1588 * gdcmHeader methods now deal with 'embedded icones images' in the header
1589 (even when an 'icone image sequence' is announced by the
1590 element (0x0088,0x0200), but there is NO icone at all ...
1592 * gdcmHeader sometimes Image Location value doesn't follow
1593 the supposed processor endianity (see gdcmData/cr172241.dcm).
1596 * gdcmHeader add the method
1597 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1598 to get *all* the Header Entries with the same tag.
1599 GetHeaderEntrySameName is probabely *useless*
1600 (no meaning : Name is *not* an identifier within the Dictionnary)
1602 2004-01-26 Benoit Regrain
1603 * Bug fix in the print of hexadecimal representations. Remove long fields
1604 in the print and add a third level of print to print them
1606 2004-01-23 Benoit Regrain
1607 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1608 * Bug fix on test suite after remove the strip made on not string fields
1609 * Split the IsReadable method between gdcmParser which test that the file
1610 is dicom and gdcmHeader which test that it's an image file
1612 2004-01-22 Benoit Regrain
1613 * DicomDir : clean code, add methods, set variables in protected or private
1614 * gdcmUtil : bug fix for the clean string method
1616 2004-01-19 Benoit Regrain
1617 * Add the use of shadow dictionaries
1618 * bug fix and coding style
1620 2004-01-19 Benoit Regrain
1621 * src/gdcmFile.cxx : bug fix concerning the close of file
1622 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1623 * Add the update of header entries using the shadow library
1625 2004-01-19 Benoit Regrain
1626 * removal of file gdcmHeader2.cxx
1627 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1628 inheriting from gdcmParser. This split is to prepare the integration
1629 of dicom dir parsing
1630 * bug fix under python
1632 2004-01-16 Jean-Pierre Roux
1633 * REM removal of class gdcmHeaderEntrySet
1634 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1635 * ADD add file gdcmHeader2.cxx
1636 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1638 2004-01-15 Benoit Regrain
1639 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1640 entries created while parsing the header. Thus, they will be destroyed
1641 when the gdcmDictSet will be destroyed
1642 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1645 2004-01-15 Benoit Regrain
1646 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1647 made a fatal error because of the memory release at the end of program.
1648 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1649 some memory and vtk seems to have some problems with that.
1650 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1652 2004-01-14 Benoit Regrain
1653 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1654 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1655 * src/*.[h|cxx] : make changes due to class name changes
1656 * gdcmPython/demo/*.py : bug fix due to method names
1658 2004-01-13 Benoit Regrain
1659 * src/*.[h|cxx] : coding style
1660 * vtk/*.[h|cxx] : coding style
1662 2004-01-13 Benoit Regrain
1663 * gdcmPython/testSuite.py : test the readable flag of file for tests
1664 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1665 It's lied to the stl compilation by MSVC (windows, always windows...)
1666 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1668 2004-01-12 Benoit Regrain
1669 * src/*.h : add comments
1670 * src/gdcmDictSet.h : set the method BuildDictPath in public
1671 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1672 directly setted in the source code
1673 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1676 2004-01-09 Benoit Regrain
1677 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1678 * setup.py : use a reference to gdcmVERSION
1680 2004-01-07 Benoit Regrain
1681 * Modification to compile with the distutils.
1684 2003-12-10 Benoit Regrain
1685 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1686 can use a gdcmHeaderHelper to load datas
1687 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1688 made in the source code
1690 2003-12-10 Benoit Regrain
1691 * Update Windows projects and .cvsignore files
1693 2003-11-12 Jean-Pierre Roux
1694 * ENH gdcmHeader constructor has one more parameter (default value : false)
1695 that allows the user to 'go inside' the SeQuences only
1697 gdcmElValSet:Print takes it into account
1699 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1700 * ENH: Update gdcmPython/CMakeLists
1701 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1702 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1704 2003-11-10 Jean-Pierre Roux
1705 * FIX : gdcmHeader::LoadElements is now based
1706 on the ListTag listElem member,
1707 not longer on the TagElValueHT tagHt member
1708 * ENH : PrintPubElVal shows (temporarily) both results,
1709 with the tagHt member and the listElem member.
1710 (it's easier to 'see' the problems when using Printheader)
1712 * FIX : old private member LgrElem is now splitted into
1713 ReadLength : Length actually found on disk (updated only
1714 if bug fixing is necessary), for internal
1716 UsableLength : Updated by FixFoundLength, to fix a bug
1717 or to allow Parser going on.
1718 Will allow to re-write a kosher header when a SeQuence
1719 with a length (not 0000) is found
1720 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1721 because gdcmElValSet::Add does not update ListElem
1724 2003-11-07 Jean-Pierre Roux
1725 * FIX misstyping in Transfert Syntax name table
1726 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1727 when they have an actual length (not 0000 nor FFFFF)
1728 (Nobody should care of it, but DICOMDIR explorers)
1730 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1733 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1734 * ENH: vtkGdcmReader now supports LUT !
1735 (vtkgdcmViewer for now is not able to use them though)
1737 2003-11-05 Jean-Pierre Roux
1738 * in testSuite.py : new files names for checking the package
1739 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1740 that returns the pixel area size to the *aware* (vtk) user
1741 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1743 2003-11-05 Benoit Regrain
1744 * in testSuite.py : Modify the rules for checking the paths
1745 : Explicit error messages
1746 * in __init__.py : Related modif
1748 2003-11-03 Jean-Pierre Roux
1749 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1750 to be used by aware (vtk) users that want to manage
1751 LUT (and no to turn the PALETTE image into an RGB pixels one)
1752 * GetPixelType now returns 8U for 24 Bits images
1753 (vtkGdcmReader compliant)
1755 2003-10-31 Jean-Pierre Roux
1756 * Removal of *all* gdcmData images and add them again
1757 in order to loose the 'history' of un-anonymised images
1759 2003-10-31 Jean-Pierre Roux
1760 * RMV : removal of useless jBitsInJsample.h
1761 for both 8 and 12 Bits JPEG Lossy Libraries
1763 2003-10-31 Jean-Pierre Roux
1764 * ENH : Add the functions gdcmFile::GetImageDataRaw
1765 gdcmFile::GetImageDataIntoVectorRaw
1766 that act as GetImageData and GetImageDataIntoVector
1767 except the making of an RGB Plane from Gray Plane + LUT
1768 Intended to aware (vtk) users who know how to manage
1771 GetLUTRGBA return a R,G,B,A LUT if any
1772 lgrTotaleRaw gives the 'Raw' length
1773 GetImageDataRaw returns the gray Plane
1774 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1775 (They stay Grey, just like with other Dicom viewers :-(
1777 2003-10-30 Jean-Pierre Roux
1778 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1780 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1781 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1782 being coherents dicom files.
1784 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1785 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1787 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1788 * ENH: Two steps is necessary to please VC++ compiler...
1789 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1790 * ENH: Add include dir to medcon lib
1791 * FIX: only one function is being exported for now !
1792 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1794 2003-10-29 Jean-Pierre Roux
1795 * adding gdcmHeader::GetLUTRGBA
1796 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1797 --> Mathieu, the modif u're waiting for is not yet committed
1798 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1800 2003-10-27 Jean-Pierre Roux
1801 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1802 00191113.dcm DermaColorLossLess.dcm
1803 MxTwinLossLess.dcm RadBWLossLess.dcm
1804 * ENH: For version prior to vtkImageViewer2 -r 1.19
1805 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1807 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1808 * Removal of ido stuff in CMakeLists.txt
1810 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1811 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1812 * FIX: remove a call to ->Modified ... see comments
1813 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1815 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1816 * FIX: Problem with path for libvtkgdcmPython
1817 * ENH: Try adding a search script for python site-package
1818 * RMV: Remove some file from medcon lib that are not necessary
1819 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1820 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1821 * FIX: More pragma disable fro VC++,
1822 I don't think I break something as it is also disable in VTK/ITK.
1823 But it fasten debug compilation time.
1825 2003-10-23 Jean-Pierre Roux
1826 * gdcm now deals with 16 Bits Run Length Encoded images
1827 (they are compressed as 2 planes images,
1828 one for the high Bytes, the other for low Bytes)
1830 2003-10-22 Jean-Pierre Roux
1831 * Now CheckRead takes into account :
1832 - the bugged 'Leonardo' Siemens images
1833 - the XA images, sent thru the burning VPRO station
1834 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1837 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1838 * FIX: When copying a Makefile.am to CMakeLists.txt
1839 one should remove the '\'
1841 2003-10-22 Jean-Pierre Roux
1842 * in gdcmData adding a bugged 'Leonardo' Siemens image
1843 (wrong lengths in header)
1844 OK with gdcm, KO with the other viewers :-)
1845 * add a GE dlx XA image, thru the VEPRO burning station
1848 2003-10-21 Jean-Pierre Roux
1849 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1850 for a brutal checking of vtkgdcmViewer compliance
1852 2003-10-21 Jean-Pierre Roux
1853 * add the files for 'xmedcon' Jpeg Lossless library
1854 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1856 2003-10-21 Jean-Pierre Roux
1857 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1859 2003-10-21 Jean-Pierre Roux
1860 * garbage Siemens 'Leonardo' images dealt with
1861 (the patch is easy to remove)
1862 * cosmetic changes to avoid warnings
1864 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1865 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1866 no need to press 'r' now.
1868 2003-10-20 Jean-Pierre Roux
1869 * upgrade of checkRead.sh checkWrite.sh according
1870 to new Jpeg Lossless decompressor
1871 * add US.3405.1.dcm, a genuine RGB medical file ...
1872 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1873 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1875 2003-10-15 Jean-Pierre Roux
1876 * general anonymisation in gdcmData
1877 * adding the 'color files' from
1878 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1879 * adding some well knowed bugged-header images
1880 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1881 waiting for their inclusion in Python testsuite
1883 2003-10-15 Jean-Pierre Roux
1884 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1885 no longer seg faults when file is not found
1887 2003-10-14 Jean-Pierre Roux
1888 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1891 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1892 * TODO: *.in file to genereate a UseGDCM later
1894 2003-10-14 Jean-Pierre Roux
1895 * Some supposed-to-be Dicom Images have no preamble.
1896 OpenFile takes it into account
1897 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1898 * Missing elements added in dicomV3.dic
1899 (just to be affraid : have a look at
1900 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1901 and do it again next year ;->
1903 2003-10-13 Jean-Pierre Roux
1904 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1905 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1906 But there are NOT. It's fixed !
1908 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1909 * FIX: "jpeglib.h" was not found on VC++
1910 * FIX: vtkgdcm was not being installed
1912 2003-10-10 Jean-Pierre Roux
1913 * ENH : OpenFile closes the file if it *really* doesn't look like
1914 an ACR-NEMA / DICOM one.
1915 * FIX : testWrite no longer writes an empty file if the source file
1916 is not gdcm Readable
1917 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1920 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1921 * FIX: CMake generate now documentation
1922 * ENH: out of source doc build !
1923 * ENH: Generate both user and dev documentation
1924 * ENH: Should work on windows too
1925 * ENH: Only one doxygen config.in file is needed
1926 * FIX: make install should be ok now on ùnix plateform
1927 * FIX: PATH to dictionary was wrong (missing /)
1928 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1930 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * vtkGdcmReader is now able to read rgb dicom file.
1932 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1933 * added a gdcmViewer to vtk test, use mouse to control
1934 window level & window width
1936 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1937 * CMake-ification of gdcm, we have now two build system
1938 * FIX: on cygwin Wsock32 doesn't exist
1939 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1941 2003-10-06 Emanuel Ollart
1942 * FIX : compilation process wad broken.
1943 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1945 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * change gdcmViewer -> vtkgdcmViewer
1947 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1949 2003-10-06 Jean-Pierre Roux
1950 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1951 ( e.g : well known GE images with a wrong elem length,
1952 : Philips MRI Images with a wrong Huffman table)
1953 * still to be done : allow the reading of bugged LEONARDO Siemens images
1955 2003-10-03 Jean-Pierre Roux
1956 * Odd length strings are padded with '\0' (not with spaces,
1957 to remain compliant with already defined strings,
1958 like Transfert Syntax UID and others)
1960 2003-10-03 Jean-Pierre Roux
1961 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1962 to allow displaying RGB images (not only by affim ;-)
1964 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * vtkGdcmReader is now able to read rgb dicom file.
1966 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1968 2003-10-03 Jean-Pierre Roux
1969 * A few nasty patches to allow the reading of a lot of nasty images
1970 ( e.g : well known GE images with a wrong elem length,
1971 : Philips MRI Images with a wrong Huffman table)
1972 * still to be done : allow the reading of bugged LEONARDO Siemens images
1974 2003-10-03 Jean-Pierre Roux
1975 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1977 2003-10-03 Jean-Pierre Roux
1978 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1979 to allow displaying RGB images (not only by affim ;-)
1981 2003-10-03 Jean-Pierre Roux
1982 * gdcmFile::GetImageDataIntoVector now
1983 - deals with MultiFrames MultiFragments Run Length Encoded files
1984 - deals with YcBcR (YBR_FULL) files
1985 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1986 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1988 (no sample found :-(
1990 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1991 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1992 Two reasons: - clear things
1993 - third parties acces gdcm through header files, so won't
1994 suffer anymore VC++ complains
1996 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1997 * add argv[1] in testvtkGdcmReader.cxx
2000 2003-09-24 Jean-Pierre Roux
2001 * The lines are now eigthy characters long.for
2002 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2004 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2005 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2006 char* to std::string. Thus, the use of strdup becomes useless. (see
2007 previous commis of Malaterre)
2008 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2009 before the last Malaterre's commit.
2011 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2012 * This commit should fix the Debug building under VC++, the problem
2013 was mainly a mixture of debug and release lib being loaded at startup.
2014 * I also remove a depency to a specific C function: strdup. Because I had
2015 to force the link to msvcrtd (whereas strdup is in libc).
2017 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2018 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2019 located in the gdcmCommon.h file. All use of reference of tha has been
2020 changed to now use the variable GDCM_UNFOUND.
2022 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2024 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2025 Dicom dictionary. The test suite can now be run again. Note:
2026 I'm note very happy with the " (RET)" changes. I believe this
2027 RETAINED comment should be dropped when parsing the dictionary.
2028 - PACKAGER corrected
2030 - AUTHORS updated and now in alphabetical order
2031 * Makefile.am now exports gdcm.dsw for Windoze users.
2033 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2034 * cygwin complains about missing std:: in subdir Test/
2036 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * remove some methods that are now in gdcmHeaderHelper
2039 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2040 * vtkGdcmReader set spacing and origin correctly
2042 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2043 * Fix a few delete/delete[] mismatch
2045 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2046 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2047 interpretation to data given by gdcmHeader. For instance there are
2048 heuristics to get informations (look at different places).
2049 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2050 sorting DICOM images based on different strategies.
2051 * modified Makefiles accordingly.
2053 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2055 when building in debug mode
2056 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2057 src/win32/gdcmdll.dsp
2058 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2060 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2061 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2064 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2065 * src/win32/libgdcmjpeg12.dsp was not dos format
2066 * src/win32/libgdcmjpeg12.dsp :
2067 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2068 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2070 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2071 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2073 * src/gdcmFile.cxx : bug fix in affectation type
2074 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2075 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2076 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2077 symbols... future problem ?
2079 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2080 * src/win32/libgdcmijpeg12.dsp was missing
2081 * modified gdcm.dsw accordingly
2083 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2086 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2087 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2088 commit of JPR (before his hollidays to facilitate our work).
2089 * setup.py : bug fix in code. Modifications made while the last commit
2090 of JPR. The code hasn't been tested before the commit... it's so
2091 useless to make that (for best programmer that is JPR) !!!
2093 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * tagged the current version as Version0_3 (i.e. version 0.3)
2096 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2097 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2098 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2099 * *.dsp : modifications to use new libgdcmijpeg8 library
2100 * setup.py : bug fix on VTKPATH variable
2101 * PACKAGER : adding all concerning windows
2103 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2106 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2107 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2108 test suite reported error.
2109 * PACKAGER file added (describes what a packager must do when
2110 packaging a new release).
2111 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2112 * configure.in: upgraded version number to 0.3.0
2113 * fixing build of rpm (through rpm -ta):
2114 - Doc/Makefile.am exports proper doxygen files
2115 - src/jpeg/libijg8/Makefile.am exports the include files.
2117 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2118 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2119 * src/gdcmHeader.h : formatting code
2121 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2122 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2123 We were obtaining error message from vtk. Now, creation of file list
2124 is made in an internal list to prevent this problem.
2125 Bug fix when output is empty.
2126 Bug fix in update of progress value. Previous commit for this was a bad
2128 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2130 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2131 * src/gdcmHeader.h : added method to get the file name
2132 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2133 files. Added method to remove all files on the input
2134 Added FIXME comment concerning the bad parsing of header made by
2135 ExecuteInformation method (in ExecuteData method)
2137 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2138 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2139 when using make instal.
2140 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2141 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2143 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2144 * setup.py : adding include dir of jpeg lib to compile all sources
2145 * */Win32/*.dsp : JPR fix for windows compilation
2147 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2148 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2150 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2151 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2153 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * setup.py is again effective on un*x (takes into account the
2155 addon of the jpeg library)
2156 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2157 * Doc/Doxy* updated (includes above enhancements)
2158 * INSTALL now points to web documentation
2160 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * src/gdcmHeader.h doesn't make unnecessary reference to
2163 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2165 * src/gdcm*.[cxx|h] :
2166 - to allow compilation with gcc 3.x
2167 -- clean up of STL usage (added explicit usage of std::)
2168 -- small fixes on exceptions.
2169 Note: linking not tested !
2170 - clean of doxygen comments to avoid warnings at documentation
2172 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2173 dependent convertion).
2175 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2176 * Clean up of previous JPR garbage commit (not even commented in the
2178 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2179 - moved all jpeg related files from src to src/jpeg/libijg8, with
2180 addition/modification of Makefile.am and configure.in.
2181 - the testSuite is still brain damage (not guilty).
2183 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2184 * WrapVTK.py : modifications to get correctly vtk source files to
2186 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2187 (FileName -> Filename)
2189 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2190 * vtk/vtkGdcmReader.[cxx/h]:
2191 - UpdateProgress method should now be effective
2192 - removed the limitation on having only images loaded (as opposed
2194 - when building a stack of images/volume, a lesser number of
2195 gdcmHeader and gdcmFile instances should be used (hopefully
2196 accelerating things).
2197 - when building a stack of images/volumes, files which are not
2198 loadable (wrong path-filename, wrong permissions on existing file,
2199 or file not parsable by gdcm) are replaced with a black image
2200 in the stack (for the caller to notice the problem).
2202 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2203 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2205 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2206 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2207 between standard library (std) and vtk library (problems are found
2208 under Windows... thanks Windows !)
2210 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2213 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2215 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2216 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2218 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * When compiling with distutils (see setup.py) the C++ compiler is
2220 called with different flags than the default ones (with automake).
2221 In order to fix all those warning, I compiled gdcm with the command
2222 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2223 and went for warning fixes:
2224 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2225 up from unused variables.
2226 - vtk/vtkGdcmReader.cxx: potential bug fix.
2227 * src/gdcmHeader.h: Doxygen warning cleanup
2229 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2230 * gdcmPython/gdcm.i:
2231 - typemaps correction to take into account the systematic replacement
2232 of "using namespace std" with std:: prefix e.g. std::list,
2233 std::string... (cf changes of 2003-05-21).
2234 - gdcmGlob global variable of type gdcmGlobal (defined in
2235 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2236 exported to Python a as cvar.
2237 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2238 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2239 gdcmDictSet.GetPubDictTagNames() and
2240 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2241 C++ static methods).
2242 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2243 with the above changes.
2245 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2246 * setup.py, manifest.in : bug fix under linux
2248 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2249 * Modification of setup.py to compile vtk part too. Then, we have 2
2250 wrappers which must work with same distutils. For that, we have a
2251 generic distutils in distusiltsWrapping.py ; with :
2252 - build_extWrap class to wrap generically all extensions,
2253 - ExtensionWrap base class for all wrapping extension that contains
2255 - Wrapper interface which wrap sources
2256 + In WrapSwig.py we have extension and wrapper for Swig
2257 + In WrapVTK.py we have extension and wrapper for VTK
2258 * MANIFEST.in : modifications to consider vtk directory and new python
2259 files for compilation
2261 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2262 * Added python wrappers of vtkGdcmReader vtk class (see the
2263 source in vtk/vtkGdcmReader.cxx) :
2264 - vtk/Makefile.am now builds a library
2265 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2266 python library (as opposed to _gdcm.so wich are the python
2267 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2268 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2270 - configure.in has an additional flag --enable-vtk that needs
2271 to be set to enable compilation of vtk related code, that is:
2272 + vtk/vtkGdcmReader.so and
2273 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2274 + gdcmPython/vtkgdcmPython.so (see above)
2275 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2276 be read when compressed or when HighBit + 1 != BitsStored),
2277 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2278 the usage of the python wrapper of vtkGdcmReader vtk class.
2279 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2280 * src/*.[h] all occurences of stl classes are now prefixed with
2281 std::, and all occurences of "using namespace std;" where removed.
2282 This is to avoid pollution of global namespace in included files.
2283 Apparently vtk does not avoid this pitfall: when using both
2284 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2285 collision of various stl members (principally cout...).
2286 * gdcmPython/testSuite.py now cleanly removes temprory generated
2288 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2289 comply with above changes)
2291 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2292 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2293 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2294 vtk data structure (an image Flip was required).
2295 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2296 * cosmetic changes in documentation.
2298 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2299 * src/gdcmHeader.cxx: the constructor no longer exits when an
2300 unexisting file is given as argument.
2301 * The subdirectory Data (containing all the images used for the
2302 test suite) is not part of this repository anymore. A new module
2303 containing those images is now available at
2304 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2305 with the name gdcmData.
2306 All the python scripts (including the package initialisation file
2307 gdcmPython/__init__.py) were adapated to take this change into
2308 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2310 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2311 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2312 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2313 demo of the usage of this class.
2314 Compilation of this vtk part is only done when using the --enable-vtk
2315 at configure (or autogen.sh) stage.
2317 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2318 * More memory link related corrections and documentation fixes.
2320 - maximum info is obtained with a command of the form:
2321 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2322 --show-reachable=yes PrintHeader
2323 - the remaining reachable blocks seem to come from the STL
2324 allocation scheme through the usage of map and list. It looks
2325 like this memory cannot be freed but it is not a memory leak
2326 (in fact further invocation to the STL would recollect the
2327 unused memory allthough it cannot explicitely be freed).
2328 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2329 of displaying an image parsed with gdcm and displayed with VTK.
2330 Note: some images don't seem to work e.g.
2331 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2332 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2333 Allthough this weakens the semantics, it is a ditch attempt to
2334 make gdcm more thread friendly.
2336 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2337 * Memory link hunt (by using valgrind through the command
2338 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2339 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2340 gdcmHeader::_dicom_vr.
2341 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2342 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2344 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2346 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2347 * src/Makefile.am now exports all the necessary include files at
2351 * UpdateGroupLength replaced by new one
2354 * UpdateGroupLength re-written using H-Table
2355 (named UpdateGroupLengthNew untill checks are over)
2357 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2358 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2359 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2361 - gdcmHeader::GetPubElValSet removed.
2362 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2363 UpdateGroupLength, WriteElements, Write.
2364 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2365 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2366 carried the same semantics.
2367 - src/gdcmHeaderIdo.cxx changed accordingly.
2368 - gdcmFile::WriteBase now regroups all the codes from previous
2369 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2370 - enum FileType moved to gdcmCommon.h
2371 * src/gdcmHeader.cxx AddDefault trashed
2372 * gdcmGetXSize added
2373 * getimageDataSize now calls gdcmGetXSize
2374 * Test/*.cxx changed to agree with above changes
2376 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2377 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2378 (to avoid double call by end user).
2379 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2380 by end user, since gdcmHeader::gdcmHeader now handles it.
2382 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2383 * gdcm/Doc many doxygen changes:
2384 - Doxyfile now has two different versions, DoxyfileUsers that generates
2385 the html.users end users oriented documentation and
2386 DoxyfileDeveloppers that generates the html.developper developper
2387 oriented documentation.
2388 - README changed accordingly
2389 - requirement.txt removed (old design info moved to TODO).
2390 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2391 DoxyMainPage.txt, DoxyPython.txt provide more information.
2392 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2393 be updated by simply regenerating the docs with doxygen and copying
2394 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2395 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2396 all the tests in the form "if (<map>.count() >1)" were removed.
2397 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2398 ill-formed documentation sections.
2399 * src/gdcmHeader.cxx: ditto
2401 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * setup.py fixed for un*x (needed macro for stdint.h)
2403 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2404 un*ces with sh-utils test utility.
2405 * gdcmPython/demo/test.py renamed to PrintHeader.py
2406 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2407 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2408 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2409 * src/gdcm*.cxx JPR's bad inclusion fixed.
2411 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2412 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2413 * gdcmPython/demo/test.py changed accordingly.
2415 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * gdcmPython/Makefile.am fixed linking against libstdc++
2417 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2418 * Swig subdir (historical tests of swig version 1.3.17++) removed
2419 * Test/testChangeEntete.cxx some lines commented out in order to make
2421 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2422 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2424 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2425 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2426 hence the user doesn't need this explicit call.
2427 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2428 i.e. LoadElements() call removed.
2429 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2430 - src/Makefile.am declares the proper flag for g++.
2431 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2432 for adding user defined new tags.
2433 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2434 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2435 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2437 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2438 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2439 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2440 src/Makefile.am : the project should properly compile and install
2441 with the autotools, included the python wrappers part.
2442 * gdcm.spec.in : added a spec file for RPM packaging.
2444 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2445 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2447 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2449 to exported to the environement (see gdcmPython/testSuite.py
2451 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2452 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2453 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2454 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2455 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2457 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2458 * gdcmPython/__init__.py doesn't crash anymore when running in
2459 in InstallMode or PreInstallMode but with an environement given
2460 value of GDCM_DICT_PATH.
2461 * src/gdcmDictSet.[cxx/h] coding style.
2463 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2464 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2465 * src/gdcm.h general comments moved to TODO, and README
2466 * src/gdcm.h should now be seen as a user commodity (including it
2467 should suffice to fully use gdcm). It is nowhere including within
2468 any of the kernel files src/*.cxx and src/*.h.
2470 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2472 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2474 * src/gdcm*.cxx only include their corresponding include file
2475 (as opposed to gdcm.h)
2476 * gdcmPython/gdcm.i changed accordingly
2477 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2478 the autogen.sh generated "make snapshot" command to work.
2479 * autogen.sh removed history related references to crea package.
2481 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2482 * distutilsSwigCPlusPlus.py work around some swig portability
2485 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2486 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2487 was done in a last ditch attempt to get setup.py _really_
2488 operationnal. The python/gdcmPython layaout add the advantage
2489 of hidding away the python related distutils specific files
2490 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2491 Alas, the src directory was out of scope (i.e. it's relative
2492 position to setup.py was ../src) which made things impossible to
2493 handle (see previous version of python/setup.py). Crossing fingers...
2495 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2496 * python/setup.py now works on Un*x. (harder than I thougth)
2497 * python/distutilsSwigCPlusPlus.py can now have include files
2498 among the list of sources.
2500 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2501 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2502 * modifications in MSVC projects
2504 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2505 * As stated by the first lines of Test/ExceptionAndPython/README, it
2506 looks like we can move back to original usage of exception within
2507 src/gdcm* and hence remove the errno stuff that was introduced
2508 as a quick and dirty fixture of this problem (added to the TODO).
2509 * Doc/Doxyfile configuration file for Doxygen and corresponding
2510 README file for usage added.
2511 * Test/testWrite.cxx added. This new test comes from a split of
2512 test.cxx that is now reverted to its original purpous i.e.
2513 testing the proper parsing of a Dicom related file.
2514 testWrite.cxx concentrates on testing the IO part of gdcm.
2515 * Test/bug1.cxx (containing a bug on WIn32) added.
2516 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2517 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2518 whose purpose is to publish the content of the TagNames of the
2519 Dicom public dictionnary were not accessible without an
2520 instance of class gdcmHeader.
2521 - those methods are now static methods of gdcmDictSet and hence
2522 require no instances at all to be invocated.
2523 - within gdcmDictSet this change required to change some method
2524 to class methods (i.e. are now static) among which SetDictPath
2525 (renamed to BuildDictPath) and LoadDefaultPubDict.
2526 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2527 the above changes by calling the new method classes of gdcmDictSet.
2528 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2529 the above to be effective.
2530 * python/gdcmPython: in order to wrap properly the above changes
2531 for Python, swig version now needs to be > 1.3.17.
2532 * python/gdcmPython/Makefile fixed to adapt itself to new
2533 configure/make shema introduced by Johan Montagnat (thanks for the
2534 contribution). Alas this Makefile cannot be turned into a proper
2535 Makefile.am without some heavy changes in the configure.in
2536 (for python dectection).
2537 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2538 now avoids publishing the empty entries.
2540 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2541 * python/setup.py : bug fix concerning install under windows
2542 ExtraPath reused :-P
2543 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2545 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2546 * Dicts/dicomV3.dic : remove double spaces !!!
2547 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2548 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2551 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2552 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2553 method. Doxygenation.
2554 * src/gdcm.h clean up of JPR spurious comments.
2556 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2557 * python/distutilsSwigCPlusPlus.py now properly collects the
2558 shadow classes generated by "swig -c++" (gdcm.py in our case)
2559 when using "python setup.py install".
2560 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2561 reexports the working classes.
2562 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2563 by the classical C errno scheme. This is to prevent an obscure
2564 behavior of the python wrappers when importing wxPython.wx prior
2565 to gdcmPython (which ended up in an abort call). An illustration
2566 of this oddity can be found in the Test/ExceptionAndPython
2567 subdir (see the README file). This problem probably due to
2568 an combination of g++ and dynamic loading.
2569 * added Test/ExceptionAndPython (see above)
2571 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2572 * Changed the layout of the python part to avoid bloating main
2573 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2574 i.e. the distutils arsenal. All the python related stuff is
2575 again in a python subdir, but the package itself is now in
2577 * setup.py was cleaned up:
2578 - pythonIncludePath removed
2579 - python setup.py bdist target is now functional.
2580 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2581 collision with other packages). gdcmPython/demo/*.py changed
2584 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * python subdir moved to gdcmPython (preparation of distutils packaging).
2586 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2587 distutils installer is operational.
2588 * - gdcmPython/__init__.py now properly loads the swig generated
2589 shadow classes (from gdcm.py).
2590 - gdcmPython/demo/*.py changed to import the package gdcmPython
2591 instead of gdcmPython/demo/load.py.
2592 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2594 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2595 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2596 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2597 entries within the associated public Dicom dictionary resp. the same
2598 information but sorted by the fourth field (PAT, IMG, DIR) of the
2600 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2601 are now in the "???" group.
2602 - python/gdcm.i changed accordingly,
2603 - python/demo/printGroupedPublicDict.py added, that gives an example
2604 of the above new functionalities in Python.
2606 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcm.h, gdcmHeader.cxx:
2608 - historic references to glib's g_malloc and g_free (#defined)
2609 were definitively removed.
2610 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2611 * src/gdcmElValSet.cxx:
2612 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2613 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2614 - GetElValue(string) renamed to GetElValueByName.
2615 - Added GetElementByName(string).
2616 * src/gdcmHeader.cxx: added
2617 - GetPubElValRepByNumber(guint16, guint16)
2618 - GetPubElValRepByName(string)
2619 - GetShaElValRepByNumber(guint16, guint16)
2620 - GetShaElValRepByName(string)
2621 - GetShaElValByNumber(guint16, guint16)
2622 - GetShaElValRepByName(string)
2623 - GetElValRepByNumber(guint16, guint16)
2624 - GetElValRepByName(string)
2625 - GetElValByNumber(guint16, guint16)
2626 - GetElValRepByName(string)
2627 * Doc/requirements.txt added.
2629 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2630 * Test/Makefile building now depends on the one of libgdcm.so
2631 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2632 pixel data) aware which enables finding the address (offset) of
2633 the pixel data of JPEG encoded DICOM files. This leaves only a single
2634 file in the testSuite whose pixel data address (offset) is unknown.
2635 * python/testSuite.py changed accordingly.
2637 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2638 * VC++ has some strong limitations when working with the STL, as stated
2639 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2640 "Also note that some STL containers (map, set, queue, list, deque)
2641 cannot be exported. [...]
2642 Some STL classes contain nested classes. These classes can not
2644 This is caused by a designed limitation that once a template
2645 class is instantiated, it can not be re-instantiated and
2647 Since our usage of map<> is ubiquitous in gdcm, this "designed
2648 limitation" of VC++ is a pitfall.
2649 Hence the Python wrappers of gdcm cannot be incrementally linked
2650 against the c++ dynamic library. The dirty but only workaround is
2651 to forget about incremental link of dynamic libraries and to generate
2652 the Python wrappers library with the inclusions of the underlying C++
2654 The following modifications concern this matter on Win32/VC++:
2655 - wrapping python correct with standalone wrapped dll (don't use separate
2656 dll under windows !!!!)
2657 - python21_d debug mode enabled (ask Frog how to use it :-)
2658 - NO problem with having an STL member of class for example string in C++
2659 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2660 - Python test of dcmlib in Python is ok under windows on a large set
2662 * removed glib references
2663 * typedef's inserted in gdcm.i for correct swig type management
2665 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2666 * python/demo/*.py load.py extracted from test.py. Added explore.py
2667 that only displays required tags and testAll.py that parses all
2668 the files of the testsuite without using unittest.
2669 * python/testSuite.py other additional test on new files added.
2670 * Data/* new test files added accordingly to the testSuite.
2671 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2672 the vr in the file differs from the one of the dictionary.
2674 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2676 values, but limits itself to values which are below a user specified
2677 size (by default 1024 bytes).
2678 * python/gdcm.i : elements not loaded (because their size is above the
2679 user specified treshold) are exported with their TagKey as key of the
2680 python dictionary. This enables the testsuite to make some checks
2681 on the unloaded elements (since we have their offset and size).
2682 * python/testSuite.py
2683 - now tests for the existence and proper value of the pixel data
2684 - two new examples added.
2685 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2687 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2688 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2689 aware. See the strategy comments in gdcmHeader::FindeLength().
2690 * Test/test.cxx now accepts a filename as first argument.
2691 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2692 * python/testSuite.py changed to integrate test on above files.
2694 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2695 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2696 the vr was also RET.
2697 * python/testSuite.py more tests added.
2699 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * python/testSuite.py unittest test suite added (uses Data)
2701 * Data/* dcm and acr files for the test suite.
2702 * glib dependance removed from un*x version. We now use ISO C99
2703 7.18 Integer types (see stdint.h)
2704 - python/Makefile, src/Makefile src/gdcm.h
2705 * src/ when an explicit vr (like dicom files) suddenly poped an
2706 implicit element we use to mark the underlying DictEntry of the
2707 concerned ElValue with "Implicit". This strategy was damageable
2708 too the public or provite dictionaries, since some of their vr
2709 would be changed. Since Header::FindLength heavily relies on the
2710 detection by Header::FindVR of falsely explicit elements, I
2711 added an extra ImplicitVr member to ElValue (boolean).
2712 The rest of the changes we the necessary adaptations.
2714 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2715 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2717 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2719 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * Adaptation for porting to VC++:
2722 o forced to use std namespace (for string to be known)
2723 o all class use __declspec export style on WIN32
2724 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2725 (in stdlib.h on Win32 but in std:: for gcc)
2726 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2727 variable GDCM_DICT_PATH.
2728 * src/gdcmHeader.cxx verbose comments made discrete.
2730 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * python/gdcm.i: added a typemap that converts a C++ hashing table
2732 to native Python dictionary.
2733 * python/demo/test.py:
2734 - now uses the native dictionary for exploration of gdcmHeader.
2735 - takes an optional filename argument (the file to parse).
2736 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2737 PubElVals hashing table.
2738 * Dicts/dicomV3.dic removed error prone trailing spaces.
2740 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * Python wrapping process moved away from src/Makefile to
2742 newly created python/Makefile (as well as gdcm.i)
2743 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2744 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2745 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2746 from the environement variable GDCM_DICT_PATH (when existing).
2747 * src/gdcmDict::GetTag bug fix.
2749 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * Straightforward temporary fixes for swig to build the python wrappers.
2751 src/Makefile now has a python working entry [by working we mean
2752 that we can import de shadow classes without errors].
2754 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2755 * hashtest.cxx removed (since allready in Test)
2756 * src/gdcmlib.h renamed to src/gdcm.h
2757 * src/dcm.i renamed to src/gdcm.i
2758 * src/Makefile prepared for python wrapping
2760 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * src/gdcmHeader.cxx :
2762 - Parsing of header is now separated from loading of element values
2763 (see gdcmHeader::LoadElements).
2764 - general clean up of hopefully all file access (creation of
2765 ReadInt16 and ReadInt32)
2767 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2768 * src/gdcmHeader.cxx :
2769 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2771 - SetLgrElem renamed to SetLength
2772 - GetLgrElem renamed to GetLength
2773 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2774 * src/gdcmElValSet.cxx fixed both GetElValue methods
2775 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2776 due to IdoDude was cleaned out.
2778 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2779 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2780 concentrates on finding the value representation (when it exists).
2781 RecupLgr now only finds the element value length, and it avoids
2782 returning the unecessary skL (skipped length).
2783 Also, offsetCourant was simply removed (with taille_fich) since
2784 it was redundant with the File position internals (by using
2785 ftell and fseek). This also made skL (see above in RecupLgr) usage
2787 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2788 on the libido specificities which are handled through class
2790 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2793 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * Truckload of changes. Parsing of header is barely functional
2795 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2797 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * src/gdcmHeader.cxx many addons of low level methods
2800 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2802 and _IdDcmSWAP_LONG.
2804 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2805 * This corresponds to all the changes decided at the meeting of
2806 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob