1 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
3 The default constructor invoked by the line
4 gdcmHeader *f1 = new gdcmHeader( header );
5 was gdcmHeader::gdcmHeader(bool) instead of the expected
6 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
7 Hence the parsing wasn't executed... See also below.
8 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
9 as explicit constructor didn't do the trick to fix the above problem.
10 Could anyone explain why ?
12 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
13 * In order to fix memory leaks:
14 - Test/TestWriteSimple.cxx: added cleaning of free store through
16 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
17 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
18 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
19 (through the call to ::AddDicomDirMeta()) or the destructor
20 would crash when deleting uninitialized ::metaElems].
21 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
22 - src/gdcmDocument.cxx:
23 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
25 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
26 was causing memory leaks.
28 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
29 cleanly handled with polymophism: sorry but my milage is low).
30 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
31 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
32 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
33 This avoids SegFaulting.
34 - src/gdcmSQItem.h: coding style.
36 - Test/TestWriteSimple still severely sucks. The output image content
37 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
38 damaged when displayed with vtkgdcmViewer.
39 - on memory leaks: TestWriteSimple leaks really less (see entry
40 of 2004-06-18 in Changelog file for the call to valgrind).
41 - on segfaults: ctest now passes all the tests but one (no more
43 * Erroneous leading white fix:
44 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
45 white[s] (as opposed to from >> xxx, that removes it [them].
46 - src/gdcmTS.cxx: ditto.
47 - gdcmPython/testSuite.py: dirty related kludge removed.
48 * src/*: remaining references to gdcmParser removed.
49 * src/*[cxx|h]: added copy[way]left header.
51 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
52 * In order to fix writing of dicom files:
53 - Test/TestWriteSimple.cxx: a simpler example of writing.
54 - Test/CMakeLists.txt changed accordingly.
55 - src/gdcmDocument.cxx:
56 -- The destructor now recursilvely removes potential sequences.
57 -- Bug fix in ::IsJPEG2000()
58 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
59 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
61 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
62 to only declared) and build on top of
63 ::GetDocEntryByNumber(guint16, guint16).
64 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
65 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
66 for usage in destructor and treatement of promotion in
67 ::ReplaceOrCreateByNumber().
68 - src/gdcmSQItem.cxx: destructor should better handle his job.
69 Test/TestWriteSimple now runs (or at least it DOES something).
70 * We can now start hutting memory links. A good starting point is:
71 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
72 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
73 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
75 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * Valgrind note: after Mathieu Malaterre teached me how to read
77 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
79 Using gcc, you can force the STL to use malloc and to free memory as
80 soon as possible by globally disabling memory caching.
81 With 3.2.2 and later, you should export the environment variable
82 GLIBCPP_FORCE_NEW before running your program.
83 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
84 simply vanish (it is still not clear to me, whether this means that
85 STL std::string leaks or if valgrind believes it leaks...).
86 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
87 running bin/gdcmTests makeDicomDir):
88 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
89 - Test/makeDicomDir.cxx now properly traps empty lists and returns
91 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
92 SegFaulting (I drowned in DicomDir related code when trying to
93 understand why the list is empty...).
94 * src/gdcmDocument.h: first BSD license header try.
95 * Doc/License.txt added.
97 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * src/gdcmDocument.[h|cxx]:
99 - Clean up of the Transfer related predicates. They are now all based
100 on new method isGivenTransferSyntax, that (should) handle properly
102 - general clean up, simplification, and coding style.
103 - Specific clean up of Parse7FE0() (umproperly named actually).
104 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
106 2004-06-14 Jean-Pierre Roux
108 - fix the display of Sequence Delimitor (SQDepthLevel pb)
109 - fix the display of SQItem ordinal number
110 - add the GetSQItemByOrdinalNumber method
111 - remove some useless never written private methods
113 2004-06-14 Jean-Pierre Roux
115 - adding a constructor taking a gdcmDocEntry as an input param
116 - ReplaceOrCreateByNumber now returns :
117 a gdcmBinEntry * if a Binary (void *) value is passed as a param
118 a gdcmValEntry * if a string value is passed as a param
120 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
121 according to the param type (no longer sets a gdcmDocEntry)
122 - GetValEntryByNumber, GetBinEntryByNumber added
123 - NewValEntryByNumber and NewBinEntryByNumber added
125 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
127 - GetSQItemNumber and SetSQItemNumber added, to provide
128 a (relative) Item identier inside a given Sequence
129 \warning : some pb remaining around this number
131 - AddEntry now takes the Item Number as a param
133 - adding a constructor taking a gdcmDocEntry as an input param
135 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
136 * Memory leak hunt with the following command:
137 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
138 --show-reachable=yes gdcmTests PrintDocument
139 It looks like many (all?) leaks are due to the STL (or a bad usage
140 of the STL. The lines producing the leaks now have a comment with
141 a "MEMORY LEAK" tag: you can retrieve them with
142 grep "MEMORY LEAK" src/*
143 Here are two typical examples which I can't help fixing:
148 char * test = "babo";
149 name = test; //// <--- valgrind detects 960 bytes lost in
150 //// call to std::string::operator=(char const*)
151 name.clear(); //// Doesn't help !
159 std::cout << "Type a bunch of characters followed by RETURN: ";
160 getline(std::cin, line); //// <--- valgrind dectects a loss
161 //// of 1320 bytes in call to
162 /// std::basic_istream<>& std::getline<>
168 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
169 * src/gdcmHeader.[cxx|h]:
170 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
171 and related, moved away to gdcmDocument.
172 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
173 the corresponding protected accessors of inherited class
174 gdcmDocument, removed ! As a consequence gdcmFile had to be
175 declared friend of class gdcmDocument (see below).
176 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
177 - Clean up of undefined or unused methods.
178 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
179 account the changes to gdcmHeader.h).
180 * src/gdcmDocument.h:
181 - gdcmFile is now a friend class (in order to take into account the
182 changes to gdcmHeader.h).
183 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
184 (see changes to gdcmHeader.h).
185 - Accessors (reading on the form GetEntry*) are now public.
186 - Clean up of undefined or unused methods.
187 * src/gdcmDocument.cxx:
188 - adaptation to changes to gdcmDocument.h
189 - ::OpenFile now writes a verbose message when file cannot be opened.
190 - some std::string properly set to VRKey
191 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
192 references to gdcmDocument.
193 * Test/TestFindTags.cxx: changed accordingly to above changes.
194 * gdcmPython/testSuite.py: adapted to renaming of acr files in
195 cvs repository gdcmData.
197 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
199 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
200 conflicts with gdcmValEntry::voidArea.
201 * src/gdcmValEntry.cxx: unmatching comment wiped out.
202 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
203 Value representation between StringRepresentable and BinaryRepresentable.
204 * src/gdcmDocument.cxx:
205 - method ParseDES: proper indentation restored and usage of
206 gdcmVR::IsVROfGdcmStringRepresentable wired in.
207 - method LoadDocEntry: the fingerprint left in the SetValue() of
208 unloaded entries (length > MaxSizeLoadEntry) had curiously been
209 removed. Reverting to previous code segment with the proper
210 dynamic_cast< gdcmValEntry* >.
211 Note: this was (partially) breaking the python test suite
212 (gdcmPython/testSuite.py) that made usage of the above
213 fingerprint to check presence of "Pixel Data".
214 * src/gdcmDocEntry.h: coding style.
215 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
216 now taken into account.
217 * gdcmPython/gdcm.i: adaptation to the new internal representation
218 of gdcm (exit gdcmParser, hello gdcmDocument).
219 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
221 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
222 anymore, but instead prints the loaded Python dictionary.
223 * .... alas, the python testSuite is still broken.
225 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
228 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
229 * src/gdcmUtil.h : export methods
231 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
234 * Initial addition of automatic python testing
235 * Initial addition of automatic image comparison
237 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
239 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
241 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
242 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
243 * Test/ShowDicom.cxx : bug fix for msvc compilation
244 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
246 2004-05-04 Jean-Pierre Roux
247 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
248 new concepts (and new classes) :
249 a 'gdcmDocument' is composed of a set of Doc Entries, that are
250 - elementary gdcmDocEntries (former gdcmHeaderEntries)
251 - Sequence Doc Entries (gdcmSeqEntries)
252 a Sequence is composed of Items.
253 Each item is a set of Doc Entries (this is recursive)
254 The non uniqueness of the 'Dicom tag' is due to this recursivity
255 (never taken into account)
256 Our unability to add a new 'entry' in the header
257 at the proper location (neither in the H-Table (map or multimap),
258 nor in the Chained List is also due to this recursivity.
259 Don't try, right now, to use/modify/compile these new sources :
261 We just commit all the stuff, 'as is', in order not to loose it.
263 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
264 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
266 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
268 file prefix (SetFilePrefix)
270 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
271 * Add a new test: ShowDicom, for now this is just the c++ version of
272 checkRead.sh, later it will be able to compare the image read against a
274 * Replace the DEBUG on the stack with a global entry in cmake interface:
275 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
277 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
278 * Add an example subdir, with a real example on how to read + write a
281 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
282 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
283 * Doc/CMakeLists.txt: the main page is now properly differentiated
284 between the developper and user version.
285 * Doc/doxygen.config.in: dropped search related obsolete flags
286 * src/gdcmParser.h, gdcmHeader.h: doxygenation
288 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
289 * DEVELOPPER: added some helpfull comments for compile/test/install
292 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
293 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
294 src directory, now generated in the build dir.
295 2. Tests as mentionned smarter
297 4. Add a new method in gdcmDict that return the PubDict by name
298 this is interesting for 3rd party lib like ITK,
299 where we could set the institution name / patient name...
301 * ENH: 1. Now the test suite is working for real
302 2. All binaries are now output in the gdcm-bin directory
303 (this was not true before)
305 2004-04-28 Jean-Pierre Roux
306 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
307 SeQuence indented printing of Dicom Header.
308 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
309 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
310 Computation of SQDepthLevel is now part of gdcmHeader constructor
311 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
312 tree-like structure of a Dicom Header.
313 * FIX Test code cleaning
315 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
316 * ENH: Adding automatic testing
317 1. Need a DartConfig.cmake to submit to public
318 2. Add a test driver gdcmTest.cxx
319 3. gdcmTestMain, an helper for the main test driver gdcmTest
320 4. Files in Test don't have a main anymore, this becomes interesting
321 when we add more and more tests, thus dsw don't have to load
323 * ENH: Adding a GDCM_DATA_ROOT for testing
324 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
325 one file instead of seven + some small cleanup
327 2004-04-22 Jean-Pierre Roux
328 * ENH Minor changes to the Print() methods.
329 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
330 Header printing. Example given with :
331 > PrintHeader fileName 2 new
332 (SQ based tree-like structure still to be done for the Header ...)
334 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
335 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
336 1. I have added some unsigned where needed
337 2. Some function parameter not used -> (void)
338 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
339 4. g++ don't like character '\' in comment
340 5. #define jpeg_create_decompress jCreaDecompress
341 this really need to be fixed
342 6. virtualize destructor of gdcmObject ... leakage
343 7. sscanf(g->first.c_str(),"%x",&gr_bid);
344 this also really need to be fixed
345 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
346 remove compression file
347 (as we only do decompression, right ?)
348 * ENH: Change malloc/calloc/free with c++ equivalent
350 2004-04-21 Jean-Pierre Roux
351 * FIX gdcmHeaderHelper::GetXSpacing
352 when a single value is found (bug ?), xpacing is now
353 defaulted to yspacing
355 2004-04-19 Jean-Pierre Roux
356 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
357 * ENH add parameters :
358 bool exception_on_error = false,
359 bool enable_sequences = false,
360 bool ignore_shadow = false
361 to the gdcmFile constructors to be full gdcmParser compliant
362 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
363 to allow reading of PAPYRUS 3.0 files
365 2004-04-06 Jean-Pierre Roux
366 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
368 2004-04-02 Jean-Pierre Roux
369 * ADD : Test/checksequence.sh, for a general recap on SQ pb
370 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
371 for Philips spurious Tag fffe|0000 while rewritting Dicom files
373 2004-03-30 Jean-Pierre Roux
374 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
375 for ACR file, written out as DICOM files (hope so...)
377 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
378 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
379 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
380 moved to base class gdcmParser and only the specialisation is kept
382 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
383 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
384 already does the job.
385 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
386 (to be consistent with gdcmParser::WriteEntries).
388 2004-03-30 Benoit Regrain
389 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
390 upate of the object's instance. It's passed to 2 in the unfavorable
391 case : one in the ExecuteInformation, one in the ExecuteData
393 2004-03-29 Jean-Pierre Roux
394 * ENH : Check on file type to be written moved
395 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
396 * FIX : gdcmObject::ResetBoundaries now stops properly
397 when end-of-list is reached
398 : gdcmVersion modified (as Benoit Regrain asked)
400 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
402 * src/gdcmUtil.cxx: added forgotten iostream include.
403 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
404 equivalent to ExplicitVR in existing code).
406 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
408 now contains all the gdcmGlobal related code.
409 * minor coding style and doxygenation changes.
411 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
413 now contains all the Debug related code.
414 * minor clean-up of includes in src/*.cxx
415 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
416 CreateCleanString) removed.
417 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
418 * Doc/DoxyMainPageUser.txt added.
419 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
420 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
423 2004-03-24 Jean-Pierre Roux
424 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
426 2004-03-23 Jean-Pierre Roux
427 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
428 big endian made volumes
429 * ENH Now gdcmParser constructor and destructor are protected to forbid
430 end user to instanciate class gdcmParser
431 (only gdcmHeader and gdcmDicomDir are meaningfull)
433 2004-03-22 Benoit Regrain
434 * FIX : src/gdcmDicomDir.cxx : make windows compilable
435 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
436 gdcmSerie to gdcmDicomDirSerie
438 2004-03-19 Jean-Pierre Roux
439 * ENH Now the tree-like structure describing a DICOMDIR comming from
440 an already existing DICOMDIR file is consistent with
441 the home-made tree-like structure build ex-nihilo
442 or build from the files held (recursively) in a Directory
443 functions gdcmDicomDir::CheckBoundaries()
444 gdcmObject::SetBoundaries() added
446 2004-03-17 Jean-Pierre Roux
447 * REM (Eric Boix bug) : removal of meaningless
448 gdcmDicomDirImage::NewImage function.
449 * FIX now file names and directory name are written properly in the
451 * FIX now gdcmDicomDir constructor may be call without any trick
454 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
456 of gdcmDicomDirImage::NewImage as empty function.
458 2004-02-28 Jean-Pierre Roux
459 * ENH add gdcmDicomDir:NewPatient
460 add gdcmDicomDirPatient:NewStudy
461 add gdcmDicomDirStudy:NewSerie
462 add gdcmDicomDirSerie:NewImage
463 to allow making gdcDicomDir object.
464 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
465 (as opposite to the gdcmHeader chained list)
467 2004-02-11 Benoit Regrain
468 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
469 when using from python
471 2004-02-10 Benoit Regrain
472 * FIX : bug fix in the gdcmDirList for the recursivity in directories
473 * FIX : in gdcmDicomDir when the directory is empty
474 * ENH : add callback and methods to get the progression of dicomDir
477 2004-02-06 Jean-Pierre Roux
478 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
479 - GDCM_META added to gdcmDicomDirType
480 - class gdcmMeta created
481 * ENH : - A brief summary is now displayed at the beginning of
482 'testDicomDir' to help disaster magnitude estimation
483 * REM : Now useless Test/explDICOMDIR.cxx
485 2004-02-05 Benoit Regrain
486 * ENH : add methods in gdcmObject to get the hash table or the list of
488 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
489 * FIX : wrapping python for TagHeaderEntryHT
491 2004-02-04 Benoit Regrain
492 * FIX : even length for some strings when writting the dicom dir
493 * FIX : sort the images in the dicom dir
494 * FIX : Bug fix for python use of dicom dir
495 * ADD : a python demo
497 2004-02-04 Jean-Pierre Roux
498 * FIX : Final solution (?) for icone embedded images
499 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
500 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
501 add groups 6002, 6004, 6006, to allow 'clean' parsing of
502 gdcmData/gdcm-MR-SIEMENS-16.acr1
503 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
504 to make full checking easier
506 2004-02-04 Benoit Regrain
507 * FIX : WriteEntries : coding style & logic in parameters
508 * FIX : Set the elements to create the DicomDir in a dictionary file
510 2004-02-03 Benoit Regrain
511 * gdcmDirList : to parse a hard drive directory in recursive (or not)
512 * gdcmDicomDir : add the load of directory
513 * Bug fix and print add-on
515 2004-02-03 Jean-Pierre Roux
516 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
517 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
518 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
519 * FIX gdcmParser.cxx : 'group length' elements are now considered
520 as integers, even for shadow groups, when file is Implicit VR
522 2004-02-02 Jean-Pierre Roux
523 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
525 of the last synonym :-(
526 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
528 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
529 * FIX taking into account the possible 7fe0,0010 multiplicity
530 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
531 to allow removal of references to 7fe0,0010, to deal with
532 ACR-NEMA images, when 0028,0200 is meaningfull
534 2004-01-31 Jean-Pierre Roux
535 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
536 no longer writes 'Un' on disk
537 * FIX SQ elements with actual length are now dealt with corectly
538 * FIX gdcmFile::WriteBase make the difference, for color images, between
539 the length (for Palette expanded images)
540 and Raw Length (non expanded image + Palette)
541 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
542 (that broke Write). Replaced by UL.
543 Aware user will reload the field if he
544 thinks it's necesssary
546 2004-01-30 Jean-Pierre Roux
547 * gdcmParser::CheckSwap() now defaults the filetype to ACR
548 when 'dirty Acr' is found, to be compliant with the new
549 IsReadable() methods.
551 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
552 (no DOUBLE images in kosher DICOM,
553 but so usefull for people that miss them ;-)
555 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
556 DICOMDIR related utilities (not checked as Windoze compliant)
558 2004-01-28 Jean-Pierre Roux
559 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
561 2004-01-27 Jean-Pierre Roux
562 * gdcmParser constructor has a new boolean param,'ignore_shadow',
563 to allow skipping the shadow elements, to save memory space.
564 The TRUE value for this param has to be used
565 with a FALSE value for the 'enable_sequence' param.
566 ('public elements' may be embedded in 'shadow Sequences')
567 * gdcmHeader methods now deal with 'embedded icones images' in the header
568 (even when an 'icone image sequence' is announced by the
569 element (0x0088,0x0200), but there is NO icone at all ...
571 * gdcmHeader sometimes Image Location value doesn't follow
572 the supposed processor endianity (see gdcmData/cr172241.dcm).
575 * gdcmHeader add the method
576 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
577 to get *all* the Header Entries with the same tag.
578 GetHeaderEntrySameName is probabely *useless*
579 (no meaning : Name is *not* an identifier within the Dictionnary)
581 2004-01-26 Benoit Regrain
582 * Bug fix in the print of hexadecimal representations. Remove long fields
583 in the print and add a third level of print to print them
585 2004-01-23 Benoit Regrain
586 * Bug fix on field having a VR = 'UI'. Assume that is a string field
587 * Bug fix on test suite after remove the strip made on not string fields
588 * Split the IsReadable method between gdcmParser which test that the file
589 is dicom and gdcmHeader which test that it's an image file
591 2004-01-22 Benoit Regrain
592 * DicomDir : clean code, add methods, set variables in protected or private
593 * gdcmUtil : bug fix for the clean string method
595 2004-01-19 Benoit Regrain
596 * Add the use of shadow dictionaries
597 * bug fix and coding style
599 2004-01-19 Benoit Regrain
600 * src/gdcmFile.cxx : bug fix concerning the close of file
601 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
602 * Add the update of header entries using the shadow library
604 2004-01-19 Benoit Regrain
605 * removal of file gdcmHeader2.cxx
606 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
607 inheriting from gdcmParser. This split is to prepare the integration
609 * bug fix under python
611 2004-01-16 Jean-Pierre Roux
612 * REM removal of class gdcmHeaderEntrySet
613 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
614 * ADD add file gdcmHeader2.cxx
615 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
617 2004-01-15 Benoit Regrain
618 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
619 entries created while parsing the header. Thus, they will be destroyed
620 when the gdcmDictSet will be destroyed
621 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
624 2004-01-15 Benoit Regrain
625 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
626 made a fatal error because of the memory release at the end of program.
627 The problem was in vtkGdcmReader::ExecuteData where we were allocate
628 some memory and vtk seems to have some problems with that.
629 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
631 2004-01-14 Benoit Regrain
632 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
633 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
634 * src/*.[h|cxx] : make changes due to class name changes
635 * gdcmPython/demo/*.py : bug fix due to method names
637 2004-01-13 Benoit Regrain
638 * src/*.[h|cxx] : coding style
639 * vtk/*.[h|cxx] : coding style
641 2004-01-13 Benoit Regrain
642 * gdcmPython/testSuite.py : test the readable flag of file for tests
643 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
644 It's lied to the stl compilation by MSVC (windows, always windows...)
645 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
647 2004-01-12 Benoit Regrain
648 * src/*.h : add comments
649 * src/gdcmDictSet.h : set the method BuildDictPath in public
650 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
651 directly setted in the source code
652 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
655 2004-01-09 Benoit Regrain
656 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
657 * setup.py : use a reference to gdcmVERSION
659 2004-01-07 Benoit Regrain
660 * Modification to compile with the distutils.
663 2003-12-10 Benoit Regrain
664 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
665 can use a gdcmHeaderHelper to load datas
666 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
667 made in the source code
669 2003-12-10 Benoit Regrain
670 * Update Windows projects and .cvsignore files
672 2003-11-12 Jean-Pierre Roux
673 * ENH gdcmHeader constructor has one more parameter (default value : false)
674 that allows the user to 'go inside' the SeQuences only
676 gdcmElValSet:Print takes it into account
678 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
679 * ENH: Update gdcmPython/CMakeLists
680 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
681 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
683 2003-11-10 Jean-Pierre Roux
684 * FIX : gdcmHeader::LoadElements is now based
685 on the ListTag listElem member,
686 not longer on the TagElValueHT tagHt member
687 * ENH : PrintPubElVal shows (temporarily) both results,
688 with the tagHt member and the listElem member.
689 (it's easier to 'see' the problems when using Printheader)
691 * FIX : old private member LgrElem is now splitted into
692 ReadLength : Length actually found on disk (updated only
693 if bug fixing is necessary), for internal
695 UsableLength : Updated by FixFoundLength, to fix a bug
696 or to allow Parser going on.
697 Will allow to re-write a kosher header when a SeQuence
698 with a length (not 0000) is found
699 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
700 because gdcmElValSet::Add does not update ListElem
703 2003-11-07 Jean-Pierre Roux
704 * FIX misstyping in Transfert Syntax name table
705 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
706 when they have an actual length (not 0000 nor FFFFF)
707 (Nobody should care of it, but DICOMDIR explorers)
709 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
710 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
712 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
713 * ENH: vtkGdcmReader now supports LUT !
714 (vtkgdcmViewer for now is not able to use them though)
716 2003-11-05 Jean-Pierre Roux
717 * in testSuite.py : new files names for checking the package
718 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
719 that returns the pixel area size to the *aware* (vtk) user
720 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
722 2003-11-05 Benoit Regrain
723 * in testSuite.py : Modify the rules for checking the paths
724 : Explicit error messages
725 * in __init__.py : Related modif
727 2003-11-03 Jean-Pierre Roux
728 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
729 to be used by aware (vtk) users that want to manage
730 LUT (and no to turn the PALETTE image into an RGB pixels one)
731 * GetPixelType now returns 8U for 24 Bits images
732 (vtkGdcmReader compliant)
734 2003-10-31 Jean-Pierre Roux
735 * Removal of *all* gdcmData images and add them again
736 in order to loose the 'history' of un-anonymised images
738 2003-10-31 Jean-Pierre Roux
739 * RMV : removal of useless jBitsInJsample.h
740 for both 8 and 12 Bits JPEG Lossy Libraries
742 2003-10-31 Jean-Pierre Roux
743 * ENH : Add the functions gdcmFile::GetImageDataRaw
744 gdcmFile::GetImageDataIntoVectorRaw
745 that act as GetImageData and GetImageDataIntoVector
746 except the making of an RGB Plane from Gray Plane + LUT
747 Intended to aware (vtk) users who know how to manage
750 GetLUTRGBA return a R,G,B,A LUT if any
751 lgrTotaleRaw gives the 'Raw' length
752 GetImageDataRaw returns the gray Plane
753 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
754 (They stay Grey, just like with other Dicom viewers :-(
756 2003-10-30 Jean-Pierre Roux
757 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
759 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
760 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
761 being coherents dicom files.
763 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
764 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
766 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
767 * ENH: Two steps is necessary to please VC++ compiler...
768 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
769 * ENH: Add include dir to medcon lib
770 * FIX: only one function is being exported for now !
771 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
773 2003-10-29 Jean-Pierre Roux
774 * adding gdcmHeader::GetLUTRGBA
775 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
776 --> Mathieu, the modif u're waiting for is not yet committed
777 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
779 2003-10-27 Jean-Pierre Roux
780 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
781 00191113.dcm DermaColorLossLess.dcm
782 MxTwinLossLess.dcm RadBWLossLess.dcm
783 * ENH: For version prior to vtkImageViewer2 -r 1.19
784 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
786 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
787 * Removal of ido stuff in CMakeLists.txt
789 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
790 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
791 * FIX: remove a call to ->Modified ... see comments
792 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
794 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
795 * FIX: Problem with path for libvtkgdcmPython
796 * ENH: Try adding a search script for python site-package
797 * RMV: Remove some file from medcon lib that are not necessary
798 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
799 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
800 * FIX: More pragma disable fro VC++,
801 I don't think I break something as it is also disable in VTK/ITK.
802 But it fasten debug compilation time.
804 2003-10-23 Jean-Pierre Roux
805 * gdcm now deals with 16 Bits Run Length Encoded images
806 (they are compressed as 2 planes images,
807 one for the high Bytes, the other for low Bytes)
809 2003-10-22 Jean-Pierre Roux
810 * Now CheckRead takes into account :
811 - the bugged 'Leonardo' Siemens images
812 - the XA images, sent thru the burning VPRO station
813 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
816 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
817 * FIX: When copying a Makefile.am to CMakeLists.txt
818 one should remove the '\'
820 2003-10-22 Jean-Pierre Roux
821 * in gdcmData adding a bugged 'Leonardo' Siemens image
822 (wrong lengths in header)
823 OK with gdcm, KO with the other viewers :-)
824 * add a GE dlx XA image, thru the VEPRO burning station
827 2003-10-21 Jean-Pierre Roux
828 * in gdcmData add the checkvtkgdcmViewer.sh shell script
829 for a brutal checking of vtkgdcmViewer compliance
831 2003-10-21 Jean-Pierre Roux
832 * add the files for 'xmedcon' Jpeg Lossless library
833 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
835 2003-10-21 Jean-Pierre Roux
836 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
838 2003-10-21 Jean-Pierre Roux
839 * garbage Siemens 'Leonardo' images dealt with
840 (the patch is easy to remove)
841 * cosmetic changes to avoid warnings
843 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
844 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
845 no need to press 'r' now.
847 2003-10-20 Jean-Pierre Roux
848 * upgrade of checkRead.sh checkWrite.sh according
849 to new Jpeg Lossless decompressor
850 * add US.3405.1.dcm, a genuine RGB medical file ...
851 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
852 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
854 2003-10-15 Jean-Pierre Roux
855 * general anonymisation in gdcmData
856 * adding the 'color files' from
857 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
858 * adding some well knowed bugged-header images
859 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
860 waiting for their inclusion in Python testsuite
862 2003-10-15 Jean-Pierre Roux
863 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
864 no longer seg faults when file is not found
866 2003-10-14 Jean-Pierre Roux
867 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
870 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
871 * TODO: *.in file to genereate a UseGDCM later
873 2003-10-14 Jean-Pierre Roux
874 * Some supposed-to-be Dicom Images have no preamble.
875 OpenFile takes it into account
876 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
877 * Missing elements added in dicomV3.dic
878 (just to be affraid : have a look at
879 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
880 and do it again next year ;->
882 2003-10-13 Jean-Pierre Roux
883 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
884 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
885 But there are NOT. It's fixed !
887 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
888 * FIX: "jpeglib.h" was not found on VC++
889 * FIX: vtkgdcm was not being installed
891 2003-10-10 Jean-Pierre Roux
892 * ENH : OpenFile closes the file if it *really* doesn't look like
893 an ACR-NEMA / DICOM one.
894 * FIX : testWrite no longer writes an empty file if the source file
896 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
899 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
900 * FIX: CMake generate now documentation
901 * ENH: out of source doc build !
902 * ENH: Generate both user and dev documentation
903 * ENH: Should work on windows too
904 * ENH: Only one doxygen config.in file is needed
905 * FIX: make install should be ok now on ùnix plateform
906 * FIX: PATH to dictionary was wrong (missing /)
907 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
909 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
910 * vtkGdcmReader is now able to read rgb dicom file.
911 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
912 * added a gdcmViewer to vtk test, use mouse to control
913 window level & window width
915 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
916 * CMake-ification of gdcm, we have now two build system
917 * FIX: on cygwin Wsock32 doesn't exist
918 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
920 2003-10-06 Emanuel Ollart
921 * FIX : compilation process wad broken.
922 Changed gdcmViewer_sources to vtkgdcmViewer_sources
924 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
925 * change gdcmViewer -> vtkgdcmViewer
926 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
928 2003-10-06 Jean-Pierre Roux
929 * FIX :A few nasty patches to allow the reading of a lot of nasty images
930 ( e.g : well known GE images with a wrong elem length,
931 : Philips MRI Images with a wrong Huffman table)
932 * still to be done : allow the reading of bugged LEONARDO Siemens images
934 2003-10-03 Jean-Pierre Roux
935 * Odd length strings are padded with '\0' (not with spaces,
936 to remain compliant with already defined strings,
937 like Transfert Syntax UID and others)
939 2003-10-03 Jean-Pierre Roux
940 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
941 to allow displaying RGB images (not only by affim ;-)
943 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
944 * vtkGdcmReader is now able to read rgb dicom file.
945 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
947 2003-10-03 Jean-Pierre Roux
948 * A few nasty patches to allow the reading of a lot of nasty images
949 ( e.g : well known GE images with a wrong elem length,
950 : Philips MRI Images with a wrong Huffman table)
951 * still to be done : allow the reading of bugged LEONARDO Siemens images
953 2003-10-03 Jean-Pierre Roux
954 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
956 2003-10-03 Jean-Pierre Roux
957 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
958 to allow displaying RGB images (not only by affim ;-)
960 2003-10-03 Jean-Pierre Roux
961 * gdcmFile::GetImageDataIntoVector now
962 - deals with MultiFrames MultiFragments Run Length Encoded files
963 - deals with YcBcR (YBR_FULL) files
964 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
965 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
969 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
970 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
971 Two reasons: - clear things
972 - third parties acces gdcm through header files, so won't
973 suffer anymore VC++ complains
975 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
976 * add argv[1] in testvtkGdcmReader.cxx
979 2003-09-24 Jean-Pierre Roux
980 * The lines are now eigthy characters long.for
981 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
983 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
984 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
985 char* to std::string. Thus, the use of strdup becomes useless. (see
986 previous commis of Malaterre)
987 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
988 before the last Malaterre's commit.
990 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
991 * This commit should fix the Debug building under VC++, the problem
992 was mainly a mixture of debug and release lib being loaded at startup.
993 * I also remove a depency to a specific C function: strdup. Because I had
994 to force the link to msvcrtd (whereas strdup is in libc).
996 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
997 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
998 located in the gdcmCommon.h file. All use of reference of tha has been
999 changed to now use the variable GDCM_UNFOUND.
1001 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1003 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1004 Dicom dictionary. The test suite can now be run again. Note:
1005 I'm note very happy with the " (RET)" changes. I believe this
1006 RETAINED comment should be dropped when parsing the dictionary.
1007 - PACKAGER corrected
1009 - AUTHORS updated and now in alphabetical order
1010 * Makefile.am now exports gdcm.dsw for Windoze users.
1012 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1013 * cygwin complains about missing std:: in subdir Test/
1015 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1016 * remove some methods that are now in gdcmHeaderHelper
1018 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1019 * vtkGdcmReader set spacing and origin correctly
1021 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1022 * Fix a few delete/delete[] mismatch
1024 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1025 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1026 interpretation to data given by gdcmHeader. For instance there are
1027 heuristics to get informations (look at different places).
1028 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1029 sorting DICOM images based on different strategies.
1030 * modified Makefiles accordingly.
1032 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1033 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1034 when building in debug mode
1035 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1036 src/win32/gdcmdll.dsp
1037 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1039 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1040 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1043 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1044 * src/win32/libgdcmjpeg12.dsp was not dos format
1045 * src/win32/libgdcmjpeg12.dsp :
1046 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1047 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1049 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1050 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1052 * src/gdcmFile.cxx : bug fix in affectation type
1053 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1054 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1055 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1056 symbols... future problem ?
1058 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1059 * src/win32/libgdcmijpeg12.dsp was missing
1060 * modified gdcm.dsw accordingly
1062 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1063 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1065 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1066 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1067 commit of JPR (before his hollidays to facilitate our work).
1068 * setup.py : bug fix in code. Modifications made while the last commit
1069 of JPR. The code hasn't been tested before the commit... it's so
1070 useless to make that (for best programmer that is JPR) !!!
1072 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1073 * tagged the current version as Version0_3 (i.e. version 0.3)
1075 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1076 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1077 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1078 * *.dsp : modifications to use new libgdcmijpeg8 library
1079 * setup.py : bug fix on VTKPATH variable
1080 * PACKAGER : adding all concerning windows
1082 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1083 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1085 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1086 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1087 test suite reported error.
1088 * PACKAGER file added (describes what a packager must do when
1089 packaging a new release).
1090 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1091 * configure.in: upgraded version number to 0.3.0
1092 * fixing build of rpm (through rpm -ta):
1093 - Doc/Makefile.am exports proper doxygen files
1094 - src/jpeg/libijg8/Makefile.am exports the include files.
1096 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1097 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1098 * src/gdcmHeader.h : formatting code
1100 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1101 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1102 We were obtaining error message from vtk. Now, creation of file list
1103 is made in an internal list to prevent this problem.
1104 Bug fix when output is empty.
1105 Bug fix in update of progress value. Previous commit for this was a bad
1107 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1109 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1110 * src/gdcmHeader.h : added method to get the file name
1111 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1112 files. Added method to remove all files on the input
1113 Added FIXME comment concerning the bad parsing of header made by
1114 ExecuteInformation method (in ExecuteData method)
1116 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1117 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1118 when using make instal.
1119 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1120 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1122 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1123 * setup.py : adding include dir of jpeg lib to compile all sources
1124 * */Win32/*.dsp : JPR fix for windows compilation
1126 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1127 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1129 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1130 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1132 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1133 * setup.py is again effective on un*x (takes into account the
1134 addon of the jpeg library)
1135 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1136 * Doc/Doxy* updated (includes above enhancements)
1137 * INSTALL now points to web documentation
1139 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1140 * src/gdcmHeader.h doesn't make unnecessary reference to
1142 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1144 * src/gdcm*.[cxx|h] :
1145 - to allow compilation with gcc 3.x
1146 -- clean up of STL usage (added explicit usage of std::)
1147 -- small fixes on exceptions.
1148 Note: linking not tested !
1149 - clean of doxygen comments to avoid warnings at documentation
1151 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1152 dependent convertion).
1154 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1155 * Clean up of previous JPR garbage commit (not even commented in the
1157 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1158 - moved all jpeg related files from src to src/jpeg/libijg8, with
1159 addition/modification of Makefile.am and configure.in.
1160 - the testSuite is still brain damage (not guilty).
1162 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1163 * WrapVTK.py : modifications to get correctly vtk source files to
1165 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1166 (FileName -> Filename)
1168 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1169 * vtk/vtkGdcmReader.[cxx/h]:
1170 - UpdateProgress method should now be effective
1171 - removed the limitation on having only images loaded (as opposed
1173 - when building a stack of images/volume, a lesser number of
1174 gdcmHeader and gdcmFile instances should be used (hopefully
1175 accelerating things).
1176 - when building a stack of images/volumes, files which are not
1177 loadable (wrong path-filename, wrong permissions on existing file,
1178 or file not parsable by gdcm) are replaced with a black image
1179 in the stack (for the caller to notice the problem).
1181 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1182 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1184 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1185 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1186 between standard library (std) and vtk library (problems are found
1187 under Windows... thanks Windows !)
1189 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1190 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1192 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1194 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1195 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1197 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * When compiling with distutils (see setup.py) the C++ compiler is
1199 called with different flags than the default ones (with automake).
1200 In order to fix all those warning, I compiled gdcm with the command
1201 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1202 and went for warning fixes:
1203 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1204 up from unused variables.
1205 - vtk/vtkGdcmReader.cxx: potential bug fix.
1206 * src/gdcmHeader.h: Doxygen warning cleanup
1208 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1209 * gdcmPython/gdcm.i:
1210 - typemaps correction to take into account the systematic replacement
1211 of "using namespace std" with std:: prefix e.g. std::list,
1212 std::string... (cf changes of 2003-05-21).
1213 - gdcmGlob global variable of type gdcmGlobal (defined in
1214 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1215 exported to Python a as cvar.
1216 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1217 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1218 gdcmDictSet.GetPubDictTagNames() and
1219 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1220 C++ static methods).
1221 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1222 with the above changes.
1224 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1225 * setup.py, manifest.in : bug fix under linux
1227 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1228 * Modification of setup.py to compile vtk part too. Then, we have 2
1229 wrappers which must work with same distutils. For that, we have a
1230 generic distutils in distusiltsWrapping.py ; with :
1231 - build_extWrap class to wrap generically all extensions,
1232 - ExtensionWrap base class for all wrapping extension that contains
1234 - Wrapper interface which wrap sources
1235 + In WrapSwig.py we have extension and wrapper for Swig
1236 + In WrapVTK.py we have extension and wrapper for VTK
1237 * MANIFEST.in : modifications to consider vtk directory and new python
1238 files for compilation
1240 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1241 * Added python wrappers of vtkGdcmReader vtk class (see the
1242 source in vtk/vtkGdcmReader.cxx) :
1243 - vtk/Makefile.am now builds a library
1244 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1245 python library (as opposed to _gdcm.so wich are the python
1246 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1247 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1249 - configure.in has an additional flag --enable-vtk that needs
1250 to be set to enable compilation of vtk related code, that is:
1251 + vtk/vtkGdcmReader.so and
1252 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1253 + gdcmPython/vtkgdcmPython.so (see above)
1254 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1255 be read when compressed or when HighBit + 1 != BitsStored),
1256 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1257 the usage of the python wrapper of vtkGdcmReader vtk class.
1258 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1259 * src/*.[h] all occurences of stl classes are now prefixed with
1260 std::, and all occurences of "using namespace std;" where removed.
1261 This is to avoid pollution of global namespace in included files.
1262 Apparently vtk does not avoid this pitfall: when using both
1263 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1264 collision of various stl members (principally cout...).
1265 * gdcmPython/testSuite.py now cleanly removes temprory generated
1267 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1268 comply with above changes)
1270 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1271 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1272 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1273 vtk data structure (an image Flip was required).
1274 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1275 * cosmetic changes in documentation.
1277 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1278 * src/gdcmHeader.cxx: the constructor no longer exits when an
1279 unexisting file is given as argument.
1280 * The subdirectory Data (containing all the images used for the
1281 test suite) is not part of this repository anymore. A new module
1282 containing those images is now available at
1283 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1284 with the name gdcmData.
1285 All the python scripts (including the package initialisation file
1286 gdcmPython/__init__.py) were adapated to take this change into
1287 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1289 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1290 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1291 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1292 demo of the usage of this class.
1293 Compilation of this vtk part is only done when using the --enable-vtk
1294 at configure (or autogen.sh) stage.
1296 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1297 * More memory link related corrections and documentation fixes.
1299 - maximum info is obtained with a command of the form:
1300 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1301 --show-reachable=yes PrintHeader
1302 - the remaining reachable blocks seem to come from the STL
1303 allocation scheme through the usage of map and list. It looks
1304 like this memory cannot be freed but it is not a memory leak
1305 (in fact further invocation to the STL would recollect the
1306 unused memory allthough it cannot explicitely be freed).
1307 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1308 of displaying an image parsed with gdcm and displayed with VTK.
1309 Note: some images don't seem to work e.g.
1310 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1311 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1312 Allthough this weakens the semantics, it is a ditch attempt to
1313 make gdcm more thread friendly.
1315 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1316 * Memory link hunt (by using valgrind through the command
1317 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1318 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1319 gdcmHeader::_dicom_vr.
1320 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1321 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1323 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1325 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1326 * src/Makefile.am now exports all the necessary include files at
1330 * UpdateGroupLength replaced by new one
1333 * UpdateGroupLength re-written using H-Table
1334 (named UpdateGroupLengthNew untill checks are over)
1336 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1337 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1338 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1340 - gdcmHeader::GetPubElValSet removed.
1341 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1342 UpdateGroupLength, WriteElements, Write.
1343 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1344 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1345 carried the same semantics.
1346 - src/gdcmHeaderIdo.cxx changed accordingly.
1347 - gdcmFile::WriteBase now regroups all the codes from previous
1348 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1349 - enum FileType moved to gdcmCommon.h
1350 * src/gdcmHeader.cxx AddDefault trashed
1351 * gdcmGetXSize added
1352 * getimageDataSize now calls gdcmGetXSize
1353 * Test/*.cxx changed to agree with above changes
1355 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1356 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1357 (to avoid double call by end user).
1358 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1359 by end user, since gdcmHeader::gdcmHeader now handles it.
1361 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1362 * gdcm/Doc many doxygen changes:
1363 - Doxyfile now has two different versions, DoxyfileUsers that generates
1364 the html.users end users oriented documentation and
1365 DoxyfileDeveloppers that generates the html.developper developper
1366 oriented documentation.
1367 - README changed accordingly
1368 - requirement.txt removed (old design info moved to TODO).
1369 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1370 DoxyMainPage.txt, DoxyPython.txt provide more information.
1371 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1372 be updated by simply regenerating the docs with doxygen and copying
1373 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1374 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1375 all the tests in the form "if (<map>.count() >1)" were removed.
1376 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1377 ill-formed documentation sections.
1378 * src/gdcmHeader.cxx: ditto
1380 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1381 * setup.py fixed for un*x (needed macro for stdint.h)
1382 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1383 un*ces with sh-utils test utility.
1384 * gdcmPython/demo/test.py renamed to PrintHeader.py
1385 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1386 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1387 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1388 * src/gdcm*.cxx JPR's bad inclusion fixed.
1390 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1391 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1392 * gdcmPython/demo/test.py changed accordingly.
1394 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1395 * gdcmPython/Makefile.am fixed linking against libstdc++
1396 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1397 * Swig subdir (historical tests of swig version 1.3.17++) removed
1398 * Test/testChangeEntete.cxx some lines commented out in order to make
1400 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1401 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1403 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1404 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1405 hence the user doesn't need this explicit call.
1406 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1407 i.e. LoadElements() call removed.
1408 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1409 - src/Makefile.am declares the proper flag for g++.
1410 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1411 for adding user defined new tags.
1412 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1413 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1414 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1416 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1417 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1418 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1419 src/Makefile.am : the project should properly compile and install
1420 with the autotools, included the python wrappers part.
1421 * gdcm.spec.in : added a spec file for RPM packaging.
1423 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1424 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1426 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1427 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1428 to exported to the environement (see gdcmPython/testSuite.py
1430 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1431 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1432 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1433 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1434 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1436 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1437 * gdcmPython/__init__.py doesn't crash anymore when running in
1438 in InstallMode or PreInstallMode but with an environement given
1439 value of GDCM_DICT_PATH.
1440 * src/gdcmDictSet.[cxx/h] coding style.
1442 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1443 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1444 * src/gdcm.h general comments moved to TODO, and README
1445 * src/gdcm.h should now be seen as a user commodity (including it
1446 should suffice to fully use gdcm). It is nowhere including within
1447 any of the kernel files src/*.cxx and src/*.h.
1449 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1450 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1451 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1453 * src/gdcm*.cxx only include their corresponding include file
1454 (as opposed to gdcm.h)
1455 * gdcmPython/gdcm.i changed accordingly
1456 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1457 the autogen.sh generated "make snapshot" command to work.
1458 * autogen.sh removed history related references to crea package.
1460 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1461 * distutilsSwigCPlusPlus.py work around some swig portability
1464 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1465 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1466 was done in a last ditch attempt to get setup.py _really_
1467 operationnal. The python/gdcmPython layaout add the advantage
1468 of hidding away the python related distutils specific files
1469 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1470 Alas, the src directory was out of scope (i.e. it's relative
1471 position to setup.py was ../src) which made things impossible to
1472 handle (see previous version of python/setup.py). Crossing fingers...
1474 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1475 * python/setup.py now works on Un*x. (harder than I thougth)
1476 * python/distutilsSwigCPlusPlus.py can now have include files
1477 among the list of sources.
1479 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1480 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1481 * modifications in MSVC projects
1483 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1484 * As stated by the first lines of Test/ExceptionAndPython/README, it
1485 looks like we can move back to original usage of exception within
1486 src/gdcm* and hence remove the errno stuff that was introduced
1487 as a quick and dirty fixture of this problem (added to the TODO).
1488 * Doc/Doxyfile configuration file for Doxygen and corresponding
1489 README file for usage added.
1490 * Test/testWrite.cxx added. This new test comes from a split of
1491 test.cxx that is now reverted to its original purpous i.e.
1492 testing the proper parsing of a Dicom related file.
1493 testWrite.cxx concentrates on testing the IO part of gdcm.
1494 * Test/bug1.cxx (containing a bug on WIn32) added.
1495 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1496 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1497 whose purpose is to publish the content of the TagNames of the
1498 Dicom public dictionnary were not accessible without an
1499 instance of class gdcmHeader.
1500 - those methods are now static methods of gdcmDictSet and hence
1501 require no instances at all to be invocated.
1502 - within gdcmDictSet this change required to change some method
1503 to class methods (i.e. are now static) among which SetDictPath
1504 (renamed to BuildDictPath) and LoadDefaultPubDict.
1505 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1506 the above changes by calling the new method classes of gdcmDictSet.
1507 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1508 the above to be effective.
1509 * python/gdcmPython: in order to wrap properly the above changes
1510 for Python, swig version now needs to be > 1.3.17.
1511 * python/gdcmPython/Makefile fixed to adapt itself to new
1512 configure/make shema introduced by Johan Montagnat (thanks for the
1513 contribution). Alas this Makefile cannot be turned into a proper
1514 Makefile.am without some heavy changes in the configure.in
1515 (for python dectection).
1516 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1517 now avoids publishing the empty entries.
1519 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1520 * python/setup.py : bug fix concerning install under windows
1521 ExtraPath reused :-P
1522 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1524 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1525 * Dicts/dicomV3.dic : remove double spaces !!!
1526 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1527 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1530 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1532 method. Doxygenation.
1533 * src/gdcm.h clean up of JPR spurious comments.
1535 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1536 * python/distutilsSwigCPlusPlus.py now properly collects the
1537 shadow classes generated by "swig -c++" (gdcm.py in our case)
1538 when using "python setup.py install".
1539 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1540 reexports the working classes.
1541 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1542 by the classical C errno scheme. This is to prevent an obscure
1543 behavior of the python wrappers when importing wxPython.wx prior
1544 to gdcmPython (which ended up in an abort call). An illustration
1545 of this oddity can be found in the Test/ExceptionAndPython
1546 subdir (see the README file). This problem probably due to
1547 an combination of g++ and dynamic loading.
1548 * added Test/ExceptionAndPython (see above)
1550 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * Changed the layout of the python part to avoid bloating main
1552 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1553 i.e. the distutils arsenal. All the python related stuff is
1554 again in a python subdir, but the package itself is now in
1556 * setup.py was cleaned up:
1557 - pythonIncludePath removed
1558 - python setup.py bdist target is now functional.
1559 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1560 collision with other packages). gdcmPython/demo/*.py changed
1563 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1564 * python subdir moved to gdcmPython (preparation of distutils packaging).
1565 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1566 distutils installer is operational.
1567 * - gdcmPython/__init__.py now properly loads the swig generated
1568 shadow classes (from gdcm.py).
1569 - gdcmPython/demo/*.py changed to import the package gdcmPython
1570 instead of gdcmPython/demo/load.py.
1571 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1573 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1575 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1576 entries within the associated public Dicom dictionary resp. the same
1577 information but sorted by the fourth field (PAT, IMG, DIR) of the
1579 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1580 are now in the "???" group.
1581 - python/gdcm.i changed accordingly,
1582 - python/demo/printGroupedPublicDict.py added, that gives an example
1583 of the above new functionalities in Python.
1585 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1586 * src/gdcm.h, gdcmHeader.cxx:
1587 - historic references to glib's g_malloc and g_free (#defined)
1588 were definitively removed.
1589 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1590 * src/gdcmElValSet.cxx:
1591 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1592 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1593 - GetElValue(string) renamed to GetElValueByName.
1594 - Added GetElementByName(string).
1595 * src/gdcmHeader.cxx: added
1596 - GetPubElValRepByNumber(guint16, guint16)
1597 - GetPubElValRepByName(string)
1598 - GetShaElValRepByNumber(guint16, guint16)
1599 - GetShaElValRepByName(string)
1600 - GetShaElValByNumber(guint16, guint16)
1601 - GetShaElValRepByName(string)
1602 - GetElValRepByNumber(guint16, guint16)
1603 - GetElValRepByName(string)
1604 - GetElValByNumber(guint16, guint16)
1605 - GetElValRepByName(string)
1606 * Doc/requirements.txt added.
1608 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * Test/Makefile building now depends on the one of libgdcm.so
1610 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1611 pixel data) aware which enables finding the address (offset) of
1612 the pixel data of JPEG encoded DICOM files. This leaves only a single
1613 file in the testSuite whose pixel data address (offset) is unknown.
1614 * python/testSuite.py changed accordingly.
1616 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1617 * VC++ has some strong limitations when working with the STL, as stated
1618 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1619 "Also note that some STL containers (map, set, queue, list, deque)
1620 cannot be exported. [...]
1621 Some STL classes contain nested classes. These classes can not
1623 This is caused by a designed limitation that once a template
1624 class is instantiated, it can not be re-instantiated and
1626 Since our usage of map<> is ubiquitous in gdcm, this "designed
1627 limitation" of VC++ is a pitfall.
1628 Hence the Python wrappers of gdcm cannot be incrementally linked
1629 against the c++ dynamic library. The dirty but only workaround is
1630 to forget about incremental link of dynamic libraries and to generate
1631 the Python wrappers library with the inclusions of the underlying C++
1633 The following modifications concern this matter on Win32/VC++:
1634 - wrapping python correct with standalone wrapped dll (don't use separate
1635 dll under windows !!!!)
1636 - python21_d debug mode enabled (ask Frog how to use it :-)
1637 - NO problem with having an STL member of class for example string in C++
1638 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1639 - Python test of dcmlib in Python is ok under windows on a large set
1641 * removed glib references
1642 * typedef's inserted in gdcm.i for correct swig type management
1644 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1645 * python/demo/*.py load.py extracted from test.py. Added explore.py
1646 that only displays required tags and testAll.py that parses all
1647 the files of the testsuite without using unittest.
1648 * python/testSuite.py other additional test on new files added.
1649 * Data/* new test files added accordingly to the testSuite.
1650 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1651 the vr in the file differs from the one of the dictionary.
1653 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1654 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1655 values, but limits itself to values which are below a user specified
1656 size (by default 1024 bytes).
1657 * python/gdcm.i : elements not loaded (because their size is above the
1658 user specified treshold) are exported with their TagKey as key of the
1659 python dictionary. This enables the testsuite to make some checks
1660 on the unloaded elements (since we have their offset and size).
1661 * python/testSuite.py
1662 - now tests for the existence and proper value of the pixel data
1663 - two new examples added.
1664 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1666 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1668 aware. See the strategy comments in gdcmHeader::FindeLength().
1669 * Test/test.cxx now accepts a filename as first argument.
1670 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1671 * python/testSuite.py changed to integrate test on above files.
1673 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1674 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1675 the vr was also RET.
1676 * python/testSuite.py more tests added.
1678 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1679 * python/testSuite.py unittest test suite added (uses Data)
1680 * Data/* dcm and acr files for the test suite.
1681 * glib dependance removed from un*x version. We now use ISO C99
1682 7.18 Integer types (see stdint.h)
1683 - python/Makefile, src/Makefile src/gdcm.h
1684 * src/ when an explicit vr (like dicom files) suddenly poped an
1685 implicit element we use to mark the underlying DictEntry of the
1686 concerned ElValue with "Implicit". This strategy was damageable
1687 too the public or provite dictionaries, since some of their vr
1688 would be changed. Since Header::FindLength heavily relies on the
1689 detection by Header::FindVR of falsely explicit elements, I
1690 added an extra ImplicitVr member to ElValue (boolean).
1691 The rest of the changes we the necessary adaptations.
1693 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1694 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1696 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1698 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1699 * Adaptation for porting to VC++:
1701 o forced to use std namespace (for string to be known)
1702 o all class use __declspec export style on WIN32
1703 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1704 (in stdlib.h on Win32 but in std:: for gcc)
1705 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1706 variable GDCM_DICT_PATH.
1707 * src/gdcmHeader.cxx verbose comments made discrete.
1709 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1710 * python/gdcm.i: added a typemap that converts a C++ hashing table
1711 to native Python dictionary.
1712 * python/demo/test.py:
1713 - now uses the native dictionary for exploration of gdcmHeader.
1714 - takes an optional filename argument (the file to parse).
1715 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1716 PubElVals hashing table.
1717 * Dicts/dicomV3.dic removed error prone trailing spaces.
1719 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1720 * Python wrapping process moved away from src/Makefile to
1721 newly created python/Makefile (as well as gdcm.i)
1722 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1723 * src/gdcmHeader::FindLength only looks for current vr when necessary.
1724 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
1725 from the environement variable GDCM_DICT_PATH (when existing).
1726 * src/gdcmDict::GetTag bug fix.
1728 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1729 * Straightforward temporary fixes for swig to build the python wrappers.
1730 src/Makefile now has a python working entry [by working we mean
1731 that we can import de shadow classes without errors].
1733 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1734 * hashtest.cxx removed (since allready in Test)
1735 * src/gdcmlib.h renamed to src/gdcm.h
1736 * src/dcm.i renamed to src/gdcm.i
1737 * src/Makefile prepared for python wrapping
1739 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1740 * src/gdcmHeader.cxx :
1741 - Parsing of header is now separated from loading of element values
1742 (see gdcmHeader::LoadElements).
1743 - general clean up of hopefully all file access (creation of
1744 ReadInt16 and ReadInt32)
1746 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1747 * src/gdcmHeader.cxx :
1748 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
1750 - SetLgrElem renamed to SetLength
1751 - GetLgrElem renamed to GetLength
1752 - ~gdcmHeader() made virtual to pesky warning messages at compile.
1753 * src/gdcmElValSet.cxx fixed both GetElValue methods
1754 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
1755 due to IdoDude was cleaned out.
1757 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1758 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
1759 concentrates on finding the value representation (when it exists).
1760 RecupLgr now only finds the element value length, and it avoids
1761 returning the unecessary skL (skipped length).
1762 Also, offsetCourant was simply removed (with taille_fich) since
1763 it was redundant with the File position internals (by using
1764 ftell and fseek). This also made skL (see above in RecupLgr) usage
1766 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
1767 on the libido specificities which are handled through class
1769 * Test/implicit_vr.dcm dicom v3 in implicit value representation
1772 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1773 * Truckload of changes. Parsing of header is barely functional
1774 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
1776 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1777 * src/gdcmHeader.cxx many addons of low level methods
1779 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1780 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
1781 and _IdDcmSWAP_LONG.
1783 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1784 * This corresponds to all the changes decided at the meeting of
1785 May 23 2002. Needless to say we are running late...