1 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * STYLE: ivars should start with a capital letter.
3 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
4 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
6 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
7 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
8 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
9 new 2004 dictionaries added (thanks to JPR).
10 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
11 * CLEANUP_ROUND (15) for gdcmPixelConvert
12 - RLEFrame::NumberFragments is now of type unsigned int
13 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
14 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
17 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
18 * Initial work in gathering all transfer syntax accessors. clearly
19 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
20 ivars, but only one transfersyntax (class) ivar with equivalent method on
23 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
24 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
25 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
26 discussed (plus I didn't like having a 2000 lines patch not commited)
28 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
29 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
30 * CLEANUP_ROUND (14) for gdcmPixelConvert
31 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
32 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
33 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
35 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
36 anymore and hence avoids storing a copy of PixelConvert::Decompressed
37 into File::Pixel_Data.
39 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
40 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
41 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
42 * CLEANUP_ROUND (13) for gdcmPixelConvert
43 Substituted File::ParsePixelData() with PixelConvert::Print() new
45 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
46 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
47 method to those classes.
48 - src/gdcmFile.[cxx|h]:
49 -- Added a ::Print() method.
50 -- PixelConverter is now a reference instead of a member.
51 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
52 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
54 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
56 collaboration diagram and inheritance diagram should be generated with
58 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
59 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
60 pointlessly wrapped (see
61 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
62 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
63 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
64 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
65 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
66 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
67 -- File::Initialise: PixelConverter setup moved away to
68 PixelConverter::GrabInformationsFromHeader()
69 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
70 interpretation moved away to PixelConverter::BuildRGBImage()
72 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
73 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
74 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
76 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
77 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
78 displayed on Win32 when a brutal abort() occurs (because of uncatched
79 exception). See TODO new entry of this commit for more on this.
80 * TODO added new entry.
81 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
82 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
83 - HandleColor is no longer called from gdcmFile.cxx
84 - gdcmPixelConvert.cxx clean up on method arguments and internal
85 variable names for semantical coherence.
87 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
88 * Finished lossless transition, not only do we now read all lossless jpeg
89 images, without the need of the Cornwell lib, but we do read them properly now
90 * To reduce code (well to avoid code duplication), I defined a common place
91 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
92 redefine symbols. This is not prefect but this the best solution I found for a
93 compilation time jpeg option.
95 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
96 * Update jpeg ijg lib to support lossless jpeg implementation
97 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
99 * Also added a special copyright for dcmtk since we use their bugfixes.
102 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
103 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
104 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
105 matters, as stated in warning note at begining of %include section).
106 * src/gdcmDicomDir*.[cxx|h]: coding style
107 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
108 * src/gdcmJpeg8.cxx: doxygen fix.
109 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
110 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
111 from File:: to PixelConvert::.
113 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
115 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
116 - more code moved away from File:: to PixelConvert::
117 - fat setup of PixelConverter set in place in File::Initialise.
119 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
120 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
121 namespace at the file system level. So now you should convert your examples
123 gdcmHeader -> gdcm::Header
124 It would be nice if people keep in mind to no open the namespace, since it
125 allows compilation on broken plateform which were defining common symbol in
126 the standart namespace (like LP, Unknown ...)
128 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
129 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
130 The JPEG fragments are now parsed at the same stage than the RLE
131 information. All code related to JPEG is now in gdcmPixelConvert:
132 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
133 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
134 export a gdcmFile:: method. Those are simply global functions
135 (for the time being this is better than having them attach to
136 either gdcmFile:: or gdcmPixelConvert::).
137 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
138 and stores the result in a gdcmJPEGFragmentsInfo.
139 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
140 code (among other stuff) moved away from gdcmFile:; to
143 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
144 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
145 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
146 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
147 clean up of RLE related code.
148 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
149 - src/gdcmRLE.cxx removed
150 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
151 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
152 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
153 * CLEANUP_ROUND (9) for gdcmPixelConvert
154 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
155 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
156 away from gdcmFile:: to gdcmPixelConvert::.
158 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
159 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
160 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
161 This is because Parse7Fe0 used to parse the pixels to compute the
162 length. This task was passed over to FindDocEntryLengthOB() a long
163 time ago, EXCEPT I had forgotten the OW case...
164 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
165 we just recylce the code for parsing RLE fragments and computing
167 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
168 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
169 with the retired Parse7Fe0().
170 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
171 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
173 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
174 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
175 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
176 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
177 - src/CMakeLists.txt: alphabetic order reodering + new entries.
178 * CLEANUP_ROUND (4) for gdcmPixelConvert
179 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
180 to return an unused length.
182 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
184 this should be cleanner from the plane view. The iostream are erally a pain
185 to use to do simple stuff.
187 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
188 * Redo the compilation of the ijg jpeg library. Now only one source is
189 necesseray. No need to rename file by hand what so ever. CMake handle the
190 copying of the file within different directory, configure header file to
191 modify some symbol. The only addition made to ijg wasd a mangle table so
192 that symbol are different wether we are within 8bits or 12bits.
194 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
195 * Added documentation of vtkgdcmReader on Website:
196 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
197 with it's binary name).
198 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
199 the Website to be more complete.
200 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
201 doxygenated documentation.
202 - Doc/DoxyVtkGdcmReaderExamples.txt added
203 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
204 DoxyVtkGdmReaderExamples.html )
205 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
206 * CLEANUP_ROUND (3) for gdcmPixelConvert
207 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
209 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
210 * CLEANUP_ROUND (2) for gdcmPixelConvert
211 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
213 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * CLEANUP_ROUND for gdcmPixelConvert:
215 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
216 - src/gdcmPixelStuff[h|cxx] removed
217 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
218 - src/CMakeLists.txt changed accordingly
220 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
221 gdcmVersion.py moved to newly created ATTIC related
222 gdcmPython/SetupOldies/ directory.
223 * Autotools clean up:
224 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
225 - autogen.sh configure.in acinclude.m4 python.m4 removed
227 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * src/*.cxx *.h Reference to License.htm fixed to License.html.
229 * Doc/CMakeLists.txt, doxygen.config.in: fix.
230 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
232 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
233 * TODO updated with Mathieu suggestions. I proposed a template for
234 describing TODO entries and used it for new entries.
235 * Added Doc/Website/CodingStyle.html, Developpers.html,
236 DeveloppersPython.html, GdcmDataCvs.html and
237 DownloadVersion0_1.html, DownloadVersion0_3.html.
238 * Some Doc/*.txt Doxygen files (which do not really concern the
239 documentation itself, but the website) moved to html and
240 placed in directory Doc/Website:
241 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
242 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
243 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
244 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
245 * CMakeLists.txt changed accordingly.
246 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
247 DeveloppersPython.html
248 * INSTALL nows refers to Doc/Website/Installation.html
250 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
251 * Added Doc/Website directory, that contains a first raw version
254 2004-09-23 Jean-Pierre Roux
255 * FIX In order not to be poluted any longer by casting problems,
256 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
257 we can now delete[] it safely
258 * VoidArea is now called BinArea (less confusing name),
259 and all the methods called ...VoidArea... are now ... BinArea...
260 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
262 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
263 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
264 clear) TagHT, which is an inherited member of gdcmElementSet. It is
265 up to the destructor of gdcmElementSet to clean up TagHt and it's
268 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
269 * Test/CMakeLists.txt: update to follow gdcmData renamings.
270 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
272 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * ENH: added some utility method that builds a flat dictionnary
274 holding all the Dicom entries contained in the recursive structure
275 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
277 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
278 BuildFlatHashTable() that build a flat dictionary.
279 - src/gdcmElementSet.h: added a new private GetTag() accessor.
280 gdcmDocument is now a friend of gdcmElementSet.
281 - src/gdcmElementSet.cxx: clean up.
282 - Example/FlatHashTablePrint.cxx added.
283 - Example/CmakeLists.txt changed accordingly
285 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
287 moved away from gdcmDocEntrySet (since this class is an abstract class
288 acting like an interface). SQDepthLevel and BaseTagKey are now
290 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
291 and associated accessors. Doxygenation of the class.
292 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
294 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
295 Use SQDepthLevel accessor instead. ::Print() adapted.
296 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
297 - src/gdcmDocument.cxx changed accordingly.
299 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
300 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
301 - The following is the doxygen comment of the typedef declaration
302 of gdcmagKey in src/gdcmCommon.h:
303 gdcmTagKey is made to old an "universal" (as in URL, Universal
304 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
305 A dicom tag allways has a group and an element, but a set of tags
306 embeded in various (optionally nested) sequences and sharing
307 the same group and element all share the same (group, element)
308 "identifier". Hence the (group, element) cannot be used as an
309 identifier (in gdcm we shall refer to a "TagKey") of a tag.
310 In order to construct a proper tag identifier (i.e. a key) we
311 consider the following definition of a TagKey:
312 - let Group, Element be the string representation of the
313 group and element dicom tag members,
314 - let ItemNumber be the string representation of the integer
315 index of the considered item number of a sequence,
316 Let the key of a tag embeded in a sequence, noted SeqTag, be
318 /ItemNumber#Group|Element
319 where "/", "#" and "|" are characters acting as separators.
320 Then the general form of a gdcmTagKey is given by:
321 Group|Element<SeqTag>
322 where <SeqTag> means NO or many instances of SeqTag.
323 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
326 but the gdcmTagKey of a tag "embeded" is the first item of
327 a sequence, itself nested in the third item of a sequence is the
329 0004|1220/2#0008|0082/0#0008|0090
330 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
331 order to hold the new sequence compatible key. Previously, the
332 GetKey() method would look in the underlying gdcmDictEntry.
333 - src/gdcmDocEntry.cxx:
334 -- constructor now copies the underlying DictEntry key, in the local
336 -- ::Print: displays the member Key, instead of the (group, element).
337 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
338 - src/gdcmDocEntrySet.h:xi
339 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
340 -- now has a new BaseTagKey member.
342 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
343 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
345 This poses the problem with the semantics of the following lines
346 LoadEntryVoidArea(0x0028,0x1201); // R LUT
347 LoadEntryVoidArea(0x0028,0x1202); // G LUT
348 LoadEntryVoidArea(0x0028,0x1203); // B LUT
349 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
350 to the long FIXME note for what the problem is. Nevertheless in
351 order to get things working the dicom dictionary was altered !
352 Please fix things urgently...
353 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
354 information), see above note on moving the member VoidArea. Nevertheless
355 the following entries previously correctly set as US are now inproperly
357 0028 1201 OW IMG Red Palette Color Lookup Table Data
358 0028 1202 OW IMG Green Palette Color Lookup Table Data
359 0028 1203 OW IMG Blue Palette Color Lookup Table Data
360 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
361 of gdcmDocEntry moved to gdcmSeqEntry.
362 * src/gdcmSeqEntry.cxx: STYLE.
364 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
365 * Test/TestAllEntryVerify.cxx minor fix and added comments.
367 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * gdcmPython/testSuite.py: all the test suite in python is now moved
369 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
370 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
371 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
373 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
375 to avoid inclusion recursion until STL is reached.
376 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
377 mecanism. errno.h is not included in gdcm anymore.
378 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
379 (gdcmFormatError now inherits from gdcmFormatUnexpected).
381 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
382 gdcmData/TestAllEntryVerifyReference.txt
383 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
384 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
385 exception_on_error parameter.
386 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
387 - vtk/vtkGdcmReader.cxx changed accordingly,
388 - Example/*.cxx and Test/*.cxx changed accordingly.
390 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
391 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
392 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
393 enable_sequences removed from gdcmHeader constructor and dependencies.
394 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
395 * gdcmPython/demo/PrintHeader.py: dummy fix.
396 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
397 skip_shadow removed from gdcmHeader constructor and dependencies.
398 * Example/*.cxx and Test/*.cxx changed accordingly.
400 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
402 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
404 2004-07-21 Jean-Pierre Roux
405 * FIX Now, Parsing and Printing a DICOMDIR do work!
406 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
408 2004-07-20 Jean-Pierre Roux
409 * FIX Some brain damaged headers have Zero-Lenght fields
410 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
412 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
413 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
414 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
415 variable (instance of gdcmDebug) by a definition macro, and the instance
416 is now in static in the gdcmDebug class
417 * src/gdcmSQItem.h : (FIXME) remove an undefined method
418 * Test/PrintAllDocument.cxx : bug fix in the result of the test
420 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
421 * WARNING: ctest now depends more tightly on gdcmData. You should
422 check out gdcmData properly for things to run smoothly...
423 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
424 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
425 we need the pixels not be loaded in order to use the ValEntry
426 that displays position and size).
427 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
428 This is a C++ based equivalent of gdcmPython/testSuite.py that should
429 be deprecated. If you have any doubts about the advantages of a
430 modern scripting language (read Python) versus grass root C++ (i.e.
431 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
432 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
433 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
434 Anyhow, consider documenting the gdcmData images in
435 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
437 * Test/CMakeLists.txt:
438 - now uses TestAllEntryVerify.cxx
439 - specific comments on oldACR00001.ima (now renamed in gdcmData
440 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
441 gdcmData/TestAllEntryVerifyReference.txt
444 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * src/*.[h|cxx] : typedef clean up
446 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
447 - TagKey renamed to gdcmTagKey (for external usage)
448 - VRKey renamed to gdcmVRKey (for external usage)
449 - removal of typedef duplication.
450 - Removed all unecessary inline keyword from class inline definitions.
451 - Some method|function(void) declarations replaced with method|function().
452 * src/jpeg/libijg12/jdhuff12.c:
453 - printf polluting ctest removed.
454 - TAB removal for comminting
456 - TestAllReadCompareDicom.cxx: added a test that compares all the
457 images in gdcmDataImages.h with corresponding images in
458 gdcmData/BaselineDicom/. When baseline images are not present
459 this test creates them.
460 Note: we need to validate each reference image, but before that
461 I'd like to rename them with a more explicit name...
462 - CMakeLists.txt: changed accordingly.
463 * Example/*.cxx: examples now only include gdcm.h (as opposed to
464 including each header needed).
466 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * Test/*.cxx and Example/*.cxx: moved some examples away from the
468 test suite to the Example directory. Are concerned:
473 - TestWriteSimple.cxx
474 * Test/CMakeLists.txt: added some comments on reasons for black listing
475 image gdcmData/oldACR00001.ima
477 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * Test/CmakeList.txt: removed the following from black list (to be coherent
479 with removal from gdcmData):
480 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
481 - gdcm-MR-PHILIPS-16.dcm
483 Added the following because after last cvs update, they cause
484 ctest -R TestReadWriteReadCompare
486 - gdcm-MR-SIEMENS-16-1.acr
488 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
489 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
490 new comments in this file) we temporarily (sigh) move to a weaker
492 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
493 we don't need to black list the following images anymore:
494 - 8BitsUncompressedColor.dcm
496 - US-PAL-8-10x-echo.dcm
497 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
498 fixes and the beautified code ;-)
499 This fixes the bug introduced in version 1.42 (when beautifying)
500 that made the parsing of 8BitsRunLengthColor.dcm unproper.
501 Note: ctest was blind to this bug (this means we need to still
502 improve the test suite). The bug could be detected by using
503 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
505 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
506 and by displaying the (garbage) produced file temp.XDCM...
508 2004-06-29 Jean-Pierre Roux
509 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
510 - replace by uggly but working old code :-(
511 A lot of things should be OK again.
512 It's really urgent to have a test suite that *tests*,
513 to prevent Frog's beautifying sessions to break all the stuff
514 (twice, withing a fortnigh ...)
516 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
517 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
518 redundancy) to added Test/TestReadWriteReadCompare.cxx
519 * Test/CmakeList.txt: because the compare test of
520 Test/TestReadWriteReadCompare.cxx fails, the following images are
521 black listed: - 8BitsUncompressedColor.dcm
523 - US-PAL-8-10x-echo.dcm
524 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
525 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
526 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
527 and ad-hoc kludge. This kludge is now removed, and on encountering
528 such an image (OB field brain damaged) we set errno. Then in
529 ::FindDocLength() we "fix" the length as being ALL what remains
530 in the file (until EOF). We then proceed, hoping for the best...
531 This fixes a SegFault in ShowDicom when trying to write such an
533 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
534 (because TestWriteRead breaks on it, after a non conformal commit?).
535 ctest now runs properly, except for MakeDicomDir (which was allways
536 broken) and the Python related stuff (still not fixed).
538 2004-06-24 Jean-Pierre Roux
539 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
540 FIX : Test/TestReadWrite now iterates on all the file names
541 (instead of infinite loop)
542 ENH : Test/TestWriteRead now iterates on all the file names
544 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
545 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
547 2004-06-24 Jean-Pierre Roux
548 FIX : - now Write drops LUT Descriptors and LUTs (if any)
549 when SamplesPerPixel =3
550 - now Write is no longer confused by
551 'BitsAllocated = 12" and 'BitsStored=12"
552 - "UN" value representation Elements are now written correctly
553 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
554 ENH : - now gdcmHeader has its own Write methods
555 (in order to split the job that has not to be done
558 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
559 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
560 loop on the same image until memory went out.
561 Note: this means we still have gobs of memory loss in PrintDocument
562 * src/gdcmDocument.cxx: fixes problem on parsing on file
563 gdcmData/16BitsJpegLosslessGrayScale.dcm.
565 2004-06-24 Jean-Pierre Roux
566 FIX : Write - All the Sequences and Sequence Item are now written
567 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
568 is added a the end, when necessary.
569 - A lot of brain-damaged images, that were read correctly are
570 now written correctly
571 - length compatible BinEntry are now loaded correctly
572 (even for odd groups)
573 Note : only Explicit Value Representation was checked.
574 (question : is implicit VR really necessary for gdcm ?)
576 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
577 * DEVELOPPER: added a proposition of coding style.
578 * src/gdcmDocEntry.h: removed every inline declaration (for test of
581 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
582 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
583 Use the gdcmDocEntry::Print() and Write() instead.
584 * src/gdcmDocument.cxx: bug fix.
586 2004-06-22 Jean-Pierre Roux
587 FIX : gdcmDocument.cxx
588 - Now we do recognize the JpegLossLess format (there was a misstyping in
589 code 'beautyfication' :-(
590 - Now we automaticaticaly load the Luts, if any
592 2004-06-22 Jean-Pierre Roux
593 In order : to write Sequences, whatever their imbrication level,
594 : to allow user to create his own Sequences
595 a lot of modif where necessary (adding, moving, or virtualising methods)
597 WARNING : save your own sources *before* cvs up !
600 ADD virtual void Write(FILE *fp, FileType filetype);
603 ADD virtual void Write(FILE *fp, FileType filetype);
604 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
607 ADD virtual void Write (FILE *fp, FileType filetype)=0;
608 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
609 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
610 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
611 ADD std::string GetEntryByName(TagName name);
612 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
614 std::string vr = "unkn",
615 std::string fourth = "unkn",
616 std::string name = "unkn");
617 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
618 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
619 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
620 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
621 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
622 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
623 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
624 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
627 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
628 ADD virtual std::string GetEntryByName (TagName tagName);
629 ADD virtual std::string GetEntryVRByName (TagName tagName);
630 REM virtual bool Write(FILE *, FileType);
631 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
632 FILE *_fp, FileType type);
633 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
634 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
635 REM virtual bool WriteEntries(FILE *_fp,FileType type);
636 REM virtual std::string GetEntryByName (std::string tagName);
637 REM virtual std::string GetEntryVRByName (std::string tagName);
638 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
639 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
640 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
642 std::string vr = "unkn",
643 std::string fourth = "unkn",
644 std::string name = "unkn");
645 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
646 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
647 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
648 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
651 ADD virtual void Write(FILE *fp, FileType filetype);
654 ADD virtual void Write(FILE *fp,FileType filetype);
657 ADD virtual void Write(FILE *fp, FileType filetype);
658 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
659 REM std::string GetEntryByNumber(guint16 group, guint16 element);
660 REM std::string GetEntryByName(TagName name);
663 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
665 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
667 The default constructor invoked by the line
668 gdcmHeader *f1 = new gdcmHeader( header );
669 was gdcmHeader::gdcmHeader(bool) instead of the expected
670 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
671 Hence the parsing wasn't executed... See also below.
672 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
673 as explicit constructor didn't do the trick to fix the above problem.
674 Could anyone explain why ?
675 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
676 properly calls gdcmValEntry::Print() (that was weed out from
677 code related to gdcmBinEntry).
679 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
680 * In order to fix memory leaks:
681 - Test/TestWriteSimple.cxx: added cleaning of free store through
683 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
684 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
685 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
686 (through the call to ::AddDicomDirMeta()) or the destructor
687 would crash when deleting uninitialized ::metaElems].
688 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
689 - src/gdcmDocument.cxx:
690 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
692 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
693 was causing memory leaks.
694 - src/gdcmSQItem.cxx:
695 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
696 cleanly handled with polymophism: sorry but my milage is low).
697 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
698 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
699 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
700 This avoids SegFaulting.
701 - src/gdcmSQItem.h: coding style.
703 - Test/TestWriteSimple still severely sucks. The output image content
704 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
705 damaged when displayed with vtkgdcmViewer.
706 - on memory leaks: TestWriteSimple leaks really less (see entry
707 of 2004-06-18 in Changelog file for the call to valgrind).
708 - on segfaults: ctest now passes all the tests but one (no more
710 * Erroneous leading white fix:
711 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
712 white[s] (as opposed to from >> xxx, that removes it [them].
713 - src/gdcmTS.cxx: ditto.
714 - gdcmPython/testSuite.py: dirty related kludge removed.
715 * src/*: remaining references to gdcmParser removed.
716 * src/*[cxx|h]: added copy[way]left header.
719 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
720 * In order to fix writing of dicom files:
721 - Test/TestWriteSimple.cxx: a simpler example of writing.
722 - Test/CMakeLists.txt changed accordingly.
723 - src/gdcmDocument.cxx:
724 -- The destructor now recursilvely removes potential sequences.
725 -- Bug fix in ::IsJPEG2000()
726 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
727 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
729 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
730 to only declared) and build on top of
731 ::GetDocEntryByNumber(guint16, guint16).
732 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
733 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
734 for usage in destructor and treatement of promotion in
735 ::ReplaceOrCreateByNumber().
736 - src/gdcmSQItem.cxx: destructor should better handle his job.
737 Test/TestWriteSimple now runs (or at least it DOES something).
738 * We can now start hutting memory links. A good starting point is:
739 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
740 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
741 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
743 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * Valgrind note: after Mathieu Malaterre teached me how to read
745 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
747 Using gcc, you can force the STL to use malloc and to free memory as
748 soon as possible by globally disabling memory caching.
749 With 3.2.2 and later, you should export the environment variable
750 GLIBCPP_FORCE_NEW before running your program.
751 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
752 simply vanish (it is still not clear to me, whether this means that
753 STL std::string leaks or if valgrind believes it leaks...).
754 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
755 running bin/gdcmTests makeDicomDir):
756 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
757 - Test/makeDicomDir.cxx now properly traps empty lists and returns
759 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
760 SegFaulting (I drowned in DicomDir related code when trying to
761 understand why the list is empty...).
762 * src/gdcmDocument.h: first BSD license header try.
763 * Doc/License.txt added.
765 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
766 * src/gdcmDocument.[h|cxx]:
767 - Clean up of the Transfer related predicates. They are now all based
768 on new method isGivenTransferSyntax, that (should) handle properly
770 - general clean up, simplification, and coding style.
771 - Specific clean up of Parse7FE0() (umproperly named actually).
772 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
774 2004-06-14 Jean-Pierre Roux
776 - fix the display of Sequence Delimitor (SQDepthLevel pb)
777 - fix the display of SQItem ordinal number
778 - add the GetSQItemByOrdinalNumber method
779 - remove some useless never written private methods
781 2004-06-14 Jean-Pierre Roux
783 - adding a constructor taking a gdcmDocEntry as an input param
784 - ReplaceOrCreateByNumber now returns :
785 a gdcmBinEntry * if a Binary (void *) value is passed as a param
786 a gdcmValEntry * if a string value is passed as a param
788 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
789 according to the param type (no longer sets a gdcmDocEntry)
790 - GetValEntryByNumber, GetBinEntryByNumber added
791 - NewValEntryByNumber and NewBinEntryByNumber added
793 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
795 - GetSQItemNumber and SetSQItemNumber added, to provide
796 a (relative) Item identier inside a given Sequence
797 \warning : some pb remaining around this number
799 - AddEntry now takes the Item Number as a param
801 - adding a constructor taking a gdcmDocEntry as an input param
803 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * Memory leak hunt with the following command:
805 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
806 --show-reachable=yes gdcmTests PrintDocument
807 It looks like many (all?) leaks are due to the STL (or a bad usage
808 of the STL. The lines producing the leaks now have a comment with
809 a "MEMORY LEAK" tag: you can retrieve them with
810 grep "MEMORY LEAK" src/*
811 Here are two typical examples which I can't help fixing:
816 char * test = "babo";
817 name = test; //// <--- valgrind detects 960 bytes lost in
818 //// call to std::string::operator=(char const*)
819 name.clear(); //// Doesn't help !
827 std::cout << "Type a bunch of characters followed by RETURN: ";
828 getline(std::cin, line); //// <--- valgrind dectects a loss
829 //// of 1320 bytes in call to
830 /// std::basic_istream<>& std::getline<>
836 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
837 * src/gdcmHeader.[cxx|h]:
838 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
839 and related, moved away to gdcmDocument.
840 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
841 the corresponding protected accessors of inherited class
842 gdcmDocument, removed ! As a consequence gdcmFile had to be
843 declared friend of class gdcmDocument (see below).
844 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
845 - Clean up of undefined or unused methods.
846 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
847 account the changes to gdcmHeader.h).
848 * src/gdcmDocument.h:
849 - gdcmFile is now a friend class (in order to take into account the
850 changes to gdcmHeader.h).
851 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
852 (see changes to gdcmHeader.h).
853 - Accessors (reading on the form GetEntry*) are now public.
854 - Clean up of undefined or unused methods.
855 * src/gdcmDocument.cxx:
856 - adaptation to changes to gdcmDocument.h
857 - ::OpenFile now writes a verbose message when file cannot be opened.
858 - some std::string properly set to VRKey
859 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
860 references to gdcmDocument.
861 * Test/TestFindTags.cxx: changed accordingly to above changes.
862 * gdcmPython/testSuite.py: adapted to renaming of acr files in
863 cvs repository gdcmData.
865 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
866 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
867 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
868 conflicts with gdcmValEntry::voidArea.
869 * src/gdcmValEntry.cxx: unmatching comment wiped out.
870 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
871 Value representation between StringRepresentable and BinaryRepresentable.
872 * src/gdcmDocument.cxx:
873 - method ParseDES: proper indentation restored and usage of
874 gdcmVR::IsVROfGdcmStringRepresentable wired in.
875 - method LoadDocEntry: the fingerprint left in the SetValue() of
876 unloaded entries (length > MaxSizeLoadEntry) had curiously been
877 removed. Reverting to previous code segment with the proper
878 dynamic_cast< gdcmValEntry* >.
879 Note: this was (partially) breaking the python test suite
880 (gdcmPython/testSuite.py) that made usage of the above
881 fingerprint to check presence of "Pixel Data".
882 * src/gdcmDocEntry.h: coding style.
883 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
884 now taken into account.
885 * gdcmPython/gdcm.i: adaptation to the new internal representation
886 of gdcm (exit gdcmParser, hello gdcmDocument).
887 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
889 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
890 anymore, but instead prints the loaded Python dictionary.
891 * .... alas, the python testSuite is still broken.
893 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
894 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
896 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
897 * src/gdcmUtil.h : export methods
899 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
900 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
902 * Initial addition of automatic python testing
903 * Initial addition of automatic image comparison
905 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
906 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
907 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
909 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
910 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
911 * Test/ShowDicom.cxx : bug fix for msvc compilation
912 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
914 2004-05-04 Jean-Pierre Roux
915 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
916 new concepts (and new classes) :
917 a 'gdcmDocument' is composed of a set of Doc Entries, that are
918 - elementary gdcmDocEntries (former gdcmHeaderEntries)
919 - Sequence Doc Entries (gdcmSeqEntries)
920 a Sequence is composed of Items.
921 Each item is a set of Doc Entries (this is recursive)
922 The non uniqueness of the 'Dicom tag' is due to this recursivity
923 (never taken into account)
924 Our unability to add a new 'entry' in the header
925 at the proper location (neither in the H-Table (map or multimap),
926 nor in the Chained List is also due to this recursivity.
927 Don't try, right now, to use/modify/compile these new sources :
929 We just commit all the stuff, 'as is', in order not to loose it.
931 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
932 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
934 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
935 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
936 file prefix (SetFilePrefix)
938 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
939 * Add a new test: ShowDicom, for now this is just the c++ version of
940 checkRead.sh, later it will be able to compare the image read against a
942 * Replace the DEBUG on the stack with a global entry in cmake interface:
943 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
945 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
946 * Add an example subdir, with a real example on how to read + write a
949 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
950 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
951 * Doc/CMakeLists.txt: the main page is now properly differentiated
952 between the developper and user version.
953 * Doc/doxygen.config.in: dropped search related obsolete flags
954 * src/gdcmParser.h, gdcmHeader.h: doxygenation
956 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
957 * DEVELOPPER: added some helpfull comments for compile/test/install
960 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
961 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
962 src directory, now generated in the build dir.
963 2. Tests as mentionned smarter
965 4. Add a new method in gdcmDict that return the PubDict by name
966 this is interesting for 3rd party lib like ITK,
967 where we could set the institution name / patient name...
969 * ENH: 1. Now the test suite is working for real
970 2. All binaries are now output in the gdcm-bin directory
971 (this was not true before)
973 2004-04-28 Jean-Pierre Roux
974 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
975 SeQuence indented printing of Dicom Header.
976 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
977 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
978 Computation of SQDepthLevel is now part of gdcmHeader constructor
979 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
980 tree-like structure of a Dicom Header.
981 * FIX Test code cleaning
983 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
984 * ENH: Adding automatic testing
985 1. Need a DartConfig.cmake to submit to public
986 2. Add a test driver gdcmTest.cxx
987 3. gdcmTestMain, an helper for the main test driver gdcmTest
988 4. Files in Test don't have a main anymore, this becomes interesting
989 when we add more and more tests, thus dsw don't have to load
991 * ENH: Adding a GDCM_DATA_ROOT for testing
992 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
993 one file instead of seven + some small cleanup
995 2004-04-22 Jean-Pierre Roux
996 * ENH Minor changes to the Print() methods.
997 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
998 Header printing. Example given with :
999 > PrintHeader fileName 2 new
1000 (SQ based tree-like structure still to be done for the Header ...)
1002 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1003 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1004 1. I have added some unsigned where needed
1005 2. Some function parameter not used -> (void)
1006 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1007 4. g++ don't like character '\' in comment
1008 5. #define jpeg_create_decompress jCreaDecompress
1009 this really need to be fixed
1010 6. virtualize destructor of gdcmObject ... leakage
1011 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1012 this also really need to be fixed
1013 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1014 remove compression file
1015 (as we only do decompression, right ?)
1016 * ENH: Change malloc/calloc/free with c++ equivalent
1018 2004-04-21 Jean-Pierre Roux
1019 * FIX gdcmHeaderHelper::GetXSpacing
1020 when a single value is found (bug ?), xpacing is now
1021 defaulted to yspacing
1023 2004-04-19 Jean-Pierre Roux
1024 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1025 * ENH add parameters :
1026 bool exception_on_error = false,
1027 bool enable_sequences = false,
1028 bool ignore_shadow = false
1029 to the gdcmFile constructors to be full gdcmParser compliant
1030 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1031 to allow reading of PAPYRUS 3.0 files
1033 2004-04-06 Jean-Pierre Roux
1034 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1036 2004-04-02 Jean-Pierre Roux
1037 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1038 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1039 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1041 2004-03-30 Jean-Pierre Roux
1042 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1043 for ACR file, written out as DICOM files (hope so...)
1045 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1046 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1047 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1048 moved to base class gdcmParser and only the specialisation is kept
1050 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1051 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1052 already does the job.
1053 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1054 (to be consistent with gdcmParser::WriteEntries).
1056 2004-03-30 Benoit Regrain
1057 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1058 upate of the object's instance. It's passed to 2 in the unfavorable
1059 case : one in the ExecuteInformation, one in the ExecuteData
1061 2004-03-29 Jean-Pierre Roux
1062 * ENH : Check on file type to be written moved
1063 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1064 * FIX : gdcmObject::ResetBoundaries now stops properly
1065 when end-of-list is reached
1066 : gdcmVersion modified (as Benoit Regrain asked)
1068 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1069 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1070 * src/gdcmUtil.cxx: added forgotten iostream include.
1071 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1072 equivalent to ExplicitVR in existing code).
1074 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1075 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1076 now contains all the gdcmGlobal related code.
1077 * minor coding style and doxygenation changes.
1079 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1080 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1081 now contains all the Debug related code.
1082 * minor clean-up of includes in src/*.cxx
1083 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1084 CreateCleanString) removed.
1085 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1086 * Doc/DoxyMainPageUser.txt added.
1087 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1088 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1089 src/gdcmDirList.cxx)
1091 2004-03-24 Jean-Pierre Roux
1092 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1094 2004-03-23 Jean-Pierre Roux
1095 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1096 big endian made volumes
1097 * ENH Now gdcmParser constructor and destructor are protected to forbid
1098 end user to instanciate class gdcmParser
1099 (only gdcmHeader and gdcmDicomDir are meaningfull)
1101 2004-03-22 Benoit Regrain
1102 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1103 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1104 gdcmSerie to gdcmDicomDirSerie
1106 2004-03-19 Jean-Pierre Roux
1107 * ENH Now the tree-like structure describing a DICOMDIR comming from
1108 an already existing DICOMDIR file is consistent with
1109 the home-made tree-like structure build ex-nihilo
1110 or build from the files held (recursively) in a Directory
1111 functions gdcmDicomDir::CheckBoundaries()
1112 gdcmObject::SetBoundaries() added
1114 2004-03-17 Jean-Pierre Roux
1115 * REM (Eric Boix bug) : removal of meaningless
1116 gdcmDicomDirImage::NewImage function.
1117 * FIX now file names and directory name are written properly in the
1119 * FIX now gdcmDicomDir constructor may be call without any trick
1122 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1124 of gdcmDicomDirImage::NewImage as empty function.
1126 2004-02-28 Jean-Pierre Roux
1127 * ENH add gdcmDicomDir:NewPatient
1128 add gdcmDicomDirPatient:NewStudy
1129 add gdcmDicomDirStudy:NewSerie
1130 add gdcmDicomDirSerie:NewImage
1131 to allow making gdcDicomDir object.
1132 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1133 (as opposite to the gdcmHeader chained list)
1135 2004-02-11 Benoit Regrain
1136 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1137 when using from python
1139 2004-02-10 Benoit Regrain
1140 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1141 * FIX : in gdcmDicomDir when the directory is empty
1142 * ENH : add callback and methods to get the progression of dicomDir
1145 2004-02-06 Jean-Pierre Roux
1146 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1147 - GDCM_META added to gdcmDicomDirType
1148 - class gdcmMeta created
1149 * ENH : - A brief summary is now displayed at the beginning of
1150 'testDicomDir' to help disaster magnitude estimation
1151 * REM : Now useless Test/explDICOMDIR.cxx
1153 2004-02-05 Benoit Regrain
1154 * ENH : add methods in gdcmObject to get the hash table or the list of
1156 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1157 * FIX : wrapping python for TagHeaderEntryHT
1159 2004-02-04 Benoit Regrain
1160 * FIX : even length for some strings when writting the dicom dir
1161 * FIX : sort the images in the dicom dir
1162 * FIX : Bug fix for python use of dicom dir
1163 * ADD : a python demo
1165 2004-02-04 Jean-Pierre Roux
1166 * FIX : Final solution (?) for icone embedded images
1167 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1168 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1169 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1170 gdcmData/gdcm-MR-SIEMENS-16.acr1
1171 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1172 to make full checking easier
1174 2004-02-04 Benoit Regrain
1175 * FIX : WriteEntries : coding style & logic in parameters
1176 * FIX : Set the elements to create the DicomDir in a dictionary file
1178 2004-02-03 Benoit Regrain
1179 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1180 * gdcmDicomDir : add the load of directory
1181 * Bug fix and print add-on
1183 2004-02-03 Jean-Pierre Roux
1184 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1185 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1186 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1187 * FIX gdcmParser.cxx : 'group length' elements are now considered
1188 as integers, even for shadow groups, when file is Implicit VR
1190 2004-02-02 Jean-Pierre Roux
1191 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1193 of the last synonym :-(
1194 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1196 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1197 * FIX taking into account the possible 7fe0,0010 multiplicity
1198 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1199 to allow removal of references to 7fe0,0010, to deal with
1200 ACR-NEMA images, when 0028,0200 is meaningfull
1202 2004-01-31 Jean-Pierre Roux
1203 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1204 no longer writes 'Un' on disk
1205 * FIX SQ elements with actual length are now dealt with corectly
1206 * FIX gdcmFile::WriteBase make the difference, for color images, between
1207 the length (for Palette expanded images)
1208 and Raw Length (non expanded image + Palette)
1209 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1210 (that broke Write). Replaced by UL.
1211 Aware user will reload the field if he
1212 thinks it's necesssary
1214 2004-01-30 Jean-Pierre Roux
1215 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1216 when 'dirty Acr' is found, to be compliant with the new
1217 IsReadable() methods.
1219 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1220 (no DOUBLE images in kosher DICOM,
1221 but so usefull for people that miss them ;-)
1223 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1224 DICOMDIR related utilities (not checked as Windoze compliant)
1226 2004-01-28 Jean-Pierre Roux
1227 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1229 2004-01-27 Jean-Pierre Roux
1230 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1231 to allow skipping the shadow elements, to save memory space.
1232 The TRUE value for this param has to be used
1233 with a FALSE value for the 'enable_sequence' param.
1234 ('public elements' may be embedded in 'shadow Sequences')
1235 * gdcmHeader methods now deal with 'embedded icones images' in the header
1236 (even when an 'icone image sequence' is announced by the
1237 element (0x0088,0x0200), but there is NO icone at all ...
1239 * gdcmHeader sometimes Image Location value doesn't follow
1240 the supposed processor endianity (see gdcmData/cr172241.dcm).
1243 * gdcmHeader add the method
1244 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1245 to get *all* the Header Entries with the same tag.
1246 GetHeaderEntrySameName is probabely *useless*
1247 (no meaning : Name is *not* an identifier within the Dictionnary)
1249 2004-01-26 Benoit Regrain
1250 * Bug fix in the print of hexadecimal representations. Remove long fields
1251 in the print and add a third level of print to print them
1253 2004-01-23 Benoit Regrain
1254 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1255 * Bug fix on test suite after remove the strip made on not string fields
1256 * Split the IsReadable method between gdcmParser which test that the file
1257 is dicom and gdcmHeader which test that it's an image file
1259 2004-01-22 Benoit Regrain
1260 * DicomDir : clean code, add methods, set variables in protected or private
1261 * gdcmUtil : bug fix for the clean string method
1263 2004-01-19 Benoit Regrain
1264 * Add the use of shadow dictionaries
1265 * bug fix and coding style
1267 2004-01-19 Benoit Regrain
1268 * src/gdcmFile.cxx : bug fix concerning the close of file
1269 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1270 * Add the update of header entries using the shadow library
1272 2004-01-19 Benoit Regrain
1273 * removal of file gdcmHeader2.cxx
1274 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1275 inheriting from gdcmParser. This split is to prepare the integration
1276 of dicom dir parsing
1277 * bug fix under python
1279 2004-01-16 Jean-Pierre Roux
1280 * REM removal of class gdcmHeaderEntrySet
1281 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1282 * ADD add file gdcmHeader2.cxx
1283 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1285 2004-01-15 Benoit Regrain
1286 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1287 entries created while parsing the header. Thus, they will be destroyed
1288 when the gdcmDictSet will be destroyed
1289 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1292 2004-01-15 Benoit Regrain
1293 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1294 made a fatal error because of the memory release at the end of program.
1295 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1296 some memory and vtk seems to have some problems with that.
1297 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1299 2004-01-14 Benoit Regrain
1300 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1301 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1302 * src/*.[h|cxx] : make changes due to class name changes
1303 * gdcmPython/demo/*.py : bug fix due to method names
1305 2004-01-13 Benoit Regrain
1306 * src/*.[h|cxx] : coding style
1307 * vtk/*.[h|cxx] : coding style
1309 2004-01-13 Benoit Regrain
1310 * gdcmPython/testSuite.py : test the readable flag of file for tests
1311 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1312 It's lied to the stl compilation by MSVC (windows, always windows...)
1313 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1315 2004-01-12 Benoit Regrain
1316 * src/*.h : add comments
1317 * src/gdcmDictSet.h : set the method BuildDictPath in public
1318 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1319 directly setted in the source code
1320 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1323 2004-01-09 Benoit Regrain
1324 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1325 * setup.py : use a reference to gdcmVERSION
1327 2004-01-07 Benoit Regrain
1328 * Modification to compile with the distutils.
1331 2003-12-10 Benoit Regrain
1332 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1333 can use a gdcmHeaderHelper to load datas
1334 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1335 made in the source code
1337 2003-12-10 Benoit Regrain
1338 * Update Windows projects and .cvsignore files
1340 2003-11-12 Jean-Pierre Roux
1341 * ENH gdcmHeader constructor has one more parameter (default value : false)
1342 that allows the user to 'go inside' the SeQuences only
1344 gdcmElValSet:Print takes it into account
1346 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1347 * ENH: Update gdcmPython/CMakeLists
1348 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1349 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1351 2003-11-10 Jean-Pierre Roux
1352 * FIX : gdcmHeader::LoadElements is now based
1353 on the ListTag listElem member,
1354 not longer on the TagElValueHT tagHt member
1355 * ENH : PrintPubElVal shows (temporarily) both results,
1356 with the tagHt member and the listElem member.
1357 (it's easier to 'see' the problems when using Printheader)
1359 * FIX : old private member LgrElem is now splitted into
1360 ReadLength : Length actually found on disk (updated only
1361 if bug fixing is necessary), for internal
1363 UsableLength : Updated by FixFoundLength, to fix a bug
1364 or to allow Parser going on.
1365 Will allow to re-write a kosher header when a SeQuence
1366 with a length (not 0000) is found
1367 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1368 because gdcmElValSet::Add does not update ListElem
1371 2003-11-07 Jean-Pierre Roux
1372 * FIX misstyping in Transfert Syntax name table
1373 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1374 when they have an actual length (not 0000 nor FFFFF)
1375 (Nobody should care of it, but DICOMDIR explorers)
1377 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1378 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1380 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1381 * ENH: vtkGdcmReader now supports LUT !
1382 (vtkgdcmViewer for now is not able to use them though)
1384 2003-11-05 Jean-Pierre Roux
1385 * in testSuite.py : new files names for checking the package
1386 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1387 that returns the pixel area size to the *aware* (vtk) user
1388 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1390 2003-11-05 Benoit Regrain
1391 * in testSuite.py : Modify the rules for checking the paths
1392 : Explicit error messages
1393 * in __init__.py : Related modif
1395 2003-11-03 Jean-Pierre Roux
1396 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1397 to be used by aware (vtk) users that want to manage
1398 LUT (and no to turn the PALETTE image into an RGB pixels one)
1399 * GetPixelType now returns 8U for 24 Bits images
1400 (vtkGdcmReader compliant)
1402 2003-10-31 Jean-Pierre Roux
1403 * Removal of *all* gdcmData images and add them again
1404 in order to loose the 'history' of un-anonymised images
1406 2003-10-31 Jean-Pierre Roux
1407 * RMV : removal of useless jBitsInJsample.h
1408 for both 8 and 12 Bits JPEG Lossy Libraries
1410 2003-10-31 Jean-Pierre Roux
1411 * ENH : Add the functions gdcmFile::GetImageDataRaw
1412 gdcmFile::GetImageDataIntoVectorRaw
1413 that act as GetImageData and GetImageDataIntoVector
1414 except the making of an RGB Plane from Gray Plane + LUT
1415 Intended to aware (vtk) users who know how to manage
1418 GetLUTRGBA return a R,G,B,A LUT if any
1419 lgrTotaleRaw gives the 'Raw' length
1420 GetImageDataRaw returns the gray Plane
1421 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1422 (They stay Grey, just like with other Dicom viewers :-(
1424 2003-10-30 Jean-Pierre Roux
1425 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1427 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1429 being coherents dicom files.
1431 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1434 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1435 * ENH: Two steps is necessary to please VC++ compiler...
1436 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1437 * ENH: Add include dir to medcon lib
1438 * FIX: only one function is being exported for now !
1439 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1441 2003-10-29 Jean-Pierre Roux
1442 * adding gdcmHeader::GetLUTRGBA
1443 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1444 --> Mathieu, the modif u're waiting for is not yet committed
1445 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1447 2003-10-27 Jean-Pierre Roux
1448 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1449 00191113.dcm DermaColorLossLess.dcm
1450 MxTwinLossLess.dcm RadBWLossLess.dcm
1451 * ENH: For version prior to vtkImageViewer2 -r 1.19
1452 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1454 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1455 * Removal of ido stuff in CMakeLists.txt
1457 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1459 * FIX: remove a call to ->Modified ... see comments
1460 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1462 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1463 * FIX: Problem with path for libvtkgdcmPython
1464 * ENH: Try adding a search script for python site-package
1465 * RMV: Remove some file from medcon lib that are not necessary
1466 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1467 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1468 * FIX: More pragma disable fro VC++,
1469 I don't think I break something as it is also disable in VTK/ITK.
1470 But it fasten debug compilation time.
1472 2003-10-23 Jean-Pierre Roux
1473 * gdcm now deals with 16 Bits Run Length Encoded images
1474 (they are compressed as 2 planes images,
1475 one for the high Bytes, the other for low Bytes)
1477 2003-10-22 Jean-Pierre Roux
1478 * Now CheckRead takes into account :
1479 - the bugged 'Leonardo' Siemens images
1480 - the XA images, sent thru the burning VPRO station
1481 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1484 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1485 * FIX: When copying a Makefile.am to CMakeLists.txt
1486 one should remove the '\'
1488 2003-10-22 Jean-Pierre Roux
1489 * in gdcmData adding a bugged 'Leonardo' Siemens image
1490 (wrong lengths in header)
1491 OK with gdcm, KO with the other viewers :-)
1492 * add a GE dlx XA image, thru the VEPRO burning station
1495 2003-10-21 Jean-Pierre Roux
1496 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1497 for a brutal checking of vtkgdcmViewer compliance
1499 2003-10-21 Jean-Pierre Roux
1500 * add the files for 'xmedcon' Jpeg Lossless library
1501 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1503 2003-10-21 Jean-Pierre Roux
1504 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1506 2003-10-21 Jean-Pierre Roux
1507 * garbage Siemens 'Leonardo' images dealt with
1508 (the patch is easy to remove)
1509 * cosmetic changes to avoid warnings
1511 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1512 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1513 no need to press 'r' now.
1515 2003-10-20 Jean-Pierre Roux
1516 * upgrade of checkRead.sh checkWrite.sh according
1517 to new Jpeg Lossless decompressor
1518 * add US.3405.1.dcm, a genuine RGB medical file ...
1519 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1520 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1522 2003-10-15 Jean-Pierre Roux
1523 * general anonymisation in gdcmData
1524 * adding the 'color files' from
1525 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1526 * adding some well knowed bugged-header images
1527 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1528 waiting for their inclusion in Python testsuite
1530 2003-10-15 Jean-Pierre Roux
1531 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1532 no longer seg faults when file is not found
1534 2003-10-14 Jean-Pierre Roux
1535 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1538 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1539 * TODO: *.in file to genereate a UseGDCM later
1541 2003-10-14 Jean-Pierre Roux
1542 * Some supposed-to-be Dicom Images have no preamble.
1543 OpenFile takes it into account
1544 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1545 * Missing elements added in dicomV3.dic
1546 (just to be affraid : have a look at
1547 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1548 and do it again next year ;->
1550 2003-10-13 Jean-Pierre Roux
1551 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1552 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1553 But there are NOT. It's fixed !
1555 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1556 * FIX: "jpeglib.h" was not found on VC++
1557 * FIX: vtkgdcm was not being installed
1559 2003-10-10 Jean-Pierre Roux
1560 * ENH : OpenFile closes the file if it *really* doesn't look like
1561 an ACR-NEMA / DICOM one.
1562 * FIX : testWrite no longer writes an empty file if the source file
1563 is not gdcm Readable
1564 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1567 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1568 * FIX: CMake generate now documentation
1569 * ENH: out of source doc build !
1570 * ENH: Generate both user and dev documentation
1571 * ENH: Should work on windows too
1572 * ENH: Only one doxygen config.in file is needed
1573 * FIX: make install should be ok now on ùnix plateform
1574 * FIX: PATH to dictionary was wrong (missing /)
1575 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1577 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1578 * vtkGdcmReader is now able to read rgb dicom file.
1579 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1580 * added a gdcmViewer to vtk test, use mouse to control
1581 window level & window width
1583 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1584 * CMake-ification of gdcm, we have now two build system
1585 * FIX: on cygwin Wsock32 doesn't exist
1586 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1588 2003-10-06 Emanuel Ollart
1589 * FIX : compilation process wad broken.
1590 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1592 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1593 * change gdcmViewer -> vtkgdcmViewer
1594 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1596 2003-10-06 Jean-Pierre Roux
1597 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1598 ( e.g : well known GE images with a wrong elem length,
1599 : Philips MRI Images with a wrong Huffman table)
1600 * still to be done : allow the reading of bugged LEONARDO Siemens images
1602 2003-10-03 Jean-Pierre Roux
1603 * Odd length strings are padded with '\0' (not with spaces,
1604 to remain compliant with already defined strings,
1605 like Transfert Syntax UID and others)
1607 2003-10-03 Jean-Pierre Roux
1608 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1609 to allow displaying RGB images (not only by affim ;-)
1611 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1612 * vtkGdcmReader is now able to read rgb dicom file.
1613 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1615 2003-10-03 Jean-Pierre Roux
1616 * A few nasty patches to allow the reading of a lot of nasty images
1617 ( e.g : well known GE images with a wrong elem length,
1618 : Philips MRI Images with a wrong Huffman table)
1619 * still to be done : allow the reading of bugged LEONARDO Siemens images
1621 2003-10-03 Jean-Pierre Roux
1622 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1624 2003-10-03 Jean-Pierre Roux
1625 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1626 to allow displaying RGB images (not only by affim ;-)
1628 2003-10-03 Jean-Pierre Roux
1629 * gdcmFile::GetImageDataIntoVector now
1630 - deals with MultiFrames MultiFragments Run Length Encoded files
1631 - deals with YcBcR (YBR_FULL) files
1632 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1633 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1635 (no sample found :-(
1637 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1638 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1639 Two reasons: - clear things
1640 - third parties acces gdcm through header files, so won't
1641 suffer anymore VC++ complains
1643 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1644 * add argv[1] in testvtkGdcmReader.cxx
1647 2003-09-24 Jean-Pierre Roux
1648 * The lines are now eigthy characters long.for
1649 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1651 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1652 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1653 char* to std::string. Thus, the use of strdup becomes useless. (see
1654 previous commis of Malaterre)
1655 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1656 before the last Malaterre's commit.
1658 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1659 * This commit should fix the Debug building under VC++, the problem
1660 was mainly a mixture of debug and release lib being loaded at startup.
1661 * I also remove a depency to a specific C function: strdup. Because I had
1662 to force the link to msvcrtd (whereas strdup is in libc).
1664 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1665 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1666 located in the gdcmCommon.h file. All use of reference of tha has been
1667 changed to now use the variable GDCM_UNFOUND.
1669 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1671 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1672 Dicom dictionary. The test suite can now be run again. Note:
1673 I'm note very happy with the " (RET)" changes. I believe this
1674 RETAINED comment should be dropped when parsing the dictionary.
1675 - PACKAGER corrected
1677 - AUTHORS updated and now in alphabetical order
1678 * Makefile.am now exports gdcm.dsw for Windoze users.
1680 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * cygwin complains about missing std:: in subdir Test/
1683 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1684 * remove some methods that are now in gdcmHeaderHelper
1686 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1687 * vtkGdcmReader set spacing and origin correctly
1689 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1690 * Fix a few delete/delete[] mismatch
1692 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1693 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1694 interpretation to data given by gdcmHeader. For instance there are
1695 heuristics to get informations (look at different places).
1696 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1697 sorting DICOM images based on different strategies.
1698 * modified Makefiles accordingly.
1700 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1701 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1702 when building in debug mode
1703 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1704 src/win32/gdcmdll.dsp
1705 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1707 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1711 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * src/win32/libgdcmjpeg12.dsp was not dos format
1713 * src/win32/libgdcmjpeg12.dsp :
1714 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1715 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1717 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1718 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1720 * src/gdcmFile.cxx : bug fix in affectation type
1721 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1722 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1723 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1724 symbols... future problem ?
1726 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * src/win32/libgdcmijpeg12.dsp was missing
1728 * modified gdcm.dsw accordingly
1730 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1731 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1733 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1734 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1735 commit of JPR (before his hollidays to facilitate our work).
1736 * setup.py : bug fix in code. Modifications made while the last commit
1737 of JPR. The code hasn't been tested before the commit... it's so
1738 useless to make that (for best programmer that is JPR) !!!
1740 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1741 * tagged the current version as Version0_3 (i.e. version 0.3)
1743 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1744 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1745 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1746 * *.dsp : modifications to use new libgdcmijpeg8 library
1747 * setup.py : bug fix on VTKPATH variable
1748 * PACKAGER : adding all concerning windows
1750 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1751 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1753 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1754 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1755 test suite reported error.
1756 * PACKAGER file added (describes what a packager must do when
1757 packaging a new release).
1758 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1759 * configure.in: upgraded version number to 0.3.0
1760 * fixing build of rpm (through rpm -ta):
1761 - Doc/Makefile.am exports proper doxygen files
1762 - src/jpeg/libijg8/Makefile.am exports the include files.
1764 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1765 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1766 * src/gdcmHeader.h : formatting code
1768 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1769 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1770 We were obtaining error message from vtk. Now, creation of file list
1771 is made in an internal list to prevent this problem.
1772 Bug fix when output is empty.
1773 Bug fix in update of progress value. Previous commit for this was a bad
1775 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1777 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1778 * src/gdcmHeader.h : added method to get the file name
1779 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1780 files. Added method to remove all files on the input
1781 Added FIXME comment concerning the bad parsing of header made by
1782 ExecuteInformation method (in ExecuteData method)
1784 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1785 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1786 when using make instal.
1787 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1788 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1790 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1791 * setup.py : adding include dir of jpeg lib to compile all sources
1792 * */Win32/*.dsp : JPR fix for windows compilation
1794 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1795 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1797 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1798 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1800 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1801 * setup.py is again effective on un*x (takes into account the
1802 addon of the jpeg library)
1803 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1804 * Doc/Doxy* updated (includes above enhancements)
1805 * INSTALL now points to web documentation
1807 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1808 * src/gdcmHeader.h doesn't make unnecessary reference to
1810 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1812 * src/gdcm*.[cxx|h] :
1813 - to allow compilation with gcc 3.x
1814 -- clean up of STL usage (added explicit usage of std::)
1815 -- small fixes on exceptions.
1816 Note: linking not tested !
1817 - clean of doxygen comments to avoid warnings at documentation
1819 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1820 dependent convertion).
1822 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1823 * Clean up of previous JPR garbage commit (not even commented in the
1825 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1826 - moved all jpeg related files from src to src/jpeg/libijg8, with
1827 addition/modification of Makefile.am and configure.in.
1828 - the testSuite is still brain damage (not guilty).
1830 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1831 * WrapVTK.py : modifications to get correctly vtk source files to
1833 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1834 (FileName -> Filename)
1836 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1837 * vtk/vtkGdcmReader.[cxx/h]:
1838 - UpdateProgress method should now be effective
1839 - removed the limitation on having only images loaded (as opposed
1841 - when building a stack of images/volume, a lesser number of
1842 gdcmHeader and gdcmFile instances should be used (hopefully
1843 accelerating things).
1844 - when building a stack of images/volumes, files which are not
1845 loadable (wrong path-filename, wrong permissions on existing file,
1846 or file not parsable by gdcm) are replaced with a black image
1847 in the stack (for the caller to notice the problem).
1849 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1852 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1853 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1854 between standard library (std) and vtk library (problems are found
1855 under Windows... thanks Windows !)
1857 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1858 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1860 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1862 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1863 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1865 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1866 * When compiling with distutils (see setup.py) the C++ compiler is
1867 called with different flags than the default ones (with automake).
1868 In order to fix all those warning, I compiled gdcm with the command
1869 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1870 and went for warning fixes:
1871 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1872 up from unused variables.
1873 - vtk/vtkGdcmReader.cxx: potential bug fix.
1874 * src/gdcmHeader.h: Doxygen warning cleanup
1876 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * gdcmPython/gdcm.i:
1878 - typemaps correction to take into account the systematic replacement
1879 of "using namespace std" with std:: prefix e.g. std::list,
1880 std::string... (cf changes of 2003-05-21).
1881 - gdcmGlob global variable of type gdcmGlobal (defined in
1882 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1883 exported to Python a as cvar.
1884 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1885 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1886 gdcmDictSet.GetPubDictTagNames() and
1887 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1888 C++ static methods).
1889 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1890 with the above changes.
1892 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1893 * setup.py, manifest.in : bug fix under linux
1895 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1896 * Modification of setup.py to compile vtk part too. Then, we have 2
1897 wrappers which must work with same distutils. For that, we have a
1898 generic distutils in distusiltsWrapping.py ; with :
1899 - build_extWrap class to wrap generically all extensions,
1900 - ExtensionWrap base class for all wrapping extension that contains
1902 - Wrapper interface which wrap sources
1903 + In WrapSwig.py we have extension and wrapper for Swig
1904 + In WrapVTK.py we have extension and wrapper for VTK
1905 * MANIFEST.in : modifications to consider vtk directory and new python
1906 files for compilation
1908 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1909 * Added python wrappers of vtkGdcmReader vtk class (see the
1910 source in vtk/vtkGdcmReader.cxx) :
1911 - vtk/Makefile.am now builds a library
1912 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1913 python library (as opposed to _gdcm.so wich are the python
1914 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1915 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1917 - configure.in has an additional flag --enable-vtk that needs
1918 to be set to enable compilation of vtk related code, that is:
1919 + vtk/vtkGdcmReader.so and
1920 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1921 + gdcmPython/vtkgdcmPython.so (see above)
1922 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1923 be read when compressed or when HighBit + 1 != BitsStored),
1924 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1925 the usage of the python wrapper of vtkGdcmReader vtk class.
1926 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1927 * src/*.[h] all occurences of stl classes are now prefixed with
1928 std::, and all occurences of "using namespace std;" where removed.
1929 This is to avoid pollution of global namespace in included files.
1930 Apparently vtk does not avoid this pitfall: when using both
1931 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1932 collision of various stl members (principally cout...).
1933 * gdcmPython/testSuite.py now cleanly removes temprory generated
1935 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1936 comply with above changes)
1938 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1939 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1940 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1941 vtk data structure (an image Flip was required).
1942 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1943 * cosmetic changes in documentation.
1945 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1946 * src/gdcmHeader.cxx: the constructor no longer exits when an
1947 unexisting file is given as argument.
1948 * The subdirectory Data (containing all the images used for the
1949 test suite) is not part of this repository anymore. A new module
1950 containing those images is now available at
1951 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1952 with the name gdcmData.
1953 All the python scripts (including the package initialisation file
1954 gdcmPython/__init__.py) were adapated to take this change into
1955 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1957 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1958 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1959 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1960 demo of the usage of this class.
1961 Compilation of this vtk part is only done when using the --enable-vtk
1962 at configure (or autogen.sh) stage.
1964 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1965 * More memory link related corrections and documentation fixes.
1967 - maximum info is obtained with a command of the form:
1968 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1969 --show-reachable=yes PrintHeader
1970 - the remaining reachable blocks seem to come from the STL
1971 allocation scheme through the usage of map and list. It looks
1972 like this memory cannot be freed but it is not a memory leak
1973 (in fact further invocation to the STL would recollect the
1974 unused memory allthough it cannot explicitely be freed).
1975 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1976 of displaying an image parsed with gdcm and displayed with VTK.
1977 Note: some images don't seem to work e.g.
1978 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1979 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1980 Allthough this weakens the semantics, it is a ditch attempt to
1981 make gdcm more thread friendly.
1983 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1984 * Memory link hunt (by using valgrind through the command
1985 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1986 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1987 gdcmHeader::_dicom_vr.
1988 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1989 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1991 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1993 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1994 * src/Makefile.am now exports all the necessary include files at
1998 * UpdateGroupLength replaced by new one
2001 * UpdateGroupLength re-written using H-Table
2002 (named UpdateGroupLengthNew untill checks are over)
2004 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2005 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2006 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2008 - gdcmHeader::GetPubElValSet removed.
2009 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2010 UpdateGroupLength, WriteElements, Write.
2011 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2012 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2013 carried the same semantics.
2014 - src/gdcmHeaderIdo.cxx changed accordingly.
2015 - gdcmFile::WriteBase now regroups all the codes from previous
2016 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2017 - enum FileType moved to gdcmCommon.h
2018 * src/gdcmHeader.cxx AddDefault trashed
2019 * gdcmGetXSize added
2020 * getimageDataSize now calls gdcmGetXSize
2021 * Test/*.cxx changed to agree with above changes
2023 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2024 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2025 (to avoid double call by end user).
2026 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2027 by end user, since gdcmHeader::gdcmHeader now handles it.
2029 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2030 * gdcm/Doc many doxygen changes:
2031 - Doxyfile now has two different versions, DoxyfileUsers that generates
2032 the html.users end users oriented documentation and
2033 DoxyfileDeveloppers that generates the html.developper developper
2034 oriented documentation.
2035 - README changed accordingly
2036 - requirement.txt removed (old design info moved to TODO).
2037 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2038 DoxyMainPage.txt, DoxyPython.txt provide more information.
2039 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2040 be updated by simply regenerating the docs with doxygen and copying
2041 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2042 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2043 all the tests in the form "if (<map>.count() >1)" were removed.
2044 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2045 ill-formed documentation sections.
2046 * src/gdcmHeader.cxx: ditto
2048 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * setup.py fixed for un*x (needed macro for stdint.h)
2050 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2051 un*ces with sh-utils test utility.
2052 * gdcmPython/demo/test.py renamed to PrintHeader.py
2053 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2054 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2055 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2056 * src/gdcm*.cxx JPR's bad inclusion fixed.
2058 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2059 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2060 * gdcmPython/demo/test.py changed accordingly.
2062 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2063 * gdcmPython/Makefile.am fixed linking against libstdc++
2064 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2065 * Swig subdir (historical tests of swig version 1.3.17++) removed
2066 * Test/testChangeEntete.cxx some lines commented out in order to make
2068 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2069 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2071 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2072 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2073 hence the user doesn't need this explicit call.
2074 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2075 i.e. LoadElements() call removed.
2076 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2077 - src/Makefile.am declares the proper flag for g++.
2078 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2079 for adding user defined new tags.
2080 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2081 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2082 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2084 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2085 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2086 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2087 src/Makefile.am : the project should properly compile and install
2088 with the autotools, included the python wrappers part.
2089 * gdcm.spec.in : added a spec file for RPM packaging.
2091 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2092 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2094 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2095 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2096 to exported to the environement (see gdcmPython/testSuite.py
2098 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2099 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2100 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2101 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2102 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2104 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2105 * gdcmPython/__init__.py doesn't crash anymore when running in
2106 in InstallMode or PreInstallMode but with an environement given
2107 value of GDCM_DICT_PATH.
2108 * src/gdcmDictSet.[cxx/h] coding style.
2110 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2112 * src/gdcm.h general comments moved to TODO, and README
2113 * src/gdcm.h should now be seen as a user commodity (including it
2114 should suffice to fully use gdcm). It is nowhere including within
2115 any of the kernel files src/*.cxx and src/*.h.
2117 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2119 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2121 * src/gdcm*.cxx only include their corresponding include file
2122 (as opposed to gdcm.h)
2123 * gdcmPython/gdcm.i changed accordingly
2124 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2125 the autogen.sh generated "make snapshot" command to work.
2126 * autogen.sh removed history related references to crea package.
2128 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * distutilsSwigCPlusPlus.py work around some swig portability
2132 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2133 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2134 was done in a last ditch attempt to get setup.py _really_
2135 operationnal. The python/gdcmPython layaout add the advantage
2136 of hidding away the python related distutils specific files
2137 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2138 Alas, the src directory was out of scope (i.e. it's relative
2139 position to setup.py was ../src) which made things impossible to
2140 handle (see previous version of python/setup.py). Crossing fingers...
2142 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * python/setup.py now works on Un*x. (harder than I thougth)
2144 * python/distutilsSwigCPlusPlus.py can now have include files
2145 among the list of sources.
2147 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2148 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2149 * modifications in MSVC projects
2151 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2152 * As stated by the first lines of Test/ExceptionAndPython/README, it
2153 looks like we can move back to original usage of exception within
2154 src/gdcm* and hence remove the errno stuff that was introduced
2155 as a quick and dirty fixture of this problem (added to the TODO).
2156 * Doc/Doxyfile configuration file for Doxygen and corresponding
2157 README file for usage added.
2158 * Test/testWrite.cxx added. This new test comes from a split of
2159 test.cxx that is now reverted to its original purpous i.e.
2160 testing the proper parsing of a Dicom related file.
2161 testWrite.cxx concentrates on testing the IO part of gdcm.
2162 * Test/bug1.cxx (containing a bug on WIn32) added.
2163 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2164 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2165 whose purpose is to publish the content of the TagNames of the
2166 Dicom public dictionnary were not accessible without an
2167 instance of class gdcmHeader.
2168 - those methods are now static methods of gdcmDictSet and hence
2169 require no instances at all to be invocated.
2170 - within gdcmDictSet this change required to change some method
2171 to class methods (i.e. are now static) among which SetDictPath
2172 (renamed to BuildDictPath) and LoadDefaultPubDict.
2173 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2174 the above changes by calling the new method classes of gdcmDictSet.
2175 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2176 the above to be effective.
2177 * python/gdcmPython: in order to wrap properly the above changes
2178 for Python, swig version now needs to be > 1.3.17.
2179 * python/gdcmPython/Makefile fixed to adapt itself to new
2180 configure/make shema introduced by Johan Montagnat (thanks for the
2181 contribution). Alas this Makefile cannot be turned into a proper
2182 Makefile.am without some heavy changes in the configure.in
2183 (for python dectection).
2184 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2185 now avoids publishing the empty entries.
2187 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2188 * python/setup.py : bug fix concerning install under windows
2189 ExtraPath reused :-P
2190 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2192 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * Dicts/dicomV3.dic : remove double spaces !!!
2194 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2195 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2198 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2199 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2200 method. Doxygenation.
2201 * src/gdcm.h clean up of JPR spurious comments.
2203 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2204 * python/distutilsSwigCPlusPlus.py now properly collects the
2205 shadow classes generated by "swig -c++" (gdcm.py in our case)
2206 when using "python setup.py install".
2207 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2208 reexports the working classes.
2209 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2210 by the classical C errno scheme. This is to prevent an obscure
2211 behavior of the python wrappers when importing wxPython.wx prior
2212 to gdcmPython (which ended up in an abort call). An illustration
2213 of this oddity can be found in the Test/ExceptionAndPython
2214 subdir (see the README file). This problem probably due to
2215 an combination of g++ and dynamic loading.
2216 * added Test/ExceptionAndPython (see above)
2218 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * Changed the layout of the python part to avoid bloating main
2220 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2221 i.e. the distutils arsenal. All the python related stuff is
2222 again in a python subdir, but the package itself is now in
2224 * setup.py was cleaned up:
2225 - pythonIncludePath removed
2226 - python setup.py bdist target is now functional.
2227 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2228 collision with other packages). gdcmPython/demo/*.py changed
2231 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2232 * python subdir moved to gdcmPython (preparation of distutils packaging).
2233 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2234 distutils installer is operational.
2235 * - gdcmPython/__init__.py now properly loads the swig generated
2236 shadow classes (from gdcm.py).
2237 - gdcmPython/demo/*.py changed to import the package gdcmPython
2238 instead of gdcmPython/demo/load.py.
2239 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2241 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2242 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2243 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2244 entries within the associated public Dicom dictionary resp. the same
2245 information but sorted by the fourth field (PAT, IMG, DIR) of the
2247 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2248 are now in the "???" group.
2249 - python/gdcm.i changed accordingly,
2250 - python/demo/printGroupedPublicDict.py added, that gives an example
2251 of the above new functionalities in Python.
2253 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * src/gdcm.h, gdcmHeader.cxx:
2255 - historic references to glib's g_malloc and g_free (#defined)
2256 were definitively removed.
2257 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2258 * src/gdcmElValSet.cxx:
2259 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2260 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2261 - GetElValue(string) renamed to GetElValueByName.
2262 - Added GetElementByName(string).
2263 * src/gdcmHeader.cxx: added
2264 - GetPubElValRepByNumber(guint16, guint16)
2265 - GetPubElValRepByName(string)
2266 - GetShaElValRepByNumber(guint16, guint16)
2267 - GetShaElValRepByName(string)
2268 - GetShaElValByNumber(guint16, guint16)
2269 - GetShaElValRepByName(string)
2270 - GetElValRepByNumber(guint16, guint16)
2271 - GetElValRepByName(string)
2272 - GetElValByNumber(guint16, guint16)
2273 - GetElValRepByName(string)
2274 * Doc/requirements.txt added.
2276 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * Test/Makefile building now depends on the one of libgdcm.so
2278 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2279 pixel data) aware which enables finding the address (offset) of
2280 the pixel data of JPEG encoded DICOM files. This leaves only a single
2281 file in the testSuite whose pixel data address (offset) is unknown.
2282 * python/testSuite.py changed accordingly.
2284 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2285 * VC++ has some strong limitations when working with the STL, as stated
2286 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2287 "Also note that some STL containers (map, set, queue, list, deque)
2288 cannot be exported. [...]
2289 Some STL classes contain nested classes. These classes can not
2291 This is caused by a designed limitation that once a template
2292 class is instantiated, it can not be re-instantiated and
2294 Since our usage of map<> is ubiquitous in gdcm, this "designed
2295 limitation" of VC++ is a pitfall.
2296 Hence the Python wrappers of gdcm cannot be incrementally linked
2297 against the c++ dynamic library. The dirty but only workaround is
2298 to forget about incremental link of dynamic libraries and to generate
2299 the Python wrappers library with the inclusions of the underlying C++
2301 The following modifications concern this matter on Win32/VC++:
2302 - wrapping python correct with standalone wrapped dll (don't use separate
2303 dll under windows !!!!)
2304 - python21_d debug mode enabled (ask Frog how to use it :-)
2305 - NO problem with having an STL member of class for example string in C++
2306 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2307 - Python test of dcmlib in Python is ok under windows on a large set
2309 * removed glib references
2310 * typedef's inserted in gdcm.i for correct swig type management
2312 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2313 * python/demo/*.py load.py extracted from test.py. Added explore.py
2314 that only displays required tags and testAll.py that parses all
2315 the files of the testsuite without using unittest.
2316 * python/testSuite.py other additional test on new files added.
2317 * Data/* new test files added accordingly to the testSuite.
2318 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2319 the vr in the file differs from the one of the dictionary.
2321 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2323 values, but limits itself to values which are below a user specified
2324 size (by default 1024 bytes).
2325 * python/gdcm.i : elements not loaded (because their size is above the
2326 user specified treshold) are exported with their TagKey as key of the
2327 python dictionary. This enables the testsuite to make some checks
2328 on the unloaded elements (since we have their offset and size).
2329 * python/testSuite.py
2330 - now tests for the existence and proper value of the pixel data
2331 - two new examples added.
2332 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2334 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2335 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2336 aware. See the strategy comments in gdcmHeader::FindeLength().
2337 * Test/test.cxx now accepts a filename as first argument.
2338 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2339 * python/testSuite.py changed to integrate test on above files.
2341 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2342 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2343 the vr was also RET.
2344 * python/testSuite.py more tests added.
2346 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2347 * python/testSuite.py unittest test suite added (uses Data)
2348 * Data/* dcm and acr files for the test suite.
2349 * glib dependance removed from un*x version. We now use ISO C99
2350 7.18 Integer types (see stdint.h)
2351 - python/Makefile, src/Makefile src/gdcm.h
2352 * src/ when an explicit vr (like dicom files) suddenly poped an
2353 implicit element we use to mark the underlying DictEntry of the
2354 concerned ElValue with "Implicit". This strategy was damageable
2355 too the public or provite dictionaries, since some of their vr
2356 would be changed. Since Header::FindLength heavily relies on the
2357 detection by Header::FindVR of falsely explicit elements, I
2358 added an extra ImplicitVr member to ElValue (boolean).
2359 The rest of the changes we the necessary adaptations.
2361 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2364 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2366 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2367 * Adaptation for porting to VC++:
2369 o forced to use std namespace (for string to be known)
2370 o all class use __declspec export style on WIN32
2371 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2372 (in stdlib.h on Win32 but in std:: for gcc)
2373 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2374 variable GDCM_DICT_PATH.
2375 * src/gdcmHeader.cxx verbose comments made discrete.
2377 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * python/gdcm.i: added a typemap that converts a C++ hashing table
2379 to native Python dictionary.
2380 * python/demo/test.py:
2381 - now uses the native dictionary for exploration of gdcmHeader.
2382 - takes an optional filename argument (the file to parse).
2383 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2384 PubElVals hashing table.
2385 * Dicts/dicomV3.dic removed error prone trailing spaces.
2387 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2388 * Python wrapping process moved away from src/Makefile to
2389 newly created python/Makefile (as well as gdcm.i)
2390 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2391 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2392 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2393 from the environement variable GDCM_DICT_PATH (when existing).
2394 * src/gdcmDict::GetTag bug fix.
2396 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2397 * Straightforward temporary fixes for swig to build the python wrappers.
2398 src/Makefile now has a python working entry [by working we mean
2399 that we can import de shadow classes without errors].
2401 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * hashtest.cxx removed (since allready in Test)
2403 * src/gdcmlib.h renamed to src/gdcm.h
2404 * src/dcm.i renamed to src/gdcm.i
2405 * src/Makefile prepared for python wrapping
2407 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * src/gdcmHeader.cxx :
2409 - Parsing of header is now separated from loading of element values
2410 (see gdcmHeader::LoadElements).
2411 - general clean up of hopefully all file access (creation of
2412 ReadInt16 and ReadInt32)
2414 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2415 * src/gdcmHeader.cxx :
2416 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2418 - SetLgrElem renamed to SetLength
2419 - GetLgrElem renamed to GetLength
2420 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2421 * src/gdcmElValSet.cxx fixed both GetElValue methods
2422 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2423 due to IdoDude was cleaned out.
2425 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2426 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2427 concentrates on finding the value representation (when it exists).
2428 RecupLgr now only finds the element value length, and it avoids
2429 returning the unecessary skL (skipped length).
2430 Also, offsetCourant was simply removed (with taille_fich) since
2431 it was redundant with the File position internals (by using
2432 ftell and fseek). This also made skL (see above in RecupLgr) usage
2434 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2435 on the libido specificities which are handled through class
2437 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2440 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * Truckload of changes. Parsing of header is barely functional
2442 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2444 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2445 * src/gdcmHeader.cxx many addons of low level methods
2447 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2448 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2449 and _IdDcmSWAP_LONG.
2451 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2452 * This corresponds to all the changes decided at the meeting of
2453 May 23 2002. Needless to say we are running late...