1 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * TODO updated with Mathieu suggestions. I proposed a template for
3 describing TODO entries and used it for new entries.
4 * Added Doc/Website/CodingStyle.html, Developpers.html,
5 DeveloppersPython.html, GdcmDataCvs.html and
6 DownloadVersion0_1.html, DownloadVersion0_3.html.
7 * Some Doc/*.txt Doxygen files (which do not really concern the
8 documentation itself, but the website) moved to html and
9 placed in directory Doc/Website:
10 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
11 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
12 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
13 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
14 * CMakeLists.txt changed accordingly.
15 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
16 DeveloppersPython.html
17 * INSTALL nows refers to Doc/Website/Installation.html
19 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
20 * Added Doc/Website directory, that contains a first raw version
23 2004-09-23 Jean-Pierre Roux
24 * FIX In order not to be poluted any longer by casting problems,
25 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
26 we can now delete[] it safely
27 * VoidArea is now called BinArea (less confusing name),
28 and all the methods called ...VoidArea... are now ... BinArea...
29 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
31 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
33 clear) TagHT, which is an inherited member of gdcmElementSet. It is
34 up to the destructor of gdcmElementSet to clean up TagHt and it's
37 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
38 * Test/CMakeLists.txt: update to follow gdcmData renamings.
39 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
41 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
42 * ENH: added some utility method that builds a flat dictionnary
43 holding all the Dicom entries contained in the recursive structure
44 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
46 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
47 BuildFlatHashTable() that build a flat dictionary.
48 - src/gdcmElementSet.h: added a new private GetTag() accessor.
49 gdcmDocument is now a friend of gdcmElementSet.
50 - src/gdcmElementSet.cxx: clean up.
51 - Example/FlatHashTablePrint.cxx added.
52 - Example/CmakeLists.txt changed accordingly
54 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
55 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
56 moved away from gdcmDocEntrySet (since this class is an abstract class
57 acting like an interface). SQDepthLevel and BaseTagKey are now
59 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
60 and associated accessors. Doxygenation of the class.
61 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
63 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
64 Use SQDepthLevel accessor instead. ::Print() adapted.
65 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
66 - src/gdcmDocument.cxx changed accordingly.
68 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
69 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
70 - The following is the doxygen comment of the typedef declaration
71 of gdcmagKey in src/gdcmCommon.h:
72 gdcmTagKey is made to old an "universal" (as in URL, Universal
73 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
74 A dicom tag allways has a group and an element, but a set of tags
75 embeded in various (optionally nested) sequences and sharing
76 the same group and element all share the same (group, element)
77 "identifier". Hence the (group, element) cannot be used as an
78 identifier (in gdcm we shall refer to a "TagKey") of a tag.
79 In order to construct a proper tag identifier (i.e. a key) we
80 consider the following definition of a TagKey:
81 - let Group, Element be the string representation of the
82 group and element dicom tag members,
83 - let ItemNumber be the string representation of the integer
84 index of the considered item number of a sequence,
85 Let the key of a tag embeded in a sequence, noted SeqTag, be
87 /ItemNumber#Group|Element
88 where "/", "#" and "|" are characters acting as separators.
89 Then the general form of a gdcmTagKey is given by:
91 where <SeqTag> means NO or many instances of SeqTag.
92 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
95 but the gdcmTagKey of a tag "embeded" is the first item of
96 a sequence, itself nested in the third item of a sequence is the
98 0004|1220/2#0008|0082/0#0008|0090
99 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
100 order to hold the new sequence compatible key. Previously, the
101 GetKey() method would look in the underlying gdcmDictEntry.
102 - src/gdcmDocEntry.cxx:
103 -- constructor now copies the underlying DictEntry key, in the local
105 -- ::Print: displays the member Key, instead of the (group, element).
106 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
107 - src/gdcmDocEntrySet.h:xi
108 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
109 -- now has a new BaseTagKey member.
111 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
112 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
114 This poses the problem with the semantics of the following lines
115 LoadEntryVoidArea(0x0028,0x1201); // R LUT
116 LoadEntryVoidArea(0x0028,0x1202); // G LUT
117 LoadEntryVoidArea(0x0028,0x1203); // B LUT
118 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
119 to the long FIXME note for what the problem is. Nevertheless in
120 order to get things working the dicom dictionary was altered !
121 Please fix things urgently...
122 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
123 information), see above note on moving the member VoidArea. Nevertheless
124 the following entries previously correctly set as US are now inproperly
126 0028 1201 OW IMG Red Palette Color Lookup Table Data
127 0028 1202 OW IMG Green Palette Color Lookup Table Data
128 0028 1203 OW IMG Blue Palette Color Lookup Table Data
129 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
130 of gdcmDocEntry moved to gdcmSeqEntry.
131 * src/gdcmSeqEntry.cxx: STYLE.
133 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
134 * Test/TestAllEntryVerify.cxx minor fix and added comments.
136 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
137 * gdcmPython/testSuite.py: all the test suite in python is now moved
138 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
139 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
140 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
142 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
143 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
144 to avoid inclusion recursion until STL is reached.
145 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
146 mecanism. errno.h is not included in gdcm anymore.
147 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
148 (gdcmFormatError now inherits from gdcmFormatUnexpected).
150 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
151 gdcmData/TestAllEntryVerifyReference.txt
152 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
153 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
154 exception_on_error parameter.
155 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
156 - vtk/vtkGdcmReader.cxx changed accordingly,
157 - Example/*.cxx and Test/*.cxx changed accordingly.
159 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
160 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
161 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
162 enable_sequences removed from gdcmHeader constructor and dependencies.
163 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
164 * gdcmPython/demo/PrintHeader.py: dummy fix.
165 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
166 skip_shadow removed from gdcmHeader constructor and dependencies.
167 * Example/*.cxx and Test/*.cxx changed accordingly.
169 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
170 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
171 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
173 2004-07-21 Jean-Pierre Roux
174 * FIX Now, Parsing and Printing a DICOMDIR do work!
175 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
177 2004-07-20 Jean-Pierre Roux
178 * FIX Some brain damaged headers have Zero-Lenght fields
179 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
181 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
182 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
183 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
184 variable (instance of gdcmDebug) by a definition macro, and the instance
185 is now in static in the gdcmDebug class
186 * src/gdcmSQItem.h : (FIXME) remove an undefined method
187 * Test/PrintAllDocument.cxx : bug fix in the result of the test
189 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * WARNING: ctest now depends more tightly on gdcmData. You should
191 check out gdcmData properly for things to run smoothly...
192 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
193 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
194 we need the pixels not be loaded in order to use the ValEntry
195 that displays position and size).
196 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
197 This is a C++ based equivalent of gdcmPython/testSuite.py that should
198 be deprecated. If you have any doubts about the advantages of a
199 modern scripting language (read Python) versus grass root C++ (i.e.
200 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
201 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
202 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
203 Anyhow, consider documenting the gdcmData images in
204 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
206 * Test/CMakeLists.txt:
207 - now uses TestAllEntryVerify.cxx
208 - specific comments on oldACR00001.ima (now renamed in gdcmData
209 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
210 gdcmData/TestAllEntryVerifyReference.txt
213 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * src/*.[h|cxx] : typedef clean up
215 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
216 - TagKey renamed to gdcmTagKey (for external usage)
217 - VRKey renamed to gdcmVRKey (for external usage)
218 - removal of typedef duplication.
219 - Removed all unecessary inline keyword from class inline definitions.
220 - Some method|function(void) declarations replaced with method|function().
221 * src/jpeg/libijg12/jdhuff12.c:
222 - printf polluting ctest removed.
223 - TAB removal for comminting
225 - TestAllReadCompareDicom.cxx: added a test that compares all the
226 images in gdcmDataImages.h with corresponding images in
227 gdcmData/BaselineDicom/. When baseline images are not present
228 this test creates them.
229 Note: we need to validate each reference image, but before that
230 I'd like to rename them with a more explicit name...
231 - CMakeLists.txt: changed accordingly.
232 * Example/*.cxx: examples now only include gdcm.h (as opposed to
233 including each header needed).
235 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
236 * Test/*.cxx and Example/*.cxx: moved some examples away from the
237 test suite to the Example directory. Are concerned:
242 - TestWriteSimple.cxx
243 * Test/CMakeLists.txt: added some comments on reasons for black listing
244 image gdcmData/oldACR00001.ima
246 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
247 * Test/CmakeList.txt: removed the following from black list (to be coherent
248 with removal from gdcmData):
249 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
250 - gdcm-MR-PHILIPS-16.dcm
252 Added the following because after last cvs update, they cause
253 ctest -R TestReadWriteReadCompare
255 - gdcm-MR-SIEMENS-16-1.acr
257 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
258 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
259 new comments in this file) we temporarily (sigh) move to a weaker
261 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
262 we don't need to black list the following images anymore:
263 - 8BitsUncompressedColor.dcm
265 - US-PAL-8-10x-echo.dcm
266 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
267 fixes and the beautified code ;-)
268 This fixes the bug introduced in version 1.42 (when beautifying)
269 that made the parsing of 8BitsRunLengthColor.dcm unproper.
270 Note: ctest was blind to this bug (this means we need to still
271 improve the test suite). The bug could be detected by using
272 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
274 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
275 and by displaying the (garbage) produced file temp.XDCM...
277 2004-06-29 Jean-Pierre Roux
278 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
279 - replace by uggly but working old code :-(
280 A lot of things should be OK again.
281 It's really urgent to have a test suite that *tests*,
282 to prevent Frog's beautifying sessions to break all the stuff
283 (twice, withing a fortnigh ...)
285 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
287 redundancy) to added Test/TestReadWriteReadCompare.cxx
288 * Test/CmakeList.txt: because the compare test of
289 Test/TestReadWriteReadCompare.cxx fails, the following images are
290 black listed: - 8BitsUncompressedColor.dcm
292 - US-PAL-8-10x-echo.dcm
293 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
294 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
295 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
296 and ad-hoc kludge. This kludge is now removed, and on encountering
297 such an image (OB field brain damaged) we set errno. Then in
298 ::FindDocLength() we "fix" the length as being ALL what remains
299 in the file (until EOF). We then proceed, hoping for the best...
300 This fixes a SegFault in ShowDicom when trying to write such an
302 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
303 (because TestWriteRead breaks on it, after a non conformal commit?).
304 ctest now runs properly, except for MakeDicomDir (which was allways
305 broken) and the Python related stuff (still not fixed).
307 2004-06-24 Jean-Pierre Roux
308 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
309 FIX : Test/TestReadWrite now iterates on all the file names
310 (instead of infinite loop)
311 ENH : Test/TestWriteRead now iterates on all the file names
313 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
314 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
316 2004-06-24 Jean-Pierre Roux
317 FIX : - now Write drops LUT Descriptors and LUTs (if any)
318 when SamplesPerPixel =3
319 - now Write is no longer confused by
320 'BitsAllocated = 12" and 'BitsStored=12"
321 - "UN" value representation Elements are now written correctly
322 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
323 ENH : - now gdcmHeader has its own Write methods
324 (in order to split the job that has not to be done
327 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
329 loop on the same image until memory went out.
330 Note: this means we still have gobs of memory loss in PrintDocument
331 * src/gdcmDocument.cxx: fixes problem on parsing on file
332 gdcmData/16BitsJpegLosslessGrayScale.dcm.
334 2004-06-24 Jean-Pierre Roux
335 FIX : Write - All the Sequences and Sequence Item are now written
336 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
337 is added a the end, when necessary.
338 - A lot of brain-damaged images, that were read correctly are
339 now written correctly
340 - length compatible BinEntry are now loaded correctly
341 (even for odd groups)
342 Note : only Explicit Value Representation was checked.
343 (question : is implicit VR really necessary for gdcm ?)
345 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
346 * DEVELOPPER: added a proposition of coding style.
347 * src/gdcmDocEntry.h: removed every inline declaration (for test of
350 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
351 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
352 Use the gdcmDocEntry::Print() and Write() instead.
353 * src/gdcmDocument.cxx: bug fix.
355 2004-06-22 Jean-Pierre Roux
356 FIX : gdcmDocument.cxx
357 - Now we do recognize the JpegLossLess format (there was a misstyping in
358 code 'beautyfication' :-(
359 - Now we automaticaticaly load the Luts, if any
361 2004-06-22 Jean-Pierre Roux
362 In order : to write Sequences, whatever their imbrication level,
363 : to allow user to create his own Sequences
364 a lot of modif where necessary (adding, moving, or virtualising methods)
366 WARNING : save your own sources *before* cvs up !
369 ADD virtual void Write(FILE *fp, FileType filetype);
372 ADD virtual void Write(FILE *fp, FileType filetype);
373 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
376 ADD virtual void Write (FILE *fp, FileType filetype)=0;
377 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
378 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
379 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
380 ADD std::string GetEntryByName(TagName name);
381 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
383 std::string vr = "unkn",
384 std::string fourth = "unkn",
385 std::string name = "unkn");
386 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
387 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
388 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
389 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
390 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
391 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
392 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
393 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
396 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
397 ADD virtual std::string GetEntryByName (TagName tagName);
398 ADD virtual std::string GetEntryVRByName (TagName tagName);
399 REM virtual bool Write(FILE *, FileType);
400 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
401 FILE *_fp, FileType type);
402 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
403 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
404 REM virtual bool WriteEntries(FILE *_fp,FileType type);
405 REM virtual std::string GetEntryByName (std::string tagName);
406 REM virtual std::string GetEntryVRByName (std::string tagName);
407 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
408 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
409 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
411 std::string vr = "unkn",
412 std::string fourth = "unkn",
413 std::string name = "unkn");
414 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
415 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
416 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
417 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
420 ADD virtual void Write(FILE *fp, FileType filetype);
423 ADD virtual void Write(FILE *fp,FileType filetype);
426 ADD virtual void Write(FILE *fp, FileType filetype);
427 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
428 REM std::string GetEntryByNumber(guint16 group, guint16 element);
429 REM std::string GetEntryByName(TagName name);
432 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
434 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
435 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
436 The default constructor invoked by the line
437 gdcmHeader *f1 = new gdcmHeader( header );
438 was gdcmHeader::gdcmHeader(bool) instead of the expected
439 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
440 Hence the parsing wasn't executed... See also below.
441 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
442 as explicit constructor didn't do the trick to fix the above problem.
443 Could anyone explain why ?
444 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
445 properly calls gdcmValEntry::Print() (that was weed out from
446 code related to gdcmBinEntry).
448 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
449 * In order to fix memory leaks:
450 - Test/TestWriteSimple.cxx: added cleaning of free store through
452 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
453 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
454 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
455 (through the call to ::AddDicomDirMeta()) or the destructor
456 would crash when deleting uninitialized ::metaElems].
457 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
458 - src/gdcmDocument.cxx:
459 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
461 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
462 was causing memory leaks.
463 - src/gdcmSQItem.cxx:
464 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
465 cleanly handled with polymophism: sorry but my milage is low).
466 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
467 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
468 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
469 This avoids SegFaulting.
470 - src/gdcmSQItem.h: coding style.
472 - Test/TestWriteSimple still severely sucks. The output image content
473 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
474 damaged when displayed with vtkgdcmViewer.
475 - on memory leaks: TestWriteSimple leaks really less (see entry
476 of 2004-06-18 in Changelog file for the call to valgrind).
477 - on segfaults: ctest now passes all the tests but one (no more
479 * Erroneous leading white fix:
480 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
481 white[s] (as opposed to from >> xxx, that removes it [them].
482 - src/gdcmTS.cxx: ditto.
483 - gdcmPython/testSuite.py: dirty related kludge removed.
484 * src/*: remaining references to gdcmParser removed.
485 * src/*[cxx|h]: added copy[way]left header.
488 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
489 * In order to fix writing of dicom files:
490 - Test/TestWriteSimple.cxx: a simpler example of writing.
491 - Test/CMakeLists.txt changed accordingly.
492 - src/gdcmDocument.cxx:
493 -- The destructor now recursilvely removes potential sequences.
494 -- Bug fix in ::IsJPEG2000()
495 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
496 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
498 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
499 to only declared) and build on top of
500 ::GetDocEntryByNumber(guint16, guint16).
501 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
502 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
503 for usage in destructor and treatement of promotion in
504 ::ReplaceOrCreateByNumber().
505 - src/gdcmSQItem.cxx: destructor should better handle his job.
506 Test/TestWriteSimple now runs (or at least it DOES something).
507 * We can now start hutting memory links. A good starting point is:
508 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
509 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
510 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
512 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
513 * Valgrind note: after Mathieu Malaterre teached me how to read
514 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
516 Using gcc, you can force the STL to use malloc and to free memory as
517 soon as possible by globally disabling memory caching.
518 With 3.2.2 and later, you should export the environment variable
519 GLIBCPP_FORCE_NEW before running your program.
520 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
521 simply vanish (it is still not clear to me, whether this means that
522 STL std::string leaks or if valgrind believes it leaks...).
523 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
524 running bin/gdcmTests makeDicomDir):
525 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
526 - Test/makeDicomDir.cxx now properly traps empty lists and returns
528 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
529 SegFaulting (I drowned in DicomDir related code when trying to
530 understand why the list is empty...).
531 * src/gdcmDocument.h: first BSD license header try.
532 * Doc/License.txt added.
534 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * src/gdcmDocument.[h|cxx]:
536 - Clean up of the Transfer related predicates. They are now all based
537 on new method isGivenTransferSyntax, that (should) handle properly
539 - general clean up, simplification, and coding style.
540 - Specific clean up of Parse7FE0() (umproperly named actually).
541 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
543 2004-06-14 Jean-Pierre Roux
545 - fix the display of Sequence Delimitor (SQDepthLevel pb)
546 - fix the display of SQItem ordinal number
547 - add the GetSQItemByOrdinalNumber method
548 - remove some useless never written private methods
550 2004-06-14 Jean-Pierre Roux
552 - adding a constructor taking a gdcmDocEntry as an input param
553 - ReplaceOrCreateByNumber now returns :
554 a gdcmBinEntry * if a Binary (void *) value is passed as a param
555 a gdcmValEntry * if a string value is passed as a param
557 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
558 according to the param type (no longer sets a gdcmDocEntry)
559 - GetValEntryByNumber, GetBinEntryByNumber added
560 - NewValEntryByNumber and NewBinEntryByNumber added
562 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
564 - GetSQItemNumber and SetSQItemNumber added, to provide
565 a (relative) Item identier inside a given Sequence
566 \warning : some pb remaining around this number
568 - AddEntry now takes the Item Number as a param
570 - adding a constructor taking a gdcmDocEntry as an input param
572 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * Memory leak hunt with the following command:
574 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
575 --show-reachable=yes gdcmTests PrintDocument
576 It looks like many (all?) leaks are due to the STL (or a bad usage
577 of the STL. The lines producing the leaks now have a comment with
578 a "MEMORY LEAK" tag: you can retrieve them with
579 grep "MEMORY LEAK" src/*
580 Here are two typical examples which I can't help fixing:
585 char * test = "babo";
586 name = test; //// <--- valgrind detects 960 bytes lost in
587 //// call to std::string::operator=(char const*)
588 name.clear(); //// Doesn't help !
596 std::cout << "Type a bunch of characters followed by RETURN: ";
597 getline(std::cin, line); //// <--- valgrind dectects a loss
598 //// of 1320 bytes in call to
599 /// std::basic_istream<>& std::getline<>
605 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * src/gdcmHeader.[cxx|h]:
607 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
608 and related, moved away to gdcmDocument.
609 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
610 the corresponding protected accessors of inherited class
611 gdcmDocument, removed ! As a consequence gdcmFile had to be
612 declared friend of class gdcmDocument (see below).
613 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
614 - Clean up of undefined or unused methods.
615 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
616 account the changes to gdcmHeader.h).
617 * src/gdcmDocument.h:
618 - gdcmFile is now a friend class (in order to take into account the
619 changes to gdcmHeader.h).
620 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
621 (see changes to gdcmHeader.h).
622 - Accessors (reading on the form GetEntry*) are now public.
623 - Clean up of undefined or unused methods.
624 * src/gdcmDocument.cxx:
625 - adaptation to changes to gdcmDocument.h
626 - ::OpenFile now writes a verbose message when file cannot be opened.
627 - some std::string properly set to VRKey
628 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
629 references to gdcmDocument.
630 * Test/TestFindTags.cxx: changed accordingly to above changes.
631 * gdcmPython/testSuite.py: adapted to renaming of acr files in
632 cvs repository gdcmData.
634 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
635 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
636 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
637 conflicts with gdcmValEntry::voidArea.
638 * src/gdcmValEntry.cxx: unmatching comment wiped out.
639 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
640 Value representation between StringRepresentable and BinaryRepresentable.
641 * src/gdcmDocument.cxx:
642 - method ParseDES: proper indentation restored and usage of
643 gdcmVR::IsVROfGdcmStringRepresentable wired in.
644 - method LoadDocEntry: the fingerprint left in the SetValue() of
645 unloaded entries (length > MaxSizeLoadEntry) had curiously been
646 removed. Reverting to previous code segment with the proper
647 dynamic_cast< gdcmValEntry* >.
648 Note: this was (partially) breaking the python test suite
649 (gdcmPython/testSuite.py) that made usage of the above
650 fingerprint to check presence of "Pixel Data".
651 * src/gdcmDocEntry.h: coding style.
652 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
653 now taken into account.
654 * gdcmPython/gdcm.i: adaptation to the new internal representation
655 of gdcm (exit gdcmParser, hello gdcmDocument).
656 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
658 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
659 anymore, but instead prints the loaded Python dictionary.
660 * .... alas, the python testSuite is still broken.
662 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
663 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
665 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
666 * src/gdcmUtil.h : export methods
668 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
669 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
671 * Initial addition of automatic python testing
672 * Initial addition of automatic image comparison
674 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
675 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
676 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
678 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
679 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
680 * Test/ShowDicom.cxx : bug fix for msvc compilation
681 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
683 2004-05-04 Jean-Pierre Roux
684 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
685 new concepts (and new classes) :
686 a 'gdcmDocument' is composed of a set of Doc Entries, that are
687 - elementary gdcmDocEntries (former gdcmHeaderEntries)
688 - Sequence Doc Entries (gdcmSeqEntries)
689 a Sequence is composed of Items.
690 Each item is a set of Doc Entries (this is recursive)
691 The non uniqueness of the 'Dicom tag' is due to this recursivity
692 (never taken into account)
693 Our unability to add a new 'entry' in the header
694 at the proper location (neither in the H-Table (map or multimap),
695 nor in the Chained List is also due to this recursivity.
696 Don't try, right now, to use/modify/compile these new sources :
698 We just commit all the stuff, 'as is', in order not to loose it.
700 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
701 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
703 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
704 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
705 file prefix (SetFilePrefix)
707 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
708 * Add a new test: ShowDicom, for now this is just the c++ version of
709 checkRead.sh, later it will be able to compare the image read against a
711 * Replace the DEBUG on the stack with a global entry in cmake interface:
712 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
714 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
715 * Add an example subdir, with a real example on how to read + write a
718 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
719 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
720 * Doc/CMakeLists.txt: the main page is now properly differentiated
721 between the developper and user version.
722 * Doc/doxygen.config.in: dropped search related obsolete flags
723 * src/gdcmParser.h, gdcmHeader.h: doxygenation
725 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * DEVELOPPER: added some helpfull comments for compile/test/install
729 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
731 src directory, now generated in the build dir.
732 2. Tests as mentionned smarter
734 4. Add a new method in gdcmDict that return the PubDict by name
735 this is interesting for 3rd party lib like ITK,
736 where we could set the institution name / patient name...
738 * ENH: 1. Now the test suite is working for real
739 2. All binaries are now output in the gdcm-bin directory
740 (this was not true before)
742 2004-04-28 Jean-Pierre Roux
743 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
744 SeQuence indented printing of Dicom Header.
745 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
746 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
747 Computation of SQDepthLevel is now part of gdcmHeader constructor
748 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
749 tree-like structure of a Dicom Header.
750 * FIX Test code cleaning
752 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
753 * ENH: Adding automatic testing
754 1. Need a DartConfig.cmake to submit to public
755 2. Add a test driver gdcmTest.cxx
756 3. gdcmTestMain, an helper for the main test driver gdcmTest
757 4. Files in Test don't have a main anymore, this becomes interesting
758 when we add more and more tests, thus dsw don't have to load
760 * ENH: Adding a GDCM_DATA_ROOT for testing
761 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
762 one file instead of seven + some small cleanup
764 2004-04-22 Jean-Pierre Roux
765 * ENH Minor changes to the Print() methods.
766 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
767 Header printing. Example given with :
768 > PrintHeader fileName 2 new
769 (SQ based tree-like structure still to be done for the Header ...)
771 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
772 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
773 1. I have added some unsigned where needed
774 2. Some function parameter not used -> (void)
775 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
776 4. g++ don't like character '\' in comment
777 5. #define jpeg_create_decompress jCreaDecompress
778 this really need to be fixed
779 6. virtualize destructor of gdcmObject ... leakage
780 7. sscanf(g->first.c_str(),"%x",&gr_bid);
781 this also really need to be fixed
782 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
783 remove compression file
784 (as we only do decompression, right ?)
785 * ENH: Change malloc/calloc/free with c++ equivalent
787 2004-04-21 Jean-Pierre Roux
788 * FIX gdcmHeaderHelper::GetXSpacing
789 when a single value is found (bug ?), xpacing is now
790 defaulted to yspacing
792 2004-04-19 Jean-Pierre Roux
793 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
794 * ENH add parameters :
795 bool exception_on_error = false,
796 bool enable_sequences = false,
797 bool ignore_shadow = false
798 to the gdcmFile constructors to be full gdcmParser compliant
799 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
800 to allow reading of PAPYRUS 3.0 files
802 2004-04-06 Jean-Pierre Roux
803 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
805 2004-04-02 Jean-Pierre Roux
806 * ADD : Test/checksequence.sh, for a general recap on SQ pb
807 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
808 for Philips spurious Tag fffe|0000 while rewritting Dicom files
810 2004-03-30 Jean-Pierre Roux
811 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
812 for ACR file, written out as DICOM files (hope so...)
814 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
816 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
817 moved to base class gdcmParser and only the specialisation is kept
819 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
820 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
821 already does the job.
822 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
823 (to be consistent with gdcmParser::WriteEntries).
825 2004-03-30 Benoit Regrain
826 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
827 upate of the object's instance. It's passed to 2 in the unfavorable
828 case : one in the ExecuteInformation, one in the ExecuteData
830 2004-03-29 Jean-Pierre Roux
831 * ENH : Check on file type to be written moved
832 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
833 * FIX : gdcmObject::ResetBoundaries now stops properly
834 when end-of-list is reached
835 : gdcmVersion modified (as Benoit Regrain asked)
837 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
838 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
839 * src/gdcmUtil.cxx: added forgotten iostream include.
840 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
841 equivalent to ExplicitVR in existing code).
843 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
844 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
845 now contains all the gdcmGlobal related code.
846 * minor coding style and doxygenation changes.
848 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
849 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
850 now contains all the Debug related code.
851 * minor clean-up of includes in src/*.cxx
852 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
853 CreateCleanString) removed.
854 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
855 * Doc/DoxyMainPageUser.txt added.
856 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
857 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
860 2004-03-24 Jean-Pierre Roux
861 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
863 2004-03-23 Jean-Pierre Roux
864 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
865 big endian made volumes
866 * ENH Now gdcmParser constructor and destructor are protected to forbid
867 end user to instanciate class gdcmParser
868 (only gdcmHeader and gdcmDicomDir are meaningfull)
870 2004-03-22 Benoit Regrain
871 * FIX : src/gdcmDicomDir.cxx : make windows compilable
872 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
873 gdcmSerie to gdcmDicomDirSerie
875 2004-03-19 Jean-Pierre Roux
876 * ENH Now the tree-like structure describing a DICOMDIR comming from
877 an already existing DICOMDIR file is consistent with
878 the home-made tree-like structure build ex-nihilo
879 or build from the files held (recursively) in a Directory
880 functions gdcmDicomDir::CheckBoundaries()
881 gdcmObject::SetBoundaries() added
883 2004-03-17 Jean-Pierre Roux
884 * REM (Eric Boix bug) : removal of meaningless
885 gdcmDicomDirImage::NewImage function.
886 * FIX now file names and directory name are written properly in the
888 * FIX now gdcmDicomDir constructor may be call without any trick
891 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
892 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
893 of gdcmDicomDirImage::NewImage as empty function.
895 2004-02-28 Jean-Pierre Roux
896 * ENH add gdcmDicomDir:NewPatient
897 add gdcmDicomDirPatient:NewStudy
898 add gdcmDicomDirStudy:NewSerie
899 add gdcmDicomDirSerie:NewImage
900 to allow making gdcDicomDir object.
901 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
902 (as opposite to the gdcmHeader chained list)
904 2004-02-11 Benoit Regrain
905 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
906 when using from python
908 2004-02-10 Benoit Regrain
909 * FIX : bug fix in the gdcmDirList for the recursivity in directories
910 * FIX : in gdcmDicomDir when the directory is empty
911 * ENH : add callback and methods to get the progression of dicomDir
914 2004-02-06 Jean-Pierre Roux
915 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
916 - GDCM_META added to gdcmDicomDirType
917 - class gdcmMeta created
918 * ENH : - A brief summary is now displayed at the beginning of
919 'testDicomDir' to help disaster magnitude estimation
920 * REM : Now useless Test/explDICOMDIR.cxx
922 2004-02-05 Benoit Regrain
923 * ENH : add methods in gdcmObject to get the hash table or the list of
925 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
926 * FIX : wrapping python for TagHeaderEntryHT
928 2004-02-04 Benoit Regrain
929 * FIX : even length for some strings when writting the dicom dir
930 * FIX : sort the images in the dicom dir
931 * FIX : Bug fix for python use of dicom dir
932 * ADD : a python demo
934 2004-02-04 Jean-Pierre Roux
935 * FIX : Final solution (?) for icone embedded images
936 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
937 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
938 add groups 6002, 6004, 6006, to allow 'clean' parsing of
939 gdcmData/gdcm-MR-SIEMENS-16.acr1
940 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
941 to make full checking easier
943 2004-02-04 Benoit Regrain
944 * FIX : WriteEntries : coding style & logic in parameters
945 * FIX : Set the elements to create the DicomDir in a dictionary file
947 2004-02-03 Benoit Regrain
948 * gdcmDirList : to parse a hard drive directory in recursive (or not)
949 * gdcmDicomDir : add the load of directory
950 * Bug fix and print add-on
952 2004-02-03 Jean-Pierre Roux
953 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
954 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
955 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
956 * FIX gdcmParser.cxx : 'group length' elements are now considered
957 as integers, even for shadow groups, when file is Implicit VR
959 2004-02-02 Jean-Pierre Roux
960 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
962 of the last synonym :-(
963 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
965 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
966 * FIX taking into account the possible 7fe0,0010 multiplicity
967 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
968 to allow removal of references to 7fe0,0010, to deal with
969 ACR-NEMA images, when 0028,0200 is meaningfull
971 2004-01-31 Jean-Pierre Roux
972 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
973 no longer writes 'Un' on disk
974 * FIX SQ elements with actual length are now dealt with corectly
975 * FIX gdcmFile::WriteBase make the difference, for color images, between
976 the length (for Palette expanded images)
977 and Raw Length (non expanded image + Palette)
978 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
979 (that broke Write). Replaced by UL.
980 Aware user will reload the field if he
981 thinks it's necesssary
983 2004-01-30 Jean-Pierre Roux
984 * gdcmParser::CheckSwap() now defaults the filetype to ACR
985 when 'dirty Acr' is found, to be compliant with the new
986 IsReadable() methods.
988 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
989 (no DOUBLE images in kosher DICOM,
990 but so usefull for people that miss them ;-)
992 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
993 DICOMDIR related utilities (not checked as Windoze compliant)
995 2004-01-28 Jean-Pierre Roux
996 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
998 2004-01-27 Jean-Pierre Roux
999 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1000 to allow skipping the shadow elements, to save memory space.
1001 The TRUE value for this param has to be used
1002 with a FALSE value for the 'enable_sequence' param.
1003 ('public elements' may be embedded in 'shadow Sequences')
1004 * gdcmHeader methods now deal with 'embedded icones images' in the header
1005 (even when an 'icone image sequence' is announced by the
1006 element (0x0088,0x0200), but there is NO icone at all ...
1008 * gdcmHeader sometimes Image Location value doesn't follow
1009 the supposed processor endianity (see gdcmData/cr172241.dcm).
1012 * gdcmHeader add the method
1013 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1014 to get *all* the Header Entries with the same tag.
1015 GetHeaderEntrySameName is probabely *useless*
1016 (no meaning : Name is *not* an identifier within the Dictionnary)
1018 2004-01-26 Benoit Regrain
1019 * Bug fix in the print of hexadecimal representations. Remove long fields
1020 in the print and add a third level of print to print them
1022 2004-01-23 Benoit Regrain
1023 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1024 * Bug fix on test suite after remove the strip made on not string fields
1025 * Split the IsReadable method between gdcmParser which test that the file
1026 is dicom and gdcmHeader which test that it's an image file
1028 2004-01-22 Benoit Regrain
1029 * DicomDir : clean code, add methods, set variables in protected or private
1030 * gdcmUtil : bug fix for the clean string method
1032 2004-01-19 Benoit Regrain
1033 * Add the use of shadow dictionaries
1034 * bug fix and coding style
1036 2004-01-19 Benoit Regrain
1037 * src/gdcmFile.cxx : bug fix concerning the close of file
1038 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1039 * Add the update of header entries using the shadow library
1041 2004-01-19 Benoit Regrain
1042 * removal of file gdcmHeader2.cxx
1043 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1044 inheriting from gdcmParser. This split is to prepare the integration
1045 of dicom dir parsing
1046 * bug fix under python
1048 2004-01-16 Jean-Pierre Roux
1049 * REM removal of class gdcmHeaderEntrySet
1050 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1051 * ADD add file gdcmHeader2.cxx
1052 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1054 2004-01-15 Benoit Regrain
1055 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1056 entries created while parsing the header. Thus, they will be destroyed
1057 when the gdcmDictSet will be destroyed
1058 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1061 2004-01-15 Benoit Regrain
1062 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1063 made a fatal error because of the memory release at the end of program.
1064 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1065 some memory and vtk seems to have some problems with that.
1066 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1068 2004-01-14 Benoit Regrain
1069 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1070 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1071 * src/*.[h|cxx] : make changes due to class name changes
1072 * gdcmPython/demo/*.py : bug fix due to method names
1074 2004-01-13 Benoit Regrain
1075 * src/*.[h|cxx] : coding style
1076 * vtk/*.[h|cxx] : coding style
1078 2004-01-13 Benoit Regrain
1079 * gdcmPython/testSuite.py : test the readable flag of file for tests
1080 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1081 It's lied to the stl compilation by MSVC (windows, always windows...)
1082 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1084 2004-01-12 Benoit Regrain
1085 * src/*.h : add comments
1086 * src/gdcmDictSet.h : set the method BuildDictPath in public
1087 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1088 directly setted in the source code
1089 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1092 2004-01-09 Benoit Regrain
1093 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1094 * setup.py : use a reference to gdcmVERSION
1096 2004-01-07 Benoit Regrain
1097 * Modification to compile with the distutils.
1100 2003-12-10 Benoit Regrain
1101 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1102 can use a gdcmHeaderHelper to load datas
1103 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1104 made in the source code
1106 2003-12-10 Benoit Regrain
1107 * Update Windows projects and .cvsignore files
1109 2003-11-12 Jean-Pierre Roux
1110 * ENH gdcmHeader constructor has one more parameter (default value : false)
1111 that allows the user to 'go inside' the SeQuences only
1113 gdcmElValSet:Print takes it into account
1115 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1116 * ENH: Update gdcmPython/CMakeLists
1117 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1118 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1120 2003-11-10 Jean-Pierre Roux
1121 * FIX : gdcmHeader::LoadElements is now based
1122 on the ListTag listElem member,
1123 not longer on the TagElValueHT tagHt member
1124 * ENH : PrintPubElVal shows (temporarily) both results,
1125 with the tagHt member and the listElem member.
1126 (it's easier to 'see' the problems when using Printheader)
1128 * FIX : old private member LgrElem is now splitted into
1129 ReadLength : Length actually found on disk (updated only
1130 if bug fixing is necessary), for internal
1132 UsableLength : Updated by FixFoundLength, to fix a bug
1133 or to allow Parser going on.
1134 Will allow to re-write a kosher header when a SeQuence
1135 with a length (not 0000) is found
1136 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1137 because gdcmElValSet::Add does not update ListElem
1140 2003-11-07 Jean-Pierre Roux
1141 * FIX misstyping in Transfert Syntax name table
1142 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1143 when they have an actual length (not 0000 nor FFFFF)
1144 (Nobody should care of it, but DICOMDIR explorers)
1146 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1147 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1149 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1150 * ENH: vtkGdcmReader now supports LUT !
1151 (vtkgdcmViewer for now is not able to use them though)
1153 2003-11-05 Jean-Pierre Roux
1154 * in testSuite.py : new files names for checking the package
1155 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1156 that returns the pixel area size to the *aware* (vtk) user
1157 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1159 2003-11-05 Benoit Regrain
1160 * in testSuite.py : Modify the rules for checking the paths
1161 : Explicit error messages
1162 * in __init__.py : Related modif
1164 2003-11-03 Jean-Pierre Roux
1165 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1166 to be used by aware (vtk) users that want to manage
1167 LUT (and no to turn the PALETTE image into an RGB pixels one)
1168 * GetPixelType now returns 8U for 24 Bits images
1169 (vtkGdcmReader compliant)
1171 2003-10-31 Jean-Pierre Roux
1172 * Removal of *all* gdcmData images and add them again
1173 in order to loose the 'history' of un-anonymised images
1175 2003-10-31 Jean-Pierre Roux
1176 * RMV : removal of useless jBitsInJsample.h
1177 for both 8 and 12 Bits JPEG Lossy Libraries
1179 2003-10-31 Jean-Pierre Roux
1180 * ENH : Add the functions gdcmFile::GetImageDataRaw
1181 gdcmFile::GetImageDataIntoVectorRaw
1182 that act as GetImageData and GetImageDataIntoVector
1183 except the making of an RGB Plane from Gray Plane + LUT
1184 Intended to aware (vtk) users who know how to manage
1187 GetLUTRGBA return a R,G,B,A LUT if any
1188 lgrTotaleRaw gives the 'Raw' length
1189 GetImageDataRaw returns the gray Plane
1190 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1191 (They stay Grey, just like with other Dicom viewers :-(
1193 2003-10-30 Jean-Pierre Roux
1194 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1196 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1197 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1198 being coherents dicom files.
1200 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1203 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1204 * ENH: Two steps is necessary to please VC++ compiler...
1205 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1206 * ENH: Add include dir to medcon lib
1207 * FIX: only one function is being exported for now !
1208 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1210 2003-10-29 Jean-Pierre Roux
1211 * adding gdcmHeader::GetLUTRGBA
1212 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1213 --> Mathieu, the modif u're waiting for is not yet committed
1214 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1216 2003-10-27 Jean-Pierre Roux
1217 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1218 00191113.dcm DermaColorLossLess.dcm
1219 MxTwinLossLess.dcm RadBWLossLess.dcm
1220 * ENH: For version prior to vtkImageViewer2 -r 1.19
1221 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1223 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1224 * Removal of ido stuff in CMakeLists.txt
1226 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1227 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1228 * FIX: remove a call to ->Modified ... see comments
1229 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1231 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1232 * FIX: Problem with path for libvtkgdcmPython
1233 * ENH: Try adding a search script for python site-package
1234 * RMV: Remove some file from medcon lib that are not necessary
1235 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1236 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1237 * FIX: More pragma disable fro VC++,
1238 I don't think I break something as it is also disable in VTK/ITK.
1239 But it fasten debug compilation time.
1241 2003-10-23 Jean-Pierre Roux
1242 * gdcm now deals with 16 Bits Run Length Encoded images
1243 (they are compressed as 2 planes images,
1244 one for the high Bytes, the other for low Bytes)
1246 2003-10-22 Jean-Pierre Roux
1247 * Now CheckRead takes into account :
1248 - the bugged 'Leonardo' Siemens images
1249 - the XA images, sent thru the burning VPRO station
1250 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1253 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1254 * FIX: When copying a Makefile.am to CMakeLists.txt
1255 one should remove the '\'
1257 2003-10-22 Jean-Pierre Roux
1258 * in gdcmData adding a bugged 'Leonardo' Siemens image
1259 (wrong lengths in header)
1260 OK with gdcm, KO with the other viewers :-)
1261 * add a GE dlx XA image, thru the VEPRO burning station
1264 2003-10-21 Jean-Pierre Roux
1265 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1266 for a brutal checking of vtkgdcmViewer compliance
1268 2003-10-21 Jean-Pierre Roux
1269 * add the files for 'xmedcon' Jpeg Lossless library
1270 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1272 2003-10-21 Jean-Pierre Roux
1273 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1275 2003-10-21 Jean-Pierre Roux
1276 * garbage Siemens 'Leonardo' images dealt with
1277 (the patch is easy to remove)
1278 * cosmetic changes to avoid warnings
1280 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1281 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1282 no need to press 'r' now.
1284 2003-10-20 Jean-Pierre Roux
1285 * upgrade of checkRead.sh checkWrite.sh according
1286 to new Jpeg Lossless decompressor
1287 * add US.3405.1.dcm, a genuine RGB medical file ...
1288 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1289 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1291 2003-10-15 Jean-Pierre Roux
1292 * general anonymisation in gdcmData
1293 * adding the 'color files' from
1294 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1295 * adding some well knowed bugged-header images
1296 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1297 waiting for their inclusion in Python testsuite
1299 2003-10-15 Jean-Pierre Roux
1300 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1301 no longer seg faults when file is not found
1303 2003-10-14 Jean-Pierre Roux
1304 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1307 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1308 * TODO: *.in file to genereate a UseGDCM later
1310 2003-10-14 Jean-Pierre Roux
1311 * Some supposed-to-be Dicom Images have no preamble.
1312 OpenFile takes it into account
1313 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1314 * Missing elements added in dicomV3.dic
1315 (just to be affraid : have a look at
1316 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1317 and do it again next year ;->
1319 2003-10-13 Jean-Pierre Roux
1320 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1321 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1322 But there are NOT. It's fixed !
1324 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1325 * FIX: "jpeglib.h" was not found on VC++
1326 * FIX: vtkgdcm was not being installed
1328 2003-10-10 Jean-Pierre Roux
1329 * ENH : OpenFile closes the file if it *really* doesn't look like
1330 an ACR-NEMA / DICOM one.
1331 * FIX : testWrite no longer writes an empty file if the source file
1332 is not gdcm Readable
1333 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1336 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1337 * FIX: CMake generate now documentation
1338 * ENH: out of source doc build !
1339 * ENH: Generate both user and dev documentation
1340 * ENH: Should work on windows too
1341 * ENH: Only one doxygen config.in file is needed
1342 * FIX: make install should be ok now on ùnix plateform
1343 * FIX: PATH to dictionary was wrong (missing /)
1344 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1346 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1347 * vtkGdcmReader is now able to read rgb dicom file.
1348 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1349 * added a gdcmViewer to vtk test, use mouse to control
1350 window level & window width
1352 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1353 * CMake-ification of gdcm, we have now two build system
1354 * FIX: on cygwin Wsock32 doesn't exist
1355 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1357 2003-10-06 Emanuel Ollart
1358 * FIX : compilation process wad broken.
1359 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1361 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1362 * change gdcmViewer -> vtkgdcmViewer
1363 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1365 2003-10-06 Jean-Pierre Roux
1366 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1367 ( e.g : well known GE images with a wrong elem length,
1368 : Philips MRI Images with a wrong Huffman table)
1369 * still to be done : allow the reading of bugged LEONARDO Siemens images
1371 2003-10-03 Jean-Pierre Roux
1372 * Odd length strings are padded with '\0' (not with spaces,
1373 to remain compliant with already defined strings,
1374 like Transfert Syntax UID and others)
1376 2003-10-03 Jean-Pierre Roux
1377 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1378 to allow displaying RGB images (not only by affim ;-)
1380 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1381 * vtkGdcmReader is now able to read rgb dicom file.
1382 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1384 2003-10-03 Jean-Pierre Roux
1385 * A few nasty patches to allow the reading of a lot of nasty images
1386 ( e.g : well known GE images with a wrong elem length,
1387 : Philips MRI Images with a wrong Huffman table)
1388 * still to be done : allow the reading of bugged LEONARDO Siemens images
1390 2003-10-03 Jean-Pierre Roux
1391 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1393 2003-10-03 Jean-Pierre Roux
1394 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1395 to allow displaying RGB images (not only by affim ;-)
1397 2003-10-03 Jean-Pierre Roux
1398 * gdcmFile::GetImageDataIntoVector now
1399 - deals with MultiFrames MultiFragments Run Length Encoded files
1400 - deals with YcBcR (YBR_FULL) files
1401 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1402 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1404 (no sample found :-(
1406 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1407 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1408 Two reasons: - clear things
1409 - third parties acces gdcm through header files, so won't
1410 suffer anymore VC++ complains
1412 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1413 * add argv[1] in testvtkGdcmReader.cxx
1416 2003-09-24 Jean-Pierre Roux
1417 * The lines are now eigthy characters long.for
1418 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1420 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1421 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1422 char* to std::string. Thus, the use of strdup becomes useless. (see
1423 previous commis of Malaterre)
1424 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1425 before the last Malaterre's commit.
1427 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1428 * This commit should fix the Debug building under VC++, the problem
1429 was mainly a mixture of debug and release lib being loaded at startup.
1430 * I also remove a depency to a specific C function: strdup. Because I had
1431 to force the link to msvcrtd (whereas strdup is in libc).
1433 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1435 located in the gdcmCommon.h file. All use of reference of tha has been
1436 changed to now use the variable GDCM_UNFOUND.
1438 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1440 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1441 Dicom dictionary. The test suite can now be run again. Note:
1442 I'm note very happy with the " (RET)" changes. I believe this
1443 RETAINED comment should be dropped when parsing the dictionary.
1444 - PACKAGER corrected
1446 - AUTHORS updated and now in alphabetical order
1447 * Makefile.am now exports gdcm.dsw for Windoze users.
1449 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1450 * cygwin complains about missing std:: in subdir Test/
1452 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1453 * remove some methods that are now in gdcmHeaderHelper
1455 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1456 * vtkGdcmReader set spacing and origin correctly
1458 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1459 * Fix a few delete/delete[] mismatch
1461 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1462 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1463 interpretation to data given by gdcmHeader. For instance there are
1464 heuristics to get informations (look at different places).
1465 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1466 sorting DICOM images based on different strategies.
1467 * modified Makefiles accordingly.
1469 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1470 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1471 when building in debug mode
1472 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1473 src/win32/gdcmdll.dsp
1474 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1476 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1477 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1480 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1481 * src/win32/libgdcmjpeg12.dsp was not dos format
1482 * src/win32/libgdcmjpeg12.dsp :
1483 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1484 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1486 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1487 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1489 * src/gdcmFile.cxx : bug fix in affectation type
1490 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1491 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1492 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1493 symbols... future problem ?
1495 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1496 * src/win32/libgdcmijpeg12.dsp was missing
1497 * modified gdcm.dsw accordingly
1499 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1500 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1502 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1503 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1504 commit of JPR (before his hollidays to facilitate our work).
1505 * setup.py : bug fix in code. Modifications made while the last commit
1506 of JPR. The code hasn't been tested before the commit... it's so
1507 useless to make that (for best programmer that is JPR) !!!
1509 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1510 * tagged the current version as Version0_3 (i.e. version 0.3)
1512 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1513 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1514 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1515 * *.dsp : modifications to use new libgdcmijpeg8 library
1516 * setup.py : bug fix on VTKPATH variable
1517 * PACKAGER : adding all concerning windows
1519 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1520 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1522 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1523 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1524 test suite reported error.
1525 * PACKAGER file added (describes what a packager must do when
1526 packaging a new release).
1527 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1528 * configure.in: upgraded version number to 0.3.0
1529 * fixing build of rpm (through rpm -ta):
1530 - Doc/Makefile.am exports proper doxygen files
1531 - src/jpeg/libijg8/Makefile.am exports the include files.
1533 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1534 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1535 * src/gdcmHeader.h : formatting code
1537 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1538 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1539 We were obtaining error message from vtk. Now, creation of file list
1540 is made in an internal list to prevent this problem.
1541 Bug fix when output is empty.
1542 Bug fix in update of progress value. Previous commit for this was a bad
1544 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1546 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1547 * src/gdcmHeader.h : added method to get the file name
1548 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1549 files. Added method to remove all files on the input
1550 Added FIXME comment concerning the bad parsing of header made by
1551 ExecuteInformation method (in ExecuteData method)
1553 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1555 when using make instal.
1556 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1557 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1559 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1560 * setup.py : adding include dir of jpeg lib to compile all sources
1561 * */Win32/*.dsp : JPR fix for windows compilation
1563 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1564 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1566 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1567 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1569 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1570 * setup.py is again effective on un*x (takes into account the
1571 addon of the jpeg library)
1572 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1573 * Doc/Doxy* updated (includes above enhancements)
1574 * INSTALL now points to web documentation
1576 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1577 * src/gdcmHeader.h doesn't make unnecessary reference to
1579 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1581 * src/gdcm*.[cxx|h] :
1582 - to allow compilation with gcc 3.x
1583 -- clean up of STL usage (added explicit usage of std::)
1584 -- small fixes on exceptions.
1585 Note: linking not tested !
1586 - clean of doxygen comments to avoid warnings at documentation
1588 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1589 dependent convertion).
1591 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1592 * Clean up of previous JPR garbage commit (not even commented in the
1594 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1595 - moved all jpeg related files from src to src/jpeg/libijg8, with
1596 addition/modification of Makefile.am and configure.in.
1597 - the testSuite is still brain damage (not guilty).
1599 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1600 * WrapVTK.py : modifications to get correctly vtk source files to
1602 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1603 (FileName -> Filename)
1605 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1606 * vtk/vtkGdcmReader.[cxx/h]:
1607 - UpdateProgress method should now be effective
1608 - removed the limitation on having only images loaded (as opposed
1610 - when building a stack of images/volume, a lesser number of
1611 gdcmHeader and gdcmFile instances should be used (hopefully
1612 accelerating things).
1613 - when building a stack of images/volumes, files which are not
1614 loadable (wrong path-filename, wrong permissions on existing file,
1615 or file not parsable by gdcm) are replaced with a black image
1616 in the stack (for the caller to notice the problem).
1618 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1619 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1621 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1622 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1623 between standard library (std) and vtk library (problems are found
1624 under Windows... thanks Windows !)
1626 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1627 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1629 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1631 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1632 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1634 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1635 * When compiling with distutils (see setup.py) the C++ compiler is
1636 called with different flags than the default ones (with automake).
1637 In order to fix all those warning, I compiled gdcm with the command
1638 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1639 and went for warning fixes:
1640 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1641 up from unused variables.
1642 - vtk/vtkGdcmReader.cxx: potential bug fix.
1643 * src/gdcmHeader.h: Doxygen warning cleanup
1645 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1646 * gdcmPython/gdcm.i:
1647 - typemaps correction to take into account the systematic replacement
1648 of "using namespace std" with std:: prefix e.g. std::list,
1649 std::string... (cf changes of 2003-05-21).
1650 - gdcmGlob global variable of type gdcmGlobal (defined in
1651 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1652 exported to Python a as cvar.
1653 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1654 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1655 gdcmDictSet.GetPubDictTagNames() and
1656 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1657 C++ static methods).
1658 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1659 with the above changes.
1661 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1662 * setup.py, manifest.in : bug fix under linux
1664 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1665 * Modification of setup.py to compile vtk part too. Then, we have 2
1666 wrappers which must work with same distutils. For that, we have a
1667 generic distutils in distusiltsWrapping.py ; with :
1668 - build_extWrap class to wrap generically all extensions,
1669 - ExtensionWrap base class for all wrapping extension that contains
1671 - Wrapper interface which wrap sources
1672 + In WrapSwig.py we have extension and wrapper for Swig
1673 + In WrapVTK.py we have extension and wrapper for VTK
1674 * MANIFEST.in : modifications to consider vtk directory and new python
1675 files for compilation
1677 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1678 * Added python wrappers of vtkGdcmReader vtk class (see the
1679 source in vtk/vtkGdcmReader.cxx) :
1680 - vtk/Makefile.am now builds a library
1681 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1682 python library (as opposed to _gdcm.so wich are the python
1683 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1684 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1686 - configure.in has an additional flag --enable-vtk that needs
1687 to be set to enable compilation of vtk related code, that is:
1688 + vtk/vtkGdcmReader.so and
1689 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1690 + gdcmPython/vtkgdcmPython.so (see above)
1691 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1692 be read when compressed or when HighBit + 1 != BitsStored),
1693 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1694 the usage of the python wrapper of vtkGdcmReader vtk class.
1695 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1696 * src/*.[h] all occurences of stl classes are now prefixed with
1697 std::, and all occurences of "using namespace std;" where removed.
1698 This is to avoid pollution of global namespace in included files.
1699 Apparently vtk does not avoid this pitfall: when using both
1700 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1701 collision of various stl members (principally cout...).
1702 * gdcmPython/testSuite.py now cleanly removes temprory generated
1704 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1705 comply with above changes)
1707 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1708 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1709 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1710 vtk data structure (an image Flip was required).
1711 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1712 * cosmetic changes in documentation.
1714 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1715 * src/gdcmHeader.cxx: the constructor no longer exits when an
1716 unexisting file is given as argument.
1717 * The subdirectory Data (containing all the images used for the
1718 test suite) is not part of this repository anymore. A new module
1719 containing those images is now available at
1720 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1721 with the name gdcmData.
1722 All the python scripts (including the package initialisation file
1723 gdcmPython/__init__.py) were adapated to take this change into
1724 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1726 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1727 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1728 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1729 demo of the usage of this class.
1730 Compilation of this vtk part is only done when using the --enable-vtk
1731 at configure (or autogen.sh) stage.
1733 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1734 * More memory link related corrections and documentation fixes.
1736 - maximum info is obtained with a command of the form:
1737 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1738 --show-reachable=yes PrintHeader
1739 - the remaining reachable blocks seem to come from the STL
1740 allocation scheme through the usage of map and list. It looks
1741 like this memory cannot be freed but it is not a memory leak
1742 (in fact further invocation to the STL would recollect the
1743 unused memory allthough it cannot explicitely be freed).
1744 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1745 of displaying an image parsed with gdcm and displayed with VTK.
1746 Note: some images don't seem to work e.g.
1747 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1748 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1749 Allthough this weakens the semantics, it is a ditch attempt to
1750 make gdcm more thread friendly.
1752 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1753 * Memory link hunt (by using valgrind through the command
1754 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1755 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1756 gdcmHeader::_dicom_vr.
1757 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1758 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1760 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1762 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1763 * src/Makefile.am now exports all the necessary include files at
1767 * UpdateGroupLength replaced by new one
1770 * UpdateGroupLength re-written using H-Table
1771 (named UpdateGroupLengthNew untill checks are over)
1773 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1774 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1775 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1777 - gdcmHeader::GetPubElValSet removed.
1778 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1779 UpdateGroupLength, WriteElements, Write.
1780 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1781 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1782 carried the same semantics.
1783 - src/gdcmHeaderIdo.cxx changed accordingly.
1784 - gdcmFile::WriteBase now regroups all the codes from previous
1785 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1786 - enum FileType moved to gdcmCommon.h
1787 * src/gdcmHeader.cxx AddDefault trashed
1788 * gdcmGetXSize added
1789 * getimageDataSize now calls gdcmGetXSize
1790 * Test/*.cxx changed to agree with above changes
1792 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1793 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1794 (to avoid double call by end user).
1795 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1796 by end user, since gdcmHeader::gdcmHeader now handles it.
1798 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1799 * gdcm/Doc many doxygen changes:
1800 - Doxyfile now has two different versions, DoxyfileUsers that generates
1801 the html.users end users oriented documentation and
1802 DoxyfileDeveloppers that generates the html.developper developper
1803 oriented documentation.
1804 - README changed accordingly
1805 - requirement.txt removed (old design info moved to TODO).
1806 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1807 DoxyMainPage.txt, DoxyPython.txt provide more information.
1808 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1809 be updated by simply regenerating the docs with doxygen and copying
1810 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1811 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1812 all the tests in the form "if (<map>.count() >1)" were removed.
1813 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1814 ill-formed documentation sections.
1815 * src/gdcmHeader.cxx: ditto
1817 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * setup.py fixed for un*x (needed macro for stdint.h)
1819 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1820 un*ces with sh-utils test utility.
1821 * gdcmPython/demo/test.py renamed to PrintHeader.py
1822 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1823 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1824 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1825 * src/gdcm*.cxx JPR's bad inclusion fixed.
1827 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1828 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1829 * gdcmPython/demo/test.py changed accordingly.
1831 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1832 * gdcmPython/Makefile.am fixed linking against libstdc++
1833 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1834 * Swig subdir (historical tests of swig version 1.3.17++) removed
1835 * Test/testChangeEntete.cxx some lines commented out in order to make
1837 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1838 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1840 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1842 hence the user doesn't need this explicit call.
1843 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1844 i.e. LoadElements() call removed.
1845 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1846 - src/Makefile.am declares the proper flag for g++.
1847 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1848 for adding user defined new tags.
1849 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1850 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1851 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1853 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1854 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1855 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1856 src/Makefile.am : the project should properly compile and install
1857 with the autotools, included the python wrappers part.
1858 * gdcm.spec.in : added a spec file for RPM packaging.
1860 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1861 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1863 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1865 to exported to the environement (see gdcmPython/testSuite.py
1867 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1868 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1869 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1870 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1871 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1873 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1874 * gdcmPython/__init__.py doesn't crash anymore when running in
1875 in InstallMode or PreInstallMode but with an environement given
1876 value of GDCM_DICT_PATH.
1877 * src/gdcmDictSet.[cxx/h] coding style.
1879 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1880 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1881 * src/gdcm.h general comments moved to TODO, and README
1882 * src/gdcm.h should now be seen as a user commodity (including it
1883 should suffice to fully use gdcm). It is nowhere including within
1884 any of the kernel files src/*.cxx and src/*.h.
1886 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1887 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1888 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1890 * src/gdcm*.cxx only include their corresponding include file
1891 (as opposed to gdcm.h)
1892 * gdcmPython/gdcm.i changed accordingly
1893 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1894 the autogen.sh generated "make snapshot" command to work.
1895 * autogen.sh removed history related references to crea package.
1897 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * distutilsSwigCPlusPlus.py work around some swig portability
1901 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1902 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1903 was done in a last ditch attempt to get setup.py _really_
1904 operationnal. The python/gdcmPython layaout add the advantage
1905 of hidding away the python related distutils specific files
1906 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1907 Alas, the src directory was out of scope (i.e. it's relative
1908 position to setup.py was ../src) which made things impossible to
1909 handle (see previous version of python/setup.py). Crossing fingers...
1911 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1912 * python/setup.py now works on Un*x. (harder than I thougth)
1913 * python/distutilsSwigCPlusPlus.py can now have include files
1914 among the list of sources.
1916 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1917 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1918 * modifications in MSVC projects
1920 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * As stated by the first lines of Test/ExceptionAndPython/README, it
1922 looks like we can move back to original usage of exception within
1923 src/gdcm* and hence remove the errno stuff that was introduced
1924 as a quick and dirty fixture of this problem (added to the TODO).
1925 * Doc/Doxyfile configuration file for Doxygen and corresponding
1926 README file for usage added.
1927 * Test/testWrite.cxx added. This new test comes from a split of
1928 test.cxx that is now reverted to its original purpous i.e.
1929 testing the proper parsing of a Dicom related file.
1930 testWrite.cxx concentrates on testing the IO part of gdcm.
1931 * Test/bug1.cxx (containing a bug on WIn32) added.
1932 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1933 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1934 whose purpose is to publish the content of the TagNames of the
1935 Dicom public dictionnary were not accessible without an
1936 instance of class gdcmHeader.
1937 - those methods are now static methods of gdcmDictSet and hence
1938 require no instances at all to be invocated.
1939 - within gdcmDictSet this change required to change some method
1940 to class methods (i.e. are now static) among which SetDictPath
1941 (renamed to BuildDictPath) and LoadDefaultPubDict.
1942 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1943 the above changes by calling the new method classes of gdcmDictSet.
1944 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1945 the above to be effective.
1946 * python/gdcmPython: in order to wrap properly the above changes
1947 for Python, swig version now needs to be > 1.3.17.
1948 * python/gdcmPython/Makefile fixed to adapt itself to new
1949 configure/make shema introduced by Johan Montagnat (thanks for the
1950 contribution). Alas this Makefile cannot be turned into a proper
1951 Makefile.am without some heavy changes in the configure.in
1952 (for python dectection).
1953 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1954 now avoids publishing the empty entries.
1956 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1957 * python/setup.py : bug fix concerning install under windows
1958 ExtraPath reused :-P
1959 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1961 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1962 * Dicts/dicomV3.dic : remove double spaces !!!
1963 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1964 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1967 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1968 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1969 method. Doxygenation.
1970 * src/gdcm.h clean up of JPR spurious comments.
1972 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1973 * python/distutilsSwigCPlusPlus.py now properly collects the
1974 shadow classes generated by "swig -c++" (gdcm.py in our case)
1975 when using "python setup.py install".
1976 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1977 reexports the working classes.
1978 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1979 by the classical C errno scheme. This is to prevent an obscure
1980 behavior of the python wrappers when importing wxPython.wx prior
1981 to gdcmPython (which ended up in an abort call). An illustration
1982 of this oddity can be found in the Test/ExceptionAndPython
1983 subdir (see the README file). This problem probably due to
1984 an combination of g++ and dynamic loading.
1985 * added Test/ExceptionAndPython (see above)
1987 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * Changed the layout of the python part to avoid bloating main
1989 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1990 i.e. the distutils arsenal. All the python related stuff is
1991 again in a python subdir, but the package itself is now in
1993 * setup.py was cleaned up:
1994 - pythonIncludePath removed
1995 - python setup.py bdist target is now functional.
1996 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1997 collision with other packages). gdcmPython/demo/*.py changed
2000 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2001 * python subdir moved to gdcmPython (preparation of distutils packaging).
2002 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2003 distutils installer is operational.
2004 * - gdcmPython/__init__.py now properly loads the swig generated
2005 shadow classes (from gdcm.py).
2006 - gdcmPython/demo/*.py changed to import the package gdcmPython
2007 instead of gdcmPython/demo/load.py.
2008 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2010 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2011 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2012 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2013 entries within the associated public Dicom dictionary resp. the same
2014 information but sorted by the fourth field (PAT, IMG, DIR) of the
2016 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2017 are now in the "???" group.
2018 - python/gdcm.i changed accordingly,
2019 - python/demo/printGroupedPublicDict.py added, that gives an example
2020 of the above new functionalities in Python.
2022 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * src/gdcm.h, gdcmHeader.cxx:
2024 - historic references to glib's g_malloc and g_free (#defined)
2025 were definitively removed.
2026 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2027 * src/gdcmElValSet.cxx:
2028 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2029 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2030 - GetElValue(string) renamed to GetElValueByName.
2031 - Added GetElementByName(string).
2032 * src/gdcmHeader.cxx: added
2033 - GetPubElValRepByNumber(guint16, guint16)
2034 - GetPubElValRepByName(string)
2035 - GetShaElValRepByNumber(guint16, guint16)
2036 - GetShaElValRepByName(string)
2037 - GetShaElValByNumber(guint16, guint16)
2038 - GetShaElValRepByName(string)
2039 - GetElValRepByNumber(guint16, guint16)
2040 - GetElValRepByName(string)
2041 - GetElValByNumber(guint16, guint16)
2042 - GetElValRepByName(string)
2043 * Doc/requirements.txt added.
2045 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2046 * Test/Makefile building now depends on the one of libgdcm.so
2047 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2048 pixel data) aware which enables finding the address (offset) of
2049 the pixel data of JPEG encoded DICOM files. This leaves only a single
2050 file in the testSuite whose pixel data address (offset) is unknown.
2051 * python/testSuite.py changed accordingly.
2053 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2054 * VC++ has some strong limitations when working with the STL, as stated
2055 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2056 "Also note that some STL containers (map, set, queue, list, deque)
2057 cannot be exported. [...]
2058 Some STL classes contain nested classes. These classes can not
2060 This is caused by a designed limitation that once a template
2061 class is instantiated, it can not be re-instantiated and
2063 Since our usage of map<> is ubiquitous in gdcm, this "designed
2064 limitation" of VC++ is a pitfall.
2065 Hence the Python wrappers of gdcm cannot be incrementally linked
2066 against the c++ dynamic library. The dirty but only workaround is
2067 to forget about incremental link of dynamic libraries and to generate
2068 the Python wrappers library with the inclusions of the underlying C++
2070 The following modifications concern this matter on Win32/VC++:
2071 - wrapping python correct with standalone wrapped dll (don't use separate
2072 dll under windows !!!!)
2073 - python21_d debug mode enabled (ask Frog how to use it :-)
2074 - NO problem with having an STL member of class for example string in C++
2075 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2076 - Python test of dcmlib in Python is ok under windows on a large set
2078 * removed glib references
2079 * typedef's inserted in gdcm.i for correct swig type management
2081 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2082 * python/demo/*.py load.py extracted from test.py. Added explore.py
2083 that only displays required tags and testAll.py that parses all
2084 the files of the testsuite without using unittest.
2085 * python/testSuite.py other additional test on new files added.
2086 * Data/* new test files added accordingly to the testSuite.
2087 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2088 the vr in the file differs from the one of the dictionary.
2090 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2091 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2092 values, but limits itself to values which are below a user specified
2093 size (by default 1024 bytes).
2094 * python/gdcm.i : elements not loaded (because their size is above the
2095 user specified treshold) are exported with their TagKey as key of the
2096 python dictionary. This enables the testsuite to make some checks
2097 on the unloaded elements (since we have their offset and size).
2098 * python/testSuite.py
2099 - now tests for the existence and proper value of the pixel data
2100 - two new examples added.
2101 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2103 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2104 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2105 aware. See the strategy comments in gdcmHeader::FindeLength().
2106 * Test/test.cxx now accepts a filename as first argument.
2107 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2108 * python/testSuite.py changed to integrate test on above files.
2110 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2111 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2112 the vr was also RET.
2113 * python/testSuite.py more tests added.
2115 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2116 * python/testSuite.py unittest test suite added (uses Data)
2117 * Data/* dcm and acr files for the test suite.
2118 * glib dependance removed from un*x version. We now use ISO C99
2119 7.18 Integer types (see stdint.h)
2120 - python/Makefile, src/Makefile src/gdcm.h
2121 * src/ when an explicit vr (like dicom files) suddenly poped an
2122 implicit element we use to mark the underlying DictEntry of the
2123 concerned ElValue with "Implicit". This strategy was damageable
2124 too the public or provite dictionaries, since some of their vr
2125 would be changed. Since Header::FindLength heavily relies on the
2126 detection by Header::FindVR of falsely explicit elements, I
2127 added an extra ImplicitVr member to ElValue (boolean).
2128 The rest of the changes we the necessary adaptations.
2130 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2131 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2133 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2135 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2136 * Adaptation for porting to VC++:
2138 o forced to use std namespace (for string to be known)
2139 o all class use __declspec export style on WIN32
2140 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2141 (in stdlib.h on Win32 but in std:: for gcc)
2142 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2143 variable GDCM_DICT_PATH.
2144 * src/gdcmHeader.cxx verbose comments made discrete.
2146 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2147 * python/gdcm.i: added a typemap that converts a C++ hashing table
2148 to native Python dictionary.
2149 * python/demo/test.py:
2150 - now uses the native dictionary for exploration of gdcmHeader.
2151 - takes an optional filename argument (the file to parse).
2152 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2153 PubElVals hashing table.
2154 * Dicts/dicomV3.dic removed error prone trailing spaces.
2156 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2157 * Python wrapping process moved away from src/Makefile to
2158 newly created python/Makefile (as well as gdcm.i)
2159 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2160 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2161 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2162 from the environement variable GDCM_DICT_PATH (when existing).
2163 * src/gdcmDict::GetTag bug fix.
2165 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2166 * Straightforward temporary fixes for swig to build the python wrappers.
2167 src/Makefile now has a python working entry [by working we mean
2168 that we can import de shadow classes without errors].
2170 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2171 * hashtest.cxx removed (since allready in Test)
2172 * src/gdcmlib.h renamed to src/gdcm.h
2173 * src/dcm.i renamed to src/gdcm.i
2174 * src/Makefile prepared for python wrapping
2176 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.cxx :
2178 - Parsing of header is now separated from loading of element values
2179 (see gdcmHeader::LoadElements).
2180 - general clean up of hopefully all file access (creation of
2181 ReadInt16 and ReadInt32)
2183 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * src/gdcmHeader.cxx :
2185 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2187 - SetLgrElem renamed to SetLength
2188 - GetLgrElem renamed to GetLength
2189 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2190 * src/gdcmElValSet.cxx fixed both GetElValue methods
2191 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2192 due to IdoDude was cleaned out.
2194 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2195 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2196 concentrates on finding the value representation (when it exists).
2197 RecupLgr now only finds the element value length, and it avoids
2198 returning the unecessary skL (skipped length).
2199 Also, offsetCourant was simply removed (with taille_fich) since
2200 it was redundant with the File position internals (by using
2201 ftell and fseek). This also made skL (see above in RecupLgr) usage
2203 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2204 on the libido specificities which are handled through class
2206 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2209 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * Truckload of changes. Parsing of header is barely functional
2211 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2213 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2214 * src/gdcmHeader.cxx many addons of low level methods
2216 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2217 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2218 and _IdDcmSWAP_LONG.
2220 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * This corresponds to all the changes decided at the meeting of
2222 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob