1 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
3 And now use a static function call instead, with a global variable. i
4 This is much closer to the VTK approach. Hopefully should be bulletproof
5 and easier to use...hopefully
7 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
8 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
10 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
13 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
15 ValEntry, BinEntry, SeqEntry creation or replace
17 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
18 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
19 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
21 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
22 when specifying the VR
23 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
24 * src/gdcmDocEntry.cxx : amelioration of print
26 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
27 * ADD : Add the method Util::IsCurrentProcessorBigEndian
28 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
29 * ADD Method Document::ComputeGroupLength
30 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
31 in order to allow further VR modification by user
32 * REM : removal of once-called method File::WriteBase
33 integration of its code in formerly one-line method File::Write
35 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
36 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
37 replace the different values "??", "Unkn", "Unknown".
38 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
39 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
40 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
41 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
43 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
46 * Set the gdcm::Base class to some Printable classes
48 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
49 * src/gdcmFile.[h|cxx] : add the Print method
50 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
51 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
52 * src/gdcmDocument.h : remove the PrintLevel informations
53 * Example/PrintFile.cxx : use the new gdcm::File::Print
55 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
57 problems when compiling with the python wrapping
59 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
61 writting in ImplicitVR
63 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
64 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
65 JPEG decompression, especially when dicom frames are split into several
66 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
67 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
69 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
70 * src/gdcmHeader.cxx : change the initialisation of default header.
71 Now, this header is readable by gdm, e-film, DicomWorks
73 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
75 Rename Decompressed to Raw
76 * Use the API changes in gdcm::File.
77 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
80 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
81 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
82 each added entry in the header. Replace the 'Planes' field by the 'Number
85 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
86 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
87 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
89 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
91 At this time, this image isn't readable by e-film... waiting JPR help to
94 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
96 DocEntry. Now use methods of the Document !
98 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
99 * Test/ShowDicomSeq.cxx : bug fix
101 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
103 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
104 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
105 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
107 * Test/TestCopyRescaleDicom.cxx : remove unused variable
108 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
109 containing found sequences
111 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
112 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
114 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
115 Some fields in BinEntry must be copied to not seg fault when making the :
116 gdcm::File *copy = new gdcm::File( copyH );
117 and tests are now made on good variables
119 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
120 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
121 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
123 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
124 * Add vtkGdcmWriter example and test
126 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * Test/TestUtil.cxx : reformat the source code
128 * vtk/vtkGdcmReader.cxx : remove and change prints
129 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
131 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
132 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
134 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
135 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
136 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
138 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
139 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
140 by an eof to prevent all bad read of the file... and in this case, the
143 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * Example/Volume2Dicom.cxx : comment unused variables
145 * Test/PrintDicomDir.cxx : comment unused variables
146 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
147 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
148 method that is redondant with AddEntry.
149 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
152 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * Bug fix due my last commit (compilation under Windows).
154 * Example/Volume2Dicom : bug fix in the file and reformatting source code
155 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
157 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
159 - Remove printf / sprintf
160 - include iostream AFTER gdcm so we don't get warnings
161 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
163 - Also remove tons of include from header files, hopefully this should
164 speeup the compilation time, since it was becoming a dog slow.
165 - Remove gdcm.h as it include way too many files and slow down compilation
166 (plus it is not up to date)
167 - remove 'using namespace std' this is BAD !
169 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
170 * Remove memory leaks on the DicomDir
171 * Remove some useless datas in DicomDirObject
172 * Add usefull methods in SQItem, to be complient withe the ElementSet
174 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
175 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
177 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
179 future, with convertion)
180 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
181 and ImageDataSize values. Remove the method to get the PixelReadConverter
182 from the output of the class
184 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
185 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
187 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
188 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
189 and vtkErrorMacro use.
190 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
192 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
195 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
196 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
197 The string leaves only in the fonction. So when we make a .c_str(), we
198 get the pointeur on the first element, element that will be destroyed
199 immediately after thee instruction.
200 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
201 file has been opened : the test must be made on the content of the
202 pointer and not directly on the pointer !
205 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
207 the python part recompiles
209 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
211 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
212 X session is killed (for my computer... it seems to not be identic on
215 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
217 avoid problems (otherwise, the difference test between the visible image
218 and the reference is incorrect. If the reference is greater than the
219 screen resolution, it's produce errors).
220 Can be used for only one image. Can be used with a visible flag.
221 * vtk/vtkGdcmReader.cxx : remove commented codes.
222 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
223 under windows at compilation
224 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
226 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
228 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
229 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
230 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
231 tests on the image size X, Y, Z
233 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
235 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
236 between the class name and the file name
238 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
239 * src/ : fix compilation warnings for the Write method (2 different
240 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
241 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
242 variable... create a static method in gdcm::Document to access to
243 this variable content.
245 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
246 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
247 file, to be accessed by other files (like gdcmFile). Remove commented
248 code. Move the change of the header to the gdcmFile, using the
250 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
251 To be sure of that (and simplify calls), the Write of the header now
252 gets a file name and not a file pointer (std::ifstream).
253 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
254 DocEntryArchive. Remove all open of the written file
256 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
259 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
261 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
263 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
264 some corresponding methods. Write correctly the file and check before
266 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
267 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
268 is now on RGB datas (as before my last commit
269 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
271 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
272 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
273 Add a print information of the type of the entry
274 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
275 It was in the gdcmFile, and all write have been regrouped
276 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
277 Write correctly all dicom files (in decompressed mode only at this time)
278 * Test/ : test on files are now made using Raw datas and not color datas if
280 * Example/PrintFile.cxx : add more printings
282 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
283 * Amelioration of code, remove some code copy. For the loading of
284 BinEntry (in gdcmDocument), add the test to verify if the file is already
287 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
289 remove a DocEntry in the header (push an empty DocEntry)
290 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
291 lines. Bug fix in the initialization of the PixelConvert and the
293 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
294 use in TestCopyDicom (now this test can run under windows... but fails)
295 * Test/TestCopyDicom.cxx : amelioration of the test :
296 - test the pixels written
297 - add test points to quickly find where is the error
298 - can set a file name input and output in arguments
299 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
300 amelioration of the test output
302 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
303 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
304 all replaced DocEntry's
305 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
306 Now, each needed DocEntry to modify is duplicated, modified and inserted
307 to the header using DocEntryArchive. Thus, after save, we can restore the
308 header initial state.
310 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
313 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
314 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
315 correct to copy it. The DictEntry is specified at the DocEntry creation,
316 then, it musn't change in the time.
317 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
318 header correctly. At this time, the change is only made for the first
319 level of the Document. In the future, it might consider sequences.
320 The change is made by replacing a DocEntry by an other that is created
321 outside the class. The old value is kept. When we restore the header
322 status, the added DocEntry is deleted and replaced by the old value.
323 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
324 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
325 set the write type to explicit VR, implicit VR or ACR. Add methods to set
326 the write mode to native, decompressed or RGB (but not used at this time)
328 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
330 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
332 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
334 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
336 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
337 set because already copied when copying the BinEntry's of the header
338 * Test/TestAllReadCompareDicom.cxx : remove warnings
340 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
341 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
342 Two problems appear when doing it :
343 - with the gdcmFile : when the GetImageData method is called, the pixels
344 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
345 datas (pixels). And each structure destruct the datas when it's
346 destructed. So we have two destructions for the same datas. To solve it,
347 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
348 datas or not. If it doesn't own datas, then they will not destroyed by
350 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
351 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
352 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
353 create a double destruction of the same DocEntry's. So, to solve it,
354 the TagHT is simply cleared and the DicomDir* elements are destroyed.
355 * TODO : add an entry concerning memory leaks in the DicomDir
357 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
358 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
359 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
362 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
363 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
364 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
365 after it have been deleted
367 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * FIX: src/* fix the doxygen warnings.
369 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
370 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
371 was erroneously defined with a size of 15 instead of 16. [many thanks
372 to Jean Michel Rouet for pointing out this bug].
374 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 1. Finish merging JMR patch for writting DICOM from scratch
376 2. Fix -hopefully- bug with MONOCHROME and space vs null character
377 3. Use const ref when possible
378 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
379 5. A few more comments
380 6. CreateUniqueUID can now be called without parameter"
382 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * ENH: Slightly bigger patch:
384 1. Getting toward full integration of JMR patch for writting dicom from scratch
385 2. Update Test to test part of this patch: CreateUniqueUID
386 3. File was not close properly in gdcmDict
387 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
388 5. Use of const ref instead of copy (speed issue)
389 6. Remove temporary (duplicate) string in TranslateToKey
390 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
391 8. Do not repeat virtual in subclasses
392 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
394 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
395 * Apply first patch toward better string comparison when dealing with broken
396 DICOM files. Essentially the string could be padded with a space instead
397 of a null character as defined by standard
399 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
400 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
401 because never used... and in the same time, that's remove some memory leaks
403 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
404 * src/gdcmFile.cxx : now delete the PixelConvert instance.
405 * In examples and tests : change the type of image data variables from void*
406 to uint8_t*. Remmove all delete on image data variables
408 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
410 Verify the file pointer value before open the file, and if it's not null,
411 a verbose message is generated.
412 Close correctly the file when the file isn't considered dicom-like. The
413 correctly close is a call to CloseFile.
414 When closing the file pointer, test if its not null to close the file.
415 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
416 file. For an uncompressed image, the copied datas correspond in the least
417 case to the image size (calculated) or the image size specified in the
418 header. A verbose is generated if these two size mismatch
420 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
421 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
422 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
423 break under windows (with msvc6 compilation).
425 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
426 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
427 compiling with MSVC6)
429 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
430 * Bugs fix for the Windows build with VC6
431 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
432 needed (only for projects required VTK). If the VTK is included in all
433 projects, there is conflicts with the jpeg lib of vtk when compiling the
434 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
435 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
436 when compiling the gdcm_wrap.cxx file (created by the compilation of the
438 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
439 (like it's already made for the cout use). Otherwise, conflict with the
442 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
445 - comments on the DicomDir::Method related usage added.
446 - now that we use the namespace gdcm, a lot of internal classes do
447 NOT need to be wrapped anymore.
448 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
449 DicomDir::Method) new example added.
451 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
452 * Improve string manipulation. I now inforce the notion of 'DicomString'
453 A DicomString can contain as many \0 as they want
454 and it is *always* of even length.
455 We only support odd length for very rare case.
456 And in the near future this should be removed.
458 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
459 * /binary_write/ gdcm source. Now even on big endian we are writting
460 little endian. This should -heopfully- fix some tests
462 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
463 * Now the dictionary is compiled into gdcm lib. This is a default
464 behavior, thus any dic file specified is picked before failback to
465 the one comiled into lib
467 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
468 * Change internals for gdcmDict. Don't use any 'new' any more.
469 This should definitely solve any leak problem, and we should be
470 as fast as before, as long as don't modify too much the dictionary.
472 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
473 * STYLE: ivars should start with a capital letter.
474 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
475 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
477 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
478 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
479 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
480 new 2004 dictionaries added (thanks to JPR).
481 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
482 * CLEANUP_ROUND (15) for gdcmPixelConvert
483 - RLEFrame::NumberFragments is now of type unsigned int
484 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
485 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
488 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
489 * Initial work in gathering all transfer syntax accessors. clearly
490 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
491 ivars, but only one transfersyntax (class) ivar with equivalent method on
494 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
495 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
496 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
497 discussed (plus I didn't like having a 2000 lines patch not commited)
499 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
500 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
501 * CLEANUP_ROUND (14) for gdcmPixelConvert
502 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
503 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
504 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
506 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
507 anymore and hence avoids storing a copy of PixelConvert::Decompressed
508 into File::Pixel_Data.
510 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
511 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
512 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
513 * CLEANUP_ROUND (13) for gdcmPixelConvert
514 Substituted File::ParsePixelData() with PixelConvert::Print() new
516 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
517 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
518 method to those classes.
519 - src/gdcmFile.[cxx|h]:
520 -- Added a ::Print() method.
521 -- PixelConverter is now a reference instead of a member.
522 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
523 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
525 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
527 collaboration diagram and inheritance diagram should be generated with
529 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
530 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
531 pointlessly wrapped (see
532 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
533 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
534 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
535 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
536 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
537 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
538 -- File::Initialise: PixelConverter setup moved away to
539 PixelConverter::GrabInformationsFromHeader()
540 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
541 interpretation moved away to PixelConverter::BuildRGBImage()
543 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
545 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
547 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
548 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
549 displayed on Win32 when a brutal abort() occurs (because of uncatched
550 exception). See TODO new entry of this commit for more on this.
551 * TODO added new entry.
552 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
553 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
554 - HandleColor is no longer called from gdcmFile.cxx
555 - gdcmPixelConvert.cxx clean up on method arguments and internal
556 variable names for semantical coherence.
558 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
559 * Finished lossless transition, not only do we now read all lossless jpeg
560 images, without the need of the Cornwell lib, but we do read them properly now
561 * To reduce code (well to avoid code duplication), I defined a common place
562 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
563 redefine symbols. This is not prefect but this the best solution I found for a
564 compilation time jpeg option.
566 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
567 * Update jpeg ijg lib to support lossless jpeg implementation
568 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
570 * Also added a special copyright for dcmtk since we use their bugfixes.
573 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
574 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
575 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
576 matters, as stated in warning note at begining of %include section).
577 * src/gdcmDicomDir*.[cxx|h]: coding style
578 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
579 * src/gdcmJpeg8.cxx: doxygen fix.
580 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
581 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
582 from File:: to PixelConvert::.
584 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
585 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
586 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
587 - more code moved away from File:: to PixelConvert::
588 - fat setup of PixelConverter set in place in File::Initialise.
590 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
591 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
592 namespace at the file system level. So now you should convert your examples
594 gdcmHeader -> gdcm::Header
595 It would be nice if people keep in mind to no open the namespace, since it
596 allows compilation on broken plateform which were defining common symbol in
597 the standart namespace (like LP, Unknown ...)
599 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
600 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
601 The JPEG fragments are now parsed at the same stage than the RLE
602 information. All code related to JPEG is now in gdcmPixelConvert:
603 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
604 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
605 export a gdcmFile:: method. Those are simply global functions
606 (for the time being this is better than having them attach to
607 either gdcmFile:: or gdcmPixelConvert::).
608 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
609 and stores the result in a gdcmJPEGFragmentsInfo.
610 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
611 code (among other stuff) moved away from gdcmFile:; to
614 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
615 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
616 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
617 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
618 clean up of RLE related code.
619 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
620 - src/gdcmRLE.cxx removed
621 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
622 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
623 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
624 * CLEANUP_ROUND (9) for gdcmPixelConvert
625 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
626 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
627 away from gdcmFile:: to gdcmPixelConvert::.
629 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
630 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
631 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
632 This is because Parse7Fe0 used to parse the pixels to compute the
633 length. This task was passed over to FindDocEntryLengthOB() a long
634 time ago, EXCEPT I had forgotten the OW case...
635 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
636 we just recylce the code for parsing RLE fragments and computing
638 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
639 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
640 with the retired Parse7Fe0().
641 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
642 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
644 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
645 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
646 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
647 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
648 - src/CMakeLists.txt: alphabetic order reodering + new entries.
649 * CLEANUP_ROUND (4) for gdcmPixelConvert
650 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
651 to return an unused length.
653 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
654 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
655 this should be cleanner from the plane view. The iostream are erally a pain
656 to use to do simple stuff.
658 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
659 * Redo the compilation of the ijg jpeg library. Now only one source is
660 necesseray. No need to rename file by hand what so ever. CMake handle the
661 copying of the file within different directory, configure header file to
662 modify some symbol. The only addition made to ijg wasd a mangle table so
663 that symbol are different wether we are within 8bits or 12bits.
665 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
666 * Added documentation of vtkgdcmReader on Website:
667 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
668 with it's binary name).
669 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
670 the Website to be more complete.
671 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
672 doxygenated documentation.
673 - Doc/DoxyVtkGdcmReaderExamples.txt added
674 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
675 DoxyVtkGdmReaderExamples.html )
676 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
677 * CLEANUP_ROUND (3) for gdcmPixelConvert
678 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
680 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
681 * CLEANUP_ROUND (2) for gdcmPixelConvert
682 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
684 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
685 * CLEANUP_ROUND for gdcmPixelConvert:
686 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
687 - src/gdcmPixelStuff[h|cxx] removed
688 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
689 - src/CMakeLists.txt changed accordingly
691 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
692 gdcmVersion.py moved to newly created ATTIC related
693 gdcmPython/SetupOldies/ directory.
694 * Autotools clean up:
695 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
696 - autogen.sh configure.in acinclude.m4 python.m4 removed
698 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
699 * src/*.cxx *.h Reference to License.htm fixed to License.html.
700 * Doc/CMakeLists.txt, doxygen.config.in: fix.
701 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
703 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * TODO updated with Mathieu suggestions. I proposed a template for
705 describing TODO entries and used it for new entries.
706 * Added Doc/Website/CodingStyle.html, Developpers.html,
707 DeveloppersPython.html, GdcmDataCvs.html and
708 DownloadVersion0_1.html, DownloadVersion0_3.html.
709 * Some Doc/*.txt Doxygen files (which do not really concern the
710 documentation itself, but the website) moved to html and
711 placed in directory Doc/Website:
712 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
713 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
714 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
715 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
716 * CMakeLists.txt changed accordingly.
717 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
718 DeveloppersPython.html
719 * INSTALL nows refers to Doc/Website/Installation.html
721 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * Added Doc/Website directory, that contains a first raw version
725 2004-09-23 Jean-Pierre Roux
726 * FIX In order not to be poluted any longer by casting problems,
727 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
728 we can now delete[] it safely
729 * VoidArea is now called BinArea (less confusing name),
730 and all the methods called ...VoidArea... are now ... BinArea...
731 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
733 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
734 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
735 clear) TagHT, which is an inherited member of gdcmElementSet. It is
736 up to the destructor of gdcmElementSet to clean up TagHt and it's
739 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
740 * Test/CMakeLists.txt: update to follow gdcmData renamings.
741 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
743 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
744 * ENH: added some utility method that builds a flat dictionnary
745 holding all the Dicom entries contained in the recursive structure
746 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
748 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
749 BuildFlatHashTable() that build a flat dictionary.
750 - src/gdcmElementSet.h: added a new private GetTag() accessor.
751 gdcmDocument is now a friend of gdcmElementSet.
752 - src/gdcmElementSet.cxx: clean up.
753 - Example/FlatHashTablePrint.cxx added.
754 - Example/CmakeLists.txt changed accordingly
756 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
758 moved away from gdcmDocEntrySet (since this class is an abstract class
759 acting like an interface). SQDepthLevel and BaseTagKey are now
761 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
762 and associated accessors. Doxygenation of the class.
763 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
765 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
766 Use SQDepthLevel accessor instead. ::Print() adapted.
767 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
768 - src/gdcmDocument.cxx changed accordingly.
770 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
771 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
772 - The following is the doxygen comment of the typedef declaration
773 of gdcmagKey in src/gdcmCommon.h:
774 gdcmTagKey is made to old an "universal" (as in URL, Universal
775 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
776 A dicom tag allways has a group and an element, but a set of tags
777 embeded in various (optionally nested) sequences and sharing
778 the same group and element all share the same (group, element)
779 "identifier". Hence the (group, element) cannot be used as an
780 identifier (in gdcm we shall refer to a "TagKey") of a tag.
781 In order to construct a proper tag identifier (i.e. a key) we
782 consider the following definition of a TagKey:
783 - let Group, Element be the string representation of the
784 group and element dicom tag members,
785 - let ItemNumber be the string representation of the integer
786 index of the considered item number of a sequence,
787 Let the key of a tag embeded in a sequence, noted SeqTag, be
789 /ItemNumber#Group|Element
790 where "/", "#" and "|" are characters acting as separators.
791 Then the general form of a gdcmTagKey is given by:
792 Group|Element<SeqTag>
793 where <SeqTag> means NO or many instances of SeqTag.
794 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
797 but the gdcmTagKey of a tag "embeded" is the first item of
798 a sequence, itself nested in the third item of a sequence is the
800 0004|1220/2#0008|0082/0#0008|0090
801 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
802 order to hold the new sequence compatible key. Previously, the
803 GetKey() method would look in the underlying gdcmDictEntry.
804 - src/gdcmDocEntry.cxx:
805 -- constructor now copies the underlying DictEntry key, in the local
807 -- ::Print: displays the member Key, instead of the (group, element).
808 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
809 - src/gdcmDocEntrySet.h:xi
810 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
811 -- now has a new BaseTagKey member.
813 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
814 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
816 This poses the problem with the semantics of the following lines
817 LoadEntryVoidArea(0x0028,0x1201); // R LUT
818 LoadEntryVoidArea(0x0028,0x1202); // G LUT
819 LoadEntryVoidArea(0x0028,0x1203); // B LUT
820 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
821 to the long FIXME note for what the problem is. Nevertheless in
822 order to get things working the dicom dictionary was altered !
823 Please fix things urgently...
824 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
825 information), see above note on moving the member VoidArea. Nevertheless
826 the following entries previously correctly set as US are now inproperly
828 0028 1201 OW IMG Red Palette Color Lookup Table Data
829 0028 1202 OW IMG Green Palette Color Lookup Table Data
830 0028 1203 OW IMG Blue Palette Color Lookup Table Data
831 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
832 of gdcmDocEntry moved to gdcmSeqEntry.
833 * src/gdcmSeqEntry.cxx: STYLE.
835 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
836 * Test/TestAllEntryVerify.cxx minor fix and added comments.
838 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * gdcmPython/testSuite.py: all the test suite in python is now moved
840 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
841 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
842 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
844 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
846 to avoid inclusion recursion until STL is reached.
847 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
848 mecanism. errno.h is not included in gdcm anymore.
849 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
850 (gdcmFormatError now inherits from gdcmFormatUnexpected).
852 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
853 gdcmData/TestAllEntryVerifyReference.txt
854 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
855 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
856 exception_on_error parameter.
857 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
858 - vtk/vtkGdcmReader.cxx changed accordingly,
859 - Example/*.cxx and Test/*.cxx changed accordingly.
861 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
862 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
863 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
864 enable_sequences removed from gdcmHeader constructor and dependencies.
865 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
866 * gdcmPython/demo/PrintHeader.py: dummy fix.
867 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
868 skip_shadow removed from gdcmHeader constructor and dependencies.
869 * Example/*.cxx and Test/*.cxx changed accordingly.
871 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
872 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
873 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
875 2004-07-21 Jean-Pierre Roux
876 * FIX Now, Parsing and Printing a DICOMDIR do work!
877 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
879 2004-07-20 Jean-Pierre Roux
880 * FIX Some brain damaged headers have Zero-Lenght fields
881 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
883 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
884 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
885 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
886 variable (instance of gdcmDebug) by a definition macro, and the instance
887 is now in static in the gdcmDebug class
888 * src/gdcmSQItem.h : (FIXME) remove an undefined method
889 * Test/PrintAllDocument.cxx : bug fix in the result of the test
891 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
892 * WARNING: ctest now depends more tightly on gdcmData. You should
893 check out gdcmData properly for things to run smoothly...
894 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
895 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
896 we need the pixels not be loaded in order to use the ValEntry
897 that displays position and size).
898 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
899 This is a C++ based equivalent of gdcmPython/testSuite.py that should
900 be deprecated. If you have any doubts about the advantages of a
901 modern scripting language (read Python) versus grass root C++ (i.e.
902 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
903 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
904 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
905 Anyhow, consider documenting the gdcmData images in
906 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
908 * Test/CMakeLists.txt:
909 - now uses TestAllEntryVerify.cxx
910 - specific comments on oldACR00001.ima (now renamed in gdcmData
911 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
912 gdcmData/TestAllEntryVerifyReference.txt
915 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
916 * src/*.[h|cxx] : typedef clean up
917 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
918 - TagKey renamed to gdcmTagKey (for external usage)
919 - VRKey renamed to gdcmVRKey (for external usage)
920 - removal of typedef duplication.
921 - Removed all unecessary inline keyword from class inline definitions.
922 - Some method|function(void) declarations replaced with method|function().
923 * src/jpeg/libijg12/jdhuff12.c:
924 - printf polluting ctest removed.
925 - TAB removal for comminting
927 - TestAllReadCompareDicom.cxx: added a test that compares all the
928 images in gdcmDataImages.h with corresponding images in
929 gdcmData/BaselineDicom/. When baseline images are not present
930 this test creates them.
931 Note: we need to validate each reference image, but before that
932 I'd like to rename them with a more explicit name...
933 - CMakeLists.txt: changed accordingly.
934 * Example/*.cxx: examples now only include gdcm.h (as opposed to
935 including each header needed).
937 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
938 * Test/*.cxx and Example/*.cxx: moved some examples away from the
939 test suite to the Example directory. Are concerned:
944 - TestWriteSimple.cxx
945 * Test/CMakeLists.txt: added some comments on reasons for black listing
946 image gdcmData/oldACR00001.ima
948 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
949 * Test/CmakeList.txt: removed the following from black list (to be coherent
950 with removal from gdcmData):
951 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
952 - gdcm-MR-PHILIPS-16.dcm
954 Added the following because after last cvs update, they cause
955 ctest -R TestReadWriteReadCompare
957 - gdcm-MR-SIEMENS-16-1.acr
959 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
960 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
961 new comments in this file) we temporarily (sigh) move to a weaker
963 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
964 we don't need to black list the following images anymore:
965 - 8BitsUncompressedColor.dcm
967 - US-PAL-8-10x-echo.dcm
968 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
969 fixes and the beautified code ;-)
970 This fixes the bug introduced in version 1.42 (when beautifying)
971 that made the parsing of 8BitsRunLengthColor.dcm unproper.
972 Note: ctest was blind to this bug (this means we need to still
973 improve the test suite). The bug could be detected by using
974 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
976 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
977 and by displaying the (garbage) produced file temp.XDCM...
979 2004-06-29 Jean-Pierre Roux
980 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
981 - replace by uggly but working old code :-(
982 A lot of things should be OK again.
983 It's really urgent to have a test suite that *tests*,
984 to prevent Frog's beautifying sessions to break all the stuff
985 (twice, withing a fortnigh ...)
987 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
988 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
989 redundancy) to added Test/TestReadWriteReadCompare.cxx
990 * Test/CmakeList.txt: because the compare test of
991 Test/TestReadWriteReadCompare.cxx fails, the following images are
992 black listed: - 8BitsUncompressedColor.dcm
994 - US-PAL-8-10x-echo.dcm
995 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
996 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
997 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
998 and ad-hoc kludge. This kludge is now removed, and on encountering
999 such an image (OB field brain damaged) we set errno. Then in
1000 ::FindDocLength() we "fix" the length as being ALL what remains
1001 in the file (until EOF). We then proceed, hoping for the best...
1002 This fixes a SegFault in ShowDicom when trying to write such an
1004 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1005 (because TestWriteRead breaks on it, after a non conformal commit?).
1006 ctest now runs properly, except for MakeDicomDir (which was allways
1007 broken) and the Python related stuff (still not fixed).
1009 2004-06-24 Jean-Pierre Roux
1010 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1011 FIX : Test/TestReadWrite now iterates on all the file names
1012 (instead of infinite loop)
1013 ENH : Test/TestWriteRead now iterates on all the file names
1015 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1018 2004-06-24 Jean-Pierre Roux
1019 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1020 when SamplesPerPixel =3
1021 - now Write is no longer confused by
1022 'BitsAllocated = 12" and 'BitsStored=12"
1023 - "UN" value representation Elements are now written correctly
1024 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1025 ENH : - now gdcmHeader has its own Write methods
1026 (in order to split the job that has not to be done
1029 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1030 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1031 loop on the same image until memory went out.
1032 Note: this means we still have gobs of memory loss in PrintDocument
1033 * src/gdcmDocument.cxx: fixes problem on parsing on file
1034 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1036 2004-06-24 Jean-Pierre Roux
1037 FIX : Write - All the Sequences and Sequence Item are now written
1038 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1039 is added a the end, when necessary.
1040 - A lot of brain-damaged images, that were read correctly are
1041 now written correctly
1042 - length compatible BinEntry are now loaded correctly
1043 (even for odd groups)
1044 Note : only Explicit Value Representation was checked.
1045 (question : is implicit VR really necessary for gdcm ?)
1047 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1048 * DEVELOPPER: added a proposition of coding style.
1049 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1052 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1053 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1054 Use the gdcmDocEntry::Print() and Write() instead.
1055 * src/gdcmDocument.cxx: bug fix.
1057 2004-06-22 Jean-Pierre Roux
1058 FIX : gdcmDocument.cxx
1059 - Now we do recognize the JpegLossLess format (there was a misstyping in
1060 code 'beautyfication' :-(
1061 - Now we automaticaticaly load the Luts, if any
1063 2004-06-22 Jean-Pierre Roux
1064 In order : to write Sequences, whatever their imbrication level,
1065 : to allow user to create his own Sequences
1066 a lot of modif where necessary (adding, moving, or virtualising methods)
1068 WARNING : save your own sources *before* cvs up !
1071 ADD virtual void Write(FILE *fp, FileType filetype);
1074 ADD virtual void Write(FILE *fp, FileType filetype);
1075 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1078 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1079 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1080 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1081 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1082 ADD std::string GetEntryByName(TagName name);
1083 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1085 std::string vr = "unkn",
1086 std::string fourth = "unkn",
1087 std::string name = "unkn");
1088 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1089 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1090 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1091 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1092 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1093 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1094 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1095 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1098 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1099 ADD virtual std::string GetEntryByName (TagName tagName);
1100 ADD virtual std::string GetEntryVRByName (TagName tagName);
1101 REM virtual bool Write(FILE *, FileType);
1102 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1103 FILE *_fp, FileType type);
1104 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1105 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1106 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1107 REM virtual std::string GetEntryByName (std::string tagName);
1108 REM virtual std::string GetEntryVRByName (std::string tagName);
1109 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1110 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1111 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1113 std::string vr = "unkn",
1114 std::string fourth = "unkn",
1115 std::string name = "unkn");
1116 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1117 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1118 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1119 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1122 ADD virtual void Write(FILE *fp, FileType filetype);
1125 ADD virtual void Write(FILE *fp,FileType filetype);
1128 ADD virtual void Write(FILE *fp, FileType filetype);
1129 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1130 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1131 REM std::string GetEntryByName(TagName name);
1134 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1136 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1137 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1138 The default constructor invoked by the line
1139 gdcmHeader *f1 = new gdcmHeader( header );
1140 was gdcmHeader::gdcmHeader(bool) instead of the expected
1141 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1142 Hence the parsing wasn't executed... See also below.
1143 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1144 as explicit constructor didn't do the trick to fix the above problem.
1145 Could anyone explain why ?
1146 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1147 properly calls gdcmValEntry::Print() (that was weed out from
1148 code related to gdcmBinEntry).
1150 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1151 * In order to fix memory leaks:
1152 - Test/TestWriteSimple.cxx: added cleaning of free store through
1154 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1155 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1156 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1157 (through the call to ::AddDicomDirMeta()) or the destructor
1158 would crash when deleting uninitialized ::metaElems].
1159 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1160 - src/gdcmDocument.cxx:
1161 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1162 from dynamic stores.
1163 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1164 was causing memory leaks.
1165 - src/gdcmSQItem.cxx:
1166 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1167 cleanly handled with polymophism: sorry but my milage is low).
1168 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1169 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1170 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1171 This avoids SegFaulting.
1172 - src/gdcmSQItem.h: coding style.
1174 - Test/TestWriteSimple still severely sucks. The output image content
1175 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1176 damaged when displayed with vtkgdcmViewer.
1177 - on memory leaks: TestWriteSimple leaks really less (see entry
1178 of 2004-06-18 in Changelog file for the call to valgrind).
1179 - on segfaults: ctest now passes all the tests but one (no more
1181 * Erroneous leading white fix:
1182 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1183 white[s] (as opposed to from >> xxx, that removes it [them].
1184 - src/gdcmTS.cxx: ditto.
1185 - gdcmPython/testSuite.py: dirty related kludge removed.
1186 * src/*: remaining references to gdcmParser removed.
1187 * src/*[cxx|h]: added copy[way]left header.
1190 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1191 * In order to fix writing of dicom files:
1192 - Test/TestWriteSimple.cxx: a simpler example of writing.
1193 - Test/CMakeLists.txt changed accordingly.
1194 - src/gdcmDocument.cxx:
1195 -- The destructor now recursilvely removes potential sequences.
1196 -- Bug fix in ::IsJPEG2000()
1197 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1198 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1200 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1201 to only declared) and build on top of
1202 ::GetDocEntryByNumber(guint16, guint16).
1203 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1204 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1205 for usage in destructor and treatement of promotion in
1206 ::ReplaceOrCreateByNumber().
1207 - src/gdcmSQItem.cxx: destructor should better handle his job.
1208 Test/TestWriteSimple now runs (or at least it DOES something).
1209 * We can now start hutting memory links. A good starting point is:
1210 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1211 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1212 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1214 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * Valgrind note: after Mathieu Malaterre teached me how to read
1216 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1218 Using gcc, you can force the STL to use malloc and to free memory as
1219 soon as possible by globally disabling memory caching.
1220 With 3.2.2 and later, you should export the environment variable
1221 GLIBCPP_FORCE_NEW before running your program.
1222 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1223 simply vanish (it is still not clear to me, whether this means that
1224 STL std::string leaks or if valgrind believes it leaks...).
1225 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1226 running bin/gdcmTests makeDicomDir):
1227 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1228 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1230 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1231 SegFaulting (I drowned in DicomDir related code when trying to
1232 understand why the list is empty...).
1233 * src/gdcmDocument.h: first BSD license header try.
1234 * Doc/License.txt added.
1236 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1237 * src/gdcmDocument.[h|cxx]:
1238 - Clean up of the Transfer related predicates. They are now all based
1239 on new method isGivenTransferSyntax, that (should) handle properly
1240 the padding problem.
1241 - general clean up, simplification, and coding style.
1242 - Specific clean up of Parse7FE0() (umproperly named actually).
1243 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1245 2004-06-14 Jean-Pierre Roux
1247 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1248 - fix the display of SQItem ordinal number
1249 - add the GetSQItemByOrdinalNumber method
1250 - remove some useless never written private methods
1252 2004-06-14 Jean-Pierre Roux
1254 - adding a constructor taking a gdcmDocEntry as an input param
1255 - ReplaceOrCreateByNumber now returns :
1256 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1257 a gdcmValEntry * if a string value is passed as a param
1259 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1260 according to the param type (no longer sets a gdcmDocEntry)
1261 - GetValEntryByNumber, GetBinEntryByNumber added
1262 - NewValEntryByNumber and NewBinEntryByNumber added
1264 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1266 - GetSQItemNumber and SetSQItemNumber added, to provide
1267 a (relative) Item identier inside a given Sequence
1268 \warning : some pb remaining around this number
1270 - AddEntry now takes the Item Number as a param
1272 - adding a constructor taking a gdcmDocEntry as an input param
1274 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1275 * Memory leak hunt with the following command:
1276 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1277 --show-reachable=yes gdcmTests PrintDocument
1278 It looks like many (all?) leaks are due to the STL (or a bad usage
1279 of the STL. The lines producing the leaks now have a comment with
1280 a "MEMORY LEAK" tag: you can retrieve them with
1281 grep "MEMORY LEAK" src/*
1282 Here are two typical examples which I can't help fixing:
1287 char * test = "babo";
1288 name = test; //// <--- valgrind detects 960 bytes lost in
1289 //// call to std::string::operator=(char const*)
1290 name.clear(); //// Doesn't help !
1298 std::cout << "Type a bunch of characters followed by RETURN: ";
1299 getline(std::cin, line); //// <--- valgrind dectects a loss
1300 //// of 1320 bytes in call to
1301 /// std::basic_istream<>& std::getline<>
1307 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1308 * src/gdcmHeader.[cxx|h]:
1309 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1310 and related, moved away to gdcmDocument.
1311 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1312 the corresponding protected accessors of inherited class
1313 gdcmDocument, removed ! As a consequence gdcmFile had to be
1314 declared friend of class gdcmDocument (see below).
1315 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1316 - Clean up of undefined or unused methods.
1317 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1318 account the changes to gdcmHeader.h).
1319 * src/gdcmDocument.h:
1320 - gdcmFile is now a friend class (in order to take into account the
1321 changes to gdcmHeader.h).
1322 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1323 (see changes to gdcmHeader.h).
1324 - Accessors (reading on the form GetEntry*) are now public.
1325 - Clean up of undefined or unused methods.
1326 * src/gdcmDocument.cxx:
1327 - adaptation to changes to gdcmDocument.h
1328 - ::OpenFile now writes a verbose message when file cannot be opened.
1329 - some std::string properly set to VRKey
1330 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1331 references to gdcmDocument.
1332 * Test/TestFindTags.cxx: changed accordingly to above changes.
1333 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1334 cvs repository gdcmData.
1336 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1338 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1339 conflicts with gdcmValEntry::voidArea.
1340 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1341 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1342 Value representation between StringRepresentable and BinaryRepresentable.
1343 * src/gdcmDocument.cxx:
1344 - method ParseDES: proper indentation restored and usage of
1345 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1346 - method LoadDocEntry: the fingerprint left in the SetValue() of
1347 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1348 removed. Reverting to previous code segment with the proper
1349 dynamic_cast< gdcmValEntry* >.
1350 Note: this was (partially) breaking the python test suite
1351 (gdcmPython/testSuite.py) that made usage of the above
1352 fingerprint to check presence of "Pixel Data".
1353 * src/gdcmDocEntry.h: coding style.
1354 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1355 now taken into account.
1356 * gdcmPython/gdcm.i: adaptation to the new internal representation
1357 of gdcm (exit gdcmParser, hello gdcmDocument).
1358 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1360 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1361 anymore, but instead prints the loaded Python dictionary.
1362 * .... alas, the python testSuite is still broken.
1364 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1365 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1367 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1368 * src/gdcmUtil.h : export methods
1370 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1371 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1373 * Initial addition of automatic python testing
1374 * Initial addition of automatic image comparison
1376 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1377 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1378 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1380 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1381 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1382 * Test/ShowDicom.cxx : bug fix for msvc compilation
1383 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1385 2004-05-04 Jean-Pierre Roux
1386 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1387 new concepts (and new classes) :
1388 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1389 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1390 - Sequence Doc Entries (gdcmSeqEntries)
1391 a Sequence is composed of Items.
1392 Each item is a set of Doc Entries (this is recursive)
1393 The non uniqueness of the 'Dicom tag' is due to this recursivity
1394 (never taken into account)
1395 Our unability to add a new 'entry' in the header
1396 at the proper location (neither in the H-Table (map or multimap),
1397 nor in the Chained List is also due to this recursivity.
1398 Don't try, right now, to use/modify/compile these new sources :
1399 nothing is finished.
1400 We just commit all the stuff, 'as is', in order not to loose it.
1402 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1403 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1405 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1406 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1407 file prefix (SetFilePrefix)
1409 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1410 * Add a new test: ShowDicom, for now this is just the c++ version of
1411 checkRead.sh, later it will be able to compare the image read against a
1413 * Replace the DEBUG on the stack with a global entry in cmake interface:
1414 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1416 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1417 * Add an example subdir, with a real example on how to read + write a
1420 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1421 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1422 * Doc/CMakeLists.txt: the main page is now properly differentiated
1423 between the developper and user version.
1424 * Doc/doxygen.config.in: dropped search related obsolete flags
1425 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1427 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1428 * DEVELOPPER: added some helpfull comments for compile/test/install
1431 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1432 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1433 src directory, now generated in the build dir.
1434 2. Tests as mentionned smarter
1436 4. Add a new method in gdcmDict that return the PubDict by name
1437 this is interesting for 3rd party lib like ITK,
1438 where we could set the institution name / patient name...
1440 * ENH: 1. Now the test suite is working for real
1441 2. All binaries are now output in the gdcm-bin directory
1442 (this was not true before)
1444 2004-04-28 Jean-Pierre Roux
1445 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1446 SeQuence indented printing of Dicom Header.
1447 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1448 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1449 Computation of SQDepthLevel is now part of gdcmHeader constructor
1450 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1451 tree-like structure of a Dicom Header.
1452 * FIX Test code cleaning
1454 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1455 * ENH: Adding automatic testing
1456 1. Need a DartConfig.cmake to submit to public
1457 2. Add a test driver gdcmTest.cxx
1458 3. gdcmTestMain, an helper for the main test driver gdcmTest
1459 4. Files in Test don't have a main anymore, this becomes interesting
1460 when we add more and more tests, thus dsw don't have to load
1462 * ENH: Adding a GDCM_DATA_ROOT for testing
1463 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1464 one file instead of seven + some small cleanup
1466 2004-04-22 Jean-Pierre Roux
1467 * ENH Minor changes to the Print() methods.
1468 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1469 Header printing. Example given with :
1470 > PrintHeader fileName 2 new
1471 (SQ based tree-like structure still to be done for the Header ...)
1473 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1474 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1475 1. I have added some unsigned where needed
1476 2. Some function parameter not used -> (void)
1477 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1478 4. g++ don't like character '\' in comment
1479 5. #define jpeg_create_decompress jCreaDecompress
1480 this really need to be fixed
1481 6. virtualize destructor of gdcmObject ... leakage
1482 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1483 this also really need to be fixed
1484 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1485 remove compression file
1486 (as we only do decompression, right ?)
1487 * ENH: Change malloc/calloc/free with c++ equivalent
1489 2004-04-21 Jean-Pierre Roux
1490 * FIX gdcmHeaderHelper::GetXSpacing
1491 when a single value is found (bug ?), xpacing is now
1492 defaulted to yspacing
1494 2004-04-19 Jean-Pierre Roux
1495 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1496 * ENH add parameters :
1497 bool exception_on_error = false,
1498 bool enable_sequences = false,
1499 bool ignore_shadow = false
1500 to the gdcmFile constructors to be full gdcmParser compliant
1501 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1502 to allow reading of PAPYRUS 3.0 files
1504 2004-04-06 Jean-Pierre Roux
1505 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1507 2004-04-02 Jean-Pierre Roux
1508 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1509 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1510 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1512 2004-03-30 Jean-Pierre Roux
1513 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1514 for ACR file, written out as DICOM files (hope so...)
1516 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1517 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1518 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1519 moved to base class gdcmParser and only the specialisation is kept
1521 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1522 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1523 already does the job.
1524 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1525 (to be consistent with gdcmParser::WriteEntries).
1527 2004-03-30 Benoit Regrain
1528 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1529 upate of the object's instance. It's passed to 2 in the unfavorable
1530 case : one in the ExecuteInformation, one in the ExecuteData
1532 2004-03-29 Jean-Pierre Roux
1533 * ENH : Check on file type to be written moved
1534 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1535 * FIX : gdcmObject::ResetBoundaries now stops properly
1536 when end-of-list is reached
1537 : gdcmVersion modified (as Benoit Regrain asked)
1539 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1540 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1541 * src/gdcmUtil.cxx: added forgotten iostream include.
1542 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1543 equivalent to ExplicitVR in existing code).
1545 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1546 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1547 now contains all the gdcmGlobal related code.
1548 * minor coding style and doxygenation changes.
1550 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1551 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1552 now contains all the Debug related code.
1553 * minor clean-up of includes in src/*.cxx
1554 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1555 CreateCleanString) removed.
1556 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1557 * Doc/DoxyMainPageUser.txt added.
1558 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1559 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1560 src/gdcmDirList.cxx)
1562 2004-03-24 Jean-Pierre Roux
1563 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1565 2004-03-23 Jean-Pierre Roux
1566 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1567 big endian made volumes
1568 * ENH Now gdcmParser constructor and destructor are protected to forbid
1569 end user to instanciate class gdcmParser
1570 (only gdcmHeader and gdcmDicomDir are meaningfull)
1572 2004-03-22 Benoit Regrain
1573 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1574 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1575 gdcmSerie to gdcmDicomDirSerie
1577 2004-03-19 Jean-Pierre Roux
1578 * ENH Now the tree-like structure describing a DICOMDIR comming from
1579 an already existing DICOMDIR file is consistent with
1580 the home-made tree-like structure build ex-nihilo
1581 or build from the files held (recursively) in a Directory
1582 functions gdcmDicomDir::CheckBoundaries()
1583 gdcmObject::SetBoundaries() added
1585 2004-03-17 Jean-Pierre Roux
1586 * REM (Eric Boix bug) : removal of meaningless
1587 gdcmDicomDirImage::NewImage function.
1588 * FIX now file names and directory name are written properly in the
1590 * FIX now gdcmDicomDir constructor may be call without any trick
1593 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1594 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1595 of gdcmDicomDirImage::NewImage as empty function.
1597 2004-02-28 Jean-Pierre Roux
1598 * ENH add gdcmDicomDir:NewPatient
1599 add gdcmDicomDirPatient:NewStudy
1600 add gdcmDicomDirStudy:NewSerie
1601 add gdcmDicomDirSerie:NewImage
1602 to allow making gdcDicomDir object.
1603 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1604 (as opposite to the gdcmHeader chained list)
1606 2004-02-11 Benoit Regrain
1607 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1608 when using from python
1610 2004-02-10 Benoit Regrain
1611 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1612 * FIX : in gdcmDicomDir when the directory is empty
1613 * ENH : add callback and methods to get the progression of dicomDir
1616 2004-02-06 Jean-Pierre Roux
1617 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1618 - GDCM_META added to gdcmDicomDirType
1619 - class gdcmMeta created
1620 * ENH : - A brief summary is now displayed at the beginning of
1621 'testDicomDir' to help disaster magnitude estimation
1622 * REM : Now useless Test/explDICOMDIR.cxx
1624 2004-02-05 Benoit Regrain
1625 * ENH : add methods in gdcmObject to get the hash table or the list of
1627 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1628 * FIX : wrapping python for TagHeaderEntryHT
1630 2004-02-04 Benoit Regrain
1631 * FIX : even length for some strings when writting the dicom dir
1632 * FIX : sort the images in the dicom dir
1633 * FIX : Bug fix for python use of dicom dir
1634 * ADD : a python demo
1636 2004-02-04 Jean-Pierre Roux
1637 * FIX : Final solution (?) for icone embedded images
1638 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1639 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1640 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1641 gdcmData/gdcm-MR-SIEMENS-16.acr1
1642 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1643 to make full checking easier
1645 2004-02-04 Benoit Regrain
1646 * FIX : WriteEntries : coding style & logic in parameters
1647 * FIX : Set the elements to create the DicomDir in a dictionary file
1649 2004-02-03 Benoit Regrain
1650 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1651 * gdcmDicomDir : add the load of directory
1652 * Bug fix and print add-on
1654 2004-02-03 Jean-Pierre Roux
1655 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1656 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1657 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1658 * FIX gdcmParser.cxx : 'group length' elements are now considered
1659 as integers, even for shadow groups, when file is Implicit VR
1661 2004-02-02 Jean-Pierre Roux
1662 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1664 of the last synonym :-(
1665 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1667 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1668 * FIX taking into account the possible 7fe0,0010 multiplicity
1669 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1670 to allow removal of references to 7fe0,0010, to deal with
1671 ACR-NEMA images, when 0028,0200 is meaningfull
1673 2004-01-31 Jean-Pierre Roux
1674 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1675 no longer writes 'Un' on disk
1676 * FIX SQ elements with actual length are now dealt with corectly
1677 * FIX gdcmFile::WriteBase make the difference, for color images, between
1678 the length (for Palette expanded images)
1679 and Raw Length (non expanded image + Palette)
1680 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1681 (that broke Write). Replaced by UL.
1682 Aware user will reload the field if he
1683 thinks it's necesssary
1685 2004-01-30 Jean-Pierre Roux
1686 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1687 when 'dirty Acr' is found, to be compliant with the new
1688 IsReadable() methods.
1690 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1691 (no DOUBLE images in kosher DICOM,
1692 but so usefull for people that miss them ;-)
1694 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1695 DICOMDIR related utilities (not checked as Windoze compliant)
1697 2004-01-28 Jean-Pierre Roux
1698 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1700 2004-01-27 Jean-Pierre Roux
1701 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1702 to allow skipping the shadow elements, to save memory space.
1703 The TRUE value for this param has to be used
1704 with a FALSE value for the 'enable_sequence' param.
1705 ('public elements' may be embedded in 'shadow Sequences')
1706 * gdcmHeader methods now deal with 'embedded icones images' in the header
1707 (even when an 'icone image sequence' is announced by the
1708 element (0x0088,0x0200), but there is NO icone at all ...
1710 * gdcmHeader sometimes Image Location value doesn't follow
1711 the supposed processor endianity (see gdcmData/cr172241.dcm).
1714 * gdcmHeader add the method
1715 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1716 to get *all* the Header Entries with the same tag.
1717 GetHeaderEntrySameName is probabely *useless*
1718 (no meaning : Name is *not* an identifier within the Dictionnary)
1720 2004-01-26 Benoit Regrain
1721 * Bug fix in the print of hexadecimal representations. Remove long fields
1722 in the print and add a third level of print to print them
1724 2004-01-23 Benoit Regrain
1725 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1726 * Bug fix on test suite after remove the strip made on not string fields
1727 * Split the IsReadable method between gdcmParser which test that the file
1728 is dicom and gdcmHeader which test that it's an image file
1730 2004-01-22 Benoit Regrain
1731 * DicomDir : clean code, add methods, set variables in protected or private
1732 * gdcmUtil : bug fix for the clean string method
1734 2004-01-19 Benoit Regrain
1735 * Add the use of shadow dictionaries
1736 * bug fix and coding style
1738 2004-01-19 Benoit Regrain
1739 * src/gdcmFile.cxx : bug fix concerning the close of file
1740 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1741 * Add the update of header entries using the shadow library
1743 2004-01-19 Benoit Regrain
1744 * removal of file gdcmHeader2.cxx
1745 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1746 inheriting from gdcmParser. This split is to prepare the integration
1747 of dicom dir parsing
1748 * bug fix under python
1750 2004-01-16 Jean-Pierre Roux
1751 * REM removal of class gdcmHeaderEntrySet
1752 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1753 * ADD add file gdcmHeader2.cxx
1754 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1756 2004-01-15 Benoit Regrain
1757 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1758 entries created while parsing the header. Thus, they will be destroyed
1759 when the gdcmDictSet will be destroyed
1760 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1763 2004-01-15 Benoit Regrain
1764 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1765 made a fatal error because of the memory release at the end of program.
1766 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1767 some memory and vtk seems to have some problems with that.
1768 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1770 2004-01-14 Benoit Regrain
1771 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1772 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1773 * src/*.[h|cxx] : make changes due to class name changes
1774 * gdcmPython/demo/*.py : bug fix due to method names
1776 2004-01-13 Benoit Regrain
1777 * src/*.[h|cxx] : coding style
1778 * vtk/*.[h|cxx] : coding style
1780 2004-01-13 Benoit Regrain
1781 * gdcmPython/testSuite.py : test the readable flag of file for tests
1782 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1783 It's lied to the stl compilation by MSVC (windows, always windows...)
1784 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1786 2004-01-12 Benoit Regrain
1787 * src/*.h : add comments
1788 * src/gdcmDictSet.h : set the method BuildDictPath in public
1789 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1790 directly setted in the source code
1791 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1794 2004-01-09 Benoit Regrain
1795 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1796 * setup.py : use a reference to gdcmVERSION
1798 2004-01-07 Benoit Regrain
1799 * Modification to compile with the distutils.
1802 2003-12-10 Benoit Regrain
1803 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1804 can use a gdcmHeaderHelper to load datas
1805 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1806 made in the source code
1808 2003-12-10 Benoit Regrain
1809 * Update Windows projects and .cvsignore files
1811 2003-11-12 Jean-Pierre Roux
1812 * ENH gdcmHeader constructor has one more parameter (default value : false)
1813 that allows the user to 'go inside' the SeQuences only
1815 gdcmElValSet:Print takes it into account
1817 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1818 * ENH: Update gdcmPython/CMakeLists
1819 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1820 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1822 2003-11-10 Jean-Pierre Roux
1823 * FIX : gdcmHeader::LoadElements is now based
1824 on the ListTag listElem member,
1825 not longer on the TagElValueHT tagHt member
1826 * ENH : PrintPubElVal shows (temporarily) both results,
1827 with the tagHt member and the listElem member.
1828 (it's easier to 'see' the problems when using Printheader)
1830 * FIX : old private member LgrElem is now splitted into
1831 ReadLength : Length actually found on disk (updated only
1832 if bug fixing is necessary), for internal
1834 UsableLength : Updated by FixFoundLength, to fix a bug
1835 or to allow Parser going on.
1836 Will allow to re-write a kosher header when a SeQuence
1837 with a length (not 0000) is found
1838 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1839 because gdcmElValSet::Add does not update ListElem
1842 2003-11-07 Jean-Pierre Roux
1843 * FIX misstyping in Transfert Syntax name table
1844 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1845 when they have an actual length (not 0000 nor FFFFF)
1846 (Nobody should care of it, but DICOMDIR explorers)
1848 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1849 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1851 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * ENH: vtkGdcmReader now supports LUT !
1853 (vtkgdcmViewer for now is not able to use them though)
1855 2003-11-05 Jean-Pierre Roux
1856 * in testSuite.py : new files names for checking the package
1857 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1858 that returns the pixel area size to the *aware* (vtk) user
1859 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1861 2003-11-05 Benoit Regrain
1862 * in testSuite.py : Modify the rules for checking the paths
1863 : Explicit error messages
1864 * in __init__.py : Related modif
1866 2003-11-03 Jean-Pierre Roux
1867 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1868 to be used by aware (vtk) users that want to manage
1869 LUT (and no to turn the PALETTE image into an RGB pixels one)
1870 * GetPixelType now returns 8U for 24 Bits images
1871 (vtkGdcmReader compliant)
1873 2003-10-31 Jean-Pierre Roux
1874 * Removal of *all* gdcmData images and add them again
1875 in order to loose the 'history' of un-anonymised images
1877 2003-10-31 Jean-Pierre Roux
1878 * RMV : removal of useless jBitsInJsample.h
1879 for both 8 and 12 Bits JPEG Lossy Libraries
1881 2003-10-31 Jean-Pierre Roux
1882 * ENH : Add the functions gdcmFile::GetImageDataRaw
1883 gdcmFile::GetImageDataIntoVectorRaw
1884 that act as GetImageData and GetImageDataIntoVector
1885 except the making of an RGB Plane from Gray Plane + LUT
1886 Intended to aware (vtk) users who know how to manage
1889 GetLUTRGBA return a R,G,B,A LUT if any
1890 lgrTotaleRaw gives the 'Raw' length
1891 GetImageDataRaw returns the gray Plane
1892 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1893 (They stay Grey, just like with other Dicom viewers :-(
1895 2003-10-30 Jean-Pierre Roux
1896 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1898 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1899 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1900 being coherents dicom files.
1902 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1903 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1905 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1906 * ENH: Two steps is necessary to please VC++ compiler...
1907 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1908 * ENH: Add include dir to medcon lib
1909 * FIX: only one function is being exported for now !
1910 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1912 2003-10-29 Jean-Pierre Roux
1913 * adding gdcmHeader::GetLUTRGBA
1914 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1915 --> Mathieu, the modif u're waiting for is not yet committed
1916 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1918 2003-10-27 Jean-Pierre Roux
1919 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1920 00191113.dcm DermaColorLossLess.dcm
1921 MxTwinLossLess.dcm RadBWLossLess.dcm
1922 * ENH: For version prior to vtkImageViewer2 -r 1.19
1923 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1925 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1926 * Removal of ido stuff in CMakeLists.txt
1928 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1930 * FIX: remove a call to ->Modified ... see comments
1931 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1933 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * FIX: Problem with path for libvtkgdcmPython
1935 * ENH: Try adding a search script for python site-package
1936 * RMV: Remove some file from medcon lib that are not necessary
1937 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1938 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1939 * FIX: More pragma disable fro VC++,
1940 I don't think I break something as it is also disable in VTK/ITK.
1941 But it fasten debug compilation time.
1943 2003-10-23 Jean-Pierre Roux
1944 * gdcm now deals with 16 Bits Run Length Encoded images
1945 (they are compressed as 2 planes images,
1946 one for the high Bytes, the other for low Bytes)
1948 2003-10-22 Jean-Pierre Roux
1949 * Now CheckRead takes into account :
1950 - the bugged 'Leonardo' Siemens images
1951 - the XA images, sent thru the burning VPRO station
1952 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1955 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * FIX: When copying a Makefile.am to CMakeLists.txt
1957 one should remove the '\'
1959 2003-10-22 Jean-Pierre Roux
1960 * in gdcmData adding a bugged 'Leonardo' Siemens image
1961 (wrong lengths in header)
1962 OK with gdcm, KO with the other viewers :-)
1963 * add a GE dlx XA image, thru the VEPRO burning station
1966 2003-10-21 Jean-Pierre Roux
1967 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1968 for a brutal checking of vtkgdcmViewer compliance
1970 2003-10-21 Jean-Pierre Roux
1971 * add the files for 'xmedcon' Jpeg Lossless library
1972 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1974 2003-10-21 Jean-Pierre Roux
1975 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1977 2003-10-21 Jean-Pierre Roux
1978 * garbage Siemens 'Leonardo' images dealt with
1979 (the patch is easy to remove)
1980 * cosmetic changes to avoid warnings
1982 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1983 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1984 no need to press 'r' now.
1986 2003-10-20 Jean-Pierre Roux
1987 * upgrade of checkRead.sh checkWrite.sh according
1988 to new Jpeg Lossless decompressor
1989 * add US.3405.1.dcm, a genuine RGB medical file ...
1990 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1991 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1993 2003-10-15 Jean-Pierre Roux
1994 * general anonymisation in gdcmData
1995 * adding the 'color files' from
1996 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1997 * adding some well knowed bugged-header images
1998 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1999 waiting for their inclusion in Python testsuite
2001 2003-10-15 Jean-Pierre Roux
2002 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2003 no longer seg faults when file is not found
2005 2003-10-14 Jean-Pierre Roux
2006 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2009 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2010 * TODO: *.in file to genereate a UseGDCM later
2012 2003-10-14 Jean-Pierre Roux
2013 * Some supposed-to-be Dicom Images have no preamble.
2014 OpenFile takes it into account
2015 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2016 * Missing elements added in dicomV3.dic
2017 (just to be affraid : have a look at
2018 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2019 and do it again next year ;->
2021 2003-10-13 Jean-Pierre Roux
2022 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2023 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2024 But there are NOT. It's fixed !
2026 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * FIX: "jpeglib.h" was not found on VC++
2028 * FIX: vtkgdcm was not being installed
2030 2003-10-10 Jean-Pierre Roux
2031 * ENH : OpenFile closes the file if it *really* doesn't look like
2032 an ACR-NEMA / DICOM one.
2033 * FIX : testWrite no longer writes an empty file if the source file
2034 is not gdcm Readable
2035 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2038 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2039 * FIX: CMake generate now documentation
2040 * ENH: out of source doc build !
2041 * ENH: Generate both user and dev documentation
2042 * ENH: Should work on windows too
2043 * ENH: Only one doxygen config.in file is needed
2044 * FIX: make install should be ok now on ùnix plateform
2045 * FIX: PATH to dictionary was wrong (missing /)
2046 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2048 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2049 * vtkGdcmReader is now able to read rgb dicom file.
2050 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2051 * added a gdcmViewer to vtk test, use mouse to control
2052 window level & window width
2054 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * CMake-ification of gdcm, we have now two build system
2056 * FIX: on cygwin Wsock32 doesn't exist
2057 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2059 2003-10-06 Emanuel Ollart
2060 * FIX : compilation process wad broken.
2061 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2063 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2064 * change gdcmViewer -> vtkgdcmViewer
2065 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2067 2003-10-06 Jean-Pierre Roux
2068 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2069 ( e.g : well known GE images with a wrong elem length,
2070 : Philips MRI Images with a wrong Huffman table)
2071 * still to be done : allow the reading of bugged LEONARDO Siemens images
2073 2003-10-03 Jean-Pierre Roux
2074 * Odd length strings are padded with '\0' (not with spaces,
2075 to remain compliant with already defined strings,
2076 like Transfert Syntax UID and others)
2078 2003-10-03 Jean-Pierre Roux
2079 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2080 to allow displaying RGB images (not only by affim ;-)
2082 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * vtkGdcmReader is now able to read rgb dicom file.
2084 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2086 2003-10-03 Jean-Pierre Roux
2087 * A few nasty patches to allow the reading of a lot of nasty images
2088 ( e.g : well known GE images with a wrong elem length,
2089 : Philips MRI Images with a wrong Huffman table)
2090 * still to be done : allow the reading of bugged LEONARDO Siemens images
2092 2003-10-03 Jean-Pierre Roux
2093 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2095 2003-10-03 Jean-Pierre Roux
2096 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2097 to allow displaying RGB images (not only by affim ;-)
2099 2003-10-03 Jean-Pierre Roux
2100 * gdcmFile::GetImageDataIntoVector now
2101 - deals with MultiFrames MultiFragments Run Length Encoded files
2102 - deals with YcBcR (YBR_FULL) files
2103 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2104 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2106 (no sample found :-(
2108 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2110 Two reasons: - clear things
2111 - third parties acces gdcm through header files, so won't
2112 suffer anymore VC++ complains
2114 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2115 * add argv[1] in testvtkGdcmReader.cxx
2118 2003-09-24 Jean-Pierre Roux
2119 * The lines are now eigthy characters long.for
2120 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2122 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2123 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2124 char* to std::string. Thus, the use of strdup becomes useless. (see
2125 previous commis of Malaterre)
2126 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2127 before the last Malaterre's commit.
2129 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2130 * This commit should fix the Debug building under VC++, the problem
2131 was mainly a mixture of debug and release lib being loaded at startup.
2132 * I also remove a depency to a specific C function: strdup. Because I had
2133 to force the link to msvcrtd (whereas strdup is in libc).
2135 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2136 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2137 located in the gdcmCommon.h file. All use of reference of tha has been
2138 changed to now use the variable GDCM_UNFOUND.
2140 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2142 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2143 Dicom dictionary. The test suite can now be run again. Note:
2144 I'm note very happy with the " (RET)" changes. I believe this
2145 RETAINED comment should be dropped when parsing the dictionary.
2146 - PACKAGER corrected
2148 - AUTHORS updated and now in alphabetical order
2149 * Makefile.am now exports gdcm.dsw for Windoze users.
2151 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * cygwin complains about missing std:: in subdir Test/
2154 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2155 * remove some methods that are now in gdcmHeaderHelper
2157 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * vtkGdcmReader set spacing and origin correctly
2160 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2161 * Fix a few delete/delete[] mismatch
2163 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2164 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2165 interpretation to data given by gdcmHeader. For instance there are
2166 heuristics to get informations (look at different places).
2167 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2168 sorting DICOM images based on different strategies.
2169 * modified Makefiles accordingly.
2171 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2172 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2173 when building in debug mode
2174 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2175 src/win32/gdcmdll.dsp
2176 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2178 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2179 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2182 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2183 * src/win32/libgdcmjpeg12.dsp was not dos format
2184 * src/win32/libgdcmjpeg12.dsp :
2185 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2186 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2188 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2189 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2191 * src/gdcmFile.cxx : bug fix in affectation type
2192 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2193 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2194 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2195 symbols... future problem ?
2197 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2198 * src/win32/libgdcmijpeg12.dsp was missing
2199 * modified gdcm.dsw accordingly
2201 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2202 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2204 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2205 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2206 commit of JPR (before his hollidays to facilitate our work).
2207 * setup.py : bug fix in code. Modifications made while the last commit
2208 of JPR. The code hasn't been tested before the commit... it's so
2209 useless to make that (for best programmer that is JPR) !!!
2211 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * tagged the current version as Version0_3 (i.e. version 0.3)
2214 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2215 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2216 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2217 * *.dsp : modifications to use new libgdcmijpeg8 library
2218 * setup.py : bug fix on VTKPATH variable
2219 * PACKAGER : adding all concerning windows
2221 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2224 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2225 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2226 test suite reported error.
2227 * PACKAGER file added (describes what a packager must do when
2228 packaging a new release).
2229 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2230 * configure.in: upgraded version number to 0.3.0
2231 * fixing build of rpm (through rpm -ta):
2232 - Doc/Makefile.am exports proper doxygen files
2233 - src/jpeg/libijg8/Makefile.am exports the include files.
2235 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2236 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2237 * src/gdcmHeader.h : formatting code
2239 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2240 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2241 We were obtaining error message from vtk. Now, creation of file list
2242 is made in an internal list to prevent this problem.
2243 Bug fix when output is empty.
2244 Bug fix in update of progress value. Previous commit for this was a bad
2246 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2248 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2249 * src/gdcmHeader.h : added method to get the file name
2250 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2251 files. Added method to remove all files on the input
2252 Added FIXME comment concerning the bad parsing of header made by
2253 ExecuteInformation method (in ExecuteData method)
2255 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2256 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2257 when using make instal.
2258 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2259 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2261 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2262 * setup.py : adding include dir of jpeg lib to compile all sources
2263 * */Win32/*.dsp : JPR fix for windows compilation
2265 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2266 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2268 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2269 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2271 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2272 * setup.py is again effective on un*x (takes into account the
2273 addon of the jpeg library)
2274 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2275 * Doc/Doxy* updated (includes above enhancements)
2276 * INSTALL now points to web documentation
2278 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2279 * src/gdcmHeader.h doesn't make unnecessary reference to
2281 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2283 * src/gdcm*.[cxx|h] :
2284 - to allow compilation with gcc 3.x
2285 -- clean up of STL usage (added explicit usage of std::)
2286 -- small fixes on exceptions.
2287 Note: linking not tested !
2288 - clean of doxygen comments to avoid warnings at documentation
2290 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2291 dependent convertion).
2293 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2294 * Clean up of previous JPR garbage commit (not even commented in the
2296 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2297 - moved all jpeg related files from src to src/jpeg/libijg8, with
2298 addition/modification of Makefile.am and configure.in.
2299 - the testSuite is still brain damage (not guilty).
2301 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2302 * WrapVTK.py : modifications to get correctly vtk source files to
2304 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2305 (FileName -> Filename)
2307 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2308 * vtk/vtkGdcmReader.[cxx/h]:
2309 - UpdateProgress method should now be effective
2310 - removed the limitation on having only images loaded (as opposed
2312 - when building a stack of images/volume, a lesser number of
2313 gdcmHeader and gdcmFile instances should be used (hopefully
2314 accelerating things).
2315 - when building a stack of images/volumes, files which are not
2316 loadable (wrong path-filename, wrong permissions on existing file,
2317 or file not parsable by gdcm) are replaced with a black image
2318 in the stack (for the caller to notice the problem).
2320 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2321 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2323 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2324 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2325 between standard library (std) and vtk library (problems are found
2326 under Windows... thanks Windows !)
2328 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2331 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2333 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2334 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2336 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2337 * When compiling with distutils (see setup.py) the C++ compiler is
2338 called with different flags than the default ones (with automake).
2339 In order to fix all those warning, I compiled gdcm with the command
2340 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2341 and went for warning fixes:
2342 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2343 up from unused variables.
2344 - vtk/vtkGdcmReader.cxx: potential bug fix.
2345 * src/gdcmHeader.h: Doxygen warning cleanup
2347 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2348 * gdcmPython/gdcm.i:
2349 - typemaps correction to take into account the systematic replacement
2350 of "using namespace std" with std:: prefix e.g. std::list,
2351 std::string... (cf changes of 2003-05-21).
2352 - gdcmGlob global variable of type gdcmGlobal (defined in
2353 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2354 exported to Python a as cvar.
2355 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2356 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2357 gdcmDictSet.GetPubDictTagNames() and
2358 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2359 C++ static methods).
2360 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2361 with the above changes.
2363 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2364 * setup.py, manifest.in : bug fix under linux
2366 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2367 * Modification of setup.py to compile vtk part too. Then, we have 2
2368 wrappers which must work with same distutils. For that, we have a
2369 generic distutils in distusiltsWrapping.py ; with :
2370 - build_extWrap class to wrap generically all extensions,
2371 - ExtensionWrap base class for all wrapping extension that contains
2373 - Wrapper interface which wrap sources
2374 + In WrapSwig.py we have extension and wrapper for Swig
2375 + In WrapVTK.py we have extension and wrapper for VTK
2376 * MANIFEST.in : modifications to consider vtk directory and new python
2377 files for compilation
2379 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2380 * Added python wrappers of vtkGdcmReader vtk class (see the
2381 source in vtk/vtkGdcmReader.cxx) :
2382 - vtk/Makefile.am now builds a library
2383 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2384 python library (as opposed to _gdcm.so wich are the python
2385 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2386 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2388 - configure.in has an additional flag --enable-vtk that needs
2389 to be set to enable compilation of vtk related code, that is:
2390 + vtk/vtkGdcmReader.so and
2391 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2392 + gdcmPython/vtkgdcmPython.so (see above)
2393 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2394 be read when compressed or when HighBit + 1 != BitsStored),
2395 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2396 the usage of the python wrapper of vtkGdcmReader vtk class.
2397 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2398 * src/*.[h] all occurences of stl classes are now prefixed with
2399 std::, and all occurences of "using namespace std;" where removed.
2400 This is to avoid pollution of global namespace in included files.
2401 Apparently vtk does not avoid this pitfall: when using both
2402 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2403 collision of various stl members (principally cout...).
2404 * gdcmPython/testSuite.py now cleanly removes temprory generated
2406 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2407 comply with above changes)
2409 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2410 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2411 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2412 vtk data structure (an image Flip was required).
2413 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2414 * cosmetic changes in documentation.
2416 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2417 * src/gdcmHeader.cxx: the constructor no longer exits when an
2418 unexisting file is given as argument.
2419 * The subdirectory Data (containing all the images used for the
2420 test suite) is not part of this repository anymore. A new module
2421 containing those images is now available at
2422 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2423 with the name gdcmData.
2424 All the python scripts (including the package initialisation file
2425 gdcmPython/__init__.py) were adapated to take this change into
2426 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2428 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2429 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2430 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2431 demo of the usage of this class.
2432 Compilation of this vtk part is only done when using the --enable-vtk
2433 at configure (or autogen.sh) stage.
2435 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2436 * More memory link related corrections and documentation fixes.
2438 - maximum info is obtained with a command of the form:
2439 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2440 --show-reachable=yes PrintHeader
2441 - the remaining reachable blocks seem to come from the STL
2442 allocation scheme through the usage of map and list. It looks
2443 like this memory cannot be freed but it is not a memory leak
2444 (in fact further invocation to the STL would recollect the
2445 unused memory allthough it cannot explicitely be freed).
2446 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2447 of displaying an image parsed with gdcm and displayed with VTK.
2448 Note: some images don't seem to work e.g.
2449 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2450 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2451 Allthough this weakens the semantics, it is a ditch attempt to
2452 make gdcm more thread friendly.
2454 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2455 * Memory link hunt (by using valgrind through the command
2456 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2457 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2458 gdcmHeader::_dicom_vr.
2459 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2460 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2462 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2464 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2465 * src/Makefile.am now exports all the necessary include files at
2469 * UpdateGroupLength replaced by new one
2472 * UpdateGroupLength re-written using H-Table
2473 (named UpdateGroupLengthNew untill checks are over)
2475 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2476 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2477 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2479 - gdcmHeader::GetPubElValSet removed.
2480 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2481 UpdateGroupLength, WriteElements, Write.
2482 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2483 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2484 carried the same semantics.
2485 - src/gdcmHeaderIdo.cxx changed accordingly.
2486 - gdcmFile::WriteBase now regroups all the codes from previous
2487 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2488 - enum FileType moved to gdcmCommon.h
2489 * src/gdcmHeader.cxx AddDefault trashed
2490 * gdcmGetXSize added
2491 * getimageDataSize now calls gdcmGetXSize
2492 * Test/*.cxx changed to agree with above changes
2494 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2496 (to avoid double call by end user).
2497 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2498 by end user, since gdcmHeader::gdcmHeader now handles it.
2500 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * gdcm/Doc many doxygen changes:
2502 - Doxyfile now has two different versions, DoxyfileUsers that generates
2503 the html.users end users oriented documentation and
2504 DoxyfileDeveloppers that generates the html.developper developper
2505 oriented documentation.
2506 - README changed accordingly
2507 - requirement.txt removed (old design info moved to TODO).
2508 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2509 DoxyMainPage.txt, DoxyPython.txt provide more information.
2510 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2511 be updated by simply regenerating the docs with doxygen and copying
2512 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2513 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2514 all the tests in the form "if (<map>.count() >1)" were removed.
2515 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2516 ill-formed documentation sections.
2517 * src/gdcmHeader.cxx: ditto
2519 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2520 * setup.py fixed for un*x (needed macro for stdint.h)
2521 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2522 un*ces with sh-utils test utility.
2523 * gdcmPython/demo/test.py renamed to PrintHeader.py
2524 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2525 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2526 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2527 * src/gdcm*.cxx JPR's bad inclusion fixed.
2529 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2531 * gdcmPython/demo/test.py changed accordingly.
2533 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * gdcmPython/Makefile.am fixed linking against libstdc++
2535 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2536 * Swig subdir (historical tests of swig version 1.3.17++) removed
2537 * Test/testChangeEntete.cxx some lines commented out in order to make
2539 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2540 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2542 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2543 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2544 hence the user doesn't need this explicit call.
2545 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2546 i.e. LoadElements() call removed.
2547 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2548 - src/Makefile.am declares the proper flag for g++.
2549 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2550 for adding user defined new tags.
2551 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2552 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2553 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2555 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2556 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2557 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2558 src/Makefile.am : the project should properly compile and install
2559 with the autotools, included the python wrappers part.
2560 * gdcm.spec.in : added a spec file for RPM packaging.
2562 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2563 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2565 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2566 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2567 to exported to the environement (see gdcmPython/testSuite.py
2569 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2570 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2571 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2572 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2573 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2575 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2576 * gdcmPython/__init__.py doesn't crash anymore when running in
2577 in InstallMode or PreInstallMode but with an environement given
2578 value of GDCM_DICT_PATH.
2579 * src/gdcmDictSet.[cxx/h] coding style.
2581 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2582 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2583 * src/gdcm.h general comments moved to TODO, and README
2584 * src/gdcm.h should now be seen as a user commodity (including it
2585 should suffice to fully use gdcm). It is nowhere including within
2586 any of the kernel files src/*.cxx and src/*.h.
2588 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2589 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2590 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2592 * src/gdcm*.cxx only include their corresponding include file
2593 (as opposed to gdcm.h)
2594 * gdcmPython/gdcm.i changed accordingly
2595 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2596 the autogen.sh generated "make snapshot" command to work.
2597 * autogen.sh removed history related references to crea package.
2599 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * distutilsSwigCPlusPlus.py work around some swig portability
2603 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2605 was done in a last ditch attempt to get setup.py _really_
2606 operationnal. The python/gdcmPython layaout add the advantage
2607 of hidding away the python related distutils specific files
2608 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2609 Alas, the src directory was out of scope (i.e. it's relative
2610 position to setup.py was ../src) which made things impossible to
2611 handle (see previous version of python/setup.py). Crossing fingers...
2613 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2614 * python/setup.py now works on Un*x. (harder than I thougth)
2615 * python/distutilsSwigCPlusPlus.py can now have include files
2616 among the list of sources.
2618 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2619 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2620 * modifications in MSVC projects
2622 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2623 * As stated by the first lines of Test/ExceptionAndPython/README, it
2624 looks like we can move back to original usage of exception within
2625 src/gdcm* and hence remove the errno stuff that was introduced
2626 as a quick and dirty fixture of this problem (added to the TODO).
2627 * Doc/Doxyfile configuration file for Doxygen and corresponding
2628 README file for usage added.
2629 * Test/testWrite.cxx added. This new test comes from a split of
2630 test.cxx that is now reverted to its original purpous i.e.
2631 testing the proper parsing of a Dicom related file.
2632 testWrite.cxx concentrates on testing the IO part of gdcm.
2633 * Test/bug1.cxx (containing a bug on WIn32) added.
2634 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2635 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2636 whose purpose is to publish the content of the TagNames of the
2637 Dicom public dictionnary were not accessible without an
2638 instance of class gdcmHeader.
2639 - those methods are now static methods of gdcmDictSet and hence
2640 require no instances at all to be invocated.
2641 - within gdcmDictSet this change required to change some method
2642 to class methods (i.e. are now static) among which SetDictPath
2643 (renamed to BuildDictPath) and LoadDefaultPubDict.
2644 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2645 the above changes by calling the new method classes of gdcmDictSet.
2646 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2647 the above to be effective.
2648 * python/gdcmPython: in order to wrap properly the above changes
2649 for Python, swig version now needs to be > 1.3.17.
2650 * python/gdcmPython/Makefile fixed to adapt itself to new
2651 configure/make shema introduced by Johan Montagnat (thanks for the
2652 contribution). Alas this Makefile cannot be turned into a proper
2653 Makefile.am without some heavy changes in the configure.in
2654 (for python dectection).
2655 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2656 now avoids publishing the empty entries.
2658 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2659 * python/setup.py : bug fix concerning install under windows
2660 ExtraPath reused :-P
2661 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2663 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2664 * Dicts/dicomV3.dic : remove double spaces !!!
2665 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2666 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2669 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2670 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2671 method. Doxygenation.
2672 * src/gdcm.h clean up of JPR spurious comments.
2674 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2675 * python/distutilsSwigCPlusPlus.py now properly collects the
2676 shadow classes generated by "swig -c++" (gdcm.py in our case)
2677 when using "python setup.py install".
2678 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2679 reexports the working classes.
2680 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2681 by the classical C errno scheme. This is to prevent an obscure
2682 behavior of the python wrappers when importing wxPython.wx prior
2683 to gdcmPython (which ended up in an abort call). An illustration
2684 of this oddity can be found in the Test/ExceptionAndPython
2685 subdir (see the README file). This problem probably due to
2686 an combination of g++ and dynamic loading.
2687 * added Test/ExceptionAndPython (see above)
2689 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2690 * Changed the layout of the python part to avoid bloating main
2691 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2692 i.e. the distutils arsenal. All the python related stuff is
2693 again in a python subdir, but the package itself is now in
2695 * setup.py was cleaned up:
2696 - pythonIncludePath removed
2697 - python setup.py bdist target is now functional.
2698 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2699 collision with other packages). gdcmPython/demo/*.py changed
2702 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * python subdir moved to gdcmPython (preparation of distutils packaging).
2704 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2705 distutils installer is operational.
2706 * - gdcmPython/__init__.py now properly loads the swig generated
2707 shadow classes (from gdcm.py).
2708 - gdcmPython/demo/*.py changed to import the package gdcmPython
2709 instead of gdcmPython/demo/load.py.
2710 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2712 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2714 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2715 entries within the associated public Dicom dictionary resp. the same
2716 information but sorted by the fourth field (PAT, IMG, DIR) of the
2718 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2719 are now in the "???" group.
2720 - python/gdcm.i changed accordingly,
2721 - python/demo/printGroupedPublicDict.py added, that gives an example
2722 of the above new functionalities in Python.
2724 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * src/gdcm.h, gdcmHeader.cxx:
2726 - historic references to glib's g_malloc and g_free (#defined)
2727 were definitively removed.
2728 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2729 * src/gdcmElValSet.cxx:
2730 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2731 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2732 - GetElValue(string) renamed to GetElValueByName.
2733 - Added GetElementByName(string).
2734 * src/gdcmHeader.cxx: added
2735 - GetPubElValRepByNumber(guint16, guint16)
2736 - GetPubElValRepByName(string)
2737 - GetShaElValRepByNumber(guint16, guint16)
2738 - GetShaElValRepByName(string)
2739 - GetShaElValByNumber(guint16, guint16)
2740 - GetShaElValRepByName(string)
2741 - GetElValRepByNumber(guint16, guint16)
2742 - GetElValRepByName(string)
2743 - GetElValByNumber(guint16, guint16)
2744 - GetElValRepByName(string)
2745 * Doc/requirements.txt added.
2747 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2748 * Test/Makefile building now depends on the one of libgdcm.so
2749 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2750 pixel data) aware which enables finding the address (offset) of
2751 the pixel data of JPEG encoded DICOM files. This leaves only a single
2752 file in the testSuite whose pixel data address (offset) is unknown.
2753 * python/testSuite.py changed accordingly.
2755 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2756 * VC++ has some strong limitations when working with the STL, as stated
2757 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2758 "Also note that some STL containers (map, set, queue, list, deque)
2759 cannot be exported. [...]
2760 Some STL classes contain nested classes. These classes can not
2762 This is caused by a designed limitation that once a template
2763 class is instantiated, it can not be re-instantiated and
2765 Since our usage of map<> is ubiquitous in gdcm, this "designed
2766 limitation" of VC++ is a pitfall.
2767 Hence the Python wrappers of gdcm cannot be incrementally linked
2768 against the c++ dynamic library. The dirty but only workaround is
2769 to forget about incremental link of dynamic libraries and to generate
2770 the Python wrappers library with the inclusions of the underlying C++
2772 The following modifications concern this matter on Win32/VC++:
2773 - wrapping python correct with standalone wrapped dll (don't use separate
2774 dll under windows !!!!)
2775 - python21_d debug mode enabled (ask Frog how to use it :-)
2776 - NO problem with having an STL member of class for example string in C++
2777 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2778 - Python test of dcmlib in Python is ok under windows on a large set
2780 * removed glib references
2781 * typedef's inserted in gdcm.i for correct swig type management
2783 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2784 * python/demo/*.py load.py extracted from test.py. Added explore.py
2785 that only displays required tags and testAll.py that parses all
2786 the files of the testsuite without using unittest.
2787 * python/testSuite.py other additional test on new files added.
2788 * Data/* new test files added accordingly to the testSuite.
2789 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2790 the vr in the file differs from the one of the dictionary.
2792 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2794 values, but limits itself to values which are below a user specified
2795 size (by default 1024 bytes).
2796 * python/gdcm.i : elements not loaded (because their size is above the
2797 user specified treshold) are exported with their TagKey as key of the
2798 python dictionary. This enables the testsuite to make some checks
2799 on the unloaded elements (since we have their offset and size).
2800 * python/testSuite.py
2801 - now tests for the existence and proper value of the pixel data
2802 - two new examples added.
2803 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2805 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2807 aware. See the strategy comments in gdcmHeader::FindeLength().
2808 * Test/test.cxx now accepts a filename as first argument.
2809 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2810 * python/testSuite.py changed to integrate test on above files.
2812 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2814 the vr was also RET.
2815 * python/testSuite.py more tests added.
2817 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2818 * python/testSuite.py unittest test suite added (uses Data)
2819 * Data/* dcm and acr files for the test suite.
2820 * glib dependance removed from un*x version. We now use ISO C99
2821 7.18 Integer types (see stdint.h)
2822 - python/Makefile, src/Makefile src/gdcm.h
2823 * src/ when an explicit vr (like dicom files) suddenly poped an
2824 implicit element we use to mark the underlying DictEntry of the
2825 concerned ElValue with "Implicit". This strategy was damageable
2826 too the public or provite dictionaries, since some of their vr
2827 would be changed. Since Header::FindLength heavily relies on the
2828 detection by Header::FindVR of falsely explicit elements, I
2829 added an extra ImplicitVr member to ElValue (boolean).
2830 The rest of the changes we the necessary adaptations.
2832 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2833 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2835 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2837 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2838 * Adaptation for porting to VC++:
2840 o forced to use std namespace (for string to be known)
2841 o all class use __declspec export style on WIN32
2842 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2843 (in stdlib.h on Win32 but in std:: for gcc)
2844 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2845 variable GDCM_DICT_PATH.
2846 * src/gdcmHeader.cxx verbose comments made discrete.
2848 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2849 * python/gdcm.i: added a typemap that converts a C++ hashing table
2850 to native Python dictionary.
2851 * python/demo/test.py:
2852 - now uses the native dictionary for exploration of gdcmHeader.
2853 - takes an optional filename argument (the file to parse).
2854 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2855 PubElVals hashing table.
2856 * Dicts/dicomV3.dic removed error prone trailing spaces.
2858 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2859 * Python wrapping process moved away from src/Makefile to
2860 newly created python/Makefile (as well as gdcm.i)
2861 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2862 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2863 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2864 from the environement variable GDCM_DICT_PATH (when existing).
2865 * src/gdcmDict::GetTag bug fix.
2867 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2868 * Straightforward temporary fixes for swig to build the python wrappers.
2869 src/Makefile now has a python working entry [by working we mean
2870 that we can import de shadow classes without errors].
2872 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2873 * hashtest.cxx removed (since allready in Test)
2874 * src/gdcmlib.h renamed to src/gdcm.h
2875 * src/dcm.i renamed to src/gdcm.i
2876 * src/Makefile prepared for python wrapping
2878 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2879 * src/gdcmHeader.cxx :
2880 - Parsing of header is now separated from loading of element values
2881 (see gdcmHeader::LoadElements).
2882 - general clean up of hopefully all file access (creation of
2883 ReadInt16 and ReadInt32)
2885 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2886 * src/gdcmHeader.cxx :
2887 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2889 - SetLgrElem renamed to SetLength
2890 - GetLgrElem renamed to GetLength
2891 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2892 * src/gdcmElValSet.cxx fixed both GetElValue methods
2893 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2894 due to IdoDude was cleaned out.
2896 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2897 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2898 concentrates on finding the value representation (when it exists).
2899 RecupLgr now only finds the element value length, and it avoids
2900 returning the unecessary skL (skipped length).
2901 Also, offsetCourant was simply removed (with taille_fich) since
2902 it was redundant with the File position internals (by using
2903 ftell and fseek). This also made skL (see above in RecupLgr) usage
2905 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2906 on the libido specificities which are handled through class
2908 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2911 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2912 * Truckload of changes. Parsing of header is barely functional
2913 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2915 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2916 * src/gdcmHeader.cxx many addons of low level methods
2918 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2919 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2920 and _IdDcmSWAP_LONG.
2922 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2923 * This corresponds to all the changes decided at the meeting of
2924 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob