1 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
3 DocEntry. Now use methods of the Document !
5 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * Test/ShowDicomSeq.cxx : bug fix
8 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
9 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
10 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
11 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
12 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
14 * Test/TestCopyRescaleDicom.cxx : remove unused variable
15 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
16 containing found sequences
18 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
21 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
22 Some fields in BinEntry must be copied to not seg fault when making the :
23 gdcm::File *copy = new gdcm::File( copyH );
24 and tests are now made on good variables
26 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
27 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
28 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
30 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
31 * Add vtkGdcmWriter example and test
33 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Test/TestUtil.cxx : reformat the source code
35 * vtk/vtkGdcmReader.cxx : remove and change prints
36 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
38 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
39 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
41 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
43 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
45 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
47 by an eof to prevent all bad read of the file... and in this case, the
50 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * Example/Volume2Dicom.cxx : comment unused variables
52 * Test/PrintDicomDir.cxx : comment unused variables
53 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
54 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
55 method that is redondant with AddEntry.
56 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
59 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Bug fix due my last commit (compilation under Windows).
61 * Example/Volume2Dicom : bug fix in the file and reformatting source code
62 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
64 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 - Remove printf / sprintf
67 - include iostream AFTER gdcm so we don't get warnings
68 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
70 - Also remove tons of include from header files, hopefully this should
71 speeup the compilation time, since it was becoming a dog slow.
72 - Remove gdcm.h as it include way too many files and slow down compilation
73 (plus it is not up to date)
74 - remove 'using namespace std' this is BAD !
76 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * Remove memory leaks on the DicomDir
78 * Remove some useless datas in DicomDirObject
79 * Add usefull methods in SQItem, to be complient withe the ElementSet
81 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
84 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
85 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
86 future, with convertion)
87 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
88 and ImageDataSize values. Remove the method to get the PixelReadConverter
89 from the output of the class
91 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
94 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
95 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
96 and vtkErrorMacro use.
97 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
99 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
102 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
103 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
104 The string leaves only in the fonction. So when we make a .c_str(), we
105 get the pointeur on the first element, element that will be destroyed
106 immediately after thee instruction.
107 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
108 file has been opened : the test must be made on the content of the
109 pointer and not directly on the pointer !
112 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
113 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
114 the python part recompiles
116 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
117 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
118 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
119 X session is killed (for my computer... it seems to not be identic on
122 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
124 avoid problems (otherwise, the difference test between the visible image
125 and the reference is incorrect. If the reference is greater than the
126 screen resolution, it's produce errors).
127 Can be used for only one image. Can be used with a visible flag.
128 * vtk/vtkGdcmReader.cxx : remove commented codes.
129 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
130 under windows at compilation
131 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
133 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
135 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
137 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
138 tests on the image size X, Y, Z
140 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
142 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
143 between the class name and the file name
145 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * src/ : fix compilation warnings for the Write method (2 different
147 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
148 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
149 variable... create a static method in gdcm::Document to access to
150 this variable content.
152 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
153 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
154 file, to be accessed by other files (like gdcmFile). Remove commented
155 code. Move the change of the header to the gdcmFile, using the
157 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
158 To be sure of that (and simplify calls), the Write of the header now
159 gets a file name and not a file pointer (std::ifstream).
160 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
161 DocEntryArchive. Remove all open of the written file
163 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
164 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
166 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
168 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
170 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
171 some corresponding methods. Write correctly the file and check before
173 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
174 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
175 is now on RGB datas (as before my last commit
176 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
178 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
179 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
180 Add a print information of the type of the entry
181 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
182 It was in the gdcmFile, and all write have been regrouped
183 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
184 Write correctly all dicom files (in decompressed mode only at this time)
185 * Test/ : test on files are now made using Raw datas and not color datas if
187 * Example/PrintFile.cxx : add more printings
189 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * Amelioration of code, remove some code copy. For the loading of
191 BinEntry (in gdcmDocument), add the test to verify if the file is already
194 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
196 remove a DocEntry in the header (push an empty DocEntry)
197 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
198 lines. Bug fix in the initialization of the PixelConvert and the
200 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
201 use in TestCopyDicom (now this test can run under windows... but fails)
202 * Test/TestCopyDicom.cxx : amelioration of the test :
203 - test the pixels written
204 - add test points to quickly find where is the error
205 - can set a file name input and output in arguments
206 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
207 amelioration of the test output
209 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
210 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
211 all replaced DocEntry's
212 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
213 Now, each needed DocEntry to modify is duplicated, modified and inserted
214 to the header using DocEntryArchive. Thus, after save, we can restore the
215 header initial state.
217 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
218 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
220 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
222 correct to copy it. The DictEntry is specified at the DocEntry creation,
223 then, it musn't change in the time.
224 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
225 header correctly. At this time, the change is only made for the first
226 level of the Document. In the future, it might consider sequences.
227 The change is made by replacing a DocEntry by an other that is created
228 outside the class. The old value is kept. When we restore the header
229 status, the added DocEntry is deleted and replaced by the old value.
230 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
231 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
232 set the write type to explicit VR, implicit VR or ACR. Add methods to set
233 the write mode to native, decompressed or RGB (but not used at this time)
235 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
236 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
237 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
239 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
240 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
241 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
243 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
244 set because already copied when copying the BinEntry's of the header
245 * Test/TestAllReadCompareDicom.cxx : remove warnings
247 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
249 Two problems appear when doing it :
250 - with the gdcmFile : when the GetImageData method is called, the pixels
251 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
252 datas (pixels). And each structure destruct the datas when it's
253 destructed. So we have two destructions for the same datas. To solve it,
254 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
255 datas or not. If it doesn't own datas, then they will not destroyed by
257 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
258 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
259 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
260 create a double destruction of the same DocEntry's. So, to solve it,
261 the TagHT is simply cleared and the DicomDir* elements are destroyed.
262 * TODO : add an entry concerning memory leaks in the DicomDir
264 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
265 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
266 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
269 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
271 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
272 after it have been deleted
274 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
275 * FIX: src/* fix the doxygen warnings.
276 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
277 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
278 was erroneously defined with a size of 15 instead of 16. [many thanks
279 to Jean Michel Rouet for pointing out this bug].
281 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
282 1. Finish merging JMR patch for writting DICOM from scratch
283 2. Fix -hopefully- bug with MONOCHROME and space vs null character
284 3. Use const ref when possible
285 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
286 5. A few more comments
287 6. CreateUniqueUID can now be called without parameter"
289 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
290 * ENH: Slightly bigger patch:
291 1. Getting toward full integration of JMR patch for writting dicom from scratch
292 2. Update Test to test part of this patch: CreateUniqueUID
293 3. File was not close properly in gdcmDict
294 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
295 5. Use of const ref instead of copy (speed issue)
296 6. Remove temporary (duplicate) string in TranslateToKey
297 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
298 8. Do not repeat virtual in subclasses
299 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
301 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
302 * Apply first patch toward better string comparison when dealing with broken
303 DICOM files. Essentially the string could be padded with a space instead
304 of a null character as defined by standard
306 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
307 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
308 because never used... and in the same time, that's remove some memory leaks
310 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * src/gdcmFile.cxx : now delete the PixelConvert instance.
312 * In examples and tests : change the type of image data variables from void*
313 to uint8_t*. Remmove all delete on image data variables
315 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
317 Verify the file pointer value before open the file, and if it's not null,
318 a verbose message is generated.
319 Close correctly the file when the file isn't considered dicom-like. The
320 correctly close is a call to CloseFile.
321 When closing the file pointer, test if its not null to close the file.
322 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
323 file. For an uncompressed image, the copied datas correspond in the least
324 case to the image size (calculated) or the image size specified in the
325 header. A verbose is generated if these two size mismatch
327 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
328 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
329 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
330 break under windows (with msvc6 compilation).
332 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
334 compiling with MSVC6)
336 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
337 * Bugs fix for the Windows build with VC6
338 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
339 needed (only for projects required VTK). If the VTK is included in all
340 projects, there is conflicts with the jpeg lib of vtk when compiling the
341 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
342 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
343 when compiling the gdcm_wrap.cxx file (created by the compilation of the
345 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
346 (like it's already made for the cout use). Otherwise, conflict with the
349 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
350 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
352 - comments on the DicomDir::Method related usage added.
353 - now that we use the namespace gdcm, a lot of internal classes do
354 NOT need to be wrapped anymore.
355 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
356 DicomDir::Method) new example added.
358 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
359 * Improve string manipulation. I now inforce the notion of 'DicomString'
360 A DicomString can contain as many \0 as they want
361 and it is *always* of even length.
362 We only support odd length for very rare case.
363 And in the near future this should be removed.
365 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
366 * /binary_write/ gdcm source. Now even on big endian we are writting
367 little endian. This should -heopfully- fix some tests
369 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
370 * Now the dictionary is compiled into gdcm lib. This is a default
371 behavior, thus any dic file specified is picked before failback to
372 the one comiled into lib
374 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 * Change internals for gdcmDict. Don't use any 'new' any more.
376 This should definitely solve any leak problem, and we should be
377 as fast as before, as long as don't modify too much the dictionary.
379 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
380 * STYLE: ivars should start with a capital letter.
381 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
382 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
384 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
385 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
386 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
387 new 2004 dictionaries added (thanks to JPR).
388 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
389 * CLEANUP_ROUND (15) for gdcmPixelConvert
390 - RLEFrame::NumberFragments is now of type unsigned int
391 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
392 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
395 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
396 * Initial work in gathering all transfer syntax accessors. clearly
397 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
398 ivars, but only one transfersyntax (class) ivar with equivalent method on
401 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
402 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
403 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
404 discussed (plus I didn't like having a 2000 lines patch not commited)
406 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
407 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
408 * CLEANUP_ROUND (14) for gdcmPixelConvert
409 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
410 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
411 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
413 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
414 anymore and hence avoids storing a copy of PixelConvert::Decompressed
415 into File::Pixel_Data.
417 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
418 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
419 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
420 * CLEANUP_ROUND (13) for gdcmPixelConvert
421 Substituted File::ParsePixelData() with PixelConvert::Print() new
423 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
424 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
425 method to those classes.
426 - src/gdcmFile.[cxx|h]:
427 -- Added a ::Print() method.
428 -- PixelConverter is now a reference instead of a member.
429 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
430 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
432 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
433 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
434 collaboration diagram and inheritance diagram should be generated with
436 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
437 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
438 pointlessly wrapped (see
439 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
440 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
441 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
442 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
443 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
444 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
445 -- File::Initialise: PixelConverter setup moved away to
446 PixelConverter::GrabInformationsFromHeader()
447 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
448 interpretation moved away to PixelConverter::BuildRGBImage()
450 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
451 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
452 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
454 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
455 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
456 displayed on Win32 when a brutal abort() occurs (because of uncatched
457 exception). See TODO new entry of this commit for more on this.
458 * TODO added new entry.
459 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
460 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
461 - HandleColor is no longer called from gdcmFile.cxx
462 - gdcmPixelConvert.cxx clean up on method arguments and internal
463 variable names for semantical coherence.
465 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
466 * Finished lossless transition, not only do we now read all lossless jpeg
467 images, without the need of the Cornwell lib, but we do read them properly now
468 * To reduce code (well to avoid code duplication), I defined a common place
469 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
470 redefine symbols. This is not prefect but this the best solution I found for a
471 compilation time jpeg option.
473 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
474 * Update jpeg ijg lib to support lossless jpeg implementation
475 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
477 * Also added a special copyright for dcmtk since we use their bugfixes.
480 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
481 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
482 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
483 matters, as stated in warning note at begining of %include section).
484 * src/gdcmDicomDir*.[cxx|h]: coding style
485 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
486 * src/gdcmJpeg8.cxx: doxygen fix.
487 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
488 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
489 from File:: to PixelConvert::.
491 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
492 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
493 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
494 - more code moved away from File:: to PixelConvert::
495 - fat setup of PixelConverter set in place in File::Initialise.
497 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
498 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
499 namespace at the file system level. So now you should convert your examples
501 gdcmHeader -> gdcm::Header
502 It would be nice if people keep in mind to no open the namespace, since it
503 allows compilation on broken plateform which were defining common symbol in
504 the standart namespace (like LP, Unknown ...)
506 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
507 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
508 The JPEG fragments are now parsed at the same stage than the RLE
509 information. All code related to JPEG is now in gdcmPixelConvert:
510 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
511 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
512 export a gdcmFile:: method. Those are simply global functions
513 (for the time being this is better than having them attach to
514 either gdcmFile:: or gdcmPixelConvert::).
515 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
516 and stores the result in a gdcmJPEGFragmentsInfo.
517 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
518 code (among other stuff) moved away from gdcmFile:; to
521 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
522 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
523 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
524 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
525 clean up of RLE related code.
526 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
527 - src/gdcmRLE.cxx removed
528 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
529 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
530 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
531 * CLEANUP_ROUND (9) for gdcmPixelConvert
532 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
533 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
534 away from gdcmFile:: to gdcmPixelConvert::.
536 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
537 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
538 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
539 This is because Parse7Fe0 used to parse the pixels to compute the
540 length. This task was passed over to FindDocEntryLengthOB() a long
541 time ago, EXCEPT I had forgotten the OW case...
542 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
543 we just recylce the code for parsing RLE fragments and computing
545 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
546 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
547 with the retired Parse7Fe0().
548 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
549 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
551 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
552 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
553 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
554 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
555 - src/CMakeLists.txt: alphabetic order reodering + new entries.
556 * CLEANUP_ROUND (4) for gdcmPixelConvert
557 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
558 to return an unused length.
560 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
561 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
562 this should be cleanner from the plane view. The iostream are erally a pain
563 to use to do simple stuff.
565 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Redo the compilation of the ijg jpeg library. Now only one source is
567 necesseray. No need to rename file by hand what so ever. CMake handle the
568 copying of the file within different directory, configure header file to
569 modify some symbol. The only addition made to ijg wasd a mangle table so
570 that symbol are different wether we are within 8bits or 12bits.
572 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * Added documentation of vtkgdcmReader on Website:
574 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
575 with it's binary name).
576 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
577 the Website to be more complete.
578 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
579 doxygenated documentation.
580 - Doc/DoxyVtkGdcmReaderExamples.txt added
581 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
582 DoxyVtkGdmReaderExamples.html )
583 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
584 * CLEANUP_ROUND (3) for gdcmPixelConvert
585 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
587 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * CLEANUP_ROUND (2) for gdcmPixelConvert
589 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
591 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
592 * CLEANUP_ROUND for gdcmPixelConvert:
593 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
594 - src/gdcmPixelStuff[h|cxx] removed
595 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
596 - src/CMakeLists.txt changed accordingly
598 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
599 gdcmVersion.py moved to newly created ATTIC related
600 gdcmPython/SetupOldies/ directory.
601 * Autotools clean up:
602 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
603 - autogen.sh configure.in acinclude.m4 python.m4 removed
605 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
606 * src/*.cxx *.h Reference to License.htm fixed to License.html.
607 * Doc/CMakeLists.txt, doxygen.config.in: fix.
608 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
610 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * TODO updated with Mathieu suggestions. I proposed a template for
612 describing TODO entries and used it for new entries.
613 * Added Doc/Website/CodingStyle.html, Developpers.html,
614 DeveloppersPython.html, GdcmDataCvs.html and
615 DownloadVersion0_1.html, DownloadVersion0_3.html.
616 * Some Doc/*.txt Doxygen files (which do not really concern the
617 documentation itself, but the website) moved to html and
618 placed in directory Doc/Website:
619 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
620 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
621 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
622 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
623 * CMakeLists.txt changed accordingly.
624 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
625 DeveloppersPython.html
626 * INSTALL nows refers to Doc/Website/Installation.html
628 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
629 * Added Doc/Website directory, that contains a first raw version
632 2004-09-23 Jean-Pierre Roux
633 * FIX In order not to be poluted any longer by casting problems,
634 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
635 we can now delete[] it safely
636 * VoidArea is now called BinArea (less confusing name),
637 and all the methods called ...VoidArea... are now ... BinArea...
638 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
640 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
641 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
642 clear) TagHT, which is an inherited member of gdcmElementSet. It is
643 up to the destructor of gdcmElementSet to clean up TagHt and it's
646 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * Test/CMakeLists.txt: update to follow gdcmData renamings.
648 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
650 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * ENH: added some utility method that builds a flat dictionnary
652 holding all the Dicom entries contained in the recursive structure
653 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
655 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
656 BuildFlatHashTable() that build a flat dictionary.
657 - src/gdcmElementSet.h: added a new private GetTag() accessor.
658 gdcmDocument is now a friend of gdcmElementSet.
659 - src/gdcmElementSet.cxx: clean up.
660 - Example/FlatHashTablePrint.cxx added.
661 - Example/CmakeLists.txt changed accordingly
663 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
664 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
665 moved away from gdcmDocEntrySet (since this class is an abstract class
666 acting like an interface). SQDepthLevel and BaseTagKey are now
668 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
669 and associated accessors. Doxygenation of the class.
670 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
672 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
673 Use SQDepthLevel accessor instead. ::Print() adapted.
674 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
675 - src/gdcmDocument.cxx changed accordingly.
677 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
679 - The following is the doxygen comment of the typedef declaration
680 of gdcmagKey in src/gdcmCommon.h:
681 gdcmTagKey is made to old an "universal" (as in URL, Universal
682 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
683 A dicom tag allways has a group and an element, but a set of tags
684 embeded in various (optionally nested) sequences and sharing
685 the same group and element all share the same (group, element)
686 "identifier". Hence the (group, element) cannot be used as an
687 identifier (in gdcm we shall refer to a "TagKey") of a tag.
688 In order to construct a proper tag identifier (i.e. a key) we
689 consider the following definition of a TagKey:
690 - let Group, Element be the string representation of the
691 group and element dicom tag members,
692 - let ItemNumber be the string representation of the integer
693 index of the considered item number of a sequence,
694 Let the key of a tag embeded in a sequence, noted SeqTag, be
696 /ItemNumber#Group|Element
697 where "/", "#" and "|" are characters acting as separators.
698 Then the general form of a gdcmTagKey is given by:
699 Group|Element<SeqTag>
700 where <SeqTag> means NO or many instances of SeqTag.
701 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
704 but the gdcmTagKey of a tag "embeded" is the first item of
705 a sequence, itself nested in the third item of a sequence is the
707 0004|1220/2#0008|0082/0#0008|0090
708 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
709 order to hold the new sequence compatible key. Previously, the
710 GetKey() method would look in the underlying gdcmDictEntry.
711 - src/gdcmDocEntry.cxx:
712 -- constructor now copies the underlying DictEntry key, in the local
714 -- ::Print: displays the member Key, instead of the (group, element).
715 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
716 - src/gdcmDocEntrySet.h:xi
717 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
718 -- now has a new BaseTagKey member.
720 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
721 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
723 This poses the problem with the semantics of the following lines
724 LoadEntryVoidArea(0x0028,0x1201); // R LUT
725 LoadEntryVoidArea(0x0028,0x1202); // G LUT
726 LoadEntryVoidArea(0x0028,0x1203); // B LUT
727 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
728 to the long FIXME note for what the problem is. Nevertheless in
729 order to get things working the dicom dictionary was altered !
730 Please fix things urgently...
731 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
732 information), see above note on moving the member VoidArea. Nevertheless
733 the following entries previously correctly set as US are now inproperly
735 0028 1201 OW IMG Red Palette Color Lookup Table Data
736 0028 1202 OW IMG Green Palette Color Lookup Table Data
737 0028 1203 OW IMG Blue Palette Color Lookup Table Data
738 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
739 of gdcmDocEntry moved to gdcmSeqEntry.
740 * src/gdcmSeqEntry.cxx: STYLE.
742 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
743 * Test/TestAllEntryVerify.cxx minor fix and added comments.
745 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
746 * gdcmPython/testSuite.py: all the test suite in python is now moved
747 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
748 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
749 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
751 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
753 to avoid inclusion recursion until STL is reached.
754 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
755 mecanism. errno.h is not included in gdcm anymore.
756 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
757 (gdcmFormatError now inherits from gdcmFormatUnexpected).
759 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
760 gdcmData/TestAllEntryVerifyReference.txt
761 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
762 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
763 exception_on_error parameter.
764 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
765 - vtk/vtkGdcmReader.cxx changed accordingly,
766 - Example/*.cxx and Test/*.cxx changed accordingly.
768 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
769 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
770 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
771 enable_sequences removed from gdcmHeader constructor and dependencies.
772 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
773 * gdcmPython/demo/PrintHeader.py: dummy fix.
774 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
775 skip_shadow removed from gdcmHeader constructor and dependencies.
776 * Example/*.cxx and Test/*.cxx changed accordingly.
778 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
779 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
780 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
782 2004-07-21 Jean-Pierre Roux
783 * FIX Now, Parsing and Printing a DICOMDIR do work!
784 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
786 2004-07-20 Jean-Pierre Roux
787 * FIX Some brain damaged headers have Zero-Lenght fields
788 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
790 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
791 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
792 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
793 variable (instance of gdcmDebug) by a definition macro, and the instance
794 is now in static in the gdcmDebug class
795 * src/gdcmSQItem.h : (FIXME) remove an undefined method
796 * Test/PrintAllDocument.cxx : bug fix in the result of the test
798 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * WARNING: ctest now depends more tightly on gdcmData. You should
800 check out gdcmData properly for things to run smoothly...
801 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
802 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
803 we need the pixels not be loaded in order to use the ValEntry
804 that displays position and size).
805 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
806 This is a C++ based equivalent of gdcmPython/testSuite.py that should
807 be deprecated. If you have any doubts about the advantages of a
808 modern scripting language (read Python) versus grass root C++ (i.e.
809 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
810 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
811 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
812 Anyhow, consider documenting the gdcmData images in
813 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
815 * Test/CMakeLists.txt:
816 - now uses TestAllEntryVerify.cxx
817 - specific comments on oldACR00001.ima (now renamed in gdcmData
818 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
819 gdcmData/TestAllEntryVerifyReference.txt
822 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
823 * src/*.[h|cxx] : typedef clean up
824 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
825 - TagKey renamed to gdcmTagKey (for external usage)
826 - VRKey renamed to gdcmVRKey (for external usage)
827 - removal of typedef duplication.
828 - Removed all unecessary inline keyword from class inline definitions.
829 - Some method|function(void) declarations replaced with method|function().
830 * src/jpeg/libijg12/jdhuff12.c:
831 - printf polluting ctest removed.
832 - TAB removal for comminting
834 - TestAllReadCompareDicom.cxx: added a test that compares all the
835 images in gdcmDataImages.h with corresponding images in
836 gdcmData/BaselineDicom/. When baseline images are not present
837 this test creates them.
838 Note: we need to validate each reference image, but before that
839 I'd like to rename them with a more explicit name...
840 - CMakeLists.txt: changed accordingly.
841 * Example/*.cxx: examples now only include gdcm.h (as opposed to
842 including each header needed).
844 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
845 * Test/*.cxx and Example/*.cxx: moved some examples away from the
846 test suite to the Example directory. Are concerned:
851 - TestWriteSimple.cxx
852 * Test/CMakeLists.txt: added some comments on reasons for black listing
853 image gdcmData/oldACR00001.ima
855 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
856 * Test/CmakeList.txt: removed the following from black list (to be coherent
857 with removal from gdcmData):
858 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
859 - gdcm-MR-PHILIPS-16.dcm
861 Added the following because after last cvs update, they cause
862 ctest -R TestReadWriteReadCompare
864 - gdcm-MR-SIEMENS-16-1.acr
866 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
867 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
868 new comments in this file) we temporarily (sigh) move to a weaker
870 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
871 we don't need to black list the following images anymore:
872 - 8BitsUncompressedColor.dcm
874 - US-PAL-8-10x-echo.dcm
875 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
876 fixes and the beautified code ;-)
877 This fixes the bug introduced in version 1.42 (when beautifying)
878 that made the parsing of 8BitsRunLengthColor.dcm unproper.
879 Note: ctest was blind to this bug (this means we need to still
880 improve the test suite). The bug could be detected by using
881 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
883 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
884 and by displaying the (garbage) produced file temp.XDCM...
886 2004-06-29 Jean-Pierre Roux
887 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
888 - replace by uggly but working old code :-(
889 A lot of things should be OK again.
890 It's really urgent to have a test suite that *tests*,
891 to prevent Frog's beautifying sessions to break all the stuff
892 (twice, withing a fortnigh ...)
894 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
895 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
896 redundancy) to added Test/TestReadWriteReadCompare.cxx
897 * Test/CmakeList.txt: because the compare test of
898 Test/TestReadWriteReadCompare.cxx fails, the following images are
899 black listed: - 8BitsUncompressedColor.dcm
901 - US-PAL-8-10x-echo.dcm
902 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
903 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
904 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
905 and ad-hoc kludge. This kludge is now removed, and on encountering
906 such an image (OB field brain damaged) we set errno. Then in
907 ::FindDocLength() we "fix" the length as being ALL what remains
908 in the file (until EOF). We then proceed, hoping for the best...
909 This fixes a SegFault in ShowDicom when trying to write such an
911 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
912 (because TestWriteRead breaks on it, after a non conformal commit?).
913 ctest now runs properly, except for MakeDicomDir (which was allways
914 broken) and the Python related stuff (still not fixed).
916 2004-06-24 Jean-Pierre Roux
917 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
918 FIX : Test/TestReadWrite now iterates on all the file names
919 (instead of infinite loop)
920 ENH : Test/TestWriteRead now iterates on all the file names
922 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
925 2004-06-24 Jean-Pierre Roux
926 FIX : - now Write drops LUT Descriptors and LUTs (if any)
927 when SamplesPerPixel =3
928 - now Write is no longer confused by
929 'BitsAllocated = 12" and 'BitsStored=12"
930 - "UN" value representation Elements are now written correctly
931 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
932 ENH : - now gdcmHeader has its own Write methods
933 (in order to split the job that has not to be done
936 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
938 loop on the same image until memory went out.
939 Note: this means we still have gobs of memory loss in PrintDocument
940 * src/gdcmDocument.cxx: fixes problem on parsing on file
941 gdcmData/16BitsJpegLosslessGrayScale.dcm.
943 2004-06-24 Jean-Pierre Roux
944 FIX : Write - All the Sequences and Sequence Item are now written
945 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
946 is added a the end, when necessary.
947 - A lot of brain-damaged images, that were read correctly are
948 now written correctly
949 - length compatible BinEntry are now loaded correctly
950 (even for odd groups)
951 Note : only Explicit Value Representation was checked.
952 (question : is implicit VR really necessary for gdcm ?)
954 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
955 * DEVELOPPER: added a proposition of coding style.
956 * src/gdcmDocEntry.h: removed every inline declaration (for test of
959 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
961 Use the gdcmDocEntry::Print() and Write() instead.
962 * src/gdcmDocument.cxx: bug fix.
964 2004-06-22 Jean-Pierre Roux
965 FIX : gdcmDocument.cxx
966 - Now we do recognize the JpegLossLess format (there was a misstyping in
967 code 'beautyfication' :-(
968 - Now we automaticaticaly load the Luts, if any
970 2004-06-22 Jean-Pierre Roux
971 In order : to write Sequences, whatever their imbrication level,
972 : to allow user to create his own Sequences
973 a lot of modif where necessary (adding, moving, or virtualising methods)
975 WARNING : save your own sources *before* cvs up !
978 ADD virtual void Write(FILE *fp, FileType filetype);
981 ADD virtual void Write(FILE *fp, FileType filetype);
982 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
985 ADD virtual void Write (FILE *fp, FileType filetype)=0;
986 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
987 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
988 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
989 ADD std::string GetEntryByName(TagName name);
990 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
992 std::string vr = "unkn",
993 std::string fourth = "unkn",
994 std::string name = "unkn");
995 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
996 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
997 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
998 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
999 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1000 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1001 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1002 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1005 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1006 ADD virtual std::string GetEntryByName (TagName tagName);
1007 ADD virtual std::string GetEntryVRByName (TagName tagName);
1008 REM virtual bool Write(FILE *, FileType);
1009 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1010 FILE *_fp, FileType type);
1011 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1012 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1013 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1014 REM virtual std::string GetEntryByName (std::string tagName);
1015 REM virtual std::string GetEntryVRByName (std::string tagName);
1016 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1017 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1018 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1020 std::string vr = "unkn",
1021 std::string fourth = "unkn",
1022 std::string name = "unkn");
1023 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1024 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1025 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1026 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1029 ADD virtual void Write(FILE *fp, FileType filetype);
1032 ADD virtual void Write(FILE *fp,FileType filetype);
1035 ADD virtual void Write(FILE *fp, FileType filetype);
1036 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1037 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1038 REM std::string GetEntryByName(TagName name);
1041 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1043 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1045 The default constructor invoked by the line
1046 gdcmHeader *f1 = new gdcmHeader( header );
1047 was gdcmHeader::gdcmHeader(bool) instead of the expected
1048 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1049 Hence the parsing wasn't executed... See also below.
1050 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1051 as explicit constructor didn't do the trick to fix the above problem.
1052 Could anyone explain why ?
1053 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1054 properly calls gdcmValEntry::Print() (that was weed out from
1055 code related to gdcmBinEntry).
1057 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * In order to fix memory leaks:
1059 - Test/TestWriteSimple.cxx: added cleaning of free store through
1061 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1062 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1063 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1064 (through the call to ::AddDicomDirMeta()) or the destructor
1065 would crash when deleting uninitialized ::metaElems].
1066 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1067 - src/gdcmDocument.cxx:
1068 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1069 from dynamic stores.
1070 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1071 was causing memory leaks.
1072 - src/gdcmSQItem.cxx:
1073 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1074 cleanly handled with polymophism: sorry but my milage is low).
1075 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1076 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1077 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1078 This avoids SegFaulting.
1079 - src/gdcmSQItem.h: coding style.
1081 - Test/TestWriteSimple still severely sucks. The output image content
1082 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1083 damaged when displayed with vtkgdcmViewer.
1084 - on memory leaks: TestWriteSimple leaks really less (see entry
1085 of 2004-06-18 in Changelog file for the call to valgrind).
1086 - on segfaults: ctest now passes all the tests but one (no more
1088 * Erroneous leading white fix:
1089 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1090 white[s] (as opposed to from >> xxx, that removes it [them].
1091 - src/gdcmTS.cxx: ditto.
1092 - gdcmPython/testSuite.py: dirty related kludge removed.
1093 * src/*: remaining references to gdcmParser removed.
1094 * src/*[cxx|h]: added copy[way]left header.
1097 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1098 * In order to fix writing of dicom files:
1099 - Test/TestWriteSimple.cxx: a simpler example of writing.
1100 - Test/CMakeLists.txt changed accordingly.
1101 - src/gdcmDocument.cxx:
1102 -- The destructor now recursilvely removes potential sequences.
1103 -- Bug fix in ::IsJPEG2000()
1104 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1105 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1107 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1108 to only declared) and build on top of
1109 ::GetDocEntryByNumber(guint16, guint16).
1110 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1111 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1112 for usage in destructor and treatement of promotion in
1113 ::ReplaceOrCreateByNumber().
1114 - src/gdcmSQItem.cxx: destructor should better handle his job.
1115 Test/TestWriteSimple now runs (or at least it DOES something).
1116 * We can now start hutting memory links. A good starting point is:
1117 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1118 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1119 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1121 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1122 * Valgrind note: after Mathieu Malaterre teached me how to read
1123 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1125 Using gcc, you can force the STL to use malloc and to free memory as
1126 soon as possible by globally disabling memory caching.
1127 With 3.2.2 and later, you should export the environment variable
1128 GLIBCPP_FORCE_NEW before running your program.
1129 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1130 simply vanish (it is still not clear to me, whether this means that
1131 STL std::string leaks or if valgrind believes it leaks...).
1132 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1133 running bin/gdcmTests makeDicomDir):
1134 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1135 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1137 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1138 SegFaulting (I drowned in DicomDir related code when trying to
1139 understand why the list is empty...).
1140 * src/gdcmDocument.h: first BSD license header try.
1141 * Doc/License.txt added.
1143 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * src/gdcmDocument.[h|cxx]:
1145 - Clean up of the Transfer related predicates. They are now all based
1146 on new method isGivenTransferSyntax, that (should) handle properly
1147 the padding problem.
1148 - general clean up, simplification, and coding style.
1149 - Specific clean up of Parse7FE0() (umproperly named actually).
1150 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1152 2004-06-14 Jean-Pierre Roux
1154 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1155 - fix the display of SQItem ordinal number
1156 - add the GetSQItemByOrdinalNumber method
1157 - remove some useless never written private methods
1159 2004-06-14 Jean-Pierre Roux
1161 - adding a constructor taking a gdcmDocEntry as an input param
1162 - ReplaceOrCreateByNumber now returns :
1163 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1164 a gdcmValEntry * if a string value is passed as a param
1166 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1167 according to the param type (no longer sets a gdcmDocEntry)
1168 - GetValEntryByNumber, GetBinEntryByNumber added
1169 - NewValEntryByNumber and NewBinEntryByNumber added
1171 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1173 - GetSQItemNumber and SetSQItemNumber added, to provide
1174 a (relative) Item identier inside a given Sequence
1175 \warning : some pb remaining around this number
1177 - AddEntry now takes the Item Number as a param
1179 - adding a constructor taking a gdcmDocEntry as an input param
1181 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1182 * Memory leak hunt with the following command:
1183 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1184 --show-reachable=yes gdcmTests PrintDocument
1185 It looks like many (all?) leaks are due to the STL (or a bad usage
1186 of the STL. The lines producing the leaks now have a comment with
1187 a "MEMORY LEAK" tag: you can retrieve them with
1188 grep "MEMORY LEAK" src/*
1189 Here are two typical examples which I can't help fixing:
1194 char * test = "babo";
1195 name = test; //// <--- valgrind detects 960 bytes lost in
1196 //// call to std::string::operator=(char const*)
1197 name.clear(); //// Doesn't help !
1205 std::cout << "Type a bunch of characters followed by RETURN: ";
1206 getline(std::cin, line); //// <--- valgrind dectects a loss
1207 //// of 1320 bytes in call to
1208 /// std::basic_istream<>& std::getline<>
1214 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1215 * src/gdcmHeader.[cxx|h]:
1216 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1217 and related, moved away to gdcmDocument.
1218 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1219 the corresponding protected accessors of inherited class
1220 gdcmDocument, removed ! As a consequence gdcmFile had to be
1221 declared friend of class gdcmDocument (see below).
1222 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1223 - Clean up of undefined or unused methods.
1224 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1225 account the changes to gdcmHeader.h).
1226 * src/gdcmDocument.h:
1227 - gdcmFile is now a friend class (in order to take into account the
1228 changes to gdcmHeader.h).
1229 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1230 (see changes to gdcmHeader.h).
1231 - Accessors (reading on the form GetEntry*) are now public.
1232 - Clean up of undefined or unused methods.
1233 * src/gdcmDocument.cxx:
1234 - adaptation to changes to gdcmDocument.h
1235 - ::OpenFile now writes a verbose message when file cannot be opened.
1236 - some std::string properly set to VRKey
1237 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1238 references to gdcmDocument.
1239 * Test/TestFindTags.cxx: changed accordingly to above changes.
1240 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1241 cvs repository gdcmData.
1243 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1244 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1245 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1246 conflicts with gdcmValEntry::voidArea.
1247 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1248 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1249 Value representation between StringRepresentable and BinaryRepresentable.
1250 * src/gdcmDocument.cxx:
1251 - method ParseDES: proper indentation restored and usage of
1252 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1253 - method LoadDocEntry: the fingerprint left in the SetValue() of
1254 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1255 removed. Reverting to previous code segment with the proper
1256 dynamic_cast< gdcmValEntry* >.
1257 Note: this was (partially) breaking the python test suite
1258 (gdcmPython/testSuite.py) that made usage of the above
1259 fingerprint to check presence of "Pixel Data".
1260 * src/gdcmDocEntry.h: coding style.
1261 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1262 now taken into account.
1263 * gdcmPython/gdcm.i: adaptation to the new internal representation
1264 of gdcm (exit gdcmParser, hello gdcmDocument).
1265 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1267 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1268 anymore, but instead prints the loaded Python dictionary.
1269 * .... alas, the python testSuite is still broken.
1271 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1272 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1274 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1275 * src/gdcmUtil.h : export methods
1277 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1278 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1280 * Initial addition of automatic python testing
1281 * Initial addition of automatic image comparison
1283 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1284 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1285 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1287 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1288 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1289 * Test/ShowDicom.cxx : bug fix for msvc compilation
1290 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1292 2004-05-04 Jean-Pierre Roux
1293 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1294 new concepts (and new classes) :
1295 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1296 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1297 - Sequence Doc Entries (gdcmSeqEntries)
1298 a Sequence is composed of Items.
1299 Each item is a set of Doc Entries (this is recursive)
1300 The non uniqueness of the 'Dicom tag' is due to this recursivity
1301 (never taken into account)
1302 Our unability to add a new 'entry' in the header
1303 at the proper location (neither in the H-Table (map or multimap),
1304 nor in the Chained List is also due to this recursivity.
1305 Don't try, right now, to use/modify/compile these new sources :
1306 nothing is finished.
1307 We just commit all the stuff, 'as is', in order not to loose it.
1309 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1310 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1312 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1313 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1314 file prefix (SetFilePrefix)
1316 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1317 * Add a new test: ShowDicom, for now this is just the c++ version of
1318 checkRead.sh, later it will be able to compare the image read against a
1320 * Replace the DEBUG on the stack with a global entry in cmake interface:
1321 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1323 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * Add an example subdir, with a real example on how to read + write a
1327 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1328 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1329 * Doc/CMakeLists.txt: the main page is now properly differentiated
1330 between the developper and user version.
1331 * Doc/doxygen.config.in: dropped search related obsolete flags
1332 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1334 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1335 * DEVELOPPER: added some helpfull comments for compile/test/install
1338 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1339 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1340 src directory, now generated in the build dir.
1341 2. Tests as mentionned smarter
1343 4. Add a new method in gdcmDict that return the PubDict by name
1344 this is interesting for 3rd party lib like ITK,
1345 where we could set the institution name / patient name...
1347 * ENH: 1. Now the test suite is working for real
1348 2. All binaries are now output in the gdcm-bin directory
1349 (this was not true before)
1351 2004-04-28 Jean-Pierre Roux
1352 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1353 SeQuence indented printing of Dicom Header.
1354 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1355 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1356 Computation of SQDepthLevel is now part of gdcmHeader constructor
1357 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1358 tree-like structure of a Dicom Header.
1359 * FIX Test code cleaning
1361 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1362 * ENH: Adding automatic testing
1363 1. Need a DartConfig.cmake to submit to public
1364 2. Add a test driver gdcmTest.cxx
1365 3. gdcmTestMain, an helper for the main test driver gdcmTest
1366 4. Files in Test don't have a main anymore, this becomes interesting
1367 when we add more and more tests, thus dsw don't have to load
1369 * ENH: Adding a GDCM_DATA_ROOT for testing
1370 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1371 one file instead of seven + some small cleanup
1373 2004-04-22 Jean-Pierre Roux
1374 * ENH Minor changes to the Print() methods.
1375 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1376 Header printing. Example given with :
1377 > PrintHeader fileName 2 new
1378 (SQ based tree-like structure still to be done for the Header ...)
1380 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1381 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1382 1. I have added some unsigned where needed
1383 2. Some function parameter not used -> (void)
1384 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1385 4. g++ don't like character '\' in comment
1386 5. #define jpeg_create_decompress jCreaDecompress
1387 this really need to be fixed
1388 6. virtualize destructor of gdcmObject ... leakage
1389 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1390 this also really need to be fixed
1391 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1392 remove compression file
1393 (as we only do decompression, right ?)
1394 * ENH: Change malloc/calloc/free with c++ equivalent
1396 2004-04-21 Jean-Pierre Roux
1397 * FIX gdcmHeaderHelper::GetXSpacing
1398 when a single value is found (bug ?), xpacing is now
1399 defaulted to yspacing
1401 2004-04-19 Jean-Pierre Roux
1402 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1403 * ENH add parameters :
1404 bool exception_on_error = false,
1405 bool enable_sequences = false,
1406 bool ignore_shadow = false
1407 to the gdcmFile constructors to be full gdcmParser compliant
1408 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1409 to allow reading of PAPYRUS 3.0 files
1411 2004-04-06 Jean-Pierre Roux
1412 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1414 2004-04-02 Jean-Pierre Roux
1415 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1416 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1417 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1419 2004-03-30 Jean-Pierre Roux
1420 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1421 for ACR file, written out as DICOM files (hope so...)
1423 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1424 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1425 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1426 moved to base class gdcmParser and only the specialisation is kept
1428 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1429 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1430 already does the job.
1431 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1432 (to be consistent with gdcmParser::WriteEntries).
1434 2004-03-30 Benoit Regrain
1435 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1436 upate of the object's instance. It's passed to 2 in the unfavorable
1437 case : one in the ExecuteInformation, one in the ExecuteData
1439 2004-03-29 Jean-Pierre Roux
1440 * ENH : Check on file type to be written moved
1441 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1442 * FIX : gdcmObject::ResetBoundaries now stops properly
1443 when end-of-list is reached
1444 : gdcmVersion modified (as Benoit Regrain asked)
1446 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1447 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1448 * src/gdcmUtil.cxx: added forgotten iostream include.
1449 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1450 equivalent to ExplicitVR in existing code).
1452 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1453 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1454 now contains all the gdcmGlobal related code.
1455 * minor coding style and doxygenation changes.
1457 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1458 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1459 now contains all the Debug related code.
1460 * minor clean-up of includes in src/*.cxx
1461 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1462 CreateCleanString) removed.
1463 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1464 * Doc/DoxyMainPageUser.txt added.
1465 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1466 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1467 src/gdcmDirList.cxx)
1469 2004-03-24 Jean-Pierre Roux
1470 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1472 2004-03-23 Jean-Pierre Roux
1473 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1474 big endian made volumes
1475 * ENH Now gdcmParser constructor and destructor are protected to forbid
1476 end user to instanciate class gdcmParser
1477 (only gdcmHeader and gdcmDicomDir are meaningfull)
1479 2004-03-22 Benoit Regrain
1480 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1481 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1482 gdcmSerie to gdcmDicomDirSerie
1484 2004-03-19 Jean-Pierre Roux
1485 * ENH Now the tree-like structure describing a DICOMDIR comming from
1486 an already existing DICOMDIR file is consistent with
1487 the home-made tree-like structure build ex-nihilo
1488 or build from the files held (recursively) in a Directory
1489 functions gdcmDicomDir::CheckBoundaries()
1490 gdcmObject::SetBoundaries() added
1492 2004-03-17 Jean-Pierre Roux
1493 * REM (Eric Boix bug) : removal of meaningless
1494 gdcmDicomDirImage::NewImage function.
1495 * FIX now file names and directory name are written properly in the
1497 * FIX now gdcmDicomDir constructor may be call without any trick
1500 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1501 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1502 of gdcmDicomDirImage::NewImage as empty function.
1504 2004-02-28 Jean-Pierre Roux
1505 * ENH add gdcmDicomDir:NewPatient
1506 add gdcmDicomDirPatient:NewStudy
1507 add gdcmDicomDirStudy:NewSerie
1508 add gdcmDicomDirSerie:NewImage
1509 to allow making gdcDicomDir object.
1510 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1511 (as opposite to the gdcmHeader chained list)
1513 2004-02-11 Benoit Regrain
1514 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1515 when using from python
1517 2004-02-10 Benoit Regrain
1518 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1519 * FIX : in gdcmDicomDir when the directory is empty
1520 * ENH : add callback and methods to get the progression of dicomDir
1523 2004-02-06 Jean-Pierre Roux
1524 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1525 - GDCM_META added to gdcmDicomDirType
1526 - class gdcmMeta created
1527 * ENH : - A brief summary is now displayed at the beginning of
1528 'testDicomDir' to help disaster magnitude estimation
1529 * REM : Now useless Test/explDICOMDIR.cxx
1531 2004-02-05 Benoit Regrain
1532 * ENH : add methods in gdcmObject to get the hash table or the list of
1534 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1535 * FIX : wrapping python for TagHeaderEntryHT
1537 2004-02-04 Benoit Regrain
1538 * FIX : even length for some strings when writting the dicom dir
1539 * FIX : sort the images in the dicom dir
1540 * FIX : Bug fix for python use of dicom dir
1541 * ADD : a python demo
1543 2004-02-04 Jean-Pierre Roux
1544 * FIX : Final solution (?) for icone embedded images
1545 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1546 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1547 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1548 gdcmData/gdcm-MR-SIEMENS-16.acr1
1549 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1550 to make full checking easier
1552 2004-02-04 Benoit Regrain
1553 * FIX : WriteEntries : coding style & logic in parameters
1554 * FIX : Set the elements to create the DicomDir in a dictionary file
1556 2004-02-03 Benoit Regrain
1557 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1558 * gdcmDicomDir : add the load of directory
1559 * Bug fix and print add-on
1561 2004-02-03 Jean-Pierre Roux
1562 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1563 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1564 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1565 * FIX gdcmParser.cxx : 'group length' elements are now considered
1566 as integers, even for shadow groups, when file is Implicit VR
1568 2004-02-02 Jean-Pierre Roux
1569 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1571 of the last synonym :-(
1572 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1574 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1575 * FIX taking into account the possible 7fe0,0010 multiplicity
1576 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1577 to allow removal of references to 7fe0,0010, to deal with
1578 ACR-NEMA images, when 0028,0200 is meaningfull
1580 2004-01-31 Jean-Pierre Roux
1581 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1582 no longer writes 'Un' on disk
1583 * FIX SQ elements with actual length are now dealt with corectly
1584 * FIX gdcmFile::WriteBase make the difference, for color images, between
1585 the length (for Palette expanded images)
1586 and Raw Length (non expanded image + Palette)
1587 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1588 (that broke Write). Replaced by UL.
1589 Aware user will reload the field if he
1590 thinks it's necesssary
1592 2004-01-30 Jean-Pierre Roux
1593 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1594 when 'dirty Acr' is found, to be compliant with the new
1595 IsReadable() methods.
1597 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1598 (no DOUBLE images in kosher DICOM,
1599 but so usefull for people that miss them ;-)
1601 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1602 DICOMDIR related utilities (not checked as Windoze compliant)
1604 2004-01-28 Jean-Pierre Roux
1605 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1607 2004-01-27 Jean-Pierre Roux
1608 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1609 to allow skipping the shadow elements, to save memory space.
1610 The TRUE value for this param has to be used
1611 with a FALSE value for the 'enable_sequence' param.
1612 ('public elements' may be embedded in 'shadow Sequences')
1613 * gdcmHeader methods now deal with 'embedded icones images' in the header
1614 (even when an 'icone image sequence' is announced by the
1615 element (0x0088,0x0200), but there is NO icone at all ...
1617 * gdcmHeader sometimes Image Location value doesn't follow
1618 the supposed processor endianity (see gdcmData/cr172241.dcm).
1621 * gdcmHeader add the method
1622 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1623 to get *all* the Header Entries with the same tag.
1624 GetHeaderEntrySameName is probabely *useless*
1625 (no meaning : Name is *not* an identifier within the Dictionnary)
1627 2004-01-26 Benoit Regrain
1628 * Bug fix in the print of hexadecimal representations. Remove long fields
1629 in the print and add a third level of print to print them
1631 2004-01-23 Benoit Regrain
1632 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1633 * Bug fix on test suite after remove the strip made on not string fields
1634 * Split the IsReadable method between gdcmParser which test that the file
1635 is dicom and gdcmHeader which test that it's an image file
1637 2004-01-22 Benoit Regrain
1638 * DicomDir : clean code, add methods, set variables in protected or private
1639 * gdcmUtil : bug fix for the clean string method
1641 2004-01-19 Benoit Regrain
1642 * Add the use of shadow dictionaries
1643 * bug fix and coding style
1645 2004-01-19 Benoit Regrain
1646 * src/gdcmFile.cxx : bug fix concerning the close of file
1647 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1648 * Add the update of header entries using the shadow library
1650 2004-01-19 Benoit Regrain
1651 * removal of file gdcmHeader2.cxx
1652 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1653 inheriting from gdcmParser. This split is to prepare the integration
1654 of dicom dir parsing
1655 * bug fix under python
1657 2004-01-16 Jean-Pierre Roux
1658 * REM removal of class gdcmHeaderEntrySet
1659 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1660 * ADD add file gdcmHeader2.cxx
1661 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1663 2004-01-15 Benoit Regrain
1664 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1665 entries created while parsing the header. Thus, they will be destroyed
1666 when the gdcmDictSet will be destroyed
1667 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1670 2004-01-15 Benoit Regrain
1671 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1672 made a fatal error because of the memory release at the end of program.
1673 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1674 some memory and vtk seems to have some problems with that.
1675 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1677 2004-01-14 Benoit Regrain
1678 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1679 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1680 * src/*.[h|cxx] : make changes due to class name changes
1681 * gdcmPython/demo/*.py : bug fix due to method names
1683 2004-01-13 Benoit Regrain
1684 * src/*.[h|cxx] : coding style
1685 * vtk/*.[h|cxx] : coding style
1687 2004-01-13 Benoit Regrain
1688 * gdcmPython/testSuite.py : test the readable flag of file for tests
1689 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1690 It's lied to the stl compilation by MSVC (windows, always windows...)
1691 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1693 2004-01-12 Benoit Regrain
1694 * src/*.h : add comments
1695 * src/gdcmDictSet.h : set the method BuildDictPath in public
1696 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1697 directly setted in the source code
1698 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1701 2004-01-09 Benoit Regrain
1702 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1703 * setup.py : use a reference to gdcmVERSION
1705 2004-01-07 Benoit Regrain
1706 * Modification to compile with the distutils.
1709 2003-12-10 Benoit Regrain
1710 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1711 can use a gdcmHeaderHelper to load datas
1712 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1713 made in the source code
1715 2003-12-10 Benoit Regrain
1716 * Update Windows projects and .cvsignore files
1718 2003-11-12 Jean-Pierre Roux
1719 * ENH gdcmHeader constructor has one more parameter (default value : false)
1720 that allows the user to 'go inside' the SeQuences only
1722 gdcmElValSet:Print takes it into account
1724 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1725 * ENH: Update gdcmPython/CMakeLists
1726 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1727 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1729 2003-11-10 Jean-Pierre Roux
1730 * FIX : gdcmHeader::LoadElements is now based
1731 on the ListTag listElem member,
1732 not longer on the TagElValueHT tagHt member
1733 * ENH : PrintPubElVal shows (temporarily) both results,
1734 with the tagHt member and the listElem member.
1735 (it's easier to 'see' the problems when using Printheader)
1737 * FIX : old private member LgrElem is now splitted into
1738 ReadLength : Length actually found on disk (updated only
1739 if bug fixing is necessary), for internal
1741 UsableLength : Updated by FixFoundLength, to fix a bug
1742 or to allow Parser going on.
1743 Will allow to re-write a kosher header when a SeQuence
1744 with a length (not 0000) is found
1745 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1746 because gdcmElValSet::Add does not update ListElem
1749 2003-11-07 Jean-Pierre Roux
1750 * FIX misstyping in Transfert Syntax name table
1751 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1752 when they have an actual length (not 0000 nor FFFFF)
1753 (Nobody should care of it, but DICOMDIR explorers)
1755 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1758 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * ENH: vtkGdcmReader now supports LUT !
1760 (vtkgdcmViewer for now is not able to use them though)
1762 2003-11-05 Jean-Pierre Roux
1763 * in testSuite.py : new files names for checking the package
1764 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1765 that returns the pixel area size to the *aware* (vtk) user
1766 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1768 2003-11-05 Benoit Regrain
1769 * in testSuite.py : Modify the rules for checking the paths
1770 : Explicit error messages
1771 * in __init__.py : Related modif
1773 2003-11-03 Jean-Pierre Roux
1774 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1775 to be used by aware (vtk) users that want to manage
1776 LUT (and no to turn the PALETTE image into an RGB pixels one)
1777 * GetPixelType now returns 8U for 24 Bits images
1778 (vtkGdcmReader compliant)
1780 2003-10-31 Jean-Pierre Roux
1781 * Removal of *all* gdcmData images and add them again
1782 in order to loose the 'history' of un-anonymised images
1784 2003-10-31 Jean-Pierre Roux
1785 * RMV : removal of useless jBitsInJsample.h
1786 for both 8 and 12 Bits JPEG Lossy Libraries
1788 2003-10-31 Jean-Pierre Roux
1789 * ENH : Add the functions gdcmFile::GetImageDataRaw
1790 gdcmFile::GetImageDataIntoVectorRaw
1791 that act as GetImageData and GetImageDataIntoVector
1792 except the making of an RGB Plane from Gray Plane + LUT
1793 Intended to aware (vtk) users who know how to manage
1796 GetLUTRGBA return a R,G,B,A LUT if any
1797 lgrTotaleRaw gives the 'Raw' length
1798 GetImageDataRaw returns the gray Plane
1799 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1800 (They stay Grey, just like with other Dicom viewers :-(
1802 2003-10-30 Jean-Pierre Roux
1803 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1805 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1807 being coherents dicom files.
1809 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1810 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1812 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1813 * ENH: Two steps is necessary to please VC++ compiler...
1814 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1815 * ENH: Add include dir to medcon lib
1816 * FIX: only one function is being exported for now !
1817 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1819 2003-10-29 Jean-Pierre Roux
1820 * adding gdcmHeader::GetLUTRGBA
1821 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1822 --> Mathieu, the modif u're waiting for is not yet committed
1823 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1825 2003-10-27 Jean-Pierre Roux
1826 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1827 00191113.dcm DermaColorLossLess.dcm
1828 MxTwinLossLess.dcm RadBWLossLess.dcm
1829 * ENH: For version prior to vtkImageViewer2 -r 1.19
1830 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1832 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1833 * Removal of ido stuff in CMakeLists.txt
1835 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1836 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1837 * FIX: remove a call to ->Modified ... see comments
1838 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1840 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * FIX: Problem with path for libvtkgdcmPython
1842 * ENH: Try adding a search script for python site-package
1843 * RMV: Remove some file from medcon lib that are not necessary
1844 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1845 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1846 * FIX: More pragma disable fro VC++,
1847 I don't think I break something as it is also disable in VTK/ITK.
1848 But it fasten debug compilation time.
1850 2003-10-23 Jean-Pierre Roux
1851 * gdcm now deals with 16 Bits Run Length Encoded images
1852 (they are compressed as 2 planes images,
1853 one for the high Bytes, the other for low Bytes)
1855 2003-10-22 Jean-Pierre Roux
1856 * Now CheckRead takes into account :
1857 - the bugged 'Leonardo' Siemens images
1858 - the XA images, sent thru the burning VPRO station
1859 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1862 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1863 * FIX: When copying a Makefile.am to CMakeLists.txt
1864 one should remove the '\'
1866 2003-10-22 Jean-Pierre Roux
1867 * in gdcmData adding a bugged 'Leonardo' Siemens image
1868 (wrong lengths in header)
1869 OK with gdcm, KO with the other viewers :-)
1870 * add a GE dlx XA image, thru the VEPRO burning station
1873 2003-10-21 Jean-Pierre Roux
1874 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1875 for a brutal checking of vtkgdcmViewer compliance
1877 2003-10-21 Jean-Pierre Roux
1878 * add the files for 'xmedcon' Jpeg Lossless library
1879 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1881 2003-10-21 Jean-Pierre Roux
1882 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1884 2003-10-21 Jean-Pierre Roux
1885 * garbage Siemens 'Leonardo' images dealt with
1886 (the patch is easy to remove)
1887 * cosmetic changes to avoid warnings
1889 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1891 no need to press 'r' now.
1893 2003-10-20 Jean-Pierre Roux
1894 * upgrade of checkRead.sh checkWrite.sh according
1895 to new Jpeg Lossless decompressor
1896 * add US.3405.1.dcm, a genuine RGB medical file ...
1897 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1898 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1900 2003-10-15 Jean-Pierre Roux
1901 * general anonymisation in gdcmData
1902 * adding the 'color files' from
1903 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1904 * adding some well knowed bugged-header images
1905 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1906 waiting for their inclusion in Python testsuite
1908 2003-10-15 Jean-Pierre Roux
1909 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1910 no longer seg faults when file is not found
1912 2003-10-14 Jean-Pierre Roux
1913 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1916 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * TODO: *.in file to genereate a UseGDCM later
1919 2003-10-14 Jean-Pierre Roux
1920 * Some supposed-to-be Dicom Images have no preamble.
1921 OpenFile takes it into account
1922 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1923 * Missing elements added in dicomV3.dic
1924 (just to be affraid : have a look at
1925 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1926 and do it again next year ;->
1928 2003-10-13 Jean-Pierre Roux
1929 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1930 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1931 But there are NOT. It's fixed !
1933 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1934 * FIX: "jpeglib.h" was not found on VC++
1935 * FIX: vtkgdcm was not being installed
1937 2003-10-10 Jean-Pierre Roux
1938 * ENH : OpenFile closes the file if it *really* doesn't look like
1939 an ACR-NEMA / DICOM one.
1940 * FIX : testWrite no longer writes an empty file if the source file
1941 is not gdcm Readable
1942 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1945 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1946 * FIX: CMake generate now documentation
1947 * ENH: out of source doc build !
1948 * ENH: Generate both user and dev documentation
1949 * ENH: Should work on windows too
1950 * ENH: Only one doxygen config.in file is needed
1951 * FIX: make install should be ok now on ùnix plateform
1952 * FIX: PATH to dictionary was wrong (missing /)
1953 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1955 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1956 * vtkGdcmReader is now able to read rgb dicom file.
1957 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1958 * added a gdcmViewer to vtk test, use mouse to control
1959 window level & window width
1961 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * CMake-ification of gdcm, we have now two build system
1963 * FIX: on cygwin Wsock32 doesn't exist
1964 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1966 2003-10-06 Emanuel Ollart
1967 * FIX : compilation process wad broken.
1968 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1970 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * change gdcmViewer -> vtkgdcmViewer
1972 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1974 2003-10-06 Jean-Pierre Roux
1975 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1976 ( e.g : well known GE images with a wrong elem length,
1977 : Philips MRI Images with a wrong Huffman table)
1978 * still to be done : allow the reading of bugged LEONARDO Siemens images
1980 2003-10-03 Jean-Pierre Roux
1981 * Odd length strings are padded with '\0' (not with spaces,
1982 to remain compliant with already defined strings,
1983 like Transfert Syntax UID and others)
1985 2003-10-03 Jean-Pierre Roux
1986 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1987 to allow displaying RGB images (not only by affim ;-)
1989 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1990 * vtkGdcmReader is now able to read rgb dicom file.
1991 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1993 2003-10-03 Jean-Pierre Roux
1994 * A few nasty patches to allow the reading of a lot of nasty images
1995 ( e.g : well known GE images with a wrong elem length,
1996 : Philips MRI Images with a wrong Huffman table)
1997 * still to be done : allow the reading of bugged LEONARDO Siemens images
1999 2003-10-03 Jean-Pierre Roux
2000 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2002 2003-10-03 Jean-Pierre Roux
2003 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2004 to allow displaying RGB images (not only by affim ;-)
2006 2003-10-03 Jean-Pierre Roux
2007 * gdcmFile::GetImageDataIntoVector now
2008 - deals with MultiFrames MultiFragments Run Length Encoded files
2009 - deals with YcBcR (YBR_FULL) files
2010 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2011 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2013 (no sample found :-(
2015 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2016 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2017 Two reasons: - clear things
2018 - third parties acces gdcm through header files, so won't
2019 suffer anymore VC++ complains
2021 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2022 * add argv[1] in testvtkGdcmReader.cxx
2025 2003-09-24 Jean-Pierre Roux
2026 * The lines are now eigthy characters long.for
2027 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2029 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2030 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2031 char* to std::string. Thus, the use of strdup becomes useless. (see
2032 previous commis of Malaterre)
2033 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2034 before the last Malaterre's commit.
2036 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * This commit should fix the Debug building under VC++, the problem
2038 was mainly a mixture of debug and release lib being loaded at startup.
2039 * I also remove a depency to a specific C function: strdup. Because I had
2040 to force the link to msvcrtd (whereas strdup is in libc).
2042 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2043 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2044 located in the gdcmCommon.h file. All use of reference of tha has been
2045 changed to now use the variable GDCM_UNFOUND.
2047 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2049 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2050 Dicom dictionary. The test suite can now be run again. Note:
2051 I'm note very happy with the " (RET)" changes. I believe this
2052 RETAINED comment should be dropped when parsing the dictionary.
2053 - PACKAGER corrected
2055 - AUTHORS updated and now in alphabetical order
2056 * Makefile.am now exports gdcm.dsw for Windoze users.
2058 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2059 * cygwin complains about missing std:: in subdir Test/
2061 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * remove some methods that are now in gdcmHeaderHelper
2064 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2065 * vtkGdcmReader set spacing and origin correctly
2067 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2068 * Fix a few delete/delete[] mismatch
2070 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2072 interpretation to data given by gdcmHeader. For instance there are
2073 heuristics to get informations (look at different places).
2074 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2075 sorting DICOM images based on different strategies.
2076 * modified Makefiles accordingly.
2078 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2079 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2080 when building in debug mode
2081 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2082 src/win32/gdcmdll.dsp
2083 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2085 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2086 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2089 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2090 * src/win32/libgdcmjpeg12.dsp was not dos format
2091 * src/win32/libgdcmjpeg12.dsp :
2092 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2093 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2095 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2096 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2098 * src/gdcmFile.cxx : bug fix in affectation type
2099 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2100 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2101 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2102 symbols... future problem ?
2104 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2105 * src/win32/libgdcmijpeg12.dsp was missing
2106 * modified gdcm.dsw accordingly
2108 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2109 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2111 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2112 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2113 commit of JPR (before his hollidays to facilitate our work).
2114 * setup.py : bug fix in code. Modifications made while the last commit
2115 of JPR. The code hasn't been tested before the commit... it's so
2116 useless to make that (for best programmer that is JPR) !!!
2118 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2119 * tagged the current version as Version0_3 (i.e. version 0.3)
2121 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2122 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2123 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2124 * *.dsp : modifications to use new libgdcmijpeg8 library
2125 * setup.py : bug fix on VTKPATH variable
2126 * PACKAGER : adding all concerning windows
2128 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2129 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2131 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2132 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2133 test suite reported error.
2134 * PACKAGER file added (describes what a packager must do when
2135 packaging a new release).
2136 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2137 * configure.in: upgraded version number to 0.3.0
2138 * fixing build of rpm (through rpm -ta):
2139 - Doc/Makefile.am exports proper doxygen files
2140 - src/jpeg/libijg8/Makefile.am exports the include files.
2142 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2143 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2144 * src/gdcmHeader.h : formatting code
2146 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2147 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2148 We were obtaining error message from vtk. Now, creation of file list
2149 is made in an internal list to prevent this problem.
2150 Bug fix when output is empty.
2151 Bug fix in update of progress value. Previous commit for this was a bad
2153 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2155 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * src/gdcmHeader.h : added method to get the file name
2157 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2158 files. Added method to remove all files on the input
2159 Added FIXME comment concerning the bad parsing of header made by
2160 ExecuteInformation method (in ExecuteData method)
2162 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2163 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2164 when using make instal.
2165 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2166 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2168 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2169 * setup.py : adding include dir of jpeg lib to compile all sources
2170 * */Win32/*.dsp : JPR fix for windows compilation
2172 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2173 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2175 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2176 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2178 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2179 * setup.py is again effective on un*x (takes into account the
2180 addon of the jpeg library)
2181 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2182 * Doc/Doxy* updated (includes above enhancements)
2183 * INSTALL now points to web documentation
2185 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2186 * src/gdcmHeader.h doesn't make unnecessary reference to
2188 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2190 * src/gdcm*.[cxx|h] :
2191 - to allow compilation with gcc 3.x
2192 -- clean up of STL usage (added explicit usage of std::)
2193 -- small fixes on exceptions.
2194 Note: linking not tested !
2195 - clean of doxygen comments to avoid warnings at documentation
2197 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2198 dependent convertion).
2200 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2201 * Clean up of previous JPR garbage commit (not even commented in the
2203 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2204 - moved all jpeg related files from src to src/jpeg/libijg8, with
2205 addition/modification of Makefile.am and configure.in.
2206 - the testSuite is still brain damage (not guilty).
2208 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2209 * WrapVTK.py : modifications to get correctly vtk source files to
2211 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2212 (FileName -> Filename)
2214 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2215 * vtk/vtkGdcmReader.[cxx/h]:
2216 - UpdateProgress method should now be effective
2217 - removed the limitation on having only images loaded (as opposed
2219 - when building a stack of images/volume, a lesser number of
2220 gdcmHeader and gdcmFile instances should be used (hopefully
2221 accelerating things).
2222 - when building a stack of images/volumes, files which are not
2223 loadable (wrong path-filename, wrong permissions on existing file,
2224 or file not parsable by gdcm) are replaced with a black image
2225 in the stack (for the caller to notice the problem).
2227 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2228 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2230 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2231 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2232 between standard library (std) and vtk library (problems are found
2233 under Windows... thanks Windows !)
2235 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2236 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2238 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2240 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2243 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * When compiling with distutils (see setup.py) the C++ compiler is
2245 called with different flags than the default ones (with automake).
2246 In order to fix all those warning, I compiled gdcm with the command
2247 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2248 and went for warning fixes:
2249 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2250 up from unused variables.
2251 - vtk/vtkGdcmReader.cxx: potential bug fix.
2252 * src/gdcmHeader.h: Doxygen warning cleanup
2254 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2255 * gdcmPython/gdcm.i:
2256 - typemaps correction to take into account the systematic replacement
2257 of "using namespace std" with std:: prefix e.g. std::list,
2258 std::string... (cf changes of 2003-05-21).
2259 - gdcmGlob global variable of type gdcmGlobal (defined in
2260 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2261 exported to Python a as cvar.
2262 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2263 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2264 gdcmDictSet.GetPubDictTagNames() and
2265 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2266 C++ static methods).
2267 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2268 with the above changes.
2270 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2271 * setup.py, manifest.in : bug fix under linux
2273 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2274 * Modification of setup.py to compile vtk part too. Then, we have 2
2275 wrappers which must work with same distutils. For that, we have a
2276 generic distutils in distusiltsWrapping.py ; with :
2277 - build_extWrap class to wrap generically all extensions,
2278 - ExtensionWrap base class for all wrapping extension that contains
2280 - Wrapper interface which wrap sources
2281 + In WrapSwig.py we have extension and wrapper for Swig
2282 + In WrapVTK.py we have extension and wrapper for VTK
2283 * MANIFEST.in : modifications to consider vtk directory and new python
2284 files for compilation
2286 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2287 * Added python wrappers of vtkGdcmReader vtk class (see the
2288 source in vtk/vtkGdcmReader.cxx) :
2289 - vtk/Makefile.am now builds a library
2290 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2291 python library (as opposed to _gdcm.so wich are the python
2292 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2293 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2295 - configure.in has an additional flag --enable-vtk that needs
2296 to be set to enable compilation of vtk related code, that is:
2297 + vtk/vtkGdcmReader.so and
2298 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2299 + gdcmPython/vtkgdcmPython.so (see above)
2300 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2301 be read when compressed or when HighBit + 1 != BitsStored),
2302 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2303 the usage of the python wrapper of vtkGdcmReader vtk class.
2304 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2305 * src/*.[h] all occurences of stl classes are now prefixed with
2306 std::, and all occurences of "using namespace std;" where removed.
2307 This is to avoid pollution of global namespace in included files.
2308 Apparently vtk does not avoid this pitfall: when using both
2309 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2310 collision of various stl members (principally cout...).
2311 * gdcmPython/testSuite.py now cleanly removes temprory generated
2313 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2314 comply with above changes)
2316 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2317 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2318 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2319 vtk data structure (an image Flip was required).
2320 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2321 * cosmetic changes in documentation.
2323 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2324 * src/gdcmHeader.cxx: the constructor no longer exits when an
2325 unexisting file is given as argument.
2326 * The subdirectory Data (containing all the images used for the
2327 test suite) is not part of this repository anymore. A new module
2328 containing those images is now available at
2329 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2330 with the name gdcmData.
2331 All the python scripts (including the package initialisation file
2332 gdcmPython/__init__.py) were adapated to take this change into
2333 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2335 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2336 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2337 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2338 demo of the usage of this class.
2339 Compilation of this vtk part is only done when using the --enable-vtk
2340 at configure (or autogen.sh) stage.
2342 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2343 * More memory link related corrections and documentation fixes.
2345 - maximum info is obtained with a command of the form:
2346 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2347 --show-reachable=yes PrintHeader
2348 - the remaining reachable blocks seem to come from the STL
2349 allocation scheme through the usage of map and list. It looks
2350 like this memory cannot be freed but it is not a memory leak
2351 (in fact further invocation to the STL would recollect the
2352 unused memory allthough it cannot explicitely be freed).
2353 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2354 of displaying an image parsed with gdcm and displayed with VTK.
2355 Note: some images don't seem to work e.g.
2356 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2357 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2358 Allthough this weakens the semantics, it is a ditch attempt to
2359 make gdcm more thread friendly.
2361 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2362 * Memory link hunt (by using valgrind through the command
2363 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2364 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2365 gdcmHeader::_dicom_vr.
2366 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2367 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2369 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2371 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2372 * src/Makefile.am now exports all the necessary include files at
2376 * UpdateGroupLength replaced by new one
2379 * UpdateGroupLength re-written using H-Table
2380 (named UpdateGroupLengthNew untill checks are over)
2382 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2383 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2384 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2386 - gdcmHeader::GetPubElValSet removed.
2387 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2388 UpdateGroupLength, WriteElements, Write.
2389 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2390 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2391 carried the same semantics.
2392 - src/gdcmHeaderIdo.cxx changed accordingly.
2393 - gdcmFile::WriteBase now regroups all the codes from previous
2394 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2395 - enum FileType moved to gdcmCommon.h
2396 * src/gdcmHeader.cxx AddDefault trashed
2397 * gdcmGetXSize added
2398 * getimageDataSize now calls gdcmGetXSize
2399 * Test/*.cxx changed to agree with above changes
2401 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2402 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2403 (to avoid double call by end user).
2404 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2405 by end user, since gdcmHeader::gdcmHeader now handles it.
2407 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2408 * gdcm/Doc many doxygen changes:
2409 - Doxyfile now has two different versions, DoxyfileUsers that generates
2410 the html.users end users oriented documentation and
2411 DoxyfileDeveloppers that generates the html.developper developper
2412 oriented documentation.
2413 - README changed accordingly
2414 - requirement.txt removed (old design info moved to TODO).
2415 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2416 DoxyMainPage.txt, DoxyPython.txt provide more information.
2417 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2418 be updated by simply regenerating the docs with doxygen and copying
2419 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2420 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2421 all the tests in the form "if (<map>.count() >1)" were removed.
2422 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2423 ill-formed documentation sections.
2424 * src/gdcmHeader.cxx: ditto
2426 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2427 * setup.py fixed for un*x (needed macro for stdint.h)
2428 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2429 un*ces with sh-utils test utility.
2430 * gdcmPython/demo/test.py renamed to PrintHeader.py
2431 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2432 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2433 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2434 * src/gdcm*.cxx JPR's bad inclusion fixed.
2436 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2437 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2438 * gdcmPython/demo/test.py changed accordingly.
2440 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2441 * gdcmPython/Makefile.am fixed linking against libstdc++
2442 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2443 * Swig subdir (historical tests of swig version 1.3.17++) removed
2444 * Test/testChangeEntete.cxx some lines commented out in order to make
2446 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2447 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2449 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2450 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2451 hence the user doesn't need this explicit call.
2452 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2453 i.e. LoadElements() call removed.
2454 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2455 - src/Makefile.am declares the proper flag for g++.
2456 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2457 for adding user defined new tags.
2458 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2459 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2460 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2462 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2463 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2464 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2465 src/Makefile.am : the project should properly compile and install
2466 with the autotools, included the python wrappers part.
2467 * gdcm.spec.in : added a spec file for RPM packaging.
2469 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2470 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2472 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2473 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2474 to exported to the environement (see gdcmPython/testSuite.py
2476 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2477 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2478 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2479 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2480 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2482 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * gdcmPython/__init__.py doesn't crash anymore when running in
2484 in InstallMode or PreInstallMode but with an environement given
2485 value of GDCM_DICT_PATH.
2486 * src/gdcmDictSet.[cxx/h] coding style.
2488 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2490 * src/gdcm.h general comments moved to TODO, and README
2491 * src/gdcm.h should now be seen as a user commodity (including it
2492 should suffice to fully use gdcm). It is nowhere including within
2493 any of the kernel files src/*.cxx and src/*.h.
2495 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2496 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2497 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2499 * src/gdcm*.cxx only include their corresponding include file
2500 (as opposed to gdcm.h)
2501 * gdcmPython/gdcm.i changed accordingly
2502 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2503 the autogen.sh generated "make snapshot" command to work.
2504 * autogen.sh removed history related references to crea package.
2506 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2507 * distutilsSwigCPlusPlus.py work around some swig portability
2510 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2512 was done in a last ditch attempt to get setup.py _really_
2513 operationnal. The python/gdcmPython layaout add the advantage
2514 of hidding away the python related distutils specific files
2515 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2516 Alas, the src directory was out of scope (i.e. it's relative
2517 position to setup.py was ../src) which made things impossible to
2518 handle (see previous version of python/setup.py). Crossing fingers...
2520 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * python/setup.py now works on Un*x. (harder than I thougth)
2522 * python/distutilsSwigCPlusPlus.py can now have include files
2523 among the list of sources.
2525 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2526 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2527 * modifications in MSVC projects
2529 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2530 * As stated by the first lines of Test/ExceptionAndPython/README, it
2531 looks like we can move back to original usage of exception within
2532 src/gdcm* and hence remove the errno stuff that was introduced
2533 as a quick and dirty fixture of this problem (added to the TODO).
2534 * Doc/Doxyfile configuration file for Doxygen and corresponding
2535 README file for usage added.
2536 * Test/testWrite.cxx added. This new test comes from a split of
2537 test.cxx that is now reverted to its original purpous i.e.
2538 testing the proper parsing of a Dicom related file.
2539 testWrite.cxx concentrates on testing the IO part of gdcm.
2540 * Test/bug1.cxx (containing a bug on WIn32) added.
2541 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2542 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2543 whose purpose is to publish the content of the TagNames of the
2544 Dicom public dictionnary were not accessible without an
2545 instance of class gdcmHeader.
2546 - those methods are now static methods of gdcmDictSet and hence
2547 require no instances at all to be invocated.
2548 - within gdcmDictSet this change required to change some method
2549 to class methods (i.e. are now static) among which SetDictPath
2550 (renamed to BuildDictPath) and LoadDefaultPubDict.
2551 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2552 the above changes by calling the new method classes of gdcmDictSet.
2553 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2554 the above to be effective.
2555 * python/gdcmPython: in order to wrap properly the above changes
2556 for Python, swig version now needs to be > 1.3.17.
2557 * python/gdcmPython/Makefile fixed to adapt itself to new
2558 configure/make shema introduced by Johan Montagnat (thanks for the
2559 contribution). Alas this Makefile cannot be turned into a proper
2560 Makefile.am without some heavy changes in the configure.in
2561 (for python dectection).
2562 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2563 now avoids publishing the empty entries.
2565 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2566 * python/setup.py : bug fix concerning install under windows
2567 ExtraPath reused :-P
2568 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2570 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2571 * Dicts/dicomV3.dic : remove double spaces !!!
2572 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2573 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2576 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2578 method. Doxygenation.
2579 * src/gdcm.h clean up of JPR spurious comments.
2581 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2582 * python/distutilsSwigCPlusPlus.py now properly collects the
2583 shadow classes generated by "swig -c++" (gdcm.py in our case)
2584 when using "python setup.py install".
2585 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2586 reexports the working classes.
2587 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2588 by the classical C errno scheme. This is to prevent an obscure
2589 behavior of the python wrappers when importing wxPython.wx prior
2590 to gdcmPython (which ended up in an abort call). An illustration
2591 of this oddity can be found in the Test/ExceptionAndPython
2592 subdir (see the README file). This problem probably due to
2593 an combination of g++ and dynamic loading.
2594 * added Test/ExceptionAndPython (see above)
2596 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2597 * Changed the layout of the python part to avoid bloating main
2598 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2599 i.e. the distutils arsenal. All the python related stuff is
2600 again in a python subdir, but the package itself is now in
2602 * setup.py was cleaned up:
2603 - pythonIncludePath removed
2604 - python setup.py bdist target is now functional.
2605 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2606 collision with other packages). gdcmPython/demo/*.py changed
2609 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * python subdir moved to gdcmPython (preparation of distutils packaging).
2611 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2612 distutils installer is operational.
2613 * - gdcmPython/__init__.py now properly loads the swig generated
2614 shadow classes (from gdcm.py).
2615 - gdcmPython/demo/*.py changed to import the package gdcmPython
2616 instead of gdcmPython/demo/load.py.
2617 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2619 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2620 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2621 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2622 entries within the associated public Dicom dictionary resp. the same
2623 information but sorted by the fourth field (PAT, IMG, DIR) of the
2625 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2626 are now in the "???" group.
2627 - python/gdcm.i changed accordingly,
2628 - python/demo/printGroupedPublicDict.py added, that gives an example
2629 of the above new functionalities in Python.
2631 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * src/gdcm.h, gdcmHeader.cxx:
2633 - historic references to glib's g_malloc and g_free (#defined)
2634 were definitively removed.
2635 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2636 * src/gdcmElValSet.cxx:
2637 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2638 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2639 - GetElValue(string) renamed to GetElValueByName.
2640 - Added GetElementByName(string).
2641 * src/gdcmHeader.cxx: added
2642 - GetPubElValRepByNumber(guint16, guint16)
2643 - GetPubElValRepByName(string)
2644 - GetShaElValRepByNumber(guint16, guint16)
2645 - GetShaElValRepByName(string)
2646 - GetShaElValByNumber(guint16, guint16)
2647 - GetShaElValRepByName(string)
2648 - GetElValRepByNumber(guint16, guint16)
2649 - GetElValRepByName(string)
2650 - GetElValByNumber(guint16, guint16)
2651 - GetElValRepByName(string)
2652 * Doc/requirements.txt added.
2654 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2655 * Test/Makefile building now depends on the one of libgdcm.so
2656 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2657 pixel data) aware which enables finding the address (offset) of
2658 the pixel data of JPEG encoded DICOM files. This leaves only a single
2659 file in the testSuite whose pixel data address (offset) is unknown.
2660 * python/testSuite.py changed accordingly.
2662 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2663 * VC++ has some strong limitations when working with the STL, as stated
2664 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2665 "Also note that some STL containers (map, set, queue, list, deque)
2666 cannot be exported. [...]
2667 Some STL classes contain nested classes. These classes can not
2669 This is caused by a designed limitation that once a template
2670 class is instantiated, it can not be re-instantiated and
2672 Since our usage of map<> is ubiquitous in gdcm, this "designed
2673 limitation" of VC++ is a pitfall.
2674 Hence the Python wrappers of gdcm cannot be incrementally linked
2675 against the c++ dynamic library. The dirty but only workaround is
2676 to forget about incremental link of dynamic libraries and to generate
2677 the Python wrappers library with the inclusions of the underlying C++
2679 The following modifications concern this matter on Win32/VC++:
2680 - wrapping python correct with standalone wrapped dll (don't use separate
2681 dll under windows !!!!)
2682 - python21_d debug mode enabled (ask Frog how to use it :-)
2683 - NO problem with having an STL member of class for example string in C++
2684 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2685 - Python test of dcmlib in Python is ok under windows on a large set
2687 * removed glib references
2688 * typedef's inserted in gdcm.i for correct swig type management
2690 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * python/demo/*.py load.py extracted from test.py. Added explore.py
2692 that only displays required tags and testAll.py that parses all
2693 the files of the testsuite without using unittest.
2694 * python/testSuite.py other additional test on new files added.
2695 * Data/* new test files added accordingly to the testSuite.
2696 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2697 the vr in the file differs from the one of the dictionary.
2699 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2700 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2701 values, but limits itself to values which are below a user specified
2702 size (by default 1024 bytes).
2703 * python/gdcm.i : elements not loaded (because their size is above the
2704 user specified treshold) are exported with their TagKey as key of the
2705 python dictionary. This enables the testsuite to make some checks
2706 on the unloaded elements (since we have their offset and size).
2707 * python/testSuite.py
2708 - now tests for the existence and proper value of the pixel data
2709 - two new examples added.
2710 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2712 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2714 aware. See the strategy comments in gdcmHeader::FindeLength().
2715 * Test/test.cxx now accepts a filename as first argument.
2716 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2717 * python/testSuite.py changed to integrate test on above files.
2719 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2720 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2721 the vr was also RET.
2722 * python/testSuite.py more tests added.
2724 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * python/testSuite.py unittest test suite added (uses Data)
2726 * Data/* dcm and acr files for the test suite.
2727 * glib dependance removed from un*x version. We now use ISO C99
2728 7.18 Integer types (see stdint.h)
2729 - python/Makefile, src/Makefile src/gdcm.h
2730 * src/ when an explicit vr (like dicom files) suddenly poped an
2731 implicit element we use to mark the underlying DictEntry of the
2732 concerned ElValue with "Implicit". This strategy was damageable
2733 too the public or provite dictionaries, since some of their vr
2734 would be changed. Since Header::FindLength heavily relies on the
2735 detection by Header::FindVR of falsely explicit elements, I
2736 added an extra ImplicitVr member to ElValue (boolean).
2737 The rest of the changes we the necessary adaptations.
2739 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2740 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2742 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2744 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * Adaptation for porting to VC++:
2747 o forced to use std namespace (for string to be known)
2748 o all class use __declspec export style on WIN32
2749 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2750 (in stdlib.h on Win32 but in std:: for gcc)
2751 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2752 variable GDCM_DICT_PATH.
2753 * src/gdcmHeader.cxx verbose comments made discrete.
2755 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2756 * python/gdcm.i: added a typemap that converts a C++ hashing table
2757 to native Python dictionary.
2758 * python/demo/test.py:
2759 - now uses the native dictionary for exploration of gdcmHeader.
2760 - takes an optional filename argument (the file to parse).
2761 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2762 PubElVals hashing table.
2763 * Dicts/dicomV3.dic removed error prone trailing spaces.
2765 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2766 * Python wrapping process moved away from src/Makefile to
2767 newly created python/Makefile (as well as gdcm.i)
2768 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2769 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2770 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2771 from the environement variable GDCM_DICT_PATH (when existing).
2772 * src/gdcmDict::GetTag bug fix.
2774 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2775 * Straightforward temporary fixes for swig to build the python wrappers.
2776 src/Makefile now has a python working entry [by working we mean
2777 that we can import de shadow classes without errors].
2779 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * hashtest.cxx removed (since allready in Test)
2781 * src/gdcmlib.h renamed to src/gdcm.h
2782 * src/dcm.i renamed to src/gdcm.i
2783 * src/Makefile prepared for python wrapping
2785 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2786 * src/gdcmHeader.cxx :
2787 - Parsing of header is now separated from loading of element values
2788 (see gdcmHeader::LoadElements).
2789 - general clean up of hopefully all file access (creation of
2790 ReadInt16 and ReadInt32)
2792 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2793 * src/gdcmHeader.cxx :
2794 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2796 - SetLgrElem renamed to SetLength
2797 - GetLgrElem renamed to GetLength
2798 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2799 * src/gdcmElValSet.cxx fixed both GetElValue methods
2800 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2801 due to IdoDude was cleaned out.
2803 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2804 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2805 concentrates on finding the value representation (when it exists).
2806 RecupLgr now only finds the element value length, and it avoids
2807 returning the unecessary skL (skipped length).
2808 Also, offsetCourant was simply removed (with taille_fich) since
2809 it was redundant with the File position internals (by using
2810 ftell and fseek). This also made skL (see above in RecupLgr) usage
2812 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2813 on the libido specificities which are handled through class
2815 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2818 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2819 * Truckload of changes. Parsing of header is barely functional
2820 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2822 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2823 * src/gdcmHeader.cxx many addons of low level methods
2825 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2827 and _IdDcmSWAP_LONG.
2829 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2830 * This corresponds to all the changes decided at the meeting of
2831 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob