1 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmFile.cxx : now delete the PixelConvert instance.
3 * In examples and tests : change the type of image data variables from void*
4 to uint8_t*. Remmove all delete on image data variables
6 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
8 Verify the file pointer value before open the file, and if it's not null,
9 a verbose message is generated.
10 Close correctly the file when the file isn't considered dicom-like. The
11 correctly close is a call to CloseFile.
12 When closing the file pointer, test if its not null to close the file.
13 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
14 file. For an uncompressed image, the copied datas correspond in the least
15 case to the image size (calculated) or the image size specified in the
16 header. A verbose is generated if these two size mismatch
18 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
19 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
20 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
21 break under windows (with msvc6 compilation).
23 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
27 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
28 * Bugs fix for the Windows build with VC6
29 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
30 needed (only for projects required VTK). If the VTK is included in all
31 projects, there is conflicts with the jpeg lib of vtk when compiling the
32 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
33 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
34 when compiling the gdcm_wrap.cxx file (created by the compilation of the
36 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
37 (like it's already made for the cout use). Otherwise, conflict with the
40 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
41 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
43 - comments on the DicomDir::Method related usage added.
44 - now that we use the namespace gdcm, a lot of internal classes do
45 NOT need to be wrapped anymore.
46 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
47 DicomDir::Method) new example added.
49 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
50 * Improve string manipulation. I now inforce the notion of 'DicomString'
51 A DicomString can contain as many \0 as they want
52 and it is *always* of even length.
53 We only support odd length for very rare case.
54 And in the near future this should be removed.
56 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
57 * /binary_write/ gdcm source. Now even on big endian we are writting
58 little endian. This should -heopfully- fix some tests
60 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
61 * Now the dictionary is compiled into gdcm lib. This is a default
62 behavior, thus any dic file specified is picked before failback to
63 the one comiled into lib
65 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
66 * Change internals for gdcmDict. Don't use any 'new' any more.
67 This should definitely solve any leak problem, and we should be
68 as fast as before, as long as don't modify too much the dictionary.
70 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * STYLE: ivars should start with a capital letter.
72 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
73 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
75 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
76 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
77 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
78 new 2004 dictionaries added (thanks to JPR).
79 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
80 * CLEANUP_ROUND (15) for gdcmPixelConvert
81 - RLEFrame::NumberFragments is now of type unsigned int
82 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
83 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
86 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
87 * Initial work in gathering all transfer syntax accessors. clearly
88 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
89 ivars, but only one transfersyntax (class) ivar with equivalent method on
92 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
93 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
94 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
95 discussed (plus I didn't like having a 2000 lines patch not commited)
97 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
98 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
99 * CLEANUP_ROUND (14) for gdcmPixelConvert
100 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
101 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
102 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
104 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
105 anymore and hence avoids storing a copy of PixelConvert::Decompressed
106 into File::Pixel_Data.
108 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
109 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
110 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
111 * CLEANUP_ROUND (13) for gdcmPixelConvert
112 Substituted File::ParsePixelData() with PixelConvert::Print() new
114 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
115 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
116 method to those classes.
117 - src/gdcmFile.[cxx|h]:
118 -- Added a ::Print() method.
119 -- PixelConverter is now a reference instead of a member.
120 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
121 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
123 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
124 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
125 collaboration diagram and inheritance diagram should be generated with
127 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
128 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
129 pointlessly wrapped (see
130 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
131 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
132 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
133 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
134 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
135 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
136 -- File::Initialise: PixelConverter setup moved away to
137 PixelConverter::GrabInformationsFromHeader()
138 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
139 interpretation moved away to PixelConverter::BuildRGBImage()
141 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
142 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
143 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
145 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
146 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
147 displayed on Win32 when a brutal abort() occurs (because of uncatched
148 exception). See TODO new entry of this commit for more on this.
149 * TODO added new entry.
150 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
151 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
152 - HandleColor is no longer called from gdcmFile.cxx
153 - gdcmPixelConvert.cxx clean up on method arguments and internal
154 variable names for semantical coherence.
156 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
157 * Finished lossless transition, not only do we now read all lossless jpeg
158 images, without the need of the Cornwell lib, but we do read them properly now
159 * To reduce code (well to avoid code duplication), I defined a common place
160 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
161 redefine symbols. This is not prefect but this the best solution I found for a
162 compilation time jpeg option.
164 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
165 * Update jpeg ijg lib to support lossless jpeg implementation
166 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
168 * Also added a special copyright for dcmtk since we use their bugfixes.
171 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
172 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
173 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
174 matters, as stated in warning note at begining of %include section).
175 * src/gdcmDicomDir*.[cxx|h]: coding style
176 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
177 * src/gdcmJpeg8.cxx: doxygen fix.
178 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
179 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
180 from File:: to PixelConvert::.
182 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
183 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
184 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
185 - more code moved away from File:: to PixelConvert::
186 - fat setup of PixelConverter set in place in File::Initialise.
188 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
189 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
190 namespace at the file system level. So now you should convert your examples
192 gdcmHeader -> gdcm::Header
193 It would be nice if people keep in mind to no open the namespace, since it
194 allows compilation on broken plateform which were defining common symbol in
195 the standart namespace (like LP, Unknown ...)
197 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
198 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
199 The JPEG fragments are now parsed at the same stage than the RLE
200 information. All code related to JPEG is now in gdcmPixelConvert:
201 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
202 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
203 export a gdcmFile:: method. Those are simply global functions
204 (for the time being this is better than having them attach to
205 either gdcmFile:: or gdcmPixelConvert::).
206 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
207 and stores the result in a gdcmJPEGFragmentsInfo.
208 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
209 code (among other stuff) moved away from gdcmFile:; to
212 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
214 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
215 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
216 clean up of RLE related code.
217 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
218 - src/gdcmRLE.cxx removed
219 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
220 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
221 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
222 * CLEANUP_ROUND (9) for gdcmPixelConvert
223 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
224 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
225 away from gdcmFile:: to gdcmPixelConvert::.
227 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
228 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
229 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
230 This is because Parse7Fe0 used to parse the pixels to compute the
231 length. This task was passed over to FindDocEntryLengthOB() a long
232 time ago, EXCEPT I had forgotten the OW case...
233 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
234 we just recylce the code for parsing RLE fragments and computing
236 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
237 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
238 with the retired Parse7Fe0().
239 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
240 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
242 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
243 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
244 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
245 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
246 - src/CMakeLists.txt: alphabetic order reodering + new entries.
247 * CLEANUP_ROUND (4) for gdcmPixelConvert
248 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
249 to return an unused length.
251 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
252 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
253 this should be cleanner from the plane view. The iostream are erally a pain
254 to use to do simple stuff.
256 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
257 * Redo the compilation of the ijg jpeg library. Now only one source is
258 necesseray. No need to rename file by hand what so ever. CMake handle the
259 copying of the file within different directory, configure header file to
260 modify some symbol. The only addition made to ijg wasd a mangle table so
261 that symbol are different wether we are within 8bits or 12bits.
263 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Added documentation of vtkgdcmReader on Website:
265 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
266 with it's binary name).
267 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
268 the Website to be more complete.
269 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
270 doxygenated documentation.
271 - Doc/DoxyVtkGdcmReaderExamples.txt added
272 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
273 DoxyVtkGdmReaderExamples.html )
274 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
275 * CLEANUP_ROUND (3) for gdcmPixelConvert
276 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
278 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
279 * CLEANUP_ROUND (2) for gdcmPixelConvert
280 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
282 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
283 * CLEANUP_ROUND for gdcmPixelConvert:
284 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
285 - src/gdcmPixelStuff[h|cxx] removed
286 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
287 - src/CMakeLists.txt changed accordingly
289 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
290 gdcmVersion.py moved to newly created ATTIC related
291 gdcmPython/SetupOldies/ directory.
292 * Autotools clean up:
293 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
294 - autogen.sh configure.in acinclude.m4 python.m4 removed
296 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * src/*.cxx *.h Reference to License.htm fixed to License.html.
298 * Doc/CMakeLists.txt, doxygen.config.in: fix.
299 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
301 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
302 * TODO updated with Mathieu suggestions. I proposed a template for
303 describing TODO entries and used it for new entries.
304 * Added Doc/Website/CodingStyle.html, Developpers.html,
305 DeveloppersPython.html, GdcmDataCvs.html and
306 DownloadVersion0_1.html, DownloadVersion0_3.html.
307 * Some Doc/*.txt Doxygen files (which do not really concern the
308 documentation itself, but the website) moved to html and
309 placed in directory Doc/Website:
310 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
311 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
312 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
313 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
314 * CMakeLists.txt changed accordingly.
315 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
316 DeveloppersPython.html
317 * INSTALL nows refers to Doc/Website/Installation.html
319 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
320 * Added Doc/Website directory, that contains a first raw version
323 2004-09-23 Jean-Pierre Roux
324 * FIX In order not to be poluted any longer by casting problems,
325 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
326 we can now delete[] it safely
327 * VoidArea is now called BinArea (less confusing name),
328 and all the methods called ...VoidArea... are now ... BinArea...
329 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
331 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
332 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
333 clear) TagHT, which is an inherited member of gdcmElementSet. It is
334 up to the destructor of gdcmElementSet to clean up TagHt and it's
337 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
338 * Test/CMakeLists.txt: update to follow gdcmData renamings.
339 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
341 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
342 * ENH: added some utility method that builds a flat dictionnary
343 holding all the Dicom entries contained in the recursive structure
344 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
346 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
347 BuildFlatHashTable() that build a flat dictionary.
348 - src/gdcmElementSet.h: added a new private GetTag() accessor.
349 gdcmDocument is now a friend of gdcmElementSet.
350 - src/gdcmElementSet.cxx: clean up.
351 - Example/FlatHashTablePrint.cxx added.
352 - Example/CmakeLists.txt changed accordingly
354 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
356 moved away from gdcmDocEntrySet (since this class is an abstract class
357 acting like an interface). SQDepthLevel and BaseTagKey are now
359 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
360 and associated accessors. Doxygenation of the class.
361 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
363 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
364 Use SQDepthLevel accessor instead. ::Print() adapted.
365 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
366 - src/gdcmDocument.cxx changed accordingly.
368 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
370 - The following is the doxygen comment of the typedef declaration
371 of gdcmagKey in src/gdcmCommon.h:
372 gdcmTagKey is made to old an "universal" (as in URL, Universal
373 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
374 A dicom tag allways has a group and an element, but a set of tags
375 embeded in various (optionally nested) sequences and sharing
376 the same group and element all share the same (group, element)
377 "identifier". Hence the (group, element) cannot be used as an
378 identifier (in gdcm we shall refer to a "TagKey") of a tag.
379 In order to construct a proper tag identifier (i.e. a key) we
380 consider the following definition of a TagKey:
381 - let Group, Element be the string representation of the
382 group and element dicom tag members,
383 - let ItemNumber be the string representation of the integer
384 index of the considered item number of a sequence,
385 Let the key of a tag embeded in a sequence, noted SeqTag, be
387 /ItemNumber#Group|Element
388 where "/", "#" and "|" are characters acting as separators.
389 Then the general form of a gdcmTagKey is given by:
390 Group|Element<SeqTag>
391 where <SeqTag> means NO or many instances of SeqTag.
392 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
395 but the gdcmTagKey of a tag "embeded" is the first item of
396 a sequence, itself nested in the third item of a sequence is the
398 0004|1220/2#0008|0082/0#0008|0090
399 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
400 order to hold the new sequence compatible key. Previously, the
401 GetKey() method would look in the underlying gdcmDictEntry.
402 - src/gdcmDocEntry.cxx:
403 -- constructor now copies the underlying DictEntry key, in the local
405 -- ::Print: displays the member Key, instead of the (group, element).
406 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
407 - src/gdcmDocEntrySet.h:xi
408 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
409 -- now has a new BaseTagKey member.
411 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
412 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
414 This poses the problem with the semantics of the following lines
415 LoadEntryVoidArea(0x0028,0x1201); // R LUT
416 LoadEntryVoidArea(0x0028,0x1202); // G LUT
417 LoadEntryVoidArea(0x0028,0x1203); // B LUT
418 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
419 to the long FIXME note for what the problem is. Nevertheless in
420 order to get things working the dicom dictionary was altered !
421 Please fix things urgently...
422 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
423 information), see above note on moving the member VoidArea. Nevertheless
424 the following entries previously correctly set as US are now inproperly
426 0028 1201 OW IMG Red Palette Color Lookup Table Data
427 0028 1202 OW IMG Green Palette Color Lookup Table Data
428 0028 1203 OW IMG Blue Palette Color Lookup Table Data
429 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
430 of gdcmDocEntry moved to gdcmSeqEntry.
431 * src/gdcmSeqEntry.cxx: STYLE.
433 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
434 * Test/TestAllEntryVerify.cxx minor fix and added comments.
436 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
437 * gdcmPython/testSuite.py: all the test suite in python is now moved
438 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
439 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
440 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
442 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
443 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
444 to avoid inclusion recursion until STL is reached.
445 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
446 mecanism. errno.h is not included in gdcm anymore.
447 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
448 (gdcmFormatError now inherits from gdcmFormatUnexpected).
450 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
451 gdcmData/TestAllEntryVerifyReference.txt
452 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
453 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
454 exception_on_error parameter.
455 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
456 - vtk/vtkGdcmReader.cxx changed accordingly,
457 - Example/*.cxx and Test/*.cxx changed accordingly.
459 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
461 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
462 enable_sequences removed from gdcmHeader constructor and dependencies.
463 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
464 * gdcmPython/demo/PrintHeader.py: dummy fix.
465 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
466 skip_shadow removed from gdcmHeader constructor and dependencies.
467 * Example/*.cxx and Test/*.cxx changed accordingly.
469 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
470 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
471 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
473 2004-07-21 Jean-Pierre Roux
474 * FIX Now, Parsing and Printing a DICOMDIR do work!
475 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
477 2004-07-20 Jean-Pierre Roux
478 * FIX Some brain damaged headers have Zero-Lenght fields
479 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
481 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
482 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
483 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
484 variable (instance of gdcmDebug) by a definition macro, and the instance
485 is now in static in the gdcmDebug class
486 * src/gdcmSQItem.h : (FIXME) remove an undefined method
487 * Test/PrintAllDocument.cxx : bug fix in the result of the test
489 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * WARNING: ctest now depends more tightly on gdcmData. You should
491 check out gdcmData properly for things to run smoothly...
492 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
493 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
494 we need the pixels not be loaded in order to use the ValEntry
495 that displays position and size).
496 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
497 This is a C++ based equivalent of gdcmPython/testSuite.py that should
498 be deprecated. If you have any doubts about the advantages of a
499 modern scripting language (read Python) versus grass root C++ (i.e.
500 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
501 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
502 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
503 Anyhow, consider documenting the gdcmData images in
504 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
506 * Test/CMakeLists.txt:
507 - now uses TestAllEntryVerify.cxx
508 - specific comments on oldACR00001.ima (now renamed in gdcmData
509 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
510 gdcmData/TestAllEntryVerifyReference.txt
513 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * src/*.[h|cxx] : typedef clean up
515 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
516 - TagKey renamed to gdcmTagKey (for external usage)
517 - VRKey renamed to gdcmVRKey (for external usage)
518 - removal of typedef duplication.
519 - Removed all unecessary inline keyword from class inline definitions.
520 - Some method|function(void) declarations replaced with method|function().
521 * src/jpeg/libijg12/jdhuff12.c:
522 - printf polluting ctest removed.
523 - TAB removal for comminting
525 - TestAllReadCompareDicom.cxx: added a test that compares all the
526 images in gdcmDataImages.h with corresponding images in
527 gdcmData/BaselineDicom/. When baseline images are not present
528 this test creates them.
529 Note: we need to validate each reference image, but before that
530 I'd like to rename them with a more explicit name...
531 - CMakeLists.txt: changed accordingly.
532 * Example/*.cxx: examples now only include gdcm.h (as opposed to
533 including each header needed).
535 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * Test/*.cxx and Example/*.cxx: moved some examples away from the
537 test suite to the Example directory. Are concerned:
542 - TestWriteSimple.cxx
543 * Test/CMakeLists.txt: added some comments on reasons for black listing
544 image gdcmData/oldACR00001.ima
546 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
547 * Test/CmakeList.txt: removed the following from black list (to be coherent
548 with removal from gdcmData):
549 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
550 - gdcm-MR-PHILIPS-16.dcm
552 Added the following because after last cvs update, they cause
553 ctest -R TestReadWriteReadCompare
555 - gdcm-MR-SIEMENS-16-1.acr
557 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
558 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
559 new comments in this file) we temporarily (sigh) move to a weaker
561 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
562 we don't need to black list the following images anymore:
563 - 8BitsUncompressedColor.dcm
565 - US-PAL-8-10x-echo.dcm
566 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
567 fixes and the beautified code ;-)
568 This fixes the bug introduced in version 1.42 (when beautifying)
569 that made the parsing of 8BitsRunLengthColor.dcm unproper.
570 Note: ctest was blind to this bug (this means we need to still
571 improve the test suite). The bug could be detected by using
572 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
574 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
575 and by displaying the (garbage) produced file temp.XDCM...
577 2004-06-29 Jean-Pierre Roux
578 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
579 - replace by uggly but working old code :-(
580 A lot of things should be OK again.
581 It's really urgent to have a test suite that *tests*,
582 to prevent Frog's beautifying sessions to break all the stuff
583 (twice, withing a fortnigh ...)
585 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
586 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
587 redundancy) to added Test/TestReadWriteReadCompare.cxx
588 * Test/CmakeList.txt: because the compare test of
589 Test/TestReadWriteReadCompare.cxx fails, the following images are
590 black listed: - 8BitsUncompressedColor.dcm
592 - US-PAL-8-10x-echo.dcm
593 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
594 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
595 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
596 and ad-hoc kludge. This kludge is now removed, and on encountering
597 such an image (OB field brain damaged) we set errno. Then in
598 ::FindDocLength() we "fix" the length as being ALL what remains
599 in the file (until EOF). We then proceed, hoping for the best...
600 This fixes a SegFault in ShowDicom when trying to write such an
602 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
603 (because TestWriteRead breaks on it, after a non conformal commit?).
604 ctest now runs properly, except for MakeDicomDir (which was allways
605 broken) and the Python related stuff (still not fixed).
607 2004-06-24 Jean-Pierre Roux
608 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
609 FIX : Test/TestReadWrite now iterates on all the file names
610 (instead of infinite loop)
611 ENH : Test/TestWriteRead now iterates on all the file names
613 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
614 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
616 2004-06-24 Jean-Pierre Roux
617 FIX : - now Write drops LUT Descriptors and LUTs (if any)
618 when SamplesPerPixel =3
619 - now Write is no longer confused by
620 'BitsAllocated = 12" and 'BitsStored=12"
621 - "UN" value representation Elements are now written correctly
622 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
623 ENH : - now gdcmHeader has its own Write methods
624 (in order to split the job that has not to be done
627 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
629 loop on the same image until memory went out.
630 Note: this means we still have gobs of memory loss in PrintDocument
631 * src/gdcmDocument.cxx: fixes problem on parsing on file
632 gdcmData/16BitsJpegLosslessGrayScale.dcm.
634 2004-06-24 Jean-Pierre Roux
635 FIX : Write - All the Sequences and Sequence Item are now written
636 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
637 is added a the end, when necessary.
638 - A lot of brain-damaged images, that were read correctly are
639 now written correctly
640 - length compatible BinEntry are now loaded correctly
641 (even for odd groups)
642 Note : only Explicit Value Representation was checked.
643 (question : is implicit VR really necessary for gdcm ?)
645 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * DEVELOPPER: added a proposition of coding style.
647 * src/gdcmDocEntry.h: removed every inline declaration (for test of
650 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
651 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
652 Use the gdcmDocEntry::Print() and Write() instead.
653 * src/gdcmDocument.cxx: bug fix.
655 2004-06-22 Jean-Pierre Roux
656 FIX : gdcmDocument.cxx
657 - Now we do recognize the JpegLossLess format (there was a misstyping in
658 code 'beautyfication' :-(
659 - Now we automaticaticaly load the Luts, if any
661 2004-06-22 Jean-Pierre Roux
662 In order : to write Sequences, whatever their imbrication level,
663 : to allow user to create his own Sequences
664 a lot of modif where necessary (adding, moving, or virtualising methods)
666 WARNING : save your own sources *before* cvs up !
669 ADD virtual void Write(FILE *fp, FileType filetype);
672 ADD virtual void Write(FILE *fp, FileType filetype);
673 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
676 ADD virtual void Write (FILE *fp, FileType filetype)=0;
677 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
678 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
679 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
680 ADD std::string GetEntryByName(TagName name);
681 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
683 std::string vr = "unkn",
684 std::string fourth = "unkn",
685 std::string name = "unkn");
686 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
687 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
688 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
689 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
690 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
691 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
692 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
693 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
696 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
697 ADD virtual std::string GetEntryByName (TagName tagName);
698 ADD virtual std::string GetEntryVRByName (TagName tagName);
699 REM virtual bool Write(FILE *, FileType);
700 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
701 FILE *_fp, FileType type);
702 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
703 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
704 REM virtual bool WriteEntries(FILE *_fp,FileType type);
705 REM virtual std::string GetEntryByName (std::string tagName);
706 REM virtual std::string GetEntryVRByName (std::string tagName);
707 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
708 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
709 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
711 std::string vr = "unkn",
712 std::string fourth = "unkn",
713 std::string name = "unkn");
714 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
715 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
716 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
717 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
720 ADD virtual void Write(FILE *fp, FileType filetype);
723 ADD virtual void Write(FILE *fp,FileType filetype);
726 ADD virtual void Write(FILE *fp, FileType filetype);
727 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
728 REM std::string GetEntryByNumber(guint16 group, guint16 element);
729 REM std::string GetEntryByName(TagName name);
732 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
734 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
736 The default constructor invoked by the line
737 gdcmHeader *f1 = new gdcmHeader( header );
738 was gdcmHeader::gdcmHeader(bool) instead of the expected
739 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
740 Hence the parsing wasn't executed... See also below.
741 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
742 as explicit constructor didn't do the trick to fix the above problem.
743 Could anyone explain why ?
744 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
745 properly calls gdcmValEntry::Print() (that was weed out from
746 code related to gdcmBinEntry).
748 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
749 * In order to fix memory leaks:
750 - Test/TestWriteSimple.cxx: added cleaning of free store through
752 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
753 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
754 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
755 (through the call to ::AddDicomDirMeta()) or the destructor
756 would crash when deleting uninitialized ::metaElems].
757 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
758 - src/gdcmDocument.cxx:
759 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
761 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
762 was causing memory leaks.
763 - src/gdcmSQItem.cxx:
764 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
765 cleanly handled with polymophism: sorry but my milage is low).
766 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
767 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
768 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
769 This avoids SegFaulting.
770 - src/gdcmSQItem.h: coding style.
772 - Test/TestWriteSimple still severely sucks. The output image content
773 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
774 damaged when displayed with vtkgdcmViewer.
775 - on memory leaks: TestWriteSimple leaks really less (see entry
776 of 2004-06-18 in Changelog file for the call to valgrind).
777 - on segfaults: ctest now passes all the tests but one (no more
779 * Erroneous leading white fix:
780 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
781 white[s] (as opposed to from >> xxx, that removes it [them].
782 - src/gdcmTS.cxx: ditto.
783 - gdcmPython/testSuite.py: dirty related kludge removed.
784 * src/*: remaining references to gdcmParser removed.
785 * src/*[cxx|h]: added copy[way]left header.
788 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
789 * In order to fix writing of dicom files:
790 - Test/TestWriteSimple.cxx: a simpler example of writing.
791 - Test/CMakeLists.txt changed accordingly.
792 - src/gdcmDocument.cxx:
793 -- The destructor now recursilvely removes potential sequences.
794 -- Bug fix in ::IsJPEG2000()
795 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
796 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
798 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
799 to only declared) and build on top of
800 ::GetDocEntryByNumber(guint16, guint16).
801 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
802 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
803 for usage in destructor and treatement of promotion in
804 ::ReplaceOrCreateByNumber().
805 - src/gdcmSQItem.cxx: destructor should better handle his job.
806 Test/TestWriteSimple now runs (or at least it DOES something).
807 * We can now start hutting memory links. A good starting point is:
808 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
809 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
810 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
812 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
813 * Valgrind note: after Mathieu Malaterre teached me how to read
814 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
816 Using gcc, you can force the STL to use malloc and to free memory as
817 soon as possible by globally disabling memory caching.
818 With 3.2.2 and later, you should export the environment variable
819 GLIBCPP_FORCE_NEW before running your program.
820 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
821 simply vanish (it is still not clear to me, whether this means that
822 STL std::string leaks or if valgrind believes it leaks...).
823 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
824 running bin/gdcmTests makeDicomDir):
825 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
826 - Test/makeDicomDir.cxx now properly traps empty lists and returns
828 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
829 SegFaulting (I drowned in DicomDir related code when trying to
830 understand why the list is empty...).
831 * src/gdcmDocument.h: first BSD license header try.
832 * Doc/License.txt added.
834 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
835 * src/gdcmDocument.[h|cxx]:
836 - Clean up of the Transfer related predicates. They are now all based
837 on new method isGivenTransferSyntax, that (should) handle properly
839 - general clean up, simplification, and coding style.
840 - Specific clean up of Parse7FE0() (umproperly named actually).
841 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
843 2004-06-14 Jean-Pierre Roux
845 - fix the display of Sequence Delimitor (SQDepthLevel pb)
846 - fix the display of SQItem ordinal number
847 - add the GetSQItemByOrdinalNumber method
848 - remove some useless never written private methods
850 2004-06-14 Jean-Pierre Roux
852 - adding a constructor taking a gdcmDocEntry as an input param
853 - ReplaceOrCreateByNumber now returns :
854 a gdcmBinEntry * if a Binary (void *) value is passed as a param
855 a gdcmValEntry * if a string value is passed as a param
857 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
858 according to the param type (no longer sets a gdcmDocEntry)
859 - GetValEntryByNumber, GetBinEntryByNumber added
860 - NewValEntryByNumber and NewBinEntryByNumber added
862 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
864 - GetSQItemNumber and SetSQItemNumber added, to provide
865 a (relative) Item identier inside a given Sequence
866 \warning : some pb remaining around this number
868 - AddEntry now takes the Item Number as a param
870 - adding a constructor taking a gdcmDocEntry as an input param
872 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
873 * Memory leak hunt with the following command:
874 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
875 --show-reachable=yes gdcmTests PrintDocument
876 It looks like many (all?) leaks are due to the STL (or a bad usage
877 of the STL. The lines producing the leaks now have a comment with
878 a "MEMORY LEAK" tag: you can retrieve them with
879 grep "MEMORY LEAK" src/*
880 Here are two typical examples which I can't help fixing:
885 char * test = "babo";
886 name = test; //// <--- valgrind detects 960 bytes lost in
887 //// call to std::string::operator=(char const*)
888 name.clear(); //// Doesn't help !
896 std::cout << "Type a bunch of characters followed by RETURN: ";
897 getline(std::cin, line); //// <--- valgrind dectects a loss
898 //// of 1320 bytes in call to
899 /// std::basic_istream<>& std::getline<>
905 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * src/gdcmHeader.[cxx|h]:
907 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
908 and related, moved away to gdcmDocument.
909 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
910 the corresponding protected accessors of inherited class
911 gdcmDocument, removed ! As a consequence gdcmFile had to be
912 declared friend of class gdcmDocument (see below).
913 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
914 - Clean up of undefined or unused methods.
915 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
916 account the changes to gdcmHeader.h).
917 * src/gdcmDocument.h:
918 - gdcmFile is now a friend class (in order to take into account the
919 changes to gdcmHeader.h).
920 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
921 (see changes to gdcmHeader.h).
922 - Accessors (reading on the form GetEntry*) are now public.
923 - Clean up of undefined or unused methods.
924 * src/gdcmDocument.cxx:
925 - adaptation to changes to gdcmDocument.h
926 - ::OpenFile now writes a verbose message when file cannot be opened.
927 - some std::string properly set to VRKey
928 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
929 references to gdcmDocument.
930 * Test/TestFindTags.cxx: changed accordingly to above changes.
931 * gdcmPython/testSuite.py: adapted to renaming of acr files in
932 cvs repository gdcmData.
934 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
935 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
936 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
937 conflicts with gdcmValEntry::voidArea.
938 * src/gdcmValEntry.cxx: unmatching comment wiped out.
939 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
940 Value representation between StringRepresentable and BinaryRepresentable.
941 * src/gdcmDocument.cxx:
942 - method ParseDES: proper indentation restored and usage of
943 gdcmVR::IsVROfGdcmStringRepresentable wired in.
944 - method LoadDocEntry: the fingerprint left in the SetValue() of
945 unloaded entries (length > MaxSizeLoadEntry) had curiously been
946 removed. Reverting to previous code segment with the proper
947 dynamic_cast< gdcmValEntry* >.
948 Note: this was (partially) breaking the python test suite
949 (gdcmPython/testSuite.py) that made usage of the above
950 fingerprint to check presence of "Pixel Data".
951 * src/gdcmDocEntry.h: coding style.
952 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
953 now taken into account.
954 * gdcmPython/gdcm.i: adaptation to the new internal representation
955 of gdcm (exit gdcmParser, hello gdcmDocument).
956 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
958 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
959 anymore, but instead prints the loaded Python dictionary.
960 * .... alas, the python testSuite is still broken.
962 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
963 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
965 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
966 * src/gdcmUtil.h : export methods
968 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
969 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
971 * Initial addition of automatic python testing
972 * Initial addition of automatic image comparison
974 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
975 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
976 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
978 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
979 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
980 * Test/ShowDicom.cxx : bug fix for msvc compilation
981 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
983 2004-05-04 Jean-Pierre Roux
984 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
985 new concepts (and new classes) :
986 a 'gdcmDocument' is composed of a set of Doc Entries, that are
987 - elementary gdcmDocEntries (former gdcmHeaderEntries)
988 - Sequence Doc Entries (gdcmSeqEntries)
989 a Sequence is composed of Items.
990 Each item is a set of Doc Entries (this is recursive)
991 The non uniqueness of the 'Dicom tag' is due to this recursivity
992 (never taken into account)
993 Our unability to add a new 'entry' in the header
994 at the proper location (neither in the H-Table (map or multimap),
995 nor in the Chained List is also due to this recursivity.
996 Don't try, right now, to use/modify/compile these new sources :
998 We just commit all the stuff, 'as is', in order not to loose it.
1000 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1001 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1003 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1004 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1005 file prefix (SetFilePrefix)
1007 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1008 * Add a new test: ShowDicom, for now this is just the c++ version of
1009 checkRead.sh, later it will be able to compare the image read against a
1011 * Replace the DEBUG on the stack with a global entry in cmake interface:
1012 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1014 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1015 * Add an example subdir, with a real example on how to read + write a
1018 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1019 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1020 * Doc/CMakeLists.txt: the main page is now properly differentiated
1021 between the developper and user version.
1022 * Doc/doxygen.config.in: dropped search related obsolete flags
1023 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1025 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1026 * DEVELOPPER: added some helpfull comments for compile/test/install
1029 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1030 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1031 src directory, now generated in the build dir.
1032 2. Tests as mentionned smarter
1034 4. Add a new method in gdcmDict that return the PubDict by name
1035 this is interesting for 3rd party lib like ITK,
1036 where we could set the institution name / patient name...
1038 * ENH: 1. Now the test suite is working for real
1039 2. All binaries are now output in the gdcm-bin directory
1040 (this was not true before)
1042 2004-04-28 Jean-Pierre Roux
1043 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1044 SeQuence indented printing of Dicom Header.
1045 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1046 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1047 Computation of SQDepthLevel is now part of gdcmHeader constructor
1048 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1049 tree-like structure of a Dicom Header.
1050 * FIX Test code cleaning
1052 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1053 * ENH: Adding automatic testing
1054 1. Need a DartConfig.cmake to submit to public
1055 2. Add a test driver gdcmTest.cxx
1056 3. gdcmTestMain, an helper for the main test driver gdcmTest
1057 4. Files in Test don't have a main anymore, this becomes interesting
1058 when we add more and more tests, thus dsw don't have to load
1060 * ENH: Adding a GDCM_DATA_ROOT for testing
1061 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1062 one file instead of seven + some small cleanup
1064 2004-04-22 Jean-Pierre Roux
1065 * ENH Minor changes to the Print() methods.
1066 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1067 Header printing. Example given with :
1068 > PrintHeader fileName 2 new
1069 (SQ based tree-like structure still to be done for the Header ...)
1071 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1072 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1073 1. I have added some unsigned where needed
1074 2. Some function parameter not used -> (void)
1075 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1076 4. g++ don't like character '\' in comment
1077 5. #define jpeg_create_decompress jCreaDecompress
1078 this really need to be fixed
1079 6. virtualize destructor of gdcmObject ... leakage
1080 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1081 this also really need to be fixed
1082 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1083 remove compression file
1084 (as we only do decompression, right ?)
1085 * ENH: Change malloc/calloc/free with c++ equivalent
1087 2004-04-21 Jean-Pierre Roux
1088 * FIX gdcmHeaderHelper::GetXSpacing
1089 when a single value is found (bug ?), xpacing is now
1090 defaulted to yspacing
1092 2004-04-19 Jean-Pierre Roux
1093 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1094 * ENH add parameters :
1095 bool exception_on_error = false,
1096 bool enable_sequences = false,
1097 bool ignore_shadow = false
1098 to the gdcmFile constructors to be full gdcmParser compliant
1099 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1100 to allow reading of PAPYRUS 3.0 files
1102 2004-04-06 Jean-Pierre Roux
1103 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1105 2004-04-02 Jean-Pierre Roux
1106 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1107 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1108 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1110 2004-03-30 Jean-Pierre Roux
1111 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1112 for ACR file, written out as DICOM files (hope so...)
1114 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1115 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1116 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1117 moved to base class gdcmParser and only the specialisation is kept
1119 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1120 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1121 already does the job.
1122 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1123 (to be consistent with gdcmParser::WriteEntries).
1125 2004-03-30 Benoit Regrain
1126 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1127 upate of the object's instance. It's passed to 2 in the unfavorable
1128 case : one in the ExecuteInformation, one in the ExecuteData
1130 2004-03-29 Jean-Pierre Roux
1131 * ENH : Check on file type to be written moved
1132 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1133 * FIX : gdcmObject::ResetBoundaries now stops properly
1134 when end-of-list is reached
1135 : gdcmVersion modified (as Benoit Regrain asked)
1137 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1138 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1139 * src/gdcmUtil.cxx: added forgotten iostream include.
1140 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1141 equivalent to ExplicitVR in existing code).
1143 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1144 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1145 now contains all the gdcmGlobal related code.
1146 * minor coding style and doxygenation changes.
1148 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1150 now contains all the Debug related code.
1151 * minor clean-up of includes in src/*.cxx
1152 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1153 CreateCleanString) removed.
1154 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1155 * Doc/DoxyMainPageUser.txt added.
1156 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1157 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1158 src/gdcmDirList.cxx)
1160 2004-03-24 Jean-Pierre Roux
1161 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1163 2004-03-23 Jean-Pierre Roux
1164 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1165 big endian made volumes
1166 * ENH Now gdcmParser constructor and destructor are protected to forbid
1167 end user to instanciate class gdcmParser
1168 (only gdcmHeader and gdcmDicomDir are meaningfull)
1170 2004-03-22 Benoit Regrain
1171 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1172 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1173 gdcmSerie to gdcmDicomDirSerie
1175 2004-03-19 Jean-Pierre Roux
1176 * ENH Now the tree-like structure describing a DICOMDIR comming from
1177 an already existing DICOMDIR file is consistent with
1178 the home-made tree-like structure build ex-nihilo
1179 or build from the files held (recursively) in a Directory
1180 functions gdcmDicomDir::CheckBoundaries()
1181 gdcmObject::SetBoundaries() added
1183 2004-03-17 Jean-Pierre Roux
1184 * REM (Eric Boix bug) : removal of meaningless
1185 gdcmDicomDirImage::NewImage function.
1186 * FIX now file names and directory name are written properly in the
1188 * FIX now gdcmDicomDir constructor may be call without any trick
1191 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1192 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1193 of gdcmDicomDirImage::NewImage as empty function.
1195 2004-02-28 Jean-Pierre Roux
1196 * ENH add gdcmDicomDir:NewPatient
1197 add gdcmDicomDirPatient:NewStudy
1198 add gdcmDicomDirStudy:NewSerie
1199 add gdcmDicomDirSerie:NewImage
1200 to allow making gdcDicomDir object.
1201 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1202 (as opposite to the gdcmHeader chained list)
1204 2004-02-11 Benoit Regrain
1205 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1206 when using from python
1208 2004-02-10 Benoit Regrain
1209 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1210 * FIX : in gdcmDicomDir when the directory is empty
1211 * ENH : add callback and methods to get the progression of dicomDir
1214 2004-02-06 Jean-Pierre Roux
1215 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1216 - GDCM_META added to gdcmDicomDirType
1217 - class gdcmMeta created
1218 * ENH : - A brief summary is now displayed at the beginning of
1219 'testDicomDir' to help disaster magnitude estimation
1220 * REM : Now useless Test/explDICOMDIR.cxx
1222 2004-02-05 Benoit Regrain
1223 * ENH : add methods in gdcmObject to get the hash table or the list of
1225 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1226 * FIX : wrapping python for TagHeaderEntryHT
1228 2004-02-04 Benoit Regrain
1229 * FIX : even length for some strings when writting the dicom dir
1230 * FIX : sort the images in the dicom dir
1231 * FIX : Bug fix for python use of dicom dir
1232 * ADD : a python demo
1234 2004-02-04 Jean-Pierre Roux
1235 * FIX : Final solution (?) for icone embedded images
1236 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1237 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1238 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1239 gdcmData/gdcm-MR-SIEMENS-16.acr1
1240 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1241 to make full checking easier
1243 2004-02-04 Benoit Regrain
1244 * FIX : WriteEntries : coding style & logic in parameters
1245 * FIX : Set the elements to create the DicomDir in a dictionary file
1247 2004-02-03 Benoit Regrain
1248 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1249 * gdcmDicomDir : add the load of directory
1250 * Bug fix and print add-on
1252 2004-02-03 Jean-Pierre Roux
1253 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1254 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1255 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1256 * FIX gdcmParser.cxx : 'group length' elements are now considered
1257 as integers, even for shadow groups, when file is Implicit VR
1259 2004-02-02 Jean-Pierre Roux
1260 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1262 of the last synonym :-(
1263 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1265 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1266 * FIX taking into account the possible 7fe0,0010 multiplicity
1267 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1268 to allow removal of references to 7fe0,0010, to deal with
1269 ACR-NEMA images, when 0028,0200 is meaningfull
1271 2004-01-31 Jean-Pierre Roux
1272 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1273 no longer writes 'Un' on disk
1274 * FIX SQ elements with actual length are now dealt with corectly
1275 * FIX gdcmFile::WriteBase make the difference, for color images, between
1276 the length (for Palette expanded images)
1277 and Raw Length (non expanded image + Palette)
1278 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1279 (that broke Write). Replaced by UL.
1280 Aware user will reload the field if he
1281 thinks it's necesssary
1283 2004-01-30 Jean-Pierre Roux
1284 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1285 when 'dirty Acr' is found, to be compliant with the new
1286 IsReadable() methods.
1288 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1289 (no DOUBLE images in kosher DICOM,
1290 but so usefull for people that miss them ;-)
1292 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1293 DICOMDIR related utilities (not checked as Windoze compliant)
1295 2004-01-28 Jean-Pierre Roux
1296 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1298 2004-01-27 Jean-Pierre Roux
1299 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1300 to allow skipping the shadow elements, to save memory space.
1301 The TRUE value for this param has to be used
1302 with a FALSE value for the 'enable_sequence' param.
1303 ('public elements' may be embedded in 'shadow Sequences')
1304 * gdcmHeader methods now deal with 'embedded icones images' in the header
1305 (even when an 'icone image sequence' is announced by the
1306 element (0x0088,0x0200), but there is NO icone at all ...
1308 * gdcmHeader sometimes Image Location value doesn't follow
1309 the supposed processor endianity (see gdcmData/cr172241.dcm).
1312 * gdcmHeader add the method
1313 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1314 to get *all* the Header Entries with the same tag.
1315 GetHeaderEntrySameName is probabely *useless*
1316 (no meaning : Name is *not* an identifier within the Dictionnary)
1318 2004-01-26 Benoit Regrain
1319 * Bug fix in the print of hexadecimal representations. Remove long fields
1320 in the print and add a third level of print to print them
1322 2004-01-23 Benoit Regrain
1323 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1324 * Bug fix on test suite after remove the strip made on not string fields
1325 * Split the IsReadable method between gdcmParser which test that the file
1326 is dicom and gdcmHeader which test that it's an image file
1328 2004-01-22 Benoit Regrain
1329 * DicomDir : clean code, add methods, set variables in protected or private
1330 * gdcmUtil : bug fix for the clean string method
1332 2004-01-19 Benoit Regrain
1333 * Add the use of shadow dictionaries
1334 * bug fix and coding style
1336 2004-01-19 Benoit Regrain
1337 * src/gdcmFile.cxx : bug fix concerning the close of file
1338 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1339 * Add the update of header entries using the shadow library
1341 2004-01-19 Benoit Regrain
1342 * removal of file gdcmHeader2.cxx
1343 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1344 inheriting from gdcmParser. This split is to prepare the integration
1345 of dicom dir parsing
1346 * bug fix under python
1348 2004-01-16 Jean-Pierre Roux
1349 * REM removal of class gdcmHeaderEntrySet
1350 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1351 * ADD add file gdcmHeader2.cxx
1352 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1354 2004-01-15 Benoit Regrain
1355 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1356 entries created while parsing the header. Thus, they will be destroyed
1357 when the gdcmDictSet will be destroyed
1358 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1361 2004-01-15 Benoit Regrain
1362 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1363 made a fatal error because of the memory release at the end of program.
1364 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1365 some memory and vtk seems to have some problems with that.
1366 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1368 2004-01-14 Benoit Regrain
1369 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1370 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1371 * src/*.[h|cxx] : make changes due to class name changes
1372 * gdcmPython/demo/*.py : bug fix due to method names
1374 2004-01-13 Benoit Regrain
1375 * src/*.[h|cxx] : coding style
1376 * vtk/*.[h|cxx] : coding style
1378 2004-01-13 Benoit Regrain
1379 * gdcmPython/testSuite.py : test the readable flag of file for tests
1380 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1381 It's lied to the stl compilation by MSVC (windows, always windows...)
1382 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1384 2004-01-12 Benoit Regrain
1385 * src/*.h : add comments
1386 * src/gdcmDictSet.h : set the method BuildDictPath in public
1387 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1388 directly setted in the source code
1389 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1392 2004-01-09 Benoit Regrain
1393 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1394 * setup.py : use a reference to gdcmVERSION
1396 2004-01-07 Benoit Regrain
1397 * Modification to compile with the distutils.
1400 2003-12-10 Benoit Regrain
1401 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1402 can use a gdcmHeaderHelper to load datas
1403 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1404 made in the source code
1406 2003-12-10 Benoit Regrain
1407 * Update Windows projects and .cvsignore files
1409 2003-11-12 Jean-Pierre Roux
1410 * ENH gdcmHeader constructor has one more parameter (default value : false)
1411 that allows the user to 'go inside' the SeQuences only
1413 gdcmElValSet:Print takes it into account
1415 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1416 * ENH: Update gdcmPython/CMakeLists
1417 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1418 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1420 2003-11-10 Jean-Pierre Roux
1421 * FIX : gdcmHeader::LoadElements is now based
1422 on the ListTag listElem member,
1423 not longer on the TagElValueHT tagHt member
1424 * ENH : PrintPubElVal shows (temporarily) both results,
1425 with the tagHt member and the listElem member.
1426 (it's easier to 'see' the problems when using Printheader)
1428 * FIX : old private member LgrElem is now splitted into
1429 ReadLength : Length actually found on disk (updated only
1430 if bug fixing is necessary), for internal
1432 UsableLength : Updated by FixFoundLength, to fix a bug
1433 or to allow Parser going on.
1434 Will allow to re-write a kosher header when a SeQuence
1435 with a length (not 0000) is found
1436 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1437 because gdcmElValSet::Add does not update ListElem
1440 2003-11-07 Jean-Pierre Roux
1441 * FIX misstyping in Transfert Syntax name table
1442 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1443 when they have an actual length (not 0000 nor FFFFF)
1444 (Nobody should care of it, but DICOMDIR explorers)
1446 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1449 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1450 * ENH: vtkGdcmReader now supports LUT !
1451 (vtkgdcmViewer for now is not able to use them though)
1453 2003-11-05 Jean-Pierre Roux
1454 * in testSuite.py : new files names for checking the package
1455 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1456 that returns the pixel area size to the *aware* (vtk) user
1457 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1459 2003-11-05 Benoit Regrain
1460 * in testSuite.py : Modify the rules for checking the paths
1461 : Explicit error messages
1462 * in __init__.py : Related modif
1464 2003-11-03 Jean-Pierre Roux
1465 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1466 to be used by aware (vtk) users that want to manage
1467 LUT (and no to turn the PALETTE image into an RGB pixels one)
1468 * GetPixelType now returns 8U for 24 Bits images
1469 (vtkGdcmReader compliant)
1471 2003-10-31 Jean-Pierre Roux
1472 * Removal of *all* gdcmData images and add them again
1473 in order to loose the 'history' of un-anonymised images
1475 2003-10-31 Jean-Pierre Roux
1476 * RMV : removal of useless jBitsInJsample.h
1477 for both 8 and 12 Bits JPEG Lossy Libraries
1479 2003-10-31 Jean-Pierre Roux
1480 * ENH : Add the functions gdcmFile::GetImageDataRaw
1481 gdcmFile::GetImageDataIntoVectorRaw
1482 that act as GetImageData and GetImageDataIntoVector
1483 except the making of an RGB Plane from Gray Plane + LUT
1484 Intended to aware (vtk) users who know how to manage
1487 GetLUTRGBA return a R,G,B,A LUT if any
1488 lgrTotaleRaw gives the 'Raw' length
1489 GetImageDataRaw returns the gray Plane
1490 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1491 (They stay Grey, just like with other Dicom viewers :-(
1493 2003-10-30 Jean-Pierre Roux
1494 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1496 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1497 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1498 being coherents dicom files.
1500 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1501 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1503 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1504 * ENH: Two steps is necessary to please VC++ compiler...
1505 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1506 * ENH: Add include dir to medcon lib
1507 * FIX: only one function is being exported for now !
1508 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1510 2003-10-29 Jean-Pierre Roux
1511 * adding gdcmHeader::GetLUTRGBA
1512 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1513 --> Mathieu, the modif u're waiting for is not yet committed
1514 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1516 2003-10-27 Jean-Pierre Roux
1517 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1518 00191113.dcm DermaColorLossLess.dcm
1519 MxTwinLossLess.dcm RadBWLossLess.dcm
1520 * ENH: For version prior to vtkImageViewer2 -r 1.19
1521 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1523 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1524 * Removal of ido stuff in CMakeLists.txt
1526 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1527 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1528 * FIX: remove a call to ->Modified ... see comments
1529 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1531 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1532 * FIX: Problem with path for libvtkgdcmPython
1533 * ENH: Try adding a search script for python site-package
1534 * RMV: Remove some file from medcon lib that are not necessary
1535 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1536 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1537 * FIX: More pragma disable fro VC++,
1538 I don't think I break something as it is also disable in VTK/ITK.
1539 But it fasten debug compilation time.
1541 2003-10-23 Jean-Pierre Roux
1542 * gdcm now deals with 16 Bits Run Length Encoded images
1543 (they are compressed as 2 planes images,
1544 one for the high Bytes, the other for low Bytes)
1546 2003-10-22 Jean-Pierre Roux
1547 * Now CheckRead takes into account :
1548 - the bugged 'Leonardo' Siemens images
1549 - the XA images, sent thru the burning VPRO station
1550 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1553 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1554 * FIX: When copying a Makefile.am to CMakeLists.txt
1555 one should remove the '\'
1557 2003-10-22 Jean-Pierre Roux
1558 * in gdcmData adding a bugged 'Leonardo' Siemens image
1559 (wrong lengths in header)
1560 OK with gdcm, KO with the other viewers :-)
1561 * add a GE dlx XA image, thru the VEPRO burning station
1564 2003-10-21 Jean-Pierre Roux
1565 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1566 for a brutal checking of vtkgdcmViewer compliance
1568 2003-10-21 Jean-Pierre Roux
1569 * add the files for 'xmedcon' Jpeg Lossless library
1570 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1572 2003-10-21 Jean-Pierre Roux
1573 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1575 2003-10-21 Jean-Pierre Roux
1576 * garbage Siemens 'Leonardo' images dealt with
1577 (the patch is easy to remove)
1578 * cosmetic changes to avoid warnings
1580 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1581 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1582 no need to press 'r' now.
1584 2003-10-20 Jean-Pierre Roux
1585 * upgrade of checkRead.sh checkWrite.sh according
1586 to new Jpeg Lossless decompressor
1587 * add US.3405.1.dcm, a genuine RGB medical file ...
1588 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1589 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1591 2003-10-15 Jean-Pierre Roux
1592 * general anonymisation in gdcmData
1593 * adding the 'color files' from
1594 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1595 * adding some well knowed bugged-header images
1596 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1597 waiting for their inclusion in Python testsuite
1599 2003-10-15 Jean-Pierre Roux
1600 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1601 no longer seg faults when file is not found
1603 2003-10-14 Jean-Pierre Roux
1604 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1607 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1608 * TODO: *.in file to genereate a UseGDCM later
1610 2003-10-14 Jean-Pierre Roux
1611 * Some supposed-to-be Dicom Images have no preamble.
1612 OpenFile takes it into account
1613 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1614 * Missing elements added in dicomV3.dic
1615 (just to be affraid : have a look at
1616 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1617 and do it again next year ;->
1619 2003-10-13 Jean-Pierre Roux
1620 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1621 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1622 But there are NOT. It's fixed !
1624 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1625 * FIX: "jpeglib.h" was not found on VC++
1626 * FIX: vtkgdcm was not being installed
1628 2003-10-10 Jean-Pierre Roux
1629 * ENH : OpenFile closes the file if it *really* doesn't look like
1630 an ACR-NEMA / DICOM one.
1631 * FIX : testWrite no longer writes an empty file if the source file
1632 is not gdcm Readable
1633 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1636 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1637 * FIX: CMake generate now documentation
1638 * ENH: out of source doc build !
1639 * ENH: Generate both user and dev documentation
1640 * ENH: Should work on windows too
1641 * ENH: Only one doxygen config.in file is needed
1642 * FIX: make install should be ok now on ùnix plateform
1643 * FIX: PATH to dictionary was wrong (missing /)
1644 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1646 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1647 * vtkGdcmReader is now able to read rgb dicom file.
1648 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1649 * added a gdcmViewer to vtk test, use mouse to control
1650 window level & window width
1652 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1653 * CMake-ification of gdcm, we have now two build system
1654 * FIX: on cygwin Wsock32 doesn't exist
1655 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1657 2003-10-06 Emanuel Ollart
1658 * FIX : compilation process wad broken.
1659 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1661 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1662 * change gdcmViewer -> vtkgdcmViewer
1663 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1665 2003-10-06 Jean-Pierre Roux
1666 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1667 ( e.g : well known GE images with a wrong elem length,
1668 : Philips MRI Images with a wrong Huffman table)
1669 * still to be done : allow the reading of bugged LEONARDO Siemens images
1671 2003-10-03 Jean-Pierre Roux
1672 * Odd length strings are padded with '\0' (not with spaces,
1673 to remain compliant with already defined strings,
1674 like Transfert Syntax UID and others)
1676 2003-10-03 Jean-Pierre Roux
1677 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1678 to allow displaying RGB images (not only by affim ;-)
1680 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1681 * vtkGdcmReader is now able to read rgb dicom file.
1682 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1684 2003-10-03 Jean-Pierre Roux
1685 * A few nasty patches to allow the reading of a lot of nasty images
1686 ( e.g : well known GE images with a wrong elem length,
1687 : Philips MRI Images with a wrong Huffman table)
1688 * still to be done : allow the reading of bugged LEONARDO Siemens images
1690 2003-10-03 Jean-Pierre Roux
1691 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1693 2003-10-03 Jean-Pierre Roux
1694 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1695 to allow displaying RGB images (not only by affim ;-)
1697 2003-10-03 Jean-Pierre Roux
1698 * gdcmFile::GetImageDataIntoVector now
1699 - deals with MultiFrames MultiFragments Run Length Encoded files
1700 - deals with YcBcR (YBR_FULL) files
1701 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1702 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1704 (no sample found :-(
1706 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1707 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1708 Two reasons: - clear things
1709 - third parties acces gdcm through header files, so won't
1710 suffer anymore VC++ complains
1712 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1713 * add argv[1] in testvtkGdcmReader.cxx
1716 2003-09-24 Jean-Pierre Roux
1717 * The lines are now eigthy characters long.for
1718 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1720 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1721 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1722 char* to std::string. Thus, the use of strdup becomes useless. (see
1723 previous commis of Malaterre)
1724 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1725 before the last Malaterre's commit.
1727 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1728 * This commit should fix the Debug building under VC++, the problem
1729 was mainly a mixture of debug and release lib being loaded at startup.
1730 * I also remove a depency to a specific C function: strdup. Because I had
1731 to force the link to msvcrtd (whereas strdup is in libc).
1733 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1734 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1735 located in the gdcmCommon.h file. All use of reference of tha has been
1736 changed to now use the variable GDCM_UNFOUND.
1738 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1740 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1741 Dicom dictionary. The test suite can now be run again. Note:
1742 I'm note very happy with the " (RET)" changes. I believe this
1743 RETAINED comment should be dropped when parsing the dictionary.
1744 - PACKAGER corrected
1746 - AUTHORS updated and now in alphabetical order
1747 * Makefile.am now exports gdcm.dsw for Windoze users.
1749 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1750 * cygwin complains about missing std:: in subdir Test/
1752 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1753 * remove some methods that are now in gdcmHeaderHelper
1755 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1756 * vtkGdcmReader set spacing and origin correctly
1758 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1759 * Fix a few delete/delete[] mismatch
1761 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1762 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1763 interpretation to data given by gdcmHeader. For instance there are
1764 heuristics to get informations (look at different places).
1765 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1766 sorting DICOM images based on different strategies.
1767 * modified Makefiles accordingly.
1769 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1770 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1771 when building in debug mode
1772 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1773 src/win32/gdcmdll.dsp
1774 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1776 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1777 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1780 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1781 * src/win32/libgdcmjpeg12.dsp was not dos format
1782 * src/win32/libgdcmjpeg12.dsp :
1783 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1784 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1786 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1787 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1789 * src/gdcmFile.cxx : bug fix in affectation type
1790 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1791 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1792 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1793 symbols... future problem ?
1795 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * src/win32/libgdcmijpeg12.dsp was missing
1797 * modified gdcm.dsw accordingly
1799 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1800 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1802 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1803 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1804 commit of JPR (before his hollidays to facilitate our work).
1805 * setup.py : bug fix in code. Modifications made while the last commit
1806 of JPR. The code hasn't been tested before the commit... it's so
1807 useless to make that (for best programmer that is JPR) !!!
1809 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1810 * tagged the current version as Version0_3 (i.e. version 0.3)
1812 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1813 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1814 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1815 * *.dsp : modifications to use new libgdcmijpeg8 library
1816 * setup.py : bug fix on VTKPATH variable
1817 * PACKAGER : adding all concerning windows
1819 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1820 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1822 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1823 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1824 test suite reported error.
1825 * PACKAGER file added (describes what a packager must do when
1826 packaging a new release).
1827 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1828 * configure.in: upgraded version number to 0.3.0
1829 * fixing build of rpm (through rpm -ta):
1830 - Doc/Makefile.am exports proper doxygen files
1831 - src/jpeg/libijg8/Makefile.am exports the include files.
1833 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1834 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1835 * src/gdcmHeader.h : formatting code
1837 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1838 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1839 We were obtaining error message from vtk. Now, creation of file list
1840 is made in an internal list to prevent this problem.
1841 Bug fix when output is empty.
1842 Bug fix in update of progress value. Previous commit for this was a bad
1844 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1846 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1847 * src/gdcmHeader.h : added method to get the file name
1848 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1849 files. Added method to remove all files on the input
1850 Added FIXME comment concerning the bad parsing of header made by
1851 ExecuteInformation method (in ExecuteData method)
1853 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1854 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1855 when using make instal.
1856 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1857 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1859 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1860 * setup.py : adding include dir of jpeg lib to compile all sources
1861 * */Win32/*.dsp : JPR fix for windows compilation
1863 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1864 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1866 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1867 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1869 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1870 * setup.py is again effective on un*x (takes into account the
1871 addon of the jpeg library)
1872 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1873 * Doc/Doxy* updated (includes above enhancements)
1874 * INSTALL now points to web documentation
1876 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1877 * src/gdcmHeader.h doesn't make unnecessary reference to
1879 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1881 * src/gdcm*.[cxx|h] :
1882 - to allow compilation with gcc 3.x
1883 -- clean up of STL usage (added explicit usage of std::)
1884 -- small fixes on exceptions.
1885 Note: linking not tested !
1886 - clean of doxygen comments to avoid warnings at documentation
1888 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1889 dependent convertion).
1891 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1892 * Clean up of previous JPR garbage commit (not even commented in the
1894 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1895 - moved all jpeg related files from src to src/jpeg/libijg8, with
1896 addition/modification of Makefile.am and configure.in.
1897 - the testSuite is still brain damage (not guilty).
1899 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1900 * WrapVTK.py : modifications to get correctly vtk source files to
1902 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1903 (FileName -> Filename)
1905 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1906 * vtk/vtkGdcmReader.[cxx/h]:
1907 - UpdateProgress method should now be effective
1908 - removed the limitation on having only images loaded (as opposed
1910 - when building a stack of images/volume, a lesser number of
1911 gdcmHeader and gdcmFile instances should be used (hopefully
1912 accelerating things).
1913 - when building a stack of images/volumes, files which are not
1914 loadable (wrong path-filename, wrong permissions on existing file,
1915 or file not parsable by gdcm) are replaced with a black image
1916 in the stack (for the caller to notice the problem).
1918 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1919 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1921 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1922 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1923 between standard library (std) and vtk library (problems are found
1924 under Windows... thanks Windows !)
1926 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1927 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1929 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1931 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1932 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1934 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1935 * When compiling with distutils (see setup.py) the C++ compiler is
1936 called with different flags than the default ones (with automake).
1937 In order to fix all those warning, I compiled gdcm with the command
1938 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1939 and went for warning fixes:
1940 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1941 up from unused variables.
1942 - vtk/vtkGdcmReader.cxx: potential bug fix.
1943 * src/gdcmHeader.h: Doxygen warning cleanup
1945 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1946 * gdcmPython/gdcm.i:
1947 - typemaps correction to take into account the systematic replacement
1948 of "using namespace std" with std:: prefix e.g. std::list,
1949 std::string... (cf changes of 2003-05-21).
1950 - gdcmGlob global variable of type gdcmGlobal (defined in
1951 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1952 exported to Python a as cvar.
1953 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1954 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1955 gdcmDictSet.GetPubDictTagNames() and
1956 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1957 C++ static methods).
1958 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1959 with the above changes.
1961 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1962 * setup.py, manifest.in : bug fix under linux
1964 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1965 * Modification of setup.py to compile vtk part too. Then, we have 2
1966 wrappers which must work with same distutils. For that, we have a
1967 generic distutils in distusiltsWrapping.py ; with :
1968 - build_extWrap class to wrap generically all extensions,
1969 - ExtensionWrap base class for all wrapping extension that contains
1971 - Wrapper interface which wrap sources
1972 + In WrapSwig.py we have extension and wrapper for Swig
1973 + In WrapVTK.py we have extension and wrapper for VTK
1974 * MANIFEST.in : modifications to consider vtk directory and new python
1975 files for compilation
1977 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1978 * Added python wrappers of vtkGdcmReader vtk class (see the
1979 source in vtk/vtkGdcmReader.cxx) :
1980 - vtk/Makefile.am now builds a library
1981 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1982 python library (as opposed to _gdcm.so wich are the python
1983 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1984 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1986 - configure.in has an additional flag --enable-vtk that needs
1987 to be set to enable compilation of vtk related code, that is:
1988 + vtk/vtkGdcmReader.so and
1989 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1990 + gdcmPython/vtkgdcmPython.so (see above)
1991 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1992 be read when compressed or when HighBit + 1 != BitsStored),
1993 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1994 the usage of the python wrapper of vtkGdcmReader vtk class.
1995 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1996 * src/*.[h] all occurences of stl classes are now prefixed with
1997 std::, and all occurences of "using namespace std;" where removed.
1998 This is to avoid pollution of global namespace in included files.
1999 Apparently vtk does not avoid this pitfall: when using both
2000 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2001 collision of various stl members (principally cout...).
2002 * gdcmPython/testSuite.py now cleanly removes temprory generated
2004 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2005 comply with above changes)
2007 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2008 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2009 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2010 vtk data structure (an image Flip was required).
2011 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2012 * cosmetic changes in documentation.
2014 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2015 * src/gdcmHeader.cxx: the constructor no longer exits when an
2016 unexisting file is given as argument.
2017 * The subdirectory Data (containing all the images used for the
2018 test suite) is not part of this repository anymore. A new module
2019 containing those images is now available at
2020 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2021 with the name gdcmData.
2022 All the python scripts (including the package initialisation file
2023 gdcmPython/__init__.py) were adapated to take this change into
2024 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2026 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2027 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2028 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2029 demo of the usage of this class.
2030 Compilation of this vtk part is only done when using the --enable-vtk
2031 at configure (or autogen.sh) stage.
2033 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2034 * More memory link related corrections and documentation fixes.
2036 - maximum info is obtained with a command of the form:
2037 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2038 --show-reachable=yes PrintHeader
2039 - the remaining reachable blocks seem to come from the STL
2040 allocation scheme through the usage of map and list. It looks
2041 like this memory cannot be freed but it is not a memory leak
2042 (in fact further invocation to the STL would recollect the
2043 unused memory allthough it cannot explicitely be freed).
2044 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2045 of displaying an image parsed with gdcm and displayed with VTK.
2046 Note: some images don't seem to work e.g.
2047 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2048 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2049 Allthough this weakens the semantics, it is a ditch attempt to
2050 make gdcm more thread friendly.
2052 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2053 * Memory link hunt (by using valgrind through the command
2054 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2055 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2056 gdcmHeader::_dicom_vr.
2057 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2058 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2060 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2062 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2063 * src/Makefile.am now exports all the necessary include files at
2067 * UpdateGroupLength replaced by new one
2070 * UpdateGroupLength re-written using H-Table
2071 (named UpdateGroupLengthNew untill checks are over)
2073 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2074 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2075 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2077 - gdcmHeader::GetPubElValSet removed.
2078 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2079 UpdateGroupLength, WriteElements, Write.
2080 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2081 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2082 carried the same semantics.
2083 - src/gdcmHeaderIdo.cxx changed accordingly.
2084 - gdcmFile::WriteBase now regroups all the codes from previous
2085 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2086 - enum FileType moved to gdcmCommon.h
2087 * src/gdcmHeader.cxx AddDefault trashed
2088 * gdcmGetXSize added
2089 * getimageDataSize now calls gdcmGetXSize
2090 * Test/*.cxx changed to agree with above changes
2092 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2094 (to avoid double call by end user).
2095 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2096 by end user, since gdcmHeader::gdcmHeader now handles it.
2098 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2099 * gdcm/Doc many doxygen changes:
2100 - Doxyfile now has two different versions, DoxyfileUsers that generates
2101 the html.users end users oriented documentation and
2102 DoxyfileDeveloppers that generates the html.developper developper
2103 oriented documentation.
2104 - README changed accordingly
2105 - requirement.txt removed (old design info moved to TODO).
2106 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2107 DoxyMainPage.txt, DoxyPython.txt provide more information.
2108 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2109 be updated by simply regenerating the docs with doxygen and copying
2110 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2111 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2112 all the tests in the form "if (<map>.count() >1)" were removed.
2113 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2114 ill-formed documentation sections.
2115 * src/gdcmHeader.cxx: ditto
2117 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2118 * setup.py fixed for un*x (needed macro for stdint.h)
2119 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2120 un*ces with sh-utils test utility.
2121 * gdcmPython/demo/test.py renamed to PrintHeader.py
2122 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2123 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2124 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2125 * src/gdcm*.cxx JPR's bad inclusion fixed.
2127 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2128 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2129 * gdcmPython/demo/test.py changed accordingly.
2131 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2132 * gdcmPython/Makefile.am fixed linking against libstdc++
2133 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2134 * Swig subdir (historical tests of swig version 1.3.17++) removed
2135 * Test/testChangeEntete.cxx some lines commented out in order to make
2137 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2138 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2140 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2141 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2142 hence the user doesn't need this explicit call.
2143 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2144 i.e. LoadElements() call removed.
2145 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2146 - src/Makefile.am declares the proper flag for g++.
2147 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2148 for adding user defined new tags.
2149 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2150 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2151 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2153 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2154 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2155 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2156 src/Makefile.am : the project should properly compile and install
2157 with the autotools, included the python wrappers part.
2158 * gdcm.spec.in : added a spec file for RPM packaging.
2160 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2161 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2163 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2164 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2165 to exported to the environement (see gdcmPython/testSuite.py
2167 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2168 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2169 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2170 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2171 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2173 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2174 * gdcmPython/__init__.py doesn't crash anymore when running in
2175 in InstallMode or PreInstallMode but with an environement given
2176 value of GDCM_DICT_PATH.
2177 * src/gdcmDictSet.[cxx/h] coding style.
2179 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2180 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2181 * src/gdcm.h general comments moved to TODO, and README
2182 * src/gdcm.h should now be seen as a user commodity (including it
2183 should suffice to fully use gdcm). It is nowhere including within
2184 any of the kernel files src/*.cxx and src/*.h.
2186 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2188 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2190 * src/gdcm*.cxx only include their corresponding include file
2191 (as opposed to gdcm.h)
2192 * gdcmPython/gdcm.i changed accordingly
2193 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2194 the autogen.sh generated "make snapshot" command to work.
2195 * autogen.sh removed history related references to crea package.
2197 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2198 * distutilsSwigCPlusPlus.py work around some swig portability
2201 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2202 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2203 was done in a last ditch attempt to get setup.py _really_
2204 operationnal. The python/gdcmPython layaout add the advantage
2205 of hidding away the python related distutils specific files
2206 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2207 Alas, the src directory was out of scope (i.e. it's relative
2208 position to setup.py was ../src) which made things impossible to
2209 handle (see previous version of python/setup.py). Crossing fingers...
2211 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2212 * python/setup.py now works on Un*x. (harder than I thougth)
2213 * python/distutilsSwigCPlusPlus.py can now have include files
2214 among the list of sources.
2216 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2217 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2218 * modifications in MSVC projects
2220 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2221 * As stated by the first lines of Test/ExceptionAndPython/README, it
2222 looks like we can move back to original usage of exception within
2223 src/gdcm* and hence remove the errno stuff that was introduced
2224 as a quick and dirty fixture of this problem (added to the TODO).
2225 * Doc/Doxyfile configuration file for Doxygen and corresponding
2226 README file for usage added.
2227 * Test/testWrite.cxx added. This new test comes from a split of
2228 test.cxx that is now reverted to its original purpous i.e.
2229 testing the proper parsing of a Dicom related file.
2230 testWrite.cxx concentrates on testing the IO part of gdcm.
2231 * Test/bug1.cxx (containing a bug on WIn32) added.
2232 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2233 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2234 whose purpose is to publish the content of the TagNames of the
2235 Dicom public dictionnary were not accessible without an
2236 instance of class gdcmHeader.
2237 - those methods are now static methods of gdcmDictSet and hence
2238 require no instances at all to be invocated.
2239 - within gdcmDictSet this change required to change some method
2240 to class methods (i.e. are now static) among which SetDictPath
2241 (renamed to BuildDictPath) and LoadDefaultPubDict.
2242 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2243 the above changes by calling the new method classes of gdcmDictSet.
2244 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2245 the above to be effective.
2246 * python/gdcmPython: in order to wrap properly the above changes
2247 for Python, swig version now needs to be > 1.3.17.
2248 * python/gdcmPython/Makefile fixed to adapt itself to new
2249 configure/make shema introduced by Johan Montagnat (thanks for the
2250 contribution). Alas this Makefile cannot be turned into a proper
2251 Makefile.am without some heavy changes in the configure.in
2252 (for python dectection).
2253 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2254 now avoids publishing the empty entries.
2256 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2257 * python/setup.py : bug fix concerning install under windows
2258 ExtraPath reused :-P
2259 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2261 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2262 * Dicts/dicomV3.dic : remove double spaces !!!
2263 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2264 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2267 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2268 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2269 method. Doxygenation.
2270 * src/gdcm.h clean up of JPR spurious comments.
2272 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2273 * python/distutilsSwigCPlusPlus.py now properly collects the
2274 shadow classes generated by "swig -c++" (gdcm.py in our case)
2275 when using "python setup.py install".
2276 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2277 reexports the working classes.
2278 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2279 by the classical C errno scheme. This is to prevent an obscure
2280 behavior of the python wrappers when importing wxPython.wx prior
2281 to gdcmPython (which ended up in an abort call). An illustration
2282 of this oddity can be found in the Test/ExceptionAndPython
2283 subdir (see the README file). This problem probably due to
2284 an combination of g++ and dynamic loading.
2285 * added Test/ExceptionAndPython (see above)
2287 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * Changed the layout of the python part to avoid bloating main
2289 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2290 i.e. the distutils arsenal. All the python related stuff is
2291 again in a python subdir, but the package itself is now in
2293 * setup.py was cleaned up:
2294 - pythonIncludePath removed
2295 - python setup.py bdist target is now functional.
2296 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2297 collision with other packages). gdcmPython/demo/*.py changed
2300 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2301 * python subdir moved to gdcmPython (preparation of distutils packaging).
2302 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2303 distutils installer is operational.
2304 * - gdcmPython/__init__.py now properly loads the swig generated
2305 shadow classes (from gdcm.py).
2306 - gdcmPython/demo/*.py changed to import the package gdcmPython
2307 instead of gdcmPython/demo/load.py.
2308 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2310 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2311 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2312 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2313 entries within the associated public Dicom dictionary resp. the same
2314 information but sorted by the fourth field (PAT, IMG, DIR) of the
2316 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2317 are now in the "???" group.
2318 - python/gdcm.i changed accordingly,
2319 - python/demo/printGroupedPublicDict.py added, that gives an example
2320 of the above new functionalities in Python.
2322 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2323 * src/gdcm.h, gdcmHeader.cxx:
2324 - historic references to glib's g_malloc and g_free (#defined)
2325 were definitively removed.
2326 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2327 * src/gdcmElValSet.cxx:
2328 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2329 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2330 - GetElValue(string) renamed to GetElValueByName.
2331 - Added GetElementByName(string).
2332 * src/gdcmHeader.cxx: added
2333 - GetPubElValRepByNumber(guint16, guint16)
2334 - GetPubElValRepByName(string)
2335 - GetShaElValRepByNumber(guint16, guint16)
2336 - GetShaElValRepByName(string)
2337 - GetShaElValByNumber(guint16, guint16)
2338 - GetShaElValRepByName(string)
2339 - GetElValRepByNumber(guint16, guint16)
2340 - GetElValRepByName(string)
2341 - GetElValByNumber(guint16, guint16)
2342 - GetElValRepByName(string)
2343 * Doc/requirements.txt added.
2345 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2346 * Test/Makefile building now depends on the one of libgdcm.so
2347 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2348 pixel data) aware which enables finding the address (offset) of
2349 the pixel data of JPEG encoded DICOM files. This leaves only a single
2350 file in the testSuite whose pixel data address (offset) is unknown.
2351 * python/testSuite.py changed accordingly.
2353 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2354 * VC++ has some strong limitations when working with the STL, as stated
2355 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2356 "Also note that some STL containers (map, set, queue, list, deque)
2357 cannot be exported. [...]
2358 Some STL classes contain nested classes. These classes can not
2360 This is caused by a designed limitation that once a template
2361 class is instantiated, it can not be re-instantiated and
2363 Since our usage of map<> is ubiquitous in gdcm, this "designed
2364 limitation" of VC++ is a pitfall.
2365 Hence the Python wrappers of gdcm cannot be incrementally linked
2366 against the c++ dynamic library. The dirty but only workaround is
2367 to forget about incremental link of dynamic libraries and to generate
2368 the Python wrappers library with the inclusions of the underlying C++
2370 The following modifications concern this matter on Win32/VC++:
2371 - wrapping python correct with standalone wrapped dll (don't use separate
2372 dll under windows !!!!)
2373 - python21_d debug mode enabled (ask Frog how to use it :-)
2374 - NO problem with having an STL member of class for example string in C++
2375 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2376 - Python test of dcmlib in Python is ok under windows on a large set
2378 * removed glib references
2379 * typedef's inserted in gdcm.i for correct swig type management
2381 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2382 * python/demo/*.py load.py extracted from test.py. Added explore.py
2383 that only displays required tags and testAll.py that parses all
2384 the files of the testsuite without using unittest.
2385 * python/testSuite.py other additional test on new files added.
2386 * Data/* new test files added accordingly to the testSuite.
2387 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2388 the vr in the file differs from the one of the dictionary.
2390 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2392 values, but limits itself to values which are below a user specified
2393 size (by default 1024 bytes).
2394 * python/gdcm.i : elements not loaded (because their size is above the
2395 user specified treshold) are exported with their TagKey as key of the
2396 python dictionary. This enables the testsuite to make some checks
2397 on the unloaded elements (since we have their offset and size).
2398 * python/testSuite.py
2399 - now tests for the existence and proper value of the pixel data
2400 - two new examples added.
2401 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2403 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2404 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2405 aware. See the strategy comments in gdcmHeader::FindeLength().
2406 * Test/test.cxx now accepts a filename as first argument.
2407 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2408 * python/testSuite.py changed to integrate test on above files.
2410 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2411 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2412 the vr was also RET.
2413 * python/testSuite.py more tests added.
2415 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2416 * python/testSuite.py unittest test suite added (uses Data)
2417 * Data/* dcm and acr files for the test suite.
2418 * glib dependance removed from un*x version. We now use ISO C99
2419 7.18 Integer types (see stdint.h)
2420 - python/Makefile, src/Makefile src/gdcm.h
2421 * src/ when an explicit vr (like dicom files) suddenly poped an
2422 implicit element we use to mark the underlying DictEntry of the
2423 concerned ElValue with "Implicit". This strategy was damageable
2424 too the public or provite dictionaries, since some of their vr
2425 would be changed. Since Header::FindLength heavily relies on the
2426 detection by Header::FindVR of falsely explicit elements, I
2427 added an extra ImplicitVr member to ElValue (boolean).
2428 The rest of the changes we the necessary adaptations.
2430 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2431 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2433 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2435 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * Adaptation for porting to VC++:
2438 o forced to use std namespace (for string to be known)
2439 o all class use __declspec export style on WIN32
2440 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2441 (in stdlib.h on Win32 but in std:: for gcc)
2442 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2443 variable GDCM_DICT_PATH.
2444 * src/gdcmHeader.cxx verbose comments made discrete.
2446 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2447 * python/gdcm.i: added a typemap that converts a C++ hashing table
2448 to native Python dictionary.
2449 * python/demo/test.py:
2450 - now uses the native dictionary for exploration of gdcmHeader.
2451 - takes an optional filename argument (the file to parse).
2452 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2453 PubElVals hashing table.
2454 * Dicts/dicomV3.dic removed error prone trailing spaces.
2456 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2457 * Python wrapping process moved away from src/Makefile to
2458 newly created python/Makefile (as well as gdcm.i)
2459 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2460 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2461 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2462 from the environement variable GDCM_DICT_PATH (when existing).
2463 * src/gdcmDict::GetTag bug fix.
2465 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * Straightforward temporary fixes for swig to build the python wrappers.
2467 src/Makefile now has a python working entry [by working we mean
2468 that we can import de shadow classes without errors].
2470 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2471 * hashtest.cxx removed (since allready in Test)
2472 * src/gdcmlib.h renamed to src/gdcm.h
2473 * src/dcm.i renamed to src/gdcm.i
2474 * src/Makefile prepared for python wrapping
2476 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2477 * src/gdcmHeader.cxx :
2478 - Parsing of header is now separated from loading of element values
2479 (see gdcmHeader::LoadElements).
2480 - general clean up of hopefully all file access (creation of
2481 ReadInt16 and ReadInt32)
2483 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2484 * src/gdcmHeader.cxx :
2485 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2487 - SetLgrElem renamed to SetLength
2488 - GetLgrElem renamed to GetLength
2489 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2490 * src/gdcmElValSet.cxx fixed both GetElValue methods
2491 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2492 due to IdoDude was cleaned out.
2494 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2495 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2496 concentrates on finding the value representation (when it exists).
2497 RecupLgr now only finds the element value length, and it avoids
2498 returning the unecessary skL (skipped length).
2499 Also, offsetCourant was simply removed (with taille_fich) since
2500 it was redundant with the File position internals (by using
2501 ftell and fseek). This also made skL (see above in RecupLgr) usage
2503 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2504 on the libido specificities which are handled through class
2506 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2509 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2510 * Truckload of changes. Parsing of header is barely functional
2511 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2513 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2514 * src/gdcmHeader.cxx many addons of low level methods
2516 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2517 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2518 and _IdDcmSWAP_LONG.
2520 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * This corresponds to all the changes decided at the meeting of
2522 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob