1 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
3 correct to copy it. The DictEntry is specified at the DocEntry creation,
4 then, it musn't change in the time.
5 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
6 header correctly. At this time, the change is only made for the first
7 level of the Document. In the future, it might consider sequences.
8 The change is made by replacing a DocEntry by an other that is created
9 outside the class. The old value is kept. When we restore the header
10 status, the added DocEntry is deleted and replaced by the old value.
11 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
12 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
13 set the write type to explicit VR, implicit VR or ACR. Add methods to set
14 the write mode to native, decompressed or RGB (but not used at this time)
16 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
18 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
20 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
22 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
24 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
25 set because already copied when copying the BinEntry's of the header
26 * Test/TestAllReadCompareDicom.cxx : remove warnings
28 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
30 Two problems appear when doing it :
31 - with the gdcmFile : when the GetImageData method is called, the pixels
32 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
33 datas (pixels). And each structure destruct the datas when it's
34 destructed. So we have two destructions for the same datas. To solve it,
35 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
36 datas or not. If it doesn't own datas, then they will not destroyed by
38 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
39 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
40 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
41 create a double destruction of the same DocEntry's. So, to solve it,
42 the TagHT is simply cleared and the DicomDir* elements are destroyed.
43 * TODO : add an entry concerning memory leaks in the DicomDir
45 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
47 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
50 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
52 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
53 after it have been deleted
55 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
56 * FIX: src/* fix the doxygen warnings.
57 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
58 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
59 was erroneously defined with a size of 15 instead of 16. [many thanks
60 to Jean Michel Rouet for pointing out this bug].
62 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
63 1. Finish merging JMR patch for writting DICOM from scratch
64 2. Fix -hopefully- bug with MONOCHROME and space vs null character
65 3. Use const ref when possible
66 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
67 5. A few more comments
68 6. CreateUniqueUID can now be called without parameter"
70 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 * ENH: Slightly bigger patch:
72 1. Getting toward full integration of JMR patch for writting dicom from scratch
73 2. Update Test to test part of this patch: CreateUniqueUID
74 3. File was not close properly in gdcmDict
75 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
76 5. Use of const ref instead of copy (speed issue)
77 6. Remove temporary (duplicate) string in TranslateToKey
78 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
79 8. Do not repeat virtual in subclasses
80 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
82 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
83 * Apply first patch toward better string comparison when dealing with broken
84 DICOM files. Essentially the string could be padded with a space instead
85 of a null character as defined by standard
87 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
89 because never used... and in the same time, that's remove some memory leaks
91 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
92 * src/gdcmFile.cxx : now delete the PixelConvert instance.
93 * In examples and tests : change the type of image data variables from void*
94 to uint8_t*. Remmove all delete on image data variables
96 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
98 Verify the file pointer value before open the file, and if it's not null,
99 a verbose message is generated.
100 Close correctly the file when the file isn't considered dicom-like. The
101 correctly close is a call to CloseFile.
102 When closing the file pointer, test if its not null to close the file.
103 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
104 file. For an uncompressed image, the copied datas correspond in the least
105 case to the image size (calculated) or the image size specified in the
106 header. A verbose is generated if these two size mismatch
108 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
110 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
111 break under windows (with msvc6 compilation).
113 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
115 compiling with MSVC6)
117 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * Bugs fix for the Windows build with VC6
119 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
120 needed (only for projects required VTK). If the VTK is included in all
121 projects, there is conflicts with the jpeg lib of vtk when compiling the
122 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
123 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
124 when compiling the gdcm_wrap.cxx file (created by the compilation of the
126 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
127 (like it's already made for the cout use). Otherwise, conflict with the
130 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
131 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
133 - comments on the DicomDir::Method related usage added.
134 - now that we use the namespace gdcm, a lot of internal classes do
135 NOT need to be wrapped anymore.
136 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
137 DicomDir::Method) new example added.
139 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
140 * Improve string manipulation. I now inforce the notion of 'DicomString'
141 A DicomString can contain as many \0 as they want
142 and it is *always* of even length.
143 We only support odd length for very rare case.
144 And in the near future this should be removed.
146 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
147 * /binary_write/ gdcm source. Now even on big endian we are writting
148 little endian. This should -heopfully- fix some tests
150 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
151 * Now the dictionary is compiled into gdcm lib. This is a default
152 behavior, thus any dic file specified is picked before failback to
153 the one comiled into lib
155 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
156 * Change internals for gdcmDict. Don't use any 'new' any more.
157 This should definitely solve any leak problem, and we should be
158 as fast as before, as long as don't modify too much the dictionary.
160 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 * STYLE: ivars should start with a capital letter.
162 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
163 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
165 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
166 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
167 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
168 new 2004 dictionaries added (thanks to JPR).
169 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
170 * CLEANUP_ROUND (15) for gdcmPixelConvert
171 - RLEFrame::NumberFragments is now of type unsigned int
172 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
173 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
176 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
177 * Initial work in gathering all transfer syntax accessors. clearly
178 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
179 ivars, but only one transfersyntax (class) ivar with equivalent method on
182 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
183 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
184 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
185 discussed (plus I didn't like having a 2000 lines patch not commited)
187 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
188 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
189 * CLEANUP_ROUND (14) for gdcmPixelConvert
190 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
191 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
192 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
194 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
195 anymore and hence avoids storing a copy of PixelConvert::Decompressed
196 into File::Pixel_Data.
198 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
199 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
200 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
201 * CLEANUP_ROUND (13) for gdcmPixelConvert
202 Substituted File::ParsePixelData() with PixelConvert::Print() new
204 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
205 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
206 method to those classes.
207 - src/gdcmFile.[cxx|h]:
208 -- Added a ::Print() method.
209 -- PixelConverter is now a reference instead of a member.
210 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
211 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
213 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
214 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
215 collaboration diagram and inheritance diagram should be generated with
217 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
218 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
219 pointlessly wrapped (see
220 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
221 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
222 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
223 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
224 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
225 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
226 -- File::Initialise: PixelConverter setup moved away to
227 PixelConverter::GrabInformationsFromHeader()
228 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
229 interpretation moved away to PixelConverter::BuildRGBImage()
231 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
232 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
233 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
235 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
236 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
237 displayed on Win32 when a brutal abort() occurs (because of uncatched
238 exception). See TODO new entry of this commit for more on this.
239 * TODO added new entry.
240 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
241 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
242 - HandleColor is no longer called from gdcmFile.cxx
243 - gdcmPixelConvert.cxx clean up on method arguments and internal
244 variable names for semantical coherence.
246 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
247 * Finished lossless transition, not only do we now read all lossless jpeg
248 images, without the need of the Cornwell lib, but we do read them properly now
249 * To reduce code (well to avoid code duplication), I defined a common place
250 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
251 redefine symbols. This is not prefect but this the best solution I found for a
252 compilation time jpeg option.
254 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
255 * Update jpeg ijg lib to support lossless jpeg implementation
256 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
258 * Also added a special copyright for dcmtk since we use their bugfixes.
261 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
262 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
263 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
264 matters, as stated in warning note at begining of %include section).
265 * src/gdcmDicomDir*.[cxx|h]: coding style
266 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
267 * src/gdcmJpeg8.cxx: doxygen fix.
268 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
269 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
270 from File:: to PixelConvert::.
272 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
273 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
274 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
275 - more code moved away from File:: to PixelConvert::
276 - fat setup of PixelConverter set in place in File::Initialise.
278 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
279 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
280 namespace at the file system level. So now you should convert your examples
282 gdcmHeader -> gdcm::Header
283 It would be nice if people keep in mind to no open the namespace, since it
284 allows compilation on broken plateform which were defining common symbol in
285 the standart namespace (like LP, Unknown ...)
287 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
289 The JPEG fragments are now parsed at the same stage than the RLE
290 information. All code related to JPEG is now in gdcmPixelConvert:
291 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
292 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
293 export a gdcmFile:: method. Those are simply global functions
294 (for the time being this is better than having them attach to
295 either gdcmFile:: or gdcmPixelConvert::).
296 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
297 and stores the result in a gdcmJPEGFragmentsInfo.
298 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
299 code (among other stuff) moved away from gdcmFile:; to
302 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
303 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
304 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
305 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
306 clean up of RLE related code.
307 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
308 - src/gdcmRLE.cxx removed
309 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
310 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
311 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
312 * CLEANUP_ROUND (9) for gdcmPixelConvert
313 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
314 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
315 away from gdcmFile:: to gdcmPixelConvert::.
317 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
318 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
319 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
320 This is because Parse7Fe0 used to parse the pixels to compute the
321 length. This task was passed over to FindDocEntryLengthOB() a long
322 time ago, EXCEPT I had forgotten the OW case...
323 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
324 we just recylce the code for parsing RLE fragments and computing
326 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
327 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
328 with the retired Parse7Fe0().
329 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
330 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
332 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
334 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
335 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
336 - src/CMakeLists.txt: alphabetic order reodering + new entries.
337 * CLEANUP_ROUND (4) for gdcmPixelConvert
338 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
339 to return an unused length.
341 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
342 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
343 this should be cleanner from the plane view. The iostream are erally a pain
344 to use to do simple stuff.
346 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
347 * Redo the compilation of the ijg jpeg library. Now only one source is
348 necesseray. No need to rename file by hand what so ever. CMake handle the
349 copying of the file within different directory, configure header file to
350 modify some symbol. The only addition made to ijg wasd a mangle table so
351 that symbol are different wether we are within 8bits or 12bits.
353 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
354 * Added documentation of vtkgdcmReader on Website:
355 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
356 with it's binary name).
357 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
358 the Website to be more complete.
359 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
360 doxygenated documentation.
361 - Doc/DoxyVtkGdcmReaderExamples.txt added
362 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
363 DoxyVtkGdmReaderExamples.html )
364 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
365 * CLEANUP_ROUND (3) for gdcmPixelConvert
366 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
368 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
369 * CLEANUP_ROUND (2) for gdcmPixelConvert
370 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
372 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
373 * CLEANUP_ROUND for gdcmPixelConvert:
374 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
375 - src/gdcmPixelStuff[h|cxx] removed
376 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
377 - src/CMakeLists.txt changed accordingly
379 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
380 gdcmVersion.py moved to newly created ATTIC related
381 gdcmPython/SetupOldies/ directory.
382 * Autotools clean up:
383 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
384 - autogen.sh configure.in acinclude.m4 python.m4 removed
386 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
387 * src/*.cxx *.h Reference to License.htm fixed to License.html.
388 * Doc/CMakeLists.txt, doxygen.config.in: fix.
389 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
391 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
392 * TODO updated with Mathieu suggestions. I proposed a template for
393 describing TODO entries and used it for new entries.
394 * Added Doc/Website/CodingStyle.html, Developpers.html,
395 DeveloppersPython.html, GdcmDataCvs.html and
396 DownloadVersion0_1.html, DownloadVersion0_3.html.
397 * Some Doc/*.txt Doxygen files (which do not really concern the
398 documentation itself, but the website) moved to html and
399 placed in directory Doc/Website:
400 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
401 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
402 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
403 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
404 * CMakeLists.txt changed accordingly.
405 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
406 DeveloppersPython.html
407 * INSTALL nows refers to Doc/Website/Installation.html
409 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
410 * Added Doc/Website directory, that contains a first raw version
413 2004-09-23 Jean-Pierre Roux
414 * FIX In order not to be poluted any longer by casting problems,
415 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
416 we can now delete[] it safely
417 * VoidArea is now called BinArea (less confusing name),
418 and all the methods called ...VoidArea... are now ... BinArea...
419 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
421 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
422 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
423 clear) TagHT, which is an inherited member of gdcmElementSet. It is
424 up to the destructor of gdcmElementSet to clean up TagHt and it's
427 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
428 * Test/CMakeLists.txt: update to follow gdcmData renamings.
429 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
431 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
432 * ENH: added some utility method that builds a flat dictionnary
433 holding all the Dicom entries contained in the recursive structure
434 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
436 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
437 BuildFlatHashTable() that build a flat dictionary.
438 - src/gdcmElementSet.h: added a new private GetTag() accessor.
439 gdcmDocument is now a friend of gdcmElementSet.
440 - src/gdcmElementSet.cxx: clean up.
441 - Example/FlatHashTablePrint.cxx added.
442 - Example/CmakeLists.txt changed accordingly
444 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
446 moved away from gdcmDocEntrySet (since this class is an abstract class
447 acting like an interface). SQDepthLevel and BaseTagKey are now
449 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
450 and associated accessors. Doxygenation of the class.
451 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
453 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
454 Use SQDepthLevel accessor instead. ::Print() adapted.
455 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
456 - src/gdcmDocument.cxx changed accordingly.
458 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
459 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
460 - The following is the doxygen comment of the typedef declaration
461 of gdcmagKey in src/gdcmCommon.h:
462 gdcmTagKey is made to old an "universal" (as in URL, Universal
463 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
464 A dicom tag allways has a group and an element, but a set of tags
465 embeded in various (optionally nested) sequences and sharing
466 the same group and element all share the same (group, element)
467 "identifier". Hence the (group, element) cannot be used as an
468 identifier (in gdcm we shall refer to a "TagKey") of a tag.
469 In order to construct a proper tag identifier (i.e. a key) we
470 consider the following definition of a TagKey:
471 - let Group, Element be the string representation of the
472 group and element dicom tag members,
473 - let ItemNumber be the string representation of the integer
474 index of the considered item number of a sequence,
475 Let the key of a tag embeded in a sequence, noted SeqTag, be
477 /ItemNumber#Group|Element
478 where "/", "#" and "|" are characters acting as separators.
479 Then the general form of a gdcmTagKey is given by:
480 Group|Element<SeqTag>
481 where <SeqTag> means NO or many instances of SeqTag.
482 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
485 but the gdcmTagKey of a tag "embeded" is the first item of
486 a sequence, itself nested in the third item of a sequence is the
488 0004|1220/2#0008|0082/0#0008|0090
489 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
490 order to hold the new sequence compatible key. Previously, the
491 GetKey() method would look in the underlying gdcmDictEntry.
492 - src/gdcmDocEntry.cxx:
493 -- constructor now copies the underlying DictEntry key, in the local
495 -- ::Print: displays the member Key, instead of the (group, element).
496 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
497 - src/gdcmDocEntrySet.h:xi
498 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
499 -- now has a new BaseTagKey member.
501 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
502 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
504 This poses the problem with the semantics of the following lines
505 LoadEntryVoidArea(0x0028,0x1201); // R LUT
506 LoadEntryVoidArea(0x0028,0x1202); // G LUT
507 LoadEntryVoidArea(0x0028,0x1203); // B LUT
508 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
509 to the long FIXME note for what the problem is. Nevertheless in
510 order to get things working the dicom dictionary was altered !
511 Please fix things urgently...
512 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
513 information), see above note on moving the member VoidArea. Nevertheless
514 the following entries previously correctly set as US are now inproperly
516 0028 1201 OW IMG Red Palette Color Lookup Table Data
517 0028 1202 OW IMG Green Palette Color Lookup Table Data
518 0028 1203 OW IMG Blue Palette Color Lookup Table Data
519 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
520 of gdcmDocEntry moved to gdcmSeqEntry.
521 * src/gdcmSeqEntry.cxx: STYLE.
523 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
524 * Test/TestAllEntryVerify.cxx minor fix and added comments.
526 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * gdcmPython/testSuite.py: all the test suite in python is now moved
528 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
529 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
530 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
532 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
533 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
534 to avoid inclusion recursion until STL is reached.
535 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
536 mecanism. errno.h is not included in gdcm anymore.
537 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
538 (gdcmFormatError now inherits from gdcmFormatUnexpected).
540 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
541 gdcmData/TestAllEntryVerifyReference.txt
542 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
543 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
544 exception_on_error parameter.
545 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
546 - vtk/vtkGdcmReader.cxx changed accordingly,
547 - Example/*.cxx and Test/*.cxx changed accordingly.
549 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
551 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
552 enable_sequences removed from gdcmHeader constructor and dependencies.
553 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
554 * gdcmPython/demo/PrintHeader.py: dummy fix.
555 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
556 skip_shadow removed from gdcmHeader constructor and dependencies.
557 * Example/*.cxx and Test/*.cxx changed accordingly.
559 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
560 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
561 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
563 2004-07-21 Jean-Pierre Roux
564 * FIX Now, Parsing and Printing a DICOMDIR do work!
565 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
567 2004-07-20 Jean-Pierre Roux
568 * FIX Some brain damaged headers have Zero-Lenght fields
569 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
571 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
572 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
573 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
574 variable (instance of gdcmDebug) by a definition macro, and the instance
575 is now in static in the gdcmDebug class
576 * src/gdcmSQItem.h : (FIXME) remove an undefined method
577 * Test/PrintAllDocument.cxx : bug fix in the result of the test
579 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
580 * WARNING: ctest now depends more tightly on gdcmData. You should
581 check out gdcmData properly for things to run smoothly...
582 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
583 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
584 we need the pixels not be loaded in order to use the ValEntry
585 that displays position and size).
586 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
587 This is a C++ based equivalent of gdcmPython/testSuite.py that should
588 be deprecated. If you have any doubts about the advantages of a
589 modern scripting language (read Python) versus grass root C++ (i.e.
590 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
591 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
592 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
593 Anyhow, consider documenting the gdcmData images in
594 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
596 * Test/CMakeLists.txt:
597 - now uses TestAllEntryVerify.cxx
598 - specific comments on oldACR00001.ima (now renamed in gdcmData
599 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
600 gdcmData/TestAllEntryVerifyReference.txt
603 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
604 * src/*.[h|cxx] : typedef clean up
605 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
606 - TagKey renamed to gdcmTagKey (for external usage)
607 - VRKey renamed to gdcmVRKey (for external usage)
608 - removal of typedef duplication.
609 - Removed all unecessary inline keyword from class inline definitions.
610 - Some method|function(void) declarations replaced with method|function().
611 * src/jpeg/libijg12/jdhuff12.c:
612 - printf polluting ctest removed.
613 - TAB removal for comminting
615 - TestAllReadCompareDicom.cxx: added a test that compares all the
616 images in gdcmDataImages.h with corresponding images in
617 gdcmData/BaselineDicom/. When baseline images are not present
618 this test creates them.
619 Note: we need to validate each reference image, but before that
620 I'd like to rename them with a more explicit name...
621 - CMakeLists.txt: changed accordingly.
622 * Example/*.cxx: examples now only include gdcm.h (as opposed to
623 including each header needed).
625 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
626 * Test/*.cxx and Example/*.cxx: moved some examples away from the
627 test suite to the Example directory. Are concerned:
632 - TestWriteSimple.cxx
633 * Test/CMakeLists.txt: added some comments on reasons for black listing
634 image gdcmData/oldACR00001.ima
636 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
637 * Test/CmakeList.txt: removed the following from black list (to be coherent
638 with removal from gdcmData):
639 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
640 - gdcm-MR-PHILIPS-16.dcm
642 Added the following because after last cvs update, they cause
643 ctest -R TestReadWriteReadCompare
645 - gdcm-MR-SIEMENS-16-1.acr
647 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
648 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
649 new comments in this file) we temporarily (sigh) move to a weaker
651 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
652 we don't need to black list the following images anymore:
653 - 8BitsUncompressedColor.dcm
655 - US-PAL-8-10x-echo.dcm
656 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
657 fixes and the beautified code ;-)
658 This fixes the bug introduced in version 1.42 (when beautifying)
659 that made the parsing of 8BitsRunLengthColor.dcm unproper.
660 Note: ctest was blind to this bug (this means we need to still
661 improve the test suite). The bug could be detected by using
662 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
664 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
665 and by displaying the (garbage) produced file temp.XDCM...
667 2004-06-29 Jean-Pierre Roux
668 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
669 - replace by uggly but working old code :-(
670 A lot of things should be OK again.
671 It's really urgent to have a test suite that *tests*,
672 to prevent Frog's beautifying sessions to break all the stuff
673 (twice, withing a fortnigh ...)
675 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
676 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
677 redundancy) to added Test/TestReadWriteReadCompare.cxx
678 * Test/CmakeList.txt: because the compare test of
679 Test/TestReadWriteReadCompare.cxx fails, the following images are
680 black listed: - 8BitsUncompressedColor.dcm
682 - US-PAL-8-10x-echo.dcm
683 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
684 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
685 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
686 and ad-hoc kludge. This kludge is now removed, and on encountering
687 such an image (OB field brain damaged) we set errno. Then in
688 ::FindDocLength() we "fix" the length as being ALL what remains
689 in the file (until EOF). We then proceed, hoping for the best...
690 This fixes a SegFault in ShowDicom when trying to write such an
692 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
693 (because TestWriteRead breaks on it, after a non conformal commit?).
694 ctest now runs properly, except for MakeDicomDir (which was allways
695 broken) and the Python related stuff (still not fixed).
697 2004-06-24 Jean-Pierre Roux
698 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
699 FIX : Test/TestReadWrite now iterates on all the file names
700 (instead of infinite loop)
701 ENH : Test/TestWriteRead now iterates on all the file names
703 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
704 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
706 2004-06-24 Jean-Pierre Roux
707 FIX : - now Write drops LUT Descriptors and LUTs (if any)
708 when SamplesPerPixel =3
709 - now Write is no longer confused by
710 'BitsAllocated = 12" and 'BitsStored=12"
711 - "UN" value representation Elements are now written correctly
712 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
713 ENH : - now gdcmHeader has its own Write methods
714 (in order to split the job that has not to be done
717 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
718 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
719 loop on the same image until memory went out.
720 Note: this means we still have gobs of memory loss in PrintDocument
721 * src/gdcmDocument.cxx: fixes problem on parsing on file
722 gdcmData/16BitsJpegLosslessGrayScale.dcm.
724 2004-06-24 Jean-Pierre Roux
725 FIX : Write - All the Sequences and Sequence Item are now written
726 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
727 is added a the end, when necessary.
728 - A lot of brain-damaged images, that were read correctly are
729 now written correctly
730 - length compatible BinEntry are now loaded correctly
731 (even for odd groups)
732 Note : only Explicit Value Representation was checked.
733 (question : is implicit VR really necessary for gdcm ?)
735 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
736 * DEVELOPPER: added a proposition of coding style.
737 * src/gdcmDocEntry.h: removed every inline declaration (for test of
740 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
741 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
742 Use the gdcmDocEntry::Print() and Write() instead.
743 * src/gdcmDocument.cxx: bug fix.
745 2004-06-22 Jean-Pierre Roux
746 FIX : gdcmDocument.cxx
747 - Now we do recognize the JpegLossLess format (there was a misstyping in
748 code 'beautyfication' :-(
749 - Now we automaticaticaly load the Luts, if any
751 2004-06-22 Jean-Pierre Roux
752 In order : to write Sequences, whatever their imbrication level,
753 : to allow user to create his own Sequences
754 a lot of modif where necessary (adding, moving, or virtualising methods)
756 WARNING : save your own sources *before* cvs up !
759 ADD virtual void Write(FILE *fp, FileType filetype);
762 ADD virtual void Write(FILE *fp, FileType filetype);
763 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
766 ADD virtual void Write (FILE *fp, FileType filetype)=0;
767 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
768 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
769 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
770 ADD std::string GetEntryByName(TagName name);
771 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
773 std::string vr = "unkn",
774 std::string fourth = "unkn",
775 std::string name = "unkn");
776 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
777 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
778 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
779 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
780 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
781 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
782 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
783 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
786 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
787 ADD virtual std::string GetEntryByName (TagName tagName);
788 ADD virtual std::string GetEntryVRByName (TagName tagName);
789 REM virtual bool Write(FILE *, FileType);
790 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
791 FILE *_fp, FileType type);
792 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
793 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
794 REM virtual bool WriteEntries(FILE *_fp,FileType type);
795 REM virtual std::string GetEntryByName (std::string tagName);
796 REM virtual std::string GetEntryVRByName (std::string tagName);
797 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
798 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
799 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
801 std::string vr = "unkn",
802 std::string fourth = "unkn",
803 std::string name = "unkn");
804 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
805 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
806 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
807 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
810 ADD virtual void Write(FILE *fp, FileType filetype);
813 ADD virtual void Write(FILE *fp,FileType filetype);
816 ADD virtual void Write(FILE *fp, FileType filetype);
817 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
818 REM std::string GetEntryByNumber(guint16 group, guint16 element);
819 REM std::string GetEntryByName(TagName name);
822 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
824 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
825 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
826 The default constructor invoked by the line
827 gdcmHeader *f1 = new gdcmHeader( header );
828 was gdcmHeader::gdcmHeader(bool) instead of the expected
829 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
830 Hence the parsing wasn't executed... See also below.
831 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
832 as explicit constructor didn't do the trick to fix the above problem.
833 Could anyone explain why ?
834 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
835 properly calls gdcmValEntry::Print() (that was weed out from
836 code related to gdcmBinEntry).
838 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * In order to fix memory leaks:
840 - Test/TestWriteSimple.cxx: added cleaning of free store through
842 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
843 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
844 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
845 (through the call to ::AddDicomDirMeta()) or the destructor
846 would crash when deleting uninitialized ::metaElems].
847 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
848 - src/gdcmDocument.cxx:
849 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
851 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
852 was causing memory leaks.
853 - src/gdcmSQItem.cxx:
854 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
855 cleanly handled with polymophism: sorry but my milage is low).
856 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
857 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
858 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
859 This avoids SegFaulting.
860 - src/gdcmSQItem.h: coding style.
862 - Test/TestWriteSimple still severely sucks. The output image content
863 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
864 damaged when displayed with vtkgdcmViewer.
865 - on memory leaks: TestWriteSimple leaks really less (see entry
866 of 2004-06-18 in Changelog file for the call to valgrind).
867 - on segfaults: ctest now passes all the tests but one (no more
869 * Erroneous leading white fix:
870 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
871 white[s] (as opposed to from >> xxx, that removes it [them].
872 - src/gdcmTS.cxx: ditto.
873 - gdcmPython/testSuite.py: dirty related kludge removed.
874 * src/*: remaining references to gdcmParser removed.
875 * src/*[cxx|h]: added copy[way]left header.
878 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
879 * In order to fix writing of dicom files:
880 - Test/TestWriteSimple.cxx: a simpler example of writing.
881 - Test/CMakeLists.txt changed accordingly.
882 - src/gdcmDocument.cxx:
883 -- The destructor now recursilvely removes potential sequences.
884 -- Bug fix in ::IsJPEG2000()
885 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
886 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
888 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
889 to only declared) and build on top of
890 ::GetDocEntryByNumber(guint16, guint16).
891 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
892 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
893 for usage in destructor and treatement of promotion in
894 ::ReplaceOrCreateByNumber().
895 - src/gdcmSQItem.cxx: destructor should better handle his job.
896 Test/TestWriteSimple now runs (or at least it DOES something).
897 * We can now start hutting memory links. A good starting point is:
898 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
899 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
900 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
902 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
903 * Valgrind note: after Mathieu Malaterre teached me how to read
904 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
906 Using gcc, you can force the STL to use malloc and to free memory as
907 soon as possible by globally disabling memory caching.
908 With 3.2.2 and later, you should export the environment variable
909 GLIBCPP_FORCE_NEW before running your program.
910 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
911 simply vanish (it is still not clear to me, whether this means that
912 STL std::string leaks or if valgrind believes it leaks...).
913 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
914 running bin/gdcmTests makeDicomDir):
915 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
916 - Test/makeDicomDir.cxx now properly traps empty lists and returns
918 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
919 SegFaulting (I drowned in DicomDir related code when trying to
920 understand why the list is empty...).
921 * src/gdcmDocument.h: first BSD license header try.
922 * Doc/License.txt added.
924 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
925 * src/gdcmDocument.[h|cxx]:
926 - Clean up of the Transfer related predicates. They are now all based
927 on new method isGivenTransferSyntax, that (should) handle properly
929 - general clean up, simplification, and coding style.
930 - Specific clean up of Parse7FE0() (umproperly named actually).
931 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
933 2004-06-14 Jean-Pierre Roux
935 - fix the display of Sequence Delimitor (SQDepthLevel pb)
936 - fix the display of SQItem ordinal number
937 - add the GetSQItemByOrdinalNumber method
938 - remove some useless never written private methods
940 2004-06-14 Jean-Pierre Roux
942 - adding a constructor taking a gdcmDocEntry as an input param
943 - ReplaceOrCreateByNumber now returns :
944 a gdcmBinEntry * if a Binary (void *) value is passed as a param
945 a gdcmValEntry * if a string value is passed as a param
947 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
948 according to the param type (no longer sets a gdcmDocEntry)
949 - GetValEntryByNumber, GetBinEntryByNumber added
950 - NewValEntryByNumber and NewBinEntryByNumber added
952 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
954 - GetSQItemNumber and SetSQItemNumber added, to provide
955 a (relative) Item identier inside a given Sequence
956 \warning : some pb remaining around this number
958 - AddEntry now takes the Item Number as a param
960 - adding a constructor taking a gdcmDocEntry as an input param
962 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
963 * Memory leak hunt with the following command:
964 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
965 --show-reachable=yes gdcmTests PrintDocument
966 It looks like many (all?) leaks are due to the STL (or a bad usage
967 of the STL. The lines producing the leaks now have a comment with
968 a "MEMORY LEAK" tag: you can retrieve them with
969 grep "MEMORY LEAK" src/*
970 Here are two typical examples which I can't help fixing:
975 char * test = "babo";
976 name = test; //// <--- valgrind detects 960 bytes lost in
977 //// call to std::string::operator=(char const*)
978 name.clear(); //// Doesn't help !
986 std::cout << "Type a bunch of characters followed by RETURN: ";
987 getline(std::cin, line); //// <--- valgrind dectects a loss
988 //// of 1320 bytes in call to
989 /// std::basic_istream<>& std::getline<>
995 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
996 * src/gdcmHeader.[cxx|h]:
997 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
998 and related, moved away to gdcmDocument.
999 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1000 the corresponding protected accessors of inherited class
1001 gdcmDocument, removed ! As a consequence gdcmFile had to be
1002 declared friend of class gdcmDocument (see below).
1003 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1004 - Clean up of undefined or unused methods.
1005 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1006 account the changes to gdcmHeader.h).
1007 * src/gdcmDocument.h:
1008 - gdcmFile is now a friend class (in order to take into account the
1009 changes to gdcmHeader.h).
1010 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1011 (see changes to gdcmHeader.h).
1012 - Accessors (reading on the form GetEntry*) are now public.
1013 - Clean up of undefined or unused methods.
1014 * src/gdcmDocument.cxx:
1015 - adaptation to changes to gdcmDocument.h
1016 - ::OpenFile now writes a verbose message when file cannot be opened.
1017 - some std::string properly set to VRKey
1018 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1019 references to gdcmDocument.
1020 * Test/TestFindTags.cxx: changed accordingly to above changes.
1021 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1022 cvs repository gdcmData.
1024 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1025 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1026 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1027 conflicts with gdcmValEntry::voidArea.
1028 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1029 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1030 Value representation between StringRepresentable and BinaryRepresentable.
1031 * src/gdcmDocument.cxx:
1032 - method ParseDES: proper indentation restored and usage of
1033 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1034 - method LoadDocEntry: the fingerprint left in the SetValue() of
1035 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1036 removed. Reverting to previous code segment with the proper
1037 dynamic_cast< gdcmValEntry* >.
1038 Note: this was (partially) breaking the python test suite
1039 (gdcmPython/testSuite.py) that made usage of the above
1040 fingerprint to check presence of "Pixel Data".
1041 * src/gdcmDocEntry.h: coding style.
1042 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1043 now taken into account.
1044 * gdcmPython/gdcm.i: adaptation to the new internal representation
1045 of gdcm (exit gdcmParser, hello gdcmDocument).
1046 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1048 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1049 anymore, but instead prints the loaded Python dictionary.
1050 * .... alas, the python testSuite is still broken.
1052 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1053 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1055 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1056 * src/gdcmUtil.h : export methods
1058 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1059 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1061 * Initial addition of automatic python testing
1062 * Initial addition of automatic image comparison
1064 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1065 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1066 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1068 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1069 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1070 * Test/ShowDicom.cxx : bug fix for msvc compilation
1071 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1073 2004-05-04 Jean-Pierre Roux
1074 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1075 new concepts (and new classes) :
1076 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1077 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1078 - Sequence Doc Entries (gdcmSeqEntries)
1079 a Sequence is composed of Items.
1080 Each item is a set of Doc Entries (this is recursive)
1081 The non uniqueness of the 'Dicom tag' is due to this recursivity
1082 (never taken into account)
1083 Our unability to add a new 'entry' in the header
1084 at the proper location (neither in the H-Table (map or multimap),
1085 nor in the Chained List is also due to this recursivity.
1086 Don't try, right now, to use/modify/compile these new sources :
1087 nothing is finished.
1088 We just commit all the stuff, 'as is', in order not to loose it.
1090 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1091 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1093 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1094 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1095 file prefix (SetFilePrefix)
1097 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1098 * Add a new test: ShowDicom, for now this is just the c++ version of
1099 checkRead.sh, later it will be able to compare the image read against a
1101 * Replace the DEBUG on the stack with a global entry in cmake interface:
1102 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1104 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1105 * Add an example subdir, with a real example on how to read + write a
1108 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1109 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1110 * Doc/CMakeLists.txt: the main page is now properly differentiated
1111 between the developper and user version.
1112 * Doc/doxygen.config.in: dropped search related obsolete flags
1113 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1115 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1116 * DEVELOPPER: added some helpfull comments for compile/test/install
1119 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1121 src directory, now generated in the build dir.
1122 2. Tests as mentionned smarter
1124 4. Add a new method in gdcmDict that return the PubDict by name
1125 this is interesting for 3rd party lib like ITK,
1126 where we could set the institution name / patient name...
1128 * ENH: 1. Now the test suite is working for real
1129 2. All binaries are now output in the gdcm-bin directory
1130 (this was not true before)
1132 2004-04-28 Jean-Pierre Roux
1133 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1134 SeQuence indented printing of Dicom Header.
1135 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1136 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1137 Computation of SQDepthLevel is now part of gdcmHeader constructor
1138 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1139 tree-like structure of a Dicom Header.
1140 * FIX Test code cleaning
1142 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1143 * ENH: Adding automatic testing
1144 1. Need a DartConfig.cmake to submit to public
1145 2. Add a test driver gdcmTest.cxx
1146 3. gdcmTestMain, an helper for the main test driver gdcmTest
1147 4. Files in Test don't have a main anymore, this becomes interesting
1148 when we add more and more tests, thus dsw don't have to load
1150 * ENH: Adding a GDCM_DATA_ROOT for testing
1151 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1152 one file instead of seven + some small cleanup
1154 2004-04-22 Jean-Pierre Roux
1155 * ENH Minor changes to the Print() methods.
1156 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1157 Header printing. Example given with :
1158 > PrintHeader fileName 2 new
1159 (SQ based tree-like structure still to be done for the Header ...)
1161 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1162 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1163 1. I have added some unsigned where needed
1164 2. Some function parameter not used -> (void)
1165 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1166 4. g++ don't like character '\' in comment
1167 5. #define jpeg_create_decompress jCreaDecompress
1168 this really need to be fixed
1169 6. virtualize destructor of gdcmObject ... leakage
1170 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1171 this also really need to be fixed
1172 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1173 remove compression file
1174 (as we only do decompression, right ?)
1175 * ENH: Change malloc/calloc/free with c++ equivalent
1177 2004-04-21 Jean-Pierre Roux
1178 * FIX gdcmHeaderHelper::GetXSpacing
1179 when a single value is found (bug ?), xpacing is now
1180 defaulted to yspacing
1182 2004-04-19 Jean-Pierre Roux
1183 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1184 * ENH add parameters :
1185 bool exception_on_error = false,
1186 bool enable_sequences = false,
1187 bool ignore_shadow = false
1188 to the gdcmFile constructors to be full gdcmParser compliant
1189 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1190 to allow reading of PAPYRUS 3.0 files
1192 2004-04-06 Jean-Pierre Roux
1193 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1195 2004-04-02 Jean-Pierre Roux
1196 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1197 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1198 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1200 2004-03-30 Jean-Pierre Roux
1201 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1202 for ACR file, written out as DICOM files (hope so...)
1204 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1205 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1206 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1207 moved to base class gdcmParser and only the specialisation is kept
1209 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1210 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1211 already does the job.
1212 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1213 (to be consistent with gdcmParser::WriteEntries).
1215 2004-03-30 Benoit Regrain
1216 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1217 upate of the object's instance. It's passed to 2 in the unfavorable
1218 case : one in the ExecuteInformation, one in the ExecuteData
1220 2004-03-29 Jean-Pierre Roux
1221 * ENH : Check on file type to be written moved
1222 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1223 * FIX : gdcmObject::ResetBoundaries now stops properly
1224 when end-of-list is reached
1225 : gdcmVersion modified (as Benoit Regrain asked)
1227 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1228 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1229 * src/gdcmUtil.cxx: added forgotten iostream include.
1230 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1231 equivalent to ExplicitVR in existing code).
1233 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1234 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1235 now contains all the gdcmGlobal related code.
1236 * minor coding style and doxygenation changes.
1238 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1239 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1240 now contains all the Debug related code.
1241 * minor clean-up of includes in src/*.cxx
1242 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1243 CreateCleanString) removed.
1244 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1245 * Doc/DoxyMainPageUser.txt added.
1246 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1247 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1248 src/gdcmDirList.cxx)
1250 2004-03-24 Jean-Pierre Roux
1251 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1253 2004-03-23 Jean-Pierre Roux
1254 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1255 big endian made volumes
1256 * ENH Now gdcmParser constructor and destructor are protected to forbid
1257 end user to instanciate class gdcmParser
1258 (only gdcmHeader and gdcmDicomDir are meaningfull)
1260 2004-03-22 Benoit Regrain
1261 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1262 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1263 gdcmSerie to gdcmDicomDirSerie
1265 2004-03-19 Jean-Pierre Roux
1266 * ENH Now the tree-like structure describing a DICOMDIR comming from
1267 an already existing DICOMDIR file is consistent with
1268 the home-made tree-like structure build ex-nihilo
1269 or build from the files held (recursively) in a Directory
1270 functions gdcmDicomDir::CheckBoundaries()
1271 gdcmObject::SetBoundaries() added
1273 2004-03-17 Jean-Pierre Roux
1274 * REM (Eric Boix bug) : removal of meaningless
1275 gdcmDicomDirImage::NewImage function.
1276 * FIX now file names and directory name are written properly in the
1278 * FIX now gdcmDicomDir constructor may be call without any trick
1281 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1282 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1283 of gdcmDicomDirImage::NewImage as empty function.
1285 2004-02-28 Jean-Pierre Roux
1286 * ENH add gdcmDicomDir:NewPatient
1287 add gdcmDicomDirPatient:NewStudy
1288 add gdcmDicomDirStudy:NewSerie
1289 add gdcmDicomDirSerie:NewImage
1290 to allow making gdcDicomDir object.
1291 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1292 (as opposite to the gdcmHeader chained list)
1294 2004-02-11 Benoit Regrain
1295 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1296 when using from python
1298 2004-02-10 Benoit Regrain
1299 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1300 * FIX : in gdcmDicomDir when the directory is empty
1301 * ENH : add callback and methods to get the progression of dicomDir
1304 2004-02-06 Jean-Pierre Roux
1305 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1306 - GDCM_META added to gdcmDicomDirType
1307 - class gdcmMeta created
1308 * ENH : - A brief summary is now displayed at the beginning of
1309 'testDicomDir' to help disaster magnitude estimation
1310 * REM : Now useless Test/explDICOMDIR.cxx
1312 2004-02-05 Benoit Regrain
1313 * ENH : add methods in gdcmObject to get the hash table or the list of
1315 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1316 * FIX : wrapping python for TagHeaderEntryHT
1318 2004-02-04 Benoit Regrain
1319 * FIX : even length for some strings when writting the dicom dir
1320 * FIX : sort the images in the dicom dir
1321 * FIX : Bug fix for python use of dicom dir
1322 * ADD : a python demo
1324 2004-02-04 Jean-Pierre Roux
1325 * FIX : Final solution (?) for icone embedded images
1326 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1327 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1328 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1329 gdcmData/gdcm-MR-SIEMENS-16.acr1
1330 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1331 to make full checking easier
1333 2004-02-04 Benoit Regrain
1334 * FIX : WriteEntries : coding style & logic in parameters
1335 * FIX : Set the elements to create the DicomDir in a dictionary file
1337 2004-02-03 Benoit Regrain
1338 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1339 * gdcmDicomDir : add the load of directory
1340 * Bug fix and print add-on
1342 2004-02-03 Jean-Pierre Roux
1343 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1344 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1345 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1346 * FIX gdcmParser.cxx : 'group length' elements are now considered
1347 as integers, even for shadow groups, when file is Implicit VR
1349 2004-02-02 Jean-Pierre Roux
1350 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1352 of the last synonym :-(
1353 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1355 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1356 * FIX taking into account the possible 7fe0,0010 multiplicity
1357 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1358 to allow removal of references to 7fe0,0010, to deal with
1359 ACR-NEMA images, when 0028,0200 is meaningfull
1361 2004-01-31 Jean-Pierre Roux
1362 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1363 no longer writes 'Un' on disk
1364 * FIX SQ elements with actual length are now dealt with corectly
1365 * FIX gdcmFile::WriteBase make the difference, for color images, between
1366 the length (for Palette expanded images)
1367 and Raw Length (non expanded image + Palette)
1368 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1369 (that broke Write). Replaced by UL.
1370 Aware user will reload the field if he
1371 thinks it's necesssary
1373 2004-01-30 Jean-Pierre Roux
1374 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1375 when 'dirty Acr' is found, to be compliant with the new
1376 IsReadable() methods.
1378 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1379 (no DOUBLE images in kosher DICOM,
1380 but so usefull for people that miss them ;-)
1382 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1383 DICOMDIR related utilities (not checked as Windoze compliant)
1385 2004-01-28 Jean-Pierre Roux
1386 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1388 2004-01-27 Jean-Pierre Roux
1389 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1390 to allow skipping the shadow elements, to save memory space.
1391 The TRUE value for this param has to be used
1392 with a FALSE value for the 'enable_sequence' param.
1393 ('public elements' may be embedded in 'shadow Sequences')
1394 * gdcmHeader methods now deal with 'embedded icones images' in the header
1395 (even when an 'icone image sequence' is announced by the
1396 element (0x0088,0x0200), but there is NO icone at all ...
1398 * gdcmHeader sometimes Image Location value doesn't follow
1399 the supposed processor endianity (see gdcmData/cr172241.dcm).
1402 * gdcmHeader add the method
1403 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1404 to get *all* the Header Entries with the same tag.
1405 GetHeaderEntrySameName is probabely *useless*
1406 (no meaning : Name is *not* an identifier within the Dictionnary)
1408 2004-01-26 Benoit Regrain
1409 * Bug fix in the print of hexadecimal representations. Remove long fields
1410 in the print and add a third level of print to print them
1412 2004-01-23 Benoit Regrain
1413 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1414 * Bug fix on test suite after remove the strip made on not string fields
1415 * Split the IsReadable method between gdcmParser which test that the file
1416 is dicom and gdcmHeader which test that it's an image file
1418 2004-01-22 Benoit Regrain
1419 * DicomDir : clean code, add methods, set variables in protected or private
1420 * gdcmUtil : bug fix for the clean string method
1422 2004-01-19 Benoit Regrain
1423 * Add the use of shadow dictionaries
1424 * bug fix and coding style
1426 2004-01-19 Benoit Regrain
1427 * src/gdcmFile.cxx : bug fix concerning the close of file
1428 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1429 * Add the update of header entries using the shadow library
1431 2004-01-19 Benoit Regrain
1432 * removal of file gdcmHeader2.cxx
1433 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1434 inheriting from gdcmParser. This split is to prepare the integration
1435 of dicom dir parsing
1436 * bug fix under python
1438 2004-01-16 Jean-Pierre Roux
1439 * REM removal of class gdcmHeaderEntrySet
1440 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1441 * ADD add file gdcmHeader2.cxx
1442 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1444 2004-01-15 Benoit Regrain
1445 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1446 entries created while parsing the header. Thus, they will be destroyed
1447 when the gdcmDictSet will be destroyed
1448 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1451 2004-01-15 Benoit Regrain
1452 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1453 made a fatal error because of the memory release at the end of program.
1454 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1455 some memory and vtk seems to have some problems with that.
1456 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1458 2004-01-14 Benoit Regrain
1459 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1460 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1461 * src/*.[h|cxx] : make changes due to class name changes
1462 * gdcmPython/demo/*.py : bug fix due to method names
1464 2004-01-13 Benoit Regrain
1465 * src/*.[h|cxx] : coding style
1466 * vtk/*.[h|cxx] : coding style
1468 2004-01-13 Benoit Regrain
1469 * gdcmPython/testSuite.py : test the readable flag of file for tests
1470 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1471 It's lied to the stl compilation by MSVC (windows, always windows...)
1472 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1474 2004-01-12 Benoit Regrain
1475 * src/*.h : add comments
1476 * src/gdcmDictSet.h : set the method BuildDictPath in public
1477 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1478 directly setted in the source code
1479 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1482 2004-01-09 Benoit Regrain
1483 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1484 * setup.py : use a reference to gdcmVERSION
1486 2004-01-07 Benoit Regrain
1487 * Modification to compile with the distutils.
1490 2003-12-10 Benoit Regrain
1491 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1492 can use a gdcmHeaderHelper to load datas
1493 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1494 made in the source code
1496 2003-12-10 Benoit Regrain
1497 * Update Windows projects and .cvsignore files
1499 2003-11-12 Jean-Pierre Roux
1500 * ENH gdcmHeader constructor has one more parameter (default value : false)
1501 that allows the user to 'go inside' the SeQuences only
1503 gdcmElValSet:Print takes it into account
1505 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1506 * ENH: Update gdcmPython/CMakeLists
1507 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1508 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1510 2003-11-10 Jean-Pierre Roux
1511 * FIX : gdcmHeader::LoadElements is now based
1512 on the ListTag listElem member,
1513 not longer on the TagElValueHT tagHt member
1514 * ENH : PrintPubElVal shows (temporarily) both results,
1515 with the tagHt member and the listElem member.
1516 (it's easier to 'see' the problems when using Printheader)
1518 * FIX : old private member LgrElem is now splitted into
1519 ReadLength : Length actually found on disk (updated only
1520 if bug fixing is necessary), for internal
1522 UsableLength : Updated by FixFoundLength, to fix a bug
1523 or to allow Parser going on.
1524 Will allow to re-write a kosher header when a SeQuence
1525 with a length (not 0000) is found
1526 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1527 because gdcmElValSet::Add does not update ListElem
1530 2003-11-07 Jean-Pierre Roux
1531 * FIX misstyping in Transfert Syntax name table
1532 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1533 when they have an actual length (not 0000 nor FFFFF)
1534 (Nobody should care of it, but DICOMDIR explorers)
1536 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1537 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1539 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1540 * ENH: vtkGdcmReader now supports LUT !
1541 (vtkgdcmViewer for now is not able to use them though)
1543 2003-11-05 Jean-Pierre Roux
1544 * in testSuite.py : new files names for checking the package
1545 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1546 that returns the pixel area size to the *aware* (vtk) user
1547 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1549 2003-11-05 Benoit Regrain
1550 * in testSuite.py : Modify the rules for checking the paths
1551 : Explicit error messages
1552 * in __init__.py : Related modif
1554 2003-11-03 Jean-Pierre Roux
1555 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1556 to be used by aware (vtk) users that want to manage
1557 LUT (and no to turn the PALETTE image into an RGB pixels one)
1558 * GetPixelType now returns 8U for 24 Bits images
1559 (vtkGdcmReader compliant)
1561 2003-10-31 Jean-Pierre Roux
1562 * Removal of *all* gdcmData images and add them again
1563 in order to loose the 'history' of un-anonymised images
1565 2003-10-31 Jean-Pierre Roux
1566 * RMV : removal of useless jBitsInJsample.h
1567 for both 8 and 12 Bits JPEG Lossy Libraries
1569 2003-10-31 Jean-Pierre Roux
1570 * ENH : Add the functions gdcmFile::GetImageDataRaw
1571 gdcmFile::GetImageDataIntoVectorRaw
1572 that act as GetImageData and GetImageDataIntoVector
1573 except the making of an RGB Plane from Gray Plane + LUT
1574 Intended to aware (vtk) users who know how to manage
1577 GetLUTRGBA return a R,G,B,A LUT if any
1578 lgrTotaleRaw gives the 'Raw' length
1579 GetImageDataRaw returns the gray Plane
1580 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1581 (They stay Grey, just like with other Dicom viewers :-(
1583 2003-10-30 Jean-Pierre Roux
1584 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1586 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1587 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1588 being coherents dicom files.
1590 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1591 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1593 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1594 * ENH: Two steps is necessary to please VC++ compiler...
1595 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1596 * ENH: Add include dir to medcon lib
1597 * FIX: only one function is being exported for now !
1598 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1600 2003-10-29 Jean-Pierre Roux
1601 * adding gdcmHeader::GetLUTRGBA
1602 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1603 --> Mathieu, the modif u're waiting for is not yet committed
1604 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1606 2003-10-27 Jean-Pierre Roux
1607 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1608 00191113.dcm DermaColorLossLess.dcm
1609 MxTwinLossLess.dcm RadBWLossLess.dcm
1610 * ENH: For version prior to vtkImageViewer2 -r 1.19
1611 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1613 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1614 * Removal of ido stuff in CMakeLists.txt
1616 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1617 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1618 * FIX: remove a call to ->Modified ... see comments
1619 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1621 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1622 * FIX: Problem with path for libvtkgdcmPython
1623 * ENH: Try adding a search script for python site-package
1624 * RMV: Remove some file from medcon lib that are not necessary
1625 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1626 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1627 * FIX: More pragma disable fro VC++,
1628 I don't think I break something as it is also disable in VTK/ITK.
1629 But it fasten debug compilation time.
1631 2003-10-23 Jean-Pierre Roux
1632 * gdcm now deals with 16 Bits Run Length Encoded images
1633 (they are compressed as 2 planes images,
1634 one for the high Bytes, the other for low Bytes)
1636 2003-10-22 Jean-Pierre Roux
1637 * Now CheckRead takes into account :
1638 - the bugged 'Leonardo' Siemens images
1639 - the XA images, sent thru the burning VPRO station
1640 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1643 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1644 * FIX: When copying a Makefile.am to CMakeLists.txt
1645 one should remove the '\'
1647 2003-10-22 Jean-Pierre Roux
1648 * in gdcmData adding a bugged 'Leonardo' Siemens image
1649 (wrong lengths in header)
1650 OK with gdcm, KO with the other viewers :-)
1651 * add a GE dlx XA image, thru the VEPRO burning station
1654 2003-10-21 Jean-Pierre Roux
1655 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1656 for a brutal checking of vtkgdcmViewer compliance
1658 2003-10-21 Jean-Pierre Roux
1659 * add the files for 'xmedcon' Jpeg Lossless library
1660 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1662 2003-10-21 Jean-Pierre Roux
1663 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1665 2003-10-21 Jean-Pierre Roux
1666 * garbage Siemens 'Leonardo' images dealt with
1667 (the patch is easy to remove)
1668 * cosmetic changes to avoid warnings
1670 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1671 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1672 no need to press 'r' now.
1674 2003-10-20 Jean-Pierre Roux
1675 * upgrade of checkRead.sh checkWrite.sh according
1676 to new Jpeg Lossless decompressor
1677 * add US.3405.1.dcm, a genuine RGB medical file ...
1678 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1679 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1681 2003-10-15 Jean-Pierre Roux
1682 * general anonymisation in gdcmData
1683 * adding the 'color files' from
1684 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1685 * adding some well knowed bugged-header images
1686 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1687 waiting for their inclusion in Python testsuite
1689 2003-10-15 Jean-Pierre Roux
1690 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1691 no longer seg faults when file is not found
1693 2003-10-14 Jean-Pierre Roux
1694 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1697 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1698 * TODO: *.in file to genereate a UseGDCM later
1700 2003-10-14 Jean-Pierre Roux
1701 * Some supposed-to-be Dicom Images have no preamble.
1702 OpenFile takes it into account
1703 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1704 * Missing elements added in dicomV3.dic
1705 (just to be affraid : have a look at
1706 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1707 and do it again next year ;->
1709 2003-10-13 Jean-Pierre Roux
1710 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1711 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1712 But there are NOT. It's fixed !
1714 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * FIX: "jpeglib.h" was not found on VC++
1716 * FIX: vtkgdcm was not being installed
1718 2003-10-10 Jean-Pierre Roux
1719 * ENH : OpenFile closes the file if it *really* doesn't look like
1720 an ACR-NEMA / DICOM one.
1721 * FIX : testWrite no longer writes an empty file if the source file
1722 is not gdcm Readable
1723 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1726 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1727 * FIX: CMake generate now documentation
1728 * ENH: out of source doc build !
1729 * ENH: Generate both user and dev documentation
1730 * ENH: Should work on windows too
1731 * ENH: Only one doxygen config.in file is needed
1732 * FIX: make install should be ok now on ùnix plateform
1733 * FIX: PATH to dictionary was wrong (missing /)
1734 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1736 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1737 * vtkGdcmReader is now able to read rgb dicom file.
1738 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1739 * added a gdcmViewer to vtk test, use mouse to control
1740 window level & window width
1742 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1743 * CMake-ification of gdcm, we have now two build system
1744 * FIX: on cygwin Wsock32 doesn't exist
1745 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1747 2003-10-06 Emanuel Ollart
1748 * FIX : compilation process wad broken.
1749 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1751 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1752 * change gdcmViewer -> vtkgdcmViewer
1753 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1755 2003-10-06 Jean-Pierre Roux
1756 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1757 ( e.g : well known GE images with a wrong elem length,
1758 : Philips MRI Images with a wrong Huffman table)
1759 * still to be done : allow the reading of bugged LEONARDO Siemens images
1761 2003-10-03 Jean-Pierre Roux
1762 * Odd length strings are padded with '\0' (not with spaces,
1763 to remain compliant with already defined strings,
1764 like Transfert Syntax UID and others)
1766 2003-10-03 Jean-Pierre Roux
1767 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1768 to allow displaying RGB images (not only by affim ;-)
1770 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1771 * vtkGdcmReader is now able to read rgb dicom file.
1772 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1774 2003-10-03 Jean-Pierre Roux
1775 * A few nasty patches to allow the reading of a lot of nasty images
1776 ( e.g : well known GE images with a wrong elem length,
1777 : Philips MRI Images with a wrong Huffman table)
1778 * still to be done : allow the reading of bugged LEONARDO Siemens images
1780 2003-10-03 Jean-Pierre Roux
1781 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1783 2003-10-03 Jean-Pierre Roux
1784 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1785 to allow displaying RGB images (not only by affim ;-)
1787 2003-10-03 Jean-Pierre Roux
1788 * gdcmFile::GetImageDataIntoVector now
1789 - deals with MultiFrames MultiFragments Run Length Encoded files
1790 - deals with YcBcR (YBR_FULL) files
1791 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1792 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1794 (no sample found :-(
1796 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1797 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1798 Two reasons: - clear things
1799 - third parties acces gdcm through header files, so won't
1800 suffer anymore VC++ complains
1802 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1803 * add argv[1] in testvtkGdcmReader.cxx
1806 2003-09-24 Jean-Pierre Roux
1807 * The lines are now eigthy characters long.for
1808 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1810 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1811 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1812 char* to std::string. Thus, the use of strdup becomes useless. (see
1813 previous commis of Malaterre)
1814 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1815 before the last Malaterre's commit.
1817 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1818 * This commit should fix the Debug building under VC++, the problem
1819 was mainly a mixture of debug and release lib being loaded at startup.
1820 * I also remove a depency to a specific C function: strdup. Because I had
1821 to force the link to msvcrtd (whereas strdup is in libc).
1823 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1824 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1825 located in the gdcmCommon.h file. All use of reference of tha has been
1826 changed to now use the variable GDCM_UNFOUND.
1828 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1830 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1831 Dicom dictionary. The test suite can now be run again. Note:
1832 I'm note very happy with the " (RET)" changes. I believe this
1833 RETAINED comment should be dropped when parsing the dictionary.
1834 - PACKAGER corrected
1836 - AUTHORS updated and now in alphabetical order
1837 * Makefile.am now exports gdcm.dsw for Windoze users.
1839 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * cygwin complains about missing std:: in subdir Test/
1842 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1843 * remove some methods that are now in gdcmHeaderHelper
1845 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * vtkGdcmReader set spacing and origin correctly
1848 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1849 * Fix a few delete/delete[] mismatch
1851 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1852 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1853 interpretation to data given by gdcmHeader. For instance there are
1854 heuristics to get informations (look at different places).
1855 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1856 sorting DICOM images based on different strategies.
1857 * modified Makefiles accordingly.
1859 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1860 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1861 when building in debug mode
1862 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1863 src/win32/gdcmdll.dsp
1864 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1866 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1867 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1870 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1871 * src/win32/libgdcmjpeg12.dsp was not dos format
1872 * src/win32/libgdcmjpeg12.dsp :
1873 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1874 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1876 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1877 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1879 * src/gdcmFile.cxx : bug fix in affectation type
1880 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1881 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1882 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1883 symbols... future problem ?
1885 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1886 * src/win32/libgdcmijpeg12.dsp was missing
1887 * modified gdcm.dsw accordingly
1889 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1890 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1892 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1893 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1894 commit of JPR (before his hollidays to facilitate our work).
1895 * setup.py : bug fix in code. Modifications made while the last commit
1896 of JPR. The code hasn't been tested before the commit... it's so
1897 useless to make that (for best programmer that is JPR) !!!
1899 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1900 * tagged the current version as Version0_3 (i.e. version 0.3)
1902 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1903 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1904 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1905 * *.dsp : modifications to use new libgdcmijpeg8 library
1906 * setup.py : bug fix on VTKPATH variable
1907 * PACKAGER : adding all concerning windows
1909 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1910 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1912 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1913 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1914 test suite reported error.
1915 * PACKAGER file added (describes what a packager must do when
1916 packaging a new release).
1917 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1918 * configure.in: upgraded version number to 0.3.0
1919 * fixing build of rpm (through rpm -ta):
1920 - Doc/Makefile.am exports proper doxygen files
1921 - src/jpeg/libijg8/Makefile.am exports the include files.
1923 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1924 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1925 * src/gdcmHeader.h : formatting code
1927 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1928 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1929 We were obtaining error message from vtk. Now, creation of file list
1930 is made in an internal list to prevent this problem.
1931 Bug fix when output is empty.
1932 Bug fix in update of progress value. Previous commit for this was a bad
1934 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1936 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1937 * src/gdcmHeader.h : added method to get the file name
1938 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1939 files. Added method to remove all files on the input
1940 Added FIXME comment concerning the bad parsing of header made by
1941 ExecuteInformation method (in ExecuteData method)
1943 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1944 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1945 when using make instal.
1946 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1947 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1949 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1950 * setup.py : adding include dir of jpeg lib to compile all sources
1951 * */Win32/*.dsp : JPR fix for windows compilation
1953 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1954 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1956 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1957 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1959 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1960 * setup.py is again effective on un*x (takes into account the
1961 addon of the jpeg library)
1962 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1963 * Doc/Doxy* updated (includes above enhancements)
1964 * INSTALL now points to web documentation
1966 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1967 * src/gdcmHeader.h doesn't make unnecessary reference to
1969 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1971 * src/gdcm*.[cxx|h] :
1972 - to allow compilation with gcc 3.x
1973 -- clean up of STL usage (added explicit usage of std::)
1974 -- small fixes on exceptions.
1975 Note: linking not tested !
1976 - clean of doxygen comments to avoid warnings at documentation
1978 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1979 dependent convertion).
1981 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1982 * Clean up of previous JPR garbage commit (not even commented in the
1984 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1985 - moved all jpeg related files from src to src/jpeg/libijg8, with
1986 addition/modification of Makefile.am and configure.in.
1987 - the testSuite is still brain damage (not guilty).
1989 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1990 * WrapVTK.py : modifications to get correctly vtk source files to
1992 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1993 (FileName -> Filename)
1995 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * vtk/vtkGdcmReader.[cxx/h]:
1997 - UpdateProgress method should now be effective
1998 - removed the limitation on having only images loaded (as opposed
2000 - when building a stack of images/volume, a lesser number of
2001 gdcmHeader and gdcmFile instances should be used (hopefully
2002 accelerating things).
2003 - when building a stack of images/volumes, files which are not
2004 loadable (wrong path-filename, wrong permissions on existing file,
2005 or file not parsable by gdcm) are replaced with a black image
2006 in the stack (for the caller to notice the problem).
2008 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2009 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2011 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2012 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2013 between standard library (std) and vtk library (problems are found
2014 under Windows... thanks Windows !)
2016 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2017 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2019 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2021 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2022 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2024 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2025 * When compiling with distutils (see setup.py) the C++ compiler is
2026 called with different flags than the default ones (with automake).
2027 In order to fix all those warning, I compiled gdcm with the command
2028 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2029 and went for warning fixes:
2030 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2031 up from unused variables.
2032 - vtk/vtkGdcmReader.cxx: potential bug fix.
2033 * src/gdcmHeader.h: Doxygen warning cleanup
2035 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2036 * gdcmPython/gdcm.i:
2037 - typemaps correction to take into account the systematic replacement
2038 of "using namespace std" with std:: prefix e.g. std::list,
2039 std::string... (cf changes of 2003-05-21).
2040 - gdcmGlob global variable of type gdcmGlobal (defined in
2041 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2042 exported to Python a as cvar.
2043 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2044 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2045 gdcmDictSet.GetPubDictTagNames() and
2046 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2047 C++ static methods).
2048 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2049 with the above changes.
2051 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2052 * setup.py, manifest.in : bug fix under linux
2054 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2055 * Modification of setup.py to compile vtk part too. Then, we have 2
2056 wrappers which must work with same distutils. For that, we have a
2057 generic distutils in distusiltsWrapping.py ; with :
2058 - build_extWrap class to wrap generically all extensions,
2059 - ExtensionWrap base class for all wrapping extension that contains
2061 - Wrapper interface which wrap sources
2062 + In WrapSwig.py we have extension and wrapper for Swig
2063 + In WrapVTK.py we have extension and wrapper for VTK
2064 * MANIFEST.in : modifications to consider vtk directory and new python
2065 files for compilation
2067 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2068 * Added python wrappers of vtkGdcmReader vtk class (see the
2069 source in vtk/vtkGdcmReader.cxx) :
2070 - vtk/Makefile.am now builds a library
2071 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2072 python library (as opposed to _gdcm.so wich are the python
2073 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2074 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2076 - configure.in has an additional flag --enable-vtk that needs
2077 to be set to enable compilation of vtk related code, that is:
2078 + vtk/vtkGdcmReader.so and
2079 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2080 + gdcmPython/vtkgdcmPython.so (see above)
2081 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2082 be read when compressed or when HighBit + 1 != BitsStored),
2083 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2084 the usage of the python wrapper of vtkGdcmReader vtk class.
2085 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2086 * src/*.[h] all occurences of stl classes are now prefixed with
2087 std::, and all occurences of "using namespace std;" where removed.
2088 This is to avoid pollution of global namespace in included files.
2089 Apparently vtk does not avoid this pitfall: when using both
2090 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2091 collision of various stl members (principally cout...).
2092 * gdcmPython/testSuite.py now cleanly removes temprory generated
2094 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2095 comply with above changes)
2097 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2098 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2099 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2100 vtk data structure (an image Flip was required).
2101 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2102 * cosmetic changes in documentation.
2104 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2105 * src/gdcmHeader.cxx: the constructor no longer exits when an
2106 unexisting file is given as argument.
2107 * The subdirectory Data (containing all the images used for the
2108 test suite) is not part of this repository anymore. A new module
2109 containing those images is now available at
2110 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2111 with the name gdcmData.
2112 All the python scripts (including the package initialisation file
2113 gdcmPython/__init__.py) were adapated to take this change into
2114 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2116 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2117 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2118 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2119 demo of the usage of this class.
2120 Compilation of this vtk part is only done when using the --enable-vtk
2121 at configure (or autogen.sh) stage.
2123 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2124 * More memory link related corrections and documentation fixes.
2126 - maximum info is obtained with a command of the form:
2127 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2128 --show-reachable=yes PrintHeader
2129 - the remaining reachable blocks seem to come from the STL
2130 allocation scheme through the usage of map and list. It looks
2131 like this memory cannot be freed but it is not a memory leak
2132 (in fact further invocation to the STL would recollect the
2133 unused memory allthough it cannot explicitely be freed).
2134 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2135 of displaying an image parsed with gdcm and displayed with VTK.
2136 Note: some images don't seem to work e.g.
2137 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2138 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2139 Allthough this weakens the semantics, it is a ditch attempt to
2140 make gdcm more thread friendly.
2142 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2143 * Memory link hunt (by using valgrind through the command
2144 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2145 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2146 gdcmHeader::_dicom_vr.
2147 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2148 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2150 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2152 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2153 * src/Makefile.am now exports all the necessary include files at
2157 * UpdateGroupLength replaced by new one
2160 * UpdateGroupLength re-written using H-Table
2161 (named UpdateGroupLengthNew untill checks are over)
2163 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2164 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2165 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2167 - gdcmHeader::GetPubElValSet removed.
2168 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2169 UpdateGroupLength, WriteElements, Write.
2170 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2171 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2172 carried the same semantics.
2173 - src/gdcmHeaderIdo.cxx changed accordingly.
2174 - gdcmFile::WriteBase now regroups all the codes from previous
2175 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2176 - enum FileType moved to gdcmCommon.h
2177 * src/gdcmHeader.cxx AddDefault trashed
2178 * gdcmGetXSize added
2179 * getimageDataSize now calls gdcmGetXSize
2180 * Test/*.cxx changed to agree with above changes
2182 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2183 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2184 (to avoid double call by end user).
2185 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2186 by end user, since gdcmHeader::gdcmHeader now handles it.
2188 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2189 * gdcm/Doc many doxygen changes:
2190 - Doxyfile now has two different versions, DoxyfileUsers that generates
2191 the html.users end users oriented documentation and
2192 DoxyfileDeveloppers that generates the html.developper developper
2193 oriented documentation.
2194 - README changed accordingly
2195 - requirement.txt removed (old design info moved to TODO).
2196 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2197 DoxyMainPage.txt, DoxyPython.txt provide more information.
2198 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2199 be updated by simply regenerating the docs with doxygen and copying
2200 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2201 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2202 all the tests in the form "if (<map>.count() >1)" were removed.
2203 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2204 ill-formed documentation sections.
2205 * src/gdcmHeader.cxx: ditto
2207 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2208 * setup.py fixed for un*x (needed macro for stdint.h)
2209 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2210 un*ces with sh-utils test utility.
2211 * gdcmPython/demo/test.py renamed to PrintHeader.py
2212 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2213 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2214 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2215 * src/gdcm*.cxx JPR's bad inclusion fixed.
2217 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2218 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2219 * gdcmPython/demo/test.py changed accordingly.
2221 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2222 * gdcmPython/Makefile.am fixed linking against libstdc++
2223 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2224 * Swig subdir (historical tests of swig version 1.3.17++) removed
2225 * Test/testChangeEntete.cxx some lines commented out in order to make
2227 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2228 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2230 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2231 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2232 hence the user doesn't need this explicit call.
2233 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2234 i.e. LoadElements() call removed.
2235 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2236 - src/Makefile.am declares the proper flag for g++.
2237 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2238 for adding user defined new tags.
2239 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2240 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2241 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2243 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2244 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2245 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2246 src/Makefile.am : the project should properly compile and install
2247 with the autotools, included the python wrappers part.
2248 * gdcm.spec.in : added a spec file for RPM packaging.
2250 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2251 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2253 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2254 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2255 to exported to the environement (see gdcmPython/testSuite.py
2257 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2258 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2259 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2260 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2261 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2263 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2264 * gdcmPython/__init__.py doesn't crash anymore when running in
2265 in InstallMode or PreInstallMode but with an environement given
2266 value of GDCM_DICT_PATH.
2267 * src/gdcmDictSet.[cxx/h] coding style.
2269 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2270 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2271 * src/gdcm.h general comments moved to TODO, and README
2272 * src/gdcm.h should now be seen as a user commodity (including it
2273 should suffice to fully use gdcm). It is nowhere including within
2274 any of the kernel files src/*.cxx and src/*.h.
2276 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2277 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2278 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2280 * src/gdcm*.cxx only include their corresponding include file
2281 (as opposed to gdcm.h)
2282 * gdcmPython/gdcm.i changed accordingly
2283 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2284 the autogen.sh generated "make snapshot" command to work.
2285 * autogen.sh removed history related references to crea package.
2287 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2288 * distutilsSwigCPlusPlus.py work around some swig portability
2291 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2292 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2293 was done in a last ditch attempt to get setup.py _really_
2294 operationnal. The python/gdcmPython layaout add the advantage
2295 of hidding away the python related distutils specific files
2296 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2297 Alas, the src directory was out of scope (i.e. it's relative
2298 position to setup.py was ../src) which made things impossible to
2299 handle (see previous version of python/setup.py). Crossing fingers...
2301 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2302 * python/setup.py now works on Un*x. (harder than I thougth)
2303 * python/distutilsSwigCPlusPlus.py can now have include files
2304 among the list of sources.
2306 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2307 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2308 * modifications in MSVC projects
2310 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2311 * As stated by the first lines of Test/ExceptionAndPython/README, it
2312 looks like we can move back to original usage of exception within
2313 src/gdcm* and hence remove the errno stuff that was introduced
2314 as a quick and dirty fixture of this problem (added to the TODO).
2315 * Doc/Doxyfile configuration file for Doxygen and corresponding
2316 README file for usage added.
2317 * Test/testWrite.cxx added. This new test comes from a split of
2318 test.cxx that is now reverted to its original purpous i.e.
2319 testing the proper parsing of a Dicom related file.
2320 testWrite.cxx concentrates on testing the IO part of gdcm.
2321 * Test/bug1.cxx (containing a bug on WIn32) added.
2322 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2323 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2324 whose purpose is to publish the content of the TagNames of the
2325 Dicom public dictionnary were not accessible without an
2326 instance of class gdcmHeader.
2327 - those methods are now static methods of gdcmDictSet and hence
2328 require no instances at all to be invocated.
2329 - within gdcmDictSet this change required to change some method
2330 to class methods (i.e. are now static) among which SetDictPath
2331 (renamed to BuildDictPath) and LoadDefaultPubDict.
2332 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2333 the above changes by calling the new method classes of gdcmDictSet.
2334 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2335 the above to be effective.
2336 * python/gdcmPython: in order to wrap properly the above changes
2337 for Python, swig version now needs to be > 1.3.17.
2338 * python/gdcmPython/Makefile fixed to adapt itself to new
2339 configure/make shema introduced by Johan Montagnat (thanks for the
2340 contribution). Alas this Makefile cannot be turned into a proper
2341 Makefile.am without some heavy changes in the configure.in
2342 (for python dectection).
2343 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2344 now avoids publishing the empty entries.
2346 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2347 * python/setup.py : bug fix concerning install under windows
2348 ExtraPath reused :-P
2349 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2351 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2352 * Dicts/dicomV3.dic : remove double spaces !!!
2353 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2354 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2357 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2358 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2359 method. Doxygenation.
2360 * src/gdcm.h clean up of JPR spurious comments.
2362 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2363 * python/distutilsSwigCPlusPlus.py now properly collects the
2364 shadow classes generated by "swig -c++" (gdcm.py in our case)
2365 when using "python setup.py install".
2366 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2367 reexports the working classes.
2368 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2369 by the classical C errno scheme. This is to prevent an obscure
2370 behavior of the python wrappers when importing wxPython.wx prior
2371 to gdcmPython (which ended up in an abort call). An illustration
2372 of this oddity can be found in the Test/ExceptionAndPython
2373 subdir (see the README file). This problem probably due to
2374 an combination of g++ and dynamic loading.
2375 * added Test/ExceptionAndPython (see above)
2377 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2378 * Changed the layout of the python part to avoid bloating main
2379 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2380 i.e. the distutils arsenal. All the python related stuff is
2381 again in a python subdir, but the package itself is now in
2383 * setup.py was cleaned up:
2384 - pythonIncludePath removed
2385 - python setup.py bdist target is now functional.
2386 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2387 collision with other packages). gdcmPython/demo/*.py changed
2390 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * python subdir moved to gdcmPython (preparation of distutils packaging).
2392 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2393 distutils installer is operational.
2394 * - gdcmPython/__init__.py now properly loads the swig generated
2395 shadow classes (from gdcm.py).
2396 - gdcmPython/demo/*.py changed to import the package gdcmPython
2397 instead of gdcmPython/demo/load.py.
2398 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2400 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2401 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2402 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2403 entries within the associated public Dicom dictionary resp. the same
2404 information but sorted by the fourth field (PAT, IMG, DIR) of the
2406 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2407 are now in the "???" group.
2408 - python/gdcm.i changed accordingly,
2409 - python/demo/printGroupedPublicDict.py added, that gives an example
2410 of the above new functionalities in Python.
2412 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * src/gdcm.h, gdcmHeader.cxx:
2414 - historic references to glib's g_malloc and g_free (#defined)
2415 were definitively removed.
2416 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2417 * src/gdcmElValSet.cxx:
2418 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2419 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2420 - GetElValue(string) renamed to GetElValueByName.
2421 - Added GetElementByName(string).
2422 * src/gdcmHeader.cxx: added
2423 - GetPubElValRepByNumber(guint16, guint16)
2424 - GetPubElValRepByName(string)
2425 - GetShaElValRepByNumber(guint16, guint16)
2426 - GetShaElValRepByName(string)
2427 - GetShaElValByNumber(guint16, guint16)
2428 - GetShaElValRepByName(string)
2429 - GetElValRepByNumber(guint16, guint16)
2430 - GetElValRepByName(string)
2431 - GetElValByNumber(guint16, guint16)
2432 - GetElValRepByName(string)
2433 * Doc/requirements.txt added.
2435 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2436 * Test/Makefile building now depends on the one of libgdcm.so
2437 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2438 pixel data) aware which enables finding the address (offset) of
2439 the pixel data of JPEG encoded DICOM files. This leaves only a single
2440 file in the testSuite whose pixel data address (offset) is unknown.
2441 * python/testSuite.py changed accordingly.
2443 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2444 * VC++ has some strong limitations when working with the STL, as stated
2445 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2446 "Also note that some STL containers (map, set, queue, list, deque)
2447 cannot be exported. [...]
2448 Some STL classes contain nested classes. These classes can not
2450 This is caused by a designed limitation that once a template
2451 class is instantiated, it can not be re-instantiated and
2453 Since our usage of map<> is ubiquitous in gdcm, this "designed
2454 limitation" of VC++ is a pitfall.
2455 Hence the Python wrappers of gdcm cannot be incrementally linked
2456 against the c++ dynamic library. The dirty but only workaround is
2457 to forget about incremental link of dynamic libraries and to generate
2458 the Python wrappers library with the inclusions of the underlying C++
2460 The following modifications concern this matter on Win32/VC++:
2461 - wrapping python correct with standalone wrapped dll (don't use separate
2462 dll under windows !!!!)
2463 - python21_d debug mode enabled (ask Frog how to use it :-)
2464 - NO problem with having an STL member of class for example string in C++
2465 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2466 - Python test of dcmlib in Python is ok under windows on a large set
2468 * removed glib references
2469 * typedef's inserted in gdcm.i for correct swig type management
2471 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * python/demo/*.py load.py extracted from test.py. Added explore.py
2473 that only displays required tags and testAll.py that parses all
2474 the files of the testsuite without using unittest.
2475 * python/testSuite.py other additional test on new files added.
2476 * Data/* new test files added accordingly to the testSuite.
2477 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2478 the vr in the file differs from the one of the dictionary.
2480 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2481 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2482 values, but limits itself to values which are below a user specified
2483 size (by default 1024 bytes).
2484 * python/gdcm.i : elements not loaded (because their size is above the
2485 user specified treshold) are exported with their TagKey as key of the
2486 python dictionary. This enables the testsuite to make some checks
2487 on the unloaded elements (since we have their offset and size).
2488 * python/testSuite.py
2489 - now tests for the existence and proper value of the pixel data
2490 - two new examples added.
2491 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2493 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2495 aware. See the strategy comments in gdcmHeader::FindeLength().
2496 * Test/test.cxx now accepts a filename as first argument.
2497 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2498 * python/testSuite.py changed to integrate test on above files.
2500 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2502 the vr was also RET.
2503 * python/testSuite.py more tests added.
2505 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2506 * python/testSuite.py unittest test suite added (uses Data)
2507 * Data/* dcm and acr files for the test suite.
2508 * glib dependance removed from un*x version. We now use ISO C99
2509 7.18 Integer types (see stdint.h)
2510 - python/Makefile, src/Makefile src/gdcm.h
2511 * src/ when an explicit vr (like dicom files) suddenly poped an
2512 implicit element we use to mark the underlying DictEntry of the
2513 concerned ElValue with "Implicit". This strategy was damageable
2514 too the public or provite dictionaries, since some of their vr
2515 would be changed. Since Header::FindLength heavily relies on the
2516 detection by Header::FindVR of falsely explicit elements, I
2517 added an extra ImplicitVr member to ElValue (boolean).
2518 The rest of the changes we the necessary adaptations.
2520 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2521 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2523 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2525 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2526 * Adaptation for porting to VC++:
2528 o forced to use std namespace (for string to be known)
2529 o all class use __declspec export style on WIN32
2530 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2531 (in stdlib.h on Win32 but in std:: for gcc)
2532 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2533 variable GDCM_DICT_PATH.
2534 * src/gdcmHeader.cxx verbose comments made discrete.
2536 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2537 * python/gdcm.i: added a typemap that converts a C++ hashing table
2538 to native Python dictionary.
2539 * python/demo/test.py:
2540 - now uses the native dictionary for exploration of gdcmHeader.
2541 - takes an optional filename argument (the file to parse).
2542 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2543 PubElVals hashing table.
2544 * Dicts/dicomV3.dic removed error prone trailing spaces.
2546 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2547 * Python wrapping process moved away from src/Makefile to
2548 newly created python/Makefile (as well as gdcm.i)
2549 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2550 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2551 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2552 from the environement variable GDCM_DICT_PATH (when existing).
2553 * src/gdcmDict::GetTag bug fix.
2555 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2556 * Straightforward temporary fixes for swig to build the python wrappers.
2557 src/Makefile now has a python working entry [by working we mean
2558 that we can import de shadow classes without errors].
2560 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2561 * hashtest.cxx removed (since allready in Test)
2562 * src/gdcmlib.h renamed to src/gdcm.h
2563 * src/dcm.i renamed to src/gdcm.i
2564 * src/Makefile prepared for python wrapping
2566 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2567 * src/gdcmHeader.cxx :
2568 - Parsing of header is now separated from loading of element values
2569 (see gdcmHeader::LoadElements).
2570 - general clean up of hopefully all file access (creation of
2571 ReadInt16 and ReadInt32)
2573 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2574 * src/gdcmHeader.cxx :
2575 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2577 - SetLgrElem renamed to SetLength
2578 - GetLgrElem renamed to GetLength
2579 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2580 * src/gdcmElValSet.cxx fixed both GetElValue methods
2581 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2582 due to IdoDude was cleaned out.
2584 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2585 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2586 concentrates on finding the value representation (when it exists).
2587 RecupLgr now only finds the element value length, and it avoids
2588 returning the unecessary skL (skipped length).
2589 Also, offsetCourant was simply removed (with taille_fich) since
2590 it was redundant with the File position internals (by using
2591 ftell and fseek). This also made skL (see above in RecupLgr) usage
2593 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2594 on the libido specificities which are handled through class
2596 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2599 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2600 * Truckload of changes. Parsing of header is barely functional
2601 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2603 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * src/gdcmHeader.cxx many addons of low level methods
2606 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2607 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2608 and _IdDcmSWAP_LONG.
2610 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * This corresponds to all the changes decided at the meeting of
2612 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob