1 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
4 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
5 Some fields in BinEntry must be copied to not seg fault when making the :
6 gdcm::File *copy = new gdcm::File( copyH );
7 and tests are now made on good variables
9 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
10 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
11 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
13 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
14 * Add vtkGdcmWriter example and test
16 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
17 * Test/TestUtil.cxx : reformat the source code
18 * vtk/vtkGdcmReader.cxx : remove and change prints
19 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
21 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
22 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
24 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
26 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
28 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
29 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
30 by an eof to prevent all bad read of the file... and in this case, the
33 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
34 * Example/Volume2Dicom.cxx : comment unused variables
35 * Test/PrintDicomDir.cxx : comment unused variables
36 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
37 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
38 method that is redondant with AddEntry.
39 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
42 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * Bug fix due my last commit (compilation under Windows).
44 * Example/Volume2Dicom : bug fix in the file and reformatting source code
45 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
47 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
49 - Remove printf / sprintf
50 - include iostream AFTER gdcm so we don't get warnings
51 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
53 - Also remove tons of include from header files, hopefully this should
54 speeup the compilation time, since it was becoming a dog slow.
55 - Remove gdcm.h as it include way too many files and slow down compilation
56 (plus it is not up to date)
57 - remove 'using namespace std' this is BAD !
59 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
60 * Remove memory leaks on the DicomDir
61 * Remove some useless datas in DicomDirObject
62 * Add usefull methods in SQItem, to be complient withe the ElementSet
64 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
67 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
68 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
69 future, with convertion)
70 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
71 and ImageDataSize values. Remove the method to get the PixelReadConverter
72 from the output of the class
74 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
75 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
77 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
79 and vtkErrorMacro use.
80 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
82 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
85 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
86 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
87 The string leaves only in the fonction. So when we make a .c_str(), we
88 get the pointeur on the first element, element that will be destroyed
89 immediately after thee instruction.
90 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
91 file has been opened : the test must be made on the content of the
92 pointer and not directly on the pointer !
95 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
96 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
97 the python part recompiles
99 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
101 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
102 X session is killed (for my computer... it seems to not be identic on
105 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
106 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
107 avoid problems (otherwise, the difference test between the visible image
108 and the reference is incorrect. If the reference is greater than the
109 screen resolution, it's produce errors).
110 Can be used for only one image. Can be used with a visible flag.
111 * vtk/vtkGdcmReader.cxx : remove commented codes.
112 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
113 under windows at compilation
114 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
116 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
118 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
120 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
121 tests on the image size X, Y, Z
123 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
124 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
125 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
126 between the class name and the file name
128 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
129 * src/ : fix compilation warnings for the Write method (2 different
130 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
131 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
132 variable... create a static method in gdcm::Document to access to
133 this variable content.
135 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
136 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
137 file, to be accessed by other files (like gdcmFile). Remove commented
138 code. Move the change of the header to the gdcmFile, using the
140 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
141 To be sure of that (and simplify calls), the Write of the header now
142 gets a file name and not a file pointer (std::ifstream).
143 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
144 DocEntryArchive. Remove all open of the written file
146 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
147 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
149 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
150 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
151 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
153 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
154 some corresponding methods. Write correctly the file and check before
156 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
157 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
158 is now on RGB datas (as before my last commit
159 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
161 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
162 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
163 Add a print information of the type of the entry
164 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
165 It was in the gdcmFile, and all write have been regrouped
166 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
167 Write correctly all dicom files (in decompressed mode only at this time)
168 * Test/ : test on files are now made using Raw datas and not color datas if
170 * Example/PrintFile.cxx : add more printings
172 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * Amelioration of code, remove some code copy. For the loading of
174 BinEntry (in gdcmDocument), add the test to verify if the file is already
177 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
178 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
179 remove a DocEntry in the header (push an empty DocEntry)
180 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
181 lines. Bug fix in the initialization of the PixelConvert and the
183 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
184 use in TestCopyDicom (now this test can run under windows... but fails)
185 * Test/TestCopyDicom.cxx : amelioration of the test :
186 - test the pixels written
187 - add test points to quickly find where is the error
188 - can set a file name input and output in arguments
189 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
190 amelioration of the test output
192 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
193 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
194 all replaced DocEntry's
195 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
196 Now, each needed DocEntry to modify is duplicated, modified and inserted
197 to the header using DocEntryArchive. Thus, after save, we can restore the
198 header initial state.
200 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
201 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
203 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
205 correct to copy it. The DictEntry is specified at the DocEntry creation,
206 then, it musn't change in the time.
207 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
208 header correctly. At this time, the change is only made for the first
209 level of the Document. In the future, it might consider sequences.
210 The change is made by replacing a DocEntry by an other that is created
211 outside the class. The old value is kept. When we restore the header
212 status, the added DocEntry is deleted and replaced by the old value.
213 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
214 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
215 set the write type to explicit VR, implicit VR or ACR. Add methods to set
216 the write mode to native, decompressed or RGB (but not used at this time)
218 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
219 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
220 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
222 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
224 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
226 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
227 set because already copied when copying the BinEntry's of the header
228 * Test/TestAllReadCompareDicom.cxx : remove warnings
230 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
231 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
232 Two problems appear when doing it :
233 - with the gdcmFile : when the GetImageData method is called, the pixels
234 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
235 datas (pixels). And each structure destruct the datas when it's
236 destructed. So we have two destructions for the same datas. To solve it,
237 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
238 datas or not. If it doesn't own datas, then they will not destroyed by
240 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
241 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
242 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
243 create a double destruction of the same DocEntry's. So, to solve it,
244 the TagHT is simply cleared and the DicomDir* elements are destroyed.
245 * TODO : add an entry concerning memory leaks in the DicomDir
247 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
249 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
252 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
254 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
255 after it have been deleted
257 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
258 * FIX: src/* fix the doxygen warnings.
259 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
260 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
261 was erroneously defined with a size of 15 instead of 16. [many thanks
262 to Jean Michel Rouet for pointing out this bug].
264 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
265 1. Finish merging JMR patch for writting DICOM from scratch
266 2. Fix -hopefully- bug with MONOCHROME and space vs null character
267 3. Use const ref when possible
268 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
269 5. A few more comments
270 6. CreateUniqueUID can now be called without parameter"
272 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
273 * ENH: Slightly bigger patch:
274 1. Getting toward full integration of JMR patch for writting dicom from scratch
275 2. Update Test to test part of this patch: CreateUniqueUID
276 3. File was not close properly in gdcmDict
277 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
278 5. Use of const ref instead of copy (speed issue)
279 6. Remove temporary (duplicate) string in TranslateToKey
280 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
281 8. Do not repeat virtual in subclasses
282 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
284 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
285 * Apply first patch toward better string comparison when dealing with broken
286 DICOM files. Essentially the string could be padded with a space instead
287 of a null character as defined by standard
289 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
290 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
291 because never used... and in the same time, that's remove some memory leaks
293 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
294 * src/gdcmFile.cxx : now delete the PixelConvert instance.
295 * In examples and tests : change the type of image data variables from void*
296 to uint8_t*. Remmove all delete on image data variables
298 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
300 Verify the file pointer value before open the file, and if it's not null,
301 a verbose message is generated.
302 Close correctly the file when the file isn't considered dicom-like. The
303 correctly close is a call to CloseFile.
304 When closing the file pointer, test if its not null to close the file.
305 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
306 file. For an uncompressed image, the copied datas correspond in the least
307 case to the image size (calculated) or the image size specified in the
308 header. A verbose is generated if these two size mismatch
310 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
312 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
313 break under windows (with msvc6 compilation).
315 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
317 compiling with MSVC6)
319 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
320 * Bugs fix for the Windows build with VC6
321 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
322 needed (only for projects required VTK). If the VTK is included in all
323 projects, there is conflicts with the jpeg lib of vtk when compiling the
324 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
325 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
326 when compiling the gdcm_wrap.cxx file (created by the compilation of the
328 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
329 (like it's already made for the cout use). Otherwise, conflict with the
332 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
333 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
335 - comments on the DicomDir::Method related usage added.
336 - now that we use the namespace gdcm, a lot of internal classes do
337 NOT need to be wrapped anymore.
338 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
339 DicomDir::Method) new example added.
341 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
342 * Improve string manipulation. I now inforce the notion of 'DicomString'
343 A DicomString can contain as many \0 as they want
344 and it is *always* of even length.
345 We only support odd length for very rare case.
346 And in the near future this should be removed.
348 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
349 * /binary_write/ gdcm source. Now even on big endian we are writting
350 little endian. This should -heopfully- fix some tests
352 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Now the dictionary is compiled into gdcm lib. This is a default
354 behavior, thus any dic file specified is picked before failback to
355 the one comiled into lib
357 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
358 * Change internals for gdcmDict. Don't use any 'new' any more.
359 This should definitely solve any leak problem, and we should be
360 as fast as before, as long as don't modify too much the dictionary.
362 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 * STYLE: ivars should start with a capital letter.
364 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
365 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
367 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
368 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
369 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
370 new 2004 dictionaries added (thanks to JPR).
371 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
372 * CLEANUP_ROUND (15) for gdcmPixelConvert
373 - RLEFrame::NumberFragments is now of type unsigned int
374 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
375 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
378 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
379 * Initial work in gathering all transfer syntax accessors. clearly
380 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
381 ivars, but only one transfersyntax (class) ivar with equivalent method on
384 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
386 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
387 discussed (plus I didn't like having a 2000 lines patch not commited)
389 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
391 * CLEANUP_ROUND (14) for gdcmPixelConvert
392 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
393 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
394 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
396 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
397 anymore and hence avoids storing a copy of PixelConvert::Decompressed
398 into File::Pixel_Data.
400 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
402 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
403 * CLEANUP_ROUND (13) for gdcmPixelConvert
404 Substituted File::ParsePixelData() with PixelConvert::Print() new
406 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
407 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
408 method to those classes.
409 - src/gdcmFile.[cxx|h]:
410 -- Added a ::Print() method.
411 -- PixelConverter is now a reference instead of a member.
412 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
413 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
415 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
417 collaboration diagram and inheritance diagram should be generated with
419 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
420 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
421 pointlessly wrapped (see
422 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
423 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
424 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
425 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
426 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
427 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
428 -- File::Initialise: PixelConverter setup moved away to
429 PixelConverter::GrabInformationsFromHeader()
430 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
431 interpretation moved away to PixelConverter::BuildRGBImage()
433 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
434 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
435 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
437 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
439 displayed on Win32 when a brutal abort() occurs (because of uncatched
440 exception). See TODO new entry of this commit for more on this.
441 * TODO added new entry.
442 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
443 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
444 - HandleColor is no longer called from gdcmFile.cxx
445 - gdcmPixelConvert.cxx clean up on method arguments and internal
446 variable names for semantical coherence.
448 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
449 * Finished lossless transition, not only do we now read all lossless jpeg
450 images, without the need of the Cornwell lib, but we do read them properly now
451 * To reduce code (well to avoid code duplication), I defined a common place
452 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
453 redefine symbols. This is not prefect but this the best solution I found for a
454 compilation time jpeg option.
456 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
457 * Update jpeg ijg lib to support lossless jpeg implementation
458 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
460 * Also added a special copyright for dcmtk since we use their bugfixes.
463 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
464 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
465 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
466 matters, as stated in warning note at begining of %include section).
467 * src/gdcmDicomDir*.[cxx|h]: coding style
468 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
469 * src/gdcmJpeg8.cxx: doxygen fix.
470 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
471 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
472 from File:: to PixelConvert::.
474 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
475 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
476 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
477 - more code moved away from File:: to PixelConvert::
478 - fat setup of PixelConverter set in place in File::Initialise.
480 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
481 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
482 namespace at the file system level. So now you should convert your examples
484 gdcmHeader -> gdcm::Header
485 It would be nice if people keep in mind to no open the namespace, since it
486 allows compilation on broken plateform which were defining common symbol in
487 the standart namespace (like LP, Unknown ...)
489 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
491 The JPEG fragments are now parsed at the same stage than the RLE
492 information. All code related to JPEG is now in gdcmPixelConvert:
493 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
494 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
495 export a gdcmFile:: method. Those are simply global functions
496 (for the time being this is better than having them attach to
497 either gdcmFile:: or gdcmPixelConvert::).
498 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
499 and stores the result in a gdcmJPEGFragmentsInfo.
500 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
501 code (among other stuff) moved away from gdcmFile:; to
504 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
505 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
506 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
507 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
508 clean up of RLE related code.
509 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
510 - src/gdcmRLE.cxx removed
511 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
512 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
513 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
514 * CLEANUP_ROUND (9) for gdcmPixelConvert
515 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
516 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
517 away from gdcmFile:: to gdcmPixelConvert::.
519 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
521 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
522 This is because Parse7Fe0 used to parse the pixels to compute the
523 length. This task was passed over to FindDocEntryLengthOB() a long
524 time ago, EXCEPT I had forgotten the OW case...
525 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
526 we just recylce the code for parsing RLE fragments and computing
528 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
529 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
530 with the retired Parse7Fe0().
531 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
532 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
534 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
535 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
536 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
537 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
538 - src/CMakeLists.txt: alphabetic order reodering + new entries.
539 * CLEANUP_ROUND (4) for gdcmPixelConvert
540 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
541 to return an unused length.
543 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
544 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
545 this should be cleanner from the plane view. The iostream are erally a pain
546 to use to do simple stuff.
548 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
549 * Redo the compilation of the ijg jpeg library. Now only one source is
550 necesseray. No need to rename file by hand what so ever. CMake handle the
551 copying of the file within different directory, configure header file to
552 modify some symbol. The only addition made to ijg wasd a mangle table so
553 that symbol are different wether we are within 8bits or 12bits.
555 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
556 * Added documentation of vtkgdcmReader on Website:
557 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
558 with it's binary name).
559 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
560 the Website to be more complete.
561 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
562 doxygenated documentation.
563 - Doc/DoxyVtkGdcmReaderExamples.txt added
564 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
565 DoxyVtkGdmReaderExamples.html )
566 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
567 * CLEANUP_ROUND (3) for gdcmPixelConvert
568 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
570 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
571 * CLEANUP_ROUND (2) for gdcmPixelConvert
572 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
574 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
575 * CLEANUP_ROUND for gdcmPixelConvert:
576 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
577 - src/gdcmPixelStuff[h|cxx] removed
578 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
579 - src/CMakeLists.txt changed accordingly
581 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
582 gdcmVersion.py moved to newly created ATTIC related
583 gdcmPython/SetupOldies/ directory.
584 * Autotools clean up:
585 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
586 - autogen.sh configure.in acinclude.m4 python.m4 removed
588 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
589 * src/*.cxx *.h Reference to License.htm fixed to License.html.
590 * Doc/CMakeLists.txt, doxygen.config.in: fix.
591 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
593 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
594 * TODO updated with Mathieu suggestions. I proposed a template for
595 describing TODO entries and used it for new entries.
596 * Added Doc/Website/CodingStyle.html, Developpers.html,
597 DeveloppersPython.html, GdcmDataCvs.html and
598 DownloadVersion0_1.html, DownloadVersion0_3.html.
599 * Some Doc/*.txt Doxygen files (which do not really concern the
600 documentation itself, but the website) moved to html and
601 placed in directory Doc/Website:
602 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
603 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
604 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
605 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
606 * CMakeLists.txt changed accordingly.
607 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
608 DeveloppersPython.html
609 * INSTALL nows refers to Doc/Website/Installation.html
611 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * Added Doc/Website directory, that contains a first raw version
615 2004-09-23 Jean-Pierre Roux
616 * FIX In order not to be poluted any longer by casting problems,
617 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
618 we can now delete[] it safely
619 * VoidArea is now called BinArea (less confusing name),
620 and all the methods called ...VoidArea... are now ... BinArea...
621 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
623 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
624 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
625 clear) TagHT, which is an inherited member of gdcmElementSet. It is
626 up to the destructor of gdcmElementSet to clean up TagHt and it's
629 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
630 * Test/CMakeLists.txt: update to follow gdcmData renamings.
631 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
633 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * ENH: added some utility method that builds a flat dictionnary
635 holding all the Dicom entries contained in the recursive structure
636 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
638 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
639 BuildFlatHashTable() that build a flat dictionary.
640 - src/gdcmElementSet.h: added a new private GetTag() accessor.
641 gdcmDocument is now a friend of gdcmElementSet.
642 - src/gdcmElementSet.cxx: clean up.
643 - Example/FlatHashTablePrint.cxx added.
644 - Example/CmakeLists.txt changed accordingly
646 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
647 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
648 moved away from gdcmDocEntrySet (since this class is an abstract class
649 acting like an interface). SQDepthLevel and BaseTagKey are now
651 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
652 and associated accessors. Doxygenation of the class.
653 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
655 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
656 Use SQDepthLevel accessor instead. ::Print() adapted.
657 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
658 - src/gdcmDocument.cxx changed accordingly.
660 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
661 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
662 - The following is the doxygen comment of the typedef declaration
663 of gdcmagKey in src/gdcmCommon.h:
664 gdcmTagKey is made to old an "universal" (as in URL, Universal
665 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
666 A dicom tag allways has a group and an element, but a set of tags
667 embeded in various (optionally nested) sequences and sharing
668 the same group and element all share the same (group, element)
669 "identifier". Hence the (group, element) cannot be used as an
670 identifier (in gdcm we shall refer to a "TagKey") of a tag.
671 In order to construct a proper tag identifier (i.e. a key) we
672 consider the following definition of a TagKey:
673 - let Group, Element be the string representation of the
674 group and element dicom tag members,
675 - let ItemNumber be the string representation of the integer
676 index of the considered item number of a sequence,
677 Let the key of a tag embeded in a sequence, noted SeqTag, be
679 /ItemNumber#Group|Element
680 where "/", "#" and "|" are characters acting as separators.
681 Then the general form of a gdcmTagKey is given by:
682 Group|Element<SeqTag>
683 where <SeqTag> means NO or many instances of SeqTag.
684 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
687 but the gdcmTagKey of a tag "embeded" is the first item of
688 a sequence, itself nested in the third item of a sequence is the
690 0004|1220/2#0008|0082/0#0008|0090
691 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
692 order to hold the new sequence compatible key. Previously, the
693 GetKey() method would look in the underlying gdcmDictEntry.
694 - src/gdcmDocEntry.cxx:
695 -- constructor now copies the underlying DictEntry key, in the local
697 -- ::Print: displays the member Key, instead of the (group, element).
698 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
699 - src/gdcmDocEntrySet.h:xi
700 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
701 -- now has a new BaseTagKey member.
703 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
704 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
706 This poses the problem with the semantics of the following lines
707 LoadEntryVoidArea(0x0028,0x1201); // R LUT
708 LoadEntryVoidArea(0x0028,0x1202); // G LUT
709 LoadEntryVoidArea(0x0028,0x1203); // B LUT
710 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
711 to the long FIXME note for what the problem is. Nevertheless in
712 order to get things working the dicom dictionary was altered !
713 Please fix things urgently...
714 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
715 information), see above note on moving the member VoidArea. Nevertheless
716 the following entries previously correctly set as US are now inproperly
718 0028 1201 OW IMG Red Palette Color Lookup Table Data
719 0028 1202 OW IMG Green Palette Color Lookup Table Data
720 0028 1203 OW IMG Blue Palette Color Lookup Table Data
721 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
722 of gdcmDocEntry moved to gdcmSeqEntry.
723 * src/gdcmSeqEntry.cxx: STYLE.
725 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
726 * Test/TestAllEntryVerify.cxx minor fix and added comments.
728 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
729 * gdcmPython/testSuite.py: all the test suite in python is now moved
730 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
731 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
732 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
734 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
736 to avoid inclusion recursion until STL is reached.
737 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
738 mecanism. errno.h is not included in gdcm anymore.
739 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
740 (gdcmFormatError now inherits from gdcmFormatUnexpected).
742 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
743 gdcmData/TestAllEntryVerifyReference.txt
744 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
745 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
746 exception_on_error parameter.
747 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
748 - vtk/vtkGdcmReader.cxx changed accordingly,
749 - Example/*.cxx and Test/*.cxx changed accordingly.
751 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
752 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
753 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
754 enable_sequences removed from gdcmHeader constructor and dependencies.
755 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
756 * gdcmPython/demo/PrintHeader.py: dummy fix.
757 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
758 skip_shadow removed from gdcmHeader constructor and dependencies.
759 * Example/*.cxx and Test/*.cxx changed accordingly.
761 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
763 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
765 2004-07-21 Jean-Pierre Roux
766 * FIX Now, Parsing and Printing a DICOMDIR do work!
767 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
769 2004-07-20 Jean-Pierre Roux
770 * FIX Some brain damaged headers have Zero-Lenght fields
771 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
773 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
774 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
775 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
776 variable (instance of gdcmDebug) by a definition macro, and the instance
777 is now in static in the gdcmDebug class
778 * src/gdcmSQItem.h : (FIXME) remove an undefined method
779 * Test/PrintAllDocument.cxx : bug fix in the result of the test
781 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
782 * WARNING: ctest now depends more tightly on gdcmData. You should
783 check out gdcmData properly for things to run smoothly...
784 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
785 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
786 we need the pixels not be loaded in order to use the ValEntry
787 that displays position and size).
788 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
789 This is a C++ based equivalent of gdcmPython/testSuite.py that should
790 be deprecated. If you have any doubts about the advantages of a
791 modern scripting language (read Python) versus grass root C++ (i.e.
792 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
793 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
794 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
795 Anyhow, consider documenting the gdcmData images in
796 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
798 * Test/CMakeLists.txt:
799 - now uses TestAllEntryVerify.cxx
800 - specific comments on oldACR00001.ima (now renamed in gdcmData
801 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
802 gdcmData/TestAllEntryVerifyReference.txt
805 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
806 * src/*.[h|cxx] : typedef clean up
807 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
808 - TagKey renamed to gdcmTagKey (for external usage)
809 - VRKey renamed to gdcmVRKey (for external usage)
810 - removal of typedef duplication.
811 - Removed all unecessary inline keyword from class inline definitions.
812 - Some method|function(void) declarations replaced with method|function().
813 * src/jpeg/libijg12/jdhuff12.c:
814 - printf polluting ctest removed.
815 - TAB removal for comminting
817 - TestAllReadCompareDicom.cxx: added a test that compares all the
818 images in gdcmDataImages.h with corresponding images in
819 gdcmData/BaselineDicom/. When baseline images are not present
820 this test creates them.
821 Note: we need to validate each reference image, but before that
822 I'd like to rename them with a more explicit name...
823 - CMakeLists.txt: changed accordingly.
824 * Example/*.cxx: examples now only include gdcm.h (as opposed to
825 including each header needed).
827 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * Test/*.cxx and Example/*.cxx: moved some examples away from the
829 test suite to the Example directory. Are concerned:
834 - TestWriteSimple.cxx
835 * Test/CMakeLists.txt: added some comments on reasons for black listing
836 image gdcmData/oldACR00001.ima
838 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * Test/CmakeList.txt: removed the following from black list (to be coherent
840 with removal from gdcmData):
841 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
842 - gdcm-MR-PHILIPS-16.dcm
844 Added the following because after last cvs update, they cause
845 ctest -R TestReadWriteReadCompare
847 - gdcm-MR-SIEMENS-16-1.acr
849 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
850 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
851 new comments in this file) we temporarily (sigh) move to a weaker
853 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
854 we don't need to black list the following images anymore:
855 - 8BitsUncompressedColor.dcm
857 - US-PAL-8-10x-echo.dcm
858 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
859 fixes and the beautified code ;-)
860 This fixes the bug introduced in version 1.42 (when beautifying)
861 that made the parsing of 8BitsRunLengthColor.dcm unproper.
862 Note: ctest was blind to this bug (this means we need to still
863 improve the test suite). The bug could be detected by using
864 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
866 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
867 and by displaying the (garbage) produced file temp.XDCM...
869 2004-06-29 Jean-Pierre Roux
870 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
871 - replace by uggly but working old code :-(
872 A lot of things should be OK again.
873 It's really urgent to have a test suite that *tests*,
874 to prevent Frog's beautifying sessions to break all the stuff
875 (twice, withing a fortnigh ...)
877 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
878 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
879 redundancy) to added Test/TestReadWriteReadCompare.cxx
880 * Test/CmakeList.txt: because the compare test of
881 Test/TestReadWriteReadCompare.cxx fails, the following images are
882 black listed: - 8BitsUncompressedColor.dcm
884 - US-PAL-8-10x-echo.dcm
885 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
886 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
887 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
888 and ad-hoc kludge. This kludge is now removed, and on encountering
889 such an image (OB field brain damaged) we set errno. Then in
890 ::FindDocLength() we "fix" the length as being ALL what remains
891 in the file (until EOF). We then proceed, hoping for the best...
892 This fixes a SegFault in ShowDicom when trying to write such an
894 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
895 (because TestWriteRead breaks on it, after a non conformal commit?).
896 ctest now runs properly, except for MakeDicomDir (which was allways
897 broken) and the Python related stuff (still not fixed).
899 2004-06-24 Jean-Pierre Roux
900 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
901 FIX : Test/TestReadWrite now iterates on all the file names
902 (instead of infinite loop)
903 ENH : Test/TestWriteRead now iterates on all the file names
905 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
906 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
908 2004-06-24 Jean-Pierre Roux
909 FIX : - now Write drops LUT Descriptors and LUTs (if any)
910 when SamplesPerPixel =3
911 - now Write is no longer confused by
912 'BitsAllocated = 12" and 'BitsStored=12"
913 - "UN" value representation Elements are now written correctly
914 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
915 ENH : - now gdcmHeader has its own Write methods
916 (in order to split the job that has not to be done
919 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
921 loop on the same image until memory went out.
922 Note: this means we still have gobs of memory loss in PrintDocument
923 * src/gdcmDocument.cxx: fixes problem on parsing on file
924 gdcmData/16BitsJpegLosslessGrayScale.dcm.
926 2004-06-24 Jean-Pierre Roux
927 FIX : Write - All the Sequences and Sequence Item are now written
928 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
929 is added a the end, when necessary.
930 - A lot of brain-damaged images, that were read correctly are
931 now written correctly
932 - length compatible BinEntry are now loaded correctly
933 (even for odd groups)
934 Note : only Explicit Value Representation was checked.
935 (question : is implicit VR really necessary for gdcm ?)
937 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
938 * DEVELOPPER: added a proposition of coding style.
939 * src/gdcmDocEntry.h: removed every inline declaration (for test of
942 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
943 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
944 Use the gdcmDocEntry::Print() and Write() instead.
945 * src/gdcmDocument.cxx: bug fix.
947 2004-06-22 Jean-Pierre Roux
948 FIX : gdcmDocument.cxx
949 - Now we do recognize the JpegLossLess format (there was a misstyping in
950 code 'beautyfication' :-(
951 - Now we automaticaticaly load the Luts, if any
953 2004-06-22 Jean-Pierre Roux
954 In order : to write Sequences, whatever their imbrication level,
955 : to allow user to create his own Sequences
956 a lot of modif where necessary (adding, moving, or virtualising methods)
958 WARNING : save your own sources *before* cvs up !
961 ADD virtual void Write(FILE *fp, FileType filetype);
964 ADD virtual void Write(FILE *fp, FileType filetype);
965 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
968 ADD virtual void Write (FILE *fp, FileType filetype)=0;
969 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
970 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
971 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
972 ADD std::string GetEntryByName(TagName name);
973 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
975 std::string vr = "unkn",
976 std::string fourth = "unkn",
977 std::string name = "unkn");
978 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
979 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
980 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
981 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
982 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
983 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
984 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
985 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
988 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
989 ADD virtual std::string GetEntryByName (TagName tagName);
990 ADD virtual std::string GetEntryVRByName (TagName tagName);
991 REM virtual bool Write(FILE *, FileType);
992 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
993 FILE *_fp, FileType type);
994 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
995 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
996 REM virtual bool WriteEntries(FILE *_fp,FileType type);
997 REM virtual std::string GetEntryByName (std::string tagName);
998 REM virtual std::string GetEntryVRByName (std::string tagName);
999 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1000 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1001 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1003 std::string vr = "unkn",
1004 std::string fourth = "unkn",
1005 std::string name = "unkn");
1006 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1007 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1008 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1009 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1012 ADD virtual void Write(FILE *fp, FileType filetype);
1015 ADD virtual void Write(FILE *fp,FileType filetype);
1018 ADD virtual void Write(FILE *fp, FileType filetype);
1019 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1020 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1021 REM std::string GetEntryByName(TagName name);
1024 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1026 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1027 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1028 The default constructor invoked by the line
1029 gdcmHeader *f1 = new gdcmHeader( header );
1030 was gdcmHeader::gdcmHeader(bool) instead of the expected
1031 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1032 Hence the parsing wasn't executed... See also below.
1033 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1034 as explicit constructor didn't do the trick to fix the above problem.
1035 Could anyone explain why ?
1036 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1037 properly calls gdcmValEntry::Print() (that was weed out from
1038 code related to gdcmBinEntry).
1040 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * In order to fix memory leaks:
1042 - Test/TestWriteSimple.cxx: added cleaning of free store through
1044 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1045 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1046 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1047 (through the call to ::AddDicomDirMeta()) or the destructor
1048 would crash when deleting uninitialized ::metaElems].
1049 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1050 - src/gdcmDocument.cxx:
1051 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1052 from dynamic stores.
1053 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1054 was causing memory leaks.
1055 - src/gdcmSQItem.cxx:
1056 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1057 cleanly handled with polymophism: sorry but my milage is low).
1058 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1059 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1060 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1061 This avoids SegFaulting.
1062 - src/gdcmSQItem.h: coding style.
1064 - Test/TestWriteSimple still severely sucks. The output image content
1065 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1066 damaged when displayed with vtkgdcmViewer.
1067 - on memory leaks: TestWriteSimple leaks really less (see entry
1068 of 2004-06-18 in Changelog file for the call to valgrind).
1069 - on segfaults: ctest now passes all the tests but one (no more
1071 * Erroneous leading white fix:
1072 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1073 white[s] (as opposed to from >> xxx, that removes it [them].
1074 - src/gdcmTS.cxx: ditto.
1075 - gdcmPython/testSuite.py: dirty related kludge removed.
1076 * src/*: remaining references to gdcmParser removed.
1077 * src/*[cxx|h]: added copy[way]left header.
1080 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * In order to fix writing of dicom files:
1082 - Test/TestWriteSimple.cxx: a simpler example of writing.
1083 - Test/CMakeLists.txt changed accordingly.
1084 - src/gdcmDocument.cxx:
1085 -- The destructor now recursilvely removes potential sequences.
1086 -- Bug fix in ::IsJPEG2000()
1087 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1088 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1090 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1091 to only declared) and build on top of
1092 ::GetDocEntryByNumber(guint16, guint16).
1093 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1094 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1095 for usage in destructor and treatement of promotion in
1096 ::ReplaceOrCreateByNumber().
1097 - src/gdcmSQItem.cxx: destructor should better handle his job.
1098 Test/TestWriteSimple now runs (or at least it DOES something).
1099 * We can now start hutting memory links. A good starting point is:
1100 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1101 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1102 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1104 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1105 * Valgrind note: after Mathieu Malaterre teached me how to read
1106 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1108 Using gcc, you can force the STL to use malloc and to free memory as
1109 soon as possible by globally disabling memory caching.
1110 With 3.2.2 and later, you should export the environment variable
1111 GLIBCPP_FORCE_NEW before running your program.
1112 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1113 simply vanish (it is still not clear to me, whether this means that
1114 STL std::string leaks or if valgrind believes it leaks...).
1115 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1116 running bin/gdcmTests makeDicomDir):
1117 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1118 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1120 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1121 SegFaulting (I drowned in DicomDir related code when trying to
1122 understand why the list is empty...).
1123 * src/gdcmDocument.h: first BSD license header try.
1124 * Doc/License.txt added.
1126 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * src/gdcmDocument.[h|cxx]:
1128 - Clean up of the Transfer related predicates. They are now all based
1129 on new method isGivenTransferSyntax, that (should) handle properly
1130 the padding problem.
1131 - general clean up, simplification, and coding style.
1132 - Specific clean up of Parse7FE0() (umproperly named actually).
1133 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1135 2004-06-14 Jean-Pierre Roux
1137 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1138 - fix the display of SQItem ordinal number
1139 - add the GetSQItemByOrdinalNumber method
1140 - remove some useless never written private methods
1142 2004-06-14 Jean-Pierre Roux
1144 - adding a constructor taking a gdcmDocEntry as an input param
1145 - ReplaceOrCreateByNumber now returns :
1146 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1147 a gdcmValEntry * if a string value is passed as a param
1149 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1150 according to the param type (no longer sets a gdcmDocEntry)
1151 - GetValEntryByNumber, GetBinEntryByNumber added
1152 - NewValEntryByNumber and NewBinEntryByNumber added
1154 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1156 - GetSQItemNumber and SetSQItemNumber added, to provide
1157 a (relative) Item identier inside a given Sequence
1158 \warning : some pb remaining around this number
1160 - AddEntry now takes the Item Number as a param
1162 - adding a constructor taking a gdcmDocEntry as an input param
1164 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * Memory leak hunt with the following command:
1166 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1167 --show-reachable=yes gdcmTests PrintDocument
1168 It looks like many (all?) leaks are due to the STL (or a bad usage
1169 of the STL. The lines producing the leaks now have a comment with
1170 a "MEMORY LEAK" tag: you can retrieve them with
1171 grep "MEMORY LEAK" src/*
1172 Here are two typical examples which I can't help fixing:
1177 char * test = "babo";
1178 name = test; //// <--- valgrind detects 960 bytes lost in
1179 //// call to std::string::operator=(char const*)
1180 name.clear(); //// Doesn't help !
1188 std::cout << "Type a bunch of characters followed by RETURN: ";
1189 getline(std::cin, line); //// <--- valgrind dectects a loss
1190 //// of 1320 bytes in call to
1191 /// std::basic_istream<>& std::getline<>
1197 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1198 * src/gdcmHeader.[cxx|h]:
1199 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1200 and related, moved away to gdcmDocument.
1201 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1202 the corresponding protected accessors of inherited class
1203 gdcmDocument, removed ! As a consequence gdcmFile had to be
1204 declared friend of class gdcmDocument (see below).
1205 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1206 - Clean up of undefined or unused methods.
1207 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1208 account the changes to gdcmHeader.h).
1209 * src/gdcmDocument.h:
1210 - gdcmFile is now a friend class (in order to take into account the
1211 changes to gdcmHeader.h).
1212 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1213 (see changes to gdcmHeader.h).
1214 - Accessors (reading on the form GetEntry*) are now public.
1215 - Clean up of undefined or unused methods.
1216 * src/gdcmDocument.cxx:
1217 - adaptation to changes to gdcmDocument.h
1218 - ::OpenFile now writes a verbose message when file cannot be opened.
1219 - some std::string properly set to VRKey
1220 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1221 references to gdcmDocument.
1222 * Test/TestFindTags.cxx: changed accordingly to above changes.
1223 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1224 cvs repository gdcmData.
1226 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1227 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1228 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1229 conflicts with gdcmValEntry::voidArea.
1230 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1231 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1232 Value representation between StringRepresentable and BinaryRepresentable.
1233 * src/gdcmDocument.cxx:
1234 - method ParseDES: proper indentation restored and usage of
1235 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1236 - method LoadDocEntry: the fingerprint left in the SetValue() of
1237 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1238 removed. Reverting to previous code segment with the proper
1239 dynamic_cast< gdcmValEntry* >.
1240 Note: this was (partially) breaking the python test suite
1241 (gdcmPython/testSuite.py) that made usage of the above
1242 fingerprint to check presence of "Pixel Data".
1243 * src/gdcmDocEntry.h: coding style.
1244 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1245 now taken into account.
1246 * gdcmPython/gdcm.i: adaptation to the new internal representation
1247 of gdcm (exit gdcmParser, hello gdcmDocument).
1248 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1250 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1251 anymore, but instead prints the loaded Python dictionary.
1252 * .... alas, the python testSuite is still broken.
1254 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1255 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1257 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1258 * src/gdcmUtil.h : export methods
1260 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1261 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1263 * Initial addition of automatic python testing
1264 * Initial addition of automatic image comparison
1266 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1267 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1268 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1270 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1271 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1272 * Test/ShowDicom.cxx : bug fix for msvc compilation
1273 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1275 2004-05-04 Jean-Pierre Roux
1276 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1277 new concepts (and new classes) :
1278 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1279 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1280 - Sequence Doc Entries (gdcmSeqEntries)
1281 a Sequence is composed of Items.
1282 Each item is a set of Doc Entries (this is recursive)
1283 The non uniqueness of the 'Dicom tag' is due to this recursivity
1284 (never taken into account)
1285 Our unability to add a new 'entry' in the header
1286 at the proper location (neither in the H-Table (map or multimap),
1287 nor in the Chained List is also due to this recursivity.
1288 Don't try, right now, to use/modify/compile these new sources :
1289 nothing is finished.
1290 We just commit all the stuff, 'as is', in order not to loose it.
1292 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1293 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1295 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1296 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1297 file prefix (SetFilePrefix)
1299 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1300 * Add a new test: ShowDicom, for now this is just the c++ version of
1301 checkRead.sh, later it will be able to compare the image read against a
1303 * Replace the DEBUG on the stack with a global entry in cmake interface:
1304 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1306 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1307 * Add an example subdir, with a real example on how to read + write a
1310 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1311 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1312 * Doc/CMakeLists.txt: the main page is now properly differentiated
1313 between the developper and user version.
1314 * Doc/doxygen.config.in: dropped search related obsolete flags
1315 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1317 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1318 * DEVELOPPER: added some helpfull comments for compile/test/install
1321 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1323 src directory, now generated in the build dir.
1324 2. Tests as mentionned smarter
1326 4. Add a new method in gdcmDict that return the PubDict by name
1327 this is interesting for 3rd party lib like ITK,
1328 where we could set the institution name / patient name...
1330 * ENH: 1. Now the test suite is working for real
1331 2. All binaries are now output in the gdcm-bin directory
1332 (this was not true before)
1334 2004-04-28 Jean-Pierre Roux
1335 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1336 SeQuence indented printing of Dicom Header.
1337 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1338 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1339 Computation of SQDepthLevel is now part of gdcmHeader constructor
1340 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1341 tree-like structure of a Dicom Header.
1342 * FIX Test code cleaning
1344 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1345 * ENH: Adding automatic testing
1346 1. Need a DartConfig.cmake to submit to public
1347 2. Add a test driver gdcmTest.cxx
1348 3. gdcmTestMain, an helper for the main test driver gdcmTest
1349 4. Files in Test don't have a main anymore, this becomes interesting
1350 when we add more and more tests, thus dsw don't have to load
1352 * ENH: Adding a GDCM_DATA_ROOT for testing
1353 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1354 one file instead of seven + some small cleanup
1356 2004-04-22 Jean-Pierre Roux
1357 * ENH Minor changes to the Print() methods.
1358 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1359 Header printing. Example given with :
1360 > PrintHeader fileName 2 new
1361 (SQ based tree-like structure still to be done for the Header ...)
1363 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1364 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1365 1. I have added some unsigned where needed
1366 2. Some function parameter not used -> (void)
1367 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1368 4. g++ don't like character '\' in comment
1369 5. #define jpeg_create_decompress jCreaDecompress
1370 this really need to be fixed
1371 6. virtualize destructor of gdcmObject ... leakage
1372 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1373 this also really need to be fixed
1374 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1375 remove compression file
1376 (as we only do decompression, right ?)
1377 * ENH: Change malloc/calloc/free with c++ equivalent
1379 2004-04-21 Jean-Pierre Roux
1380 * FIX gdcmHeaderHelper::GetXSpacing
1381 when a single value is found (bug ?), xpacing is now
1382 defaulted to yspacing
1384 2004-04-19 Jean-Pierre Roux
1385 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1386 * ENH add parameters :
1387 bool exception_on_error = false,
1388 bool enable_sequences = false,
1389 bool ignore_shadow = false
1390 to the gdcmFile constructors to be full gdcmParser compliant
1391 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1392 to allow reading of PAPYRUS 3.0 files
1394 2004-04-06 Jean-Pierre Roux
1395 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1397 2004-04-02 Jean-Pierre Roux
1398 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1399 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1400 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1402 2004-03-30 Jean-Pierre Roux
1403 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1404 for ACR file, written out as DICOM files (hope so...)
1406 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1407 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1408 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1409 moved to base class gdcmParser and only the specialisation is kept
1411 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1412 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1413 already does the job.
1414 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1415 (to be consistent with gdcmParser::WriteEntries).
1417 2004-03-30 Benoit Regrain
1418 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1419 upate of the object's instance. It's passed to 2 in the unfavorable
1420 case : one in the ExecuteInformation, one in the ExecuteData
1422 2004-03-29 Jean-Pierre Roux
1423 * ENH : Check on file type to be written moved
1424 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1425 * FIX : gdcmObject::ResetBoundaries now stops properly
1426 when end-of-list is reached
1427 : gdcmVersion modified (as Benoit Regrain asked)
1429 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1430 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1431 * src/gdcmUtil.cxx: added forgotten iostream include.
1432 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1433 equivalent to ExplicitVR in existing code).
1435 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1436 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1437 now contains all the gdcmGlobal related code.
1438 * minor coding style and doxygenation changes.
1440 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1441 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1442 now contains all the Debug related code.
1443 * minor clean-up of includes in src/*.cxx
1444 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1445 CreateCleanString) removed.
1446 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1447 * Doc/DoxyMainPageUser.txt added.
1448 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1449 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1450 src/gdcmDirList.cxx)
1452 2004-03-24 Jean-Pierre Roux
1453 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1455 2004-03-23 Jean-Pierre Roux
1456 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1457 big endian made volumes
1458 * ENH Now gdcmParser constructor and destructor are protected to forbid
1459 end user to instanciate class gdcmParser
1460 (only gdcmHeader and gdcmDicomDir are meaningfull)
1462 2004-03-22 Benoit Regrain
1463 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1464 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1465 gdcmSerie to gdcmDicomDirSerie
1467 2004-03-19 Jean-Pierre Roux
1468 * ENH Now the tree-like structure describing a DICOMDIR comming from
1469 an already existing DICOMDIR file is consistent with
1470 the home-made tree-like structure build ex-nihilo
1471 or build from the files held (recursively) in a Directory
1472 functions gdcmDicomDir::CheckBoundaries()
1473 gdcmObject::SetBoundaries() added
1475 2004-03-17 Jean-Pierre Roux
1476 * REM (Eric Boix bug) : removal of meaningless
1477 gdcmDicomDirImage::NewImage function.
1478 * FIX now file names and directory name are written properly in the
1480 * FIX now gdcmDicomDir constructor may be call without any trick
1483 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1484 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1485 of gdcmDicomDirImage::NewImage as empty function.
1487 2004-02-28 Jean-Pierre Roux
1488 * ENH add gdcmDicomDir:NewPatient
1489 add gdcmDicomDirPatient:NewStudy
1490 add gdcmDicomDirStudy:NewSerie
1491 add gdcmDicomDirSerie:NewImage
1492 to allow making gdcDicomDir object.
1493 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1494 (as opposite to the gdcmHeader chained list)
1496 2004-02-11 Benoit Regrain
1497 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1498 when using from python
1500 2004-02-10 Benoit Regrain
1501 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1502 * FIX : in gdcmDicomDir when the directory is empty
1503 * ENH : add callback and methods to get the progression of dicomDir
1506 2004-02-06 Jean-Pierre Roux
1507 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1508 - GDCM_META added to gdcmDicomDirType
1509 - class gdcmMeta created
1510 * ENH : - A brief summary is now displayed at the beginning of
1511 'testDicomDir' to help disaster magnitude estimation
1512 * REM : Now useless Test/explDICOMDIR.cxx
1514 2004-02-05 Benoit Regrain
1515 * ENH : add methods in gdcmObject to get the hash table or the list of
1517 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1518 * FIX : wrapping python for TagHeaderEntryHT
1520 2004-02-04 Benoit Regrain
1521 * FIX : even length for some strings when writting the dicom dir
1522 * FIX : sort the images in the dicom dir
1523 * FIX : Bug fix for python use of dicom dir
1524 * ADD : a python demo
1526 2004-02-04 Jean-Pierre Roux
1527 * FIX : Final solution (?) for icone embedded images
1528 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1529 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1530 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1531 gdcmData/gdcm-MR-SIEMENS-16.acr1
1532 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1533 to make full checking easier
1535 2004-02-04 Benoit Regrain
1536 * FIX : WriteEntries : coding style & logic in parameters
1537 * FIX : Set the elements to create the DicomDir in a dictionary file
1539 2004-02-03 Benoit Regrain
1540 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1541 * gdcmDicomDir : add the load of directory
1542 * Bug fix and print add-on
1544 2004-02-03 Jean-Pierre Roux
1545 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1546 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1547 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1548 * FIX gdcmParser.cxx : 'group length' elements are now considered
1549 as integers, even for shadow groups, when file is Implicit VR
1551 2004-02-02 Jean-Pierre Roux
1552 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1554 of the last synonym :-(
1555 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1557 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1558 * FIX taking into account the possible 7fe0,0010 multiplicity
1559 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1560 to allow removal of references to 7fe0,0010, to deal with
1561 ACR-NEMA images, when 0028,0200 is meaningfull
1563 2004-01-31 Jean-Pierre Roux
1564 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1565 no longer writes 'Un' on disk
1566 * FIX SQ elements with actual length are now dealt with corectly
1567 * FIX gdcmFile::WriteBase make the difference, for color images, between
1568 the length (for Palette expanded images)
1569 and Raw Length (non expanded image + Palette)
1570 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1571 (that broke Write). Replaced by UL.
1572 Aware user will reload the field if he
1573 thinks it's necesssary
1575 2004-01-30 Jean-Pierre Roux
1576 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1577 when 'dirty Acr' is found, to be compliant with the new
1578 IsReadable() methods.
1580 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1581 (no DOUBLE images in kosher DICOM,
1582 but so usefull for people that miss them ;-)
1584 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1585 DICOMDIR related utilities (not checked as Windoze compliant)
1587 2004-01-28 Jean-Pierre Roux
1588 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1590 2004-01-27 Jean-Pierre Roux
1591 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1592 to allow skipping the shadow elements, to save memory space.
1593 The TRUE value for this param has to be used
1594 with a FALSE value for the 'enable_sequence' param.
1595 ('public elements' may be embedded in 'shadow Sequences')
1596 * gdcmHeader methods now deal with 'embedded icones images' in the header
1597 (even when an 'icone image sequence' is announced by the
1598 element (0x0088,0x0200), but there is NO icone at all ...
1600 * gdcmHeader sometimes Image Location value doesn't follow
1601 the supposed processor endianity (see gdcmData/cr172241.dcm).
1604 * gdcmHeader add the method
1605 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1606 to get *all* the Header Entries with the same tag.
1607 GetHeaderEntrySameName is probabely *useless*
1608 (no meaning : Name is *not* an identifier within the Dictionnary)
1610 2004-01-26 Benoit Regrain
1611 * Bug fix in the print of hexadecimal representations. Remove long fields
1612 in the print and add a third level of print to print them
1614 2004-01-23 Benoit Regrain
1615 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1616 * Bug fix on test suite after remove the strip made on not string fields
1617 * Split the IsReadable method between gdcmParser which test that the file
1618 is dicom and gdcmHeader which test that it's an image file
1620 2004-01-22 Benoit Regrain
1621 * DicomDir : clean code, add methods, set variables in protected or private
1622 * gdcmUtil : bug fix for the clean string method
1624 2004-01-19 Benoit Regrain
1625 * Add the use of shadow dictionaries
1626 * bug fix and coding style
1628 2004-01-19 Benoit Regrain
1629 * src/gdcmFile.cxx : bug fix concerning the close of file
1630 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1631 * Add the update of header entries using the shadow library
1633 2004-01-19 Benoit Regrain
1634 * removal of file gdcmHeader2.cxx
1635 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1636 inheriting from gdcmParser. This split is to prepare the integration
1637 of dicom dir parsing
1638 * bug fix under python
1640 2004-01-16 Jean-Pierre Roux
1641 * REM removal of class gdcmHeaderEntrySet
1642 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1643 * ADD add file gdcmHeader2.cxx
1644 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1646 2004-01-15 Benoit Regrain
1647 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1648 entries created while parsing the header. Thus, they will be destroyed
1649 when the gdcmDictSet will be destroyed
1650 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1653 2004-01-15 Benoit Regrain
1654 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1655 made a fatal error because of the memory release at the end of program.
1656 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1657 some memory and vtk seems to have some problems with that.
1658 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1660 2004-01-14 Benoit Regrain
1661 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1662 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1663 * src/*.[h|cxx] : make changes due to class name changes
1664 * gdcmPython/demo/*.py : bug fix due to method names
1666 2004-01-13 Benoit Regrain
1667 * src/*.[h|cxx] : coding style
1668 * vtk/*.[h|cxx] : coding style
1670 2004-01-13 Benoit Regrain
1671 * gdcmPython/testSuite.py : test the readable flag of file for tests
1672 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1673 It's lied to the stl compilation by MSVC (windows, always windows...)
1674 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1676 2004-01-12 Benoit Regrain
1677 * src/*.h : add comments
1678 * src/gdcmDictSet.h : set the method BuildDictPath in public
1679 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1680 directly setted in the source code
1681 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1684 2004-01-09 Benoit Regrain
1685 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1686 * setup.py : use a reference to gdcmVERSION
1688 2004-01-07 Benoit Regrain
1689 * Modification to compile with the distutils.
1692 2003-12-10 Benoit Regrain
1693 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1694 can use a gdcmHeaderHelper to load datas
1695 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1696 made in the source code
1698 2003-12-10 Benoit Regrain
1699 * Update Windows projects and .cvsignore files
1701 2003-11-12 Jean-Pierre Roux
1702 * ENH gdcmHeader constructor has one more parameter (default value : false)
1703 that allows the user to 'go inside' the SeQuences only
1705 gdcmElValSet:Print takes it into account
1707 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1708 * ENH: Update gdcmPython/CMakeLists
1709 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1710 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1712 2003-11-10 Jean-Pierre Roux
1713 * FIX : gdcmHeader::LoadElements is now based
1714 on the ListTag listElem member,
1715 not longer on the TagElValueHT tagHt member
1716 * ENH : PrintPubElVal shows (temporarily) both results,
1717 with the tagHt member and the listElem member.
1718 (it's easier to 'see' the problems when using Printheader)
1720 * FIX : old private member LgrElem is now splitted into
1721 ReadLength : Length actually found on disk (updated only
1722 if bug fixing is necessary), for internal
1724 UsableLength : Updated by FixFoundLength, to fix a bug
1725 or to allow Parser going on.
1726 Will allow to re-write a kosher header when a SeQuence
1727 with a length (not 0000) is found
1728 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1729 because gdcmElValSet::Add does not update ListElem
1732 2003-11-07 Jean-Pierre Roux
1733 * FIX misstyping in Transfert Syntax name table
1734 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1735 when they have an actual length (not 0000 nor FFFFF)
1736 (Nobody should care of it, but DICOMDIR explorers)
1738 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1739 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1741 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1742 * ENH: vtkGdcmReader now supports LUT !
1743 (vtkgdcmViewer for now is not able to use them though)
1745 2003-11-05 Jean-Pierre Roux
1746 * in testSuite.py : new files names for checking the package
1747 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1748 that returns the pixel area size to the *aware* (vtk) user
1749 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1751 2003-11-05 Benoit Regrain
1752 * in testSuite.py : Modify the rules for checking the paths
1753 : Explicit error messages
1754 * in __init__.py : Related modif
1756 2003-11-03 Jean-Pierre Roux
1757 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1758 to be used by aware (vtk) users that want to manage
1759 LUT (and no to turn the PALETTE image into an RGB pixels one)
1760 * GetPixelType now returns 8U for 24 Bits images
1761 (vtkGdcmReader compliant)
1763 2003-10-31 Jean-Pierre Roux
1764 * Removal of *all* gdcmData images and add them again
1765 in order to loose the 'history' of un-anonymised images
1767 2003-10-31 Jean-Pierre Roux
1768 * RMV : removal of useless jBitsInJsample.h
1769 for both 8 and 12 Bits JPEG Lossy Libraries
1771 2003-10-31 Jean-Pierre Roux
1772 * ENH : Add the functions gdcmFile::GetImageDataRaw
1773 gdcmFile::GetImageDataIntoVectorRaw
1774 that act as GetImageData and GetImageDataIntoVector
1775 except the making of an RGB Plane from Gray Plane + LUT
1776 Intended to aware (vtk) users who know how to manage
1779 GetLUTRGBA return a R,G,B,A LUT if any
1780 lgrTotaleRaw gives the 'Raw' length
1781 GetImageDataRaw returns the gray Plane
1782 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1783 (They stay Grey, just like with other Dicom viewers :-(
1785 2003-10-30 Jean-Pierre Roux
1786 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1788 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1789 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1790 being coherents dicom files.
1792 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1793 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1795 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1796 * ENH: Two steps is necessary to please VC++ compiler...
1797 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1798 * ENH: Add include dir to medcon lib
1799 * FIX: only one function is being exported for now !
1800 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1802 2003-10-29 Jean-Pierre Roux
1803 * adding gdcmHeader::GetLUTRGBA
1804 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1805 --> Mathieu, the modif u're waiting for is not yet committed
1806 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1808 2003-10-27 Jean-Pierre Roux
1809 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1810 00191113.dcm DermaColorLossLess.dcm
1811 MxTwinLossLess.dcm RadBWLossLess.dcm
1812 * ENH: For version prior to vtkImageViewer2 -r 1.19
1813 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1815 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1816 * Removal of ido stuff in CMakeLists.txt
1818 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1819 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1820 * FIX: remove a call to ->Modified ... see comments
1821 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1823 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1824 * FIX: Problem with path for libvtkgdcmPython
1825 * ENH: Try adding a search script for python site-package
1826 * RMV: Remove some file from medcon lib that are not necessary
1827 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1828 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1829 * FIX: More pragma disable fro VC++,
1830 I don't think I break something as it is also disable in VTK/ITK.
1831 But it fasten debug compilation time.
1833 2003-10-23 Jean-Pierre Roux
1834 * gdcm now deals with 16 Bits Run Length Encoded images
1835 (they are compressed as 2 planes images,
1836 one for the high Bytes, the other for low Bytes)
1838 2003-10-22 Jean-Pierre Roux
1839 * Now CheckRead takes into account :
1840 - the bugged 'Leonardo' Siemens images
1841 - the XA images, sent thru the burning VPRO station
1842 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1845 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * FIX: When copying a Makefile.am to CMakeLists.txt
1847 one should remove the '\'
1849 2003-10-22 Jean-Pierre Roux
1850 * in gdcmData adding a bugged 'Leonardo' Siemens image
1851 (wrong lengths in header)
1852 OK with gdcm, KO with the other viewers :-)
1853 * add a GE dlx XA image, thru the VEPRO burning station
1856 2003-10-21 Jean-Pierre Roux
1857 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1858 for a brutal checking of vtkgdcmViewer compliance
1860 2003-10-21 Jean-Pierre Roux
1861 * add the files for 'xmedcon' Jpeg Lossless library
1862 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1864 2003-10-21 Jean-Pierre Roux
1865 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1867 2003-10-21 Jean-Pierre Roux
1868 * garbage Siemens 'Leonardo' images dealt with
1869 (the patch is easy to remove)
1870 * cosmetic changes to avoid warnings
1872 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1873 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1874 no need to press 'r' now.
1876 2003-10-20 Jean-Pierre Roux
1877 * upgrade of checkRead.sh checkWrite.sh according
1878 to new Jpeg Lossless decompressor
1879 * add US.3405.1.dcm, a genuine RGB medical file ...
1880 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1881 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1883 2003-10-15 Jean-Pierre Roux
1884 * general anonymisation in gdcmData
1885 * adding the 'color files' from
1886 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1887 * adding some well knowed bugged-header images
1888 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1889 waiting for their inclusion in Python testsuite
1891 2003-10-15 Jean-Pierre Roux
1892 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1893 no longer seg faults when file is not found
1895 2003-10-14 Jean-Pierre Roux
1896 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1899 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1900 * TODO: *.in file to genereate a UseGDCM later
1902 2003-10-14 Jean-Pierre Roux
1903 * Some supposed-to-be Dicom Images have no preamble.
1904 OpenFile takes it into account
1905 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1906 * Missing elements added in dicomV3.dic
1907 (just to be affraid : have a look at
1908 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1909 and do it again next year ;->
1911 2003-10-13 Jean-Pierre Roux
1912 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1913 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1914 But there are NOT. It's fixed !
1916 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * FIX: "jpeglib.h" was not found on VC++
1918 * FIX: vtkgdcm was not being installed
1920 2003-10-10 Jean-Pierre Roux
1921 * ENH : OpenFile closes the file if it *really* doesn't look like
1922 an ACR-NEMA / DICOM one.
1923 * FIX : testWrite no longer writes an empty file if the source file
1924 is not gdcm Readable
1925 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1928 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1929 * FIX: CMake generate now documentation
1930 * ENH: out of source doc build !
1931 * ENH: Generate both user and dev documentation
1932 * ENH: Should work on windows too
1933 * ENH: Only one doxygen config.in file is needed
1934 * FIX: make install should be ok now on ùnix plateform
1935 * FIX: PATH to dictionary was wrong (missing /)
1936 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1938 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * vtkGdcmReader is now able to read rgb dicom file.
1940 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1941 * added a gdcmViewer to vtk test, use mouse to control
1942 window level & window width
1944 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1945 * CMake-ification of gdcm, we have now two build system
1946 * FIX: on cygwin Wsock32 doesn't exist
1947 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1949 2003-10-06 Emanuel Ollart
1950 * FIX : compilation process wad broken.
1951 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1953 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * change gdcmViewer -> vtkgdcmViewer
1955 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1957 2003-10-06 Jean-Pierre Roux
1958 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1959 ( e.g : well known GE images with a wrong elem length,
1960 : Philips MRI Images with a wrong Huffman table)
1961 * still to be done : allow the reading of bugged LEONARDO Siemens images
1963 2003-10-03 Jean-Pierre Roux
1964 * Odd length strings are padded with '\0' (not with spaces,
1965 to remain compliant with already defined strings,
1966 like Transfert Syntax UID and others)
1968 2003-10-03 Jean-Pierre Roux
1969 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1970 to allow displaying RGB images (not only by affim ;-)
1972 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1973 * vtkGdcmReader is now able to read rgb dicom file.
1974 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1976 2003-10-03 Jean-Pierre Roux
1977 * A few nasty patches to allow the reading of a lot of nasty images
1978 ( e.g : well known GE images with a wrong elem length,
1979 : Philips MRI Images with a wrong Huffman table)
1980 * still to be done : allow the reading of bugged LEONARDO Siemens images
1982 2003-10-03 Jean-Pierre Roux
1983 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1985 2003-10-03 Jean-Pierre Roux
1986 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1987 to allow displaying RGB images (not only by affim ;-)
1989 2003-10-03 Jean-Pierre Roux
1990 * gdcmFile::GetImageDataIntoVector now
1991 - deals with MultiFrames MultiFragments Run Length Encoded files
1992 - deals with YcBcR (YBR_FULL) files
1993 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1994 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1996 (no sample found :-(
1998 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1999 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2000 Two reasons: - clear things
2001 - third parties acces gdcm through header files, so won't
2002 suffer anymore VC++ complains
2004 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2005 * add argv[1] in testvtkGdcmReader.cxx
2008 2003-09-24 Jean-Pierre Roux
2009 * The lines are now eigthy characters long.for
2010 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2012 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2013 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2014 char* to std::string. Thus, the use of strdup becomes useless. (see
2015 previous commis of Malaterre)
2016 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2017 before the last Malaterre's commit.
2019 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2020 * This commit should fix the Debug building under VC++, the problem
2021 was mainly a mixture of debug and release lib being loaded at startup.
2022 * I also remove a depency to a specific C function: strdup. Because I had
2023 to force the link to msvcrtd (whereas strdup is in libc).
2025 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2026 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2027 located in the gdcmCommon.h file. All use of reference of tha has been
2028 changed to now use the variable GDCM_UNFOUND.
2030 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2032 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2033 Dicom dictionary. The test suite can now be run again. Note:
2034 I'm note very happy with the " (RET)" changes. I believe this
2035 RETAINED comment should be dropped when parsing the dictionary.
2036 - PACKAGER corrected
2038 - AUTHORS updated and now in alphabetical order
2039 * Makefile.am now exports gdcm.dsw for Windoze users.
2041 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2042 * cygwin complains about missing std:: in subdir Test/
2044 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2045 * remove some methods that are now in gdcmHeaderHelper
2047 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2048 * vtkGdcmReader set spacing and origin correctly
2050 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2051 * Fix a few delete/delete[] mismatch
2053 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2054 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2055 interpretation to data given by gdcmHeader. For instance there are
2056 heuristics to get informations (look at different places).
2057 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2058 sorting DICOM images based on different strategies.
2059 * modified Makefiles accordingly.
2061 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2062 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2063 when building in debug mode
2064 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2065 src/win32/gdcmdll.dsp
2066 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2068 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2069 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2072 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * src/win32/libgdcmjpeg12.dsp was not dos format
2074 * src/win32/libgdcmjpeg12.dsp :
2075 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2076 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2078 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2079 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2081 * src/gdcmFile.cxx : bug fix in affectation type
2082 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2083 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2084 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2085 symbols... future problem ?
2087 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2088 * src/win32/libgdcmijpeg12.dsp was missing
2089 * modified gdcm.dsw accordingly
2091 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2092 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2094 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2095 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2096 commit of JPR (before his hollidays to facilitate our work).
2097 * setup.py : bug fix in code. Modifications made while the last commit
2098 of JPR. The code hasn't been tested before the commit... it's so
2099 useless to make that (for best programmer that is JPR) !!!
2101 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2102 * tagged the current version as Version0_3 (i.e. version 0.3)
2104 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2105 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2106 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2107 * *.dsp : modifications to use new libgdcmijpeg8 library
2108 * setup.py : bug fix on VTKPATH variable
2109 * PACKAGER : adding all concerning windows
2111 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2112 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2114 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2115 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2116 test suite reported error.
2117 * PACKAGER file added (describes what a packager must do when
2118 packaging a new release).
2119 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2120 * configure.in: upgraded version number to 0.3.0
2121 * fixing build of rpm (through rpm -ta):
2122 - Doc/Makefile.am exports proper doxygen files
2123 - src/jpeg/libijg8/Makefile.am exports the include files.
2125 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2126 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2127 * src/gdcmHeader.h : formatting code
2129 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2130 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2131 We were obtaining error message from vtk. Now, creation of file list
2132 is made in an internal list to prevent this problem.
2133 Bug fix when output is empty.
2134 Bug fix in update of progress value. Previous commit for this was a bad
2136 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2138 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2139 * src/gdcmHeader.h : added method to get the file name
2140 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2141 files. Added method to remove all files on the input
2142 Added FIXME comment concerning the bad parsing of header made by
2143 ExecuteInformation method (in ExecuteData method)
2145 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2146 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2147 when using make instal.
2148 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2149 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2151 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2152 * setup.py : adding include dir of jpeg lib to compile all sources
2153 * */Win32/*.dsp : JPR fix for windows compilation
2155 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2156 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2158 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2159 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2161 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2162 * setup.py is again effective on un*x (takes into account the
2163 addon of the jpeg library)
2164 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2165 * Doc/Doxy* updated (includes above enhancements)
2166 * INSTALL now points to web documentation
2168 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2169 * src/gdcmHeader.h doesn't make unnecessary reference to
2171 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2173 * src/gdcm*.[cxx|h] :
2174 - to allow compilation with gcc 3.x
2175 -- clean up of STL usage (added explicit usage of std::)
2176 -- small fixes on exceptions.
2177 Note: linking not tested !
2178 - clean of doxygen comments to avoid warnings at documentation
2180 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2181 dependent convertion).
2183 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * Clean up of previous JPR garbage commit (not even commented in the
2186 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2187 - moved all jpeg related files from src to src/jpeg/libijg8, with
2188 addition/modification of Makefile.am and configure.in.
2189 - the testSuite is still brain damage (not guilty).
2191 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2192 * WrapVTK.py : modifications to get correctly vtk source files to
2194 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2195 (FileName -> Filename)
2197 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2198 * vtk/vtkGdcmReader.[cxx/h]:
2199 - UpdateProgress method should now be effective
2200 - removed the limitation on having only images loaded (as opposed
2202 - when building a stack of images/volume, a lesser number of
2203 gdcmHeader and gdcmFile instances should be used (hopefully
2204 accelerating things).
2205 - when building a stack of images/volumes, files which are not
2206 loadable (wrong path-filename, wrong permissions on existing file,
2207 or file not parsable by gdcm) are replaced with a black image
2208 in the stack (for the caller to notice the problem).
2210 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2211 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2213 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2214 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2215 between standard library (std) and vtk library (problems are found
2216 under Windows... thanks Windows !)
2218 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2219 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2221 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2223 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2226 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2227 * When compiling with distutils (see setup.py) the C++ compiler is
2228 called with different flags than the default ones (with automake).
2229 In order to fix all those warning, I compiled gdcm with the command
2230 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2231 and went for warning fixes:
2232 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2233 up from unused variables.
2234 - vtk/vtkGdcmReader.cxx: potential bug fix.
2235 * src/gdcmHeader.h: Doxygen warning cleanup
2237 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2238 * gdcmPython/gdcm.i:
2239 - typemaps correction to take into account the systematic replacement
2240 of "using namespace std" with std:: prefix e.g. std::list,
2241 std::string... (cf changes of 2003-05-21).
2242 - gdcmGlob global variable of type gdcmGlobal (defined in
2243 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2244 exported to Python a as cvar.
2245 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2246 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2247 gdcmDictSet.GetPubDictTagNames() and
2248 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2249 C++ static methods).
2250 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2251 with the above changes.
2253 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * setup.py, manifest.in : bug fix under linux
2256 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2257 * Modification of setup.py to compile vtk part too. Then, we have 2
2258 wrappers which must work with same distutils. For that, we have a
2259 generic distutils in distusiltsWrapping.py ; with :
2260 - build_extWrap class to wrap generically all extensions,
2261 - ExtensionWrap base class for all wrapping extension that contains
2263 - Wrapper interface which wrap sources
2264 + In WrapSwig.py we have extension and wrapper for Swig
2265 + In WrapVTK.py we have extension and wrapper for VTK
2266 * MANIFEST.in : modifications to consider vtk directory and new python
2267 files for compilation
2269 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2270 * Added python wrappers of vtkGdcmReader vtk class (see the
2271 source in vtk/vtkGdcmReader.cxx) :
2272 - vtk/Makefile.am now builds a library
2273 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2274 python library (as opposed to _gdcm.so wich are the python
2275 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2276 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2278 - configure.in has an additional flag --enable-vtk that needs
2279 to be set to enable compilation of vtk related code, that is:
2280 + vtk/vtkGdcmReader.so and
2281 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2282 + gdcmPython/vtkgdcmPython.so (see above)
2283 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2284 be read when compressed or when HighBit + 1 != BitsStored),
2285 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2286 the usage of the python wrapper of vtkGdcmReader vtk class.
2287 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2288 * src/*.[h] all occurences of stl classes are now prefixed with
2289 std::, and all occurences of "using namespace std;" where removed.
2290 This is to avoid pollution of global namespace in included files.
2291 Apparently vtk does not avoid this pitfall: when using both
2292 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2293 collision of various stl members (principally cout...).
2294 * gdcmPython/testSuite.py now cleanly removes temprory generated
2296 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2297 comply with above changes)
2299 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2300 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2301 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2302 vtk data structure (an image Flip was required).
2303 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2304 * cosmetic changes in documentation.
2306 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2307 * src/gdcmHeader.cxx: the constructor no longer exits when an
2308 unexisting file is given as argument.
2309 * The subdirectory Data (containing all the images used for the
2310 test suite) is not part of this repository anymore. A new module
2311 containing those images is now available at
2312 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2313 with the name gdcmData.
2314 All the python scripts (including the package initialisation file
2315 gdcmPython/__init__.py) were adapated to take this change into
2316 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2318 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2319 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2320 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2321 demo of the usage of this class.
2322 Compilation of this vtk part is only done when using the --enable-vtk
2323 at configure (or autogen.sh) stage.
2325 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2326 * More memory link related corrections and documentation fixes.
2328 - maximum info is obtained with a command of the form:
2329 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2330 --show-reachable=yes PrintHeader
2331 - the remaining reachable blocks seem to come from the STL
2332 allocation scheme through the usage of map and list. It looks
2333 like this memory cannot be freed but it is not a memory leak
2334 (in fact further invocation to the STL would recollect the
2335 unused memory allthough it cannot explicitely be freed).
2336 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2337 of displaying an image parsed with gdcm and displayed with VTK.
2338 Note: some images don't seem to work e.g.
2339 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2340 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2341 Allthough this weakens the semantics, it is a ditch attempt to
2342 make gdcm more thread friendly.
2344 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2345 * Memory link hunt (by using valgrind through the command
2346 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2347 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2348 gdcmHeader::_dicom_vr.
2349 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2350 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2352 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2354 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2355 * src/Makefile.am now exports all the necessary include files at
2359 * UpdateGroupLength replaced by new one
2362 * UpdateGroupLength re-written using H-Table
2363 (named UpdateGroupLengthNew untill checks are over)
2365 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2366 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2367 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2369 - gdcmHeader::GetPubElValSet removed.
2370 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2371 UpdateGroupLength, WriteElements, Write.
2372 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2373 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2374 carried the same semantics.
2375 - src/gdcmHeaderIdo.cxx changed accordingly.
2376 - gdcmFile::WriteBase now regroups all the codes from previous
2377 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2378 - enum FileType moved to gdcmCommon.h
2379 * src/gdcmHeader.cxx AddDefault trashed
2380 * gdcmGetXSize added
2381 * getimageDataSize now calls gdcmGetXSize
2382 * Test/*.cxx changed to agree with above changes
2384 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2385 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2386 (to avoid double call by end user).
2387 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2388 by end user, since gdcmHeader::gdcmHeader now handles it.
2390 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2391 * gdcm/Doc many doxygen changes:
2392 - Doxyfile now has two different versions, DoxyfileUsers that generates
2393 the html.users end users oriented documentation and
2394 DoxyfileDeveloppers that generates the html.developper developper
2395 oriented documentation.
2396 - README changed accordingly
2397 - requirement.txt removed (old design info moved to TODO).
2398 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2399 DoxyMainPage.txt, DoxyPython.txt provide more information.
2400 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2401 be updated by simply regenerating the docs with doxygen and copying
2402 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2403 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2404 all the tests in the form "if (<map>.count() >1)" were removed.
2405 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2406 ill-formed documentation sections.
2407 * src/gdcmHeader.cxx: ditto
2409 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2410 * setup.py fixed for un*x (needed macro for stdint.h)
2411 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2412 un*ces with sh-utils test utility.
2413 * gdcmPython/demo/test.py renamed to PrintHeader.py
2414 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2415 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2416 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2417 * src/gdcm*.cxx JPR's bad inclusion fixed.
2419 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2420 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2421 * gdcmPython/demo/test.py changed accordingly.
2423 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2424 * gdcmPython/Makefile.am fixed linking against libstdc++
2425 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2426 * Swig subdir (historical tests of swig version 1.3.17++) removed
2427 * Test/testChangeEntete.cxx some lines commented out in order to make
2429 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2430 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2432 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2433 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2434 hence the user doesn't need this explicit call.
2435 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2436 i.e. LoadElements() call removed.
2437 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2438 - src/Makefile.am declares the proper flag for g++.
2439 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2440 for adding user defined new tags.
2441 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2442 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2443 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2445 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2446 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2447 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2448 src/Makefile.am : the project should properly compile and install
2449 with the autotools, included the python wrappers part.
2450 * gdcm.spec.in : added a spec file for RPM packaging.
2452 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2453 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2455 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2456 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2457 to exported to the environement (see gdcmPython/testSuite.py
2459 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2460 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2461 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2462 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2463 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2465 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2466 * gdcmPython/__init__.py doesn't crash anymore when running in
2467 in InstallMode or PreInstallMode but with an environement given
2468 value of GDCM_DICT_PATH.
2469 * src/gdcmDictSet.[cxx/h] coding style.
2471 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2472 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2473 * src/gdcm.h general comments moved to TODO, and README
2474 * src/gdcm.h should now be seen as a user commodity (including it
2475 should suffice to fully use gdcm). It is nowhere including within
2476 any of the kernel files src/*.cxx and src/*.h.
2478 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2479 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2480 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2482 * src/gdcm*.cxx only include their corresponding include file
2483 (as opposed to gdcm.h)
2484 * gdcmPython/gdcm.i changed accordingly
2485 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2486 the autogen.sh generated "make snapshot" command to work.
2487 * autogen.sh removed history related references to crea package.
2489 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2490 * distutilsSwigCPlusPlus.py work around some swig portability
2493 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2495 was done in a last ditch attempt to get setup.py _really_
2496 operationnal. The python/gdcmPython layaout add the advantage
2497 of hidding away the python related distutils specific files
2498 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2499 Alas, the src directory was out of scope (i.e. it's relative
2500 position to setup.py was ../src) which made things impossible to
2501 handle (see previous version of python/setup.py). Crossing fingers...
2503 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2504 * python/setup.py now works on Un*x. (harder than I thougth)
2505 * python/distutilsSwigCPlusPlus.py can now have include files
2506 among the list of sources.
2508 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2509 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2510 * modifications in MSVC projects
2512 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2513 * As stated by the first lines of Test/ExceptionAndPython/README, it
2514 looks like we can move back to original usage of exception within
2515 src/gdcm* and hence remove the errno stuff that was introduced
2516 as a quick and dirty fixture of this problem (added to the TODO).
2517 * Doc/Doxyfile configuration file for Doxygen and corresponding
2518 README file for usage added.
2519 * Test/testWrite.cxx added. This new test comes from a split of
2520 test.cxx that is now reverted to its original purpous i.e.
2521 testing the proper parsing of a Dicom related file.
2522 testWrite.cxx concentrates on testing the IO part of gdcm.
2523 * Test/bug1.cxx (containing a bug on WIn32) added.
2524 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2525 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2526 whose purpose is to publish the content of the TagNames of the
2527 Dicom public dictionnary were not accessible without an
2528 instance of class gdcmHeader.
2529 - those methods are now static methods of gdcmDictSet and hence
2530 require no instances at all to be invocated.
2531 - within gdcmDictSet this change required to change some method
2532 to class methods (i.e. are now static) among which SetDictPath
2533 (renamed to BuildDictPath) and LoadDefaultPubDict.
2534 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2535 the above changes by calling the new method classes of gdcmDictSet.
2536 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2537 the above to be effective.
2538 * python/gdcmPython: in order to wrap properly the above changes
2539 for Python, swig version now needs to be > 1.3.17.
2540 * python/gdcmPython/Makefile fixed to adapt itself to new
2541 configure/make shema introduced by Johan Montagnat (thanks for the
2542 contribution). Alas this Makefile cannot be turned into a proper
2543 Makefile.am without some heavy changes in the configure.in
2544 (for python dectection).
2545 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2546 now avoids publishing the empty entries.
2548 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2549 * python/setup.py : bug fix concerning install under windows
2550 ExtraPath reused :-P
2551 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2553 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2554 * Dicts/dicomV3.dic : remove double spaces !!!
2555 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2556 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2559 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2560 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2561 method. Doxygenation.
2562 * src/gdcm.h clean up of JPR spurious comments.
2564 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2565 * python/distutilsSwigCPlusPlus.py now properly collects the
2566 shadow classes generated by "swig -c++" (gdcm.py in our case)
2567 when using "python setup.py install".
2568 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2569 reexports the working classes.
2570 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2571 by the classical C errno scheme. This is to prevent an obscure
2572 behavior of the python wrappers when importing wxPython.wx prior
2573 to gdcmPython (which ended up in an abort call). An illustration
2574 of this oddity can be found in the Test/ExceptionAndPython
2575 subdir (see the README file). This problem probably due to
2576 an combination of g++ and dynamic loading.
2577 * added Test/ExceptionAndPython (see above)
2579 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2580 * Changed the layout of the python part to avoid bloating main
2581 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2582 i.e. the distutils arsenal. All the python related stuff is
2583 again in a python subdir, but the package itself is now in
2585 * setup.py was cleaned up:
2586 - pythonIncludePath removed
2587 - python setup.py bdist target is now functional.
2588 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2589 collision with other packages). gdcmPython/demo/*.py changed
2592 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2593 * python subdir moved to gdcmPython (preparation of distutils packaging).
2594 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2595 distutils installer is operational.
2596 * - gdcmPython/__init__.py now properly loads the swig generated
2597 shadow classes (from gdcm.py).
2598 - gdcmPython/demo/*.py changed to import the package gdcmPython
2599 instead of gdcmPython/demo/load.py.
2600 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2602 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2603 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2604 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2605 entries within the associated public Dicom dictionary resp. the same
2606 information but sorted by the fourth field (PAT, IMG, DIR) of the
2608 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2609 are now in the "???" group.
2610 - python/gdcm.i changed accordingly,
2611 - python/demo/printGroupedPublicDict.py added, that gives an example
2612 of the above new functionalities in Python.
2614 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * src/gdcm.h, gdcmHeader.cxx:
2616 - historic references to glib's g_malloc and g_free (#defined)
2617 were definitively removed.
2618 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2619 * src/gdcmElValSet.cxx:
2620 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2621 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2622 - GetElValue(string) renamed to GetElValueByName.
2623 - Added GetElementByName(string).
2624 * src/gdcmHeader.cxx: added
2625 - GetPubElValRepByNumber(guint16, guint16)
2626 - GetPubElValRepByName(string)
2627 - GetShaElValRepByNumber(guint16, guint16)
2628 - GetShaElValRepByName(string)
2629 - GetShaElValByNumber(guint16, guint16)
2630 - GetShaElValRepByName(string)
2631 - GetElValRepByNumber(guint16, guint16)
2632 - GetElValRepByName(string)
2633 - GetElValByNumber(guint16, guint16)
2634 - GetElValRepByName(string)
2635 * Doc/requirements.txt added.
2637 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2638 * Test/Makefile building now depends on the one of libgdcm.so
2639 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2640 pixel data) aware which enables finding the address (offset) of
2641 the pixel data of JPEG encoded DICOM files. This leaves only a single
2642 file in the testSuite whose pixel data address (offset) is unknown.
2643 * python/testSuite.py changed accordingly.
2645 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2646 * VC++ has some strong limitations when working with the STL, as stated
2647 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2648 "Also note that some STL containers (map, set, queue, list, deque)
2649 cannot be exported. [...]
2650 Some STL classes contain nested classes. These classes can not
2652 This is caused by a designed limitation that once a template
2653 class is instantiated, it can not be re-instantiated and
2655 Since our usage of map<> is ubiquitous in gdcm, this "designed
2656 limitation" of VC++ is a pitfall.
2657 Hence the Python wrappers of gdcm cannot be incrementally linked
2658 against the c++ dynamic library. The dirty but only workaround is
2659 to forget about incremental link of dynamic libraries and to generate
2660 the Python wrappers library with the inclusions of the underlying C++
2662 The following modifications concern this matter on Win32/VC++:
2663 - wrapping python correct with standalone wrapped dll (don't use separate
2664 dll under windows !!!!)
2665 - python21_d debug mode enabled (ask Frog how to use it :-)
2666 - NO problem with having an STL member of class for example string in C++
2667 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2668 - Python test of dcmlib in Python is ok under windows on a large set
2670 * removed glib references
2671 * typedef's inserted in gdcm.i for correct swig type management
2673 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2674 * python/demo/*.py load.py extracted from test.py. Added explore.py
2675 that only displays required tags and testAll.py that parses all
2676 the files of the testsuite without using unittest.
2677 * python/testSuite.py other additional test on new files added.
2678 * Data/* new test files added accordingly to the testSuite.
2679 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2680 the vr in the file differs from the one of the dictionary.
2682 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2684 values, but limits itself to values which are below a user specified
2685 size (by default 1024 bytes).
2686 * python/gdcm.i : elements not loaded (because their size is above the
2687 user specified treshold) are exported with their TagKey as key of the
2688 python dictionary. This enables the testsuite to make some checks
2689 on the unloaded elements (since we have their offset and size).
2690 * python/testSuite.py
2691 - now tests for the existence and proper value of the pixel data
2692 - two new examples added.
2693 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2695 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2697 aware. See the strategy comments in gdcmHeader::FindeLength().
2698 * Test/test.cxx now accepts a filename as first argument.
2699 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2700 * python/testSuite.py changed to integrate test on above files.
2702 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2704 the vr was also RET.
2705 * python/testSuite.py more tests added.
2707 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2708 * python/testSuite.py unittest test suite added (uses Data)
2709 * Data/* dcm and acr files for the test suite.
2710 * glib dependance removed from un*x version. We now use ISO C99
2711 7.18 Integer types (see stdint.h)
2712 - python/Makefile, src/Makefile src/gdcm.h
2713 * src/ when an explicit vr (like dicom files) suddenly poped an
2714 implicit element we use to mark the underlying DictEntry of the
2715 concerned ElValue with "Implicit". This strategy was damageable
2716 too the public or provite dictionaries, since some of their vr
2717 would be changed. Since Header::FindLength heavily relies on the
2718 detection by Header::FindVR of falsely explicit elements, I
2719 added an extra ImplicitVr member to ElValue (boolean).
2720 The rest of the changes we the necessary adaptations.
2722 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2723 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2725 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2727 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2728 * Adaptation for porting to VC++:
2730 o forced to use std namespace (for string to be known)
2731 o all class use __declspec export style on WIN32
2732 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2733 (in stdlib.h on Win32 but in std:: for gcc)
2734 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2735 variable GDCM_DICT_PATH.
2736 * src/gdcmHeader.cxx verbose comments made discrete.
2738 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2739 * python/gdcm.i: added a typemap that converts a C++ hashing table
2740 to native Python dictionary.
2741 * python/demo/test.py:
2742 - now uses the native dictionary for exploration of gdcmHeader.
2743 - takes an optional filename argument (the file to parse).
2744 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2745 PubElVals hashing table.
2746 * Dicts/dicomV3.dic removed error prone trailing spaces.
2748 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2749 * Python wrapping process moved away from src/Makefile to
2750 newly created python/Makefile (as well as gdcm.i)
2751 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2752 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2753 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2754 from the environement variable GDCM_DICT_PATH (when existing).
2755 * src/gdcmDict::GetTag bug fix.
2757 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2758 * Straightforward temporary fixes for swig to build the python wrappers.
2759 src/Makefile now has a python working entry [by working we mean
2760 that we can import de shadow classes without errors].
2762 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2763 * hashtest.cxx removed (since allready in Test)
2764 * src/gdcmlib.h renamed to src/gdcm.h
2765 * src/dcm.i renamed to src/gdcm.i
2766 * src/Makefile prepared for python wrapping
2768 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2769 * src/gdcmHeader.cxx :
2770 - Parsing of header is now separated from loading of element values
2771 (see gdcmHeader::LoadElements).
2772 - general clean up of hopefully all file access (creation of
2773 ReadInt16 and ReadInt32)
2775 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * src/gdcmHeader.cxx :
2777 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2779 - SetLgrElem renamed to SetLength
2780 - GetLgrElem renamed to GetLength
2781 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2782 * src/gdcmElValSet.cxx fixed both GetElValue methods
2783 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2784 due to IdoDude was cleaned out.
2786 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2787 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2788 concentrates on finding the value representation (when it exists).
2789 RecupLgr now only finds the element value length, and it avoids
2790 returning the unecessary skL (skipped length).
2791 Also, offsetCourant was simply removed (with taille_fich) since
2792 it was redundant with the File position internals (by using
2793 ftell and fseek). This also made skL (see above in RecupLgr) usage
2795 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2796 on the libido specificities which are handled through class
2798 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2801 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2802 * Truckload of changes. Parsing of header is barely functional
2803 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2805 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * src/gdcmHeader.cxx many addons of low level methods
2808 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2810 and _IdDcmSWAP_LONG.
2812 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2813 * This corresponds to all the changes decided at the meeting of
2814 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob