1 2004-09-23 Jean-Pierre Roux
2 * FIX In order not to be poluted any longer by casting problems,
3 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
4 we can now delete[] it safely
5 * VoidArea is now called BinArea (less confusing name),
6 and all the methods called ...VoidArea... are now ... BinArea...
8 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
9 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
10 clear) TagHT, which is an inherited member of gdcmElementSet. It is
11 up to the destructor of gdcmElementSet to clean up TagHt and it's
14 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
15 * Test/CMakeLists.txt: update to follow gdcmData renamings.
16 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
18 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
19 * ENH: added some utility method that builds a flat dictionnary
20 holding all the Dicom entries contained in the recursive structure
21 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
23 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
24 BuildFlatHashTable() that build a flat dictionary.
25 - src/gdcmElementSet.h: added a new private GetTag() accessor.
26 gdcmDocument is now a friend of gdcmElementSet.
27 - src/gdcmElementSet.cxx: clean up.
28 - Example/FlatHashTablePrint.cxx added.
29 - Example/CmakeLists.txt changed accordingly
31 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
32 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
33 moved away from gdcmDocEntrySet (since this class is an abstract class
34 acting like an interface). SQDepthLevel and BaseTagKey are now
36 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
37 and associated accessors. Doxygenation of the class.
38 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
40 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
41 Use SQDepthLevel accessor instead. ::Print() adapted.
42 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
43 - src/gdcmDocument.cxx changed accordingly.
45 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
46 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
47 - The following is the doxygen comment of the typedef declaration
48 of gdcmagKey in src/gdcmCommon.h:
49 gdcmTagKey is made to old an "universal" (as in URL, Universal
50 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
51 A dicom tag allways has a group and an element, but a set of tags
52 embeded in various (optionally nested) sequences and sharing
53 the same group and element all share the same (group, element)
54 "identifier". Hence the (group, element) cannot be used as an
55 identifier (in gdcm we shall refer to a "TagKey") of a tag.
56 In order to construct a proper tag identifier (i.e. a key) we
57 consider the following definition of a TagKey:
58 - let Group, Element be the string representation of the
59 group and element dicom tag members,
60 - let ItemNumber be the string representation of the integer
61 index of the considered item number of a sequence,
62 Let the key of a tag embeded in a sequence, noted SeqTag, be
64 /ItemNumber#Group|Element
65 where "/", "#" and "|" are characters acting as separators.
66 Then the general form of a gdcmTagKey is given by:
68 where <SeqTag> means NO or many instances of SeqTag.
69 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
72 but the gdcmTagKey of a tag "embeded" is the first item of
73 a sequence, itself nested in the third item of a sequence is the
75 0004|1220/2#0008|0082/0#0008|0090
76 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
77 order to hold the new sequence compatible key. Previously, the
78 GetKey() method would look in the underlying gdcmDictEntry.
79 - src/gdcmDocEntry.cxx:
80 -- constructor now copies the underlying DictEntry key, in the local
82 -- ::Print: displays the member Key, instead of the (group, element).
83 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
84 - src/gdcmDocEntrySet.h:xi
85 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
86 -- now has a new BaseTagKey member.
88 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
89 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
91 This poses the problem with the semantics of the following lines
92 LoadEntryVoidArea(0x0028,0x1201); // R LUT
93 LoadEntryVoidArea(0x0028,0x1202); // G LUT
94 LoadEntryVoidArea(0x0028,0x1203); // B LUT
95 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
96 to the long FIXME note for what the problem is. Nevertheless in
97 order to get things working the dicom dictionary was altered !
98 Please fix things urgently...
99 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
100 information), see above note on moving the member VoidArea. Nevertheless
101 the following entries previously correctly set as US are now inproperly
103 0028 1201 OW IMG Red Palette Color Lookup Table Data
104 0028 1202 OW IMG Green Palette Color Lookup Table Data
105 0028 1203 OW IMG Blue Palette Color Lookup Table Data
106 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
107 of gdcmDocEntry moved to gdcmSeqEntry.
108 * src/gdcmSeqEntry.cxx: STYLE.
110 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
111 * Test/TestAllEntryVerify.cxx minor fix and added comments.
113 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
114 * gdcmPython/testSuite.py: all the test suite in python is now moved
115 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
116 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
117 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
119 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
120 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
121 to avoid inclusion recursion until STL is reached.
122 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
123 mecanism. errno.h is not included in gdcm anymore.
124 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
125 (gdcmFormatError now inherits from gdcmFormatUnexpected).
127 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
128 gdcmData/TestAllEntryVerifyReference.txt
129 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
130 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
131 exception_on_error parameter.
132 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
133 - vtk/vtkGdcmReader.cxx changed accordingly,
134 - Example/*.cxx and Test/*.cxx changed accordingly.
136 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
137 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
138 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
139 enable_sequences removed from gdcmHeader constructor and dependencies.
140 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
141 * gdcmPython/demo/PrintHeader.py: dummy fix.
142 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
143 skip_shadow removed from gdcmHeader constructor and dependencies.
144 * Example/*.cxx and Test/*.cxx changed accordingly.
146 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
147 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
148 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
150 2004-07-21 Jean-Pierre Roux
151 * FIX Now, Parsing and Printing a DICOMDIR do work!
152 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
154 2004-07-20 Jean-Pierre Roux
155 * FIX Some brain damaged headers have Zero-Lenght fields
156 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
158 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
159 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
160 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
161 variable (instance of gdcmDebug) by a definition macro, and the instance
162 is now in static in the gdcmDebug class
163 * src/gdcmSQItem.h : (FIXME) remove an undefined method
164 * Test/PrintAllDocument.cxx : bug fix in the result of the test
166 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * WARNING: ctest now depends more tightly on gdcmData. You should
168 check out gdcmData properly for things to run smoothly...
169 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
170 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
171 we need the pixels not be loaded in order to use the ValEntry
172 that displays position and size).
173 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
174 This is a C++ based equivalent of gdcmPython/testSuite.py that should
175 be deprecated. If you have any doubts about the advantages of a
176 modern scripting language (read Python) versus grass root C++ (i.e.
177 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
178 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
179 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
180 Anyhow, consider documenting the gdcmData images in
181 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
183 * Test/CMakeLists.txt:
184 - now uses TestAllEntryVerify.cxx
185 - specific comments on oldACR00001.ima (now renamed in gdcmData
186 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
187 gdcmData/TestAllEntryVerifyReference.txt
190 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
191 * src/*.[h|cxx] : typedef clean up
192 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
193 - TagKey renamed to gdcmTagKey (for external usage)
194 - VRKey renamed to gdcmVRKey (for external usage)
195 - removal of typedef duplication.
196 - Removed all unecessary inline keyword from class inline definitions.
197 - Some method|function(void) declarations replaced with method|function().
198 * src/jpeg/libijg12/jdhuff12.c:
199 - printf polluting ctest removed.
200 - TAB removal for comminting
202 - TestAllReadCompareDicom.cxx: added a test that compares all the
203 images in gdcmDataImages.h with corresponding images in
204 gdcmData/BaselineDicom/. When baseline images are not present
205 this test creates them.
206 Note: we need to validate each reference image, but before that
207 I'd like to rename them with a more explicit name...
208 - CMakeLists.txt: changed accordingly.
209 * Example/*.cxx: examples now only include gdcm.h (as opposed to
210 including each header needed).
212 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
213 * Test/*.cxx and Example/*.cxx: moved some examples away from the
214 test suite to the Example directory. Are concerned:
219 - TestWriteSimple.cxx
220 * Test/CMakeLists.txt: added some comments on reasons for black listing
221 image gdcmData/oldACR00001.ima
223 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
224 * Test/CmakeList.txt: removed the following from black list (to be coherent
225 with removal from gdcmData):
226 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
227 - gdcm-MR-PHILIPS-16.dcm
229 Added the following because after last cvs update, they cause
230 ctest -R TestReadWriteReadCompare
232 - gdcm-MR-SIEMENS-16-1.acr
234 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
235 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
236 new comments in this file) we temporarily (sigh) move to a weaker
238 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
239 we don't need to black list the following images anymore:
240 - 8BitsUncompressedColor.dcm
242 - US-PAL-8-10x-echo.dcm
243 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
244 fixes and the beautified code ;-)
245 This fixes the bug introduced in version 1.42 (when beautifying)
246 that made the parsing of 8BitsRunLengthColor.dcm unproper.
247 Note: ctest was blind to this bug (this means we need to still
248 improve the test suite). The bug could be detected by using
249 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
251 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
252 and by displaying the (garbage) produced file temp.XDCM...
254 2004-06-29 Jean-Pierre Roux
255 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
256 - replace by uggly but working old code :-(
257 A lot of things should be OK again.
258 It's really urgent to have a test suite that *tests*,
259 to prevent Frog's beautifying sessions to break all the stuff
260 (twice, withing a fortnigh ...)
262 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
263 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
264 redundancy) to added Test/TestReadWriteReadCompare.cxx
265 * Test/CmakeList.txt: because the compare test of
266 Test/TestReadWriteReadCompare.cxx fails, the following images are
267 black listed: - 8BitsUncompressedColor.dcm
269 - US-PAL-8-10x-echo.dcm
270 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
271 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
272 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
273 and ad-hoc kludge. This kludge is now removed, and on encountering
274 such an image (OB field brain damaged) we set errno. Then in
275 ::FindDocLength() we "fix" the length as being ALL what remains
276 in the file (until EOF). We then proceed, hoping for the best...
277 This fixes a SegFault in ShowDicom when trying to write such an
279 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
280 (because TestWriteRead breaks on it, after a non conformal commit?).
281 ctest now runs properly, except for MakeDicomDir (which was allways
282 broken) and the Python related stuff (still not fixed).
284 2004-06-24 Jean-Pierre Roux
285 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
286 FIX : Test/TestReadWrite now iterates on all the file names
287 (instead of infinite loop)
288 ENH : Test/TestWriteRead now iterates on all the file names
290 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
291 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
293 2004-06-24 Jean-Pierre Roux
294 FIX : - now Write drops LUT Descriptors and LUTs (if any)
295 when SamplesPerPixel =3
296 - now Write is no longer confused by
297 'BitsAllocated = 12" and 'BitsStored=12"
298 - "UN" value representation Elements are now written correctly
299 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
300 ENH : - now gdcmHeader has its own Write methods
301 (in order to split the job that has not to be done
304 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
305 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
306 loop on the same image until memory went out.
307 Note: this means we still have gobs of memory loss in PrintDocument
308 * src/gdcmDocument.cxx: fixes problem on parsing on file
309 gdcmData/16BitsJpegLosslessGrayScale.dcm.
311 2004-06-24 Jean-Pierre Roux
312 FIX : Write - All the Sequences and Sequence Item are now written
313 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
314 is added a the end, when necessary.
315 - A lot of brain-damaged images, that were read correctly are
316 now written correctly
317 - length compatible BinEntry are now loaded correctly
318 (even for odd groups)
319 Note : only Explicit Value Representation was checked.
320 (question : is implicit VR really necessary for gdcm ?)
322 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
323 * DEVELOPPER: added a proposition of coding style.
324 * src/gdcmDocEntry.h: removed every inline declaration (for test of
327 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
329 Use the gdcmDocEntry::Print() and Write() instead.
330 * src/gdcmDocument.cxx: bug fix.
332 2004-06-22 Jean-Pierre Roux
333 FIX : gdcmDocument.cxx
334 - Now we do recognize the JpegLossLess format (there was a misstyping in
335 code 'beautyfication' :-(
336 - Now we automaticaticaly load the Luts, if any
338 2004-06-22 Jean-Pierre Roux
339 In order : to write Sequences, whatever their imbrication level,
340 : to allow user to create his own Sequences
341 a lot of modif where necessary (adding, moving, or virtualising methods)
343 WARNING : save your own sources *before* cvs up !
346 ADD virtual void Write(FILE *fp, FileType filetype);
349 ADD virtual void Write(FILE *fp, FileType filetype);
350 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
353 ADD virtual void Write (FILE *fp, FileType filetype)=0;
354 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
355 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
356 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
357 ADD std::string GetEntryByName(TagName name);
358 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
360 std::string vr = "unkn",
361 std::string fourth = "unkn",
362 std::string name = "unkn");
363 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
364 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
365 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
366 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
367 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
368 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
369 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
370 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
373 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
374 ADD virtual std::string GetEntryByName (TagName tagName);
375 ADD virtual std::string GetEntryVRByName (TagName tagName);
376 REM virtual bool Write(FILE *, FileType);
377 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
378 FILE *_fp, FileType type);
379 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
380 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
381 REM virtual bool WriteEntries(FILE *_fp,FileType type);
382 REM virtual std::string GetEntryByName (std::string tagName);
383 REM virtual std::string GetEntryVRByName (std::string tagName);
384 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
385 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
386 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
388 std::string vr = "unkn",
389 std::string fourth = "unkn",
390 std::string name = "unkn");
391 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
392 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
393 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
394 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
397 ADD virtual void Write(FILE *fp, FileType filetype);
400 ADD virtual void Write(FILE *fp,FileType filetype);
403 ADD virtual void Write(FILE *fp, FileType filetype);
404 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
405 REM std::string GetEntryByNumber(guint16 group, guint16 element);
406 REM std::string GetEntryByName(TagName name);
409 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
411 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
413 The default constructor invoked by the line
414 gdcmHeader *f1 = new gdcmHeader( header );
415 was gdcmHeader::gdcmHeader(bool) instead of the expected
416 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
417 Hence the parsing wasn't executed... See also below.
418 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
419 as explicit constructor didn't do the trick to fix the above problem.
420 Could anyone explain why ?
421 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
422 properly calls gdcmValEntry::Print() (that was weed out from
423 code related to gdcmBinEntry).
425 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
426 * In order to fix memory leaks:
427 - Test/TestWriteSimple.cxx: added cleaning of free store through
429 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
430 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
431 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
432 (through the call to ::AddDicomDirMeta()) or the destructor
433 would crash when deleting uninitialized ::metaElems].
434 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
435 - src/gdcmDocument.cxx:
436 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
438 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
439 was causing memory leaks.
440 - src/gdcmSQItem.cxx:
441 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
442 cleanly handled with polymophism: sorry but my milage is low).
443 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
444 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
445 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
446 This avoids SegFaulting.
447 - src/gdcmSQItem.h: coding style.
449 - Test/TestWriteSimple still severely sucks. The output image content
450 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
451 damaged when displayed with vtkgdcmViewer.
452 - on memory leaks: TestWriteSimple leaks really less (see entry
453 of 2004-06-18 in Changelog file for the call to valgrind).
454 - on segfaults: ctest now passes all the tests but one (no more
456 * Erroneous leading white fix:
457 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
458 white[s] (as opposed to from >> xxx, that removes it [them].
459 - src/gdcmTS.cxx: ditto.
460 - gdcmPython/testSuite.py: dirty related kludge removed.
461 * src/*: remaining references to gdcmParser removed.
462 * src/*[cxx|h]: added copy[way]left header.
465 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * In order to fix writing of dicom files:
467 - Test/TestWriteSimple.cxx: a simpler example of writing.
468 - Test/CMakeLists.txt changed accordingly.
469 - src/gdcmDocument.cxx:
470 -- The destructor now recursilvely removes potential sequences.
471 -- Bug fix in ::IsJPEG2000()
472 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
473 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
475 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
476 to only declared) and build on top of
477 ::GetDocEntryByNumber(guint16, guint16).
478 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
479 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
480 for usage in destructor and treatement of promotion in
481 ::ReplaceOrCreateByNumber().
482 - src/gdcmSQItem.cxx: destructor should better handle his job.
483 Test/TestWriteSimple now runs (or at least it DOES something).
484 * We can now start hutting memory links. A good starting point is:
485 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
486 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
487 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
489 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * Valgrind note: after Mathieu Malaterre teached me how to read
491 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
493 Using gcc, you can force the STL to use malloc and to free memory as
494 soon as possible by globally disabling memory caching.
495 With 3.2.2 and later, you should export the environment variable
496 GLIBCPP_FORCE_NEW before running your program.
497 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
498 simply vanish (it is still not clear to me, whether this means that
499 STL std::string leaks or if valgrind believes it leaks...).
500 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
501 running bin/gdcmTests makeDicomDir):
502 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
503 - Test/makeDicomDir.cxx now properly traps empty lists and returns
505 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
506 SegFaulting (I drowned in DicomDir related code when trying to
507 understand why the list is empty...).
508 * src/gdcmDocument.h: first BSD license header try.
509 * Doc/License.txt added.
511 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * src/gdcmDocument.[h|cxx]:
513 - Clean up of the Transfer related predicates. They are now all based
514 on new method isGivenTransferSyntax, that (should) handle properly
516 - general clean up, simplification, and coding style.
517 - Specific clean up of Parse7FE0() (umproperly named actually).
518 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
520 2004-06-14 Jean-Pierre Roux
522 - fix the display of Sequence Delimitor (SQDepthLevel pb)
523 - fix the display of SQItem ordinal number
524 - add the GetSQItemByOrdinalNumber method
525 - remove some useless never written private methods
527 2004-06-14 Jean-Pierre Roux
529 - adding a constructor taking a gdcmDocEntry as an input param
530 - ReplaceOrCreateByNumber now returns :
531 a gdcmBinEntry * if a Binary (void *) value is passed as a param
532 a gdcmValEntry * if a string value is passed as a param
534 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
535 according to the param type (no longer sets a gdcmDocEntry)
536 - GetValEntryByNumber, GetBinEntryByNumber added
537 - NewValEntryByNumber and NewBinEntryByNumber added
539 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
541 - GetSQItemNumber and SetSQItemNumber added, to provide
542 a (relative) Item identier inside a given Sequence
543 \warning : some pb remaining around this number
545 - AddEntry now takes the Item Number as a param
547 - adding a constructor taking a gdcmDocEntry as an input param
549 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
550 * Memory leak hunt with the following command:
551 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
552 --show-reachable=yes gdcmTests PrintDocument
553 It looks like many (all?) leaks are due to the STL (or a bad usage
554 of the STL. The lines producing the leaks now have a comment with
555 a "MEMORY LEAK" tag: you can retrieve them with
556 grep "MEMORY LEAK" src/*
557 Here are two typical examples which I can't help fixing:
562 char * test = "babo";
563 name = test; //// <--- valgrind detects 960 bytes lost in
564 //// call to std::string::operator=(char const*)
565 name.clear(); //// Doesn't help !
573 std::cout << "Type a bunch of characters followed by RETURN: ";
574 getline(std::cin, line); //// <--- valgrind dectects a loss
575 //// of 1320 bytes in call to
576 /// std::basic_istream<>& std::getline<>
582 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
583 * src/gdcmHeader.[cxx|h]:
584 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
585 and related, moved away to gdcmDocument.
586 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
587 the corresponding protected accessors of inherited class
588 gdcmDocument, removed ! As a consequence gdcmFile had to be
589 declared friend of class gdcmDocument (see below).
590 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
591 - Clean up of undefined or unused methods.
592 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
593 account the changes to gdcmHeader.h).
594 * src/gdcmDocument.h:
595 - gdcmFile is now a friend class (in order to take into account the
596 changes to gdcmHeader.h).
597 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
598 (see changes to gdcmHeader.h).
599 - Accessors (reading on the form GetEntry*) are now public.
600 - Clean up of undefined or unused methods.
601 * src/gdcmDocument.cxx:
602 - adaptation to changes to gdcmDocument.h
603 - ::OpenFile now writes a verbose message when file cannot be opened.
604 - some std::string properly set to VRKey
605 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
606 references to gdcmDocument.
607 * Test/TestFindTags.cxx: changed accordingly to above changes.
608 * gdcmPython/testSuite.py: adapted to renaming of acr files in
609 cvs repository gdcmData.
611 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
612 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
613 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
614 conflicts with gdcmValEntry::voidArea.
615 * src/gdcmValEntry.cxx: unmatching comment wiped out.
616 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
617 Value representation between StringRepresentable and BinaryRepresentable.
618 * src/gdcmDocument.cxx:
619 - method ParseDES: proper indentation restored and usage of
620 gdcmVR::IsVROfGdcmStringRepresentable wired in.
621 - method LoadDocEntry: the fingerprint left in the SetValue() of
622 unloaded entries (length > MaxSizeLoadEntry) had curiously been
623 removed. Reverting to previous code segment with the proper
624 dynamic_cast< gdcmValEntry* >.
625 Note: this was (partially) breaking the python test suite
626 (gdcmPython/testSuite.py) that made usage of the above
627 fingerprint to check presence of "Pixel Data".
628 * src/gdcmDocEntry.h: coding style.
629 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
630 now taken into account.
631 * gdcmPython/gdcm.i: adaptation to the new internal representation
632 of gdcm (exit gdcmParser, hello gdcmDocument).
633 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
635 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
636 anymore, but instead prints the loaded Python dictionary.
637 * .... alas, the python testSuite is still broken.
639 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
640 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
642 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
643 * src/gdcmUtil.h : export methods
645 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
646 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
648 * Initial addition of automatic python testing
649 * Initial addition of automatic image comparison
651 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
652 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
653 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
655 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
656 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
657 * Test/ShowDicom.cxx : bug fix for msvc compilation
658 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
660 2004-05-04 Jean-Pierre Roux
661 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
662 new concepts (and new classes) :
663 a 'gdcmDocument' is composed of a set of Doc Entries, that are
664 - elementary gdcmDocEntries (former gdcmHeaderEntries)
665 - Sequence Doc Entries (gdcmSeqEntries)
666 a Sequence is composed of Items.
667 Each item is a set of Doc Entries (this is recursive)
668 The non uniqueness of the 'Dicom tag' is due to this recursivity
669 (never taken into account)
670 Our unability to add a new 'entry' in the header
671 at the proper location (neither in the H-Table (map or multimap),
672 nor in the Chained List is also due to this recursivity.
673 Don't try, right now, to use/modify/compile these new sources :
675 We just commit all the stuff, 'as is', in order not to loose it.
677 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
678 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
680 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
681 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
682 file prefix (SetFilePrefix)
684 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
685 * Add a new test: ShowDicom, for now this is just the c++ version of
686 checkRead.sh, later it will be able to compare the image read against a
688 * Replace the DEBUG on the stack with a global entry in cmake interface:
689 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
691 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
692 * Add an example subdir, with a real example on how to read + write a
695 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
696 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
697 * Doc/CMakeLists.txt: the main page is now properly differentiated
698 between the developper and user version.
699 * Doc/doxygen.config.in: dropped search related obsolete flags
700 * src/gdcmParser.h, gdcmHeader.h: doxygenation
702 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
703 * DEVELOPPER: added some helpfull comments for compile/test/install
706 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
707 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
708 src directory, now generated in the build dir.
709 2. Tests as mentionned smarter
711 4. Add a new method in gdcmDict that return the PubDict by name
712 this is interesting for 3rd party lib like ITK,
713 where we could set the institution name / patient name...
715 * ENH: 1. Now the test suite is working for real
716 2. All binaries are now output in the gdcm-bin directory
717 (this was not true before)
719 2004-04-28 Jean-Pierre Roux
720 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
721 SeQuence indented printing of Dicom Header.
722 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
723 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
724 Computation of SQDepthLevel is now part of gdcmHeader constructor
725 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
726 tree-like structure of a Dicom Header.
727 * FIX Test code cleaning
729 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
730 * ENH: Adding automatic testing
731 1. Need a DartConfig.cmake to submit to public
732 2. Add a test driver gdcmTest.cxx
733 3. gdcmTestMain, an helper for the main test driver gdcmTest
734 4. Files in Test don't have a main anymore, this becomes interesting
735 when we add more and more tests, thus dsw don't have to load
737 * ENH: Adding a GDCM_DATA_ROOT for testing
738 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
739 one file instead of seven + some small cleanup
741 2004-04-22 Jean-Pierre Roux
742 * ENH Minor changes to the Print() methods.
743 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
744 Header printing. Example given with :
745 > PrintHeader fileName 2 new
746 (SQ based tree-like structure still to be done for the Header ...)
748 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
749 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
750 1. I have added some unsigned where needed
751 2. Some function parameter not used -> (void)
752 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
753 4. g++ don't like character '\' in comment
754 5. #define jpeg_create_decompress jCreaDecompress
755 this really need to be fixed
756 6. virtualize destructor of gdcmObject ... leakage
757 7. sscanf(g->first.c_str(),"%x",&gr_bid);
758 this also really need to be fixed
759 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
760 remove compression file
761 (as we only do decompression, right ?)
762 * ENH: Change malloc/calloc/free with c++ equivalent
764 2004-04-21 Jean-Pierre Roux
765 * FIX gdcmHeaderHelper::GetXSpacing
766 when a single value is found (bug ?), xpacing is now
767 defaulted to yspacing
769 2004-04-19 Jean-Pierre Roux
770 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
771 * ENH add parameters :
772 bool exception_on_error = false,
773 bool enable_sequences = false,
774 bool ignore_shadow = false
775 to the gdcmFile constructors to be full gdcmParser compliant
776 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
777 to allow reading of PAPYRUS 3.0 files
779 2004-04-06 Jean-Pierre Roux
780 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
782 2004-04-02 Jean-Pierre Roux
783 * ADD : Test/checksequence.sh, for a general recap on SQ pb
784 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
785 for Philips spurious Tag fffe|0000 while rewritting Dicom files
787 2004-03-30 Jean-Pierre Roux
788 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
789 for ACR file, written out as DICOM files (hope so...)
791 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
792 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
793 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
794 moved to base class gdcmParser and only the specialisation is kept
796 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
797 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
798 already does the job.
799 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
800 (to be consistent with gdcmParser::WriteEntries).
802 2004-03-30 Benoit Regrain
803 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
804 upate of the object's instance. It's passed to 2 in the unfavorable
805 case : one in the ExecuteInformation, one in the ExecuteData
807 2004-03-29 Jean-Pierre Roux
808 * ENH : Check on file type to be written moved
809 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
810 * FIX : gdcmObject::ResetBoundaries now stops properly
811 when end-of-list is reached
812 : gdcmVersion modified (as Benoit Regrain asked)
814 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
815 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
816 * src/gdcmUtil.cxx: added forgotten iostream include.
817 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
818 equivalent to ExplicitVR in existing code).
820 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
821 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
822 now contains all the gdcmGlobal related code.
823 * minor coding style and doxygenation changes.
825 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
826 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
827 now contains all the Debug related code.
828 * minor clean-up of includes in src/*.cxx
829 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
830 CreateCleanString) removed.
831 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
832 * Doc/DoxyMainPageUser.txt added.
833 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
834 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
837 2004-03-24 Jean-Pierre Roux
838 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
840 2004-03-23 Jean-Pierre Roux
841 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
842 big endian made volumes
843 * ENH Now gdcmParser constructor and destructor are protected to forbid
844 end user to instanciate class gdcmParser
845 (only gdcmHeader and gdcmDicomDir are meaningfull)
847 2004-03-22 Benoit Regrain
848 * FIX : src/gdcmDicomDir.cxx : make windows compilable
849 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
850 gdcmSerie to gdcmDicomDirSerie
852 2004-03-19 Jean-Pierre Roux
853 * ENH Now the tree-like structure describing a DICOMDIR comming from
854 an already existing DICOMDIR file is consistent with
855 the home-made tree-like structure build ex-nihilo
856 or build from the files held (recursively) in a Directory
857 functions gdcmDicomDir::CheckBoundaries()
858 gdcmObject::SetBoundaries() added
860 2004-03-17 Jean-Pierre Roux
861 * REM (Eric Boix bug) : removal of meaningless
862 gdcmDicomDirImage::NewImage function.
863 * FIX now file names and directory name are written properly in the
865 * FIX now gdcmDicomDir constructor may be call without any trick
868 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
869 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
870 of gdcmDicomDirImage::NewImage as empty function.
872 2004-02-28 Jean-Pierre Roux
873 * ENH add gdcmDicomDir:NewPatient
874 add gdcmDicomDirPatient:NewStudy
875 add gdcmDicomDirStudy:NewSerie
876 add gdcmDicomDirSerie:NewImage
877 to allow making gdcDicomDir object.
878 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
879 (as opposite to the gdcmHeader chained list)
881 2004-02-11 Benoit Regrain
882 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
883 when using from python
885 2004-02-10 Benoit Regrain
886 * FIX : bug fix in the gdcmDirList for the recursivity in directories
887 * FIX : in gdcmDicomDir when the directory is empty
888 * ENH : add callback and methods to get the progression of dicomDir
891 2004-02-06 Jean-Pierre Roux
892 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
893 - GDCM_META added to gdcmDicomDirType
894 - class gdcmMeta created
895 * ENH : - A brief summary is now displayed at the beginning of
896 'testDicomDir' to help disaster magnitude estimation
897 * REM : Now useless Test/explDICOMDIR.cxx
899 2004-02-05 Benoit Regrain
900 * ENH : add methods in gdcmObject to get the hash table or the list of
902 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
903 * FIX : wrapping python for TagHeaderEntryHT
905 2004-02-04 Benoit Regrain
906 * FIX : even length for some strings when writting the dicom dir
907 * FIX : sort the images in the dicom dir
908 * FIX : Bug fix for python use of dicom dir
909 * ADD : a python demo
911 2004-02-04 Jean-Pierre Roux
912 * FIX : Final solution (?) for icone embedded images
913 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
914 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
915 add groups 6002, 6004, 6006, to allow 'clean' parsing of
916 gdcmData/gdcm-MR-SIEMENS-16.acr1
917 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
918 to make full checking easier
920 2004-02-04 Benoit Regrain
921 * FIX : WriteEntries : coding style & logic in parameters
922 * FIX : Set the elements to create the DicomDir in a dictionary file
924 2004-02-03 Benoit Regrain
925 * gdcmDirList : to parse a hard drive directory in recursive (or not)
926 * gdcmDicomDir : add the load of directory
927 * Bug fix and print add-on
929 2004-02-03 Jean-Pierre Roux
930 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
931 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
932 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
933 * FIX gdcmParser.cxx : 'group length' elements are now considered
934 as integers, even for shadow groups, when file is Implicit VR
936 2004-02-02 Jean-Pierre Roux
937 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
939 of the last synonym :-(
940 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
942 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
943 * FIX taking into account the possible 7fe0,0010 multiplicity
944 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
945 to allow removal of references to 7fe0,0010, to deal with
946 ACR-NEMA images, when 0028,0200 is meaningfull
948 2004-01-31 Jean-Pierre Roux
949 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
950 no longer writes 'Un' on disk
951 * FIX SQ elements with actual length are now dealt with corectly
952 * FIX gdcmFile::WriteBase make the difference, for color images, between
953 the length (for Palette expanded images)
954 and Raw Length (non expanded image + Palette)
955 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
956 (that broke Write). Replaced by UL.
957 Aware user will reload the field if he
958 thinks it's necesssary
960 2004-01-30 Jean-Pierre Roux
961 * gdcmParser::CheckSwap() now defaults the filetype to ACR
962 when 'dirty Acr' is found, to be compliant with the new
963 IsReadable() methods.
965 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
966 (no DOUBLE images in kosher DICOM,
967 but so usefull for people that miss them ;-)
969 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
970 DICOMDIR related utilities (not checked as Windoze compliant)
972 2004-01-28 Jean-Pierre Roux
973 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
975 2004-01-27 Jean-Pierre Roux
976 * gdcmParser constructor has a new boolean param,'ignore_shadow',
977 to allow skipping the shadow elements, to save memory space.
978 The TRUE value for this param has to be used
979 with a FALSE value for the 'enable_sequence' param.
980 ('public elements' may be embedded in 'shadow Sequences')
981 * gdcmHeader methods now deal with 'embedded icones images' in the header
982 (even when an 'icone image sequence' is announced by the
983 element (0x0088,0x0200), but there is NO icone at all ...
985 * gdcmHeader sometimes Image Location value doesn't follow
986 the supposed processor endianity (see gdcmData/cr172241.dcm).
989 * gdcmHeader add the method
990 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
991 to get *all* the Header Entries with the same tag.
992 GetHeaderEntrySameName is probabely *useless*
993 (no meaning : Name is *not* an identifier within the Dictionnary)
995 2004-01-26 Benoit Regrain
996 * Bug fix in the print of hexadecimal representations. Remove long fields
997 in the print and add a third level of print to print them
999 2004-01-23 Benoit Regrain
1000 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1001 * Bug fix on test suite after remove the strip made on not string fields
1002 * Split the IsReadable method between gdcmParser which test that the file
1003 is dicom and gdcmHeader which test that it's an image file
1005 2004-01-22 Benoit Regrain
1006 * DicomDir : clean code, add methods, set variables in protected or private
1007 * gdcmUtil : bug fix for the clean string method
1009 2004-01-19 Benoit Regrain
1010 * Add the use of shadow dictionaries
1011 * bug fix and coding style
1013 2004-01-19 Benoit Regrain
1014 * src/gdcmFile.cxx : bug fix concerning the close of file
1015 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1016 * Add the update of header entries using the shadow library
1018 2004-01-19 Benoit Regrain
1019 * removal of file gdcmHeader2.cxx
1020 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1021 inheriting from gdcmParser. This split is to prepare the integration
1022 of dicom dir parsing
1023 * bug fix under python
1025 2004-01-16 Jean-Pierre Roux
1026 * REM removal of class gdcmHeaderEntrySet
1027 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1028 * ADD add file gdcmHeader2.cxx
1029 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1031 2004-01-15 Benoit Regrain
1032 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1033 entries created while parsing the header. Thus, they will be destroyed
1034 when the gdcmDictSet will be destroyed
1035 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1038 2004-01-15 Benoit Regrain
1039 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1040 made a fatal error because of the memory release at the end of program.
1041 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1042 some memory and vtk seems to have some problems with that.
1043 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1045 2004-01-14 Benoit Regrain
1046 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1047 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1048 * src/*.[h|cxx] : make changes due to class name changes
1049 * gdcmPython/demo/*.py : bug fix due to method names
1051 2004-01-13 Benoit Regrain
1052 * src/*.[h|cxx] : coding style
1053 * vtk/*.[h|cxx] : coding style
1055 2004-01-13 Benoit Regrain
1056 * gdcmPython/testSuite.py : test the readable flag of file for tests
1057 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1058 It's lied to the stl compilation by MSVC (windows, always windows...)
1059 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1061 2004-01-12 Benoit Regrain
1062 * src/*.h : add comments
1063 * src/gdcmDictSet.h : set the method BuildDictPath in public
1064 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1065 directly setted in the source code
1066 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1069 2004-01-09 Benoit Regrain
1070 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1071 * setup.py : use a reference to gdcmVERSION
1073 2004-01-07 Benoit Regrain
1074 * Modification to compile with the distutils.
1077 2003-12-10 Benoit Regrain
1078 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1079 can use a gdcmHeaderHelper to load datas
1080 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1081 made in the source code
1083 2003-12-10 Benoit Regrain
1084 * Update Windows projects and .cvsignore files
1086 2003-11-12 Jean-Pierre Roux
1087 * ENH gdcmHeader constructor has one more parameter (default value : false)
1088 that allows the user to 'go inside' the SeQuences only
1090 gdcmElValSet:Print takes it into account
1092 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * ENH: Update gdcmPython/CMakeLists
1094 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1095 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1097 2003-11-10 Jean-Pierre Roux
1098 * FIX : gdcmHeader::LoadElements is now based
1099 on the ListTag listElem member,
1100 not longer on the TagElValueHT tagHt member
1101 * ENH : PrintPubElVal shows (temporarily) both results,
1102 with the tagHt member and the listElem member.
1103 (it's easier to 'see' the problems when using Printheader)
1105 * FIX : old private member LgrElem is now splitted into
1106 ReadLength : Length actually found on disk (updated only
1107 if bug fixing is necessary), for internal
1109 UsableLength : Updated by FixFoundLength, to fix a bug
1110 or to allow Parser going on.
1111 Will allow to re-write a kosher header when a SeQuence
1112 with a length (not 0000) is found
1113 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1114 because gdcmElValSet::Add does not update ListElem
1117 2003-11-07 Jean-Pierre Roux
1118 * FIX misstyping in Transfert Syntax name table
1119 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1120 when they have an actual length (not 0000 nor FFFFF)
1121 (Nobody should care of it, but DICOMDIR explorers)
1123 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1124 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1126 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1127 * ENH: vtkGdcmReader now supports LUT !
1128 (vtkgdcmViewer for now is not able to use them though)
1130 2003-11-05 Jean-Pierre Roux
1131 * in testSuite.py : new files names for checking the package
1132 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1133 that returns the pixel area size to the *aware* (vtk) user
1134 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1136 2003-11-05 Benoit Regrain
1137 * in testSuite.py : Modify the rules for checking the paths
1138 : Explicit error messages
1139 * in __init__.py : Related modif
1141 2003-11-03 Jean-Pierre Roux
1142 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1143 to be used by aware (vtk) users that want to manage
1144 LUT (and no to turn the PALETTE image into an RGB pixels one)
1145 * GetPixelType now returns 8U for 24 Bits images
1146 (vtkGdcmReader compliant)
1148 2003-10-31 Jean-Pierre Roux
1149 * Removal of *all* gdcmData images and add them again
1150 in order to loose the 'history' of un-anonymised images
1152 2003-10-31 Jean-Pierre Roux
1153 * RMV : removal of useless jBitsInJsample.h
1154 for both 8 and 12 Bits JPEG Lossy Libraries
1156 2003-10-31 Jean-Pierre Roux
1157 * ENH : Add the functions gdcmFile::GetImageDataRaw
1158 gdcmFile::GetImageDataIntoVectorRaw
1159 that act as GetImageData and GetImageDataIntoVector
1160 except the making of an RGB Plane from Gray Plane + LUT
1161 Intended to aware (vtk) users who know how to manage
1164 GetLUTRGBA return a R,G,B,A LUT if any
1165 lgrTotaleRaw gives the 'Raw' length
1166 GetImageDataRaw returns the gray Plane
1167 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1168 (They stay Grey, just like with other Dicom viewers :-(
1170 2003-10-30 Jean-Pierre Roux
1171 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1173 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1174 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1175 being coherents dicom files.
1177 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1178 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1180 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1181 * ENH: Two steps is necessary to please VC++ compiler...
1182 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1183 * ENH: Add include dir to medcon lib
1184 * FIX: only one function is being exported for now !
1185 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1187 2003-10-29 Jean-Pierre Roux
1188 * adding gdcmHeader::GetLUTRGBA
1189 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1190 --> Mathieu, the modif u're waiting for is not yet committed
1191 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1193 2003-10-27 Jean-Pierre Roux
1194 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1195 00191113.dcm DermaColorLossLess.dcm
1196 MxTwinLossLess.dcm RadBWLossLess.dcm
1197 * ENH: For version prior to vtkImageViewer2 -r 1.19
1198 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1200 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * Removal of ido stuff in CMakeLists.txt
1203 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1204 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1205 * FIX: remove a call to ->Modified ... see comments
1206 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1208 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1209 * FIX: Problem with path for libvtkgdcmPython
1210 * ENH: Try adding a search script for python site-package
1211 * RMV: Remove some file from medcon lib that are not necessary
1212 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1213 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1214 * FIX: More pragma disable fro VC++,
1215 I don't think I break something as it is also disable in VTK/ITK.
1216 But it fasten debug compilation time.
1218 2003-10-23 Jean-Pierre Roux
1219 * gdcm now deals with 16 Bits Run Length Encoded images
1220 (they are compressed as 2 planes images,
1221 one for the high Bytes, the other for low Bytes)
1223 2003-10-22 Jean-Pierre Roux
1224 * Now CheckRead takes into account :
1225 - the bugged 'Leonardo' Siemens images
1226 - the XA images, sent thru the burning VPRO station
1227 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1230 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1231 * FIX: When copying a Makefile.am to CMakeLists.txt
1232 one should remove the '\'
1234 2003-10-22 Jean-Pierre Roux
1235 * in gdcmData adding a bugged 'Leonardo' Siemens image
1236 (wrong lengths in header)
1237 OK with gdcm, KO with the other viewers :-)
1238 * add a GE dlx XA image, thru the VEPRO burning station
1241 2003-10-21 Jean-Pierre Roux
1242 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1243 for a brutal checking of vtkgdcmViewer compliance
1245 2003-10-21 Jean-Pierre Roux
1246 * add the files for 'xmedcon' Jpeg Lossless library
1247 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1249 2003-10-21 Jean-Pierre Roux
1250 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1252 2003-10-21 Jean-Pierre Roux
1253 * garbage Siemens 'Leonardo' images dealt with
1254 (the patch is easy to remove)
1255 * cosmetic changes to avoid warnings
1257 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1258 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1259 no need to press 'r' now.
1261 2003-10-20 Jean-Pierre Roux
1262 * upgrade of checkRead.sh checkWrite.sh according
1263 to new Jpeg Lossless decompressor
1264 * add US.3405.1.dcm, a genuine RGB medical file ...
1265 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1266 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1268 2003-10-15 Jean-Pierre Roux
1269 * general anonymisation in gdcmData
1270 * adding the 'color files' from
1271 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1272 * adding some well knowed bugged-header images
1273 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1274 waiting for their inclusion in Python testsuite
1276 2003-10-15 Jean-Pierre Roux
1277 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1278 no longer seg faults when file is not found
1280 2003-10-14 Jean-Pierre Roux
1281 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1284 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1285 * TODO: *.in file to genereate a UseGDCM later
1287 2003-10-14 Jean-Pierre Roux
1288 * Some supposed-to-be Dicom Images have no preamble.
1289 OpenFile takes it into account
1290 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1291 * Missing elements added in dicomV3.dic
1292 (just to be affraid : have a look at
1293 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1294 and do it again next year ;->
1296 2003-10-13 Jean-Pierre Roux
1297 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1298 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1299 But there are NOT. It's fixed !
1301 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1302 * FIX: "jpeglib.h" was not found on VC++
1303 * FIX: vtkgdcm was not being installed
1305 2003-10-10 Jean-Pierre Roux
1306 * ENH : OpenFile closes the file if it *really* doesn't look like
1307 an ACR-NEMA / DICOM one.
1308 * FIX : testWrite no longer writes an empty file if the source file
1309 is not gdcm Readable
1310 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1313 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1314 * FIX: CMake generate now documentation
1315 * ENH: out of source doc build !
1316 * ENH: Generate both user and dev documentation
1317 * ENH: Should work on windows too
1318 * ENH: Only one doxygen config.in file is needed
1319 * FIX: make install should be ok now on ùnix plateform
1320 * FIX: PATH to dictionary was wrong (missing /)
1321 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1323 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1324 * vtkGdcmReader is now able to read rgb dicom file.
1325 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1326 * added a gdcmViewer to vtk test, use mouse to control
1327 window level & window width
1329 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1330 * CMake-ification of gdcm, we have now two build system
1331 * FIX: on cygwin Wsock32 doesn't exist
1332 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1334 2003-10-06 Emanuel Ollart
1335 * FIX : compilation process wad broken.
1336 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1338 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1339 * change gdcmViewer -> vtkgdcmViewer
1340 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1342 2003-10-06 Jean-Pierre Roux
1343 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1344 ( e.g : well known GE images with a wrong elem length,
1345 : Philips MRI Images with a wrong Huffman table)
1346 * still to be done : allow the reading of bugged LEONARDO Siemens images
1348 2003-10-03 Jean-Pierre Roux
1349 * Odd length strings are padded with '\0' (not with spaces,
1350 to remain compliant with already defined strings,
1351 like Transfert Syntax UID and others)
1353 2003-10-03 Jean-Pierre Roux
1354 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1355 to allow displaying RGB images (not only by affim ;-)
1357 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1358 * vtkGdcmReader is now able to read rgb dicom file.
1359 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1361 2003-10-03 Jean-Pierre Roux
1362 * A few nasty patches to allow the reading of a lot of nasty images
1363 ( e.g : well known GE images with a wrong elem length,
1364 : Philips MRI Images with a wrong Huffman table)
1365 * still to be done : allow the reading of bugged LEONARDO Siemens images
1367 2003-10-03 Jean-Pierre Roux
1368 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1370 2003-10-03 Jean-Pierre Roux
1371 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1372 to allow displaying RGB images (not only by affim ;-)
1374 2003-10-03 Jean-Pierre Roux
1375 * gdcmFile::GetImageDataIntoVector now
1376 - deals with MultiFrames MultiFragments Run Length Encoded files
1377 - deals with YcBcR (YBR_FULL) files
1378 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1379 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1381 (no sample found :-(
1383 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1384 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1385 Two reasons: - clear things
1386 - third parties acces gdcm through header files, so won't
1387 suffer anymore VC++ complains
1389 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1390 * add argv[1] in testvtkGdcmReader.cxx
1393 2003-09-24 Jean-Pierre Roux
1394 * The lines are now eigthy characters long.for
1395 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1397 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1398 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1399 char* to std::string. Thus, the use of strdup becomes useless. (see
1400 previous commis of Malaterre)
1401 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1402 before the last Malaterre's commit.
1404 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * This commit should fix the Debug building under VC++, the problem
1406 was mainly a mixture of debug and release lib being loaded at startup.
1407 * I also remove a depency to a specific C function: strdup. Because I had
1408 to force the link to msvcrtd (whereas strdup is in libc).
1410 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1411 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1412 located in the gdcmCommon.h file. All use of reference of tha has been
1413 changed to now use the variable GDCM_UNFOUND.
1415 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1417 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1418 Dicom dictionary. The test suite can now be run again. Note:
1419 I'm note very happy with the " (RET)" changes. I believe this
1420 RETAINED comment should be dropped when parsing the dictionary.
1421 - PACKAGER corrected
1423 - AUTHORS updated and now in alphabetical order
1424 * Makefile.am now exports gdcm.dsw for Windoze users.
1426 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1427 * cygwin complains about missing std:: in subdir Test/
1429 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1430 * remove some methods that are now in gdcmHeaderHelper
1432 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1433 * vtkGdcmReader set spacing and origin correctly
1435 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1436 * Fix a few delete/delete[] mismatch
1438 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1439 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1440 interpretation to data given by gdcmHeader. For instance there are
1441 heuristics to get informations (look at different places).
1442 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1443 sorting DICOM images based on different strategies.
1444 * modified Makefiles accordingly.
1446 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1447 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1448 when building in debug mode
1449 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1450 src/win32/gdcmdll.dsp
1451 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1453 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1454 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1457 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1458 * src/win32/libgdcmjpeg12.dsp was not dos format
1459 * src/win32/libgdcmjpeg12.dsp :
1460 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1461 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1463 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1464 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1466 * src/gdcmFile.cxx : bug fix in affectation type
1467 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1468 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1469 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1470 symbols... future problem ?
1472 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1473 * src/win32/libgdcmijpeg12.dsp was missing
1474 * modified gdcm.dsw accordingly
1476 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1477 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1479 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1480 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1481 commit of JPR (before his hollidays to facilitate our work).
1482 * setup.py : bug fix in code. Modifications made while the last commit
1483 of JPR. The code hasn't been tested before the commit... it's so
1484 useless to make that (for best programmer that is JPR) !!!
1486 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1487 * tagged the current version as Version0_3 (i.e. version 0.3)
1489 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1490 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1491 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1492 * *.dsp : modifications to use new libgdcmijpeg8 library
1493 * setup.py : bug fix on VTKPATH variable
1494 * PACKAGER : adding all concerning windows
1496 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1497 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1499 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1500 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1501 test suite reported error.
1502 * PACKAGER file added (describes what a packager must do when
1503 packaging a new release).
1504 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1505 * configure.in: upgraded version number to 0.3.0
1506 * fixing build of rpm (through rpm -ta):
1507 - Doc/Makefile.am exports proper doxygen files
1508 - src/jpeg/libijg8/Makefile.am exports the include files.
1510 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1511 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1512 * src/gdcmHeader.h : formatting code
1514 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1515 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1516 We were obtaining error message from vtk. Now, creation of file list
1517 is made in an internal list to prevent this problem.
1518 Bug fix when output is empty.
1519 Bug fix in update of progress value. Previous commit for this was a bad
1521 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1523 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1524 * src/gdcmHeader.h : added method to get the file name
1525 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1526 files. Added method to remove all files on the input
1527 Added FIXME comment concerning the bad parsing of header made by
1528 ExecuteInformation method (in ExecuteData method)
1530 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1531 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1532 when using make instal.
1533 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1534 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1536 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1537 * setup.py : adding include dir of jpeg lib to compile all sources
1538 * */Win32/*.dsp : JPR fix for windows compilation
1540 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1541 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1543 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1544 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1546 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1547 * setup.py is again effective on un*x (takes into account the
1548 addon of the jpeg library)
1549 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1550 * Doc/Doxy* updated (includes above enhancements)
1551 * INSTALL now points to web documentation
1553 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1554 * src/gdcmHeader.h doesn't make unnecessary reference to
1556 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1558 * src/gdcm*.[cxx|h] :
1559 - to allow compilation with gcc 3.x
1560 -- clean up of STL usage (added explicit usage of std::)
1561 -- small fixes on exceptions.
1562 Note: linking not tested !
1563 - clean of doxygen comments to avoid warnings at documentation
1565 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1566 dependent convertion).
1568 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1569 * Clean up of previous JPR garbage commit (not even commented in the
1571 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1572 - moved all jpeg related files from src to src/jpeg/libijg8, with
1573 addition/modification of Makefile.am and configure.in.
1574 - the testSuite is still brain damage (not guilty).
1576 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1577 * WrapVTK.py : modifications to get correctly vtk source files to
1579 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1580 (FileName -> Filename)
1582 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1583 * vtk/vtkGdcmReader.[cxx/h]:
1584 - UpdateProgress method should now be effective
1585 - removed the limitation on having only images loaded (as opposed
1587 - when building a stack of images/volume, a lesser number of
1588 gdcmHeader and gdcmFile instances should be used (hopefully
1589 accelerating things).
1590 - when building a stack of images/volumes, files which are not
1591 loadable (wrong path-filename, wrong permissions on existing file,
1592 or file not parsable by gdcm) are replaced with a black image
1593 in the stack (for the caller to notice the problem).
1595 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1596 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1598 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1599 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1600 between standard library (std) and vtk library (problems are found
1601 under Windows... thanks Windows !)
1603 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1604 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1606 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1608 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1609 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1611 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1612 * When compiling with distutils (see setup.py) the C++ compiler is
1613 called with different flags than the default ones (with automake).
1614 In order to fix all those warning, I compiled gdcm with the command
1615 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1616 and went for warning fixes:
1617 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1618 up from unused variables.
1619 - vtk/vtkGdcmReader.cxx: potential bug fix.
1620 * src/gdcmHeader.h: Doxygen warning cleanup
1622 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1623 * gdcmPython/gdcm.i:
1624 - typemaps correction to take into account the systematic replacement
1625 of "using namespace std" with std:: prefix e.g. std::list,
1626 std::string... (cf changes of 2003-05-21).
1627 - gdcmGlob global variable of type gdcmGlobal (defined in
1628 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1629 exported to Python a as cvar.
1630 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1631 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1632 gdcmDictSet.GetPubDictTagNames() and
1633 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1634 C++ static methods).
1635 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1636 with the above changes.
1638 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1639 * setup.py, manifest.in : bug fix under linux
1641 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1642 * Modification of setup.py to compile vtk part too. Then, we have 2
1643 wrappers which must work with same distutils. For that, we have a
1644 generic distutils in distusiltsWrapping.py ; with :
1645 - build_extWrap class to wrap generically all extensions,
1646 - ExtensionWrap base class for all wrapping extension that contains
1648 - Wrapper interface which wrap sources
1649 + In WrapSwig.py we have extension and wrapper for Swig
1650 + In WrapVTK.py we have extension and wrapper for VTK
1651 * MANIFEST.in : modifications to consider vtk directory and new python
1652 files for compilation
1654 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1655 * Added python wrappers of vtkGdcmReader vtk class (see the
1656 source in vtk/vtkGdcmReader.cxx) :
1657 - vtk/Makefile.am now builds a library
1658 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1659 python library (as opposed to _gdcm.so wich are the python
1660 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1661 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1663 - configure.in has an additional flag --enable-vtk that needs
1664 to be set to enable compilation of vtk related code, that is:
1665 + vtk/vtkGdcmReader.so and
1666 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1667 + gdcmPython/vtkgdcmPython.so (see above)
1668 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1669 be read when compressed or when HighBit + 1 != BitsStored),
1670 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1671 the usage of the python wrapper of vtkGdcmReader vtk class.
1672 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1673 * src/*.[h] all occurences of stl classes are now prefixed with
1674 std::, and all occurences of "using namespace std;" where removed.
1675 This is to avoid pollution of global namespace in included files.
1676 Apparently vtk does not avoid this pitfall: when using both
1677 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1678 collision of various stl members (principally cout...).
1679 * gdcmPython/testSuite.py now cleanly removes temprory generated
1681 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1682 comply with above changes)
1684 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1685 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1686 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1687 vtk data structure (an image Flip was required).
1688 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1689 * cosmetic changes in documentation.
1691 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1692 * src/gdcmHeader.cxx: the constructor no longer exits when an
1693 unexisting file is given as argument.
1694 * The subdirectory Data (containing all the images used for the
1695 test suite) is not part of this repository anymore. A new module
1696 containing those images is now available at
1697 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1698 with the name gdcmData.
1699 All the python scripts (including the package initialisation file
1700 gdcmPython/__init__.py) were adapated to take this change into
1701 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1703 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1704 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1705 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1706 demo of the usage of this class.
1707 Compilation of this vtk part is only done when using the --enable-vtk
1708 at configure (or autogen.sh) stage.
1710 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1711 * More memory link related corrections and documentation fixes.
1713 - maximum info is obtained with a command of the form:
1714 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1715 --show-reachable=yes PrintHeader
1716 - the remaining reachable blocks seem to come from the STL
1717 allocation scheme through the usage of map and list. It looks
1718 like this memory cannot be freed but it is not a memory leak
1719 (in fact further invocation to the STL would recollect the
1720 unused memory allthough it cannot explicitely be freed).
1721 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1722 of displaying an image parsed with gdcm and displayed with VTK.
1723 Note: some images don't seem to work e.g.
1724 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1725 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1726 Allthough this weakens the semantics, it is a ditch attempt to
1727 make gdcm more thread friendly.
1729 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1730 * Memory link hunt (by using valgrind through the command
1731 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1732 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1733 gdcmHeader::_dicom_vr.
1734 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1735 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1737 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1739 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1740 * src/Makefile.am now exports all the necessary include files at
1744 * UpdateGroupLength replaced by new one
1747 * UpdateGroupLength re-written using H-Table
1748 (named UpdateGroupLengthNew untill checks are over)
1750 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1751 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1752 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1754 - gdcmHeader::GetPubElValSet removed.
1755 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1756 UpdateGroupLength, WriteElements, Write.
1757 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1758 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1759 carried the same semantics.
1760 - src/gdcmHeaderIdo.cxx changed accordingly.
1761 - gdcmFile::WriteBase now regroups all the codes from previous
1762 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1763 - enum FileType moved to gdcmCommon.h
1764 * src/gdcmHeader.cxx AddDefault trashed
1765 * gdcmGetXSize added
1766 * getimageDataSize now calls gdcmGetXSize
1767 * Test/*.cxx changed to agree with above changes
1769 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1770 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1771 (to avoid double call by end user).
1772 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1773 by end user, since gdcmHeader::gdcmHeader now handles it.
1775 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1776 * gdcm/Doc many doxygen changes:
1777 - Doxyfile now has two different versions, DoxyfileUsers that generates
1778 the html.users end users oriented documentation and
1779 DoxyfileDeveloppers that generates the html.developper developper
1780 oriented documentation.
1781 - README changed accordingly
1782 - requirement.txt removed (old design info moved to TODO).
1783 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1784 DoxyMainPage.txt, DoxyPython.txt provide more information.
1785 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1786 be updated by simply regenerating the docs with doxygen and copying
1787 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1788 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1789 all the tests in the form "if (<map>.count() >1)" were removed.
1790 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1791 ill-formed documentation sections.
1792 * src/gdcmHeader.cxx: ditto
1794 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1795 * setup.py fixed for un*x (needed macro for stdint.h)
1796 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1797 un*ces with sh-utils test utility.
1798 * gdcmPython/demo/test.py renamed to PrintHeader.py
1799 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1800 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1801 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1802 * src/gdcm*.cxx JPR's bad inclusion fixed.
1804 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1805 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1806 * gdcmPython/demo/test.py changed accordingly.
1808 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1809 * gdcmPython/Makefile.am fixed linking against libstdc++
1810 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1811 * Swig subdir (historical tests of swig version 1.3.17++) removed
1812 * Test/testChangeEntete.cxx some lines commented out in order to make
1814 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1815 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1817 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1818 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1819 hence the user doesn't need this explicit call.
1820 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1821 i.e. LoadElements() call removed.
1822 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1823 - src/Makefile.am declares the proper flag for g++.
1824 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1825 for adding user defined new tags.
1826 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1827 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1828 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1830 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1831 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1832 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1833 src/Makefile.am : the project should properly compile and install
1834 with the autotools, included the python wrappers part.
1835 * gdcm.spec.in : added a spec file for RPM packaging.
1837 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1838 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1840 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1841 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1842 to exported to the environement (see gdcmPython/testSuite.py
1844 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1845 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1846 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1847 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1848 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1850 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1851 * gdcmPython/__init__.py doesn't crash anymore when running in
1852 in InstallMode or PreInstallMode but with an environement given
1853 value of GDCM_DICT_PATH.
1854 * src/gdcmDictSet.[cxx/h] coding style.
1856 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1857 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1858 * src/gdcm.h general comments moved to TODO, and README
1859 * src/gdcm.h should now be seen as a user commodity (including it
1860 should suffice to fully use gdcm). It is nowhere including within
1861 any of the kernel files src/*.cxx and src/*.h.
1863 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1864 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1865 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1867 * src/gdcm*.cxx only include their corresponding include file
1868 (as opposed to gdcm.h)
1869 * gdcmPython/gdcm.i changed accordingly
1870 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1871 the autogen.sh generated "make snapshot" command to work.
1872 * autogen.sh removed history related references to crea package.
1874 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1875 * distutilsSwigCPlusPlus.py work around some swig portability
1878 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1879 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1880 was done in a last ditch attempt to get setup.py _really_
1881 operationnal. The python/gdcmPython layaout add the advantage
1882 of hidding away the python related distutils specific files
1883 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1884 Alas, the src directory was out of scope (i.e. it's relative
1885 position to setup.py was ../src) which made things impossible to
1886 handle (see previous version of python/setup.py). Crossing fingers...
1888 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1889 * python/setup.py now works on Un*x. (harder than I thougth)
1890 * python/distutilsSwigCPlusPlus.py can now have include files
1891 among the list of sources.
1893 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1894 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1895 * modifications in MSVC projects
1897 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1898 * As stated by the first lines of Test/ExceptionAndPython/README, it
1899 looks like we can move back to original usage of exception within
1900 src/gdcm* and hence remove the errno stuff that was introduced
1901 as a quick and dirty fixture of this problem (added to the TODO).
1902 * Doc/Doxyfile configuration file for Doxygen and corresponding
1903 README file for usage added.
1904 * Test/testWrite.cxx added. This new test comes from a split of
1905 test.cxx that is now reverted to its original purpous i.e.
1906 testing the proper parsing of a Dicom related file.
1907 testWrite.cxx concentrates on testing the IO part of gdcm.
1908 * Test/bug1.cxx (containing a bug on WIn32) added.
1909 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1910 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1911 whose purpose is to publish the content of the TagNames of the
1912 Dicom public dictionnary were not accessible without an
1913 instance of class gdcmHeader.
1914 - those methods are now static methods of gdcmDictSet and hence
1915 require no instances at all to be invocated.
1916 - within gdcmDictSet this change required to change some method
1917 to class methods (i.e. are now static) among which SetDictPath
1918 (renamed to BuildDictPath) and LoadDefaultPubDict.
1919 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1920 the above changes by calling the new method classes of gdcmDictSet.
1921 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1922 the above to be effective.
1923 * python/gdcmPython: in order to wrap properly the above changes
1924 for Python, swig version now needs to be > 1.3.17.
1925 * python/gdcmPython/Makefile fixed to adapt itself to new
1926 configure/make shema introduced by Johan Montagnat (thanks for the
1927 contribution). Alas this Makefile cannot be turned into a proper
1928 Makefile.am without some heavy changes in the configure.in
1929 (for python dectection).
1930 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1931 now avoids publishing the empty entries.
1933 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1934 * python/setup.py : bug fix concerning install under windows
1935 ExtraPath reused :-P
1936 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1938 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1939 * Dicts/dicomV3.dic : remove double spaces !!!
1940 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1941 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1944 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1945 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1946 method. Doxygenation.
1947 * src/gdcm.h clean up of JPR spurious comments.
1949 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * python/distutilsSwigCPlusPlus.py now properly collects the
1951 shadow classes generated by "swig -c++" (gdcm.py in our case)
1952 when using "python setup.py install".
1953 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1954 reexports the working classes.
1955 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1956 by the classical C errno scheme. This is to prevent an obscure
1957 behavior of the python wrappers when importing wxPython.wx prior
1958 to gdcmPython (which ended up in an abort call). An illustration
1959 of this oddity can be found in the Test/ExceptionAndPython
1960 subdir (see the README file). This problem probably due to
1961 an combination of g++ and dynamic loading.
1962 * added Test/ExceptionAndPython (see above)
1964 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1965 * Changed the layout of the python part to avoid bloating main
1966 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1967 i.e. the distutils arsenal. All the python related stuff is
1968 again in a python subdir, but the package itself is now in
1970 * setup.py was cleaned up:
1971 - pythonIncludePath removed
1972 - python setup.py bdist target is now functional.
1973 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1974 collision with other packages). gdcmPython/demo/*.py changed
1977 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1978 * python subdir moved to gdcmPython (preparation of distutils packaging).
1979 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1980 distutils installer is operational.
1981 * - gdcmPython/__init__.py now properly loads the swig generated
1982 shadow classes (from gdcm.py).
1983 - gdcmPython/demo/*.py changed to import the package gdcmPython
1984 instead of gdcmPython/demo/load.py.
1985 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1987 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1988 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1989 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1990 entries within the associated public Dicom dictionary resp. the same
1991 information but sorted by the fourth field (PAT, IMG, DIR) of the
1993 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1994 are now in the "???" group.
1995 - python/gdcm.i changed accordingly,
1996 - python/demo/printGroupedPublicDict.py added, that gives an example
1997 of the above new functionalities in Python.
1999 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2000 * src/gdcm.h, gdcmHeader.cxx:
2001 - historic references to glib's g_malloc and g_free (#defined)
2002 were definitively removed.
2003 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2004 * src/gdcmElValSet.cxx:
2005 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2006 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2007 - GetElValue(string) renamed to GetElValueByName.
2008 - Added GetElementByName(string).
2009 * src/gdcmHeader.cxx: added
2010 - GetPubElValRepByNumber(guint16, guint16)
2011 - GetPubElValRepByName(string)
2012 - GetShaElValRepByNumber(guint16, guint16)
2013 - GetShaElValRepByName(string)
2014 - GetShaElValByNumber(guint16, guint16)
2015 - GetShaElValRepByName(string)
2016 - GetElValRepByNumber(guint16, guint16)
2017 - GetElValRepByName(string)
2018 - GetElValByNumber(guint16, guint16)
2019 - GetElValRepByName(string)
2020 * Doc/requirements.txt added.
2022 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * Test/Makefile building now depends on the one of libgdcm.so
2024 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2025 pixel data) aware which enables finding the address (offset) of
2026 the pixel data of JPEG encoded DICOM files. This leaves only a single
2027 file in the testSuite whose pixel data address (offset) is unknown.
2028 * python/testSuite.py changed accordingly.
2030 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2031 * VC++ has some strong limitations when working with the STL, as stated
2032 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2033 "Also note that some STL containers (map, set, queue, list, deque)
2034 cannot be exported. [...]
2035 Some STL classes contain nested classes. These classes can not
2037 This is caused by a designed limitation that once a template
2038 class is instantiated, it can not be re-instantiated and
2040 Since our usage of map<> is ubiquitous in gdcm, this "designed
2041 limitation" of VC++ is a pitfall.
2042 Hence the Python wrappers of gdcm cannot be incrementally linked
2043 against the c++ dynamic library. The dirty but only workaround is
2044 to forget about incremental link of dynamic libraries and to generate
2045 the Python wrappers library with the inclusions of the underlying C++
2047 The following modifications concern this matter on Win32/VC++:
2048 - wrapping python correct with standalone wrapped dll (don't use separate
2049 dll under windows !!!!)
2050 - python21_d debug mode enabled (ask Frog how to use it :-)
2051 - NO problem with having an STL member of class for example string in C++
2052 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2053 - Python test of dcmlib in Python is ok under windows on a large set
2055 * removed glib references
2056 * typedef's inserted in gdcm.i for correct swig type management
2058 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2059 * python/demo/*.py load.py extracted from test.py. Added explore.py
2060 that only displays required tags and testAll.py that parses all
2061 the files of the testsuite without using unittest.
2062 * python/testSuite.py other additional test on new files added.
2063 * Data/* new test files added accordingly to the testSuite.
2064 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2065 the vr in the file differs from the one of the dictionary.
2067 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2068 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2069 values, but limits itself to values which are below a user specified
2070 size (by default 1024 bytes).
2071 * python/gdcm.i : elements not loaded (because their size is above the
2072 user specified treshold) are exported with their TagKey as key of the
2073 python dictionary. This enables the testsuite to make some checks
2074 on the unloaded elements (since we have their offset and size).
2075 * python/testSuite.py
2076 - now tests for the existence and proper value of the pixel data
2077 - two new examples added.
2078 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2080 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2081 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2082 aware. See the strategy comments in gdcmHeader::FindeLength().
2083 * Test/test.cxx now accepts a filename as first argument.
2084 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2085 * python/testSuite.py changed to integrate test on above files.
2087 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2088 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2089 the vr was also RET.
2090 * python/testSuite.py more tests added.
2092 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2093 * python/testSuite.py unittest test suite added (uses Data)
2094 * Data/* dcm and acr files for the test suite.
2095 * glib dependance removed from un*x version. We now use ISO C99
2096 7.18 Integer types (see stdint.h)
2097 - python/Makefile, src/Makefile src/gdcm.h
2098 * src/ when an explicit vr (like dicom files) suddenly poped an
2099 implicit element we use to mark the underlying DictEntry of the
2100 concerned ElValue with "Implicit". This strategy was damageable
2101 too the public or provite dictionaries, since some of their vr
2102 would be changed. Since Header::FindLength heavily relies on the
2103 detection by Header::FindVR of falsely explicit elements, I
2104 added an extra ImplicitVr member to ElValue (boolean).
2105 The rest of the changes we the necessary adaptations.
2107 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2108 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2110 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2112 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2113 * Adaptation for porting to VC++:
2115 o forced to use std namespace (for string to be known)
2116 o all class use __declspec export style on WIN32
2117 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2118 (in stdlib.h on Win32 but in std:: for gcc)
2119 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2120 variable GDCM_DICT_PATH.
2121 * src/gdcmHeader.cxx verbose comments made discrete.
2123 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * python/gdcm.i: added a typemap that converts a C++ hashing table
2125 to native Python dictionary.
2126 * python/demo/test.py:
2127 - now uses the native dictionary for exploration of gdcmHeader.
2128 - takes an optional filename argument (the file to parse).
2129 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2130 PubElVals hashing table.
2131 * Dicts/dicomV3.dic removed error prone trailing spaces.
2133 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * Python wrapping process moved away from src/Makefile to
2135 newly created python/Makefile (as well as gdcm.i)
2136 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2137 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2138 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2139 from the environement variable GDCM_DICT_PATH (when existing).
2140 * src/gdcmDict::GetTag bug fix.
2142 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2143 * Straightforward temporary fixes for swig to build the python wrappers.
2144 src/Makefile now has a python working entry [by working we mean
2145 that we can import de shadow classes without errors].
2147 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2148 * hashtest.cxx removed (since allready in Test)
2149 * src/gdcmlib.h renamed to src/gdcm.h
2150 * src/dcm.i renamed to src/gdcm.i
2151 * src/Makefile prepared for python wrapping
2153 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2154 * src/gdcmHeader.cxx :
2155 - Parsing of header is now separated from loading of element values
2156 (see gdcmHeader::LoadElements).
2157 - general clean up of hopefully all file access (creation of
2158 ReadInt16 and ReadInt32)
2160 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2161 * src/gdcmHeader.cxx :
2162 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2164 - SetLgrElem renamed to SetLength
2165 - GetLgrElem renamed to GetLength
2166 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2167 * src/gdcmElValSet.cxx fixed both GetElValue methods
2168 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2169 due to IdoDude was cleaned out.
2171 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2172 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2173 concentrates on finding the value representation (when it exists).
2174 RecupLgr now only finds the element value length, and it avoids
2175 returning the unecessary skL (skipped length).
2176 Also, offsetCourant was simply removed (with taille_fich) since
2177 it was redundant with the File position internals (by using
2178 ftell and fseek). This also made skL (see above in RecupLgr) usage
2180 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2181 on the libido specificities which are handled through class
2183 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2186 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2187 * Truckload of changes. Parsing of header is barely functional
2188 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2190 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * src/gdcmHeader.cxx many addons of low level methods
2193 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2194 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2195 and _IdDcmSWAP_LONG.
2197 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2198 * This corresponds to all the changes decided at the meeting of
2199 May 23 2002. Needless to say we are running late...