1 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
3 At this time, this image isn't readable by e-film... waiting JPR help to
6 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
7 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
8 DocEntry. Now use methods of the Document !
10 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
11 * Test/ShowDicomSeq.cxx : bug fix
13 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
14 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
15 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
16 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
17 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
19 * Test/TestCopyRescaleDicom.cxx : remove unused variable
20 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
21 containing found sequences
23 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
26 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
27 Some fields in BinEntry must be copied to not seg fault when making the :
28 gdcm::File *copy = new gdcm::File( copyH );
29 and tests are now made on good variables
31 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
33 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
35 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
36 * Add vtkGdcmWriter example and test
38 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * Test/TestUtil.cxx : reformat the source code
40 * vtk/vtkGdcmReader.cxx : remove and change prints
41 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
43 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
44 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
46 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
47 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
48 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
50 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
51 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
52 by an eof to prevent all bad read of the file... and in this case, the
55 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
56 * Example/Volume2Dicom.cxx : comment unused variables
57 * Test/PrintDicomDir.cxx : comment unused variables
58 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
59 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
60 method that is redondant with AddEntry.
61 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
64 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
65 * Bug fix due my last commit (compilation under Windows).
66 * Example/Volume2Dicom : bug fix in the file and reformatting source code
67 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
69 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
71 - Remove printf / sprintf
72 - include iostream AFTER gdcm so we don't get warnings
73 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
75 - Also remove tons of include from header files, hopefully this should
76 speeup the compilation time, since it was becoming a dog slow.
77 - Remove gdcm.h as it include way too many files and slow down compilation
78 (plus it is not up to date)
79 - remove 'using namespace std' this is BAD !
81 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
82 * Remove memory leaks on the DicomDir
83 * Remove some useless datas in DicomDirObject
84 * Add usefull methods in SQItem, to be complient withe the ElementSet
86 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
89 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
91 future, with convertion)
92 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
93 and ImageDataSize values. Remove the method to get the PixelReadConverter
94 from the output of the class
96 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
99 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
101 and vtkErrorMacro use.
102 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
104 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
105 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
107 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
108 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
109 The string leaves only in the fonction. So when we make a .c_str(), we
110 get the pointeur on the first element, element that will be destroyed
111 immediately after thee instruction.
112 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
113 file has been opened : the test must be made on the content of the
114 pointer and not directly on the pointer !
117 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
119 the python part recompiles
121 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
122 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
123 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
124 X session is killed (for my computer... it seems to not be identic on
127 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
128 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
129 avoid problems (otherwise, the difference test between the visible image
130 and the reference is incorrect. If the reference is greater than the
131 screen resolution, it's produce errors).
132 Can be used for only one image. Can be used with a visible flag.
133 * vtk/vtkGdcmReader.cxx : remove commented codes.
134 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
135 under windows at compilation
136 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
138 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
140 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
142 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
143 tests on the image size X, Y, Z
145 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
146 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
147 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
148 between the class name and the file name
150 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
151 * src/ : fix compilation warnings for the Write method (2 different
152 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
153 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
154 variable... create a static method in gdcm::Document to access to
155 this variable content.
157 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
159 file, to be accessed by other files (like gdcmFile). Remove commented
160 code. Move the change of the header to the gdcmFile, using the
162 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
163 To be sure of that (and simplify calls), the Write of the header now
164 gets a file name and not a file pointer (std::ifstream).
165 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
166 DocEntryArchive. Remove all open of the written file
168 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
169 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
171 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
173 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
175 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
176 some corresponding methods. Write correctly the file and check before
178 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
179 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
180 is now on RGB datas (as before my last commit
181 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
183 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
184 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
185 Add a print information of the type of the entry
186 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
187 It was in the gdcmFile, and all write have been regrouped
188 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
189 Write correctly all dicom files (in decompressed mode only at this time)
190 * Test/ : test on files are now made using Raw datas and not color datas if
192 * Example/PrintFile.cxx : add more printings
194 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * Amelioration of code, remove some code copy. For the loading of
196 BinEntry (in gdcmDocument), add the test to verify if the file is already
199 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
200 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
201 remove a DocEntry in the header (push an empty DocEntry)
202 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
203 lines. Bug fix in the initialization of the PixelConvert and the
205 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
206 use in TestCopyDicom (now this test can run under windows... but fails)
207 * Test/TestCopyDicom.cxx : amelioration of the test :
208 - test the pixels written
209 - add test points to quickly find where is the error
210 - can set a file name input and output in arguments
211 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
212 amelioration of the test output
214 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
215 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
216 all replaced DocEntry's
217 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
218 Now, each needed DocEntry to modify is duplicated, modified and inserted
219 to the header using DocEntryArchive. Thus, after save, we can restore the
220 header initial state.
222 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
223 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
225 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
226 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
227 correct to copy it. The DictEntry is specified at the DocEntry creation,
228 then, it musn't change in the time.
229 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
230 header correctly. At this time, the change is only made for the first
231 level of the Document. In the future, it might consider sequences.
232 The change is made by replacing a DocEntry by an other that is created
233 outside the class. The old value is kept. When we restore the header
234 status, the added DocEntry is deleted and replaced by the old value.
235 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
236 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
237 set the write type to explicit VR, implicit VR or ACR. Add methods to set
238 the write mode to native, decompressed or RGB (but not used at this time)
240 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
241 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
242 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
244 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
246 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
248 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
249 set because already copied when copying the BinEntry's of the header
250 * Test/TestAllReadCompareDicom.cxx : remove warnings
252 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
253 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
254 Two problems appear when doing it :
255 - with the gdcmFile : when the GetImageData method is called, the pixels
256 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
257 datas (pixels). And each structure destruct the datas when it's
258 destructed. So we have two destructions for the same datas. To solve it,
259 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
260 datas or not. If it doesn't own datas, then they will not destroyed by
262 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
263 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
264 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
265 create a double destruction of the same DocEntry's. So, to solve it,
266 the TagHT is simply cleared and the DicomDir* elements are destroyed.
267 * TODO : add an entry concerning memory leaks in the DicomDir
269 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
270 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
271 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
274 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
275 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
276 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
277 after it have been deleted
279 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
280 * FIX: src/* fix the doxygen warnings.
281 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
282 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
283 was erroneously defined with a size of 15 instead of 16. [many thanks
284 to Jean Michel Rouet for pointing out this bug].
286 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
287 1. Finish merging JMR patch for writting DICOM from scratch
288 2. Fix -hopefully- bug with MONOCHROME and space vs null character
289 3. Use const ref when possible
290 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
291 5. A few more comments
292 6. CreateUniqueUID can now be called without parameter"
294 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
295 * ENH: Slightly bigger patch:
296 1. Getting toward full integration of JMR patch for writting dicom from scratch
297 2. Update Test to test part of this patch: CreateUniqueUID
298 3. File was not close properly in gdcmDict
299 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
300 5. Use of const ref instead of copy (speed issue)
301 6. Remove temporary (duplicate) string in TranslateToKey
302 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
303 8. Do not repeat virtual in subclasses
304 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
306 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
307 * Apply first patch toward better string comparison when dealing with broken
308 DICOM files. Essentially the string could be padded with a space instead
309 of a null character as defined by standard
311 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
312 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
313 because never used... and in the same time, that's remove some memory leaks
315 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmFile.cxx : now delete the PixelConvert instance.
317 * In examples and tests : change the type of image data variables from void*
318 to uint8_t*. Remmove all delete on image data variables
320 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
322 Verify the file pointer value before open the file, and if it's not null,
323 a verbose message is generated.
324 Close correctly the file when the file isn't considered dicom-like. The
325 correctly close is a call to CloseFile.
326 When closing the file pointer, test if its not null to close the file.
327 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
328 file. For an uncompressed image, the copied datas correspond in the least
329 case to the image size (calculated) or the image size specified in the
330 header. A verbose is generated if these two size mismatch
332 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
333 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
334 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
335 break under windows (with msvc6 compilation).
337 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
338 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
339 compiling with MSVC6)
341 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * Bugs fix for the Windows build with VC6
343 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
344 needed (only for projects required VTK). If the VTK is included in all
345 projects, there is conflicts with the jpeg lib of vtk when compiling the
346 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
347 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
348 when compiling the gdcm_wrap.cxx file (created by the compilation of the
350 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
351 (like it's already made for the cout use). Otherwise, conflict with the
354 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
355 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
357 - comments on the DicomDir::Method related usage added.
358 - now that we use the namespace gdcm, a lot of internal classes do
359 NOT need to be wrapped anymore.
360 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
361 DicomDir::Method) new example added.
363 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
364 * Improve string manipulation. I now inforce the notion of 'DicomString'
365 A DicomString can contain as many \0 as they want
366 and it is *always* of even length.
367 We only support odd length for very rare case.
368 And in the near future this should be removed.
370 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * /binary_write/ gdcm source. Now even on big endian we are writting
372 little endian. This should -heopfully- fix some tests
374 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
375 * Now the dictionary is compiled into gdcm lib. This is a default
376 behavior, thus any dic file specified is picked before failback to
377 the one comiled into lib
379 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
380 * Change internals for gdcmDict. Don't use any 'new' any more.
381 This should definitely solve any leak problem, and we should be
382 as fast as before, as long as don't modify too much the dictionary.
384 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
385 * STYLE: ivars should start with a capital letter.
386 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
387 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
389 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
390 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
391 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
392 new 2004 dictionaries added (thanks to JPR).
393 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
394 * CLEANUP_ROUND (15) for gdcmPixelConvert
395 - RLEFrame::NumberFragments is now of type unsigned int
396 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
397 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
400 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
401 * Initial work in gathering all transfer syntax accessors. clearly
402 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
403 ivars, but only one transfersyntax (class) ivar with equivalent method on
406 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
407 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
408 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
409 discussed (plus I didn't like having a 2000 lines patch not commited)
411 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
413 * CLEANUP_ROUND (14) for gdcmPixelConvert
414 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
415 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
416 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
418 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
419 anymore and hence avoids storing a copy of PixelConvert::Decompressed
420 into File::Pixel_Data.
422 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
423 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
424 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
425 * CLEANUP_ROUND (13) for gdcmPixelConvert
426 Substituted File::ParsePixelData() with PixelConvert::Print() new
428 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
429 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
430 method to those classes.
431 - src/gdcmFile.[cxx|h]:
432 -- Added a ::Print() method.
433 -- PixelConverter is now a reference instead of a member.
434 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
435 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
437 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
438 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
439 collaboration diagram and inheritance diagram should be generated with
441 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
442 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
443 pointlessly wrapped (see
444 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
445 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
446 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
447 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
448 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
449 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
450 -- File::Initialise: PixelConverter setup moved away to
451 PixelConverter::GrabInformationsFromHeader()
452 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
453 interpretation moved away to PixelConverter::BuildRGBImage()
455 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
456 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
457 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
459 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
460 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
461 displayed on Win32 when a brutal abort() occurs (because of uncatched
462 exception). See TODO new entry of this commit for more on this.
463 * TODO added new entry.
464 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
465 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
466 - HandleColor is no longer called from gdcmFile.cxx
467 - gdcmPixelConvert.cxx clean up on method arguments and internal
468 variable names for semantical coherence.
470 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
471 * Finished lossless transition, not only do we now read all lossless jpeg
472 images, without the need of the Cornwell lib, but we do read them properly now
473 * To reduce code (well to avoid code duplication), I defined a common place
474 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
475 redefine symbols. This is not prefect but this the best solution I found for a
476 compilation time jpeg option.
478 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
479 * Update jpeg ijg lib to support lossless jpeg implementation
480 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
482 * Also added a special copyright for dcmtk since we use their bugfixes.
485 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
486 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
487 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
488 matters, as stated in warning note at begining of %include section).
489 * src/gdcmDicomDir*.[cxx|h]: coding style
490 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
491 * src/gdcmJpeg8.cxx: doxygen fix.
492 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
493 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
494 from File:: to PixelConvert::.
496 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
497 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
498 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
499 - more code moved away from File:: to PixelConvert::
500 - fat setup of PixelConverter set in place in File::Initialise.
502 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
503 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
504 namespace at the file system level. So now you should convert your examples
506 gdcmHeader -> gdcm::Header
507 It would be nice if people keep in mind to no open the namespace, since it
508 allows compilation on broken plateform which were defining common symbol in
509 the standart namespace (like LP, Unknown ...)
511 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
512 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
513 The JPEG fragments are now parsed at the same stage than the RLE
514 information. All code related to JPEG is now in gdcmPixelConvert:
515 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
516 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
517 export a gdcmFile:: method. Those are simply global functions
518 (for the time being this is better than having them attach to
519 either gdcmFile:: or gdcmPixelConvert::).
520 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
521 and stores the result in a gdcmJPEGFragmentsInfo.
522 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
523 code (among other stuff) moved away from gdcmFile:; to
526 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
527 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
528 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
529 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
530 clean up of RLE related code.
531 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
532 - src/gdcmRLE.cxx removed
533 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
534 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
535 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
536 * CLEANUP_ROUND (9) for gdcmPixelConvert
537 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
538 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
539 away from gdcmFile:: to gdcmPixelConvert::.
541 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
542 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
543 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
544 This is because Parse7Fe0 used to parse the pixels to compute the
545 length. This task was passed over to FindDocEntryLengthOB() a long
546 time ago, EXCEPT I had forgotten the OW case...
547 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
548 we just recylce the code for parsing RLE fragments and computing
550 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
551 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
552 with the retired Parse7Fe0().
553 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
554 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
556 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
558 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
559 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
560 - src/CMakeLists.txt: alphabetic order reodering + new entries.
561 * CLEANUP_ROUND (4) for gdcmPixelConvert
562 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
563 to return an unused length.
565 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
566 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
567 this should be cleanner from the plane view. The iostream are erally a pain
568 to use to do simple stuff.
570 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
571 * Redo the compilation of the ijg jpeg library. Now only one source is
572 necesseray. No need to rename file by hand what so ever. CMake handle the
573 copying of the file within different directory, configure header file to
574 modify some symbol. The only addition made to ijg wasd a mangle table so
575 that symbol are different wether we are within 8bits or 12bits.
577 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
578 * Added documentation of vtkgdcmReader on Website:
579 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
580 with it's binary name).
581 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
582 the Website to be more complete.
583 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
584 doxygenated documentation.
585 - Doc/DoxyVtkGdcmReaderExamples.txt added
586 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
587 DoxyVtkGdmReaderExamples.html )
588 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
589 * CLEANUP_ROUND (3) for gdcmPixelConvert
590 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
592 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
593 * CLEANUP_ROUND (2) for gdcmPixelConvert
594 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
596 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
597 * CLEANUP_ROUND for gdcmPixelConvert:
598 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
599 - src/gdcmPixelStuff[h|cxx] removed
600 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
601 - src/CMakeLists.txt changed accordingly
603 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
604 gdcmVersion.py moved to newly created ATTIC related
605 gdcmPython/SetupOldies/ directory.
606 * Autotools clean up:
607 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
608 - autogen.sh configure.in acinclude.m4 python.m4 removed
610 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
611 * src/*.cxx *.h Reference to License.htm fixed to License.html.
612 * Doc/CMakeLists.txt, doxygen.config.in: fix.
613 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
615 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
616 * TODO updated with Mathieu suggestions. I proposed a template for
617 describing TODO entries and used it for new entries.
618 * Added Doc/Website/CodingStyle.html, Developpers.html,
619 DeveloppersPython.html, GdcmDataCvs.html and
620 DownloadVersion0_1.html, DownloadVersion0_3.html.
621 * Some Doc/*.txt Doxygen files (which do not really concern the
622 documentation itself, but the website) moved to html and
623 placed in directory Doc/Website:
624 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
625 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
626 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
627 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
628 * CMakeLists.txt changed accordingly.
629 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
630 DeveloppersPython.html
631 * INSTALL nows refers to Doc/Website/Installation.html
633 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
634 * Added Doc/Website directory, that contains a first raw version
637 2004-09-23 Jean-Pierre Roux
638 * FIX In order not to be poluted any longer by casting problems,
639 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
640 we can now delete[] it safely
641 * VoidArea is now called BinArea (less confusing name),
642 and all the methods called ...VoidArea... are now ... BinArea...
643 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
645 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
646 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
647 clear) TagHT, which is an inherited member of gdcmElementSet. It is
648 up to the destructor of gdcmElementSet to clean up TagHt and it's
651 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
652 * Test/CMakeLists.txt: update to follow gdcmData renamings.
653 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
655 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
656 * ENH: added some utility method that builds a flat dictionnary
657 holding all the Dicom entries contained in the recursive structure
658 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
660 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
661 BuildFlatHashTable() that build a flat dictionary.
662 - src/gdcmElementSet.h: added a new private GetTag() accessor.
663 gdcmDocument is now a friend of gdcmElementSet.
664 - src/gdcmElementSet.cxx: clean up.
665 - Example/FlatHashTablePrint.cxx added.
666 - Example/CmakeLists.txt changed accordingly
668 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
670 moved away from gdcmDocEntrySet (since this class is an abstract class
671 acting like an interface). SQDepthLevel and BaseTagKey are now
673 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
674 and associated accessors. Doxygenation of the class.
675 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
677 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
678 Use SQDepthLevel accessor instead. ::Print() adapted.
679 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
680 - src/gdcmDocument.cxx changed accordingly.
682 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
684 - The following is the doxygen comment of the typedef declaration
685 of gdcmagKey in src/gdcmCommon.h:
686 gdcmTagKey is made to old an "universal" (as in URL, Universal
687 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
688 A dicom tag allways has a group and an element, but a set of tags
689 embeded in various (optionally nested) sequences and sharing
690 the same group and element all share the same (group, element)
691 "identifier". Hence the (group, element) cannot be used as an
692 identifier (in gdcm we shall refer to a "TagKey") of a tag.
693 In order to construct a proper tag identifier (i.e. a key) we
694 consider the following definition of a TagKey:
695 - let Group, Element be the string representation of the
696 group and element dicom tag members,
697 - let ItemNumber be the string representation of the integer
698 index of the considered item number of a sequence,
699 Let the key of a tag embeded in a sequence, noted SeqTag, be
701 /ItemNumber#Group|Element
702 where "/", "#" and "|" are characters acting as separators.
703 Then the general form of a gdcmTagKey is given by:
704 Group|Element<SeqTag>
705 where <SeqTag> means NO or many instances of SeqTag.
706 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
709 but the gdcmTagKey of a tag "embeded" is the first item of
710 a sequence, itself nested in the third item of a sequence is the
712 0004|1220/2#0008|0082/0#0008|0090
713 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
714 order to hold the new sequence compatible key. Previously, the
715 GetKey() method would look in the underlying gdcmDictEntry.
716 - src/gdcmDocEntry.cxx:
717 -- constructor now copies the underlying DictEntry key, in the local
719 -- ::Print: displays the member Key, instead of the (group, element).
720 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
721 - src/gdcmDocEntrySet.h:xi
722 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
723 -- now has a new BaseTagKey member.
725 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
726 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
728 This poses the problem with the semantics of the following lines
729 LoadEntryVoidArea(0x0028,0x1201); // R LUT
730 LoadEntryVoidArea(0x0028,0x1202); // G LUT
731 LoadEntryVoidArea(0x0028,0x1203); // B LUT
732 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
733 to the long FIXME note for what the problem is. Nevertheless in
734 order to get things working the dicom dictionary was altered !
735 Please fix things urgently...
736 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
737 information), see above note on moving the member VoidArea. Nevertheless
738 the following entries previously correctly set as US are now inproperly
740 0028 1201 OW IMG Red Palette Color Lookup Table Data
741 0028 1202 OW IMG Green Palette Color Lookup Table Data
742 0028 1203 OW IMG Blue Palette Color Lookup Table Data
743 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
744 of gdcmDocEntry moved to gdcmSeqEntry.
745 * src/gdcmSeqEntry.cxx: STYLE.
747 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
748 * Test/TestAllEntryVerify.cxx minor fix and added comments.
750 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
751 * gdcmPython/testSuite.py: all the test suite in python is now moved
752 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
753 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
754 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
756 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
757 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
758 to avoid inclusion recursion until STL is reached.
759 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
760 mecanism. errno.h is not included in gdcm anymore.
761 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
762 (gdcmFormatError now inherits from gdcmFormatUnexpected).
764 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
765 gdcmData/TestAllEntryVerifyReference.txt
766 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
767 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
768 exception_on_error parameter.
769 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
770 - vtk/vtkGdcmReader.cxx changed accordingly,
771 - Example/*.cxx and Test/*.cxx changed accordingly.
773 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
775 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
776 enable_sequences removed from gdcmHeader constructor and dependencies.
777 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
778 * gdcmPython/demo/PrintHeader.py: dummy fix.
779 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
780 skip_shadow removed from gdcmHeader constructor and dependencies.
781 * Example/*.cxx and Test/*.cxx changed accordingly.
783 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
784 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
785 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
787 2004-07-21 Jean-Pierre Roux
788 * FIX Now, Parsing and Printing a DICOMDIR do work!
789 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
791 2004-07-20 Jean-Pierre Roux
792 * FIX Some brain damaged headers have Zero-Lenght fields
793 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
795 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
796 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
797 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
798 variable (instance of gdcmDebug) by a definition macro, and the instance
799 is now in static in the gdcmDebug class
800 * src/gdcmSQItem.h : (FIXME) remove an undefined method
801 * Test/PrintAllDocument.cxx : bug fix in the result of the test
803 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
804 * WARNING: ctest now depends more tightly on gdcmData. You should
805 check out gdcmData properly for things to run smoothly...
806 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
807 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
808 we need the pixels not be loaded in order to use the ValEntry
809 that displays position and size).
810 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
811 This is a C++ based equivalent of gdcmPython/testSuite.py that should
812 be deprecated. If you have any doubts about the advantages of a
813 modern scripting language (read Python) versus grass root C++ (i.e.
814 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
815 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
816 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
817 Anyhow, consider documenting the gdcmData images in
818 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
820 * Test/CMakeLists.txt:
821 - now uses TestAllEntryVerify.cxx
822 - specific comments on oldACR00001.ima (now renamed in gdcmData
823 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
824 gdcmData/TestAllEntryVerifyReference.txt
827 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
828 * src/*.[h|cxx] : typedef clean up
829 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
830 - TagKey renamed to gdcmTagKey (for external usage)
831 - VRKey renamed to gdcmVRKey (for external usage)
832 - removal of typedef duplication.
833 - Removed all unecessary inline keyword from class inline definitions.
834 - Some method|function(void) declarations replaced with method|function().
835 * src/jpeg/libijg12/jdhuff12.c:
836 - printf polluting ctest removed.
837 - TAB removal for comminting
839 - TestAllReadCompareDicom.cxx: added a test that compares all the
840 images in gdcmDataImages.h with corresponding images in
841 gdcmData/BaselineDicom/. When baseline images are not present
842 this test creates them.
843 Note: we need to validate each reference image, but before that
844 I'd like to rename them with a more explicit name...
845 - CMakeLists.txt: changed accordingly.
846 * Example/*.cxx: examples now only include gdcm.h (as opposed to
847 including each header needed).
849 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * Test/*.cxx and Example/*.cxx: moved some examples away from the
851 test suite to the Example directory. Are concerned:
856 - TestWriteSimple.cxx
857 * Test/CMakeLists.txt: added some comments on reasons for black listing
858 image gdcmData/oldACR00001.ima
860 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
861 * Test/CmakeList.txt: removed the following from black list (to be coherent
862 with removal from gdcmData):
863 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
864 - gdcm-MR-PHILIPS-16.dcm
866 Added the following because after last cvs update, they cause
867 ctest -R TestReadWriteReadCompare
869 - gdcm-MR-SIEMENS-16-1.acr
871 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
872 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
873 new comments in this file) we temporarily (sigh) move to a weaker
875 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
876 we don't need to black list the following images anymore:
877 - 8BitsUncompressedColor.dcm
879 - US-PAL-8-10x-echo.dcm
880 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
881 fixes and the beautified code ;-)
882 This fixes the bug introduced in version 1.42 (when beautifying)
883 that made the parsing of 8BitsRunLengthColor.dcm unproper.
884 Note: ctest was blind to this bug (this means we need to still
885 improve the test suite). The bug could be detected by using
886 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
888 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
889 and by displaying the (garbage) produced file temp.XDCM...
891 2004-06-29 Jean-Pierre Roux
892 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
893 - replace by uggly but working old code :-(
894 A lot of things should be OK again.
895 It's really urgent to have a test suite that *tests*,
896 to prevent Frog's beautifying sessions to break all the stuff
897 (twice, withing a fortnigh ...)
899 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
901 redundancy) to added Test/TestReadWriteReadCompare.cxx
902 * Test/CmakeList.txt: because the compare test of
903 Test/TestReadWriteReadCompare.cxx fails, the following images are
904 black listed: - 8BitsUncompressedColor.dcm
906 - US-PAL-8-10x-echo.dcm
907 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
908 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
909 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
910 and ad-hoc kludge. This kludge is now removed, and on encountering
911 such an image (OB field brain damaged) we set errno. Then in
912 ::FindDocLength() we "fix" the length as being ALL what remains
913 in the file (until EOF). We then proceed, hoping for the best...
914 This fixes a SegFault in ShowDicom when trying to write such an
916 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
917 (because TestWriteRead breaks on it, after a non conformal commit?).
918 ctest now runs properly, except for MakeDicomDir (which was allways
919 broken) and the Python related stuff (still not fixed).
921 2004-06-24 Jean-Pierre Roux
922 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
923 FIX : Test/TestReadWrite now iterates on all the file names
924 (instead of infinite loop)
925 ENH : Test/TestWriteRead now iterates on all the file names
927 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
928 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
930 2004-06-24 Jean-Pierre Roux
931 FIX : - now Write drops LUT Descriptors and LUTs (if any)
932 when SamplesPerPixel =3
933 - now Write is no longer confused by
934 'BitsAllocated = 12" and 'BitsStored=12"
935 - "UN" value representation Elements are now written correctly
936 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
937 ENH : - now gdcmHeader has its own Write methods
938 (in order to split the job that has not to be done
941 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
942 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
943 loop on the same image until memory went out.
944 Note: this means we still have gobs of memory loss in PrintDocument
945 * src/gdcmDocument.cxx: fixes problem on parsing on file
946 gdcmData/16BitsJpegLosslessGrayScale.dcm.
948 2004-06-24 Jean-Pierre Roux
949 FIX : Write - All the Sequences and Sequence Item are now written
950 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
951 is added a the end, when necessary.
952 - A lot of brain-damaged images, that were read correctly are
953 now written correctly
954 - length compatible BinEntry are now loaded correctly
955 (even for odd groups)
956 Note : only Explicit Value Representation was checked.
957 (question : is implicit VR really necessary for gdcm ?)
959 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
960 * DEVELOPPER: added a proposition of coding style.
961 * src/gdcmDocEntry.h: removed every inline declaration (for test of
964 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
965 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
966 Use the gdcmDocEntry::Print() and Write() instead.
967 * src/gdcmDocument.cxx: bug fix.
969 2004-06-22 Jean-Pierre Roux
970 FIX : gdcmDocument.cxx
971 - Now we do recognize the JpegLossLess format (there was a misstyping in
972 code 'beautyfication' :-(
973 - Now we automaticaticaly load the Luts, if any
975 2004-06-22 Jean-Pierre Roux
976 In order : to write Sequences, whatever their imbrication level,
977 : to allow user to create his own Sequences
978 a lot of modif where necessary (adding, moving, or virtualising methods)
980 WARNING : save your own sources *before* cvs up !
983 ADD virtual void Write(FILE *fp, FileType filetype);
986 ADD virtual void Write(FILE *fp, FileType filetype);
987 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
990 ADD virtual void Write (FILE *fp, FileType filetype)=0;
991 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
992 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
993 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
994 ADD std::string GetEntryByName(TagName name);
995 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
997 std::string vr = "unkn",
998 std::string fourth = "unkn",
999 std::string name = "unkn");
1000 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1001 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1002 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1003 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1004 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1005 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1006 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1007 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1010 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1011 ADD virtual std::string GetEntryByName (TagName tagName);
1012 ADD virtual std::string GetEntryVRByName (TagName tagName);
1013 REM virtual bool Write(FILE *, FileType);
1014 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1015 FILE *_fp, FileType type);
1016 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1017 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1018 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1019 REM virtual std::string GetEntryByName (std::string tagName);
1020 REM virtual std::string GetEntryVRByName (std::string tagName);
1021 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1022 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1023 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1025 std::string vr = "unkn",
1026 std::string fourth = "unkn",
1027 std::string name = "unkn");
1028 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1029 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1030 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1031 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1034 ADD virtual void Write(FILE *fp, FileType filetype);
1037 ADD virtual void Write(FILE *fp,FileType filetype);
1040 ADD virtual void Write(FILE *fp, FileType filetype);
1041 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1042 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1043 REM std::string GetEntryByName(TagName name);
1046 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1048 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1049 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1050 The default constructor invoked by the line
1051 gdcmHeader *f1 = new gdcmHeader( header );
1052 was gdcmHeader::gdcmHeader(bool) instead of the expected
1053 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1054 Hence the parsing wasn't executed... See also below.
1055 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1056 as explicit constructor didn't do the trick to fix the above problem.
1057 Could anyone explain why ?
1058 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1059 properly calls gdcmValEntry::Print() (that was weed out from
1060 code related to gdcmBinEntry).
1062 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1063 * In order to fix memory leaks:
1064 - Test/TestWriteSimple.cxx: added cleaning of free store through
1066 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1067 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1068 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1069 (through the call to ::AddDicomDirMeta()) or the destructor
1070 would crash when deleting uninitialized ::metaElems].
1071 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1072 - src/gdcmDocument.cxx:
1073 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1074 from dynamic stores.
1075 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1076 was causing memory leaks.
1077 - src/gdcmSQItem.cxx:
1078 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1079 cleanly handled with polymophism: sorry but my milage is low).
1080 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1081 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1082 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1083 This avoids SegFaulting.
1084 - src/gdcmSQItem.h: coding style.
1086 - Test/TestWriteSimple still severely sucks. The output image content
1087 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1088 damaged when displayed with vtkgdcmViewer.
1089 - on memory leaks: TestWriteSimple leaks really less (see entry
1090 of 2004-06-18 in Changelog file for the call to valgrind).
1091 - on segfaults: ctest now passes all the tests but one (no more
1093 * Erroneous leading white fix:
1094 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1095 white[s] (as opposed to from >> xxx, that removes it [them].
1096 - src/gdcmTS.cxx: ditto.
1097 - gdcmPython/testSuite.py: dirty related kludge removed.
1098 * src/*: remaining references to gdcmParser removed.
1099 * src/*[cxx|h]: added copy[way]left header.
1102 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1103 * In order to fix writing of dicom files:
1104 - Test/TestWriteSimple.cxx: a simpler example of writing.
1105 - Test/CMakeLists.txt changed accordingly.
1106 - src/gdcmDocument.cxx:
1107 -- The destructor now recursilvely removes potential sequences.
1108 -- Bug fix in ::IsJPEG2000()
1109 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1110 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1112 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1113 to only declared) and build on top of
1114 ::GetDocEntryByNumber(guint16, guint16).
1115 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1116 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1117 for usage in destructor and treatement of promotion in
1118 ::ReplaceOrCreateByNumber().
1119 - src/gdcmSQItem.cxx: destructor should better handle his job.
1120 Test/TestWriteSimple now runs (or at least it DOES something).
1121 * We can now start hutting memory links. A good starting point is:
1122 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1123 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1124 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1126 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1127 * Valgrind note: after Mathieu Malaterre teached me how to read
1128 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1130 Using gcc, you can force the STL to use malloc and to free memory as
1131 soon as possible by globally disabling memory caching.
1132 With 3.2.2 and later, you should export the environment variable
1133 GLIBCPP_FORCE_NEW before running your program.
1134 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1135 simply vanish (it is still not clear to me, whether this means that
1136 STL std::string leaks or if valgrind believes it leaks...).
1137 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1138 running bin/gdcmTests makeDicomDir):
1139 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1140 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1142 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1143 SegFaulting (I drowned in DicomDir related code when trying to
1144 understand why the list is empty...).
1145 * src/gdcmDocument.h: first BSD license header try.
1146 * Doc/License.txt added.
1148 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1149 * src/gdcmDocument.[h|cxx]:
1150 - Clean up of the Transfer related predicates. They are now all based
1151 on new method isGivenTransferSyntax, that (should) handle properly
1152 the padding problem.
1153 - general clean up, simplification, and coding style.
1154 - Specific clean up of Parse7FE0() (umproperly named actually).
1155 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1157 2004-06-14 Jean-Pierre Roux
1159 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1160 - fix the display of SQItem ordinal number
1161 - add the GetSQItemByOrdinalNumber method
1162 - remove some useless never written private methods
1164 2004-06-14 Jean-Pierre Roux
1166 - adding a constructor taking a gdcmDocEntry as an input param
1167 - ReplaceOrCreateByNumber now returns :
1168 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1169 a gdcmValEntry * if a string value is passed as a param
1171 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1172 according to the param type (no longer sets a gdcmDocEntry)
1173 - GetValEntryByNumber, GetBinEntryByNumber added
1174 - NewValEntryByNumber and NewBinEntryByNumber added
1176 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1178 - GetSQItemNumber and SetSQItemNumber added, to provide
1179 a (relative) Item identier inside a given Sequence
1180 \warning : some pb remaining around this number
1182 - AddEntry now takes the Item Number as a param
1184 - adding a constructor taking a gdcmDocEntry as an input param
1186 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1187 * Memory leak hunt with the following command:
1188 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1189 --show-reachable=yes gdcmTests PrintDocument
1190 It looks like many (all?) leaks are due to the STL (or a bad usage
1191 of the STL. The lines producing the leaks now have a comment with
1192 a "MEMORY LEAK" tag: you can retrieve them with
1193 grep "MEMORY LEAK" src/*
1194 Here are two typical examples which I can't help fixing:
1199 char * test = "babo";
1200 name = test; //// <--- valgrind detects 960 bytes lost in
1201 //// call to std::string::operator=(char const*)
1202 name.clear(); //// Doesn't help !
1210 std::cout << "Type a bunch of characters followed by RETURN: ";
1211 getline(std::cin, line); //// <--- valgrind dectects a loss
1212 //// of 1320 bytes in call to
1213 /// std::basic_istream<>& std::getline<>
1219 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1220 * src/gdcmHeader.[cxx|h]:
1221 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1222 and related, moved away to gdcmDocument.
1223 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1224 the corresponding protected accessors of inherited class
1225 gdcmDocument, removed ! As a consequence gdcmFile had to be
1226 declared friend of class gdcmDocument (see below).
1227 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1228 - Clean up of undefined or unused methods.
1229 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1230 account the changes to gdcmHeader.h).
1231 * src/gdcmDocument.h:
1232 - gdcmFile is now a friend class (in order to take into account the
1233 changes to gdcmHeader.h).
1234 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1235 (see changes to gdcmHeader.h).
1236 - Accessors (reading on the form GetEntry*) are now public.
1237 - Clean up of undefined or unused methods.
1238 * src/gdcmDocument.cxx:
1239 - adaptation to changes to gdcmDocument.h
1240 - ::OpenFile now writes a verbose message when file cannot be opened.
1241 - some std::string properly set to VRKey
1242 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1243 references to gdcmDocument.
1244 * Test/TestFindTags.cxx: changed accordingly to above changes.
1245 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1246 cvs repository gdcmData.
1248 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1249 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1250 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1251 conflicts with gdcmValEntry::voidArea.
1252 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1253 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1254 Value representation between StringRepresentable and BinaryRepresentable.
1255 * src/gdcmDocument.cxx:
1256 - method ParseDES: proper indentation restored and usage of
1257 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1258 - method LoadDocEntry: the fingerprint left in the SetValue() of
1259 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1260 removed. Reverting to previous code segment with the proper
1261 dynamic_cast< gdcmValEntry* >.
1262 Note: this was (partially) breaking the python test suite
1263 (gdcmPython/testSuite.py) that made usage of the above
1264 fingerprint to check presence of "Pixel Data".
1265 * src/gdcmDocEntry.h: coding style.
1266 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1267 now taken into account.
1268 * gdcmPython/gdcm.i: adaptation to the new internal representation
1269 of gdcm (exit gdcmParser, hello gdcmDocument).
1270 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1272 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1273 anymore, but instead prints the loaded Python dictionary.
1274 * .... alas, the python testSuite is still broken.
1276 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1277 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1279 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1280 * src/gdcmUtil.h : export methods
1282 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1283 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1285 * Initial addition of automatic python testing
1286 * Initial addition of automatic image comparison
1288 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1289 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1290 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1292 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1293 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1294 * Test/ShowDicom.cxx : bug fix for msvc compilation
1295 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1297 2004-05-04 Jean-Pierre Roux
1298 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1299 new concepts (and new classes) :
1300 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1301 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1302 - Sequence Doc Entries (gdcmSeqEntries)
1303 a Sequence is composed of Items.
1304 Each item is a set of Doc Entries (this is recursive)
1305 The non uniqueness of the 'Dicom tag' is due to this recursivity
1306 (never taken into account)
1307 Our unability to add a new 'entry' in the header
1308 at the proper location (neither in the H-Table (map or multimap),
1309 nor in the Chained List is also due to this recursivity.
1310 Don't try, right now, to use/modify/compile these new sources :
1311 nothing is finished.
1312 We just commit all the stuff, 'as is', in order not to loose it.
1314 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1315 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1317 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1318 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1319 file prefix (SetFilePrefix)
1321 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1322 * Add a new test: ShowDicom, for now this is just the c++ version of
1323 checkRead.sh, later it will be able to compare the image read against a
1325 * Replace the DEBUG on the stack with a global entry in cmake interface:
1326 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1328 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1329 * Add an example subdir, with a real example on how to read + write a
1332 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1333 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1334 * Doc/CMakeLists.txt: the main page is now properly differentiated
1335 between the developper and user version.
1336 * Doc/doxygen.config.in: dropped search related obsolete flags
1337 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1339 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1340 * DEVELOPPER: added some helpfull comments for compile/test/install
1343 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1344 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1345 src directory, now generated in the build dir.
1346 2. Tests as mentionned smarter
1348 4. Add a new method in gdcmDict that return the PubDict by name
1349 this is interesting for 3rd party lib like ITK,
1350 where we could set the institution name / patient name...
1352 * ENH: 1. Now the test suite is working for real
1353 2. All binaries are now output in the gdcm-bin directory
1354 (this was not true before)
1356 2004-04-28 Jean-Pierre Roux
1357 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1358 SeQuence indented printing of Dicom Header.
1359 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1360 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1361 Computation of SQDepthLevel is now part of gdcmHeader constructor
1362 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1363 tree-like structure of a Dicom Header.
1364 * FIX Test code cleaning
1366 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1367 * ENH: Adding automatic testing
1368 1. Need a DartConfig.cmake to submit to public
1369 2. Add a test driver gdcmTest.cxx
1370 3. gdcmTestMain, an helper for the main test driver gdcmTest
1371 4. Files in Test don't have a main anymore, this becomes interesting
1372 when we add more and more tests, thus dsw don't have to load
1374 * ENH: Adding a GDCM_DATA_ROOT for testing
1375 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1376 one file instead of seven + some small cleanup
1378 2004-04-22 Jean-Pierre Roux
1379 * ENH Minor changes to the Print() methods.
1380 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1381 Header printing. Example given with :
1382 > PrintHeader fileName 2 new
1383 (SQ based tree-like structure still to be done for the Header ...)
1385 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1386 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1387 1. I have added some unsigned where needed
1388 2. Some function parameter not used -> (void)
1389 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1390 4. g++ don't like character '\' in comment
1391 5. #define jpeg_create_decompress jCreaDecompress
1392 this really need to be fixed
1393 6. virtualize destructor of gdcmObject ... leakage
1394 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1395 this also really need to be fixed
1396 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1397 remove compression file
1398 (as we only do decompression, right ?)
1399 * ENH: Change malloc/calloc/free with c++ equivalent
1401 2004-04-21 Jean-Pierre Roux
1402 * FIX gdcmHeaderHelper::GetXSpacing
1403 when a single value is found (bug ?), xpacing is now
1404 defaulted to yspacing
1406 2004-04-19 Jean-Pierre Roux
1407 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1408 * ENH add parameters :
1409 bool exception_on_error = false,
1410 bool enable_sequences = false,
1411 bool ignore_shadow = false
1412 to the gdcmFile constructors to be full gdcmParser compliant
1413 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1414 to allow reading of PAPYRUS 3.0 files
1416 2004-04-06 Jean-Pierre Roux
1417 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1419 2004-04-02 Jean-Pierre Roux
1420 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1421 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1422 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1424 2004-03-30 Jean-Pierre Roux
1425 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1426 for ACR file, written out as DICOM files (hope so...)
1428 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1429 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1430 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1431 moved to base class gdcmParser and only the specialisation is kept
1433 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1434 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1435 already does the job.
1436 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1437 (to be consistent with gdcmParser::WriteEntries).
1439 2004-03-30 Benoit Regrain
1440 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1441 upate of the object's instance. It's passed to 2 in the unfavorable
1442 case : one in the ExecuteInformation, one in the ExecuteData
1444 2004-03-29 Jean-Pierre Roux
1445 * ENH : Check on file type to be written moved
1446 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1447 * FIX : gdcmObject::ResetBoundaries now stops properly
1448 when end-of-list is reached
1449 : gdcmVersion modified (as Benoit Regrain asked)
1451 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1452 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1453 * src/gdcmUtil.cxx: added forgotten iostream include.
1454 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1455 equivalent to ExplicitVR in existing code).
1457 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1458 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1459 now contains all the gdcmGlobal related code.
1460 * minor coding style and doxygenation changes.
1462 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1463 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1464 now contains all the Debug related code.
1465 * minor clean-up of includes in src/*.cxx
1466 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1467 CreateCleanString) removed.
1468 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1469 * Doc/DoxyMainPageUser.txt added.
1470 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1471 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1472 src/gdcmDirList.cxx)
1474 2004-03-24 Jean-Pierre Roux
1475 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1477 2004-03-23 Jean-Pierre Roux
1478 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1479 big endian made volumes
1480 * ENH Now gdcmParser constructor and destructor are protected to forbid
1481 end user to instanciate class gdcmParser
1482 (only gdcmHeader and gdcmDicomDir are meaningfull)
1484 2004-03-22 Benoit Regrain
1485 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1486 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1487 gdcmSerie to gdcmDicomDirSerie
1489 2004-03-19 Jean-Pierre Roux
1490 * ENH Now the tree-like structure describing a DICOMDIR comming from
1491 an already existing DICOMDIR file is consistent with
1492 the home-made tree-like structure build ex-nihilo
1493 or build from the files held (recursively) in a Directory
1494 functions gdcmDicomDir::CheckBoundaries()
1495 gdcmObject::SetBoundaries() added
1497 2004-03-17 Jean-Pierre Roux
1498 * REM (Eric Boix bug) : removal of meaningless
1499 gdcmDicomDirImage::NewImage function.
1500 * FIX now file names and directory name are written properly in the
1502 * FIX now gdcmDicomDir constructor may be call without any trick
1505 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1506 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1507 of gdcmDicomDirImage::NewImage as empty function.
1509 2004-02-28 Jean-Pierre Roux
1510 * ENH add gdcmDicomDir:NewPatient
1511 add gdcmDicomDirPatient:NewStudy
1512 add gdcmDicomDirStudy:NewSerie
1513 add gdcmDicomDirSerie:NewImage
1514 to allow making gdcDicomDir object.
1515 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1516 (as opposite to the gdcmHeader chained list)
1518 2004-02-11 Benoit Regrain
1519 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1520 when using from python
1522 2004-02-10 Benoit Regrain
1523 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1524 * FIX : in gdcmDicomDir when the directory is empty
1525 * ENH : add callback and methods to get the progression of dicomDir
1528 2004-02-06 Jean-Pierre Roux
1529 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1530 - GDCM_META added to gdcmDicomDirType
1531 - class gdcmMeta created
1532 * ENH : - A brief summary is now displayed at the beginning of
1533 'testDicomDir' to help disaster magnitude estimation
1534 * REM : Now useless Test/explDICOMDIR.cxx
1536 2004-02-05 Benoit Regrain
1537 * ENH : add methods in gdcmObject to get the hash table or the list of
1539 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1540 * FIX : wrapping python for TagHeaderEntryHT
1542 2004-02-04 Benoit Regrain
1543 * FIX : even length for some strings when writting the dicom dir
1544 * FIX : sort the images in the dicom dir
1545 * FIX : Bug fix for python use of dicom dir
1546 * ADD : a python demo
1548 2004-02-04 Jean-Pierre Roux
1549 * FIX : Final solution (?) for icone embedded images
1550 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1551 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1552 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1553 gdcmData/gdcm-MR-SIEMENS-16.acr1
1554 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1555 to make full checking easier
1557 2004-02-04 Benoit Regrain
1558 * FIX : WriteEntries : coding style & logic in parameters
1559 * FIX : Set the elements to create the DicomDir in a dictionary file
1561 2004-02-03 Benoit Regrain
1562 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1563 * gdcmDicomDir : add the load of directory
1564 * Bug fix and print add-on
1566 2004-02-03 Jean-Pierre Roux
1567 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1568 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1569 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1570 * FIX gdcmParser.cxx : 'group length' elements are now considered
1571 as integers, even for shadow groups, when file is Implicit VR
1573 2004-02-02 Jean-Pierre Roux
1574 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1576 of the last synonym :-(
1577 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1579 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1580 * FIX taking into account the possible 7fe0,0010 multiplicity
1581 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1582 to allow removal of references to 7fe0,0010, to deal with
1583 ACR-NEMA images, when 0028,0200 is meaningfull
1585 2004-01-31 Jean-Pierre Roux
1586 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1587 no longer writes 'Un' on disk
1588 * FIX SQ elements with actual length are now dealt with corectly
1589 * FIX gdcmFile::WriteBase make the difference, for color images, between
1590 the length (for Palette expanded images)
1591 and Raw Length (non expanded image + Palette)
1592 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1593 (that broke Write). Replaced by UL.
1594 Aware user will reload the field if he
1595 thinks it's necesssary
1597 2004-01-30 Jean-Pierre Roux
1598 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1599 when 'dirty Acr' is found, to be compliant with the new
1600 IsReadable() methods.
1602 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1603 (no DOUBLE images in kosher DICOM,
1604 but so usefull for people that miss them ;-)
1606 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1607 DICOMDIR related utilities (not checked as Windoze compliant)
1609 2004-01-28 Jean-Pierre Roux
1610 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1612 2004-01-27 Jean-Pierre Roux
1613 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1614 to allow skipping the shadow elements, to save memory space.
1615 The TRUE value for this param has to be used
1616 with a FALSE value for the 'enable_sequence' param.
1617 ('public elements' may be embedded in 'shadow Sequences')
1618 * gdcmHeader methods now deal with 'embedded icones images' in the header
1619 (even when an 'icone image sequence' is announced by the
1620 element (0x0088,0x0200), but there is NO icone at all ...
1622 * gdcmHeader sometimes Image Location value doesn't follow
1623 the supposed processor endianity (see gdcmData/cr172241.dcm).
1626 * gdcmHeader add the method
1627 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1628 to get *all* the Header Entries with the same tag.
1629 GetHeaderEntrySameName is probabely *useless*
1630 (no meaning : Name is *not* an identifier within the Dictionnary)
1632 2004-01-26 Benoit Regrain
1633 * Bug fix in the print of hexadecimal representations. Remove long fields
1634 in the print and add a third level of print to print them
1636 2004-01-23 Benoit Regrain
1637 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1638 * Bug fix on test suite after remove the strip made on not string fields
1639 * Split the IsReadable method between gdcmParser which test that the file
1640 is dicom and gdcmHeader which test that it's an image file
1642 2004-01-22 Benoit Regrain
1643 * DicomDir : clean code, add methods, set variables in protected or private
1644 * gdcmUtil : bug fix for the clean string method
1646 2004-01-19 Benoit Regrain
1647 * Add the use of shadow dictionaries
1648 * bug fix and coding style
1650 2004-01-19 Benoit Regrain
1651 * src/gdcmFile.cxx : bug fix concerning the close of file
1652 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1653 * Add the update of header entries using the shadow library
1655 2004-01-19 Benoit Regrain
1656 * removal of file gdcmHeader2.cxx
1657 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1658 inheriting from gdcmParser. This split is to prepare the integration
1659 of dicom dir parsing
1660 * bug fix under python
1662 2004-01-16 Jean-Pierre Roux
1663 * REM removal of class gdcmHeaderEntrySet
1664 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1665 * ADD add file gdcmHeader2.cxx
1666 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1668 2004-01-15 Benoit Regrain
1669 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1670 entries created while parsing the header. Thus, they will be destroyed
1671 when the gdcmDictSet will be destroyed
1672 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1675 2004-01-15 Benoit Regrain
1676 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1677 made a fatal error because of the memory release at the end of program.
1678 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1679 some memory and vtk seems to have some problems with that.
1680 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1682 2004-01-14 Benoit Regrain
1683 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1684 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1685 * src/*.[h|cxx] : make changes due to class name changes
1686 * gdcmPython/demo/*.py : bug fix due to method names
1688 2004-01-13 Benoit Regrain
1689 * src/*.[h|cxx] : coding style
1690 * vtk/*.[h|cxx] : coding style
1692 2004-01-13 Benoit Regrain
1693 * gdcmPython/testSuite.py : test the readable flag of file for tests
1694 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1695 It's lied to the stl compilation by MSVC (windows, always windows...)
1696 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1698 2004-01-12 Benoit Regrain
1699 * src/*.h : add comments
1700 * src/gdcmDictSet.h : set the method BuildDictPath in public
1701 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1702 directly setted in the source code
1703 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1706 2004-01-09 Benoit Regrain
1707 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1708 * setup.py : use a reference to gdcmVERSION
1710 2004-01-07 Benoit Regrain
1711 * Modification to compile with the distutils.
1714 2003-12-10 Benoit Regrain
1715 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1716 can use a gdcmHeaderHelper to load datas
1717 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1718 made in the source code
1720 2003-12-10 Benoit Regrain
1721 * Update Windows projects and .cvsignore files
1723 2003-11-12 Jean-Pierre Roux
1724 * ENH gdcmHeader constructor has one more parameter (default value : false)
1725 that allows the user to 'go inside' the SeQuences only
1727 gdcmElValSet:Print takes it into account
1729 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1730 * ENH: Update gdcmPython/CMakeLists
1731 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1732 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1734 2003-11-10 Jean-Pierre Roux
1735 * FIX : gdcmHeader::LoadElements is now based
1736 on the ListTag listElem member,
1737 not longer on the TagElValueHT tagHt member
1738 * ENH : PrintPubElVal shows (temporarily) both results,
1739 with the tagHt member and the listElem member.
1740 (it's easier to 'see' the problems when using Printheader)
1742 * FIX : old private member LgrElem is now splitted into
1743 ReadLength : Length actually found on disk (updated only
1744 if bug fixing is necessary), for internal
1746 UsableLength : Updated by FixFoundLength, to fix a bug
1747 or to allow Parser going on.
1748 Will allow to re-write a kosher header when a SeQuence
1749 with a length (not 0000) is found
1750 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1751 because gdcmElValSet::Add does not update ListElem
1754 2003-11-07 Jean-Pierre Roux
1755 * FIX misstyping in Transfert Syntax name table
1756 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1757 when they have an actual length (not 0000 nor FFFFF)
1758 (Nobody should care of it, but DICOMDIR explorers)
1760 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1761 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1763 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1764 * ENH: vtkGdcmReader now supports LUT !
1765 (vtkgdcmViewer for now is not able to use them though)
1767 2003-11-05 Jean-Pierre Roux
1768 * in testSuite.py : new files names for checking the package
1769 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1770 that returns the pixel area size to the *aware* (vtk) user
1771 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1773 2003-11-05 Benoit Regrain
1774 * in testSuite.py : Modify the rules for checking the paths
1775 : Explicit error messages
1776 * in __init__.py : Related modif
1778 2003-11-03 Jean-Pierre Roux
1779 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1780 to be used by aware (vtk) users that want to manage
1781 LUT (and no to turn the PALETTE image into an RGB pixels one)
1782 * GetPixelType now returns 8U for 24 Bits images
1783 (vtkGdcmReader compliant)
1785 2003-10-31 Jean-Pierre Roux
1786 * Removal of *all* gdcmData images and add them again
1787 in order to loose the 'history' of un-anonymised images
1789 2003-10-31 Jean-Pierre Roux
1790 * RMV : removal of useless jBitsInJsample.h
1791 for both 8 and 12 Bits JPEG Lossy Libraries
1793 2003-10-31 Jean-Pierre Roux
1794 * ENH : Add the functions gdcmFile::GetImageDataRaw
1795 gdcmFile::GetImageDataIntoVectorRaw
1796 that act as GetImageData and GetImageDataIntoVector
1797 except the making of an RGB Plane from Gray Plane + LUT
1798 Intended to aware (vtk) users who know how to manage
1801 GetLUTRGBA return a R,G,B,A LUT if any
1802 lgrTotaleRaw gives the 'Raw' length
1803 GetImageDataRaw returns the gray Plane
1804 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1805 (They stay Grey, just like with other Dicom viewers :-(
1807 2003-10-30 Jean-Pierre Roux
1808 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1810 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1811 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1812 being coherents dicom files.
1814 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1815 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1817 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1818 * ENH: Two steps is necessary to please VC++ compiler...
1819 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1820 * ENH: Add include dir to medcon lib
1821 * FIX: only one function is being exported for now !
1822 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1824 2003-10-29 Jean-Pierre Roux
1825 * adding gdcmHeader::GetLUTRGBA
1826 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1827 --> Mathieu, the modif u're waiting for is not yet committed
1828 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1830 2003-10-27 Jean-Pierre Roux
1831 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1832 00191113.dcm DermaColorLossLess.dcm
1833 MxTwinLossLess.dcm RadBWLossLess.dcm
1834 * ENH: For version prior to vtkImageViewer2 -r 1.19
1835 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1837 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1838 * Removal of ido stuff in CMakeLists.txt
1840 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1842 * FIX: remove a call to ->Modified ... see comments
1843 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1845 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * FIX: Problem with path for libvtkgdcmPython
1847 * ENH: Try adding a search script for python site-package
1848 * RMV: Remove some file from medcon lib that are not necessary
1849 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1850 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1851 * FIX: More pragma disable fro VC++,
1852 I don't think I break something as it is also disable in VTK/ITK.
1853 But it fasten debug compilation time.
1855 2003-10-23 Jean-Pierre Roux
1856 * gdcm now deals with 16 Bits Run Length Encoded images
1857 (they are compressed as 2 planes images,
1858 one for the high Bytes, the other for low Bytes)
1860 2003-10-22 Jean-Pierre Roux
1861 * Now CheckRead takes into account :
1862 - the bugged 'Leonardo' Siemens images
1863 - the XA images, sent thru the burning VPRO station
1864 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1867 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1868 * FIX: When copying a Makefile.am to CMakeLists.txt
1869 one should remove the '\'
1871 2003-10-22 Jean-Pierre Roux
1872 * in gdcmData adding a bugged 'Leonardo' Siemens image
1873 (wrong lengths in header)
1874 OK with gdcm, KO with the other viewers :-)
1875 * add a GE dlx XA image, thru the VEPRO burning station
1878 2003-10-21 Jean-Pierre Roux
1879 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1880 for a brutal checking of vtkgdcmViewer compliance
1882 2003-10-21 Jean-Pierre Roux
1883 * add the files for 'xmedcon' Jpeg Lossless library
1884 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1886 2003-10-21 Jean-Pierre Roux
1887 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1889 2003-10-21 Jean-Pierre Roux
1890 * garbage Siemens 'Leonardo' images dealt with
1891 (the patch is easy to remove)
1892 * cosmetic changes to avoid warnings
1894 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1896 no need to press 'r' now.
1898 2003-10-20 Jean-Pierre Roux
1899 * upgrade of checkRead.sh checkWrite.sh according
1900 to new Jpeg Lossless decompressor
1901 * add US.3405.1.dcm, a genuine RGB medical file ...
1902 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1903 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1905 2003-10-15 Jean-Pierre Roux
1906 * general anonymisation in gdcmData
1907 * adding the 'color files' from
1908 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1909 * adding some well knowed bugged-header images
1910 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1911 waiting for their inclusion in Python testsuite
1913 2003-10-15 Jean-Pierre Roux
1914 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1915 no longer seg faults when file is not found
1917 2003-10-14 Jean-Pierre Roux
1918 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1921 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * TODO: *.in file to genereate a UseGDCM later
1924 2003-10-14 Jean-Pierre Roux
1925 * Some supposed-to-be Dicom Images have no preamble.
1926 OpenFile takes it into account
1927 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1928 * Missing elements added in dicomV3.dic
1929 (just to be affraid : have a look at
1930 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1931 and do it again next year ;->
1933 2003-10-13 Jean-Pierre Roux
1934 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1935 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1936 But there are NOT. It's fixed !
1938 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1939 * FIX: "jpeglib.h" was not found on VC++
1940 * FIX: vtkgdcm was not being installed
1942 2003-10-10 Jean-Pierre Roux
1943 * ENH : OpenFile closes the file if it *really* doesn't look like
1944 an ACR-NEMA / DICOM one.
1945 * FIX : testWrite no longer writes an empty file if the source file
1946 is not gdcm Readable
1947 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1950 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1951 * FIX: CMake generate now documentation
1952 * ENH: out of source doc build !
1953 * ENH: Generate both user and dev documentation
1954 * ENH: Should work on windows too
1955 * ENH: Only one doxygen config.in file is needed
1956 * FIX: make install should be ok now on ùnix plateform
1957 * FIX: PATH to dictionary was wrong (missing /)
1958 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1960 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1961 * vtkGdcmReader is now able to read rgb dicom file.
1962 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1963 * added a gdcmViewer to vtk test, use mouse to control
1964 window level & window width
1966 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1967 * CMake-ification of gdcm, we have now two build system
1968 * FIX: on cygwin Wsock32 doesn't exist
1969 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1971 2003-10-06 Emanuel Ollart
1972 * FIX : compilation process wad broken.
1973 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1975 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1976 * change gdcmViewer -> vtkgdcmViewer
1977 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1979 2003-10-06 Jean-Pierre Roux
1980 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1981 ( e.g : well known GE images with a wrong elem length,
1982 : Philips MRI Images with a wrong Huffman table)
1983 * still to be done : allow the reading of bugged LEONARDO Siemens images
1985 2003-10-03 Jean-Pierre Roux
1986 * Odd length strings are padded with '\0' (not with spaces,
1987 to remain compliant with already defined strings,
1988 like Transfert Syntax UID and others)
1990 2003-10-03 Jean-Pierre Roux
1991 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1992 to allow displaying RGB images (not only by affim ;-)
1994 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1995 * vtkGdcmReader is now able to read rgb dicom file.
1996 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1998 2003-10-03 Jean-Pierre Roux
1999 * A few nasty patches to allow the reading of a lot of nasty images
2000 ( e.g : well known GE images with a wrong elem length,
2001 : Philips MRI Images with a wrong Huffman table)
2002 * still to be done : allow the reading of bugged LEONARDO Siemens images
2004 2003-10-03 Jean-Pierre Roux
2005 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2007 2003-10-03 Jean-Pierre Roux
2008 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2009 to allow displaying RGB images (not only by affim ;-)
2011 2003-10-03 Jean-Pierre Roux
2012 * gdcmFile::GetImageDataIntoVector now
2013 - deals with MultiFrames MultiFragments Run Length Encoded files
2014 - deals with YcBcR (YBR_FULL) files
2015 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2016 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2018 (no sample found :-(
2020 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2021 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2022 Two reasons: - clear things
2023 - third parties acces gdcm through header files, so won't
2024 suffer anymore VC++ complains
2026 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * add argv[1] in testvtkGdcmReader.cxx
2030 2003-09-24 Jean-Pierre Roux
2031 * The lines are now eigthy characters long.for
2032 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2034 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2035 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2036 char* to std::string. Thus, the use of strdup becomes useless. (see
2037 previous commis of Malaterre)
2038 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2039 before the last Malaterre's commit.
2041 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2042 * This commit should fix the Debug building under VC++, the problem
2043 was mainly a mixture of debug and release lib being loaded at startup.
2044 * I also remove a depency to a specific C function: strdup. Because I had
2045 to force the link to msvcrtd (whereas strdup is in libc).
2047 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2048 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2049 located in the gdcmCommon.h file. All use of reference of tha has been
2050 changed to now use the variable GDCM_UNFOUND.
2052 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2054 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2055 Dicom dictionary. The test suite can now be run again. Note:
2056 I'm note very happy with the " (RET)" changes. I believe this
2057 RETAINED comment should be dropped when parsing the dictionary.
2058 - PACKAGER corrected
2060 - AUTHORS updated and now in alphabetical order
2061 * Makefile.am now exports gdcm.dsw for Windoze users.
2063 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2064 * cygwin complains about missing std:: in subdir Test/
2066 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * remove some methods that are now in gdcmHeaderHelper
2069 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2070 * vtkGdcmReader set spacing and origin correctly
2072 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2073 * Fix a few delete/delete[] mismatch
2075 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2076 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2077 interpretation to data given by gdcmHeader. For instance there are
2078 heuristics to get informations (look at different places).
2079 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2080 sorting DICOM images based on different strategies.
2081 * modified Makefiles accordingly.
2083 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2084 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2085 when building in debug mode
2086 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2087 src/win32/gdcmdll.dsp
2088 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2090 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2091 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2094 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2095 * src/win32/libgdcmjpeg12.dsp was not dos format
2096 * src/win32/libgdcmjpeg12.dsp :
2097 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2098 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2100 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2101 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2103 * src/gdcmFile.cxx : bug fix in affectation type
2104 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2105 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2106 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2107 symbols... future problem ?
2109 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2110 * src/win32/libgdcmijpeg12.dsp was missing
2111 * modified gdcm.dsw accordingly
2113 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2114 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2116 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2117 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2118 commit of JPR (before his hollidays to facilitate our work).
2119 * setup.py : bug fix in code. Modifications made while the last commit
2120 of JPR. The code hasn't been tested before the commit... it's so
2121 useless to make that (for best programmer that is JPR) !!!
2123 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2124 * tagged the current version as Version0_3 (i.e. version 0.3)
2126 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2127 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2128 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2129 * *.dsp : modifications to use new libgdcmijpeg8 library
2130 * setup.py : bug fix on VTKPATH variable
2131 * PACKAGER : adding all concerning windows
2133 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2136 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2137 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2138 test suite reported error.
2139 * PACKAGER file added (describes what a packager must do when
2140 packaging a new release).
2141 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2142 * configure.in: upgraded version number to 0.3.0
2143 * fixing build of rpm (through rpm -ta):
2144 - Doc/Makefile.am exports proper doxygen files
2145 - src/jpeg/libijg8/Makefile.am exports the include files.
2147 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2148 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2149 * src/gdcmHeader.h : formatting code
2151 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2152 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2153 We were obtaining error message from vtk. Now, creation of file list
2154 is made in an internal list to prevent this problem.
2155 Bug fix when output is empty.
2156 Bug fix in update of progress value. Previous commit for this was a bad
2158 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2160 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2161 * src/gdcmHeader.h : added method to get the file name
2162 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2163 files. Added method to remove all files on the input
2164 Added FIXME comment concerning the bad parsing of header made by
2165 ExecuteInformation method (in ExecuteData method)
2167 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2168 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2169 when using make instal.
2170 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2171 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2173 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2174 * setup.py : adding include dir of jpeg lib to compile all sources
2175 * */Win32/*.dsp : JPR fix for windows compilation
2177 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2178 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2180 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2181 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2183 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2184 * setup.py is again effective on un*x (takes into account the
2185 addon of the jpeg library)
2186 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2187 * Doc/Doxy* updated (includes above enhancements)
2188 * INSTALL now points to web documentation
2190 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2191 * src/gdcmHeader.h doesn't make unnecessary reference to
2193 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2195 * src/gdcm*.[cxx|h] :
2196 - to allow compilation with gcc 3.x
2197 -- clean up of STL usage (added explicit usage of std::)
2198 -- small fixes on exceptions.
2199 Note: linking not tested !
2200 - clean of doxygen comments to avoid warnings at documentation
2202 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2203 dependent convertion).
2205 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2206 * Clean up of previous JPR garbage commit (not even commented in the
2208 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2209 - moved all jpeg related files from src to src/jpeg/libijg8, with
2210 addition/modification of Makefile.am and configure.in.
2211 - the testSuite is still brain damage (not guilty).
2213 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2214 * WrapVTK.py : modifications to get correctly vtk source files to
2216 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2217 (FileName -> Filename)
2219 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2220 * vtk/vtkGdcmReader.[cxx/h]:
2221 - UpdateProgress method should now be effective
2222 - removed the limitation on having only images loaded (as opposed
2224 - when building a stack of images/volume, a lesser number of
2225 gdcmHeader and gdcmFile instances should be used (hopefully
2226 accelerating things).
2227 - when building a stack of images/volumes, files which are not
2228 loadable (wrong path-filename, wrong permissions on existing file,
2229 or file not parsable by gdcm) are replaced with a black image
2230 in the stack (for the caller to notice the problem).
2232 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2233 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2235 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2236 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2237 between standard library (std) and vtk library (problems are found
2238 under Windows... thanks Windows !)
2240 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2241 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2243 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2245 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2246 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2248 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2249 * When compiling with distutils (see setup.py) the C++ compiler is
2250 called with different flags than the default ones (with automake).
2251 In order to fix all those warning, I compiled gdcm with the command
2252 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2253 and went for warning fixes:
2254 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2255 up from unused variables.
2256 - vtk/vtkGdcmReader.cxx: potential bug fix.
2257 * src/gdcmHeader.h: Doxygen warning cleanup
2259 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * gdcmPython/gdcm.i:
2261 - typemaps correction to take into account the systematic replacement
2262 of "using namespace std" with std:: prefix e.g. std::list,
2263 std::string... (cf changes of 2003-05-21).
2264 - gdcmGlob global variable of type gdcmGlobal (defined in
2265 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2266 exported to Python a as cvar.
2267 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2268 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2269 gdcmDictSet.GetPubDictTagNames() and
2270 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2271 C++ static methods).
2272 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2273 with the above changes.
2275 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2276 * setup.py, manifest.in : bug fix under linux
2278 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2279 * Modification of setup.py to compile vtk part too. Then, we have 2
2280 wrappers which must work with same distutils. For that, we have a
2281 generic distutils in distusiltsWrapping.py ; with :
2282 - build_extWrap class to wrap generically all extensions,
2283 - ExtensionWrap base class for all wrapping extension that contains
2285 - Wrapper interface which wrap sources
2286 + In WrapSwig.py we have extension and wrapper for Swig
2287 + In WrapVTK.py we have extension and wrapper for VTK
2288 * MANIFEST.in : modifications to consider vtk directory and new python
2289 files for compilation
2291 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2292 * Added python wrappers of vtkGdcmReader vtk class (see the
2293 source in vtk/vtkGdcmReader.cxx) :
2294 - vtk/Makefile.am now builds a library
2295 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2296 python library (as opposed to _gdcm.so wich are the python
2297 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2298 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2300 - configure.in has an additional flag --enable-vtk that needs
2301 to be set to enable compilation of vtk related code, that is:
2302 + vtk/vtkGdcmReader.so and
2303 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2304 + gdcmPython/vtkgdcmPython.so (see above)
2305 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2306 be read when compressed or when HighBit + 1 != BitsStored),
2307 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2308 the usage of the python wrapper of vtkGdcmReader vtk class.
2309 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2310 * src/*.[h] all occurences of stl classes are now prefixed with
2311 std::, and all occurences of "using namespace std;" where removed.
2312 This is to avoid pollution of global namespace in included files.
2313 Apparently vtk does not avoid this pitfall: when using both
2314 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2315 collision of various stl members (principally cout...).
2316 * gdcmPython/testSuite.py now cleanly removes temprory generated
2318 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2319 comply with above changes)
2321 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2322 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2323 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2324 vtk data structure (an image Flip was required).
2325 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2326 * cosmetic changes in documentation.
2328 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2329 * src/gdcmHeader.cxx: the constructor no longer exits when an
2330 unexisting file is given as argument.
2331 * The subdirectory Data (containing all the images used for the
2332 test suite) is not part of this repository anymore. A new module
2333 containing those images is now available at
2334 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2335 with the name gdcmData.
2336 All the python scripts (including the package initialisation file
2337 gdcmPython/__init__.py) were adapated to take this change into
2338 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2340 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2341 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2342 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2343 demo of the usage of this class.
2344 Compilation of this vtk part is only done when using the --enable-vtk
2345 at configure (or autogen.sh) stage.
2347 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2348 * More memory link related corrections and documentation fixes.
2350 - maximum info is obtained with a command of the form:
2351 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2352 --show-reachable=yes PrintHeader
2353 - the remaining reachable blocks seem to come from the STL
2354 allocation scheme through the usage of map and list. It looks
2355 like this memory cannot be freed but it is not a memory leak
2356 (in fact further invocation to the STL would recollect the
2357 unused memory allthough it cannot explicitely be freed).
2358 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2359 of displaying an image parsed with gdcm and displayed with VTK.
2360 Note: some images don't seem to work e.g.
2361 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2362 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2363 Allthough this weakens the semantics, it is a ditch attempt to
2364 make gdcm more thread friendly.
2366 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2367 * Memory link hunt (by using valgrind through the command
2368 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2369 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2370 gdcmHeader::_dicom_vr.
2371 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2372 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2374 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2376 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2377 * src/Makefile.am now exports all the necessary include files at
2381 * UpdateGroupLength replaced by new one
2384 * UpdateGroupLength re-written using H-Table
2385 (named UpdateGroupLengthNew untill checks are over)
2387 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2388 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2389 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2391 - gdcmHeader::GetPubElValSet removed.
2392 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2393 UpdateGroupLength, WriteElements, Write.
2394 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2395 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2396 carried the same semantics.
2397 - src/gdcmHeaderIdo.cxx changed accordingly.
2398 - gdcmFile::WriteBase now regroups all the codes from previous
2399 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2400 - enum FileType moved to gdcmCommon.h
2401 * src/gdcmHeader.cxx AddDefault trashed
2402 * gdcmGetXSize added
2403 * getimageDataSize now calls gdcmGetXSize
2404 * Test/*.cxx changed to agree with above changes
2406 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2407 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2408 (to avoid double call by end user).
2409 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2410 by end user, since gdcmHeader::gdcmHeader now handles it.
2412 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2413 * gdcm/Doc many doxygen changes:
2414 - Doxyfile now has two different versions, DoxyfileUsers that generates
2415 the html.users end users oriented documentation and
2416 DoxyfileDeveloppers that generates the html.developper developper
2417 oriented documentation.
2418 - README changed accordingly
2419 - requirement.txt removed (old design info moved to TODO).
2420 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2421 DoxyMainPage.txt, DoxyPython.txt provide more information.
2422 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2423 be updated by simply regenerating the docs with doxygen and copying
2424 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2425 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2426 all the tests in the form "if (<map>.count() >1)" were removed.
2427 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2428 ill-formed documentation sections.
2429 * src/gdcmHeader.cxx: ditto
2431 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2432 * setup.py fixed for un*x (needed macro for stdint.h)
2433 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2434 un*ces with sh-utils test utility.
2435 * gdcmPython/demo/test.py renamed to PrintHeader.py
2436 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2437 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2438 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2439 * src/gdcm*.cxx JPR's bad inclusion fixed.
2441 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2442 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2443 * gdcmPython/demo/test.py changed accordingly.
2445 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2446 * gdcmPython/Makefile.am fixed linking against libstdc++
2447 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2448 * Swig subdir (historical tests of swig version 1.3.17++) removed
2449 * Test/testChangeEntete.cxx some lines commented out in order to make
2451 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2452 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2454 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2455 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2456 hence the user doesn't need this explicit call.
2457 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2458 i.e. LoadElements() call removed.
2459 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2460 - src/Makefile.am declares the proper flag for g++.
2461 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2462 for adding user defined new tags.
2463 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2464 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2465 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2467 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2468 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2469 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2470 src/Makefile.am : the project should properly compile and install
2471 with the autotools, included the python wrappers part.
2472 * gdcm.spec.in : added a spec file for RPM packaging.
2474 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2475 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2477 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2478 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2479 to exported to the environement (see gdcmPython/testSuite.py
2481 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2482 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2483 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2484 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2485 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2487 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2488 * gdcmPython/__init__.py doesn't crash anymore when running in
2489 in InstallMode or PreInstallMode but with an environement given
2490 value of GDCM_DICT_PATH.
2491 * src/gdcmDictSet.[cxx/h] coding style.
2493 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2494 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2495 * src/gdcm.h general comments moved to TODO, and README
2496 * src/gdcm.h should now be seen as a user commodity (including it
2497 should suffice to fully use gdcm). It is nowhere including within
2498 any of the kernel files src/*.cxx and src/*.h.
2500 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2501 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2502 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2504 * src/gdcm*.cxx only include their corresponding include file
2505 (as opposed to gdcm.h)
2506 * gdcmPython/gdcm.i changed accordingly
2507 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2508 the autogen.sh generated "make snapshot" command to work.
2509 * autogen.sh removed history related references to crea package.
2511 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2512 * distutilsSwigCPlusPlus.py work around some swig portability
2515 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2516 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2517 was done in a last ditch attempt to get setup.py _really_
2518 operationnal. The python/gdcmPython layaout add the advantage
2519 of hidding away the python related distutils specific files
2520 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2521 Alas, the src directory was out of scope (i.e. it's relative
2522 position to setup.py was ../src) which made things impossible to
2523 handle (see previous version of python/setup.py). Crossing fingers...
2525 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2526 * python/setup.py now works on Un*x. (harder than I thougth)
2527 * python/distutilsSwigCPlusPlus.py can now have include files
2528 among the list of sources.
2530 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2531 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2532 * modifications in MSVC projects
2534 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2535 * As stated by the first lines of Test/ExceptionAndPython/README, it
2536 looks like we can move back to original usage of exception within
2537 src/gdcm* and hence remove the errno stuff that was introduced
2538 as a quick and dirty fixture of this problem (added to the TODO).
2539 * Doc/Doxyfile configuration file for Doxygen and corresponding
2540 README file for usage added.
2541 * Test/testWrite.cxx added. This new test comes from a split of
2542 test.cxx that is now reverted to its original purpous i.e.
2543 testing the proper parsing of a Dicom related file.
2544 testWrite.cxx concentrates on testing the IO part of gdcm.
2545 * Test/bug1.cxx (containing a bug on WIn32) added.
2546 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2547 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2548 whose purpose is to publish the content of the TagNames of the
2549 Dicom public dictionnary were not accessible without an
2550 instance of class gdcmHeader.
2551 - those methods are now static methods of gdcmDictSet and hence
2552 require no instances at all to be invocated.
2553 - within gdcmDictSet this change required to change some method
2554 to class methods (i.e. are now static) among which SetDictPath
2555 (renamed to BuildDictPath) and LoadDefaultPubDict.
2556 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2557 the above changes by calling the new method classes of gdcmDictSet.
2558 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2559 the above to be effective.
2560 * python/gdcmPython: in order to wrap properly the above changes
2561 for Python, swig version now needs to be > 1.3.17.
2562 * python/gdcmPython/Makefile fixed to adapt itself to new
2563 configure/make shema introduced by Johan Montagnat (thanks for the
2564 contribution). Alas this Makefile cannot be turned into a proper
2565 Makefile.am without some heavy changes in the configure.in
2566 (for python dectection).
2567 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2568 now avoids publishing the empty entries.
2570 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2571 * python/setup.py : bug fix concerning install under windows
2572 ExtraPath reused :-P
2573 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2575 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2576 * Dicts/dicomV3.dic : remove double spaces !!!
2577 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2578 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2581 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2582 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2583 method. Doxygenation.
2584 * src/gdcm.h clean up of JPR spurious comments.
2586 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2587 * python/distutilsSwigCPlusPlus.py now properly collects the
2588 shadow classes generated by "swig -c++" (gdcm.py in our case)
2589 when using "python setup.py install".
2590 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2591 reexports the working classes.
2592 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2593 by the classical C errno scheme. This is to prevent an obscure
2594 behavior of the python wrappers when importing wxPython.wx prior
2595 to gdcmPython (which ended up in an abort call). An illustration
2596 of this oddity can be found in the Test/ExceptionAndPython
2597 subdir (see the README file). This problem probably due to
2598 an combination of g++ and dynamic loading.
2599 * added Test/ExceptionAndPython (see above)
2601 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * Changed the layout of the python part to avoid bloating main
2603 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2604 i.e. the distutils arsenal. All the python related stuff is
2605 again in a python subdir, but the package itself is now in
2607 * setup.py was cleaned up:
2608 - pythonIncludePath removed
2609 - python setup.py bdist target is now functional.
2610 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2611 collision with other packages). gdcmPython/demo/*.py changed
2614 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2615 * python subdir moved to gdcmPython (preparation of distutils packaging).
2616 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2617 distutils installer is operational.
2618 * - gdcmPython/__init__.py now properly loads the swig generated
2619 shadow classes (from gdcm.py).
2620 - gdcmPython/demo/*.py changed to import the package gdcmPython
2621 instead of gdcmPython/demo/load.py.
2622 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2624 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2625 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2626 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2627 entries within the associated public Dicom dictionary resp. the same
2628 information but sorted by the fourth field (PAT, IMG, DIR) of the
2630 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2631 are now in the "???" group.
2632 - python/gdcm.i changed accordingly,
2633 - python/demo/printGroupedPublicDict.py added, that gives an example
2634 of the above new functionalities in Python.
2636 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2637 * src/gdcm.h, gdcmHeader.cxx:
2638 - historic references to glib's g_malloc and g_free (#defined)
2639 were definitively removed.
2640 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2641 * src/gdcmElValSet.cxx:
2642 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2643 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2644 - GetElValue(string) renamed to GetElValueByName.
2645 - Added GetElementByName(string).
2646 * src/gdcmHeader.cxx: added
2647 - GetPubElValRepByNumber(guint16, guint16)
2648 - GetPubElValRepByName(string)
2649 - GetShaElValRepByNumber(guint16, guint16)
2650 - GetShaElValRepByName(string)
2651 - GetShaElValByNumber(guint16, guint16)
2652 - GetShaElValRepByName(string)
2653 - GetElValRepByNumber(guint16, guint16)
2654 - GetElValRepByName(string)
2655 - GetElValByNumber(guint16, guint16)
2656 - GetElValRepByName(string)
2657 * Doc/requirements.txt added.
2659 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2660 * Test/Makefile building now depends on the one of libgdcm.so
2661 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2662 pixel data) aware which enables finding the address (offset) of
2663 the pixel data of JPEG encoded DICOM files. This leaves only a single
2664 file in the testSuite whose pixel data address (offset) is unknown.
2665 * python/testSuite.py changed accordingly.
2667 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2668 * VC++ has some strong limitations when working with the STL, as stated
2669 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2670 "Also note that some STL containers (map, set, queue, list, deque)
2671 cannot be exported. [...]
2672 Some STL classes contain nested classes. These classes can not
2674 This is caused by a designed limitation that once a template
2675 class is instantiated, it can not be re-instantiated and
2677 Since our usage of map<> is ubiquitous in gdcm, this "designed
2678 limitation" of VC++ is a pitfall.
2679 Hence the Python wrappers of gdcm cannot be incrementally linked
2680 against the c++ dynamic library. The dirty but only workaround is
2681 to forget about incremental link of dynamic libraries and to generate
2682 the Python wrappers library with the inclusions of the underlying C++
2684 The following modifications concern this matter on Win32/VC++:
2685 - wrapping python correct with standalone wrapped dll (don't use separate
2686 dll under windows !!!!)
2687 - python21_d debug mode enabled (ask Frog how to use it :-)
2688 - NO problem with having an STL member of class for example string in C++
2689 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2690 - Python test of dcmlib in Python is ok under windows on a large set
2692 * removed glib references
2693 * typedef's inserted in gdcm.i for correct swig type management
2695 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2696 * python/demo/*.py load.py extracted from test.py. Added explore.py
2697 that only displays required tags and testAll.py that parses all
2698 the files of the testsuite without using unittest.
2699 * python/testSuite.py other additional test on new files added.
2700 * Data/* new test files added accordingly to the testSuite.
2701 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2702 the vr in the file differs from the one of the dictionary.
2704 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2706 values, but limits itself to values which are below a user specified
2707 size (by default 1024 bytes).
2708 * python/gdcm.i : elements not loaded (because their size is above the
2709 user specified treshold) are exported with their TagKey as key of the
2710 python dictionary. This enables the testsuite to make some checks
2711 on the unloaded elements (since we have their offset and size).
2712 * python/testSuite.py
2713 - now tests for the existence and proper value of the pixel data
2714 - two new examples added.
2715 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2717 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2719 aware. See the strategy comments in gdcmHeader::FindeLength().
2720 * Test/test.cxx now accepts a filename as first argument.
2721 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2722 * python/testSuite.py changed to integrate test on above files.
2724 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2725 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2726 the vr was also RET.
2727 * python/testSuite.py more tests added.
2729 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2730 * python/testSuite.py unittest test suite added (uses Data)
2731 * Data/* dcm and acr files for the test suite.
2732 * glib dependance removed from un*x version. We now use ISO C99
2733 7.18 Integer types (see stdint.h)
2734 - python/Makefile, src/Makefile src/gdcm.h
2735 * src/ when an explicit vr (like dicom files) suddenly poped an
2736 implicit element we use to mark the underlying DictEntry of the
2737 concerned ElValue with "Implicit". This strategy was damageable
2738 too the public or provite dictionaries, since some of their vr
2739 would be changed. Since Header::FindLength heavily relies on the
2740 detection by Header::FindVR of falsely explicit elements, I
2741 added an extra ImplicitVr member to ElValue (boolean).
2742 The rest of the changes we the necessary adaptations.
2744 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2745 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2747 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2749 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2750 * Adaptation for porting to VC++:
2752 o forced to use std namespace (for string to be known)
2753 o all class use __declspec export style on WIN32
2754 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2755 (in stdlib.h on Win32 but in std:: for gcc)
2756 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2757 variable GDCM_DICT_PATH.
2758 * src/gdcmHeader.cxx verbose comments made discrete.
2760 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2761 * python/gdcm.i: added a typemap that converts a C++ hashing table
2762 to native Python dictionary.
2763 * python/demo/test.py:
2764 - now uses the native dictionary for exploration of gdcmHeader.
2765 - takes an optional filename argument (the file to parse).
2766 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2767 PubElVals hashing table.
2768 * Dicts/dicomV3.dic removed error prone trailing spaces.
2770 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2771 * Python wrapping process moved away from src/Makefile to
2772 newly created python/Makefile (as well as gdcm.i)
2773 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2774 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2775 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2776 from the environement variable GDCM_DICT_PATH (when existing).
2777 * src/gdcmDict::GetTag bug fix.
2779 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2780 * Straightforward temporary fixes for swig to build the python wrappers.
2781 src/Makefile now has a python working entry [by working we mean
2782 that we can import de shadow classes without errors].
2784 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2785 * hashtest.cxx removed (since allready in Test)
2786 * src/gdcmlib.h renamed to src/gdcm.h
2787 * src/dcm.i renamed to src/gdcm.i
2788 * src/Makefile prepared for python wrapping
2790 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2791 * src/gdcmHeader.cxx :
2792 - Parsing of header is now separated from loading of element values
2793 (see gdcmHeader::LoadElements).
2794 - general clean up of hopefully all file access (creation of
2795 ReadInt16 and ReadInt32)
2797 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2798 * src/gdcmHeader.cxx :
2799 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2801 - SetLgrElem renamed to SetLength
2802 - GetLgrElem renamed to GetLength
2803 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2804 * src/gdcmElValSet.cxx fixed both GetElValue methods
2805 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2806 due to IdoDude was cleaned out.
2808 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2809 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2810 concentrates on finding the value representation (when it exists).
2811 RecupLgr now only finds the element value length, and it avoids
2812 returning the unecessary skL (skipped length).
2813 Also, offsetCourant was simply removed (with taille_fich) since
2814 it was redundant with the File position internals (by using
2815 ftell and fseek). This also made skL (see above in RecupLgr) usage
2817 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2818 on the libido specificities which are handled through class
2820 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2823 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2824 * Truckload of changes. Parsing of header is barely functional
2825 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2827 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2828 * src/gdcmHeader.cxx many addons of low level methods
2830 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2831 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2832 and _IdDcmSWAP_LONG.
2834 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2835 * This corresponds to all the changes decided at the meeting of
2836 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob