1 2005-01-07 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
2 * Removal of useless and dangerous methods :
3 GetEntryByName, GetEntryVRByName, GetDocEntryByName, SetEntryByName
4 GetDocEntryByName, GetEntryByName, GetDictEntryByName
5 * Removal of usless methods :
6 Dict::PrintByName, Dict::GetDictEntryByName
7 * Commenting out of probabely useless methods :
8 Dict::GetDictEntryNames()
9 Dict::GetDictEntryNamesByCategory()
10 DictSet::GetPubDictEntryNames()
11 DictSet::GetPubDictEntryNamesByCategory()
12 * ENH : New Dicom Dictionnary (with Value Multiplicity) is now used
13 * ENH : Use dicomTS.dic as described in 2004 version
14 * ENH : Removal out of the Dicom Dictionary of non dicom 'fourth' field
15 Add to the Dicom Dictionary of Dicom 'Value Multiplicity' field
16 Add Accessors on VM (Value Multiplicity), and VM related methods
17 * ADD : Add a list of 'Dicom Attribute types', as found in
18 http://medical.nema.org/dicom/2004/04_15PU.PDF
20 * ADD : Add dicomGroupNameAbbreviations.dic
21 should be used to write a method to replace the former
22 Dict::GetDictEntryNamesByCategory()
24 2005-01-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/gdcmDocEntry.[h|cxx] : now the ReadLength is the length of the data
26 to read in the file... and only it ! Length is the efective length of the
27 data in the DocEntry structure
29 2005-01-07 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
30 * Change the gdcmDebug approach. Remov the global static debug 'dbg'.
31 And now use a static function call instead, with a global variable. i
32 This is much closer to the VTK approach. Hopefully should be bulletproof
33 and easier to use...hopefully
35 2005-01-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
36 * Adding GetMACAddres very alpha for now. This is tricky to be cross plateform.
38 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
39 * src/gdcmDocument.[h|cxx] : remove all copy of DocEntry when parsing a file
41 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
42 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
43 ValEntry, BinEntry, SeqEntry creation or replace
45 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
47 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
49 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
50 when specifying the VR
51 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
52 * src/gdcmDocEntry.cxx : amelioration of print
54 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr>
55 * ADD : Add the method Util::IsCurrentProcessorBigEndian
56 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
57 * ADD Method Document::ComputeGroupLength
58 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
59 in order to allow further VR modification by user
60 * REM : removal of once-called method File::WriteBase
61 integration of its code in formerly one-line method File::Write
63 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
64 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
65 replace the different values "??", "Unkn", "Unknown".
66 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
67 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
68 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
69 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
71 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
72 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
74 * Set the gdcm::Base class to some Printable classes
76 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
77 * src/gdcmFile.[h|cxx] : add the Print method
78 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
79 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
80 * src/gdcmDocument.h : remove the PrintLevel informations
81 * Example/PrintFile.cxx : use the new gdcm::File::Print
83 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
84 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
85 problems when compiling with the python wrapping
87 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
88 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
89 writting in ImplicitVR
91 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
92 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
93 JPEG decompression, especially when dicom frames are split into several
94 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
95 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
97 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
98 * src/gdcmHeader.cxx : change the initialisation of default header.
99 Now, this header is readable by gdm, e-film, DicomWorks
101 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
102 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
103 Rename Decompressed to Raw
104 * Use the API changes in gdcm::File.
105 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
108 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
109 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
110 each added entry in the header. Replace the 'Planes' field by the 'Number
113 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
114 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
115 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
117 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
118 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
119 At this time, this image isn't readable by e-film... waiting JPR help to
122 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
124 DocEntry. Now use methods of the Document !
126 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * Test/ShowDicomSeq.cxx : bug fix
129 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
130 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
131 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
132 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
133 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
135 * Test/TestCopyRescaleDicom.cxx : remove unused variable
136 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
137 containing found sequences
139 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
140 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
142 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
143 Some fields in BinEntry must be copied to not seg fault when making the :
144 gdcm::File *copy = new gdcm::File( copyH );
145 and tests are now made on good variables
147 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
148 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
149 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
151 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
152 * Add vtkGdcmWriter example and test
154 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
155 * Test/TestUtil.cxx : reformat the source code
156 * vtk/vtkGdcmReader.cxx : remove and change prints
157 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
159 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
160 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
162 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
164 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
166 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
167 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
168 by an eof to prevent all bad read of the file... and in this case, the
171 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
172 * Example/Volume2Dicom.cxx : comment unused variables
173 * Test/PrintDicomDir.cxx : comment unused variables
174 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
175 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
176 method that is redondant with AddEntry.
177 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
180 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * Bug fix due my last commit (compilation under Windows).
182 * Example/Volume2Dicom : bug fix in the file and reformatting source code
183 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
185 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
187 - Remove printf / sprintf
188 - include iostream AFTER gdcm so we don't get warnings
189 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
191 - Also remove tons of include from header files, hopefully this should
192 speeup the compilation time, since it was becoming a dog slow.
193 - Remove gdcm.h as it include way too many files and slow down compilation
194 (plus it is not up to date)
195 - remove 'using namespace std' this is BAD !
197 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * Remove memory leaks on the DicomDir
199 * Remove some useless datas in DicomDirObject
200 * Add usefull methods in SQItem, to be complient withe the ElementSet
202 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
203 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
205 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
206 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
207 future, with convertion)
208 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
209 and ImageDataSize values. Remove the method to get the PixelReadConverter
210 from the output of the class
212 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
213 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
215 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
217 and vtkErrorMacro use.
218 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
220 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
221 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
223 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
224 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
225 The string leaves only in the fonction. So when we make a .c_str(), we
226 get the pointeur on the first element, element that will be destroyed
227 immediately after thee instruction.
228 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
229 file has been opened : the test must be made on the content of the
230 pointer and not directly on the pointer !
233 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
235 the python part recompiles
237 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
238 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
239 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
240 X session is killed (for my computer... it seems to not be identic on
243 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
244 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
245 avoid problems (otherwise, the difference test between the visible image
246 and the reference is incorrect. If the reference is greater than the
247 screen resolution, it's produce errors).
248 Can be used for only one image. Can be used with a visible flag.
249 * vtk/vtkGdcmReader.cxx : remove commented codes.
250 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
251 under windows at compilation
252 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
254 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
256 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
257 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
258 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
259 tests on the image size X, Y, Z
261 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
262 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
263 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
264 between the class name and the file name
266 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
267 * src/ : fix compilation warnings for the Write method (2 different
268 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
269 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
270 variable... create a static method in gdcm::Document to access to
271 this variable content.
273 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
274 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
275 file, to be accessed by other files (like gdcmFile). Remove commented
276 code. Move the change of the header to the gdcmFile, using the
278 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
279 To be sure of that (and simplify calls), the Write of the header now
280 gets a file name and not a file pointer (std::ifstream).
281 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
282 DocEntryArchive. Remove all open of the written file
284 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
285 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
287 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
288 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
289 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
291 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
292 some corresponding methods. Write correctly the file and check before
294 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
295 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
296 is now on RGB datas (as before my last commit
297 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
299 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
300 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
301 Add a print information of the type of the entry
302 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
303 It was in the gdcmFile, and all write have been regrouped
304 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
305 Write correctly all dicom files (in decompressed mode only at this time)
306 * Test/ : test on files are now made using Raw datas and not color datas if
308 * Example/PrintFile.cxx : add more printings
310 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
311 * Amelioration of code, remove some code copy. For the loading of
312 BinEntry (in gdcmDocument), add the test to verify if the file is already
315 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
316 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
317 remove a DocEntry in the header (push an empty DocEntry)
318 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
319 lines. Bug fix in the initialization of the PixelConvert and the
321 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
322 use in TestCopyDicom (now this test can run under windows... but fails)
323 * Test/TestCopyDicom.cxx : amelioration of the test :
324 - test the pixels written
325 - add test points to quickly find where is the error
326 - can set a file name input and output in arguments
327 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
328 amelioration of the test output
330 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
331 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
332 all replaced DocEntry's
333 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
334 Now, each needed DocEntry to modify is duplicated, modified and inserted
335 to the header using DocEntryArchive. Thus, after save, we can restore the
336 header initial state.
338 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
339 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
341 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
342 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
343 correct to copy it. The DictEntry is specified at the DocEntry creation,
344 then, it musn't change in the time.
345 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
346 header correctly. At this time, the change is only made for the first
347 level of the Document. In the future, it might consider sequences.
348 The change is made by replacing a DocEntry by an other that is created
349 outside the class. The old value is kept. When we restore the header
350 status, the added DocEntry is deleted and replaced by the old value.
351 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
352 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
353 set the write type to explicit VR, implicit VR or ACR. Add methods to set
354 the write mode to native, decompressed or RGB (but not used at this time)
356 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
357 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
358 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
360 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
361 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
362 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
364 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
365 set because already copied when copying the BinEntry's of the header
366 * Test/TestAllReadCompareDicom.cxx : remove warnings
368 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
369 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
370 Two problems appear when doing it :
371 - with the gdcmFile : when the GetImageData method is called, the pixels
372 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
373 datas (pixels). And each structure destruct the datas when it's
374 destructed. So we have two destructions for the same datas. To solve it,
375 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
376 datas or not. If it doesn't own datas, then they will not destroyed by
378 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
379 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
380 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
381 create a double destruction of the same DocEntry's. So, to solve it,
382 the TagHT is simply cleared and the DicomDir* elements are destroyed.
383 * TODO : add an entry concerning memory leaks in the DicomDir
385 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
386 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
387 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
390 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
391 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
392 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
393 after it have been deleted
395 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
396 * FIX: src/* fix the doxygen warnings.
397 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
398 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
399 was erroneously defined with a size of 15 instead of 16. [many thanks
400 to Jean Michel Rouet for pointing out this bug].
402 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
403 1. Finish merging JMR patch for writting DICOM from scratch
404 2. Fix -hopefully- bug with MONOCHROME and space vs null character
405 3. Use const ref when possible
406 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
407 5. A few more comments
408 6. CreateUniqueUID can now be called without parameter"
410 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
411 * ENH: Slightly bigger patch:
412 1. Getting toward full integration of JMR patch for writting dicom from scratch
413 2. Update Test to test part of this patch: CreateUniqueUID
414 3. File was not close properly in gdcmDict
415 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
416 5. Use of const ref instead of copy (speed issue)
417 6. Remove temporary (duplicate) string in TranslateToKey
418 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
419 8. Do not repeat virtual in subclasses
420 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
422 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
423 * Apply first patch toward better string comparison when dealing with broken
424 DICOM files. Essentially the string could be padded with a space instead
425 of a null character as defined by standard
427 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
428 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
429 because never used... and in the same time, that's remove some memory leaks
431 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
432 * src/gdcmFile.cxx : now delete the PixelConvert instance.
433 * In examples and tests : change the type of image data variables from void*
434 to uint8_t*. Remmove all delete on image data variables
436 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
437 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
438 Verify the file pointer value before open the file, and if it's not null,
439 a verbose message is generated.
440 Close correctly the file when the file isn't considered dicom-like. The
441 correctly close is a call to CloseFile.
442 When closing the file pointer, test if its not null to close the file.
443 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
444 file. For an uncompressed image, the copied datas correspond in the least
445 case to the image size (calculated) or the image size specified in the
446 header. A verbose is generated if these two size mismatch
448 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
449 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
450 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
451 break under windows (with msvc6 compilation).
453 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
454 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
455 compiling with MSVC6)
457 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
458 * Bugs fix for the Windows build with VC6
459 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
460 needed (only for projects required VTK). If the VTK is included in all
461 projects, there is conflicts with the jpeg lib of vtk when compiling the
462 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
463 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
464 when compiling the gdcm_wrap.cxx file (created by the compilation of the
466 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
467 (like it's already made for the cout use). Otherwise, conflict with the
470 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
473 - comments on the DicomDir::Method related usage added.
474 - now that we use the namespace gdcm, a lot of internal classes do
475 NOT need to be wrapped anymore.
476 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
477 DicomDir::Method) new example added.
479 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
480 * Improve string manipulation. I now inforce the notion of 'DicomString'
481 A DicomString can contain as many \0 as they want
482 and it is *always* of even length.
483 We only support odd length for very rare case.
484 And in the near future this should be removed.
486 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
487 * /binary_write/ gdcm source. Now even on big endian we are writting
488 little endian. This should -heopfully- fix some tests
490 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
491 * Now the dictionary is compiled into gdcm lib. This is a default
492 behavior, thus any dic file specified is picked before failback to
493 the one comiled into lib
495 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
496 * Change internals for gdcmDict. Don't use any 'new' any more.
497 This should definitely solve any leak problem, and we should be
498 as fast as before, as long as don't modify too much the dictionary.
500 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
501 * STYLE: ivars should start with a capital letter.
502 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
503 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
505 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
506 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
507 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
508 new 2004 dictionaries added (thanks to JPR).
509 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
510 * CLEANUP_ROUND (15) for gdcmPixelConvert
511 - RLEFrame::NumberFragments is now of type unsigned int
512 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
513 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
516 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
517 * Initial work in gathering all transfer syntax accessors. clearly
518 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
519 ivars, but only one transfersyntax (class) ivar with equivalent method on
522 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
523 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
524 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
525 discussed (plus I didn't like having a 2000 lines patch not commited)
527 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
528 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
529 * CLEANUP_ROUND (14) for gdcmPixelConvert
530 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
531 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
532 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
534 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
535 anymore and hence avoids storing a copy of PixelConvert::Decompressed
536 into File::Pixel_Data.
538 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
539 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
540 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
541 * CLEANUP_ROUND (13) for gdcmPixelConvert
542 Substituted File::ParsePixelData() with PixelConvert::Print() new
544 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
545 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
546 method to those classes.
547 - src/gdcmFile.[cxx|h]:
548 -- Added a ::Print() method.
549 -- PixelConverter is now a reference instead of a member.
550 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
551 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
553 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
554 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
555 collaboration diagram and inheritance diagram should be generated with
557 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
558 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
559 pointlessly wrapped (see
560 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
561 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
562 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
563 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
564 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
565 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
566 -- File::Initialise: PixelConverter setup moved away to
567 PixelConverter::GrabInformationsFromHeader()
568 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
569 interpretation moved away to PixelConverter::BuildRGBImage()
571 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
572 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
573 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
575 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
576 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
577 displayed on Win32 when a brutal abort() occurs (because of uncatched
578 exception). See TODO new entry of this commit for more on this.
579 * TODO added new entry.
580 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
581 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
582 - HandleColor is no longer called from gdcmFile.cxx
583 - gdcmPixelConvert.cxx clean up on method arguments and internal
584 variable names for semantical coherence.
586 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
587 * Finished lossless transition, not only do we now read all lossless jpeg
588 images, without the need of the Cornwell lib, but we do read them properly now
589 * To reduce code (well to avoid code duplication), I defined a common place
590 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
591 redefine symbols. This is not prefect but this the best solution I found for a
592 compilation time jpeg option.
594 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
595 * Update jpeg ijg lib to support lossless jpeg implementation
596 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
598 * Also added a special copyright for dcmtk since we use their bugfixes.
601 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
602 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
603 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
604 matters, as stated in warning note at begining of %include section).
605 * src/gdcmDicomDir*.[cxx|h]: coding style
606 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
607 * src/gdcmJpeg8.cxx: doxygen fix.
608 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
609 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
610 from File:: to PixelConvert::.
612 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
613 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
614 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
615 - more code moved away from File:: to PixelConvert::
616 - fat setup of PixelConverter set in place in File::Initialise.
618 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
619 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
620 namespace at the file system level. So now you should convert your examples
622 gdcmHeader -> gdcm::Header
623 It would be nice if people keep in mind to no open the namespace, since it
624 allows compilation on broken plateform which were defining common symbol in
625 the standart namespace (like LP, Unknown ...)
627 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
628 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
629 The JPEG fragments are now parsed at the same stage than the RLE
630 information. All code related to JPEG is now in gdcmPixelConvert:
631 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
632 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
633 export a gdcmFile:: method. Those are simply global functions
634 (for the time being this is better than having them attach to
635 either gdcmFile:: or gdcmPixelConvert::).
636 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
637 and stores the result in a gdcmJPEGFragmentsInfo.
638 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
639 code (among other stuff) moved away from gdcmFile:; to
642 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
643 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
644 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
645 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
646 clean up of RLE related code.
647 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
648 - src/gdcmRLE.cxx removed
649 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
650 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
651 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
652 * CLEANUP_ROUND (9) for gdcmPixelConvert
653 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
654 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
655 away from gdcmFile:: to gdcmPixelConvert::.
657 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
659 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
660 This is because Parse7Fe0 used to parse the pixels to compute the
661 length. This task was passed over to FindDocEntryLengthOB() a long
662 time ago, EXCEPT I had forgotten the OW case...
663 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
664 we just recylce the code for parsing RLE fragments and computing
666 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
667 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
668 with the retired Parse7Fe0().
669 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
670 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
672 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
674 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
675 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
676 - src/CMakeLists.txt: alphabetic order reodering + new entries.
677 * CLEANUP_ROUND (4) for gdcmPixelConvert
678 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
679 to return an unused length.
681 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
682 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
683 this should be cleanner from the plane view. The iostream are erally a pain
684 to use to do simple stuff.
686 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
687 * Redo the compilation of the ijg jpeg library. Now only one source is
688 necesseray. No need to rename file by hand what so ever. CMake handle the
689 copying of the file within different directory, configure header file to
690 modify some symbol. The only addition made to ijg wasd a mangle table so
691 that symbol are different wether we are within 8bits or 12bits.
693 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
694 * Added documentation of vtkgdcmReader on Website:
695 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
696 with it's binary name).
697 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
698 the Website to be more complete.
699 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
700 doxygenated documentation.
701 - Doc/DoxyVtkGdcmReaderExamples.txt added
702 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
703 DoxyVtkGdmReaderExamples.html )
704 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
705 * CLEANUP_ROUND (3) for gdcmPixelConvert
706 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
708 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
709 * CLEANUP_ROUND (2) for gdcmPixelConvert
710 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
712 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
713 * CLEANUP_ROUND for gdcmPixelConvert:
714 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
715 - src/gdcmPixelStuff[h|cxx] removed
716 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
717 - src/CMakeLists.txt changed accordingly
719 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
720 gdcmVersion.py moved to newly created ATTIC related
721 gdcmPython/SetupOldies/ directory.
722 * Autotools clean up:
723 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
724 - autogen.sh configure.in acinclude.m4 python.m4 removed
726 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
727 * src/*.cxx *.h Reference to License.htm fixed to License.html.
728 * Doc/CMakeLists.txt, doxygen.config.in: fix.
729 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
731 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * TODO updated with Mathieu suggestions. I proposed a template for
733 describing TODO entries and used it for new entries.
734 * Added Doc/Website/CodingStyle.html, Developpers.html,
735 DeveloppersPython.html, GdcmDataCvs.html and
736 DownloadVersion0_1.html, DownloadVersion0_3.html.
737 * Some Doc/*.txt Doxygen files (which do not really concern the
738 documentation itself, but the website) moved to html and
739 placed in directory Doc/Website:
740 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
741 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
742 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
743 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
744 * CMakeLists.txt changed accordingly.
745 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
746 DeveloppersPython.html
747 * INSTALL nows refers to Doc/Website/Installation.html
749 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
750 * Added Doc/Website directory, that contains a first raw version
753 2004-09-23 Jean-Pierre Roux
754 * FIX In order not to be poluted any longer by casting problems,
755 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
756 we can now delete[] it safely
757 * VoidArea is now called BinArea (less confusing name),
758 and all the methods called ...VoidArea... are now ... BinArea...
759 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
761 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
762 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
763 clear) TagHT, which is an inherited member of gdcmElementSet. It is
764 up to the destructor of gdcmElementSet to clean up TagHt and it's
767 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
768 * Test/CMakeLists.txt: update to follow gdcmData renamings.
769 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
771 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
772 * ENH: added some utility method that builds a flat dictionnary
773 holding all the Dicom entries contained in the recursive structure
774 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
776 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
777 BuildFlatHashTable() that build a flat dictionary.
778 - src/gdcmElementSet.h: added a new private GetTag() accessor.
779 gdcmDocument is now a friend of gdcmElementSet.
780 - src/gdcmElementSet.cxx: clean up.
781 - Example/FlatHashTablePrint.cxx added.
782 - Example/CmakeLists.txt changed accordingly
784 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
785 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
786 moved away from gdcmDocEntrySet (since this class is an abstract class
787 acting like an interface). SQDepthLevel and BaseTagKey are now
789 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
790 and associated accessors. Doxygenation of the class.
791 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
793 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
794 Use SQDepthLevel accessor instead. ::Print() adapted.
795 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
796 - src/gdcmDocument.cxx changed accordingly.
798 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
799 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
800 - The following is the doxygen comment of the typedef declaration
801 of gdcmagKey in src/gdcmCommon.h:
802 gdcmTagKey is made to old an "universal" (as in URL, Universal
803 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
804 A dicom tag allways has a group and an element, but a set of tags
805 embeded in various (optionally nested) sequences and sharing
806 the same group and element all share the same (group, element)
807 "identifier". Hence the (group, element) cannot be used as an
808 identifier (in gdcm we shall refer to a "TagKey") of a tag.
809 In order to construct a proper tag identifier (i.e. a key) we
810 consider the following definition of a TagKey:
811 - let Group, Element be the string representation of the
812 group and element dicom tag members,
813 - let ItemNumber be the string representation of the integer
814 index of the considered item number of a sequence,
815 Let the key of a tag embeded in a sequence, noted SeqTag, be
817 /ItemNumber#Group|Element
818 where "/", "#" and "|" are characters acting as separators.
819 Then the general form of a gdcmTagKey is given by:
820 Group|Element<SeqTag>
821 where <SeqTag> means NO or many instances of SeqTag.
822 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
825 but the gdcmTagKey of a tag "embeded" is the first item of
826 a sequence, itself nested in the third item of a sequence is the
828 0004|1220/2#0008|0082/0#0008|0090
829 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
830 order to hold the new sequence compatible key. Previously, the
831 GetKey() method would look in the underlying gdcmDictEntry.
832 - src/gdcmDocEntry.cxx:
833 -- constructor now copies the underlying DictEntry key, in the local
835 -- ::Print: displays the member Key, instead of the (group, element).
836 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
837 - src/gdcmDocEntrySet.h:xi
838 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
839 -- now has a new BaseTagKey member.
841 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
842 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
844 This poses the problem with the semantics of the following lines
845 LoadEntryVoidArea(0x0028,0x1201); // R LUT
846 LoadEntryVoidArea(0x0028,0x1202); // G LUT
847 LoadEntryVoidArea(0x0028,0x1203); // B LUT
848 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
849 to the long FIXME note for what the problem is. Nevertheless in
850 order to get things working the dicom dictionary was altered !
851 Please fix things urgently...
852 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
853 information), see above note on moving the member VoidArea. Nevertheless
854 the following entries previously correctly set as US are now inproperly
856 0028 1201 OW IMG Red Palette Color Lookup Table Data
857 0028 1202 OW IMG Green Palette Color Lookup Table Data
858 0028 1203 OW IMG Blue Palette Color Lookup Table Data
859 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
860 of gdcmDocEntry moved to gdcmSeqEntry.
861 * src/gdcmSeqEntry.cxx: STYLE.
863 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
864 * Test/TestAllEntryVerify.cxx minor fix and added comments.
866 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
867 * gdcmPython/testSuite.py: all the test suite in python is now moved
868 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
869 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
870 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
872 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
873 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
874 to avoid inclusion recursion until STL is reached.
875 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
876 mecanism. errno.h is not included in gdcm anymore.
877 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
878 (gdcmFormatError now inherits from gdcmFormatUnexpected).
880 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
881 gdcmData/TestAllEntryVerifyReference.txt
882 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
883 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
884 exception_on_error parameter.
885 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
886 - vtk/vtkGdcmReader.cxx changed accordingly,
887 - Example/*.cxx and Test/*.cxx changed accordingly.
889 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
890 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
891 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
892 enable_sequences removed from gdcmHeader constructor and dependencies.
893 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
894 * gdcmPython/demo/PrintHeader.py: dummy fix.
895 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
896 skip_shadow removed from gdcmHeader constructor and dependencies.
897 * Example/*.cxx and Test/*.cxx changed accordingly.
899 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
900 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
901 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
903 2004-07-21 Jean-Pierre Roux
904 * FIX Now, Parsing and Printing a DICOMDIR do work!
905 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
907 2004-07-20 Jean-Pierre Roux
908 * FIX Some brain damaged headers have Zero-Lenght fields
909 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
911 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
912 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
913 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
914 variable (instance of gdcmDebug) by a definition macro, and the instance
915 is now in static in the gdcmDebug class
916 * src/gdcmSQItem.h : (FIXME) remove an undefined method
917 * Test/PrintAllDocument.cxx : bug fix in the result of the test
919 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
920 * WARNING: ctest now depends more tightly on gdcmData. You should
921 check out gdcmData properly for things to run smoothly...
922 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
923 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
924 we need the pixels not be loaded in order to use the ValEntry
925 that displays position and size).
926 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
927 This is a C++ based equivalent of gdcmPython/testSuite.py that should
928 be deprecated. If you have any doubts about the advantages of a
929 modern scripting language (read Python) versus grass root C++ (i.e.
930 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
931 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
932 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
933 Anyhow, consider documenting the gdcmData images in
934 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
936 * Test/CMakeLists.txt:
937 - now uses TestAllEntryVerify.cxx
938 - specific comments on oldACR00001.ima (now renamed in gdcmData
939 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
940 gdcmData/TestAllEntryVerifyReference.txt
943 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
944 * src/*.[h|cxx] : typedef clean up
945 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
946 - TagKey renamed to gdcmTagKey (for external usage)
947 - VRKey renamed to gdcmVRKey (for external usage)
948 - removal of typedef duplication.
949 - Removed all unecessary inline keyword from class inline definitions.
950 - Some method|function(void) declarations replaced with method|function().
951 * src/jpeg/libijg12/jdhuff12.c:
952 - printf polluting ctest removed.
953 - TAB removal for comminting
955 - TestAllReadCompareDicom.cxx: added a test that compares all the
956 images in gdcmDataImages.h with corresponding images in
957 gdcmData/BaselineDicom/. When baseline images are not present
958 this test creates them.
959 Note: we need to validate each reference image, but before that
960 I'd like to rename them with a more explicit name...
961 - CMakeLists.txt: changed accordingly.
962 * Example/*.cxx: examples now only include gdcm.h (as opposed to
963 including each header needed).
965 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
966 * Test/*.cxx and Example/*.cxx: moved some examples away from the
967 test suite to the Example directory. Are concerned:
972 - TestWriteSimple.cxx
973 * Test/CMakeLists.txt: added some comments on reasons for black listing
974 image gdcmData/oldACR00001.ima
976 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * Test/CmakeList.txt: removed the following from black list (to be coherent
978 with removal from gdcmData):
979 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
980 - gdcm-MR-PHILIPS-16.dcm
982 Added the following because after last cvs update, they cause
983 ctest -R TestReadWriteReadCompare
985 - gdcm-MR-SIEMENS-16-1.acr
987 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
988 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
989 new comments in this file) we temporarily (sigh) move to a weaker
991 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
992 we don't need to black list the following images anymore:
993 - 8BitsUncompressedColor.dcm
995 - US-PAL-8-10x-echo.dcm
996 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
997 fixes and the beautified code ;-)
998 This fixes the bug introduced in version 1.42 (when beautifying)
999 that made the parsing of 8BitsRunLengthColor.dcm unproper.
1000 Note: ctest was blind to this bug (this means we need to still
1001 improve the test suite). The bug could be detected by using
1002 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
1004 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
1005 and by displaying the (garbage) produced file temp.XDCM...
1007 2004-06-29 Jean-Pierre Roux
1008 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
1009 - replace by uggly but working old code :-(
1010 A lot of things should be OK again.
1011 It's really urgent to have a test suite that *tests*,
1012 to prevent Frog's beautifying sessions to break all the stuff
1013 (twice, withing a fortnigh ...)
1015 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1016 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
1017 redundancy) to added Test/TestReadWriteReadCompare.cxx
1018 * Test/CmakeList.txt: because the compare test of
1019 Test/TestReadWriteReadCompare.cxx fails, the following images are
1020 black listed: - 8BitsUncompressedColor.dcm
1022 - US-PAL-8-10x-echo.dcm
1023 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
1024 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
1025 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
1026 and ad-hoc kludge. This kludge is now removed, and on encountering
1027 such an image (OB field brain damaged) we set errno. Then in
1028 ::FindDocLength() we "fix" the length as being ALL what remains
1029 in the file (until EOF). We then proceed, hoping for the best...
1030 This fixes a SegFault in ShowDicom when trying to write such an
1032 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
1033 (because TestWriteRead breaks on it, after a non conformal commit?).
1034 ctest now runs properly, except for MakeDicomDir (which was allways
1035 broken) and the Python related stuff (still not fixed).
1037 2004-06-24 Jean-Pierre Roux
1038 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
1039 FIX : Test/TestReadWrite now iterates on all the file names
1040 (instead of infinite loop)
1041 ENH : Test/TestWriteRead now iterates on all the file names
1043 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1044 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1046 2004-06-24 Jean-Pierre Roux
1047 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1048 when SamplesPerPixel =3
1049 - now Write is no longer confused by
1050 'BitsAllocated = 12" and 'BitsStored=12"
1051 - "UN" value representation Elements are now written correctly
1052 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1053 ENH : - now gdcmHeader has its own Write methods
1054 (in order to split the job that has not to be done
1057 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1058 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1059 loop on the same image until memory went out.
1060 Note: this means we still have gobs of memory loss in PrintDocument
1061 * src/gdcmDocument.cxx: fixes problem on parsing on file
1062 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1064 2004-06-24 Jean-Pierre Roux
1065 FIX : Write - All the Sequences and Sequence Item are now written
1066 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1067 is added a the end, when necessary.
1068 - A lot of brain-damaged images, that were read correctly are
1069 now written correctly
1070 - length compatible BinEntry are now loaded correctly
1071 (even for odd groups)
1072 Note : only Explicit Value Representation was checked.
1073 (question : is implicit VR really necessary for gdcm ?)
1075 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1076 * DEVELOPPER: added a proposition of coding style.
1077 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1080 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1081 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1082 Use the gdcmDocEntry::Print() and Write() instead.
1083 * src/gdcmDocument.cxx: bug fix.
1085 2004-06-22 Jean-Pierre Roux
1086 FIX : gdcmDocument.cxx
1087 - Now we do recognize the JpegLossLess format (there was a misstyping in
1088 code 'beautyfication' :-(
1089 - Now we automaticaticaly load the Luts, if any
1091 2004-06-22 Jean-Pierre Roux
1092 In order : to write Sequences, whatever their imbrication level,
1093 : to allow user to create his own Sequences
1094 a lot of modif where necessary (adding, moving, or virtualising methods)
1096 WARNING : save your own sources *before* cvs up !
1099 ADD virtual void Write(FILE *fp, FileType filetype);
1102 ADD virtual void Write(FILE *fp, FileType filetype);
1103 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1106 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1107 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1108 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1109 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1110 ADD std::string GetEntryByName(TagName name);
1111 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1113 std::string vr = "unkn",
1114 std::string fourth = "unkn",
1115 std::string name = "unkn");
1116 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1117 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1118 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1119 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1120 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1121 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1122 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1123 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1126 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1127 ADD virtual std::string GetEntryByName (TagName tagName);
1128 ADD virtual std::string GetEntryVRByName (TagName tagName);
1129 REM virtual bool Write(FILE *, FileType);
1130 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1131 FILE *_fp, FileType type);
1132 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1133 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1134 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1135 REM virtual std::string GetEntryByName (std::string tagName);
1136 REM virtual std::string GetEntryVRByName (std::string tagName);
1137 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1138 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1139 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1141 std::string vr = "unkn",
1142 std::string fourth = "unkn",
1143 std::string name = "unkn");
1144 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1145 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1146 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1147 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1150 ADD virtual void Write(FILE *fp, FileType filetype);
1153 ADD virtual void Write(FILE *fp,FileType filetype);
1156 ADD virtual void Write(FILE *fp, FileType filetype);
1157 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1158 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1159 REM std::string GetEntryByName(TagName name);
1162 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1164 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1165 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1166 The default constructor invoked by the line
1167 gdcmHeader *f1 = new gdcmHeader( header );
1168 was gdcmHeader::gdcmHeader(bool) instead of the expected
1169 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1170 Hence the parsing wasn't executed... See also below.
1171 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1172 as explicit constructor didn't do the trick to fix the above problem.
1173 Could anyone explain why ?
1174 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1175 properly calls gdcmValEntry::Print() (that was weed out from
1176 code related to gdcmBinEntry).
1178 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * In order to fix memory leaks:
1180 - Test/TestWriteSimple.cxx: added cleaning of free store through
1182 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1183 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1184 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1185 (through the call to ::AddDicomDirMeta()) or the destructor
1186 would crash when deleting uninitialized ::metaElems].
1187 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1188 - src/gdcmDocument.cxx:
1189 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1190 from dynamic stores.
1191 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1192 was causing memory leaks.
1193 - src/gdcmSQItem.cxx:
1194 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1195 cleanly handled with polymophism: sorry but my milage is low).
1196 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1197 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1198 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1199 This avoids SegFaulting.
1200 - src/gdcmSQItem.h: coding style.
1202 - Test/TestWriteSimple still severely sucks. The output image content
1203 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1204 damaged when displayed with vtkgdcmViewer.
1205 - on memory leaks: TestWriteSimple leaks really less (see entry
1206 of 2004-06-18 in Changelog file for the call to valgrind).
1207 - on segfaults: ctest now passes all the tests but one (no more
1209 * Erroneous leading white fix:
1210 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1211 white[s] (as opposed to from >> xxx, that removes it [them].
1212 - src/gdcmTS.cxx: ditto.
1213 - gdcmPython/testSuite.py: dirty related kludge removed.
1214 * src/*: remaining references to gdcmParser removed.
1215 * src/*[cxx|h]: added copy[way]left header.
1218 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1219 * In order to fix writing of dicom files:
1220 - Test/TestWriteSimple.cxx: a simpler example of writing.
1221 - Test/CMakeLists.txt changed accordingly.
1222 - src/gdcmDocument.cxx:
1223 -- The destructor now recursilvely removes potential sequences.
1224 -- Bug fix in ::IsJPEG2000()
1225 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1226 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1228 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1229 to only declared) and build on top of
1230 ::GetDocEntryByNumber(guint16, guint16).
1231 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1232 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1233 for usage in destructor and treatement of promotion in
1234 ::ReplaceOrCreateByNumber().
1235 - src/gdcmSQItem.cxx: destructor should better handle his job.
1236 Test/TestWriteSimple now runs (or at least it DOES something).
1237 * We can now start hutting memory links. A good starting point is:
1238 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1239 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1240 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1242 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1243 * Valgrind note: after Mathieu Malaterre teached me how to read
1244 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1246 Using gcc, you can force the STL to use malloc and to free memory as
1247 soon as possible by globally disabling memory caching.
1248 With 3.2.2 and later, you should export the environment variable
1249 GLIBCPP_FORCE_NEW before running your program.
1250 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1251 simply vanish (it is still not clear to me, whether this means that
1252 STL std::string leaks or if valgrind believes it leaks...).
1253 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1254 running bin/gdcmTests makeDicomDir):
1255 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1256 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1258 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1259 SegFaulting (I drowned in DicomDir related code when trying to
1260 understand why the list is empty...).
1261 * src/gdcmDocument.h: first BSD license header try.
1262 * Doc/License.txt added.
1264 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1265 * src/gdcmDocument.[h|cxx]:
1266 - Clean up of the Transfer related predicates. They are now all based
1267 on new method isGivenTransferSyntax, that (should) handle properly
1268 the padding problem.
1269 - general clean up, simplification, and coding style.
1270 - Specific clean up of Parse7FE0() (umproperly named actually).
1271 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1273 2004-06-14 Jean-Pierre Roux
1275 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1276 - fix the display of SQItem ordinal number
1277 - add the GetSQItemByOrdinalNumber method
1278 - remove some useless never written private methods
1280 2004-06-14 Jean-Pierre Roux
1282 - adding a constructor taking a gdcmDocEntry as an input param
1283 - ReplaceOrCreateByNumber now returns :
1284 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1285 a gdcmValEntry * if a string value is passed as a param
1287 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1288 according to the param type (no longer sets a gdcmDocEntry)
1289 - GetValEntryByNumber, GetBinEntryByNumber added
1290 - NewValEntryByNumber and NewBinEntryByNumber added
1292 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1294 - GetSQItemNumber and SetSQItemNumber added, to provide
1295 a (relative) Item identier inside a given Sequence
1296 \warning : some pb remaining around this number
1298 - AddEntry now takes the Item Number as a param
1300 - adding a constructor taking a gdcmDocEntry as an input param
1302 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * Memory leak hunt with the following command:
1304 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1305 --show-reachable=yes gdcmTests PrintDocument
1306 It looks like many (all?) leaks are due to the STL (or a bad usage
1307 of the STL. The lines producing the leaks now have a comment with
1308 a "MEMORY LEAK" tag: you can retrieve them with
1309 grep "MEMORY LEAK" src/*
1310 Here are two typical examples which I can't help fixing:
1315 char * test = "babo";
1316 name = test; //// <--- valgrind detects 960 bytes lost in
1317 //// call to std::string::operator=(char const*)
1318 name.clear(); //// Doesn't help !
1326 std::cout << "Type a bunch of characters followed by RETURN: ";
1327 getline(std::cin, line); //// <--- valgrind dectects a loss
1328 //// of 1320 bytes in call to
1329 /// std::basic_istream<>& std::getline<>
1335 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1336 * src/gdcmHeader.[cxx|h]:
1337 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1338 and related, moved away to gdcmDocument.
1339 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1340 the corresponding protected accessors of inherited class
1341 gdcmDocument, removed ! As a consequence gdcmFile had to be
1342 declared friend of class gdcmDocument (see below).
1343 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1344 - Clean up of undefined or unused methods.
1345 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1346 account the changes to gdcmHeader.h).
1347 * src/gdcmDocument.h:
1348 - gdcmFile is now a friend class (in order to take into account the
1349 changes to gdcmHeader.h).
1350 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1351 (see changes to gdcmHeader.h).
1352 - Accessors (reading on the form GetEntry*) are now public.
1353 - Clean up of undefined or unused methods.
1354 * src/gdcmDocument.cxx:
1355 - adaptation to changes to gdcmDocument.h
1356 - ::OpenFile now writes a verbose message when file cannot be opened.
1357 - some std::string properly set to VRKey
1358 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1359 references to gdcmDocument.
1360 * Test/TestFindTags.cxx: changed accordingly to above changes.
1361 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1362 cvs repository gdcmData.
1364 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1365 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1366 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1367 conflicts with gdcmValEntry::voidArea.
1368 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1369 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1370 Value representation between StringRepresentable and BinaryRepresentable.
1371 * src/gdcmDocument.cxx:
1372 - method ParseDES: proper indentation restored and usage of
1373 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1374 - method LoadDocEntry: the fingerprint left in the SetValue() of
1375 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1376 removed. Reverting to previous code segment with the proper
1377 dynamic_cast< gdcmValEntry* >.
1378 Note: this was (partially) breaking the python test suite
1379 (gdcmPython/testSuite.py) that made usage of the above
1380 fingerprint to check presence of "Pixel Data".
1381 * src/gdcmDocEntry.h: coding style.
1382 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1383 now taken into account.
1384 * gdcmPython/gdcm.i: adaptation to the new internal representation
1385 of gdcm (exit gdcmParser, hello gdcmDocument).
1386 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1388 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1389 anymore, but instead prints the loaded Python dictionary.
1390 * .... alas, the python testSuite is still broken.
1392 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1393 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1395 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1396 * src/gdcmUtil.h : export methods
1398 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1399 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1401 * Initial addition of automatic python testing
1402 * Initial addition of automatic image comparison
1404 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1405 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1406 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1408 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1409 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1410 * Test/ShowDicom.cxx : bug fix for msvc compilation
1411 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1413 2004-05-04 Jean-Pierre Roux
1414 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1415 new concepts (and new classes) :
1416 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1417 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1418 - Sequence Doc Entries (gdcmSeqEntries)
1419 a Sequence is composed of Items.
1420 Each item is a set of Doc Entries (this is recursive)
1421 The non uniqueness of the 'Dicom tag' is due to this recursivity
1422 (never taken into account)
1423 Our unability to add a new 'entry' in the header
1424 at the proper location (neither in the H-Table (map or multimap),
1425 nor in the Chained List is also due to this recursivity.
1426 Don't try, right now, to use/modify/compile these new sources :
1427 nothing is finished.
1428 We just commit all the stuff, 'as is', in order not to loose it.
1430 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1431 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1433 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1434 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1435 file prefix (SetFilePrefix)
1437 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1438 * Add a new test: ShowDicom, for now this is just the c++ version of
1439 checkRead.sh, later it will be able to compare the image read against a
1441 * Replace the DEBUG on the stack with a global entry in cmake interface:
1442 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1444 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1445 * Add an example subdir, with a real example on how to read + write a
1448 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1449 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1450 * Doc/CMakeLists.txt: the main page is now properly differentiated
1451 between the developper and user version.
1452 * Doc/doxygen.config.in: dropped search related obsolete flags
1453 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1455 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1456 * DEVELOPPER: added some helpfull comments for compile/test/install
1459 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1460 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1461 src directory, now generated in the build dir.
1462 2. Tests as mentionned smarter
1464 4. Add a new method in gdcmDict that return the PubDict by name
1465 this is interesting for 3rd party lib like ITK,
1466 where we could set the institution name / patient name...
1468 * ENH: 1. Now the test suite is working for real
1469 2. All binaries are now output in the gdcm-bin directory
1470 (this was not true before)
1472 2004-04-28 Jean-Pierre Roux
1473 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1474 SeQuence indented printing of Dicom Header.
1475 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1476 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1477 Computation of SQDepthLevel is now part of gdcmHeader constructor
1478 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1479 tree-like structure of a Dicom Header.
1480 * FIX Test code cleaning
1482 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1483 * ENH: Adding automatic testing
1484 1. Need a DartConfig.cmake to submit to public
1485 2. Add a test driver gdcmTest.cxx
1486 3. gdcmTestMain, an helper for the main test driver gdcmTest
1487 4. Files in Test don't have a main anymore, this becomes interesting
1488 when we add more and more tests, thus dsw don't have to load
1490 * ENH: Adding a GDCM_DATA_ROOT for testing
1491 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1492 one file instead of seven + some small cleanup
1494 2004-04-22 Jean-Pierre Roux
1495 * ENH Minor changes to the Print() methods.
1496 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1497 Header printing. Example given with :
1498 > PrintHeader fileName 2 new
1499 (SQ based tree-like structure still to be done for the Header ...)
1501 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1502 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1503 1. I have added some unsigned where needed
1504 2. Some function parameter not used -> (void)
1505 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1506 4. g++ don't like character '\' in comment
1507 5. #define jpeg_create_decompress jCreaDecompress
1508 this really need to be fixed
1509 6. virtualize destructor of gdcmObject ... leakage
1510 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1511 this also really need to be fixed
1512 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1513 remove compression file
1514 (as we only do decompression, right ?)
1515 * ENH: Change malloc/calloc/free with c++ equivalent
1517 2004-04-21 Jean-Pierre Roux
1518 * FIX gdcmHeaderHelper::GetXSpacing
1519 when a single value is found (bug ?), xpacing is now
1520 defaulted to yspacing
1522 2004-04-19 Jean-Pierre Roux
1523 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1524 * ENH add parameters :
1525 bool exception_on_error = false,
1526 bool enable_sequences = false,
1527 bool ignore_shadow = false
1528 to the gdcmFile constructors to be full gdcmParser compliant
1529 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1530 to allow reading of PAPYRUS 3.0 files
1532 2004-04-06 Jean-Pierre Roux
1533 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1535 2004-04-02 Jean-Pierre Roux
1536 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1537 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1538 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1540 2004-03-30 Jean-Pierre Roux
1541 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1542 for ACR file, written out as DICOM files (hope so...)
1544 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1545 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1546 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1547 moved to base class gdcmParser and only the specialisation is kept
1549 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1550 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1551 already does the job.
1552 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1553 (to be consistent with gdcmParser::WriteEntries).
1555 2004-03-30 Benoit Regrain
1556 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1557 upate of the object's instance. It's passed to 2 in the unfavorable
1558 case : one in the ExecuteInformation, one in the ExecuteData
1560 2004-03-29 Jean-Pierre Roux
1561 * ENH : Check on file type to be written moved
1562 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1563 * FIX : gdcmObject::ResetBoundaries now stops properly
1564 when end-of-list is reached
1565 : gdcmVersion modified (as Benoit Regrain asked)
1567 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1568 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1569 * src/gdcmUtil.cxx: added forgotten iostream include.
1570 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1571 equivalent to ExplicitVR in existing code).
1573 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1574 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1575 now contains all the gdcmGlobal related code.
1576 * minor coding style and doxygenation changes.
1578 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1579 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1580 now contains all the Debug related code.
1581 * minor clean-up of includes in src/*.cxx
1582 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1583 CreateCleanString) removed.
1584 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1585 * Doc/DoxyMainPageUser.txt added.
1586 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1587 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1588 src/gdcmDirList.cxx)
1590 2004-03-24 Jean-Pierre Roux
1591 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1593 2004-03-23 Jean-Pierre Roux
1594 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1595 big endian made volumes
1596 * ENH Now gdcmParser constructor and destructor are protected to forbid
1597 end user to instanciate class gdcmParser
1598 (only gdcmHeader and gdcmDicomDir are meaningfull)
1600 2004-03-22 Benoit Regrain
1601 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1602 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1603 gdcmSerie to gdcmDicomDirSerie
1605 2004-03-19 Jean-Pierre Roux
1606 * ENH Now the tree-like structure describing a DICOMDIR comming from
1607 an already existing DICOMDIR file is consistent with
1608 the home-made tree-like structure build ex-nihilo
1609 or build from the files held (recursively) in a Directory
1610 functions gdcmDicomDir::CheckBoundaries()
1611 gdcmObject::SetBoundaries() added
1613 2004-03-17 Jean-Pierre Roux
1614 * REM (Eric Boix bug) : removal of meaningless
1615 gdcmDicomDirImage::NewImage function.
1616 * FIX now file names and directory name are written properly in the
1618 * FIX now gdcmDicomDir constructor may be call without any trick
1621 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1622 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1623 of gdcmDicomDirImage::NewImage as empty function.
1625 2004-02-28 Jean-Pierre Roux
1626 * ENH add gdcmDicomDir:NewPatient
1627 add gdcmDicomDirPatient:NewStudy
1628 add gdcmDicomDirStudy:NewSerie
1629 add gdcmDicomDirSerie:NewImage
1630 to allow making gdcDicomDir object.
1631 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1632 (as opposite to the gdcmHeader chained list)
1634 2004-02-11 Benoit Regrain
1635 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1636 when using from python
1638 2004-02-10 Benoit Regrain
1639 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1640 * FIX : in gdcmDicomDir when the directory is empty
1641 * ENH : add callback and methods to get the progression of dicomDir
1644 2004-02-06 Jean-Pierre Roux
1645 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1646 - GDCM_META added to gdcmDicomDirType
1647 - class gdcmMeta created
1648 * ENH : - A brief summary is now displayed at the beginning of
1649 'testDicomDir' to help disaster magnitude estimation
1650 * REM : Now useless Test/explDICOMDIR.cxx
1652 2004-02-05 Benoit Regrain
1653 * ENH : add methods in gdcmObject to get the hash table or the list of
1655 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1656 * FIX : wrapping python for TagHeaderEntryHT
1658 2004-02-04 Benoit Regrain
1659 * FIX : even length for some strings when writting the dicom dir
1660 * FIX : sort the images in the dicom dir
1661 * FIX : Bug fix for python use of dicom dir
1662 * ADD : a python demo
1664 2004-02-04 Jean-Pierre Roux
1665 * FIX : Final solution (?) for icone embedded images
1666 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1667 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1668 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1669 gdcmData/gdcm-MR-SIEMENS-16.acr1
1670 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1671 to make full checking easier
1673 2004-02-04 Benoit Regrain
1674 * FIX : WriteEntries : coding style & logic in parameters
1675 * FIX : Set the elements to create the DicomDir in a dictionary file
1677 2004-02-03 Benoit Regrain
1678 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1679 * gdcmDicomDir : add the load of directory
1680 * Bug fix and print add-on
1682 2004-02-03 Jean-Pierre Roux
1683 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1684 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1685 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1686 * FIX gdcmParser.cxx : 'group length' elements are now considered
1687 as integers, even for shadow groups, when file is Implicit VR
1689 2004-02-02 Jean-Pierre Roux
1690 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1692 of the last synonym :-(
1693 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1695 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1696 * FIX taking into account the possible 7fe0,0010 multiplicity
1697 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1698 to allow removal of references to 7fe0,0010, to deal with
1699 ACR-NEMA images, when 0028,0200 is meaningfull
1701 2004-01-31 Jean-Pierre Roux
1702 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1703 no longer writes 'Un' on disk
1704 * FIX SQ elements with actual length are now dealt with corectly
1705 * FIX gdcmFile::WriteBase make the difference, for color images, between
1706 the length (for Palette expanded images)
1707 and Raw Length (non expanded image + Palette)
1708 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1709 (that broke Write). Replaced by UL.
1710 Aware user will reload the field if he
1711 thinks it's necesssary
1713 2004-01-30 Jean-Pierre Roux
1714 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1715 when 'dirty Acr' is found, to be compliant with the new
1716 IsReadable() methods.
1718 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1719 (no DOUBLE images in kosher DICOM,
1720 but so usefull for people that miss them ;-)
1722 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1723 DICOMDIR related utilities (not checked as Windoze compliant)
1725 2004-01-28 Jean-Pierre Roux
1726 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1728 2004-01-27 Jean-Pierre Roux
1729 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1730 to allow skipping the shadow elements, to save memory space.
1731 The TRUE value for this param has to be used
1732 with a FALSE value for the 'enable_sequence' param.
1733 ('public elements' may be embedded in 'shadow Sequences')
1734 * gdcmHeader methods now deal with 'embedded icones images' in the header
1735 (even when an 'icone image sequence' is announced by the
1736 element (0x0088,0x0200), but there is NO icone at all ...
1738 * gdcmHeader sometimes Image Location value doesn't follow
1739 the supposed processor endianity (see gdcmData/cr172241.dcm).
1742 * gdcmHeader add the method
1743 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1744 to get *all* the Header Entries with the same tag.
1745 GetHeaderEntrySameName is probabely *useless*
1746 (no meaning : Name is *not* an identifier within the Dictionnary)
1748 2004-01-26 Benoit Regrain
1749 * Bug fix in the print of hexadecimal representations. Remove long fields
1750 in the print and add a third level of print to print them
1752 2004-01-23 Benoit Regrain
1753 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1754 * Bug fix on test suite after remove the strip made on not string fields
1755 * Split the IsReadable method between gdcmParser which test that the file
1756 is dicom and gdcmHeader which test that it's an image file
1758 2004-01-22 Benoit Regrain
1759 * DicomDir : clean code, add methods, set variables in protected or private
1760 * gdcmUtil : bug fix for the clean string method
1762 2004-01-19 Benoit Regrain
1763 * Add the use of shadow dictionaries
1764 * bug fix and coding style
1766 2004-01-19 Benoit Regrain
1767 * src/gdcmFile.cxx : bug fix concerning the close of file
1768 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1769 * Add the update of header entries using the shadow library
1771 2004-01-19 Benoit Regrain
1772 * removal of file gdcmHeader2.cxx
1773 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1774 inheriting from gdcmParser. This split is to prepare the integration
1775 of dicom dir parsing
1776 * bug fix under python
1778 2004-01-16 Jean-Pierre Roux
1779 * REM removal of class gdcmHeaderEntrySet
1780 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1781 * ADD add file gdcmHeader2.cxx
1782 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1784 2004-01-15 Benoit Regrain
1785 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1786 entries created while parsing the header. Thus, they will be destroyed
1787 when the gdcmDictSet will be destroyed
1788 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1791 2004-01-15 Benoit Regrain
1792 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1793 made a fatal error because of the memory release at the end of program.
1794 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1795 some memory and vtk seems to have some problems with that.
1796 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1798 2004-01-14 Benoit Regrain
1799 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1800 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1801 * src/*.[h|cxx] : make changes due to class name changes
1802 * gdcmPython/demo/*.py : bug fix due to method names
1804 2004-01-13 Benoit Regrain
1805 * src/*.[h|cxx] : coding style
1806 * vtk/*.[h|cxx] : coding style
1808 2004-01-13 Benoit Regrain
1809 * gdcmPython/testSuite.py : test the readable flag of file for tests
1810 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1811 It's lied to the stl compilation by MSVC (windows, always windows...)
1812 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1814 2004-01-12 Benoit Regrain
1815 * src/*.h : add comments
1816 * src/gdcmDictSet.h : set the method BuildDictPath in public
1817 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1818 directly setted in the source code
1819 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1822 2004-01-09 Benoit Regrain
1823 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1824 * setup.py : use a reference to gdcmVERSION
1826 2004-01-07 Benoit Regrain
1827 * Modification to compile with the distutils.
1830 2003-12-10 Benoit Regrain
1831 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1832 can use a gdcmHeaderHelper to load datas
1833 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1834 made in the source code
1836 2003-12-10 Benoit Regrain
1837 * Update Windows projects and .cvsignore files
1839 2003-11-12 Jean-Pierre Roux
1840 * ENH gdcmHeader constructor has one more parameter (default value : false)
1841 that allows the user to 'go inside' the SeQuences only
1843 gdcmElValSet:Print takes it into account
1845 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1846 * ENH: Update gdcmPython/CMakeLists
1847 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1848 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1850 2003-11-10 Jean-Pierre Roux
1851 * FIX : gdcmHeader::LoadElements is now based
1852 on the ListTag listElem member,
1853 not longer on the TagElValueHT tagHt member
1854 * ENH : PrintPubElVal shows (temporarily) both results,
1855 with the tagHt member and the listElem member.
1856 (it's easier to 'see' the problems when using Printheader)
1858 * FIX : old private member LgrElem is now splitted into
1859 ReadLength : Length actually found on disk (updated only
1860 if bug fixing is necessary), for internal
1862 UsableLength : Updated by FixFoundLength, to fix a bug
1863 or to allow Parser going on.
1864 Will allow to re-write a kosher header when a SeQuence
1865 with a length (not 0000) is found
1866 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1867 because gdcmElValSet::Add does not update ListElem
1870 2003-11-07 Jean-Pierre Roux
1871 * FIX misstyping in Transfert Syntax name table
1872 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1873 when they have an actual length (not 0000 nor FFFFF)
1874 (Nobody should care of it, but DICOMDIR explorers)
1876 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1877 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1879 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1880 * ENH: vtkGdcmReader now supports LUT !
1881 (vtkgdcmViewer for now is not able to use them though)
1883 2003-11-05 Jean-Pierre Roux
1884 * in testSuite.py : new files names for checking the package
1885 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1886 that returns the pixel area size to the *aware* (vtk) user
1887 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1889 2003-11-05 Benoit Regrain
1890 * in testSuite.py : Modify the rules for checking the paths
1891 : Explicit error messages
1892 * in __init__.py : Related modif
1894 2003-11-03 Jean-Pierre Roux
1895 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1896 to be used by aware (vtk) users that want to manage
1897 LUT (and no to turn the PALETTE image into an RGB pixels one)
1898 * GetPixelType now returns 8U for 24 Bits images
1899 (vtkGdcmReader compliant)
1901 2003-10-31 Jean-Pierre Roux
1902 * Removal of *all* gdcmData images and add them again
1903 in order to loose the 'history' of un-anonymised images
1905 2003-10-31 Jean-Pierre Roux
1906 * RMV : removal of useless jBitsInJsample.h
1907 for both 8 and 12 Bits JPEG Lossy Libraries
1909 2003-10-31 Jean-Pierre Roux
1910 * ENH : Add the functions gdcmFile::GetImageDataRaw
1911 gdcmFile::GetImageDataIntoVectorRaw
1912 that act as GetImageData and GetImageDataIntoVector
1913 except the making of an RGB Plane from Gray Plane + LUT
1914 Intended to aware (vtk) users who know how to manage
1917 GetLUTRGBA return a R,G,B,A LUT if any
1918 lgrTotaleRaw gives the 'Raw' length
1919 GetImageDataRaw returns the gray Plane
1920 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1921 (They stay Grey, just like with other Dicom viewers :-(
1923 2003-10-30 Jean-Pierre Roux
1924 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1926 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1927 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1928 being coherents dicom files.
1930 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1931 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1933 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1934 * ENH: Two steps is necessary to please VC++ compiler...
1935 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1936 * ENH: Add include dir to medcon lib
1937 * FIX: only one function is being exported for now !
1938 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1940 2003-10-29 Jean-Pierre Roux
1941 * adding gdcmHeader::GetLUTRGBA
1942 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1943 --> Mathieu, the modif u're waiting for is not yet committed
1944 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1946 2003-10-27 Jean-Pierre Roux
1947 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1948 00191113.dcm DermaColorLossLess.dcm
1949 MxTwinLossLess.dcm RadBWLossLess.dcm
1950 * ENH: For version prior to vtkImageViewer2 -r 1.19
1951 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1953 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1954 * Removal of ido stuff in CMakeLists.txt
1956 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1957 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1958 * FIX: remove a call to ->Modified ... see comments
1959 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1961 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1962 * FIX: Problem with path for libvtkgdcmPython
1963 * ENH: Try adding a search script for python site-package
1964 * RMV: Remove some file from medcon lib that are not necessary
1965 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1966 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1967 * FIX: More pragma disable fro VC++,
1968 I don't think I break something as it is also disable in VTK/ITK.
1969 But it fasten debug compilation time.
1971 2003-10-23 Jean-Pierre Roux
1972 * gdcm now deals with 16 Bits Run Length Encoded images
1973 (they are compressed as 2 planes images,
1974 one for the high Bytes, the other for low Bytes)
1976 2003-10-22 Jean-Pierre Roux
1977 * Now CheckRead takes into account :
1978 - the bugged 'Leonardo' Siemens images
1979 - the XA images, sent thru the burning VPRO station
1980 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1983 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1984 * FIX: When copying a Makefile.am to CMakeLists.txt
1985 one should remove the '\'
1987 2003-10-22 Jean-Pierre Roux
1988 * in gdcmData adding a bugged 'Leonardo' Siemens image
1989 (wrong lengths in header)
1990 OK with gdcm, KO with the other viewers :-)
1991 * add a GE dlx XA image, thru the VEPRO burning station
1994 2003-10-21 Jean-Pierre Roux
1995 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1996 for a brutal checking of vtkgdcmViewer compliance
1998 2003-10-21 Jean-Pierre Roux
1999 * add the files for 'xmedcon' Jpeg Lossless library
2000 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
2002 2003-10-21 Jean-Pierre Roux
2003 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
2005 2003-10-21 Jean-Pierre Roux
2006 * garbage Siemens 'Leonardo' images dealt with
2007 (the patch is easy to remove)
2008 * cosmetic changes to avoid warnings
2010 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2011 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
2012 no need to press 'r' now.
2014 2003-10-20 Jean-Pierre Roux
2015 * upgrade of checkRead.sh checkWrite.sh according
2016 to new Jpeg Lossless decompressor
2017 * add US.3405.1.dcm, a genuine RGB medical file ...
2018 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
2019 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
2021 2003-10-15 Jean-Pierre Roux
2022 * general anonymisation in gdcmData
2023 * adding the 'color files' from
2024 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
2025 * adding some well knowed bugged-header images
2026 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
2027 waiting for their inclusion in Python testsuite
2029 2003-10-15 Jean-Pierre Roux
2030 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
2031 no longer seg faults when file is not found
2033 2003-10-14 Jean-Pierre Roux
2034 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
2037 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2038 * TODO: *.in file to genereate a UseGDCM later
2040 2003-10-14 Jean-Pierre Roux
2041 * Some supposed-to-be Dicom Images have no preamble.
2042 OpenFile takes it into account
2043 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2044 * Missing elements added in dicomV3.dic
2045 (just to be affraid : have a look at
2046 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2047 and do it again next year ;->
2049 2003-10-13 Jean-Pierre Roux
2050 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2051 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2052 But there are NOT. It's fixed !
2054 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2055 * FIX: "jpeglib.h" was not found on VC++
2056 * FIX: vtkgdcm was not being installed
2058 2003-10-10 Jean-Pierre Roux
2059 * ENH : OpenFile closes the file if it *really* doesn't look like
2060 an ACR-NEMA / DICOM one.
2061 * FIX : testWrite no longer writes an empty file if the source file
2062 is not gdcm Readable
2063 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2066 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2067 * FIX: CMake generate now documentation
2068 * ENH: out of source doc build !
2069 * ENH: Generate both user and dev documentation
2070 * ENH: Should work on windows too
2071 * ENH: Only one doxygen config.in file is needed
2072 * FIX: make install should be ok now on ùnix plateform
2073 * FIX: PATH to dictionary was wrong (missing /)
2074 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2076 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2077 * vtkGdcmReader is now able to read rgb dicom file.
2078 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2079 * added a gdcmViewer to vtk test, use mouse to control
2080 window level & window width
2082 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2083 * CMake-ification of gdcm, we have now two build system
2084 * FIX: on cygwin Wsock32 doesn't exist
2085 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2087 2003-10-06 Emanuel Ollart
2088 * FIX : compilation process wad broken.
2089 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2091 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2092 * change gdcmViewer -> vtkgdcmViewer
2093 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2095 2003-10-06 Jean-Pierre Roux
2096 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2097 ( e.g : well known GE images with a wrong elem length,
2098 : Philips MRI Images with a wrong Huffman table)
2099 * still to be done : allow the reading of bugged LEONARDO Siemens images
2101 2003-10-03 Jean-Pierre Roux
2102 * Odd length strings are padded with '\0' (not with spaces,
2103 to remain compliant with already defined strings,
2104 like Transfert Syntax UID and others)
2106 2003-10-03 Jean-Pierre Roux
2107 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2108 to allow displaying RGB images (not only by affim ;-)
2110 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2111 * vtkGdcmReader is now able to read rgb dicom file.
2112 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2114 2003-10-03 Jean-Pierre Roux
2115 * A few nasty patches to allow the reading of a lot of nasty images
2116 ( e.g : well known GE images with a wrong elem length,
2117 : Philips MRI Images with a wrong Huffman table)
2118 * still to be done : allow the reading of bugged LEONARDO Siemens images
2120 2003-10-03 Jean-Pierre Roux
2121 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2123 2003-10-03 Jean-Pierre Roux
2124 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2125 to allow displaying RGB images (not only by affim ;-)
2127 2003-10-03 Jean-Pierre Roux
2128 * gdcmFile::GetImageDataIntoVector now
2129 - deals with MultiFrames MultiFragments Run Length Encoded files
2130 - deals with YcBcR (YBR_FULL) files
2131 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2132 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2134 (no sample found :-(
2136 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2137 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2138 Two reasons: - clear things
2139 - third parties acces gdcm through header files, so won't
2140 suffer anymore VC++ complains
2142 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * add argv[1] in testvtkGdcmReader.cxx
2146 2003-09-24 Jean-Pierre Roux
2147 * The lines are now eigthy characters long.for
2148 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2150 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2151 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2152 char* to std::string. Thus, the use of strdup becomes useless. (see
2153 previous commis of Malaterre)
2154 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2155 before the last Malaterre's commit.
2157 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2158 * This commit should fix the Debug building under VC++, the problem
2159 was mainly a mixture of debug and release lib being loaded at startup.
2160 * I also remove a depency to a specific C function: strdup. Because I had
2161 to force the link to msvcrtd (whereas strdup is in libc).
2163 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2164 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2165 located in the gdcmCommon.h file. All use of reference of tha has been
2166 changed to now use the variable GDCM_UNFOUND.
2168 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2170 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2171 Dicom dictionary. The test suite can now be run again. Note:
2172 I'm note very happy with the " (RET)" changes. I believe this
2173 RETAINED comment should be dropped when parsing the dictionary.
2174 - PACKAGER corrected
2176 - AUTHORS updated and now in alphabetical order
2177 * Makefile.am now exports gdcm.dsw for Windoze users.
2179 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2180 * cygwin complains about missing std:: in subdir Test/
2182 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2183 * remove some methods that are now in gdcmHeaderHelper
2185 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * vtkGdcmReader set spacing and origin correctly
2188 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2189 * Fix a few delete/delete[] mismatch
2191 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2192 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2193 interpretation to data given by gdcmHeader. For instance there are
2194 heuristics to get informations (look at different places).
2195 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2196 sorting DICOM images based on different strategies.
2197 * modified Makefiles accordingly.
2199 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2200 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2201 when building in debug mode
2202 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2203 src/win32/gdcmdll.dsp
2204 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2206 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2207 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2210 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2211 * src/win32/libgdcmjpeg12.dsp was not dos format
2212 * src/win32/libgdcmjpeg12.dsp :
2213 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2214 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2216 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2217 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2219 * src/gdcmFile.cxx : bug fix in affectation type
2220 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2221 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2222 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2223 symbols... future problem ?
2225 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2226 * src/win32/libgdcmijpeg12.dsp was missing
2227 * modified gdcm.dsw accordingly
2229 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2230 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2232 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2233 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2234 commit of JPR (before his hollidays to facilitate our work).
2235 * setup.py : bug fix in code. Modifications made while the last commit
2236 of JPR. The code hasn't been tested before the commit... it's so
2237 useless to make that (for best programmer that is JPR) !!!
2239 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2240 * tagged the current version as Version0_3 (i.e. version 0.3)
2242 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2243 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2244 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2245 * *.dsp : modifications to use new libgdcmijpeg8 library
2246 * setup.py : bug fix on VTKPATH variable
2247 * PACKAGER : adding all concerning windows
2249 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2250 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2252 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2253 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2254 test suite reported error.
2255 * PACKAGER file added (describes what a packager must do when
2256 packaging a new release).
2257 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2258 * configure.in: upgraded version number to 0.3.0
2259 * fixing build of rpm (through rpm -ta):
2260 - Doc/Makefile.am exports proper doxygen files
2261 - src/jpeg/libijg8/Makefile.am exports the include files.
2263 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2264 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2265 * src/gdcmHeader.h : formatting code
2267 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2268 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2269 We were obtaining error message from vtk. Now, creation of file list
2270 is made in an internal list to prevent this problem.
2271 Bug fix when output is empty.
2272 Bug fix in update of progress value. Previous commit for this was a bad
2274 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2276 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2277 * src/gdcmHeader.h : added method to get the file name
2278 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2279 files. Added method to remove all files on the input
2280 Added FIXME comment concerning the bad parsing of header made by
2281 ExecuteInformation method (in ExecuteData method)
2283 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2284 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2285 when using make instal.
2286 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2287 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2289 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2290 * setup.py : adding include dir of jpeg lib to compile all sources
2291 * */Win32/*.dsp : JPR fix for windows compilation
2293 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2294 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2296 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2297 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2299 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2300 * setup.py is again effective on un*x (takes into account the
2301 addon of the jpeg library)
2302 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2303 * Doc/Doxy* updated (includes above enhancements)
2304 * INSTALL now points to web documentation
2306 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2307 * src/gdcmHeader.h doesn't make unnecessary reference to
2309 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2311 * src/gdcm*.[cxx|h] :
2312 - to allow compilation with gcc 3.x
2313 -- clean up of STL usage (added explicit usage of std::)
2314 -- small fixes on exceptions.
2315 Note: linking not tested !
2316 - clean of doxygen comments to avoid warnings at documentation
2318 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2319 dependent convertion).
2321 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * Clean up of previous JPR garbage commit (not even commented in the
2324 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2325 - moved all jpeg related files from src to src/jpeg/libijg8, with
2326 addition/modification of Makefile.am and configure.in.
2327 - the testSuite is still brain damage (not guilty).
2329 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2330 * WrapVTK.py : modifications to get correctly vtk source files to
2332 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2333 (FileName -> Filename)
2335 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * vtk/vtkGdcmReader.[cxx/h]:
2337 - UpdateProgress method should now be effective
2338 - removed the limitation on having only images loaded (as opposed
2340 - when building a stack of images/volume, a lesser number of
2341 gdcmHeader and gdcmFile instances should be used (hopefully
2342 accelerating things).
2343 - when building a stack of images/volumes, files which are not
2344 loadable (wrong path-filename, wrong permissions on existing file,
2345 or file not parsable by gdcm) are replaced with a black image
2346 in the stack (for the caller to notice the problem).
2348 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2349 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2351 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2352 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2353 between standard library (std) and vtk library (problems are found
2354 under Windows... thanks Windows !)
2356 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2357 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2359 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2361 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2364 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2365 * When compiling with distutils (see setup.py) the C++ compiler is
2366 called with different flags than the default ones (with automake).
2367 In order to fix all those warning, I compiled gdcm with the command
2368 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2369 and went for warning fixes:
2370 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2371 up from unused variables.
2372 - vtk/vtkGdcmReader.cxx: potential bug fix.
2373 * src/gdcmHeader.h: Doxygen warning cleanup
2375 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2376 * gdcmPython/gdcm.i:
2377 - typemaps correction to take into account the systematic replacement
2378 of "using namespace std" with std:: prefix e.g. std::list,
2379 std::string... (cf changes of 2003-05-21).
2380 - gdcmGlob global variable of type gdcmGlobal (defined in
2381 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2382 exported to Python a as cvar.
2383 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2384 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2385 gdcmDictSet.GetPubDictTagNames() and
2386 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2387 C++ static methods).
2388 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2389 with the above changes.
2391 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2392 * setup.py, manifest.in : bug fix under linux
2394 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2395 * Modification of setup.py to compile vtk part too. Then, we have 2
2396 wrappers which must work with same distutils. For that, we have a
2397 generic distutils in distusiltsWrapping.py ; with :
2398 - build_extWrap class to wrap generically all extensions,
2399 - ExtensionWrap base class for all wrapping extension that contains
2401 - Wrapper interface which wrap sources
2402 + In WrapSwig.py we have extension and wrapper for Swig
2403 + In WrapVTK.py we have extension and wrapper for VTK
2404 * MANIFEST.in : modifications to consider vtk directory and new python
2405 files for compilation
2407 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2408 * Added python wrappers of vtkGdcmReader vtk class (see the
2409 source in vtk/vtkGdcmReader.cxx) :
2410 - vtk/Makefile.am now builds a library
2411 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2412 python library (as opposed to _gdcm.so wich are the python
2413 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2414 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2416 - configure.in has an additional flag --enable-vtk that needs
2417 to be set to enable compilation of vtk related code, that is:
2418 + vtk/vtkGdcmReader.so and
2419 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2420 + gdcmPython/vtkgdcmPython.so (see above)
2421 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2422 be read when compressed or when HighBit + 1 != BitsStored),
2423 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2424 the usage of the python wrapper of vtkGdcmReader vtk class.
2425 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2426 * src/*.[h] all occurences of stl classes are now prefixed with
2427 std::, and all occurences of "using namespace std;" where removed.
2428 This is to avoid pollution of global namespace in included files.
2429 Apparently vtk does not avoid this pitfall: when using both
2430 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2431 collision of various stl members (principally cout...).
2432 * gdcmPython/testSuite.py now cleanly removes temprory generated
2434 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2435 comply with above changes)
2437 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2438 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2439 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2440 vtk data structure (an image Flip was required).
2441 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2442 * cosmetic changes in documentation.
2444 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2445 * src/gdcmHeader.cxx: the constructor no longer exits when an
2446 unexisting file is given as argument.
2447 * The subdirectory Data (containing all the images used for the
2448 test suite) is not part of this repository anymore. A new module
2449 containing those images is now available at
2450 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2451 with the name gdcmData.
2452 All the python scripts (including the package initialisation file
2453 gdcmPython/__init__.py) were adapated to take this change into
2454 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2456 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2457 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2458 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2459 demo of the usage of this class.
2460 Compilation of this vtk part is only done when using the --enable-vtk
2461 at configure (or autogen.sh) stage.
2463 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2464 * More memory link related corrections and documentation fixes.
2466 - maximum info is obtained with a command of the form:
2467 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2468 --show-reachable=yes PrintHeader
2469 - the remaining reachable blocks seem to come from the STL
2470 allocation scheme through the usage of map and list. It looks
2471 like this memory cannot be freed but it is not a memory leak
2472 (in fact further invocation to the STL would recollect the
2473 unused memory allthough it cannot explicitely be freed).
2474 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2475 of displaying an image parsed with gdcm and displayed with VTK.
2476 Note: some images don't seem to work e.g.
2477 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2478 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2479 Allthough this weakens the semantics, it is a ditch attempt to
2480 make gdcm more thread friendly.
2482 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2483 * Memory link hunt (by using valgrind through the command
2484 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2485 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2486 gdcmHeader::_dicom_vr.
2487 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2488 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2490 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2492 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2493 * src/Makefile.am now exports all the necessary include files at
2497 * UpdateGroupLength replaced by new one
2500 * UpdateGroupLength re-written using H-Table
2501 (named UpdateGroupLengthNew untill checks are over)
2503 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2504 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2505 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2507 - gdcmHeader::GetPubElValSet removed.
2508 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2509 UpdateGroupLength, WriteElements, Write.
2510 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2511 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2512 carried the same semantics.
2513 - src/gdcmHeaderIdo.cxx changed accordingly.
2514 - gdcmFile::WriteBase now regroups all the codes from previous
2515 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2516 - enum FileType moved to gdcmCommon.h
2517 * src/gdcmHeader.cxx AddDefault trashed
2518 * gdcmGetXSize added
2519 * getimageDataSize now calls gdcmGetXSize
2520 * Test/*.cxx changed to agree with above changes
2522 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2523 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2524 (to avoid double call by end user).
2525 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2526 by end user, since gdcmHeader::gdcmHeader now handles it.
2528 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2529 * gdcm/Doc many doxygen changes:
2530 - Doxyfile now has two different versions, DoxyfileUsers that generates
2531 the html.users end users oriented documentation and
2532 DoxyfileDeveloppers that generates the html.developper developper
2533 oriented documentation.
2534 - README changed accordingly
2535 - requirement.txt removed (old design info moved to TODO).
2536 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2537 DoxyMainPage.txt, DoxyPython.txt provide more information.
2538 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2539 be updated by simply regenerating the docs with doxygen and copying
2540 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2541 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2542 all the tests in the form "if (<map>.count() >1)" were removed.
2543 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2544 ill-formed documentation sections.
2545 * src/gdcmHeader.cxx: ditto
2547 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2548 * setup.py fixed for un*x (needed macro for stdint.h)
2549 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2550 un*ces with sh-utils test utility.
2551 * gdcmPython/demo/test.py renamed to PrintHeader.py
2552 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2553 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2554 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2555 * src/gdcm*.cxx JPR's bad inclusion fixed.
2557 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2558 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2559 * gdcmPython/demo/test.py changed accordingly.
2561 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2562 * gdcmPython/Makefile.am fixed linking against libstdc++
2563 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2564 * Swig subdir (historical tests of swig version 1.3.17++) removed
2565 * Test/testChangeEntete.cxx some lines commented out in order to make
2567 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2568 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2570 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2571 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2572 hence the user doesn't need this explicit call.
2573 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2574 i.e. LoadElements() call removed.
2575 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2576 - src/Makefile.am declares the proper flag for g++.
2577 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2578 for adding user defined new tags.
2579 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2580 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2581 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2583 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2584 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2585 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2586 src/Makefile.am : the project should properly compile and install
2587 with the autotools, included the python wrappers part.
2588 * gdcm.spec.in : added a spec file for RPM packaging.
2590 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2591 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2593 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2594 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2595 to exported to the environement (see gdcmPython/testSuite.py
2597 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2598 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2599 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2600 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2601 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2603 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * gdcmPython/__init__.py doesn't crash anymore when running in
2605 in InstallMode or PreInstallMode but with an environement given
2606 value of GDCM_DICT_PATH.
2607 * src/gdcmDictSet.[cxx/h] coding style.
2609 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2610 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2611 * src/gdcm.h general comments moved to TODO, and README
2612 * src/gdcm.h should now be seen as a user commodity (including it
2613 should suffice to fully use gdcm). It is nowhere including within
2614 any of the kernel files src/*.cxx and src/*.h.
2616 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2617 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2618 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2620 * src/gdcm*.cxx only include their corresponding include file
2621 (as opposed to gdcm.h)
2622 * gdcmPython/gdcm.i changed accordingly
2623 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2624 the autogen.sh generated "make snapshot" command to work.
2625 * autogen.sh removed history related references to crea package.
2627 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2628 * distutilsSwigCPlusPlus.py work around some swig portability
2631 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2632 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2633 was done in a last ditch attempt to get setup.py _really_
2634 operationnal. The python/gdcmPython layaout add the advantage
2635 of hidding away the python related distutils specific files
2636 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2637 Alas, the src directory was out of scope (i.e. it's relative
2638 position to setup.py was ../src) which made things impossible to
2639 handle (see previous version of python/setup.py). Crossing fingers...
2641 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2642 * python/setup.py now works on Un*x. (harder than I thougth)
2643 * python/distutilsSwigCPlusPlus.py can now have include files
2644 among the list of sources.
2646 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2648 * modifications in MSVC projects
2650 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2651 * As stated by the first lines of Test/ExceptionAndPython/README, it
2652 looks like we can move back to original usage of exception within
2653 src/gdcm* and hence remove the errno stuff that was introduced
2654 as a quick and dirty fixture of this problem (added to the TODO).
2655 * Doc/Doxyfile configuration file for Doxygen and corresponding
2656 README file for usage added.
2657 * Test/testWrite.cxx added. This new test comes from a split of
2658 test.cxx that is now reverted to its original purpous i.e.
2659 testing the proper parsing of a Dicom related file.
2660 testWrite.cxx concentrates on testing the IO part of gdcm.
2661 * Test/bug1.cxx (containing a bug on WIn32) added.
2662 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2663 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2664 whose purpose is to publish the content of the TagNames of the
2665 Dicom public dictionnary were not accessible without an
2666 instance of class gdcmHeader.
2667 - those methods are now static methods of gdcmDictSet and hence
2668 require no instances at all to be invocated.
2669 - within gdcmDictSet this change required to change some method
2670 to class methods (i.e. are now static) among which SetDictPath
2671 (renamed to BuildDictPath) and LoadDefaultPubDict.
2672 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2673 the above changes by calling the new method classes of gdcmDictSet.
2674 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2675 the above to be effective.
2676 * python/gdcmPython: in order to wrap properly the above changes
2677 for Python, swig version now needs to be > 1.3.17.
2678 * python/gdcmPython/Makefile fixed to adapt itself to new
2679 configure/make shema introduced by Johan Montagnat (thanks for the
2680 contribution). Alas this Makefile cannot be turned into a proper
2681 Makefile.am without some heavy changes in the configure.in
2682 (for python dectection).
2683 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2684 now avoids publishing the empty entries.
2686 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2687 * python/setup.py : bug fix concerning install under windows
2688 ExtraPath reused :-P
2689 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2691 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2692 * Dicts/dicomV3.dic : remove double spaces !!!
2693 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2694 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2697 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2699 method. Doxygenation.
2700 * src/gdcm.h clean up of JPR spurious comments.
2702 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2703 * python/distutilsSwigCPlusPlus.py now properly collects the
2704 shadow classes generated by "swig -c++" (gdcm.py in our case)
2705 when using "python setup.py install".
2706 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2707 reexports the working classes.
2708 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2709 by the classical C errno scheme. This is to prevent an obscure
2710 behavior of the python wrappers when importing wxPython.wx prior
2711 to gdcmPython (which ended up in an abort call). An illustration
2712 of this oddity can be found in the Test/ExceptionAndPython
2713 subdir (see the README file). This problem probably due to
2714 an combination of g++ and dynamic loading.
2715 * added Test/ExceptionAndPython (see above)
2717 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2718 * Changed the layout of the python part to avoid bloating main
2719 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2720 i.e. the distutils arsenal. All the python related stuff is
2721 again in a python subdir, but the package itself is now in
2723 * setup.py was cleaned up:
2724 - pythonIncludePath removed
2725 - python setup.py bdist target is now functional.
2726 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2727 collision with other packages). gdcmPython/demo/*.py changed
2730 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2731 * python subdir moved to gdcmPython (preparation of distutils packaging).
2732 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2733 distutils installer is operational.
2734 * - gdcmPython/__init__.py now properly loads the swig generated
2735 shadow classes (from gdcm.py).
2736 - gdcmPython/demo/*.py changed to import the package gdcmPython
2737 instead of gdcmPython/demo/load.py.
2738 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2740 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2741 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2742 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2743 entries within the associated public Dicom dictionary resp. the same
2744 information but sorted by the fourth field (PAT, IMG, DIR) of the
2746 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2747 are now in the "???" group.
2748 - python/gdcm.i changed accordingly,
2749 - python/demo/printGroupedPublicDict.py added, that gives an example
2750 of the above new functionalities in Python.
2752 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2753 * src/gdcm.h, gdcmHeader.cxx:
2754 - historic references to glib's g_malloc and g_free (#defined)
2755 were definitively removed.
2756 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2757 * src/gdcmElValSet.cxx:
2758 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2759 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2760 - GetElValue(string) renamed to GetElValueByName.
2761 - Added GetElementByName(string).
2762 * src/gdcmHeader.cxx: added
2763 - GetPubElValRepByNumber(guint16, guint16)
2764 - GetPubElValRepByName(string)
2765 - GetShaElValRepByNumber(guint16, guint16)
2766 - GetShaElValRepByName(string)
2767 - GetShaElValByNumber(guint16, guint16)
2768 - GetShaElValRepByName(string)
2769 - GetElValRepByNumber(guint16, guint16)
2770 - GetElValRepByName(string)
2771 - GetElValByNumber(guint16, guint16)
2772 - GetElValRepByName(string)
2773 * Doc/requirements.txt added.
2775 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2776 * Test/Makefile building now depends on the one of libgdcm.so
2777 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2778 pixel data) aware which enables finding the address (offset) of
2779 the pixel data of JPEG encoded DICOM files. This leaves only a single
2780 file in the testSuite whose pixel data address (offset) is unknown.
2781 * python/testSuite.py changed accordingly.
2783 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2784 * VC++ has some strong limitations when working with the STL, as stated
2785 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2786 "Also note that some STL containers (map, set, queue, list, deque)
2787 cannot be exported. [...]
2788 Some STL classes contain nested classes. These classes can not
2790 This is caused by a designed limitation that once a template
2791 class is instantiated, it can not be re-instantiated and
2793 Since our usage of map<> is ubiquitous in gdcm, this "designed
2794 limitation" of VC++ is a pitfall.
2795 Hence the Python wrappers of gdcm cannot be incrementally linked
2796 against the c++ dynamic library. The dirty but only workaround is
2797 to forget about incremental link of dynamic libraries and to generate
2798 the Python wrappers library with the inclusions of the underlying C++
2800 The following modifications concern this matter on Win32/VC++:
2801 - wrapping python correct with standalone wrapped dll (don't use separate
2802 dll under windows !!!!)
2803 - python21_d debug mode enabled (ask Frog how to use it :-)
2804 - NO problem with having an STL member of class for example string in C++
2805 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2806 - Python test of dcmlib in Python is ok under windows on a large set
2808 * removed glib references
2809 * typedef's inserted in gdcm.i for correct swig type management
2811 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2812 * python/demo/*.py load.py extracted from test.py. Added explore.py
2813 that only displays required tags and testAll.py that parses all
2814 the files of the testsuite without using unittest.
2815 * python/testSuite.py other additional test on new files added.
2816 * Data/* new test files added accordingly to the testSuite.
2817 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2818 the vr in the file differs from the one of the dictionary.
2820 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2822 values, but limits itself to values which are below a user specified
2823 size (by default 1024 bytes).
2824 * python/gdcm.i : elements not loaded (because their size is above the
2825 user specified treshold) are exported with their TagKey as key of the
2826 python dictionary. This enables the testsuite to make some checks
2827 on the unloaded elements (since we have their offset and size).
2828 * python/testSuite.py
2829 - now tests for the existence and proper value of the pixel data
2830 - two new examples added.
2831 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2833 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2834 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2835 aware. See the strategy comments in gdcmHeader::FindeLength().
2836 * Test/test.cxx now accepts a filename as first argument.
2837 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2838 * python/testSuite.py changed to integrate test on above files.
2840 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2841 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2842 the vr was also RET.
2843 * python/testSuite.py more tests added.
2845 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2846 * python/testSuite.py unittest test suite added (uses Data)
2847 * Data/* dcm and acr files for the test suite.
2848 * glib dependance removed from un*x version. We now use ISO C99
2849 7.18 Integer types (see stdint.h)
2850 - python/Makefile, src/Makefile src/gdcm.h
2851 * src/ when an explicit vr (like dicom files) suddenly poped an
2852 implicit element we use to mark the underlying DictEntry of the
2853 concerned ElValue with "Implicit". This strategy was damageable
2854 too the public or provite dictionaries, since some of their vr
2855 would be changed. Since Header::FindLength heavily relies on the
2856 detection by Header::FindVR of falsely explicit elements, I
2857 added an extra ImplicitVr member to ElValue (boolean).
2858 The rest of the changes we the necessary adaptations.
2860 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2863 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2865 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2866 * Adaptation for porting to VC++:
2868 o forced to use std namespace (for string to be known)
2869 o all class use __declspec export style on WIN32
2870 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2871 (in stdlib.h on Win32 but in std:: for gcc)
2872 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2873 variable GDCM_DICT_PATH.
2874 * src/gdcmHeader.cxx verbose comments made discrete.
2876 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2877 * python/gdcm.i: added a typemap that converts a C++ hashing table
2878 to native Python dictionary.
2879 * python/demo/test.py:
2880 - now uses the native dictionary for exploration of gdcmHeader.
2881 - takes an optional filename argument (the file to parse).
2882 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2883 PubElVals hashing table.
2884 * Dicts/dicomV3.dic removed error prone trailing spaces.
2886 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2887 * Python wrapping process moved away from src/Makefile to
2888 newly created python/Makefile (as well as gdcm.i)
2889 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2890 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2891 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2892 from the environement variable GDCM_DICT_PATH (when existing).
2893 * src/gdcmDict::GetTag bug fix.
2895 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2896 * Straightforward temporary fixes for swig to build the python wrappers.
2897 src/Makefile now has a python working entry [by working we mean
2898 that we can import de shadow classes without errors].
2900 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2901 * hashtest.cxx removed (since allready in Test)
2902 * src/gdcmlib.h renamed to src/gdcm.h
2903 * src/dcm.i renamed to src/gdcm.i
2904 * src/Makefile prepared for python wrapping
2906 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcmHeader.cxx :
2908 - Parsing of header is now separated from loading of element values
2909 (see gdcmHeader::LoadElements).
2910 - general clean up of hopefully all file access (creation of
2911 ReadInt16 and ReadInt32)
2913 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2914 * src/gdcmHeader.cxx :
2915 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2917 - SetLgrElem renamed to SetLength
2918 - GetLgrElem renamed to GetLength
2919 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2920 * src/gdcmElValSet.cxx fixed both GetElValue methods
2921 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2922 due to IdoDude was cleaned out.
2924 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2925 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2926 concentrates on finding the value representation (when it exists).
2927 RecupLgr now only finds the element value length, and it avoids
2928 returning the unecessary skL (skipped length).
2929 Also, offsetCourant was simply removed (with taille_fich) since
2930 it was redundant with the File position internals (by using
2931 ftell and fseek). This also made skL (see above in RecupLgr) usage
2933 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2934 on the libido specificities which are handled through class
2936 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2939 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2940 * Truckload of changes. Parsing of header is barely functional
2941 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2943 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2944 * src/gdcmHeader.cxx many addons of low level methods
2946 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2947 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2948 and _IdDcmSWAP_LONG.
2950 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2951 * This corresponds to all the changes decided at the meeting of
2952 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob