1 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
3 avoid problems (otherwise, the difference test between the visible image
4 and the reference is incorrect. If the reference is greater than the
5 screen resolution, it's produce errors).
6 Can be used for only one image. Can be used with a visible flag.
7 * vtk/vtkGdcmReader.cxx : remove commented codes.
8 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
9 under windows at compilation
10 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
12 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
14 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
15 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
16 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
17 tests on the image size X, Y, Z
19 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
20 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
21 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
22 between the class name and the file name
24 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
25 * src/ : fix compilation warnings for the Write method (2 different
26 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
27 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
28 variable... create a static method in gdcm::Document to access to
29 this variable content.
31 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
33 file, to be accessed by other files (like gdcmFile). Remove commented
34 code. Move the change of the header to the gdcmFile, using the
36 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
37 To be sure of that (and simplify calls), the Write of the header now
38 gets a file name and not a file pointer (std::ifstream).
39 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
40 DocEntryArchive. Remove all open of the written file
42 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
43 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
45 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
46 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
47 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
49 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
50 some corresponding methods. Write correctly the file and check before
52 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
53 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
54 is now on RGB datas (as before my last commit
55 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
57 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
59 Add a print information of the type of the entry
60 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
61 It was in the gdcmFile, and all write have been regrouped
62 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
63 Write correctly all dicom files (in decompressed mode only at this time)
64 * Test/ : test on files are now made using Raw datas and not color datas if
66 * Example/PrintFile.cxx : add more printings
68 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * Amelioration of code, remove some code copy. For the loading of
70 BinEntry (in gdcmDocument), add the test to verify if the file is already
73 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
75 remove a DocEntry in the header (push an empty DocEntry)
76 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
77 lines. Bug fix in the initialization of the PixelConvert and the
79 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
80 use in TestCopyDicom (now this test can run under windows... but fails)
81 * Test/TestCopyDicom.cxx : amelioration of the test :
82 - test the pixels written
83 - add test points to quickly find where is the error
84 - can set a file name input and output in arguments
85 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
86 amelioration of the test output
88 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
89 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
90 all replaced DocEntry's
91 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
92 Now, each needed DocEntry to modify is duplicated, modified and inserted
93 to the header using DocEntryArchive. Thus, after save, we can restore the
96 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
97 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
99 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
101 correct to copy it. The DictEntry is specified at the DocEntry creation,
102 then, it musn't change in the time.
103 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
104 header correctly. At this time, the change is only made for the first
105 level of the Document. In the future, it might consider sequences.
106 The change is made by replacing a DocEntry by an other that is created
107 outside the class. The old value is kept. When we restore the header
108 status, the added DocEntry is deleted and replaced by the old value.
109 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
110 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
111 set the write type to explicit VR, implicit VR or ACR. Add methods to set
112 the write mode to native, decompressed or RGB (but not used at this time)
114 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
116 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
118 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
119 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
120 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
122 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
123 set because already copied when copying the BinEntry's of the header
124 * Test/TestAllReadCompareDicom.cxx : remove warnings
126 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
128 Two problems appear when doing it :
129 - with the gdcmFile : when the GetImageData method is called, the pixels
130 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
131 datas (pixels). And each structure destruct the datas when it's
132 destructed. So we have two destructions for the same datas. To solve it,
133 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
134 datas or not. If it doesn't own datas, then they will not destroyed by
136 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
137 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
138 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
139 create a double destruction of the same DocEntry's. So, to solve it,
140 the TagHT is simply cleared and the DicomDir* elements are destroyed.
141 * TODO : add an entry concerning memory leaks in the DicomDir
143 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
144 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
145 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
148 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
149 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
150 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
151 after it have been deleted
153 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
154 * FIX: src/* fix the doxygen warnings.
155 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
156 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
157 was erroneously defined with a size of 15 instead of 16. [many thanks
158 to Jean Michel Rouet for pointing out this bug].
160 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
161 1. Finish merging JMR patch for writting DICOM from scratch
162 2. Fix -hopefully- bug with MONOCHROME and space vs null character
163 3. Use const ref when possible
164 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
165 5. A few more comments
166 6. CreateUniqueUID can now be called without parameter"
168 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
169 * ENH: Slightly bigger patch:
170 1. Getting toward full integration of JMR patch for writting dicom from scratch
171 2. Update Test to test part of this patch: CreateUniqueUID
172 3. File was not close properly in gdcmDict
173 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
174 5. Use of const ref instead of copy (speed issue)
175 6. Remove temporary (duplicate) string in TranslateToKey
176 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
177 8. Do not repeat virtual in subclasses
178 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
180 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
181 * Apply first patch toward better string comparison when dealing with broken
182 DICOM files. Essentially the string could be padded with a space instead
183 of a null character as defined by standard
185 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
186 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
187 because never used... and in the same time, that's remove some memory leaks
189 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
190 * src/gdcmFile.cxx : now delete the PixelConvert instance.
191 * In examples and tests : change the type of image data variables from void*
192 to uint8_t*. Remmove all delete on image data variables
194 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
195 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
196 Verify the file pointer value before open the file, and if it's not null,
197 a verbose message is generated.
198 Close correctly the file when the file isn't considered dicom-like. The
199 correctly close is a call to CloseFile.
200 When closing the file pointer, test if its not null to close the file.
201 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
202 file. For an uncompressed image, the copied datas correspond in the least
203 case to the image size (calculated) or the image size specified in the
204 header. A verbose is generated if these two size mismatch
206 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
207 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
208 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
209 break under windows (with msvc6 compilation).
211 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
212 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
213 compiling with MSVC6)
215 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
216 * Bugs fix for the Windows build with VC6
217 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
218 needed (only for projects required VTK). If the VTK is included in all
219 projects, there is conflicts with the jpeg lib of vtk when compiling the
220 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
221 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
222 when compiling the gdcm_wrap.cxx file (created by the compilation of the
224 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
225 (like it's already made for the cout use). Otherwise, conflict with the
228 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
229 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
231 - comments on the DicomDir::Method related usage added.
232 - now that we use the namespace gdcm, a lot of internal classes do
233 NOT need to be wrapped anymore.
234 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
235 DicomDir::Method) new example added.
237 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
238 * Improve string manipulation. I now inforce the notion of 'DicomString'
239 A DicomString can contain as many \0 as they want
240 and it is *always* of even length.
241 We only support odd length for very rare case.
242 And in the near future this should be removed.
244 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
245 * /binary_write/ gdcm source. Now even on big endian we are writting
246 little endian. This should -heopfully- fix some tests
248 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
249 * Now the dictionary is compiled into gdcm lib. This is a default
250 behavior, thus any dic file specified is picked before failback to
251 the one comiled into lib
253 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
254 * Change internals for gdcmDict. Don't use any 'new' any more.
255 This should definitely solve any leak problem, and we should be
256 as fast as before, as long as don't modify too much the dictionary.
258 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
259 * STYLE: ivars should start with a capital letter.
260 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
261 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
263 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
264 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
265 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
266 new 2004 dictionaries added (thanks to JPR).
267 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
268 * CLEANUP_ROUND (15) for gdcmPixelConvert
269 - RLEFrame::NumberFragments is now of type unsigned int
270 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
271 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
274 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
275 * Initial work in gathering all transfer syntax accessors. clearly
276 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
277 ivars, but only one transfersyntax (class) ivar with equivalent method on
280 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
281 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
282 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
283 discussed (plus I didn't like having a 2000 lines patch not commited)
285 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
286 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
287 * CLEANUP_ROUND (14) for gdcmPixelConvert
288 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
289 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
290 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
292 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
293 anymore and hence avoids storing a copy of PixelConvert::Decompressed
294 into File::Pixel_Data.
296 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
297 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
298 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
299 * CLEANUP_ROUND (13) for gdcmPixelConvert
300 Substituted File::ParsePixelData() with PixelConvert::Print() new
302 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
303 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
304 method to those classes.
305 - src/gdcmFile.[cxx|h]:
306 -- Added a ::Print() method.
307 -- PixelConverter is now a reference instead of a member.
308 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
309 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
311 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
312 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
313 collaboration diagram and inheritance diagram should be generated with
315 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
316 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
317 pointlessly wrapped (see
318 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
319 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
320 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
321 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
322 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
323 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
324 -- File::Initialise: PixelConverter setup moved away to
325 PixelConverter::GrabInformationsFromHeader()
326 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
327 interpretation moved away to PixelConverter::BuildRGBImage()
329 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
330 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
331 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
333 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
334 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
335 displayed on Win32 when a brutal abort() occurs (because of uncatched
336 exception). See TODO new entry of this commit for more on this.
337 * TODO added new entry.
338 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
339 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
340 - HandleColor is no longer called from gdcmFile.cxx
341 - gdcmPixelConvert.cxx clean up on method arguments and internal
342 variable names for semantical coherence.
344 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
345 * Finished lossless transition, not only do we now read all lossless jpeg
346 images, without the need of the Cornwell lib, but we do read them properly now
347 * To reduce code (well to avoid code duplication), I defined a common place
348 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
349 redefine symbols. This is not prefect but this the best solution I found for a
350 compilation time jpeg option.
352 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
353 * Update jpeg ijg lib to support lossless jpeg implementation
354 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
356 * Also added a special copyright for dcmtk since we use their bugfixes.
359 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
360 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
361 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
362 matters, as stated in warning note at begining of %include section).
363 * src/gdcmDicomDir*.[cxx|h]: coding style
364 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
365 * src/gdcmJpeg8.cxx: doxygen fix.
366 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
367 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
368 from File:: to PixelConvert::.
370 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
371 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
372 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
373 - more code moved away from File:: to PixelConvert::
374 - fat setup of PixelConverter set in place in File::Initialise.
376 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
377 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
378 namespace at the file system level. So now you should convert your examples
380 gdcmHeader -> gdcm::Header
381 It would be nice if people keep in mind to no open the namespace, since it
382 allows compilation on broken plateform which were defining common symbol in
383 the standart namespace (like LP, Unknown ...)
385 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
386 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
387 The JPEG fragments are now parsed at the same stage than the RLE
388 information. All code related to JPEG is now in gdcmPixelConvert:
389 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
390 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
391 export a gdcmFile:: method. Those are simply global functions
392 (for the time being this is better than having them attach to
393 either gdcmFile:: or gdcmPixelConvert::).
394 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
395 and stores the result in a gdcmJPEGFragmentsInfo.
396 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
397 code (among other stuff) moved away from gdcmFile:; to
400 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
401 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
402 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
403 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
404 clean up of RLE related code.
405 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
406 - src/gdcmRLE.cxx removed
407 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
408 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
409 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
410 * CLEANUP_ROUND (9) for gdcmPixelConvert
411 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
412 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
413 away from gdcmFile:: to gdcmPixelConvert::.
415 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
416 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
417 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
418 This is because Parse7Fe0 used to parse the pixels to compute the
419 length. This task was passed over to FindDocEntryLengthOB() a long
420 time ago, EXCEPT I had forgotten the OW case...
421 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
422 we just recylce the code for parsing RLE fragments and computing
424 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
425 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
426 with the retired Parse7Fe0().
427 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
428 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
430 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
432 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
433 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
434 - src/CMakeLists.txt: alphabetic order reodering + new entries.
435 * CLEANUP_ROUND (4) for gdcmPixelConvert
436 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
437 to return an unused length.
439 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
440 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
441 this should be cleanner from the plane view. The iostream are erally a pain
442 to use to do simple stuff.
444 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
445 * Redo the compilation of the ijg jpeg library. Now only one source is
446 necesseray. No need to rename file by hand what so ever. CMake handle the
447 copying of the file within different directory, configure header file to
448 modify some symbol. The only addition made to ijg wasd a mangle table so
449 that symbol are different wether we are within 8bits or 12bits.
451 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
452 * Added documentation of vtkgdcmReader on Website:
453 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
454 with it's binary name).
455 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
456 the Website to be more complete.
457 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
458 doxygenated documentation.
459 - Doc/DoxyVtkGdcmReaderExamples.txt added
460 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
461 DoxyVtkGdmReaderExamples.html )
462 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
463 * CLEANUP_ROUND (3) for gdcmPixelConvert
464 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
466 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
467 * CLEANUP_ROUND (2) for gdcmPixelConvert
468 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
470 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
471 * CLEANUP_ROUND for gdcmPixelConvert:
472 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
473 - src/gdcmPixelStuff[h|cxx] removed
474 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
475 - src/CMakeLists.txt changed accordingly
477 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
478 gdcmVersion.py moved to newly created ATTIC related
479 gdcmPython/SetupOldies/ directory.
480 * Autotools clean up:
481 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
482 - autogen.sh configure.in acinclude.m4 python.m4 removed
484 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
485 * src/*.cxx *.h Reference to License.htm fixed to License.html.
486 * Doc/CMakeLists.txt, doxygen.config.in: fix.
487 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
489 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
490 * TODO updated with Mathieu suggestions. I proposed a template for
491 describing TODO entries and used it for new entries.
492 * Added Doc/Website/CodingStyle.html, Developpers.html,
493 DeveloppersPython.html, GdcmDataCvs.html and
494 DownloadVersion0_1.html, DownloadVersion0_3.html.
495 * Some Doc/*.txt Doxygen files (which do not really concern the
496 documentation itself, but the website) moved to html and
497 placed in directory Doc/Website:
498 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
499 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
500 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
501 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
502 * CMakeLists.txt changed accordingly.
503 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
504 DeveloppersPython.html
505 * INSTALL nows refers to Doc/Website/Installation.html
507 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
508 * Added Doc/Website directory, that contains a first raw version
511 2004-09-23 Jean-Pierre Roux
512 * FIX In order not to be poluted any longer by casting problems,
513 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
514 we can now delete[] it safely
515 * VoidArea is now called BinArea (less confusing name),
516 and all the methods called ...VoidArea... are now ... BinArea...
517 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
519 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
520 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
521 clear) TagHT, which is an inherited member of gdcmElementSet. It is
522 up to the destructor of gdcmElementSet to clean up TagHt and it's
525 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
526 * Test/CMakeLists.txt: update to follow gdcmData renamings.
527 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
529 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
530 * ENH: added some utility method that builds a flat dictionnary
531 holding all the Dicom entries contained in the recursive structure
532 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
534 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
535 BuildFlatHashTable() that build a flat dictionary.
536 - src/gdcmElementSet.h: added a new private GetTag() accessor.
537 gdcmDocument is now a friend of gdcmElementSet.
538 - src/gdcmElementSet.cxx: clean up.
539 - Example/FlatHashTablePrint.cxx added.
540 - Example/CmakeLists.txt changed accordingly
542 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
543 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
544 moved away from gdcmDocEntrySet (since this class is an abstract class
545 acting like an interface). SQDepthLevel and BaseTagKey are now
547 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
548 and associated accessors. Doxygenation of the class.
549 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
551 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
552 Use SQDepthLevel accessor instead. ::Print() adapted.
553 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
554 - src/gdcmDocument.cxx changed accordingly.
556 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
557 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
558 - The following is the doxygen comment of the typedef declaration
559 of gdcmagKey in src/gdcmCommon.h:
560 gdcmTagKey is made to old an "universal" (as in URL, Universal
561 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
562 A dicom tag allways has a group and an element, but a set of tags
563 embeded in various (optionally nested) sequences and sharing
564 the same group and element all share the same (group, element)
565 "identifier". Hence the (group, element) cannot be used as an
566 identifier (in gdcm we shall refer to a "TagKey") of a tag.
567 In order to construct a proper tag identifier (i.e. a key) we
568 consider the following definition of a TagKey:
569 - let Group, Element be the string representation of the
570 group and element dicom tag members,
571 - let ItemNumber be the string representation of the integer
572 index of the considered item number of a sequence,
573 Let the key of a tag embeded in a sequence, noted SeqTag, be
575 /ItemNumber#Group|Element
576 where "/", "#" and "|" are characters acting as separators.
577 Then the general form of a gdcmTagKey is given by:
578 Group|Element<SeqTag>
579 where <SeqTag> means NO or many instances of SeqTag.
580 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
583 but the gdcmTagKey of a tag "embeded" is the first item of
584 a sequence, itself nested in the third item of a sequence is the
586 0004|1220/2#0008|0082/0#0008|0090
587 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
588 order to hold the new sequence compatible key. Previously, the
589 GetKey() method would look in the underlying gdcmDictEntry.
590 - src/gdcmDocEntry.cxx:
591 -- constructor now copies the underlying DictEntry key, in the local
593 -- ::Print: displays the member Key, instead of the (group, element).
594 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
595 - src/gdcmDocEntrySet.h:xi
596 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
597 -- now has a new BaseTagKey member.
599 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
600 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
602 This poses the problem with the semantics of the following lines
603 LoadEntryVoidArea(0x0028,0x1201); // R LUT
604 LoadEntryVoidArea(0x0028,0x1202); // G LUT
605 LoadEntryVoidArea(0x0028,0x1203); // B LUT
606 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
607 to the long FIXME note for what the problem is. Nevertheless in
608 order to get things working the dicom dictionary was altered !
609 Please fix things urgently...
610 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
611 information), see above note on moving the member VoidArea. Nevertheless
612 the following entries previously correctly set as US are now inproperly
614 0028 1201 OW IMG Red Palette Color Lookup Table Data
615 0028 1202 OW IMG Green Palette Color Lookup Table Data
616 0028 1203 OW IMG Blue Palette Color Lookup Table Data
617 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
618 of gdcmDocEntry moved to gdcmSeqEntry.
619 * src/gdcmSeqEntry.cxx: STYLE.
621 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
622 * Test/TestAllEntryVerify.cxx minor fix and added comments.
624 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
625 * gdcmPython/testSuite.py: all the test suite in python is now moved
626 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
627 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
628 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
630 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
631 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
632 to avoid inclusion recursion until STL is reached.
633 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
634 mecanism. errno.h is not included in gdcm anymore.
635 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
636 (gdcmFormatError now inherits from gdcmFormatUnexpected).
638 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
639 gdcmData/TestAllEntryVerifyReference.txt
640 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
641 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
642 exception_on_error parameter.
643 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
644 - vtk/vtkGdcmReader.cxx changed accordingly,
645 - Example/*.cxx and Test/*.cxx changed accordingly.
647 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
648 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
649 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
650 enable_sequences removed from gdcmHeader constructor and dependencies.
651 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
652 * gdcmPython/demo/PrintHeader.py: dummy fix.
653 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
654 skip_shadow removed from gdcmHeader constructor and dependencies.
655 * Example/*.cxx and Test/*.cxx changed accordingly.
657 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
658 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
659 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
661 2004-07-21 Jean-Pierre Roux
662 * FIX Now, Parsing and Printing a DICOMDIR do work!
663 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
665 2004-07-20 Jean-Pierre Roux
666 * FIX Some brain damaged headers have Zero-Lenght fields
667 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
669 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
670 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
671 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
672 variable (instance of gdcmDebug) by a definition macro, and the instance
673 is now in static in the gdcmDebug class
674 * src/gdcmSQItem.h : (FIXME) remove an undefined method
675 * Test/PrintAllDocument.cxx : bug fix in the result of the test
677 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
678 * WARNING: ctest now depends more tightly on gdcmData. You should
679 check out gdcmData properly for things to run smoothly...
680 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
681 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
682 we need the pixels not be loaded in order to use the ValEntry
683 that displays position and size).
684 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
685 This is a C++ based equivalent of gdcmPython/testSuite.py that should
686 be deprecated. If you have any doubts about the advantages of a
687 modern scripting language (read Python) versus grass root C++ (i.e.
688 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
689 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
690 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
691 Anyhow, consider documenting the gdcmData images in
692 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
694 * Test/CMakeLists.txt:
695 - now uses TestAllEntryVerify.cxx
696 - specific comments on oldACR00001.ima (now renamed in gdcmData
697 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
698 gdcmData/TestAllEntryVerifyReference.txt
701 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
702 * src/*.[h|cxx] : typedef clean up
703 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
704 - TagKey renamed to gdcmTagKey (for external usage)
705 - VRKey renamed to gdcmVRKey (for external usage)
706 - removal of typedef duplication.
707 - Removed all unecessary inline keyword from class inline definitions.
708 - Some method|function(void) declarations replaced with method|function().
709 * src/jpeg/libijg12/jdhuff12.c:
710 - printf polluting ctest removed.
711 - TAB removal for comminting
713 - TestAllReadCompareDicom.cxx: added a test that compares all the
714 images in gdcmDataImages.h with corresponding images in
715 gdcmData/BaselineDicom/. When baseline images are not present
716 this test creates them.
717 Note: we need to validate each reference image, but before that
718 I'd like to rename them with a more explicit name...
719 - CMakeLists.txt: changed accordingly.
720 * Example/*.cxx: examples now only include gdcm.h (as opposed to
721 including each header needed).
723 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
724 * Test/*.cxx and Example/*.cxx: moved some examples away from the
725 test suite to the Example directory. Are concerned:
730 - TestWriteSimple.cxx
731 * Test/CMakeLists.txt: added some comments on reasons for black listing
732 image gdcmData/oldACR00001.ima
734 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
735 * Test/CmakeList.txt: removed the following from black list (to be coherent
736 with removal from gdcmData):
737 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
738 - gdcm-MR-PHILIPS-16.dcm
740 Added the following because after last cvs update, they cause
741 ctest -R TestReadWriteReadCompare
743 - gdcm-MR-SIEMENS-16-1.acr
745 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
746 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
747 new comments in this file) we temporarily (sigh) move to a weaker
749 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
750 we don't need to black list the following images anymore:
751 - 8BitsUncompressedColor.dcm
753 - US-PAL-8-10x-echo.dcm
754 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
755 fixes and the beautified code ;-)
756 This fixes the bug introduced in version 1.42 (when beautifying)
757 that made the parsing of 8BitsRunLengthColor.dcm unproper.
758 Note: ctest was blind to this bug (this means we need to still
759 improve the test suite). The bug could be detected by using
760 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
762 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
763 and by displaying the (garbage) produced file temp.XDCM...
765 2004-06-29 Jean-Pierre Roux
766 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
767 - replace by uggly but working old code :-(
768 A lot of things should be OK again.
769 It's really urgent to have a test suite that *tests*,
770 to prevent Frog's beautifying sessions to break all the stuff
771 (twice, withing a fortnigh ...)
773 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
774 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
775 redundancy) to added Test/TestReadWriteReadCompare.cxx
776 * Test/CmakeList.txt: because the compare test of
777 Test/TestReadWriteReadCompare.cxx fails, the following images are
778 black listed: - 8BitsUncompressedColor.dcm
780 - US-PAL-8-10x-echo.dcm
781 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
782 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
783 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
784 and ad-hoc kludge. This kludge is now removed, and on encountering
785 such an image (OB field brain damaged) we set errno. Then in
786 ::FindDocLength() we "fix" the length as being ALL what remains
787 in the file (until EOF). We then proceed, hoping for the best...
788 This fixes a SegFault in ShowDicom when trying to write such an
790 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
791 (because TestWriteRead breaks on it, after a non conformal commit?).
792 ctest now runs properly, except for MakeDicomDir (which was allways
793 broken) and the Python related stuff (still not fixed).
795 2004-06-24 Jean-Pierre Roux
796 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
797 FIX : Test/TestReadWrite now iterates on all the file names
798 (instead of infinite loop)
799 ENH : Test/TestWriteRead now iterates on all the file names
801 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
802 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
804 2004-06-24 Jean-Pierre Roux
805 FIX : - now Write drops LUT Descriptors and LUTs (if any)
806 when SamplesPerPixel =3
807 - now Write is no longer confused by
808 'BitsAllocated = 12" and 'BitsStored=12"
809 - "UN" value representation Elements are now written correctly
810 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
811 ENH : - now gdcmHeader has its own Write methods
812 (in order to split the job that has not to be done
815 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
816 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
817 loop on the same image until memory went out.
818 Note: this means we still have gobs of memory loss in PrintDocument
819 * src/gdcmDocument.cxx: fixes problem on parsing on file
820 gdcmData/16BitsJpegLosslessGrayScale.dcm.
822 2004-06-24 Jean-Pierre Roux
823 FIX : Write - All the Sequences and Sequence Item are now written
824 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
825 is added a the end, when necessary.
826 - A lot of brain-damaged images, that were read correctly are
827 now written correctly
828 - length compatible BinEntry are now loaded correctly
829 (even for odd groups)
830 Note : only Explicit Value Representation was checked.
831 (question : is implicit VR really necessary for gdcm ?)
833 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
834 * DEVELOPPER: added a proposition of coding style.
835 * src/gdcmDocEntry.h: removed every inline declaration (for test of
838 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
839 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
840 Use the gdcmDocEntry::Print() and Write() instead.
841 * src/gdcmDocument.cxx: bug fix.
843 2004-06-22 Jean-Pierre Roux
844 FIX : gdcmDocument.cxx
845 - Now we do recognize the JpegLossLess format (there was a misstyping in
846 code 'beautyfication' :-(
847 - Now we automaticaticaly load the Luts, if any
849 2004-06-22 Jean-Pierre Roux
850 In order : to write Sequences, whatever their imbrication level,
851 : to allow user to create his own Sequences
852 a lot of modif where necessary (adding, moving, or virtualising methods)
854 WARNING : save your own sources *before* cvs up !
857 ADD virtual void Write(FILE *fp, FileType filetype);
860 ADD virtual void Write(FILE *fp, FileType filetype);
861 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
864 ADD virtual void Write (FILE *fp, FileType filetype)=0;
865 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
866 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
867 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
868 ADD std::string GetEntryByName(TagName name);
869 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
871 std::string vr = "unkn",
872 std::string fourth = "unkn",
873 std::string name = "unkn");
874 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
875 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
876 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
877 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
878 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
879 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
880 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
881 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
884 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
885 ADD virtual std::string GetEntryByName (TagName tagName);
886 ADD virtual std::string GetEntryVRByName (TagName tagName);
887 REM virtual bool Write(FILE *, FileType);
888 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
889 FILE *_fp, FileType type);
890 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
891 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
892 REM virtual bool WriteEntries(FILE *_fp,FileType type);
893 REM virtual std::string GetEntryByName (std::string tagName);
894 REM virtual std::string GetEntryVRByName (std::string tagName);
895 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
896 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
897 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
899 std::string vr = "unkn",
900 std::string fourth = "unkn",
901 std::string name = "unkn");
902 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
903 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
904 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
905 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
908 ADD virtual void Write(FILE *fp, FileType filetype);
911 ADD virtual void Write(FILE *fp,FileType filetype);
914 ADD virtual void Write(FILE *fp, FileType filetype);
915 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
916 REM std::string GetEntryByNumber(guint16 group, guint16 element);
917 REM std::string GetEntryByName(TagName name);
920 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
922 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
923 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
924 The default constructor invoked by the line
925 gdcmHeader *f1 = new gdcmHeader( header );
926 was gdcmHeader::gdcmHeader(bool) instead of the expected
927 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
928 Hence the parsing wasn't executed... See also below.
929 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
930 as explicit constructor didn't do the trick to fix the above problem.
931 Could anyone explain why ?
932 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
933 properly calls gdcmValEntry::Print() (that was weed out from
934 code related to gdcmBinEntry).
936 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * In order to fix memory leaks:
938 - Test/TestWriteSimple.cxx: added cleaning of free store through
940 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
941 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
942 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
943 (through the call to ::AddDicomDirMeta()) or the destructor
944 would crash when deleting uninitialized ::metaElems].
945 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
946 - src/gdcmDocument.cxx:
947 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
949 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
950 was causing memory leaks.
951 - src/gdcmSQItem.cxx:
952 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
953 cleanly handled with polymophism: sorry but my milage is low).
954 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
955 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
956 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
957 This avoids SegFaulting.
958 - src/gdcmSQItem.h: coding style.
960 - Test/TestWriteSimple still severely sucks. The output image content
961 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
962 damaged when displayed with vtkgdcmViewer.
963 - on memory leaks: TestWriteSimple leaks really less (see entry
964 of 2004-06-18 in Changelog file for the call to valgrind).
965 - on segfaults: ctest now passes all the tests but one (no more
967 * Erroneous leading white fix:
968 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
969 white[s] (as opposed to from >> xxx, that removes it [them].
970 - src/gdcmTS.cxx: ditto.
971 - gdcmPython/testSuite.py: dirty related kludge removed.
972 * src/*: remaining references to gdcmParser removed.
973 * src/*[cxx|h]: added copy[way]left header.
976 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
977 * In order to fix writing of dicom files:
978 - Test/TestWriteSimple.cxx: a simpler example of writing.
979 - Test/CMakeLists.txt changed accordingly.
980 - src/gdcmDocument.cxx:
981 -- The destructor now recursilvely removes potential sequences.
982 -- Bug fix in ::IsJPEG2000()
983 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
984 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
986 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
987 to only declared) and build on top of
988 ::GetDocEntryByNumber(guint16, guint16).
989 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
990 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
991 for usage in destructor and treatement of promotion in
992 ::ReplaceOrCreateByNumber().
993 - src/gdcmSQItem.cxx: destructor should better handle his job.
994 Test/TestWriteSimple now runs (or at least it DOES something).
995 * We can now start hutting memory links. A good starting point is:
996 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
997 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
998 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1000 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1001 * Valgrind note: after Mathieu Malaterre teached me how to read
1002 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1004 Using gcc, you can force the STL to use malloc and to free memory as
1005 soon as possible by globally disabling memory caching.
1006 With 3.2.2 and later, you should export the environment variable
1007 GLIBCPP_FORCE_NEW before running your program.
1008 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1009 simply vanish (it is still not clear to me, whether this means that
1010 STL std::string leaks or if valgrind believes it leaks...).
1011 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1012 running bin/gdcmTests makeDicomDir):
1013 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1014 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1016 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1017 SegFaulting (I drowned in DicomDir related code when trying to
1018 understand why the list is empty...).
1019 * src/gdcmDocument.h: first BSD license header try.
1020 * Doc/License.txt added.
1022 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1023 * src/gdcmDocument.[h|cxx]:
1024 - Clean up of the Transfer related predicates. They are now all based
1025 on new method isGivenTransferSyntax, that (should) handle properly
1026 the padding problem.
1027 - general clean up, simplification, and coding style.
1028 - Specific clean up of Parse7FE0() (umproperly named actually).
1029 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1031 2004-06-14 Jean-Pierre Roux
1033 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1034 - fix the display of SQItem ordinal number
1035 - add the GetSQItemByOrdinalNumber method
1036 - remove some useless never written private methods
1038 2004-06-14 Jean-Pierre Roux
1040 - adding a constructor taking a gdcmDocEntry as an input param
1041 - ReplaceOrCreateByNumber now returns :
1042 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1043 a gdcmValEntry * if a string value is passed as a param
1045 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1046 according to the param type (no longer sets a gdcmDocEntry)
1047 - GetValEntryByNumber, GetBinEntryByNumber added
1048 - NewValEntryByNumber and NewBinEntryByNumber added
1050 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1052 - GetSQItemNumber and SetSQItemNumber added, to provide
1053 a (relative) Item identier inside a given Sequence
1054 \warning : some pb remaining around this number
1056 - AddEntry now takes the Item Number as a param
1058 - adding a constructor taking a gdcmDocEntry as an input param
1060 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1061 * Memory leak hunt with the following command:
1062 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1063 --show-reachable=yes gdcmTests PrintDocument
1064 It looks like many (all?) leaks are due to the STL (or a bad usage
1065 of the STL. The lines producing the leaks now have a comment with
1066 a "MEMORY LEAK" tag: you can retrieve them with
1067 grep "MEMORY LEAK" src/*
1068 Here are two typical examples which I can't help fixing:
1073 char * test = "babo";
1074 name = test; //// <--- valgrind detects 960 bytes lost in
1075 //// call to std::string::operator=(char const*)
1076 name.clear(); //// Doesn't help !
1084 std::cout << "Type a bunch of characters followed by RETURN: ";
1085 getline(std::cin, line); //// <--- valgrind dectects a loss
1086 //// of 1320 bytes in call to
1087 /// std::basic_istream<>& std::getline<>
1093 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1094 * src/gdcmHeader.[cxx|h]:
1095 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1096 and related, moved away to gdcmDocument.
1097 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1098 the corresponding protected accessors of inherited class
1099 gdcmDocument, removed ! As a consequence gdcmFile had to be
1100 declared friend of class gdcmDocument (see below).
1101 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1102 - Clean up of undefined or unused methods.
1103 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1104 account the changes to gdcmHeader.h).
1105 * src/gdcmDocument.h:
1106 - gdcmFile is now a friend class (in order to take into account the
1107 changes to gdcmHeader.h).
1108 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1109 (see changes to gdcmHeader.h).
1110 - Accessors (reading on the form GetEntry*) are now public.
1111 - Clean up of undefined or unused methods.
1112 * src/gdcmDocument.cxx:
1113 - adaptation to changes to gdcmDocument.h
1114 - ::OpenFile now writes a verbose message when file cannot be opened.
1115 - some std::string properly set to VRKey
1116 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1117 references to gdcmDocument.
1118 * Test/TestFindTags.cxx: changed accordingly to above changes.
1119 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1120 cvs repository gdcmData.
1122 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1123 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1124 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1125 conflicts with gdcmValEntry::voidArea.
1126 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1127 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1128 Value representation between StringRepresentable and BinaryRepresentable.
1129 * src/gdcmDocument.cxx:
1130 - method ParseDES: proper indentation restored and usage of
1131 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1132 - method LoadDocEntry: the fingerprint left in the SetValue() of
1133 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1134 removed. Reverting to previous code segment with the proper
1135 dynamic_cast< gdcmValEntry* >.
1136 Note: this was (partially) breaking the python test suite
1137 (gdcmPython/testSuite.py) that made usage of the above
1138 fingerprint to check presence of "Pixel Data".
1139 * src/gdcmDocEntry.h: coding style.
1140 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1141 now taken into account.
1142 * gdcmPython/gdcm.i: adaptation to the new internal representation
1143 of gdcm (exit gdcmParser, hello gdcmDocument).
1144 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1146 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1147 anymore, but instead prints the loaded Python dictionary.
1148 * .... alas, the python testSuite is still broken.
1150 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1151 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1153 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1154 * src/gdcmUtil.h : export methods
1156 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1157 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1159 * Initial addition of automatic python testing
1160 * Initial addition of automatic image comparison
1162 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1163 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1164 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1166 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1167 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1168 * Test/ShowDicom.cxx : bug fix for msvc compilation
1169 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1171 2004-05-04 Jean-Pierre Roux
1172 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1173 new concepts (and new classes) :
1174 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1175 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1176 - Sequence Doc Entries (gdcmSeqEntries)
1177 a Sequence is composed of Items.
1178 Each item is a set of Doc Entries (this is recursive)
1179 The non uniqueness of the 'Dicom tag' is due to this recursivity
1180 (never taken into account)
1181 Our unability to add a new 'entry' in the header
1182 at the proper location (neither in the H-Table (map or multimap),
1183 nor in the Chained List is also due to this recursivity.
1184 Don't try, right now, to use/modify/compile these new sources :
1185 nothing is finished.
1186 We just commit all the stuff, 'as is', in order not to loose it.
1188 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1189 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1191 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1192 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1193 file prefix (SetFilePrefix)
1195 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1196 * Add a new test: ShowDicom, for now this is just the c++ version of
1197 checkRead.sh, later it will be able to compare the image read against a
1199 * Replace the DEBUG on the stack with a global entry in cmake interface:
1200 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1202 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1203 * Add an example subdir, with a real example on how to read + write a
1206 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1207 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1208 * Doc/CMakeLists.txt: the main page is now properly differentiated
1209 between the developper and user version.
1210 * Doc/doxygen.config.in: dropped search related obsolete flags
1211 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1213 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1214 * DEVELOPPER: added some helpfull comments for compile/test/install
1217 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1218 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1219 src directory, now generated in the build dir.
1220 2. Tests as mentionned smarter
1222 4. Add a new method in gdcmDict that return the PubDict by name
1223 this is interesting for 3rd party lib like ITK,
1224 where we could set the institution name / patient name...
1226 * ENH: 1. Now the test suite is working for real
1227 2. All binaries are now output in the gdcm-bin directory
1228 (this was not true before)
1230 2004-04-28 Jean-Pierre Roux
1231 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1232 SeQuence indented printing of Dicom Header.
1233 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1234 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1235 Computation of SQDepthLevel is now part of gdcmHeader constructor
1236 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1237 tree-like structure of a Dicom Header.
1238 * FIX Test code cleaning
1240 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1241 * ENH: Adding automatic testing
1242 1. Need a DartConfig.cmake to submit to public
1243 2. Add a test driver gdcmTest.cxx
1244 3. gdcmTestMain, an helper for the main test driver gdcmTest
1245 4. Files in Test don't have a main anymore, this becomes interesting
1246 when we add more and more tests, thus dsw don't have to load
1248 * ENH: Adding a GDCM_DATA_ROOT for testing
1249 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1250 one file instead of seven + some small cleanup
1252 2004-04-22 Jean-Pierre Roux
1253 * ENH Minor changes to the Print() methods.
1254 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1255 Header printing. Example given with :
1256 > PrintHeader fileName 2 new
1257 (SQ based tree-like structure still to be done for the Header ...)
1259 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1260 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1261 1. I have added some unsigned where needed
1262 2. Some function parameter not used -> (void)
1263 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1264 4. g++ don't like character '\' in comment
1265 5. #define jpeg_create_decompress jCreaDecompress
1266 this really need to be fixed
1267 6. virtualize destructor of gdcmObject ... leakage
1268 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1269 this also really need to be fixed
1270 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1271 remove compression file
1272 (as we only do decompression, right ?)
1273 * ENH: Change malloc/calloc/free with c++ equivalent
1275 2004-04-21 Jean-Pierre Roux
1276 * FIX gdcmHeaderHelper::GetXSpacing
1277 when a single value is found (bug ?), xpacing is now
1278 defaulted to yspacing
1280 2004-04-19 Jean-Pierre Roux
1281 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1282 * ENH add parameters :
1283 bool exception_on_error = false,
1284 bool enable_sequences = false,
1285 bool ignore_shadow = false
1286 to the gdcmFile constructors to be full gdcmParser compliant
1287 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1288 to allow reading of PAPYRUS 3.0 files
1290 2004-04-06 Jean-Pierre Roux
1291 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1293 2004-04-02 Jean-Pierre Roux
1294 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1295 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1296 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1298 2004-03-30 Jean-Pierre Roux
1299 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1300 for ACR file, written out as DICOM files (hope so...)
1302 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1303 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1304 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1305 moved to base class gdcmParser and only the specialisation is kept
1307 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1308 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1309 already does the job.
1310 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1311 (to be consistent with gdcmParser::WriteEntries).
1313 2004-03-30 Benoit Regrain
1314 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1315 upate of the object's instance. It's passed to 2 in the unfavorable
1316 case : one in the ExecuteInformation, one in the ExecuteData
1318 2004-03-29 Jean-Pierre Roux
1319 * ENH : Check on file type to be written moved
1320 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1321 * FIX : gdcmObject::ResetBoundaries now stops properly
1322 when end-of-list is reached
1323 : gdcmVersion modified (as Benoit Regrain asked)
1325 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1326 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1327 * src/gdcmUtil.cxx: added forgotten iostream include.
1328 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1329 equivalent to ExplicitVR in existing code).
1331 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1332 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1333 now contains all the gdcmGlobal related code.
1334 * minor coding style and doxygenation changes.
1336 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1337 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1338 now contains all the Debug related code.
1339 * minor clean-up of includes in src/*.cxx
1340 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1341 CreateCleanString) removed.
1342 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1343 * Doc/DoxyMainPageUser.txt added.
1344 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1345 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1346 src/gdcmDirList.cxx)
1348 2004-03-24 Jean-Pierre Roux
1349 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1351 2004-03-23 Jean-Pierre Roux
1352 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1353 big endian made volumes
1354 * ENH Now gdcmParser constructor and destructor are protected to forbid
1355 end user to instanciate class gdcmParser
1356 (only gdcmHeader and gdcmDicomDir are meaningfull)
1358 2004-03-22 Benoit Regrain
1359 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1360 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1361 gdcmSerie to gdcmDicomDirSerie
1363 2004-03-19 Jean-Pierre Roux
1364 * ENH Now the tree-like structure describing a DICOMDIR comming from
1365 an already existing DICOMDIR file is consistent with
1366 the home-made tree-like structure build ex-nihilo
1367 or build from the files held (recursively) in a Directory
1368 functions gdcmDicomDir::CheckBoundaries()
1369 gdcmObject::SetBoundaries() added
1371 2004-03-17 Jean-Pierre Roux
1372 * REM (Eric Boix bug) : removal of meaningless
1373 gdcmDicomDirImage::NewImage function.
1374 * FIX now file names and directory name are written properly in the
1376 * FIX now gdcmDicomDir constructor may be call without any trick
1379 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1380 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1381 of gdcmDicomDirImage::NewImage as empty function.
1383 2004-02-28 Jean-Pierre Roux
1384 * ENH add gdcmDicomDir:NewPatient
1385 add gdcmDicomDirPatient:NewStudy
1386 add gdcmDicomDirStudy:NewSerie
1387 add gdcmDicomDirSerie:NewImage
1388 to allow making gdcDicomDir object.
1389 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1390 (as opposite to the gdcmHeader chained list)
1392 2004-02-11 Benoit Regrain
1393 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1394 when using from python
1396 2004-02-10 Benoit Regrain
1397 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1398 * FIX : in gdcmDicomDir when the directory is empty
1399 * ENH : add callback and methods to get the progression of dicomDir
1402 2004-02-06 Jean-Pierre Roux
1403 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1404 - GDCM_META added to gdcmDicomDirType
1405 - class gdcmMeta created
1406 * ENH : - A brief summary is now displayed at the beginning of
1407 'testDicomDir' to help disaster magnitude estimation
1408 * REM : Now useless Test/explDICOMDIR.cxx
1410 2004-02-05 Benoit Regrain
1411 * ENH : add methods in gdcmObject to get the hash table or the list of
1413 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1414 * FIX : wrapping python for TagHeaderEntryHT
1416 2004-02-04 Benoit Regrain
1417 * FIX : even length for some strings when writting the dicom dir
1418 * FIX : sort the images in the dicom dir
1419 * FIX : Bug fix for python use of dicom dir
1420 * ADD : a python demo
1422 2004-02-04 Jean-Pierre Roux
1423 * FIX : Final solution (?) for icone embedded images
1424 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1425 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1426 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1427 gdcmData/gdcm-MR-SIEMENS-16.acr1
1428 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1429 to make full checking easier
1431 2004-02-04 Benoit Regrain
1432 * FIX : WriteEntries : coding style & logic in parameters
1433 * FIX : Set the elements to create the DicomDir in a dictionary file
1435 2004-02-03 Benoit Regrain
1436 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1437 * gdcmDicomDir : add the load of directory
1438 * Bug fix and print add-on
1440 2004-02-03 Jean-Pierre Roux
1441 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1442 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1443 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1444 * FIX gdcmParser.cxx : 'group length' elements are now considered
1445 as integers, even for shadow groups, when file is Implicit VR
1447 2004-02-02 Jean-Pierre Roux
1448 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1450 of the last synonym :-(
1451 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1453 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1454 * FIX taking into account the possible 7fe0,0010 multiplicity
1455 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1456 to allow removal of references to 7fe0,0010, to deal with
1457 ACR-NEMA images, when 0028,0200 is meaningfull
1459 2004-01-31 Jean-Pierre Roux
1460 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1461 no longer writes 'Un' on disk
1462 * FIX SQ elements with actual length are now dealt with corectly
1463 * FIX gdcmFile::WriteBase make the difference, for color images, between
1464 the length (for Palette expanded images)
1465 and Raw Length (non expanded image + Palette)
1466 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1467 (that broke Write). Replaced by UL.
1468 Aware user will reload the field if he
1469 thinks it's necesssary
1471 2004-01-30 Jean-Pierre Roux
1472 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1473 when 'dirty Acr' is found, to be compliant with the new
1474 IsReadable() methods.
1476 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1477 (no DOUBLE images in kosher DICOM,
1478 but so usefull for people that miss them ;-)
1480 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1481 DICOMDIR related utilities (not checked as Windoze compliant)
1483 2004-01-28 Jean-Pierre Roux
1484 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1486 2004-01-27 Jean-Pierre Roux
1487 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1488 to allow skipping the shadow elements, to save memory space.
1489 The TRUE value for this param has to be used
1490 with a FALSE value for the 'enable_sequence' param.
1491 ('public elements' may be embedded in 'shadow Sequences')
1492 * gdcmHeader methods now deal with 'embedded icones images' in the header
1493 (even when an 'icone image sequence' is announced by the
1494 element (0x0088,0x0200), but there is NO icone at all ...
1496 * gdcmHeader sometimes Image Location value doesn't follow
1497 the supposed processor endianity (see gdcmData/cr172241.dcm).
1500 * gdcmHeader add the method
1501 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1502 to get *all* the Header Entries with the same tag.
1503 GetHeaderEntrySameName is probabely *useless*
1504 (no meaning : Name is *not* an identifier within the Dictionnary)
1506 2004-01-26 Benoit Regrain
1507 * Bug fix in the print of hexadecimal representations. Remove long fields
1508 in the print and add a third level of print to print them
1510 2004-01-23 Benoit Regrain
1511 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1512 * Bug fix on test suite after remove the strip made on not string fields
1513 * Split the IsReadable method between gdcmParser which test that the file
1514 is dicom and gdcmHeader which test that it's an image file
1516 2004-01-22 Benoit Regrain
1517 * DicomDir : clean code, add methods, set variables in protected or private
1518 * gdcmUtil : bug fix for the clean string method
1520 2004-01-19 Benoit Regrain
1521 * Add the use of shadow dictionaries
1522 * bug fix and coding style
1524 2004-01-19 Benoit Regrain
1525 * src/gdcmFile.cxx : bug fix concerning the close of file
1526 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1527 * Add the update of header entries using the shadow library
1529 2004-01-19 Benoit Regrain
1530 * removal of file gdcmHeader2.cxx
1531 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1532 inheriting from gdcmParser. This split is to prepare the integration
1533 of dicom dir parsing
1534 * bug fix under python
1536 2004-01-16 Jean-Pierre Roux
1537 * REM removal of class gdcmHeaderEntrySet
1538 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1539 * ADD add file gdcmHeader2.cxx
1540 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1542 2004-01-15 Benoit Regrain
1543 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1544 entries created while parsing the header. Thus, they will be destroyed
1545 when the gdcmDictSet will be destroyed
1546 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1549 2004-01-15 Benoit Regrain
1550 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1551 made a fatal error because of the memory release at the end of program.
1552 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1553 some memory and vtk seems to have some problems with that.
1554 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1556 2004-01-14 Benoit Regrain
1557 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1558 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1559 * src/*.[h|cxx] : make changes due to class name changes
1560 * gdcmPython/demo/*.py : bug fix due to method names
1562 2004-01-13 Benoit Regrain
1563 * src/*.[h|cxx] : coding style
1564 * vtk/*.[h|cxx] : coding style
1566 2004-01-13 Benoit Regrain
1567 * gdcmPython/testSuite.py : test the readable flag of file for tests
1568 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1569 It's lied to the stl compilation by MSVC (windows, always windows...)
1570 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1572 2004-01-12 Benoit Regrain
1573 * src/*.h : add comments
1574 * src/gdcmDictSet.h : set the method BuildDictPath in public
1575 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1576 directly setted in the source code
1577 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1580 2004-01-09 Benoit Regrain
1581 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1582 * setup.py : use a reference to gdcmVERSION
1584 2004-01-07 Benoit Regrain
1585 * Modification to compile with the distutils.
1588 2003-12-10 Benoit Regrain
1589 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1590 can use a gdcmHeaderHelper to load datas
1591 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1592 made in the source code
1594 2003-12-10 Benoit Regrain
1595 * Update Windows projects and .cvsignore files
1597 2003-11-12 Jean-Pierre Roux
1598 * ENH gdcmHeader constructor has one more parameter (default value : false)
1599 that allows the user to 'go inside' the SeQuences only
1601 gdcmElValSet:Print takes it into account
1603 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1604 * ENH: Update gdcmPython/CMakeLists
1605 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1606 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1608 2003-11-10 Jean-Pierre Roux
1609 * FIX : gdcmHeader::LoadElements is now based
1610 on the ListTag listElem member,
1611 not longer on the TagElValueHT tagHt member
1612 * ENH : PrintPubElVal shows (temporarily) both results,
1613 with the tagHt member and the listElem member.
1614 (it's easier to 'see' the problems when using Printheader)
1616 * FIX : old private member LgrElem is now splitted into
1617 ReadLength : Length actually found on disk (updated only
1618 if bug fixing is necessary), for internal
1620 UsableLength : Updated by FixFoundLength, to fix a bug
1621 or to allow Parser going on.
1622 Will allow to re-write a kosher header when a SeQuence
1623 with a length (not 0000) is found
1624 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1625 because gdcmElValSet::Add does not update ListElem
1628 2003-11-07 Jean-Pierre Roux
1629 * FIX misstyping in Transfert Syntax name table
1630 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1631 when they have an actual length (not 0000 nor FFFFF)
1632 (Nobody should care of it, but DICOMDIR explorers)
1634 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1635 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1637 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1638 * ENH: vtkGdcmReader now supports LUT !
1639 (vtkgdcmViewer for now is not able to use them though)
1641 2003-11-05 Jean-Pierre Roux
1642 * in testSuite.py : new files names for checking the package
1643 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1644 that returns the pixel area size to the *aware* (vtk) user
1645 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1647 2003-11-05 Benoit Regrain
1648 * in testSuite.py : Modify the rules for checking the paths
1649 : Explicit error messages
1650 * in __init__.py : Related modif
1652 2003-11-03 Jean-Pierre Roux
1653 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1654 to be used by aware (vtk) users that want to manage
1655 LUT (and no to turn the PALETTE image into an RGB pixels one)
1656 * GetPixelType now returns 8U for 24 Bits images
1657 (vtkGdcmReader compliant)
1659 2003-10-31 Jean-Pierre Roux
1660 * Removal of *all* gdcmData images and add them again
1661 in order to loose the 'history' of un-anonymised images
1663 2003-10-31 Jean-Pierre Roux
1664 * RMV : removal of useless jBitsInJsample.h
1665 for both 8 and 12 Bits JPEG Lossy Libraries
1667 2003-10-31 Jean-Pierre Roux
1668 * ENH : Add the functions gdcmFile::GetImageDataRaw
1669 gdcmFile::GetImageDataIntoVectorRaw
1670 that act as GetImageData and GetImageDataIntoVector
1671 except the making of an RGB Plane from Gray Plane + LUT
1672 Intended to aware (vtk) users who know how to manage
1675 GetLUTRGBA return a R,G,B,A LUT if any
1676 lgrTotaleRaw gives the 'Raw' length
1677 GetImageDataRaw returns the gray Plane
1678 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1679 (They stay Grey, just like with other Dicom viewers :-(
1681 2003-10-30 Jean-Pierre Roux
1682 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1684 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1685 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1686 being coherents dicom files.
1688 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1689 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1691 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1692 * ENH: Two steps is necessary to please VC++ compiler...
1693 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1694 * ENH: Add include dir to medcon lib
1695 * FIX: only one function is being exported for now !
1696 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1698 2003-10-29 Jean-Pierre Roux
1699 * adding gdcmHeader::GetLUTRGBA
1700 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1701 --> Mathieu, the modif u're waiting for is not yet committed
1702 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1704 2003-10-27 Jean-Pierre Roux
1705 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1706 00191113.dcm DermaColorLossLess.dcm
1707 MxTwinLossLess.dcm RadBWLossLess.dcm
1708 * ENH: For version prior to vtkImageViewer2 -r 1.19
1709 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1711 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1712 * Removal of ido stuff in CMakeLists.txt
1714 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1715 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1716 * FIX: remove a call to ->Modified ... see comments
1717 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1719 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1720 * FIX: Problem with path for libvtkgdcmPython
1721 * ENH: Try adding a search script for python site-package
1722 * RMV: Remove some file from medcon lib that are not necessary
1723 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1724 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1725 * FIX: More pragma disable fro VC++,
1726 I don't think I break something as it is also disable in VTK/ITK.
1727 But it fasten debug compilation time.
1729 2003-10-23 Jean-Pierre Roux
1730 * gdcm now deals with 16 Bits Run Length Encoded images
1731 (they are compressed as 2 planes images,
1732 one for the high Bytes, the other for low Bytes)
1734 2003-10-22 Jean-Pierre Roux
1735 * Now CheckRead takes into account :
1736 - the bugged 'Leonardo' Siemens images
1737 - the XA images, sent thru the burning VPRO station
1738 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1741 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1742 * FIX: When copying a Makefile.am to CMakeLists.txt
1743 one should remove the '\'
1745 2003-10-22 Jean-Pierre Roux
1746 * in gdcmData adding a bugged 'Leonardo' Siemens image
1747 (wrong lengths in header)
1748 OK with gdcm, KO with the other viewers :-)
1749 * add a GE dlx XA image, thru the VEPRO burning station
1752 2003-10-21 Jean-Pierre Roux
1753 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1754 for a brutal checking of vtkgdcmViewer compliance
1756 2003-10-21 Jean-Pierre Roux
1757 * add the files for 'xmedcon' Jpeg Lossless library
1758 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1760 2003-10-21 Jean-Pierre Roux
1761 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1763 2003-10-21 Jean-Pierre Roux
1764 * garbage Siemens 'Leonardo' images dealt with
1765 (the patch is easy to remove)
1766 * cosmetic changes to avoid warnings
1768 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1769 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1770 no need to press 'r' now.
1772 2003-10-20 Jean-Pierre Roux
1773 * upgrade of checkRead.sh checkWrite.sh according
1774 to new Jpeg Lossless decompressor
1775 * add US.3405.1.dcm, a genuine RGB medical file ...
1776 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1777 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1779 2003-10-15 Jean-Pierre Roux
1780 * general anonymisation in gdcmData
1781 * adding the 'color files' from
1782 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1783 * adding some well knowed bugged-header images
1784 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1785 waiting for their inclusion in Python testsuite
1787 2003-10-15 Jean-Pierre Roux
1788 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1789 no longer seg faults when file is not found
1791 2003-10-14 Jean-Pierre Roux
1792 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1795 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1796 * TODO: *.in file to genereate a UseGDCM later
1798 2003-10-14 Jean-Pierre Roux
1799 * Some supposed-to-be Dicom Images have no preamble.
1800 OpenFile takes it into account
1801 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1802 * Missing elements added in dicomV3.dic
1803 (just to be affraid : have a look at
1804 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1805 and do it again next year ;->
1807 2003-10-13 Jean-Pierre Roux
1808 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1809 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1810 But there are NOT. It's fixed !
1812 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1813 * FIX: "jpeglib.h" was not found on VC++
1814 * FIX: vtkgdcm was not being installed
1816 2003-10-10 Jean-Pierre Roux
1817 * ENH : OpenFile closes the file if it *really* doesn't look like
1818 an ACR-NEMA / DICOM one.
1819 * FIX : testWrite no longer writes an empty file if the source file
1820 is not gdcm Readable
1821 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1824 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1825 * FIX: CMake generate now documentation
1826 * ENH: out of source doc build !
1827 * ENH: Generate both user and dev documentation
1828 * ENH: Should work on windows too
1829 * ENH: Only one doxygen config.in file is needed
1830 * FIX: make install should be ok now on ùnix plateform
1831 * FIX: PATH to dictionary was wrong (missing /)
1832 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1834 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1835 * vtkGdcmReader is now able to read rgb dicom file.
1836 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1837 * added a gdcmViewer to vtk test, use mouse to control
1838 window level & window width
1840 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1841 * CMake-ification of gdcm, we have now two build system
1842 * FIX: on cygwin Wsock32 doesn't exist
1843 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1845 2003-10-06 Emanuel Ollart
1846 * FIX : compilation process wad broken.
1847 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1849 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1850 * change gdcmViewer -> vtkgdcmViewer
1851 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1853 2003-10-06 Jean-Pierre Roux
1854 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1855 ( e.g : well known GE images with a wrong elem length,
1856 : Philips MRI Images with a wrong Huffman table)
1857 * still to be done : allow the reading of bugged LEONARDO Siemens images
1859 2003-10-03 Jean-Pierre Roux
1860 * Odd length strings are padded with '\0' (not with spaces,
1861 to remain compliant with already defined strings,
1862 like Transfert Syntax UID and others)
1864 2003-10-03 Jean-Pierre Roux
1865 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1866 to allow displaying RGB images (not only by affim ;-)
1868 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1869 * vtkGdcmReader is now able to read rgb dicom file.
1870 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1872 2003-10-03 Jean-Pierre Roux
1873 * A few nasty patches to allow the reading of a lot of nasty images
1874 ( e.g : well known GE images with a wrong elem length,
1875 : Philips MRI Images with a wrong Huffman table)
1876 * still to be done : allow the reading of bugged LEONARDO Siemens images
1878 2003-10-03 Jean-Pierre Roux
1879 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1881 2003-10-03 Jean-Pierre Roux
1882 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1883 to allow displaying RGB images (not only by affim ;-)
1885 2003-10-03 Jean-Pierre Roux
1886 * gdcmFile::GetImageDataIntoVector now
1887 - deals with MultiFrames MultiFragments Run Length Encoded files
1888 - deals with YcBcR (YBR_FULL) files
1889 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1890 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1892 (no sample found :-(
1894 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1895 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1896 Two reasons: - clear things
1897 - third parties acces gdcm through header files, so won't
1898 suffer anymore VC++ complains
1900 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1901 * add argv[1] in testvtkGdcmReader.cxx
1904 2003-09-24 Jean-Pierre Roux
1905 * The lines are now eigthy characters long.for
1906 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1908 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1909 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1910 char* to std::string. Thus, the use of strdup becomes useless. (see
1911 previous commis of Malaterre)
1912 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1913 before the last Malaterre's commit.
1915 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1916 * This commit should fix the Debug building under VC++, the problem
1917 was mainly a mixture of debug and release lib being loaded at startup.
1918 * I also remove a depency to a specific C function: strdup. Because I had
1919 to force the link to msvcrtd (whereas strdup is in libc).
1921 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1922 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1923 located in the gdcmCommon.h file. All use of reference of tha has been
1924 changed to now use the variable GDCM_UNFOUND.
1926 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1928 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1929 Dicom dictionary. The test suite can now be run again. Note:
1930 I'm note very happy with the " (RET)" changes. I believe this
1931 RETAINED comment should be dropped when parsing the dictionary.
1932 - PACKAGER corrected
1934 - AUTHORS updated and now in alphabetical order
1935 * Makefile.am now exports gdcm.dsw for Windoze users.
1937 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1938 * cygwin complains about missing std:: in subdir Test/
1940 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1941 * remove some methods that are now in gdcmHeaderHelper
1943 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * vtkGdcmReader set spacing and origin correctly
1946 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1947 * Fix a few delete/delete[] mismatch
1949 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1950 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1951 interpretation to data given by gdcmHeader. For instance there are
1952 heuristics to get informations (look at different places).
1953 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1954 sorting DICOM images based on different strategies.
1955 * modified Makefiles accordingly.
1957 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1958 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1959 when building in debug mode
1960 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1961 src/win32/gdcmdll.dsp
1962 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1964 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1965 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1968 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1969 * src/win32/libgdcmjpeg12.dsp was not dos format
1970 * src/win32/libgdcmjpeg12.dsp :
1971 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1972 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1974 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1975 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1977 * src/gdcmFile.cxx : bug fix in affectation type
1978 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1979 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1980 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1981 symbols... future problem ?
1983 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1984 * src/win32/libgdcmijpeg12.dsp was missing
1985 * modified gdcm.dsw accordingly
1987 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1988 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1990 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1991 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1992 commit of JPR (before his hollidays to facilitate our work).
1993 * setup.py : bug fix in code. Modifications made while the last commit
1994 of JPR. The code hasn't been tested before the commit... it's so
1995 useless to make that (for best programmer that is JPR) !!!
1997 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1998 * tagged the current version as Version0_3 (i.e. version 0.3)
2000 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2001 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2002 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2003 * *.dsp : modifications to use new libgdcmijpeg8 library
2004 * setup.py : bug fix on VTKPATH variable
2005 * PACKAGER : adding all concerning windows
2007 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2008 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2010 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2011 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2012 test suite reported error.
2013 * PACKAGER file added (describes what a packager must do when
2014 packaging a new release).
2015 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2016 * configure.in: upgraded version number to 0.3.0
2017 * fixing build of rpm (through rpm -ta):
2018 - Doc/Makefile.am exports proper doxygen files
2019 - src/jpeg/libijg8/Makefile.am exports the include files.
2021 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2022 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2023 * src/gdcmHeader.h : formatting code
2025 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2026 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2027 We were obtaining error message from vtk. Now, creation of file list
2028 is made in an internal list to prevent this problem.
2029 Bug fix when output is empty.
2030 Bug fix in update of progress value. Previous commit for this was a bad
2032 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2034 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2035 * src/gdcmHeader.h : added method to get the file name
2036 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2037 files. Added method to remove all files on the input
2038 Added FIXME comment concerning the bad parsing of header made by
2039 ExecuteInformation method (in ExecuteData method)
2041 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2042 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2043 when using make instal.
2044 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2045 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2047 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2048 * setup.py : adding include dir of jpeg lib to compile all sources
2049 * */Win32/*.dsp : JPR fix for windows compilation
2051 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2052 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2054 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2055 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2057 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2058 * setup.py is again effective on un*x (takes into account the
2059 addon of the jpeg library)
2060 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2061 * Doc/Doxy* updated (includes above enhancements)
2062 * INSTALL now points to web documentation
2064 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2065 * src/gdcmHeader.h doesn't make unnecessary reference to
2067 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2069 * src/gdcm*.[cxx|h] :
2070 - to allow compilation with gcc 3.x
2071 -- clean up of STL usage (added explicit usage of std::)
2072 -- small fixes on exceptions.
2073 Note: linking not tested !
2074 - clean of doxygen comments to avoid warnings at documentation
2076 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2077 dependent convertion).
2079 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2080 * Clean up of previous JPR garbage commit (not even commented in the
2082 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2083 - moved all jpeg related files from src to src/jpeg/libijg8, with
2084 addition/modification of Makefile.am and configure.in.
2085 - the testSuite is still brain damage (not guilty).
2087 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2088 * WrapVTK.py : modifications to get correctly vtk source files to
2090 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2091 (FileName -> Filename)
2093 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2094 * vtk/vtkGdcmReader.[cxx/h]:
2095 - UpdateProgress method should now be effective
2096 - removed the limitation on having only images loaded (as opposed
2098 - when building a stack of images/volume, a lesser number of
2099 gdcmHeader and gdcmFile instances should be used (hopefully
2100 accelerating things).
2101 - when building a stack of images/volumes, files which are not
2102 loadable (wrong path-filename, wrong permissions on existing file,
2103 or file not parsable by gdcm) are replaced with a black image
2104 in the stack (for the caller to notice the problem).
2106 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2107 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2109 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2110 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2111 between standard library (std) and vtk library (problems are found
2112 under Windows... thanks Windows !)
2114 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2115 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2117 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2119 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2120 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2122 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2123 * When compiling with distutils (see setup.py) the C++ compiler is
2124 called with different flags than the default ones (with automake).
2125 In order to fix all those warning, I compiled gdcm with the command
2126 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2127 and went for warning fixes:
2128 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2129 up from unused variables.
2130 - vtk/vtkGdcmReader.cxx: potential bug fix.
2131 * src/gdcmHeader.h: Doxygen warning cleanup
2133 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2134 * gdcmPython/gdcm.i:
2135 - typemaps correction to take into account the systematic replacement
2136 of "using namespace std" with std:: prefix e.g. std::list,
2137 std::string... (cf changes of 2003-05-21).
2138 - gdcmGlob global variable of type gdcmGlobal (defined in
2139 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2140 exported to Python a as cvar.
2141 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2142 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2143 gdcmDictSet.GetPubDictTagNames() and
2144 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2145 C++ static methods).
2146 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2147 with the above changes.
2149 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2150 * setup.py, manifest.in : bug fix under linux
2152 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2153 * Modification of setup.py to compile vtk part too. Then, we have 2
2154 wrappers which must work with same distutils. For that, we have a
2155 generic distutils in distusiltsWrapping.py ; with :
2156 - build_extWrap class to wrap generically all extensions,
2157 - ExtensionWrap base class for all wrapping extension that contains
2159 - Wrapper interface which wrap sources
2160 + In WrapSwig.py we have extension and wrapper for Swig
2161 + In WrapVTK.py we have extension and wrapper for VTK
2162 * MANIFEST.in : modifications to consider vtk directory and new python
2163 files for compilation
2165 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2166 * Added python wrappers of vtkGdcmReader vtk class (see the
2167 source in vtk/vtkGdcmReader.cxx) :
2168 - vtk/Makefile.am now builds a library
2169 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2170 python library (as opposed to _gdcm.so wich are the python
2171 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2172 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2174 - configure.in has an additional flag --enable-vtk that needs
2175 to be set to enable compilation of vtk related code, that is:
2176 + vtk/vtkGdcmReader.so and
2177 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2178 + gdcmPython/vtkgdcmPython.so (see above)
2179 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2180 be read when compressed or when HighBit + 1 != BitsStored),
2181 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2182 the usage of the python wrapper of vtkGdcmReader vtk class.
2183 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2184 * src/*.[h] all occurences of stl classes are now prefixed with
2185 std::, and all occurences of "using namespace std;" where removed.
2186 This is to avoid pollution of global namespace in included files.
2187 Apparently vtk does not avoid this pitfall: when using both
2188 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2189 collision of various stl members (principally cout...).
2190 * gdcmPython/testSuite.py now cleanly removes temprory generated
2192 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2193 comply with above changes)
2195 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2196 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2197 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2198 vtk data structure (an image Flip was required).
2199 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2200 * cosmetic changes in documentation.
2202 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2203 * src/gdcmHeader.cxx: the constructor no longer exits when an
2204 unexisting file is given as argument.
2205 * The subdirectory Data (containing all the images used for the
2206 test suite) is not part of this repository anymore. A new module
2207 containing those images is now available at
2208 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2209 with the name gdcmData.
2210 All the python scripts (including the package initialisation file
2211 gdcmPython/__init__.py) were adapated to take this change into
2212 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2214 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2215 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2216 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2217 demo of the usage of this class.
2218 Compilation of this vtk part is only done when using the --enable-vtk
2219 at configure (or autogen.sh) stage.
2221 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2222 * More memory link related corrections and documentation fixes.
2224 - maximum info is obtained with a command of the form:
2225 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2226 --show-reachable=yes PrintHeader
2227 - the remaining reachable blocks seem to come from the STL
2228 allocation scheme through the usage of map and list. It looks
2229 like this memory cannot be freed but it is not a memory leak
2230 (in fact further invocation to the STL would recollect the
2231 unused memory allthough it cannot explicitely be freed).
2232 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2233 of displaying an image parsed with gdcm and displayed with VTK.
2234 Note: some images don't seem to work e.g.
2235 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2236 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2237 Allthough this weakens the semantics, it is a ditch attempt to
2238 make gdcm more thread friendly.
2240 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2241 * Memory link hunt (by using valgrind through the command
2242 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2243 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2244 gdcmHeader::_dicom_vr.
2245 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2246 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2248 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2250 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2251 * src/Makefile.am now exports all the necessary include files at
2255 * UpdateGroupLength replaced by new one
2258 * UpdateGroupLength re-written using H-Table
2259 (named UpdateGroupLengthNew untill checks are over)
2261 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2262 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2263 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2265 - gdcmHeader::GetPubElValSet removed.
2266 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2267 UpdateGroupLength, WriteElements, Write.
2268 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2269 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2270 carried the same semantics.
2271 - src/gdcmHeaderIdo.cxx changed accordingly.
2272 - gdcmFile::WriteBase now regroups all the codes from previous
2273 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2274 - enum FileType moved to gdcmCommon.h
2275 * src/gdcmHeader.cxx AddDefault trashed
2276 * gdcmGetXSize added
2277 * getimageDataSize now calls gdcmGetXSize
2278 * Test/*.cxx changed to agree with above changes
2280 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2281 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2282 (to avoid double call by end user).
2283 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2284 by end user, since gdcmHeader::gdcmHeader now handles it.
2286 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2287 * gdcm/Doc many doxygen changes:
2288 - Doxyfile now has two different versions, DoxyfileUsers that generates
2289 the html.users end users oriented documentation and
2290 DoxyfileDeveloppers that generates the html.developper developper
2291 oriented documentation.
2292 - README changed accordingly
2293 - requirement.txt removed (old design info moved to TODO).
2294 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2295 DoxyMainPage.txt, DoxyPython.txt provide more information.
2296 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2297 be updated by simply regenerating the docs with doxygen and copying
2298 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2299 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2300 all the tests in the form "if (<map>.count() >1)" were removed.
2301 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2302 ill-formed documentation sections.
2303 * src/gdcmHeader.cxx: ditto
2305 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2306 * setup.py fixed for un*x (needed macro for stdint.h)
2307 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2308 un*ces with sh-utils test utility.
2309 * gdcmPython/demo/test.py renamed to PrintHeader.py
2310 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2311 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2312 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2313 * src/gdcm*.cxx JPR's bad inclusion fixed.
2315 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2316 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2317 * gdcmPython/demo/test.py changed accordingly.
2319 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2320 * gdcmPython/Makefile.am fixed linking against libstdc++
2321 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2322 * Swig subdir (historical tests of swig version 1.3.17++) removed
2323 * Test/testChangeEntete.cxx some lines commented out in order to make
2325 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2326 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2328 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2329 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2330 hence the user doesn't need this explicit call.
2331 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2332 i.e. LoadElements() call removed.
2333 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2334 - src/Makefile.am declares the proper flag for g++.
2335 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2336 for adding user defined new tags.
2337 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2338 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2339 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2341 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2342 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2343 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2344 src/Makefile.am : the project should properly compile and install
2345 with the autotools, included the python wrappers part.
2346 * gdcm.spec.in : added a spec file for RPM packaging.
2348 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2349 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2351 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2352 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2353 to exported to the environement (see gdcmPython/testSuite.py
2355 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2356 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2357 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2358 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2359 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2361 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2362 * gdcmPython/__init__.py doesn't crash anymore when running in
2363 in InstallMode or PreInstallMode but with an environement given
2364 value of GDCM_DICT_PATH.
2365 * src/gdcmDictSet.[cxx/h] coding style.
2367 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2368 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2369 * src/gdcm.h general comments moved to TODO, and README
2370 * src/gdcm.h should now be seen as a user commodity (including it
2371 should suffice to fully use gdcm). It is nowhere including within
2372 any of the kernel files src/*.cxx and src/*.h.
2374 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2375 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2376 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2378 * src/gdcm*.cxx only include their corresponding include file
2379 (as opposed to gdcm.h)
2380 * gdcmPython/gdcm.i changed accordingly
2381 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2382 the autogen.sh generated "make snapshot" command to work.
2383 * autogen.sh removed history related references to crea package.
2385 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2386 * distutilsSwigCPlusPlus.py work around some swig portability
2389 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2390 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2391 was done in a last ditch attempt to get setup.py _really_
2392 operationnal. The python/gdcmPython layaout add the advantage
2393 of hidding away the python related distutils specific files
2394 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2395 Alas, the src directory was out of scope (i.e. it's relative
2396 position to setup.py was ../src) which made things impossible to
2397 handle (see previous version of python/setup.py). Crossing fingers...
2399 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2400 * python/setup.py now works on Un*x. (harder than I thougth)
2401 * python/distutilsSwigCPlusPlus.py can now have include files
2402 among the list of sources.
2404 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2405 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2406 * modifications in MSVC projects
2408 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2409 * As stated by the first lines of Test/ExceptionAndPython/README, it
2410 looks like we can move back to original usage of exception within
2411 src/gdcm* and hence remove the errno stuff that was introduced
2412 as a quick and dirty fixture of this problem (added to the TODO).
2413 * Doc/Doxyfile configuration file for Doxygen and corresponding
2414 README file for usage added.
2415 * Test/testWrite.cxx added. This new test comes from a split of
2416 test.cxx that is now reverted to its original purpous i.e.
2417 testing the proper parsing of a Dicom related file.
2418 testWrite.cxx concentrates on testing the IO part of gdcm.
2419 * Test/bug1.cxx (containing a bug on WIn32) added.
2420 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2421 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2422 whose purpose is to publish the content of the TagNames of the
2423 Dicom public dictionnary were not accessible without an
2424 instance of class gdcmHeader.
2425 - those methods are now static methods of gdcmDictSet and hence
2426 require no instances at all to be invocated.
2427 - within gdcmDictSet this change required to change some method
2428 to class methods (i.e. are now static) among which SetDictPath
2429 (renamed to BuildDictPath) and LoadDefaultPubDict.
2430 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2431 the above changes by calling the new method classes of gdcmDictSet.
2432 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2433 the above to be effective.
2434 * python/gdcmPython: in order to wrap properly the above changes
2435 for Python, swig version now needs to be > 1.3.17.
2436 * python/gdcmPython/Makefile fixed to adapt itself to new
2437 configure/make shema introduced by Johan Montagnat (thanks for the
2438 contribution). Alas this Makefile cannot be turned into a proper
2439 Makefile.am without some heavy changes in the configure.in
2440 (for python dectection).
2441 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2442 now avoids publishing the empty entries.
2444 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2445 * python/setup.py : bug fix concerning install under windows
2446 ExtraPath reused :-P
2447 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2449 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2450 * Dicts/dicomV3.dic : remove double spaces !!!
2451 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2452 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2455 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2456 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2457 method. Doxygenation.
2458 * src/gdcm.h clean up of JPR spurious comments.
2460 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2461 * python/distutilsSwigCPlusPlus.py now properly collects the
2462 shadow classes generated by "swig -c++" (gdcm.py in our case)
2463 when using "python setup.py install".
2464 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2465 reexports the working classes.
2466 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2467 by the classical C errno scheme. This is to prevent an obscure
2468 behavior of the python wrappers when importing wxPython.wx prior
2469 to gdcmPython (which ended up in an abort call). An illustration
2470 of this oddity can be found in the Test/ExceptionAndPython
2471 subdir (see the README file). This problem probably due to
2472 an combination of g++ and dynamic loading.
2473 * added Test/ExceptionAndPython (see above)
2475 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2476 * Changed the layout of the python part to avoid bloating main
2477 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2478 i.e. the distutils arsenal. All the python related stuff is
2479 again in a python subdir, but the package itself is now in
2481 * setup.py was cleaned up:
2482 - pythonIncludePath removed
2483 - python setup.py bdist target is now functional.
2484 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2485 collision with other packages). gdcmPython/demo/*.py changed
2488 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * python subdir moved to gdcmPython (preparation of distutils packaging).
2490 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2491 distutils installer is operational.
2492 * - gdcmPython/__init__.py now properly loads the swig generated
2493 shadow classes (from gdcm.py).
2494 - gdcmPython/demo/*.py changed to import the package gdcmPython
2495 instead of gdcmPython/demo/load.py.
2496 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2498 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2499 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2500 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2501 entries within the associated public Dicom dictionary resp. the same
2502 information but sorted by the fourth field (PAT, IMG, DIR) of the
2504 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2505 are now in the "???" group.
2506 - python/gdcm.i changed accordingly,
2507 - python/demo/printGroupedPublicDict.py added, that gives an example
2508 of the above new functionalities in Python.
2510 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2511 * src/gdcm.h, gdcmHeader.cxx:
2512 - historic references to glib's g_malloc and g_free (#defined)
2513 were definitively removed.
2514 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2515 * src/gdcmElValSet.cxx:
2516 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2517 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2518 - GetElValue(string) renamed to GetElValueByName.
2519 - Added GetElementByName(string).
2520 * src/gdcmHeader.cxx: added
2521 - GetPubElValRepByNumber(guint16, guint16)
2522 - GetPubElValRepByName(string)
2523 - GetShaElValRepByNumber(guint16, guint16)
2524 - GetShaElValRepByName(string)
2525 - GetShaElValByNumber(guint16, guint16)
2526 - GetShaElValRepByName(string)
2527 - GetElValRepByNumber(guint16, guint16)
2528 - GetElValRepByName(string)
2529 - GetElValByNumber(guint16, guint16)
2530 - GetElValRepByName(string)
2531 * Doc/requirements.txt added.
2533 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2534 * Test/Makefile building now depends on the one of libgdcm.so
2535 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2536 pixel data) aware which enables finding the address (offset) of
2537 the pixel data of JPEG encoded DICOM files. This leaves only a single
2538 file in the testSuite whose pixel data address (offset) is unknown.
2539 * python/testSuite.py changed accordingly.
2541 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2542 * VC++ has some strong limitations when working with the STL, as stated
2543 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2544 "Also note that some STL containers (map, set, queue, list, deque)
2545 cannot be exported. [...]
2546 Some STL classes contain nested classes. These classes can not
2548 This is caused by a designed limitation that once a template
2549 class is instantiated, it can not be re-instantiated and
2551 Since our usage of map<> is ubiquitous in gdcm, this "designed
2552 limitation" of VC++ is a pitfall.
2553 Hence the Python wrappers of gdcm cannot be incrementally linked
2554 against the c++ dynamic library. The dirty but only workaround is
2555 to forget about incremental link of dynamic libraries and to generate
2556 the Python wrappers library with the inclusions of the underlying C++
2558 The following modifications concern this matter on Win32/VC++:
2559 - wrapping python correct with standalone wrapped dll (don't use separate
2560 dll under windows !!!!)
2561 - python21_d debug mode enabled (ask Frog how to use it :-)
2562 - NO problem with having an STL member of class for example string in C++
2563 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2564 - Python test of dcmlib in Python is ok under windows on a large set
2566 * removed glib references
2567 * typedef's inserted in gdcm.i for correct swig type management
2569 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * python/demo/*.py load.py extracted from test.py. Added explore.py
2571 that only displays required tags and testAll.py that parses all
2572 the files of the testsuite without using unittest.
2573 * python/testSuite.py other additional test on new files added.
2574 * Data/* new test files added accordingly to the testSuite.
2575 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2576 the vr in the file differs from the one of the dictionary.
2578 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2579 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2580 values, but limits itself to values which are below a user specified
2581 size (by default 1024 bytes).
2582 * python/gdcm.i : elements not loaded (because their size is above the
2583 user specified treshold) are exported with their TagKey as key of the
2584 python dictionary. This enables the testsuite to make some checks
2585 on the unloaded elements (since we have their offset and size).
2586 * python/testSuite.py
2587 - now tests for the existence and proper value of the pixel data
2588 - two new examples added.
2589 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2591 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2593 aware. See the strategy comments in gdcmHeader::FindeLength().
2594 * Test/test.cxx now accepts a filename as first argument.
2595 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2596 * python/testSuite.py changed to integrate test on above files.
2598 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2599 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2600 the vr was also RET.
2601 * python/testSuite.py more tests added.
2603 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2604 * python/testSuite.py unittest test suite added (uses Data)
2605 * Data/* dcm and acr files for the test suite.
2606 * glib dependance removed from un*x version. We now use ISO C99
2607 7.18 Integer types (see stdint.h)
2608 - python/Makefile, src/Makefile src/gdcm.h
2609 * src/ when an explicit vr (like dicom files) suddenly poped an
2610 implicit element we use to mark the underlying DictEntry of the
2611 concerned ElValue with "Implicit". This strategy was damageable
2612 too the public or provite dictionaries, since some of their vr
2613 would be changed. Since Header::FindLength heavily relies on the
2614 detection by Header::FindVR of falsely explicit elements, I
2615 added an extra ImplicitVr member to ElValue (boolean).
2616 The rest of the changes we the necessary adaptations.
2618 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2619 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2621 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2623 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2624 * Adaptation for porting to VC++:
2626 o forced to use std namespace (for string to be known)
2627 o all class use __declspec export style on WIN32
2628 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2629 (in stdlib.h on Win32 but in std:: for gcc)
2630 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2631 variable GDCM_DICT_PATH.
2632 * src/gdcmHeader.cxx verbose comments made discrete.
2634 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2635 * python/gdcm.i: added a typemap that converts a C++ hashing table
2636 to native Python dictionary.
2637 * python/demo/test.py:
2638 - now uses the native dictionary for exploration of gdcmHeader.
2639 - takes an optional filename argument (the file to parse).
2640 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2641 PubElVals hashing table.
2642 * Dicts/dicomV3.dic removed error prone trailing spaces.
2644 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2645 * Python wrapping process moved away from src/Makefile to
2646 newly created python/Makefile (as well as gdcm.i)
2647 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2648 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2649 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2650 from the environement variable GDCM_DICT_PATH (when existing).
2651 * src/gdcmDict::GetTag bug fix.
2653 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2654 * Straightforward temporary fixes for swig to build the python wrappers.
2655 src/Makefile now has a python working entry [by working we mean
2656 that we can import de shadow classes without errors].
2658 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2659 * hashtest.cxx removed (since allready in Test)
2660 * src/gdcmlib.h renamed to src/gdcm.h
2661 * src/dcm.i renamed to src/gdcm.i
2662 * src/Makefile prepared for python wrapping
2664 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2665 * src/gdcmHeader.cxx :
2666 - Parsing of header is now separated from loading of element values
2667 (see gdcmHeader::LoadElements).
2668 - general clean up of hopefully all file access (creation of
2669 ReadInt16 and ReadInt32)
2671 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2672 * src/gdcmHeader.cxx :
2673 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2675 - SetLgrElem renamed to SetLength
2676 - GetLgrElem renamed to GetLength
2677 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2678 * src/gdcmElValSet.cxx fixed both GetElValue methods
2679 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2680 due to IdoDude was cleaned out.
2682 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2683 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2684 concentrates on finding the value representation (when it exists).
2685 RecupLgr now only finds the element value length, and it avoids
2686 returning the unecessary skL (skipped length).
2687 Also, offsetCourant was simply removed (with taille_fich) since
2688 it was redundant with the File position internals (by using
2689 ftell and fseek). This also made skL (see above in RecupLgr) usage
2691 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2692 on the libido specificities which are handled through class
2694 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2697 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2698 * Truckload of changes. Parsing of header is barely functional
2699 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2701 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2702 * src/gdcmHeader.cxx many addons of low level methods
2704 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2705 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2706 and _IdDcmSWAP_LONG.
2708 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2709 * This corresponds to all the changes decided at the meeting of
2710 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob