1 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2 * src/gdcmDocEntrySet.[h|cxx], gdcmDocument.[h|cxx] : amelioration of
3 ValEntry, BinEntry, SeqEntry creation or replace
5 2005-01-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
6 * src/gdcmDictEntry.h : now, the IsVRUnknown is correct
7 * src/gdcmDocument.[h|cxx] : simplify the search of VR value when parsing
9 * src/gdcmDocEntrySet.cxx : now the created DocEntry without values is good
10 when specifying the VR
11 * src/gdcmVR.[h|cxx] : add usefull method to test the validity of a VR
12 * src/gdcmDocEntry.cxx : amelioration of print
14 2005-01-05 Jean-Pierre Roux <jpr@creatis.univ-lyon1.fr
15 * ADD : Add the method Util::IsCurrentProcessorBigEndian
16 (we'll need it for 'Explicit VR Big Endian' Transfert Syntax)
17 * ADD Method Document::ComputeGroupLength
18 * ENH : now parsing creates a Vitual DictEntry for Pixels Element,
19 in order to allow further VR modification by user
20 * REM : removal of once-called method File::WriteBase
21 integration of its code in formerly one-line method File::Write
23 2005-01-05 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
24 * src/gdcmCommon.h : add the GDCM_UNKNOWN constant. This constant is to
25 replace the different values "??", "Unkn", "Unknown".
26 * src/gdcmDicomDirElement.h, gdcmDictEntry.h, gdcmDictSet.h,
27 gdcmDocEntry.cxx, gdcmDocEntrySet.[h|cxx], gdcmDocument.h, gdcmSQItem.cxx,
28 gdcmVR.cxx : use the GDCM_UNKNOWN constant.
29 * Appears a bug in gdcmDictEntry : IsVRUnknown always returns false... bad
31 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
32 * src/gdcmBase.[h|cxx] : new base class. Contains the PrintLevel and an
34 * Set the gdcm::Base class to some Printable classes
36 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
37 * src/gdcmFile.[h|cxx] : add the Print method
38 * src/gdcmPixelReadConvert.[h|cxx] : add the generalized Print method
39 * src/gdcmDocEntrySet.h : generalize the Print with the PrintLevel
40 * src/gdcmDocument.h : remove the PrintLevel informations
41 * Example/PrintFile.cxx : use the new gdcm::File::Print
43 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
44 * src/gdcmFile.cxx : Add the code of ReplaceOrCreateByNumber to not have
45 problems when compiling with the python wrapping
47 2004-12-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
48 * src/gdcmFile.cxx : bug fix. Omitted a Push in the DocEntryArchive when
49 writting in ImplicitVR
51 2004-12-12 Jean-Michel Rouet <jm.rouet@noos.fr>
52 * src/gdcmPixelReadConvert.[h|cxx], src/gdcmJpeg*.cxx : new handling of
53 JPEG decompression, especially when dicom frames are split into several
54 JPEG Fragments. This makes use of jpeg decompression from memory buffer.
55 This solves reading for example gdcm-JPEG-Lossless_Thoravision.dcm.
57 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
58 * src/gdcmHeader.cxx : change the initialisation of default header.
59 Now, this header is readable by gdm, e-film, DicomWorks
61 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
62 * src/gdcmFile.[h|cxx], gdcmPixelReadConvert.[h|cxx] : change the API.
63 Rename Decompressed to Raw
64 * Use the API changes in gdcm::File.
65 * vtk/vtkGdcmWriter.[h|cxx] : add the possibility to write in other modes
68 2004-12-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
69 * vtk/vtkGdcmWriter.cxx, Example/WriteDicomSimple.cxx : add comments for
70 each added entry in the header. Replace the 'Planes' field by the 'Number
73 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
74 * vtk/vtkGdcmWriter.[h|cxx] : now can write stack of images.
75 * vtk/vtkWriteDicom.cxx : can write 2D stack or 3D image
77 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
78 * Example/WriteDicomSimple.cxx : example to write a dicom file from nothing.
79 At this time, this image isn't readable by e-film... waiting JPR help to
82 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
83 * src/gdcmPixelReadConvert.cxx : bug fix when would forcing load of a
84 DocEntry. Now use methods of the Document !
86 2004-12-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
87 * Test/ShowDicomSeq.cxx : bug fix
89 2004-12-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
90 * vtk/vtkGdcmReader.[h|cxx] : bug fix. Plane order isn't inverted
91 * vtk/vtkGdcmWriter.[h|cxx] : correctly write images (the Y axis is inverted)
92 * Test/ShowDicomSeq.cxx : new test to verify the use of AddFileName method
93 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : set the threshold of regression
95 * Test/TestCopyRescaleDicom.cxx : remove unused variable
96 * Test/CMakeLists.txt : add the creation of the gdcmDataSeqImages.h file
97 containing found sequences
99 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
100 * Test/ShowDicom.cxx, TestWriteWithVTK.cxx : bug fix, now this test pass
102 * Test/TestCopyRescaleDicom.cxx : rearrange the test to correctly pass...
103 Some fields in BinEntry must be copied to not seg fault when making the :
104 gdcm::File *copy = new gdcm::File( copyH );
105 and tests are now made on good variables
107 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
108 * vtk/vtkGdcmWriter.[h|cxx] : add a first version of vtkGdcmWriter
109 * src/gdcmValEntry.cxx : bug fix when setting the value. Problems of odd
111 * src/gdcmHeader.cxx : Remove a useless call to Util::DicomString
112 * Add vtkGdcmWriter example and test
114 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
115 * Test/TestUtil.cxx : reformat the source code
116 * vtk/vtkGdcmReader.cxx : remove and change prints
117 * src/gdcmValEntry.[cxx|h] : now set the length of the value when calling
119 * src/gdcmBinEntry.[cxx|h] : SetValue method don't set the length
120 * src/*.cxx : remove all useless call to SetLength of a ValEntry object
122 2004-12-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
123 * src/gdcmPixelWriteConvert.[h|cxx] : ficnished this class
124 * src/gdcmFile.cxx : finished the correctly use of PixelWriteConvert
126 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
127 * src/gdcmDocument.cxx : bug fix when opening the file. All read is followed
128 by an eof to prevent all bad read of the file... and in this case, the
131 2004-12-06 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
132 * Example/Volume2Dicom.cxx : comment unused variables
133 * Test/PrintDicomDir.cxx : comment unused variables
134 * Test/BuildUpDicomDir.cxx : remove dbg.Verbose. Remove the FIXME.
135 * src/SQItem.[h|cxx] : remove the PtagHT variable. Remove the AddDocEntry
136 method that is redondant with AddEntry.
137 * src/gdcmDocEntrySet.h : add pure virtual methods common to ElementSet and
140 2004-12-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
141 * Bug fix due my last commit (compilation under Windows).
142 * Example/Volume2Dicom : bug fix in the file and reformatting source code
143 * src/gdcmFile.h : bug fix. Variable type and variable name had same name
145 2004-12-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
147 - Remove printf / sprintf
148 - include iostream AFTER gdcm so we don't get warnings
149 - GDCM_NO_ANSI_STRING_STREAM shouldn't be used explitely ouside of gdcm
151 - Also remove tons of include from header files, hopefully this should
152 speeup the compilation time, since it was becoming a dog slow.
153 - Remove gdcm.h as it include way too many files and slow down compilation
154 (plus it is not up to date)
155 - remove 'using namespace std' this is BAD !
157 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
158 * Remove memory leaks on the DicomDir
159 * Remove some useless datas in DicomDirObject
160 * Add usefull methods in SQItem, to be complient withe the ElementSet
162 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
163 * src/gdcmFile.[h|cxx] : now use FileType instead of TWriteType.
165 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
166 * src/gdcmPixelWriteConvert.[h|cxx] : new class to write datas (and in the
167 future, with convertion)
168 * src/gdcmFile.[h|cxx] : the PixelWriteConverter instance replace Pixel_Data
169 and ImageDataSize values. Remove the method to get the PixelReadConverter
170 from the output of the class
172 2004-12-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
173 * Rename src/gdcmPixelConvert.[h|cxx] to src/gdcmPixelReadConvert.[h|cxx]
175 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
176 * vtk/vtkGdcmReader.cxx : correct error in vtkDebugMacro, vtkWarningMacro
177 and vtkErrorMacro use.
178 * gdcmPython/gdcm.i : corrections to avoid warnings at compilation
180 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
181 * Test/TestCopyDicom.cxx : the new dicom created is created empty, without
183 * src/gdcmSeqEntry.cxx : bug fix in destruction of an element
184 * src/gdcmHeader.cxx : bug fix. Keep the string, otherwise it is destroyed.
185 The string leaves only in the fonction. So when we make a .c_str(), we
186 get the pointeur on the first element, element that will be destroyed
187 immediately after thee instruction.
188 * src/gdcmDocument.cxx : remove memory leaks. Bug fix when testing if the
189 file has been opened : the test must be made on the content of the
190 pointer and not directly on the pointer !
193 2004-12-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
194 * gdcmPython/gdcm.i : change gdcmHeaderHelper to gdcmSerieHeader. Now,
195 the python part recompiles
197 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
198 * Test/ShowDicom.cxx : Change the test to only open one vtkImageViewer.
199 Otherwise, under linux (Graphic card : NVidia / SE : FedoraCore 1) the
200 X session is killed (for my computer... it seems to not be identic on
203 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
204 * Test/ShowDicom.cxx : now can be used with an off-screen rendering to
205 avoid problems (otherwise, the difference test between the visible image
206 and the reference is incorrect. If the reference is greater than the
207 screen resolution, it's produce errors).
208 Can be used for only one image. Can be used with a visible flag.
209 * vtk/vtkGdcmReader.cxx : remove commented codes.
210 * vtk/vtkGdcmReader.h : add the gdcmCommon.h include file to avoid warnings
211 under windows at compilation
212 * vtk/vtkgdcmViewer.cxx : reformat the file. Apply a default window/level
214 * vtk/GdcmToBaseline.cxx : new program to easy create the reference image
216 2004-11-30 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
217 * src/gdcmFile.[h|cxx] : bug fix for ACR-LIBIDO files when writting the file
218 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx : add
219 tests on the image size X, Y, Z
221 2004-11-26 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
222 * Remove some useless methods in gdcm::Document, gdcm::Header and gdcm::File
223 * Rename gdcmHeaderHelper.[h|cxx] to gdcmSerieHeader.[h|cxx] to be coherent
224 between the class name and the file name
226 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
227 * src/ : fix compilation warnings for the Write method (2 different
228 proto). So Rename 'Write(ifstream* fp' into 'WriteContent(ifstream* fp'
229 fix compilation warnings for the gdcm::Document::TransferSyntaxStrings
230 variable... create a static method in gdcm::Document to access to
231 this variable content.
233 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
234 * src/gdcmDocument.[h|cxx] : set the Transfert Syntax values to the header
235 file, to be accessed by other files (like gdcmFile). Remove commented
236 code. Move the change of the header to the gdcmFile, using the
238 * src/gdcmHeader.[h|cxx] : the write is completely made in the Header.
239 To be sure of that (and simplify calls), the Write of the header now
240 gets a file name and not a file pointer (std::ifstream).
241 * src/gdcmFile.[h|cxx] : apply the write file type to the header, using the
242 DocEntryArchive. Remove all open of the written file
244 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
245 * vtk/vtkGdcmReader.cxx : compilation bug fix for the vtk part
247 2004-11-25 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
248 * src/gdcmDocument.cxx : fix bug... test if the fp is opened to use it
249 * src/gdcmPixelConvert.cxx : calculate the image size when while the grab of
251 * src/gdcmFile.[h|cxx] : remove PixelRead and ImageDataSizeRaw variables and
252 some corresponding methods. Write correctly the file and check before
254 * Test/TestCopyDicom.cxx, TestReadWriteReadCompare.cxx,
255 TestAllReadCompareDicom.cxx : pass the write of images to RGB and test
256 is now on RGB datas (as before my last commit
257 * Example/PrintHeader.cxx, PrintFile.cxx : repad files.
259 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
260 * src/gdcmBinEntry.cxx, gdcmSeqEntry.cxx, gdcmSQItem.cxx, gdcmValEntry.cxx :
261 Add a print information of the type of the entry
262 * src/gdcmDocument.cxx : add the write of the preambule of a Dicom file.
263 It was in the gdcmFile, and all write have been regrouped
264 * src/gdcmFile.[h|cxx] : add methods to get the Raw data elements and size.
265 Write correctly all dicom files (in decompressed mode only at this time)
266 * Test/ : test on files are now made using Raw datas and not color datas if
268 * Example/PrintFile.cxx : add more printings
270 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
271 * Amelioration of code, remove some code copy. For the loading of
272 BinEntry (in gdcmDocument), add the test to verify if the file is already
275 2004-11-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
276 * src/gdcmDocEntryArchive.[h|cxx] : bug fix and add a method to temporary
277 remove a DocEntry in the header (push an empty DocEntry)
278 * src/gdcmFile.[h|cxx] : remove some useless variables, methods and code
279 lines. Bug fix in the initialization of the PixelConvert and the
281 * src/gdcmElementSet.[h|cxx] : add methods Initialize and GetNext to
282 use in TestCopyDicom (now this test can run under windows... but fails)
283 * Test/TestCopyDicom.cxx : amelioration of the test :
284 - test the pixels written
285 - add test points to quickly find where is the error
286 - can set a file name input and output in arguments
287 * Test/TestAllReadCompareDicom.cxx, TestReadWriteReadCompare.cxx :
288 amelioration of the test output
290 2004-11-23 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
291 * src/gdcmDocEntryArchive.cxx : complete the print function, that prints
292 all replaced DocEntry's
293 * src/gdcmFile.[h|cxx] : remove all changes of the header when getting datas.
294 Now, each needed DocEntry to modify is duplicated, modified and inserted
295 to the header using DocEntryArchive. Thus, after save, we can restore the
296 header initial state.
298 2004-11-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
299 * src/gdcmFile.h : fix compilation errors on zorglub linuc computer
301 2004-11-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
302 * src/gdcmDocEntry.cxx : remove the copy of the DictEntry... there isn't
303 correct to copy it. The DictEntry is specified at the DocEntry creation,
304 then, it musn't change in the time.
305 * src/gdcmDocEntryArchive.[h|cxx] : new class. It's goal is to change the
306 header correctly. At this time, the change is only made for the first
307 level of the Document. In the future, it might consider sequences.
308 The change is made by replacing a DocEntry by an other that is created
309 outside the class. The old value is kept. When we restore the header
310 status, the added DocEntry is deleted and replaced by the old value.
311 * src/gdcmElementSet.h : Set the DocEntryArchive like friend.
312 * src/gdcmFile.[h|cxx] : Use the gdcmDocEntryArchive. Add methods to
313 set the write type to explicit VR, implicit VR or ACR. Add methods to set
314 the write mode to native, decompressed or RGB (but not used at this time)
316 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
317 * src/gdcmSeqEntry.cxx : add initialisation of variable SeqTerm
318 * src/gdcmDocument.cxx : add delete of DocEntry's to remove some memory leaks
320 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
321 * src/gdcmDocument.cxx : now, when using the ReplaceOrCreateByNumber to
322 set a BinEntry, the binArea is copied (like to set a ValEntry, the string
324 * Test/TestCopyDicom.cxx, Example/TestCopyDicom.cxx : the image data isn't
325 set because already copied when copying the BinEntry's of the header
326 * Test/TestAllReadCompareDicom.cxx : remove warnings
328 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
329 * FIX : now, the DocEntries are all deleted in the gdcmElementSet.
330 Two problems appear when doing it :
331 - with the gdcmFile : when the GetImageData method is called, the pixels
332 are stored in the gdcmPixelConvert, but a gdcmBinEntry link to these
333 datas (pixels). And each structure destruct the datas when it's
334 destructed. So we have two destructions for the same datas. To solve it,
335 a flag is added in the gdcmBinEntry to indicate if the BinEntry owns the
336 datas or not. If it doesn't own datas, then they will not destroyed by
338 - with the gdcmDicomDir : the sequences (gdcmSQItem) contain DocEntry
339 elements. The DicomDir* (DicomDirPatient, etc.) inherit from SQItem.
340 Thus destruct the DicomDir* elements and the TagHT of the ElementSet
341 create a double destruction of the same DocEntry's. So, to solve it,
342 the TagHT is simply cleared and the DicomDir* elements are destroyed.
343 * TODO : add an entry concerning memory leaks in the DicomDir
345 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
346 * FIX : src/gdcmDocument.cxx Remove obvious code in the destructor
347 * FIX : src/gdcmPixelConvert : Set to NULL the deleted structures in the
350 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
351 * FIX: src/gdcmUtil.cxx : to compile with MSVC6
352 * src/gdcmDocument.cxx : fix memory leaks. Fix possible bugs : use an object
353 after it have been deleted
355 2004-11-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
356 * FIX: src/* fix the doxygen warnings.
357 * src/gdcmVR.cxx: removed some redundant tests (e.g. LO)
358 * src/gdcmDocument.cxx: FIX ::ComputeRLEInfo() rleSegmentOffsetTable[]
359 was erroneously defined with a size of 15 instead of 16. [many thanks
360 to Jean Michel Rouet for pointing out this bug].
362 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
363 1. Finish merging JMR patch for writting DICOM from scratch
364 2. Fix -hopefully- bug with MONOCHROME and space vs null character
365 3. Use const ref when possible
366 4. Add a new function InitializeDefaultHeader, which create a template DICOM header (CT image for now)
367 5. A few more comments
368 6. CreateUniqueUID can now be called without parameter"
370 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
371 * ENH: Slightly bigger patch:
372 1. Getting toward full integration of JMR patch for writting dicom from scratch
373 2. Update Test to test part of this patch: CreateUniqueUID
374 3. File was not close properly in gdcmDict
375 4. Use of typedef is to be prefered when possible (gdcmDict.cxx)
376 5. Use of const ref instead of copy (speed issue)
377 6. Remove temporary (duplicate) string in TranslateToKey
378 7. Mark extremely dangerous code as such (gdcmDocument.cxx and AddEntry fallback case)
379 8. Do not repeat virtual in subclasses
380 9. Implemented in gdcm::Util two new function: GetIPAddress, and CreateUniqueUID
382 2004-11-15 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
383 * Apply first patch toward better string comparison when dealing with broken
384 DICOM files. Essentially the string could be padded with a space instead
385 of a null character as defined by standard
387 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
388 * src/gdcmDocument.[cxx|h] : fix memory leaks. The return is suppressed
389 because never used... and in the same time, that's remove some memory leaks
391 2004-11-15 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
392 * src/gdcmFile.cxx : now delete the PixelConvert instance.
393 * In examples and tests : change the type of image data variables from void*
394 to uint8_t*. Remmove all delete on image data variables
396 2004-11-10 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
397 * src/gdcmDocument.cxx : Set the file pointer TP to 0 in the constructors.
398 Verify the file pointer value before open the file, and if it's not null,
399 a verbose message is generated.
400 Close correctly the file when the file isn't considered dicom-like. The
401 correctly close is a call to CloseFile.
402 When closing the file pointer, test if its not null to close the file.
403 * src/gdcmPixelConvert.cxx : bug fix for the SIEMENS_GBS_III-16-ACR_NEMA_1.acr
404 file. For an uncompressed image, the copied datas correspond in the least
405 case to the image size (calculated) or the image size specified in the
406 header. A verbose is generated if these two size mismatch
408 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
409 * Test/TestAllReadCompareDicom.cxx : test the existence of the directory
410 using an 'ifstream' other than a 'FILE *'. The previous solution ('FILE *')
411 break under windows (with msvc6 compilation).
413 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
414 * src/gdcmDicomDir.h : bug fix for the last Boix's commit (problem when
415 compiling with MSVC6)
417 2004-11-09 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
418 * Bugs fix for the Windows build with VC6
419 * CMakeLists.txt : bug fix - The include of the VTK lib is made only when it's
420 needed (only for projects required VTK). If the VTK is included in all
421 projects, there is conflicts with the jpeg lib of vtk when compiling the
422 gdcmjpeg[8,12,16] projects. The first conflict is on the jmorecfg.h file.
423 * src/gdcmUtil.h : export binary_write methods. Otherwise, there's problems
424 when compiling the gdcm_wrap.cxx file (created by the compilation of the
426 * vtk/vtkGdcmDemo.cxx : remove the use of std namespace for the cerr use
427 (like it's already made for the cout use). Otherwise, conflict with the
430 2004-11-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
431 * src/gdcmDicomDit.h the Method typedef is now local to DicomDir class.
433 - comments on the DicomDir::Method related usage added.
434 - now that we use the namespace gdcm, a lot of internal classes do
435 NOT need to be wrapped anymore.
436 * gdcmPython/demo/DicomDirProgressMethod.py (that uses the above
437 DicomDir::Method) new example added.
439 2004-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
440 * Improve string manipulation. I now inforce the notion of 'DicomString'
441 A DicomString can contain as many \0 as they want
442 and it is *always* of even length.
443 We only support odd length for very rare case.
444 And in the near future this should be removed.
446 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
447 * /binary_write/ gdcm source. Now even on big endian we are writting
448 little endian. This should -heopfully- fix some tests
450 2004-11-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
451 * Now the dictionary is compiled into gdcm lib. This is a default
452 behavior, thus any dic file specified is picked before failback to
453 the one comiled into lib
455 2004-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
456 * Change internals for gdcmDict. Don't use any 'new' any more.
457 This should definitely solve any leak problem, and we should be
458 as fast as before, as long as don't modify too much the dictionary.
460 2004-10-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
461 * STYLE: ivars should start with a capital letter.
462 * Accessors should be const to avoid people starting modifying stuff (since this is a ref).
463 * remove 'virtual' as Style specify subclasses shouldn't reuse the keyword
465 2004-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
466 * Doc/Dicom2004_Part5.pdf added (thanks to JPR).
467 * Dicts/dicomTS2004.dic, dicomV3VM2004.dic, groupNameAbbreviations2004.dic
468 new 2004 dictionaries added (thanks to JPR).
469 * FIX dashboard warning RLEFrame::NumberFragments is now of type unsigned int
470 * CLEANUP_ROUND (15) for gdcmPixelConvert
471 - RLEFrame::NumberFragments is now of type unsigned int
472 - gdcmFile::GetImageData(), GetImageDataIntoVector(), GetImageDataRaw()
473 are now all based on PixelConverter. ::GetImageDataIntoVectorRaw()
476 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
477 * Initial work in gathering all transfer syntax accessors. clearly
478 IsDecompressed/IsJPEG2000/IsJPEGLossless/IsRLELossless shouldn't be all
479 ivars, but only one transfersyntax (class) ivar with equivalent method on
482 2004-10-21 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
483 * Removed all FILE* ref and replace by ifstream/ofstream. For now I use a temp
484 solution with the two files jdatadst.cxx and jdatasrc.cxx, this need to be
485 discussed (plus I didn't like having a 2000 lines patch not commited)
487 2004-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
488 * src/gdcmDocument.cxx: wrong type on return fixed (thanks dashboard)
489 * CLEANUP_ROUND (14) for gdcmPixelConvert
490 - PixelConvert::GetLutRGBA(FILE*) is now GetLutRGBA() (no fp needed)
491 - PixelConvert::BuildRGBImage()(FILE*) is now BuildRGBImage() (no fp needed)
492 - File::GetImageDataIntoVector() doesn't need unnecessary OpenFile() and
494 - File::GetImageDataRaw() doesn't call GetImageDataIntoVectorRaw()
495 anymore and hence avoids storing a copy of PixelConvert::Decompressed
496 into File::Pixel_Data.
498 2004-10-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
499 * src/gdcmDocument.cxx ftell() return properly stored in a long (i.e.
500 no longer depends on's programmers PMS = Preposterous Mood Swings ;).
501 * CLEANUP_ROUND (13) for gdcmPixelConvert
502 Substituted File::ParsePixelData() with PixelConvert::Print() new
504 - src/gdcmParsePixels.cxx removed (only contained File::ParsePixelData())
505 - src/gdcmRLEFrame.cxx, gdcmJPEGFragment.cxx added. Added a ::Print()
506 method to those classes.
507 - src/gdcmFile.[cxx|h]:
508 -- Added a ::Print() method.
509 -- PixelConverter is now a reference instead of a member.
510 -- gdcmPython/gdcm.i: added "using namespace gdcm" in order for
511 gdcm_wrap.cxx to "understand" File::GetPixelConverter()
513 2004-10-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
514 * Doc/CMakeLists.txt, doxygen.config.in: when dot is present the
515 collaboration diagram and inheritance diagram should be generated with
517 * Doc/Website/Sidebar.html: Dashboard is now also in the sidebar.
518 * gdcmPython/gdcm.i: gdcmRLEFramesInfo.h gdcmJPEGFragmentsInfo.h are
519 pointlessly wrapped (see
520 http://www.creatis.insa-lyon.fr/pipermail/dcmlib/2004-October/000692.html )
521 * CLEANUP_ROUND (12) for gdcmPixelConvert (sugar is my friend stage)
522 - Header::GetLUTRGBA() moved to PixelConvert::GetLutRGBA()
523 - vtk/vtkGdcmReader.cxx: adapted to displacment of Header::GetLUTRGBA()
524 - Document::RLEInfo and JPEGInfo are now pointer members (Swig thing)
525 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
526 -- File::Initialise: PixelConverter setup moved away to
527 PixelConverter::GrabInformationsFromHeader()
528 -- File::GetImageDataIntoVector(): Lut R + Lut G + Lut B color table
529 interpretation moved away to PixelConverter::BuildRGBImage()
531 2004-10-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
532 * Remove GDCM_EXPORT keyword from gdcm::DirList due to :
533 http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP
535 2004-10-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
536 * src/gdcmDebug.cxx last ditch attempt to get warning/error messages
537 displayed on Win32 when a brutal abort() occurs (because of uncatched
538 exception). See TODO new entry of this commit for more on this.
539 * TODO added new entry.
540 * CLEANUP_ROUND (12) for gdcmPixelConvert (nicotine is my friend stage)
541 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
542 - HandleColor is no longer called from gdcmFile.cxx
543 - gdcmPixelConvert.cxx clean up on method arguments and internal
544 variable names for semantical coherence.
546 2004-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * Finished lossless transition, not only do we now read all lossless jpeg
548 images, without the need of the Cornwell lib, but we do read them properly now
549 * To reduce code (well to avoid code duplication), I defined a common place
550 for jpeg read/write: gdcmJpeg.cxx. Now gdcmJpeg[8,12 16] include this file and
551 redefine symbols. This is not prefect but this the best solution I found for a
552 compilation time jpeg option.
554 2004-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
555 * Update jpeg ijg lib to support lossless jpeg implementation
556 For more info look in jpeg/libijg/README.GDCM.txt for necessary steps to
558 * Also added a special copyright for dcmtk since we use their bugfixes.
561 2004-10-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
562 * Doc/Website/MailingList.html added (Sidebar.html changed accordingly).
563 * gdcmPython/gdcm.i: fix for compilation of wrappers (Note: %include order
564 matters, as stated in warning note at begining of %include section).
565 * src/gdcmDicomDir*.[cxx|h]: coding style
566 * src/gdcmDocument.h: doxygen \ref seems uncompatible with \todo.
567 * src/gdcmJpeg8.cxx: doxygen fix.
568 * CLEANUP_ROUND (12) for gdcmPixelConvert (seing the ligth stage)
569 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: color handling moved
570 from File:: to PixelConvert::.
572 2004-10-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
573 * CLEANUP_ROUND (11) for gdcmPixelConvert (cafeine is my friend stage)
574 src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]:
575 - more code moved away from File:: to PixelConvert::
576 - fat setup of PixelConverter set in place in File::Initialise.
578 2004-10-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
579 * Apply patch for namespace in gdcm. Didn't rename files for keeping a sort of
580 namespace at the file system level. So now you should convert your examples
582 gdcmHeader -> gdcm::Header
583 It would be nice if people keep in mind to no open the namespace, since it
584 allows compilation on broken plateform which were defining common symbol in
585 the standart namespace (like LP, Unknown ...)
587 2004-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
588 * CLEANUP_ROUND (10) for gdcmPixelConvert (Xanax is my friend stage)
589 The JPEG fragments are now parsed at the same stage than the RLE
590 information. All code related to JPEG is now in gdcmPixelConvert:
591 - src/gdcmJPEGFragment.h and gdcmJPEGFragmentsInfo.[h|cxx] added
592 - src/gdcmJpeg12.cxx, gdcmJpeg2000.cxx and gdcmJpeg8.cxx no longer
593 export a gdcmFile:: method. Those are simply global functions
594 (for the time being this is better than having them attach to
595 either gdcmFile:: or gdcmPixelConvert::).
596 - src/gdcmDocument.[cxx|h], gdcmDocument:: now parser the JPEG fragments
597 and stores the result in a gdcmJPEGFragmentsInfo.
598 - src/gdcmFile.[cxx|h] and gdcmPixelConvert.[cxx|h]: all JPEG related
599 code (among other stuff) moved away from gdcmFile:; to
602 2004-10-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
603 * src/gdcmCommon.h now declares int8_t for non stdint.h plateforms.
604 * CLEANUP_ROUND (7) for gdcmPixelConvert (lost at sea)
605 - src/gdcmFile.h gdcmPixelConvert.cxx gdcmPixelConvert.h gdcmRLE.cxx:
606 clean up of RLE related code.
607 * CLEANUP_ROUND (8) for gdcmPixelConvert (end of RLE nigthmare)
608 - src/gdcmRLE.cxx removed
609 - src/gdcmPixelConvert.cxx all RLE code is now in PixelConvert::
610 - src/CMakeLists.txt gdcmFile.[cxx|h] changed accordingly
611 - src/gdcmRLEFrame*.h gdcmPixelConvert is now a friend class.
612 * CLEANUP_ROUND (9) for gdcmPixelConvert
613 - src/gdcmFile.[cxx|h} gdcmPixelConvert.[cxx|h], SwapZone(),
614 ConvertReorderEndianity(), ConvertDecmpres12BitsTo16Bits() moved
615 away from gdcmFile:: to gdcmPixelConvert::.
617 2004-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
618 * CLEANUP_ROUND (5) for gdcmPixelConvert (Upshit creek without a paddle)
619 - src/gdcmDocument.[cxx|h] Parse7Fe0 renamed to ComputeRLEInfo.
620 This is because Parse7Fe0 used to parse the pixels to compute the
621 length. This task was passed over to FindDocEntryLengthOB() a long
622 time ago, EXCEPT I had forgotten the OW case...
623 Hence Parse7Fe0 was no longer necessary. When renaming to ComputeRLEInfo
624 we just recylce the code for parsing RLE fragments and computing
626 * CLEANUP_ROUND (6) for gdcmPixelConvert (man, I need a paddle bad)
627 - src/gdcmRLE.cxx: is now much simpler and avoids code replication
628 with the retired Parse7Fe0().
629 - src/gdcmRLEFrame.h: type fix for properly computing OffSet[]
630 - src/gdcmDocument.cxx: segments offset are now correct + clean up.
632 2004-10-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
633 * CLEANUP_ROUND (3) for gdcmPixelConvert (nightmare stage)
634 - src/gdcmRLEFramesInfo.[cxx|h], gdcmRLEFrame.h added
635 - src/gdcmDocument.[cxx|h] ::Parse7FE0 now sets up the RLEInfo.
636 - src/CMakeLists.txt: alphabetic order reodering + new entries.
637 * CLEANUP_ROUND (4) for gdcmPixelConvert
638 - src/gdcmDocument.[cxx|h] ::ParseDES and ::ParseSQ no longer bother
639 to return an unused length.
641 2004-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
642 * Remove all sprintf from the code to centralize in one spot in gdcmUtil
643 this should be cleanner from the plane view. The iostream are erally a pain
644 to use to do simple stuff.
646 2004-10-04 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
647 * Redo the compilation of the ijg jpeg library. Now only one source is
648 necesseray. No need to rename file by hand what so ever. CMake handle the
649 copying of the file within different directory, configure header file to
650 modify some symbol. The only addition made to ijg wasd a mangle table so
651 that symbol are different wether we are within 8bits or 12bits.
653 2004-10-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * Added documentation of vtkgdcmReader on Website:
655 - testvtkGdcmReader.cxx renamed to vtkGdcmDemo.cxx (to be compatible
656 with it's binary name).
657 - vtk/vtkGdcmDemo.cxx and vtkgdcmViewer.cxx: added comments for
658 the Website to be more complete.
659 - Doc/doxygen.config.in: vtk/vtkGdcmReader.cxx now appears on
660 doxygenated documentation.
661 - Doc/DoxyVtkGdcmReaderExamples.txt added
662 (see http://www.creatis.insa-lyon.fr/Public/Gdcm/html.developper/
663 DoxyVtkGdmReaderExamples.html )
664 * src/win32, vtk/win32 manually maintained .dsp and .dsw removed.
665 * CLEANUP_ROUND (3) for gdcmPixelConvert
666 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
668 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
669 * CLEANUP_ROUND (2) for gdcmPixelConvert
670 - src/gdcmFile.cxx, gdcmFile.h splitting GetImageDataIntoVectorRaw
672 2004-09-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
673 * CLEANUP_ROUND for gdcmPixelConvert:
674 - src/gdcmFile.cxx, gdcmFile.h, gdcmHeader.cxx, gdcmHeader.h clean up
675 - src/gdcmPixelStuff[h|cxx] removed
676 - src/gdcmPixelConvert[h|cxx] added. Preparatory work included.
677 - src/CMakeLists.txt changed accordingly
679 - MANIFEST.in, WrapSwig.py, WrapVTK.py, distutilsWrapping.py and
680 gdcmVersion.py moved to newly created ATTIC related
681 gdcmPython/SetupOldies/ directory.
682 * Autotools clean up:
683 - */*/Makefile.am removed AT EXCEPTION of gdcmPython/Makefile.am
684 - autogen.sh configure.in acinclude.m4 python.m4 removed
686 2004-09-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
687 * src/*.cxx *.h Reference to License.htm fixed to License.html.
688 * Doc/CMakeLists.txt, doxygen.config.in: fix.
689 * Doc/Website/ConformanceSummary.html, minimal conformance statement added.
691 2004-09-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
692 * TODO updated with Mathieu suggestions. I proposed a template for
693 describing TODO entries and used it for new entries.
694 * Added Doc/Website/CodingStyle.html, Developpers.html,
695 DeveloppersPython.html, GdcmDataCvs.html and
696 DownloadVersion0_1.html, DownloadVersion0_3.html.
697 * Some Doc/*.txt Doxygen files (which do not really concern the
698 documentation itself, but the website) moved to html and
699 placed in directory Doc/Website:
700 - Doc/DoxyDevelInstal.txt moved to Doc/Website/Developpers.html
701 - Doc/DoxyInstallation.txt moved to Doc/Website/Installation.html
702 - Doc/DoxyIntroduction.txt included in Doc/Website/Main.html
703 * Doc/DoxyfileDeveloppers, DoxyfileUsers, Makefile.am oldies removed.
704 * CMakeLists.txt changed accordingly.
705 * DEVELOPPER spread out in Doc/Website/Developpers.html, CodingStyle.html,
706 DeveloppersPython.html
707 * INSTALL nows refers to Doc/Website/Installation.html
709 2004-09-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
710 * Added Doc/Website directory, that contains a first raw version
713 2004-09-23 Jean-Pierre Roux
714 * FIX In order not to be poluted any longer by casting problems,
715 the member VoidArea of gdcmBinEntry is now uint8_t* (instead of void *)
716 we can now delete[] it safely
717 * VoidArea is now called BinArea (less confusing name),
718 and all the methods called ...VoidArea... are now ... BinArea...
719 * class gdcmObject is now called gdcmDicomDirObject (less confusing name)
721 2004-09-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
722 * src/gdcmDocument.cxx: gdcmDocument::~gdcmDocument() doesn't clear (nor
723 clear) TagHT, which is an inherited member of gdcmElementSet. It is
724 up to the destructor of gdcmElementSet to clean up TagHt and it's
727 2004-09-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
728 * Test/CMakeLists.txt: update to follow gdcmData renamings.
729 * src/gdcmCommon.h, gdcmDocument.cxx: doxygen typos
731 2004-09-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
732 * ENH: added some utility method that builds a flat dictionnary
733 holding all the Dicom entries contained in the recursive structure
734 of a gdcmElementSet. Refer to add FlatHashTablePrint.cxx for
736 - src/gdcmDocument.[h|cxx] added BuildFlatHashTableRecurse() and
737 BuildFlatHashTable() that build a flat dictionary.
738 - src/gdcmElementSet.h: added a new private GetTag() accessor.
739 gdcmDocument is now a friend of gdcmElementSet.
740 - src/gdcmElementSet.cxx: clean up.
741 - Example/FlatHashTablePrint.cxx added.
742 - Example/CmakeLists.txt changed accordingly
744 2004-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
745 * gdcmDocEntrySet::SQDepthLevel and gdcmDocEntrySet::BaseTagKey attributes
746 moved away from gdcmDocEntrySet (since this class is an abstract class
747 acting like an interface). SQDepthLevel and BaseTagKey are now
749 - src/gdcmDocEntrySet.[h|cxx] removal of SQDepthLevel and BaseTagKey
750 and associated accessors. Doxygenation of the class.
751 - src/gdcmSQItem.[h|cxx] SQDepthLevel and BaseTagKey and associated
753 - src/gdcmSeqEntry.[h|cxx]: constructor doesn't handle depth anymore.
754 Use SQDepthLevel accessor instead. ::Print() adapted.
755 - src/gdcmElementSet.cxx changed according to changes in gdcmSeqEntry.
756 - src/gdcmDocument.cxx changed accordingly.
758 2004-09-13 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
759 * Preparation of writing a gdcmHeader iterator: generalisation of gdcmTagKey
760 - The following is the doxygen comment of the typedef declaration
761 of gdcmagKey in src/gdcmCommon.h:
762 gdcmTagKey is made to old an "universal" (as in URL, Universal
763 Ressource Locator) key to a gdcmDocEntry i.e. a dicom tag.
764 A dicom tag allways has a group and an element, but a set of tags
765 embeded in various (optionally nested) sequences and sharing
766 the same group and element all share the same (group, element)
767 "identifier". Hence the (group, element) cannot be used as an
768 identifier (in gdcm we shall refer to a "TagKey") of a tag.
769 In order to construct a proper tag identifier (i.e. a key) we
770 consider the following definition of a TagKey:
771 - let Group, Element be the string representation of the
772 group and element dicom tag members,
773 - let ItemNumber be the string representation of the integer
774 index of the considered item number of a sequence,
775 Let the key of a tag embeded in a sequence, noted SeqTag, be
777 /ItemNumber#Group|Element
778 where "/", "#" and "|" are characters acting as separators.
779 Then the general form of a gdcmTagKey is given by:
780 Group|Element<SeqTag>
781 where <SeqTag> means NO or many instances of SeqTag.
782 Hence the gdcmTagKey of a tag not "leaving" in a sequence is the
785 but the gdcmTagKey of a tag "embeded" is the first item of
786 a sequence, itself nested in the third item of a sequence is the
788 0004|1220/2#0008|0082/0#0008|0090
789 - src/gdcmDocEntry.h: added a new Key (of type gdcmTagKey) member, in
790 order to hold the new sequence compatible key. Previously, the
791 GetKey() method would look in the underlying gdcmDictEntry.
792 - src/gdcmDocEntry.cxx:
793 -- constructor now copies the underlying DictEntry key, in the local
795 -- ::Print: displays the member Key, instead of the (group, element).
796 - src/gdcmCommon.h: added some comments on typedef gdcmTagKey.
797 - src/gdcmDocEntrySet.h:xi
798 -- ::ParseDES() now setups the gdcmTagKey of the sequence it is parsing.
799 -- now has a new BaseTagKey member.
801 * src/gdcmValEntry.[h|cxx], src/gdcmBinEntry.[h|cxx]: the member VoidArea,
802 previously a member of gdcmValEntry, moved to gdcmBinEntry were is
804 This poses the problem with the semantics of the following lines
805 LoadEntryVoidArea(0x0028,0x1201); // R LUT
806 LoadEntryVoidArea(0x0028,0x1202); // G LUT
807 LoadEntryVoidArea(0x0028,0x1203); // B LUT
808 in gdcmDocument::gdcmDocument(std::string const & ). Please refer
809 to the long FIXME note for what the problem is. Nevertheless in
810 order to get things working the dicom dictionary was altered !
811 Please fix things urgently...
812 * Dicts/dicomV3.dic WRONGLY altered (this means we introduced a uncorrect
813 information), see above note on moving the member VoidArea. Nevertheless
814 the following entries previously correctly set as US are now inproperly
816 0028 1201 OW IMG Red Palette Color Lookup Table Data
817 0028 1202 OW IMG Green Palette Color Lookup Table Data
818 0028 1203 OW IMG Blue Palette Color Lookup Table Data
819 * src/gdcmDocEntry.[h|cxx], src/gdcmSeqEntry.h: SQDepthLevel member
820 of gdcmDocEntry moved to gdcmSeqEntry.
821 * src/gdcmSeqEntry.cxx: STYLE.
823 2004-08-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
824 * Test/TestAllEntryVerify.cxx minor fix and added comments.
826 2004-08-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
827 * gdcmPython/testSuite.py: all the test suite in python is now moved
828 to it's C++ version (see gdcmData/TestAllEntryVerifyReference.txt)
829 * Test/CMakeLists.txt adapted to renaming of files in gdcmData
830 * gdcm/TODO and src/gdcmDictSet.h cleaned up frow the "TODO Swig" oldies
832 2004-08-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
833 * gdcmPython/CMakeLists.txt: SWIG_FLAGS doesn't declare includeall
834 to avoid inclusion recursion until STL is reached.
835 * src/gdcmDocument.[h|cxx]: exceptions substituted to errno C-style
836 mecanism. errno.h is not included in gdcm anymore.
837 * src/gdcmException.h: introduced new gdcmFormatUnexpected class
838 (gdcmFormatError now inherits from gdcmFormatUnexpected).
840 * gdcmPython/testSuite.py checks on CR-MONO1-10-chest.dcm moved to
841 gdcmData/TestAllEntryVerifyReference.txt
842 * Test/TestAllEntryVerify.cxx is now effective (used allways return true)
843 * src/gdcmDocument.[cxx|h]: constructors no longer use the bool
844 exception_on_error parameter.
845 - src/gdcmFile.[cxx|h], src/gdcmHeader.[cxx|h] changed accordingly,
846 - vtk/vtkGdcmReader.cxx changed accordingly,
847 - Example/*.cxx and Test/*.cxx changed accordingly.
849 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
850 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
851 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
852 enable_sequences removed from gdcmHeader constructor and dependencies.
853 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
854 * gdcmPython/demo/PrintHeader.py: dummy fix.
855 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
856 skip_shadow removed from gdcmHeader constructor and dependencies.
857 * Example/*.cxx and Test/*.cxx changed accordingly.
859 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
860 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
861 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
863 2004-07-21 Jean-Pierre Roux
864 * FIX Now, Parsing and Printing a DICOMDIR do work!
865 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
867 2004-07-20 Jean-Pierre Roux
868 * FIX Some brain damaged headers have Zero-Lenght fields
869 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
871 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
872 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
873 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
874 variable (instance of gdcmDebug) by a definition macro, and the instance
875 is now in static in the gdcmDebug class
876 * src/gdcmSQItem.h : (FIXME) remove an undefined method
877 * Test/PrintAllDocument.cxx : bug fix in the result of the test
879 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
880 * WARNING: ctest now depends more tightly on gdcmData. You should
881 check out gdcmData properly for things to run smoothly...
882 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
883 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
884 we need the pixels not be loaded in order to use the ValEntry
885 that displays position and size).
886 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
887 This is a C++ based equivalent of gdcmPython/testSuite.py that should
888 be deprecated. If you have any doubts about the advantages of a
889 modern scripting language (read Python) versus grass root C++ (i.e.
890 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
891 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
892 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
893 Anyhow, consider documenting the gdcmData images in
894 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
896 * Test/CMakeLists.txt:
897 - now uses TestAllEntryVerify.cxx
898 - specific comments on oldACR00001.ima (now renamed in gdcmData
899 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
900 gdcmData/TestAllEntryVerifyReference.txt
903 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
904 * src/*.[h|cxx] : typedef clean up
905 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
906 - TagKey renamed to gdcmTagKey (for external usage)
907 - VRKey renamed to gdcmVRKey (for external usage)
908 - removal of typedef duplication.
909 - Removed all unecessary inline keyword from class inline definitions.
910 - Some method|function(void) declarations replaced with method|function().
911 * src/jpeg/libijg12/jdhuff12.c:
912 - printf polluting ctest removed.
913 - TAB removal for comminting
915 - TestAllReadCompareDicom.cxx: added a test that compares all the
916 images in gdcmDataImages.h with corresponding images in
917 gdcmData/BaselineDicom/. When baseline images are not present
918 this test creates them.
919 Note: we need to validate each reference image, but before that
920 I'd like to rename them with a more explicit name...
921 - CMakeLists.txt: changed accordingly.
922 * Example/*.cxx: examples now only include gdcm.h (as opposed to
923 including each header needed).
925 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
926 * Test/*.cxx and Example/*.cxx: moved some examples away from the
927 test suite to the Example directory. Are concerned:
932 - TestWriteSimple.cxx
933 * Test/CMakeLists.txt: added some comments on reasons for black listing
934 image gdcmData/oldACR00001.ima
936 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
937 * Test/CmakeList.txt: removed the following from black list (to be coherent
938 with removal from gdcmData):
939 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
940 - gdcm-MR-PHILIPS-16.dcm
942 Added the following because after last cvs update, they cause
943 ctest -R TestReadWriteReadCompare
945 - gdcm-MR-SIEMENS-16-1.acr
947 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
948 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
949 new comments in this file) we temporarily (sigh) move to a weaker
951 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
952 we don't need to black list the following images anymore:
953 - 8BitsUncompressedColor.dcm
955 - US-PAL-8-10x-echo.dcm
956 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
957 fixes and the beautified code ;-)
958 This fixes the bug introduced in version 1.42 (when beautifying)
959 that made the parsing of 8BitsRunLengthColor.dcm unproper.
960 Note: ctest was blind to this bug (this means we need to still
961 improve the test suite). The bug could be detected by using
962 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
964 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
965 and by displaying the (garbage) produced file temp.XDCM...
967 2004-06-29 Jean-Pierre Roux
968 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
969 - replace by uggly but working old code :-(
970 A lot of things should be OK again.
971 It's really urgent to have a test suite that *tests*,
972 to prevent Frog's beautifying sessions to break all the stuff
973 (twice, withing a fortnigh ...)
975 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
976 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
977 redundancy) to added Test/TestReadWriteReadCompare.cxx
978 * Test/CmakeList.txt: because the compare test of
979 Test/TestReadWriteReadCompare.cxx fails, the following images are
980 black listed: - 8BitsUncompressedColor.dcm
982 - US-PAL-8-10x-echo.dcm
983 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
984 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
985 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
986 and ad-hoc kludge. This kludge is now removed, and on encountering
987 such an image (OB field brain damaged) we set errno. Then in
988 ::FindDocLength() we "fix" the length as being ALL what remains
989 in the file (until EOF). We then proceed, hoping for the best...
990 This fixes a SegFault in ShowDicom when trying to write such an
992 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
993 (because TestWriteRead breaks on it, after a non conformal commit?).
994 ctest now runs properly, except for MakeDicomDir (which was allways
995 broken) and the Python related stuff (still not fixed).
997 2004-06-24 Jean-Pierre Roux
998 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
999 FIX : Test/TestReadWrite now iterates on all the file names
1000 (instead of infinite loop)
1001 ENH : Test/TestWriteRead now iterates on all the file names
1003 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1004 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
1006 2004-06-24 Jean-Pierre Roux
1007 FIX : - now Write drops LUT Descriptors and LUTs (if any)
1008 when SamplesPerPixel =3
1009 - now Write is no longer confused by
1010 'BitsAllocated = 12" and 'BitsStored=12"
1011 - "UN" value representation Elements are now written correctly
1012 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
1013 ENH : - now gdcmHeader has its own Write methods
1014 (in order to split the job that has not to be done
1017 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1018 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
1019 loop on the same image until memory went out.
1020 Note: this means we still have gobs of memory loss in PrintDocument
1021 * src/gdcmDocument.cxx: fixes problem on parsing on file
1022 gdcmData/16BitsJpegLosslessGrayScale.dcm.
1024 2004-06-24 Jean-Pierre Roux
1025 FIX : Write - All the Sequences and Sequence Item are now written
1026 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
1027 is added a the end, when necessary.
1028 - A lot of brain-damaged images, that were read correctly are
1029 now written correctly
1030 - length compatible BinEntry are now loaded correctly
1031 (even for odd groups)
1032 Note : only Explicit Value Representation was checked.
1033 (question : is implicit VR really necessary for gdcm ?)
1035 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1036 * DEVELOPPER: added a proposition of coding style.
1037 * src/gdcmDocEntry.h: removed every inline declaration (for test of
1040 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1041 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
1042 Use the gdcmDocEntry::Print() and Write() instead.
1043 * src/gdcmDocument.cxx: bug fix.
1045 2004-06-22 Jean-Pierre Roux
1046 FIX : gdcmDocument.cxx
1047 - Now we do recognize the JpegLossLess format (there was a misstyping in
1048 code 'beautyfication' :-(
1049 - Now we automaticaticaly load the Luts, if any
1051 2004-06-22 Jean-Pierre Roux
1052 In order : to write Sequences, whatever their imbrication level,
1053 : to allow user to create his own Sequences
1054 a lot of modif where necessary (adding, moving, or virtualising methods)
1056 WARNING : save your own sources *before* cvs up !
1059 ADD virtual void Write(FILE *fp, FileType filetype);
1062 ADD virtual void Write(FILE *fp, FileType filetype);
1063 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
1066 ADD virtual void Write (FILE *fp, FileType filetype)=0;
1067 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
1068 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
1069 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
1070 ADD std::string GetEntryByName(TagName name);
1071 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1073 std::string vr = "unkn",
1074 std::string fourth = "unkn",
1075 std::string name = "unkn");
1076 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1077 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1078 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1079 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
1080 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
1081 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1082 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
1083 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
1086 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
1087 ADD virtual std::string GetEntryByName (TagName tagName);
1088 ADD virtual std::string GetEntryVRByName (TagName tagName);
1089 REM virtual bool Write(FILE *, FileType);
1090 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
1091 FILE *_fp, FileType type);
1092 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
1093 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
1094 REM virtual bool WriteEntries(FILE *_fp,FileType type);
1095 REM virtual std::string GetEntryByName (std::string tagName);
1096 REM virtual std::string GetEntryVRByName (std::string tagName);
1097 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
1098 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
1099 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
1101 std::string vr = "unkn",
1102 std::string fourth = "unkn",
1103 std::string name = "unkn");
1104 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
1105 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
1106 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
1107 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
1110 ADD virtual void Write(FILE *fp, FileType filetype);
1113 ADD virtual void Write(FILE *fp,FileType filetype);
1116 ADD virtual void Write(FILE *fp, FileType filetype);
1117 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
1118 REM std::string GetEntryByNumber(guint16 group, guint16 element);
1119 REM std::string GetEntryByName(TagName name);
1122 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
1124 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1125 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
1126 The default constructor invoked by the line
1127 gdcmHeader *f1 = new gdcmHeader( header );
1128 was gdcmHeader::gdcmHeader(bool) instead of the expected
1129 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
1130 Hence the parsing wasn't executed... See also below.
1131 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
1132 as explicit constructor didn't do the trick to fix the above problem.
1133 Could anyone explain why ?
1134 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
1135 properly calls gdcmValEntry::Print() (that was weed out from
1136 code related to gdcmBinEntry).
1138 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1139 * In order to fix memory leaks:
1140 - Test/TestWriteSimple.cxx: added cleaning of free store through
1142 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
1143 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
1144 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
1145 (through the call to ::AddDicomDirMeta()) or the destructor
1146 would crash when deleting uninitialized ::metaElems].
1147 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
1148 - src/gdcmDocument.cxx:
1149 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
1150 from dynamic stores.
1151 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
1152 was causing memory leaks.
1153 - src/gdcmSQItem.cxx:
1154 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
1155 cleanly handled with polymophism: sorry but my milage is low).
1156 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
1157 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
1158 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
1159 This avoids SegFaulting.
1160 - src/gdcmSQItem.h: coding style.
1162 - Test/TestWriteSimple still severely sucks. The output image content
1163 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
1164 damaged when displayed with vtkgdcmViewer.
1165 - on memory leaks: TestWriteSimple leaks really less (see entry
1166 of 2004-06-18 in Changelog file for the call to valgrind).
1167 - on segfaults: ctest now passes all the tests but one (no more
1169 * Erroneous leading white fix:
1170 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
1171 white[s] (as opposed to from >> xxx, that removes it [them].
1172 - src/gdcmTS.cxx: ditto.
1173 - gdcmPython/testSuite.py: dirty related kludge removed.
1174 * src/*: remaining references to gdcmParser removed.
1175 * src/*[cxx|h]: added copy[way]left header.
1178 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1179 * In order to fix writing of dicom files:
1180 - Test/TestWriteSimple.cxx: a simpler example of writing.
1181 - Test/CMakeLists.txt changed accordingly.
1182 - src/gdcmDocument.cxx:
1183 -- The destructor now recursilvely removes potential sequences.
1184 -- Bug fix in ::IsJPEG2000()
1185 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
1186 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
1188 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
1189 to only declared) and build on top of
1190 ::GetDocEntryByNumber(guint16, guint16).
1191 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
1192 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
1193 for usage in destructor and treatement of promotion in
1194 ::ReplaceOrCreateByNumber().
1195 - src/gdcmSQItem.cxx: destructor should better handle his job.
1196 Test/TestWriteSimple now runs (or at least it DOES something).
1197 * We can now start hutting memory links. A good starting point is:
1198 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
1199 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
1200 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
1202 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1203 * Valgrind note: after Mathieu Malaterre teached me how to read
1204 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
1206 Using gcc, you can force the STL to use malloc and to free memory as
1207 soon as possible by globally disabling memory caching.
1208 With 3.2.2 and later, you should export the environment variable
1209 GLIBCPP_FORCE_NEW before running your program.
1210 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
1211 simply vanish (it is still not clear to me, whether this means that
1212 STL std::string leaks or if valgrind believes it leaks...).
1213 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
1214 running bin/gdcmTests makeDicomDir):
1215 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
1216 - Test/makeDicomDir.cxx now properly traps empty lists and returns
1218 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
1219 SegFaulting (I drowned in DicomDir related code when trying to
1220 understand why the list is empty...).
1221 * src/gdcmDocument.h: first BSD license header try.
1222 * Doc/License.txt added.
1224 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1225 * src/gdcmDocument.[h|cxx]:
1226 - Clean up of the Transfer related predicates. They are now all based
1227 on new method isGivenTransferSyntax, that (should) handle properly
1228 the padding problem.
1229 - general clean up, simplification, and coding style.
1230 - Specific clean up of Parse7FE0() (umproperly named actually).
1231 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
1233 2004-06-14 Jean-Pierre Roux
1235 - fix the display of Sequence Delimitor (SQDepthLevel pb)
1236 - fix the display of SQItem ordinal number
1237 - add the GetSQItemByOrdinalNumber method
1238 - remove some useless never written private methods
1240 2004-06-14 Jean-Pierre Roux
1242 - adding a constructor taking a gdcmDocEntry as an input param
1243 - ReplaceOrCreateByNumber now returns :
1244 a gdcmBinEntry * if a Binary (void *) value is passed as a param
1245 a gdcmValEntry * if a string value is passed as a param
1247 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
1248 according to the param type (no longer sets a gdcmDocEntry)
1249 - GetValEntryByNumber, GetBinEntryByNumber added
1250 - NewValEntryByNumber and NewBinEntryByNumber added
1252 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
1254 - GetSQItemNumber and SetSQItemNumber added, to provide
1255 a (relative) Item identier inside a given Sequence
1256 \warning : some pb remaining around this number
1258 - AddEntry now takes the Item Number as a param
1260 - adding a constructor taking a gdcmDocEntry as an input param
1262 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1263 * Memory leak hunt with the following command:
1264 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1265 --show-reachable=yes gdcmTests PrintDocument
1266 It looks like many (all?) leaks are due to the STL (or a bad usage
1267 of the STL. The lines producing the leaks now have a comment with
1268 a "MEMORY LEAK" tag: you can retrieve them with
1269 grep "MEMORY LEAK" src/*
1270 Here are two typical examples which I can't help fixing:
1275 char * test = "babo";
1276 name = test; //// <--- valgrind detects 960 bytes lost in
1277 //// call to std::string::operator=(char const*)
1278 name.clear(); //// Doesn't help !
1286 std::cout << "Type a bunch of characters followed by RETURN: ";
1287 getline(std::cin, line); //// <--- valgrind dectects a loss
1288 //// of 1320 bytes in call to
1289 /// std::basic_istream<>& std::getline<>
1295 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1296 * src/gdcmHeader.[cxx|h]:
1297 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
1298 and related, moved away to gdcmDocument.
1299 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
1300 the corresponding protected accessors of inherited class
1301 gdcmDocument, removed ! As a consequence gdcmFile had to be
1302 declared friend of class gdcmDocument (see below).
1303 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
1304 - Clean up of undefined or unused methods.
1305 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
1306 account the changes to gdcmHeader.h).
1307 * src/gdcmDocument.h:
1308 - gdcmFile is now a friend class (in order to take into account the
1309 changes to gdcmHeader.h).
1310 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
1311 (see changes to gdcmHeader.h).
1312 - Accessors (reading on the form GetEntry*) are now public.
1313 - Clean up of undefined or unused methods.
1314 * src/gdcmDocument.cxx:
1315 - adaptation to changes to gdcmDocument.h
1316 - ::OpenFile now writes a verbose message when file cannot be opened.
1317 - some std::string properly set to VRKey
1318 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
1319 references to gdcmDocument.
1320 * Test/TestFindTags.cxx: changed accordingly to above changes.
1321 * gdcmPython/testSuite.py: adapted to renaming of acr files in
1322 cvs repository gdcmData.
1324 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1325 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
1326 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
1327 conflicts with gdcmValEntry::voidArea.
1328 * src/gdcmValEntry.cxx: unmatching comment wiped out.
1329 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
1330 Value representation between StringRepresentable and BinaryRepresentable.
1331 * src/gdcmDocument.cxx:
1332 - method ParseDES: proper indentation restored and usage of
1333 gdcmVR::IsVROfGdcmStringRepresentable wired in.
1334 - method LoadDocEntry: the fingerprint left in the SetValue() of
1335 unloaded entries (length > MaxSizeLoadEntry) had curiously been
1336 removed. Reverting to previous code segment with the proper
1337 dynamic_cast< gdcmValEntry* >.
1338 Note: this was (partially) breaking the python test suite
1339 (gdcmPython/testSuite.py) that made usage of the above
1340 fingerprint to check presence of "Pixel Data".
1341 * src/gdcmDocEntry.h: coding style.
1342 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
1343 now taken into account.
1344 * gdcmPython/gdcm.i: adaptation to the new internal representation
1345 of gdcm (exit gdcmParser, hello gdcmDocument).
1346 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
1348 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
1349 anymore, but instead prints the loaded Python dictionary.
1350 * .... alas, the python testSuite is still broken.
1352 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1353 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
1355 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
1356 * src/gdcmUtil.h : export methods
1358 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1359 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
1361 * Initial addition of automatic python testing
1362 * Initial addition of automatic image comparison
1364 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1365 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
1366 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
1368 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1369 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
1370 * Test/ShowDicom.cxx : bug fix for msvc compilation
1371 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
1373 2004-05-04 Jean-Pierre Roux
1374 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
1375 new concepts (and new classes) :
1376 a 'gdcmDocument' is composed of a set of Doc Entries, that are
1377 - elementary gdcmDocEntries (former gdcmHeaderEntries)
1378 - Sequence Doc Entries (gdcmSeqEntries)
1379 a Sequence is composed of Items.
1380 Each item is a set of Doc Entries (this is recursive)
1381 The non uniqueness of the 'Dicom tag' is due to this recursivity
1382 (never taken into account)
1383 Our unability to add a new 'entry' in the header
1384 at the proper location (neither in the H-Table (map or multimap),
1385 nor in the Chained List is also due to this recursivity.
1386 Don't try, right now, to use/modify/compile these new sources :
1387 nothing is finished.
1388 We just commit all the stuff, 'as is', in order not to loose it.
1390 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1391 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
1393 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1394 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
1395 file prefix (SetFilePrefix)
1397 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1398 * Add a new test: ShowDicom, for now this is just the c++ version of
1399 checkRead.sh, later it will be able to compare the image read against a
1401 * Replace the DEBUG on the stack with a global entry in cmake interface:
1402 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
1404 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1405 * Add an example subdir, with a real example on how to read + write a
1408 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
1410 * Doc/CMakeLists.txt: the main page is now properly differentiated
1411 between the developper and user version.
1412 * Doc/doxygen.config.in: dropped search related obsolete flags
1413 * src/gdcmParser.h, gdcmHeader.h: doxygenation
1415 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1416 * DEVELOPPER: added some helpfull comments for compile/test/install
1419 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1420 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
1421 src directory, now generated in the build dir.
1422 2. Tests as mentionned smarter
1424 4. Add a new method in gdcmDict that return the PubDict by name
1425 this is interesting for 3rd party lib like ITK,
1426 where we could set the institution name / patient name...
1428 * ENH: 1. Now the test suite is working for real
1429 2. All binaries are now output in the gdcm-bin directory
1430 (this was not true before)
1432 2004-04-28 Jean-Pierre Roux
1433 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
1434 SeQuence indented printing of Dicom Header.
1435 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
1436 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
1437 Computation of SQDepthLevel is now part of gdcmHeader constructor
1438 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
1439 tree-like structure of a Dicom Header.
1440 * FIX Test code cleaning
1442 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1443 * ENH: Adding automatic testing
1444 1. Need a DartConfig.cmake to submit to public
1445 2. Add a test driver gdcmTest.cxx
1446 3. gdcmTestMain, an helper for the main test driver gdcmTest
1447 4. Files in Test don't have a main anymore, this becomes interesting
1448 when we add more and more tests, thus dsw don't have to load
1450 * ENH: Adding a GDCM_DATA_ROOT for testing
1451 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
1452 one file instead of seven + some small cleanup
1454 2004-04-22 Jean-Pierre Roux
1455 * ENH Minor changes to the Print() methods.
1456 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
1457 Header printing. Example given with :
1458 > PrintHeader fileName 2 new
1459 (SQ based tree-like structure still to be done for the Header ...)
1461 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1462 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
1463 1. I have added some unsigned where needed
1464 2. Some function parameter not used -> (void)
1465 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
1466 4. g++ don't like character '\' in comment
1467 5. #define jpeg_create_decompress jCreaDecompress
1468 this really need to be fixed
1469 6. virtualize destructor of gdcmObject ... leakage
1470 7. sscanf(g->first.c_str(),"%x",&gr_bid);
1471 this also really need to be fixed
1472 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
1473 remove compression file
1474 (as we only do decompression, right ?)
1475 * ENH: Change malloc/calloc/free with c++ equivalent
1477 2004-04-21 Jean-Pierre Roux
1478 * FIX gdcmHeaderHelper::GetXSpacing
1479 when a single value is found (bug ?), xpacing is now
1480 defaulted to yspacing
1482 2004-04-19 Jean-Pierre Roux
1483 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
1484 * ENH add parameters :
1485 bool exception_on_error = false,
1486 bool enable_sequences = false,
1487 bool ignore_shadow = false
1488 to the gdcmFile constructors to be full gdcmParser compliant
1489 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
1490 to allow reading of PAPYRUS 3.0 files
1492 2004-04-06 Jean-Pierre Roux
1493 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
1495 2004-04-02 Jean-Pierre Roux
1496 * ADD : Test/checksequence.sh, for a general recap on SQ pb
1497 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
1498 for Philips spurious Tag fffe|0000 while rewritting Dicom files
1500 2004-03-30 Jean-Pierre Roux
1501 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
1502 for ACR file, written out as DICOM files (hope so...)
1504 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1505 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
1506 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
1507 moved to base class gdcmParser and only the specialisation is kept
1509 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
1510 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
1511 already does the job.
1512 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
1513 (to be consistent with gdcmParser::WriteEntries).
1515 2004-03-30 Benoit Regrain
1516 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
1517 upate of the object's instance. It's passed to 2 in the unfavorable
1518 case : one in the ExecuteInformation, one in the ExecuteData
1520 2004-03-29 Jean-Pierre Roux
1521 * ENH : Check on file type to be written moved
1522 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
1523 * FIX : gdcmObject::ResetBoundaries now stops properly
1524 when end-of-list is reached
1525 : gdcmVersion modified (as Benoit Regrain asked)
1527 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1528 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
1529 * src/gdcmUtil.cxx: added forgotten iostream include.
1530 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
1531 equivalent to ExplicitVR in existing code).
1533 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1534 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
1535 now contains all the gdcmGlobal related code.
1536 * minor coding style and doxygenation changes.
1538 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1539 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
1540 now contains all the Debug related code.
1541 * minor clean-up of includes in src/*.cxx
1542 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
1543 CreateCleanString) removed.
1544 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
1545 * Doc/DoxyMainPageUser.txt added.
1546 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
1547 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
1548 src/gdcmDirList.cxx)
1550 2004-03-24 Jean-Pierre Roux
1551 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
1553 2004-03-23 Jean-Pierre Roux
1554 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
1555 big endian made volumes
1556 * ENH Now gdcmParser constructor and destructor are protected to forbid
1557 end user to instanciate class gdcmParser
1558 (only gdcmHeader and gdcmDicomDir are meaningfull)
1560 2004-03-22 Benoit Regrain
1561 * FIX : src/gdcmDicomDir.cxx : make windows compilable
1562 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
1563 gdcmSerie to gdcmDicomDirSerie
1565 2004-03-19 Jean-Pierre Roux
1566 * ENH Now the tree-like structure describing a DICOMDIR comming from
1567 an already existing DICOMDIR file is consistent with
1568 the home-made tree-like structure build ex-nihilo
1569 or build from the files held (recursively) in a Directory
1570 functions gdcmDicomDir::CheckBoundaries()
1571 gdcmObject::SetBoundaries() added
1573 2004-03-17 Jean-Pierre Roux
1574 * REM (Eric Boix bug) : removal of meaningless
1575 gdcmDicomDirImage::NewImage function.
1576 * FIX now file names and directory name are written properly in the
1578 * FIX now gdcmDicomDir constructor may be call without any trick
1581 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1582 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
1583 of gdcmDicomDirImage::NewImage as empty function.
1585 2004-02-28 Jean-Pierre Roux
1586 * ENH add gdcmDicomDir:NewPatient
1587 add gdcmDicomDirPatient:NewStudy
1588 add gdcmDicomDirStudy:NewSerie
1589 add gdcmDicomDirSerie:NewImage
1590 to allow making gdcDicomDir object.
1591 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
1592 (as opposite to the gdcmHeader chained list)
1594 2004-02-11 Benoit Regrain
1595 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
1596 when using from python
1598 2004-02-10 Benoit Regrain
1599 * FIX : bug fix in the gdcmDirList for the recursivity in directories
1600 * FIX : in gdcmDicomDir when the directory is empty
1601 * ENH : add callback and methods to get the progression of dicomDir
1604 2004-02-06 Jean-Pierre Roux
1605 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
1606 - GDCM_META added to gdcmDicomDirType
1607 - class gdcmMeta created
1608 * ENH : - A brief summary is now displayed at the beginning of
1609 'testDicomDir' to help disaster magnitude estimation
1610 * REM : Now useless Test/explDICOMDIR.cxx
1612 2004-02-05 Benoit Regrain
1613 * ENH : add methods in gdcmObject to get the hash table or the list of
1615 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
1616 * FIX : wrapping python for TagHeaderEntryHT
1618 2004-02-04 Benoit Regrain
1619 * FIX : even length for some strings when writting the dicom dir
1620 * FIX : sort the images in the dicom dir
1621 * FIX : Bug fix for python use of dicom dir
1622 * ADD : a python demo
1624 2004-02-04 Jean-Pierre Roux
1625 * FIX : Final solution (?) for icone embedded images
1626 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
1627 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
1628 add groups 6002, 6004, 6006, to allow 'clean' parsing of
1629 gdcmData/gdcm-MR-SIEMENS-16.acr1
1630 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
1631 to make full checking easier
1633 2004-02-04 Benoit Regrain
1634 * FIX : WriteEntries : coding style & logic in parameters
1635 * FIX : Set the elements to create the DicomDir in a dictionary file
1637 2004-02-03 Benoit Regrain
1638 * gdcmDirList : to parse a hard drive directory in recursive (or not)
1639 * gdcmDicomDir : add the load of directory
1640 * Bug fix and print add-on
1642 2004-02-03 Jean-Pierre Roux
1643 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
1644 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
1645 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
1646 * FIX gdcmParser.cxx : 'group length' elements are now considered
1647 as integers, even for shadow groups, when file is Implicit VR
1649 2004-02-02 Jean-Pierre Roux
1650 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
1652 of the last synonym :-(
1653 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
1655 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
1656 * FIX taking into account the possible 7fe0,0010 multiplicity
1657 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
1658 to allow removal of references to 7fe0,0010, to deal with
1659 ACR-NEMA images, when 0028,0200 is meaningfull
1661 2004-01-31 Jean-Pierre Roux
1662 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
1663 no longer writes 'Un' on disk
1664 * FIX SQ elements with actual length are now dealt with corectly
1665 * FIX gdcmFile::WriteBase make the difference, for color images, between
1666 the length (for Palette expanded images)
1667 and Raw Length (non expanded image + Palette)
1668 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
1669 (that broke Write). Replaced by UL.
1670 Aware user will reload the field if he
1671 thinks it's necesssary
1673 2004-01-30 Jean-Pierre Roux
1674 * gdcmParser::CheckSwap() now defaults the filetype to ACR
1675 when 'dirty Acr' is found, to be compliant with the new
1676 IsReadable() methods.
1678 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
1679 (no DOUBLE images in kosher DICOM,
1680 but so usefull for people that miss them ;-)
1682 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
1683 DICOMDIR related utilities (not checked as Windoze compliant)
1685 2004-01-28 Jean-Pierre Roux
1686 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
1688 2004-01-27 Jean-Pierre Roux
1689 * gdcmParser constructor has a new boolean param,'ignore_shadow',
1690 to allow skipping the shadow elements, to save memory space.
1691 The TRUE value for this param has to be used
1692 with a FALSE value for the 'enable_sequence' param.
1693 ('public elements' may be embedded in 'shadow Sequences')
1694 * gdcmHeader methods now deal with 'embedded icones images' in the header
1695 (even when an 'icone image sequence' is announced by the
1696 element (0x0088,0x0200), but there is NO icone at all ...
1698 * gdcmHeader sometimes Image Location value doesn't follow
1699 the supposed processor endianity (see gdcmData/cr172241.dcm).
1702 * gdcmHeader add the method
1703 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
1704 to get *all* the Header Entries with the same tag.
1705 GetHeaderEntrySameName is probabely *useless*
1706 (no meaning : Name is *not* an identifier within the Dictionnary)
1708 2004-01-26 Benoit Regrain
1709 * Bug fix in the print of hexadecimal representations. Remove long fields
1710 in the print and add a third level of print to print them
1712 2004-01-23 Benoit Regrain
1713 * Bug fix on field having a VR = 'UI'. Assume that is a string field
1714 * Bug fix on test suite after remove the strip made on not string fields
1715 * Split the IsReadable method between gdcmParser which test that the file
1716 is dicom and gdcmHeader which test that it's an image file
1718 2004-01-22 Benoit Regrain
1719 * DicomDir : clean code, add methods, set variables in protected or private
1720 * gdcmUtil : bug fix for the clean string method
1722 2004-01-19 Benoit Regrain
1723 * Add the use of shadow dictionaries
1724 * bug fix and coding style
1726 2004-01-19 Benoit Regrain
1727 * src/gdcmFile.cxx : bug fix concerning the close of file
1728 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
1729 * Add the update of header entries using the shadow library
1731 2004-01-19 Benoit Regrain
1732 * removal of file gdcmHeader2.cxx
1733 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
1734 inheriting from gdcmParser. This split is to prepare the integration
1735 of dicom dir parsing
1736 * bug fix under python
1738 2004-01-16 Jean-Pierre Roux
1739 * REM removal of class gdcmHeaderEntrySet
1740 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
1741 * ADD add file gdcmHeader2.cxx
1742 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
1744 2004-01-15 Benoit Regrain
1745 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
1746 entries created while parsing the header. Thus, they will be destroyed
1747 when the gdcmDictSet will be destroyed
1748 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
1751 2004-01-15 Benoit Regrain
1752 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
1753 made a fatal error because of the memory release at the end of program.
1754 The problem was in vtkGdcmReader::ExecuteData where we were allocate
1755 some memory and vtk seems to have some problems with that.
1756 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
1758 2004-01-14 Benoit Regrain
1759 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
1760 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
1761 * src/*.[h|cxx] : make changes due to class name changes
1762 * gdcmPython/demo/*.py : bug fix due to method names
1764 2004-01-13 Benoit Regrain
1765 * src/*.[h|cxx] : coding style
1766 * vtk/*.[h|cxx] : coding style
1768 2004-01-13 Benoit Regrain
1769 * gdcmPython/testSuite.py : test the readable flag of file for tests
1770 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
1771 It's lied to the stl compilation by MSVC (windows, always windows...)
1772 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
1774 2004-01-12 Benoit Regrain
1775 * src/*.h : add comments
1776 * src/gdcmDictSet.h : set the method BuildDictPath in public
1777 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
1778 directly setted in the source code
1779 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
1782 2004-01-09 Benoit Regrain
1783 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
1784 * setup.py : use a reference to gdcmVERSION
1786 2004-01-07 Benoit Regrain
1787 * Modification to compile with the distutils.
1790 2003-12-10 Benoit Regrain
1791 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
1792 can use a gdcmHeaderHelper to load datas
1793 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
1794 made in the source code
1796 2003-12-10 Benoit Regrain
1797 * Update Windows projects and .cvsignore files
1799 2003-11-12 Jean-Pierre Roux
1800 * ENH gdcmHeader constructor has one more parameter (default value : false)
1801 that allows the user to 'go inside' the SeQuences only
1803 gdcmElValSet:Print takes it into account
1805 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1806 * ENH: Update gdcmPython/CMakeLists
1807 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
1808 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
1810 2003-11-10 Jean-Pierre Roux
1811 * FIX : gdcmHeader::LoadElements is now based
1812 on the ListTag listElem member,
1813 not longer on the TagElValueHT tagHt member
1814 * ENH : PrintPubElVal shows (temporarily) both results,
1815 with the tagHt member and the listElem member.
1816 (it's easier to 'see' the problems when using Printheader)
1818 * FIX : old private member LgrElem is now splitted into
1819 ReadLength : Length actually found on disk (updated only
1820 if bug fixing is necessary), for internal
1822 UsableLength : Updated by FixFoundLength, to fix a bug
1823 or to allow Parser going on.
1824 Will allow to re-write a kosher header when a SeQuence
1825 with a length (not 0000) is found
1826 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
1827 because gdcmElValSet::Add does not update ListElem
1830 2003-11-07 Jean-Pierre Roux
1831 * FIX misstyping in Transfert Syntax name table
1832 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
1833 when they have an actual length (not 0000 nor FFFFF)
1834 (Nobody should care of it, but DICOMDIR explorers)
1836 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1837 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
1839 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1840 * ENH: vtkGdcmReader now supports LUT !
1841 (vtkgdcmViewer for now is not able to use them though)
1843 2003-11-05 Jean-Pierre Roux
1844 * in testSuite.py : new files names for checking the package
1845 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
1846 that returns the pixel area size to the *aware* (vtk) user
1847 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
1849 2003-11-05 Benoit Regrain
1850 * in testSuite.py : Modify the rules for checking the paths
1851 : Explicit error messages
1852 * in __init__.py : Related modif
1854 2003-11-03 Jean-Pierre Roux
1855 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1856 to be used by aware (vtk) users that want to manage
1857 LUT (and no to turn the PALETTE image into an RGB pixels one)
1858 * GetPixelType now returns 8U for 24 Bits images
1859 (vtkGdcmReader compliant)
1861 2003-10-31 Jean-Pierre Roux
1862 * Removal of *all* gdcmData images and add them again
1863 in order to loose the 'history' of un-anonymised images
1865 2003-10-31 Jean-Pierre Roux
1866 * RMV : removal of useless jBitsInJsample.h
1867 for both 8 and 12 Bits JPEG Lossy Libraries
1869 2003-10-31 Jean-Pierre Roux
1870 * ENH : Add the functions gdcmFile::GetImageDataRaw
1871 gdcmFile::GetImageDataIntoVectorRaw
1872 that act as GetImageData and GetImageDataIntoVector
1873 except the making of an RGB Plane from Gray Plane + LUT
1874 Intended to aware (vtk) users who know how to manage
1877 GetLUTRGBA return a R,G,B,A LUT if any
1878 lgrTotaleRaw gives the 'Raw' length
1879 GetImageDataRaw returns the gray Plane
1880 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1881 (They stay Grey, just like with other Dicom viewers :-(
1883 2003-10-30 Jean-Pierre Roux
1884 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1886 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1887 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1888 being coherents dicom files.
1890 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1891 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1893 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1894 * ENH: Two steps is necessary to please VC++ compiler...
1895 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1896 * ENH: Add include dir to medcon lib
1897 * FIX: only one function is being exported for now !
1898 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1900 2003-10-29 Jean-Pierre Roux
1901 * adding gdcmHeader::GetLUTRGBA
1902 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1903 --> Mathieu, the modif u're waiting for is not yet committed
1904 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1906 2003-10-27 Jean-Pierre Roux
1907 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1908 00191113.dcm DermaColorLossLess.dcm
1909 MxTwinLossLess.dcm RadBWLossLess.dcm
1910 * ENH: For version prior to vtkImageViewer2 -r 1.19
1911 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1913 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1914 * Removal of ido stuff in CMakeLists.txt
1916 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1917 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1918 * FIX: remove a call to ->Modified ... see comments
1919 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1921 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1922 * FIX: Problem with path for libvtkgdcmPython
1923 * ENH: Try adding a search script for python site-package
1924 * RMV: Remove some file from medcon lib that are not necessary
1925 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1926 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1927 * FIX: More pragma disable fro VC++,
1928 I don't think I break something as it is also disable in VTK/ITK.
1929 But it fasten debug compilation time.
1931 2003-10-23 Jean-Pierre Roux
1932 * gdcm now deals with 16 Bits Run Length Encoded images
1933 (they are compressed as 2 planes images,
1934 one for the high Bytes, the other for low Bytes)
1936 2003-10-22 Jean-Pierre Roux
1937 * Now CheckRead takes into account :
1938 - the bugged 'Leonardo' Siemens images
1939 - the XA images, sent thru the burning VPRO station
1940 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1943 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1944 * FIX: When copying a Makefile.am to CMakeLists.txt
1945 one should remove the '\'
1947 2003-10-22 Jean-Pierre Roux
1948 * in gdcmData adding a bugged 'Leonardo' Siemens image
1949 (wrong lengths in header)
1950 OK with gdcm, KO with the other viewers :-)
1951 * add a GE dlx XA image, thru the VEPRO burning station
1954 2003-10-21 Jean-Pierre Roux
1955 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1956 for a brutal checking of vtkgdcmViewer compliance
1958 2003-10-21 Jean-Pierre Roux
1959 * add the files for 'xmedcon' Jpeg Lossless library
1960 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1962 2003-10-21 Jean-Pierre Roux
1963 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1965 2003-10-21 Jean-Pierre Roux
1966 * garbage Siemens 'Leonardo' images dealt with
1967 (the patch is easy to remove)
1968 * cosmetic changes to avoid warnings
1970 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1971 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1972 no need to press 'r' now.
1974 2003-10-20 Jean-Pierre Roux
1975 * upgrade of checkRead.sh checkWrite.sh according
1976 to new Jpeg Lossless decompressor
1977 * add US.3405.1.dcm, a genuine RGB medical file ...
1978 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1979 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1981 2003-10-15 Jean-Pierre Roux
1982 * general anonymisation in gdcmData
1983 * adding the 'color files' from
1984 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1985 * adding some well knowed bugged-header images
1986 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1987 waiting for their inclusion in Python testsuite
1989 2003-10-15 Jean-Pierre Roux
1990 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1991 no longer seg faults when file is not found
1993 2003-10-14 Jean-Pierre Roux
1994 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1997 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1998 * TODO: *.in file to genereate a UseGDCM later
2000 2003-10-14 Jean-Pierre Roux
2001 * Some supposed-to-be Dicom Images have no preamble.
2002 OpenFile takes it into account
2003 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
2004 * Missing elements added in dicomV3.dic
2005 (just to be affraid : have a look at
2006 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
2007 and do it again next year ;->
2009 2003-10-13 Jean-Pierre Roux
2010 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
2011 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
2012 But there are NOT. It's fixed !
2014 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2015 * FIX: "jpeglib.h" was not found on VC++
2016 * FIX: vtkgdcm was not being installed
2018 2003-10-10 Jean-Pierre Roux
2019 * ENH : OpenFile closes the file if it *really* doesn't look like
2020 an ACR-NEMA / DICOM one.
2021 * FIX : testWrite no longer writes an empty file if the source file
2022 is not gdcm Readable
2023 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
2026 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2027 * FIX: CMake generate now documentation
2028 * ENH: out of source doc build !
2029 * ENH: Generate both user and dev documentation
2030 * ENH: Should work on windows too
2031 * ENH: Only one doxygen config.in file is needed
2032 * FIX: make install should be ok now on ùnix plateform
2033 * FIX: PATH to dictionary was wrong (missing /)
2034 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
2036 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2037 * vtkGdcmReader is now able to read rgb dicom file.
2038 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2039 * added a gdcmViewer to vtk test, use mouse to control
2040 window level & window width
2042 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2043 * CMake-ification of gdcm, we have now two build system
2044 * FIX: on cygwin Wsock32 doesn't exist
2045 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
2047 2003-10-06 Emanuel Ollart
2048 * FIX : compilation process wad broken.
2049 Changed gdcmViewer_sources to vtkgdcmViewer_sources
2051 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2052 * change gdcmViewer -> vtkgdcmViewer
2053 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
2055 2003-10-06 Jean-Pierre Roux
2056 * FIX :A few nasty patches to allow the reading of a lot of nasty images
2057 ( e.g : well known GE images with a wrong elem length,
2058 : Philips MRI Images with a wrong Huffman table)
2059 * still to be done : allow the reading of bugged LEONARDO Siemens images
2061 2003-10-03 Jean-Pierre Roux
2062 * Odd length strings are padded with '\0' (not with spaces,
2063 to remain compliant with already defined strings,
2064 like Transfert Syntax UID and others)
2066 2003-10-03 Jean-Pierre Roux
2067 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2068 to allow displaying RGB images (not only by affim ;-)
2070 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2071 * vtkGdcmReader is now able to read rgb dicom file.
2072 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
2074 2003-10-03 Jean-Pierre Roux
2075 * A few nasty patches to allow the reading of a lot of nasty images
2076 ( e.g : well known GE images with a wrong elem length,
2077 : Philips MRI Images with a wrong Huffman table)
2078 * still to be done : allow the reading of bugged LEONARDO Siemens images
2080 2003-10-03 Jean-Pierre Roux
2081 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
2083 2003-10-03 Jean-Pierre Roux
2084 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
2085 to allow displaying RGB images (not only by affim ;-)
2087 2003-10-03 Jean-Pierre Roux
2088 * gdcmFile::GetImageDataIntoVector now
2089 - deals with MultiFrames MultiFragments Run Length Encoded files
2090 - deals with YcBcR (YBR_FULL) files
2091 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
2092 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
2094 (no sample found :-(
2096 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2097 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
2098 Two reasons: - clear things
2099 - third parties acces gdcm through header files, so won't
2100 suffer anymore VC++ complains
2102 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2103 * add argv[1] in testvtkGdcmReader.cxx
2106 2003-09-24 Jean-Pierre Roux
2107 * The lines are now eigthy characters long.for
2108 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
2110 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2111 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
2112 char* to std::string. Thus, the use of strdup becomes useless. (see
2113 previous commis of Malaterre)
2114 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
2115 before the last Malaterre's commit.
2117 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2118 * This commit should fix the Debug building under VC++, the problem
2119 was mainly a mixture of debug and release lib being loaded at startup.
2120 * I also remove a depency to a specific C function: strdup. Because I had
2121 to force the link to msvcrtd (whereas strdup is in libc).
2123 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2124 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
2125 located in the gdcmCommon.h file. All use of reference of tha has been
2126 changed to now use the variable GDCM_UNFOUND.
2128 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2130 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
2131 Dicom dictionary. The test suite can now be run again. Note:
2132 I'm note very happy with the " (RET)" changes. I believe this
2133 RETAINED comment should be dropped when parsing the dictionary.
2134 - PACKAGER corrected
2136 - AUTHORS updated and now in alphabetical order
2137 * Makefile.am now exports gdcm.dsw for Windoze users.
2139 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2140 * cygwin complains about missing std:: in subdir Test/
2142 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2143 * remove some methods that are now in gdcmHeaderHelper
2145 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2146 * vtkGdcmReader set spacing and origin correctly
2148 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2149 * Fix a few delete/delete[] mismatch
2151 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2152 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
2153 interpretation to data given by gdcmHeader. For instance there are
2154 heuristics to get informations (look at different places).
2155 * it also include a specific class: gdcmSerieHeaderHelper devoted to
2156 sorting DICOM images based on different strategies.
2157 * modified Makefiles accordingly.
2159 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2160 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
2161 when building in debug mode
2162 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
2163 src/win32/gdcmdll.dsp
2164 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
2166 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2167 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
2170 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2171 * src/win32/libgdcmjpeg12.dsp was not dos format
2172 * src/win32/libgdcmjpeg12.dsp :
2173 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
2174 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
2176 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2177 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
2179 * src/gdcmFile.cxx : bug fix in affectation type
2180 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
2181 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
2182 * Modifs of MVSC projects to compile them. Not concerning 2 identic
2183 symbols... future problem ?
2185 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2186 * src/win32/libgdcmijpeg12.dsp was missing
2187 * modified gdcm.dsw accordingly
2189 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
2190 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
2192 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2193 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
2194 commit of JPR (before his hollidays to facilitate our work).
2195 * setup.py : bug fix in code. Modifications made while the last commit
2196 of JPR. The code hasn't been tested before the commit... it's so
2197 useless to make that (for best programmer that is JPR) !!!
2199 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2200 * tagged the current version as Version0_3 (i.e. version 0.3)
2202 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2203 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
2204 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
2205 * *.dsp : modifications to use new libgdcmijpeg8 library
2206 * setup.py : bug fix on VTKPATH variable
2207 * PACKAGER : adding all concerning windows
2209 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2210 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
2212 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
2213 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
2214 test suite reported error.
2215 * PACKAGER file added (describes what a packager must do when
2216 packaging a new release).
2217 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
2218 * configure.in: upgraded version number to 0.3.0
2219 * fixing build of rpm (through rpm -ta):
2220 - Doc/Makefile.am exports proper doxygen files
2221 - src/jpeg/libijg8/Makefile.am exports the include files.
2223 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2224 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
2225 * src/gdcmHeader.h : formatting code
2227 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2228 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
2229 We were obtaining error message from vtk. Now, creation of file list
2230 is made in an internal list to prevent this problem.
2231 Bug fix when output is empty.
2232 Bug fix in update of progress value. Previous commit for this was a bad
2234 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
2236 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2237 * src/gdcmHeader.h : added method to get the file name
2238 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
2239 files. Added method to remove all files on the input
2240 Added FIXME comment concerning the bad parsing of header made by
2241 ExecuteInformation method (in ExecuteData method)
2243 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2244 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
2245 when using make instal.
2246 * src/gdcmFile.cxx : bug fix under Window after JPR commit
2247 RQ : the JPR doesn't appear in the ChangeLog... normal for him
2249 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2250 * setup.py : adding include dir of jpeg lib to compile all sources
2251 * */Win32/*.dsp : JPR fix for windows compilation
2253 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2254 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
2256 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
2257 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
2259 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2260 * setup.py is again effective on un*x (takes into account the
2261 addon of the jpeg library)
2262 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
2263 * Doc/Doxy* updated (includes above enhancements)
2264 * INSTALL now points to web documentation
2266 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2267 * src/gdcmHeader.h doesn't make unnecessary reference to
2269 * gdcmPython/Makefile.am now avoids calling the wrappers for the
2271 * src/gdcm*.[cxx|h] :
2272 - to allow compilation with gcc 3.x
2273 -- clean up of STL usage (added explicit usage of std::)
2274 -- small fixes on exceptions.
2275 Note: linking not tested !
2276 - clean of doxygen comments to avoid warnings at documentation
2278 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
2279 dependent convertion).
2281 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2282 * Clean up of previous JPR garbage commit (not even commented in the
2284 - Test/Makefile.am removed the reference to unexisting testTS.cxx
2285 - moved all jpeg related files from src to src/jpeg/libijg8, with
2286 addition/modification of Makefile.am and configure.in.
2287 - the testSuite is still brain damage (not guilty).
2289 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2290 * WrapVTK.py : modifications to get correctly vtk source files to
2292 * vtk/vtkGdcmReader.cxx : modification for an already existing name
2293 (FileName -> Filename)
2295 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2296 * vtk/vtkGdcmReader.[cxx/h]:
2297 - UpdateProgress method should now be effective
2298 - removed the limitation on having only images loaded (as opposed
2300 - when building a stack of images/volume, a lesser number of
2301 gdcmHeader and gdcmFile instances should be used (hopefully
2302 accelerating things).
2303 - when building a stack of images/volumes, files which are not
2304 loadable (wrong path-filename, wrong permissions on existing file,
2305 or file not parsable by gdcm) are replaced with a black image
2306 in the stack (for the caller to notice the problem).
2308 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2309 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
2311 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2312 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
2313 between standard library (std) and vtk library (problems are found
2314 under Windows... thanks Windows !)
2316 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2317 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
2319 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
2321 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2322 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
2324 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2325 * When compiling with distutils (see setup.py) the C++ compiler is
2326 called with different flags than the default ones (with automake).
2327 In order to fix all those warning, I compiled gdcm with the command
2328 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
2329 and went for warning fixes:
2330 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
2331 up from unused variables.
2332 - vtk/vtkGdcmReader.cxx: potential bug fix.
2333 * src/gdcmHeader.h: Doxygen warning cleanup
2335 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2336 * gdcmPython/gdcm.i:
2337 - typemaps correction to take into account the systematic replacement
2338 of "using namespace std" with std:: prefix e.g. std::list,
2339 std::string... (cf changes of 2003-05-21).
2340 - gdcmGlob global variable of type gdcmGlobal (defined in
2341 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
2342 exported to Python a as cvar.
2343 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
2344 and GetPubDictTagNamesByCategory() as a replacement for deprecated
2345 gdcmDictSet.GetPubDictTagNames() and
2346 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
2347 C++ static methods).
2348 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
2349 with the above changes.
2351 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2352 * setup.py, manifest.in : bug fix under linux
2354 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2355 * Modification of setup.py to compile vtk part too. Then, we have 2
2356 wrappers which must work with same distutils. For that, we have a
2357 generic distutils in distusiltsWrapping.py ; with :
2358 - build_extWrap class to wrap generically all extensions,
2359 - ExtensionWrap base class for all wrapping extension that contains
2361 - Wrapper interface which wrap sources
2362 + In WrapSwig.py we have extension and wrapper for Swig
2363 + In WrapVTK.py we have extension and wrapper for VTK
2364 * MANIFEST.in : modifications to consider vtk directory and new python
2365 files for compilation
2367 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
2368 * Added python wrappers of vtkGdcmReader vtk class (see the
2369 source in vtk/vtkGdcmReader.cxx) :
2370 - vtk/Makefile.am now builds a library
2371 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
2372 python library (as opposed to _gdcm.so wich are the python
2373 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
2374 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
2376 - configure.in has an additional flag --enable-vtk that needs
2377 to be set to enable compilation of vtk related code, that is:
2378 + vtk/vtkGdcmReader.so and
2379 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
2380 + gdcmPython/vtkgdcmPython.so (see above)
2381 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
2382 be read when compressed or when HighBit + 1 != BitsStored),
2383 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
2384 the usage of the python wrapper of vtkGdcmReader vtk class.
2385 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
2386 * src/*.[h] all occurences of stl classes are now prefixed with
2387 std::, and all occurences of "using namespace std;" where removed.
2388 This is to avoid pollution of global namespace in included files.
2389 Apparently vtk does not avoid this pitfall: when using both
2390 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
2391 collision of various stl members (principally cout...).
2392 * gdcmPython/testSuite.py now cleanly removes temprory generated
2394 * gdcmPython/gdcm.i now declares a typemap for std::string (to
2395 comply with above changes)
2397 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2398 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
2399 * vtk/vtkGdcmReader.cxx now properly inports the image in the
2400 vtk data structure (an image Flip was required).
2401 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
2402 * cosmetic changes in documentation.
2404 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2405 * src/gdcmHeader.cxx: the constructor no longer exits when an
2406 unexisting file is given as argument.
2407 * The subdirectory Data (containing all the images used for the
2408 test suite) is not part of this repository anymore. A new module
2409 containing those images is now available at
2410 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
2411 with the name gdcmData.
2412 All the python scripts (including the package initialisation file
2413 gdcmPython/__init__.py) were adapated to take this change into
2414 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
2416 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2417 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
2418 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
2419 demo of the usage of this class.
2420 Compilation of this vtk part is only done when using the --enable-vtk
2421 at configure (or autogen.sh) stage.
2423 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2424 * More memory link related corrections and documentation fixes.
2426 - maximum info is obtained with a command of the form:
2427 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
2428 --show-reachable=yes PrintHeader
2429 - the remaining reachable blocks seem to come from the STL
2430 allocation scheme through the usage of map and list. It looks
2431 like this memory cannot be freed but it is not a memory leak
2432 (in fact further invocation to the STL would recollect the
2433 unused memory allthough it cannot explicitely be freed).
2434 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
2435 of displaying an image parsed with gdcm and displayed with VTK.
2436 Note: some images don't seem to work e.g.
2437 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
2438 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
2439 Allthough this weakens the semantics, it is a ditch attempt to
2440 make gdcm more thread friendly.
2442 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2443 * Memory link hunt (by using valgrind through the command
2444 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
2445 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
2446 gdcmHeader::_dicom_vr.
2447 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
2448 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
2450 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
2452 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2453 * src/Makefile.am now exports all the necessary include files at
2457 * UpdateGroupLength replaced by new one
2460 * UpdateGroupLength re-written using H-Table
2461 (named UpdateGroupLengthNew untill checks are over)
2463 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
2464 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
2465 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
2467 - gdcmHeader::GetPubElValSet removed.
2468 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
2469 UpdateGroupLength, WriteElements, Write.
2470 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
2471 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
2472 carried the same semantics.
2473 - src/gdcmHeaderIdo.cxx changed accordingly.
2474 - gdcmFile::WriteBase now regroups all the codes from previous
2475 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
2476 - enum FileType moved to gdcmCommon.h
2477 * src/gdcmHeader.cxx AddDefault trashed
2478 * gdcmGetXSize added
2479 * getimageDataSize now calls gdcmGetXSize
2480 * Test/*.cxx changed to agree with above changes
2482 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2483 * src/gdcmHeader.h: LoadElements() is not a public method anymore
2484 (to avoid double call by end user).
2485 * Test/*.cxx LoadElements() doesn't need to be called explicitely
2486 by end user, since gdcmHeader::gdcmHeader now handles it.
2488 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2489 * gdcm/Doc many doxygen changes:
2490 - Doxyfile now has two different versions, DoxyfileUsers that generates
2491 the html.users end users oriented documentation and
2492 DoxyfileDeveloppers that generates the html.developper developper
2493 oriented documentation.
2494 - README changed accordingly
2495 - requirement.txt removed (old design info moved to TODO).
2496 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
2497 DoxyMainPage.txt, DoxyPython.txt provide more information.
2498 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
2499 be updated by simply regenerating the docs with doxygen and copying
2500 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
2501 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
2502 all the tests in the form "if (<map>.count() >1)" were removed.
2503 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
2504 ill-formed documentation sections.
2505 * src/gdcmHeader.cxx: ditto
2507 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2508 * setup.py fixed for un*x (needed macro for stdint.h)
2509 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
2510 un*ces with sh-utils test utility.
2511 * gdcmPython/demo/test.py renamed to PrintHeader.py
2512 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
2513 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
2514 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
2515 * src/gdcm*.cxx JPR's bad inclusion fixed.
2517 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2518 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
2519 * gdcmPython/demo/test.py changed accordingly.
2521 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2522 * gdcmPython/Makefile.am fixed linking against libstdc++
2523 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
2524 * Swig subdir (historical tests of swig version 1.3.17++) removed
2525 * Test/testChangeEntete.cxx some lines commented out in order to make
2527 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
2528 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
2530 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2531 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
2532 hence the user doesn't need this explicit call.
2533 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
2534 i.e. LoadElements() call removed.
2535 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
2536 - src/Makefile.am declares the proper flag for g++.
2537 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
2538 for adding user defined new tags.
2539 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
2540 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
2541 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
2543 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
2544 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
2545 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
2546 src/Makefile.am : the project should properly compile and install
2547 with the autotools, included the python wrappers part.
2548 * gdcm.spec.in : added a spec file for RPM packaging.
2550 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2551 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
2553 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2554 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
2555 to exported to the environement (see gdcmPython/testSuite.py
2557 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
2558 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
2559 ElValue class renamed to gdcmElValue for obvious consistency reasons.
2560 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
2561 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
2563 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2564 * gdcmPython/__init__.py doesn't crash anymore when running in
2565 in InstallMode or PreInstallMode but with an environement given
2566 value of GDCM_DICT_PATH.
2567 * src/gdcmDictSet.[cxx/h] coding style.
2569 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2570 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
2571 * src/gdcm.h general comments moved to TODO, and README
2572 * src/gdcm.h should now be seen as a user commodity (including it
2573 should suffice to fully use gdcm). It is nowhere including within
2574 any of the kernel files src/*.cxx and src/*.h.
2576 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2577 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
2578 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
2580 * src/gdcm*.cxx only include their corresponding include file
2581 (as opposed to gdcm.h)
2582 * gdcmPython/gdcm.i changed accordingly
2583 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
2584 the autogen.sh generated "make snapshot" command to work.
2585 * autogen.sh removed history related references to crea package.
2587 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2588 * distutilsSwigCPlusPlus.py work around some swig portability
2591 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2592 * Eventually, python/gdcmPython was renamed to gdcmPython. This
2593 was done in a last ditch attempt to get setup.py _really_
2594 operationnal. The python/gdcmPython layaout add the advantage
2595 of hidding away the python related distutils specific files
2596 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
2597 Alas, the src directory was out of scope (i.e. it's relative
2598 position to setup.py was ../src) which made things impossible to
2599 handle (see previous version of python/setup.py). Crossing fingers...
2601 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2602 * python/setup.py now works on Un*x. (harder than I thougth)
2603 * python/distutilsSwigCPlusPlus.py can now have include files
2604 among the list of sources.
2606 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2607 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
2608 * modifications in MSVC projects
2610 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2611 * As stated by the first lines of Test/ExceptionAndPython/README, it
2612 looks like we can move back to original usage of exception within
2613 src/gdcm* and hence remove the errno stuff that was introduced
2614 as a quick and dirty fixture of this problem (added to the TODO).
2615 * Doc/Doxyfile configuration file for Doxygen and corresponding
2616 README file for usage added.
2617 * Test/testWrite.cxx added. This new test comes from a split of
2618 test.cxx that is now reverted to its original purpous i.e.
2619 testing the proper parsing of a Dicom related file.
2620 testWrite.cxx concentrates on testing the IO part of gdcm.
2621 * Test/bug1.cxx (containing a bug on WIn32) added.
2622 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
2623 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
2624 whose purpose is to publish the content of the TagNames of the
2625 Dicom public dictionnary were not accessible without an
2626 instance of class gdcmHeader.
2627 - those methods are now static methods of gdcmDictSet and hence
2628 require no instances at all to be invocated.
2629 - within gdcmDictSet this change required to change some method
2630 to class methods (i.e. are now static) among which SetDictPath
2631 (renamed to BuildDictPath) and LoadDefaultPubDict.
2632 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
2633 the above changes by calling the new method classes of gdcmDictSet.
2634 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
2635 the above to be effective.
2636 * python/gdcmPython: in order to wrap properly the above changes
2637 for Python, swig version now needs to be > 1.3.17.
2638 * python/gdcmPython/Makefile fixed to adapt itself to new
2639 configure/make shema introduced by Johan Montagnat (thanks for the
2640 contribution). Alas this Makefile cannot be turned into a proper
2641 Makefile.am without some heavy changes in the configure.in
2642 (for python dectection).
2643 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
2644 now avoids publishing the empty entries.
2646 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2647 * python/setup.py : bug fix concerning install under windows
2648 ExtraPath reused :-P
2649 * gdcm.dsw : bug fix concerning path for libraries for python !!!
2651 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
2652 * Dicts/dicomV3.dic : remove double spaces !!!
2653 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
2654 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
2657 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2658 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
2659 method. Doxygenation.
2660 * src/gdcm.h clean up of JPR spurious comments.
2662 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2663 * python/distutilsSwigCPlusPlus.py now properly collects the
2664 shadow classes generated by "swig -c++" (gdcm.py in our case)
2665 when using "python setup.py install".
2666 * python/gdcmPython/__init__.py imports gdcm.py and only manually
2667 reexports the working classes.
2668 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
2669 by the classical C errno scheme. This is to prevent an obscure
2670 behavior of the python wrappers when importing wxPython.wx prior
2671 to gdcmPython (which ended up in an abort call). An illustration
2672 of this oddity can be found in the Test/ExceptionAndPython
2673 subdir (see the README file). This problem probably due to
2674 an combination of g++ and dynamic loading.
2675 * added Test/ExceptionAndPython (see above)
2677 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2678 * Changed the layout of the python part to avoid bloating main
2679 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
2680 i.e. the distutils arsenal. All the python related stuff is
2681 again in a python subdir, but the package itself is now in
2683 * setup.py was cleaned up:
2684 - pythonIncludePath removed
2685 - python setup.py bdist target is now functional.
2686 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
2687 collision with other packages). gdcmPython/demo/*.py changed
2690 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2691 * python subdir moved to gdcmPython (preparation of distutils packaging).
2692 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
2693 distutils installer is operational.
2694 * - gdcmPython/__init__.py now properly loads the swig generated
2695 shadow classes (from gdcm.py).
2696 - gdcmPython/demo/*.py changed to import the package gdcmPython
2697 instead of gdcmPython/demo/load.py.
2698 - gdcmPython/testSuite.py changed to import the package gdcmPython.
2700 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2701 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
2702 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
2703 entries within the associated public Dicom dictionary resp. the same
2704 information but sorted by the fourth field (PAT, IMG, DIR) of the
2706 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
2707 are now in the "???" group.
2708 - python/gdcm.i changed accordingly,
2709 - python/demo/printGroupedPublicDict.py added, that gives an example
2710 of the above new functionalities in Python.
2712 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2713 * src/gdcm.h, gdcmHeader.cxx:
2714 - historic references to glib's g_malloc and g_free (#defined)
2715 were definitively removed.
2716 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
2717 * src/gdcmElValSet.cxx:
2718 - GetElement(guint32, guint32) renamed to GetElementByNumber.
2719 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
2720 - GetElValue(string) renamed to GetElValueByName.
2721 - Added GetElementByName(string).
2722 * src/gdcmHeader.cxx: added
2723 - GetPubElValRepByNumber(guint16, guint16)
2724 - GetPubElValRepByName(string)
2725 - GetShaElValRepByNumber(guint16, guint16)
2726 - GetShaElValRepByName(string)
2727 - GetShaElValByNumber(guint16, guint16)
2728 - GetShaElValRepByName(string)
2729 - GetElValRepByNumber(guint16, guint16)
2730 - GetElValRepByName(string)
2731 - GetElValByNumber(guint16, guint16)
2732 - GetElValRepByName(string)
2733 * Doc/requirements.txt added.
2735 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2736 * Test/Makefile building now depends on the one of libgdcm.so
2737 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
2738 pixel data) aware which enables finding the address (offset) of
2739 the pixel data of JPEG encoded DICOM files. This leaves only a single
2740 file in the testSuite whose pixel data address (offset) is unknown.
2741 * python/testSuite.py changed accordingly.
2743 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
2744 * VC++ has some strong limitations when working with the STL, as stated
2745 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
2746 "Also note that some STL containers (map, set, queue, list, deque)
2747 cannot be exported. [...]
2748 Some STL classes contain nested classes. These classes can not
2750 This is caused by a designed limitation that once a template
2751 class is instantiated, it can not be re-instantiated and
2753 Since our usage of map<> is ubiquitous in gdcm, this "designed
2754 limitation" of VC++ is a pitfall.
2755 Hence the Python wrappers of gdcm cannot be incrementally linked
2756 against the c++ dynamic library. The dirty but only workaround is
2757 to forget about incremental link of dynamic libraries and to generate
2758 the Python wrappers library with the inclusions of the underlying C++
2760 The following modifications concern this matter on Win32/VC++:
2761 - wrapping python correct with standalone wrapped dll (don't use separate
2762 dll under windows !!!!)
2763 - python21_d debug mode enabled (ask Frog how to use it :-)
2764 - NO problem with having an STL member of class for example string in C++
2765 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
2766 - Python test of dcmlib in Python is ok under windows on a large set
2768 * removed glib references
2769 * typedef's inserted in gdcm.i for correct swig type management
2771 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2772 * python/demo/*.py load.py extracted from test.py. Added explore.py
2773 that only displays required tags and testAll.py that parses all
2774 the files of the testsuite without using unittest.
2775 * python/testSuite.py other additional test on new files added.
2776 * Data/* new test files added accordingly to the testSuite.
2777 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
2778 the vr in the file differs from the one of the dictionary.
2780 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2781 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
2782 values, but limits itself to values which are below a user specified
2783 size (by default 1024 bytes).
2784 * python/gdcm.i : elements not loaded (because their size is above the
2785 user specified treshold) are exported with their TagKey as key of the
2786 python dictionary. This enables the testsuite to make some checks
2787 on the unloaded elements (since we have their offset and size).
2788 * python/testSuite.py
2789 - now tests for the existence and proper value of the pixel data
2790 - two new examples added.
2791 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
2793 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2794 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
2795 aware. See the strategy comments in gdcmHeader::FindeLength().
2796 * Test/test.cxx now accepts a filename as first argument.
2797 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
2798 * python/testSuite.py changed to integrate test on above files.
2800 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2801 * Dicts/dicomV3.dic removed all the trailing (RET) when the
2802 the vr was also RET.
2803 * python/testSuite.py more tests added.
2805 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2806 * python/testSuite.py unittest test suite added (uses Data)
2807 * Data/* dcm and acr files for the test suite.
2808 * glib dependance removed from un*x version. We now use ISO C99
2809 7.18 Integer types (see stdint.h)
2810 - python/Makefile, src/Makefile src/gdcm.h
2811 * src/ when an explicit vr (like dicom files) suddenly poped an
2812 implicit element we use to mark the underlying DictEntry of the
2813 concerned ElValue with "Implicit". This strategy was damageable
2814 too the public or provite dictionaries, since some of their vr
2815 would be changed. Since Header::FindLength heavily relies on the
2816 detection by Header::FindVR of falsely explicit elements, I
2817 added an extra ImplicitVr member to ElValue (boolean).
2818 The rest of the changes we the necessary adaptations.
2820 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2821 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
2823 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
2825 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2826 * Adaptation for porting to VC++:
2828 o forced to use std namespace (for string to be known)
2829 o all class use __declspec export style on WIN32
2830 - src/gdcmUtil.cxx new Exit method that wraps the exit call
2831 (in stdlib.h on Win32 but in std:: for gcc)
2832 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
2833 variable GDCM_DICT_PATH.
2834 * src/gdcmHeader.cxx verbose comments made discrete.
2836 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2837 * python/gdcm.i: added a typemap that converts a C++ hashing table
2838 to native Python dictionary.
2839 * python/demo/test.py:
2840 - now uses the native dictionary for exploration of gdcmHeader.
2841 - takes an optional filename argument (the file to parse).
2842 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
2843 PubElVals hashing table.
2844 * Dicts/dicomV3.dic removed error prone trailing spaces.
2846 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2847 * Python wrapping process moved away from src/Makefile to
2848 newly created python/Makefile (as well as gdcm.i)
2849 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
2850 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2851 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2852 from the environement variable GDCM_DICT_PATH (when existing).
2853 * src/gdcmDict::GetTag bug fix.
2855 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2856 * Straightforward temporary fixes for swig to build the python wrappers.
2857 src/Makefile now has a python working entry [by working we mean
2858 that we can import de shadow classes without errors].
2860 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2861 * hashtest.cxx removed (since allready in Test)
2862 * src/gdcmlib.h renamed to src/gdcm.h
2863 * src/dcm.i renamed to src/gdcm.i
2864 * src/Makefile prepared for python wrapping
2866 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2867 * src/gdcmHeader.cxx :
2868 - Parsing of header is now separated from loading of element values
2869 (see gdcmHeader::LoadElements).
2870 - general clean up of hopefully all file access (creation of
2871 ReadInt16 and ReadInt32)
2873 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2874 * src/gdcmHeader.cxx :
2875 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2877 - SetLgrElem renamed to SetLength
2878 - GetLgrElem renamed to GetLength
2879 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2880 * src/gdcmElValSet.cxx fixed both GetElValue methods
2881 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2882 due to IdoDude was cleaned out.
2884 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2885 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2886 concentrates on finding the value representation (when it exists).
2887 RecupLgr now only finds the element value length, and it avoids
2888 returning the unecessary skL (skipped length).
2889 Also, offsetCourant was simply removed (with taille_fich) since
2890 it was redundant with the File position internals (by using
2891 ftell and fseek). This also made skL (see above in RecupLgr) usage
2893 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2894 on the libido specificities which are handled through class
2896 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2899 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2900 * Truckload of changes. Parsing of header is barely functional
2901 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2903 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2904 * src/gdcmHeader.cxx many addons of low level methods
2906 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2907 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2908 and _IdDcmSWAP_LONG.
2910 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2911 * This corresponds to all the changes decided at the meeting of
2912 May 23 2002. Needless to say we are running late...
git://git.creatis.insa-lyon.fr / gdcm.git / blob