1 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2 * src/gdcmDicomDir.cxx, gdcmDocEntrySet.cxx: removed inclusion of errno.h
3 * src/gdcmDocument.[h|cxx], gdcmFile.[h|cxx], gdcmHeader.[h|cxx]:
4 enable_sequences removed from gdcmHeader constructor and dependencies.
5 * Example/PrintHeader.cxx: fixed accordingly (enable_sequences removal).
6 * gdcmPython/demo/PrintHeader.py: dummy fix.
8 2004-07-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
9 * Test/CMakeLists.txt: newly re-introduced SIEMENS_Sonata-12-MONO2-SQ.dcm
10 in gdcmData (previously known as E00001S03I0015.dcm) is blacklisted.
12 2004-07-21 Jean-Pierre Roux
13 * FIX Now, Parsing and Printing a DICOMDIR do work!
14 ( troubles remain in makeDicomDir and BuildUpDicomDir :-(
16 2004-07-20 Jean-Pierre Roux
17 * FIX Some brain damaged headers have Zero-Lenght fields
18 for 'Transfert Syntax UID', or 'Media Stored SOP Class UID'.
20 2004-07-19 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
21 * src/gdcmCommon.h, gdcmDict.cxx, gdcmTS.cxx : bug fix for msvc6 compilation
22 * src/gdcmDebug.[h|cxx] : bug fix for msvc6 compilation. Replace the dbg
23 variable (instance of gdcmDebug) by a definition macro, and the instance
24 is now in static in the gdcmDebug class
25 * src/gdcmSQItem.h : (FIXME) remove an undefined method
26 * Test/PrintAllDocument.cxx : bug fix in the result of the test
28 2004-07-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
29 * WARNING: ctest now depends more tightly on gdcmData. You should
30 check out gdcmData properly for things to run smoothly...
31 * src/gdcmDocument.cxx MAX_SIZE_LOAD_ELEMENT_VALUE is set back to 0xfff
32 (4096) for "ctest -R TestAllEntryVerify" to be able to run (i.e.
33 we need the pixels not be loaded in order to use the ValEntry
34 that displays position and size).
35 * Test/TestAllEntryVerify.cxx a new low level test now seems fair.
36 This is a C++ based equivalent of gdcmPython/testSuite.py that should
37 be deprecated. If you have any doubts about the advantages of a
38 modern scripting language (read Python) versus grass root C++ (i.e.
39 without lex + yacc, because of gdcm commitement to MS-VC++, sighhh),
40 I suggest you compare TestAllEntryVerify.cxx (639 lines, without the
41 reference file gdcmData/TestAllEntryVerifyReference.txt) and testSuite.py.
42 Anyhow, consider documenting the gdcmData images in
43 gdcmData/TestAllEntryVerifyReference.txt (and please run ctest before
45 * Test/CMakeLists.txt:
46 - now uses TestAllEntryVerify.cxx
47 - specific comments on oldACR00001.ima (now renamed in gdcmData
48 to SIEMENS_GBS_III-16-ACR_NEMA_1.acr) moved away to
49 gdcmData/TestAllEntryVerifyReference.txt
52 2004-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
53 * src/*.[h|cxx] : typedef clean up
54 - guint16 and guint32 removed. Use ISO C uint16_t, uint32_t instead.
55 - TagKey renamed to gdcmTagKey (for external usage)
56 - VRKey renamed to gdcmVRKey (for external usage)
57 - removal of typedef duplication.
58 - Removed all unecessary inline keyword from class inline definitions.
59 - Some method|function(void) declarations replaced with method|function().
60 * src/jpeg/libijg12/jdhuff12.c:
61 - printf polluting ctest removed.
62 - TAB removal for comminting
64 - TestAllReadCompareDicom.cxx: added a test that compares all the
65 images in gdcmDataImages.h with corresponding images in
66 gdcmData/BaselineDicom/. When baseline images are not present
67 this test creates them.
68 Note: we need to validate each reference image, but before that
69 I'd like to rename them with a more explicit name...
70 - CMakeLists.txt: changed accordingly.
71 * Example/*.cxx: examples now only include gdcm.h (as opposed to
72 including each header needed).
74 2004-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
75 * Test/*.cxx and Example/*.cxx: moved some examples away from the
76 test suite to the Example directory. Are concerned:
82 * Test/CMakeLists.txt: added some comments on reasons for black listing
83 image gdcmData/oldACR00001.ima
85 2004-06-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
86 * Test/CmakeList.txt: removed the following from black list (to be coherent
87 with removal from gdcmData):
88 - gdcm-MR-PHILIPS-16-Multi-Seq.fixed.dcm
89 - gdcm-MR-PHILIPS-16.dcm
91 Added the following because after last cvs update, they cause
92 ctest -R TestReadWriteReadCompare
94 - gdcm-MR-SIEMENS-16-1.acr
96 * Test/TestReadWriteReadCompare.cxx was properly written (with a call
97 to gdcmFile::SetImageData()) BUT since gdcmFile is brain damaged (see
98 new comments in this file) we temporarily (sigh) move to a weaker
100 * Test/CmakeList.txt: with the change to Test/TestReadWriteReadCompare.cxx
101 we don't need to black list the following images anymore:
102 - 8BitsUncompressedColor.dcm
104 - US-PAL-8-10x-echo.dcm
105 * src/gdcmDocument.[h|cxx]: RE-Reverting to version 1.42 with the proper
106 fixes and the beautified code ;-)
107 This fixes the bug introduced in version 1.42 (when beautifying)
108 that made the parsing of 8BitsRunLengthColor.dcm unproper.
109 Note: ctest was blind to this bug (this means we need to still
110 improve the test suite). The bug could be detected by using
111 gdcmbin/bin/PrintDocument $GDCM_DATA/8BitsRunLengthColor.dcm
113 gdcmbin/bin/ReadWrite $GDCM_DATA/8BitsRunLengthColor.dcm
114 and by displaying the (garbage) produced file temp.XDCM...
116 2004-06-29 Jean-Pierre Roux
117 FIX : - remove Frog's beautified, but never checked 'Parse7FE0' code,
118 - replace by uggly but working old code :-(
119 A lot of things should be OK again.
120 It's really urgent to have a test suite that *tests*,
121 to prevent Frog's beautifying sessions to break all the stuff
122 (twice, withing a fortnigh ...)
124 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
125 * Test/TestWriteRead.cxx and TestReadWrite.cxx merged (because of
126 redundancy) to added Test/TestReadWriteReadCompare.cxx
127 * Test/CmakeList.txt: because the compare test of
128 Test/TestReadWriteReadCompare.cxx fails, the following images are
129 black listed: - 8BitsUncompressedColor.dcm
131 - US-PAL-8-10x-echo.dcm
132 * src/gdcmDocument.cxx: for broken (non DICOM V3 conformal) images
133 (e.g. gdcm-JPEG-LossLess3a.dcm see comments in
134 gdcm/gdcmPython/testSuite.py for details) ::FindDocLengthOB() had
135 and ad-hoc kludge. This kludge is now removed, and on encountering
136 such an image (OB field brain damaged) we set errno. Then in
137 ::FindDocLength() we "fix" the length as being ALL what remains
138 in the file (until EOF). We then proceed, hoping for the best...
139 This fixes a SegFault in ShowDicom when trying to write such an
141 * Test/CmakeList.txt: 8BitsRunLengthColor.dcm is now blacklisted
142 (because TestWriteRead breaks on it, after a non conformal commit?).
143 ctest now runs properly, except for MakeDicomDir (which was allways
144 broken) and the Python related stuff (still not fixed).
146 2004-06-24 Jean-Pierre Roux
147 ADD : Examples/WriteRead, that acts like the former Test/TestWriteRead
148 FIX : Test/TestReadWrite now iterates on all the file names
149 (instead of infinite loop)
150 ENH : Test/TestWriteRead now iterates on all the file names
152 2004-06-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
153 * Test/TestReadWrite.cxx: now uses all the images of gdcmData.
155 2004-06-24 Jean-Pierre Roux
156 FIX : - now Write drops LUT Descriptors and LUTs (if any)
157 when SamplesPerPixel =3
158 - now Write is no longer confused by
159 'BitsAllocated = 12" and 'BitsStored=12"
160 - "UN" value representation Elements are now written correctly
161 (their legth is stored on 4 bytes -just like OB, OW, and SQ-)
162 ENH : - now gdcmHeader has its own Write methods
163 (in order to split the job that has not to be done
166 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
167 * Test/PrintAllDocument.cxx: looping on files is now effective. It used to
168 loop on the same image until memory went out.
169 Note: this means we still have gobs of memory loss in PrintDocument
170 * src/gdcmDocument.cxx: fixes problem on parsing on file
171 gdcmData/16BitsJpegLosslessGrayScale.dcm.
173 2004-06-24 Jean-Pierre Roux
174 FIX : Write - All the Sequences and Sequence Item are now written
175 as 'no length' stuff, and a Sequence Delimitor aor an Item Delimitor
176 is added a the end, when necessary.
177 - A lot of brain-damaged images, that were read correctly are
178 now written correctly
179 - length compatible BinEntry are now loaded correctly
180 (even for odd groups)
181 Note : only Explicit Value Representation was checked.
182 (question : is implicit VR really necessary for gdcm ?)
184 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
185 * DEVELOPPER: added a proposition of coding style.
186 * src/gdcmDocEntry.h: removed every inline declaration (for test of
189 2004-06-23 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
190 * gdcmDocEntry::PrintCommonPart() and ::WriteCommonPart() removed.
191 Use the gdcmDocEntry::Print() and Write() instead.
192 * src/gdcmDocument.cxx: bug fix.
194 2004-06-22 Jean-Pierre Roux
195 FIX : gdcmDocument.cxx
196 - Now we do recognize the JpegLossLess format (there was a misstyping in
197 code 'beautyfication' :-(
198 - Now we automaticaticaly load the Luts, if any
200 2004-06-22 Jean-Pierre Roux
201 In order : to write Sequences, whatever their imbrication level,
202 : to allow user to create his own Sequences
203 a lot of modif where necessary (adding, moving, or virtualising methods)
205 WARNING : save your own sources *before* cvs up !
208 ADD virtual void Write(FILE *fp, FileType filetype);
211 ADD virtual void Write(FILE *fp, FileType filetype);
212 ADD void gdcmDocEntry::WriteCommonPart(FILE *fp, FileType filetype);
215 ADD virtual void Write (FILE *fp, FileType filetype)=0;
216 ADD virtual gdcmDocEntry *GetDocEntryByNumber(guint16 group,guint16 element) = 0;
217 ADD gdcmDocEntry *GetDocEntryByName(std::string name);
218 ADD virtual std::string GetEntryByNumber(guint16 group,guint16 element) = 0;
219 ADD std::string GetEntryByName(TagName name);
220 ADD gdcmDictEntry *NewVirtualDictEntry(guint16 group,
222 std::string vr = "unkn",
223 std::string fourth = "unkn",
224 std::string name = "unkn");
225 ADD gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
226 ADD gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
227 ADD gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
228 ADD gdcmDocEntry *NewDocEntryByName (std::string Name);
229 ADD gdcmDictEntry *GetDictEntryByName (std::string Name);
230 ADD gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
231 REM virtual gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element)=0;
232 REM virtual gdcmDocEntry *NewDocEntryByName (std::string Name)=0;
235 ADD virtual bool WriteF(FileType type); // New stuff, with recursive exploration
236 ADD virtual std::string GetEntryByName (TagName tagName);
237 ADD virtual std::string GetEntryVRByName (TagName tagName);
238 REM virtual bool Write(FILE *, FileType);
239 REM virtual void WriteEntryTagVRLength(gdcmDocEntry *tag,
240 FILE *_fp, FileType type);
241 REM virtual void WriteEntryValue(gdcmDocEntry *tag,FILE *_fp,FileType type);
242 REM virtual bool WriteEntry(gdcmDocEntry *tag,FILE *_fp,FileType type);
243 REM virtual bool WriteEntries(FILE *_fp,FileType type);
244 REM virtual std::string GetEntryByName (std::string tagName);
245 REM virtual std::string GetEntryVRByName (std::string tagName);
246 REM gdcmDictEntry *GetDictEntryByName (std::string Name);
247 REM gdcmDictEntry *GetDictEntryByNumber(guint16, guint16);
248 REM gdcmDictEntry *NewVirtualDictEntry(guint16 group,
250 std::string vr = "unkn",
251 std::string fourth = "unkn",
252 std::string name = "unkn");
253 REM gdcmDocEntry *NewDocEntryByNumber(guint16 group, guint16 element);
254 REM gdcmDocEntry *NewDocEntryByName (std::string Name);
255 REM gdcmValEntry *NewValEntryByNumber(guint16 group, guint16 element);
256 REM gdcmBinEntry *NewBinEntryByNumber(guint16 group, guint16 element);
259 ADD virtual void Write(FILE *fp, FileType filetype);
262 ADD virtual void Write(FILE *fp,FileType filetype);
265 ADD virtual void Write(FILE *fp, FileType filetype);
266 ADD virtual std::string GetEntryByNumber(guint16 group, guint16 element);
267 REM std::string GetEntryByNumber(guint16 group, guint16 element);
268 REM std::string GetEntryByName(TagName name);
271 ADD virtual void gdcmValEntry::Write(FILE *fp, FileType filetype);
273 2004-06-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
274 * Test/TestWriteSimple.cxx: fix to gdcmHeader-gdcmHeaderHelper revamping.
275 The default constructor invoked by the line
276 gdcmHeader *f1 = new gdcmHeader( header );
277 was gdcmHeader::gdcmHeader(bool) instead of the expected
278 gdcmHeader::gdcmHeader(std::string const &, bool = false, bool, bool).
279 Hence the parsing wasn't executed... See also below.
280 * src/gdcmHeader.h: the declaration of gdcmHeader::gdcmHeader(bool)
281 as explicit constructor didn't do the trick to fix the above problem.
282 Could anyone explain why ?
283 * src/gdcmBinEntry.cxx, gdcmValEntry.cxx: gdcmBinEntry::Print() now
284 properly calls gdcmValEntry::Print() (that was weed out from
285 code related to gdcmBinEntry).
287 2004-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
288 * In order to fix memory leaks:
289 - Test/TestWriteSimple.cxx: added cleaning of free store through
291 - src/gdcmBinEntry.cxx: fix to avoid SegFault.
292 - src/gdcmDicomDir.[cxx|h]: fixed initialisation in constructor
293 gdcmDicomDir::gdcmDicomDir(bool) [either the constructor itself
294 (through the call to ::AddDicomDirMeta()) or the destructor
295 would crash when deleting uninitialized ::metaElems].
296 - src/gdcmDictEntry.cxx: annotation of ununderstood memory leak.
297 - src/gdcmDocument.cxx:
298 -- ::~gdcmDocument() destructor now cleans up all dictionary entries
300 -- ::ParseDES() misplaced deletion of temporary NewDocEntry
301 was causing memory leaks.
302 - src/gdcmSQItem.cxx:
303 -- ::~gdcmSQItem() dummy code cleaned (learned that deletion is
304 cleanly handled with polymophism: sorry but my milage is low).
305 -- ::SetEntryByNumber(string, guint16, guint16) now cleanly allocates
306 a gdcmValENtry, and makes no assumption on type (gdcmDocEntry,
307 gdcmSeqEntry vs gdcmValEntry) of existing entry (when present).
308 This avoids SegFaulting.
309 - src/gdcmSQItem.h: coding style.
311 - Test/TestWriteSimple still severely sucks. The output image content
312 (when $(GDCMDATA_HOME)/012345.002.050.dcm in input) is brain
313 damaged when displayed with vtkgdcmViewer.
314 - on memory leaks: TestWriteSimple leaks really less (see entry
315 of 2004-06-18 in Changelog file for the call to valgrind).
316 - on segfaults: ctest now passes all the tests but one (no more
318 * Erroneous leading white fix:
319 - src/gdcmDict.cxx: getline(from,xxx) doesn't remove the leading
320 white[s] (as opposed to from >> xxx, that removes it [them].
321 - src/gdcmTS.cxx: ditto.
322 - gdcmPython/testSuite.py: dirty related kludge removed.
323 * src/*: remaining references to gdcmParser removed.
324 * src/*[cxx|h]: added copy[way]left header.
327 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
328 * In order to fix writing of dicom files:
329 - Test/TestWriteSimple.cxx: a simpler example of writing.
330 - Test/CMakeLists.txt changed accordingly.
331 - src/gdcmDocument.cxx:
332 -- The destructor now recursilvely removes potential sequences.
333 -- Bug fix in ::IsJPEG2000()
334 -- ::ReplaceOrCreateByNumber(std::string, guint16, guint16)
335 now handles promotion of gdcmDocEntry to gdcmValEntry in a cleaner
337 -- ::GetValEntryByNumber(guint16, guint16) now defined (as opposed
338 to only declared) and build on top of
339 ::GetDocEntryByNumber(guint16, guint16).
340 -- ::SetEntryByNumber() now uses GetValEntryByNumber(group, element)
341 - src/gdcmElementSet.[h|cxx]: added ::RemoveEntry(gdcmDocEntry *)
342 for usage in destructor and treatement of promotion in
343 ::ReplaceOrCreateByNumber().
344 - src/gdcmSQItem.cxx: destructor should better handle his job.
345 Test/TestWriteSimple now runs (or at least it DOES something).
346 * We can now start hutting memory links. A good starting point is:
347 valgrind -q --skin=memcheck --leak-check=yes --leak-resolution=high
348 --num-callers=100 --show-reachable=yes gdcmTests TestWriteSimple
349 $(GDCMDATA_HOME)/012345.002.050.dcm foo.dcm
351 2004-06-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
352 * Valgrind note: after Mathieu Malaterre teached me how to read
353 the valgrind FAQ ;-] (see http://valgrind.kde.org/faq.html), I
355 Using gcc, you can force the STL to use malloc and to free memory as
356 soon as possible by globally disabling memory caching.
357 With 3.2.2 and later, you should export the environment variable
358 GLIBCPP_FORCE_NEW before running your program.
359 By setting GLIBCPP_FORCE_NEW, STL related memory leak messages of gdcm
360 simply vanish (it is still not clear to me, whether this means that
361 STL std::string leaks or if valgrind believes it leaks...).
362 * Fixing of SegFault of Test/makeDicomDir (as shown by ctest or by
363 running bin/gdcmTests makeDicomDir):
364 - src/gdcmDicomDir.cxx: dynamic casting used + clean up.
365 - Test/makeDicomDir.cxx now properly traps empty lists and returns
367 NOW, makeDicomDir cleanly fails (in ctest terminology) instead of
368 SegFaulting (I drowned in DicomDir related code when trying to
369 understand why the list is empty...).
370 * src/gdcmDocument.h: first BSD license header try.
371 * Doc/License.txt added.
373 2004-06-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
374 * src/gdcmDocument.[h|cxx]:
375 - Clean up of the Transfer related predicates. They are now all based
376 on new method isGivenTransferSyntax, that (should) handle properly
378 - general clean up, simplification, and coding style.
379 - Specific clean up of Parse7FE0() (umproperly named actually).
380 * gdcmPython/testSuite.py: an odd temporary kludge introduced.
382 2004-06-14 Jean-Pierre Roux
384 - fix the display of Sequence Delimitor (SQDepthLevel pb)
385 - fix the display of SQItem ordinal number
386 - add the GetSQItemByOrdinalNumber method
387 - remove some useless never written private methods
389 2004-06-14 Jean-Pierre Roux
391 - adding a constructor taking a gdcmDocEntry as an input param
392 - ReplaceOrCreateByNumber now returns :
393 a gdcmBinEntry * if a Binary (void *) value is passed as a param
394 a gdcmValEntry * if a string value is passed as a param
396 - SetEntryByNumber now allows setting gdcmValEntry or gdcmBinEntry,
397 according to the param type (no longer sets a gdcmDocEntry)
398 - GetValEntryByNumber, GetBinEntryByNumber added
399 - NewValEntryByNumber and NewBinEntryByNumber added
401 - Pixel Data are now linked to the (7fe0,0010) elements, after reading
403 - GetSQItemNumber and SetSQItemNumber added, to provide
404 a (relative) Item identier inside a given Sequence
405 \warning : some pb remaining around this number
407 - AddEntry now takes the Item Number as a param
409 - adding a constructor taking a gdcmDocEntry as an input param
411 2004-06-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
412 * Memory leak hunt with the following command:
413 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
414 --show-reachable=yes gdcmTests PrintDocument
415 It looks like many (all?) leaks are due to the STL (or a bad usage
416 of the STL. The lines producing the leaks now have a comment with
417 a "MEMORY LEAK" tag: you can retrieve them with
418 grep "MEMORY LEAK" src/*
419 Here are two typical examples which I can't help fixing:
424 char * test = "babo";
425 name = test; //// <--- valgrind detects 960 bytes lost in
426 //// call to std::string::operator=(char const*)
427 name.clear(); //// Doesn't help !
435 std::cout << "Type a bunch of characters followed by RETURN: ";
436 getline(std::cin, line); //// <--- valgrind dectects a loss
437 //// of 1320 bytes in call to
438 /// std::basic_istream<>& std::getline<>
444 2004-06-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
445 * src/gdcmHeader.[cxx|h]:
446 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*)
447 and related, moved away to gdcmDocument.
448 - Accessors (on the form [Get|Set]Entry*) set up to expose publicly
449 the corresponding protected accessors of inherited class
450 gdcmDocument, removed ! As a consequence gdcmFile had to be
451 declared friend of class gdcmDocument (see below).
452 - operator< moved to gdcmDocument (in fact it belongs to gdcmDicomDir).
453 - Clean up of undefined or unused methods.
454 * src/gdcmFile.[cxx|h]: added SetEntryByNumber (in order to take into
455 account the changes to gdcmHeader.h).
456 * src/gdcmDocument.h:
457 - gdcmFile is now a friend class (in order to take into account the
458 changes to gdcmHeader.h).
459 - Predicates on the Transfer syntax (of the form Is[JPEG|RLE]*) added
460 (see changes to gdcmHeader.h).
461 - Accessors (reading on the form GetEntry*) are now public.
462 - Clean up of undefined or unused methods.
463 * src/gdcmDocument.cxx:
464 - adaptation to changes to gdcmDocument.h
465 - ::OpenFile now writes a verbose message when file cannot be opened.
466 - some std::string properly set to VRKey
467 * src/gdcmDicomDir.h: historical references to gdcmHeader changed to
468 references to gdcmDocument.
469 * Test/TestFindTags.cxx: changed accordingly to above changes.
470 * gdcmPython/testSuite.py: adapted to renaming of acr files in
471 cvs repository gdcmData.
473 2004-06-09 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
474 * src/gdcmValEntry.h: member voidArea type changed from char* to void*.
475 * src/gdcmBinEntry.h: member voidArea commented out, since it potentially
476 conflicts with gdcmValEntry::voidArea.
477 * src/gdcmValEntry.cxx: unmatching comment wiped out.
478 * src/gdcmVR.[h|cxx]: added two predicates that partition the possible
479 Value representation between StringRepresentable and BinaryRepresentable.
480 * src/gdcmDocument.cxx:
481 - method ParseDES: proper indentation restored and usage of
482 gdcmVR::IsVROfGdcmStringRepresentable wired in.
483 - method LoadDocEntry: the fingerprint left in the SetValue() of
484 unloaded entries (length > MaxSizeLoadEntry) had curiously been
485 removed. Reverting to previous code segment with the proper
486 dynamic_cast< gdcmValEntry* >.
487 Note: this was (partially) breaking the python test suite
488 (gdcmPython/testSuite.py) that made usage of the above
489 fingerprint to check presence of "Pixel Data".
490 * src/gdcmDocEntry.h: coding style.
491 * gdcmPython/__init__.py: environement variable GDCM_DATA_PATH is
492 now taken into account.
493 * gdcmPython/gdcm.i: adaptation to the new internal representation
494 of gdcm (exit gdcmParser, hello gdcmDocument).
495 * gdcmPython/testSuite.py: quick and dirty fix for loading vtkgdcmPython
497 * gdcmPython/demo/PrintHeader.py: doesn't use the gdcmDocument::Print()
498 anymore, but instead prints the loaded Python dictionary.
499 * .... alas, the python testSuite is still broken.
501 2004-05-18 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
502 * gdcmPython/gdcm.i : remove useless lines concerning the gdcmGlobal
504 * gdcmPython/setup.py : replace the use of cvar.gdcmGlob to gdcmGlobal
505 * src/gdcmUtil.h : export methods
507 2004-05-16 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
508 * Some more cleanup/enhancement in gdcmPython/CMakeLists.txt getting close
510 * Initial addition of automatic python testing
511 * Initial addition of automatic image comparison
513 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
514 * src/gdcmCommon.h, gdcmDicomDir.cxx, gdcmFile.cxx, gdcmHeaderHelper.h,
515 gdcmParser.cxx, gdcmParser.h : bug fix for the Microsoft .Net compilation
517 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
518 * src/gdcmFile.cxx, gdcmHeader.cxx : bug fix for the msvc compilation
519 * Test/ShowDicom.cxx : bug fix for msvc compilation
520 * vtk/vtkgdcmViewer.cxx : bug fix for msvc compilation
522 2004-05-04 Jean-Pierre Roux
523 * ADD Taking into account the 'Dicom Sequences' leads up to introduce
524 new concepts (and new classes) :
525 a 'gdcmDocument' is composed of a set of Doc Entries, that are
526 - elementary gdcmDocEntries (former gdcmHeaderEntries)
527 - Sequence Doc Entries (gdcmSeqEntries)
528 a Sequence is composed of Items.
529 Each item is a set of Doc Entries (this is recursive)
530 The non uniqueness of the 'Dicom tag' is due to this recursivity
531 (never taken into account)
532 Our unability to add a new 'entry' in the header
533 at the proper location (neither in the H-Table (map or multimap),
534 nor in the Chained List is also due to this recursivity.
535 Don't try, right now, to use/modify/compile these new sources :
537 We just commit all the stuff, 'as is', in order not to loose it.
539 2004-05-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
540 * vtk/vtkGdcmReader.cxx : bug fix in the setting of file name
542 2004-05-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
543 * vtk/vtkGdcmReader.cxx : bug fix when loading a list of files using the
544 file prefix (SetFilePrefix)
546 2004-05-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
547 * Add a new test: ShowDicom, for now this is just the c++ version of
548 checkRead.sh, later it will be able to compare the image read against a
550 * Replace the DEBUG on the stack with a global entry in cmake interface:
551 GDCM_DEBUG, so you can turn verbosity ON/OFF for debug statement.
553 2004-04-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
554 * Add an example subdir, with a real example on how to read + write a
557 2004-04-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
558 * Doc/gdcmUML.xmi added raw UML class view (umbrello format)
559 * Doc/CMakeLists.txt: the main page is now properly differentiated
560 between the developper and user version.
561 * Doc/doxygen.config.in: dropped search related obsolete flags
562 * src/gdcmParser.h, gdcmHeader.h: doxygenation
564 2004-04-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
565 * DEVELOPPER: added some helpfull comments for compile/test/install
568 2004-04-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
569 * ENH: 1. Remove remp solution of gdcmTests.cxx+ gdcmMain directly in
570 src directory, now generated in the build dir.
571 2. Tests as mentionned smarter
573 4. Add a new method in gdcmDict that return the PubDict by name
574 this is interesting for 3rd party lib like ITK,
575 where we could set the institution name / patient name...
577 * ENH: 1. Now the test suite is working for real
578 2. All binaries are now output in the gdcm-bin directory
579 (this was not true before)
581 2004-04-28 Jean-Pierre Roux
582 * ENH add the provisional gdcmHeader::SQDepthLevel to allow
583 SeQuence indented printing of Dicom Header.
584 * ENH merge methods gdcmParser::Parse and gdcmParser::LoadHeaderEntries
585 into the single gdcmParser::LoadHeaderEntries for efficiency purpose.
586 Computation of SQDepthLevel is now part of gdcmHeader constructor
587 * ENH add self defined param 'new' to PrintHeader to 'show' the SeQuence
588 tree-like structure of a Dicom Header.
589 * FIX Test code cleaning
591 2004-04-25 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
592 * ENH: Adding automatic testing
593 1. Need a DartConfig.cmake to submit to public
594 2. Add a test driver gdcmTest.cxx
595 3. gdcmTestMain, an helper for the main test driver gdcmTest
596 4. Files in Test don't have a main anymore, this becomes interesting
597 when we add more and more tests, thus dsw don't have to load
599 * ENH: Adding a GDCM_DATA_ROOT for testing
600 * ENH: Remove redundancie about GDCM_DICT stuff, now we only need to modify
601 one file instead of seven + some small cleanup
603 2004-04-22 Jean-Pierre Roux
604 * ENH Minor changes to the Print() methods.
605 * ADD gdcmParser::PrintEntryNiceSQ() to allow SQ-indented
606 Header printing. Example given with :
607 > PrintHeader fileName 2 new
608 (SQ based tree-like structure still to be done for the Header ...)
610 2004-04-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
611 * ENH: Some cosmetic clean up for compilation with -W -Wall -Werror
612 1. I have added some unsigned where needed
613 2. Some function parameter not used -> (void)
614 3. In gdcmDicomDir.cxx, add GDCM_DICOMDIR_NONE case
615 4. g++ don't like character '\' in comment
616 5. #define jpeg_create_decompress jCreaDecompress
617 this really need to be fixed
618 6. virtualize destructor of gdcmObject ... leakage
619 7. sscanf(g->first.c_str(),"%x",&gr_bid);
620 this also really need to be fixed
621 8. gdcm/src/jpeg/libijg8/CMakeLists.txt,
622 remove compression file
623 (as we only do decompression, right ?)
624 * ENH: Change malloc/calloc/free with c++ equivalent
626 2004-04-21 Jean-Pierre Roux
627 * FIX gdcmHeaderHelper::GetXSpacing
628 when a single value is found (bug ?), xpacing is now
629 defaulted to yspacing
631 2004-04-19 Jean-Pierre Roux
632 * ADD gdcmData/Wrist.pap (PAPYRUS 3.0 -single frame-) for checking purpose
633 * ENH add parameters :
634 bool exception_on_error = false,
635 bool enable_sequences = false,
636 bool ignore_shadow = false
637 to the gdcmFile constructors to be full gdcmParser compliant
638 * FIX vtk/vtkGdcmReader.cxx now uses enable_sequences = true in gdcmFile
639 to allow reading of PAPYRUS 3.0 files
641 2004-04-06 Jean-Pierre Roux
642 * ADD gdcmData/E00001S03I0015.dcm for SQ checking purpose
644 2004-04-02 Jean-Pierre Roux
645 * ADD : Test/checksequence.sh, for a general recap on SQ pb
646 * FIX : gdcmParser::WriteEntryTagVRLength emprovement of special treatement
647 for Philips spurious Tag fffe|0000 while rewritting Dicom files
649 2004-03-30 Jean-Pierre Roux
650 * FIX gdcmParser::ReplaceOrCreateByNumber shouldn't seg fault any more
651 for ACR file, written out as DICOM files (hope so...)
653 2004-03-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
654 * src/gdcmParser.[cxx|h] and gdcmHeader.[cxx.h]: gdcmHeader::Write split
655 in WriteEntryTagVRLength and WriteEntryValue. Those methods were
656 moved to base class gdcmParser and only the specialisation is kept
658 * src/gdcmParser.[cxx|h]: ReplaceOrCreateByNumber(char*, guint16, guint16)
659 trashed out (because ReplaceOrCreateByNumber(string, guint16, guint16)
660 already does the job.
661 * src/gdcmDicomDir.[cxx|h]: WriteDicomDirEntries renamed to WriteEntries
662 (to be consistent with gdcmParser::WriteEntries).
664 2004-03-30 Benoit Regrain
665 * vtk/vtkGdcmReader.[h|cxx] : fix the read of 3 gdcmHeader when making an
666 upate of the object's instance. It's passed to 2 in the unfavorable
667 case : one in the ExecuteInformation, one in the ExecuteData
669 2004-03-29 Jean-Pierre Roux
670 * ENH : Check on file type to be written moved
671 from gdcmParser::WriteEntry to gdcmParser::WriteEntries
672 * FIX : gdcmObject::ResetBoundaries now stops properly
673 when end-of-list is reached
674 : gdcmVersion modified (as Benoit Regrain asked)
676 2004-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
677 * src/gdcmParser.cxx: removal of all TAB character. Indentation fixed.
678 * src/gdcmUtil.cxx: added forgotten iostream include.
679 * src/gdcmCommon.h: FileType enum entry DICOMDIR removed (since
680 equivalent to ExplicitVR in existing code).
682 2004-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
683 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmGlobal.[cxx|h]
684 now contains all the gdcmGlobal related code.
685 * minor coding style and doxygenation changes.
687 2004-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
688 * src/gdcmUtil.[cxx|h] split in two. Additional file gdcmDebug.[cxx|h]
689 now contains all the Debug related code.
690 * minor clean-up of includes in src/*.cxx
691 * src/gdcmUtil.[cxx|h] _cleanString C style function (replaced with
692 CreateCleanString) removed.
693 * src/gdcmUtil.[cxx|h] _CreateCleanString renamed to CreateCleanString
694 * Doc/DoxyMainPageUser.txt added.
695 * Doc/Doc/DoxyfileUsers updated to version 1.3.4 of Doxygen.
696 * src/gdcmCommon.h now defines getcwd for Win32 (moved away from
699 2004-03-24 Jean-Pierre Roux
700 * FIX a lot of little surface modifications to be doxygen 1.3.6 compliant
702 2004-03-23 Jean-Pierre Roux
703 * FIX Now gdcmFile::SwapZone doesn't seg faults any longer for
704 big endian made volumes
705 * ENH Now gdcmParser constructor and destructor are protected to forbid
706 end user to instanciate class gdcmParser
707 (only gdcmHeader and gdcmDicomDir are meaningfull)
709 2004-03-22 Benoit Regrain
710 * FIX : src/gdcmDicomDir.cxx : make windows compilable
711 * FIX : gdcmPython/gdcm.i : change gdcmStudy to gdcmDicomDirStudy and
712 gdcmSerie to gdcmDicomDirSerie
714 2004-03-19 Jean-Pierre Roux
715 * ENH Now the tree-like structure describing a DICOMDIR comming from
716 an already existing DICOMDIR file is consistent with
717 the home-made tree-like structure build ex-nihilo
718 or build from the files held (recursively) in a Directory
719 functions gdcmDicomDir::CheckBoundaries()
720 gdcmObject::SetBoundaries() added
722 2004-03-17 Jean-Pierre Roux
723 * REM (Eric Boix bug) : removal of meaningless
724 gdcmDicomDirImage::NewImage function.
725 * FIX now file names and directory name are written properly in the
727 * FIX now gdcmDicomDir constructor may be call without any trick
730 2004-03-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
731 * FIX (JPR bug) : src/gdcmDicomDirImage.cxx added missing definition
732 of gdcmDicomDirImage::NewImage as empty function.
734 2004-02-28 Jean-Pierre Roux
735 * ENH add gdcmDicomDir:NewPatient
736 add gdcmDicomDirPatient:NewStudy
737 add gdcmDicomDirStudy:NewSerie
738 add gdcmDicomDirSerie:NewImage
739 to allow making gdcDicomDir object.
740 * ADD PrintDicomDir executable that uses gdcmDicomDir tree-like structure
741 (as opposite to the gdcmHeader chained list)
743 2004-02-11 Benoit Regrain
744 * FIX : memory leaks and the set of ArgDelete methods in gdcmDicomDir
745 when using from python
747 2004-02-10 Benoit Regrain
748 * FIX : bug fix in the gdcmDirList for the recursivity in directories
749 * FIX : in gdcmDicomDir when the directory is empty
750 * ENH : add callback and methods to get the progression of dicomDir
753 2004-02-06 Jean-Pierre Roux
754 * ENH : - now gdcmDicomDir::CreateDicomDir() returns also the meta elements
755 - GDCM_META added to gdcmDicomDirType
756 - class gdcmMeta created
757 * ENH : - A brief summary is now displayed at the beginning of
758 'testDicomDir' to help disaster magnitude estimation
759 * REM : Now useless Test/explDICOMDIR.cxx
761 2004-02-05 Benoit Regrain
762 * ENH : add methods in gdcmObject to get the hash table or the list of
764 * FIX : wrapping python for ListPatient, ListStudy, ListSerie, ListImage
765 * FIX : wrapping python for TagHeaderEntryHT
767 2004-02-04 Benoit Regrain
768 * FIX : even length for some strings when writting the dicom dir
769 * FIX : sort the images in the dicom dir
770 * FIX : Bug fix for python use of dicom dir
771 * ADD : a python demo
773 2004-02-04 Jean-Pierre Roux
774 * FIX : Final solution (?) for icone embedded images
775 * FIX : dicomVR.dic Overlay group is not *only* 6000, but 60xxx
776 (see http://medical.nema.org/dicom/2003/03_06PU.PDF)
777 add groups 6002, 6004, 6006, to allow 'clean' parsing of
778 gdcmData/gdcm-MR-SIEMENS-16.acr1
779 * ENH add gdcmData/checkWriteExplicit.sh gdcmData/checkWriteImplicit.sh
780 to make full checking easier
782 2004-02-04 Benoit Regrain
783 * FIX : WriteEntries : coding style & logic in parameters
784 * FIX : Set the elements to create the DicomDir in a dictionary file
786 2004-02-03 Benoit Regrain
787 * gdcmDirList : to parse a hard drive directory in recursive (or not)
788 * gdcmDicomDir : add the load of directory
789 * Bug fix and print add-on
791 2004-02-03 Jean-Pierre Roux
792 * ENH gdcmParser : allows "DICM" files, with NO group '0002'
793 * FIX handling 'non string elements' unsecure area (LUT, overlays, etc)
794 * FIX Dicts/dicomV3.dic : Add a few missing 'group length' Elements
795 * FIX gdcmParser.cxx : 'group length' elements are now considered
796 as integers, even for shadow groups, when file is Implicit VR
798 2004-02-02 Jean-Pierre Roux
799 * FIX : gdcmWrite : equal_range() for multimap doesn't return a 'second'
801 of the last synonym :-(
802 * FIX : gdcmWrite::WriteBase : method stops if Pixels not yet Read (except
804 * ENH gdcmData/checkWrite.sh :modif for full check of Explicit VR writting
805 * FIX taking into account the possible 7fe0,0010 multiplicity
806 * FIX add GRPixel,NumPixel,countGrPixel (gdcmParser protected members)
807 to allow removal of references to 7fe0,0010, to deal with
808 ACR-NEMA images, when 0028,0200 is meaningfull
810 2004-01-31 Jean-Pierre Roux
811 * FIX gdcmParser::WriteEntries : when a VR is tagged as 'Unknown'
812 no longer writes 'Un' on disk
813 * FIX SQ elements with actual length are now dealt with corectly
814 * FIX gdcmFile::WriteBase make the difference, for color images, between
815 the length (for Palette expanded images)
816 and Raw Length (non expanded image + Palette)
817 * FIX Dicts/dicomV3.dic : removal of 'CTX' (context dependant) VR
818 (that broke Write). Replaced by UL.
819 Aware user will reload the field if he
820 thinks it's necesssary
822 2004-01-30 Jean-Pierre Roux
823 * gdcmParser::CheckSwap() now defaults the filetype to ACR
824 when 'dirty Acr' is found, to be compliant with the new
825 IsReadable() methods.
827 * gdcmHeaderHelper :add Pixel Type 'FD', for dealing with 'double' images.
828 (no DOUBLE images in kosher DICOM,
829 but so usefull for people that miss them ;-)
831 * add Test/testDicomDir.cxx, Test/makeDicomDir.cxx , Test/explDICOMDIR.cxx
832 DICOMDIR related utilities (not checked as Windoze compliant)
834 2004-01-28 Jean-Pierre Roux
835 * upgrade GdcmHeaderEntry Print Method for DICOMDIR
837 2004-01-27 Jean-Pierre Roux
838 * gdcmParser constructor has a new boolean param,'ignore_shadow',
839 to allow skipping the shadow elements, to save memory space.
840 The TRUE value for this param has to be used
841 with a FALSE value for the 'enable_sequence' param.
842 ('public elements' may be embedded in 'shadow Sequences')
843 * gdcmHeader methods now deal with 'embedded icones images' in the header
844 (even when an 'icone image sequence' is announced by the
845 element (0x0088,0x0200), but there is NO icone at all ...
847 * gdcmHeader sometimes Image Location value doesn't follow
848 the supposed processor endianity (see gdcmData/cr172241.dcm).
851 * gdcmHeader add the method
852 IterHT GetHeaderEntrySameNumber(grPixel,numPixel);
853 to get *all* the Header Entries with the same tag.
854 GetHeaderEntrySameName is probabely *useless*
855 (no meaning : Name is *not* an identifier within the Dictionnary)
857 2004-01-26 Benoit Regrain
858 * Bug fix in the print of hexadecimal representations. Remove long fields
859 in the print and add a third level of print to print them
861 2004-01-23 Benoit Regrain
862 * Bug fix on field having a VR = 'UI'. Assume that is a string field
863 * Bug fix on test suite after remove the strip made on not string fields
864 * Split the IsReadable method between gdcmParser which test that the file
865 is dicom and gdcmHeader which test that it's an image file
867 2004-01-22 Benoit Regrain
868 * DicomDir : clean code, add methods, set variables in protected or private
869 * gdcmUtil : bug fix for the clean string method
871 2004-01-19 Benoit Regrain
872 * Add the use of shadow dictionaries
873 * bug fix and coding style
875 2004-01-19 Benoit Regrain
876 * src/gdcmFile.cxx : bug fix concerning the close of file
877 * src/gdcmParser.[h|cxx] : remove obvious Pub informations
878 * Add the update of header entries using the shadow library
880 2004-01-19 Benoit Regrain
881 * removal of file gdcmHeader2.cxx
882 * split class gdcmHeader into gdcmParser and gdcmHeader, with gdcmHeader
883 inheriting from gdcmParser. This split is to prepare the integration
885 * bug fix under python
887 2004-01-16 Jean-Pierre Roux
888 * REM removal of class gdcmHeaderEntrySet
889 * REM removal of files gdcmHeaderEntrySet.cxx, gdcmHeaderEntrySet.h
890 * ADD add file gdcmHeader2.cxx
891 * ADD add method gdcmHeader::SetPrintLevel (for PrintHeader)
893 2004-01-15 Benoit Regrain
894 * src/gdcmDicSet.[h|cxx] : add virtual entries to have a reference of
895 entries created while parsing the header. Thus, they will be destroyed
896 when the gdcmDictSet will be destroyed
897 * src/gdcmHeader.cxx, gdcmHeaderEntrySet.cxx : uses virtual entries of
900 2004-01-15 Benoit Regrain
901 * vtk/vtkGdcmReader.cxx : bug fix : before, with python only, the program
902 made a fatal error because of the memory release at the end of program.
903 The problem was in vtkGdcmReader::ExecuteData where we were allocate
904 some memory and vtk seems to have some problems with that.
905 * src/gdcmHeaderEntrySet.cxx : bug fix for std lib and cout
907 2004-01-14 Benoit Regrain
908 * src/gdcmHeaderEntry.[h|cxx] : gdcmElValue -> gdcmHeaderEntry
909 * src/gdcmHeaderEntrySet.[h|cxx] : gdcmElValSet -> gdcmHeaderEntrySet
910 * src/*.[h|cxx] : make changes due to class name changes
911 * gdcmPython/demo/*.py : bug fix due to method names
913 2004-01-13 Benoit Regrain
914 * src/*.[h|cxx] : coding style
915 * vtk/*.[h|cxx] : coding style
917 2004-01-13 Benoit Regrain
918 * gdcmPython/testSuite.py : test the readable flag of file for tests
919 * src/gdcmDict.cxx, gdcmElValSet.cxx : bug fix under windows for prints.
920 It's lied to the stl compilation by MSVC (windows, always windows...)
921 * src/gdcmIdo.h, gdcmHeaderIdo.cxx : remove the Ido unused files
923 2004-01-12 Benoit Regrain
924 * src/*.h : add comments
925 * src/gdcmDictSet.h : set the method BuildDictPath in public
926 * src/gdcmTS.cxx, gdcmVR.cxx : use now a dictionnary file other than to be
927 directly setted in the source code
928 * Dicts/dicomTS.dic, dicomVR.dic : 2 new dictionnary files loaded by
931 2004-01-09 Benoit Regrain
932 * gdcmPython/gdcmVersion.py : add a gdcmVERSION variable information
933 * setup.py : use a reference to gdcmVERSION
935 2004-01-07 Benoit Regrain
936 * Modification to compile with the distutils.
939 2003-12-10 Benoit Regrain
940 * gdcmHeader is now aggregating gdcmFile, and not derived into. Thus, we
941 can use a gdcmHeaderHelper to load datas
942 * gdcmPython/testSuite.py : make the testSuite compliant with modifications
943 made in the source code
945 2003-12-10 Benoit Regrain
946 * Update Windows projects and .cvsignore files
948 2003-11-12 Jean-Pierre Roux
949 * ENH gdcmHeader constructor has one more parameter (default value : false)
950 that allows the user to 'go inside' the SeQuences only
952 gdcmElValSet:Print takes it into account
954 2003-11-12 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
955 * ENH: Update gdcmPython/CMakeLists
956 * FIX: (gdcmHeaderHelper) GetRescale and GetSlope
957 * FIX: (gdcmElValSet) char 'tag' was overiding private members (VC++)
959 2003-11-10 Jean-Pierre Roux
960 * FIX : gdcmHeader::LoadElements is now based
961 on the ListTag listElem member,
962 not longer on the TagElValueHT tagHt member
963 * ENH : PrintPubElVal shows (temporarily) both results,
964 with the tagHt member and the listElem member.
965 (it's easier to 'see' the problems when using Printheader)
967 * FIX : old private member LgrElem is now splitted into
968 ReadLength : Length actually found on disk (updated only
969 if bug fixing is necessary), for internal
971 UsableLength : Updated by FixFoundLength, to fix a bug
972 or to allow Parser going on.
973 Will allow to re-write a kosher header when a SeQuence
974 with a length (not 0000) is found
975 Warning : gdcmFile::Write still uses the TagHt (not ListElem)
976 because gdcmElValSet::Add does not update ListElem
979 2003-11-07 Jean-Pierre Roux
980 * FIX misstyping in Transfert Syntax name table
981 * ENH gdcmHeader::FixFoundLength now allow to 'go inside' tge SeQuences
982 when they have an actual length (not 0000 nor FFFFF)
983 (Nobody should care of it, but DICOMDIR explorers)
985 2003-11-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
986 * ENH: vtkgdcmViewer now works with LUT dicom (OT-PAL-face ...)
988 2003-11-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
989 * ENH: vtkGdcmReader now supports LUT !
990 (vtkgdcmViewer for now is not able to use them though)
992 2003-11-05 Jean-Pierre Roux
993 * in testSuite.py : new files names for checking the package
994 * FIX : Forgot to commit gdcmFile::GetImageDataSizeRaw();
995 that returns the pixel area size to the *aware* (vtk) user
996 that DOESN'T want to turn the PALETTE COLOR image into an RGB image
998 2003-11-05 Benoit Regrain
999 * in testSuite.py : Modify the rules for checking the paths
1000 : Explicit error messages
1001 * in __init__.py : Related modif
1003 2003-11-03 Jean-Pierre Roux
1004 * add gdcmHeaderHelper::GetNumberOfScalarComponentsRaw()
1005 to be used by aware (vtk) users that want to manage
1006 LUT (and no to turn the PALETTE image into an RGB pixels one)
1007 * GetPixelType now returns 8U for 24 Bits images
1008 (vtkGdcmReader compliant)
1010 2003-10-31 Jean-Pierre Roux
1011 * Removal of *all* gdcmData images and add them again
1012 in order to loose the 'history' of un-anonymised images
1014 2003-10-31 Jean-Pierre Roux
1015 * RMV : removal of useless jBitsInJsample.h
1016 for both 8 and 12 Bits JPEG Lossy Libraries
1018 2003-10-31 Jean-Pierre Roux
1019 * ENH : Add the functions gdcmFile::GetImageDataRaw
1020 gdcmFile::GetImageDataIntoVectorRaw
1021 that act as GetImageData and GetImageDataIntoVector
1022 except the making of an RGB Plane from Gray Plane + LUT
1023 Intended to aware (vtk) users who know how to manage
1026 GetLUTRGBA return a R,G,B,A LUT if any
1027 lgrTotaleRaw gives the 'Raw' length
1028 GetImageDataRaw returns the gray Plane
1029 * FIX : no more dirty trick for 'Segmented xxx Palette Color Lookup' images
1030 (They stay Grey, just like with other Dicom viewers :-(
1032 2003-10-30 Jean-Pierre Roux
1033 * FIX : a VC++ intended syntax modif broke the 12/12 Bytes expanding
1035 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1036 * ENH: Can be used like this '$vtkgdcmViewer *.dcm' with *.dcm
1037 being coherents dicom files.
1039 2003-10-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1040 * FIX: DOH ! Forgot about windo$e users, they couldn't read lossless jpeg,
1042 * ENH: Turn it into DOS file type to match libgdcmijpeg8.dsp file type
1043 * ENH: Two steps is necessary to please VC++ compiler...
1044 * FIX: DOH ! libgdcmijpg8 -> libgdcmljpeg
1045 * ENH: Add include dir to medcon lib
1046 * FIX: only one function is being exported for now !
1047 You should use GLOBAL(return type) see ljpg/jpeg.h for more info
1049 2003-10-29 Jean-Pierre Roux
1050 * adding gdcmHeader::GetLUTRGBA
1051 returns a 4 * 256 Bytes Reg/Green/Blue/Alpha vtk compliant LUT
1052 --> Mathieu, the modif u're waiting for is not yet committed
1053 * removal of now useless GetLUTRed,GetLUTGreen,GetLUTBlue,GetLUTRGB
1055 2003-10-27 Jean-Pierre Roux
1056 * adding some xmedcon breaker files (courtesy of Loïc Boussel)
1057 00191113.dcm DermaColorLossLess.dcm
1058 MxTwinLossLess.dcm RadBWLossLess.dcm
1059 * ENH: For version prior to vtkImageViewer2 -r 1.19
1060 * FIX: avoid pb with xmedcon-breaker CT McTwin Elscint images
1062 2003-10-27 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1063 * Removal of ido stuff in CMakeLists.txt
1065 2003-10-24 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1066 * ENH: vtkGdcmReader.cxx can now read multiframe dicom
1067 * FIX: remove a call to ->Modified ... see comments
1068 * FIX: vtkgdcmViewer.cxx was writting ASCII file...this is so slooooow !
1070 2003-10-23 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1071 * FIX: Problem with path for libvtkgdcmPython
1072 * ENH: Try adding a search script for python site-package
1073 * RMV: Remove some file from medcon lib that are not necessary
1074 * FIX: gdcm/Makefile.am fix for generating ljpg medcon
1075 * ENH: CMakeLists.txt now generate 'pygdcm.so' instead of 'libpygdcm.so'
1076 * FIX: More pragma disable fro VC++,
1077 I don't think I break something as it is also disable in VTK/ITK.
1078 But it fasten debug compilation time.
1080 2003-10-23 Jean-Pierre Roux
1081 * gdcm now deals with 16 Bits Run Length Encoded images
1082 (they are compressed as 2 planes images,
1083 one for the high Bytes, the other for low Bytes)
1085 2003-10-22 Jean-Pierre Roux
1086 * Now CheckRead takes into account :
1087 - the bugged 'Leonardo' Siemens images
1088 - the XA images, sent thru the burning VPRO station
1089 * add I9000001.dcm, a GE dlx XA image, thru the VEPRO burning station
1092 2003-10-22 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1093 * FIX: When copying a Makefile.am to CMakeLists.txt
1094 one should remove the '\'
1096 2003-10-22 Jean-Pierre Roux
1097 * in gdcmData adding a bugged 'Leonardo' Siemens image
1098 (wrong lengths in header)
1099 OK with gdcm, KO with the other viewers :-)
1100 * add a GE dlx XA image, thru the VEPRO burning station
1103 2003-10-21 Jean-Pierre Roux
1104 * in gdcmData add the checkvtkgdcmViewer.sh shell script
1105 for a brutal checking of vtkgdcmViewer compliance
1107 2003-10-21 Jean-Pierre Roux
1108 * add the files for 'xmedcon' Jpeg Lossless library
1109 * call of 'xmedcom' Jpeg Lossles libray (instead of the old LibIDO one)
1111 2003-10-21 Jean-Pierre Roux
1112 * 'Compacted Files' (12 Bits Allocate, 12 Bits Stored) are now dealt with
1114 2003-10-21 Jean-Pierre Roux
1115 * garbage Siemens 'Leonardo' images dealt with
1116 (the patch is easy to remove)
1117 * cosmetic changes to avoid warnings
1119 2003-10-20 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1120 * ENH: vtkgdcmViewer now autoscale color/window level on start-up,
1121 no need to press 'r' now.
1123 2003-10-20 Jean-Pierre Roux
1124 * upgrade of checkRead.sh checkWrite.sh according
1125 to new Jpeg Lossless decompressor
1126 * add US.3405.1.dcm, a genuine RGB medical file ...
1127 * add gdcm-ACR-LibIDO.acr, unnormalized Rectangular LibIDO format image
1128 * add CLIP0001-Sequoia-U11.dcm, US 'Clip', from SEQUOIA machine,
1130 2003-10-15 Jean-Pierre Roux
1131 * general anonymisation in gdcmData
1132 * adding the 'color files' from
1133 http://www.leadtools.com/SDK/Medical/DICOM/ltdc19.htm
1134 * adding some well knowed bugged-header images
1135 * adding checkRead.sk, checkReadColor.sh, checkWrite.sh,
1136 waiting for their inclusion in Python testsuite
1138 2003-10-15 Jean-Pierre Roux
1139 * gdcmHeader::gdcmHeader(const char *InFilename, bool exception_on_error)
1140 no longer seg faults when file is not found
1142 2003-10-14 Jean-Pierre Roux
1143 * Emprovement of reading for Dicom encapsulated Jpeg LossLess
1146 2003-10-14 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1147 * TODO: *.in file to genereate a UseGDCM later
1149 2003-10-14 Jean-Pierre Roux
1150 * Some supposed-to-be Dicom Images have no preamble.
1151 OpenFile takes it into account
1152 * Jpeg LossLess 24 Bits images doesn't break any longer gdcm
1153 * Missing elements added in dicomV3.dic
1154 (just to be affraid : have a look at
1155 ftp://medical.nema.org/medical/dicom/2003/01v03dif/01v03_06.pdf
1156 and do it again next year ;->
1158 2003-10-13 Jean-Pierre Roux
1159 * According to PS 3.3-2003 C.11.1.1.2 p 619, when each pixel of
1160 a PALETTE COLOR is stored on 2 Bytes, theese 2 Bytes must be equal.
1161 But there are NOT. It's fixed !
1163 2003-10-13 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1164 * FIX: "jpeglib.h" was not found on VC++
1165 * FIX: vtkgdcm was not being installed
1167 2003-10-10 Jean-Pierre Roux
1168 * ENH : OpenFile closes the file if it *really* doesn't look like
1169 an ACR-NEMA / DICOM one.
1170 * FIX : testWrite no longer writes an empty file if the source file
1171 is not gdcm Readable
1172 * ENH : One more JPEG LossLess type "JPEG Baseline (Process 14)"
1175 2003-10-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1176 * FIX: CMake generate now documentation
1177 * ENH: out of source doc build !
1178 * ENH: Generate both user and dev documentation
1179 * ENH: Should work on windows too
1180 * ENH: Only one doxygen config.in file is needed
1181 * FIX: make install should be ok now on ùnix plateform
1182 * FIX: PATH to dictionary was wrong (missing /)
1183 * ENH: OpenFile, return true if the file looks like an ACR or DICOM file
1185 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1186 * vtkGdcmReader is now able to read rgb dicom file.
1187 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1188 * added a gdcmViewer to vtk test, use mouse to control
1189 window level & window width
1191 2003-10-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1192 * CMake-ification of gdcm, we have now two build system
1193 * FIX: on cygwin Wsock32 doesn't exist
1194 * FIX: force jpeg dir to the local one (gdcm/src/jpeg)
1196 2003-10-06 Emanuel Ollart
1197 * FIX : compilation process wad broken.
1198 Changed gdcmViewer_sources to vtkgdcmViewer_sources
1200 2003-10-06 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1201 * change gdcmViewer -> vtkgdcmViewer
1202 * change GetXSpacing and GetYSpacing "%f\\%" is parsed backward
1204 2003-10-06 Jean-Pierre Roux
1205 * FIX :A few nasty patches to allow the reading of a lot of nasty images
1206 ( e.g : well known GE images with a wrong elem length,
1207 : Philips MRI Images with a wrong Huffman table)
1208 * still to be done : allow the reading of bugged LEONARDO Siemens images
1210 2003-10-03 Jean-Pierre Roux
1211 * Odd length strings are padded with '\0' (not with spaces,
1212 to remain compliant with already defined strings,
1213 like Transfert Syntax UID and others)
1215 2003-10-03 Jean-Pierre Roux
1216 * ENH :gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1217 to allow displaying RGB images (not only by affim ;-)
1219 2003-10-03 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1220 * vtkGdcmReader is now able to read rgb dicom file.
1221 * src/gdcmHeaderHelper : GetNumberOfScalarComponents()
1223 2003-10-03 Jean-Pierre Roux
1224 * A few nasty patches to allow the reading of a lot of nasty images
1225 ( e.g : well known GE images with a wrong elem length,
1226 : Philips MRI Images with a wrong Huffman table)
1227 * still to be done : allow the reading of bugged LEONARDO Siemens images
1229 2003-10-03 Jean-Pierre Roux
1230 * One more JPEG LossLess type "JPEG Baseline (Process 14)" is now decoded.
1232 2003-10-03 Jean-Pierre Roux
1233 * gdcmHeaderHelper::GetNumberOfScalarComponents() added,
1234 to allow displaying RGB images (not only by affim ;-)
1236 2003-10-03 Jean-Pierre Roux
1237 * gdcmFile::GetImageDataIntoVector now
1238 - deals with MultiFrames MultiFragments Run Length Encoded files
1239 - deals with YcBcR (YBR_FULL) files
1240 - deals with YBR_YBR_FULL_422 files (they work as RBG files ?!?)
1241 WARNING : nothing was checked for YBR_PARTIAL_422, YBR_ICT,
1243 (no sample found :-(
1245 2003-10-02 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1246 * src/*.cxx removed pragma thingies to src/gdcmCommon.h
1247 Two reasons: - clear things
1248 - third parties acces gdcm through header files, so won't
1249 suffer anymore VC++ complains
1251 2003-09-30 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1252 * add argv[1] in testvtkGdcmReader.cxx
1255 2003-09-24 Jean-Pierre Roux
1256 * The lines are now eigthy characters long.for
1257 gdcmHeader.cxx gdcmHeaderHelper.cxx gdcmParse.cxx
1259 2003-09-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1260 * src/gdcmUtil.[cxx|h] : change the _CreateCleanString return value from
1261 char* to std::string. Thus, the use of strdup becomes useless. (see
1262 previous commis of Malaterre)
1263 * src/gdcmElValSet.cxx : reuse commented call to _CreateCleanString like
1264 before the last Malaterre's commit.
1266 2003-09-19 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1267 * This commit should fix the Debug building under VC++, the problem
1268 was mainly a mixture of debug and release lib being loaded at startup.
1269 * I also remove a depency to a specific C function: strdup. Because I had
1270 to force the link to msvcrtd (whereas strdup is in libc).
1272 2003-09-16 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1273 * "gdcm::Unfound" string changed to a constant variable (GDCM_UNFOUND)
1274 located in the gdcmCommon.h file. All use of reference of tha has been
1275 changed to now use the variable GDCM_UNFOUND.
1277 2003-09-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1279 - gdcmPython/testSuite.py adapted to the JPR updated Dicts/dicomV3.dic
1280 Dicom dictionary. The test suite can now be run again. Note:
1281 I'm note very happy with the " (RET)" changes. I believe this
1282 RETAINED comment should be dropped when parsing the dictionary.
1283 - PACKAGER corrected
1285 - AUTHORS updated and now in alphabetical order
1286 * Makefile.am now exports gdcm.dsw for Windoze users.
1288 2003-09-11 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1289 * cygwin complains about missing std:: in subdir Test/
1291 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1292 * remove some methods that are now in gdcmHeaderHelper
1294 2003-09-10 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1295 * vtkGdcmReader set spacing and origin correctly
1297 2003-09-09 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1298 * Fix a few delete/delete[] mismatch
1300 2003-09-08 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1301 * src/gdcmHeaderHelper.[h cxx]: added new class that provide an
1302 interpretation to data given by gdcmHeader. For instance there are
1303 heuristics to get informations (look at different places).
1304 * it also include a specific class: gdcmSerieHeaderHelper devoted to
1305 sorting DICOM images based on different strategies.
1306 * modified Makefiles accordingly.
1308 2003-09-05 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1309 * src/*.cxx : added pragma disable 4786/4251 to get rid of ~4300 warning
1310 when building in debug mode
1311 * vtk/win32/vtkgdcm.dsp : change /MT -> /MD and /MTd -> /MDd to match
1312 src/win32/gdcmdll.dsp
1313 * vtk/win32/vtkgdcm.dsp : added /nodefaultlib "mscvrt" for debug mode
1315 2003-08-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1316 * Corrected a leak in vtkGdcmREader.cxx, the pSource was find thanks
1319 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1320 * src/win32/libgdcmjpeg12.dsp was not dos format
1321 * src/win32/libgdcmjpeg12.dsp :
1322 libgdcmijpeg12_EXPORTS -> LIBGDCMIJPEG12_EXPORTS
1323 * src/win32/gdcmdll.dsp: + /I "..\jpeg\libijg12"
1325 2003-07-29 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1326 * src/gdcmHeader.h : add std:: prefix for stl elements... like others in
1328 * src/gdcmFile.cxx : bug fix in affectation type
1329 * src/jpeg/libijpeg12/jmorecfg12.h : export for windows modified... like
1330 in src/jpeg/libijpeg8/jmorecfg8.h (JPR : copy/paste exists !!!)
1331 * Modifs of MVSC projects to compile them. Not concerning 2 identic
1332 symbols... future problem ?
1334 2003-07-29 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1335 * src/win32/libgdcmijpeg12.dsp was missing
1336 * modified gdcm.dsw accordingly
1338 2003-07-28 Mathieu Malaterre <Mathieu.Malaterre@creatis.insa-lyon.fr>
1339 * src/gdcmHeader.cxx : misplaced return 0.; for ACR/NEMA
1341 2003-07-24 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1342 * src/jpeg/libijg12/.cvsignore, jconfig.* : ommited files while last
1343 commit of JPR (before his hollidays to facilitate our work).
1344 * setup.py : bug fix in code. Modifications made while the last commit
1345 of JPR. The code hasn't been tested before the commit... it's so
1346 useless to make that (for best programmer that is JPR) !!!
1348 2003-07-08 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1349 * tagged the current version as Version0_3 (i.e. version 0.3)
1351 2003-07-08 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1352 * vtk/testvtkGdcmReader.cxx : remove a symbol that is unused
1353 * src/jpeg/libijg8/jmorecfg.h : adding export symbol for windows
1354 * *.dsp : modifications to use new libgdcmijpeg8 library
1355 * setup.py : bug fix on VTKPATH variable
1356 * PACKAGER : adding all concerning windows
1358 2003-07-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1359 * src/gdcmElValSet.cxx, gdcmFile.cxx: JPR bug fix, removal of
1361 * TODO, vtk/vtkGdcmReader.cxx: upcoming fixes comments.
1362 * gdcmPython/testSuite.py: JPR bug fix, brutal erasement of
1363 test suite reported error.
1364 * PACKAGER file added (describes what a packager must do when
1365 packaging a new release).
1366 * MANIFEST.in, now declares jconfig.linux and jconfig.vc
1367 * configure.in: upgraded version number to 0.3.0
1368 * fixing build of rpm (through rpm -ta):
1369 - Doc/Makefile.am exports proper doxygen files
1370 - src/jpeg/libijg8/Makefile.am exports the include files.
1372 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1373 * vtk/vtkGdcmReader.cxx : bug fix when loading only 1 file.
1374 * src/gdcmHeader.h : formatting code
1376 2003-07-07 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1377 * vtk/vtkGdcmReader.[cxx|h] : bug fix when loading only one file.
1378 We were obtaining error message from vtk. Now, creation of file list
1379 is made in an internal list to prevent this problem.
1380 Bug fix when output is empty.
1381 Bug fix in update of progress value. Previous commit for this was a bad
1383 * vtk/vtkGdcmReader.h : adding comments for InternalFileNaleList variable
1385 2003-07-04 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1386 * src/gdcmHeader.h : added method to get the file name
1387 * vtk/vtkGdcmReader.[cxx|h] : bug fix concerning loading of bad dicom
1388 files. Added method to remove all files on the input
1389 Added FIXME comment concerning the bad parsing of header made by
1390 ExecuteInformation method (in ExecuteData method)
1392 2003-07-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1393 * vtk/Makefile.am: vtkGdcmReader.h should now be cleany installed
1394 when using make instal.
1395 * src/gdcmFile.cxx : bug fix under Window after JPR commit
1396 RQ : the JPR doesn't appear in the ChangeLog... normal for him
1398 2003-07-03 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1399 * setup.py : adding include dir of jpeg lib to compile all sources
1400 * */Win32/*.dsp : JPR fix for windows compilation
1402 2003-07-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1403 * src/jpeg/libijg8/jconfig.* : JPR bug fix : now compile on both
1405 * src/gdcmJpeg.cxx : JPR bug fix : erroneous include
1406 * src/win32/gdcmdll.dsp : JPR fix for windows compilation
1408 2003-07-02 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1409 * setup.py is again effective on un*x (takes into account the
1410 addon of the jpeg library)
1411 * Doc/DoxyDevelInstal.txt added (developper's raw documentation)
1412 * Doc/Doxy* updated (includes above enhancements)
1413 * INSTALL now points to web documentation
1415 2003-07-01 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1416 * src/gdcmHeader.h doesn't make unnecessary reference to
1418 * gdcmPython/Makefile.am now avoids calling the wrappers for the
1420 * src/gdcm*.[cxx|h] :
1421 - to allow compilation with gcc 3.x
1422 -- clean up of STL usage (added explicit usage of std::)
1423 -- small fixes on exceptions.
1424 Note: linking not tested !
1425 - clean of doxygen comments to avoid warnings at documentation
1427 * vtk/vtkGdcmReader.cxx: g++ warning message clean up (platform
1428 dependent convertion).
1430 2003-06-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1431 * Clean up of previous JPR garbage commit (not even commented in the
1433 - Test/Makefile.am removed the reference to unexisting testTS.cxx
1434 - moved all jpeg related files from src to src/jpeg/libijg8, with
1435 addition/modification of Makefile.am and configure.in.
1436 - the testSuite is still brain damage (not guilty).
1438 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1439 * WrapVTK.py : modifications to get correctly vtk source files to
1441 * vtk/vtkGdcmReader.cxx : modification for an already existing name
1442 (FileName -> Filename)
1444 2003-06-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1445 * vtk/vtkGdcmReader.[cxx/h]:
1446 - UpdateProgress method should now be effective
1447 - removed the limitation on having only images loaded (as opposed
1449 - when building a stack of images/volume, a lesser number of
1450 gdcmHeader and gdcmFile instances should be used (hopefully
1451 accelerating things).
1452 - when building a stack of images/volumes, files which are not
1453 loadable (wrong path-filename, wrong permissions on existing file,
1454 or file not parsable by gdcm) are replaced with a black image
1455 in the stack (for the caller to notice the problem).
1457 2003-06-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1458 * vtk/vtkGdcmReader.cxx: hopefully corrected Z extent.
1460 2003-06-02 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1461 * vtk/vtkGdcmReader[cxx|h] : makes correct code to remove conflicts
1462 between standard library (std) and vtk library (problems are found
1463 under Windows... thanks Windows !)
1465 2003-05-30 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1466 * vtk/vtkGdcmReader[cxx|h] should now be volume aware (read ready for
1468 * gdcmPython/demo/vtkGdcmReader.py: commented lines for volume test
1470 2003-05-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1471 * vtk/vtkGdcmReader[cxx|h] preparation addons for loading volumes.
1473 2003-05-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1474 * When compiling with distutils (see setup.py) the C++ compiler is
1475 called with different flags than the default ones (with automake).
1476 In order to fix all those warning, I compiled gdcm with the command
1477 make 'CXXFLAGS=-Wall -Wstrict-prototypes -D__STDC_LIMIT_MACROS'
1478 and went for warning fixes:
1479 - src/gdcmHeader.cxx, Test/dcm2acr.cxx, pourFindTaggs.cxx cleaned
1480 up from unused variables.
1481 - vtk/vtkGdcmReader.cxx: potential bug fix.
1482 * src/gdcmHeader.h: Doxygen warning cleanup
1484 2003-05-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1485 * gdcmPython/gdcm.i:
1486 - typemaps correction to take into account the systematic replacement
1487 of "using namespace std" with std:: prefix e.g. std::list,
1488 std::string... (cf changes of 2003-05-21).
1489 - gdcmGlob global variable of type gdcmGlobal (defined in
1490 src/gdcmUtil.cxx and declared in gdcmPython/gdcm.i) is now
1491 exported to Python a as cvar.
1492 * gdcmPython/__init__.py now defines two functions GetPubDictTagNames()
1493 and GetPubDictTagNamesByCategory() as a replacement for deprecated
1494 gdcmDictSet.GetPubDictTagNames() and
1495 gdcmDictSet.GetPubDictTagNamesByCategory() class functions (i.e.
1496 C++ static methods).
1497 * gdcmPython/demo/printGroupedPublicDict.py is operational again,
1498 with the above changes.
1500 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1501 * setup.py, manifest.in : bug fix under linux
1503 2003-05-22 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1504 * Modification of setup.py to compile vtk part too. Then, we have 2
1505 wrappers which must work with same distutils. For that, we have a
1506 generic distutils in distusiltsWrapping.py ; with :
1507 - build_extWrap class to wrap generically all extensions,
1508 - ExtensionWrap base class for all wrapping extension that contains
1510 - Wrapper interface which wrap sources
1511 + In WrapSwig.py we have extension and wrapper for Swig
1512 + In WrapVTK.py we have extension and wrapper for VTK
1513 * MANIFEST.in : modifications to consider vtk directory and new python
1514 files for compilation
1516 2003-05-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with Benoit Regrain
1517 * Added python wrappers of vtkGdcmReader vtk class (see the
1518 source in vtk/vtkGdcmReader.cxx) :
1519 - vtk/Makefile.am now builds a library
1520 - gdcmPython/Makefile.am now builds vtkgdcmPython a second import
1521 python library (as opposed to _gdcm.so wich are the python
1522 wrappers of gdcm). vtkgdcmPython.so uses the vtk python wrappers
1523 (vtkWrapPython and vtkWrapPythonInit utility) to build vtkgdcmPython
1525 - configure.in has an additional flag --enable-vtk that needs
1526 to be set to enable compilation of vtk related code, that is:
1527 + vtk/vtkGdcmReader.so and
1528 + vtk/testvtkGdcmReader C++ demo of vtk wrappers of gdcm)
1529 + gdcmPython/vtkgdcmPython.so (see above)
1530 - gdcmPython/demo/vtkGdcmDemo.py corrected (some images cannot
1531 be read when compressed or when HighBit + 1 != BitsStored),
1532 - gdcmPython/demo/vtkGdcmReader.py added. This demo illustrates
1533 the usage of the python wrapper of vtkGdcmReader vtk class.
1534 * vtk/vtkGdcmReader.cxx: bug fixed (thanks to Benoit Regrain).
1535 * src/*.[h] all occurences of stl classes are now prefixed with
1536 std::, and all occurences of "using namespace std;" where removed.
1537 This is to avoid pollution of global namespace in included files.
1538 Apparently vtk does not avoid this pitfall: when using both
1539 gdcm and vtk (as in vtk/vtkGdcmReader.cxx) this ended up in a
1540 collision of various stl members (principally cout...).
1541 * gdcmPython/testSuite.py now cleanly removes temprory generated
1543 * gdcmPython/gdcm.i now declares a typemap for std::string (to
1544 comply with above changes)
1546 2003-05-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1547 * src/gdcmHeader>[h/cxx] added gdcmHeader::GetPixelSize()
1548 * vtk/vtkGdcmReader.cxx now properly inports the image in the
1549 vtk data structure (an image Flip was required).
1550 * vtk/testvtkGdcmReader.cxx refers to gdcmData subdir instead of Data.
1551 * cosmetic changes in documentation.
1553 2003-05-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1554 * src/gdcmHeader.cxx: the constructor no longer exits when an
1555 unexisting file is given as argument.
1556 * The subdirectory Data (containing all the images used for the
1557 test suite) is not part of this repository anymore. A new module
1558 containing those images is now available at
1559 :pserver:xxx@cvs.creatis.insa-lyon.fr:2402/cvs/public
1560 with the name gdcmData.
1561 All the python scripts (including the package initialisation file
1562 gdcmPython/__init__.py) were adapated to take this change into
1563 account (basically GDCM_DATA_PATH is now GDCM_TEST_DATA_PATH).
1565 2003-05-5 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1566 * vtk subdir added. Contains vtkGdcmReader.[cxx|h] a vtk class
1567 inherinting from vtkImageReader and testvtkGdcmReader.cxx a small
1568 demo of the usage of this class.
1569 Compilation of this vtk part is only done when using the --enable-vtk
1570 at configure (or autogen.sh) stage.
1572 2003-04-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1573 * More memory link related corrections and documentation fixes.
1575 - maximum info is obtained with a command of the form:
1576 valgrind --leak-check=yes --leak-resolution=high --num-callers=40
1577 --show-reachable=yes PrintHeader
1578 - the remaining reachable blocks seem to come from the STL
1579 allocation scheme through the usage of map and list. It looks
1580 like this memory cannot be freed but it is not a memory leak
1581 (in fact further invocation to the STL would recollect the
1582 unused memory allthough it cannot explicitely be freed).
1583 * gdcmPython/demo/vtkGdcmDemo.py added: this is a small demo
1584 of displaying an image parsed with gdcm and displayed with VTK.
1585 Note: some images don't seem to work e.g.
1586 python vtkGdcmDemo.py ../../Data/US-RGB-8-esopecho.dcm
1587 * src/gdcmHeader.x: dicom_vr and Dicts are not class members anymore.
1588 Allthough this weakens the semantics, it is a ditch attempt to
1589 make gdcm more thread friendly.
1591 2003-04-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1592 * Memory link hunt (by using valgrind through the command
1593 valgrind --show-reachable=yes --leak-check=yes PrintHeader).
1594 - added src/gdcmVR.cxx gdcmVR.h that objectify the previous
1595 gdcmHeader::_dicom_vr.
1596 - gdcmHeader::InitVRDict transfered as gdcmVR::gdcmVR().
1597 - gdcmHeader::dicom_vr is now of type gdcmVR* as opposed to
1599 - gdcmGlobal global object contained class added (see src/gdcmUtil.x)
1601 2003-04-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1602 * src/Makefile.am now exports all the necessary include files at
1606 * UpdateGroupLength replaced by new one
1609 * UpdateGroupLength re-written using H-Table
1610 (named UpdateGroupLengthNew untill checks are over)
1612 2003-04-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr> with JPR
1613 * Data/im_00001 renamed to gdcm-MR-PHILIPS-16-Multi-Seq.dcm
1614 * gdcmPython/testSuite.py now include a test of gdcmFile::Write.
1616 - gdcmHeader::GetPubElValSet removed.
1617 - gdcmElValSet::WriteDcm, WriteAcr, WriteExplVR, revamped to
1618 UpdateGroupLength, WriteElements, Write.
1619 - gdcmHeader::FileType moved to gdcmCommon.h. The enum FileType
1620 doesn't contain TrueDicom anymore since ExplicitVR and ImplicitVR
1621 carried the same semantics.
1622 - src/gdcmHeaderIdo.cxx changed accordingly.
1623 - gdcmFile::WriteBase now regroups all the codes from previous
1624 versions of WriteDcm, WriteDcmImplVR, and WriteACR.
1625 - enum FileType moved to gdcmCommon.h
1626 * src/gdcmHeader.cxx AddDefault trashed
1627 * gdcmGetXSize added
1628 * getimageDataSize now calls gdcmGetXSize
1629 * Test/*.cxx changed to agree with above changes
1631 2003-03-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1632 * src/gdcmHeader.h: LoadElements() is not a public method anymore
1633 (to avoid double call by end user).
1634 * Test/*.cxx LoadElements() doesn't need to be called explicitely
1635 by end user, since gdcmHeader::gdcmHeader now handles it.
1637 2003-03-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1638 * gdcm/Doc many doxygen changes:
1639 - Doxyfile now has two different versions, DoxyfileUsers that generates
1640 the html.users end users oriented documentation and
1641 DoxyfileDeveloppers that generates the html.developper developper
1642 oriented documentation.
1643 - README changed accordingly
1644 - requirement.txt removed (old design info moved to TODO).
1645 - Additional files DoxyInstallation.txt, DoxyIntroduction.txt,
1646 DoxyMainPage.txt, DoxyPython.txt provide more information.
1647 - Note: the website http://www.creatis.insa-lyon.fr/Public/Gdcm/ can now
1648 be updated by simply regenerating the docs with doxygen and copying
1649 html.developper and html.users to tux:/home/httpd/html/Public/Gdcm
1650 * src/gdcmElValSet.cxx: stl <map>.count() can only return 0 or 1. Hence
1651 all the tests in the form "if (<map>.count() >1)" were removed.
1652 * src/gdcmFile.cxx: cosmetic changes to avoid messages of doxygen about
1653 ill-formed documentation sections.
1654 * src/gdcmHeader.cxx: ditto
1656 2003-03-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1657 * setup.py fixed for un*x (needed macro for stdint.h)
1658 * Test/test.cxx renamed to PrintHeader.cxx to avoid collision on
1659 un*ces with sh-utils test utility.
1660 * gdcmPython/demo/test.py renamed to PrintHeader.py
1661 * gdcmPython/demo/ReorganiseFiles.py new demo script added.
1662 * gdcmPython/win32/gdcmpycomplet.dsp renamed to gdcmpyembedded.dsp.
1663 * gdcmPython/win32/gdcmpy.dsp trashed away (brain damaged).
1664 * src/gdcm*.cxx JPR's bad inclusion fixed.
1666 2003-03-26 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1667 * src/gdcmHeader[h, cxx] gdcmHeader now has an IsReadable predicate.
1668 * gdcmPython/demo/test.py changed accordingly.
1670 2003-03-25 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1671 * gdcmPython/Makefile.am fixed linking against libstdc++
1672 * gdcmPython/_gdcm.so symbolic link to gdcmPython/.libs/pygdcm.so added.
1673 * Swig subdir (historical tests of swig version 1.3.17++) removed
1674 * Test/testChangeEntete.cxx some lines commented out in order to make
1676 * src/gdcmHeader.cxx cleaned up wild JPR's dirty kludge.
1677 * src/gdcmElValSet.cxx cleaned up frog's forgotten debug message
1679 2003-03-24 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1680 * src/gdcmHeader.cxx gdcmHeader::gdcmHeader now calls LoadElements(),
1681 hence the user doesn't need this explicit call.
1682 - gdcmPython/testSuite.py, gdcmPython/demo/*.py changed accordingly
1683 i.e. LoadElements() call removed.
1684 * src/gdcmCommon.h now defines UINT32_MAX (see stdint.h).
1685 - src/Makefile.am declares the proper flag for g++.
1686 * src/gdcmElValSet.h added gdcmElValSet::GenerateFreeTagKeyInGroup
1687 for adding user defined new tags.
1688 - src/gdcmHeader.cxx gdcmHeader::NewManualElValToPubDict added.
1689 - src/gdcmHeader.cxx gdcmHeader::AddAndDefaultElements now
1690 cleanly adds some gdcm added tags (like gdcmXSize, gdcmYSize...)
1692 2003-03-17 Fabrice Bellet <Fabrice.Bellet@creatis.insa-lyon.fr>
1693 * Makefile.am, acinclude.m4, configure.in, python.m4, Dicts/Makefile.am,
1694 Doc/Makefile.am, Test/Makefile.am, gdcmPython/Makefile.am,
1695 src/Makefile.am : the project should properly compile and install
1696 with the autotools, included the python wrappers part.
1697 * gdcm.spec.in : added a spec file for RPM packaging.
1699 2003-03-14 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1700 * src/gdcmUtils.cxx : redifinition of defaults parameters in code
1702 2003-03-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1703 * gdcmPython/__init__.py fix of GDCM_DICT_PATH which was not
1704 to exported to the environement (see gdcmPython/testSuite.py
1706 * src/gdcmElValSet.[cxx/h], gdcmElValue.[cxx/h], gdcmFile.[cxx/h],
1707 gdcmHeader.[cxx/h]: ElValSet class renamed to gdcmElValSet, and
1708 ElValue class renamed to gdcmElValue for obvious consistency reasons.
1709 * src/gdcmElValSet.cxx, src/gdcmUtil.[cxx-h] Tokenize utility function
1710 moved away from gdcmElValSet.cxx to gdcmUtil.cxx.
1712 2003-03-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1713 * gdcmPython/__init__.py doesn't crash anymore when running in
1714 in InstallMode or PreInstallMode but with an environement given
1715 value of GDCM_DICT_PATH.
1716 * src/gdcmDictSet.[cxx/h] coding style.
1718 2003-03-06 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1719 * src/gdcmHeader.h and gdcmHeader.cxx Coding style + doxigenation.
1720 * src/gdcm.h general comments moved to TODO, and README
1721 * src/gdcm.h should now be seen as a user commodity (including it
1722 should suffice to fully use gdcm). It is nowhere including within
1723 any of the kernel files src/*.cxx and src/*.h.
1725 2003-03-05 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1726 * src/gdcm.h splitted in gdcmCommon.h, gdcmDict.h, gdcmDictEntry.h,
1727 gdcmDictSet.h, gdcmElValSet.h, gdcmElValue.h, gdcmFile.h,
1729 * src/gdcm*.cxx only include their corresponding include file
1730 (as opposed to gdcm.h)
1731 * gdcmPython/gdcm.i changed accordingly
1732 * Test/Makefile.am corrected and added NEWS, AUTHORS in order for
1733 the autogen.sh generated "make snapshot" command to work.
1734 * autogen.sh removed history related references to crea package.
1736 2003-03-04 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1737 * distutilsSwigCPlusPlus.py work around some swig portability
1740 2003-03-03 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1741 * Eventually, python/gdcmPython was renamed to gdcmPython. This
1742 was done in a last ditch attempt to get setup.py _really_
1743 operationnal. The python/gdcmPython layaout add the advantage
1744 of hidding away the python related distutils specific files
1745 (MANIFEST.in, setup.py, distutils*.py...) from the main directory.
1746 Alas, the src directory was out of scope (i.e. it's relative
1747 position to setup.py was ../src) which made things impossible to
1748 handle (see previous version of python/setup.py). Crossing fingers...
1750 2003-02-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1751 * python/setup.py now works on Un*x. (harder than I thougth)
1752 * python/distutilsSwigCPlusPlus.py can now have include files
1753 among the list of sources.
1755 2003-02-20 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1756 * src/gdcmHeader.cxx : bug fix - opening dicom file in binary !!!
1757 * modifications in MSVC projects
1759 2003-02-19 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1760 * As stated by the first lines of Test/ExceptionAndPython/README, it
1761 looks like we can move back to original usage of exception within
1762 src/gdcm* and hence remove the errno stuff that was introduced
1763 as a quick and dirty fixture of this problem (added to the TODO).
1764 * Doc/Doxyfile configuration file for Doxygen and corresponding
1765 README file for usage added.
1766 * Test/testWrite.cxx added. This new test comes from a split of
1767 test.cxx that is now reverted to its original purpous i.e.
1768 testing the proper parsing of a Dicom related file.
1769 testWrite.cxx concentrates on testing the IO part of gdcm.
1770 * Test/bug1.cxx (containing a bug on WIn32) added.
1771 * src/gdcm.h, gdcmHeader.cxx, gdcmDictSet.cxx:
1772 - gdcmHeader::GetPubTagNames and gdcmHeader::GetPubTagNamesByCategory
1773 whose purpose is to publish the content of the TagNames of the
1774 Dicom public dictionnary were not accessible without an
1775 instance of class gdcmHeader.
1776 - those methods are now static methods of gdcmDictSet and hence
1777 require no instances at all to be invocated.
1778 - within gdcmDictSet this change required to change some method
1779 to class methods (i.e. are now static) among which SetDictPath
1780 (renamed to BuildDictPath) and LoadDefaultPubDict.
1781 * python/gdcmPython/demo/printGroupedPublicDict.py changed to illustrate
1782 the above changes by calling the new method classes of gdcmDictSet.
1783 * python/gdcmPython/__init__.py now exposes gdcm.gdcmDictSet for
1784 the above to be effective.
1785 * python/gdcmPython: in order to wrap properly the above changes
1786 for Python, swig version now needs to be > 1.3.17.
1787 * python/gdcmPython/Makefile fixed to adapt itself to new
1788 configure/make shema introduced by Johan Montagnat (thanks for the
1789 contribution). Alas this Makefile cannot be turned into a proper
1790 Makefile.am without some heavy changes in the configure.in
1791 (for python dectection).
1792 * python/gdcmPython/gdcm.i: the out typemap map<string, list<string>>*
1793 now avoids publishing the empty entries.
1795 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1796 * python/setup.py : bug fix concerning install under windows
1797 ExtraPath reused :-P
1798 * gdcm.dsw : bug fix concerning path for libraries for python !!!
1800 2003-02-13 Benoit Regrain <Benoit.Regrain@creatis.insa-lyon.fr>
1801 * Dicts/dicomV3.dic : remove double spaces !!!
1802 * src/gdcmElValSet.cxx : bug fix concerning windows compiler
1803 * python/gdcmPython/win32/gdcmpycomplet.dsp : bug fix concerning paths
1806 2003-01-28 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1807 * src/gdcmHeader.cxx added a post header parsing AddAndDefaultElements
1808 method. Doxygenation.
1809 * src/gdcm.h clean up of JPR spurious comments.
1811 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1812 * python/distutilsSwigCPlusPlus.py now properly collects the
1813 shadow classes generated by "swig -c++" (gdcm.py in our case)
1814 when using "python setup.py install".
1815 * python/gdcmPython/__init__.py imports gdcm.py and only manually
1816 reexports the working classes.
1817 * src/gdcmHeader.cxx all the try/catch/throw calls were replaced
1818 by the classical C errno scheme. This is to prevent an obscure
1819 behavior of the python wrappers when importing wxPython.wx prior
1820 to gdcmPython (which ended up in an abort call). An illustration
1821 of this oddity can be found in the Test/ExceptionAndPython
1822 subdir (see the README file). This problem probably due to
1823 an combination of g++ and dynamic loading.
1824 * added Test/ExceptionAndPython (see above)
1826 2003-01-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1827 * Changed the layout of the python part to avoid bloating main
1828 directory with setup.py, distutilsSwigCPlusPlus.py, MANIFEST.in
1829 i.e. the distutils arsenal. All the python related stuff is
1830 again in a python subdir, but the package itself is now in
1832 * setup.py was cleaned up:
1833 - pythonIncludePath removed
1834 - python setup.py bdist target is now functional.
1835 * gdcmPython/__init__.py doesn't export FileName any more (to avoid
1836 collision with other packages). gdcmPython/demo/*.py changed
1839 2003-01-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1840 * python subdir moved to gdcmPython (preparation of distutils packaging).
1841 * gdcmPython/setup.py and distutilsSwigCPlusPlus.py added. The
1842 distutils installer is operational.
1843 * - gdcmPython/__init__.py now properly loads the swig generated
1844 shadow classes (from gdcm.py).
1845 - gdcmPython/demo/*.py changed to import the package gdcmPython
1846 instead of gdcmPython/demo/load.py.
1847 - gdcmPython/testSuite.py changed to import the package gdcmPython.
1849 2002-12-16 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1850 * src/gdcm.h, src/gdcmHeader.cxx: added GetPubTagNames() resp.
1851 GetPubTagNamesByCategory() to gdcmHeader that return a list of the
1852 entries within the associated public Dicom dictionary resp. the same
1853 information but sorted by the fourth field (PAT, IMG, DIR) of the
1855 - Dicts/dicomV3.dic Entries which had and unspecified fourth field
1856 are now in the "???" group.
1857 - python/gdcm.i changed accordingly,
1858 - python/demo/printGroupedPublicDict.py added, that gives an example
1859 of the above new functionalities in Python.
1861 2002-12-11 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1862 * src/gdcm.h, gdcmHeader.cxx:
1863 - historic references to glib's g_malloc and g_free (#defined)
1864 were definitively removed.
1865 - gdcm.h: cosmetic changes (part of comments moved to Doc/requirements)
1866 * src/gdcmElValSet.cxx:
1867 - GetElement(guint32, guint32) renamed to GetElementByNumber.
1868 - GetElValue(guint32, guint32) renamed to GetElValueByNumber.
1869 - GetElValue(string) renamed to GetElValueByName.
1870 - Added GetElementByName(string).
1871 * src/gdcmHeader.cxx: added
1872 - GetPubElValRepByNumber(guint16, guint16)
1873 - GetPubElValRepByName(string)
1874 - GetShaElValRepByNumber(guint16, guint16)
1875 - GetShaElValRepByName(string)
1876 - GetShaElValByNumber(guint16, guint16)
1877 - GetShaElValRepByName(string)
1878 - GetElValRepByNumber(guint16, guint16)
1879 - GetElValRepByName(string)
1880 - GetElValByNumber(guint16, guint16)
1881 - GetElValRepByName(string)
1882 * Doc/requirements.txt added.
1884 2002-12-9 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1885 * Test/Makefile building now depends on the one of libgdcm.so
1886 * src/gdcmHeader.cxx and gdcm.h are now OB (undefined length encoded
1887 pixel data) aware which enables finding the address (offset) of
1888 the pixel data of JPEG encoded DICOM files. This leaves only a single
1889 file in the testSuite whose pixel data address (offset) is unknown.
1890 * python/testSuite.py changed accordingly.
1892 2002-12-6 Christophe Odet + Hugues Benoit-Cattin + Eric.Boix
1893 * VC++ has some strong limitations when working with the STL, as stated
1894 in http://support.microsoft.com/support/kb/articles/Q168/9/58.ASP :
1895 "Also note that some STL containers (map, set, queue, list, deque)
1896 cannot be exported. [...]
1897 Some STL classes contain nested classes. These classes can not
1899 This is caused by a designed limitation that once a template
1900 class is instantiated, it can not be re-instantiated and
1902 Since our usage of map<> is ubiquitous in gdcm, this "designed
1903 limitation" of VC++ is a pitfall.
1904 Hence the Python wrappers of gdcm cannot be incrementally linked
1905 against the c++ dynamic library. The dirty but only workaround is
1906 to forget about incremental link of dynamic libraries and to generate
1907 the Python wrappers library with the inclusions of the underlying C++
1909 The following modifications concern this matter on Win32/VC++:
1910 - wrapping python correct with standalone wrapped dll (don't use separate
1911 dll under windows !!!!)
1912 - python21_d debug mode enabled (ask Frog how to use it :-)
1913 - NO problem with having an STL member of class for example string in C++
1914 WITH THE RESTRICTION OF FORGETING ABOUT INCREMENTAL LINK.
1915 - Python test of dcmlib in Python is ok under windows on a large set
1917 * removed glib references
1918 * typedef's inserted in gdcm.i for correct swig type management
1920 2002-11-27 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1921 * python/demo/*.py load.py extracted from test.py. Added explore.py
1922 that only displays required tags and testAll.py that parses all
1923 the files of the testsuite without using unittest.
1924 * python/testSuite.py other additional test on new files added.
1925 * Data/* new test files added accordingly to the testSuite.
1926 * src/gdcmHeader.cxx avoid overwriting of the dictionary when
1927 the vr in the file differs from the one of the dictionary.
1929 2002-11-20 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1930 * src/gdcm.h and gdcmHeader.cxx gdcm no longer loads all the elements
1931 values, but limits itself to values which are below a user specified
1932 size (by default 1024 bytes).
1933 * python/gdcm.i : elements not loaded (because their size is above the
1934 user specified treshold) are exported with their TagKey as key of the
1935 python dictionary. This enables the testsuite to make some checks
1936 on the unloaded elements (since we have their offset and size).
1937 * python/testSuite.py
1938 - now tests for the existence and proper value of the pixel data
1939 - two new examples added.
1940 * Data/gdcm-MR-SIEMENS-16.acr[12] added.
1942 2002-11-18 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1943 * src/gdcm.h and gdcmHeader.cxx are now "Big Endian transfer syntax"
1944 aware. See the strategy comments in gdcmHeader::FindeLength().
1945 * Test/test.cxx now accepts a filename as first argument.
1946 * Data/US-PAL-8-10x-echo.dcm and US-RGB-8-epicard.dcm added.
1947 * python/testSuite.py changed to integrate test on above files.
1949 2002-11-15 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1950 * Dicts/dicomV3.dic removed all the trailing (RET) when the
1951 the vr was also RET.
1952 * python/testSuite.py more tests added.
1954 2002-11-14 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1955 * python/testSuite.py unittest test suite added (uses Data)
1956 * Data/* dcm and acr files for the test suite.
1957 * glib dependance removed from un*x version. We now use ISO C99
1958 7.18 Integer types (see stdint.h)
1959 - python/Makefile, src/Makefile src/gdcm.h
1960 * src/ when an explicit vr (like dicom files) suddenly poped an
1961 implicit element we use to mark the underlying DictEntry of the
1962 concerned ElValue with "Implicit". This strategy was damageable
1963 too the public or provite dictionaries, since some of their vr
1964 would be changed. Since Header::FindLength heavily relies on the
1965 detection by Header::FindVR of falsely explicit elements, I
1966 added an extra ImplicitVr member to ElValue (boolean).
1967 The rest of the changes we the necessary adaptations.
1969 2002-11-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1970 * src/gdcmHeader::FindLength bug fix when trapping falsely explicit
1972 * src/gdcmHeader::FindVR: hard way fix of falsely explicit vr files.
1974 2002-11-8 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1975 * Adaptation for porting to VC++:
1977 o forced to use std namespace (for string to be known)
1978 o all class use __declspec export style on WIN32
1979 - src/gdcmUtil.cxx new Exit method that wraps the exit call
1980 (in stdlib.h on Win32 but in std:: for gcc)
1981 * src/gdcmDictSet::SetDictPath adds a trailing / to environement
1982 variable GDCM_DICT_PATH.
1983 * src/gdcmHeader.cxx verbose comments made discrete.
1985 2002-11-7 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1986 * python/gdcm.i: added a typemap that converts a C++ hashing table
1987 to native Python dictionary.
1988 * python/demo/test.py:
1989 - now uses the native dictionary for exploration of gdcmHeader.
1990 - takes an optional filename argument (the file to parse).
1991 * src/gdcm.h and gdcmHeader.cxx: gdcmHeader now has an accessor on
1992 PubElVals hashing table.
1993 * Dicts/dicomV3.dic removed error prone trailing spaces.
1995 2002-11-6 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
1996 * Python wrapping process moved away from src/Makefile to
1997 newly created python/Makefile (as well as gdcm.i)
1998 * python/demo/test.py (that mirrors Test/test.cxx) is effective.
1999 * src/gdcmHeader::FindLength only looks for current vr when necessary.
2000 * src/gdcmDictSet.cxx: the dictionnaries directory path is now imported
2001 from the environement variable GDCM_DICT_PATH (when existing).
2002 * src/gdcmDict::GetTag bug fix.
2004 2002-10-31 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2005 * Straightforward temporary fixes for swig to build the python wrappers.
2006 src/Makefile now has a python working entry [by working we mean
2007 that we can import de shadow classes without errors].
2009 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2010 * hashtest.cxx removed (since allready in Test)
2011 * src/gdcmlib.h renamed to src/gdcm.h
2012 * src/dcm.i renamed to src/gdcm.i
2013 * src/Makefile prepared for python wrapping
2015 2002-10-29 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2016 * src/gdcmHeader.cxx :
2017 - Parsing of header is now separated from loading of element values
2018 (see gdcmHeader::LoadElements).
2019 - general clean up of hopefully all file access (creation of
2020 ReadInt16 and ReadInt32)
2022 2002-10-22 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2023 * src/gdcmHeader.cxx :
2024 - RecupLgr renamed to FindLength and cut off with new IsAnInteger
2026 - SetLgrElem renamed to SetLength
2027 - GetLgrElem renamed to GetLength
2028 - ~gdcmHeader() made virtual to pesky warning messages at compile.
2029 * src/gdcmElValSet.cxx fixed both GetElValue methods
2030 * Dicts/dicomV3.dic falacious entry [7fe0 0010 OT PXL Pixel Data]
2031 due to IdoDude was cleaned out.
2033 2002-10-21 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2034 * src/gdcmHeader.cxx RecupLgr split in FindVR and RecupLgr. FindVR
2035 concentrates on finding the value representation (when it exists).
2036 RecupLgr now only finds the element value length, and it avoids
2037 returning the unecessary skL (skipped length).
2038 Also, offsetCourant was simply removed (with taille_fich) since
2039 it was redundant with the File position internals (by using
2040 ftell and fseek). This also made skL (see above in RecupLgr) usage
2042 * src/gdcmHeaderIdo.cxx src/gdcmIdo.h added. Those files concentrate
2043 on the libido specificities which are handled through class
2045 * Test/implicit_vr.dcm dicom v3 in implicit value representation
2048 2002-10-17 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2049 * Truckload of changes. Parsing of header is barely functional
2050 (see Test/test) with the standard dictionary (see Dicts/dicomV3.dic).
2052 2002-10-10 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2053 * src/gdcmHeader.cxx many addons of low level methods
2055 2002-10-07 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2056 * src/gdcmHeader now contains_IdDcmCheckSwap, _IdDcmRecupLgr,
2057 and _IdDcmSWAP_LONG.
2059 2002-09-12 Eric Boix <Eric.Boix@creatis.insa-lyon.fr>
2060 * This corresponds to all the changes decided at the meeting of
2061 May 23 2002. Needless to say we are running late...